Kimirock/django-helpdesk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1458 from DavidVadnais/fallback_for_respond_layout

Browse Source 
fallback to tabs if typo in ticket_respond_layout
This commit is contained in:
Christopher Broderick
2026-09-27 14:04:20 +01:00
committed by GitHub
parent 0e8d0f1189 e7f1ae6f8b
commit 68bbd57663
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/helpdesk/templates/helpdesk/ticket.html
View File

@@ -32,7 +32,7 @@
</div>
{% else %}
{% with respond_layout=request.user.usersettings_helpdesk.ticket_respond_layout|default:"tabs" %}
{% if respond_layout == "tabs" %}
{% if respond_layout != "top" and respond_layout != "bottom" %}
{# Nav Tabs #}
<div class="card">
<div class="card-header bg-body-tertiary pb-0 d-flex align-items-center">

7
tests/test_ticket_respond_layout.py
View File

@@ -75,6 +75,13 @@ class TicketRespondLayoutTests(TestCase):
page = self.get_page()
self.assertIn('id="respond-tab-pane"', page)
def test_unknown_layout_falls_back_to_tabs(self):
"""if a typo in setting ticket_respond_layout fallback to tabs"""
self.set_layout("TYPO")
page = self.get_page()
self.assertIn('id="respond-tab-pane"', page)
self.assertIn('id="followup-tab-pane"', page)
def test_user_settings_form_saves_layout(self):
settings = self.user.usersettings_helpdesk
form = UserSettingsForm(