Compare commits

...

448 Commits

Author SHA1 Message Date
Bryan Maass
6b8829bd58 Spike: sqlc -> Clojure query codegen with Malli schemas
Generate Clojure query fns with Malli result schemas from .sql files, using
sqlc for SQL parsing and type inference and sqlc-gen-json to expose its
analysis as JSON.

Verified end to end: migrations against Postgres 16 (1427 changesets, 190
tables), pg_dump fed to sqlc unmodified, real queries ported from the
glossary/sso HugSQL spike branches, and the generated file compiles with
schemas that accept valid rows and reject bad ones.

See dev/src/dev/sqlc/README.md for open issues (no H2 engine, weak param
type inference, no dynamic SQL).
2026-09-15 23:06:24 -06:00
Chris Vandoodewaard
14fe567687 only auto-patch current version (#82368)
only auto-patch latest
2026-09-11 14:56:29 -04:00
technomancy
daceb36e65 Snowflake schema specified in :additional-options should take precedence (#82364)
Fixes https://github.com/metabase/metabase/issues/65493

If you have a `details.schema` property set in your connection (this was
removed in v42 in favor of schema filters), you can't change it in the
UI in the current Metabase version.  If you wanted to specify a schema
through the "Additional JDBC connection string options", the old
buried schema property would take precedence anyway.

This makes it so the deprecated field is removed when the schema is
set in additional-options.

I've verified this using a real connection and querying `SELECT current_schema()`
as suggested in the bug report.
2026-09-11 11:20:31 -07:00
github-automation-metabase
1c561d056c Tighten ratchets (#82365)
Co-authored-by: github-actions <github-actions@github.com>
2026-09-11 17:42:07 +00:00
Chris Truter
dd9d8d0579 Ratchet module boundary escape hatches (#82300)
Protect against bad things happening because agents and reviewers aren't aware that they're bad.
2026-09-11 17:36:42 +00:00
metamben
d0cbe49c68 Prime app-db connection-pool before use (#81601)
* Prime app-db connection-pool before use

Closes QUE2-833
Closes #81440

* Fix linter warnings
2026-09-11 17:08:38 +00:00
Nick Fitzpatrick
3e83533d06 BE PDFs - target 300dpi for rendered visualizations (#81078) 2026-09-11 13:55:16 -03:00
Chris Truter
eff3209a34 Add hierarchy to the backend module system (#82301)
This will allow us to resolve a lot a cycles in the module graph, and increase encapsulation considerably.
2026-09-11 18:48:15 +02:00
Alex Yarosh
93aabef5d3 docs: expand data modeling overview (#82309)
* data modeling overview

* copy paste strikes again

* Apply suggestions from code review

Co-authored-by: Michael Eby <38187276+michaeleby1@users.noreply.github.com>

---------

Co-authored-by: Michael Eby <38187276+michaeleby1@users.noreply.github.com>
2026-09-11 16:37:49 +00:00
Anderson
1a8883d604 Revert "Apply responsive spacing and typography to dashboard chart cards" (#82346)
* Revert "Apply responsive spacing and typography to dashboard chart cards (#81…"

This reverts commit 13e00d55b9.

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-09-11 13:10:36 -03:00
Timofey Kachalov
0cf4be2fd2 Fixed MCP search response schema validation (#82205) 2026-09-11 20:02:54 +04:00
Eric Normand
615cfdb48b Fix race in detached-fetch!-sweeps-stalled-fetches-test (#82347)
The test read `:future-ref` straight off the registry entry as soon as the
fetch signalled it had started. But `detached-fetch!` registers the entry
before the fetch begins and only stores the future just after submitting it,
so the thunk can deliver `started` before the `reset!` lands. When it does,
`stalled-future` is nil and `future-cancelled?` throws an NPE.

Under 300 spinning threads a probe caught the window 1-4 times per 20000
fetches; inserting a 5ms sleep between the `future` and the `reset!` makes
the old test fail every run.

Poll for the future instead. Only the test is affected: the sweep acts on
entries older than *fetch-max-age-ms* (an hour), so it can never observe one
whose `:future-ref` is still unset.


Claude-Session: https://claude.ai/code/session_01J1yFPpYiWH2ik8LB9rs7BT

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-11 10:56:49 -05:00
Alex Yarosh
19989ab207 docs: cloud migration (#82305)
* Revise migration steps 

Updated migration guide to clarify steps and include images.

* Delete docs/cloud/images/migrate-button.png
2026-09-11 15:36:37 +00:00
Alex Yarosh
efb95e2e18 docs: add glossary article (#82308)
* add glossary article

* Optimized 2 images, saved 219.4 KB (42.5% smaller)

* link

* Update docs/data-modeling/semantic-layer/glossary.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-09-11 15:29:28 +00:00
Riley Thompson
3ad97e619d Use multiple jvms per runner for bigquery tests (#81204)
* multiple jvms per runner for bigquery

* trigger CI

* add failing test

* lower timeout

* remove debug stuff

* clean up comments

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-09-11 11:27:34 -04:00
Anna Tomka
5b7c89d8ee GDGT-2478 Translate PasswordInput toggle label at call time (#82338)
* GDGT-2478 Translate PasswordInput toggle label at call time

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-09-11 15:26:10 +00:00
Riley Thompson
05d2f186a0 Use calendar days for bigquery datetimeDiff (#82194)
* BigQuery: use calendar days for datetimeDiff day unit

Fixes #82193

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Avoid :raw for date part in BigQuery day diff

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* clean up

* add timezone to test

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-11 10:53:37 -04:00
Phoomparin Mano
c8f77a0925 Data Apps Permissions (#79822)
* add saved question extraction prototype

* fix additional failure cases

* refactor: reconciler

* revert me: manual skill file edit for source swapping

* set data permissions to view for databases referenced in the query

* rename data app collection and group

* prevent agents from removing savedQuestionSourceId

* docs: clarify data app query location

* chore: cleanup query-sync canonical module

* refactor: split query tests into different files

* Swap query source for data app query hooks and apply dynamic filters on top of it (#79584)

* code improvements and bug-fixes for data apps permissions

* Add data apps model imports

* address reviews on data apps permissions

* run sync queries before vite build

* Add data app resource link (#79878)

add button to view data app resources

* Show permission error when users cannot access a data app (#79874)

show permission error page when user do not have permission to view data apps

* Add data app group link in overflow menu (#79873)

Add data app group link

* Store and reconcile data app entity ids in data_app.yaml (#79833)

* Store data app resource entity IDs

* make entity ids in data_app.yaml authoritative

* add top-level value after path key

* simplify data_app.yaml manifest parser

* only allow changing data app collection if empty

* consolidate backend test helpers and remove redundant tests

* chore: restore README changes

* ci: fix failing tests

* Add support of actions to Data App reconciler (#79842)

Add support of actions to Data App reconciler

* Fix bugs/inconsistency and add more e2e for data apps reconciler/syncing (#80002)

* Update semantic schema skill about preventing segments and measures in dynamic parts of a query in Data Apps (#80288)

* Grant view data access on a table-by-table basis in data app groups (#80189)

* grant view data on table instead of database level

* refactor table scan in reconciler

* update e2e tests for permission grants

* Grant data app view permissions per table

* Skip unchanged data app permissions

* add e2e data app test for sandboxing

* reset host app sources after runs

* Preserve sandboxing for data app users (#80406)

* add e2e data app test for sandboxing

* improve e2e tests for data apps

* Remove sandbox E2E from table permissions change

* preserve existing sandboxing from sandboxed groups in data apps

* assert that we grant non-sandboxed tables

* Explain data app sandbox exclusion

* Add data app sandbox E2E coverage

* Exercise sandbox preservation in data app E2E

* Disable saved question sources in data apps (#80139)

* Disable saved question sources in data apps

* Preserve question-only schema scope

* Remove the saved question schema parameter

* Copy table-sourced metrics into data app collection and do not codegen card-sourced metrics (#80086)

* copy table-sourced metrics into the data app collections

* copy table-sourced metrics into the data app collections

* Address metric sync review feedback

* Accept keyword metric display in query response

* Fix data app metric reconciliation ordering

* Remove old lockfile format

* exclude card-sourced metrics from schema generator

* do not use card terms in metrics to avoid ambiguity with card-sourced metrics

* fix model imports

* Fix data app metric reconciliation

* refactor: cleanup reconciler unit tests

* Fix duplicated metric client helper

* add safe metrics path

* Handle unsupported metric dependencies

* Fix data app CI test regressions

* Fix "Re-adding removed query fails to adopt deleted card" (#80341)

* Clean-up data apps permissions endpoints (#80825)

* Remove entity ids from data_app.yaml (#81317)

Remove data app entity ids from data_app.yaml

* Adjust data apps permissions code (#81093)

* Remove the data app table permission grants (#81584)

* Add permissions_group.is_data_app_group and hide data app permission groups from UI (#81705)

* Add data app user management and access warnings (#81839)

* Address data app user access review feedback

* additional e2e test cases for bugs in manage users page

* fix failing frontend type check on unit test

* fix migration id collision for data apps

* combine migration changes into one file

* fix data app metric sync after trashing copied metrics

* fix cli runtime dependency packaging for embedding sdk

* avoid loading data app bundle during resource setup

* prevent redundant data app collection permission updates

* allow admins to remove data app members after token expires

* update docs and add e2e test for missing resource collection case

* isolate data app sync using transactions

* do not leave user on an empty page when removing the last member on the page

* reserve sandbox-host slug in data app config

* ignore generated data app action fixtures

* move queries into db.clj

* preserve legacy permissions when adding data app members

* regenerate the kondo modules config

The data-apps module reaches for :model/Permissions and :model/DataPermissions,
neither of which was recorded in :model-imports, so metabase.core.modules-test
fails on the current tree.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011nNKkhQjjiUSM7qwLReyfP

* reject data app queries whose metrics read another card

Sync copies a referenced metric but rewrites nothing inside the copy, and
copies nothing that copy in turn reads, so those references still point at
the originals. The app publishes successfully and then fails for every
viewer without access to the originals' collections.

Checking while resolving the query, rather than at codegen, also catches a
metric edited into that shape after its schema was generated.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011nNKkhQjjiUSM7qwLReyfP

* exclude metrics that read a saved card anywhere from generated schemas

source-card-id only reads stage 0, so a table-sourced metric that joins a
saved question passed the codegen filter. The CLI checks the whole query and
rejects such a metric, aborting sync-resources for any app that uses it.

Checking the whole query here keeps codegen consistent with what sync
supports, and removes the database round trip that asked which of the
referenced cards were metrics -- the step that let a saved-question join
through in the first place.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011nNKkhQjjiUSM7qwLReyfP

* resolve copied resources' table dependencies through the server

Numeric source-table entries miss implicit joins: a copied model querying
Orders and reading Products.Category through a foreign key names Products
nowhere, so it was left out of the app's permission warnings.

Run the same metadata-based lookup the query endpoint uses, through a new
endpoint the CLI calls for copied models, actions and metrics, and drop the
JSON walk it replaces.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011nNKkhQjjiUSM7qwLReyfP

* cover the create-queries grant the database defaults leave on app groups

An app group that predates the first non-audit database is given
create-queries :query-builder-and-native by set-new-database-permissions!,
alongside the :blocked view-data it special-cases for app groups. A user with
data access through another group would gain native query authoring just by
joining the app.

The reconciler already resets it, but nothing failed when :perms/create-queries
was dropped from its list. The pairing cannot be produced through
set-database-permission!, which cascades view-data to :unrestricted for any
create-queries value other than :no, so the test writes the row the way the
defaults insert it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011nNKkhQjjiUSM7qwLReyfP

* prevent models based on saved questions from being copied

* return to a valid member page after overlapping removals

* do not resolve query objects when either enabled flag is false

* prevent shorthand properties and spreads from overriding generated ids

* prevent adding duplicate members and retry only members that are failed to add

* define schema for data app query endpoint

* reconcile only the current data app group during resource setup

* expand the schema fingerprint

* add data app group field in permission group schemas

* prevent new databases from granting query creation to data app groups

* throw validation errors when invalid query spec fields are passed

* do not fail validation on columns metadata

* add enabled metadata to query definition schema

* accept more data app specific query metadata and binning options

---------

Co-authored-by: Timofey Kachalov <timofei@metabase.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-09-11 15:41:01 +01:00
Timofey Kachalov
1626b31be7 Fix flaky child-frame realm gate in the data-app sandbox (#82324) 2026-09-11 18:07:04 +04:00
metamben
2659b87941 Throw on uncoerceable user attributes (#82118)
Closes QUE2-842
Closes #81821
2026-09-11 14:05:29 +00:00
metamben
b2c923e496 Remove explicit :fields on the last stage of pivot queries (#82111)
Closes QUE2-825
Closes #81203
2026-09-11 17:03:42 +03:00
Chris Vandoodewaard
cc1fa36312 add workflow combining quick and simple PR checks (#82126)
* combine workflows into single pr.checks.yml

* fixes and better checkout

* ignore parallel lint failure

* add filter to checkout to avoid slow checkouts

* remove check
2026-09-11 13:59:23 +00:00
github-automation-metabase
498dfc7435 Tighten ratchets (#82331)
Co-authored-by: github-actions <github-actions@github.com>
2026-09-11 13:16:25 +00:00
Ben Grabow
6780dbbf52 Allow multiple intermediate ns segments (#82125)
* Allow multiple intermediate ns segments

* Detangle llm settings

# Conflicts:
#	src/metabase/llm/provider.clj

* Move settings.providers to providers.settings

* Move providers.settings to provider.settings

* Loosen filter to include all `metabase.llm.*` settings

* Merge from master

* Delete obsolete linter ignore

* Clarify linter message
2026-09-11 08:11:09 -05:00
Jeff Bruemmer
86f64c3d9f docs - update docs job (#82327)
update docs job
2026-09-11 08:57:59 -04:00
Anna Tomka
ca17b89463 GDGT-2478 PasswordInput (#82117)
* test(ui): add PasswordInput Storybook story

* test(ui): add PasswordInput to Loki as baseline for restyle

* feat(ui): restyle PasswordInput from Figma and add input-background token

* test: cover PasswordInput visibility toggle in unit and e2e tests

* fix(PasswordInput): use highlight border color in focused error mode by overriding Input styles

* Update Loki Snapshots

* test(ui): add Loki reference for PasswordInput Overview story

* fix(PasswordInput): address review feedback

- keep border width constant and use an inset ring for focus/error to avoid layout shift
- tie right padding to the toggle button size so text clears it in lg
- restrict size prop to sm | md | lg
- order color keys alphabetically
- explicit visibility assertion in the e2e spec

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-09-11 14:18:41 +02:00
Anna Tomka
38b7b8c0b7 GDGT-3212 add missing inner border in dark theme (#82203)
* fix(Pill): add missing inner border in dark theme

* fix(Pill): drop explanatory comment per review
2026-09-11 14:18:11 +02:00
Kevin Kelleher
94e58da90d Fix auto-wiring dashboard filters to dashcards with multiple series (#81913)
* handle auto-wiring dashboard filters to dashcards with multiple series

* review feedback
2026-09-11 07:24:06 -04:00
Oleh K
6a035e234c Use JetBrains Mono as the code font (#82278)
* Use JetBrains Mono as the code font

Ship JetBrains Mono (regular + bold) and point the monospace font family
at it, replacing the hardcoded Monaco/Menlo stacks scattered across the
codebase.

- Add the woff2 files, @font-face declarations, and the type, fallback
  map, docs and backend test entries that keep the admin font picker in
  sync with the fonts directory.
- Route every monospace call site through
  --mb-default-monospace-font-family, and define that variable in the
  embedding SDK's variable set, where it was previously missing. With
  the variable always defined, the per-call-site `, monospace` fallback
  is redundant and is dropped.
- Inline the variable at the CodeMirror theme, which was the only
  consumer of monospaceFontFamily, and delete typography.ts.
- Set the Code component to 13px/22px per the design spec.

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-09-11 12:12:15 +02:00
Andrei Simionescu
b75caae5f3 AI settings docs: a provider connection takes credentials, not just an API key (#82026)
Bedrock takes an AWS access key pair and Google Gemini Enterprise a service
account key file, so the AI settings page can't keep calling every provider
connection an API key.
2026-09-11 09:18:39 +01:00
Fraser
a5af036433 Rehome the analytics export machinery to EE audit_app (#79808) 2026-09-11 19:04:08 +12:00
Romeo Van Snick
1c5ba041d6 Stop the metabot viewing-context tests from depending on absent entity ids (#82248)
The tests pass ids like 789 for entities they do not create. format-entity looks the
id up, and the test asserts on the fallback rendering that a 404 produces. When a
parallel test happens to hold that id, read-check gives a 403 instead, which renders
nothing, and the test fails.

Use Integer/MAX_VALUE, which no fixture allocates.


Claude-Session: https://claude.ai/code/session_01GCoSa7L7KrXh42rDRYR3Nk

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-11 15:11:30 +10:00
Romeo Van Snick
86c23eaf5e Read a card's UI parameters off its question (#82238)
* Read a card's UI parameters off its question

* Drop a tombstone comment

* Pin the agreement between getCardUiParameters and Question.parameters

* Type the unsaved card in the agreement test

* Format the agreement test
2026-09-11 15:11:21 +10:00
Fraser
1447d9cf97 Move the application permissions selector slot into current-user (#81846)
* Move the application permissions selector slot into current-user

PLUGIN_APPLICATION_PERMISSIONS.selectors was only read by current-user, so the slot now lives there as PLUGIN_APPLICATION_PERMISSIONS_SELECTORS with its OSS defaults, and the EE application permissions plugin registers into it from metabase/current-user. getRoutes and tabs stay in metabase/plugins for the admin permissions editor.
2026-09-11 16:42:11 +12:00
Romeo Van Snick
90688e49a7 Translate at call time, not at import time (#82147)
* Translate viz nouns and formatting operators on demand

`noun` was the one field on a visualization definition still translated at
import. `get noun()` matches what ObjectDetail and TreemapChart already do,
and the registry stores a definition by reference, so the getter survives.

The table-formatting operator names were four module-level objects. They are
functions now. `ALL_OPERATOR_NAMES` becomes `getAllOperatorNames()`, which
its three readers call.

25 of the 124 sites that translate before a catalogue can be applied.

* Translate settings titles on demand

`title` in a settings definition follows the same rule as the rest of the
object. 152 settings already use `get title()`; these 23 were the laggards.

The group-managers confirmation held two frozen strings, so it becomes a
function rather than an object with getters.

49 of 124.

* Lift translated containers into functions

Where a whole array or object is translations, the function goes on the
container so consumers keep a plain array or object: PieChart's ring titles,
the whitelabel illustration options and descriptions, PivotTable's partitions
(which held JSX built at import), the model-caching options, the cloud
migration messages, and the geo filter placeholders.

Where only a field or two of a mixed config is translated, and call sites read
it by property, the getter goes on the field instead. That covers the
collection configs, the permission option records and the loading messages,
none of which are spread anywhere.

Four files carried a whole-file disable rather than one per site, hiding 20
sites behind 4 directives. The real total is 140, not 124.

118 of 140.

* Clear the last module-scope translations

Validation schemas become functions, matching getOidcFormSchema and the other
lazy schemas already here. Module-local error strings become functions called
at their use sites. Three exported constants follow: NULL_DISPLAY_VALUE,
BEFORE_UNLOAD_UNSAVED_MESSAGE and NO_X_AXIS_VALUES_ERROR_MESSAGE, across 37
files.

The two Mantine `aria-label` defaults get a getter. Mantine merges
`defaultProps` by spread on each render, so the getter is read every time.

`ttag/no-module-declaration` now passes across all five trees it covers with
no opt-outs left, and `--report-unused-disable-directives` confirms none were
stranded.

* Stop spreads from flattening lazy translations

A spread or a rest destructure reads every getter it copies. Where an object
holds `get title()` so the string translates when it is read, spreading that
object at module scope translates it at import instead, which is the bug the
getters were meant to avoid.

Adds `mergeLazily` / `omitLazily`, which copy property descriptors instead,
and uses them where the flattening happened at import:

- `viz-core/lib/settings/utils.ts` flattened twice, once in the rest
  destructure and once in `...def`, so every setting built through
  `fieldSetting` / `metricSetting` / `dimensionSetting` froze at import.
- `palette/shortcuts/index.ts` spread five shortcut maps into one.
- `PaletteShortcutsModal` spread each shortcut again while grouping, so that
  now happens per render.

Measured with a test that imports every source module with `ttag` mocked:
40 modules and 370 translation calls at import, down to 35 and 256.

* Build parameter, admin and graph settings when read

* Build option lists when they are rendered

* Guard import-time translation with a test

* Make the instance analytics message a function so the plugin registry can replace it

* Resolve admin path names when the navbar renders them

* Give the enterprise caching tabs a lazy name too

* Skip generated cli-snippets from the side-effect scan

* Key the null slice by its untranslated label

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NUuaopJ7ZtMVvdwwxF6qyx

* Fail the import-time guard on unlisted import errors

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NUuaopJ7ZtMVvdwwxF6qyx

* Read lazy translations once per render, not per lookup

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NUuaopJ7ZtMVvdwwxF6qyx

* Let jest transform the MCP ext-apps package

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NUuaopJ7ZtMVvdwwxF6qyx

* Skip the SDK cli scripts in the import-time guard

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NUuaopJ7ZtMVvdwwxF6qyx

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-11 14:16:04 +10:00
Romeo Van Snick
60f2668137 Build dashboard and query-runner questions from the store (#82241)
* Build dashboard and query-runner questions from the store

* Cover the pivot endpoint selection
2026-09-11 14:13:19 +10:00
Romeo Van Snick
503c3bf068 Build the card embed and SDK questions from the store (#82253)
* Build the card embed questions from the store

* Read the SDK parameter values off the question
2026-09-11 10:27:16 +10:00
Fraser
a6de42f467 Re-tier styled-components to U4 and enforce its shared tiers (#82256) 2026-09-11 12:22:50 +12:00
github-automation-metabase
c998859487 Auto-update documentation for master (#82298)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-09-10 23:37:23 +00:00
Alexander Polyankin
a491bd11be Namespace the table name BigQuery's compiled native form carries as :qp/table-name (#82275)
* Namespace the table name BigQuery's compiled native form carries as :qp/table-name

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Update the BigQuery compile tests for :qp/table-name

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Update the remaining BigQuery compile tests for :qp/table-name

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-10 19:23:06 -04:00
Anderson
0a30b63176 Trim redundant Data Studio TablePicker end-to-end tests (#81848)
Trim redundant Data Studio TablePicker E2Es
2026-09-10 19:18:50 -03:00
technomancy
f1ce332568 Refuse to create new tables in static datasets with Snowflake (#82222)
Refuse to create new tables in static datasets with Snowflake.

Table creation will always succeed on non-static datasets, but if it's
static then the table being created has to be a table that's in the
dataset definition.

Ensure all tests which alter the dataset by creating new tables
declare a non-static dataset. The transform-related tests switch over
to using transforms-dataset/transforms-test which most of them are
already using.

Upload tests have their dataset defined in a fixture so we can do it
all in one place instead of editing 60 different deftests.
2026-09-10 14:55:14 -07:00
Will Fry
1690028d0f GDGT-2653: uncomment E2E assertions (#82199) 2026-09-11 00:10:43 +03:00
Andrei Chernykh
0c76874681 Move SSO user provisioning a toggle card under server settings (#82232)
* Make SSO user provisioning a toggle card under server settings

* Debounce provisioning writes and drop the real timers from the spec
2026-09-10 13:52:45 -07:00
Chris Vandoodewaard
a6be073fb2 auto-merge e2e timing update prs (#82292)
* create PR using CLI, also auto-approve/merge

* cleanup string, check if things changed

* remove extra blank line

* namespace file
2026-09-10 15:05:29 -04:00
Ben Grabow
cb4541b965 Extract dispatch type hierarchy (#82226) 2026-09-10 13:37:56 -05:00
Ben Grabow
463fb9355b Extract entity types (#82265) 2026-09-10 13:23:50 -05:00
Andrei Chernykh
791b649cc0 bump qs to 6.16.0 (#82283) 2026-09-10 11:06:44 -07:00
Tyler Plude
085418edb8 [GIT-74095] Use git path separators in remote-sync export paths (#82284)
use git path separators in remote-sync export paths
2026-09-10 10:47:29 -07:00
Andrei Chernykh
1118c3e897 Bump js-yaml to 4.3.2 (#82282) 2026-09-10 10:36:08 -07:00
Alexander Polyankin
6e74e41eaf Strip undeclared keys from stored and legacy queries the way the request decoder does (#82273) 2026-09-10 13:32:50 -04:00
metabase-bot[bot]
38404fd9df [chore] Update E2E test timings with recent data (#81995)
Update E2E test timings with averaged data

Collected timing data from 7 days of test runs.
All specs with timing data were included (simple averages).

🤖 Generated automatically by update-e2e-timings workflow

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <actions@github.com>
2026-09-10 17:26:53 +00:00
Chris Vandoodewaard
8a7cd79f47 Bump backend deps to resolve security vulnerabilities (#82261)
* bump backend deps

* missed bump
2026-09-10 13:25:18 -04:00
Alex Yarosh
f3685652d3 docs: making semantic layer happen - org part (#82247)
* rename directories

* Revert "rename directories"

This reverts commit 13ebd4ae48.

* heard you like links

* what good is claude if it doesn't even find all the links

* Optimized 55 images, saved 698.8 KB (11.2% smaller)

* Fix docs links after merge

Co-authored-by: alexyarosh <16640109+alexyarosh@users.noreply.github.com>

* Fix merged docs regressions

Co-authored-by: alexyarosh <16640109+alexyarosh@users.noreply.github.com>

* Tighten merged docs links

Co-authored-by: alexyarosh <16640109+alexyarosh@users.noreply.github.com>

* Revert extra post-merge docs edits

Co-authored-by: alexyarosh <16640109+alexyarosh@users.noreply.github.com>

* link

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexyarosh <16640109+alexyarosh@users.noreply.github.com>
2026-09-10 12:49:43 -04:00
Andrei Simionescu
08497ded2f Bump csv-parse to 7.0.2 (#82266) 2026-09-10 15:48:24 +00:00
appleby
bfe0b19738 Update map tile server settings with suggested copy from DOC-301 (#81835)
* Update map tile server settings with suggested copy from DOC-301

And also include a link to the relevant page in the metabase docs.

* Add a note about not including private keys to the docstring for map-tile-server-url

so that the warning also shows up in the env var docs.
2026-09-10 08:44:01 -07:00
Riley Thompson
a155c1f4ee Document bigquery median behaviour (#82201)
* BigQuery: use PERCENTILE_CONT for median and percentile

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* update docs

* update doc

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-10 11:42:36 -04:00
Braden Shepherdson
9f48230b57 [PDFs] Respect the text wrapping settings on tables (#77090)
Fixes UXW-4714.

The static viz for tables uses a fixed width, but it was too big for the
PDFs, causing tables with long text in columns to lay out badly.

This PR disables the fixed width of `780px` on tables for PDFs, so that
the tables now lay out correctly.
2026-09-10 15:39:28 +00:00
Ben Grabow
503349c6ae Fix duplicates of the same namespace name (#81974)
* Fix collisions on metabase.notification.payload.core-test namespace name. Lint for future collisions.

* Include .clj-kondo/{src,test} in backend check triggers

* Expect the new project test namespace

* Symbolically reference project test suite namespaces

* Include resources, test_resources, test_config dirs in project checks

* Return [namespace relative-path] pairs.
Skip local/src

* Catch read-file errors and explain why some files may not have ns forms

* Sort paths that collide
2026-09-10 10:24:17 -05:00
Jeff Bruemmer
4d60c4bcf5 docs - nav link check (#82211) 2026-09-10 15:08:17 +00:00
Chris Truter
d9f905b7da Fix H2 migration failures after running transforms (#82135)
* Copy the transform tables in dump-to-h2 and load-from-h2

None of the nine transform_* models were in copy/entities, but metabase_table is,
and it carries a transform_id FK to transform. A table row reached the target
referencing a transform row that never arrived, and the deferred FK check
rejected it at commit.

transform_run_cancelation also goes in entities-without-autoinc-ids, since its
primary key is run_id rather than an autoincrement id.

Adds copied-tables-have-copied-fk-parents-test, which migrates a throwaway H2
database and fails if any copied table's FK parent is not copied.

* Simplify the copy foreign-key regression test

* Clarify the foreign-key coverage test names
2026-09-10 14:42:03 +00:00
Andrei Simionescu
36f273d523 BOT-1790: Redact Metabot chain-of-thought details in embedded sessions (#81872) 2026-09-10 14:01:55 +01:00
Alexander Polyankin
38cda45f69 Type every :any and [:map-of :keyword ...] property in the API (#82196)
* Make defendpoint reject request schemas that reach an open map, a keyword-keyed map-of or :any

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Close the MBQL 5 query and column schemas and declare the keys the query processor adds

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Type the shared schemas requests reach and drop ms/Map and ms/JSONString

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Close every map schema a request can reach

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Regenerate the modules config

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Keep action parameters string-keyed and type lens params and permission graph ids

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Declare the sandbox coercion keys a column's options can carry

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Declare the alias-info and Mongo keys a column can carry and strip internal keys from legacy column metadata

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Carry the Mongo column keys in the serialize test fixture

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Declare the keys the frontend and query processor put on columns, parameters and card embeds

- column metadata: :remapping, a typed :lib/options, the nest-breakouts option key
- query parameters accept the rest of a stored filter declaration
  (sectionId, isMultiSelect, values source config etc.)
- static-list values may be one-tuples; raw-value template tags may
  carry a nil widget-type
- card embed attrs declare chart_href, child_target_id and host_data;
  explore filter refs accept the legacy field_ref the chart column has
- notification card echoes a metric's query_description
- serialization deep-sort orders mixed keyword/string keys
- viz-settings column refs are normalized before matching; a Field
  hydrated with its table can be fingerprinted; broken segment
  definitions read back as nil
- test fixtures: real fingerprints, snippet tag type, http channel
  details, comment content, no min_duration_ms on duration strategies

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Wire the defendpoint check, keep every map single-keyed, and apply the review findings

- defendpoint now calls closed-schemas/check! on every request schema;
  the walker no longer lets :any leak through collections, treats
  map?/:some as :any, skips :=/:enum/:fn values and never skips the
  default entry
- no map mixes keyword and string keys: ms/string-keyed-object gives an
  opaque JSON object string-keyed declared entries; ProseMirror attrs
  (documents, comments, explorations embeds), CSV upload parts, search
  weights and testing query specs use it and their readers use string
  keys; the serdes deep-sort comparator is back to master
- the Metabot context is fully typed from the frontend types instead of
  an opaque default; a draft transform query without a database is
  accepted
- permission graphs, settings PUT and SCIM PATCH reject a body whose
  map-of entries the decoder dropped; ad-hoc query endpoints drop a
  client-sent cache strategy; action parameter values keep collections
  out without nil-ing them; SCIM meta.resourceType is optional; sandbox
  user attributes are LoginAttributes; a metric filter clause carries its
  offset options; explore filter refs are the legacy field_ref the
  chart column has; result_metadata written by older releases and
  hasVariableTemplateTagTarget on parameters are declared; a bare
  map-of on a request path is guarded against scalars

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Close the endpoints tests define and let a column's target and name field be an id reference

The check runs on every defendpoint, the ones test namespaces define included. A column's
:target and :name-field are hydrated Fields on the backend but id references in the
metadata the frontend hands over; the closed column schema nil'd the reference, which
lost the search field of a model's primary key.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Hand an action's query only the parameter values, and fix two fixtures the closed schemas caught

A query action's stored parameters carry the frontend's widget settings; the query gets
the value keys. The Metabot viewing-context tests use ids no card can have, and the
Mongo cache test spells the strategy key the schema does.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Declare the table name BigQuery's compiled native form carries on a native stage

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Keep a BigQuery RECORD's sub-field sync metadata off its result column, and fix a binning fixture

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-10 08:17:08 -04:00
Timofey Kachalov
fc18a66b6c Add remaining data apps sandboxing e2e (#82170) 2026-09-10 15:44:38 +04:00
Chris Vandoodewaard
433561ad5b Move Snyk scans into the Lint Security workflow (#82197)
* Move Snyk scans into the Lint Security workflow

Fold snyk.yml's three jobs into lint.security.yml as snyk-generate-poms,
snyk-frontend-projects, and snyk-maven-projects, and delete snyk.yml.

Snyk now runs on the existing daily 11:00 UTC cron instead of its own
05:00 cron and dependency-file push trigger. The notify job reports Snyk
failures to Slack alongside CodeQL and Trivy, and Snyk's upload-sarif is
bumped from v3 to v4 to match the rest of the workflow.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* add timeouts

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-09-10 07:16:23 -04:00
Will Fry
3c23f921e2 GDGT-3132 fix misaligned undo toast (#82045)
* GDGT-3132 fix misaligned undo toast

* migrate UndoListing to from styled components to CSS module

* absolute px -> rem, compact -> compact-md

* fix inconsistent toast height, use line-height instead of measuring the DOM to handle single vs multi line layouts

* strip comments
2026-09-10 11:06:19 +00:00
Oleh K
7f4883cc49 Fix inefficiencies in formatValue (#82103)
* GDGT-3195: Fix inefficiencies in formatValue

formatValue is fine per-cell but pathological in bulk; the "Copy results"
button made this visible, with a 100x2000 grid spending ~4.5s in this path.

- Drop a dead dayjs strict parse. The format literal 'T' is not valid dayjs
  escaping (dayjs wants [T]), so isValid() returned false for every value.
  It sat above the string/number/boolean branches, so every non-date cell
  paid for it.
- Only JSON.parse the value when a markdown_template will consume it,
  instead of on every call.
- Memoize the per-column type predicates (isURL/isEmail/isTime/isDate/
  isNumber/isCoordinate/isBoolean) in a WeakMap keyed on the column. Each
  fans out into recursive type-hierarchy lookups that cross into CLJS, and
  they only depend on the column. Entries snapshot the type fields they
  were computed from, since the custom-viz API hands third-party code
  mutable column objects.
- Skip new URL() construction for values with no ":" in getUrlProtocol.
- Cache Intl.NumberFormat by its constructor options, bounded at 100
  entries with oldest-first eviction.

Also make the value-formatting signatures honest: formatUrl, getLinkText,
getLinkUrl and getRemappedValue take unknown, which is what they actually
receive. getUrlProtocol keeps its string signature, with getLinkUrl
narrowing before the call. This removes both `value as string` casts.

Benchmarked with a synthetic 100x2000 copy path (medians of 5):
full table 4512ms -> 440ms, text 1231 -> 12, currency 637 -> 20,
integer 535 -> 15, boolean 343 -> 5, email 101 -> 4.

Claude-Session: https://claude.ai/code/session_01KUcocQj2bJPwVBi4dXKyEP

* Cleanup

* Revert the createPlainCellFormatter change

Hoisting the options spread out of the per-cell closure is not worth the
churn. Measured in isolation with a realistic 22-key columnSettings, the
spread costs 0.023us per cell against 0.002us to reuse a hoisted
reference, so it saves ~4ms per 200k cells — a rounding error next to the
dead dayjs parse at ~13.5us per cell, and nothing at all for columns with
click behaviour, where both shapes spread per cell anyway.

* Address review feedback

Guard the markdown_template JSON.parse with a typeof check instead of
carrying the placeholder cast comment.

Cover the two changes the review called out as untested:

- numberFormatterForOptions returns the same formatter for equivalent
  options, a separate one for different options, and evicts the oldest
  entry once the cache is full. The eviction test resets the module so
  the 100-entry boundary does not depend on what earlier tests cached.
- formatUrl passes strings and numbers through untouched and renders
  booleans and objects rather than returning them raw.

Both were checked by mutation: breaking the coercion and stubbing the
cache lookup to always miss fails exactly those assertions.
2026-09-10 12:49:27 +02:00
Fraser
667d038d46 Move the upload error modal slot into status (#82242) 2026-09-10 21:18:59 +12:00
Fraser
19df422bbd Move the storage setup provider slot beside its context (#82243) 2026-09-10 17:44:42 +12:00
Fraser
9fff12013e Move the DataReference library pane slot into querying (#81858)
* Move the DataReference library pane slot into querying

DataReference is the slot's only reader and querying owns its props type, so the slot lives next to it as PLUGIN_DATA_REFERENCE.LibraryPane.
The enterprise library plugin registers into it at boot, and plugins/oss/library.ts no longer imports querying's DataReference types.
2026-09-10 17:44:28 +12:00
Fraser
4bc6ccb00c Move the verified search filter slot into search (#81860)
* Move the verified search filter slot into search

SearchSidebar is the only reader of PLUGIN_CONTENT_VERIFICATION.VerifiedFilter, so the field becomes PLUGIN_SEARCH_FILTERS in metabase/search/plugin, next to the other search filter components. The EE content verification plugin registers the filter there from initializePlugin, and the rest of PLUGIN_CONTENT_VERIFICATION stays in plugins without the search import.

* Declare the search filters slot with definePluginSlot

* Import definePluginSlot from the plugins entry point

* Describe the verified filter default without naming its consumer

* Cover enterprise feature gates and plugin reset behaviour

* Remove redundant plugin registration tests
2026-09-10 17:44:12 +12:00
Fraser
81049d6069 Move the entity icon slot into hooks (#81857)
* Move the useGetIcon plugin slot into hooks/use-icon

The hook is the slot's only reader, so the slot and its OSS default live next to it as PLUGIN_ICON.
The enterprise collections plugin registers into it at boot, and plugins/oss/collections.ts no longer imports metabase/hooks/use-icon.

* Declare the entity icon slot with definePluginSlot

* Import definePluginSlot from the plugins entry point

* Cover enterprise feature gates and plugin reset behaviour

* Remove redundant plugin registration tests
2026-09-10 17:43:59 +12:00
Fraser
85ce065045 Remove the stale dashboard selectors side-effect entry (#82252) 2026-09-10 17:43:34 +12:00
Romeo Van Snick
dcb85ae924 Trigger the stats workflows from Run tests, gated on the uberjar artifact (#82244)
* Trigger the stats workflows from Run tests, gated on the uberjar artifact

Both workflows have recorded nothing since 2026-09-03. PR #81238 took the push
trigger off `uberjar.yml`, so master merges reach it only through
`workflow_call`. A reusable workflow reached that way raises no `workflow_run`
event, and both watchers went quiet. 143 master commits went unmeasured.

They now watch "Run tests", which is what builds the jar on a master merge.
Its conclusion is not a usable gate, because it is `failure` on master more
often than `success`, from jobs that have nothing to do with the jar. The
uberjar artifact is the right gate: a new job looks it up without downloading
it, and a docs-only merge that skipped the build finds nothing and stops.

Calling both from `run-tests.yml` would have been lower latency, but a stats
failure would then turn the master run red, and `rerun-workflows.yml` watches
that run and would re-run master CI over it. Keeping them in their own run
keeps a stats problem to itself.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01171Lkmug15JzrcN2aMBLMk

* Let a PR run the size benchmark against its own uberjar

A `workflow_run` workflow always runs the copy on the default branch, so a
change here cannot be tried out before it merges. This matches the trigger
Bundle Load Stats already carries. A called run measures and reports; the
upload step stays gated on the `workflow_run` path, so it writes no row.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01171Lkmug15JzrcN2aMBLMk

* Trim the trigger comments in the stats workflows

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-10 14:38:31 +10:00
Romeo Van Snick
3403f82c0a Build the dashcard question and metric series from the store (#82250) 2026-09-10 14:32:27 +10:00
Romeo Van Snick
95306c12fc Take metadata options at the store door (#82249)
* Take metadata options at the store door

* Build the conversation detail questions from the store

* Select the test fixtures through the store door
2026-09-10 14:32:17 +10:00
github-automation-metabase
5d1e1ad8f1 Auto-update documentation for master (#82227)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-09-10 00:06:10 -04:00
Romeo Van Snick
6465693b78 Take a metadata provider where the database is already known (#82160)
* Take a metadata provider where the database is already known

* Fold the source-code provider into a hook
2026-09-10 13:37:15 +10:00
Romeo Van Snick
4e4cbac853 Give the visualizations a question builder instead of the metadata object (#82158)
* Give the visualizations a question builder instead of the metadata object

* Let the visualizations read the question builder themselves

* Read the store when a chart brush builds its question

* Drop the single-use question helper

* Give the map and object-detail views the question builder too

* Drop the last v1 metadata reads from the visualization tree
2026-09-10 13:37:10 +10:00
Romeo Van Snick
9762d0e164 Keep the CSP nonce out of the DOM, and off script-src (#82161)
* Give a script-src nonce only to responses that opt in

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DEcoNcbcoVpvPsGsX3ceua

* Hand the CSP nonce to page JS via the script element, not a DOM-readable JSON block

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DEcoNcbcoVpvPsGsX3ceua

* Pass the new script-nonce? arg at the common-test CSP call site

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GCoSa7L7KrXh42rDRYR3Nk

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-10 13:01:23 +10:00
Anderson
13e00d55b9 Apply responsive spacing and typography to dashboard chart cards (#81906)
* Apply responsive spacing and typography to dashboard chart cards (UXW-5181)

* Update Loki Snapshots

* Fix preview height regression and update e2e tests for dashcard size tiers

* Fix card heading typography and non-cartesian chart bottom padding

* Update Loki Snapshots

* Apply new styles only on cartesian charts

* Move changed styled components to css modules

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-09-09 23:51:25 -03:00
Romeo Van Snick
ad2d269251 Send the Field columns a parameter widget reads, and stop re-resolving them (#81936)
* Send the Field columns a parameter widget reads in param_fields

* Stop re-resolving a parameter widget's fields through the store

* Keep the empty default a parameter widget's fields prop had

* Read the driver-dependent Field columns in param_fields expectations
2026-09-10 12:04:48 +10:00
Romeo Van Snick
a22958cee3 Track page load times on every master merge (#80978)
* Add a harness for measuring bundle load time

* Report the second load and make the benchmark safe to run in CI

* Run the load benchmark across network and CPU conditions

* Sign the load benchmark in to a real instance

* Track page load times on every master merge

* Backfill load times for recent master commits

* Rewrite the load-time backfill in TypeScript with a tested core

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Launch the benchmark jar the way we ship it, and lint the .ts scripts

* Measure the whole load, not just DOMContentLoaded

* Do not let the performance marks gate a reading

* Drop the backfill workflow

The goal is a global trend, which the per-merge job builds on its own after a
few days. Backfilling only bought a readable chart sooner, at the cost of a
second workflow and the largest script in the PR.

The commit date stamp goes with it. It existed so a backfilled row could claim
its commit's date rather than today's, and the per-merge job never set it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Let a PR run the load benchmark against its own uberjar

A `workflow_run` workflow always runs the copy on the default branch, so a
change here cannot be tried out before it merges. The `workflow_call` trigger
lets CI hand the workflow a commit and reuse the uberjar it already built. A
called run measures and reports; it does not write rows to Stats.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01171Lkmug15JzrcN2aMBLMk

* Report each state from one load, not a median per reading

Every reading was medianed on its own, so a row described a load that never
happened. It could also put the readings out of order and print a page-ready
that precedes the TTFB beside it.

`measure.js` now picks the run whose DOMContentLoaded is the median of its
series and reports that run whole. The second visit happens once per browser
profile, so it stays the run itself, and its page-ready now comes from that same
load rather than from a median that included the series' first, uncached run.

`Cold spread %` still comes from all the cold runs. A spread is a property of the
series rather than of one load.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01171Lkmug15JzrcN2aMBLMk

* Read the largest paint with an observer, and cut the timeout

The first CI run reported a zero largest paint in all four conditions, and would
have done so forever. These entries never reach the performance timeline, so
`getEntriesByType` cannot see them. Only a `PerformanceObserver` can, and it has
to exist before the paint. Paint entries are buffered, which is why
first-contentful-paint needed none of this.

The browser keeps revising the value until the user interacts, and the reading is
taken once the page reports ready. It is a lower bound rather than the final
figure, which is what makes it comparable between commits.

That same run took 4.4 minutes, of which the measurement was 164 seconds. The
timeout drops from 25 minutes to 10.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01171Lkmug15JzrcN2aMBLMk

* Move the bench to frontend/test and write it in TypeScript

---------

Co-authored-by: Fraser <frasermcintosh1@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-09-10 11:42:14 +10:00
Fraser
e92dfab50e Refine TypeScript authoring and review skills (#82141) 2026-09-10 13:39:46 +12:00
Romeo Van Snick
7c4159eedd Read the query builder's cards and tables without the metadata object (#82159)
* Read the query builder's cards and tables without the metadata object

* Build the query builder's question from the store's builder
2026-09-10 11:19:39 +10:00
Romeo Van Snick
6dc53c3773 Keep the generated CLI snippets out of the side-effect registry (#82172) 2026-09-10 11:18:18 +10:00
Romeo Van Snick
86d1bf3ec7 Read table foreign keys from the store, not the metadata wrapper (#82163) 2026-09-10 11:17:59 +10:00
Chris Vandoodewaard
fe4e2beffa only re-run the failed specs for SDK component tests (#82220)
* granular re-run for sdk component tests

* update e2e-test to avoid clobering artifacts on multiple attempts
2026-09-10 12:27:57 +12:00
Romeo Van Snick
e096a361d8 Take a metadata provider in the detail-view query helpers (#82151)
* Take a metadata provider in the detail-view query helpers

* Select the detail-view queries instead of building them

* Take the provider for the table's own database

* Guard the table query selector's memoisation

* Type the table query guard against the API table
2026-09-10 09:13:56 +10:00
Ben Grabow
8b58b48375 Test registration fixes (#82130)
* Add missing requires

* Add missing requires

* Apply batched suggestions from code review

Co-authored-by: Ben Grabow <ben.grabow@metabase.com>

* Sort nses

* */keep-me
2026-09-09 17:28:31 -05:00
Fraser
ecde907aff Add definePluginSlot and a reset registry to metabase/plugins (#81926) 2026-09-10 10:01:23 +12:00
Andrei Chernykh
d1934fb897 Fix the JWT settings spec import after the store mocks move (#82228) 2026-09-09 14:45:58 -07:00
Jeff Bruemmer
03a39f47c8 docs - CLI updates (#81978) 2026-09-09 20:54:06 +00:00
thackervishal
ad22a8730c white_label - do not use hardcoded metabase in filenames for nonOSS (#81979)
* for EE/white_label - do not use hardcoded metabase in filenames
* test coverage includes test for special characters in application-name
* also use gibberish names in tests
2026-09-09 16:00:18 -04:00
Andrei Chernykh
3d145ccb73 Redesign the JWT group mapping section (#81928)
* Redesign the JWT group mapping section

* Tidy the JWT group mapping tests

* Type the group mapping hooks explicitly and tidy comments
2026-09-09 12:27:15 -07:00
metamben
1b93876984 Prevent inactive fields from breaking chain filtering (#82041)
Closes QUE2-820
Closes #80557

There are two changes:
1. handle `nil` nodes gracefully during traversal, and
2. don't add `nil` nodes to the graph in the first place.

Both of these changes alone fix the reported issue, but both make sense on their own.
2026-09-09 18:39:26 +00:00
Anderson
283b194a38 Stabilize Data Studio bulk-table e2e via shared TablePicker expand helpers (#81623)
* Stabilize Data Studio bulk-table e2e via shared TablePicker expand helpers

* Match unnamed-schema tables fetch and trim expand wait timeout to 25s
2026-09-09 15:33:00 -03:00
Alexander Polyankin
28b2ad9eb6 Remove Honey SQL arguments from db.clj (#82175) 2026-09-09 13:34:39 -04:00
Andrei Chernykh
5b705231d7 Collection filters UX followup (#79863)
* Stabilize collection type-filter options via an items-metadata endpoint, default the type checkboxes to unchecked, and hide the filters for collections of 10 or fewer items

* Show every type in the filter popover, disabling the ones without matching items

* Use kebab-case params on the metadata endpoint and adapt toolbar tests to the visibility threshold

* Scope the items metadata to the models the list shows, name its count total_items, and align root permissions with the items list

* Assert the restricted root metadata count against the items list instead of a fixture-dependent number

* Code review improvements

* Cleaned up kebob usage

* Adapt the branch to master's show-exploration-documents param and re-record kondo budgets

* Cover the items-metadata endpoint's exploration-document scoping

---------

Co-authored-by: Nathan Voxland <nathan@metabase.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 10:20:19 -07:00
Alex Yarosh
10f53bdcec Fix documentation URL for collection permissions (#82136) 2026-09-09 11:45:02 -04:00
Paolo Rascunà
2e1a0c1a2c BOT-1895: Stream reasoning tokens for 7 more LLM providers (#81956)
Every provider behind Metabot now streams reasoning to the chain-of-thought UI,
with one predicate per adapter deciding the settings gate, the request directive,
stream forwarding and replay together.

* BOT-1895: Shared groundwork. Drop the pre-registry saved-model fallback from
  Azure and Google; make tool_calls outrank reasoning in delta classification,
  which previously lost a tool call's only id/name chunk; consolidate
  reasoning-part coalescing into one helper.

* BOT-2027: Bedrock. Request thinking per model via the shared builders. The
  openai-family gate answers false — probes across all four GPT models confirm
  Bedrock never emits reasoning summaries.

* BOT-2028: Azure. Gate derived from the admin-typed deployment name, matched
  case-insensitively, which also fixes a latent temperature 400 on cased Claude
  deployments. Negative paths verified live; the positive path rests on docs.

* BOT-2025: Z.AI. Forward reasoning_content and send the thinking directive
  explicitly — GLM was already thinking invisibly on every chat. Thinking-only
  models get reasoning_effort and a 2048 floor on forced tool calls, flagged on
  the supported-models row so the sets cannot diverge.

* BOT-2024: OpenRouter. Forward flat delta.reasoning and classify all 26 models
  by live probe; the gpt-5.5/5.6 family streams under the server default, where
  an explicit enable verifiably suppresses it. Forced tool calls floored on
  mandatory-reasoning models.

* BOT-2026: Google Gemini. One catalog drives context windows, directive and
  gate. Thought summaries on chat, thinkingLevel LOW on structured (no off
  switch), and a 2048 floor — probed, a real prompt at 512 spent the whole
  budget thinking and returned no tool call.

* BOT-2030: Mistral. Net-new cost: the default sends no thinking and only
  "high"/"none" are accepted. Flattens vector content chunks into the shared
  xf's events, and adds the opt-in reasoning replay hook Mistral's docs require.

* BOT-2046: Moonshot. kimi-k3 always thinks — explicit effort, mandatory in-turn
  replay, 2048 floor; kimi-k2.6 is optional and disabled under a forced tool
  choice, which it rejects while thinking.

Co-authored-by: Paolo Rascuna <1936871+prascuna@users.noreply.github.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 17:42:56 +02:00
Chris Vandoodewaard
e49b98186b remove quarantine-engine paramater from test-driver action (#82107)
* remove quarantine-engine param from test-driver action

* remove uses of quarantine-engine param

* add timeout
2026-09-09 11:13:42 -04:00
Nicolò Pretto
f74d32c39a make sdk analytics use specific client names for data app and mcp apps (#82110) 2026-09-09 17:06:12 +02:00
Anderson
6431bc412b Fix chart color settings not applying in the query builder sidebar (#82140) 2026-09-09 11:45:11 -03:00
Tyler Plude
40a15bc485 [GIT-81733] Handle jar native filesystem paths (#81927)
* return a native filesystem path from get-jar-path

* extract code-location->path and add jimfs-backed regression test
2026-09-09 15:39:32 +01:00
Ben Grabow
b0c8103cdb Make batch timing stubs more reliable (#82073) 2026-09-09 09:30:16 -05:00
metamben
4b88b2ae79 Make sure we provide an order by clause when paging with SQL Server (#82039)
Closes QUE2-841
Closes #81988
2026-09-09 16:49:24 +03:00
Nathan Voxland
d3c7576ccb Validate local infile (#81967) 2026-09-09 08:41:57 -05:00
github-automation-metabase
7dbf078a40 Auto-update documentation for master (#82133)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-09-09 09:32:21 -04:00
Jakub Chodorowicz
c0949b1d38 Gdgt 2465 popover (#81561) 2026-09-09 15:26:04 +02:00
Romeo Van Snick
ebdcd6c743 Take a metadata provider in the shared query helpers (#82150)
* Take a metadata provider in the shared query helpers

* Select the segment query instead of building it

* Take the provider for the segment definition's database

* Guard the segment query selector's memoisation

* Guard the segment query assertion against a vacuous pass
2026-09-09 22:05:52 +10:00
Andrei Simionescu
66038ba6d0 BOT-1427: link conversation user groups to filtered usage stats (#81869)
* BOT-1427: link conversation user groups to filtered usage stats

* Take the group id as an argument to the usage URL helper
2026-09-09 12:48:52 +01:00
Romeo Van Snick
97d871c78a Build the new metric page's queries from the store's builder (#82153)
* Build the new metric page's queries from the store's builder

* Select the new metric page's queries instead of building them
2026-09-09 20:57:50 +10:00
Romeo Van Snick
6bb98bce1d Build action-creator questions from the store's builders (#82154)
* Build action-creator questions from the store's builders

* Select the action-creator question instead of building it
2026-09-09 20:21:30 +10:00
Romeo Van Snick
c908146299 Build the browse-tables virtual question from the store's builder (#82155)
* Build the browse-tables virtual question from the store's builder

* Select the browse-tables url instead of building it
2026-09-09 20:20:56 +10:00
Romeo Van Snick
2d80c0e360 Build the model and source-card questions from the card the loader fetched (#82156) 2026-09-09 20:20:25 +10:00
Romeo Van Snick
7f589be657 Build draft questions from the store's builder (#82144)
* Build draft questions from the store's builder

* Read the store when normalizing a transform source
2026-09-09 20:18:36 +10:00
Kamil Mielnik
12e5f16918 GDGT-2796 Namespacing custom viz settings (#81181) 2026-09-09 16:38:51 +07:00
Egor Grushin
979b344073 Fix light theme border-highlight token (#82157)
Fix light theme border-highlight: brand[30] -> brand[60] (GDGT-2484)
2026-09-09 11:30:55 +02:00
Romeo Van Snick
4558ce654d Narrow the dashboard navigation cards, and build their questions from the store (#82148) 2026-09-09 19:11:28 +10:00
Romeo Van Snick
e584e95d48 Drop the question the click-behavior source filters never read (#82149) 2026-09-09 16:50:23 +10:00
Romeo Van Snick
6ed9837a03 Build parameter fields from param_fields, not the metadata store (#81935)
* Build parameter fields from param_fields, not the metadata store

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

* Answer a field's remapped value from the store, not a v1 method

The parameter pipeline now carries plain API fields, which have no
`hasRemappedValue` or `remappedValue`. Both callers read the store
through one selector instead.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

* Carry an FK's target in param_fields for anonymous requests

The usual :target hydration reads the target Field through permissions,
which a public or embedded request does not have, so a public parameter
widget could not label an FK's values.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

* Give the number filter story a field with no values to list

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 15:17:40 +10:00
Romeo Van Snick
e4cc4a61ff Reduce the frontend to one memoize helper, and stop top-level caches leaking (#81866)
* Add a jest project for heap retention specs

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Scope the parsed x value cache to one getXValues pass

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Assert heap retention on the settled pass, not the first touch

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Key the log timestamp cache on the log object

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Key the schema viewer flow graph on the response object

The memo key serialized every table and field of the schema, so each distinct
schema held a megabyte-scale string forever. RTK Query returns a stable
reference per cache entry, so a WeakMap keeps the identity that useGraphSync
depends on without retaining the schema.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Key pie.rows on the dataset instead of a JSON copy of it

The memo key serialized every row and column, so each dataset the user viewed
held roughly its own size in cache key for the life of the tab. A WeakMap on
the dataset with a short settings subkey keeps the same hit rate.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Ban new uses of underscore's memoize

The 17 remaining call sites are allowlisted. The list may only shrink.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Narrow the memoize rule to module scope

A cache built inside a function, a component render, a class field or a
constructor is released with whatever owns it. Only a module scope cache lives
for the life of the tab, so the rule now flags just those.

This drops the allowlist from 17 files to 5, and each remaining entry carries
the reason its set of keys stays small.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Remove the memoize allowlist

Three of the five module scope caches are gone:

- getScrollBarSize takes no arguments, so it is a lazy value, not a cache.
- getScheduleExplanation returns a string that no caller compares by identity.
- cronToBuilderValue moves to the one caller that needs a stable identity.
  Schedule takes its value as a useMemo dependency, so StrategyForm now holds
  that memo itself. A user can write any number of cron strings, so a module
  cache for them was unbounded.

The remaining two carry an eslint-disable with the reason their set of keys
stays small.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Follow renderer_utils into the viz-core module

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Cover metabase/utils/memoize in the module scope rule

That memoize roots its WeakMap on the function it wraps, so it only releases
once that function does. At module scope the function never does, and the
nested Maps hold every argument ever passed. No call site does this today, but
the rule could not have caught one.

The rule now covers both sources, so it drops "underscore" from its name.
memoizeClass stays allowed: it keys on the instance.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Drop re-reselect from the dashboard selectors

createCachedSelector keyed getQuestionByCard and
getDashcardParameterMappingOptions on the card id, a primitive, in a
FlatObjectCache. That cache is a plain object with no eviction, so a session
kept one Question per card id it ever saw, and each Question pins the whole
Metadata snapshot it was built with.

reselect v5 defaults to weakMapMemoize, which keys on the card and the metadata
objects themselves. Entries are released when their card leaves the store or
the metadata is replaced, and identity still holds for every card in the
working set, which is what connect and useSelector compare on.

Measured over 300 cards, with the states dropped: 6.2 MB retained before,
0.0 MB after. Per entry, 21462 B before and 51 B after.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Drop re-reselect from the lockfile

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Back metabase/utils/memoize with reselect's weakMapMemoize

The hand-rolled implementation had two problems. It allocated two arrays on
every call, including cache hits: 225 ms against 20 ms for weakMapMemoize over
two million hits. And its WeakMap was keyed on the wrapped function rather than
the wrapper, so a cache built around a module-level helper outlived the wrapper
that owned it. A plain Map would have been safer.

weakMapMemoize matches on the same terms, identity for objects and value for
primitives, so no call site changes. It also weak-keys object arguments, which
the old one held strongly.

definition-cache passed weakMapMemoize as the memoize and argsMemoize options.
reselect v5 already defaults to both, so those are dropped.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Route all memoization through metabase/utils/memoize

underscore's memoize is gone from the app. Its 16 call sites now use the house
helper, which is reselect's weakMapMemoize. Three of them were in metabase-lib,
which cannot import metabase/utils, and all three took no arguments, so they
became plain lazy fields instead.

Two rules keep it that way:

- no-direct-memoize-import bans memoize from underscore and weakMapMemoize or
  lruMemoize from reselect, in any scope. Only metabase/utils/memoize may reach
  for an implementation.
- no-module-level-memoize keeps its job, now that the house helper is the only
  one left to police.

measureTextWidthSafely took a style object that was rebuilt on every render, so
identity keying would never have hit. Its third argument is now the font family
string, which is the only field any caller ever set.

useMemoizedCallback returns the callable shape rather than casting to T, since
the memoized function also carries clearCache and resultsCount.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Build memoizeClass on the house memoize

It kept a module-level WeakMap and walked a nested Map trie keyed on the
instance, the method, the argument count and then each argument, assembling
that path into an array on every call.

Keying weakMapMemoize on the instance and then the arguments gives the same
per-instance caching. One cache per decorated method replaces the shared trie,
so the method no longer needs to be part of the key, and neither does the
argument count. The file is down to 61 lines from 128.

A leak spec covers the property this rests on: an instance's results are
released with the instance.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Measure memoizeClass retention under load

2,000 instances per pass, 20 calls each, across a method with no arguments and
one taking a primitive and an object. Nothing is retained once the instances
are dropped.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Delete memoizeClass

It decorated a prototype method by rewriting the property descriptor, and put
the memoization 600 lines away from the method it applied to. Its one consumer
memoized a method whose body uses no `this`, so the same caching comes from
assigning a memoized arrow to a class field. The field is created per instance,
so the cache is released with the instance, and the memoization is now visible
at the definition.

metabase/utils/memoize is 14 lines, from 128.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Run the heap specs from their own jest config

They were a project inside jest.config.js, and a bare `jest` runs every
project, which is what CI does. So the sharded unit run picked them up, without
--expose-gc, and they failed as designed.

They now live in jest.memory.conf.js, the way the timezone specs live in their
own config. The shared base moves to jest.base.conf.js so neither file has to
duplicate it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Reduce the heap specs to one collection assertion each

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

* Follow the store mocks into test support

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012b67ubbXJVMuQrpuEksbeh

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 15:02:13 +10:00
Alexander Polyankin
c1805286bb Convert db.clj public functions to mu/defn with schemas (#82139) 2026-09-09 04:47:13 +00:00
Chris Truter
22b2577799 Require credentials when changing LLM provider base URLs (#81450)
A settings manager could change a connection's base URL without entering its
masked secret again. The update merged the stored secret back in, and
credential verification sent it to the new host before anything was persisted.
A network policy cannot tell a legitimate provider from a public host the
caller controls.

Changing a connection's effective base URL now requires freshly submitted
credentials for every sensitive field that would otherwise carry a secret to
the new destination. Environment-owned credentials must be repointed through
deployment configuration. Trusted provisioning such as config.yml is
unchanged.

Generic writes to the llm-providers setting run the same field validators, so
PUT /api/setting cannot bypass the connection API's checks.
2026-09-09 06:33:41 +02:00
Romeo Van Snick
2a35f6390b Let the measure and segment query hooks reach the store themselves (#82152)
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 13:59:17 +10:00
Chris Truter
f508214657 Enforce a network policy on LLM provider base URLs (#81301)
* Enforce a network policy on LLM provider base URLs

A settings manager could point any provider's base URL at an internal
host; the model listing behind the admin Connect button then fetched
GET /v1/models from it with bare clj-http, and a 4xx body preview came
back in the error. Semi-blind SSRF.

New llm-allowed-networks setting, same shape as warehouse-allowed-networks:
external-only on Cloud, allow-all self-hosted (vLLM/Ollama on localhost
or a private network is the normal case there). Admin-only, so the
settings-manager class can't loosen it.

Every base-url registry field validates against it on write, so the
API rejects a forbidden URL before verify-credentials! makes the
request. core/request and llm.anthropic/chat-completion check again at
request time and resolve DNS through the policy resolver, which closes
the rebinding gap. The AI proxy URL is operator config and is exempt.

e2e pins MB_LLM_ALLOWED_NETWORKS=allow-all next to the warehouse pin,
since the mock LLM server is on localhost.

* Cover the embedding and Google token sinks too

Semantic search posts embeddings to llm-openai-api-base-url and to the
settings-manager-writable ee-embedding-service-base-url with bare
clj-http, so the same writer class reached the same kind of sink. Those
now run the llm-allowed-networks check and DNS resolver; the operator's
ai-service-base-url is exempt, and ee-embedding-service-base-url is
validated on write.

A Google service account key carries its own token_uri, and the
credential library posts to it to mint an access token before any
request we guard. Keys are now refused unless token_uri is one of
Google's OAuth hosts.

* Use var links in LLM policy docstrings

* Keep SSRF rejections out of the embedder breaker

* Normalize connection-time LLM policy errors

* Link LLM timeout settings in request docs

* Fix reflection warnings in LLM URL validation

* Use explicit policies for managed AI endpoints

* Address final Copilot review feedback

* Reject non-global special-purpose addresses

* Align network policy terminology

* Make external-only the LLM network policy everywhere

llm-allowed-networks is now environment-only (:internal, no setter)
and defaults to external-only on every instance. A settings manager is
who it defends against, and on Cloud a customer admin loosening it
would be reaching for our own infrastructure, so nobody sets it through
the API. Self-hosted operators with a vLLM server on a private network
opt in with MB_LLM_ALLOWED_NETWORKS; a value that is not one of the
three policies fails closed with one warning.

The rejection message says what to do: self-hosted, it names the
setting and which value fits; on Cloud, that private networks are out
of reach. The vLLM field's placeholder and help text no longer
advertise a private host as the default setup.

The managed endpoints' :allow-private is now a floor rather than a
replacement, so an explicit allow-all keeps an AI service on localhost
reachable. An embedding service URL supplied by the environment gets
the same floor, since the setter cannot vet it.

* Enforce the LLM network policy at connection time only

The request-time check resolved the host with a blocking lookup that
the connection's DNS resolver then repeated, and in the embedding path
it ran ahead of the breaker's fast-fail. Requests now run only the
I/O-free syntax check up front; the resolver decides on the addresses
the connection actually opens, and its refusal maps to the same 400
the set-time check gives. The set-time check still resolves, so a bad
URL is refused when it is entered.

One helper, llm-request-opts, replaces the three hand-copied
sequences; the refusal is thrown from one constructor. It carries
:status 400 beside :status-code because the semantic-search dead-letter
queue files errors by :status and was retrying a refused endpoint on
the fast schedule.

A base URL with a username or password is refused outright, and the
refusal names only the host, since the message reaches Metabot chat
users and the API's 400 body. A connection-time refusal is logged; it
is the only trace a host that rebinds leaves.

* Read llm-allowed-networks from the environment alone

get-value-of-type falls back to the application database, so a value
stored there before the setter went away kept working. The getter now
reads only the environment variable, and the setting carries a :doc
string so the generated environment-variable docs keep it now that it
has no setter. On Cloud the default applies; the operator's environment
is still honored, which the e2e runner's pin relies on.

* Disable redirects for LLM requests

* Normalize embedding service base URLs

* Normalize configured embedding URLs on read

* Clarify LLM network policy documentation

* Revert "Clarify LLM network policy documentation"

This reverts commit 8f2cff7c4963efba6756c117927ca56492cd49c5.

* Polish new LLM security comments

* Clarify embedding API key fallback

* Treat unallocated IPv6 space as non-global

* Grant private-network policy floors to environment-supplied URLs only

* Refuse IPv6 space IANA has not allocated

2000::/3 is the global-unicast space, but everything in it from 2d00:: up
is reserved: no ISP routes it, so a name resolving there is either a
mistake or an internal network squatting on it. `3000::1` passed as public
before.

* Pin Google's token endpoints by whole URI

The transport posts to whatever `token_uri` says, so checking only the
scheme and host let through another path, port, or query string on
accounts.google.com.

* Validate connections written as the llm-providers setting

The connection endpoints check a base URL against the network policy, but
the list they write is a setting in its own right: PUT /api/setting or a
config.yml entry saved a loopback URL straight past them. Run the field
validators in the setter too, on the connections a write changes.

* Hold the token-cache invalidation to the LLM network policy

/api/premium-features/token/refresh POSTs to ai-service-base-url with the
premium token in the URL path. That setting is admin-writable, so the
request needs the same syntax check, redirect ban and DNS policy as any
other LLM request; only an environment-supplied URL earns the private
floor.

* Check the target host when a JVM proxy is in the way

clj-http's route planner honours -Dhttps.proxyHost, so the connection is
opened to the proxy and the :dns-resolver is handed the proxy's hostname:
the target is resolved by the proxy, out of reach, and a private egress
proxy is itself refused under external-only. Treat an operator-configured
proxy as the trusted boundary it is and check the target host up front
instead.

* Judge a NAT64 address by the IPv4 it reaches

64:ff9b::/96 is globally reachable, but its low 32 bits are the IPv4 a
gateway translates to, so 64:ff9b::7f00:1 passed external-only and reached
127.0.0.1. RFC 6052 forbids the prefix carrying a non-global IPv4; nothing
on this side of the gateway enforces that.

* Validate only the connection fields a write changes

Comparing whole connections meant rotating an API key re-ran the base URL
check, so a private URL stored before the check existed made its own
connection unwritable.

* Name a network policy that would change the outcome

A refusal under a deployment endpoint's allow-private floor advised
setting MB_LLM_ALLOWED_NETWORKS=allow-private, which was already in force.
The resolver records the policy it refused under; use that for the message
and the log line.

* Refuse an unresolvable host behind a JVM proxy

Everywhere else a host that will not resolve is allowed, because the
connection then fails on its own. Behind a proxy there is no connection to
fail: the proxy resolves the target, so a split-horizon or cluster-internal
name went out with nothing checked at all.

* Keep proxy-only DNS working

* Document and test the LLM proxy enforcement boundary

* Match JVM proxy detection to Apache routing and fix tile fixture
2026-09-09 03:56:22 +00:00
Romeo Van Snick
a24ac528b3 Build reference questions from a provider and the field itself (#82142)
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 12:51:21 +10:00
Alexander Polyankin
e0c40554da Accept a plaintext numeric example-dashboard-id in BackfillExampleDashboardIdValueWithAad (#82143) 2026-09-08 22:03:55 -04:00
Romeo Van Snick
c9c2552964 Build SDK and document questions from the store's builder (#81867)
* Build query builder questions from the store's builder

* Build document questions from the store's builder

* Build SDK and document questions from the store's builder
2026-09-09 11:46:12 +10:00
Romeo Van Snick
b57475ab38 Build query builder questions from the store's builder (#81861)
* Build query builder questions from the store's builder

* Build document questions from the store's builder
2026-09-09 11:42:14 +10:00
Romeo Van Snick
758aade121 Take metadata from the store's own doors, not the raw Metadata object (#81847)
* Build queries from a provider, not the raw Metadata object

* Build questions from cards through the metadata store

* Type the dashcard menu against the question dashcards its callers pass

* Name the guard the callers actually use

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 10:10:30 +10:00
Romeo Van Snick
5db23f4182 Move the test-side store mocks into test support (#81499)
* Move the test-side store mocks into test support

* Drop the moved store mocks from the side-effect registry

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 09:06:24 +10:00
Andrei Simionescu
0efc4c2161 BOT-1575: Show the illustrations toggle whenever illustrations are off (#81871)
The illustrations switch only appeared next to a custom icon, so turning illustrations off
and then removing the icon left no way to switch them back on. It now appears whenever
illustrations are off as well.
2026-09-08 23:40:41 +01:00
Andrei Simionescu
f4b04b6966 BOT-1573: Slackbot posts specific copy for known error codes (#81200)
Clackbot answered every failure with "Something went wrong", so a user denied by AI
permissions or an admin with a misconfigured provider had nothing to act on. Both the
streamed error part and the thrown-exception path now look the failure up by error
code and reply with copy that names the problem, and usage-limit errors pass their
server-authored message through. Anything unrecognised keeps the generic line, so raw
provider errors stay out of shared Slack channels.
2026-09-08 22:14:02 +00:00
Romeo Van Snick
83ed9b6c3d Serve the metabase-lib provider from the metadata store (#81664)
* Serve the metabase-lib provider from the metadata store

* Serve metric metadata providers from the store too

* Serve providers for metrics and for per-item database lookups

* Take a provider lookup in the transforms query helpers

* Resolve SDK query sources from the RTK cache, not the mirror

* Delete the unused isSourceEmpty helper and the dead tableId prop chain

* Canonicalise getMetadata's options so both call shapes share one Metadata

* Build v1 Questions through the metadata store (#81666)
2026-09-09 08:01:09 +10:00
Andrei Chernykh
0cd9134160 Keep closed group mapping dropdowns unmounted (#82124) 2026-09-08 14:56:21 -07:00
Sloan Sparger
d273dc56b6 [Metabot] Context window improvements (#81133) 2026-09-08 21:49:40 +00:00
Sloan Sparger
2d6db97c9d [Metabot] Frontend convo message shape refactor (#80967) 2026-09-08 16:10:26 -05:00
Ben Grabow
3fb5cbcb74 Use explicit hierarchy for action keywords (#79464)
* Use explicit hierarchy for action keywords

The :table.row/* -> :table.row/common and :data-grid.row/* -> :data-grid.row/common
relationships lived in Clojure's global hierarchy, sharing one mutable namespace with model
keywords, hook traits and every other subsystem. Move them into metabase.actions.hierarchy,
mirroring metabase.events.hierarchy: a defonce var holding a hierarchy map, mutated through
derive!.

Four multimethods consume those parents -- action-arg-map-schema, normalize-action-arg-map,
validate-inputs! and default-mapping -- and now dispatch on the new hierarchy. Driver-level
action methods are untouched: they dispatch on [driver action] through the driver hierarchy
and only ever name leaf action keywords.

The enterprise action_v2 module derives through metabase.actions.core, which re-exports
derive!.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* State the real reason driver action dispatch is unaffected

The hierarchy docstring said driver-level action methods are safe because they only ever name leaf action
keywords. That describes an incidental convention -- `[:postgres :model.row/create]` happens to be the only
such method -- and implies a fragile dependency that does not exist.

`driver/hierarchy` is its own `(make-hierarchy)`, and `isa?` against an explicit hierarchy never consults the
global one for keyword parents, so the derives this namespace moves had no effect on `prepare-query*` before
the move either. Say that instead, and note it at `prepare-query*` too, where someone adding a driver method
will actually be reading.

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Chris Truter <chris@metabase.com>
2026-09-08 21:06:29 +00:00
Alex Yarosh
f52a94984a docs: typos (#82079)
* typos

* Update docs/developers-guide/api-changelog.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* fine

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-09-08 20:38:33 +00:00
Jeff Bruemmer
8170a2ecdd docs - nav updates (#82116)
nav updates
2026-09-08 20:23:55 +00:00
Ben Grabow
ca2c341522 Use explicit hierarchy for auth identity providers (#79463)
* Use explicit hierarchy for auth providers

Provider relationships (:provider/saml -> ::provider/provider, etc.) lived in Clojure's
global hierarchy, sharing one mutable namespace with model keywords, hook traits and every
other subsystem. Move them into metabase.auth-identity.hierarchy, mirroring
metabase.events.hierarchy: a defonce var holding a hierarchy map, mutated through derive!
and underive!, read through isa? and descendants.

The three provider multimethods (validate, authenticate, login!) now dispatch on that
hierarchy via methodical's :hierarchy option.

Callers outside the module go through metabase.auth-identity.core, which re-exports the four
operations; namespaces inside the module use metabase.auth-identity.hierarchy directly, since
core requires them.

derive! is whitelisted as :parallel/safe because each test registers its own distinct
:provider/test-* keyword, so the additions never overlap. The plain `derive` calls it replaces
were equally global but escaped the linter by not ending in `!`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Register test providers at namespace level, not inside parallel tests

Each of these eight ^:parallel tests registered its provider by calling derive! and
methodical/defmethod in the test body. Both mutate process-wide state, so the tests were never
actually parallel-safe -- only derive! was visible to the linter, because defmethod does not
end in `!`.

Hoist both registrations above their deftest, alongside the test providers already registered
at the top of the namespace. The deftests are now pure assertions over providers that exist by
the time the namespace has loaded, which is what ^:parallel claims. No linter exemption for
metabase.auth-identity.core/derive! is needed, so .clj-kondo/ratchets.edn is untouched.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Chris Truter <chris@metabase.com>
2026-09-08 22:04:07 +02:00
Ben Grabow
3390d69763 Use explicit hierarchy for domain entity types (#79459)
Domain entity types derived from :DomainEntity/* in Clojure's global hierarchy, sharing one
mutable namespace with model keywords, hook traits and every other subsystem. Specs are loaded
from YAML files, so adding a spec file was writing into that shared space.

Move them into metabase.xrays.domain-entities.hierarchy, mirroring metabase.events.hierarchy:
a defonce var holding a hierarchy map, mutated through derive!. A leaf namespace rather than
an in-file var because both specs (which registers types and validates them) and core (which
ranks candidate entities by ancestor count) read it.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-08 19:36:22 +00:00
Ben Grabow
adf3bd7254 Use explicit hierarchy for user-key-value namespaces (#79460)
Key-value namespaces registered by defnamespace derived from ::registered-namespace in
Clojure's global hierarchy, sharing one mutable namespace with model keywords, hook traits and
every other subsystem. Namespaces are loaded from EDN files on disk, so an operator adding a
file was writing into that shared space.

Move them into a hierarchy var private to this namespace, mutated through derive! -- the same
shape as metabase.events.hierarchy, kept in-file because defnamespace is the only writer and
known-namespaces the only reader.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-08 19:31:31 +00:00
Chris Vandoodewaard
2357c1b843 refactor pr env cleanup into single workflow (#81817)
* refactor pr env cleanup into single workflow

* add timeout

* rename to match naming scheme
2026-09-08 19:21:42 +00:00
Ben Grabow
e85fa9c446 Fix BigQuery tests (#82106)
* Avoid wildcard scan against all similar datasets on the warehouse

* Update bigquery page fetch tests to match new adaptive page sizing API
2026-09-08 14:08:28 -05:00
Nathan Voxland
250868257e Improve LLM token usage for add_reseach_group (#79556) 2026-09-08 14:08:26 -05:00
Jakub Chodorowicz
27752c76e0 Gdgt 3198 allow setting metabase instance url when starting embedding (#82063)
allow setting metabase instance url for embedding storybook
2026-09-08 20:38:18 +02:00
Alexander Polyankin
15106f17fd Add kondo rule keeping Toucan 2 query calls in module db namespaces (#82099) 2026-09-08 14:07:41 -04:00
Alexander Polyankin
4b2cfdc623 Add MB_DISABLE_LEGACY_STARTUP_ENCRYPTION to refuse startup instead of encrypting legacy plaintext (#82097) 2026-09-08 13:38:39 -04:00
Will Fry
3439faff23 GDGT-3094: remove attachment limit tooltip (#82055) 2026-09-08 17:49:35 +01:00
Chris Truter
18f216de52 Ensure mage -test runs every test namespace (#82051)
* Fail the mage suite when a test namespace is not required

`mage -test` runs `run-all-tests`, which only sees namespaces that are already
loaded, and loading happens solely through this namespace's `:require`. A test
file missing from it never runs, and nothing says so.

`mage.quick-test-runner-test` and `mage.start-db-test` were missing that way.
They are required by `mage/test/mage/runtests.clj`, but CI runs `mage -test`,
which does not read that file, so their four tests had not been running.

* Drop the dead mage test runner and a test that cannot fail

Nothing referenced mage/test/mage/runtests.clj. It required three namespaces
directly, which made mage.quick-test-runner-test and mage.start-db-test look
wired up while `mage -test` never loaded either.

mage.start-db-test asserted a string literal, so it passed unconditionally.
Wiring it in would have added a green test covering nothing. start-db still
deserves real tests; this makes their absence visible.
2026-09-08 18:37:44 +02:00
Anderson
e354134858 Show table publisher and publish date in the Library (#81076)
* Show table publishing info in Library

* address review comments

* Refine publishing info response

* Clarify publishing audit lookup

* Fix publishing info database queries
2026-09-08 12:56:46 -03:00
Ben Grabow
34da51c654 Fix OIDC test isolation (#81987)
Use the right localhost-site-url test helper, and make sure the web server is initialized
2026-09-08 10:47:40 -05:00
github-automation-metabase
55f3c0f268 Add docs/util/data/nav.yml for master (#82078)
Add docs/util/data/nav.yml (seeded from docs.metabase.github.io)

Co-authored-by: github-actions <github-actions@github.com>
2026-09-08 11:34:19 -04:00
Sébastien
4cb99413ed Deflake the standalone cardEmbed supporting text test (#81772) 2026-09-08 15:58:27 +02:00
Ben Grabow
beb22cd1b5 Add missing fixtures init (#82007) 2026-09-08 08:44:03 -05:00
Voytek Pituła
eb7bcaa06f Add krever to team.json and github-slack-map.json (#82058)
Adds @krever to the Metabot team in .github/team.json and maps the
GitHub username to Slack ID U0BUSKQRN80 in release/github-slack-map.json.
2026-09-08 15:34:58 +02:00
github-automation-metabase
7e11715582 Update translations 2026-09-08 (#82056)
* Update translation sources 2026-09-08

* Update translations

---------

Co-authored-by: github-actions <github-actions@github.com>
2026-09-08 13:20:14 +00:00
Stas Gavrylov
c7a5060ca8 GDGT-2462: Update Switch component (#81709)
* GDGT-2462: Update Switch component

* GDGT-2462: Add Switch Loki references

* Update Loki Snapshots

* Address PR findings

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-09-08 15:42:53 +03:00
Kevin Kelleher
b7500371ca Remove duplicate in Gauge color picker (#81920)
fix duplicate in gauge color picker
2026-09-08 12:41:00 +00:00
lbrdnk
bf0186730c Add goldens triggers (#81873)
* Enable golden scopes

* Add label triggers

* Temporarily remove label input

* drop the input completely

* Re-add label
2026-09-08 14:40:41 +02:00
Timofey Kachalov
6ca683c042 Re-enable Shoppy sample app e2e (#82061) 2026-09-08 16:27:53 +04:00
Sébastien
c16a8abfa6 Fix EditableDashboard collapsing when entering edit mode (#82019)
* Fix EditableDashboard collapsing when entering edit mode without a sized parent

* Also fix EditableDashboard collapsing while sharing

* Revert "Also fix EditableDashboard collapsing while sharing"

This reverts commit be2f86c738.
2026-09-08 11:28:56 +02:00
Oleksandr Yakushev
074e967be7 [liquibase] Remove obsolete proxy package hack (#81480) 2026-09-08 11:51:55 +03:00
Bartosz Rybacki
47bc44f775 GDGT-2028 Fix wrong column headers in alerts with a remapped foreign key (#81896)
GDGT-2028: Fix wrong column headers in alerts with a remapped foreign key

The header titles and the header row were built separately and zipped by
index. Only the header row dropped the remap target column, so every title
after it shifted by one. Both now derive from `visible-columns`.
2026-09-08 10:31:41 +02:00
Andrei Simionescu
06d46ec0c2 BOT-2113: Copy metabot_permissions on every edition
An H2 dump made by an OSS build kept the metabot_permissions rows that migration 061 seeds into the fresh target instead of copying the source's own rows, because the table only appears in cmd.copy/entities when the Enterprise backend is on the classpath. The seed references the four magic groups at ids 1 to 4, which on the source are often different groups or no groups at all, so restoring that dump into Cloud either failed on a foreign key or handed Metabot permissions to whoever happened to sit at ids 3 and 4.

The table is now copied on every edition. The load side also skips rows whose group is missing from the dump, so the dumps customers have already sent restore once Cloud picks this up, and magic groups left without rows get the 061 seed re-run by magic_group_type so a restored instance matches a fresh one. Grants that landed on a real custom group cannot be told apart from a deliberate grant and stay a data fix, tracked in CLO-5999.
2026-09-08 08:30:46 +00:00
Romeo Van Snick
28a72bb30c Answer field remapping from the field, not the metadata store (#81932)
* Answer field remapping from the field, not the metadata store

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

* Say what a remappable field has to carry, and simplify the format type

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNvsg9cPuNQ6BHiDwa1bif

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-08 16:19:53 +10:00
Chris Truter
b57dc3f98e Prevent mage commands hanging on orphaned output pipes (#81699)
* Start subprocesses with ProcessBuilder

Runtime.exec's three-arg form has been deprecated since JDK 18, and it forced the command and environment
through String arrays with array type hints to match. ProcessBuilder takes both as collections, so the
call site is one line and the array juggling is gone. `:env` still replaces the parent environment rather
than adding to it, which is what the docstring promises: that is `.clear` then `.putAll`, not a bare
`.putAll`. read-lines now hints the BufferedReader the namespace already imports.

* Spend one timeout budget across a command's three waits

sh* waited for the exit code, then stdout, then stderr, giving each a fresh timeout-ms. A command that
dribbled output could take three times its budget, and the exception still claimed the single figure, so
"Timed out after 200 ms." could be thrown 600 ms in. The three waits now measure against one deadline
taken when the process starts.

* Measure the backend health-check wait with nanoTime

check-backend-health! polls for five minutes against a wall-clock start, so a clock adjustment mid-poll
could cut the wait short or stretch it. The interval literal is now written as a duration too.

* Kill the command however the wait ends, not only on timeout

Three fixes around sh*'s failure handling.

The catch was for ExceptionInfo carrying :timed-out?, so any other way out left the command running: a
reader future failing on the pipe, or the calling thread being interrupted. It now catches Throwable and
asks whether the process is still alive, which is the question that actually decides whether to kill.

:or does not fire on an explicit nil, so a caller computing :timeout-ms from an env var and handing us nil
got a NullPointerException building the deadline rather than the default.

The test's 200 ms budget left the shell to fork twice and write both pids with no margin. On a loaded
runner the file could come up a line short, failing the descendant assertion for the wrong reason. A
second is still far below the bound the test asserts.

* Stop waiting on a command that orphaned our output pipe

sh* could sit for as long as an orphan lived, whatever its timeout said: 62 s against a 500 ms budget in
the case that prompted this. with-open closed the BufferedReader, and that close takes the same lock a
blocked readLine holds, so it waited for EOF -- which a process the command left holding our stdout never
delivers. Closing the pipe underneath ends the read at once, so the streams are now closed directly.

Closing the pipe means a cut-off read reports EOF rather than an error, which would make truncation
invisible. Two things guard against that. The readers get a floor of their own once the exit code is in,
so a command that finished a moment inside its budget is not robbed of the output it had already written.
And if the pipe is still held when that floor runs out, sh* says so and throws, because half a command's
output returned as though it were all of it is worse than a failure.

The orphan itself is still running afterwards. Reaching it needs process-group handling, which is a
larger change and no mage command leaks one today.

* Rewrite the comments and docstrings in mage.shell

The docstrings now state the caller's contract and nothing else: what sh* returns, what it throws, what
the timeout actually covers now that one budget spans the whole command. Rationale about how the body
works moved down to the lines it explains -- why the descendants are listed before anything is signalled,
why the deadline is read off a monotonic clock, why the pipes are closed rather than the readers.

* Tighten the comments once more, and drop the duration glosses

A second pass over the comment wording, and a correction: a DST change does not move the epoch
milliseconds `currentTimeMillis` reports, so it was never one of the things nanoTime protects the deadline
from. NTP corrections and manual clock changes are.

The `; 5 seconds` style glosses are gone throughout. Writing the constant as `(* 5 1000)` already says
which unit it is in, and the name carries the rest.

* Serialize mage shell output and fix test namespace loading

`println` writes the text and its newline separately, so the stdout and
stderr readers could land halves of two lines on one line of the terminal.
Lock on the destination, which also keeps two commands streaming at once
from splitting each other.

`mage -test` runs `run-all-tests`, which only sees namespaces that are
already loaded, and nothing required mage.bot.pr-env-test or
mage.bot.repl-eval-test, so eight tests never ran. The `(comment ...)`
block meant to hold these requires open only referenced an alias that
existed for its own benefit; kondo does not flag alias-less requires, so
it was protecting nothing.
2026-09-08 01:03:13 +02:00
github-automation-metabase
ada3520e32 Auto-update documentation for master (#81981)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-09-07 17:29:15 -04:00
Timofey Kachalov
33ebc8e671 Gate data apps remote sync logic under a token feature (#81946) 2026-09-07 20:04:42 +00:00
Andrei Simionescu
f1ea6b4ad5 BOT-1918: use the AWS default credentials chain for keyless Bedrock (#80512)
A Bedrock connection with no access key pair now signs with whatever the AWS
SDK default credentials chain resolves (environment, IRSA, EKS Pod Identity,
ECS task role, EC2 instance profile), and the SDK refreshes those on its own,
so a pod that already has a role needs no long-lived keys. Explicit keys still
override the chain, and half a pair or a lone session token is rejected.

On Metabase Cloud the chain would resolve our own identity rather than the
customer's, so a keyless connection is rejected there, and a token status the
license service could not confirm counts as hosted.
2026-09-07 18:24:18 +00:00
Will Fry
0de35e5dd3 Add Will Fry to team and slack map json files (#82028)
* Add Will Fry to team and slack map json files

* use exact casing for gh handle
2026-09-07 16:48:18 +00:00
Andrei Simionescu
0ed863ba11 BOT-1590: Test that the Conversations tab stays current on a conversation page (#81870) 2026-09-07 17:25:47 +01:00
Kamil Mielnik
da793ea976 GDGT-3189 Remove CustomVisualization['id'] and use CustomVisualization['getName'] (#82033) 2026-09-07 14:54:04 +00:00
Sébastien
7e6c62a105 Use consistent colors for the MCP errors-by-type pie chart (#81943)
* Avoid success-green slices in the MCP errors-by-type pie chart

* Use createMockStructuredDatasetQuery instead of a type cast
2026-09-07 16:51:27 +02:00
Paolo Rascunà
3ba6cb1479 BOT-2111: Stop the Gemini stream when the client cancels (#81959)
The streamGenerateContent xf walked each event's parts with a plain
`reduce`, which strips the `reduced` wrapper a cancelled consumer
returns. The stop never reached the outer reduction, so every event
that followed was still translated and pushed downstream — Google's
response was read to the end, and billed, after the client had gone.
The other adapters propagate the stop; only this one dropped it.

Use u/reduce-preserving-reduced so the early stop survives, and pin it
with a test that cancels on the first text delta: before the fix the
consumer kept receiving text from later events.

Co-authored-by: Paolo Rascuna <1936871+prascuna@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-07 14:23:37 +00:00
Stas Gavrylov
3c07580bcc GDGT-3188 Remove unintended elevation styles (#81958)
* GDGT-3188 Remove unintended elevation styles

* GDGT-3188 Fix remaining elevation regressions

* GDGT-3188 Update elevation guard expectations
2026-09-07 17:22:00 +03:00
Nicola Mometto
38fcd8e057 Scope tenant endpoints and pulse recipients by tenancy (#81765)
* Only serve tenant attributes and member_count to superusers

* Scope pulse recipients and the Slack directory by tenancy

* Update cross-tenant recipient test for non-superuser scoping
2026-09-07 15:15:20 +01:00
Nicola Mometto
c573e659f6 Read-check the transform in GET /api/transform/run/:run-id (#81761) 2026-09-07 14:45:17 +01:00
YB
f6ea5b6092 Fix ENOBUFS in the Create test plan CI step (#82025)
raise git ls-files maxbuffer so the test planner stops failing with enobufs
2026-09-07 21:33:49 +08:00
Sébastien
69256a104a Apply embedding theme colors to hand-picked chart series (#81014)
* fix: apply embedding theme colors to hand-picked chart series

* Clarify and dedupe chart color-picker naming

* Apply the instance's chart colors when rendering static visualizations
2026-09-07 15:00:00 +02:00
Kamil Mielnik
ff7b417ce6 GDGT-3184 Reject ':' in custom viz plugin identifiers (#81886) 2026-09-07 12:41:11 +00:00
Stas Gavrylov
0e7e969925 GDGT-2467: Curate Paper radius tokens (#81700)
* GDGT-2467: Restrict Paper padding/radius to curated token options

* Update Loki Snapshots

* GDGT-2467: Update entity picker width e2e expectation for Paper padding

* GDGT-2467: Keep Paper default padding at 0, add no-padding option to stories

* GDGT-2467: Keep all padding options in Paper stories, only curate radius

* Update Loki Snapshots

* GDGT-2467: Type PAPER_RADIUS_OPTIONS against RadiusScaleKey

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-09-07 15:07:41 +03:00
Nicola Mometto
1dfc2d1c90 Fix transform self cycle (#81676)
* Resolve the under-test transform's target live in cycle detection

* Split the change-target overwrite e2e test into the two cases it conflated

Retargeting onto the transform's own source table is a self-cycle (400), not a
target conflict, so exercise the conflict case with a table produced by another
transform and add a dedicated self-cycle case.

* Make the transform under test win target collisions in get-transform-cycle

* remove live-target-table-id
2026-09-07 09:49:13 +01:00
Nicola Mometto
78d3c10b00 perf: optimize fix-sql-params regex (#81893)
* Make fix-sql-params regex linear-time

The tag-body class excluded only `}`, so `\s*[^}]+\s*` had three overlapping
quantifiers and backtracked cubically on an unclosed `{ {` followed by
whitespace. Exclude `{` from the body and drop the redundant \s* so every
position matches in linear time.

* Use :standardsql dialect in test so no kondo ignore is needed
2026-09-07 09:48:49 +01:00
Kamil Mielnik
bbef4a31a2 GDGT-3185 Replace document viz settings instead of merging them (#81889) 2026-09-07 08:18:02 +00:00
Stas Gavrylov
ace7aa5dd0 Add Loki and Figma Desktop workflows to component skill (#81763) 2026-09-07 10:44:28 +03:00
Fraser
f531a39d14 Enforce the shared tiers for visualizations (#81990) 2026-09-07 16:59:45 +12:00
Romeo Van Snick
dbc843ce23 Derive each store root's state type from the slices it composes (#81481)
* Derive each store root's state type from the slices it composes

* Type the mirror's own selectors against the slice they read
2026-09-07 09:44:55 +10:00
metamben
e6216478c6 Introduce billing-project for BigQuery (#79489)
* Introduce billing-project for BigQuery

Closes QUE2-539
2026-09-05 22:29:39 +00:00
technomancy
42a8e9f77d Update create-transform-with-tags-test to be more specific about schema. (#81986)
Previously it was just picking a table at random and using that row,
but in redshift it turns out that table's row doesn't actually exist,
causing a bunch of failures. Let's look specifically at the people
test-data table instead of just using whatever.
2026-09-05 00:06:32 +00:00
Ben Grabow
6fdf223404 bgrabow/redshift-describe-database-probe (#81980)
* Probe for cause of describe database flakes

* Fix brittle test

* Delete obsolete probe test suite
2026-09-04 16:54:56 -05:00
Andrei Simionescu
70a3d8cb4a BOT-2110: sweep orphaned search index tables when a reindex starts (#81944)
Sweep orphaned search_index__* tables at the start of reindex! instead of at activation, so a rebuild
that dies partway is cleaned up by the next run instead of leaving its table behind. The sweep is best
effort and never aborts the reindex.
2026-09-04 21:52:11 +00:00
Fraser
8e3b90894e Move the drill layer from visualizations into querying (#79500) 2026-09-05 09:06:32 +12:00
Ben Grabow
a8db179087 Fix "The result set is closed" flaky reuse of connections (#80033) 2026-09-04 13:31:12 -05:00
Phoomparin Mano
ee9cd6a54e Fix getComputedStyle crash in data app sandbox (#81739)
* fix iframe parent distortion

Fix getComputedStyle calls in data app sandbox

fix frame parent distortion

* update distortion tests
2026-09-04 18:10:38 +00:00
Phoomparin Mano
96c905f643 Allow multiple useDataAppLocation consumers without crashing data apps (#81854)
Fix multiple data app location consumers
2026-09-05 01:06:40 +07:00
Riley Thompson
2a92db58c0 Don't merge db details if db engine was changed (#81968)
dont merge detials if new engine selected
2026-09-04 13:50:23 -04:00
Riley Thompson
cbfbeb3ce1 Fix implicit date conversion in postgres convertTimezone (#81912)
* add test

* Cast DATE inputs before timezone conversion on Oracle and SQL Server

`convertTimezone` on a `DATE` column failed on both drivers:

- Oracle: `FROM_TZ` only accepts a `TIMESTAMP` and refuses to implicitly
  promote a `DATE` (ORA-00932: inconsistent datatypes: expected TIMESTAMP got
  DATE). Cast date-typed inputs to `TIMESTAMP` first.
- SQL Server: `AT TIME ZONE` rejects a `date` argument (error 8116: Argument
  data type date is invalid for argument 1 of AT TIME ZONE function). Cast
  date-typed inputs to `datetime2` first.

Fixes `convert-timezone-date-column-test` for both drivers (#27186).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RYP35BadwdEL9LAC9zHWQZ

* Derive expected DATE column values from the results timezone in test

`convert-timezone-date-column-test` hardcoded the raw `d` column as
midnight `+07:00`, which is only right for drivers that support
`:set-timezone`. SQL Server can't set a session timezone, so its results
timezone falls back to the database timezone (UTC in CI) and the column
formats as `Z`. Compute the expected values the same way `format-rows`
does so the assertion holds on every driver with `:convert-timezone`.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RYP35BadwdEL9LAC9zHWQZ

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-09-04 17:37:51 +00:00
technomancy
234568bf20 Deprecate merged-column-info in driver-api. (#81965)
We want to drop as much usage of legacy-mbql as we can. This function
is never used internally, but it's exported in the driver-api. We
should mark it as deprecated since everything else in this namespace
is deprecated, so we can remove it when the time comes.

Need to get this in today so it's included in the 64 branch.
2026-09-04 17:32:16 +00:00
technomancy
4be1fd71c9 Replace Bigquery/Snowflake dataset tracking table; track by name instead (#81655)
* Replace Bigquery/Snowflake dataset tracking table; track by name instead.

The current system of using a tracking table was based on the
assumption that all datasets would need to be tracked by access
time. In fact, datasets fall into one of two buckets, either they are
static and immutable, or they are temporary one-offs. Static datasets
change *very* rarely and do not necessitate automated tracking. If we
neglect to clean them up, we could go for decades before the
accumulated datasets pose a real problem. But non-static datasets are
used once and accumulate *very* rapidly, needing to be cleaned up.

All datasets defined using `defdataset` are considered static.

Rather than using a database to track which ones must be cleaned up,
the logic can be much simpler; use the date embedded in the dataset's
name. It turns out it's even simpler because the logic to track
datasets based on their name has existed this entire time since 2023
in `metabase.driver.sql.test-util.unique-prefix`; we just stopped
using it in Snowflake/Bigquery in favor of the overly-complex tracking
table which A) leaked like mad and B) mistakenly marking static
datasets as old and causing them to get deleted while they were still
in use.

Redshift already uses the `unique-prefix` namespace generating its
schemas, so it only needs a few minor changes to adapt to the changes
in the gc job and the `unique-prefix` functions.

This also simplifies the gc nightly task; rather than having two
separate settings, we only need one setting for how many hours old a
non-static dataset has to be before cleaning it up. Also adds a
`dry-run?` option for manual testing.

* Address review feedback.

* Update workflow yaml to refer to single :hours parameter
* Remove 256-row limit from bigquery/snowflake
* Fix snowflake dataset :name in report data
* Get rid of with-write-stmt helper.
* Accept tracked? arg for manually GCing tracked datasets.
2026-09-04 09:24:56 -07:00
Nicolò Pretto
374e182461 add react_version to sdk analytics (#81954) 2026-09-04 17:03:33 +02:00
Anderson
35c9ea0a29 Fix flaky 'admin > allows to undo every action' test (#81020)
* Keep the data model in sync when a change is undone

* Extract shared TableSection update handlers into a hook

* Undo a custom field order with a single request

* Guard the optimistic table patch by table id

* Reproduce the dropped refetch scenario in the middleware test

* Link the upstream RTK issue from the dropped-refetch middleware and test
2026-09-04 13:52:40 +00:00
Nicolò Pretto
2176f18597 feat(sdk, eajs): add support to show "all" collections in the browser components (#80881)
* Accept "all" as a collection id in the browser public API

Adds the public api plumbing

* refactor: own the ItemsTable container query inside ItemsTable

The CSS container was defined in CollectionContent.module.css, which meant it only worked on ItemsTable when it was rendered inside CollectionItemsTable. The virtual "all collections" root renders ItemsTable on its own, so the container moves onto ItemsTable.

* refactor: split the collection breadcrumbs into a view and its data

We'll need to customize what breadcrumbs will be rendered for the virtual root.
This commit extracts the view that we'll use directly.

* Clear the browsed collection while the next one loads

RTK Query keeps serving the previous collection from `data` while the next one
loads, and keeps serving it once the argument becomes skipToken. A caller that
reads `can_write` during the switch therefore offers to create content in the
collection the user just left.

`currentData` drops to undefined on any argument change, so it covers both
cases and the manual clearing from 397a3e82e04 goes away.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gdru2a8afSo6y24e99W6hy

* Don't let the popped stack entry override the clicked breadcrumb

Clicking a collection breadcrumb from inside a question landed on the
collection the browser was mounted on, not on the one the user clicked.

Opening a question, a metric or a model pushes a navigation stack entry, so the
back button keeps working. That entry carried an onPop that reset the view to
the mounted collection. The breadcrumb handler sets the view to the clicked
crumb and then pops the stack, so onPop ran last and overwrote the click.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gdru2a8afSo6y24e99W6hy

* Render the virtual "all collections" root in the collection browser

collectionId="all" now lists everything the current user can reach, as flat
siblings, in the same order the entity picker uses: "Our analytics", the shared
tenant collections, "Our data" and the personal collection.

useAllCollectionsItems builds those rows:

- A 403 on GET /api/collection/root means the user cannot read "Our analytics"
  itself, so the hook falls back to /api/collection/root/items, which has no
  read check on the root. The models=collection argument is required: without
  it the endpoint returns no models at all.

- "Our analytics" needs a numeric id for the table, so it gets 0. Real
  collection ids start at 1, and the caller maps 0 back to "root".

- The shared tenant collections come from the collection tree, gated on the
  use-tenants setting and on the tenants plugin. shallow=true keeps the
  backend from building a nested tree the caller never reads.

- The backend excludes the tenant collection from /api/collection/root/items,
  so the hook adds it from the current user.

CollectionBrowser renders the rows with ItemsTable directly, without the
archive column: archiving resolves its permissions from a parent collection,
and the virtual root has none.

The breadcrumbs put a static "All collections" crumb in front of
CollectionBreadcrumbsView. The personal and the namespaced collections lose
their "Our analytics" crumb, because the API reports them as its children
while the virtual root shows them as siblings.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gdru2a8afSo6y24e99W6hy

* Key the SDK breadcrumbs by type and id

Breadcrumb ids come from separate id spaces, so a collection and a dashboard
can both be 5. On an instance where collection 5 holds dashboard 5 the trail is
[all-collections "all", collection 5, dashboard 5], and two children of the
same list share the key 5. React warns about the duplicate key in the host
application's console.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gdru2a8afSo6y24e99W6hy

* fix sdk package type

* e2e tests

* Unit test the virtual "all collections" root

* "all collections" -> "all-collections"

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>

* pageSize support

* Assert the error message, not the error container

The virtual root error tests only checked that the sdk-error-container
testid rendered. That proves an error appeared, not which one, so any
other failure rendering into the same container would keep them green.
They now look for "Failed to load collections".

Verified by mutation: changing that string in CollectionBrowser turns
all four tests red, where the testid version stayed green.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C9MrpBnd3VEiXVvYf15Qqd

* change root id from 0 to -1 and wrap the mapping

* import already existing defer

* not.toHaveLength(0) -> toBeGreaterThan(0)

* clarify that the root is 403 in the test

* `SdkBrowseCollectionId` -> `SdkBrowserCollectionId`

* docs(sdk): list the accepted collectionId values as bullets

The CollectionBrowser `collectionId` doc described five accepted values in
one running paragraph, and adding "all" pushed it past readable. Split it
into one bullet per value, and document the entity ID string, which the
paragraph never mentioned.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UTu6CuVJnRjzS1HrmrJQT3

* else if

* rename the virtual root identifiers to all mode root

* refactor root status into union

* clarify when the root could be empty

* fix eslint

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
2026-09-04 14:59:46 +02:00
Kamil Mielnik
af22e8cf22 GDGT-3183 Sanitize ClickObject and HoverObject (#81885) 2026-09-04 19:57:23 +07:00
Kamil Mielnik
d3cb526e49 GDGT-3186 Custom viz SDK type-check (#81891) 2026-09-04 19:38:54 +07:00
Alexander Polyankin
6be1b2761e Warn when startup encrypts legacy plaintext, and make migrations leave none behind (#81898)
* Warn when startup or a migration encrypts data that was stored unencrypted

The settings backfill reports that settings saved by an older version are being
converted, the startup sweep reports each column whose plaintext values it
encrypted, and the migrations that encrypt existing rows report how many they
touched, so an operator can see when and why data changed at rest.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Find legacy unencrypted values first and hand them to a handler before encrypting them

`legacy-unencrypted-value?` decides what counts as legacy plaintext, the startup
sweep and the encrypting migrations filter their rows with it, and
`handle-legacy-unencrypted-values!` is called with the count before anything is
encrypted, so it can turn from a warning into something else later. The
migrations keep private mirrors of both, as they do for the encrypted JSON
helpers, and read their rows eagerly: reducing a reducible query closes the
transaction's connection.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Call the handler's location parameter title

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Make the encryption migrations no-ops and move the app-db module's queries to db.clj

The Encrypt* custom migrations did the same work `encrypt-plaintext-columns!` does
on every startup, so their forward bodies are gone; the reversible ones keep their
decrypting rollback for downgrades. The handler now takes only a `table.column`
location. The encryption and setting namespaces run their Toucan 2 queries through
the new `metabase.app-db.db`, like the other modules.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Drop the decrypting rollbacks of the no-op encryption migrations

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Make a fresh install come out fully encrypted from the migrations alone

The encryption-touching data migrations that only rewrote existing rows are no-ops
now that the startup sweep covers their columns, and MigrateMetricsToV2 goes with
them. Two v58 changesets left rows a fresh install would then see as legacy: the
SQL copy of password authentication into auth_identity is retired from the
changelog and redone in Clojure with the credentials encrypted, and sample content
is created by CreateSampleContentV3 once setting.value_with_aad exists so the
example-dashboard-id row is written whole. The settings backfill skips the
encryption-check sentinel, which the encryption tooling rewrites itself. The
fresh-install test asserts that setup logs no app-db warning and that the sweep
afterwards finds nothing.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Keep the sample-content migration tests in version order

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Stop inserting the plaintext encryption-check marker on new databases

The v53 changeset that inserted it is retired from the changelog: the encryption
tooling writes the sentinel itself, whole, and reads a missing row the same way, so
the settings backfill no longer needs to special-case it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Delete the plaintext encryption-check marker instead of retiring its changeset

The v53 changeset inserted the marker on every new database, encrypted ones
included, so it never said anything about the actual state. It stays in the
changelog as a checksum-agnostic no-op, since a rollback to a release that still
has it must not re-run the insert, and a new changeset deletes the marker rows: with
no row the state is unknown and judged from the content, which the encryption
tooling already does.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Leave the v53 encryption-check changeset untouched

Its checksum is recorded on every existing database and validCheckSum: ANY does
not lift the check, so it keeps inserting the plaintext marker on a new database
and the v58 changeset deletes the row right after.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Keep the data migrations, retire the Encrypt* changesets, and never change a row's encryption state

The migrations that rewrite encrypted JSON columns are back with their original
bodies, but `encrypted-json-in` now writes a row back the way it was stored:
encrypted only when the stored value decrypts with the current key, so a
migration never turns plaintext into ciphertext or the reverse. The Encrypt*
migrations are removed outright, with a changeset retiring their changelog
records, since encrypting legacy plaintext is the startup sweep's job.
CreateSampleContentV2 is untouched again and a small migration fills its
setting's value_with_aad from the strictly decrypted value; the LLM providers
migration writes both columns too.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Address the review: decide by decrypting, stream the sweep, and write NULL rather than an empty SET

The settings backfill now treats a value as encrypted only if it decrypts, so a
plaintext value that merely looks like ciphertext is filled in instead of being
skipped forever. update-setting-values! takes the columns to set as a map, so a
value that encrypts to nothing is written as NULL as before instead of compiling to
an empty SET. The startup sweep streams each column again, warning once before the
first row it encrypts. The unused bytes predicate is gone, the string one is
private, and the two changelog-retirement changesets are one, using the changelog
table property.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Keep the SQL copy of password authentication; the startup sweep encrypts the credentials

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Give the internal user no password

It is inactive and can never log in, and a password would be copied into
auth_identity bare by the v58 SQL changesets, leaving a fresh install with one
row for the startup sweep to encrypt.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-04 08:01:14 -04:00
Fraser
21b94190f6 Move FieldPanel into the table columns settings widget (#81929) 2026-09-04 21:24:50 +12:00
Nicola Mometto
72951848e5 Use tighter schema for POST /api/notification/send (#81877)
The endpoint sends an unsaved notification, so its body has no row of its
own. Decode it with the create schema instead of the full hydrated one.
2026-09-04 09:54:48 +01:00
Fraser
364ec28c56 Move template_tags and native parameters list into parameters (#79127) 2026-09-04 15:32:45 +12:00
Fraser
63e4a7ccb2 Create the segments module (#81864) 2026-09-04 14:59:02 +12:00
Anderson
3fafdbd58a Aggregate static viz grid map cells when the mapped dimensions are not unique (#80354)
* Aggregate static viz grid map cells that share a lat/long bin

* Address review
2026-09-04 01:13:19 +00:00
Riley Thompson
df8d8a2f41 Add test for presto struct fields (#81903)
add test
2026-09-03 21:33:06 +00:00
Tyler Plude
7d07cc9ac8 [GHY-4377] Data sensitivity table scanning (#81752)
* add deterministic data_sensitivity rules classifier

* fill data_sensitivity rule table to full enum breadth

* add data_sensitivity scan step and opt-in setting

* register classify-data-sensitivity as the last analyze step

* document PUBLIC as scanned-or-reviewed for data_sensitivity; add end-to-end tests for the data_sensitivity scan

* label non-Text base types and integer/band variants in the data sensitivity classifier

* add reset-data-sensitivity! to clear classifier-written labels
2026-09-03 14:33:01 -07:00
github-automation-metabase
cf03ebca8d Auto-update documentation for master (#81921)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-09-03 17:29:02 -04:00
Fraser
a00b3d7fd1 Move CollectionBadge into common/collections (#81856) 2026-09-04 09:05:48 +12:00
Fraser
c82c593a00 Move the no-results alert prompt from querying into notifications (#81853) 2026-09-04 09:05:19 +12:00
Riley Thompson
b7a39e92b3 Add test for cumulative sum of a literal number (#81806)
* Add test for cumulative sum of a literal number (#27807)

Adds a QP test verifying that a custom aggregation expression of
CumulativeSum(1) on the Products table, broken out by Created At by
month and ordered ascending, runs successfully instead of failing
with 'Field 1: Field does not exist'.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011kKRbqUbfSKNViTEzS82ss

* clean up

* undo

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-09-03 23:43:36 +03:00
Aleksandr Lesnenko
8444d69eb9 Show errors from the body of http 500 responses to users (#74693)
surface http 500 error messages to users
2026-09-03 20:37:04 +00:00
Fraser
295d7eaabb Dispatch fetchTableMetadata directly instead of through loadMetadataForTable (#81852) 2026-09-04 08:35:08 +12:00
Cam Saul
cf6a95c3b8 Metadata for plain-:field expressions should propagate Field ID and Table ID (#81286)
* Metadata for plain-`:field` expressions should propagate Field ID and Table ID

* Fix 🔧

* Add tests 🔧

* Test fix 🔧

* Test fix 🔧

* Test fixes 🔧

* Test fix 🔧
2026-09-03 20:05:10 +00:00
Tyler Plude
e315710292 [GHY-4378] Add data_sensitivity col to field (#81744)
* add nullable data_sensitivity column to Field and its user-settings mirror

* Expose data_sensitivity on PUT /api/field/:id

* add tests for data_sensitivity survives sync, reactivation, and base-type changes

* add serdes round-trip tests for data_sensitivity on Field and FieldUserSettings

* Expose data_sensitivity in Lib column metadata

* tweak wording
2026-09-03 13:01:43 -07:00
Chris Vandoodewaard
2b35888297 containerize uberjar from uberjar workflow (#81238)
* merge containerize-uberjar into uberjar workflow

* big refactor

* move things around, add inputs to fetch-artifact action

* update conditional logic

* clean up comments

cleanup whitespace

* simplify conditional logic

* guard conditional matrix

* review cleanup

* add job names

* cleanup whitespace

* update get-docker-info to resolve repo/tag inputs

* trim trailing whitespace

* fix linting

* simplify fetch-artifact, use continue-on-error instead
2026-09-03 14:37:13 -04:00
Eric Normand
0dfca163f0 GHY-2937: On-demand field values can take forever to load (#81753)
* Keep on-demand FieldValues fetches alive past request cancellation

On-demand FieldValues are fetched on the request thread, so a canceled HTTP
request threw the warehouse scan away: every retry started the scan over and
nothing ever landed in the app DB, which is what makes these requests feel
like they take forever.

Run the fetch on a detached thread instead. It runs to completion and persists
what it fetched even when the caller stops waiting, and concurrent callers for
the same field (and sandboxing/constraint context) share the one in-flight run
rather than each kicking off their own scan.

Fixes GHY-2937 (#67843)

* Log detached FieldValues fetch failures

When every caller has walked away — the case detached-fetch! exists for —
nobody derefs the promise, so a thrown exception was dropped without a trace.

* Don't wipe cached FieldValues when the warehouse scan fails

`distinct-values` catches and logs warehouse errors, then returns nil — but
`create-or-update-full-field-values!` destructured that nil into empty values
and handed it to `persist-field-values!`, which reads empty as "this field has
no values" and calls `clear-field-values-for-field!`. So any failed or
timed-out scan deleted the values the field already had cached, and a field
slow enough to hit the QP timeout could never keep a cache at all.

Distinguish the two cases: nil means the scan failed, so leave whatever is
cached alone and return ::fv-fetch-failed. A scan that genuinely comes back
empty still clears, as before. The sync path already made this distinction
(see fetch-distinct-per-field's :failed-fields).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Guarantee detached FieldValues fetches always complete

A registry entry left behind with its promise undelivered is worse than a
leak: every later caller for that key parks on it forever, holding a request
thread each. Two paths could do that.

The `log/warnf` added for failed fetches sits inside the catch, so an appender
that throws skips both the registry cleanup and the delivery. And the registry
entry is claimed before the work is submitted, so a rejected submit — which is
what `future`'s pool does once the JVM starts shutting down — orphans it.

Route both through `complete-fetch!`, which still drops the entry before
delivering so a woken caller starts a fresh fetch rather than re-attaching to
a finished one.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Sweep and cancel stalled detached FieldValues fetches

Nothing bounded the in-flight registry except every code path remembering to
clean up after itself, which is a property that keeps not holding — the
logging call has now stranded entries twice.

Give each entry a timer and its future, and sweep on the way into
detached-fetch!, which is the only moment the registry can grow. The sweep
cancels the work and *completes* the entry rather than just forgetting it:
callers park on the promise, so dropping one undelivered leaves them blocked
forever, each holding a request thread.

Only a fetch wedged outside the query processor can reach the max age — the
warehouse query is already capped by *query-timeout-ms* (20 minutes in prod).

Removing an entry is now conditional on it still being the registered one, so
a swept fetch that later finishes can't evict its own replacement.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Filter stalled fetches in the doseq rather than up front

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Cap the in-flight FieldValues registry at 100 entries

Callers park on their fetch, so the number in flight is today limited by the
request thread pool — but that is an accident of how these endpoints are
served, not something this namespace can guarantee, and it stops holding the
moment anything frees a caller early.

Past the cap, detached-fetch! stops detaching and runs the work on the calling
thread. That degrades to what happened before detaching existed — no
single-flighting, no surviving cancellation — rather than failing the request,
so a ceiling that should never be reached can't take a filter dropdown down
with it. Capacity is checked inside the swap, so the ceiling holds exactly
under concurrent claims.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Refuse FieldValues fetches past the in-flight cap

Reaching the cap means something is wrong — callers park on their fetch, so
the number in flight is bounded by the request thread pool unless that stops
holding. Absorb it by running the work inline and the ceiling stops being a
signal; throw a 503 and it says what it means.

Raised to 200 now that hitting it fails the request rather than degrading it:
an instance has to have raised MB_JETTY_MAXTHREADS well past its default of 50
before this is reachable at all.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Pin down that joining an in-flight fetch bypasses the cap

The behavior was already right — claim-fetch!'s `contains?` short-circuits
before the count check — but it reads as incidental, and a caller that only
attaches to existing work adds no entry, so the ceiling has no reason to
refuse it. Say so, and test it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Bound how long a caller waits on a detached FieldValues fetch

sweep-stalled-fetches! only runs when a request arrives, which is exactly what
the case it guards against prevents: callers parked on a wedged fetch are
request threads, so enough of them and nothing reaches the sweep to cancel
anything. The watchdog was only reachable while the system was healthy.

Bound the waiter's deref by the same max age. The expensive thing here is the
parked request threads rather than the registry entry, and giving those back
lets requests flow again — at which point the next one sweeps the corpse. No
scheduler needed.

fetch-max-age-ms stays a backstop rather than a request-latency bound: a value
nearer a sensible HTTP timeout would return the thread far sooner, but
answering before the values are ready changes what the endpoint promises, and
that wants deciding on its own.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Report scan failures from POST /api/field/:id/rescan_values

The endpoint discarded the result and always answered {:status :success}. That
was already misleading, and the cache-wipe fix made it worse: a failed scan now
leaves the existing FieldValues untouched, so there is no observable trace of
it at all — the caller is told the scan succeeded and sees the values it had
before.

Return a 500 when the scan failed. The button already toasts on error, so this
is the difference between "Scan triggered!" and a visible failure.

Unlike the table and database endpoints, this one runs the scan synchronously,
so it is in a position to know.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Serve warm advanced FieldValues without a detached fetch

The advanced branch wrapped the whole select-or-insert in detached-fetch!, so a
cache hit — one SELECT — paid a thread handoff and a registry sweep for a plain
read. field-id->field-values-for-current-user walks advanced fields serially,
so a sandboxed user with N filters paid N of them.

Look the row up on the calling thread and detach only on a miss, which is the
only case that scans the warehouse. This is what the full-values path at
get-or-create-full-field-values! already did.

The miss path gains one extra SELECT, since select-or-insert! still does its
own read before inserting. That is noise next to a warehouse scan, and keeping
select-or-insert! there is what makes two callers racing a genuine miss safe —
detached-fetch! only single-flights within one JVM.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

* Stop the FieldValues tests mutating JVM-global state

Two tests could only be trusted because of a test-runner setting. The cap test
stuffed 200 fake entries into the shared in-flight registry, so anything else
asking for field values during that window would have been refused with a 503;
three tests swapped distinct-values with `with-redefs`, which rebinds the root
for the whole process. Under the current runner nothing else is running, but
that is a property of `:multithread? :vars`, not of the tests — flip it and the
failures land in other people's namespaces.

Make the two knobs dynamic so the cap test can bind the ceiling to 0 and drive
everything through the public API instead: one real fetch held in flight, a new
key refused, and a joiner admitted. That tests more than the fake entries did.

Use the thread-local `mt/with-dynamic-fn-redefs` where the work stays on
threads that inherit bindings. Where it delegates to the original, capture it
with `mt/original-fn`: `patch-vars!` installs its proxy as the root for the
life of the JVM, so a bare symbol captured after some earlier test patched the
same var would have recursed into the proxy.

The rescan test keeps `with-redefs` — `mt/user-http-request` is served on a
Jetty worker that inherits nothing, so only a root rebind is visible there.
Commented so nobody "fixes" it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XwGt3aocjPgJeGXTuEjujp

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-09-03 13:16:43 -05:00
Alexander Polyankin
30e5526fa7 Cover enable-encryption against the read-only-mode guard reading settings (#81890) 2026-09-03 14:00:47 -04:00
Jeff Bruemmer
196032c3fe docs - banner cleanup (#81895)
banner cleanup
2026-09-03 13:51:49 -04:00
Alexander Polyankin
a865fd1ad7 Address the remaining db.clj review findings: metabot, sync, search and friends (#81865) 2026-09-03 11:53:29 -04:00
Andrei Simionescu
9c04238b16 BOT-2052: stop reading six Metabot settings from the environment (#81217)
The three system prompts, the two usage limit settings and the quota message no
longer read their environment variables, so they are set through the admin page,
the API or a config file like every other setting. Name, icon and
show-illustrations keep theirs, which matches the MB_APPLICATION_* whitelabel
settings that self-hosted deployments set once at startup.

Demoting a setting used to drop it from the config file template as well, because
the template generator shared the environment variable docs filter. That filter
now sits with the docs alone, which puts use-tenants back in the template.
transforms-setup-complete is derived and never read back, so it is marked
read-only and the template stops advertising a key that does nothing.
2026-09-03 14:46:53 +00:00
Timofey Kachalov
25060e4397 Fixed outdated data app sync skill/comment (#81790) 2026-09-03 18:29:31 +04:00
Kamil Mielnik
a2979abd20 GDGT-3182 Make checkRenderable optional in custom viz (#81884) 2026-09-03 21:10:50 +07:00
Andrei Simionescu
f1ddc2317b BOT-2003: Support GLM 5.3 (#81681)
Add GLM 5.3 to the model picker whitelist on both providers
2026-09-03 13:01:26 +00:00
Chris Vandoodewaard
cb5e5847c4 use gh cli to approve/automerge instead of 3rd party action (#81599) 2026-09-03 08:47:31 -04:00
Chris Vandoodewaard
00b57255ea remove ci release comments (#81598) 2026-09-03 08:46:34 -04:00
Andrei Simionescu
fa07f544d5 Metabot: remove extraneous data from non-500 errors with an error code (#81201)
An `:error-code` means the throw site wrote this as an API response rather than
hitting an unexpected failure, so the client gets the message and the error data
and nothing else. The Metabot token-limit 402 and the transforms trial-limit 402
both returned a full backend trace before this.

Validation errors, real 500s and the older `:error_code` spelling are untouched.
2026-09-03 12:07:03 +00:00
Kevin Kelleher
c8a8941508 Documents viz setting sidebar fixes (#81740)
* documents viz setting sidebar fixes

* use Ellipsified on viz name
2026-09-03 07:19:14 -04:00
Chris Truter
94d7dd520c Show what automated ratchet PRs shrink (#81807)
* Show what automated ratchet PRs shrink

* Tweak messaging

* Fix ratchet PR body test lint
2026-09-03 12:57:39 +02:00
Jakub Chodorowicz
e4cf63ff23 gate event apis on window instance (#81680) 2026-09-03 11:03:12 +02:00
Timofey Kachalov
c73e309b13 Adjust skill guidance telling agents not to offer a "deploy" step for data apps (#81791) 2026-09-03 11:45:58 +04:00
Timofey Kachalov
8196701636 Update data apps upsell (#81786) 2026-09-03 10:56:26 +04:00
github-automation-metabase
042ec24fe9 Tighten ratchets (#81862)
Co-authored-by: github-actions <github-actions@github.com>
2026-09-03 04:58:07 +00:00
Alexander Polyankin
ff335470e7 Route each module's app-DB queries through a db.clj namespace (#81824) 2026-09-03 04:52:56 +00:00
Fraser
75bce3e619 Move open-url out of visualizations into urls (#81842) 2026-09-03 16:14:55 +12:00
Fraser
9ddee1f434 Register the use-icon spec's own visualizations from viz-core (#81844) 2026-09-03 16:01:14 +12:00
Fraser
0337de20c1 Read the app slice instead of current-user in the redux hooks spec (#81841) 2026-09-03 15:46:09 +12:00
Fraser
c71cf2a379 Move useHelpLink from nav into common/hooks (#81843) 2026-09-03 15:45:42 +12:00
Fraser
06462d0005 Enforce shared tiers for urls (#81845) 2026-09-03 15:45:26 +12:00
Alexander Polyankin
e6aa23212c Write re-encrypted rows with plain SQL, not Toucan DML (#81829) 2026-09-02 23:42:56 +00:00
bryan
79041e2487 mcp-v2.00 prep: extract query guards + pulse helpers; additive shared-ns changes v2 needs (#81244)
* MCP v2 prep: extract query guards + pulse helpers; additive shared-ns changes v2 needs

Behavior-preserving groundwork for the v2 MCP surface, landed while v1 is
untouched and v2 is not yet present:

- NEW metabase.agent-api.query-guards (+ its test): query safety checks
  extracted so REST and MCP run identical guard logic.
- metabase.pulse: recipient-filtering and sensitive-metadata-stripping
  logic moved from private fns in api/pulse.clj into models/pulse.clj and
  exported via pulse.core / pulse.api, so REST and MCP share it. Pure move;
  existing REST pulse tests are the check (+ new direct tests).
- metabase.channel.urls: adds metric-path, transform-path, collection-path
  helpers (additive).
- metabase.metabot.scope: adds agent:{content,query,sql,delivery}:* scopes
  and collapses agent:viz:mcp-ui:{query,drill-through} into
  agent:viz:mcp-ui:* — a proven superset, backward-compatible with v1's
  gating (REPL-verified: old concrete scopes still match). Also regates
  agent:metric:* from SQL-generation to NLQ permission (scope_test).
- metabase.mcp.settings: adds mcp-v2-disabled-tools and
  mcp-query-handle-ttl-hours (additive; v1-safe; tests included).
- metabase.models.serialization.resolve{,.mp}: adds *numeric-ids-allowed?*
  dynvar; resolver miss messages no longer name a specific discovery tool
  (the calling surface owns the recovery sentence) — mp_test updated.
- metabase.server.streaming-response: optional :executor option threaded
  through do-f-async; default path (shared pool) unchanged. Needed by
  long-lived SSE keepalive streams so they can't exhaust the fixed pool.

Review question for this PR: does REST/v1 behavior stay identical?

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BjQcjQx7NPGr3Rpf6QaG4b

Review fixes (2026-08-27 deep review of #81244):
- native-marker? requires a truthy :native value (an explicit-null key from a
  JSON round-trip is not a marker); docstrings state the guard/agent-api
  sequencing explicitly (live v1 path untouched; call sites migrate at retirement).
- check-mcp-ui-native-query! accepts agent:sql:execute (v1's concrete scope)
  alongside agent:sql:run, and documents that scope claims arrive with the v2
  session rework — until then native-over-UI-credential fails closed.
- mcp-query-handle-ttl-hours getter no longer rethrows on an unparseable env
  var (falls back to the default instead of killing the GC task).
- *numeric-ids-allowed?* docstring rewritten in future tense naming its binder
  (the v2 query pipeline) and reader (the dialect rework PR).
- viz-scope comment corrected (v1 resources still register those strings until
  retirement; wildcard keeps them satisfied); mp.clj database-id tru args
  str-wrapped against MessageFormat locale grouping; streaming-response
  :executor docstring notes the Future.cancel(true) interruption requirement.

Follow-up (review round 2): the guards are now genuinely shared — agent-api's
private copies are deleted and its execution paths call query-guards directly.
Deliberate tightening: raw-scan native detection replaces normalize-then-inspect
(fail-closed on unparseable payloads). Full agent-api api-test green.

Re-review round: agent:sql:execute compat branch now tested; TTL getter's
catch path tested ("forever"); reject-native-query! no longer echoes the
payload in ex-data (matches the old live rejection shape); viz-scope comment
typo fixed; pure predicate tests ^:parallel; check-token-query-permissions!
docstring states the stage-0-fast-path/QP-backstop contract.

--- Close-out review response (slice 00's first adversarial round) ---

CRITICAL (native-query false-positive on legacy MBQL with a field/expression/tag named `native`)
FIXED. native-query? scanned the whole payload via tree-seq, so a legit query whose :expressions or
:template-tags map had a key named "native" was rejected (400) though it ran fine on master. It now
scans only the structural query-nesting edges (:stages/:joins, :query/:source-query), never
descending into caller-named :expressions/:template-tags; a malformed value off a structural edge is
still deep-scanned to stay fail-closed. Proven: a 17-case REPL matrix — every crafted false-positive
now false, every genuine native (legacy top/nested, MBQL5 stage, joins, string-keyed, malformed)
still true.

SECURITY (v1 MCP bearer authenticates a deactivated user) FIXED. resolve-access-token — the single
resolver shared by the v1 transport and the core session bearer bridge — now gates on
(t2/exists? :model/User :id user-id :is_active true). v1's transport dispatched straight on :user-id
with no active check; v2 was already refuse-only. Proven fails-when-broken: reverting the guard lets
a deactivated user's token resolve; restored, it is refused. v1 mcp.api-test (598 assertions) green.

IMPORTANT fixed: agent:delivery:write now granted by the metabot-other-tools bucket (was dead
config → alert_write would 403 everyone); metabot-nlq grants agent:content:read not :* (was
over-granting write to NLQ-only users); update-pulse-with-perm-checks! validates :cards against
CoercibleToCardRef (a bad string id was a 500, now a 400); check-mcp-ui-native-query!'s docstrings
now state it is dormant until the v2 session-rework slice wires it (was claiming to be live).

MINOR fixed: thrown-status test helper distinguishes no-throw from throw-without-status; kill-switch
check moved after the scope check (a scope-denied caller no longer learns the kill-switch state);
the query-handle-ttl default is one const, not two literals; mp_test gains positive assertions.

Re-verified (fresh JVM, run separately): query-guards + scope + settings + mp 328 assertions;
oauth + v1 mcp.api-test green. The one red in pulse-test is create-csv-xls-test = GDGT-3161, a
pre-existing EE-app-db bug (empty {} dataset_query -> download-perms 500) in the CREATE path (not
this fix's update path), reproducing on plain master — not introduced here. kondo 0/0; cljfmt clean;
modules-config regenerated (oauth-server :model-imports gains :model/User).

--- master parity sync (user-approved Option A) ---
Carries master 8c3ea6f40b (#80554 Remove Explorations dimension anchored blocks) + master search/appdb/index.clj (isolate-write! savepoint isolation). Stack forked before both; without them the dropped exploration_block.type migration is absent -> Liquibase changelog-integrity failure on real app-DBs (App-DB Part2 CI). Synced at base to restore parity. 41 files, all slice-untouched.

* Fix save-access-token! call arity after master merge

Master gave the test helper a 5th arg (client-id via
oauth-server.tu/with-oauth-client); the new
resolve-access-token-deactivated-user-test still called the 4-arg form.
Wrap it in with-oauth-client and pass client-id, matching every other
call site. Verified: full session-oauth-test namespace green locally
(10 tests, 27 assertions, 0 failures).

* Fix native-guard snake_case gap and make the tenant recipient filter work end-to-end

- native-map-edges gains :source_query/"source_query": legacy MBQL
  normalization canonicalizes the snake_case spelling too, so a payload
  like {"query" {"source_query" {"native" ...}}} reached the query
  processor as a native stage while native-query? said false — an
  MBQL-only-scoped caller could run raw SQL through /v1/execute,
  bypassing the scope split and the execute-sql kill switch. Regression
  tests cover both the string and keyword snake forms.

- The cross-tenant recipient filter compared :tenant_id on recipient
  maps that the :recipients hydration never populates, so a tenant
  caller lost every user recipient and a tenantless caller was filtered
  by nil = nil. Tenant membership is now looked up from the app DB
  inside the filter, and the filter only engages for a caller who
  belongs to a tenant — a tenantless user sees recipients unfiltered,
  as before tenants existed. The test now builds real users in real
  tenants (production-shaped recipient maps, ids only) instead of
  fabricating :tenant_id keys, and pins the tenantless-caller
  passthrough.

* Match native-SQL markers case- and separator-insensitively

`native-query?` matched edge names and markers case-exactly, but the QP
normalizer canonicalizes keys case-insensitively and treats `_` and `-`
alike. `{:query {:SOURCE_QUERY {:native "select 1"}}}` therefore scanned
as not-native and then executed as a native stage — REPL-confirmed, along
with `:Source_Query` and an uppercased `:NATIVE` marker.

That is a live bypass rather than a latent one: since
`+refuse-unscoped-native-sql` went live on /api/dataset, this scan is the
only gate between an unrestricted-stamped MCP UI credential and raw SQL.
The same scan backs `reject-native-query!` on the agent-api execution
paths, so those inherit the fix.

All key and value matching now goes through one `token` fn — namespace
kept, lowercased, `_` folded to `-`. Nodes are walked as `[token value]`
pairs rather than by fixed lookup, so a node carrying two spellings of
one edge has both scanned instead of one silently shadowing the other.

* Deep-scan a non-map stage element instead of throwing

`native-query?`'s `scan-map` iterated the node's entries without checking it was a map, so a
junk payload like `{:stages [1]}` threw "Don't know how to create ISeq from Integer" and
`/v2/query` answered 500 where shape validation should have answered 400
(`combined-query-rejects-malformed-payload-test`). A non-map where a stage belongs is now
deep-scanned like every other malformed sub-tree: never throws, and a marker after it still
trips the guard.

* Address round-3 review findings on the extraction slice

- The bearer resolver's is_active gate is defense in depth, not the primary control: deactivating
  through the model already revokes the user's tokens. The docstring now says so, and the test
  deactivates with a raw core_user UPDATE (the path the gate exists for) and asserts the token was
  not revoked, so the gate is what the test exercises.
- Pin that a tenant-scoped caller sees only same-tenant pulse recipients (tenantless users hidden).
- scope.clj comments described a wildcard collapse that is not in this diff; say what the slice
  does: adds scopes, removes none.
- Correct the guard test docstring: the /api/dataset gate is wired by the next slice.
- Pin the guard's deep-scan fallbacks and the streaming response's :executor option with tests.

* Widen the recipient merge-back to cover the tenant filter

Addresses review feedback on the tenant recipient filter: a filtered read
that is submitted back as a write silently deleted the recipients the
caller was never shown.

The `:channels` submitted to an update are authoritative --
`update-notification-channels!` deletes any recipient not present -- so
every recipient hidden on the read path has to be restored on the write
path. Master already did this for one read filter (sandboxed and
impersonated users, via `maybe-add-recipients`), but the tenant filter
added in this slice had no corresponding write-path compensation. A
tenant-scoped caller doing GET then PUT of the returned body therefore
dropped every other-tenant and tenantless recipient row.

Rather than add a second parallel mechanism, the tenant visibility rule
is now a single predicate (`recipient-visible-to-tenant-caller?`) used by
both sides: the read path filters with it, and the write path merges back
exactly what it excluded via `hidden-cross-tenant-recipients`.

Two supporting fixes:

- `maybe-add-recipients` now normalizes `:channel_type` the way
  `email-channel` does. The old `(= "email" ...)` string comparison only
  matched the REST shape, so a direct call with a hydrated pulse (keyword
  `:email`) skipped the merge entirely -- which also made the pre-existing
  sandbox protection REST-only.
- Merged recipients are de-duplicated by `(some-fn :id :email)`, the same
  key `update-pulse-with-perm-checks!` uses to diff recipients, so a
  caller matching both filters cannot get a recipient appended twice.

Verified in a REPL: the new endpoint-level round-trip test goes red
without the merge-back (two recipient rows destroyed) and green with it.
It asserts on `pulse_channel_recipient` rows rather than the API response,
since the response is filtered either way and cannot distinguish "hidden"
from "deleted". Pulse, pulse-channel and enterprise sandbox pulse suites
show no new failures (`create-csv-xls-test` fails identically on the
unmodified branch).

---------

Co-authored-by: Eric Normand <ericwnormand@gmail.com>
2026-09-02 23:18:07 +00:00
technomancy
9d216767d0 Remove be-tests-databricks-multi-catalog-ee job. (#81127)
In https://github.com/metabase/metabase/pull/80957 we trimmed this job
down so it no longer doubles the tests run. But it's still pointless
to have it as a separate job; it should be tested inline with the main
suite.

We still run some individual tests twice using the
`with-and-without-multi-level` macro when we need to cover both the
multi-catalog behavior and the non-multi-catalog behavior, but this is
only a handful of tests now instead of the entire suite or the entire
namespace.

Removal of `when-not (tx/db-test-env-var :databricks :multi-level-schema false)`
causes a lot of indentation changes here, so it's best to review with
whitespace diffs turned off.
2026-09-02 22:35:39 +00:00
Alexander Polyankin
a9a062731b Store setting values encrypted under the setting's name (#81751) 2026-09-02 17:26:10 -04:00
github-automation-metabase
a7090f30ba Auto-update documentation for master (#81820)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-09-02 21:23:08 +00:00
Andrei Chernykh
8a7375b368 Split the SSO auth settings pages into card sections (#81750)
* Split the SSO auth settings pages into card sections

* Deflake modal escape close in data-model e2e specs

* Move docs changes to a separate PR

* Finish token-scale translation in the merged css modules

* Deflake dark mode toggle assertions in palette spec
2026-09-02 13:44:47 -07:00
Nathan Voxland
a55b6b6b8a Better handling of unparsable user settings (#78737) 2026-09-02 15:15:33 -05:00
Nathan Voxland
58819b5ea2 Pivot table download should respect currency formatting (#75969) 2026-09-02 14:23:06 -05:00
Tyler Plude
0c06e94821 [BOT-1838] Release JDBC savepoints when nested transactions OK (#77562)
* release JDBC savepoints when nested transactions succeed

* tighten inline comment

* pr feedback

* Release savepoints only when no later scope is still running
2026-09-02 12:09:44 -07:00
Andrei Simionescu
e34e6190c6 BOT-1927: gate audit-view chart queries behind a Run query button (#81215)
* BOT-1927: gate audit-view chart queries behind a Run query button

* Track the Run query click with useDisclosure instead of useState
2026-09-02 18:00:34 +00:00
github-automation-metabase
eeba22c5fe Tighten ratchets (#81805)
Co-authored-by: github-actions <github-actions@github.com>
2026-09-02 17:57:02 +00:00
Anna Tomka
a06e24c8bd GDGT-3104: Fix unreadable active tab count badge in dark theme (#81800)
Fix unreadable active tab count badge in dark theme (GDGT-3104)
2026-09-02 19:46:00 +02:00
Riley Thompson
af1c635d4e Fix sqlglot parse failure for ?::type placeholder casts (#81381)
* Fix sqlglot parse failure for ?::type placeholder casts (#81373)

With connection impersonation enabled, native queries are parsed by
sqlglot after template-variable substitution, when {{var}} has already
become a JDBC `?` placeholder. sqlglot's base tokenizer treats `?::` as
a single token (DuckDB's try-cast operator) in every dialect, and only
DuckDB's parser can consume it, so `{{var}}::date` -- a very common
pattern on Postgres/Redshift/Snowflake -- failed with "Unable to parse
native query".

Fix: before parsing in is_single_stmt_of_type, rewrite `?::` to `? ::`
(which sqlglot parses fine, emitting CAST(? AS type)). Occurrences are
located via the tokenizer's own QDCOLON tokens, so `?::` inside string
literals, dollar-quoted strings, and comments is left untouched, and
placeholder order is preserved in the re-emitted SQL. Multi-statement
rejection and the rest of the impersonation validation are unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XkBejATyUcaq2R74xFd5M1

* comments and tests

* Assert all placeholders survive; fix QDCOLON dialect guard (databricks, not duckdb)

Review feedback: the placeholder-cast test now asserts that every ? in the
input survives into the re-emitted SQL, not just that one does.

While adding duckdb coverage, it turned out the dialect guard in
_split_placeholder_casts named the wrong dialect: in sqlglot 28.6.0 the
?:: (QDCOLON) token is emitted by the *base* tokenizer but only
Databricks' parser consumes it (the expr?::type try-cast column
operator); duckdb's parser does not, so duckdb was still failing on
placeholder casts. The guard now skips databricks instead, duckdb gets
the same ?:: -> ? :: rewrite as everyone else, and tests cover both:
duckdb placeholder casts parse with placeholders preserved, and
databricks' native try-cast is left intact (re-emitted as TRY_CAST).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* clean up

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-09-02 13:42:38 -04:00
Chris Truter
30f9f25ba9 Refine kondo ratchet commands and prompts (#81776)
* Make ratchet shrinking explicit, and check it in one place

The ratchet test fixture ran `fix!` on every non-CI run, so `project-tests
ratchets` rewrote .clj-kondo/ratchets.edn in your working tree before
asserting against it. A check that edits what it checks leaves a diff nobody
asked for, in the file every PR conflicts over, and its only reachable
failure was a bug in the fixer that had just run.

Removing the auto-fix forces the dev/CI split to go too: a strict local test
that no longer tightens would fail on every branch that removes an ignore.
So over-budget is now the rule everywhere, and shrinking is only
`./bin/mage kondo-ratchets-shrink`, which the shrink workflow runs on master.

That left two implementations of nearly the same check. The babashka
`check-report` gains the justification finding — the one assertion the JVM
suite had that it lacked — so `./bin/mage kondo-ratchets` covers over-budget,
config over-budget, unjustified ignores, normalization and unknown linters on
its own. CI runs it instead of booting a JVM, and the five now-duplicated
in-repo assertions leave the test namespace, which drops from 6.2s to 0.8s
because it no longer walks the source tree.

Task names follow: check-kondo-ratchets (which nothing called) becomes
kondo-ratchets, fix-kondo-ratchets becomes kondo-ratchets-shrink, and the
merge task becomes private -kondo-ratchets-merge, since only the git merge
driver invokes it. bin/merge-kondo-ratchets keeps its name; installed merge
drivers point at it.

* Polish kondo ratchet guidance

* Prime the ratchet shrink workflow

Intentionally raise the :case-symbol-test budget from 1 to 2 without adding a suppression. The read-only check allows the unused budget; after this PR merges, the shrink workflow should restore it to 1 through a Tighten ratchets automation PR.

* Make the ratchet suite check the project

Keep the ratchet tooling unit tests in the backend suite, but make project-tests ratchets run the read-only repository check. Include it in the bare project-tests command so local project-level checks still validate the checked-in ratchet policy.

* List project-test suites once

* Address review findings on the ratchet check

check-report threw NPE on a ratchets map without :comment-exempt, while
tolerating a missing :ignore-counts or :config-counts. Default it, so the
three policy keys behave alike.

The run-project-ratchet-checks description and the step comment both still
described the old wiring. The check now runs alongside the backend checks,
which no longer include it, and "no JVM" is not quite true: resolving
clj-kondo on a cold cache shells out to the JDK prepare-backend installs.

* Warn about stale comment exemptions

The only check that a :comment-exempt entry is still needed was a local-only
test, which went vacuous when the dev and CI semantics were unified, so
nothing named a stale exemption any more. The check now reports one the way
it reports an :unlimited policy nobody uses: informational, never a failure,
since only the shrink workflow removes them.

* Say why the merge driver finds mage through its own path

The script runs against whatever repository holds the conflict, which is not
always the one it lives in -- the tests merge stages in a throwaway repo. A
relative bin/mage looks plausible and fails there, so record the reason.

* Stop wrapping two comments that did not need it

One fits on a single line once it says less. The other breaks at its sentence
boundary rather than mid-clause.

* Break the ratchets header on its sentences

Four sentences started mid-line and wrapped mid-clause, one of them trailing
"in the PR." onto a line of its own. Same words, one sentence per line.

* Keep comment exemptions until someone removes them

fix! dropped a :comment-exempt entry as soon as every ignore of its linter
carried a comment, or the last uncommented one was deleted -- so an exemption
could disappear as a side effect of unrelated work, and getting it back is a
change to defend in review.

An exemption records a decision about a linter, not a count, which is the
reason :unlimited policies are already kept at zero and only warned about.
Treat the two alike: the check and the shrinker name a stale exemption, and a
person deletes it.
2026-09-02 17:37:16 +00:00
Jakub Chodorowicz
89da67a9f3 Gdgt 3146 remap cypress maildev ports so they don't conflict with app maildev 2026-09-02 19:36:37 +02:00
Ben Grabow
ae10677d61 Use a single future for a batched feature check in tests (#81743)
Use a single future for a batched feature check when per-feature memoization is disabled
2026-09-02 11:31:48 -05:00
Ben Grabow
3bcaab2e3b Avoid has_any_column_privilege run on entire cluster (#81734)
* Avoid has_any_column_privilege run on entire cluster

* Ensure that privilege filter only lets through `true?` values
2026-09-02 11:29:54 -05:00
Nathan Voxland
2921ecdcf9 Fix image tile url tracking (#81371) 2026-09-02 11:23:22 -05:00
Kevin Kelleher
8819a72555 Prompt to reload after changing settings that update CSP (#80906)
* new domains settings page with reload on save

* review feedback

* better null safety
2026-09-02 15:05:07 +00:00
metamben
22e8ddba1f Return mongodb's collection in QP /native API response (#80918)
Fixes QUE2-822
2026-09-02 17:23:43 +03:00
metamben
8dbfef0fe6 Use the underlying nested field name (#81640)
Closes QUE2-834
Closes #81546
2026-09-02 17:22:55 +03:00
metamben
de7cedfeb6 Only set SQL Server instanceName when specified (#81595)
Closes QUE2-829
Closes 81270
2026-09-02 17:22:35 +03:00
Stas Gavrylov
5885d30ad0 GDGT-2486 Add elevation, radius, and spacing scale variables (#80481)
* GDGT-2486 Add elevation, radius, and spacing scale variables

* GDGT-2486 Remap scale tokens in files merged from master

* Address review

Review fixes for the GDGT-2486 scale migration:

- Revert double-shifted tokens from the merge-remap pass: it re-applied
  the old-to-new mapping to 22 files already remapped by the first pass,
  shifting spacing values one extra step (e.g. xl 24px -> xxl 32px).
- Fix codemod escapes where old key names kept their name but changed px:
  Modal default padding (lg->xl, 24px), MultiSelect radius (sm->xs, 6px),
  MetricSearchInput radius-sm, ThemeEditor PreviewPanel radius-md,
  ColumnInput theme.spacing.xs->xxs, ChartTypeSettings Space h props,
  TableRowForCacheableItem icon placeholder w (md->lg, 16px),
  ResizeHandle/ResizableBoxHandle grip h (xs->xxs, 4px).
- Pin Group/Stack default gap to "lg" (16px): Mantine's default is
  "md", which is 12px in the new scale (was 16px in the old scale).
- Allowlist the runtime-defined --mantine-spacing-xxs/-xxl and
  --mantine-radius-xxs CSS variables in find-never-defined-css-variables
  (fixes fe-lint CI).
- Add theme.unit.spec.ts covering the spacing/radius/shadow scales,
  dark-mode shadow set, whitelabel independence, and a guard asserting
  every scale-based component default resolves to a defined key.
- Derive Card/Paper story argTypes options from the real scale.
- Augment MantineThemeSizesOverride so the custom scale tokens appear in
  editor autocomplete for p/m/gap/radius/shadow props.
- Update the emotion-migrate and metabase-ui-component-from-figma skill
  token tables to the new scale (spacing/radius values, shadow tokens,
  snap tables).

* Update Loki Snapshots

* Address review: fix h/w style props missed by the scale codemod

The codemod did not remap height/width style props, so every bare h=/w=
scale-key value silently changed px with the new scale. Remap each to the
px-preserving key (xs 4px->xxs, md 16px->lg, lg 24px->xl, xl 32px->xxl):

- PaneHeader breadcrumb row h xl->xxl (32px, restores data studio
  pane header height)
- BrowseDatabases logo boxes h/w xl->xxl (32px)
- DatabaseConnectionStringField rows h lg->xl (24px)
- DatabaseEngineList logo Center h/w lg->xl (24px)
- Metabot chat chevron flexes h/w md->lg (16px)
- MetricsFilterPill h lg->xl (24px)
- DatasetNotebook divider h xs->xxs (4px)
- DataReference NodeList icon w md->lg (16px)
- transforms-python ResizableBoxHandle grip h xs->xxs (4px)

Audited: no remaining bare h/w/maw/mah/miw/mih old-key props whose px
changed (verified line-identical against master for every occurrence).

* Address review: fix bdrs and responsive-object size tokens missed by the codemod

Two more escape classes from the scale codemod, found by a full sweep of
every touched-token form (string style props, responsive objects, CSS
vars, theme accessors) with each line compared against master:

- bdrs style prop (border-radius): remapped px-preservingly at 69 sites
  in 58 files (xs 4px->xxs, sm 6px->xs, md 8px->sm). The codemod remapped
  radius= but not its style-prop alias bdrs.
- Responsive object values (e.g. p={{ base: "md", sm: "xl" }}): remapped
  the token VALUES at 9 sites in 6 files (base/sm/md breakpoint keys are
  untouched; only their spacing values shifted: md 16->lg, xl 32->xxl,
  xs 4->xxs).

Sweep result after fixes: zero remaining line-identical old-key token
references to spacing xs/md/lg/xl, radius xs/sm/md, or shadow xs/md in
any form. Intentional survivors unchanged: radius/shadow/bdrs "lg"
(disclosed broken-key-now-16px class), spacing/radius sm where the
px value did not change.

Verified: tsc, eslint (changed files), metabase/ui jest suite.

* Address review: fix remaining token escape forms (object props, braces props, style objects)

Final codemod escape classes from the exhaustive token sweep, all
remapped px-preservingly:

- Object-literal / default-parameter prop values (15 sites / 8 files):
  ItemList picker-item default containerProps pb xs->xxs (4px, the
  reported gap), FormFooter pt lg->xl, SlackSetup pt lg->xl,
  EmbeddingSecretKeyWidget mb xs->xxs, CreateDashboardForm labelProps
  mb xs->xxs x2, databases styles mb lg->xl, NotebookDataPicker
  menuDropdownProps mt xl->xxl, Banner story py md->lg
- Braces-wrapped string props: CloudSMTPConnectionCard p lg->xl (24px)
  and gap md->lg (16px), SettingsLdapForm mt xs->xxs,
  DashboardLeaveConfirmationModal mb lg->xl
- style-object CSS properties: DatasetNotebook borderRadius xs->xxs
- Ternary token values inside responsive objects: SummarizeStep gap
  md->lg (16px)

Sweep now returns zero real misses across every checked form: string
style props (incl. h/w/bdrs), braces props, responsive objects with
ternaries, object-literal/default-param props, style-object CSS props,
CSS var() references, theme.* accessors. Remaining grep hits are
untouched scales (lh, fz, size, breakpoints) or px-identical sm values.

* Address review: preserve Mantine spacing defaults exposed by Loki

* Update Loki Snapshots

* Address review: fix remaining scale regressions and visual guards

* Address review: make Loki update capture new references

* Update Loki Snapshots

* Address review: keep only targeted Loki references

* Address review: assign ticket component elevations

* Update Loki Snapshots

* Address review: tighten MonthPicker header spacing

* Address review: refine elevation visual stories

* Update Loki Snapshots

* Address review: keep renamed Menu Loki story selected

* Update Loki Snapshots

* Address review: preserve inherited Mantine defaults

* Address review: allow stock Mantine shadow tokens

* Address review: replace token audit test with ESLint rule

* Address review: drop unrelated whitespace-only dev/src changes

* Address review: use rem() in radius scale and rem docs

* Update Loki Snapshots

* GDGT-2486: Address PR comments

* GDGT-2486: Adjust negative tokens

* GDGT-2486: Address review findings

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-09-02 17:21:33 +03:00
Nicola Mometto
0b4bbf0427 Use a generic error message for the parameter-permission 403 (#81762) 2026-09-02 15:20:45 +01:00
lbrdnk
74e847104b Clean up the ai benchmark workflow (#80532)
* Clean up the ai-benchmark.yml

* Address review
2026-09-02 15:24:31 +02:00
Sébastien
bf5778bc50 Fix flaky embed parameters e2e by pre-accepting embedding terms (#81322)
Pre-accept embedding terms in embed parameters e2e setup
2026-09-02 14:53:32 +02:00
Kevin Kelleher
386fe3b12a Fix small Explorations UI issues (#81730)
fix comment badge line height, background color overflowing rounded borders
2026-09-02 08:37:41 -04:00
Andrei Simionescu
dc3f2134cb Move the Metabot model capability checks into the provider catalog (#81679)
* Move the Metabot model capability checks into the provider catalog
* Move the fast-mode proxy check into the Claude adapter
2026-09-02 12:10:51 +01:00
Jakub Chodorowicz
30be3958a2 Fix double-coercion in DOM distortions (#81672) 2026-09-02 11:18:06 +02:00
Andrei Simionescu
58ad1ba564 BOT-1033: Add box plot support to the metabot chart tools (#81198)
* BOT-1033: Add box plot support to the metabot chart tools

* BOT-1033: Narrow the chart-types docstring to the enums that derive from it
2026-09-02 10:03:13 +01:00
Sébastien
0da75ad4a3 Deflake the SQL default-parameters embed wizard test (#81759)
Wait for the preview query before asserting embed parameter results
2026-09-02 10:56:38 +02:00
Bartosz Rybacki
b3365881d0 Add brybacki to team and slack map (#81702) 2026-09-02 10:26:14 +02:00
Anna Tomka
663a04c231 chore: add annatomka as team member (#81713) 2026-09-02 10:03:21 +02:00
Kamil Mielnik
fc3927c030 Add core-frontend-gadget as codeowners of custom viz (#81333) 2026-09-02 14:27:49 +07:00
Sébastien
7a20107f87 Prefer the X-Metabase-Session header over the session cookie (#81165)
* Prefer the X-Metabase-Session header over the session cookie

* Don't fall back to the session cookie when the header is stale

* comment
2026-09-02 06:41:28 +02:00
Romeo Van Snick
577f242c41 Move the entities store into the metadata module and hide normalizr (#81290)
* Move the entities store into the metadata module and hide normalizr

* Record the moved schema file's import-time effect

* Describe what the metadata reducers do, not what they replaced

* Move the mirror's fixtures and slice-name helpers into the module (#81297)

* Move the mirror's fixtures and slice-name helpers into the module

* Build the QuestionSources fixture through the metadata store barrel

* Document why the metadata store is not a deletable mirror slice

* Trim the barrel and write-door comments
2026-09-02 10:46:02 +10:00
Nathan Voxland
de202b144a Create personal colection on user create (#78714) 2026-09-01 17:35:56 -05:00
dpsutton
9bf3b136af only derive site-url from authenticated superuser requests (#81130)
* only derive site-url from authenticated superuser requests

`maybe-set-site-url*` (global Ring middleware) derived `site-url` from request
headers whenever `(or (not (setup/has-user-setup)) superuser?)`. The left arm
needed no authenticated caller, so an unauthenticated request reaching the
instance before its first user was created could pin `site-url` from a forged
Host/Origin/X-Forwarded-Host header. Because the write is first-writer-wins and
setup never overwrites it, that attacker-chosen value survived setup and
poisoned every later auth/email link (notably password-reset URLs) for the life
of the instance.

Gate derivation on `superuser?` alone. `:is-superuser?` is already on the request
by the time this middleware runs (wrap-current-user-info is inner/earlier in the
onion), so an admin's own request still auto-derives `site-url` -- which happens
on the operator's next request after an interactive setup. An unauthenticated
pre-setup request now writes nothing; `site-url` simply stays unset (nil is
handled everywhere it's consumed, and a reset link built on nil is relative,
never attacker-controlled).

Deployments that provision headlessly, run multi-tenant, or never sign in as an
admin will otherwise sit at a nil site-url, so note in the setting's docs that
they should set MB_SITE_URL explicitly.

* Read Quartz job-data blobs through a class allow-list

Quartz persists job data, calendars, and BLOB triggers as serialized objects.
Metabase's job data is only ever EDN-shaped data (keywords, strings, numbers,
maps/sets/vectors) wrapped in Quartz's own JobDataMap/trigger classes, so when we
read it back we constrain deserialization to exactly those classes and decline
anything else.

Install a per-DB DriverDelegate (StdJDBCDelegate for H2/MySQL, PostgreSQLDelegate
for Postgres) that overrides getObjectFromBlob to read through a class allow-list
built from the plain-data classes job data consists of. This is scoped to
Quartz's own blob reads, so nothing else in the JVM is affected.

- metabase.util.deserialization-allowlist: a reusable, composable ObjectInputFilter
  allow-list. clojure-data-prefixes covers the EDN value space; callers add their
  own wrapper prefixes and read via read-object / read-object-bytes.
- metabase.task.secure-delegate: the allow-set (EDN + org.quartz.*), the blob-read
  bodies, and install!, wired into task.bootstrap. The gen-class delegates are
  AOT-compiled in the jar; from source they're compiled on demand so the class is
  loadable by name through the classloader Quartz uses. That runtime compile is
  fenced to source only (config/jar?): from a jar a missing class is a build error.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BjQcjQx7NPGr3Rpf6QaG4b

* Don't deserialize Java objects from H2 query results

Metabase reads scalar and collection values out of query results, never
serialized Java objects. Register a JavaObjectSerializer on the H2 driver so H2's
JAVA_OBJECT (de)serialization is declined rather than reconstructing arbitrary
classes from stored bytes. With that in place the ad hoc JAVA_OBJECT check in
read-column-thunk is redundant, so it's removed; read-column-thunk keeps its CLOB
handling. Ordinary values are unaffected.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BjQcjQx7NPGr3Rpf6QaG4b

* Strip internal keys from binning maps

Add :decode/api and :encode/serialize remove-internal-keys hooks to the
::binning schema so clients can't smuggle internal query-processor keys in
through a :binning map.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Strip internal keys from more client-submitted query maps

Extend the :decode/api / :encode/serialize remove-internal-keys hooks to the
::parameter, ::template-tag, ::constraints, ::middleware-options, and ::page
schemas so clients can't smuggle internal query-processor keys in through them.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Reformat strip-internal-keys-test doseq bindings

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test improvements and fix reflection warnings

* Validate HoneySQL idents at the app-DB compile step

Honey SQL renders an ident as bare, unquoted SQL in several positions --
a form head it doesn't recognize, an ORDER BY direction, a DDL modifier,
the function name of a `:%fn.arg` var -- so an ident reaching any of them
is raw SQL text. Hold every ident to a plain-identifier shape, with an
explicit allow-list for the keywords Honey SQL renders as fixed SQL of its
own (operators, DDL modifiers, column types, ORDER BY directions).

Also close two gaps found along the way: symbols walked past the `:raw` and
`:inline` gates, since Honey SQL resolves symbol heads and clause keys the
same as keywords; and `safe-value?` trusted any value shape it didn't
recognize, where it now enumerates the types bound as `?` parameters.

Query idents that were kebab-case are renamed in the SQL only -- the
Clojure keys they feed, including the `:metabase-user-id` request key, are
mapped back at the read site and unchanged for their consumers.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Allow the Postgres operators our drivers register globally

`metabase.driver.postgres` registers the PG JSON, array and regex operators
with `honey.sql/register-op!`, which makes them global -- and the app DB can
be Postgres, so app-DB queries reach for them too: the semantic-search
migration compiles a `[:->> ...]`. Add them, and a test that holds the
allow-list to every non-namespaced operator Honey SQL knows, so an upgrade
or a new registration can't silently leave one out.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Snake_case the remaining app-DB query idents

Four more sites the sweeps turned up, all renamed in the SQL only:

- `request/session.clj` selects the current user under the same kebab
  aliases the session middleware did, so it gets the same rename-at-the-read
  -site treatment.
- Search scorer names double as SQL aliases, and three of them are
  kebab-case. They also key the weights in `search.config` and name the
  scores the API returns, so the conversion happens at the one seam that
  writes and reads the alias, leaving the scorer name alone. The alias gains
  a `_score` suffix because `:view-count` and `:data-layer` are named after
  the very columns they read.
- The model alias registry in `api/common.clj` feeds
  `column-with-model-alias`, which assembles `alias.column` idents, so its
  six kebab aliases are snake_cased along with the literal uses in the
  in-place search engine.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Constrain embedded card parameter values by the locked parameters

A dashboard's parameter value lookups receive the values of the other
parameters as chain-filter constraints, so the values offered for an
enabled parameter are limited to the rows the locked ones select. The card
lookups had no constraint argument to receive them: `card-param-values`
bound the JWT's params, used them only to check the searched parameter was
enabled and not pinned, then resolved the parameter to a Field and returned
that Field's whole value list.

Give the card lookups the same constraint argument and pass the JWT's
locked values from the embed layer. The argument is optional, so the
authenticated and public routes keep their current behaviour.

`param-type->op` and `param-type->default-options` move from
`parameters.dashboard` to `parameters.params`, so both the dashboard and
card constraint builders can reach them.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Snake_case the app-DB query idents the guard rejects

CI caught `queries.models.query`, and a grep for the same shape found four
more sites the earlier sweeps had missed -- they were confined to the
app_db, collections, search and permissions modules. The aliases move to
snake_case in the SQL; where the keys they feed are confined to their own
namespace the readers move with them, and where they have to match a shape
from elsewhere they are renamed back at the read site:

- `queries.models.query` aliases so the app-DB branch matches the keys
  `lib.metadata/card` returns, so it renames rather than propagates.
- `cache.task.refresh-cache-configs` feeds its aliases through a nested
  subquery whose outer `:select` names them, so both levels move, along
  with the readers and the test's expectations.

Also widen `safe-parameter?`: a `query_hash` read back from H2 arrives as a
`java.sql.Blob` rather than a byte array, and the enumeration rejected it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Remove a scratch probe test

Committed by accident in the previous commit -- a throwaway namespace with
printlns, used while checking chain-filter behaviour.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Fix the locked-parameter constraints for previews and stale slugs

Three problems with the constraints the card parameter lookups build:

The preview routes passed the sanitized Card, whose `:parameters` has the
locked ones removed, so the constraints were always empty and a preview
offered wider value lists than the embed it previews. They now pass the
stored Card and take only `:embedding_params` from the token, which is what
the published routes already do.

`embedding_params` is keyed by slug and `:parameters` by id, and nothing
keeps them in sync; a locked slug naming no parameter produced no
constraint and widened the values rather than narrowing them. It is now
refused. `param-values-merged-params` refuses the same on dashboards, where
the slug otherwise became a nil key that the constraint builder dropped.

A locked value of `[]` reached the filter builder as a value rather than as
"no value", producing a `:=` clause with one argument.

The constraints also carry the parameter's own `:options` now, as the
dashboard builder does.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Allow a qualified argument in a :%fn.arg ident

`:%lower.metabase_field/name` renders `LOWER("metabase_field"."name")` --
Honey SQL splits the ident at the first `.` and formats what follows as
quoted entities, so a `/` there separates the parts of a qualified column
rather than landing in the SQL. Only the function name, which is rendered
unquoted, has to be a bare identifier.

The pattern rejected `/` anywhere after the `%`, which took the database
autocomplete endpoint with it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Snake_case more app-DB query idents, and allow the FOR UPDATE modifiers

Found by widening the search: the earlier grep looked for the alias and its
`:select` on one line, so it missed every alias sitting on a continuation
line -- which is most of them.

- `activity_feed`: the recent-views queries alias `database-name`,
  `initial-sync-status`, `entity-coll-id` and `moderated-status`. The keys
  are read only within their own namespace, which builds the API response
  from them under different names, so the readers move too.
- `xrays.automagic-dashboards`: `num-fields` and `list-like?` -- the latter
  loses its `?`, which no snake_case spelling keeps.
- `:skip-locked`, `:nowait` and `:no-wait` are lock modifiers Honey SQL
  matches by name in a `:for` clause, not idents it renders, so they join
  the allow-list rather than being rewritten.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Move the query-analyzer's readers to the renamed table id

`query-analyzer/tables-for-native` aliases its table id, and that alias was
snake_cased without moving one of its two readers: `used-tables` still asked
for `:table-id` and so silently collected nothing. Unlike the write side,
which the guard rejects outright, a reader left behind reads nil.

The `tables-for-native` redefs in the tests carried the old shape too, so
they asserted against a result the function no longer produces.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Revert the HoneySQL ident guard and the renames it required

The guard held every ident in an app-DB query to a plain-identifier shape,
which turned out to have a long tail: each release of it found more query
aliases to rename, and a rename that missed a reader failed silently rather
than loudly, since the reader simply got nil.

This reverts the guard along with every alias rename made to satisfy it,
leaving the parameter-value security fixes, which do not depend on it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Harden site-url derivation fix: fail-closed redirect check, discerning test

Follow-ups to gating site-url auto-derivation on authenticated superuser
requests.

- check-sso-redirect: fail closed when site-url is nil. Previously a nil
  site-url left our-host nil, so a redirect with a nil host but a non-nil
  scheme was non-relative yet matched (= nil nil) and passed -- an open
  redirect. Require a known host to match against: (and
  our-host (= (.getHost redirect) our-host)).

- misc-test: bind has-user-setup false in the non-superuser negative case.
  With has-user-setup true (the test-DB default) the old gate
  (or (not has-user-setup) superuser?) was already false for that request,
  so the test passed against the vulnerable code and distinguished nothing.

- misc: rewrite the SETTING SITE-URL block comment and the maybe-set-site-url
  docstring, which still described the removed behavior (site-url set on the
  initial setup request).

- system settings: drop the blank line in the site-url :doc (it made the new
  paragraph render as an indented code block in the generated env-var docs)
  and replace an em-dash with a comma.

* Read a card's parameters the way the rest of the code does

`card-param-constraints` read `:parameters` alone, but a native card can be
described entirely by its template tags and carry none -- which is how the
static embedding e2e fixture builds one. The locked slug then matched no
parameter and the lookup was refused. Use the same either/or source
`get-param-or-throw` uses a few lines above.

A parameter with no value constrains nothing whether or not it still
exists, so the existence check now runs after the empty-value guard rather
than before it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rQMWmi2o1WGSqK5DDZ99u

* Fix jar startup crash when the jar's directory contains a space

find-in-current-jar built a jar: URL by string-concatenating
get-jar-path, but get-jar-path returns the *decoded* filesystem path
(URL -> URI -> .getPath turns %20 back into a literal space). URL.toURI
then throws URISyntaxException on the raw space, killing startup while
loading bundled driver manifests.

Open the jar via the Path-based nio-fs helper instead — Paths don't
round-trip through URI encoding, so spaces are fine. This also stops
closing a filesystem out from under other consumers: the old code, on
FileSystemAlreadyExistsException, grabbed the provider's *cached*
filesystem and closed it in with-open; the Path-based overload creates
an independent uncached instance whose close affects only itself.

Verified against a jar in a spaced directory: the manifest URI is found
and slurpable, and a concurrently-open URI-cached filesystem for the
same jar stays open and registered.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Fpja4n6bzdCy4QufM49Hb

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
2026-09-01 17:14:27 -05:00
Denis Berezin
84223a0d4d Restyle Number and Trend dashboard cards (UXW-5128) (#81131)
* Restyle Number and Trend dashboard cards (UXW-5128)

* Adjust sizes and tooltips

* Adjust sizes, fix icon

* fix

* Fixes after merge

* Update Loki Snapshots

* Fix multiple comparisons

* Add link to card title, Implement query builder view

* Undo scalar dashcard ellipsis menu styling changes

* Design review fixes

* Fix e2e

* Fix e2e

* Review fixes

* Update Loki Snapshots

* fix

* Self review fixes

* Self review fixes

* Add a "Show comparison value" display setting to the Trend visualization (#81148)

* Add Show comparison value setting to the Trend visualization

* Address review comments

* Standardize ellipsis menu styling across all dashboard cards (#81405)

* Standardize dashboard card ellipsis menus

* Update Loki Snapshots

* Update Loki Snapshots

* Refine dashcard menu button props

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>

* Fix review comments

* Update Loki Snapshots

* Add more tests

* Add keyboard navigation

* Fix borders for dark theme

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
Co-authored-by: Anderson <anderson@metabase.com>
Co-authored-by: Anderson <ands.alves.nunes@gmail.com>
2026-09-02 01:11:13 +03:00
Chris Truter
e24150083f Report dynamic requires which linter cannot verify (#78082)
* Don't crash the modules require hook on dynamic requires

(requiring-resolve (:failing-test-var opts)) has no statically-known
namespace; unwrap-require now returns nil for such forms instead of
falling through, and both callers skip non-symbols. dev.clj has carried
a live :hook crash from this since the hook was added.

* Add a hook regression test for dynamic requiring-resolve

Covers the crash fix: dynamic arguments lint to nothing, static
cross-module violations still report. hooks.* test namespaces join the
outside-the-module-system prefix list.

* Fail closed on dynamic module requires

* Polish module require hook tests

* Assert module hook findings directly

* Document intentional dynamic module requires

* Update module linter ratchet
2026-09-01 21:51:21 +00:00
github-automation-metabase
70f9234106 Auto-update documentation for master (#81742)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-09-01 21:35:27 +00:00
Nathan Voxland
540817adfe Improve document read/write performance (#76018) 2026-09-01 16:19:58 -05:00
Chris Truter
7f73a7464c Add merge tool for ratchet conflicts (#81341)
* Add a manual kondo ratchet conflict merger

* Split kondo ratchet merge tests

* Document the ratchet conflict merger

* Simplify unlimited ratchet merge policy

* Simplify ratchet merger for final policy schema

* Resolve ratchet conflicts to the stricter policy

Concurrent policy changes now always resolve: the smaller budget wins, a
finite budget beats :unlimited, and a removed entry beats any budget.
Comment exemptions merge on their own. Every stage is read through
read-ratchets and shape-checked before a disabled stage decides the result.

bin/merge-kondo-ratchets reads the index stages by number, so a file
deleted on one side and changed on the other exits nonzero with nothing
staged, and both-sides-add merges against an empty base. It runs from any
directory in the repository and stages only .clj-kondo/ratchets.edn.

mage.merge-kondo-ratchets-test drives the script against real conflicts
in temporary repositories.

* Point the clojure-write skill at the ratchet merge resolver

* Reject malformed stages before merging ratchets

The shape checks move out of read-ratchets into validate-policies, and merge-ratchets runs them on every stage, so a stage with :config-counts [] or :comment-exempt [] is an error rather than an empty set of policies that the merge would read as removals.

* Cover unreadable stages in the merger tests

An empty file, two forms, or a non-map stage now fails the reader instead of merging as no policies; the script leaves such a conflict for a human and stages nothing.

* Reject a non-map ratchet stage before merging

A nil stage passed every field check because dissoc, keys, and the defaults all accept nil, so a malformed stage could merge as an empty set of policies.

* Reject non-keyword linter names

The merge keys on (str linter) and renders the same way, so a string, nil or
symbol name was rewritten as a keyword, collided with one, or produced a file
that no longer read back -- and the script still exited 0 saying it had staged
the merge. Also describe the two sides by git stage: "current" and "incoming"
are inverted during a rebase.

* Run each refused merge once in the tests

leaves-unresolved? and output each ran the script, so every refusal ran it twice
and the "changed nothing" assertion covered a different run from the one whose
message was checked. Read the merged policies with the EDN reader while here.

* Compare the conflicted file, not just its status

A conflicted path reports UU, DU or UD however its contents are rewritten, so
comparing git status alone did not show that a refused run left the file alone.

* Tighten merge-tool docstrings and the ratchet conflict docs

* Compare the index stages of a refused merge too

Porcelain status reports a conflicted path as DU/UU whatever its stages hold, so it alone does not show
that a refused run left the conflict alone. The stages carry each side's blob.

* Spell out the unmerged status codes

UU/DU/UD as bare shorthand assumes the reader knows git's porcelain codes for a conflicted path.

* Clarify the unmerged-state snapshot comment
2026-09-01 21:08:21 +00:00
Nathan Voxland
85f1e975a5 Ensure CSV strings show as strings in excel (#81258) 2026-09-01 15:50:56 -05:00
Chris Truter
bc0200ece0 Enforce and maintain ratchet policies (#81319)
* Add trusted master ratchet shrinker

* Retry ratchet shrink after concurrent master pushes

* Test the check-kondo-ratchets report

* Apply ratchet policy to the check report

* Add severity-based inline ratchet policies

* Update ratchet policy documentation

* Finalize ratchet policy enforcement

* Move seeded linters to bounded ratchets

* Simplify unlimited ratchet policies

* Finish ratchet CI integration

* Document unlimited ratchet policy values

* Keep ignore counts as the policy map

* Validate ratchet policy keys against known linters

Policy keys in .clj-kondo/ratchets.edn must name a clj-kondo built-in from the
pinned version, a linter configured under .clj-kondo/, or an allowlisted
external diagnostic. The check and the fixer fail with one error listing every
unknown name instead of counting it. Config budgets must be non-negative
integers.

Drop :unresolved-require, a linter that never existed, from the semantic-search
ignore and the ratchets file.

* Keep unlimited ratchet policies with no ignores left

An :unlimited entry in :ignore-counts records a decision about the linter, so
the fixer no longer drops it when its count reaches zero. The check and the
fixer print one sorted warning naming such entries; it never fails CI. Bounded
zero budgets are still dropped, and :comment-exempt is unchanged.

* Deliver ratchet shrinking through an automation PR

* Validate seeds and read only tracked kondo configs

The known-linter set now comes from git-tracked `.edn` files under
`.clj-kondo`, so the dependency configs `mage kondo` copies in locally
(gitignored, absent from a clean checkout) no longer make validation
depend on the machine. `--seed` is checked against the same set before
anything is written, and a hand-written bounded `0` with no ignores
left is reported when the fixer drops it.

* Reopen the ratchet automation PR after a close

The "already carries this result" skip now requires an open PR, so a
branch left behind by a PR closed without merging is overwritten and
gets a fresh PR instead of silencing every later run. The compare step
reads PR state with the default token under `pull-requests: read`.

* Let the ratchet automation PR approve and merge itself

Copies the backport recipe: github-actions[bot] approves the PR with the default token (a user cannot approve their own PR, and the automation user owns it), then the automation user enables squash auto-merge. The commit identity is the docs generator's, which merges with that one approval. A ratchets-only change no longer flips backend_all, so the PR waits on the Project tests job alone.

* Describe the self-merging ratchet automation PR

* Expect the ratchet check namespace in the project-test suites

* Read the ratchets file as exactly one map

An empty file, a non-map, or a trailing second form used to read as an empty policy set, which the merger would have staged as the removal of every budget. Tracked kondo configs missing from the worktree (unstaged deletions, sparse checkouts) are skipped instead of failing the scan.

* Skip the uberjar for a ratchets-only change

* Keep fork PRs away from the ratchet automation steps

The head-branch lookup matched any repository's branch of that name, so a fork PR could have reached the approval and auto-merge steps; only an open PR from this repository counts now. Approval and auto-merge key on the open PR rather than on whether the branch was pushed, so a run that failed after opening the PR is repaired by the next one.

* Look up the ratchet automation PR by owner-qualified head

gh pr list caps at 30 results and filtered forks client-side, so enough fork PRs on the same branch name could hide the real automation PR and make the create step fail. The REST head=owner:branch filter is applied server-side and matches only this repository's branch.

* Stop checkout credentials from overriding the automation push token

actions/checkout persists GITHUB_TOKEN as an Authorization header, which takes precedence over the token embedded in the push URL, so the force-push to the automation branch would be rejected.

* Tolerate config budget and exemption reductions in CI

CI already let inline counts fall below their budgets so the shrinker could record them after merge, but a lowered config budget or a stale comment exemption still needed an exact match, so two PRs that each removed a suppression could fail the second merge. Config counts now fail CI only when they grow, stale exemptions never fail CI, and check-kondo-ratchets reports config growth alongside inline growth. Local runs stay exact.

* Say what CI rejects without listing the cases

* Keep actionable ratchets bounded

* Exclude the ratchets file with one pattern

Path filters are OR-ed, so a separate "!.clj-kondo/ratchets.edn" entry matched
every path that was not that file: backend_all became true for every PR, and
no_source_code_changes could never be true. The exclusion has to live inside the
pattern, as modules/drivers does above.

* Arm auto-merge against a known commit

The approve and merge steps keyed on the PR number alone, so nothing had checked
what the fixed automation branch name currently holds. Both paths now record the
sha they pushed or compared, and auto-merge matches it. Also guard the job to
this repository, as the workflow it replaces did.

* Report ratchet validation failures without a stack dump

check read and validated the file, then read it again. Now it parses once and
catches inside, so read-ratchets, validate-linters! and scan all report the same
one-line message. Also: CI=false was truthy in the tests, seeding a recorded
linter with no ignores said "nothing to seed" while dropping its policy, and
lowered-counts rebuilt the seeded set per entry.

* Keep the drift message off stdout

The drifted path prints its findings and then exits; folding it into fail! added
a summary line that check-reports-empty-unlimited-test pins. Split the throw from
the print so only messages the run has not already shown are printed.

* Tighten ratchet docstrings and the generated header

* Guard against standalone negations in the path filters

The patterns in a filter are OR-ed, so a "!..." entry matches every path the other entries don't
instead of subtracting from them, and the filter is then always on. The ratchets exclusion is written
inside one pattern for that reason; this keeps the next one from being written the other way.

* Reuse the automation PR on its ratchet file alone

The extra check that master had not touched ratchets.edn since the branch was cut only bites when master
moved to a different value that shrinks back to the same result, since any change to the result is already
caught by comparing the file. Dropping it means only a shallow fetch of the branch tip is needed.

* Force-push the automation PR when it conflicts

A PR whose ratchet file already matches is otherwise left alone, and a conflict is the one thing that
state cannot clear on its own. Mergeability is computed lazily, so UNKNOWN is polled past and, if it
never resolves, left for the next run.

* Ask once whether the automation PR conflicts

Polling for a definitive answer bought nothing: the next push to master runs this again within the hour,
so a mergeability check still in flight can read as not conflicted and be settled then.

* Say what the reuse comparison is against

git diff FETCH_HEAD -- <path> reads as a commit-to-commit diff. It is against the working tree, which is
the only reason comparing the branch tip answers whether the PR still delivers the right file.

* Fix the circular Filter type alias

Record<string, Filter> is expanded eagerly, so naming it inside Filter's own definition trips TS2456. An
inline index signature is deferred and holds the same shape.

* Prove a ratchets-only change skips the backend filters

* Run the path-filter specs when the filters change

* Use gh CLI to approve ratchet PRs
2026-09-01 20:31:30 +00:00
Ben Grabow
b4f84f1736 Skip some connection validity checks in test (#81725) 2026-09-01 15:22:41 -05:00
Nathan Voxland
52ba78451d Added map-tile-server-allowed-networks setting (#81243) 2026-09-01 15:10:53 -05:00
Ben Grabow
8e4e18f6d5 Don't hit DWH server when no parameters are being set (#81727) 2026-09-01 14:57:28 -05:00
Chris Truter
3c5d1111d7 Run project checks in a separate job (#81318) 2026-09-01 19:37:54 +00:00
Jeff Bruemmer
af549487df docs - ai connections (#81617) 2026-09-01 19:32:12 +00:00
github-automation-metabase
9e2fa97aa1 Auto-update documentation for master (#81619)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-09-01 15:24:53 -04:00
github-automation-metabase
1d598c7af4 Update translations 2026-09-01 (#81668)
* Update translation sources 2026-09-01

* Update translations

---------

Co-authored-by: github-actions <github-actions@github.com>
2026-09-01 13:22:09 -06:00
Edward Paget
b244f3c7ca Give Quartz a dedicated app-db connection pool to prevent deadlocks (#72261)
* Reuse toucan2's current connection in Quartz to prevent deadlocks

When code inside a with-transaction or with-connection block triggers a
Quartz operation, Quartz would check out a new connection from the pool.
If the pool is saturated, this deadlocks the thread. Now the
ConnectionProvider checks for a bound toucan2 *current-connectable* and
reuses it via a non-closeable proxy that suppresses close/commit/rollback/
setAutoCommit, preventing interference with the outer transaction.

Closes UXW-307

* Address review comments

verify that asking for a connection while one is already bound via
t2.conn/*current-connectable* reuses the identical underlying connection
instead of checking out a new one. Plus fix an `if` that should be a
`when`.

* Revert Quartz connection-reuse proxy

Revert the non-closeable connection proxy that let Quartz reuse the
thread's bound toucan2 connection with close/commit/rollback/setAutoCommit
suppressed. Suppressing those methods breaks Quartz's data integrity:
JobStoreTX only releases its SELECT ... FOR UPDATE row locks on QRTZ_LOCKS
via commit/rollback, so the proxy either held the cluster lock for the
length of the outer transaction or, for autoCommit connections, defeated
the cluster mutex entirely, and made partial job-store writes
un-rollbackable.

The deadlock this was fixing (UXW-307) is addressed in the next commit by
giving Quartz its own connection pool instead.

* Give Quartz a dedicated app-db connection pool to prevent deadlocks

When code inside a with-transaction or with-connection block triggers a
Quartz operation, Quartz checks out a connection from the app-db pool. If
the pool is saturated, this deadlocks the thread (UXW-307). Fix it at the
root: Quartz now draws from its own small c3p0 pool, so job-store
operations never compete with application code for main-pool connections,
and Quartz keeps full control of its connections' transaction lifecycle.

- ApplicationDB now carries a quartz-data-source: a separate pool (max 5,
  min 1, configurable via MB_QUARTZ_MAX_CONNECTION_POOL_SIZE) when
  create-pool? is true, the raw data source otherwise. It inherits all the
  main pool's properties except sizing.
- mdb.connection/quartz-data-source exposes it behind the ApplicationDB
  read-write lock, re-exported via metabase.app-db.core.
- The Quartz ConnectionProvider draws from it; the tracing
  connection-interceptor hook is unchanged.
- Tests cover provider behavior (no reuse of the bound connection, not even
  wrapped), pool construction/sizing, lock-respecting acquisition, and a
  deterministic pool-of-1 deadlock regression test.

* Reject already-pooled data-sources for the dedicated Quartz pool

connection-pool-data-source returns an already-pooled data-source
as-is, so building the Quartz pool from one would silently hand Quartz
the main pool itself -- reintroducing the starvation deadlock the
dedicated pool exists to prevent. No current caller does this (the only
production :create-pool? true site uses the always-unpooled env-derived
data-source), but nothing stopped a future caller from doing it.

Fail fast instead: quartz-connection-pool-data-source now throws on
pooled input, and application-db documents that :create-pool? true
requires an unpooled data-source.

---------

Co-authored-by: John Swanson <john.swanson@metabase.com>
2026-09-01 12:09:11 -07:00
Chris Truter
3fd1f63cfc Refresh settings cache before reading LLM providers (#81714)
Refresh the settings cache before reading LLM provider connections

Provider connections all live in the one llm-providers setting, and settings
are cached in process, so an instance only learns about another instance's
edit when its cache next polls — once a minute.

Until then it answers a page load with a list that predates the edit, and it
decides whether an edit is allowed against that same list: a connection
another instance has just deleted still looks present, and the type it
belonged to still reports itself as connected, so a legitimate create is
refused.

Force the staleness check on the five endpoints that read the list. It costs
the one query that reads settings-last-updated, unless something has actually
changed.

This does not make the read-modify-write of the list atomic: two instances
editing different connections at the same moment still lose one of the two
edits. That needs a lock, and is left for its own change.
2026-09-01 20:08:03 +02:00
Egor Grushin
2459fe20ba Carry over picked schedule fields when the frequency changes (#80758)
* Carry over picked schedule fields when frequency changes (GDGT-3096)

* Drop redundant mid-frame test

* Hook normalizeScheduleValue to changeScheduleType

* TDD first

* reviewed

* reviewed

* reviewed

* reviewed

* reviewed

* reviewed

* reviewed

* reviewed

* reviewed
2026-09-01 18:52:23 +01:00
Nicola Mometto
0fec254d6d Compile the LIKE ESCAPE character as h2x/literal so driver inlining can't touch it (#81704)
With a driver bound, [:inline "!"] compiles through driver-specific
inline-value; MySQL emits the hex literal _utf8mb4 X'21', whose implicit
collation (utf8mb4's default, utf8mb4_0900_ai_ci) clashes with the
connection collation when MySQL aggregates collations for LIKE, failing
with 'Illegal mix of collations'. ::h2x/literal compiles through its own
registered formatter to a plain '!' on every dialect, which takes the
connection collation like the pattern parameter next to it.
2026-09-01 17:34:00 +00:00
Andrei Simionescu
ebad52172a Fix AdminSettingInput write race (#80737)
* Don't lose the last change to a setting when a save fails

* Drop a duplicated test title

* Drop the no-op catch on the write chain

* Replace the write queue with a pessimistic disabled state

* Extend the failed-save revert to select and radio inputs
2026-09-01 18:29:21 +01:00
Chris Truter
d7a519ab60 Stop timed-out mage commands and their descendants (#81463) 2026-09-01 19:20:43 +02:00
Riley Thompson
0e0e6ac82b Enforce single-statement impersonated queries on all sql-jdbc drivers (#81653)
* Enforce single-statement impersonated queries on all sql-jdbc drivers (SEC-1189)

Connection impersonation confines a non-admin's native queries to a restricted
DB role, which Metabase activates with a `SET ROLE` prefix. To stop a user from
appending `; SET ROLE <broader>` and climbing out of that role, impersonated
native queries must be a single statement. That guard
(`driver/validate-impersonated-query`) was only overridden for `:postgres` and
`:sqlserver`; every other impersonation-capable JDBC driver (MySQL, Snowflake,
ClickHouse, Starburst) inherited the no-op `:default` pass-through and ran the
stacked query verbatim. On MySQL a stacked `; SET ROLE ALL` activates every role
granted to the connection user, escaping the restricted role entirely.

Define `validate-impersonated-query` once at the `:sql-jdbc` floor so every
impersonation-supporting driver enforces the single-statement validation, and
remove the now-redundant per-driver `:postgres`/`:sqlserver` overrides.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XM9HwBRFsa3ptVAP7UWV14

* clean up

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-09-01 11:53:13 -04:00
Kevin Kelleher
4348d9373e Improve Card type usage (#81409)
* improve card type usage

* fix a few more Card type casts

* use same gate for visualize another way button as in getVisualizerInitialState so button doesn't silently do nothing
2026-09-01 15:49:36 +00:00
Michael Eby
3e094bd928 docs: reorganize line, bar, and area chart docs (#81108)
* docs: reorganize line, bar, and area chart docs

* Optimized 1 images, saved 199.4 KB (55.6% smaller)

* add content from learn bar chart and histograms articles

* edits from jeff

* remove learn article reference

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-09-01 10:54:36 -04:00
Ryan Laurie
880bb31835 Treat EoL dates as unsupported (#81639)
treat EoL dates as unsupported
2026-09-01 08:36:22 -06:00
Sébastien
698fd4f1ee Fix flaky terms acceptance in sdk iframe embed setup wizard (#80826) 2026-09-01 14:46:24 +02:00
Sébastien
4dda44859b Move embed wizard copy-event tracking test from Cypress to Jest (#80821) 2026-09-01 14:45:52 +02:00
Sébastien
bd7048574b Gate embedding-hub sandbox column-update test on stepper settling (#80808) 2026-09-01 14:45:18 +02:00
Sébastien
7c8d735d20 Deflake SDK target-collection data-picker test (#81558) 2026-09-01 14:44:45 +02:00
Alexander Polyankin
8b29969f1c Public settings cleanup (#81452)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-09-01 08:19:25 -04:00
Nicola Mometto
90b3db6dec Escape LIKE metacharacters in user-supplied search strings (#81161)
* Escape LIKE metacharacters in user-supplied search patterns (SEC-847)

Name the LIKE escape character explicitly so the escaping also holds on app DBs without a default one

Add h2x/like-substring and h2x/like-prefix and use them at every search sink

* Update in-place search filter tests for escaped LIKE patterns
2026-09-01 12:34:22 +01:00
Chris Truter
39ad1d5167 Keep ratchets off release branches (#81033) 2026-09-01 11:58:19 +02:00
Chris Truter
ba06454a57 Stabilize transform API tests with explicit native-query permissions (#81574)
Grant native create-queries explicitly in transform API tests

The transform API tests grant :perms/transforms explicitly but rely on the ambient db-level create-queries default (:query-builder-and-native) for the shared dataset DB.
That default is fragile: the native level only exists db-level, so any table-level create-queries row written for the group granularizes it down to :query-builder, and re-coalescing can never bring the native level back.
A target table synced by an async transform run during another test's snapshot-restore window leaves exactly such a row, and full-database-permission-for-user takes the most restrictive value across the DB.
When that happens, every test creating or running a native-query transform as a non-superuser 403s for the rest of the run while the MBQL-source tests keep passing (seen on the SQL Server 2022 driver job).

Replace the bare transforms grant with with-transform-db-perms!, which also grants db-level create-queries :query-builder-and-native.
A db-level set deletes every row of that perm type - leaked table rows included - so the grant repairs any polluted state for the test and the scoped restore puts the prior rows back afterwards.
2026-09-01 09:39:30 +00:00
Andrei Simionescu
a1059fff57 BOT-2018: Support Anthropic fast mode for Metabot (#80511)
Admins can turn on fast mode for Metabot when the selected Anthropic model offers it. A rejected fast request falls back to standard speed and holds it for five minutes, so the speed and the cache prefix stay put.
2026-09-01 10:16:58 +01:00
Andrei Simionescu
3d5011e100 BOT-1668: hide the MCP server URL when the MCP server is disabled (#81195) 2026-09-01 10:08:38 +01:00
Timofey Kachalov
08b90a304c Escape and anchor the www. strip in CSP host allowlist (#81182) 2026-09-01 12:06:14 +04:00
Timofey Kachalov
49af71fd44 Validate embedding-app-origins-interactive before it reaches headers (#81166) 2026-09-01 12:05:48 +04:00
Nathan Voxland
e34951e8b7 Improve quoting and literal handling (#80254) 2026-09-01 00:35:52 -05:00
Fraser
8d618a8620 Viz loading slot and small moves (#81625) 2026-09-01 10:56:10 +12:00
YB
72edd1917c Bump mariadb-java-client to 2.7.15 (#81456)
bump mariadb-java-client to 2.7.15
2026-09-01 06:51:56 +08:00
YB
bb4b24c65f Bump httpclient5 to 5.6.4 (#81556)
bump httpclient5 to 5.6.4
2026-09-01 06:45:52 +08:00
Alexander Polyankin
baa2f30a5d Model the request scheme as https/http/unknown (#81592) 2026-08-31 18:22:12 -04:00
Alexander Polyankin
2742202af1 Restrict :param_fields in public/embed endpoints to public Field columns and enabled parameters (#81383) 2026-08-31 18:17:31 -04:00
Romeo Van Snick
2bd8150f2c Give the metadata mirror an enforced public API at metabase/metadata/store (#81272) 2026-09-01 09:12:14 +12:00
Ben Grabow
bd77074097 Migrate H2 -> SQLite sample db even when we're in new-install mode (#81596) 2026-08-31 15:58:10 -05:00
Chris Truter
a93af09ff5 Bump the remaining Hive artifacts to 4.2.1 (#81508)
4.2.1 is published for eight more of the Hive pins in the hive-like driver,
so move them along with hive-common rather than leaving the family split
across two patch versions.

hive-jdbc, hive-service and hive-hplsql stay at 4.2.0 -- no 4.2.1 was
published for those three.
2026-08-31 20:45:01 +00:00
Phoomparin Mano
c5e99eb320 Refresh MCP Apps UI credentials before expiry (#81041)
* fix broken mcp apps authentication due to credentials being cached

* add server-side tool calls to mint ui capability tokens

* rename MCP Apps credential metadata key

* rely on server tools for MCP Apps credentials

* show MCP Apps host errors

* add a test that we do not break existing chats

* fix transient MCP UI credential refresh failures

* combine credential refresh into a single tool

* refactor: extract ui credential constants

* refactor: simplify to a single refresh tool in frontend

* refactor: cleanup

* refactor: simplify unit tests

* refactor: use retry utility

* refactor: remove unused session-id

* chore: copy changes

* chore: rename method to redact-ui-credential

* remove v2 resource prefix

* add test for redacting secret in trace

* Harden MCP UI credential refresh after review (#81454)

* Harden MCP UI credential refresh lifecycle

* Harden MCP UI credential backend contracts

* Accept compatible MCP App resource URIs

* refactor: extract mcp auth hooks and utilities

---------

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
2026-08-31 20:10:50 +00:00
Andrei Chernykh
4b8fca4eb0 Delete no-op resolutions entries (#81408) 2026-08-31 12:48:35 -07:00
Romeo Van Snick
0b035e3f44 Cut four of the common module's back-edges (#80052) 2026-09-01 07:40:16 +12:00
Chris Vandoodewaard
1b7226c27a Require job-level timeout-minutes in GitHub workflows (#80353)
* Add a lint check requiring job-level timeout-minutes in workflows

A job without `timeout-minutes` inherits GitHub's 6-hour default, so a hung
job burns six hours of runner time - and holds up everything queued behind it -
before anyone notices.

actionlint cannot enforce this: its rule set is compiled into the binary, and
`.github/actionlint.yaml` only accepts `self-hosted-runner`, `config-variables`,
and `paths`, the last of which suppresses findings rather than adding them. So
the rule lives in a small yq-based script instead.

It runs in the lint job next to actionlint, gated on the same workflow-file
filter and passed the same changed-file list, and emits `::error file=,line=::`
annotations. Jobs that call a reusable workflow are skipped, since GitHub
rejects `timeout-minutes` there.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Fold the actionlint path filter into the workflows filter

The `actionlint` filter matched exactly the same paths as `workflows`, and the
lint job was the only consumer of it. Drop the duplicate and point the actionlint
steps at `workflows` / `workflows_files`.

Also give lint.yml's own snowplow job a 10 minute timeout, so the workflow
passes the check it adds.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Stop yq shifting reported line numbers on files with header comments

yq slurps a leading comment block before parsing unless
--header-preprocess=false, so every line number it reported was short by the
size of that block. Five workflows start with a comment; on cache-warm.yml the
`warm` job was annotated at line 18 instead of 42.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Update .github/file-paths.yaml

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
2026-08-31 19:20:45 +00:00
dpsutton
fd707ac9a3 Cache parse-approved-origins to stop per-request Invalid-URL log spam (#81126)
`parse-approved-origins` runs on essentially every API response (via
`approved-origin?` in the security-headers middleware, and again in the MCP
origin check) and re-parses the whole CORS-origins allowlist each time. Any
entry that fails to parse -- e.g. a malformed `http://localhost:3000:*` saved
into the SDK/MCP origins setting -- hits `log/errorf "Invalid URL"` on every
request, producing bursts of identical errors around each dashboard load.

The allowlist strings are slow-moving globals, so LRU-cache the parse. Callers
pass a couple of distinct strings (the merged SDK+MCP allowlist, and the
MCP-only one), so a small LRU bound keeps both cached without either evicting
the other, while remaining bounded.


Claude-Session: https://claude.ai/code/session_01BjQcjQx7NPGr3Rpf6QaG4b

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-31 13:39:30 -05:00
Chris Truter
4f81af5691 Prevent missing search index tables from aborting caller transactions (#81573) 2026-08-31 20:33:20 +02:00
John Swanson
f2cef9e46c More clarity around revoking credentials when "base" entity is gone/deactivated (#80556)
* Fail closed when an OAuth token's client is gone

resolve-access-token looked up the access token, checked expiry, and read the
user id off the token row — but never consulted oauth_client. So an access
token kept authenticating even if the client had been deleted.

Require the token's client_id to still exist in oauth_client, using the
client_id already present in the fetched token data — one indexed lookup on the
bearer path, no schema change. A missing client now fails closed (401).

Tests:
- core-test: token resolves while its client exists, returns nil once the
  client row is deleted.
- session_oauth_test: register the referenced oauth_client so the bearer-bridge
  tests exercise the new client-existence check (previously they minted tokens
  against a client_id with no row).

* Revoke sessions and OAuth tokens on user deactivation

Add an `:event/user-credentials-revoked` event, emitted in the user
`before-update` hook when a user is deactivated, with two subscribers:

- session: delete the user's core_session rows
- oauth-server: mark the user's access and refresh tokens revoked_at

* Pin that an API key's lifecycle follows its synthetic user

An API key authenticates as its own synthetic user (api_key.user_id); the
creator_id column that records the admin who minted it is attribution only and
is never consulted at auth time. So deactivating that admin does not revoke the
key — which is the intended design: keys are org-level service credentials,
visible to and revocable by any admin from the API-key page, independent of who
created them. Revoke a key by deactivating its synthetic user
(DELETE /api/api-key/:id), not the human who minted it.

No behavior change. Add a regression test that pins this: a key survives its
creator's deactivation (200) but is revoked when its own synthetic user is
deactivated (401), so the two paths cannot be conflated by a future creator_id
join. The DELETE-endpoint revocation path is already covered by api-keys-work-e2e.

* Register the credentials-revoked topic in the events hierarchy

The events system validates topics against its own hierarchy in
metabase.events.hierarchy, not Clojure's global one, so the plain
derive calls left :event/user-credentials-revoked unregistered and
publish-event! threw a 500 whenever a user (or API key's synthetic
user) was deactivated. Use events/derive! like every other subscriber.
2026-08-31 11:29:45 -07:00
Chris Vandoodewaard
596e0c0f71 Fix for LTS tag causing minor release failure (#81038)
* filter lts versions when finding latest from tags

* always skip lts tag since it isn't valid for finding latest versions

* add guard for valid version to release-log

* add tests

* fix actionlint

* clean up/fix logic in release-log

* Keep returning the major version for rolling .x tags

getMajorVersionFromRef now recognizes v0.56.x / v0.51.2.x style tags in
addition to valid version strings, so only lts and non-version tags get
an empty string back.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-08-31 18:28:27 +00:00
Kevin Kelleher
8c3ea6f40b Remove Explorations dimension anchored blocks (#80554)
* remove dimension anchored blocks from FE

* Remove dimension-anchored blocks from the backend

Research-plan groups are now always a metric sliced by dimensions; the
dimension-anchored shape (one dimension slicing several metrics) is gone:

- add_research_groups: drop anchor/dimension_id/metric_ids, require metric_id
- remove_from_research_plan: members lose metric_ids; dimension_ids required
- research-groups validation: metric-only, anchor dispatch removed
- blocks-tree: no :type on nodes; "By <dimension>" headings and the
  same-name disambiguation machinery deleted
- BlockSelection/ExplorationBlockNode schemas lose :type; the
  exploration_block.type column is no longer written (left in place,
  nullable)
- explorations.selmer prompt rewritten for the single group shape

Legacy dimension-anchored rows keep rendering (as metric-headed blocks);
pinned by the new blocks_test regression test.

* more FE cleanup, fix tests

* Drop exploration_block.type column

---------

Co-authored-by: John Swanson <john.swanson@metabase.com>
Co-authored-by: Nathan Voxland <nathan@metabase.com>
2026-08-31 17:14:01 +00:00
bryan
72987c24bc Validate LDAP server certificates and normalize synced attributes (#81039) 2026-08-31 10:43:37 -06:00
Oleksandr Yakushev
105262e022 Bump Toucan2 to 1.0.575 (#81449) 2026-08-31 19:22:45 +03:00
Andrei Chernykh
883ff5c9ac Remove unused webpack deps, fix rspack invalidate path (#81390) 2026-08-31 09:20:25 -07:00
Andrei Chernykh
fa7e1e598a Remove json-to-pretty-yaml (#81085) 2026-08-31 09:11:28 -07:00
Andrei Chernykh
94f0aec2e9 Replace @cypress/skip-test with a local helper (#80947)
* Replace @cypress/skip-test with a local e2e helper

* Document --spec requirement in the e2e-test skill

* Tidy skip-test helper comments and skill doc wording
2026-08-31 09:08:47 -07:00
Chris Truter
2da893377b Fix the cancellation race in process-userland-query-test (#81560)
* Wait for the query to reach the reduce step before cancelling in cancel-test

cancel-test gave the query a fixed 100ms head start before future-cancel and
assumed it would be sleeping inside *reduce* by then. Only an interrupt that
lands inside *run*'s try posts ::cancel to the canceled channel, so whenever
pre-pipeline setup took longer than 100ms the future died silently during
setup and the test timed out waiting for the cancel message.

That made the test flaky under CI load and deterministically red when run in
isolation: on a fresh JVM the first query's setup takes seconds, so the
granular-rerun step (which re-runs only the failed test) could never pass it,
pinning any PR that flaked onto it. Synchronize on a promise delivered from
*reduce* instead of sleeping.

* Block on a latch instead of sleeping in *reduce*

The 1000ms sleep was a second timing assumption: the cancel had to arrive
within it or the reduce would complete and save the execution. Await a latch
nobody opens instead — the interrupt wakes it just like the sleep, with no
window to miss. The 30s timeout only bounds the worker thread if cancellation
is genuinely broken.

* Use a never-delivered promise and drop the dead *result* call

A promise is the same CountDownLatch under the hood (interrupt propagates
identically from deref) and matches the started promise next to it. The
*result* call after the block was unreachable on the happy path — the
interrupt throws out of the deref — and pointless on the timeout path, where
the test failed 28 seconds earlier.

* Collapse the port/val channel assertions into one

A timeout or closed channel takes nil, which fails against ::cancel on its
own — no need to name the winning port. Also fixes the doubled word in the
testing string.

* fix cancellation test cleanup race

* Clarify cancellation test scope

* Strengthen cancellation metadata assertion

* Polish cancellation test formatting
2026-08-31 17:49:57 +02:00
Mihael Konjević
e815f913d1 Update Metabot data-source guidance for stale references and curation signals (#78248)
Clean up stale, contradictory, and unreachable guidance in Metabot prompts and skills

- Remove references to tools/params that never existed (`search_tables`, `search_transforms`, `get_report_details`, doc-search tool, `collection_id`/`database_id` on search, `update_dashboard` mutations, `is_library_member`, dead `source_tables` param, duplicate Slackbot tool)
- Align per-profile guidance with actual tool wiring: SQL-only profile has no notebook/metric/chart tools, Slackbot has no `read_resource`, `construct_notebook_query` schema differs by profile, SQL query-link behavior differs by tool
- Fix `read_resource`: pagination bug (server now returns a ready-to-use `next-page-uri` instead of broken `?page=N` guidance), curation-signal comparison, container/document listing
- Fix a Selmer `{% safe %}` vs `{% verbatim %}` bug that silently blanked all `{{#model_id}}` examples in the SQL profile prompt
- Document previously-missing required arguments across several tools (`create/edit/replace_sql_query`, `edit_chart`, time-clause `unit`, etc.)
- Fix `document_schema_collect`'s unreachable stop instruction and missing `database_id`
- Fix `list_available_fields` fallback for saved questions
- Add regression tests locking in the template-rendering and pagination fixes
2026-08-31 17:45:35 +02:00
Mahatthana (Kelvin) Nomsawadi
63057ee485 Key guest embed tokens per instance instead of one shared slot (#81351)
* key guest embed tokens per instance instead of one shared slot

Concurrent guest StaticQuestion/StaticDashboard embeds under one
MetabaseProvider wrote into a single Redux rawToken slot, so the
last-mounted instance's token won for all of them. Key by a stable
per-mount instance id instead.

* refactor: name the guest token key mountId

instanceId read as the Metabase instance, and collided with
EnsureSingleInstance's own instanceId. Also simplify the two reducer
cases the fix rewrites, which Immer lets us assign into directly, and
drop a !mountId guard that currentToken already covers.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CkZ5rUUDeeWN9GU2wuEUHk

* test: drop the multi-dashboard guest token spec

It passed with the whole fix reverted to master: asserting each endpoint
was called at least once is already true there, because every mount's
first render uses its own token prop and only the re-render collides. The
name also implied multiple StaticDashboards work, which they never have —
they share one global state.dashboard slot.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CkZ5rUUDeeWN9GU2wuEUHk

* test: cover a guest refresh that switches resource

Every existing refresh case reissues a token for the same resource, so
none of them notice which token the component ends up using — PR #81240
flipped that precedence and CI stayed green. Switching to a question that
takes different parameters is what makes the choice observable.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CkZ5rUUDeeWN9GU2wuEUHk

* fix: drop a guest mount's token when it unmounts

The iframe embed route re-keys its children when the token changes, so a
parent-side token update remounts the component with a fresh mountId.
Nothing removed the old entry, so Object.keys(...)[0] in
getOrRefreshGuestSession kept picking the dead mount and every request
was rewritten with its stale token. Once that token expired, the refresh
wrote back to the same dead key, so the map never recovered.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016stkr2R8EEPxp5gbyqDjdR

* test: cover a guest remount with a new token

Mounts a guest question, re-keys it with a second token the way the
iframe route does, and asserts the query goes out with the new token.
Fails without the unmount cleanup: no request reaches the new token's
url at all.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016stkr2R8EEPxp5gbyqDjdR

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-31 15:21:19 +00:00
github-automation-metabase
38cc09d133 Auto-update documentation for master (#81576)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-08-31 11:03:40 -04:00
John Swanson
ba823a5488 Include every attribute remapping in the sandbox FieldValues fingerprint (#81040)
The per-user sandbox fingerprint (the advanced-FieldValues cache key, and
the sandbox component of data-access tokens) narrowed the hashed login
attributes to remappings whose dimension target resolved to a field of the
sandboxed table itself. But the query processor applies *every* attribute
remapping when it runs the sandboxed query, including ones targeting
columns of tables joined inside the sandbox card, or columns referenced by
name. Those remappings were silently dropped from the fingerprint, so two
users whose sandboxes differed only by such an attribute hashed to the
same field_values row and were served each other's cached values (and
could read each other's stored exploration results via the colliding
data-access token).

Fix: fingerprint every key in attribute_remappings, regardless of what
its target resolves to. This exactly mirrors the set of attributes the QP
consumes, keeps unrelated login-attribute changes from busting the cache,
and leaves hashes for own-table-only sandboxes (the common case)
unchanged. Existing colliding rows become unreachable under the new hash
and are reaped by the delete-expired-advanced-field-values sync job.

Fixes SEC-874.
2026-08-31 07:41:06 -07:00
Ben Grabow
b7d74aab6d Fix order-dependent transform permissions in tests (#81404)
* Small correctness and hardening fixes

A handful of independent, low-risk fixes bundled together — each too small to
ship on its own, each a behavior improvement that also closes a minor
hardening gap.

Reduce DB load / avoid unconditional work:
- Settings cache: a settings-last-updated cookie now triggers a cheap
  single-row staleness check and reloads only if the cache is genuinely
  behind, instead of unconditionally reloading the whole settings table.
  Exposes restore-cache-if-needed! with a :force-check? option as the shared
  "reload if actually stale" primitive the cookie path now uses.

Reduce log noise:
- CORS origin validation runs on every request's raw Origin header, so it now
  parses that client-supplied value with the silent try-parse-url rather than
  the variant that logs "Invalid URL" at ERROR — a malformed Origin no longer
  fills the operator's error log. Parsing behavior is otherwise identical, so
  no CORS allow/deny decision changes.

Correctness (case-insensitivity):
- forgot_password throttles on the lower-cased email, matching the
  case-insensitive account lookup, so User@x and user@x share one bucket
  rather than each getting a fresh allowance.

Add a missing throttle:
- PUT /api/user/:id/password throttles the old_password re-auth check, which
  previously had none, bringing it in line with the other credential
  endpoints.

* Set create queries permission explicitly for transforms tests

---------

Co-authored-by: dan sutton <dan@dpsutton.com>
2026-08-31 09:32:26 -05:00
Jeff Bruemmer
e8b8ad1a88 docs - script to generate page for supported AI providers (#81101) 2026-08-31 09:57:51 -04:00
Jeff Bruemmer
a1c217c51b docs - embedded ai chat updates (#80940)
* ai chat

* edits

* edits

* split

* revisions

Co-authored-by: Jeff Bruemmer <jeffbruemmer@gmail.com>

* revisions

* custom error image
2026-08-31 09:57:02 -04:00
Alexander Polyankin
629fd1fee0 Encrypt only settings that are secret or integrity-critical (#81506) 2026-08-31 09:37:14 -04:00
Chris Truter
f332a4e4b2 Stamp private ECR images with their Git commit (#81557) 2026-08-31 15:05:46 +02:00
Mihael Konjević
1c7ac88006 Respect sandboxing, impersonation, and routing in Metabot metadata (#80723)
* Withhold fingerprint statistics from row-restricted users in get_field_values/read_resource

Fingerprints were read from the shared Field row and refingerprinted on demand with no
restriction gating -- the same leak #436 fixed in llm/context.clj, left open here. Gate
both behind a fail-closed, per-database-batched row-restricted-table-ids check, resolving
each Field's owning table canonically rather than trusting caller-supplied metadata.

Also guard list_available_fields, viewing-context entity lookups, and typed-schemas
table/card selection against destination-database resources, and apply a missing
permission-filter-columns pass to card-details' FK targets.

* Widen LLM schema-context row-restriction handling to sandboxing and routing

row-restricted-user? only checked impersonation and failed open on a feature/license
lapse. Replace it with metabot's fail-closed row-restricted-table-ids, applied per table so
one restricted table doesn't blank out fingerprints for the whole response.

Also filter a table's own sandbox-restricted columns (previously only FK targets were),
constrain mentioned/FK-target tables to the requested database, add a database read-check,
and cap+log restricted-table field-values fetches per table.

* Cover destination-DB exclusion in typed schemas; quiet expected 404s in viewing context

Adds test coverage proving select-schema-cards/select-tables actually exclude
tables and cards backed by a destination (routed) database from typed-schema
generation -- the only guard on that path, previously unverified.

Also stops fetch-and-format logging every expected 404 (missing entity, or a
destination-db routing guard) at ERROR level; it now logs at DEBUG and still
falls back to the simple entity rendering, same as before.

* Quiet expected destination-DB 404s in get_metadata

safe-fetch was logging every fetch failure at error level, including
the routing-destination-database 404s from check-table-resource-database
/check-card-resource-database, which are an expected outcome rather
than a bug. Matches the debug-level treatment already given to the
same case in agent/user_context.clj.

* Style pass: trim design-rationale docstrings, shorten oversized fns, wrap long lines

- row-restricted-by-db: move the retry-ladder rationale out of the docstring and
  onto the try/catch lines it explains.
- permission-filter-columns: extract column-table-id/field-visible?/caller-joined?/
  referenced-field-visible?/column-visible? as top-level private fns instead of
  closures, bringing the function back under ~20 lines.
- build-schema-context: extract drop-or-enrich-fingerprints.
- Wrap a handful of lines pushed past 120 chars by the with-cache nesting and new
  test fixtures.

No behavior change; same 83 tests (315 assertions) still pass.

* Fail closed on unresolvable table IDs in row-restricted-table-ids

A table ID that couldn't be resolved to a Table row silently fell out
of the per-database restriction map and defaulted to unrestricted,
contradicting the fail-closed contract this function documents.

* Log restriction-probe failures in row-restricted-by-db

All three exception paths in row-restricted-by-db were silent, so an
impersonation/routing attribute failure left no trace of why every
fingerprint for a database fell back to the per-table restriction path.

* Handle unrecognized get_field_values data_source gracefully

mu/defn schemas aren't enforced in production, so an LLM-supplied
data_source could reach a case with no default clause and throw
uncaught, failing the whole tool call. Widen the case (and its schema)
to cover "question"/"report" like field-values already does, and give
both the permission-check case and field-values a graceful fallback
for anything else.

* Return an agent-facing 404 for a field-id with no resolvable table

check-column-table-perms! used api/check-404, which throws without
:agent-error?, so handle-agent-error rethrows it and fails the whole
tool call. This is reachable from ordinary stale result_metadata (a
dropped column, or serdes drift), not just a malicious input.

* Apply restricted-field-values cap after the eligibility filter

The per-table cap on restricted-table FieldValues fetches was applied
to raw columns before filtering to those that should have FieldValues,
so ineligible columns ahead of an eligible one in the raw list could
consume its slot in the budget and leave it without values. Filter
first, then cap -- grouping by the persisted Field's own table_id
while at it, consistent with the permission checks elsewhere in this
namespace.

* Move database read-check out of the extract-sources/generate-sql prelude

fetch-accessible-tables-with-columns required database read access
unconditionally, so /extract-sources hard-403'd even when a caller only
wanted its independent :card_ids behavior. generate-sql is the path
that needs the 403, so move the check there via build-schema-context
and leave get-tables-with-columns (extract-sources) to return an
empty result instead.

* Exclude destination-DB cards and fieldless models from answer-sources

get-metrics-and-models had no destination-database guard, so a card
backed by a destination (routed) database could still reach
list_available_data_sources -- the same gap already closed for
get_metadata. Also omit models whose :fields end up empty after
permission filtering (no view-data access to their table) instead of
listing them as data sources with nothing queryable.
2026-08-31 14:44:47 +02:00
Rodrigo López Dato
7d46650cad Don't use app DB pool to probe for initial connectivity (#81271)
Prevents app DB misconfigurations from timing out by failing immediately
2026-08-31 08:17:54 -03:00
YB
24f4aec505 Bump hive-common to 4.2.1 in the hive-like driver (#81460)
bump hive-common to 4.2.1 in the hive-like driver
2026-08-31 17:15:55 +08:00
YB
c839a31539 Pin reactor-core 3.8.7 in the Snowflake driver (#81462)
pin reactor-core 3.8.7 in the snowflake driver
2026-08-31 17:15:03 +08:00
YB
3866917fba Bump jsoup to 1.23.2 (#81457)
bump jsoup to 1.23.2 and pin it in the snowflake driver
2026-08-31 17:14:28 +08:00
YB
1866aaccd9 Bump sshd-core to 2.19.0 (#81461)
bump sshd-core to 2.19.0
2026-08-31 17:14:17 +08:00
YB
52fa5626a2 Bump httpclient5 to 5.6.3 (#81459)
bump httpclient5 to 5.6.3 and pin it in the clickhouse and databricks drivers
2026-08-31 17:14:05 +08:00
YB
ad47b4094b Bump Netty to 4.1.137.Final / 4.2.17.Final in driver deps (#81458)
bump netty to 4.1.137.final and 4.2.17.final in driver deps
2026-08-31 17:13:55 +08:00
Alexander Polyankin
d568f38f1a Encrypt plaintext values of encrypted-at-rest columns on startup (#81498) 2026-08-31 00:12:53 -04:00
Alexander Polyankin
0c54590106 Read settings without the cache while reconciling their encryption (#81491) 2026-08-30 23:02:41 -04:00
Alexander Polyankin
840faeb408 Reconcile settings encryption with the registry on every startup (#81478) 2026-08-30 21:38:46 -04:00
Alexander Polyankin
172bc22044 Name the source in strict-decrypt read failures (#81471) 2026-08-30 17:25:28 -04:00
Alexander Polyankin
c5878f2509 Encrypt legacy plaintext rows of :setter :none settings (#81464) 2026-08-30 15:25:34 -04:00
Ben Grabow
1e78c186c0 Improve log output in DWH GC job (#81447) 2026-08-29 04:05:59 +00:00
Alexander Polyankin
6b9bcaca8e Never encrypt the app DB on startup when there is existing data; add enable-encryption command (#81237) 2026-08-28 22:05:19 -04:00
John Swanson
418fbf1bf9 Treat API-key users consistently across user endpoints and attributes (#78976)
* Treat API-key users consistently across user endpoints and attributes

API keys are backed by rows in core_user with type = 'api-key'. Most
/api/user endpoints already restrict themselves to personal users, but
a few didn't, and user attributes were resolved for all user types.
Align everything on the rule that only personal users are managed via
/api/user and only personal users carry attributes:

- GET /api/user/:id and PUT /api/user/:id now 404 for non-personal
  users (API-key users and the internal user), matching the sibling
  endpoints (password, reactivate, password-reset-url, delete, modal)
  and the list endpoint's existing type = 'personal' filter. API keys
  are managed via /api/api-key instead.
- EE PUT /api/mt/user/:id/attributes now 404s for non-personal users.
- user/add-attributes only resolves attributes (tenant + jwt + login)
  for personal users; other types resolve to {}. Sandboxed queries run
  by a non-personal user therefore report a missing user attribute
  rather than reading attributes stored on the user row.

No migration: any pre-existing login_attributes on API-key rows are
left in place but no longer take effect. GET /api/user/current still
works for API-key authentication, with an unchanged response shape.

Scoped programmatic access as a first-class feature is tracked
separately in #72959.

* Provide a schema for `/api/user/current`

* Update kondo ratchet budgets

- :metabase/validate-defendpoint-has-response-schema 441 -> 440, since
  GET /api/user/current now has a response schema.
- :discouraged-var 100 -> 101 for the mt/with-temp ignore in the new
  sandboxing test: it creates a :model/User, which metadata providers
  do not support, matching the exception documented in the linter
  message and the file's existing ignores.

* CR resp - throw on missing `:type`
2026-08-28 15:41:39 -07:00
Ryan Laurie
7293988a96 dont refresh dynamic snowflake tables (#79846)
# Conflicts:
#	modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
2026-08-28 22:32:27 +00:00
Timofey Kachalov
e925a8df94 Temporarily disable Shoppy sample app tests (#81416) 2026-08-28 15:53:59 -06:00
Fraser
a0d5c5a0c7 Create the viz-core module (#80786) 2026-08-29 09:53:45 +12:00
Ryan Laurie
441cfa66ef Add Databricks Workspace Sharding (#81241)
* add env sharding for databricks

* follow the rules

* kick ci

* kick ci

* make the console output nicer
2026-08-28 15:15:46 -06:00
Timofey Kachalov
01add7e6e2 Fix per-table permission queries in db metadata endpoint (#81397) 2026-08-29 00:54:55 +04:00
appleby
e023152e90 Send finish-reason length for a Gemini MAX_TOKENS truncation (#80959)
* Send finish-reason length for a Gemini MAX_TOKENS truncation

Translate Gemini finishReason values to AI SDK v5 finish reasons and add them to the `:usage` chunk, as the other
adapters do. `MAX_TOKENS` now reports `:finish-reason "length"` instead of an in-stream error part, so the agent loop
stops cleanly and the client can offer to continue.

* Add missing image-related stop-reasons to gemini provider

The image related stop reasons should happen in practice since we only do text generation, but add them for
completeness.

https://docs.cloud.google.com/gemini-enterprise-agent-platform/reference/rest/v1/GenerateContentResponse#FinishReason

* Add stop-reasons from the Gemini Developer API as well

https://github.com/metabase/metabase/pull/80959#discussion_r3867216474
https://ai.google.dev/api/generate-content#FinishReason

* Review feedback: only add synthetic usage part for finish-reasons-without-error

* Review feedback: name the early-stop-without-error subset
2026-08-28 13:27:23 -07:00
Anderson
e9235e2983 Fix flaky remote-sync branch-switch e2e test (#80397)
* Deterministically gate remote-sync branch-switch test on its async boundaries

* Sign in before activating the token in the admin settings describe

* Wait for collection items responses before asserting synced content

* Reword test comments per writing conventions

* Trim comments and move timeouts to request/test-level options

* Remove test comments and restore waitForTask retries cap

* Fix H2 deadlock between the post-import search reindex and readers

* Additional cleanup

* Cover the in-task H2 reindex with a unit test

* Consolidate remote-sync e2e setup into a shared helper
2026-08-28 16:54:53 -03:00
appleby
5bf02e30d7 Support Anthropic partner models via the Google provider (#80133)
* Support Anthropic partner models via the Google provider

Anthropic models are served by `streamRawPredict` with an Anthropic Messages body, so route them through the new
`metabase.metabot.self.google.raw-predict` namespace, which wraps the existing claude adapter. Connecting probes the
model's own `streamRawPredict` route with an empty body: Google resolves the credential, project, location and model
from the URL before Anthropic sees the body, so an Anthropic-shaped 400 validates all four without spending a tokens.

* Title-case the Gemini model display names

To match the convention for all other providers and models.

* Translate mid-stream failures on the Google provider

`google-raw` handed back the SSE reducible unwrapped, so a failure while the agent loop consumed it escaped the
adapter untranslated and surfaced as a raw 500. Wrap it in `core/reducible-with-api-errors`, like every other adapter.

* Carry the probed model in :learned-config

We already reported `:probed-model` as sibling of `:learned-config`. Nest it inside so that it gets saved with the
learned config so we can use it for subsequent connection probes for the Google provider. This tends to be a much
better guess for what model we should use for the connection test rather than just using the first model in the fixed
models list, since there is no guarantee that model is actually present in the currently configured location.

* Probe a Google connection against the model it serves

The listing path re-probed whichever model the fixed catalog names first, so a connection at a location serving Claude
but not Gemini 3.x saved fine and then reported itself broken the moment its cache entry expired. Probe the model the
connection is known to serve instead — the one Metabot is pointed at, or the `:probed-model` its last successful probe
recorded — and fall back to the catalog's first model only when it has neither.

* Start the edit form on the model the connection was probed against

Reopening a connection while Metabot points elsewhere reset the Model picker to the type default and submitted that as
the probe target, so a Google project whose location serves Anthropic partner models but not Gemini had a no-op edit
rejected against credentials that work. Fall back to the connection's own probed-model, when the catalog still offers
it, before the type default.

* Ensure the obfuscated-value? regex matches values ending in newline

Enable "dotall" mode for the obfuscated-value? regex to support obfuscated values where one of the last two chars is a
newline. For example, the contents of JSON service account key used for Google cloud auth or similar.

https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/regex/Pattern.html#DOTALL

* Review feedback: validate-google-model!

* Review feedback: use proposed-model in vllm list-models

* Review feedback: ensure new-value is not an obfuscated-value? in set-single-provider-setting!

* Add comment about `model->family` dispatch

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

---------

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
2026-08-28 11:54:39 -07:00
John Swanson
cb7c71d1ba Allow embedding readable cards in documents without adhoc query-authoring perms (#80775)
Allow embedding readable cards in documents without query-authoring perms (UXW-5037)

Saving a document clones every embedded existing card into a document-owned
card row. The clone path ran check-run-permissions-for-query on the cloned
query, which for a native query demands create-queries=query-builder-and-native
on the whole database. A user who could view (and run) an existing native
question therefore could not save a document embedding it, losing their work
with a vague 403.

That check is an authoring gate, but the embedding user is not authoring a
query: the query text comes from an existing card row they passed a read
check on -- the client supplies only a card ID, never SQL. Running the clone
is still gated by the usual runtime permission checks (card read perms,
result-metadata view-data, block perms), which are the same checks that gate
running the source card, so cloning grants no new runtime capability. This
mirrors POST /api/card/:id/copy, which likewise clones a readable card
without an authoring check.

Split the documents-API card creation helper into create-card! (still
checked; used for client-supplied draft cards) and clone-card! (used when
cloning embedded cards and when copying a document's cards). Authoring a new
query -- via draft cards or by editing a cloned card's query through
PUT /api/card/:id -- still requires the appropriate query permissions.
2026-08-28 11:35:40 -07:00
Ben Grabow
2bfd318907 Dwh gc parallel (#81382)
* Bump timeout to 60 minutes

* Run redshift GC in parallel, with 1 worker per cluster node

* Run snowflake GC with N=8 parallelism

* Record dataset census before GC sweep

* Satisfy the linter
2026-08-28 13:27:49 -05:00
John Swanson
4c62275732 Hide all tenant groups/users from perms graph api (#74973)
* More consistently hide tenant users/groups

There were a few locations where we weren't correctly hiding the
existence of Tenant Groups such as "All Tenant Users" when the setting
was turned off. This also hides tenant *users* from the API surface.

* allow specifically showing tenant users

I realized that there was a possible regression in the last commit. We
were hiding tenant users across the board. This meant that a workflow
that was previously possible was not possible anymore:

- an admin turns off the tenant feature or disables tenants

- then the admin uses the API to reactivate some tenant users and turn
  them into internal users.

This is probably super niche anyway but it seems nicer to allow `GET
/api/user` to show these users, IF you pass the
`tenancy=external&status=all` flags.

Then you can reactivate the user and detach them from the tenant.

This is all API only so it's probably academic, but figured I'd keep the
door open.

* fix tests

* fix e2e tests

* Move tenant tests to enterprise tenant test namespaces

* Address review feedback on tenant-group hiding

- Rewrite hidden-tenant-group-ids to intersect the input IDs with all
  tenant-group PKs in memory instead of building an unbounded IN clause
- Return 404 from PUT/DELETE /api/permissions/group/:group-id for hidden
  tenant groups, matching GET /api/permissions/group/:id
- Assert GET /permissions/graph/group/:id succeeds when use-tenants is on
- Remove duplicate create-tenant-group-requires-use-tenants-test
2026-08-28 11:26:13 -07:00
John Swanson
2971a5b944 Strip client-supplied :card before hydrating in update-dashcards! (#73104)
`dashboard/update-dashcards!` calls `(params/dashcards->param-field-ids
(t2/hydrate new-dashcards :card))` to compute the field IDs referenced by
parameter mappings. `t2/hydrate` is a no-op when `:card` is already present
on a dashcard, so if the client `PUT`s `/api/dashboard/:id` with a dashcard
that includes a nested `:card` (the standard shape from `GET`), that object
is forwarded verbatim into `param-target->field-id`.

That function validates its `card` arg against `:metabase.queries.schema/card`
(added Oct 2025), which requires keywordized metadata (`:type/Category`,
`:source/table-defaults`, ...). After JSON round-trip through
`cy.request`, those values are strings, so the request 500s with
`Invalid input: {:result_metadata [{:semantic_type [...]}]}`.

`dissoc :card` before the hydrate call forces a fresh DB select with
properly-typed metadata, keeping the on-demand-DB field-value update path
unchanged.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-08-28 11:24:38 -07:00
dpsutton
439b8e2af5 Small correctness and hardening fixes (#81374)
A handful of independent, low-risk fixes bundled together — each too small to
ship on its own, each a behavior improvement that also closes a minor
hardening gap.

Reduce DB load / avoid unconditional work:
- Settings cache: a settings-last-updated cookie now triggers a cheap
  single-row staleness check and reloads only if the cache is genuinely
  behind, instead of unconditionally reloading the whole settings table.
  Exposes restore-cache-if-needed! with a :force-check? option as the shared
  "reload if actually stale" primitive the cookie path now uses.

Reduce log noise:
- CORS origin validation runs on every request's raw Origin header, so it now
  parses that client-supplied value with the silent try-parse-url rather than
  the variant that logs "Invalid URL" at ERROR — a malformed Origin no longer
  fills the operator's error log. Parsing behavior is otherwise identical, so
  no CORS allow/deny decision changes.

Correctness (case-insensitivity):
- forgot_password throttles on the lower-cased email, matching the
  case-insensitive account lookup, so User@x and user@x share one bucket
  rather than each getting a fresh allowance.

Add a missing throttle:
- PUT /api/user/:id/password throttles the old_password re-auth check, which
  previously had none, bringing it in line with the other credential
  endpoints.
2026-08-28 13:13:31 -05:00
Ben Grabow
8861e84d3f Cache clojure cli download (#81369) 2026-08-28 12:24:22 -05:00
Ben Grabow
0cad99631a Fix flaky query executions test (#81366)
* Flush other executions before test. Divert other executions during test.

* Flush after closing the batch ingress path.

* Remove extraneous changes

* Remove more extraneous changes
2026-08-28 12:04:12 -05:00
Nathan Voxland
393086c44a Don't allow reset password for deactivated accounts (#78699) 2026-08-28 11:32:14 -05:00
Ryan Laurie
7e3ab7a682 Cleanup data warehouses nightly (#79849)
* cleanup data warehouses nightly

* rename

* don't reinvent wheels

* simplify

* more

* cleanup

* updates

* Absorb failures at the redshift cluster level and at the driver level

* Extract old dataset name pattern

* Update ratchets

* Merge MB_REDSHIFT_TEST_HOSTS and MB_REDSHIFT_TEST_HOST when both are set

* Allow ad-hoc dispatch and report on outcomes of gc sweeps

* Don't run on forks

* Update ratchets

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Ben Grabow <ben.grabow@gmail.com>
2026-08-28 10:09:56 -05:00
Sébastien
e56d3de794 Wait for the content-translation dictionary in the SDK rerender spec (#81352) 2026-08-28 16:55:31 +02:00
github-automation-metabase
c06c3b8f16 Make isRenderedWithinViewport retry until element settles in viewport (#77401)
Make isRenderedWithinViewport retry until element settles in viewport

The command read getBoundingClientRect() once, so a caller asserting right
after a scroll-into-view action (focusing a recently moved dashboard filter)
could observe the element mid-scroll (top ~1647px vs 800px viewport) and fail.
Wrapping the geometry checks in .should() lets Cypress re-read the rect until
it lands within the viewport.
2026-08-28 16:19:42 +02:00
Nicola Mometto
190dcf1bd0 Compute longest common substring length with an iterative O(n*m) pass (#80985)
* Compute longest common substring length with an iterative O(n*m) pass

* Add perf edge-case tests for largest-common-subseq-length
2026-08-28 14:55:29 +01:00
Mihael Konjević
4fc305fa64 fix: recognize lib/*-stripped pMBQL in ->legacy-mbql, restore edit-chart's query-id (#78798)
* fix: recognize lib/*-stripped pMBQL in ->legacy-mbql, restore edit-chart's query-id

->legacy-mbql gated pMBQL->legacy conversion on :lib/type alone, so a query that
lost its :lib/* keys (e.g. round-tripped through the frontend's viewing context)
fell through unconverted. The raw pMBQL then got embedded in /question# links,
crashing the frontend with "Stage 0 does not exist". Detect pMBQL structurally
(:lib/type or :stages) and normalize against the query schema before converting.

Also add the query-id edit-chart's result was missing, so extract-charts can
capture edited charts into conversation state and chart->xml stops rendering
an empty query-id attribute.

* fix: preserve edit-chart's query in memory, don't fail turn on link conversion

edit-chart's result set :query-id without :query, so extract-charts (which
requires both to fire, then rebuilds :queries from :query alone) overwrote
the chart's real queries with [nil] on the next update-memory call.

->legacy-mbql could also throw instead of degrading: normalizing a
:lib/*-stripped query mints fresh :lib/uuids that don't match positional
aggregation/expression refs elsewhere in the query (e.g. an order-by on the
query's own aggregation), failing conversion inside the streaming transducer
and taking down the whole agent turn instead of just producing a bad link.
Falls back to the raw query on conversion failure now.

* fix: document ->legacy-mbql's conversion-failure fallback

Docstring claimed conversion always succeeds after normalize, but the
try/catch fallback added earlier can still return raw pMBQL when a
stripped query's positional refs don't resolve.

* test: mark edit-chart-result-survives-update-memory-test ^:parallel

Doesn't write shared state, same as the test above it.

* fix: thread edit-chart-tool's resolved query into edit-chart

edit-chart-tool falls back to current-queries-state when a chart's own
:queries is empty, but edit-chart only checked charts-state, so its
result carried :query-id with a nil :query in that case -- the same
[nil]-in-memory bug fixed earlier, via a different path. Pass the
caller's resolved query through as a fallback.

* fix: capture viewing-context charts' query-id, don't clobber on edit

chart-config->chart never set :query_id, so a chart seeded from viewing
context rendered query-id="" on edit and was never captured into :charts
state by extract-charts. Reuse the context-item id already shared with
:chart_id.

That capture also collided with edit-chart-tool's own memory write for
the same chart-id: extract-charts fully replaced the entry, dropping
:image_base_64/:timeline_events/:chart_config the tool had just written.
Merge onto the existing entry instead.

* fix: separate ->legacy-mbql's docstring from its bug history

Docstring for ->legacy-mbql read as the change's rationale (BOT-1604,
the :stages detection story) rather than the function's contract.
Trim the docstring to what a caller needs -- normalizes MBQL 5 to
legacy, passes through unchanged on failure -- and move the "why"
for the :stages guard down to an inline comment next to the check.
2026-08-28 15:10:46 +02:00
Stas Gavrylov
daf31c8bc3 Fix lint-eslint-pure warning noise in fresh worktrees (#81214)
Remove stale /* eslint-env node */ comments from frontend/build files

Flat config ignores eslint-env comments (ESLintEnvWarning per file, hard
errors as of ESLint v10), and they are redundant: eslint.config.mjs already
defines globals.node for frontend/build/**/*.js.
2026-08-28 16:08:27 +03:00
John Swanson
cfd6896c17 respect default time dimensions from list of dimensions (#79167)
* respect default time dimensions from list of dimensions

* Curate a default time dimension on the time-facet test fixture

Master's #79409 stopped auto-assigning a default dimension to new
metrics, so the time-facet tests' fixture card no longer gets a default
time dimension from dimension auto-sync. Since this branch makes the
curated default authoritative for the time-facet variant (no fallback to
the query's temporal breakout), curate the default explicitly on the
fixture.
2026-08-28 05:32:29 -07:00
YB
847666c6d1 [GDGT-2528] return an actionable error when an export target id does not exist (#80809)
return an actionable error when a serialization export target id does not exist
2026-08-28 20:27:13 +08:00
John Swanson
bb2b9786f3 Make register-listeners! idempotent, mirroring the queue-declaration fix (#80887)
The earlier fix (#80388) made *queue declarations* reload-safe by guarding
them with a load-time ownership claim and replace-on-reregister semantics,
but left the *listener* registry non-idempotent: register-listener! threw
"Listener already registered" whenever the channel was already present in
the root *listeners* atom.

Fix mirrors the queue side exactly: def-listener! now claims its channel's
declaration site at load time (claim-listener-declaration! — same-ns
re-claims are no-ops so reloads stay legal, cross-ns claims throw), and
activates through register-declared-listener!, which replaces any existing
registration instead of throwing. Ad-hoc batch-listen! keeps its strict
throw-on-duplicate contract (double-listen-throws-test et al.), since
runtime registrations have no load-time claim protecting them.
2026-08-28 05:01:03 -07:00
Romeo Van Snick
57ac36ff71 Match permissions URLs for databases without schemas (#81332) 2026-08-28 11:25:40 +00:00
Timofey Kachalov
8b42f49288 Normalize instance-origin matching when filtering data-app allowed_hosts (#81106) 2026-08-28 15:14:37 +04:00
YB
3ef8df323a Bump Bouncy Castle to 1.85.2 (#81287)
bump bouncy castle to 1.85.2
2026-08-28 18:44:37 +08:00
Alexander Polyankin
8b478a76ab Encrypt subscription/alert recipient details; enforce allow-list on send (#81227)
* Encrypt subscription/alert recipient details; enforce allow-list on send

Encrypt at rest the `details` column of `notification_recipient` and
`pulse_channel`, which stores external email recipients for alerts and
dashboard subscriptions, so plaintext values are rejected on the strict
read when an encryption key is configured. Register both columns in
`encrypted-string-columns` so `encrypt-db`/`decrypt-db` and key rotation
re-encrypt them, and add a v58 migration that encrypts existing rows and
decrypts them on rollback.

Also enforce `subscription-allowed-domains` at send time (previously only
on write): the notification send path calls `validate-email-handlers!`
before delivery and throws if any external recipient is not permitted by
the allow-list. The exception is re-thrown with a generic message so
recipient addresses are never written to the logs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Move the v58 pulse_channel encryption migration test into the v58 group

order-your-migration-tests-test requires migration tests to be grouped by
major version in ascending order; the new test had landed among the v48 tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-08-28 12:19:26 +02:00
Sébastien
ed6247eb24 Fix collapsed visualization in the dashboard new-question query builder (#81163) 2026-08-28 10:10:07 +02:00
Chris Truter
53a31166db Justify the grandfathered kondo ignores (#78168)
* Justify the :metabase/discourage-millis-duration ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :reduce-without-init ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :def-fn ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :unquote-not-syntax-quoted ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :aliased-namespace-symbol ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :equals-true ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :case-symbol-test ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :metabase/prefer-with-dynamic-fn-redefs ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :syntax ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :unused-binding ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :unused-private-var ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :unresolved-symbol ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :unused-excluded-var ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :unresolved-namespace ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :unresolved-require ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :unused-value ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :unused-alias ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :metabase/namespace-name ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :missing-docstring ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :metabase/defsetting-namespace ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :metabase/validate-deftest ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :missing-protocol-method ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :discouraged-java-method ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :clojure-lsp/unused-public-var ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :metabase/modules ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :metabase/test-helpers-use-non-thread-safe-functions ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the bare :clj-kondo/ignore forms

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :discouraged-namespace ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :deprecated-namespace ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :deprecated-var ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Justify the :discouraged-var ignores

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Correct inaccurate justification comments from review

Reword the overclaims the review round caught: 'every render path'
and 'every test-query feature' scoped to what the tests cover, the
'mutates nothing' datasource comments acknowledge lazy pool init, the
'only channel' store comments name the pending general-cached-value
migration, the ASCII-makes-default-locale-safe clauses dropped
(Turkish casing changes ASCII I), and the accidentally-justified
import-vars ignore in metabase.test gets a real comment. Contested
claims move to the uncertain list rather than guessing.

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Use Locale/US casing directly; drop the ignores it obsoletes

The review round was right that the circular-dep comments didn't
justify locale-sensitive casing: a Turkish default locale lowercases
ASCII I to a dotless i, mangling locale codes like "ID" and hiding
"Windows" from the os.name probe. Call .toLowerCase/.toUpperCase
with Locale/US at both sites, which removes the :discouraged-var
ignores entirely instead of excusing them. The logger comment now
states the real invariant: the notice reports logger reconfiguration
itself, so it can't go through log4j.

Claude-Session: https://claude.ai/code/session_01GParLfcfdFBwFrdzUWjGJN

* Correct remaining kondo justification comments

* Correct four justification comments from CodeRabbit review

* Correct the qp.store justification: the mbql5 shim reads the store too

* Complete kondo justification coverage

* Keep the named ignore forms while justifying them

The per-linter sweep was written when these sites still used the bare
`#_:clj-kondo/ignore`, so replaying it over the naming branch put the bare
form back under each new comment. Restore the linter vectors and rebuild
the budgets: :comment-exempt lands at 10, down from the 38 the mechanism
starts with.

* Justify the ignores master added under the exempted linters

The restack picked up new :deprecated-var and :clojure-lsp/unused-public-var
ignores from master. Left unjustified they would have re-exempted both linters,
undoing what this branch is for.

* Regenerate kondo ignore budgets after restacking onto master
2026-08-28 05:59:14 +00:00
Chris Truter
72d6cfe9cd Fail fast when a test loses its rollback boundary (#80994)
Fail the test when a rollback-only scope cannot roll back

Every top-level `with-temp` runs in a rollback-only transaction. If something
inside one commits -- DDL does that implicitly on H2 and MySQL, which also
destroys the savepoint -- the rows written up to that point are durable and
leak into every later test. Warning about it hides the leak until some
unrelated test counts rows and gets the wrong answer, and the six offending
sites found so far were caught exactly that way.

Throw instead when running tests. That covers every cause -- raw SQL DDL,
HoneySQL DDL, a savepoint lost to a deadlock -- where a guard on the SQL we
build would miss the raw statements `drop-table!` sends. Production keeps
warning and discarding what is still pending: there the transaction is a real
one that has already committed, and failing the request would not undo it.
2026-08-28 05:53:46 +00:00
technomancy
f9008f7884 Disable databricks JDBC driver's auto-retry. (#81231)
It sucks!

We will need to put our own error handling in place to do Actually
Good retries for 429s, but it's not clear yet where the best place for
that would be, because we're not getting stack traces from the 429s currently.
2026-08-28 00:05:28 -05:00
Romeo Van Snick
e6e11ee362 Write the metadata mirror from one listener, not 33 endpoint hookups (#81147)
* Write the metadata mirror from one listener, not 33 endpoint hookups

* Describe the hydration listener by what it does, not what it replaced

* Point the original_fields note at the listener, not onQueryStarted

* Pin the hydration listener to Api actions, and report a failed write
2026-08-28 13:16:41 +10:00
Romeo Van Snick
41cd2ab4f7 Name the chunks that lazy routes load (#80970) 2026-08-28 11:46:56 +10:00
Ben Grabow
f73eb6d00e Filter server-side when all target schemas are exactly named (#81250)
* Filter server-side when all target schemas are exactly named

* Blacklist metacharacters instead of whitelist word characters
2026-08-27 17:04:19 -07:00
Romeo Van Snick
21024ec984 Keep MCP node_modules out of the shared vendor chunk (#81157) 2026-08-28 09:40:04 +10:00
Fraser
a7815e9354 Give query_builder a store/ folder and an enforced public API (#79965) 2026-08-28 11:26:07 +12:00
Andrei Chernykh
e819ade161 bump dompurify to 3.4.14; removed from resolutions (#81228) 2026-08-27 15:19:20 -07:00
Nathan Voxland
0163ebfd7a Don't drop column order/visibility settings when one column no longer matches (#76088) 2026-08-27 16:18:30 -05:00
Cam Saul
27852dcc4c Resolve columns from model metadata saved in ~<=55 correctly (#75771)
* Resolve columns from model metadata saved in ~<=55 correctly

* Remove annoying :lib/options in stages and joins

* Test fix 🔧

* Code cleanup

* Comments

* Fix typo

* Revert pointless changes

* Try something different??

* Test fix 🔧

* Will disabling unneeded change fix e2e tests??

* Simplified fix 🔧

* PR Feedback

* cljfmt

* Test fix 🔧
2026-08-27 13:13:48 -07:00
Nathan Voxland
9eb4ce8524 Session Management (#80243) 2026-08-27 14:35:22 -05:00
github-automation-metabase
a9337e6046 Auto-update documentation for master (#81128)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-08-27 15:33:00 -04:00
John Swanson
96faa6d511 re-check read permission when listing bookmarks (#80774)
SEC-669: re-check read permission when listing bookmarks

GET /api/bookmark (bookmarks-for-user) filtered only on the target's
archived column and never re-checked read permission, so a bookmark kept
leaking a card/dashboard/collection/document/exploration's name,
description, and type after the user lost read access without the item
being archived (moved to a private collection, or a revoked/narrowed
collection grant).

Add a visible_collection_ids CTE (permissions only; archived filtering is
left to the existing where-conditions) and filter each bookmark branch by
collection visibility via visible-collection-filter-clause. Visibility is
evaluated for the passed user-id via a UserScope, so the function is
correct for any user, not only the current request's user.
2026-08-27 12:28:20 -07:00
Uladzimir Havenchyk
dff2fd94ce chore: replace lodash.orderby with inline function (#81160)
* chore: replace lodash.orderby with inline function

* drop deps

* fix eslint
2026-08-27 22:15:20 +03:00
Nathan Voxland
a25cc1f7be Improve oracle parsing (#80043) 2026-08-27 14:12:55 -05:00
Nathan Voxland
5c63c45970 Better error handling on result_metadata.settings (#80909) 2026-08-27 14:12:10 -05:00
Andrei Chernykh
cb3d067c6e Bump js-yaml to 4.3.1 (#81229) 2026-08-27 12:10:32 -07:00
Andrei Chernykh
3ac0958c50 Replace @sinonjs/fake-timers with a local Date mock (#80930) 2026-08-27 11:46:36 -07:00
Egor Grushin
05300912fb Radio component redesign (#80372)
* Redesign Radio

* Add Radio stories to loki filter

* disallow radio labelPosition

* use StoryBoard in radio stories

* add new story's snapshots

* Radio.Card: border, leftSection, migrate call sites

- card border 0.5px border-neutral-strong, none when disabled
- children disallowed, leftSection slot for icons
- EditUserStrategyModal + DataSegregationStrategyPicker on label/description

* update loki snapshots

* Icon color prop instead of css module in DataSegregationStrategyPicker

* remove extra div

* make the indicator in the radio card optional

* fixed radio size, no size prop

* radio card body via mantine text/stack

* forwardRef radio card

* radio card border: highlight when selected

* update loki snapshots

* drop size="xs" from radio call sites

* fix card growing on select, interactive card stories, optional checkbox card indicator

* skip interactive card stories in loki, update card snapshots
2026-08-27 19:35:48 +01:00
Riley Thompson
3ecdab5ea7 Test for mongo multi column aggregation on joined models (#81079)
* add test

* use test helpers

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018bfeq38ZBHxqfwJAgRaRH4

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-08-27 18:34:19 +00:00
Ben Grabow
d18a2df374 Fix flaky snowflake key sharing (#81197) 2026-08-27 17:33:41 +00:00
Chris Vandoodewaard
32ff8a7c7c paginate PR results for backport Slack reminder (#81216)
paginate PR results
2026-08-27 13:16:27 -04:00
Chris Truter
0be2972872 Make rollback-only app DB transactions actually roll back (#80065)
* Key cached session tokens on the app db

with-empty-h2-app-db! swaps in a different application database, and this cache was keyed on the username
alone. A token minted against the previous database names a session that does not exist in the new one, so
the request 401s, and the token minted inside leaks back out when the original is restored. The retry in
client-fn cleared the whole cache and tried again, which papered over it often enough to look like flake:
"Failed to authenticate X after three tries".

Key it on the app db as well, like every neighbouring cache does via memoize-for-application-db.

databases-list-can-upload-test and dismiss-spinner-test go from failing to passing; both were in the CI
failure list, the former across 12 jobs.

* Fix rollback-only app DB transaction semantics

* Reject rollback-only combinations that cannot roll back

- :nested-transaction-rule :ignore skips the savepoint :rollback-only needs, so the pair is rejected at any
  depth rather than silently committing
- a throw out of the transaction body now rolls the connection back explicitly, since restoring autocommit
  commits whatever is still open -- a requested rollback that failed was committing the work it had to discard
- the unsupported-options error names the options, and drops the "application database" framing that
  misattributed failures on other java.sql.Connections

* Restore transaction state even when the savepoint rollback throws

The callback accumulators are discarded unconditionally at the top of rollback!, so leaving the state
restore behind a throwing .rollback left the tree half-unwound: an outer scope that caught the error and
committed would run its before-commit callbacks against the failed nested scope's state.

* Create test-data Databases outside the caller's transaction

Their ids are memoized for the whole app db, so the Database has to outlive whatever scope first asked for
one. Created inside a test's rollback-only with-temp it is rolled back while the memo keeps its id, and every
later lookup hands out an id for a row that never existed.

do-outside-transaction is the same detachment run-after-commit-callbacks! already did privately.

* Don't cache a personal collection id created inside a transaction

The cache's premise is that a Personal Collection cannot be deleted, so its id never changes. A rollback
breaks that: the collection goes away and the cached id points at a row that never existed, which reads as
a 403 on every later request that resolves the user's personal collection.

* Skip the test-database cache in a transaction rather than detaching

Detaching made the Database durable but took a second connection while the caller's transaction was still
open. When that transaction holds cluster lock rows -- data_permissions and search index setup both take
them -- the second connection waits on them until the lock acquisition times out.

Bypassing the cache keeps the work on the caller's connection, and matches how the personal collection id
cache handles the same problem. do-outside-transaction goes with it, having no other callers.

* Stop the outer commit when a requested rollback failed

The full rollback only runs when this call turned autocommit off, so for a nested scope or a caller-managed
connection a failed rollback! just propagated. Code between there and the outermost scope can catch it, and
the commit branch would then commit the writes the caller asked to discard.

Mark the tree instead, and refuse to commit it. Throwing rather than quietly rolling back: the caller asked
to commit and cannot, and dropping the outer work silently trades one bug for a worse one.

* Tolerate a savepoint an outermost rollback-only can no longer roll back to

A statement in the body can commit the transaction under us -- DDL does that implicitly on H2 and MySQL --
which invalidates the savepoint. Those writes are durable by then, so failing the scope reports a problem
nobody can act on while leaving the data exactly where it was.

At the outermost scope, discard whatever is still pending and log where it happened. Nested scopes still
poison the tree and throw, since there the enclosing work is pending and must not be committed.

* Note the option of rejecting DDL inside a savepoint-bearing transaction

* Never commit a transaction whose rollback failed

Four review passes flagged the same hole from different angles. Restoring autocommit commits whatever is
still pending, and after a rollback we were relying on to discard those writes, that is exactly the work
we were told to throw away. Track it and leave autocommit off instead, letting the pool roll the
connection back on check-in.

Two narrower routes to the same place:

- rollback! now marks the tree itself, so an exception-driven rollback that fails poisons it too. Before,
  only a requested rollback did, and the error path could still reach a commit.
- the mark is rechecked after before-commit callbacks drain. A callback can catch a nested scope whose
  rollback failed, which lands after the earlier check has already passed.

Two tests changed meaning as a result: a nested scope whose rollback throws now stops the outer scope
committing, so it no longer completes and its own after-commit callbacks no longer run. That is the point
-- its writes are still there.

Also adds the regression test for personal collection id caching, models autocommit honestly in the mock
rather than pinning it true, and records what the in-transaction test-Database lookup gives up.

* Build the test-data Database before with-temp opens its transaction

Created inside a rollback-only scope it never survives, so it is rebuilt for every test, and the ids
memoized in metabase.test.data.impl outlive it. Cards then get inserted against table ids for rows that no
longer exist: FK_REPORT_CARD_REF_TABLE_ID on a fresh app db.

Materialise it before the transaction opens, where it can commit. The table and field lookup maps get the
same in-transaction bypass the Database id already had, for the case where a dataset is first asked for
inside a scope anyway -- neither is enough on its own.

Reproduce with a throwaway app db, which is what CI has and a local one does not:

  MB_DB_TYPE=h2 MB_DB_FILE=/tmp/fresh-$$ ./bin/test-agent :only '[metabase.queries.models.card-test]'

* Only pre-warm the dataset for the default driver

db-id resolves through the driver under test, so in a driver-test namespace the pre-warm reached for that
warehouse's dataset -- work a with-temp there may never need, against a warehouse that may not be up.
Driver failures went from 2 to 12 in the push that added it.

The FK problem it fixes is on the app-db side, for the default dataset, so confine it there. Best effort
even then: a dataset that cannot be built must not take an unrelated with-temp down with it.

* Evict temporary users from personal collection cache

* Evict the personal collection cache on the rollback, not on the user

Clearing the temp User's own entry misses the case that actually bites: a committed user's Personal
Collection is created lazily on its first permission check, which often lands inside somebody else's
with-temp. Nothing evicts it when that scope rolls back, and every later request for that user 403s.

Key off the with-temp boundary instead, and drop whatever it may have cached. Costs a re-lookup per user
afterwards; correct whichever user and whichever scope created the entry.

agent-api + activity-feed went from 21 failures to none.

* Skip the dataset pre-warm where the app db is deliberately empty

with-empty-h2-app-db! rebinds the app db, and the memo key includes its identifier, so the pre-warm missed
the cache and created a test-data Database inside a scope whose whole contract is emptiness.
databases-list-can-upload-test snapshots an empty Database set and saw two.

Bind *skip-dataset-prewarm?* there instead. Also drops the earlier :h2 restriction, which came from a bad
reading of two CI runs sampled at different completion stages: it could never have helped here, since those
helpers are H2, and it took the pre-warm away from driver tests that needed it.

Reproduce with a throwaway app db, which is what CI has and a local one does not:

  MB_DB_TYPE=h2 ./bin/test-agent :only '[metabase.queries.models.card-test]'

* Register the cache eviction with a unique key

metabase.test.redefs already holds `:around :default` on do-with-temp*, and methodical overwrites methods
sharing a key rather than composing them. Whichever namespace loaded last would win, silently dropping
either this eviction or the rollback-only transaction wrapper. It happened to work; it should not depend on
load order.

Also notes what a failed connection-level discard leaves behind. Only a caller-supplied connection is
exposed: on one we own, the same flag stops autocommit being restored, so the writes are never committed.
It logs rather than throws because throwing from that catch would mask the exception being unwound, and
master never attempted the discard at all, so a caller-supplied connection is no worse off than before.
Signalling it properly would mean telling the caller some other way.

* Note that session tokens are cached without regard for transactions

The user ids directly above skip the memo inside a transaction, since users created in a `with-temp` are
discarded with it. The token cache has no equivalent guard, so a session rolled back with its scope leaves a
token behind and the request fails with "Failed to authenticate X after three tries". The retry in
`client-fn` hides it more often than not.

* Note that a rollback can leave a stale personal collection id cached

"A Personal Collection cannot be deleted" does not hold for a transaction that rolls back. Tests evict on
the with-temp boundary; production has no equivalent and keeps the id for the rest of the TTL. Accepting
that for now -- it predates honoring :rollback-only, and closing it properly wants an after-rollback hook
alongside do-before-commit/do-after-commit.

* Follow the created-globally rename in the token cache TODO

* Build the query for export inside the guard, not beside it

`:query_json` already returns nil for a card whose query cannot be exported, but `lib/query` was called in the
argument position, outside `try-export-query`. A stored `dataset_query` with no stages builds a query that fails
its own output schema, so one such Card takes down every response that walks a set of Cards -- the typed-schemas
endpoint among them.

metabase.search.appdb.scoring-test alongside metabase.typed-schemas-rest.api-test goes from 13 failures to 0.

* Don't run a test request inside a rollback-only transaction

`user-request` takes a temporary Session when it is handed a User or an id rather than a `:rasta`-style keyword,
and the handler runs in-process on this thread. Now that the with-temp rolls back for real, every app db write
the request made is discarded when it returns -- the warehouse table writes survive on their own connection and
the API still answers 200, so the test sees a successful call that changed nothing.

Insert the Session and delete it in a `finally` instead. A caller already inside a transaction still gets the
same behaviour it always had; what goes away is the extra rollback scope around the request itself.

metabase-enterprise.action-v2.models.undo-test goes from 25 failures to 0, passing all 134 assertions, which
matches master.

* Mint the test users' sessions before anything opens a transaction

`authenticate!` ran about 150 times in a single `pulse.api.pulse-test` run, nearly always inside a transaction.
A session minted inside a `with-temp` is rolled back with the scope, the next request 401s, and the retry in
`client-fn` cleared the whole cache -- every user's token, not just the dead one -- so everyone re-authenticated
in-transaction and the cycle repeated. Each of those inserts bumps the user's `last_login` through the
`:model/Session` after-insert hook, which is what breaks a test that reads the creator before making its request.

Mint the four test users' sessions at initialization, where nothing has opened a transaction yet, so they are
durable. On a 401 forget only that user's token, so one temporary user's rolled-back session cannot evict them.

pulse.api.pulse-test goes from one failure to none, matching master. publish-refresh-error-event-sends-admin-email-test
passes too, where it fails standalone on master: that email only goes to admins with a `last_login`, and
crowberto's was rolled back with every login.

* Ask for the FieldValues the chain filter test needs

The full FieldValues row for `categories.name` is created lazily, and `update-field-values-for-table!` only
refreshes rows that already exist -- so a run that creates it inside a `with-temp` discards it and nothing
makes another. `select-one-pk` then returns nil and the test dies on "Not something with an ID".

Same shape as the rest of this branch: a durable row created on demand, now rolled back with the scope that
created it. Ask for the row instead of assuming an earlier test left one behind.

* Run the metric leaf queries one at a time inside a transaction

A transaction owns a single connection and `future` hands that binding to every thread it starts, so the
leaves' app db writes -- used-card stats behind a cluster lock, query rows -- interleave on one session.
Savepoints are per session: a thread rolling back to its own destroys the ones its siblings are holding, the
next release fails with "savepoint does not exist", and the transaction aborts, taking the rest of the test
with it. That is why api-arithmetic-test loses a different test on each CI run.

Only tests get here. A request runs in no transaction, where each future takes its own pooled connection and
the parallelism is worth having.

On a throwaway Postgres the namespace errors on two tests per run before this and passes three runs out of
three after.

* Commit a lock row that would otherwise roll back with the caller

A lock row is written once and read forever after, and acquisition leans on that: rival first-time inserters
block on the winner's uncommitted unique-index entry and retry once it commits. Inside a `with-temp` that
commit never comes, so the row is gone again and the next acquisition replays the race -- on MariaDB until the
lock-wait timeout expires.

Insert it on a connection of our own when the caller was already in a transaction, which is the only case
where the row would not survive. Nothing in production takes a cluster lock from inside another transaction,
so this leaves that path alone -- worth keeping that way, since lock names are dynamic in places and rows that
used to roll back with a failed transaction would otherwise persist.

Reasoning rather than measurement; the TODO on the function says so and says what to do if it does not help.

* Bound the out-of-band insert on its own connection

`set-query-timeout!` returns false on MySQL running MariaDB Connector/J, and the fallback sets
`innodb_lock_wait_timeout` on the session -- but `acquire-lock-row!` sets it on the caller's connection, not
the one the insert opens. Blocked by a rival's uncommitted row, the insert would then wait out the server
default instead of the second it was given, on exactly the databases this is meant to help.

Give it the same treatment on its own connection. Also note in the docstring that the second connection is
only taken until the row exists, which is what bounds the cost of holding two at once.

* Resolve the venues id before counting queries

The cache is fine; the query the test counts is its own `(mt/id :venues)`. Inside a transaction the test-data
id lookup deliberately skips its memo, so the call lands in the window that is supposed to see none.

* Keep the pre-warm out of app dbs that are meant to be empty

`with-empty-h2-app-db!` already opts out of the dataset pre-warm; the serialization test dbs and the
schema-migration ones never did. A `with-temp` inside them materialised the test-data Database, and an extract
then saw a Database no assertion expects -- serialization.v2.load-test/database-test wanted one and found two.

* Do not insert a lock row out of band outside tests

The claim in "Commit a lock row that would otherwise roll back with the caller" was wrong: production does take
cluster locks inside another transaction. `load-from-h2!` inserts Databases, and so takes the batch-permissions
locks, inside one big load transaction. Our fresh connection then blocked on a next-key gap lock the caller's
own SELECT ... FOR UPDATE was holding, and a thread cannot outwait itself -- it timed out, retried, and failed.
That is what broke dump-to-h2, load-from-h2 and rotate-encryption-key on MariaDB.

Gate the out-of-band insert on `config/is-test?`, which is the only place a transaction may never commit, so
production goes back to exactly what it did before. Keep a fallback for the same shape inside tests, where
`load-from-h2!` can block on itself just as readily: on a lock-wait timeout, insert on the caller's connection.

* Stop three card tests leaving rows behind

`updating-model-query-does-not-shift-metadata-overrides-test` had no cleanup at all, and
`create-card-with-type-and-dataset-test` opened a plain `t2/with-transaction` where its siblings pass
`{:rollback-only true}` -- so both committed cards with a `{}` dataset_query that every later test walking the
card table then had to survive. That leak is older than this branch; honoring the rollback is what makes the
second fix work.

`get-series-for-card-permission-test` read crowberto's personal collection with `select-one-pk`, and a nil
collection_id puts the card in the root collection, which rasta can read -- so the test quietly asserted 403
against a card that was never private. Ask for the collection instead.

* Truncate the heartbeat fixture times to milliseconds

Postgres stores microseconds, so a timestamp ending .7369995 comes back a millisecond above its own
millis-truncation and the assertion misses by one.

* Tolerate a card whose query will not parse when finding related entities

Nothing at the schema level stops a stored `dataset_query` being empty, and such a card simply has no
context-bearing forms. Without the guard one of them takes down the related-entities computation, and with it
every x-ray, for everyone else. Same treatment `card-details` already gives an unexportable query.

* Give the end-to-end schema test a Database of its own

The test asserts exactly which questions, metrics and models fall inside the test-data Database's scope, which
holds only as long as no other namespace commits a Card against that Database. Two such leaks have been fixed
on this branch already and there is at least one more; the assertion cannot be made safe by chasing them,
because any test added later can break it again.

Run it against a copy of the Database instead, so nothing else can write there.

A throwaway namespace that commits one Card on the test-data Database ahead of it reproduces the CI failure
exactly (core_test.clj:147) and passes with this change.

* Recognise the MySQL lock-wait timeout in the in-band fallback

`lock-wait-timed-out?` knew about `SQLTimeoutException` and our own `::acquisition-timeout` marker, but not
ER_LOCK_WAIT_TIMEOUT itself. The server raises that on its own schedule, so on MySQL and MariaDB -- the
databases the fallback exists for -- it could arrive as a plain `SQLException` and the fallback would not fire.
Check the code through the cause chain.

* Take the revisions with the cards

`with-model-cleanup` deletes rows directly, which skips the Card hook that would have removed the revisions
this test's POST and two PUTs create. Name Revision in the cleanup as well.

* Truncate once, and align the chain filter's temp values

The second `truncate-to` could not do anything the first had not.

* Create the test users before the related tests race for them

`user->id` skips its memo inside a transaction and creates the users there instead, so on this branch they roll
back with the scope and the next test makes them again. These tests are parallel and every one of them takes a
`with-temp` Card whose creator defaults to rasta, so several threads insert the same user at once and all but
one time out on the row lock. The namespace goes from three errors to none.

Also covers the guard in `related/definition`: a Card whose stored query will not parse contributes no
context-bearing forms, and a genuinely similar Card still outranks it.

* Cover the card whose query will not build

The guard in `card-details` had no test: a Card with a stage-less stored query answers without `:query_json`,
and the Card beside it in the same response is unaffected.

* Cover the batch path and the lock-wait code

The first version of the card test called `get-table-details` once per card, which cannot see the failure it
claims to cover -- the bug was that one bad card killed the whole `cards-details` seq the others were in. Go
through that seq instead. Removing the guard turns the test red at the same malli output error CI was showing,
which the per-card version did not.

Also cover `lock-wait-timed-out?`: MySQL's ER_LOCK_WAIT_TIMEOUT on its own and inside a cause chain, and any
other error still propagating rather than being taken for a timeout.

* Create the temp search index before the transaction, not inside it

`with-temp-index-table` runs CREATE TABLE and DROP TABLE on the ambient connection, and on H2 and MySQL that
commits the transaction around it. Six tests opened it inside a `with-temp`, so the rollback had nothing left
to take back and every row they created leaked -- a Transform, some Cards and Collections, a published Table, a
Document -- to any later test that walks the app db.

That one leaked Transform is the whole of the serialization failures: a collection-scoped export includes every
Transform in the instance, so all four tests came back with one entity more than they expected.

Take the index table before the `with-temp` instead. The nested scope reuses it, so nothing else moves.

`metabase-enterprise.search.scoring-test` also had no fixtures at all, and fails on its own: the first lazy
`initialize :db` fires mid-test and recreates the H2 database underneath a test already writing index
bookkeeping.

The 133 namespaces that run before serialization.api-test in the Enterprise job reproduce the CI failures
exactly -- 5011 assertions, 5 failures -- and pass with this, at 4714 assertions.

* Say the cluster lock comments plainly

Lead with the point rather than building up to it, and drop the clause chains. No behaviour change.

The TODO above `clear-cached-session-tokens!` was stale: it asked for the `created-globally` treatment, which
landed earlier on this branch. Point at what is actually left instead -- initialization can still first happen
inside a `with-temp`, and then the sessions roll back with it.

* Keep the non-index assertions where the app db cannot index

`with-temp-index-table` is a `when`, so wrapping a whole test in it skips the whole test on MySQL and MariaDB.
Two of the tests moved in the last commit also assert things that need no index, and those assertions went
quiet there. Add a sibling that runs the body either way, and use it for those two.

`search.appdb.scoring-test` had no initialization fixture, the same gap its enterprise counterpart had: the
first lazy `initialize` can recreate the H2 db underneath a test already writing index bookkeeping.

* Sort the fixtures require

* Download through the client that retries a 401

`downloaded-card-filenames-test` passed a raw cached token straight to `client-full-response`, so it skipped
the retry every other test gets from `client-fn`. A session rolled back with the scope that made it then came
back here as a bare 401, which is what the BigQuery job has been failing on.

`user-http-request-full-response` still returns the headers the test reads.

* Improve rollback test isolation and comments

* Do not poison the transaction tree when the savepoint is already gone

MySQL and MariaDB roll back the whole transaction to break a deadlock, discarding every savepoint with it. The
ROLLBACK TO SAVEPOINT that follows fails with "SAVEPOINT does not exist", and marking the tree rollback-required
there is backwards: the server has already discarded the writes, so nothing is pending for an enclosing scope to
commit by mistake. A rollback-only scope whose DDL committed implicitly already gets this treatment.

The refusal message named a rollback-only transaction, but the ordinary error path sets the flag too.

Also validate :nested-transaction-rule with a throw. It is a public option, and `assert` compiles away under
`*assert*` false. Sorting the unsupported keys keeps the message stable across runs.

* Keep the test request's session out of the login hooks

:model/Session's after-insert hook publishes :event/user-login, which stamps User.last_login, and
:event/user-joined for a User that has never logged in. Deleting the Session afterwards undoes neither, so every
user-http-request left both behind for whatever ran next.

Write the row instead. created_at has to come along, since the model supplied it.

* Ask whether the app db can hold the index, not whether any engine can

supports-index? is true for any active engine. With semantic search on MySQL or MariaDB, the macro that exists to
run the body without an app-db index took the app-db branch and tried to create the table anyway.

* Say something when a stored query is dropped

Both guards swallowed every exception silently, so a Card whose query failed to build for an unrelated reason
looked exactly like one that has no query. try-export-query, right next to the Metabot guard, already warns.

Related entities logs at debug: it runs for every candidate Card while ranking.

* Commit the out-of-band lock row rather than assume autocommit

The docstring said the row was committed, but nothing committed it -- the insert relied on the pooled connection
arriving in autocommit, which the pool does not promise. The caller's SELECT cannot find the row otherwise.

* Let a failed dataset pre-warm be heard

Now that the pre-warm runs for every driver, a warehouse that is down fails it on every top-level with-temp. At
debug that is invisible on a normal run and resurfaces much later as a Database that does not exist. Warn once
per message.

Also note that mt/id costs a query inside a transaction, which is what a with-call-count window has to plan for.

* Polish prewarm comments

* Mark the tree rollback-required even when the savepoint vanished

A vanished savepoint does not mean nothing is pending. DDL committing implicitly, or a server breaking a deadlock,
ends the transaction and discards the writes so far -- but anything written afterwards sits in a fresh transaction
and is still pending. Skipping the flag there let an enclosing scope swallow the rollback error and commit exactly
those writes.

Say so at the point of the catch, since the reasoning does not survive a quick read.

* Gate every app-db index helper on app-db support

with-temp-index-table and with-appdb-search-if-available-otherwise-legacy still asked supports-index?, which is
true for any active engine. With semantic search on MySQL or MariaDB they ran app-db DDL the app DB cannot take,
including from scopes nested inside the fallback body that exists to avoid exactly that.

Cover the borrowed session too: it must leave last_login empty, and delete itself afterwards.

* Cover the out-of-band lock row against a connection in a transaction

Hands the dedicated connection over with autocommit off and checks the row survives the caller's rollback. Without
the explicit commit the insert dies with the connection, and acquisition then fails on the row it just wrote.

Runs on MySQL and PostgreSQL only; H2 takes an in-process lock and writes no row.

* Pin the vanished-savepoint case against the outer commit

A savepoint the server already discarded says nothing about what was written after it. The existing rollback tests
throw generic exceptions, so nothing stopped the SQLState 3B001 / MySQL 1305 exemption from coming back.

* Pin the engine in the otherwise-legacy fallback

Where the app DB cannot hold an index, the fallback took whatever default engine was active. Semantic can be
active there, and the bodies are written for an index the app DB does not have. Run them under legacy search, as
the macro's name says. with-legacy-search moves above its first use.

* Polish rollback and search comments

* Stop two remapping scopes deadlocking on MySQL and MariaDB

A remapping writes a Dimension for a Field the whole suite shares, and holds it until its scope ends. Two threads
doing that at once deadlock on the unique index over dimension.field_id: each holds the record lock the other's
uniqueness check wants, while asking for the insert-intention gap in front of it. MySQL and MariaDB pick a victim
and roll it back, which drops its savepoints, so the rollback that follows fails on a savepoint that is gone.

Serialise remapping scopes against each other. Tests that never remap keep running in parallel alongside them.

The helper already carried a TODO saying it was not thread-safe.

Reproduced on MariaDB 12.3 and confirmed on master, so this predates the branch. custom-values-test failed nearly
every run before, and three runs in a row are clean after. Verified on H2 as well.

* Serialise every temporary Dimension, not just remapping scopes

Remapping is not the only way a test writes a Dimension for a shared Field: card-test, card/metadata-test,
field-values-test and data-studio's table-test all create them directly, in parallel, on the Orders and Products
fields. Those still raced with the remapping scopes.

Move the lock to `do-with-temp*` for :model/Dimension so every site is covered, including ones added later.
`locking` is reentrant, so a `with-temp` holding several Dimensions still works.

* Take the search index out of six more with-temp transactions

Same fix as the earlier pass over the search tests, for the ones that pass a warehouse driver: their index scope
sits inside `with-temp`, so `drop-table!` runs DDL on the ambient connection. H2 and MySQL commit the transaction
to do it, which makes the temporary Transforms durable and destroys the savepoint. The rollback that follows can
no longer take them back, and it discards toucan's compensating deletes along with everything else still pending,
so the Transforms outlive the test.

Three tests later in the same namespace count transforms and saw the strays: root-collection-items-include-
transforms-test expected one and found four.

These were missed the first time because `mt/normal-drivers-with-feature :transforms/table` skips them on H2, so
only a driver run reaches them.

Reproduced with a MariaDB warehouse: transform-test went 3 failures to 0, and the four namespaces that failed
together now match master at 2532 assertions. H2 is unchanged at 109.

* Let the failed-rollback warning reach the console

The shared Console appender only accepts FATAL, so the warning naming a rollback-only scope that could not roll
back went to logs/test-log.json and nowhere a CI run gets read. It took hours to find six tests leaking rows
because of it; the warning had been firing the whole time.

Give that logger an appender that accepts WARN. The message carries the mb-test key, so it names the test that
broke its own isolation rather than the later one that trips over the rows.

* Hoist the search index scope above with-temp in two document search tests

Both tests opened `with-appdb-search-and-legacy-search` inside `mt/with-temp`.
That scope creates and drops the index table on the ambient connection, and on H2
and MySQL the DDL commits the transaction `with-temp` meant to roll back, so the
temp Documents leaked into later tests.

Found by the throw this branch adds: both showed up as errors at connection.clj:293
in the app DB test jobs.

* Serialize the reduced-fields card test

It holds a rollback-only savepoint across two `with-temp` Cards and an API call. Run in parallel, something else
commits the transaction that savepoint lives in, so both Cards are discarded and the downstream query reports its
source Card as missing.

Only MySQL surfaces it, and only under a full suite: the test passes on its own, and six local configurations could
not reproduce it. Confirmed by running the MySQL and MariaDB driver jobs with this single change -- all four green,
against four runs where they failed.

* Materialize the test users' Personal Collections before with-temp opens

`user->personal-collection` is a get-or-create and sits on the permissions path every API request takes. A
namespace that does not initialize `:test-users-personal-collections` creates Lucky's the first time a request
calculates permissions -- which happens inside a `with-temp` -- so the transaction rolls it back. Every later
request tries to create it again, and the parallel ones time out on each other's COLLECTION table lock:

  GET /api/database expected a status code of 200, got 500.
  Timeout trying to lock table; INSERT INTO COLLECTION (..., "Lucky Pigeon's Personal Collection", ...)

That is what failed `databases-list-include-saved-questions-test` on the Mongo, Redshift and Athena jobs -- the
empty database list was the 500, not a visibility problem.

Prewarm them next to the dataset, under the same skip flag, so helpers that need an empty app DB are unaffected.
This also closes the related hole where `:test-users` itself first initializes inside `with-temp`, since that
component initializes it.

Confirmed on the Mongo driver jobs: MongoDB Latest went from failing to green.

* Update the test-user session note now that initialization is prewarmed
2026-08-27 19:05:06 +02:00
bryan
13dde0bba3 Reject unneeded connection properties in SQL-JDBC additional-options (#81097) 2026-08-27 10:29:18 -06:00
Nathan Voxland
c24f084ae6 Improve SVG handling (#80249) 2026-08-27 11:25:08 -05:00
Andrei Chernykh
e1fbadec0b Remove unused raf dependency (#80931) 2026-08-27 09:17:21 -07:00
Andrei Chernykh
ad48fed046 Remove the direct reselect usage and dependency (#81034) 2026-08-27 09:16:17 -07:00
Andrei Chernykh
7c08b5d95c Remove cypress-each (#81086) 2026-08-27 09:15:55 -07:00
Andrei Chernykh
25ed6aac2b Swap merge-refs for Mantine's mergeRefs (#81104) 2026-08-27 09:15:15 -07:00
Andrei Chernykh
5c169f142a Replace react-innertext with a local helper (#81105) 2026-08-27 09:14:44 -07:00
Chris Truter
42cf92479a Ratchet config-level kondo suppressions too (#78217)
* Ratchet config-level kondo suppressions too

:config-counts in ratchets.edn tracks, per linter, the :off switches and
:exclude entries in .clj-kondo/config.edn (top-level and per ns-group).
Only weakening counts: adding discouragements or turning a linter on is
free. Lowering works like the inline budgets; raising is a hand edit.

* Count every excluded item and :config-in-comment in the config ratchet

Map-shaped :exclude values with vector entries counted as one suppression
({compojure.core [GET DELETE POST PUT]} is 4, not 1), and the
:config-in-comment :off switch wasn't aggregated at all, so both could
grow without tripping CI. Reseeded.

* Count :config-in-call suppressions, and self-heal on config.edn

`:config-in-call` is a scoped `:linters` map like `:config-in-ns`, so a
linter switched off inside one was invisible to the ratchet. Both scopes
now fold into the same count.

The self-heal workflow only watched Clojure sources, which was right while
budgets came from inline ignores alone. Now that `.clj-kondo/config.edn`
feeds `:config-counts`, removing a suppression there can leave a budget
stale with no way to trigger the fix.

* Count scoped :off suppressions at any nesting depth

Linter scopes nest more than one level: :discouraged-java-method keys by
class and then by method. Counting only the first level meant an :off one
map further down waived a warning the ratchet never saw. No budget moves --
the repo's only two-deep entry is a :level :error discouragement.

* Regenerate kondo ignore budgets after restacking onto master
2026-08-27 17:40:39 +02:00
Kevin Kelleher
fc487f06c9 Explorations summary document (#78848)
Co-authored-by: Nathan Voxland <nathan@metabase.com>
2026-08-27 11:32:54 -04:00
github-automation-metabase
6d2c060ef1 Fix flaky document-comment split test (#77391)
* Fix flaky document-comment split test by using realClick on hover-revealed button

The test clicked the hover-revealed "new thread" comment button of the
second paragraph via Cypress's synthetic .click(). After realHover() moved
the cursor to reveal the button, the synthetic click could act on the button
while its hover transition was unwinding, so the click did not reliably
trigger the route navigation that opens the comments sidebar — leaving
getSidebar() to time out.

Switch to .realClick(), which moves the real mouse onto the button (keeping
it visible/stable) and dispatches a real click that reliably fires the link.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Wait for document save to persist before opening comments sidebar

The split-paragraph test opened the comments sidebar immediately after the
Save button disappeared, but a successful save schedules a deferred
navigation back to /document/:id. Under network throttling that navigation
resolved after the sidebar route had opened, clobbering it, so the sidebar
never mounted and getSidebar timed out. Wait on the PUT request and the
"Document saved" toast so the post-save navigation settles first.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-08-27 17:28:43 +02:00
Nicola Mometto
f8ce01fcca Check the email_verified claim in the generic OIDC provider (#80269)
Google SSO already requires the id-token email to be verified; the
generic OIDC provider (and slack-connect, which derives from it) did
not look at the claim at all.

Tokens with email_verified present and not true are now rejected. An
absent claim is still accepted: it is optional per OIDC Core and some
IdPs never send it.
2026-08-27 16:16:12 +01:00
Merlin-S3NS
e433af3f90 Fix: Support Google Cloud Universe Domain in BigQuery driver (#68607)
* Fix: Support Google Cloud Universe Domain in BigQuery driver

* feat(bigquery): Add universe domain to connection properties UI

* feat(bigquery): improve universe domain helper text

* Update bigquery_cloud_sdk.clj

Indeed we are out of sync as the impersonating was removed from master branch.

* removed empty comment

* Fixing formatting
2026-08-27 10:57:23 -04:00
Nicola Mometto
57f6f37864 Match SSO group names by exact string value when syncing memberships (#80615)
Ignore non-string SSO group names when syncing group memberships
2026-08-27 15:45:51 +01:00
github-automation-metabase
2ef0e4d264 Fix flaky dashboard bulk-move empty-state test (#78457)
Wait for the question move PUT to settle before navigating to the
affected dashboard, so its empty state is asserted only after the
dashcard has actually been removed.
2026-08-27 16:44:22 +02:00
Nemanja Glumac
c090eb292a Delete redundant e2e spec (#81174) 2026-08-27 16:03:30 +02:00
Kevin Kelleher
9e329ce6fe Ensure highlighted bars are included in brush drill filter (#80025)
* ensure highlighted bars are included in brush drill filter

* fix e2e

* fix e2e again, December 2026 label was not appearing maybe due to a screen size flake
2026-08-27 13:53:32 +00:00
github-automation-metabase
0d36304bf5 Stabilize scatter tooltip test against ExplicitSize resize flake (#78458)
The 'adding non-series columns to the tooltip' scatter test hovered a
bubble immediately after render. The ExplicitSize throttle re-renders the
chart once its container is measured, moving bubbles out from under the
realHover() before the tooltip fires, so [data-testid=echarts-tooltip]
was intermittently never found (4000ms timeout).

Apply the same view-toggle stabilization the sibling tooltip test already
uses (extracted as stabilizeScatterChart) before each hover, forcing a
re-render against an already-measured container.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-08-27 15:29:26 +02:00
Chris Truter
dd1cb0f0ba Require justifications for linter ignores (#77820)
* Require a justification comment above inline ignores, ratcheted per linter

An ignore of a linter outside :comment-exempt needs a substantive ;;
comment on the line above or trailing on the same line (bare ;; dividers
don't count, and no attempt is made to check the comment is about the
ignore). ~18% of ignores have one today, so 35 linters start exempt.
The set only shrinks: once a linter's last uncommented ignore gains a
comment, the fixer drops its exemption and CI holds the line.

* Locate trailing justification comments in masked source

A semicolon inside a string or character literal on the ignore's line
counted as a trailing comment, so an unjustified ignore could pass.
The masker now keeps the ; that starts a comment (and blanks the char
after a backslash), so justified? finds only real comment starts.

* Share one tree scan across the ratchet tests

Each ratchet test walked and slurped the whole source tree; a delay
runs the scan once for all three.

* Invalidate the shared tree scan per test run

The namespace-level delay cached the scan for the JVM's lifetime, so a
long-lived REPL compared fresh ratchet-file contents with stale counts.
The :once fixture now resets the cache; a directly-run test var scans
fresh.

* Scope the shared tree scan to the fixture's lifetime

The atom cache survived a run, so a later directly-invoked test var
(which skips :once fixtures) reused a stale scan. The cache now holds a
delay only while the fixture is live; without it every call scans fresh.

* Require canonical syntax for kondo ignores

Keep ignore detection deliberately lexical and fail closed: every real marker must use the key-first map form, otherwise the ratchet rejects it with an actionable error. This avoids maintaining a partial Clojure reader for the two attr maps that previously placed the ignore behind another key.

Justification comments must be substantive and either directly above the ignore or trailing on its line. Authenticate comment openers in masked source so strings and code-line comments cannot pose as justifications.

* Harden kondo ignore scanning edge cases

* Use reader delimiters for kondo marker boundaries

* Match Clojure reader whitespace in kondo markers

* Reserve clj-kondo namespaced map syntax

* Harden kondo scanner diagnostics

* Rebuild the budgets and exemptions on the named-linter base

Rebased onto the ignore-naming branch, so every budget is recomputed from
the tree and :comment-exempt is reseeded with exactly the linters that
still have an uncommented ignore: 38, up from 35. The three extra are
linters that were hidden inside bare `#_:clj-kondo/ignore` forms until
they were spelled out; :all itself drops out, having no ignores left.

* Point at :comment-exempt after inserting ignores for a new linter

kondo-insert-ignores writes comment-less ignores, which the justification
ratchet rejects for non-exempt linters.

* Leave ignores preceded by a # for a human, and gate the exemption advice

A `#` immediately before the matched form is ambiguous: in `#^{...}` it is
legacy metadata that removal must take with it, in `x#^{...}` it closes a
syntax-quote gensym that removal must leave alone. Telling them apart means
reading Clojure, which this scanner deliberately does not do -- so report
the site under :skipped, as it already does for prefixless maps and
unbalanced braces, and let a human excise it.

Separately, kondo-insert-ignores no longer advises a :comment-exempt entry
unconditionally. An inserted ignore lands under whatever comment already sat
above the flagged form, so a linter whose sites are all justified would get
an exemption that no-stale-exemptions-test then rejects.

* Align the scan-test expectations

The occurrence vector's :justified? column and the counts map both drifted
out of alignment as linters were added to the fixture.

* Regenerate kondo ignore budgets after restacking onto master
2026-08-27 15:16:59 +02:00
Chris Truter
ec3b24fadd Make every kondo ignore name the linters it suppresses (#79531)
* Make every kondo ignore name the linters it suppresses

The vector-less `#_:clj-kondo/ignore` suppresses every linter on the next
form, so a site added to silence one warning quietly absorbs any other that
appears there later. Replace all 50 with explicit linter vectors.

The budgets absorb what the bare forms were hiding: :discouraged-var
106 -> 129, :unresolved-namespace 3 -> 9, :type-mismatch 2 -> 6,
:unresolved-symbol 4 -> 9, plus first entries for :consistent-alias,
:duplicate-require and :redundant-do. :all drops out entirely, so a new
bare ignore now fails the ratchet with no budget to land in.

* Use the mdb.env alias in app-db-as-data-warehouse

Var-quotes resolve namespace aliases, private vars included, so the
fully-qualified name was never needed. Dropping it retires the
:aliased-namespace-symbol ignore and the unused-alias warning the
workaround caused.

* Regenerate kondo ignore budgets after restacking onto master
2026-08-27 14:23:09 +02:00
Jakub Chodorowicz
7eba2629f2 harden host event listener access across membrane (#81036) 2026-08-27 14:02:06 +02:00
Jakub Chodorowicz
c433278e06 Gdgt 2472 loader (#80586) 2026-08-27 11:53:29 +02:00
Oleh K
11be7cb3e7 Restyle NavLink with primary and secondary variants (#80640)
* Add primary/secondary NavLink variants and sibling components (GDGT-2469)

Restyle the design-system NavLink from Figma:

- Add `primary` (brand-fill selected) and `secondary` (subtle gray selected)
  variants, with Default/Hover/Pressed/Selected states.
- Add the `icon-{primary,secondary,disabled,brand}-inverse` color tokens.
- Add `NavLinkButton` and `NavLinkBadge` sibling components for the right
  section; both invert automatically on a selected `primary` item (no prop),
  the button also has its own hover/press and stops click propagation.
- Give NavLink a `leftIcon` prop so it renders and colors the leading icon
  itself instead of styling the section slot.
- Add a two-variant state-matrix Storybook showcase (Loki-covered).

* Migrate NavLink call sites to primary/secondary variants (GDGT-2469)

- Admin nav: `admin-nav` -> `secondary`
- Entity picker: current level -> `primary`, other levels -> `secondary`;
  search results -> `primary`
- Remove the now-unused `default`/`mb-light`/`admin-nav` variant CSS

* Revert NavLink `leftIcon` prop back to `leftSection` (GDGT-2469)

Drop the polymorphic NavLink wrapper and colour the leading icon via the
`.NavLinkSection[data-position="left"]` CSS overrides again.

* Update Loki Snapshots

* Cleanup

* Update Loki Snapshots

* Add Loki reference for the NavLink Overview story (GDGT-2469)

* Update Loki Snapshots

* Address NavLink review comments (GDGT-2469)

- Migrate the remaining `default` NavLink (embedding SimpleDataPicker) to
  `primary`, restoring its selected styling
- Render NavLinkButton as a `<div role="button">` (valid inside a NavLink's
  `<a>`) with keyboard activation, instead of a `<button>`

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-08-27 11:42:14 +02:00
Oleksandr Yakushev
cad622a164 [test] Extract and reuse deferred str mechanism for testing macro (#79932) 2026-08-27 10:50:01 +03:00
6135 changed files with 1376599 additions and 1263014 deletions

View File

@@ -81,7 +81,7 @@ Everything else in the module is **internal** and not allowed to be referenced f
`dev/src/dev/modularization_help.clj` — `potemkin-ns!` helper that generates `.core` re-export boilerplate from a target namespace.
`test/metabase/core/modules_test.clj` — runs on config changes; validates structure, team assignments, API and model boundaries.
`dev/test/metabase/core/modules_test.clj` — runs on config changes; validates structure, team assignments, API and model boundaries.
### API Design Inside a Module
@@ -119,7 +119,7 @@ When the linter complains, the answer is **always refactoring**, never suppressi
- `dev/src/dev/module_score.clj` — quality scoring
- `dev/src/dev/modularization_help.clj` — Potemkin re-export helper
- `dev/src/dev/model_boundary_config.clj` + `dev/src/dev/model_tracking.clj` — model-level enforcement
- `test/metabase/core/modules_test.clj` — config validation tests
- `dev/test/metabase/core/modules_test.clj` — config validation tests
- `src/metabase/core/init.clj` — OSS module init aggregation
- `enterprise/backend/src/metabase_enterprise/core/init.clj` — EE module init aggregation
- `src/metabase/models/resolution.clj` — `:model/X` keyword → namespace map
@@ -198,6 +198,6 @@ Use the `clojure-eval` skill (preferred) or `clj-nrepl-eval` to drive the dev to
(dev.module-score/scores (dev.module-score/deps) (dev.module-score/config))
```
For tests of the config itself, use `./bin/test-agent :only '[metabase.core.modules-test]'`. After editing Clojure files, run `clj-paren-repair`. After editing `config.edn`, re-run the modules-test.
For tests of the config itself, use `./bin/mage project-tests modules`. After editing Clojure files, run `clj-paren-repair`. After editing `config.edn`, re-run the modules-test.
**Update your agent memory** as you discover idioms: which modules use `:friends` and why, which models are most-imported (suggesting they belong in their own module), which settings are accessed cross-module via `(setting/get …)` instead of `:uses` deps, and which refactors the team is actively running.

View File

@@ -304,12 +304,13 @@ Tag response Malli `:map` schemas with `{:closed true}` so the generated OpenAPI
**Linter Suppressions:**
The right shape is a **reader-discard map** placed directly above the form being silenced, listing the rule keywords explicitly:
The right shape is a **reader-discard map** placed directly above the form being silenced, listing the
rule keywords explicitly and including the required explanation:
```clojure
#_{:clj-kondo/ignore [:metabase/validate-defendpoint-route-uses-kebab-case
:metabase/validate-defendpoint-has-response-schema]}
(api.macros/defendpoint :post "/api_key" ...)
;; Loaded by name from the plugin registry.
#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
(defn plugin-entrypoint ...)
```
For a single require entry, hang it as metadata on that entry:
@@ -320,7 +321,12 @@ For a single require entry, hang it as metadata on that entry:
[metabase.query-processor.store :as qp.store])
```
Common Metabase-specific rules you'll see: `:metabase/modules`, `:metabase/validate-defendpoint-route-uses-kebab-case`, `:metabase/validate-defendpoint-has-response-schema`, `:metabase/prefer-with-dynamic-fn-redefs`, `:deprecated-namespace`, `:discouraged-namespace`. Don't use the keyword form (`#_:clj-kondo/ignore`); always the map form so it's grep-able by which rule(s) are suppressed.
Use the map form, not the keyword form (`#_:clj-kondo/ignore`), so searches can identify the suppressed
rules. Keep `:clj-kondo/ignore` as the map's first key; the ratchet scanner rejects other orderings.
Fix the warning when possible. Adding a suppression is a last resort and requires approval. If one is
necessary, add an explanatory `;;` comment directly above it or at the end of the same line. CI enforces
these requirements with `./bin/mage kondo-ratchets`.
**Configurable Options:**

View File

@@ -149,8 +149,7 @@ ms/NonBlankString ;; Non-empty string
ms/BooleanValue ;; String "true"/"false" or boolean
ms/MaybeBooleanValue ;; BooleanValue or nil
ms/TemporalString ;; ISO-8601 date/time string (for REQUEST params only!)
ms/Map ;; Any map
ms/JSONString ;; JSON-encoded string
ms/OpaqueJSONObject ;; JSON object whose keys are not ours to declare; string-keyed
ms/PositiveNum ;; Positive number
ms/IntGreaterThanOrEqualToZero ;; 0 or positive
```

View File

@@ -111,7 +111,12 @@ liability it usually is.
### Miscellaneous
- [ ] Example data is bird-themed when possible
- [ ] Kondo linter suppressions use proper format (not `#_:clj-kondo/ignore` keyword form)
- [ ] Kondo suppressions use a reader-discard map, not `#_:clj-kondo/ignore`, with
`:clj-kondo/ignore` as the first key
- [ ] Each new suppression is approved and has a `;;` comment explaining why the warning cannot be fixed
- [ ] Any ratchet budget increase is explained in the PR
- [ ] PRs that remove ignores leave ratchet budgets unchanged; the shrink workflow records reductions on
`master`
## Pattern matching table

View File

@@ -123,5 +123,12 @@ breakage keeps happening, *that* is the signal a comment was warranted.
- Spaces on a line with nothing after it is not allowed
- After changing module boundaries (adding/removing/renaming a `src` namespace, a cross-module `require`
or `:model/X` reference, or a new module), run `./bin/mage fix-modules-config` to regenerate
`.clj-kondo/config/modules/config.edn` and keep `metabase.core.modules-test` green. No-op when nothing
drifted; see "Module Boundaries" in the project `CLAUDE.md`.
`.clj-kondo/config/modules/config.edn`, then run `./bin/mage project-tests modules`. The fixer is a no-op when
nothing drifted; see "Module Boundaries" in the project `CLAUDE.md`.
- Fix kondo warnings instead of suppressing them. Add a suppression only as a last resort, with approval
and a `;;` comment explaining why it is necessary.
- Do not lower budgets in `.clj-kondo/ratchets.edn` after removing ignores. The shrink workflow records
reductions on `master`.
- If `.clj-kondo/ratchets.edn` conflicts during a merge, rebase, or restack, run
`./bin/merge-kondo-ratchets`. It preserves one-sided changes, chooses the policy that allows fewer
suppressions when both sides change the same entry, and stops when the conflict needs a human decision.

View File

@@ -37,14 +37,16 @@ First check if snapshots exist:
ls e2e/snapshots/default.sql 2>/dev/null && echo "snapshots exist" || echo "snapshots missing"
```
Always pass the spec path via `--spec`. The runner feeds its arguments to Cypress's CLI parser (`cypress.cli.parseRunArguments`), which silently drops bare positional paths and then runs the entire suite. A leading `run` argument is harmless, but the path itself must follow `--spec`. Sanity-check that the first `Running:` line says `(1 of 1)`.
If snapshots exist, skip regeneration for speed:
```bash
MB_EDITION=oss CYPRESS_VIDEO=false CYPRESS_RETRIES=0 CYPRESS_GUI=false GENERATE_SNAPSHOTS=false bun test-cypress $ARGUMENTS
MB_EDITION=oss CYPRESS_VIDEO=false CYPRESS_RETRIES=0 CYPRESS_GUI=false GENERATE_SNAPSHOTS=false bun test-cypress --spec path/to/spec.cy.spec.js
```
If snapshots are missing (first run), let the runner generate them:
```bash
MB_EDITION=oss CYPRESS_VIDEO=false CYPRESS_RETRIES=0 CYPRESS_GUI=false bun test-cypress $ARGUMENTS
MB_EDITION=oss CYPRESS_VIDEO=false CYPRESS_RETRIES=0 CYPRESS_GUI=false bun test-cypress --spec path/to/spec.cy.spec.js
```
When running enterprise tests, replace `MB_EDITION=oss` with `MB_EDITION=ee` in the commands above.
@@ -67,9 +69,11 @@ GREP="test name here" MB_EDITION=oss bun test-cypress --spec path/to/spec.js
When the user asks to verify a test is not flaky:
```bash
MB_EDITION=oss bin/e2e-stress-test $ARGUMENTS
MB_EDITION=oss bin/e2e-stress-test --spec path/to/spec.cy.spec.js
```
(The stress script forwards its arguments to `bun test-cypress`, so the same `--spec` rule applies.)
Set `E2E_STRESS_RUNS=N` for more iterations (default: 5). Stops on first failure and prints screenshot paths. Read those screenshots to analyze the failure.
## Analyzing failures

View File

@@ -171,7 +171,7 @@ Create `ComponentName.module.css` alongside the component file:
/* Use design system tokens — NEVER raw color/spacing values */
.root {
border: 1px solid var(--mb-color-border-neutral);
border-radius: var(--mantine-radius-md);
border-radius: var(--mantine-radius-sm);
background-color: var(--mb-color-background_page-primary);
}
@@ -246,7 +246,8 @@ Remove the old styled file entirely. Remove all imports of it from other files.
**Spacing** (`p`, `px`, `py`, `pt`, `pb`, `pl`, `pr`, `m`, `mx`, `my`, `mt`, `mb`, `ml`, `mr`):
- `"xs"` = 4px, `"sm"` = 8px, `"md"` = 16px, `"lg"` = 24px, `"xl"` = 32px
- `"xxxs"` = 0.125rem, `"xxs"` = 0.25rem, `"xs"` = 0.375rem, `"sm"` = 0.5rem, `"md"` = 0.75rem, `"lg"` = 1rem, `"xl"` = 1.5rem, `"xxl"` = 2rem, `"xxxl"` = 2.5rem
- Use numeric `0` for zero spacing.
- Custom: `rem(48)` for non-standard values (import `rem` from `metabase/ui`)
**Dimensions** (`w`, `h`, `maw`, `mah`, `miw`, `mih`):
@@ -289,11 +290,16 @@ Remove the old styled file entirely. Remove all imports of it from other files.
**Mantine spacing** — `var(--mantine-spacing-<size>)`:
- `--mantine-spacing-xs` (4px), `--mantine-spacing-sm` (8px), `--mantine-spacing-md` (16px), `--mantine-spacing-lg` (24px), `--mantine-spacing-xl` (32px)
- `--mantine-spacing-xxxs` (0.125rem), `--mantine-spacing-xxs` (0.25rem), `--mantine-spacing-xs` (0.375rem), `--mantine-spacing-sm` (0.5rem), `--mantine-spacing-md` (0.75rem), `--mantine-spacing-lg` (1rem), `--mantine-spacing-xl` (1.5rem), `--mantine-spacing-xxl` (2rem), `--mantine-spacing-xxxl` (2.5rem)
**Mantine radius** — `var(--mantine-radius-<size>)`:
- `--mantine-radius-xs` (4px), `--mantine-radius-sm` (6px), `--mantine-radius-md` (8px), `--mantine-radius-xl` (40px)
- `--mantine-radius-xxxs` (0.125rem), `--mantine-radius-xxs` (0.25rem), `--mantine-radius-xs` (0.375rem), `--mantine-radius-sm` (0.5rem), `--mantine-radius-md` (0.75rem), `--mantine-radius-lg` (1rem), `--mantine-radius-xl` (1.5rem)
**Mantine shadows (elevation)** — `var(--mantine-shadow-<size>)`:
- `--mantine-shadow-xs`, `--mantine-shadow-xs_outline`, `--mantine-shadow-sm`, `--mantine-shadow-sm_outline`, `--mantine-shadow-lg_outline`
- Light and dark modes use different shadow values (defined in `frontend/src/metabase/ui/theme.ts`)
**Mantine font sizes** — `var(--mantine-font-size-<size>)`:
@@ -313,24 +319,36 @@ When migrating, **never carry over hardcoded `rem`/`px` values** from the origin
**Spacing** — snap to the nearest Mantine spacing token:
| Hardcoded value | Nearest token | Style prop | CSS variable |
| --------------------------------- | ------------- | ------------ | ------------------------------ |
| `0.125rem` (2px) | `2px` | `2` (number) | `2px` (keep literal, no token) |
| `0.2rem` (3.2px), `0.25rem` (4px) | **xs** (4px) | `"xs"` | `var(--mantine-spacing-xs)` |
| `0.5rem` (8px) | **sm** (8px) | `"sm"` | `var(--mantine-spacing-sm)` |
| `0.75rem` (12px) | between sm/md | `rem(12)` | `0.75rem` (no exact token) |
| `1rem` (16px) | **md** (16px) | `"md"` | `var(--mantine-spacing-md)` |
| `1.5rem` (24px) | **lg** (24px) | `"lg"` | `var(--mantine-spacing-lg)` |
| `2rem` (32px) | **xl** (32px) | `"xl"` | `var(--mantine-spacing-xl)` |
| Hardcoded value | Nearest token | Style prop | CSS variable |
| --------------------------------- | ------------- | ---------- | ------------------------------- |
| `0` (0px) | — | `0` | `0` |
| `0.125rem` (2px) | **xxxs** | `"xxxs"` | `var(--mantine-spacing-xxxs)` |
| `0.2rem` (3.2px), `0.25rem` (4px) | **xxs** | `"xxs"` | `var(--mantine-spacing-xxs)` |
| `0.375rem` (6px) | **xs** | `"xs"` | `var(--mantine-spacing-xs)` |
| `0.5rem` (8px) | **sm** | `"sm"` | `var(--mantine-spacing-sm)` |
| `0.75rem` (12px) | **md** | `"md"` | `var(--mantine-spacing-md)` |
| `1rem` (16px) | **lg** | `"lg"` | `var(--mantine-spacing-lg)` |
| `1.5rem` (24px) | **xl** | `"xl"` | `var(--mantine-spacing-xl)` |
| `2rem` (32px) | **xxl** | `"xxl"` | `var(--mantine-spacing-xxl)` |
| `2.5rem` (40px) | **xxxl** | `"xxxl"` | `var(--mantine-spacing-xxxl)` |
Values between steps: keep the literal (e.g. `rem(10)`), don't round to a token.
**Border radius** — snap to the nearest Mantine radius token:
| Hardcoded value | Nearest token | CSS variable |
| ---------------- | ----------------------------- | -------------------------- |
| `0.25rem` (4px) | **xs** (4px) | `var(--mantine-radius-xs)` |
| `0.375rem` (6px) | **sm** (6px) | `var(--mantine-radius-sm)` |
| `0.5rem` (8px) | **md** (8px) | `var(--mantine-radius-md)` |
| `1rem`+ (16px+) | **xl** (40px) or keep literal | `var(--mantine-radius-xl)` |
| Hardcoded value | Nearest token | CSS variable |
| ---------------- | ------------- | ----------------------------- |
| `0` (0px) | — | `0` |
| `0.125rem` (2px) | **xxxs** | `var(--mantine-radius-xxxs)` |
| `0.25rem` (4px) | **xxs** | `var(--mantine-radius-xxs)` |
| `0.375rem` (6px) | **xs** | `var(--mantine-radius-xs)` |
| `0.5rem` (8px) | **sm** | `var(--mantine-radius-sm)` |
| `0.75rem` (12px) | **md** | `var(--mantine-radius-md)` |
| `1rem` (16px) | **lg** | `var(--mantine-radius-lg)` |
| `1.5rem` (24px) | **xl** | `var(--mantine-radius-xl)` |
Fully-round pills/badges (radius ≥ half the element height): keep a literal
such as `9999px`.
**Font sizes** — snap to the nearest Mantine font size token:

View File

@@ -31,6 +31,11 @@ Phases 1, 2, 5 and 6 are shared. The middle two differ in **order**: update mode
- **The component's intended API** — variants, sizes, and states the design system supports for this component. This defines the axes of your showcase (Phase 3).
3. Decide the mode (see **Two modes** above): search for an existing component — in `metabase/ui` or as a legacy component elsewhere. Found → **update**; nothing equivalent anywhere → **create**. Confirm with the user when unsure.
4. **Verify a Figma desktop MCP is connected before doing the work** — this skill depends on it for exact tokens in Phase 4 (and styling can't proceed accurately without it). Do a quick read against the issue's node (e.g. `get_metadata`/`get_variable_defs`); if it errors with "nothing selected" or the server isn't connected, prompt the user to enable it (Switch to Dev Mode → MCP section in the right sidebar) and select the relevant layer before continuing.
5. **Figma Desktop MCP environments only:** open the issue's exact page with [`figma-open`](./figma-open) before MCP reads. Do not run this helper when Desktop MCP is unavailable.
```bash
.claude/skills/metabase-ui-component-from-figma/figma-open "<figma-url-with-node-id>"
```
A URL with `node-id` needs no token. Bare page-name and `--list` lookups require an already-configured `FIGMA_TOKEN`.
## Phase 2 — Understand the component
@@ -205,7 +210,7 @@ Per `docs/developers-guide/frontend.md` ("Colors"): every color must be a **sema
The same discipline applies to **dimensional** values — radius, spacing/padding/gap, elevation/shadow, and typography (font size, line-height, weight). Prefer the codebase's existing scale variable over a literal: `--mantine-radius-*`, `--mantine-spacing-*`, `--mantine-shadow-*`, and the Mantine font tokens.
But Figma's scales don't always line up with the codebase's. When a Figma value **has no matching step** in the corresponding scale — e.g. Figma `radius/md = 12px` while `--mantine-radius-md` is `8px`, or a Figma `xxxs` spacing step with no Mantine equivalent — **don't silently bake in a literal.** Flag it to the user the same way you flag primitive colors: name the property, the Figma value, and the nearest codebase token, so it can be resolved with design / the scale owners (align the value, or add a scale step). Only fall back to a literal if the user confirms it's an accepted one-off, and leave a short comment in the code explaining why.
But Figma's scales don't always line up with the codebase's. When a Figma value **has no matching step** in the corresponding scale — e.g. Figma `radius/md = 16px` while `--mantine-radius-md` is `0.75rem`, or a Figma spacing step that has no Mantine equivalent — **don't silently bake in a literal.** Flag it to the user the same way you flag primitive colors: name the property, the Figma value, and the nearest codebase token, so it can be resolved with design / the scale owners (align the value, or add a scale step). Only fall back to a literal if the user confirms it's an accepted one-off, and leave a short comment in the code explaining why. The codebase scales are defined in `frontend/src/metabase/ui/theme.ts` (`SPACING_SCALE`, `RADIUS_SCALE`, `LIGHT_SHADOWS`/`DARK_SHADOWS`).
### Mantine implementation notes (reference)
@@ -240,5 +245,6 @@ Only after sign-off:
- [ ] Storybook showcase matrix built from the component's full state space (theme excluded — global toggle drives light/dark), single panel, hover/pressed forced via `storybook-addon-pseudo-states`, controls scoped per story; lint + type-check pass. (Update mode: built before styling, **component styles untouched**. Create mode: built after the component is implemented in Phase 4.)
- [ ] Figma desktop MCP available; exact tokens extracted and mapped to semantic `--mb-color-*` (NO `color-mix`, NO primitives) and to existing scale vars for radius/spacing/elevation/type — any color *or* dimensional value with no matching token/scale step flagged to the user, not baked in as a literal.
- [ ] Component styled; stylelint + eslint(+CSS modules) + type-check pass.
- [ ] Loki coverage registered: `storiesFilter` matches exact story display names; targeted `loki update` generated references; reference PNGs and Playwright screenshots visually inspected; targeted `loki test` passes; `.loki/reference/*.png` included in the commit.
- [ ] Iterated with the user until satisfied.
- [ ] Committed (when asked); call sites migrated/verified (update) or export wired (create); findings doc handed back.

View File

@@ -0,0 +1,68 @@
#!/usr/bin/env bash
# figma-open — open a Figma file (or a specific page) in the Figma desktop app
#
# Usage:
# figma-open <url-or-file-key> open the file
# figma-open <url-or-file-key> <node-id> open at a node/page id (e.g. 12-3 or 12:3)
# figma-open <url-or-file-key> --list list pages with their ids
# figma-open <url-or-file-key> "Page name" open a page by name
#
# Page lookup by name/--list needs a Figma personal access token:
# export FIGMA_TOKEN=figd_... or put it in ~/.config/figma/token
set -euo pipefail
arg="${1:-}"
[[ -n "$arg" ]] || { awk 'NR==1 && /^#!/ {next} /^#/ {sub(/^# ?/,""); print; next} {exit}' "$0"; exit 1; }
token="${FIGMA_TOKEN:-}"
[[ -f "$HOME/.config/figma/token" ]] && token="$(<"$HOME/.config/figma/token")"
# Extract the file key from any Figma URL form, or use the arg as a bare key.
key="$arg"
case "$arg" in
*figma.com*|figma://*)
key="$(printf '%s' "$arg" | sed -E 's#https?://([a-z]+\.)?figma\.com##; s#^([a-z0-9-]+\.)?figma\.com##; s#^figma://##; s#^/?(file|design|proto|board)/##; s#^/##; s#/.*##; s#\?.*##')"
;;
esac
req="${2:-}"
# If no page arg was given but the URL carries a node-id, use it.
url_node="$(printf '%s' "$arg" | sed -nE 's/.*[?&]node-id=([0-9]+([-:][0-9]+)*).*/\1/p')"
open_fig() { # $1 = optional node id
if [[ -n "${1:-}" ]]; then
open "figma://file/${key}?node-id=${1//:/-}"
else
open "figma://file/${key}"
fi
}
# No page requested — open the file (or the node the URL points at).
[[ -z "$req" ]] && { open_fig "${url_node:-}"; exit 0; }
# Explicit node id (page ids work: pages are top-level nodes).
if [[ "$req" =~ ^[0-9]+[:-][0-9]+$ ]]; then
open_fig "$req"
exit 0
fi
# Everything else needs the REST API.
[[ -n "$token" ]] || { echo "error: page lookup needs FIGMA_TOKEN (env or ~/.config/figma/token)" >&2; exit 1; }
pages_json="$(curl -sf -H "X-Figma-Token: ${token}" "https://api.figma.com/v1/files/${key}?depth=1")" \
|| { echo "error: could not fetch file ${key} (bad key, no access, or bad token)" >&2; exit 1; }
if [[ "$req" == "--list" || "$req" == "-l" ]]; then
printf '%s\n' "$pages_json" | jq -r '.document.children[] | "\(.id // .guid)\t\(.name)"' | column -t -s $'\t'
exit 0
fi
# Page by name (case-insensitive, exact match first, then substring).
node_id="$(printf '%s' "$pages_json" | jq -r --arg n "$req" \
'first(.document.children[] | select((.name // "") | ascii_downcase == ($n | ascii_downcase)) | .id // .guid) //
first(.document.children[] | select((.name // "") | ascii_downcase | contains($n | ascii_downcase)) | .id // .guid) //
empty')"
[[ -n "$node_id" ]] || { echo "error: no page matching \"$req\" in file ${key}" >&2; exit 1; }
open_fig "$node_id"

View File

@@ -17,10 +17,10 @@ Adherence to `typescript-write` is the **highest-priority** review dimension: ra
Review in this priority order:
1. **Violations of [`typescript-write`](../typescript-write/SKILL.md) provisions** — no-`any`, type tightening, type modeling, null/undefined handling, naming, structure, comments. Highest priority; block on the no-`any` rule.
1. **Violations of [`typescript-write`](../typescript-write/SKILL.md) provisions** — no-`any`, type tightening, type modeling, function signatures, null/undefined handling, naming, structure, comments. Highest priority; block on the no-`any` rule. Apply conditional guidance in context: explain the unsupported type guarantee or concrete readability problem, rather than treating every preference as a blanket ban.
2. Compliance with `frontend/CLAUDE.md`.
3. Readability and maintainability.
4. Appropriate test coverage.
4. Appropriate test coverage. For internal typed callers, avoid requesting tests solely for inputs the type system excludes. External API data, deserialised values, storage and JavaScript callers can violate annotations: test runtime validation and nontrivial assumptions at those boundaries. Types do not replace behavioural, security or data-integrity tests.
## Blind spots — act as the missing reviewer
@@ -31,3 +31,4 @@ These rarely surface in team reviews, so this skill should raise them. They are
- **Security.** Evaluate potential security issues in new code.
- **Bundle size.** Flag new large dependencies, default imports from icon or util libs, and heavy modules imported at route-load time.
- **Analytics.** User-facing flows should emit tracking events. If a PR adds a new flow (button, modal, navigation) without a tracking event, ask whether one is expected.
- **Public API surface** (embedding SDK). Consumers should be able to use public signatures and name types they need to import. Export those types deliberately and document public behaviour, including `@deprecated` for deprecated APIs; a referenced structural type does not automatically need its own named export.

View File

@@ -20,20 +20,27 @@ description: Write TypeScript and JavaScript code following Metabase coding stan
- **Avoid type casts and loose `unknown`** — fix the signature instead.
- **If a function only needs one field of a wide object, accept that field** — not the wide object. The cast often disappears once the signature is right.
- **Reach for `Partial<T>`, `Pick<T, K>`, `Record<K, V>`, and generics** before reaching for a cast.
- **Match dictionary keys to the data.** Use a finite key union when the keys are known. Open dictionaries can use an index signature, `Record<string, T>`, or `Map`; index signatures still constrain values, and changing their spelling to `Record<string, T>` does not make missing-key access safe.
- **Prefer making props/components generic** (`<T>`) when a value flows through unchanged and the caller knows the type.
- **Prefer `unknown` over loose typing** and narrow before use — an `unknown` value forces a guard at the point of use.
- **`satisfies` for object literals** that must conform without widening (config objects, lookup maps, discriminated literals) — better than `: T` (widens) or `as T` (unsafe).
- **Avoid non-null assertions (`!`)**. Prefer a guard, early return, or `?.`. Use `!` only when non-nullness is provably true and localized, with a comment.
- **Guard indexed lookups that may miss.** Arrays and dictionaries can return `undefined` even when the inferred type omits it. Use an iteration form that preserves the key/value relationship, and only assert `keyof` when the runtime keys are known to belong to the declared type.
- **No redundant runtime coercion** — don't wrap already-typed values in `Number()` / `String()` / `Boolean()`.
- **Type guards belong in `frontend/src/metabase-types/guards/`**. Do not redefine them locally.
- **A cast you can't avoid needs a real justification comment.** The `metabase/no-unjustified-type-casts` rule accepts any preceding comment — state the actual reason the cast is safe. NEVER write the legacy `// Unjustified type cast. FIXME` placeholder; it exists only on casts that predated the rule, and copying it sneaks an unjustified cast past the linter. If you can't articulate why the cast is correct, the cast is wrong — fix the types.
- **Keep unavoidable assertions local.** Isolate a repeated or complex assertion behind a helper when that makes its invariant easier to enforce. Test nontrivial runtime assumptions that justify it; a trivial assertion does not automatically need a new helper or test. Do not weaken a public signature just to silence implementation errors.
## Type modeling
- **Reuse existing types; don't re-declare them.** Use canonical IDs and domain entity types from `metabase-types/api` (`FieldId`, `TableId`, `ConcreteTableId`, `SchemaName`, …) and key data structures by them (`new Map<ConcreteTableId, …>()`). Don't duplicate generated/API types — compose or derive (`Pick`, `Omit`, indexed access `SomeType["field"]`, `ReturnType`).
- **Use generics to allow TypeScript to infer correct types** when creating functions and components that need to be reusable and type-safe. Don't hesitate to introduce complex generics if they allow to derive types automatically instead of manual narrowing.
- **Generics must make promises the implementation can keep.** A caller-selected `get<T>(): T` must not disguise an unchecked assertion about external data. Return `unknown` and validate, or accept a validator that establishes `T`. A factory such as `function empty<T>(): T[] { return []; }` is valid; judge the implementation, not how often `T` appears in the signature.
- **Prefer an honest type over false precision.** Use generics when they express a real relationship. If a complex type cannot model the behaviour accurately, choose a simpler type or `unknown` with narrowing instead of asserting an unsupported guarantee.
- **Model the actual data contract; keep types narrow.** Optional `field?: T` for a key that may be absent, `field: T | undefined` only when the key is always present but the value may be undefined, `| null` for explicit API nulls. Prefer domain unions over broad `string` / `number` / loose `Record`.
- **Refer to API implementation** when defining or refining types to ensure they match the actual data structure. When considering a type cast, first consider if the type should be refined to match the actual data structure.
- **Optionality must reflect absence.** Keep required fields required and optional fields optional. Normalise input when the application has a meaningful default, not merely to remove a type error. Preserve the actual wire shape in API types.
- **Represent related absence together when modelling internal state.** If several fields exist or disappear together, consider a nullable containing object or a discriminated union. Do not reshape a raw API declaration unless the data actually has that shape.
- **Prefer explicit special states when designing a format.** Use nullability or named union variants when sentinel values such as `-1` hide meaning. Preserve established protocol sentinel values unless the behaviour is deliberately changed, or normalise them at an explicit boundary.
- **Discriminated unions for variant state, with exhaustive checks.** Model "one of N shapes" as a union with a literal discriminant rather than a bag of optional fields, and exhaust it with ts-pattern's `.exhaustive()` so adding a variant becomes a compile error:
```ts
import { match } from "ts-pattern";
@@ -45,20 +52,30 @@ description: Write TypeScript and JavaScript code following Metabase coding stan
.exhaustive(); // Compile-time guarantee all cases handled
```
- **Derive union types from constants** (`as const` + `typeof`/`keyof`) so the type and the values can't drift.
- **`readonly` / immutability where mutation isn't intended** — component props, shared constants, exported config. Prefer `readonly T[]` / `ReadonlyArray<T>` for inputs you don't mutate.
- **`readonly` / immutability where mutation isn't intended** — component props, shared constants, exported config, and unmutated parameters. Prefer `readonly T[]` / `ReadonlyArray<T>` for inputs you don't mutate. Functions that mutate caller-owned data should make that behaviour explicit.
- **Construct complete, well-typed objects where practical.** Prefer an object expression when it avoids partially initialised state or assertions. Incremental construction is fine when it is clearer and maintains the type's invariants.
- **Treat `metabase-lib` opaque types as black boxes.** Use `metabase-lib` functions to work with types such as `Lib.Query`, rather than casting into their internal representation.
- **Type async and error states explicitly** (a discriminated union or the data-layer's typed result) — never leave loading/error/empty implicit.
## Function signatures
- **Make public contracts explicit where it improves stability and clarity.** Annotate parameters and return types at shared boundaries when useful; let local values infer. Use `satisfies` or an annotation when a declaration needs an explicit shape check.
- **Accept the inputs the operation supports and return the most precise honest result.** Narrow avoidable uncertainty inside the function, but preserve meaningful nullability and union variants in its return type.
- **Use named options when positional arguments are easy to confuse.** Consecutive arguments with the same type are a useful warning sign, not an automatic requirement to rewrite a clear API.
- **Use `async`/`await` when it clarifies control flow or error handling.** Returning an existing promise directly is also valid; a Promise return type alone does not require adding `async`.
## Null and undefined
- **Narrow at the source**. If a value is optional only in a corner case, don't thread `undefined` through every layer — guard at the producer.
- **Sensible defaults for optional values**. Use `?.` and `??` at the consumer.
- **Lists should be filtered** before being used in a map or other iteration.
- **Narrow nullable list elements when the operation requires present values.** Filter with a type guard when missing entries should be discarded; preserve them when their absence or position carries meaning.
- **Avoid non-strict null comparisons** (`X != null`) when `X` can never be `null` — use a strict check or narrow the type. Use `checkNotNull` where necessary.
- **Check actual nullability against API implementation**. Find the API endpoint implementation and check if the field can actually be null.
## Naming
- **Names describe the entity, not the mechanism**. A name must reflect what the value holds.
- **Use domain vocabulary and include units where useful** (`timeoutMs`, `widthPx`, `temperatureC`). Prefer a more specific name when `Info`, `Data`, or `Entity` obscures the meaning, while keeping established terminology when it is clear.
- **Align sibling concepts**: keep verb conventions consistent across a related API.
- **No names that encode implementation history** rather than current meaning. Suffixes like `Base`, `New`, `Old`, `Initial` need a real semantic distinction, otherwise drop them.
- **Avoid cryptic identifiers** (`v`, `n`, `$n`) for domain values; short names are fine only in tiny conventional contexts (loop index `i`, coordinates `x`/`y`, generic params `T`/`K`/`V`).

View File

@@ -72,6 +72,7 @@
:metabase/namespace-name {:level :warning}
:metabase/no-jsqlparser-imports {:level :warning}
:metabase/prefer-with-dynamic-fn-redefs {:level :warning}
:metabase/t2-query-namespace {:level :warning}
:metabase/toucan-model-ns {:level :warning}
:metabase/require-shape-checker {:level :warning}
:metabase/tests-must-live-in-known-modules {:level :warning}
@@ -180,7 +181,7 @@
clojure.core.async/take!
clojure.core.async/to-chan!
clojure.core.async/to-chan!!
;; only writes .clj-kondo/ratchets.edn, from a :once fixture that finishes before the parallel tests
;; writes the ratchet files from a :once fixture that finishes before the parallel tests
dev.kondo-ratchet/fix!
metabase.ai-tracing.core/record!
metabase.api.macros.defendpoint.tools-manifest/assert-optional-fields-nullable!
@@ -191,6 +192,8 @@
metabase.channel.render.pdf.font/load-fonts!
metabase.warehouses.models.database/assert-not-h2!
metabase.driver.sql-jdbc.execute/execute-prepared-statement!
;; only inspects a details map and throws; the `!` is for the throw, not for a mutation
metabase.driver/validate-db-details!
metabase.mcp.usage/record-mcp-session!
metabase.mcp.usage/record-mcp-session-end!
metabase.mcp.usage/record-mcp-tool-call!
@@ -467,6 +470,7 @@
metabase-enterprise.serialization.metadata-file-import.wire-format-test/with-tiny-fixture! clojure.core/fn
metabase-enterprise.serialization.test-util/with-dbs clojure.core/fn
metabase-enterprise.serialization.test-util/with-random-dump-dir clojure.core/let
metabase-enterprise.tenants.pulse-api-test/with-tenant-pulse-fixture! clojure.core/fn
metabase-enterprise.workspaces.test-util/with-resources! clojure.core/let
metabase-enterprise.workspaces.test-util/with-workspaces! clojure.core/let
metabase.actions.test-util/with-actions clojure.core/let
@@ -496,6 +500,7 @@
metabase.notification.test-util/with-card-notification clojure.core/let
metabase.notification.test-util/with-system-event-notification! clojure.core/let
metabase.notification.test-util/with-temp-notification clojure.core/let
metabase.oauth-server.test-util/with-oauth-client clojure.core/fn
metabase.osi.ai-context.api-test/with-test-entry clojure.core/let
metabase.premium-features.core/defenterprise-schema clj-kondo.lint-as/def-catch-all
metabase.premium-features.defenterprise/defenterprise-schema clj-kondo.lint-as/def-catch-all
@@ -629,6 +634,45 @@
metabase.lib.schema.mbql-clause/define-tuple-mbql-clause hooks.metabase.lib.schema.mbql-clause/define-mbql-clause
methodical.core/defmethod hooks.metabase.toucan.table-name/lint-defmethod
methodical.macros/defmethod hooks.metabase.toucan.table-name/lint-defmethod
metabase.app-db.core/query hooks.metabase.toucan.db-ns/lint-query-call
metabase.app-db.core/streaming-reducible-query hooks.metabase.toucan.db-ns/lint-query-call
metabase.app-db.core/select-or-insert! hooks.metabase.toucan.db-ns/lint-query-call
metabase.app-db.core/update-or-insert! hooks.metabase.toucan.db-ns/lint-query-call
metabase.app-db.core/current-timestamp-string hooks.metabase.toucan.db-ns/lint-query-call
metabase.app-db.query/query hooks.metabase.toucan.db-ns/lint-query-call
metabase.app-db.query/streaming-reducible-query hooks.metabase.toucan.db-ns/lint-query-call
metabase.app-db.query/select-or-insert! hooks.metabase.toucan.db-ns/lint-query-call
metabase.app-db.query/update-or-insert! hooks.metabase.toucan.db-ns/lint-query-call
metabase.app-db.query/current-timestamp-string hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/count hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/delete! hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/exists? hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/insert! hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/insert-returning-instance! hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/insert-returning-instances! hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/insert-returning-pk! hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/insert-returning-pks! hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/query hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/query-one hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/reducible-query hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/reducible-select hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/reducible-update hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/reducible-update-returning-pks hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/save! hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-fn->fn hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-fn->pk hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-fn-reducible hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-fn-set hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-fn-vec hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-one hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-one-fn hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-one-pk hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-pk->fn hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-pks-set hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/select-pks-vec hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/update! hooks.metabase.toucan.db-ns/lint-query-call
toucan2.core/update-returning-pks! hooks.metabase.toucan.db-ns/lint-query-call
metabase.lib.test-util.macros/$ids hooks.metabase.test.data/$ids
metabase.lib.test-util.macros/mbql-query hooks.metabase.test.data/mbql-query
metabase.lib.test-util.macros/mbql-5-query hooks.metabase.test.data/mbql-query
@@ -800,7 +844,7 @@
:name test-namespaces}
{:pattern "^(?!.*-test(?:\\..*)?$)(?!.*test-util)(?!^metabase\\.test.*).*$"
:name source-namespaces}
{:pattern "(?:(?:^metabase\\.cmd.*)|(?:^build.*)|(?:^metabuild-common.*)|(?:^release.*)|(?:^i18n.*)|(?:^lint-migrations-file$))|(?:^mage.*)|(?:^load-namespaces.*)"
{:pattern "(?:(?:^metabase\\.cmd.*)|(?:^build.*)|(?:^metabuild-common.*)|(?:^release.*)|(?:^i18n.*)|(?:^lint-migrations-file$))|(?:^mage.*)|(?:^load-namespaces.*)|(?:^dev\\..*)"
:name printable-namespaces}
{:pattern "^metabase\\.(?:(?:lib)|(?:legacy-mbql))\\..*"
:name metabase-lib}
@@ -837,7 +881,13 @@
{:pattern "^metabase(?:((?:-enterprise\\.sandbox)?\\.query-processor)|(?:\\.driver\\.sql(?!server)(?!ite))).*-test$"
:name general-qp-and-driver-test-namespaces}
{:pattern "(?:^mage.*)"
:name mage-namespaces}]
:name mage-namespaces}
;;
;; the app-db module is the application database layer itself (connections, migrations, encryption), so it gets to
;; run Toucan 2 queries anywhere.
;;
{:pattern "^metabase\\.app-db\\..*"
:name app-db-namespaces}]
:config-in-ns
{test-namespaces
@@ -847,6 +897,7 @@
:private-call {:level :off}
:metabase/defsetting-must-specify-export {:level :off}
:metabase/defsetting-namespace {:level :off}
:metabase/t2-query-namespace {:level :off}
:metabase/test-helpers-use-non-thread-safe-functions {:level :warning} ; more config in `.clj-kondo/config/test-helpers/config.edn`
:discouraged-var
@@ -854,6 +905,9 @@
metabase.lib.convert/->legacy-MBQL {:level :off}
metabase.lib.core/->legacy-MBQL {:level :off}}}}
app-db-namespaces
{:linters {:metabase/t2-query-namespace {:level :off}}}
;; .cljc tests run in both Clojure and ClojureScript — `with-dynamic-fn-redefs` is JVM-only,
;; so leave these alone.
metabase.lib.aggregation-test

File diff suppressed because it is too large Load Diff

View File

@@ -0,0 +1,6 @@
;; Budgets for escape hatches in config.edn. Counts may fall but not exceed these values.
;; Leave reductions to the post-merge shrink workflow; explain increases in the PR.
{:api-any 1
:friend-edges 22
:model-imports-bypass 2
:uses-any 4}

View File

@@ -58,6 +58,7 @@
metabase.app-db.core/finish-db-setup!
metabase.app-db.core/migrate!
metabase.app-db.core/setup-db!
metabase.app-db.encryption-test-util/do-with-encrypted-app-db!
metabase.app-db.schema-migrations-test.impl/run-migrations-in-range!
metabase.app-db.setup/migrate!
metabase.app-db.setup/setup-db!

View File

@@ -1,47 +1,81 @@
;; Per-linter budgets for inline `:clj-kondo/ignore` forms.
;; metabase.core.kondo-ratchet-test fails when the budgets drift from the actual counts.
;; `./bin/mage fix-kondo-ratchets` lowers budgets to match the tree; local test runs do it
;; automatically. Raising a budget, or adding one for a new linter (`--seed`), is a hand edit
;; to defend in your PR.
;; Budgets for kondo suppressions: inline `:clj-kondo/ignore` forms per linter (:ignore-counts), and
;; config-level waivers in .clj-kondo/config.edn (:config-counts -- :off switches and :exclude entries).
;; Each :ignore-counts value is a non-negative integer budget, or :unlimited for no ceiling.
;; Checks fail when a count exceeds its numeric budget; unused budget is allowed.
;; Any ignore outside :comment-exempt needs an explanatory comment directly above or trailing on its line.
;; `./bin/mage kondo-ratchets-shrink` lowers budgets unless `--seed` explicitly adds or raises one.
;; The workflow runs it on master, so feature branches do not need to record reductions.
;; Raising or adding a budget (`--seed` for inline ignores, a manual edit otherwise) or widening the
;; exemptions must be explained in the PR.
;; :all is the vector-less ignore form, which suppresses every linter on the next form.
{:ignore-counts {:aliased-namespace-symbol 3
:all 48
:case-symbol-test 1
:clojure-lsp/unused-public-var 9
:def-fn 1
:deprecated-namespace 95
:deprecated-var 84
:discouraged-java-method 3
:discouraged-namespace 81
:discouraged-var 111
:equals-true 1
:main-without-gen-class 1
:metabase/defsetting-namespace 2
:metabase/disallow-hardcoded-driver-names-in-tests 34
:metabase/discourage-millis-duration 1
:metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests 13
:metabase/modules 7
:metabase/namespace-name 4
:metabase/prefer-with-dynamic-fn-redefs 28
:metabase/test-helpers-use-non-thread-safe-functions 17
:metabase/validate-defendpoint-has-response-schema 440
:metabase/validate-defendpoint-query-params-use-kebab-case 50
:metabase/validate-defendpoint-route-uses-kebab-case 44
:metabase/validate-deftest 10
:missing-docstring 10
:missing-protocol-method 3
:non-arg-vec-return-type-hint 1
:reduce-without-init 3
:syntax 2
:uninitialized-var 1
:unquote-not-syntax-quoted 1
:unresolved-namespace 3
:unresolved-require 1
:unresolved-symbol 4
:unsorted-required-namespaces 1
:unused-alias 1
:unused-binding 9
:unused-excluded-var 2
:unused-namespace 1
:unused-private-var 9
:unused-value 1}}
{:ignore-counts {:aliased-namespace-symbol 3
:case-symbol-test 1
:clojure-lsp/unused-public-var 9
:consistent-alias 2
:def-fn 1
:deprecated-namespace 95
:deprecated-var 86
:discouraged-java-method 4
:discouraged-namespace 71
:discouraged-var 130
:duplicate-require 1
:equals-true 1
:main-without-gen-class 1
:metabase/defsetting-namespace 1
:metabase/disallow-hardcoded-driver-names-in-tests 34
:metabase/discourage-millis-duration 1
:metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests 13
:metabase/modules 23
:metabase/namespace-name 4
:metabase/prefer-with-dynamic-fn-redefs 28
:metabase/test-helpers-use-non-thread-safe-functions 18
:metabase/validate-defendpoint-has-response-schema 427
:metabase/validate-defendpoint-query-params-use-kebab-case 48
:metabase/validate-defendpoint-route-uses-kebab-case 44
:metabase/validate-deftest 10
:missing-docstring 12
:missing-protocol-method 3
:non-arg-vec-return-type-hint 1
:reduce-without-init 3
:redundant-do 1
:syntax 2
:type-mismatch 8
:uninitialized-var 1
:unquote-not-syntax-quoted 1
:unresolved-namespace 3
:unresolved-symbol 11
:unsorted-required-namespaces :unlimited
:unused-alias 2
:unused-binding 9
:unused-excluded-var 2
:unused-namespace 2
:unused-private-var 8
:unused-value 1}
:config-counts {:constant-condition 1
:deprecated-namespace 7
:deprecated-var 16
:discouraged-namespace 14
:discouraged-var 14
:inline-def 1
:main-without-gen-class 1
:metabase/defsetting-must-specify-export 1
:metabase/defsetting-namespace 1
:metabase/prefer-with-dynamic-fn-redefs 3
:metabase/t2-query-namespace 2
:missing-docstring 1
:private-call 1
:redundant-ignore 1
:redundant-primitive-coercion 1
:refer-all 1
:type-mismatch 1
:unexpected-recur 1
:unresolved-symbol 19
:unresolved-var 1
:unused-referred-var 4}
:comment-exempt #{:deprecated-namespace
:discouraged-namespace
:discouraged-var
:metabase/modules
:metabase/validate-defendpoint-has-response-schema
:metabase/validate-defendpoint-query-params-use-kebab-case
:metabase/validate-defendpoint-route-uses-kebab-case}}

View File

@@ -92,7 +92,7 @@
(defn- lint-modules [ns-form-node config]
(let [ns-symb (ns-form-node->ns-symb ns-form-node)]
(when-not (modules/ignored-namespace? config ns-symb)
(when-let [current-module (modules/module ns-symb)]
(when-let [current-module (modules/module config ns-symb)]
(let [required-namespace-symb-nodes (-> ns-form-node
ns-form-node->require-node
require-node->namespace-symb-nodes)]

View File

@@ -11,15 +11,32 @@
(every? simple-symbol? required-namespaces)]}
(when-not (modules/ignored-namespace? config current-ns)
;; ignore namespaces outside of the module system
(when-let [current-module (modules/module current-ns)]
(when-let [current-module (modules/module config current-ns)]
(doseq [required-namespace required-namespaces]
;; ignore namespaces outside of the module system.
(when (modules/module required-namespace)
(when (modules/module config required-namespace)
(when-let [error (modules/usage-error config current-module required-namespace)]
(hooks/reg-finding! (assoc (meta node)
:message error
:type :metabase/modules))))))))
(defn- lint-dynamic-require* [node current-ns config]
(when (and (not (modules/ignored-namespace? config current-ns))
(modules/module config current-ns))
(hooks/reg-finding! (assoc (meta node)
:message "Module dependency cannot be statically determined from a dynamic require"
:type :metabase/modules))))
(defn- quoted-require? [node]
(or (= (hooks/tag node) :quote)
(and (= (hooks/tag node) :list)
(let [[x] (:children node)]
(and (hooks/token-node? x)
(= (hooks/sexpr x) 'quote))))))
(defn- keyword-node? [node]
(keyword? (hooks/sexpr node)))
(defn- unwrap-require [node]
(case (hooks/tag node)
;; some.namespace of some.namespace/some-var
@@ -42,7 +59,11 @@
;; something like [some.namespace :as whatever]
:vector
(recur (first (:children node)))))
(recur (first (:children node)))
;; anything else -- e.g. a runtime expression like `(requiring-resolve (:failing-test-var opts))` --
;; has no statically-known namespace
nil))
(comment
(unwrap-require (-> "(requiring-resolve 'metabase.notification.payload.execute/execute-dashboard)"
@@ -51,20 +72,24 @@
second)))
(defn- lint-require* [node current-ns config]
(let [[_require & args] (:children node)
required-namespaces (->> (keep unwrap-require args)
;; `require` runs through `cc/load-libs` which allows
;; #{:as :reload :reload-all :require :use :verbose :refer :as-alias}
;; as args. If you use a REPL tool that applies clj-kondo linting (e.g., Clojure MCP)
;; you may wish to `:reload` or `:reload-all` a namespace. So we shouldn't assume all
;; args are keywords:
(remove keyword?))]
(lint* node current-ns config required-namespaces)))
(let [[_require & args] (:children node)
;; Keywords such as `:reload` and `:reload-all` are options, not namespace dependencies.
namespace-nodes (remove keyword-node? args)
static-nodes (filter quoted-require? namespace-nodes)
required-namespaces (->> (keep unwrap-require static-nodes)
(filter simple-symbol?))]
(lint* node current-ns config required-namespaces)
(when (or (not= (count static-nodes) (count namespace-nodes))
(not= (count required-namespaces) (count static-nodes)))
(lint-dynamic-require* node current-ns config))))
(defn- lint-requiring-resolve* [node current-ns config]
(let [[_requiring-resolve symb-node] (:children node)
required-namespace (unwrap-require symb-node)]
(lint* node current-ns config [required-namespace])))
(if (and (quoted-require? symb-node)
(simple-symbol? required-namespace))
(lint* node current-ns config [required-namespace])
(lint-dynamic-require* node current-ns config))))
(defn lint-require [x]
(lint-require* (:node x) (:ns x) (modules/config x))

View File

@@ -171,6 +171,7 @@
(str/starts-with? (name ns-symb) prefix))
["build-drivers."
"build."
"hooks." ; clj-kondo hook tests, outside the module system
"i18n." ; bin/i18n
"lint-migrations-file-test"
"load-namespaces." ; bin/load-namespaces
@@ -193,7 +194,7 @@
(not (contains? @warned-namespaces ns-symb)))
(swap! warned-namespaces conj ns-symb)
(let [known-modules (set (keys (:metabase/modules (modules/config input))))
current-module (modules/module ns-symb)]
current-module (modules/module (modules/config input) ns-symb)]
(when (or (not current-module)
(not (contains? known-modules current-module)))
(hooks/reg-finding! (assoc (meta node)

View File

@@ -1,4 +1,8 @@
(ns hooks.common.modules
"Resolves namespaces to modules and enforces module boundaries.
The Kondo linter, config generator, and CI tooling share this namespace so
they apply the same rules."
(:require
[clojure.string :as str]))
@@ -12,25 +16,130 @@
(merge (get-in config [:linters :metabase/modules])
(select-keys config [:metabase/modules])))
(defn module
;;;; Module tree. These functions take the `:metabase/modules` map, or the prefix map built from it.
;;;;
;;;; Dots express nesting: `lib.schema` is a child of `lib`. A declared
;;;; `enterprise/X` module is also a child of OSS module `X`. A namespace
;;;; belongs to the module with the most specific matching `:ns-prefix`.
(defn default-ns-prefix
"Namespace prefix a module owns unless it sets `:ns-prefix`: `metabase.lib.schema` for `lib.schema`,
`metabase-enterprise.foo` for `enterprise/foo`."
[module]
(str (if (= "enterprise" (namespace module)) "metabase-enterprise." "metabase.") (name module)))
(defn module-ns-prefix
"Namespace prefix `module` owns: its `:ns-prefix`, else [[default-ns-prefix]]."
[modules module]
(or (get-in modules [module :ns-prefix])
(default-ns-prefix module)))
(defn build-prefix->module
"Map each declared namespace prefix to its module, for [[declared-module]]."
[modules]
(into {}
(map (fn [module] [(module-ns-prefix modules module) module]))
(keys modules)))
(defn declared-module
"Resolve `ns-symb` to its declared module, or `nil`.
Chooses the most specific dotted prefix and ignores a trailing `-test`."
[prefix->module ns-symb]
(loop [candidate (str/replace (str ns-symb) #"-test$" "")]
(or (get prefix->module candidate)
(when-let [dot (str/last-index-of candidate ".")]
(recur (subs candidate 0 dot))))))
(defn resolve-module
"E.g.
(module 'metabase.qp.middleware.wow) => 'qp
(module 'metabase-enterprise.whatever.core) => enterprise/whatever"
[ns-symb]
(resolve-module prefix->module 'metabase.qp.middleware.wow) => 'qp
(resolve-module prefix->module 'metabase-enterprise.whatever.core) => enterprise/whatever
An unmatched Metabase namespace resolves to its first segment so the linter can report an undeclared module."
[prefix->module ns-symb]
{:pre [(simple-symbol? ns-symb)]}
;; treat something like `metabase.driver-test` (for a module that hasn't fully been updated to use `.core`
;; namespaces) as being in the `driver` module
(let [ns-symb (if (str/ends-with? (name ns-symb) "-test")
(symbol (str/replace (name ns-symb) #"-test$" ""))
ns-symb)]
(or (some->> (re-find #"^metabase-enterprise\.([^.]+)" (str ns-symb))
(or (declared-module prefix->module ns-symb)
(some->> (re-find #"^metabase-enterprise\.([^.]+)" (str ns-symb))
second
(symbol "enterprise"))
(some-> (re-find #"^metabase\.([^.]+)" (str ns-symb))
second
symbol))))
(defn parent-module
"The direct parent of `module`, or `nil` when it is top-level."
[modules module]
(let [module-name (name module)]
(if-let [dot (str/last-index-of module-name ".")]
(symbol (namespace module) (subs module-name 0 dot))
(when (= "enterprise" (namespace module))
(let [oss (symbol module-name)]
(when (contains? modules oss)
oss))))))
(defn descendant-of?
"Whether `module` is `ancestor` or one of its descendants."
[modules module ancestor]
(boolean (some #{ancestor} (take-while some? (iterate #(parent-module modules %) module)))))
(defn- exports-child?
[modules parent child]
(or (contains? (set (get-in modules [parent :module-exports])) child)
;; OSS module `X` implicitly exports its `enterprise/X` companion.
(and (not= (namespace parent) (namespace child))
(contains? modules child))))
(defn- blocking-export
"The first missing export from `module` toward the root.
Returns `{:ancestor parent, :child child}`, or `nil` when every link is
exported."
[modules module]
(loop [child module]
(when-let [ancestor (parent-module modules child)]
(if (exports-child? modules ancestor child)
(recur ancestor)
{:ancestor ancestor, :child child}))))
(defn namability-error
"Explain why `caller` may not refer to `target` in `:uses`, or return `nil` if it may.
A nested module is private to the nearest ancestor with a missing export.
Exporting every link makes it public."
[modules caller target]
(when-let [{:keys [ancestor child]} (blocking-export modules target)]
(when-not (descendant-of? modules caller ancestor)
(format (str "Module %s is nested and not exported by its ancestors; %s may not use it. Add %s to %s's "
":module-exports, or move the caller into the %s subtree. [:metabase/modules %s :module-exports]")
target caller child ancestor ancestor ancestor))))
;;;; Lint rules. These functions take the full linter config.
(defonce ^:private prefix->module-cache
(atom nil))
(defn- prefix->module
"[[build-prefix->module]] for `config`, cached because Kondo hands every hook call the same `:metabase/modules` map."
[config]
(let [modules (:metabase/modules config)
cached @prefix->module-cache]
(if (identical? modules (:modules cached))
(:prefix->module cached)
(:prefix->module (reset! prefix->module-cache {:modules modules
:prefix->module (build-prefix->module modules)})))))
(defn module
"Resolve `ns-symb` to its module under `config`; see [[resolve-module]]."
[config ns-symb]
(resolve-module (prefix->module config) ns-symb))
(defn- module-api-namespaces
"Set of API namespace symbols for a given module. `:any` means you can use anything, there are no API namespaces for
this module (yet). If unspecified, the default is just the `<module>.core` namespace."
@@ -44,9 +153,7 @@
module-config
:else
(let [ns-prefix (if (= (namespace module) "enterprise")
(str "metabase-enterprise." (name module))
(name module))]
(let [ns-prefix (module-ns-prefix (:metabase/modules config) module)]
#{(symbol (str ns-prefix ".api"))
(symbol (str ns-prefix ".core"))
(symbol (str ns-prefix ".init"))}))))
@@ -68,15 +175,17 @@
(contains? (set allowed-modules) required-module))))
(defn- allowed-module-namespace? [config current-module ns-symb]
(let [module (module ns-symb)
(let [module (module config ns-symb)
module-api-namespaces (module-api-namespaces config module)
module-friends (module-friends config module)]
(or (nil? module-api-namespaces)
(contains? module-api-namespaces ns-symb)
(contains? module-friends current-module))))
(contains? module-friends current-module)
;; a child may use its ancestors' internals; a parent still goes through its child's `:api`
(descendant-of? (:metabase/modules config) current-module module))))
(defn- rest-module? [module]
(str/ends-with? module "-rest"))
(re-find #"[.-]rest$" (str module)))
(defn- routes-module? [module]
(str/ends-with? module "-routes"))
@@ -89,7 +198,7 @@
error type if there is one, otherwise `nil` if there are no errors."
[config current-module required-namespace]
;; ignore stuff not in a module i.e. non-Metabase stuff.
(when-let [required-module (module required-namespace)]
(when-let [required-module (module config required-namespace)]
(when-not (= current-module required-module)
(cond
(not (allowed-module? config current-module required-module))
@@ -113,4 +222,8 @@
required-module
current-module
required-module
(symbol (str/replace required-module #"-rest$" "")))))))
(symbol (str/replace required-module #"[.-]rest$" "")))
;; Config tests check explicit `:uses`; wildcard callers are checked here.
(= :any (allowed-modules config current-module))
(namability-error (:metabase/modules config) current-module required-module)))))

View File

@@ -4,9 +4,9 @@
[hooks.common :as common]))
(defn lint-defsetting-namespace [node context]
(when-not (re-matches #"^metabase(?:-enterprise)?\.[^\.]+\.settings$" (name (:ns context)))
(when-not (re-matches #"^metabase(?:-enterprise)?\.([^\.]+\.)+settings$" (name (:ns context)))
(hooks/reg-finding! (assoc (meta node)
:message "All defsettings should live in metabase[-enterprise].<module>.settings namespaces"
:message "All defsettings should live in a namespace ending in .settings under metabase[-enterprise]"
:type :metabase/defsetting-namespace))))
;;; TODO -- move this into a Kondo config file in `.clj-kondo/config/`
@@ -286,6 +286,7 @@
(update context :node update-node)))
(comment
(require '[clojure.pprint])
(defn- defsetting* [form]
(hooks/sexpr
(:node
@@ -293,7 +294,6 @@
{:node
(hooks/parse-string
(with-out-str
#_{:clj-kondo/ignore [:unresolved-namespace]}
(clojure.pprint/pprint
form)))}))))

View File

@@ -0,0 +1,45 @@
(ns hooks.metabase.toucan.db-ns
"Lint that application database query calls -- Toucan 2's `t2/select`, `t2/query`, `t2/insert!`, `t2/update!`,
`t2/delete!` and friends, plus the `metabase.app-db.core` wrappers around them such as `mdb/query` and
`mdb/update-or-insert!` -- live in a module's `db` namespace, i.e. `metabase[-enterprise].<module>.db` (or `metabase.driver.<driver>.db` for
driver modules). Every other namespace in a module goes through those functions instead of talking to the
application database directly.
Registered as an `:analyze-call` hook on each of those functions in `.clj-kondo/config.edn`. The hook
returns its input unchanged so Kondo's normal analysis of the call (arity, var usage) still runs."
(:require
[clj-kondo.hooks-api :as hooks]
[hooks.common.modules :as modules]))
(def ^:private driver-db-namespace
"Matches `metabase.driver.<driver>.db`; individual drivers are not modules."
#"^metabase\.driver\.[^.]+\.db$")
(defn- db-namespace? [config ns-sym]
(let [ns-str (name ns-sym)]
(boolean
;; Resolve ownership first: a nested `.db` name alone does not make a module.
(or (when-let [module (modules/module config ns-sym)]
(= ns-str (str (modules/module-ns-prefix (:metabase/modules config) module) ".db")))
(re-matches driver-db-namespace ns-str)))))
(defn- test-file?
"Whether `filename` is in a test source tree. Test namespaces are exempt through the `test-namespaces` group in
`config.edn`, but helper namespaces like `metabase.sso.test-helpers` don't match that group's pattern."
[filename]
(boolean (and filename (re-find #"(?:^|/)test/" filename))))
(defn lint-query-call
"Register a `:metabase/t2-query-namespace` finding when a Toucan 2 query call appears outside a `<module>.db`
namespace."
[{:keys [node ns filename] :as input}]
(when (and ns
(not (db-namespace? (modules/config input) ns))
(not (test-file? filename)))
(let [fn-node (first (:children node))]
(hooks/reg-finding!
(assoc (meta fn-node)
:message (format "Application database query calls like `%s` must live in metabase[-enterprise].<module>.db (or metabase.driver.<driver>.db) namespaces"
(hooks/sexpr fn-node))
:type :metabase/t2-query-namespace))))
input)

View File

@@ -0,0 +1,65 @@
(ns hooks.clojure.core.require-test
(:require
[clj-kondo.hooks-api :as hooks]
[clj-kondo.impl.utils]
[clojure.test :refer :all]
[hooks.clojure.core.require]))
(def ^:private config
'{:linters {:metabase/modules {:level :warning}}
:metabase/modules {search {:uses #{}}
task {:api #{metabase.task.core}}}})
(defn- lint [hook form current-ns]
(binding [clj-kondo.impl.utils/*ctx* {:config config
:ignores (atom nil)
:findings (atom [])
:namespaces (atom {})}]
(hook {:node (hooks/parse-string (pr-str form))
:ns current-ns
:config config})
@(:findings clj-kondo.impl.utils/*ctx*)))
(defn- lint-require [form current-ns]
(lint hooks.clojure.core.require/lint-require form current-ns))
(defn- lint-requiring-resolve [form current-ns]
(lint hooks.clojure.core.require/lint-requiring-resolve form current-ns))
(def ^:private dynamic-require-finding
{:message "Module dependency cannot be statically determined from a dynamic require"
:type :metabase/modules})
(def ^:private cross-module-finding
{:message "Module task should not be used in the search module. [:metabase/modules search :uses]"
:type :metabase/modules})
(deftest ^:parallel dynamic-requiring-resolve-test
(testing "outside the module system"
(is (= [] (lint-requiring-resolve '(requiring-resolve (:failing-test-var opts)) 'dev))))
(testing "inside a module"
(are [form] (=? [dynamic-require-finding]
(lint-requiring-resolve form 'metabase.search.core))
'(requiring-resolve (:failing-test-var opts))
'(requiring-resolve @some-atom)
'(requiring-resolve some-local)
'(requiring-resolve "not-a-symbol"))))
(deftest ^:parallel dynamic-require-test
(testing "outside the module system"
(is (= [] (lint-require '(require some-local) 'dev))))
(testing "inside a module"
(is (=? [dynamic-require-finding]
(lint-require '(require some-local) 'metabase.search.core)))))
(deftest ^:parallel static-requiring-resolve-still-linted-test
(is (=? [cross-module-finding]
(lint-requiring-resolve '(requiring-resolve 'metabase.task.impl/go)
'metabase.search.core))
"a statically-known cross-module violation is still reported"))
(deftest ^:parallel static-require-still-linted-test
(is (=? [cross-module-finding]
(lint-require '(require 'metabase.task.impl :reload)
'metabase.search.core))
"a statically-known cross-module violation is still reported while keyword flags are ignored"))

View File

@@ -5,6 +5,6 @@
(deftest ^:parallel module-test
(are [symb expected] (= expected
(hooks.common.modules/module symb))
(hooks.common.modules/module {} symb))
'metabase.qp.middleware.wow 'qp
'metabase-enterprise.whatever.core 'enterprise/whatever))

View File

@@ -0,0 +1,73 @@
(ns hooks.metabase.toucan.db-ns-test
(:require
[clj-kondo.hooks-api :as hooks]
[clj-kondo.impl.utils]
[clojure.test :refer :all]
[hooks.metabase.toucan.db-ns :as toucan.db-ns]))
(defn- lint-query-call [form ns-sym & [filename modules]]
(binding [clj-kondo.impl.utils/*ctx* {:config {:linters {:metabase/t2-query-namespace {:level :warning}}}
:ignores (atom nil)
:findings (atom [])
:namespaces (atom {})}]
(let [input {:node (hooks/parse-string (pr-str form))
:ns ns-sym
:filename (or filename "src/metabase/foo/bar.clj")
:config {:metabase/modules modules}}
output (toucan.db-ns/lint-query-call input)]
(is (identical? (:node input) (:node output))
"the hook must return the node unchanged so Kondo's normal analysis still runs")
@(:findings clj-kondo.impl.utils/*ctx*))))
(deftest ^:parallel t2-query-must-live-in-db-namespace-test
(testing "a query call outside a db namespace is flagged"
(is (=? [{:type :metabase/t2-query-namespace
:message #".*`t2/select-one`.*"}]
(lint-query-call '(t2/select-one :model/Card :id 1) 'metabase.queries.models.card))))
(testing "metabase.<module>.db is allowed"
(is (empty? (lint-query-call '(t2/select-one :model/Card :id 1) 'metabase.queries.db))))
(testing "metabase-enterprise.<module>.db is allowed"
(is (empty? (lint-query-call '(t2/select-one :model/Card :id 1) 'metabase-enterprise.sandbox.db))))
(testing "metabase.driver.<driver>.db is allowed for driver modules"
(is (empty? (lint-query-call '(t2/select-one :model/Database :id 1) 'metabase.driver.bigquery-cloud-sdk.db))))
(testing "a nested db namespace is not a module db namespace"
(is (=? [{:type :metabase/t2-query-namespace}]
(lint-query-call '(t2/query {:select [:*]}) 'metabase.queries.models.db))))
(testing "a namespace merely ending in db is not a module db namespace"
(is (=? [{:type :metabase/t2-query-namespace}]
(lint-query-call '(t2/delete! :model/Card :id 1) 'metabase.queries.dashboards-db))))
(testing "files in a test source tree are exempt even when the namespace name doesn't look like a test"
(is (empty? (lint-query-call '(t2/update! :model/User 1 {:sso_source nil}) 'metabase.sso.test-helpers
"test/metabase/sso/test_helpers.clj")))
(is (empty? (lint-query-call '(t2/select :model/Card) 'metabase-enterprise.remote-sync.test-helpers
"/repo/enterprise/backend/test/metabase_enterprise/remote_sync/test_helpers.clj"))))
(testing "app-db wrappers around Toucan 2 are reported the same way"
(is (=? [{:type :metabase/t2-query-namespace
:message #".*`mdb/update-or-insert!`.*"}]
(lint-query-call '(mdb/update-or-insert! :model/Foo {:id 1}) 'metabase.foo.models.foo))))
(testing "fully-qualified calls are reported by their written name"
(is (=? [{:type :metabase/t2-query-namespace
:message #".*`toucan2.core/insert!`.*"}]
(lint-query-call '(toucan2.core/insert! :model/Card {}) 'metabase.queries.models.card)))))
(deftest ^:parallel t2-query-namespace-follows-the-module-tree-test
(let [modules '{queries {}
metabot {}
metabot.llm {}
lib.be {:ns-prefix "metabase.lib-be"}
enterprise/sandbox {}}]
(testing "a nested module owns its own db namespace"
(is (empty? (lint-query-call '(t2/select :model/Card) 'metabase.metabot.llm.db nil modules))))
(testing "the parent's db namespace stays its own"
(is (empty? (lint-query-call '(t2/select :model/Card) 'metabase.metabot.db nil modules))))
(testing "a module with an explicit :ns-prefix is resolved through it, not its dotted name"
(is (empty? (lint-query-call '(t2/select :model/Card) 'metabase.lib-be.db nil modules)))
(is (=? [{:type :metabase/t2-query-namespace}]
(lint-query-call '(t2/select :model/Card) 'metabase.lib.be.db nil modules))))
(testing "a db namespace under a directory naming no module is still a finding"
(is (=? [{:type :metabase/t2-query-namespace}]
(lint-query-call '(t2/query {:select [:*]}) 'metabase.queries.models.db nil modules)))
(is (=? [{:type :metabase/t2-query-namespace}]
(lint-query-call '(t2/query {:select [:*]}) 'metabase.metabot.llm.models.db nil modules))))
(testing "enterprise modules resolve through the metabase-enterprise root"
(is (empty? (lint-query-call '(t2/select :model/Card) 'metabase-enterprise.sandbox.db nil modules))))))

View File

@@ -16,7 +16,7 @@ skip =
frontend/src/metabase/querying/expressions/tokenizer/lezer.js,
frontend/src/metabase/query_builder/components/NativeQueryEditor/CodeMirrorEditor/language.ts,
frontend/src/metabase/static-viz/constants/char-sizes.ts,
frontend/src/metabase/visualizations/lib/mapping_codes.ts,
frontend/src/metabase/viz-core/lib/mapping_codes.ts,
frontend/*/mocks/*,
modules/drivers/mongo/src/metabase/driver/mongo/operators.clj,
src/metabase/analyze/classifiers/name.clj,

13
.github/CODEOWNERS vendored
View File

@@ -42,6 +42,7 @@ docs/api.json # auto-generated
docs/configuring-metabase/environment-variables.md # auto-generated
docs/configuring-metabase/config-template.md # auto-generated
docs/installation-and-operation/commands.md # auto-generated
docs/ai/providers.md # auto-generated
docs/embedding/sdk/api # auto-generated
docs/embedding/eajs/snippets # auto-generated
@@ -54,3 +55,15 @@ src/metabase/analytics/prometheus.clj @metabase/cloud-ops
# @metabase/metabot-frontend
enterprise/frontend/src/metabase-enterprise/metabot @metabase/metabot-frontend
frontend/src/metabase/metabot @metabase/metabot-frontend
# @metabase/core-frontend-gadget
bin/custom-viz @metabase/core-frontend-gadget
docs/developers-guide/custom-visualizations.md @metabase/core-frontend-gadget
enterprise/frontend/src/custom-viz @metabase/core-frontend-gadget
enterprise/frontend/src/metabase-enterprise/api/custom-viz-plugin.ts @metabase/core-frontend-gadget
enterprise/frontend/src/metabase-enterprise/custom_viz @metabase/core-frontend-gadget
frontend/src/metabase-types/api/custom-viz-plugin.ts @metabase/core-frontend-gadget
frontend/src/metabase/plugins/oss/custom-viz.ts @metabase/core-frontend-gadget
frontend/src/metabase/visualizations/custom-visualizations @metabase/core-frontend-gadget
frontend/test/__support__/custom-viz-fixtures @metabase/core-frontend-gadget
.github/workflows/release-custom-viz.yml @metabase/devexp @metabase/core-frontend-gadget

View File

@@ -8,6 +8,12 @@ paths:
# GitHub added parallel steps (`parallel`, `background`, `wait`, `wait-all`,
# `cancel`) in June 2026, and actionlint 1.7.12 does not know the schema yet:
# https://github.blog/changelog/2026-06-25-actions-steps-can-now-be-run-in-parallel/
.github/workflows/backend.yml:
ignore:
- 'step must run script with "run" section or run action with "uses" section'
.github/workflows/lint.yml:
ignore:
- 'step must run script with "run" section or run action with "uses" section'
.github/workflows/pr.checks.yml:
ignore:
- 'step must run script with "run" section or run action with "uses" section'

View File

@@ -25,6 +25,8 @@ runs:
COMMIT: ${{ inputs.backport-commit }}
shell: bash
run: | # bash
source "${{ github.action_path }}/kondo-ratchets.sh"
git config --global user.email "metabase-bot@metabase.com"
git config --global user.name "Metabase bot"
@@ -34,7 +36,7 @@ runs:
git checkout ${TARGET_BRANCH}
git fetch --all
git checkout -b ${BACKPORT_BRANCH}
git cherry-pick ${COMMIT} || true
cherry_pick_backport "${COMMIT}"
CONFLICT_LIST=$(git ls-files -u)
@@ -46,10 +48,7 @@ runs:
echo "has-conflicts=true" >> "$GITHUB_OUTPUT"
# Add a shell script for resolving conflicts
echo "git reset HEAD~1" > ./backport.sh
echo "rm ./backport.sh" >> ./backport.sh
echo "git cherry-pick ${COMMIT}" >> ./backport.sh
echo "echo 'Resolve conflicts and force push this branch.\n\nTo backport translations run: bin/i18n/merge-translations <release-branch>'" >> ./backport.sh
write_backport_script "${COMMIT}"
chmod +x ./backport.sh
git add ./backport.sh
git commit -m "Add backport resolution script"
@@ -86,19 +85,15 @@ runs:
git checkout ${{ github.sha }}
- name: Auto approve backport PR
- name: Approve and Merge the PR
if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
uses: juliangruber/approve-pull-request-action@68fcc9a5a73b5641cadf757cf99d73720dcb05d0 # v2.1.0
with:
github-token: ${{ inputs.github-token-2 }}
number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
- name: Enable Pull Request Automerge
if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
run: gh pr merge --squash --auto "$PR_NUMBER"
run: |
gh pr review --approve "$PR_NUMBER"
gh pr merge --squash --auto "$PR_NUMBER"
shell: bash
env:
GH_TOKEN: ${{ inputs.github-token }}
# uses a different token than the token that created the PR so we can approve and merge it
GH_TOKEN: ${{ inputs.github-token-2 }}
PR_NUMBER: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
- uses: ./.github/actions/notify-pull-request

View File

@@ -0,0 +1,375 @@
#!/usr/bin/env bash
set -euo pipefail
action_dir=$(cd "$(dirname "$0")" && pwd)
cut_release_workflow="$action_dir/../../workflows/cut-release-branch.yml"
# shellcheck source=.github/actions/create-backport/kondo-ratchets.sh
source "$action_dir/kondo-ratchets.sh"
# Any editor launch fails the run, so a continuation that waits on an editor cannot pass.
export GIT_EDITOR=false
test_root=
trap '[ -z "$test_root" ] || rm -rf -- "$test_root"' EXIT
trap 'exit 129' HUP
trap 'exit 130' INT
trap 'exit 143' TERM
test_root=$(mktemp -d)
active_ratchets='{:ignore-counts {:example 1}}'
disabled_ratchets=';; Kondo ignore ratchets apply only to master; this release branch opts out.
;; The test and fixer recognize this explicit opt-out.
{:disabled true}'
# Coverage:
#
# Target state Incoming change Other conflict Expected result
# ----------------- -------------------- --------------- ------------------------------------------
# active ratchets unrelated file none leave ratchets unchanged
# active ratchets ratchets none install the release opt-out
# disabled ratchets ratchets none keep the opt-out; finish with an empty commit
# divergent ratchets ratchets none resolve ratchets and finish the cherry-pick
# divergent ratchets ratchets (on a pty) none finish without opening an editor
# active ratchets unrelated file app.txt leave the conflict for manual resolution
# divergent ratchets ratchets + app.txt app.txt resolve only ratchets
# release cut ratchets none cut and backport commit the same opt-out
# n/a cut-release workflow n/a the workflow calls the shared writer
# any invalid commit n/a propagate the cherry-pick failure
# divergent ratchets generated backport.sh app.txt resolve only ratchets through the manual script
#
# Known gaps: an older target with no ratchets file, and an incoming commit that
# deletes the ratchets file.
test_unrelated_backport_preserves_target_ratchets() (
local repo="$test_root/unrelated"
init_repo "$repo"
local commit
commit=$(feature_commit "$repo" change_app)
git -C "$repo" checkout -q release
cd "$repo"
cherry_pick_backport "$commit"
assert_eq feature "$(cat app.txt)" "the unrelated change was not cherry-picked"
assert_ratchets "$active_ratchets"
assert_cherry_pick_completed
assert_worktree_clean
)
test_clean_ratchet_backport_installs_release_opt_out() (
local repo="$test_root/clean-ratchet"
init_repo "$repo"
local commit
commit=$(feature_commit "$repo" change_ratchets)
git -C "$repo" checkout -q release
cd "$repo"
cherry_pick_backport "$commit"
assert_ratchets_disabled
assert_cherry_pick_completed
assert_worktree_clean
)
test_disabled_release_absorbs_ratchet_only_backport() (
local repo="$test_root/disabled-release"
init_repo "$repo"
local commit
commit=$(feature_commit "$repo" change_ratchets)
git -C "$repo" checkout -q release
commit_release_change "$repo" disable_release_ratchets "Disable release ratchets"
cd "$repo"
cherry_pick_backport "$commit"
assert_ratchets_disabled
assert_cherry_pick_completed
assert_empty_commit
assert_worktree_clean
)
test_ratchet_only_conflict_is_resolved() (
local repo="$test_root/ratchet-conflict"
init_repo "$repo"
local commit
commit=$(conflicting_ratchet_commit "$repo")
cd "$repo"
cherry_pick_backport "$commit"
assert_ratchets_disabled
assert_cherry_pick_completed
assert_worktree_clean
)
test_continuation_never_opens_an_editor() (
local repo="$test_root/editor"
init_repo "$repo"
local commit
commit=$(conflicting_ratchet_commit "$repo")
cd "$repo"
# Git only opens an editor for the continuation when stdin is a terminal, so run it on a pty. The
# exported GIT_EDITOR=false turns any editor launch into a failure. The single quotes are deliberate:
# $1 and $2 are for the inner bash, not this shell.
# shellcheck disable=SC2016
python3 -c 'import os, pty, sys; sys.exit(os.waitstatus_to_exitcode(pty.spawn(sys.argv[1:])))' \
bash -c 'source "$1/kondo-ratchets.sh" && cherry_pick_backport "$2"' bash "$action_dir" "$commit" >/dev/null ||
fail "the cherry-pick continuation opened an editor"
assert_ratchets_disabled
assert_cherry_pick_completed
)
test_non_ratchet_conflict_remains_manual() (
local repo="$test_root/non-ratchet-conflict"
init_repo "$repo"
local commit
commit=$(feature_commit "$repo" change_app)
git -C "$repo" checkout -q release
commit_release_change "$repo" change_release_app "Change release app"
cd "$repo"
cherry_pick_backport "$commit"
assert_ratchets "$active_ratchets"
assert_only_conflicts app.txt
assert_cherry_pick_pending
)
test_mixed_conflict_resolves_only_ratchets() (
local repo="$test_root/mixed-conflict"
init_repo "$repo"
local commit
commit=$(feature_commit "$repo" change_app_and_ratchets)
git -C "$repo" checkout -q release
commit_release_change "$repo" change_release_app_and_ratchets "Change release app and ratchets"
cd "$repo"
cherry_pick_backport "$commit"
assert_ratchets_disabled
assert_only_conflicts app.txt
assert_cherry_pick_pending
)
test_release_cut_and_backport_commit_the_same_opt_out() (
local cut_repo="$test_root/release-cut"
init_repo "$cut_repo"
cd "$cut_repo"
git checkout -qb release-x.99.x
write_disabled_ratchets
git add --sparse .clj-kondo/ratchets.edn
git commit -q --allow-empty --no-verify -m "Cut release-x.99.x branch"
git show HEAD:.clj-kondo/ratchets.edn > "$test_root/release-cut.edn"
local backport_repo="$test_root/release-cut-backport"
init_repo "$backport_repo"
local commit
commit=$(feature_commit "$backport_repo" change_ratchets)
git -C "$backport_repo" checkout -q release
cd "$backport_repo"
cherry_pick_backport "$commit"
git show HEAD:.clj-kondo/ratchets.edn > "$test_root/backport.edn"
cmp -s "$test_root/release-cut.edn" "$test_root/backport.edn" ||
fail "the release cut and the backport committed different opt-out files"
assert_eq "$disabled_ratchets" "$(cat "$test_root/release-cut.edn")" \
"the release cut did not install the expected opt-out"
)
test_cut_release_workflow_uses_the_shared_writer() (
grep -Fq 'source .github/actions/create-backport/kondo-ratchets.sh' "$cut_release_workflow" ||
fail "the cut-release workflow does not source kondo-ratchets.sh"
grep -Fq 'write_disabled_ratchets' "$cut_release_workflow" ||
fail "the cut-release workflow does not call write_disabled_ratchets"
! grep -Fq ':disabled' "$cut_release_workflow" ||
fail "the cut-release workflow carries its own copy of the opt-out"
)
test_invalid_commit_failure_is_propagated() (
local repo="$test_root/invalid"
init_repo "$repo"
cd "$repo"
if cherry_pick_backport deadbeef; then
fail "an invalid commit succeeded"
fi
)
test_generated_script_resolves_ratchets_end_to_end() (
local repo="$test_root/generated-script"
init_repo "$repo"
local commit
commit=$(feature_commit "$repo" change_app_and_ratchets)
git -C "$repo" checkout -q release
commit_release_change "$repo" change_release_app_and_ratchets "Change release app and ratchets"
cd "$repo"
cherry_pick_backport "$commit"
git cherry-pick --abort
local release_commit
release_commit=$(git rev-parse HEAD)
write_backport_script "$commit"
chmod +x backport.sh
git add backport.sh
git commit -qm "Add manual backport script"
bash -n backport.sh
grep -Fq 'write_disabled_ratchets ()' backport.sh || fail "the generated script omitted write_disabled_ratchets"
./backport.sh
assert_ratchets_disabled
assert_only_conflicts app.txt
assert_cherry_pick_pending
assert_eq "$release_commit" "$(git rev-parse HEAD)" "the generated script did not return HEAD to the release commit"
[ ! -e backport.sh ] || fail "the generated script did not remove itself"
! git ls-files --error-unmatch backport.sh >/dev/null 2>&1 || fail "the generated script is still tracked"
! git status --porcelain | grep -q backport.sh || fail "the generated script left a status entry"
)
# Test harness
fail() {
echo "FAIL: $*" >&2
exit 1
}
assert_eq() {
local expected=$1
local actual=$2
local message=$3
[ "$expected" = "$actual" ] || fail "$message (expected '$expected', got '$actual')"
}
assert_ratchets() {
assert_eq "$1" "$(cat .clj-kondo/ratchets.edn)" "unexpected ratchet state"
}
assert_ratchets_disabled() {
assert_ratchets "$disabled_ratchets"
}
assert_cherry_pick_completed() {
! git rev-parse -q --verify CHERRY_PICK_HEAD >/dev/null || fail "the cherry-pick is still pending"
}
assert_cherry_pick_pending() {
git rev-parse -q --verify CHERRY_PICK_HEAD >/dev/null || fail "the cherry-pick state was lost"
}
assert_only_conflicts() {
local expected
local actual
expected=$(printf '%s\n' "$@" | sort)
actual=$(git diff --name-only --diff-filter=U | sort)
assert_eq "$expected" "$actual" "unexpected unresolved files"
}
assert_empty_commit() {
git diff --quiet HEAD^ HEAD || fail "the backport commit was not empty"
}
assert_worktree_clean() {
[ -z "$(git status --porcelain)" ] || fail "the backport left worktree changes"
}
init_repo() {
local repo=$1
git init -q -b release "$repo"
git -C "$repo" config user.email test@example.com
git -C "$repo" config user.name "Backport test"
printf 'base\n' > "$repo/app.txt"
mkdir -p "$repo/.clj-kondo"
printf '%s\n' "$active_ratchets" > "$repo/.clj-kondo/ratchets.edn"
git -C "$repo" add .
git -C "$repo" commit -qm "Base"
}
feature_commit() {
local repo=$1
shift
git -C "$repo" checkout -qb feature
"$@" "$repo"
git -C "$repo" add .
git -C "$repo" commit -qm "Feature"
git -C "$repo" rev-parse HEAD
}
# Sets up a release branch whose ratchets conflict with the feature commit, and prints that commit.
conflicting_ratchet_commit() {
local repo=$1
local commit
commit=$(feature_commit "$repo" change_ratchets)
git -C "$repo" checkout -q release
commit_release_change "$repo" change_release_ratchets "Change release ratchets"
echo "$commit"
}
change_app() {
printf 'feature\n' > "$1/app.txt"
}
change_ratchets() {
printf '{:ignore-counts {:example 2}}\n' > "$1/.clj-kondo/ratchets.edn"
}
change_app_and_ratchets() {
change_app "$1"
change_ratchets "$1"
}
change_release_app() {
printf 'release\n' > "$1/app.txt"
}
change_release_ratchets() {
printf '{:ignore-counts {:release 1}}\n' > "$1/.clj-kondo/ratchets.edn"
}
change_release_app_and_ratchets() {
change_release_app "$1"
change_release_ratchets "$1"
}
# Setup writes the opt-out through the shared writer; the only copy is the expected text at the top.
disable_release_ratchets() {
(cd "$1" && write_disabled_ratchets)
}
commit_release_change() {
local repo=$1
local change=$2
local message=$3
"$change" "$repo"
git -C "$repo" add .
git -C "$repo" commit -qm "$message"
}
run_test() {
local description=$1
local test=${description// /_}
test=${test//-/_}
test="test_$test"
declare -F "$test" >/dev/null || fail "missing test function: $test"
printf 'TEST: %s\n' "$description"
"$test"
printf 'PASS: %s\n' "$description"
}
run_test "unrelated backport preserves target ratchets"
run_test "clean ratchet backport installs release opt-out"
run_test "disabled release absorbs ratchet-only backport"
run_test "ratchet-only conflict is resolved"
run_test "continuation never opens an editor"
run_test "non-ratchet conflict remains manual"
run_test "mixed conflict resolves only ratchets"
run_test "release cut and backport commit the same opt-out"
run_test "cut-release workflow uses the shared writer"
run_test "invalid commit failure is propagated"
run_test "generated script resolves ratchets end-to-end"

View File

@@ -0,0 +1,74 @@
#!/usr/bin/env bash
set -euo pipefail
# The only place that knows what a release branch's opt-out looks like. The cut-release workflow, the
# backport helper, and the tests all go through this function.
write_disabled_ratchets() {
mkdir -p .clj-kondo
printf '%s\n' \
';; Kondo ignore ratchets apply only to master; this release branch opts out.' \
';; The test and fixer recognize this explicit opt-out.' \
'{:disabled true}' \
> .clj-kondo/ratchets.edn
}
disable_ratchets() {
local commit=$1
local file=.clj-kondo/ratchets.edn
[ -n "$(git diff-tree --root --no-commit-id --name-only -r "$commit" -- "$file")" ] || return 0
echo "$file: disabling kondo ratchets on the release branch"
write_disabled_ratchets
git add -- "$file"
if ! git rev-parse -q --verify CHERRY_PICK_HEAD >/dev/null; then
if ! git diff --cached --quiet HEAD; then
git commit --amend --no-edit
fi
return 0
fi
if [ -z "$(git ls-files -u)" ]; then
echo "$file was the only conflict, finishing the cherry-pick"
if git diff --cached --quiet HEAD; then
echo "nothing left to apply, committing the backport empty"
git commit --allow-empty --no-edit
else
# GIT_EDITOR outranks core.editor, VISUAL, and EDITOR, so the continuation can never wait on
# an editor; the repository's own editor configuration is left alone.
GIT_EDITOR=true git cherry-pick --continue
fi
fi
}
cherry_pick_backport() {
local commit=$1
local status=0
git cherry-pick "$commit" || status=$?
if [ "$status" -ne 0 ] && ! git rev-parse -q --verify CHERRY_PICK_HEAD >/dev/null; then
echo "cherry-pick failed without entering a resolvable conflict state" >&2
return "$status"
fi
disable_ratchets "$commit"
if [ "$status" -ne 0 ] &&
git rev-parse -q --verify CHERRY_PICK_HEAD >/dev/null &&
[ -z "$(git ls-files -u)" ]; then
echo "cherry-pick stopped without a file conflict to resolve" >&2
return "$status"
fi
}
write_backport_script() {
local commit=$1
{
echo "#!/usr/bin/env bash"
echo "set -euo pipefail"
echo "git reset HEAD~1"
echo "rm ./backport.sh"
declare -f write_disabled_ratchets disable_ratchets cherry_pick_backport
printf 'cherry_pick_backport %q\n' "$commit"
printf '%s\n' "printf 'Resolve conflicts and force push this branch.\\n\\nTo backport translations run: bin/i18n/merge-translations <release-branch>\\n'"
} > ./backport.sh
}

View File

@@ -93,8 +93,8 @@ runs:
if ${{ inputs.maildev }}; then
echo -e "${Y}checking maildev container..." &&
while ! nc -z localhost 1080; do sleep 1; done &&
while ! nc -z localhost 1025; do sleep 1; done &&
while ! nc -z localhost 1180; do sleep 1; done &&
while ! nc -z localhost 1125; do sleep 1; done &&
echo -e "${G}Maildev is up and running!"
echo -e "${Y}checking maildev-ssl container..." &&

View File

@@ -20,6 +20,15 @@ inputs:
description: Directory path where the jar should be extracted (defaults to current directory)
required: false
default: "."
download:
description: Default is true. Set to false to only look the artifact up and report `fetch-hit`.
required: false
default: "true"
outputs:
fetch-hit:
description: Boolean indicating if an artifact was successfully found and downloaded.
value: ${{ steps.find_release_artifact.outputs.fetch-hit }}
runs:
using: "composite"
@@ -28,11 +37,12 @@ runs:
id: find_release_artifact
uses: actions/github-script@v9
with:
result-encoding: string
script: | # js
const fs = require('fs');
const isRelease = "${{ inputs.release }}" === "true";
const failOnMiss = "${{ inputs.fail-on-fetch-miss }}" !== "false";
const shouldDownload = "${{ inputs.download }}" !== "false";
const prefix = isRelease ? "metabase-release" : "metabase";
const artifactName = `${prefix}-${{ inputs.edition }}-${{ inputs.commit }}-uberjar`;
console.log(`Looking for artifact: ${artifactName}`);
@@ -44,12 +54,18 @@ runs:
per_page: 1,
});
if (!artifacts.data?.artifacts?.[0]?.id) {
core.setFailed(`No artifacts found for ${artifactName}`);
return;
const artifact_id = artifacts.data?.artifacts?.[0]?.id;
if (!artifact_id) {
core.setOutput('fetch-hit', 'false');
} else {
core.setOutput('fetch-hit', 'true');
}
const artifact_id = artifacts.data.artifacts[0].id;
if (!shouldDownload) {
console.log(`skipping download (download: false)`);
return;
}
let download;
const maxAttempts = 3;
@@ -74,6 +90,7 @@ runs:
fs.writeFileSync(`${process.env.GITHUB_WORKSPACE}/mb.zip`, Buffer.from(download.data));
- name: Extract and rename JAR
if: ${{ steps.find_release_artifact.outputs.fetch-hit == 'true' && inputs.download != 'false' }}
shell: bash
run: | # bash
OUTPUT_NAME="${{ inputs.output-name }}"
@@ -119,12 +136,14 @@ runs:
fi
- name: Verify that this is a valid JAR file
if: ${{ steps.find_release_artifact.outputs.fetch-hit == 'true' && inputs.download != 'false' }}
shell: bash
run: |
echo "Verifying JAR at: $JAR_PATH"
file --mime-type "$JAR_PATH"
- name: Reveal its version.properties
if: ${{ steps.find_release_artifact.outputs.fetch-hit == 'true' && inputs.download != 'false' }}
shell: bash
run: |
echo "Extracting version.properties from: $JAR_PATH"

View File

@@ -1,7 +1,15 @@
name: Get Docker Info
description: Determines Docker repository and tag based on branch and edition
description: Determines the registry, repository, and tag a container image is pushed to.
inputs:
repo:
description: Registry and repo, e.g. "metabase/metabase". Overrides branch derived repo.
required: false
default: ''
tag:
description: Docker tag, e.g. v1.87.2. Overrides a branch derived tag.
required: false
default: ''
branch:
description: Branch name (defaults to current branch)
required: false
@@ -25,9 +33,6 @@ outputs:
full_image:
description: Full Docker image name (repo:tag)
value: ${{ steps.docker-info.outputs.full_image }}
editions:
description: JSON array of editions to build
value: ${{ steps.docker-info.outputs.editions }}
runs:
using: "composite"
@@ -41,34 +46,22 @@ runs:
const edition = '${{ inputs.edition }}';
const owner = '${{ inputs.owner }}';
console.log(`Determining Docker info for branch: ${branch}, edition: ${edition}`);
let repo, tag, editions;
if (branch === 'master') {
// Master builds both editions with specific repos
editions = ['ee', 'oss'];
tag = 'latest';
if (edition === 'ee') {
repo = `${owner}/metabase-enterprise-head`;
} else {
repo = `${owner}/metabase-head`;
}
} else {
// All other branches only build EE to metabase-dev
editions = ['ee'];
tag = branch.replaceAll('/', '-'); // slashes make docker sad
repo = `${owner}/metabase-dev`;
let tag = '${{ inputs.tag}}';
if (!tag) {
tag = branch === 'master' ? 'latest' : `${branch.replaceAll('/', '-')}-${edition}`;
}
const fullImage = `${repo}:${tag}`;
let repo = '${{ inputs.repo }}';
if (!repo) {
if (branch === 'master') {
repo = edition === 'ee' ? `${owner}/metabase-enterprise-head` : `${owner}/metabase-head`;
} else {
repo = `${owner}/metabase-dev`;
}
}
// Set outputs
core.setOutput('repo', repo);
core.setOutput('tag', tag);
core.setOutput('full_image', fullImage);
core.setOutput('editions', JSON.stringify(editions));
core.setOutput('full_image', `${repo}:${tag}`);
console.log(`Docker image: ${fullImage}`);
console.log(`Editions: ${JSON.stringify(editions)}`);
console.log(`Resolved: repo = ${repo}, tag = ${tag}`);

View File

@@ -5,9 +5,6 @@ inputs:
java-version:
required: true
default: "25"
clojure-version:
required: true
default: "1.12.0.1488"
runs:
using: "composite"
@@ -17,12 +14,40 @@ runs:
with:
java-version: ${{ inputs.java-version }}
distribution: "temurin"
- name: Cache spec
id: cache-spec
shell: bash
run: .github/scripts/cache-keys.sh | tee -a "$GITHUB_OUTPUT"
- name: Restore Clojure CLI
uses: actions/cache/restore@v5
with:
path: ${{ steps.cache-spec.outputs.clojure-path }}
key: ${{ steps.cache-spec.outputs.clojure-key }}
- name: Install Clojure CLI
shell: bash
env:
CLOJURE_PREFIX: ${{ steps.cache-spec.outputs.clojure-path }}
CLOJURE_VERSION: ${{ steps.cache-spec.outputs.clojure-version }}
run: |
set -uo pipefail
echo "$CLOJURE_PREFIX/bin" >> "$GITHUB_PATH"
export PATH="$CLOJURE_PREFIX/bin:$PATH"
# Whether the prefix already holds the right install is decided by running it, not by the
# cache-hit flag. The installer bakes the prefix into the clj/clojure shims, so a tree restored
# under a different $HOME points at a directory that is not there; and on a runner that is not
# ephemeral, a previous version's prefix outlives the cache entry that stopped matching it.
if clojure --version | grep -qF "$CLOJURE_VERSION"; then
clojure --version
exit 0
fi
cd "$RUNNER_TEMP"
for attempt in 1 2 3; do
curl --retry 3 --retry-delay 5 --fail -O https://download.clojure.org/install/linux-install-${{ inputs.clojure-version }}.sh \
&& sudo bash ./linux-install-${{ inputs.clojure-version }}.sh \
curl --retry 3 --retry-delay 5 --fail -O "https://download.clojure.org/install/linux-install-$CLOJURE_VERSION.sh" \
&& bash "./linux-install-$CLOJURE_VERSION.sh" --prefix "$CLOJURE_PREFIX" \
&& break
echo "::warning::Clojure install attempt $attempt failed, retrying in 10s..."
sleep 10
@@ -39,11 +64,6 @@ runs:
version: "0.10.2" # keep in sync with mise.toml
github-token: ${{ github.token }}
- name: Cache spec
id: cache-spec
shell: bash
run: .github/scripts/cache-keys.sh | tee -a "$GITHUB_OUTPUT"
- name: Restore M2 cache
uses: actions/cache/restore@v5
with:

View File

@@ -14,21 +14,6 @@ inputs:
staging-mb-all-features-token:
description: "Staging MB all features token"
required: true
shoppy-iam-role:
description: "Shoppy IAM role for AWS credentials"
required: true
shoppy-metabase-app-db-s3-bucket:
description: "S3 bucket for Shoppy app DB dump"
required: true
shoppy-metabase-app-db-s3-key:
description: "S3 key for Shoppy app DB dump"
required: true
shoppy-metabase-app-db-user:
description: "Shoppy Metabase app DB user"
required: true
shoppy-metabase-app-db-database:
description: "Shoppy Metabase app DB database"
required: true
metastore-dev-server-url:
description: "Metastore dev server URL"
required: true
@@ -93,20 +78,6 @@ runs:
echo "sample_app_branch_exists=false" >> "$GITHUB_OUTPUT"
fi
- name: Configure AWS credentials
if: ${{ steps.check-sample-app-branch.outputs.sample_app_branch_exists == 'true' }}
uses: aws-actions/configure-aws-credentials@d979d5b3a71173a29b74b5b88418bfda9437d885
with:
role-to-assume: ${{ inputs.shoppy-iam-role }}
role-session-name: GitHub_to_AWS_via_FederatedOIDC
aws-region: us-east-1
- name: Download Shoppy's App DB PostgreSQL dump from S3
if: ${{ steps.check-sample-app-branch.outputs.sample_app_branch_exists == 'true' }}
shell: bash
run: |
aws s3 cp s3://${{ inputs.shoppy-metabase-app-db-s3-bucket }}/${{ inputs.shoppy-metabase-app-db-s3-key }} ./e2e/tmp/db_dumps/shoppy_metabase_app_db_dump.sql
- name: Prepare and launch Shoppy containers
if: ${{ steps.check-sample-app-branch.outputs.sample_app_branch_exists == 'true' }}
shell: bash
@@ -115,8 +86,6 @@ runs:
SAMPLE_APP_ENVIRONMENT: ${{ inputs.sample-app-environment }}
CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ inputs.staging-mb-all-features-token }}
METASTORE_DEV_SERVER_URL: ${{ inputs.metastore-dev-server-url }}
METABASE_APP_DB_USER: ${{ inputs.shoppy-metabase-app-db-user }}
METABASE_APP_DB: ${{ inputs.shoppy-metabase-app-db-database }}
SHOPPY_DATADOG_APPLICATION_ID: ${{ inputs.shoppy-datadog-application-id }}
SHOPPY_DATADOG_CLIENT_TOKEN: ${{ inputs.shoppy-datadog-client-token }}
SHOPPY_DATADOG_SITE: "us5.datadoghq.com"

View File

@@ -20,8 +20,30 @@ inputs:
required: false
default: "ee"
description: Edition to test (oss or ee)
quarantine-engine:
runner-index:
required: false
description: >-
The index of this runner among those sharing a partitioned suite. See
`be-tests-bigquery-cloud-sdk-ee` in `.github/workflows/drivers.yml` for an example.
runner-count:
required: false
description: >-
How many runners share the suite. Recommended to set to `strategy.job-total` rather
than a literal so that it doesn't need updating if the `runner-index` matrix changes.
jvms-per-runner:
required: false
default: "1"
description: >-
Concurrent JVMs per runner. Recommended to raise above 1 for drivers whose tests
spend a lot of time waiting on a remote warehouse.
heap-per-jvm:
required: false
default: "4g"
description: >-
`-Xmx` per JVM, applied only when `jvms-per-runner` is more than 1 (otherwise the
the `:ci` alias's `-Xmx12g` is used). To size it: reserve ~1G for the OS and ~2G
of non-heap per JVM, then divide what's left. On a 16G runner that's ~4G each for
two JVMs.
granular-rerun:
required: false
default: "true"
@@ -100,6 +122,7 @@ runs:
# Otherwise run exactly as before. Quote the file so the whole `[ns/var ...]`
# vector reaches clojure -X as a single argument.
run: |
ALIASES="dev:ci:${{ inputs.edition }}:${{ inputs.edition }}-dev:drivers:drivers-dev:test"
BASE="clojure -X:dev:ci:${{ inputs.edition }}:${{ inputs.edition }}-dev:drivers:drivers-dev:test"
# `:profile-tests` overrides `:test`'s exec-fn, so it has to come last. See dev.profile-tests.
# The `profiled` output is what the collection steps below key off, so that the decision is
@@ -117,12 +140,19 @@ runs:
$BASE :only "$ONLY"
elif [ "${{ inputs.granular-rerun }}" = "true" ] && [ "${{ github.run_attempt }}" != "1" ] && [ -s target/failed-tests ]; then
echo "Granular rerun of previously-failed tests: $(cat target/failed-tests)"
$BASE :only "$(cat target/failed-tests)"
clojure -X:"$ALIASES" :only "$(cat target/failed-tests)"
elif [ -n "$TEST_RUNNER_INDEX" ]; then
CLOJURE_ALIASES="$ALIASES" ./.github/scripts/run-backend-test-jvms.sh ${{ inputs.test-args }}
else
$BASE ${{ inputs.test-args }}
clojure -X:"$ALIASES" ${{ inputs.test-args }}
fi
shell: bash
id: run-test
env:
TEST_RUNNER_INDEX: ${{ inputs.runner-index }}
TEST_RUNNER_COUNT: ${{ inputs.runner-count }}
TEST_JVMS_PER_RUNNER: ${{ inputs.jvms-per-runner }}
TEST_HEAP_PER_JVM: ${{ inputs.heap-per-jvm }}
# Keep this step continue-on-error because the quarantine gate below controls whether it
# ultimately fails.
continue-on-error: true
@@ -186,7 +216,9 @@ runs:
uses: actions/upload-artifact@v7
with:
name: ${{ format('test-logs-{0}{1}', github.job, inputs.artifact-suffix && format('-{0}', inputs.artifact-suffix) || '') }}
path: logs/test-log.json
# Glob: a single-JVM run writes `logs/test-log.json`; a multi-JVM run merges one
# `logs/test-log-p<index>.json` per JVM.
path: logs/test-log*.json
retention-days: 1
# Failing to upload the artifact should never affect the outcome of the whole test run.
continue-on-error: true
@@ -199,4 +231,4 @@ runs:
with:
adapter: backend
test-suite: ${{ inputs.junit-name }}
enforce-quarantine: ${{ inputs.quarantine-engine == 'ci-conductor' }}
enforce-quarantine: "true"

View File

@@ -7,9 +7,8 @@ default: &default
- "locales/**"
- "bin/**/!(*.md)"
actionlint:
- added|modified: ".github/workflows/*.yml"
- added|modified: ".github/workflows/*.yaml"
workflows:
- added|modified: ".github/workflows/*.{yml,yaml}"
shared_sources: &shared_sources
- "src/**/*.cljc"
@@ -65,6 +64,9 @@ frontend_specs: &frontend_specs
- "frontend/**/*.unit.*"
- "enterprise/frontend/**/*.unit.*"
- ".github/**/*.unit.spec.*"
# file-paths.unit.spec.ts asserts what this file's own patterns match, so a change to it has to
# run the specs that guard it.
- ".github/file-paths.yaml"
- "jest.config.js"
- "jest.tz.unit.conf.json"
@@ -113,11 +115,15 @@ backend_sources: &backend_sources
- "src/**"
- "modules/drivers/{*,*/{*,!(test)/**}}"
- "resources/**"
- ".clj-kondo/**"
# Ratchet files drive project_ratchet_checks alone, so automation PRs that lower budgets
# run the Project tests job by themselves. Patterns are OR-ed, so a separate "!..." entry would match
# every other path instead of excluding this one.
- ".clj-kondo/**/!(ratchets.edn)"
backend_specs: &backend_specs
- *shared_specs
- "test/**"
- "dev/test/**"
- "enterprise/backend/test/**"
- "test_modules/**"
- "modules/drivers/*/test/**"
@@ -130,6 +136,48 @@ backend_all: &backend_all
- *backend_sources
- *backend_specs
# Project checks have narrower triggers than the backend matrix.
# Changes to their shared CI entry points exercise every suite; otherwise each
# suite follows only the files that can affect its result.
project_tests_infra: &project_tests_infra
- ".github/actions/prepare-backend/**"
- ".github/file-paths.yaml"
- ".github/workflows/backend.yml"
- ".github/workflows/run-tests.yml"
- "bb.edn"
- "bin/mage"
- "bin/mage.bb"
- "mage/src/mage/color.clj"
- "mage/src/mage/project_tests.clj"
- "mage/src/mage/shell.clj"
- "mage/src/mage/util.clj"
project_backend_checks:
- *project_tests_infra
- "{src,test,enterprise,dev,bin,mage}/**/*.{clj,cljc,cljs}"
- "modules/**/*.clj"
- "modules/**/*.cljc"
- "modules/**/*.cljs"
- "**deps.edn"
- ".clj-kondo/{src,test}/**/*.{clj,cljc,cljs}"
- "{resources,test_resources,test_config}/**/*.{clj,cljc,cljs}"
- ".clj-kondo/config.edn"
- ".clj-kondo/config/modules/config.edn"
- ".github/team.json"
- "dev/resources/dev/modules_config_test/**"
# Only the ratchet check reads the budgets, so a diff that touches nothing else runs that suite alone.
project_ratchet_checks:
- ".clj-kondo/ratchets.edn"
- ".clj-kondo/config/modules/ratchets.edn"
project_migration_checks:
- *project_tests_infra
- "bin/lint-migrations-file/**"
- "resources/migrations/**/*.{yaml,yml}"
- "src/metabase/app_db/custom_migrations.clj"
- "src/metabase/app_db/custom_migrations/**"
sources: &sources
- *shared_sources
- *frontend_sources

View File

@@ -50,7 +50,11 @@ digest() {
}
shopt -s nullglob
DEPS_FILES=(deps.edn modules/drivers/deps.edn modules/drivers/*/deps.edn)
DEPS_FILES=(deps.edn
bin/lint-migrations-file/deps.edn
bin/load-namespaces/deps.edn
modules/drivers/deps.edn
modules/drivers/*/deps.edn)
shopt -u nullglob
DEPS_HASH="$(digest "${DEPS_FILES[@]}")"
@@ -70,6 +74,10 @@ if [ "$CYPRESS_MATCHES" != "1" ]; then
fi
CYPRESS_VERSION="$CYPRESS_VERSIONS"
# The Clojure CLI version CI installs. It lives here rather than in prepare-backend so that the version
# and the key that identifies its cache entry cannot drift apart.
CLOJURE_VERSION="1.12.0.1488"
# An incremental lint cache is only ever an accelerator, so it keys on the commit and always falls back
# to the newest entry on the prefix. The exact key never pre-exists, which keeps the entry current.
ESLINT_SHA="${GITHUB_SHA:-$(git rev-parse HEAD)}"
@@ -96,6 +104,15 @@ spec() {
echo "bun-store-key=bun-store-$OS-$LOCK_HASH"
echo "bun-store-restore-key=bun-store-$OS-"
# No restore-key: an entry from another version installs a working `clojure` of the wrong version, and
# the freshness check in prepare-backend - running the binary - would accept it.
#
# The installer bakes this prefix into the clj/clojure shims, so the tree only works when restored to
# the same absolute path it was built at; prepare-backend reinstalls when it is not.
echo "clojure-path=$HOME/.clojure-cli"
echo "clojure-key=clojure-cli-$OS-$CLOJURE_VERSION"
echo "clojure-version=$CLOJURE_VERSION"
echo "cypress-path=$HOME/.cache/Cypress"
echo "cypress-key=cypress-$OS-$CYPRESS_VERSION"
echo "cypress-restore-key=cypress-$OS-"

71
.github/scripts/check-job-timeouts.sh vendored Executable file
View File

@@ -0,0 +1,71 @@
#!/usr/bin/env bash
# Fails when a job in .github/workflows/ does not set `timeout-minutes`.
#
# Without it a job inherits GitHub's 6-hour default, so a hung job burns six hours of runner time -
# and holds up everything queued behind it - before anyone notices. actionlint cannot check this: its
# rule set is compiled in and .github/actionlint.yaml only takes `self-hosted-runner`,
# `config-variables`, and `paths` (which suppresses findings rather than adding them). Hence this
# script.
#
# The rule is per job: a `timeout-minutes` on a step does not satisfy it, and steps are not required
# to carry one of their own.
#
# Jobs that call a reusable workflow (`uses:` at the job level) are skipped - GitHub rejects
# `timeout-minutes` there. The called workflow's own jobs are checked when it lives in this repo.
#
# .github/scripts/check-job-timeouts.sh [workflow-file ...]
#
# With no arguments it checks every workflow; CI passes the files that changed, like actionlint does.
set -euo pipefail
# Arguments are used as given, so the paths in the annotations match what the caller passed. Without
# them the full scan has to run from the repo root.
if [ $# -gt 0 ]; then
workflows=("$@")
else
cd "$(git rev-parse --show-toplevel)"
shopt -s nullglob
workflows=(.github/workflows/*.yml .github/workflows/*.yaml)
if [ ${#workflows[@]} -eq 0 ]; then
echo "::error::check-job-timeouts.sh: no workflow files found under .github/workflows/" >&2
exit 1
fi
fi
status=0
for file in "${workflows[@]}"; do
# `awk NF` drops the blank line yq emits when a file has nothing to report.
missing="$(
# --header-preprocess=false: yq otherwise slurps any leading comment block before parsing, which
# shifts every line number it reports by the size of that block.
yq --header-preprocess=false '
.jobs
| to_entries
| .[]
| select(((.value | has("timeout-minutes")) or (.value | has("uses"))) | not)
| [(.key | line), .key]
| @tsv
' "$file" | awk NF
)"
[ -n "$missing" ] || continue
while IFS=$'\t' read -r line job; do
echo "::error file=${file},line=${line}::Job \"${job}\" does not set a job-level timeout-minutes" >&2
done <<< "$missing"
status=1
done
if [ "$status" -ne 0 ]; then
echo >&2
echo "Every job must set an explicit timeout-minutes; without one it inherits GitHub's 6-hour default." >&2
echo "Pick a value with headroom over the job's normal runtime." >&2
exit 1
fi
echo "All jobs in the ${#workflows[@]} workflow file(s) checked set timeout-minutes."

View File

@@ -1,6 +1,5 @@
#!/usr/bin/env bash
# Fails when a `clojure` invocation under .github/ uses an alias combination that cache-warm does not
# pre-resolve.
# Fails when a Clojure classpath used by CI is not pre-resolved by cache-warm.
#
# tools.deps selects dependency versions globally per classpath, so two alias combinations can resolve
# the same transitive library to different versions. A combination the warm job never resolved is
@@ -30,10 +29,18 @@ EOF
# :deps - tools.deps built-in used by write-poms.sh; contributes no dependencies of its own.
# :outdated - scheduled dependency-bump workflow only; a cold resolve there costs nothing anyone waits on.
# Alias combinations the warm job pre-resolves.
declared="$(sed -n '/combos=(/,/^ *)/p' "$WARM" | grep -oE '":[^"]*"' | tr -d '"' | sort -u)"
# Dependency roots and alias combinations the warm job pre-resolves.
declared="$({
sed -n '/^[[:space:]]*combos=(/,/^ *)/p' "$WARM" \
| grep -oE '":[^"]*"' \
| tr -d '"' \
| sed 's#^#.|#'
sed -n '/^[[:space:]]*nested_combos=(/,/^ *)/p' "$WARM" \
| grep -oE '"[^"]+\|:[^"]+"' \
| tr -d '"'
} | sort -u)"
if [ -z "$declared" ]; then
echo "::error::check-preresolve-aliases.sh: found no combos=( ... ) list in $WARM" >&2
echo "::error::check-preresolve-aliases.sh: found no pre-resolved classpaths in $WARM" >&2
exit 1
fi
@@ -43,27 +50,60 @@ unknown="$(grep -rhoE '\$\{\{[^}]*\}\}' --include='*' \
--exclude='*.png' --exclude='*.jpg' .github/ 2>/dev/null \
| sort -u | grep -v 'edition' || true)"
scan() { # scan <edition>: alias strings used by clojure invocations, with expressions substituted
scan() { # scan <edition>: dependency root and aliases used by .github Clojure invocations
grep -rhE 'clojure[[:space:]]+(-P[[:space:]]+)?-[XMATP]?:' \
--include='*' --exclude='*.png' --exclude='*.jpg' .github/ 2>/dev/null \
| sed "s/\\\${{[^}]*edition[^}]*}}/$1/g" \
| grep -oE 'clojure[[:space:]]+(-P[[:space:]]+)?-[XMATP]?:[A-Za-z0-9:_.-]+' \
| grep -oE ':[A-Za-z0-9:_.-]+' \
| sed 's/:$//'
| grep -oE 'clojure[[:space:]]+(-P[[:space:]]+)?-[XMATP]?:[A-Za-z0-9:_./-]+' \
| grep -oE ':[A-Za-z0-9:_./-]+' \
| sed -e 's/:$//' -e 's#^#.|#'
}
found="$( { scan ee; scan oss; } | sort -u )"
scan_project_tests() { # scan_project_tests <function> <dependency-root>
# Mage shell commands are vectors split across lines, so flatten each function body before
# extracting its alias.
sed -n "/(defn- $1 /,/^(defn/p" mage/src/mage/project_tests.clj \
| tr '\n' ' ' \
| grep -oE '"clojure"[[:space:]]+("-P"[[:space:]]+)?"-[XMATP]?:[A-Za-z0-9:_./-]+' \
| grep -oE ':[A-Za-z0-9:_./-]+' \
| sed -e 's/:$//' -e "s#^#$2|#"
}
covered="$(printf '%s\n%s\n' "$declared" "$WAIVED" | sort -u)"
# Check each scan separately. One scan still finding commands would otherwise conceal that another has
# stopped matching, which silently drops everything it used to cover.
require_scan() { # require_scan <what> <result>
[ -n "$2" ] && return
echo "::error::check-preresolve-aliases.sh: found no Clojure invocation in $1; the scan pattern no longer matches" >&2
exit 1
}
workflow_checks=$( { scan ee; scan oss; } || true)
clojure_checks=$(scan_project_tests run-clojure-checks! . || true)
migration_checks=$(scan_project_tests run-migration-checks! bin/lint-migrations-file || true)
require_scan ".github/" "$workflow_checks"
require_scan "run-clojure-checks! (mage/src/mage/project_tests.clj)" "$clojure_checks"
require_scan "run-migration-checks! (mage/src/mage/project_tests.clj)" "$migration_checks"
scanned="$(printf '%s\n' "$workflow_checks" "$clojure_checks" "$migration_checks" | sort -u)"
found="$( {
printf '%s\n' "$scanned"
# build-scripts.yml runs this classpath from its own dependency root.
printf '%s\n' 'bin/load-namespaces|:test'
} | sort -u )"
covered="$( {
printf '%s\n' "$declared"
printf '%s\n' "$WAIVED" | sed 's#^#.|#'
} | sort -u)"
missing="$(comm -23 <(printf '%s\n' "$found") <(printf '%s\n' "$covered") || true)"
if [ -n "$missing" ]; then
echo "::error::Alias combinations used under .github/ that cache-warm does not pre-resolve:" >&2
echo "::error::Clojure classpaths used by CI that cache-warm does not pre-resolve:" >&2
printf '%s\n' "$missing" | sed 's/^/ /' >&2
echo >&2
echo "Add each to the combos list in $WARM, or waive it in this script with a reason." >&2
echo "Add each to the matching root or nested combo list in $WARM, or waive it here with a reason." >&2
echo "Leaving it uncovered means those jobs re-fetch their version deltas from Maven on every run." >&2
exit 1
fi
echo "All $(printf '%s\n' "$found" | grep -c .) clojure alias combinations under .github/ are pre-resolved."
echo "All $(printf '%s\n' "$found" | grep -c .) Clojure classpaths used by CI are pre-resolved."

View File

@@ -24,11 +24,17 @@ const STORY_GLOBS = [
"enterprise/frontend/**/*.stories.{js,jsx,ts,tsx}",
];
// `git ls-files -- frontend enterprise/frontend` already prints just over a
// megabyte of paths, and node's default maxBuffer is exactly 1 MiB: past that
// the spawn dies with ENOBUFS. Give the listings room to grow.
const LS_FILES_MAX_BUFFER = 64 * 1024 * 1024;
// Returns the tracked files under `roots` that match `globs`. The `dot: true`
// option means files inside dot-directories such as `.storybook` are included.
function listFiles(roots: string[], globs: string[]): string[] {
const tracked = execFileSync("git", ["ls-files", "--", ...roots], {
encoding: "utf8",
maxBuffer: LS_FILES_MAX_BUFFER,
})
.split("\n")
.map((line) => line.trim())

66
.github/scripts/file-paths.unit.spec.ts vendored Normal file
View File

@@ -0,0 +1,66 @@
import { readFileSync } from "fs";
import { join } from "path";
import { load } from "js-yaml";
import { isMatch } from "micromatch";
const FILTERS = join(__dirname, "..", "file-paths.yaml");
type Filter = string | Filter[] | { [changeType: string]: Filter };
// A filter is a list of patterns, and an entry may name the change types it applies to as
// { "added|modified": pattern }. Either way the patterns are what matters here.
const patterns = (value: Filter): string[] => {
if (typeof value === "string") return [value];
if (Array.isArray(value)) return value.flatMap(patterns);
return Object.values(value).flatMap(patterns);
};
describe("file-paths.yaml", () => {
const filters = load(readFileSync(FILTERS, "utf8")) as Record<string, Filter>;
// dorny/paths-filter matches with picomatch, which micromatch wraps, so this asks the same
// question CI asks of a changed path.
const matches = (name: string, path: string) =>
patterns(filters[name]).some((pattern) =>
isMatch(path, pattern, { dot: true }),
);
// dorny/paths-filter ORs the patterns in a filter, so a "!..." entry does not subtract from the
// other entries - it matches every path they don't, turning the filter permanently on. Excluding
// a path means writing the exclusion inside one pattern, the way backend_sources keeps
// ratchet files out with ".clj-kondo/**/!(ratchets.edn)".
it("never excludes a path with a standalone negation", () => {
const negated = Object.entries(filters).flatMap(([name, filter]) =>
patterns(filter)
.filter((pattern) => pattern.startsWith("!"))
.map((pattern) => `${name}: ${pattern}`),
);
expect(negated).toEqual([]);
});
it.each(["backend_sources", "backend_all"])(
"%s skips a ratchets-only change and still follows the rest of .clj-kondo",
(name) => {
expect(matches(name, ".clj-kondo/ratchets.edn")).toBe(false);
expect(
matches(name, ".clj-kondo/config/modules/ratchets.edn"),
).toBe(false);
expect(matches(name, ".clj-kondo/config.edn")).toBe(true);
expect(matches(name, ".clj-kondo/config/modules/config.edn")).toBe(true);
},
);
it("runs the ratchet check on the ratchets file", () => {
expect(matches("project_ratchet_checks", ".clj-kondo/ratchets.edn")).toBe(
true,
);
expect(
matches(
"project_ratchet_checks",
".clj-kondo/config/modules/ratchets.edn",
),
).toBe(true);
});
});

160
.github/scripts/run-backend-test-jvms.sh vendored Executable file
View File

@@ -0,0 +1,160 @@
#!/usr/bin/env bash
#
# Run this runner's share of a partitioned backend test suite as one or more concurrent
# JVMs. The caller says how many runners share the suite and how many JVMs each gets.
#
# WHY MULTIPLE JVMS PER RUNNER
# ----------------------------
# Driver tests spend most of their wall time waiting on the remote warehouse, and they
# can't use the idle CPU by using more threads because some tests mutate global state.
# A second JVM gets that isolation for free.
#
# Two paths are NOT safe to share:
# * `target/junit` — hawk deletes the whole directory at `:begin-test-run`, so a JVM
# starting late would wipe an earlier one's results.
# * `logs/test-log.json` — the log4j2 File appender truncates it on open.
# So each JVM runs in its own hardlinked copy of the checkout (inodes, not disk) and
# outputs are merged back into the workspace afterwards.
#
# INPUTS (environment)
# --------------------
# CLOJURE_ALIASES alias string for `clojure -X`, e.g. dev:ci:ee:ee-dev:drivers:drivers-dev:test
# TEST_RUNNER_INDEX index of this runner among those sharing the suite
# TEST_RUNNER_COUNT how many runners share the suite
# TEST_JVMS_PER_RUNNER concurrent JVMs per runner (default 1)
# TEST_HEAP_PER_JVM -Xmx per JVM, applied only when running more than one
#
# Exits non-zero if any JVM fails.
set -uo pipefail
: "${CLOJURE_ALIASES:?CLOJURE_ALIASES is required}"
: "${TEST_RUNNER_INDEX:?TEST_RUNNER_INDEX is required}"
: "${TEST_RUNNER_COUNT:?TEST_RUNNER_COUNT is required}"
TEST_ARGS=("$@")
TEST_JVMS_PER_RUNNER="${TEST_JVMS_PER_RUNNER:-1}"
TEST_HEAP_PER_JVM="${TEST_HEAP_PER_JVM:-4g}"
die() {
echo "::error::run-backend-test-jvms.sh: $1"
exit 1
}
[[ "$TEST_RUNNER_INDEX" =~ ^[0-9]+$ ]] || die "TEST_RUNNER_INDEX must be a non-negative integer, got '$TEST_RUNNER_INDEX'"
[[ "$TEST_RUNNER_COUNT" =~ ^[0-9]+$ ]] || die "TEST_RUNNER_COUNT must be a positive integer, got '$TEST_RUNNER_COUNT'"
[[ "$TEST_JVMS_PER_RUNNER" =~ ^[0-9]+$ ]] || die "TEST_JVMS_PER_RUNNER must be a positive integer, got '$TEST_JVMS_PER_RUNNER'"
[ "$TEST_RUNNER_COUNT" -ge 1 ] || die "TEST_RUNNER_COUNT must be at least 1"
[ "$TEST_JVMS_PER_RUNNER" -ge 1 ] || die "TEST_JVMS_PER_RUNNER must be at least 1"
[ "$TEST_RUNNER_INDEX" -lt "$TEST_RUNNER_COUNT" ] ||
die "runner index $TEST_RUNNER_INDEX is out of range for $TEST_RUNNER_COUNT runner(s) — a matrix entry was added without raising runner-count"
# Partition indexes are split across runners rather than handed out in contiguous
# blocks. E.g. with 2 runners and 2 JVMs the first runner gets partition 0 and 2, and
# the second runner gets partitions 1 and 3. Hawk partitions in namespace order, so
# neighbouring partitions have similar runtimes — contiguous blocks would group the slow
# ones together onto one runner.
PARTITION_TOTAL=$((TEST_RUNNER_COUNT * TEST_JVMS_PER_RUNNER))
INDEXES=()
for ((k = 0; k < TEST_JVMS_PER_RUNNER; k++)); do
INDEXES+=($((TEST_RUNNER_INDEX + k * TEST_RUNNER_COUNT)))
done
# One JVM: run directly in the workspace with no heap override, exactly as a
# partitioned run behaved before this script existed.
if [ "$TEST_JVMS_PER_RUNNER" -eq 1 ]; then
echo "Running partition ${INDEXES[0]} of $PARTITION_TOTAL"
exec clojure -X:"$CLOJURE_ALIASES" "${TEST_ARGS[@]}" \
:partition/total "$PARTITION_TOTAL" \
:partition/index "${INDEXES[0]}"
fi
WORKSPACE="$PWD"
# Sibling of the checkout: same filesystem (so `cp -al` can hardlink) but outside the
# repo, so one JVM's directory never gets copied into another's.
JVM_DIRS_ROOT="$(dirname "$WORKSPACE")/backend-test-jvms"
STATUS_DIR="$JVM_DIRS_ROOT/status"
# Merge every JVM's results into the workspace the rest of the job reads from.
#
# Each partition's junit XML goes into its own subdirectory: `mb_hawk_var_less_errors.xml`
# has a fixed name, so a flat copy would silently overwrite it. Nesting is safe because
# both consumers (dorny/test-reporter and ci-conductor's backend adapter) walk
# `target/junit` recursively and match on filename suffix.
#
# Runs from an EXIT trap so a cancelled or timed-out job still publishes whatever
# finished.
# shellcheck disable=SC2329 # invoked by the EXIT trap below, which shellcheck can't see.
merge_outputs() {
mkdir -p "$WORKSPACE/target/junit" "$WORKSPACE/logs"
local idx jvm_dir
for idx in "${INDEXES[@]}"; do
jvm_dir="$JVM_DIRS_ROOT/partition-$idx"
if [ -d "$jvm_dir/target/junit" ]; then
mkdir -p "$WORKSPACE/target/junit/p$idx"
cp -a "$jvm_dir/target/junit/." "$WORKSPACE/target/junit/p$idx/" || true
fi
# `logs/test-log*.json` is what the action uploads on failure.
if [ -f "$jvm_dir/logs/test-log.json" ]; then
cp -a "$jvm_dir/logs/test-log.json" "$WORKSPACE/logs/test-log-p$idx.json" || true
fi
done
}
trap merge_outputs EXIT
trap 'exit 143' TERM
trap 'exit 130' INT
# Hardlinked copy of the checkout. Skips the paths a run writes to (`target`, `logs`, `.cpcache`)
# and the two most expensive trees nothing on the test classpath reads (`.git`, `node_modules`).
prepare_jvm_dir() {
local jvm_dir="$1" entry
rm -rf "$jvm_dir"
mkdir -p "$jvm_dir"
for entry in "$WORKSPACE"/* "$WORKSPACE"/.[!.]*; do
[ -e "$entry" ] || continue
case "$(basename "$entry")" in
.git | node_modules | target | logs | .cpcache) continue ;;
esac
# Fall back to a real copy if the filesystem refuses the hardlink.
cp -al "$entry" "$jvm_dir/" 2>/dev/null || cp -a "$entry" "$jvm_dir/"
done
}
# Prefix output with the partition index so interleaved JVM logs stay readable.
run_partition() {
local idx="$1" jvm_dir="$2" rc line
(
cd "$jvm_dir" || exit 1
# `-J` options land after the aliases' `:jvm-opts`, overriding the `:ci` alias's
# `-Xms12g -Xmx12g`. Xms stays small so JVMs sharing a runner grow into memory on
# demand rather than each committing its ceiling up front.
exec clojure -J-Xms512m -J-Xmx"$TEST_HEAP_PER_JVM" -X:"$CLOJURE_ALIASES" \
"${TEST_ARGS[@]}" \
:partition/total "$PARTITION_TOTAL" \
:partition/index "$idx"
) 2>&1 | while IFS= read -r line || [ -n "$line" ]; do printf '[p%s] %s\n' "$idx" "$line"; done
rc="${PIPESTATUS[0]}"
echo "$rc" > "$STATUS_DIR/p$idx"
}
rm -rf "$JVM_DIRS_ROOT"
mkdir -p "$STATUS_DIR"
echo "Runner $TEST_RUNNER_INDEX of $TEST_RUNNER_COUNT: running $TEST_JVMS_PER_RUNNER concurrent JVMs for partition(s) ${INDEXES[*]} of $PARTITION_TOTAL (-Xmx$TEST_HEAP_PER_JVM each)"
for idx in "${INDEXES[@]}"; do
prepare_jvm_dir "$JVM_DIRS_ROOT/partition-$idx"
done
for idx in "${INDEXES[@]}"; do
run_partition "$idx" "$JVM_DIRS_ROOT/partition-$idx" &
done
wait
overall=0
for idx in "${INDEXES[@]}"; do
rc="$(cat "$STATUS_DIR/p$idx" 2>/dev/null || echo 1)"
echo "partition $idx exited $rc"
[ "$rc" -eq 0 ] || overall=1
done
exit "$overall"

View File

@@ -0,0 +1,97 @@
// Appends the measured load times to the "Bundle Load Times" table in
// eng-stats-importer. Reads ROWS (the JSON matrix.js prints) and API_KEY from
// env, and stamps each row with the commit it came from.
import { readFileSync } from "node:fs";
import { importStats } from "./stats-import";
/** One condition, as `frontend/test/bench/matrix.ts` reports it. */
interface Condition {
network: string;
networkMbps: number;
latencyMs: number;
cpu: string;
cpuThrottle: number;
coldMs: number;
warmMs: number;
steadyMs: number;
coldSpreadPercent: number;
coldTtfbMs: number;
coldFirstPaintMs: number;
coldAppMountedMs: number;
coldLargestPaintMs: number;
coldPageReadyMs: number;
warmPageReadyMs: number;
scripts: number;
scriptKb: number;
runs: number;
}
interface CommitStamp {
sha: string;
subject: string;
}
type LoadTimeRow = Record<string, string | number>;
function buildRows(
conditions: Condition[],
{ sha, subject }: CommitStamp,
): LoadTimeRow[] {
return conditions.map((condition) => ({
Date: new Date().toISOString().slice(0, 10),
// Truncated the same way the bundle-size table does, so the two join.
Commit: sha.slice(0, 12),
// The stats table carries a free-text Description column. Populate it with
// the commit subject so the chart's points are self-describing.
Description: subject.split("\n")[0],
Network: condition.network,
"Network mbps": condition.networkMbps,
"Latency ms": condition.latencyMs,
CPU: condition.cpu,
"CPU throttle": condition.cpuThrottle,
"Cold ms": condition.coldMs,
"Warm ms": condition.warmMs,
"Steady ms": condition.steadyMs,
"Cold spread %": condition.coldSpreadPercent,
// The cold load broken up. A zero means the browser or the route never
// reported that one, rather than that it happened at time zero.
"Cold ttfb ms": condition.coldTtfbMs,
"Cold first paint ms": condition.coldFirstPaintMs,
"Cold app mounted ms": condition.coldAppMountedMs,
"Cold largest paint ms": condition.coldLargestPaintMs,
"Cold page ready ms": condition.coldPageReadyMs,
"Warm page ready ms": condition.warmPageReadyMs,
Scripts: condition.scripts,
"Script kb": condition.scriptKb,
Runs: condition.runs,
}));
}
async function main() {
const path = process.env.ROWS || "artifacts/load-times.json";
// matrix.js wrote this file, and Condition is the shape it prints.
const conditions = JSON.parse(readFileSync(path, "utf8")) as Condition[];
const rows = buildRows(conditions, {
sha: process.env.HEAD_SHA || "",
subject: process.env.COMMIT_MESSAGE || "",
});
console.table(rows);
try {
await importStats({ table: "bundle_load_times", rows });
console.log("Load times uploaded successfully");
} catch (error) {
// Stats logging is best-effort. A point lost to an unreachable importer is
// worth less than a red build on master, and the next commit plots another.
const message = error instanceof Error ? error.message : String(error);
console.log(
`::warning::Load-time upload failed after retries; leaving run green: ${message}`,
);
}
}
main();

8
.github/team.json vendored
View File

@@ -63,7 +63,8 @@
"crisptrutski",
"undrfined",
"andreis",
"prascuna"
"prascuna",
"krever"
]
},
{
@@ -110,7 +111,10 @@
"uladzimirdev",
"egorgrushin",
"metatyb",
"olehk-mb"
"olehk-mb",
"annatomka",
"brybacki",
"BillyBobFry"
]
},
{

View File

@@ -1,5 +1,5 @@
name: AI Benchmark
run-name: "dispatch evals · ${{ github.event_name == 'pull_request' && format('smoke PR#{0}', github.event.pull_request.number) || (inputs.ref != '' && inputs.ref || (inputs.pr != '' && format('PR#{0}', inputs.pr) || 'master')) }}"
run-name: "Evals · ${{ github.event_name == 'pull_request' && github.event.label.name || format('manual · {0}', inputs.scope) }} · ${{ github.event.pull_request.number || inputs.pr || inputs.ref || github.sha }}"
on:
pull_request:
@@ -18,7 +18,16 @@ on:
description: "Scope"
required: true
type: choice
options: [smoke, full, "all (EXPENSIVE)"]
options:
- smoke
- full
- embarrassing-plain
- embarrassing-human
- embarrassing-all
- goldens-plain
- goldens-human
- goldens-all
- "all (EXPENSIVE)"
default: smoke
sample:
description: "Sample (0 = full suite)"
@@ -29,27 +38,76 @@ on:
default: main
concurrency:
group: evals-dispatch-${{ (github.event.label.name == 'evals/smoke' && github.event.pull_request.number) || github.run_id }}
group: evals-dispatch-${{ github.event_name == 'pull_request' && format('{0}-{1}', github.event.pull_request.number, github.event.label.name) || github.run_id }}
cancel-in-progress: true
jobs:
unsupported:
prepare:
if: >-
github.event_name == 'pull_request'
&& github.event.label.name == 'evals/smoke'
&& github.event.pull_request.head.repo.full_name != github.repository
(github.event_name == 'pull_request'
&& github.event.pull_request.head.repo.full_name == github.repository
&& startsWith(github.event.label.name, 'evals:'))
|| github.event_name == 'workflow_dispatch'
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
outputs:
pr: ${{ steps.prepare.outputs.pr }}
ref: ${{ steps.prepare.outputs.ref }}
scope: ${{ steps.prepare.outputs.scope }}
sample: ${{ steps.prepare.outputs.sample }}
label: ${{ steps.prepare.outputs.label }}
evals_branch: ${{ steps.prepare.outputs.evals_branch }}
steps:
- run: |
echo "::error::evals/smoke only runs on same-repo PRs; this PR's head is on a fork"
exit 1
- name: Prepare
id: prepare
env:
EVENT_NAME: ${{ github.event_name }}
LABEL_PR: ${{ github.event.pull_request.number }}
LABEL: ${{ github.event.label.name }}
INPUT_PR: ${{ inputs.pr }}
INPUT_REF: ${{ inputs.ref }}
INPUT_SCOPE: ${{ inputs.scope }}
INPUT_SAMPLE: ${{ inputs.sample }}
INPUT_EVALS_BRANCH: ${{ inputs.evals_branch }}
run: |
set -euo pipefail
# The two paths are mutually exclusive, and `on:` admits no other trigger.
if [[ "$EVENT_NAME" == 'pull_request' ]]; then
SCOPE="${LABEL#evals:}"
case "$SCOPE" in
embarrassing-plain|embarrassing-human|embarrassing-all|goldens-plain|goldens-human|goldens-all)
SAMPLE='0' ;;
smoke|full)
SAMPLE='5' ;;
*)
echo "::error::'${LABEL}' is not a known evals trigger label; add its scope here and to the workflow's \`scope\` options, or remove the label"
exit 1 ;;
esac
PR="$LABEL_PR"; REF=''; EVALS_BRANCH='main'
else
PR="$INPUT_PR"; REF="$INPUT_REF"; SCOPE="$INPUT_SCOPE"
SAMPLE="${INPUT_SAMPLE:-5}"; EVALS_BRANCH="$INPUT_EVALS_BRANCH"
LABEL='' # nothing to consume: a manual dispatch was not triggered by a label
fi
# None of these is ever multi-line; a newline would forge extra output entries.
for v in PR REF SCOPE SAMPLE LABEL EVALS_BRANCH; do
if [[ "${!v}" == *$'\n'* ]]; then
echo "::error::${v} must be a single line"
exit 1
fi
done
{
echo "pr=$PR"
echo "ref=$REF"
echo "scope=$SCOPE"
echo "sample=$SAMPLE"
echo "label=$LABEL"
echo "evals_branch=$EVALS_BRANCH"
} >> "$GITHUB_OUTPUT"
announce:
if: >-
github.event_name == 'pull_request'
&& github.event.label.name == 'evals/smoke'
&& github.event.pull_request.head.repo.full_name == github.repository
needs: prepare
if: github.event_name == 'pull_request'
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
outputs:
@@ -57,29 +115,33 @@ jobs:
steps:
- name: Comment (building)
id: post
env:
SCOPE: ${{ needs.prepare.outputs.scope }}
uses: actions/github-script@v9
with:
github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
script: |
const runUrl = `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;
const body = `🤖 **Evals smoke** — ⏳ building the image… ([logs](${runUrl}))`;
const prefix = `🤖 **Evals (${process.env.SCOPE})**`;
const body = `${prefix} — ⏳ building the image… ([logs](${runUrl}))`;
const { owner, repo } = context.repo;
const issue_number = context.payload.pull_request.number;
// Drop earlier verdicts first: they describe shas that are no longer head, and a stale
// green one reads as this PR passing. The prefix survives eval-run's rewrites.
// Drop this scope's earlier verdicts first: they describe shas that are no longer head,
// and a stale green one reads as this PR passing. Only this scope's, though — a sibling
// scope's comment is a live report on a run still going.
const existing = await github.paginate(github.rest.issues.listComments, { owner, repo, issue_number });
for (const c of existing.filter(c => c.body.startsWith('🤖 **Evals'))) {
// The second form is what the single `evals/smoke` trigger wrote before the labels were
// split per scope; nothing writes it any more, so this clause is only here to tidy PRs
// that predate the split and can go once none are open.
const stale = c => c.body.startsWith(prefix) || c.body.startsWith('🤖 **Evals smoke**');
for (const c of existing.filter(stale)) {
await github.rest.issues.deleteComment({ owner, repo, comment_id: c.id }).catch(() => {});
}
const { data } = await github.rest.issues.createComment({ owner, repo, issue_number, body });
core.setOutput('comment_id', String(data.id));
resolve:
# Collapse the dispatch inputs into the one full sha everything downstream needs: it keys the
# uberjar artifact, tags the ECR image, and tells eval-run which commit was measured. `pr` was
# not consulted at all before, so `pr: 12345` built the tip of whatever branch the run was
# launched from and then reported the result against the PR.
if: github.event_name == 'workflow_dispatch'
needs: prepare
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
permissions:
@@ -92,8 +154,8 @@ jobs:
id: sha
env:
GH_TOKEN: ${{ github.token }}
PR: ${{ inputs.pr }}
REF: ${{ inputs.ref }}
PR: ${{ needs.prepare.outputs.pr }}
REF: ${{ needs.prepare.outputs.ref }}
DEFAULT_SHA: ${{ github.sha }}
run: |
set -euo pipefail
@@ -119,75 +181,59 @@ jobs:
echo "sha=${SHA}" >> "$GITHUB_OUTPUT"
image:
needs: [resolve]
# `resolve` is workflow_dispatch-only, so tolerate it being skipped. The label guard is not
# optional: the trigger is `pull_request: [labeled]` with no filter of its own, so without it
# any label on any same-repo PR builds ee+oss and pushes to ECR — and since announce/smoke/
# finalize all skip in that case, a failure shows up as a bare red check with nothing
# explaining it.
if: >-
!cancelled()
&& (needs.resolve.result == 'success' || needs.resolve.result == 'skipped')
&& (github.event_name == 'workflow_dispatch'
|| (github.event_name == 'pull_request'
&& github.event.label.name == 'evals/smoke'
&& github.event.pull_request.head.repo.full_name == github.repository))
needs: resolve
uses: ./.github/workflows/build-private-ee-docker-image.yml
secrets:
PR_ENV_IAM_ROLE: ${{ secrets.PR_ENV_IAM_ROLE }}
PR_ENV_AWS_ACCOUNT_ID: ${{ secrets.PR_ENV_AWS_ACCOUNT_ID }}
with:
# Empty on the label path on purpose — the image workflow then falls back to the PR head,
# which is the artifact run-tests has already built and cached under that sha.
commit: ${{ needs.resolve.outputs.sha }}
smoke:
needs: [announce, image]
# `!cancelled()` is load-bearing, not decoration: on the label path `resolve` is skipped by
# design, and `image` only runs at all because it opts back in with its own `!cancelled()`.
# GitHub propagates that skip *transitively*, so a plain boolean `if` here — carrying the
# implicit `success()` — skips smoke even though image succeeded and the image is in ECR.
# Opting out of the implicit check means the needs' results have to be asserted by hand.
dispatch:
needs: [prepare, announce, resolve, image]
if: >-
!cancelled()
&& needs.announce.result == 'success'
&& needs.prepare.result == 'success'
&& (needs.announce.result == 'success' || needs.announce.result == 'skipped')
&& needs.resolve.result == 'success'
&& needs.image.result == 'success'
&& github.event_name == 'pull_request'
&& github.event.label.name == 'evals/smoke'
&& github.event.pull_request.head.repo.full_name == github.repository
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
env:
COMMENT_ID: ${{ needs.announce.outputs.comment_id }}
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
steps:
- name: Dispatch smoke eval-run
- name: Dispatch eval-run
env:
GH_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
PR: ${{ github.event.pull_request.number }}
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
EVALS_BRANCH: main
EVALS_BRANCH: ${{ needs.prepare.outputs.evals_branch }}
PR: ${{ needs.prepare.outputs.pr }}
SHA: ${{ needs.resolve.outputs.sha }}
SCOPE: ${{ needs.prepare.outputs.scope }}
SAMPLE: ${{ needs.prepare.outputs.sample }}
LABEL: ${{ needs.prepare.outputs.label }}
COMMENT_ID: ${{ needs.announce.outputs.comment_id }}
run: |
# `label` is the one eval-run consumes once it has taken the run over; empty on a manual
# dispatch, where there is nothing to consume.
gh api repos/metabase/evals/actions/workflows/eval-run.yml/dispatches \
-f ref="$EVALS_BRANCH" \
-f "inputs[pr]=$PR" \
-f "inputs[ref]=$HEAD_SHA" \
-f "inputs[scope]=smoke" \
-f "inputs[ref]=$SHA" \
-f "inputs[scope]=$SCOPE" \
-f "inputs[surfaces]=all" \
-f "inputs[sample]=5" \
-f "inputs[sample]=$SAMPLE" \
-f "inputs[label]=$LABEL" \
-f "inputs[evals_branch]=$EVALS_BRANCH" \
-f "inputs[comment_id]=$COMMENT_ID"
finalize:
# If the build or dispatch fell over, eval-run never took over the comment — leave a
# failure verdict instead of a comment stuck at "building the image…".
needs: [announce, image, smoke]
if: always() && needs.announce.result == 'success' && needs.smoke.result != 'success'
needs: [prepare, announce, resolve, image, dispatch]
if: always() && needs.announce.result == 'success' && needs.dispatch.result != 'success'
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
env:
COMMENT_ID: ${{ needs.announce.outputs.comment_id }}
SMOKE_RESULT: ${{ needs.smoke.result }}
IMAGE_RESULT: ${{ needs.image.result }}
SCOPE: ${{ needs.prepare.outputs.scope }}
LABEL: ${{ needs.prepare.outputs.label }}
NEEDS_JSON: ${{ toJSON(needs) }}
steps:
- name: Comment (build/dispatch failed)
uses: actions/github-script@v9
@@ -195,11 +241,12 @@ jobs:
github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
script: |
const runUrl = `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`;
// A concurrency-cancelled retrigger lands here too; don't stamp it as an infra failure.
const cancelled = [process.env.SMOKE_RESULT, process.env.IMAGE_RESULT].includes('cancelled');
const cancelled = Object.values(JSON.parse(process.env.NEEDS_JSON))
.some(j => j.result === 'cancelled');
const prefix = `🤖 **Evals (${process.env.SCOPE})**`;
const body = cancelled
? `🤖 **Evals smoke** — ⚪ cancelled before evals started ([logs](${runUrl}))`
: `🤖 **Evals smoke** — ❌ build or dispatch failed before evals started ([logs](${runUrl}))`;
? `${prefix} — ⚪ cancelled before evals started ([logs](${runUrl}))`
: `${prefix} — ❌ build or dispatch failed before evals started ([logs](${runUrl}))`;
// The replacement run deletes this comment on its way in, so a concurrency cancel can
// land here with nothing to patch. Losing the stamp is fine; failing the job isn't.
await github.rest.issues.updateComment({
@@ -212,32 +259,5 @@ jobs:
await github.rest.issues.removeLabel({
owner: context.repo.owner, repo: context.repo.repo,
issue_number: context.payload.pull_request.number,
name: 'evals/smoke',
name: process.env.LABEL,
}).catch(() => {});
dispatch:
needs: [resolve, image]
# Deliberately no `always()`: benchmarking without the image this run was supposed to produce
# would measure a stale build or nothing at all. A failed `image` fails the run, which is the
# signal here — unlike the PR path there is no comment for `finalize` to stamp.
if: github.event_name == 'workflow_dispatch'
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Dispatch eval-run
env:
GH_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
EVALS_BRANCH: ${{ github.event.inputs.evals_branch }}
PR: ${{ inputs.pr }}
# The sha the image was actually built and tagged with, not the raw `ref` input.
REF: ${{ needs.resolve.outputs.sha }}
SCOPE: ${{ inputs.scope }}
SAMPLE: ${{ inputs.sample }}
run: |
gh api repos/metabase/evals/actions/workflows/eval-run.yml/dispatches \
-f ref="$EVALS_BRANCH" \
-f "inputs[pr]=$PR" \
-f "inputs[ref]=$REF" \
-f "inputs[scope]=$SCOPE" \
-f "inputs[sample]=${SAMPLE:-5}" \
-f "inputs[evals_branch]=$EVALS_BRANCH"

View File

@@ -217,7 +217,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-mysql:
needs: app-db-matrix
@@ -311,7 +310,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-postgres:
needs: app-db-matrix
@@ -332,7 +330,6 @@ jobs:
build-static-viz: true
test-args: >-
:only '"test"'
:exclude-tags [:mb/driver-tests]
:partition/total 2
:partition/index 0
exclude-tag: ':mb/driver-tests :mb/transforms-python-test'
@@ -389,7 +386,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
app-db-tests-result:
needs:

View File

@@ -10,6 +10,18 @@ on:
description: Run the full suite regardless of the diff (master / release branches).
type: boolean
default: false
run-project-backend-checks:
description: Run project-level backend checks.
type: boolean
default: false
run-project-migration-checks:
description: Run project-level migration checks.
type: boolean
default: false
run-project-ratchet-checks:
description: Run the ratchet check for a diff that touches nothing but the ratchets file.
type: boolean
default: false
# Run the backend test suite on demand, against the ref you dispatch on, optionally under a
# profiler. Everything else about the jobs -- matrix legs, tag filters, quarantine gating -- is
@@ -46,6 +58,95 @@ env:
ONLY_TESTS: ${{ inputs.tests }}
jobs:
project-checks:
name: 'Project tests: Suites'
if: >-
${{ inputs.force-run ||
inputs.run-project-backend-checks ||
inputs.run-project-migration-checks ||
inputs.run-project-ratchet-checks }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
steps:
- uses: actions/checkout@v6
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
# Bootstrap the shared Mage runtime before concurrent commands try to install it themselves.
- name: Prepare Mage
run: ./bin/mage
- parallel:
- name: Run backend checks
if: ${{ inputs.force-run || inputs.run-project-backend-checks }}
run: ./bin/mage project-tests backend
- name: Run migration checks
if: ${{ inputs.force-run || inputs.run-project-migration-checks }}
run: ./bin/mage project-tests migrations
# Babashka, not a JVM test run, so it is cheap enough to run alongside the backend checks.
# It still needs the JDK prepare-backend installs, to resolve clj-kondo on a cold cache.
- name: Run ratchet checks
if: ${{ inputs.force-run || inputs.run-project-backend-checks || inputs.run-project-ratchet-checks }}
run: ./bin/mage kondo-ratchets
project-tests:
name: Project tests
needs: project-checks
if: ${{ always() && !cancelled() }}
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Check Project tests status
uses: actions/github-script@v9
env:
needs: ${{ toJson(needs) }}
with:
script: | # js
const needs = JSON.parse(process.env.needs);
const jobs = Object.entries(needs).map(
([jobName, jobValues]) => ({
name: jobName,
result: jobValues.result
}));
if (jobs.every(job => job.result === 'skipped' || job.result === 'success')) {
console.log('');
console.log(' |>>> |>>> |>>>');
console.log(' | | |');
console.log(' _ _|_ _ _ _|_ _ _ _|_ _');
console.log(' | |_| |_| |______| |_| |_| |______| |_| |_| |');
console.log(' | | | | | |');
console.log(' | [] [] | | [] [] | | [] [] |');
console.log(' | |______| |______| |');
console.log(' | ___ |');
console.log(' |___________________| |___________________|');
console.log(' |___|');
console.log('');
console.log('Everything is up to code and structurally sound.');
process.exit(0);
}
console.log('');
console.log(' .-===========-.____');
console.log(' /_______________\\ \\____');
console.log(' | .-----------. | \\___');
console.log(' | | x x | | \\__');
console.log(' | | ~ | | _\\_');
console.log(" | `-----------' | /___\\");
console.log(' | o o |');
console.log(" `-----------------'");
console.log(' /=============\\');
console.log(' / O O O O O O O \\');
console.log(' \\_______________/');
console.log('');
console.log('One or more project checks are off the blueprint. Hard hats required.');
jobs.forEach((job) => {
if (job.result !== 'success' && job.result !== 'skipped') {
console.log(`${job.name} - ${job.result}`);
}
});
process.exit(1);
be-linter-clj-kondo:
if: ${{ !inputs.skip }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
@@ -80,7 +181,7 @@ jobs:
- uses: actions/checkout@v6
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- run: clojure -X:dev:ee:ee-dev:drivers:drivers-dev:test:eastwood/test
- run: clojure -X:dev:dev/test:ee:ee-dev:drivers:drivers-dev:test:eastwood/test
name: Run Eastwood linter on our backend tests
be-linter-eastwood-test-changed:
@@ -108,13 +209,14 @@ jobs:
# last synced don't widen our scope. Falls back to BASE_SHA if older than fetched depth.
git fetch --no-tags --depth=200 origin "$BASE_SHA"
DIFF_BASE=$(git merge-base "$BASE_SHA" "$HEAD_SHA" 2>/dev/null || echo "$BASE_SHA")
# Test roots we lint: core, EE, and each driver module's test tree.
# Test roots we lint: core, EE, dev/test, and each driver module's test tree.
# :eastwood/test derives matching :source-paths from the classpath, so any
# namespace we name here is reachable. Include renames (R) so a test that
# was just renamed still gets linted under its new name.
FILES=$(git diff --name-only --diff-filter=AMR "$DIFF_BASE" "$HEAD_SHA" \
-- 'test/**/*.clj' 'test/**/*.cljc' \
'enterprise/backend/test/**/*.clj' 'enterprise/backend/test/**/*.cljc' \
'dev/test/**/*.clj' 'dev/test/**/*.cljc' \
'modules/drivers/**/test/**/*.clj' 'modules/drivers/**/test/**/*.cljc')
if [ -z "$FILES" ]; then
@@ -130,7 +232,14 @@ jobs:
exit 1
fi
NS=$(sed -E 's#^(test/|enterprise/backend/test/|modules/drivers/[^/]+/test/)##; s#\.cljc?$##; s#/#.#g; s#_#-#g' <<<"$FILES" \
# Convert each test path to a Clojure namespace: strip its known test root and
# extension, then translate path separators and underscores. Keep these roots
# aligned with FILES above and the Eastwood classpath aliases below.
NS=$(sed -E \
-e 's#^(test/|enterprise/backend/test/|dev/test/|modules/drivers/[^/]+/test/)##' \
-e 's#\.cljc?$##' \
-e 's#/#.#g' \
-e 's#_#-#g' <<<"$FILES" \
| sort -u \
| paste -sd' ' -)
echo "Changed test namespaces: $NS"
@@ -139,7 +248,7 @@ jobs:
if: steps.changed.outputs.namespaces != ''
env:
NAMESPACES: ${{ steps.changed.outputs.namespaces }}
run: clojure -X:dev:ee:ee-dev:drivers:drivers-dev:test:eastwood/test :namespaces "[$NAMESPACES]"
run: clojure -X:dev:dev/test:ee:ee-dev:drivers:drivers-dev:test:eastwood/test :namespaces "[$NAMESPACES]"
be-tests:
if: ${{ !inputs.skip }}
@@ -368,6 +477,7 @@ jobs:
be-tests-result:
needs:
- project-tests
- be-linter-eastwood
- be-linter-eastwood-test
- be-linter-eastwood-test-changed

View File

@@ -1,15 +0,0 @@
name: Block Master Branch PRs
on:
pull_request:
types: [opened, synchronize]
jobs:
check-source-branch:
if: github.head_ref == 'master'
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Block master branch PRs
run: |
echo "PRs from \`master\` branches are not allowed, please use a new branch name for your PR."
exit 1

View File

@@ -136,5 +136,7 @@ jobs:
context: bin/docker/
platforms: linux/amd64
network: host
build-args: |
GIT_COMMIT_SHA=${{ steps.meta.outputs.tag }}
tags: ${{ secrets.PR_ENV_AWS_ACCOUNT_ID }}.dkr.ecr.us-east-1.amazonaws.com/metabase-enterprise:${{ steps.meta.outputs.tag }}
push: true

View File

@@ -79,6 +79,7 @@ jobs:
test-build-scripts:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
steps:
- uses: actions/checkout@v6
- name: Prepare back-end environment
@@ -88,10 +89,6 @@ jobs:
- name: Run build and release script tests
run: clojure -X:dev:drivers:build:build-dev:build-test:ci
timeout-minutes: 15
- name: Run Liquibase migrations linter tests
run: clojure -M:test
working-directory: bin/lint-migrations-file
timeout-minutes: 15
- name: Run load-namespaces tests
run: clojure -M:test
working-directory: bin/load-namespaces

View File

@@ -4,25 +4,54 @@ name: Bundle Size Stats
# emitted JS) plus the bundle-stats and embedding-sdk artifacts, measures
# initial/total bundle sizes, and appends them to eng-stats-importer.
# Triggered by "Run tests", which is the workflow that builds the uberjar on a
# master merge.
on:
workflow_run:
workflows: ["Build Uberjar"]
workflows: ["Run tests"]
types: [completed]
# Master only: releases form non-linear lines whose deltas are meaningless,
# so their sizes are backfilled separately rather than logged here.
branches: [master]
workflow_call:
inputs:
commit:
description: "Commit SHA to measure."
type: string
required: false
default: ""
concurrency:
group: bundle-size-stats-${{ github.event.workflow_run.head_sha }}
group: bundle-size-stats-${{ inputs.commit || github.event.workflow_run.head_sha }}
cancel-in-progress: true
jobs:
# "Run tests" concludes `failure` on master more often than `success`, from
# jobs that have nothing to do with the jar, so its conclusion is not a usable
# gate. The artifact is one: the uberjar job publishes it, and a docs-only
# merge that skipped that job publishes none.
uberjar-built:
if: ${{ github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
outputs:
found: ${{ steps.probe.outputs.fetch-hit }}
steps:
- uses: actions/checkout@v6
- id: probe
uses: ./.github/actions/fetch-artifact
with:
commit: ${{ inputs.commit || github.event.workflow_run.head_sha }}
edition: ee
download: false
bundle-size-stats:
if: ${{ github.event.workflow_run.conclusion == 'success' && github.repository == 'metabase/metabase' }}
needs: [uberjar-built]
if: ${{ needs.uberjar-built.outputs.found == 'true' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
env:
HEAD_SHA: ${{ github.event.workflow_run.head_sha }}
HEAD_SHA: ${{ inputs.commit || github.event.workflow_run.head_sha }}
# Only record a data point when a bundle's as-served size (brotli where the
# build ships .br, else gzip) moved by at least this percent vs the last
# plotted point, keeping the chart to real changes.
@@ -31,12 +60,12 @@ jobs:
- name: Check out the code
uses: actions/checkout@v6
with:
ref: ${{ github.event.workflow_run.head_sha }}
ref: ${{ env.HEAD_SHA }}
- uses: ./.github/actions/prepare-node-bun
- name: Download EE uberjar
uses: ./.github/actions/fetch-artifact
with:
commit: ${{ github.event.workflow_run.head_sha }}
commit: ${{ env.HEAD_SHA }}
edition: ee
extract-path: temp/uberjar
- name: Extract front-end bundles from uberjar
@@ -108,7 +137,7 @@ jobs:
run: bun ./.github/scripts/bundle-size-stats-prepare.ts
- name: Import sizes (with deltas) into Stats
id: upload
if: steps.prepare.outputs.significant == 'true'
if: ${{ steps.prepare.outputs.significant == 'true' && inputs.commit == '' }}
env:
ROWS: artifacts/upload-rows.json
ENG_STATS_URL: ${{ secrets.ENG_STATS_URL }}

View File

@@ -1,4 +1,4 @@
# Writes the three large dependency caches. Every other job restores them and none of them writes.
# Writes the shared dependency caches. Every other job restores them and none of them writes.
#
# A single writer rather than the usual let-every-job-save arrangement, because a pull request here fans
# out to roughly 200 jobs, ~75 of which install Cypress. Letting each of those save would have them all
@@ -13,7 +13,7 @@
# at it, and master's copy backs up every ref that has none of its own.
#
# Keys are content-derived (see .github/scripts/cache-keys.sh), so a push whose dependencies already have
# an entry does nothing but three lookups. There is no cron: nothing here is keyed by date.
# an entry does nothing but four lookups. There is no cron: nothing here is keyed by date.
#
#
# PRINCIPLES:
@@ -69,6 +69,13 @@ jobs:
path: ${{ steps.cache-spec.outputs.bun-store-path }}
key: ${{ steps.cache-spec.outputs.bun-store-key }}
lookup-only: true
- name: Look up Clojure CLI
id: clojure-lookup
uses: actions/cache/restore@v5
with:
path: ${{ steps.cache-spec.outputs.clojure-path }}
key: ${{ steps.cache-spec.outputs.clojure-key }}
lookup-only: true
- name: Look up Cypress binary
id: cypress-lookup
uses: actions/cache/restore@v5
@@ -77,10 +84,19 @@ jobs:
key: ${{ steps.cache-spec.outputs.cypress-key }}
lookup-only: true
# Also runs when only the Clojure CLI entry is missing: installing it is what there is to save,
# and the pre-resolve below needs it either way.
- name: Prepare backend
if: steps.m2-lookup.outputs.cache-hit != 'true'
if: steps.m2-lookup.outputs.cache-hit != 'true' || steps.clojure-lookup.outputs.cache-hit != 'true'
uses: ./.github/actions/prepare-backend
- name: Save Clojure CLI
if: steps.clojure-lookup.outputs.cache-hit != 'true'
uses: actions/cache/save@v5
with:
path: ${{ steps.cache-spec.outputs.clojure-path }}
key: ${{ steps.cache-spec.outputs.clojure-key }}
# Pre-resolve every Clojure dependency classpath CI actually uses, so the saved cache is a SUPERSET
# of what each job resolves at runtime.
#
@@ -102,7 +118,9 @@ jobs:
combos=(
":build:dev:ee:ee-dev:drivers:drivers-dev:cljs" # build + uberjar (combined classpath)
":cljs" # shadow-cljs (build:cljs); resolves :cljs alone -> covers asm:9.2
":dev:ee:ee-dev:drivers:drivers-dev:test:eastwood" # backend.yml (eastwood + eastwood/test)
":dev:ee:ee-dev:drivers:drivers-dev:test:eastwood" # backend.yml (eastwood)
":dev:dev/test:ee:ee-dev:drivers:drivers-dev:test:eastwood/test" # backend.yml (eastwood tests)
":dev:dev/test:ee:ee-dev:drivers:drivers-dev:test:ci" # run-tests.yml (project tests)
":dev:ci:ee:ee-dev:drivers:drivers-dev:test" # test-driver.yml (ee) -> covers data.json:2.4.0
":dev:ci:oss:oss-dev:drivers:drivers-dev:test" # test-driver.yml (oss)
":dev:ci:test:ee:ee-dev" # backend.yml matrix (ee)
@@ -124,6 +142,20 @@ jobs:
echo "::endgroup::"
done
# These commands use nested tools.deps projects; resolving the same alias from the
# repository root does not warm their dependencies.
nested_combos=(
"bin/lint-migrations-file|:test" # project migration checks
"bin/load-namespaces|:test" # build-scripts.yml
)
for spec in "${nested_combos[@]}"; do
project=${spec%%|*}
combo=${spec#*|}
echo "::group::${project}: clojure -P -M${combo}"
(cd "$project" && clojure -P -M"${combo}")
echo "::endgroup::"
done
echo "::group::./bin/mage"
./bin/mage
echo "::endgroup::"

View File

@@ -1,21 +0,0 @@
name: Prevent backport.sh from being merged
on:
pull_request:
types: [opened, synchronize, reopened]
jobs:
check-backport-script:
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Checkout code
uses: actions/checkout@v6
- name: Check for backport.sh file
run: |
if [ -f "./backport.sh" ]; then
echo "backport.sh file exists. Please remove it before merging."
exit 1
else
echo "All good."
fi

View File

@@ -1,5 +1,5 @@
name: Containerize Uberjar
run-name: Containerize ${{ inputs.tag }} Uberjar
run-name: Containerize ${{ inputs.edition }} ${{ inputs.tag }} Uberjar
on:
workflow_call:
@@ -9,9 +9,10 @@ on:
type: string
required: true
repo:
description: owner and repo like "metabase/metabase"
description: Docker owner and repo, e.g. "metabase/metabase".
type: string
tag:
description: Docker tag, e.g. v1.87.2.
type: string
commit:
type: string
@@ -30,10 +31,10 @@ on:
- oss
required: true
repo:
description: docker owner and repo like "metabase/metabase"
description: Docker owner and repo, e.g. "metabase/metabase".
type: string
tag:
description: usually a version like v1.87.2
description: Docker tag, e.g. v1.87.2.
type: string
commit:
description: the full commit hash
@@ -45,10 +46,14 @@ on:
jobs:
containerize:
name: containerize (${{ inputs.edition }})
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
outputs:
platforms: ${{ steps.platforms.outputs.result }}
repo: ${{ steps.image.outputs.repo }}
tag: ${{ steps.image.outputs.tag }}
full_image: ${{ steps.image.outputs.full_image }}
steps:
- uses: actions/checkout@v6
with:
@@ -65,6 +70,13 @@ jobs:
release: ${{ inputs.release }}
- name: Prepare release scripts
uses: ./.github/actions/prepare-release-scripts
- name: Resolve image repo and tag
id: image
uses: ./.github/actions/get-docker-info
with:
repo: ${{ inputs.repo }}
tag: ${{ inputs.tag }}
edition: ${{ inputs.edition }}
- name: Get platforms
id: platforms
uses: actions/github-script@v9
@@ -72,7 +84,7 @@ jobs:
result-encoding: string
script: | # js
const { getBuildRequirements, isValidVersionString} = require('${{ github.workspace }}/release/dist/index.cjs');
const version = "${{ inputs.tag }}".split('-')[0];
const version = "${{ steps.image.outputs.tag }}".split('-')[0];
if (!isValidVersionString(version)) {
return "linux/amd64,linux/arm64";
@@ -100,7 +112,7 @@ jobs:
context: bin/docker/.
platforms: ${{ steps.platforms.outputs.result }}
network: host
tags: ${{ inputs.repo }}:${{ inputs.tag }}
tags: ${{ steps.image.outputs.full_image }}
no-cache: true
push: true
build-args: ${{ inputs.build-args }}
@@ -108,16 +120,26 @@ jobs:
# we need to do this to get the nice fallback behavior of the legacy manifest file
- name: Build container (x86 only)
if: contains(steps.platforms.outputs.result, 'arm') == false
env:
BUILD_ARGS: ${{ inputs.build-args }}
FULL_IMAGE: ${{ steps.image.outputs.full_image }}
run: | # bash
args=()
while IFS= read -r line; do
[ -n "$line" ] && args+=(--build-arg "$line")
done <<< "$BUILD_ARGS"
docker build \
-t ${{ inputs.repo }}:${{ inputs.tag }} \
-t "$FULL_IMAGE" \
"${args[@]}" \
--network=host \
--push \
bin/docker/.
verify-docker-pull:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: containerize
name: verify-docker-pull (${{ inputs.edition }})
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
steps:
- name: Login to Docker Hub
@@ -126,18 +148,19 @@ jobs:
username: ${{ inputs.release && secrets.DOCKERHUB_RELEASE_USERNAME || secrets.DOCKERHUB_USERNAME }}
password: ${{ inputs.release && secrets.DOCKERHUB_RELEASE_TOKEN || secrets.DOCKERHUB_TOKEN }}
- name: Pull the container image
run: docker pull ${{ inputs.repo }}:${{ inputs.tag }}
run: docker pull ${{ needs.containerize.outputs.full_image }}
- name: Launch container
run: docker run --rm -dp 3000:3000 ${{ inputs.repo }}:${{ inputs.tag }}
run: docker run --rm -dp 3000:3000 ${{ needs.containerize.outputs.full_image }}
timeout-minutes: 5
- name: Wait for Metabase to start
run: while ! curl -s 'http://localhost:3000/api/health' | grep '{"status":"ok"}'; do sleep 1; done
timeout-minutes: 5
verify-docker-pull-arm:
runs-on: arm-ubuntu-24-2core
needs: containerize
if: contains(needs.containerize.outputs.platforms, 'linux/arm64')
name: verify-docker-pull-arm (${{ inputs.edition }})
runs-on: arm-ubuntu-24-2core
timeout-minutes: 15
steps:
- name: Login to Docker Hub
@@ -146,10 +169,41 @@ jobs:
username: ${{ inputs.release && secrets.DOCKERHUB_RELEASE_USERNAME || secrets.DOCKERHUB_USERNAME }}
password: ${{ inputs.release && secrets.DOCKERHUB_RELEASE_TOKEN || secrets.DOCKERHUB_TOKEN }}
- name: Pull the container image
run: docker pull ${{ inputs.repo }}:${{ inputs.tag }}
run: docker pull ${{ needs.containerize.outputs.full_image }}
- name: Launch container
run: docker run --rm -dp 3000:3000 ${{ inputs.repo }}:${{ inputs.tag }}
run: docker run --rm -dp 3000:3000 ${{ needs.containerize.outputs.full_image }}
timeout-minutes: 5
- name: Wait for Metabase to start
run: while ! curl -s 'http://localhost:3000/api/health' | grep '{"status":"ok"}'; do sleep 1; done
timeout-minutes: 5
post-docker-info-comment:
needs: [containerize, verify-docker-pull, verify-docker-pull-arm]
# Only post a comment if all the steps pass and this is a PR.
if: |
!cancelled() &&
!failure() &&
!inputs.release &&
github.event_name == 'pull_request'
name: post-docker-info-comment (${{ inputs.edition }})
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Post PR comment
uses: marocchino/sticky-pull-request-comment@0ea0beb66eb9baf113663a64ec522f60e49231c0 # v3.0.4
with:
header: docker-build-status-${{ inputs.edition }}
message: |
✅ Docker build completed for commit ${{ inputs.commit || github.event.pull_request.head.sha || github.sha }}
The uberjar has been built and containerized successfully.
**Branch:** `${{ github.head_ref || github.ref_name }}`
**Docker Image:** `${{ needs.containerize.outputs.full_image }}`
**Docker Hub:** [View on Docker Hub](https://hub.docker.com/r/${{ needs.containerize.outputs.repo }}/tags?name=${{ needs.containerize.outputs.tag }})
**Triggered by:** @${{ github.actor }}
Pull the image:
```bash
docker pull ${{ needs.containerize.outputs.full_image }}
```

View File

@@ -1,102 +0,0 @@
name: Containerize Uberjar
on:
workflow_call:
workflow_dispatch:
inputs:
commit:
description: the full commit hash to containerize (defaults to the triggering commit)
type: string
jobs:
get-container-info:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
name: Get container info
outputs:
editions: ${{ steps.ee-info.outputs.editions }}
ee: ${{ toJson(fromJson(steps.build-matrix.outputs.result).ee) }}
oss: ${{ toJson(fromJson(steps.build-matrix.outputs.result).oss) }}
steps:
- name: Check out the code
uses: actions/checkout@v6
- name: Get EE Docker info
id: ee-info
uses: ./.github/actions/get-docker-info
with:
edition: ee
- name: Get OSS Docker info
id: oss-info
uses: ./.github/actions/get-docker-info
with:
edition: oss
- name: Build matrix info
id: build-matrix
uses: actions/github-script@v9
with:
script: | # js
const editions = JSON.parse('${{ steps.ee-info.outputs.editions }}');
const result = {
editions: editions,
ee: {
repo: '${{ steps.ee-info.outputs.repo }}',
tag: '${{ steps.ee-info.outputs.tag }}'
},
oss: {
repo: '${{ steps.oss-info.outputs.repo }}',
tag: '${{ steps.oss-info.outputs.tag }}'
}
};
console.log('Build matrix:', result);
return result;
containerize:
needs: [get-container-info]
if: needs.get-container-info.result == 'success'
strategy:
matrix:
edition: ${{ fromJson(needs.get-container-info.outputs.editions) }}
uses: ./.github/workflows/containerize-jar.yml
secrets: inherit
with:
edition: ${{ matrix.edition }}
commit: ${{ github.event.inputs.commit || github.event.pull_request.head.sha || github.sha }}
repo: ${{ fromJson(needs.get-container-info.outputs[matrix.edition]).repo }}
tag: ${{ fromJson(needs.get-container-info.outputs[matrix.edition]).tag }}
release: false
build-args: |
GIT_COMMIT_SHA=${{ github.event.inputs.commit || github.event.pull_request.head.sha || github.sha }}
post-comment:
needs: [get-container-info, containerize]
if: github.event_name == 'pull_request'
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: Post PR comment
steps:
- name: Check out the code
uses: actions/checkout@v6
- name: Get Docker info for comment
id: docker-info
uses: ./.github/actions/get-docker-info
with:
branch: ${{ github.head_ref || github.ref_name }}
edition: ee
- name: Post PR comment
uses: marocchino/sticky-pull-request-comment@0ea0beb66eb9baf113663a64ec522f60e49231c0 # v3.0.4
with:
header: docker-build-status
message: |
✅ Docker build completed for commit ${{ github.event.pull_request.head.sha || github.sha }}
The uberjar has been built and containerized successfully.
**Branch:** `${{ github.head_ref || github.ref_name }}`
**Docker Image:** `${{ steps.docker-info.outputs.full_image }}`
**Docker Hub:** [View on Docker Hub](https://hub.docker.com/r/${{ steps.docker-info.outputs.repo }}/tags?name=${{ steps.docker-info.outputs.tag }})
**Triggered by:** @${{ github.actor }}
Pull the image:
```bash
docker pull ${{ steps.docker-info.outputs.full_image }}
```

View File

@@ -59,6 +59,12 @@ jobs:
# Pushing the new branch triggers set-milestone.yml, which does the
# full milestone backfill and then dispatches release-notes-preview
# to upload the markdown to #writing.
#
# Kondo ignore ratchets apply only to master. The cut commit replaces the
# budgets with an explicit opt-out so future budget changes are not applied
# to the release branch. Keeping the opt-out in the canonical file avoids
# introducing a separate marker that could drift out of sync, and the
# backport helper writes the same opt-out so both paths stay identical.
- name: Cut the branch
id: cut
run: |
@@ -66,6 +72,9 @@ jobs:
git config user.name github-actions
git config user.email github-actions@github.com
git checkout -b "$BRANCH"
source .github/actions/create-backport/kondo-ratchets.sh
write_disabled_ratchets
git add --sparse .clj-kondo/ratchets.edn
git commit --allow-empty --no-verify -m "Cut $BRANCH branch"
git push -u origin "$BRANCH"
echo "sha=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT"

View File

@@ -75,6 +75,17 @@ jobs:
clojure -M:ee:doc command-documentation
continue-on-error: false
- name: Generate AI provider documentation
id: generate_ai_provider_docs
# The generator only exists on branches that ship the multi-provider registry (master / 64+), but
# this reusable workflow always runs from master, so skip the step on release branches without it.
if: hashFiles('src/metabase/cmd/ai_provider_dox.clj') != ''
run: |
set -e # Exit on any error
echo "Generating AI provider documentation..."
clojure -M:ee:doc ai-providers-documentation
continue-on-error: false
- name: Generate usage analytics documentation
run: ./bin/generate-usage-analytics-docs.bb
@@ -164,6 +175,7 @@ jobs:
- \`clojure -M:ee:doc config-template\`
- \`clojure -M:ee:doc api-documentation\`
- \`clojure -M:ee:doc command-documentation\`
- \`clojure -M:ee:doc ai-providers-documentation\`
- \`./bin/generate-usage-analytics-docs.bb\`
- \`bun run embedding-sdk:docs:generate\`
- \`bun run embedding-eajs:docs:generate\`

View File

@@ -32,3 +32,9 @@ jobs:
fail: true
args: docs --config ./.lychee/config.toml --offline
format: markdown
# lychee can't read the YAML nav, so this script renders it as markdown first. lychee is on PATH
# from the step above.
- name: Check nav.yml links
if: ${{ !cancelled() }}
run: docs/util/check-links.sh nav

View File

@@ -74,6 +74,7 @@ jobs:
# All decision logic is consolidated in mage driver-decisions.
determine-driver-skips:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
outputs:
# All driver run decisions (from mage driver-decisions)
h2-should-run: ${{ steps.driver-decisions.outputs.h2-should-run }}
@@ -162,35 +163,16 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-bigquery-cloud-sdk-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.bigquery-should-run == 'true' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 70
timeout-minutes: 40
strategy:
fail-fast: false
matrix:
job:
- name: Driver Tests Part 1
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 2
:partition/index 0
- name: Driver Tests Part 2
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 2
:partition/index 1
- name: Transforms Python Tests
test-args: >-
:only-tags [:mb/transforms-python-test]
needs-python-runner: true
runner-index: [0, 1]
env:
CI: 'true'
DRIVERS: bigquery-cloud-sdk
@@ -201,11 +183,43 @@ jobs:
MB_BIGQUERY_TEST_REFRESH_TOKEN: ${{ secrets.MB_BIGQUERY_TEST_REFRESH_TOKEN }}
MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON: ${{ secrets.MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON }}
MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON_ROUTING: ${{ secrets.MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON_ROUTING }}
name: BigQuery ${{ matrix.job.name }}
name: BigQuery Driver Tests ${{ matrix.runner-index }}
steps:
- uses: actions/checkout@v6
- name: Test BigQuery Cloud SDK driver
id: test-driver
uses: ./.github/actions/test-driver
with:
junit-name: 'be-tests-bigquery-cloud-sdk-ee'
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
runner-index: ${{ matrix.runner-index }}
runner-count: ${{ strategy.job-total }}
jvms-per-runner: '2'
heap-per-jvm: '4g'
artifact-suffix: runner-${{ matrix.runner-index }}
be-tests-bigquery-transforms-python-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.bigquery-should-run == 'true' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
env:
CI: 'true'
DRIVERS: bigquery-cloud-sdk
MB_BIGQUERY_TEST_PROJECT_ID: ${{ secrets.BIGQUERY_TEST_PROJECT_ID }}
MB_BIGQUERY_TEST_CLIENT_ID: ${{ secrets.MB_BIGQUERY_TEST_CLIENT_ID }}
MB_BIGQUERY_TEST_CLIENT_SECRET: ${{ secrets.MB_BIGQUERY_TEST_CLIENT_SECRET }}
MB_BIGQUERY_TEST_ACCESS_TOKEN: ${{ secrets.MB_BIGQUERY_TEST_ACCESS_TOKEN }}
MB_BIGQUERY_TEST_REFRESH_TOKEN: ${{ secrets.MB_BIGQUERY_TEST_REFRESH_TOKEN }}
MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON: ${{ secrets.MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON }}
MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON_ROUTING: ${{ secrets.MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON_ROUTING }}
name: BigQuery Transforms Python Tests
steps:
- uses: actions/checkout@v6
- name: Setup python-runner
if: ${{ matrix.job.needs-python-runner == true }}
uses: ./.github/actions/setup-python-runner
with:
metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
@@ -213,16 +227,17 @@ jobs:
id: test-driver
uses: ./.github/actions/test-driver
with:
# This is the same as the cloud-sdk job above to preserve quarantine history in ci-conductor.
junit-name: 'be-tests-bigquery-cloud-sdk-ee'
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
test-args: >-
:only-tags [:mb/transforms-python-test]
artifact-suffix: transforms-python
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
if: ${{ always() }}
uses: ./.github/actions/cleanup-python-runner
with:
upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
logs-artifact-suffix: ${{ matrix.job.name }}
logs-artifact-suffix: transforms-python
be-tests-clickhouse-ee:
needs: determine-driver-skips
@@ -279,7 +294,6 @@ jobs:
junit-name: 'be-tests-clickhouse-ee'
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -313,7 +327,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-databricks-ee:
needs: determine-driver-skips
@@ -341,15 +354,33 @@ jobs:
env:
CI: 'true'
DRIVERS: databricks
MB_DATABRICKS_TEST_HOST: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HOST }}
MB_DATABRICKS_TEST_HTTP_PATH: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HTTP_PATH }}
MB_DATABRICKS_TEST_TOKEN: ${{ secrets.MB_DATABRICKS_JDBC_TEST_TOKEN }}
MB_DATABRICKS_TEST_CATALOG: 'metabase_ci'
MB_DATABRICKS_TEST_CATALOG_ROUTING: 'metabase_routing_catalog'
MB_DATABRICKS_TEST_CLIENT_ID: ${{ secrets.MB_DATABRICKS_JDBC_TEST_CLIENT_ID }}
MB_DATABRICKS_TEST_OAUTH_SECRET: ${{ secrets.MB_DATABRICKS_JDBC_TEST_OAUTH_SECRET }}
name: Databricks
steps:
- name: Select Databricks workspace
shell: bash
env:
TOTAL_SHARDS: '2'
HOST_0: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HOST }}
TOKEN_0: ${{ secrets.MB_DATABRICKS_JDBC_TEST_TOKEN }}
HTTP_PATH_0: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HTTP_PATH }}
HOST_1: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HOST_2 }}
TOKEN_1: ${{ secrets.MB_DATABRICKS_JDBC_TEST_TOKEN_2 }}
HTTP_PATH_1: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HTTP_PATH_2 }}
run: | # sh
shard=$(( GITHUB_RUN_NUMBER % TOTAL_SHARDS ))
echo "Using Databricks workspace shard $(( shard + 1 )) of $TOTAL_SHARDS"
for name in HOST HTTP_PATH TOKEN; do
var="${name}_${shard}"
if [ -z "${!var}" ]; then
echo "::error::Secret $var is empty - is the shard $shard Databricks workspace configured?"
exit 1
fi
echo "MB_DATABRICKS_TEST_${name}=${!var}" >> "$GITHUB_ENV"
done
- uses: actions/checkout@v6
- name: Test Databricks driver
id: test-driver
@@ -358,47 +389,6 @@ jobs:
junit-name: 'be-tests-databricks-ee'
artifact-suffix: ${{ matrix.job.name }}
test-args: ${{ matrix.job.test-args }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
# there's no need for this to be a completely separate job; it should be
# just another test or set of tests inside metabase.driver.databricks-test,
# but for the time being let's just get rid of the full duplication and just
# run the tests that are affected by the multi-catalog behavior.
be-tests-databricks-multi-catalog-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.databricks-should-run == 'true' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 50
strategy:
fail-fast: false
matrix:
job:
- name: Driver Tests
test-args: >-
:only metabase.driver.databricks-test
:fail-fast? true
env:
CI: 'true'
DRIVERS: databricks
MB_DATABRICKS_TEST_MULTI_LEVEL_SCHEMA: true
MB_DATABRICKS_TEST_HOST: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HOST }}
MB_DATABRICKS_TEST_HTTP_PATH: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HTTP_PATH }}
MB_DATABRICKS_TEST_TOKEN: ${{ secrets.MB_DATABRICKS_JDBC_TEST_TOKEN }}
MB_DATABRICKS_TEST_CATALOG: 'metabase_ci'
MB_DATABRICKS_TEST_CATALOG_ROUTING: 'metabase_routing_catalog'
MB_DATABRICKS_TEST_CLIENT_ID: ${{ secrets.MB_DATABRICKS_JDBC_TEST_CLIENT_ID }}
MB_DATABRICKS_TEST_OAUTH_SECRET: ${{ secrets.MB_DATABRICKS_JDBC_TEST_OAUTH_SECRET }}
name: Databricks (Multi-Catalog)
steps:
- uses: actions/checkout@v6
- name: Test Databricks driver with multi-catalog
id: test-driver
uses: ./.github/actions/test-driver
with:
junit-name: 'be-tests-databricks-multi-catalog-ee'
artifact-suffix: ${{ matrix.job.name }}
test-args: ${{ matrix.job.test-args }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-h2:
needs: determine-driver-skips
@@ -418,7 +408,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-h2-oss:
needs: determine-driver-skips
@@ -439,7 +428,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-mysql-mariadb:
needs: determine-driver-skips
@@ -558,7 +546,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -618,7 +605,6 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.version.name }}-${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -680,7 +666,6 @@ jobs:
test-args: >-
:exclude-tags '[:mongo-sharded-cluster-tests :mb/transforms-python-test]'
:only-tags [:mb/driver-tests]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-mongo-sharded-cluster-ee:
needs: determine-driver-skips
@@ -705,7 +690,6 @@ jobs:
junit-name: 'be-tests-mongo-sharded-cluster-ee'
test-args: >-
:only metabase.driver.mongo.sharded-cluster-test
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-oracle:
needs: determine-driver-skips
@@ -770,7 +754,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-postgres:
needs: determine-driver-skips
@@ -863,7 +846,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -930,7 +912,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-redshift-ee:
needs: determine-driver-skips
@@ -1021,7 +1002,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1084,7 +1064,6 @@ jobs:
junit-name: 'be-tests-snowflake-ee'
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1116,7 +1095,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-sqlite-ee:
needs: determine-driver-skips
@@ -1137,7 +1115,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
be-tests-sqlserver:
needs: determine-driver-skips
@@ -1193,7 +1170,6 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
artifact-suffix: ${{ matrix.version.name }}-${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1290,7 +1266,6 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
drivers-tests-result:
needs:
@@ -1298,9 +1273,9 @@ jobs:
# if you add a driver job, you must add it to this list for it to be a required check
- be-tests-athena-ee
- be-tests-bigquery-cloud-sdk-ee
- be-tests-bigquery-transforms-python-ee
- be-tests-clickhouse-ee
- be-tests-databricks-ee
- be-tests-databricks-multi-catalog-ee
- be-tests-druid-jdbc-ee
- be-tests-h2
- be-tests-h2-oss

View File

@@ -64,6 +64,7 @@ jobs:
# workspace where the gate step runs; an absolute path anchored to the
# workspace makes both agree regardless of cwd.
QUARANTINE_FAILURES_FILE: ${{ github.workspace }}/target/quarantine-failures.jsonl
RERUN_ARTIFACT_BASE: failed-tests-${{ inputs.name }}-${{ inputs.edition }}
# Cypress records video for every spec but the passing specs' videos are
# deleted in after:spec so recording is ~5-10% slowdown per shard and almost
# never yields an artifact. Failure screenshots are unaffected, and the
@@ -119,17 +120,28 @@ jobs:
id: cypress-prep
uses: ./.github/actions/prepare-cypress
- name: Download failed test artifacts
uses: actions/download-artifact@v8
if: github.run_attempt != '1'
- name: Resolve previous attempt
if: ${{ github.run_attempt != '1' }}
run: echo "RERUN_PREV_ATTEMPT=$((GITHUB_RUN_ATTEMPT - 1))" >> "$GITHUB_ENV"
- name: Restore previously-failed specs
if: ${{ github.run_attempt != '1' }}
continue-on-error: true
id: failed-specs
uses: actions/download-artifact@v8
with:
name: failed-tests-${{ inputs.name }}-${{ inputs.edition }}
pattern: ${{ env.RERUN_ARTIFACT_BASE }}-attempt-${{ env.RERUN_PREV_ATTEMPT }}
path: target/rerun
- name: Get failed specs
if: github.run_attempt != '1'
run: echo "specs=$(cat failed-specs)" >> "$GITHUB_ENV"
if: ${{ github.run_attempt != '1' }}
run: |
if [ -s target/rerun/failed-specs ]; then
echo "Re-running only the specs that failed on attempt $RERUN_PREV_ATTEMPT:"
cat target/rerun/failed-specs
echo "specs=$(cat target/rerun/failed-specs)" >> "$GITHUB_ENV"
else
echo "No failed-spec list from attempt $RERUN_PREV_ATTEMPT; running the full suite."
fi
# run-tests.yml compiles this in parallel with the uberjar build. Downloading it is ~10x faster than compiling it here.
# Callers without that job (stress tests, coverage shards, cross-run re-runs) fall through to compiling as before.
@@ -232,7 +244,7 @@ jobs:
if: |
!cancelled() && (steps.split-e2e.outcome == 'failure' || steps.tagged-e2e.outcome == 'failure')
with:
name: cypress-recording-${{ inputs.name }}-${{ inputs.edition }}
name: cypress-recording-${{ inputs.name }}-${{ inputs.edition }}-attempt-${{ github.run_attempt }}
path: |
./cypress
./logs/test.log
@@ -242,8 +254,9 @@ jobs:
uses: actions/upload-artifact@v7
if: |
!cancelled() && (steps.split-e2e.outcome == 'failure' || steps.tagged-e2e.outcome == 'failure')
continue-on-error: true
with:
name: failed-tests-${{ inputs.name }}-${{ inputs.edition }}
name: ${{ env.RERUN_ARTIFACT_BASE }}-attempt-${{ github.run_attempt }}
path: ./cypress/test-results
if-no-files-found: ignore

View File

@@ -26,6 +26,9 @@ jobs:
fail-fast: false
env:
CI_CONDUCTOR_TEST_SUITE: embedding-sdk-component-react-${{ matrix.react-version }}
# Base name of this leg's granular-rerun artifact. Each matrix leg needs its own, or a
# leg would restore the other leg's failed set. `-attempt-N` is appended below.
RERUN_ARTIFACT_BASE: failed-specs-embedding-sdk-component-react-${{ matrix.react-version }}
# Sensitive env vars (tokens, secrets) starting with `CYPRESS_` are accessed via async `cy.env()`
# Example: `cy.env(["FOO"]).then(({ FOO }) => ...)`
# For non-sensitive config, use `Cypress.expose()` in cypress config instead (synchronous)
@@ -73,6 +76,45 @@ jobs:
id: cypress-prep
uses: ./.github/actions/prepare-cypress
- name: Resolve previous attempt
if: ${{ github.run_attempt != '1' }}
run: echo "RERUN_PREV_ATTEMPT=$((GITHUB_RUN_ATTEMPT - 1))" >> "$GITHUB_ENV"
- name: Restore previously-failed specs
if: ${{ github.run_attempt != '1' }}
continue-on-error: true
uses: actions/download-artifact@v8
with:
# use pattern instead of name since this should still pass if the artifact doesn't exist
pattern: ${{ env.RERUN_ARTIFACT_BASE }}-attempt-${{ env.RERUN_PREV_ATTEMPT }}
path: target/rerun
- name: Get failed specs
if: ${{ github.run_attempt != '1' }}
run: |
if [ -s target/rerun/failed-specs ]; then
echo "Re-running failed specs from attempt $RERUN_PREV_ATTEMPT:"
cat target/rerun/failed-specs
echo "specs=$(cat target/rerun/failed-specs)" >> "$GITHUB_ENV"
else
echo "No failed-spec list from attempt $RERUN_PREV_ATTEMPT; running the full suite."
fi
# esbuild resolves every import in the spec bundle's graph, even the ones tree shaking then drops.
# The cljs imports resolve into target/cljs_dev, so the compiled CLJS has to exist before Cypress runs.
# run-tests.yml compiles it in parallel with the uberjar build, so downloading is ~10x faster than compiling here.
- name: Download pre-built CLJS
id: prebuilt-cljs
uses: actions/download-artifact@v8
continue-on-error: true
with:
name: e2e-cljs-${{ github.event.pull_request.head.sha || github.sha }}
path: target/cljs_dev
- name: Compile CLJS
if: steps.prebuilt-cljs.outcome != 'success'
run: bun run build-pure:cljs
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
@@ -92,9 +134,18 @@ jobs:
- name: Run component tests for Embedding SDK
id: run-tests
shell: bash
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: node e2e/runner/run_cypress_ci.js component
SPECS: ${{ env.specs }}
# record video for re-runs of previously failed specs
CYPRESS_VIDEO: ${{ env.specs && 'true' || 'false' }}
run: |
SPEC_ARGS=()
if [ -n "$SPECS" ]; then
SPEC_ARGS=(--spec "$SPECS")
fi
node e2e/runner/run_cypress_ci.js component "${SPEC_ARGS[@]}"
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
@@ -125,12 +176,21 @@ jobs:
uses: actions/upload-artifact@v7
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
with:
name: cypress-recording-embedding-sdk-react-${{ matrix.react-version }}
name: cypress-recording-embedding-sdk-react-${{ matrix.react-version }}-attempt-${{ github.run_attempt }}
path: |
./cypress
./logs/test.log
if-no-files-found: ignore
- name: "SDK component tests > Upload failed specs for rerun"
uses: actions/upload-artifact@v7
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
continue-on-error: true
with:
name: ${{ env.RERUN_ARTIFACT_BASE }}-attempt-${{ github.run_attempt }}
path: ./cypress/test-results
if-no-files-found: ignore
- name: "SDK component tests > Publish Summary"
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
uses: actions/github-script@v9
@@ -180,6 +240,7 @@ jobs:
MB_WAREHOUSE_ALLOWED_NETWORKS: "allow-all"
METASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}
CI_CONDUCTOR_TEST_SUITE: embedding-sdk-component-backward-compatibility
RERUN_ARTIFACT_BASE: failed-specs-embedding-sdk-component-backward-compatibility
# Sensitive env vars (tokens, secrets) starting with `CYPRESS_` are accessed via async `cy.env()`
# Example: `cy.env(["FOO"]).then(({ FOO }) => ...)`
# For non-sensitive config, use `Cypress.expose()` in cypress config instead (synchronous)
@@ -246,6 +307,37 @@ jobs:
id: cypress-prep
uses: ./.github/actions/prepare-cypress
- name: Resolve previous attempt
if: ${{ github.run_attempt != '1' }}
run: echo "RERUN_PREV_ATTEMPT=$((GITHUB_RUN_ATTEMPT - 1))" >> "$GITHUB_ENV"
- name: Restore previously-failed specs
if: ${{ github.run_attempt != '1' }}
continue-on-error: true
uses: actions/download-artifact@v8
with:
# use pattern instead of name since this should still pass if the artifact doesn't exist
pattern: ${{ env.RERUN_ARTIFACT_BASE }}-attempt-${{ env.RERUN_PREV_ATTEMPT }}
path: target/rerun
- name: Get failed specs
if: ${{ github.run_attempt != '1' }}
run: |
if [ -s target/rerun/failed-specs ]; then
echo "Re-running only the specs that failed on attempt $RERUN_PREV_ATTEMPT:"
cat target/rerun/failed-specs
echo "specs=$(cat target/rerun/failed-specs)" >> "$GITHUB_ENV"
else
echo "No failed-spec list from attempt $RERUN_PREV_ATTEMPT; running the full suite."
fi
# esbuild resolves every import in the spec bundle's graph, even the ones tree shaking then drops.
# The cljs imports resolve into target/cljs_dev, so the compiled CLJS has to exist before Cypress runs.
# The checked-out tree is the previous commit, which the current run's CLJS artifact was not built from,
# so compile from source instead of downloading.
- name: Compile CLJS
run: bun run build-pure:cljs
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
@@ -261,11 +353,20 @@ jobs:
- name: Run component tests for Embedding SDK
id: run-tests
shell: bash
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
SPECS: ${{ env.specs }}
# record video for re-runs of previously failed specs
CYPRESS_VIDEO: ${{ env.specs && 'true' || 'false' }}
run: |
SPEC_ARGS=()
if [ -n "$SPECS" ]; then
SPEC_ARGS=(--spec "$SPECS")
fi
node e2e/runner/run_cypress_ci.js component \
--expose grepTags="-@skip-backward-compatibility"
--expose grepTags="-@skip-backward-compatibility" \
"${SPEC_ARGS[@]}"
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
@@ -296,12 +397,21 @@ jobs:
uses: actions/upload-artifact@v7
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
with:
name: cypress-recording-embedding-sdk-cross-version
name: cypress-recording-embedding-sdk-cross-version-attempt-${{ github.run_attempt }}
path: |
./cypress
./logs/test.log
if-no-files-found: ignore
- name: Upload failed specs for rerun
uses: actions/upload-artifact@v7
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
continue-on-error: true
with:
name: ${{ env.RERUN_ARTIFACT_BASE }}-attempt-${{ github.run_attempt }}
path: ./cypress/test-results
if-no-files-found: ignore
- name: Publish Summary
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
uses: actions/github-script@v9

View File

@@ -233,11 +233,6 @@ jobs:
sample-app-branch-name: ${{ needs.get-sample-apps-data.outputs.branch_name }}
sample-app-environment: ${{ matrix.environment }}
staging-mb-all-features-token: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}
shoppy-iam-role: ${{ secrets.SHOPPY_IAM_ROLE }}
shoppy-metabase-app-db-s3-bucket: ${{ secrets.SHOPPY_METABASE_APP_DB_S3_BUCKET }}
shoppy-metabase-app-db-s3-key: ${{ secrets.SHOPPY_METABASE_APP_DB_S3_KEY }}
shoppy-metabase-app-db-user: ${{ secrets.SHOPPY_METABASE_APP_DB_USER }}
shoppy-metabase-app-db-database: ${{ secrets.SHOPPY_METABASE_APP_DB_DATABASE }}
metastore-dev-server-url: ${{ secrets.METASTORE_DEV_SERVER_URL }}
shoppy-datadog-application-id: ${{ secrets.SHOPPY_METABASE_APP_DATADOG_APPLICATION_ID }}
shoppy-datadog-client-token: ${{ secrets.SHOPPY_METABASE_APP_DATADOG_CLIENT_TOKEN }}
@@ -301,11 +296,6 @@ jobs:
sample-app-branch-name: ${{ needs.get-sample-apps-data.outputs.branch_name }}
sample-app-environment: production
staging-mb-all-features-token: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}
shoppy-iam-role: ${{ secrets.SHOPPY_IAM_ROLE }}
shoppy-metabase-app-db-s3-bucket: ${{ secrets.SHOPPY_METABASE_APP_DB_S3_BUCKET }}
shoppy-metabase-app-db-s3-key: ${{ secrets.SHOPPY_METABASE_APP_DB_S3_KEY }}
shoppy-metabase-app-db-user: ${{ secrets.SHOPPY_METABASE_APP_DB_USER }}
shoppy-metabase-app-db-database: ${{ secrets.SHOPPY_METABASE_APP_DB_DATABASE }}
metastore-dev-server-url: ${{ secrets.METASTORE_DEV_SERVER_URL }}
shoppy-datadog-application-id: ${{ secrets.SHOPPY_METABASE_APP_DATADOG_APPLICATION_ID }}
shoppy-datadog-client-token: ${{ secrets.SHOPPY_METABASE_APP_DATADOG_CLIENT_TOKEN }}
@@ -419,15 +409,53 @@ jobs:
id: cypress-prep
uses: ./.github/actions/prepare-cypress
# esbuild resolves every import in the spec bundle's graph, even the ones tree shaking then drops.
# The cljs imports resolve into target/cljs_dev, so the compiled CLJS has to exist before Cypress runs.
# run-tests.yml compiles it in parallel with the uberjar build, so downloading is ~10x faster than compiling here.
- name: Download pre-built CLJS
id: prebuilt-cljs
uses: actions/download-artifact@v8
continue-on-error: true
with:
name: e2e-cljs-${{ github.event.pull_request.head.sha || github.sha }}
path: target/cljs_dev
- name: Compile CLJS
if: steps.prebuilt-cljs.outcome != 'success'
run: bun run build-pure:cljs
# The data-app suite synchronizes real actions, and Metabase only permits
# those against a writable warehouse, which comes from the `qa-db`
# snapshot below. That snapshot creator builds every QA database in one
# pass — Mongo and MySQL included — so all three have to be up even though
# only `postgres-writable` is restored. The other host apps read the sample
# database, so they skip the pull entirely.
- name: Prepare Docker containers
if: ${{ matrix.test_suite == 'vite-6-data-app-host-app-e2e' }}
uses: ./.github/actions/e2e-prepare-containers
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
postgres: true
mysql: true
mongo: true
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
- uses: ./.github/actions/resolve-job-id
# Without `--spec` the snapshot config picks up `qa-db.cy.snap.js` too,
# which is what creates the `postgres-writable` snapshot the data-app
# action tests restore.
- name: Generate database snapshots
run: |
node e2e/runner/run_cypress_ci.js snapshot \
--spec "e2e/snapshot-creators/default.cy.snap.js"
if [ "${{ matrix.test_suite }}" = "vite-6-data-app-host-app-e2e" ]; then
node e2e/runner/run_cypress_ci.js snapshot
else
node e2e/runner/run_cypress_ci.js snapshot \
--spec "e2e/snapshot-creators/default.cy.snap.js"
fi
- name: Prepare and launch Host App
run: npx tsx ./e2e/runner/embedding-sdk/host-apps/start-ci.ts ${{ matrix.test_suite }}

View File

@@ -24,6 +24,8 @@ jobs:
# unrelated to embedding (EMB-765)
echo "::remove-matcher owner=tsc::"
bun run build-embedding-sdk-package
- name: Smoke test the packed SDK CLI
run: node bin/embedding-sdk/test-sdk-package.mjs
- name: Prepare Embedding SDK artifact
uses: actions/upload-artifact@v7
with:

View File

@@ -1,29 +1,68 @@
name: CI for PR Review ENV Destroy
run-name: Destroying Dynamic PR Environment for ${{ github.ref_name }} by @${{ github.actor }}
name: Cleanup PR Environment
run-name: Destroying Dynamic PR Environment for PR ${{ inputs.pr_number || github.event.number }} by @${{ github.actor }}
on:
workflow_call:
pull_request:
types: [ closed, unlabeled ]
workflow_dispatch:
inputs:
pr_number:
description: 'PR number to destroy environment for'
required: true
type: string
self_hosting:
description: 'Self-hosting stack'
required: false
type: boolean
default: false
pr_number:
description: 'PR number (required for manual dispatch)'
required: false
type: string
env:
PR_NUMBER: ${{ inputs.pr_number || github.event.number }}
concurrency:
group: ${{ github.workflow }}-${{ inputs.pr_number || github.event.number }}
cancel-in-progress: false
jobs:
destroy_pr:
# Manual runs go through the pr-env-admin environment for approval.
# Skipped for pull_request events, which are already scoped to the PR's own labels.
approve:
if: ${{ github.event_name == 'workflow_dispatch' }}
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
environment: pr-env-admin
steps:
- name: Approved
env:
PR_NUMBER: ${{ inputs.pr_number }}
run: |
echo "Destroying PR environment for PR #${PR_NUMBER}"
cleanup:
needs: [ approve ]
# Runs when dispatched manually (after approval), when a PR carrying a PR-Env
# label is closed, or when one of those labels is removed.
if: >-
${{ !cancelled()
&& (needs.approve.result == 'success' || needs.approve.result == 'skipped')
&& (github.event_name == 'workflow_dispatch'
|| (github.event.action == 'closed'
&& (contains(github.event.pull_request.labels.*.name, 'PR-Env')
|| contains(github.event.pull_request.labels.*.name, 'PR-Env-self-hosting')
|| contains(github.event.pull_request.labels.*.name, 'PR-Env-analytics-dev')
|| contains(github.event.pull_request.labels.*.name, 'PR-Env-Stats-Dump')))
|| (github.event.action == 'unlabeled'
&& (github.event.label.name == 'PR-Env'
|| github.event.label.name == 'PR-Env-self-hosting'
|| github.event.label.name == 'PR-Env-analytics-dev'
|| github.event.label.name == 'PR-Env-Stats-Dump'))) }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: PR Review ENV Destroy
timeout-minutes: 10
permissions:
id-token: write
contents: read
env:
PR_NUMBER: ${{ inputs.pr_number || github.event.number }}
SELF_HOSTING: >-
${{ (github.event_name == 'workflow_dispatch' && inputs.self_hosting)
|| (github.event.action == 'unlabeled' && github.event.label.name == 'PR-Env-self-hosting')
|| (github.event.action == 'closed' && contains(github.event.pull_request.labels.*.name, 'PR-Env-self-hosting')) }}
steps:
- name: Checkout source code
uses: actions/checkout@v6
@@ -69,17 +108,17 @@ jobs:
namespace: default
user: oidc-token
- name: Destroy PR Review ENV
if: ${{ !inputs.self_hosting }}
if: ${{ env.SELF_HOSTING != 'true' }}
run: |
kubectl delete metabase -n hosting-pr${{ env.PR_NUMBER }} hosting-pr${{ env.PR_NUMBER }}
kubectl delete ns hosting-pr${{ env.PR_NUMBER }}
- name: Setup Helm
if: ${{ inputs.self_hosting }}
if: ${{ env.SELF_HOSTING == 'true' }}
uses: azure/setup-helm@dda3372f752e03dde6b3237bc9431cdc2f7a02a2 # v5.0.0
with:
version: 'latest'
- name: Destroy PR Review ENV (self-hosting)
if: ${{ inputs.self_hosting }}
if: ${{ env.SELF_HOSTING == 'true' }}
run: |
helm uninstall hosting-pr${{ env.PR_NUMBER }} --namespace hosting-pr${{ env.PR_NUMBER }} || true
kubectl delete ns hosting-pr${{ env.PR_NUMBER }} || true

View File

@@ -1,87 +0,0 @@
name: Kondo Ratchets Self-Heal
# Stale budgets in .clj-kondo/ratchets.edn (above the actual ignore counts) fail CI. On PRs
# labelled kondo-ratchets-self-healing, this commits the lowered budgets to the branch;
# unlabelled PRs rely on local test runs to tighten the file.
#
# Two jobs so the automation token never shares an environment with PR-controlled code: the
# ratchet-down job runs ./bin/mage from the PR branch and only exports the fixed file as an
# artifact; the push job starts from a clean runner, executes nothing from the PR, and pushes.
permissions:
contents: read
on:
pull_request:
types: [opened, synchronize, reopened, labeled, unlabeled]
paths:
- "**.clj"
- "**.cljc"
- "**.cljs"
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
ratchet-down:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
# fork PRs don't get the automation token, so we couldn't push to them anyway
if: >-
contains(github.event.pull_request.labels.*.name, 'kondo-ratchets-self-healing')
&& github.event.pull_request.head.repo.full_name == github.repository
outputs:
changed: ${{ steps.diff.outputs.changed }}
steps:
- uses: actions/checkout@v6
with:
ref: ${{ github.event.pull_request.head.ref }}
persist-credentials: false
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- name: Lower ignore budgets to match the source tree
run: ./bin/mage fix-kondo-ratchets
- name: Check for changes
id: diff
run: |
if git diff --quiet .clj-kondo/ratchets.edn; then
echo "budgets already tight"
echo "changed=false" >> "$GITHUB_OUTPUT"
else
echo "changed=true" >> "$GITHUB_OUTPUT"
fi
- uses: actions/upload-artifact@v7
if: steps.diff.outputs.changed == 'true'
with:
name: ratchets-edn
path: .clj-kondo/ratchets.edn
# dot-directories are excluded by default, which would ship an empty artifact
include-hidden-files: true
push:
needs: ratchet-down
if: needs.ratchet-down.outputs.changed == 'true'
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: actions/checkout@v6
with:
ref: ${{ github.event.pull_request.head.ref }}
persist-credentials: false
- uses: actions/download-artifact@v8
with:
name: ratchets-edn
path: .clj-kondo/
- name: Commit to the PR branch
env:
PR_BRANCH: ${{ github.event.pull_request.head.ref }}
REPO: ${{ github.repository }}
# METABASE_AUTOMATION_USER_TOKEN so the self-healing commit triggers CI
# (a GITHUB_TOKEN push would not)
AUTOMATION_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
run: |
git config --global user.name "Metabase Automation"
git config --global user.email "github-automation@metabase.com"
git add .clj-kondo/ratchets.edn
git commit -m "Ratchet down kondo ignore budgets" --no-verify
git push "https://x-access-token:${AUTOMATION_TOKEN}@github.com/${REPO}.git" "HEAD:$PR_BRANCH"

View File

@@ -0,0 +1,170 @@
name: Shrink ratchets
# Lowers the ratchet budgets to match master and delivers the result through one
# automation PR, because the rulesets require a pull request for every change to master. The PR is
# approved by github-actions[bot] and merges itself once the ratchet check passes. A merge of that PR
# touches only ratchet files, which match `.clj-kondo/**` below, so it triggers one more run that finds
# nothing to lower and stops: a single no-op, not a loop.
on:
push:
branches: [master]
paths:
- "**.clj"
- "**.cljc"
- "**.cljs"
- ".clj-kondo/**"
- "bb.edn"
workflow_dispatch:
permissions:
# checkout and the fetch of the automation branch
contents: read
# the compare step reads whether the automation PR is still open, and the approve step reviews it as
# github-actions[bot]; pushes and the PR itself use the automation user's token
pull-requests: write
# When master is pushed again, the newest run cancels the older one, checks out the latest master it can
# see, and force-updates the automation branch. The PR therefore contains one commit on top of master.
concurrency:
group: kondo-ratchets-shrink
cancel-in-progress: true
env:
AUTOMATION_BRANCH: automation/shrink-ratchets
KONDO_RATCHETS_FILE: .clj-kondo/ratchets.edn
MODULE_RATCHETS_FILE: .clj-kondo/config/modules/ratchets.edn
jobs:
shrink:
name: Shrink ratchets
# A fork with Actions enabled has no automation token, so this would only ever fail at the push.
if: github.repository == 'metabase/metabase'
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
# `ref: master` checks out the branch head at checkout time rather than the pushed commit, so a run
# that queued behind another one starts from the newest master it can see.
- uses: actions/checkout@v6
with:
ref: master
# The persisted GITHUB_TOKEN header would override the automation token in the push URL and
# get the force-push rejected. Nothing here needs it: the repo is public, so the fetch of the
# automation branch is anonymous, and every gh call carries its own token.
persist-credentials: false
- name: Set up Java for cold dependency resolution
uses: actions/setup-java@v5.2.0
with:
distribution: temurin
java-version: 25
- name: Shrink ratchets
run: |
cp "$KONDO_RATCHETS_FILE" "$RUNNER_TEMP/kondo-ratchets-before.edn"
cp "$MODULE_RATCHETS_FILE" "$RUNNER_TEMP/module-ratchets-before.edn"
./bin/mage kondo-ratchets-shrink
# Two independent outputs: `push` says the branch needs a new commit, `pr` names the open automation
# PR if there is one. Approval and auto-merge key on `pr` alone, so a run that failed after opening
# the PR is repaired by the next run instead of leaving the PR stranded.
- name: Compare with master and the automation PR
id: compare
env:
GH_TOKEN: ${{ github.token }}
run: |
# The REST `head=owner:branch` filter is applied server-side and only matches this repository's
# branch, so a fork carrying a branch of the same name can never hand its PR number to the
# approval and auto-merge steps, however many such forks exist. Only an open PR counts; a branch
# left behind by a PR closed without merging is overwritten below and gets a new PR, so a closed
# one never stops the budgets from being lowered.
open_pr=$(gh api "repos/${GITHUB_REPOSITORY}/pulls?state=open&base=master&head=${GITHUB_REPOSITORY_OWNER}:${AUTOMATION_BRANCH}" \
--jq '.[0].number // empty')
echo "pr=$open_pr" >> "$GITHUB_OUTPUT"
if git diff --quiet -- "$KONDO_RATCHETS_FILE" "$MODULE_RATCHETS_FILE"; then
echo "Ratchet budgets already match master $(git rev-parse --short HEAD)"
[ -z "$open_pr" ] || echo "The open automation PR #$open_pr is re-approved below"
echo "push=false" >> "$GITHUB_OUTPUT"
exit 0
fi
# The ratchet files are the whole payload, so an open PR that already carries this result is left
# alone. Rebasing it onto every master push would restart its CI and churn the diff without
# changing what it delivers. Compare the open PR with the working tree, which contains the
# shrunk ratchet files produced above, to determine whether the PR would deliver the same result.
#
# A conflicted PR is the exception: only a fresh commit clears it. Mergeability is computed
# lazily, so a pending UNKNOWN reads as not conflicted and the next run settles it.
if [ -n "$open_pr" ] \
&& git fetch --quiet --depth=1 origin "refs/heads/$AUTOMATION_BRANCH" 2>/dev/null \
&& git diff --quiet FETCH_HEAD -- "$KONDO_RATCHETS_FILE" "$MODULE_RATCHETS_FILE" \
&& [ "$(gh pr view "$open_pr" --repo "$GITHUB_REPOSITORY" \
--json mergeable --jq .mergeable)" != CONFLICTING ]; then
echo "The automation PR #$open_pr already carries this result"
echo "push=false" >> "$GITHUB_OUTPUT"
echo "head=$(git rev-parse FETCH_HEAD)" >> "$GITHUB_OUTPUT"
exit 0
fi
git diff --stat -- "$KONDO_RATCHETS_FILE" "$MODULE_RATCHETS_FILE"
echo "push=true" >> "$GITHUB_OUTPUT"
- name: Update the automation PR
id: deliver
if: steps.compare.outputs.push == 'true'
# The automation user's token pushes the branch and owns the PR: a branch pushed with
# GITHUB_TOKEN starts no pull_request workflows, so the PR would never get its checks. The commit
# identity is the docs generator's, which merges with one approval under the unattributed-changes
# rule. Nothing raises a budget.
env:
GH_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
OPEN_PR: ${{ steps.compare.outputs.pr }}
run: |
./bin/mage -kondo-ratchets-pr-body \
"$RUNNER_TEMP/kondo-ratchets-before.edn" \
"$KONDO_RATCHETS_FILE" \
"$RUNNER_TEMP/module-ratchets-before.edn" \
"$MODULE_RATCHETS_FILE" \
"${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}" \
> "$RUNNER_TEMP/ratchets-pr-body.md"
git config user.name github-actions
git config user.email github-actions@github.com
git add -- "$KONDO_RATCHETS_FILE" "$MODULE_RATCHETS_FILE"
git commit --quiet -m "Tighten ratchets"
git push --force --quiet \
"https://x-access-token:${GH_TOKEN}@github.com/${GITHUB_REPOSITORY}.git" \
"HEAD:refs/heads/$AUTOMATION_BRANCH"
echo "head=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT"
if [ -n "$OPEN_PR" ]; then
gh pr edit "$OPEN_PR" --body-file "$RUNNER_TEMP/ratchets-pr-body.md"
echo "Updated the automation PR #$OPEN_PR"
echo "pr=$OPEN_PR" >> "$GITHUB_OUTPUT"
exit 0
fi
url=$(gh pr create \
--base master \
--head "$AUTOMATION_BRANCH" \
--title "Tighten ratchets" \
--label "no-backport" \
--body-file "$RUNNER_TEMP/ratchets-pr-body.md")
echo "Opened the automation PR $url"
echo "pr=${url##*/}" >> "$GITHUB_OUTPUT"
- name: Approve the automation PR
if: (steps.deliver.outputs.pr || steps.compare.outputs.pr) != ''
# GITHUB_TOKEN reviews as github-actions[bot], a different identity from the automation user that
# owns the PR, so the approval counts; a user cannot approve their own PR. Reviews survive a push,
# so approving an already-open PR again is harmless and keeps a reopened one covered.
env:
GH_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ steps.deliver.outputs.pr || steps.compare.outputs.pr }}
run: gh pr review --approve "$PR_NUMBER"
# Armed only against the commit this run pushed or compared: the branch name is fixed, and anyone
# with push access could otherwise collect this run's approval for their own commit.
- name: Enable auto-merge
if: (steps.deliver.outputs.pr || steps.compare.outputs.pr) != ''
&& (steps.deliver.outputs.head || steps.compare.outputs.head) != ''
env:
GH_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
PR_NUMBER: ${{ steps.deliver.outputs.pr || steps.compare.outputs.pr }}
HEAD_SHA: ${{ steps.deliver.outputs.head || steps.compare.outputs.head }}
run: gh pr merge --squash --auto --match-head-commit "$HEAD_SHA" "$PR_NUMBER"

View File

@@ -1,25 +0,0 @@
name: Add Issue References to PR
on:
pull_request:
types: [opened, edited, synchronize]
jobs:
add-issue-references:
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Checkout code
uses: actions/checkout@v6
- name: Run the link script
uses: actions/github-script@v9
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LINEAR_API_KEY: ${{ secrets.LINEAR_API_KEY }}
PR_NUMBER: ${{ github.event.pull_request.number }}
REPO_OWNER: ${{ github.repository_owner }}
REPO_NAME: ${{ github.event.repository.name }}
with:
script: |
const { link_issues } = require('${{ github.workspace }}/.github/scripts/update-pr-with-issues.js');
await link_issues(github)

View File

@@ -36,6 +36,7 @@ jobs:
uses: github/codeql-action/analyze@v4
trivy:
timeout-minutes: 15
strategy:
fail-fast: false
matrix:
@@ -68,8 +69,157 @@ jobs:
sarif_file: trivy-results-${{ matrix.edition }}.sarif
category: trivy-${{ matrix.edition }}
# Generate pom.xml files for all Maven projects
snyk-generate-poms:
name: Generate pom.xml files
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
steps:
- uses: actions/checkout@v6
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- name: Generate all pom.xml
run: .github/scripts/write-poms.sh
- name: Upload pom files
uses: actions/upload-artifact@v7
with:
name: pom-files
path: |
pom.xml
modules/drivers/*/pom.xml
# Yarn/NPM projects that don't need pom files
snyk-frontend-projects:
name: ${{ matrix.project.name }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
strategy:
matrix:
project:
- name: Main Frontend (bun w/ yarn.lock)
file: yarn.lock
package-manager: yarn
category: main-frontend-bun
- name: Release Helper
file: release/yarn.lock
package-manager: yarn
category: release-helper
steps:
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
# Snyk doesn't support bun.lock yet, so we generate yarn.lock and scan that.
# Bun has a bug where it normalizes "< 3.0.0" to "< 3" in alias entries
# but not in dependency specs, causing Snyk to fail matching dependencies.
# The sed commands fix this inconsistency. Bun also names aliased entries
# after the aliased package instead of the alias, which the script fixes.
# Both continue on error to let Snyk report parsing issues directly rather
# than failing on the workaround.
- name: Generate yarn.lock
if: matrix.project.file == 'yarn.lock'
run: |
bun install --yarn
sed -i -E 's/< ([0-9]+)\.0\.0"/< \1"/g; s/< ([0-9]+)\.0"/< \1"/g' yarn.lock || true
bun ${{ github.workspace }}/.github/scripts/fix-yarn-lock-aliases.ts || true
- name: Generate release/yarn.lock
if: matrix.project.file == 'release/yarn.lock'
run: |
bun install --yarn
sed -i -E 's/< ([0-9]+)\.0\.0"/< \1"/g; s/< ([0-9]+)\.0"/< \1"/g' yarn.lock || true
bun ${{ github.workspace }}/.github/scripts/fix-yarn-lock-aliases.ts || true
working-directory: release
- uses: snyk/actions/setup@9adf32b1121593767fc3c057af55b55db032dc04 # v1.0.0
- name: Run snyk test
env:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
continue-on-error: true
run: snyk test --org="metabase-AnD9iS4Wfu4eBYMsG2DZ5N" --remote-repo-url="https://github.com/metabase/metabase" --file=${{ matrix.project.file }} --package-manager=${{ matrix.project.package-manager }} --sarif-file-output=snyk-${{ matrix.project.category }}.sarif
- name: Upload results
uses: github/codeql-action/upload-sarif@v4
with:
sarif_file: snyk-${{ matrix.project.category }}.sarif
category: ${{ matrix.project.category }}
# Maven projects that need pom files
snyk-maven-projects:
needs: snyk-generate-poms
name: ${{ matrix.project.name }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
strategy:
matrix:
project:
- name: Main Backend (maven)
file: pom.xml
category: main-backend-maven
- name: Driver - Athena
file: modules/drivers/athena/pom.xml
category: driver-athena
- name: Driver - BigQuery Cloud SDK
file: modules/drivers/bigquery-cloud-sdk/pom.xml
category: driver-bigquery-cloud-sdk
- name: Driver - ClickHouse
file: modules/drivers/clickhouse/pom.xml
category: driver-clickhouse
- name: Driver - Databricks
file: modules/drivers/databricks/pom.xml
category: driver-databricks
- name: Driver - Druid JDBC
file: modules/drivers/druid-jdbc/pom.xml
category: driver-druid-jdbc
- name: Driver - Hive-like
file: modules/drivers/hive-like/pom.xml
category: driver-hive-like
- name: Driver - MongoDB
file: modules/drivers/mongo/pom.xml
category: driver-mongo
- name: Driver - Oracle
file: modules/drivers/oracle/pom.xml
category: driver-oracle
- name: Driver - Presto JDBC
file: modules/drivers/presto-jdbc/pom.xml
category: driver-presto-jdbc
- name: Driver - Redshift
file: modules/drivers/redshift/pom.xml
category: driver-redshift
- name: Driver - Snowflake
file: modules/drivers/snowflake/pom.xml
category: driver-snowflake
- name: Driver - SparkSQL
file: modules/drivers/sparksql/pom.xml
category: driver-sparksql
- name: Driver - SQL Server
file: modules/drivers/sqlserver/pom.xml
category: driver-sqlserver
- name: Driver - Starburst
file: modules/drivers/starburst/pom.xml
category: driver-starburst
- name: Driver - Vertica
file: modules/drivers/vertica/pom.xml
category: driver-vertica
steps:
- uses: actions/checkout@v6
- uses: snyk/actions/setup@9adf32b1121593767fc3c057af55b55db032dc04 # v1.0.0
- name: Download pom files
uses: actions/download-artifact@v8
with:
name: pom-files
- name: Run snyk test
env:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
continue-on-error: true
run: snyk test --org="metabase-AnD9iS4Wfu4eBYMsG2DZ5N" --remote-repo-url="https://github.com/metabase/metabase" --file=${{ matrix.project.file }} --package-manager=maven --sarif-file-output=snyk-${{ matrix.project.category }}.sarif
- name: Upload results
uses: github/codeql-action/upload-sarif@v4
with:
sarif_file: snyk-${{ matrix.project.category }}.sarif
category: ${{ matrix.project.category }}
notify:
needs: [codeql, trivy]
needs: [codeql, trivy, snyk-frontend-projects, snyk-maven-projects]
if: ${{ failure() && github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
@@ -94,6 +244,8 @@ jobs:
const scans = [
['CodeQL', '${{ needs.codeql.result }}'],
['Trivy', '${{ needs.trivy.result }}'],
['Snyk (frontend)', '${{ needs.snyk-frontend-projects.result }}'],
['Snyk (maven)', '${{ needs.snyk-maven-projects.result }}'],
];
const failed = scans.filter(([, result]) => result === 'failure').map(([name]) => name);

View File

@@ -16,12 +16,12 @@ jobs:
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 10
outputs:
actionlint: ${{ steps.changes.outputs.actionlint }}
actionlint_files: ${{ steps.changes.outputs.actionlint_files }}
codeql: ${{ steps.changes.outputs.codeql }}
i18n: ${{ steps.changes.outputs.i18n }}
openapi: ${{ steps.changes.outputs.openapi }}
snowplow: ${{ steps.changes.outputs.snowplow }}
workflows: ${{ steps.changes.outputs.workflows }}
workflows_files: ${{ steps.changes.outputs.workflows_files }}
yaml: ${{ steps.changes.outputs.yaml }}
steps:
- uses: actions/checkout@v6
@@ -52,7 +52,7 @@ jobs:
uses: ./.github/actions/prepare-backend
- name: Setup actionlint
if: needs.files-changed.outputs.actionlint == 'true'
if: needs.files-changed.outputs.workflows == 'true'
id: download
shell: bash
run: |
@@ -81,8 +81,12 @@ jobs:
# Lint Github Actions
- name: Run actionlint
if: needs.files-changed.outputs.actionlint == 'true'
run: ${{ steps.download.outputs.executable }} --color --verbose ${{ needs.files-changed.outputs.actionlint_files }}
if: needs.files-changed.outputs.workflows == 'true'
run: ${{ steps.download.outputs.executable }} --color --verbose ${{ needs.files-changed.outputs.workflows_files }}
- name: Check every workflow job sets a timeout
if: needs.files-changed.outputs.workflows == 'true'
run: .github/scripts/check-job-timeouts.sh ${{ needs.files-changed.outputs.workflows_files }}
# Generate and Lint OpenAPI spec
- name: Generate OpenAPI spec
@@ -123,6 +127,7 @@ jobs:
needs: files-changed
if: needs.files-changed.outputs.snowplow == 'true'
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- name: Checkout
uses: actions/checkout@v6

View File

@@ -16,3 +16,7 @@ jobs:
run: ./bin/mage -h
- name: Run mage tests
run: ./bin/mage -test
- name: Lint create-backport scripts
run: shellcheck .github/actions/create-backport/{kondo-ratchets,create-backport-test}.sh
- name: Run create-backport tests
run: ./.github/actions/create-backport/create-backport-test.sh

View File

@@ -1,38 +0,0 @@
name: PR Closed or Unlabeled
on:
pull_request:
types: [ closed, unlabeled ]
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: false
jobs:
pr-env:
if: ${{ (github.event.action == 'closed' && contains(github.event.pull_request.labels.*.name, 'PR-Env') && !contains(github.event.pull_request.labels.*.name, 'PR-Env-self-hosting') && !contains(github.event.pull_request.labels.*.name, 'PR-Env-analytics-dev') && !contains(github.event.pull_request.labels.*.name, 'PR-Env-Stats-Dump')) || github.event.label.name == 'PR-Env' }}
uses: ./.github/workflows/pr-env-destroy.yml
secrets: inherit
with:
self_hosting: false
pr-env-self-hosting:
if: ${{ (github.event.action == 'closed' && contains(github.event.pull_request.labels.*.name, 'PR-Env-self-hosting')) || github.event.label.name == 'PR-Env-self-hosting' }}
uses: ./.github/workflows/pr-env-destroy.yml
secrets: inherit
with:
self_hosting: true
pr-env-analytics-dev:
if: ${{ (github.event.action == 'closed' && contains(github.event.pull_request.labels.*.name, 'PR-Env-analytics-dev')) || github.event.label.name == 'PR-Env-analytics-dev' }}
uses: ./.github/workflows/pr-env-destroy.yml
secrets: inherit
with:
self_hosting: false
pr-env-stats-dump:
if: ${{ (github.event.action == 'closed' && contains(github.event.pull_request.labels.*.name, 'PR-Env-Stats-Dump')) || github.event.label.name == 'PR-Env-Stats-Dump' }}
uses: ./.github/workflows/pr-env-destroy.yml
secrets: inherit
with:
self_hosting: false

View File

@@ -1,33 +0,0 @@
name: PR Env Destroy (Manual)
on:
workflow_dispatch:
inputs:
pr_number:
description: 'PR number to destroy environment for'
required: true
type: string
self_hosting:
description: 'Self-hosting stack'
type: boolean
default: false
jobs:
approve:
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
environment: pr-env-admin
steps:
- name: Approved
env:
PR_NUMBER: ${{ inputs.pr_number }}
run: |
echo "Destroying PR environment for PR #${PR_NUMBER}"
destroy:
needs: approve
uses: ./.github/workflows/pr-env-destroy.yml
secrets: inherit
with:
self_hosting: ${{ inputs.self_hosting }}
pr_number: ${{ inputs.pr_number }}

52
.github/workflows/pr.checks.yml vendored Normal file
View File

@@ -0,0 +1,52 @@
# Helpful (and quick) checks that run on PRs.
name: PR Checks
on: pull_request
jobs:
checks:
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 10
permissions:
pull-requests: write
issues: read
steps:
- uses: actions/checkout@v6
with:
sparse-checkout: |
/.github/scripts/update-pr-with-issues.js
/backport.sh
sparse-checkout-cone-mode: false
# download repo structure without file contents, fetched on demand since we only need a few files
# NOTE: this gets slow if we start accessing more files, remove this filter in that case.
filter: blob:none
- parallel:
- name: Block master branch PRs (from forks)
if: github.head_ref == 'master'
run: |
echo "PRs from \`master\` branches are not allowed, please use a new branch name for your PR."
exit 1
- name: Link PR and issues
uses: actions/github-script@v9
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LINEAR_API_KEY: ${{ secrets.LINEAR_API_KEY }}
PR_NUMBER: ${{ github.event.pull_request.number }}
REPO_OWNER: ${{ github.repository_owner }}
REPO_NAME: ${{ github.event.repository.name }}
with:
script: |
const { link_issues } = require('${{ github.workspace }}/.github/scripts/update-pr-with-issues.js');
await link_issues(github)
- name: Prevent backport.sh from being merged
run: |
if [ -f "./backport.sh" ]; then
echo "backport.sh file exists. Please remove it before merging."
exit 1
else
echo "All good."
fi

View File

@@ -1,45 +0,0 @@
name: Pull Request Reminders
on:
pull_request:
types: [opened]
branches:
- "master"
jobs:
external-reminder:
name: External PR Helper
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
permissions:
pull-requests: write
issues: read
steps:
- uses: actions/github-script@v9
with:
script: | # js
const owner = context.repo.owner;
const repo = context.repo.repo;
const pullNumber = '${{ github.event.pull_request.number }}';
const author = '${{ github.event.pull_request.user.login }}';
await github.rest.issues.addLabels({
owner,
repo,
issue_number: pullNumber,
labels: ["External"],
});
const guideLink = "https://www.notion.so/metabase/Third-Party-PRs-External-contributions-5954061854424c1ea6391d98746646e0";
const message = `@${author} Thanks for your contribution! ❤️ We'll try to review it as soon as we can.\n\n
Reviewers, make sure to check out our [External PR Review Guide](${guideLink}) when reviewing.
`;
await github.rest.issues.createComment({
owner,
repo,
issue_number: pullNumber,
body: message,
});

View File

@@ -382,6 +382,9 @@ jobs:
- name: Generate SDK package.json in the build directory
run: bun run embedding-sdk:generate-package
- name: Smoke test the packed SDK CLI
run: node bin/embedding-sdk/test-sdk-package.mjs
- name: Upload built SDK package as artifact
uses: actions/upload-artifact@v7
with:

View File

@@ -45,40 +45,36 @@ jobs:
- name: Install tsx
run: npm i -g tsx
- name: Get version number
id: get-version
uses: actions/github-script@v9
env:
VERSION_INPUT: ${{ inputs.version }}
with:
script: | # js
const {
getMajorVersionFromRef,
getMajorVersion,
} = require('${{ github.workspace }}/release/dist/index.cjs');
const { getMajorVersionFromRef } = require('${{ github.workspace }}/release/dist/index.cjs');
console.log({ context });
// if the version is explicitly set, use that
if (context.payload?.inputs?.version) {
core.exportVariable('VERSION', context.payload.inputs.version);
return;
}
const version = process.env.VERSION_INPUT || getMajorVersionFromRef(context.payload.ref);
// otherwise, get the version from the release branch name
const ref = context.payload.ref;
const majorVersion = getMajorVersionFromRef(ref);
console.log({ ref, majorVersion });
core.exportVariable('VERSION', majorVersion);
console.log({ version });
core.exportVariable('VERSION', version);
core.setOutput('version', version);
- name: generate release Log
if: ${{ steps.get-version.outputs.version != '' }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: cd release && tsx ./src/release-log-run.ts "$VERSION" > "v$VERSION.html"
- name: upload release log to the web
if: ${{ steps.get-version.outputs.version != '' }}
run: |
aws s3 cp \
"release/v$VERSION.html" \
"s3://${{ vars.AWS_S3_STATIC_BUCKET }}/release-log/v$VERSION.html"
- name: Create cloudfront invalidation
if: ${{ steps.get-version.outputs.version != '' }}
run: |
aws cloudfront create-invalidation \
--distribution-id ${{ vars.AWS_CLOUDFRONT_STATIC_ID }} \

View File

@@ -0,0 +1,128 @@
name: Update E2E Timings
permissions:
contents: write
pull-requests: write
on:
workflow_dispatch:
inputs:
days_back:
description: "Number of days to look back for timing artifacts"
type: number
default: 7
required: false
schedule:
# Run weekly on Sundays at 6 AM UTC
- cron: "0 6 * * 0"
jobs:
collect-and-average-timings:
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
env:
DAYS_BACK: ${{ inputs.days_back || 7 }}
steps:
- name: Generate GitHub App Token
uses: actions/create-github-app-token@v1
id: app-token
with:
app-id: ${{ secrets.METABASE_BOT_APP_ID }}
private-key: ${{ secrets.METABASE_BOT_APP_PRIVATE_KEY }}
- uses: actions/checkout@v6
with:
token: ${{ steps.app-token.outputs.token }}
- name: Setup Node.js
uses: actions/setup-node@v6.4.0
with:
node-version: 22
- name: Collect and average timing data
id: collect-timings
uses: actions/github-script@v9
with:
script: |
const { collectAndAverageTimings } = require('${{ github.workspace }}/.github/scripts/average-e2e-timings.js');
const result = await collectAndAverageTimings({
github,
context,
token: '${{ steps.app-token.outputs.token }}',
daysBack: ${{ env.DAYS_BACK }},
existingTimingsPath: 'e2e/support/timings.json'
});
core.setOutput('artifact-count', result.artifactCount);
- name: Configure git and commit changes
id: commit
run: |
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
git add e2e/support/timings.json
# Check if anything changed before commit/push
if git diff --cached --quiet; then
echo "changed=false" >> "$GITHUB_OUTPUT"
echo "Timing data is unchanged; skipping the pull request"
exit 0
fi
DATE=$(date +%Y%m%d-%H%M%S)
BRANCH_NAME="update-e2e-timings-$DATE"
echo "BRANCH_NAME=$BRANCH_NAME" >> "$GITHUB_ENV"
echo "Branch name will be: $BRANCH_NAME"
git checkout -b "$BRANCH_NAME"
git commit -m "update e2e timings $DATE" --no-verify
git push -u origin "$BRANCH_NAME"
echo "changed=true" >> "$GITHUB_OUTPUT"
- name: Create Pull Request
id: create_pr
if: steps.commit.outputs.changed == 'true'
env:
GH_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
run: |
BODY=$(cat <<'EOF'
## Summary
This PR updates the E2E test timing data with averaged values from recent test runs.
## Details
- Collected data from the last **${{ env.DAYS_BACK }} days** of test runs
- Averaged timing data from **${{ steps.collect-timings.outputs.artifact-count }}** test runs
## Generated automatically
🤖 This PR was created automatically by the `update-e2e-timings` workflow.
The timing data helps cypress-split optimize test distribution across parallel jobs.
Co-Authored-By: GitHub Actions <actions@github.com>
EOF
)
URL=$(gh pr create \
--base master \
--head "$BRANCH_NAME" \
--title "[chore] Update E2E test timings with recent data" \
--body "$BODY" \
--label ".CI & Tests" \
--label "no-backport" \
--reviewer metabase/devexp)
PR_NUMBER=${URL##*/}
echo "pr_number=$PR_NUMBER" >> "$GITHUB_OUTPUT"
- name: Approve and Merge the PR
if: steps.commit.outputs.changed == 'true'
env:
# uses a different token than the token that created the PR so we can approve and merge it
GH_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ steps.create_pr.outputs.pr_number }}
shell: bash
run: |
gh pr review --approve "$PR_NUMBER"
gh pr merge --squash --auto "$PR_NUMBER"

View File

@@ -1,63 +0,0 @@
name: Reset Cloud Test Dataset
on:
workflow_dispatch:
inputs:
driver:
description: 'Driver to reset dataset for'
required: true
default: 'snowflake'
type: choice
options:
- snowflake
- bigquery-cloud-sdk
- redshift
- databricks
dataset-name:
description: 'Dataset name to drop (e.g., test-data)'
required: true
default: 'test-data'
type: string
jobs:
reset-dataset:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
CI: 'true'
DRIVERS: ${{ inputs.driver }}
# Snowflake
MB_SNOWFLAKE_TEST_USER: METABASE CI
MB_SNOWFLAKE_TEST_ACCOUNT: ${{ secrets.MB_SNOWFLAKE_TEST_ACCOUNT }}
MB_SNOWFLAKE_TEST_PASSWORD: ${{ secrets.MB_SNOWFLAKE_TEST_PASSWORD }}
MB_SNOWFLAKE_TEST_PRIVATE_KEY: ${{ secrets.MB_SNOWFLAKE_TEST_PRIVATE_KEY }}
MB_SNOWFLAKE_TEST_WAREHOUSE: ${{ secrets.MB_SNOWFLAKE_TEST_WAREHOUSE }}
# BigQuery
MB_BIGQUERY_TEST_PROJECT_ID: ${{ secrets.BIGQUERY_TEST_PROJECT_ID }}
MB_BIGQUERY_TEST_CLIENT_ID: ${{ secrets.MB_BIGQUERY_TEST_CLIENT_ID }}
MB_BIGQUERY_TEST_CLIENT_SECRET: ${{ secrets.MB_BIGQUERY_TEST_CLIENT_SECRET }}
MB_BIGQUERY_TEST_ACCESS_TOKEN: ${{ secrets.MB_BIGQUERY_TEST_ACCESS_TOKEN }}
MB_BIGQUERY_TEST_REFRESH_TOKEN: ${{ secrets.MB_BIGQUERY_TEST_REFRESH_TOKEN }}
MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON: ${{ secrets.MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON }}
MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON_ROUTING: ${{ secrets.MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON_ROUTING }}
# Redshift
MB_REDSHIFT_TEST_USER: metabase_ci
MB_REDSHIFT_TEST_DB: testdb
MB_REDSHIFT_TEST_HOST: ${{ secrets.MB_REDSHIFT_TEST_HOST }}
MB_REDSHIFT_TEST_PASSWORD: ${{ secrets.MB_REDSHIFT_TEST_PASSWORD }}
# Databricks
MB_DATABRICKS_TEST_HOST: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HOST }}
MB_DATABRICKS_TEST_HTTP_PATH: ${{ secrets.MB_DATABRICKS_JDBC_TEST_HTTP_PATH }}
MB_DATABRICKS_TEST_TOKEN: ${{ secrets.MB_DATABRICKS_JDBC_TEST_TOKEN }}
MB_DATABRICKS_TEST_CATALOG: metabase_ci
MB_DATABRICKS_TEST_CLIENT_ID: ${{ secrets.MB_DATABRICKS_JDBC_TEST_CLIENT_ID }}
MB_DATABRICKS_TEST_OAUTH_SECRET: ${{ secrets.MB_DATABRICKS_JDBC_TEST_OAUTH_SECRET }}
steps:
- uses: actions/checkout@v6
- uses: ./.github/actions/prepare-backend
- name: Drop dataset
run: >-
clojure -X:dev:drivers:drivers-dev:test
metabase.test.data.impl/drop-dataset!
:driver '"${{ inputs.driver }}"'
:dataset-name '"${{ inputs.dataset-name }}"'

View File

@@ -65,8 +65,13 @@ jobs:
embedding_sdk_host_sample_apps: ${{ steps.changes.outputs.embedding_sdk_host_sample_apps }}
embedding_sdk_ci: ${{ steps.changes.outputs.embedding_sdk_ci }}
custom_viz_all: ${{ steps.changes.outputs.custom_viz_all }}
project_backend_checks: ${{ steps.changes.outputs.project_backend_checks }}
project_migration_checks: ${{ steps.changes.outputs.project_migration_checks }}
project_ratchet_checks: ${{ steps.changes.outputs.project_ratchet_checks }}
# A ratchets-only change (the shrink automation PR) needs the ratchet check, not an uberjar.
no_source_code_changes: >-
${{ steps.changes.outputs.documentation == 'true'
${{ (steps.changes.outputs.documentation == 'true'
|| steps.changes.outputs.project_ratchet_checks == 'true')
&& steps.changes.outputs.backend_all == 'false'
&& steps.changes.outputs.frontend_all == 'false'
&& steps.changes.outputs.e2e_all == 'false' }}
@@ -143,6 +148,8 @@ jobs:
(needs.should-run.outputs.verdict == 'force-run' ||
needs.files-changed.outputs.no_source_code_changes != 'true')
uses: ./.github/workflows/uberjar.yml
with:
containerize: ${{ (github.event_name == 'push' && github.ref_name == 'master') || contains(github.event.pull_request.labels.*.name, 'build-docker-uberjar') }}
secrets: inherit
# Compile CLJS in parallel with the uberjar and pass it to each e2e group.
@@ -215,6 +222,9 @@ jobs:
needs.files-changed.outputs.backend_all != 'true' &&
needs.static-viz-files-changed.outputs.static_viz != 'true' }}
force-run: ${{ needs.should-run.outputs.verdict == 'force-run' }}
run-project-backend-checks: ${{ needs.files-changed.outputs.project_backend_checks == 'true' }}
run-project-migration-checks: ${{ needs.files-changed.outputs.project_migration_checks == 'true' }}
run-project-ratchet-checks: ${{ needs.files-changed.outputs.project_ratchet_checks == 'true' }}
semantic-search-tests:
if: |
@@ -406,15 +416,3 @@ jobs:
self_hosting: false
analytics_dev_mode: false
stats_dump: true
containerize:
needs: [uberjar]
if: |
!cancelled() &&
needs.uberjar.result == 'success' &&
(
(github.event_name == 'push' && contains(fromJson('["master", "metabot-v3-main", "internal-tools"]'), github.ref_name)) ||
(github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'build-docker-uberjar'))
)
uses: ./.github/workflows/containerize-uberjar.yml
secrets: inherit

View File

@@ -21,7 +21,7 @@ jobs:
// Nightly patches cover the current supported major and the one
// before it. release-auto.yml releases one major per dispatch.
const currentRelease = Number('${{ vars.CURRENT_VERSION }}');
const majors = [currentRelease - 1, currentRelease];
const majors = [currentRelease];
await Promise.all(majors.map(version =>
github.rest.actions.createWorkflowDispatch({

View File

@@ -96,7 +96,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
semantic-search-tests-mariadb:
if: ${{ !inputs.skip && (inputs.suite == '' || inputs.suite == 'mariadb') }}
@@ -162,7 +161,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
semantic-search-tests-mysql:
if: ${{ !inputs.skip && (inputs.suite == '' || inputs.suite == 'mysql') }}
@@ -235,7 +233,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
semantic-search-tests-postgres:
if: ${{ !inputs.skip && (inputs.suite == '' || inputs.suite == 'postgres') }}
@@ -300,7 +297,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
# pgvector-on-the-app-db mode: the app db itself is a pgvector-capable Postgres and
# MB_PGVECTOR_DB_URL is deliberately unset. The dedicated-harness tests gate themselves off; the
@@ -355,7 +351,6 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
semantic-search-tests-result:
needs:

View File

@@ -1,165 +0,0 @@
name: "Snyk"
on:
push:
branches:
- "master"
- "release-**"
paths:
- "**/deps.edn"
- "**/package.json"
- ".github/workflows/snyk.yml"
- ".github/scripts/write-poms.sh"
- ".github/scripts/fix-yarn-lock-aliases.ts"
schedule:
- cron: "0 5 * * *"
jobs:
# Generate pom.xml files for all Maven projects
generate-poms:
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
name: Generate pom.xml files
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- uses: actions/checkout@v6
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- name: Generate all pom.xml
run: .github/scripts/write-poms.sh
- name: Upload pom files
uses: actions/upload-artifact@v7
with:
name: pom-files
path: |
pom.xml
modules/drivers/*/pom.xml
# Yarn/NPM projects that don't need pom files
frontend-projects:
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
name: ${{ matrix.project.name }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
strategy:
matrix:
project:
- name: Main Frontend (bun w/ yarn.lock)
file: yarn.lock
package-manager: yarn
category: main-frontend-bun
- name: Release Helper
file: release/yarn.lock
package-manager: yarn
category: release-helper
steps:
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
# Snyk doesn't support bun.lock yet, so we generate yarn.lock and scan that.
# Bun has a bug where it normalizes "< 3.0.0" to "< 3" in alias entries
# but not in dependency specs, causing Snyk to fail matching dependencies.
# The sed commands fix this inconsistency. Bun also names aliased entries
# after the aliased package instead of the alias, which the script fixes.
# Both continue on error to let Snyk report parsing issues directly rather
# than failing on the workaround.
- name: Generate yarn.lock
if: matrix.project.file == 'yarn.lock'
run: |
bun install --yarn
sed -i -E 's/< ([0-9]+)\.0\.0"/< \1"/g; s/< ([0-9]+)\.0"/< \1"/g' yarn.lock || true
bun ${{ github.workspace }}/.github/scripts/fix-yarn-lock-aliases.ts || true
- name: Generate release/yarn.lock
if: matrix.project.file == 'release/yarn.lock'
run: |
bun install --yarn
sed -i -E 's/< ([0-9]+)\.0\.0"/< \1"/g; s/< ([0-9]+)\.0"/< \1"/g' yarn.lock || true
bun ${{ github.workspace }}/.github/scripts/fix-yarn-lock-aliases.ts || true
working-directory: release
- uses: snyk/actions/setup@9adf32b1121593767fc3c057af55b55db032dc04 # v1.0.0
- name: Run snyk test
env:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
continue-on-error: true
run: snyk test --org="metabase-AnD9iS4Wfu4eBYMsG2DZ5N" --remote-repo-url="https://github.com/metabase/metabase" --file=${{ matrix.project.file }} --package-manager=${{ matrix.project.package-manager }} --sarif-file-output=snyk-${{ matrix.project.category }}.sarif
- name: Upload results
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: snyk-${{ matrix.project.category }}.sarif
category: ${{ matrix.project.category }}
# Maven projects that need pom files
maven-projects:
needs: generate-poms
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
name: ${{ matrix.project.name }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
strategy:
matrix:
project:
- name: Main Backend (maven)
file: pom.xml
category: main-backend-maven
- name: Driver - Athena
file: modules/drivers/athena/pom.xml
category: driver-athena
- name: Driver - BigQuery Cloud SDK
file: modules/drivers/bigquery-cloud-sdk/pom.xml
category: driver-bigquery-cloud-sdk
- name: Driver - ClickHouse
file: modules/drivers/clickhouse/pom.xml
category: driver-clickhouse
- name: Driver - Databricks
file: modules/drivers/databricks/pom.xml
category: driver-databricks
- name: Driver - Druid JDBC
file: modules/drivers/druid-jdbc/pom.xml
category: driver-druid-jdbc
- name: Driver - Hive-like
file: modules/drivers/hive-like/pom.xml
category: driver-hive-like
- name: Driver - MongoDB
file: modules/drivers/mongo/pom.xml
category: driver-mongo
- name: Driver - Oracle
file: modules/drivers/oracle/pom.xml
category: driver-oracle
- name: Driver - Presto JDBC
file: modules/drivers/presto-jdbc/pom.xml
category: driver-presto-jdbc
- name: Driver - Redshift
file: modules/drivers/redshift/pom.xml
category: driver-redshift
- name: Driver - Snowflake
file: modules/drivers/snowflake/pom.xml
category: driver-snowflake
- name: Driver - SparkSQL
file: modules/drivers/sparksql/pom.xml
category: driver-sparksql
- name: Driver - SQL Server
file: modules/drivers/sqlserver/pom.xml
category: driver-sqlserver
- name: Driver - Starburst
file: modules/drivers/starburst/pom.xml
category: driver-starburst
- name: Driver - Vertica
file: modules/drivers/vertica/pom.xml
category: driver-vertica
steps:
- uses: actions/checkout@v6
- uses: snyk/actions/setup@9adf32b1121593767fc3c057af55b55db032dc04 # v1.0.0
- name: Download pom files
uses: actions/download-artifact@v8
with:
name: pom-files
- name: Run snyk test
env:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
continue-on-error: true
run: snyk test --org="metabase-AnD9iS4Wfu4eBYMsG2DZ5N" --remote-repo-url="https://github.com/metabase/metabase" --file=${{ matrix.project.file }} --package-manager=maven --sarif-file-output=snyk-${{ matrix.project.category }}.sarif
- name: Upload results
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: snyk-${{ matrix.project.category }}.sarif
category: ${{ matrix.project.category }}

View File

@@ -0,0 +1,125 @@
name: Bundle Load Stats
# Reuses the uberjar built on every master merge: boots it, signs in, loads the
# app in a throttled headless Chrome across four network and CPU conditions, and
# appends the times to eng-stats-importer.
#
# The instance is blank on purpose. `index.html` is built from settings and the
# signed-in user alone, so seeding content would not change a single byte of the
# document this measures.
# Triggered by "Run tests", which is the workflow that builds the uberjar on a
# master merge.
on:
workflow_run:
workflows: ["Run tests"]
types: [completed]
# Master only: a release forms a non-linear line whose times cannot be
# compared against the commit before it.
branches: [master]
workflow_call:
inputs:
commit:
description: "Commit SHA to measure."
type: string
required: false
default: ""
concurrency:
group: bundle-load-stats-${{ inputs.commit || github.event.workflow_run.head_sha }}
cancel-in-progress: true
jobs:
# "Run tests" concludes `failure` on master more often than `success`, from
# jobs that have nothing to do with the jar, so its conclusion is not a usable
# gate. The artifact is one: the uberjar job publishes it, and a docs-only
# merge that skipped that job publishes none.
uberjar-built:
if: ${{ github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.SLIM_RUNNER_KEY }}
timeout-minutes: 5
outputs:
found: ${{ steps.probe.outputs.fetch-hit }}
steps:
- uses: actions/checkout@v6
- id: probe
uses: ./.github/actions/fetch-artifact
with:
commit: ${{ inputs.commit || github.event.workflow_run.head_sha }}
edition: ee
download: false
bundle-load-stats:
needs: [uberjar-built]
if: ${{ needs.uberjar-built.outputs.found == 'true' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
HEAD_SHA: ${{ inputs.commit || github.event.workflow_run.head_sha }}
MB_JETTY_PORT: "4000"
SITE: http://localhost:4000
# Loads per condition. The first is the cold reading and the rest give the
# median, so this trades run time for a steadier number.
RUNS: "8"
steps:
- name: Check out the code
uses: actions/checkout@v6
with:
ref: ${{ env.HEAD_SHA }}
- uses: ./.github/actions/prepare-node-bun
- name: Prepare JDK 25
uses: actions/setup-java@v5.2.0
with:
java-version: "25"
distribution: "temurin"
- name: Install Chrome v144
uses: browser-actions/setup-chrome@2e1d749697dd1612b833dba4a722266286fbefcd # v2.1.2
with:
chrome-version: 144
id: setup-chrome
- name: Download EE uberjar
uses: ./.github/actions/fetch-artifact
with:
commit: ${{ env.HEAD_SHA }}
edition: ee
extract-path: temp/uberjar
- name: Start Metabase
run: |
mkdir -p artifacts
# --add-opens matches how the jar is launched everywhere else
# (uberjar.yml, pre-release.yml, bin/docker/run_metabase.sh), so the
# benchmark runs the app under the JVM configuration we ship.
MB_DB_FILE="${RUNNER_TEMP}/bench.db" \
nohup java --add-opens java.base/java.nio=ALL-UNNAMED \
-jar temp/uberjar/metabase.jar > artifacts/metabase.log 2>&1 &
- name: Sign in
run: |
# Waits for the instance to migrate and come up, then creates the
# first user. Masked because the token authenticates as that user.
session=$(bun frontend/test/bench/sign-in.ts "$SITE")
echo "::add-mask::$session"
echo "SESSION_COOKIE=$session" >> "$GITHUB_ENV"
- name: Warm the backend
run: |
# The first document a fresh JVM renders pays for its own JIT. Spend
# that here rather than inside the first condition measured.
for _ in 1 2 3 4 5; do curl -sS -o /dev/null "$SITE/"; done
- name: Measure load times
env:
CHROME_PATH: ${{ steps.setup-chrome.outputs.chrome-path }}
run: |
bun frontend/test/bench/matrix.ts "$SITE/" "$RUNS" \
| tee artifacts/load-times.json
- name: Show the Metabase log if something went wrong
if: failure()
run: tail -100 artifacts/metabase.log || true
- name: Import load times into Stats
if: ${{ inputs.commit == '' }}
env:
ROWS: artifacts/load-times.json
# Passed via env (not interpolated into the shell) so the commit
# message can't inject commands; the script keeps only the subject.
COMMIT_MESSAGE: ${{ github.event.workflow_run.head_commit.message }}
ENG_STATS_URL: ${{ secrets.ENG_STATS_URL }}
API_KEY: ${{ secrets.ENG_STATS_API_KEY }}
run: bun .github/scripts/upload-bundle-load-stats.ts

View File

@@ -0,0 +1,74 @@
name: Cleanup DWH Test Data
on:
schedule:
- cron: '0 7 * * *'
workflow_dispatch:
inputs:
drivers:
description: 'Drivers to sweep (comma-separated)'
required: false
default: 'snowflake,bigquery-cloud-sdk,redshift'
type: string
hours:
description: 'TTL in hours for per-run garbage (minimum 4)'
required: false
default: '12'
type: string
# `inputs.*` is empty on the scheduled run, so each falls back to the nightly value.
env:
GC_HOURS: ${{ inputs.hours || 12 }} # for temp data
GC_DRIVERS: ${{ inputs.drivers || 'snowflake,bigquery-cloud-sdk,redshift' }}
concurrency:
group: test-cleanup-dwh-data
cancel-in-progress: false
permissions:
contents: read
jobs:
gc:
name: Sweep orphaned test data
if: ${{ github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 60
env:
CI: 'true'
# Snowflake
MB_SNOWFLAKE_TEST_USER: METABASE CI
MB_SNOWFLAKE_TEST_ACCOUNT: ${{ secrets.MB_SNOWFLAKE_TEST_ACCOUNT }}
MB_SNOWFLAKE_TEST_PASSWORD: ${{ secrets.MB_SNOWFLAKE_TEST_PASSWORD }}
MB_SNOWFLAKE_TEST_PRIVATE_KEY: ${{ secrets.MB_SNOWFLAKE_TEST_PRIVATE_KEY }}
MB_SNOWFLAKE_TEST_WAREHOUSE: ${{ secrets.MB_SNOWFLAKE_TEST_WAREHOUSE }}
# BigQuery
MB_BIGQUERY_TEST_PROJECT_ID: ${{ secrets.BIGQUERY_TEST_PROJECT_ID }}
MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON: ${{ secrets.MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON }}
MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON_ROUTING: ${{ secrets.MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON_ROUTING }}
# Redshift
MB_REDSHIFT_TEST_USER: metabase_ci
MB_REDSHIFT_TEST_DB: testdb
MB_REDSHIFT_TEST_DB_ROUTING: dev
MB_REDSHIFT_TEST_HOSTS: ${{ secrets.MB_REDSHIFT_TEST_HOSTS }}
MB_REDSHIFT_TEST_HOST: ${{ secrets.MB_REDSHIFT_TEST_HOST }}
MB_REDSHIFT_TEST_PASSWORD: ${{ secrets.MB_REDSHIFT_TEST_PASSWORD }}
steps:
- uses: actions/checkout@v6
- uses: ./.github/actions/prepare-backend
- name: Sweep orphaned test data
run: |
clojure -X:dev:drivers:drivers-dev:test metabase.test.data.gc/gc-orphans! \
:drivers "\"${{ env.GC_DRIVERS }}\"" \
:hours "${{ env.GC_HOURS }}" \
:report-dir '"target/gc-report"'
# The report is most wanted on the runs that fail, so upload it regardless of the sweep's outcome.
- name: Upload sweep report
if: ${{ !cancelled() }}
continue-on-error: true
uses: actions/upload-artifact@v7
with:
name: dwh-gc-report-${{ github.run_id }}-attempt-${{ github.run_attempt }}
path: target/gc-report
if-no-files-found: warn

View File

@@ -144,14 +144,12 @@ jobs:
EOF
)"
- name: Auto approve PR
uses: juliangruber/approve-pull-request-action@68fcc9a5a73b5641cadf757cf99d73720dcb05d0 # v2.1.0
with:
github-token: ${{ github.token }}
number: ${{ steps.create_pr.outputs.pr_number }}
- name: Enable Pull Request Automerge
run: gh pr merge --squash --auto "$PR_NUMBER"
- name: Approve and Merge the PR
run: |
gh pr review --approve "$PR_NUMBER"
gh pr merge --squash --auto "$PR_NUMBER"
shell: bash
env:
GH_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
# uses a different token than the token that created the PR so we can approve and merge it
GH_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ steps.create_pr.outputs.pr_number }}

View File

@@ -1,21 +0,0 @@
name: Uberjar Containerize labeled
on:
pull_request:
types: [ labeled, opened, synchronize, reopened ]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
uberjar:
if: ${{ contains(github.event.pull_request.labels.*.name, 'build-docker-uberjar') || github.event.label.name == 'build-docker-uberjar' }}
uses: ./.github/workflows/uberjar.yml
secrets: inherit
containerize:
needs: [uberjar]
if: ${{ contains(github.event.pull_request.labels.*.name, 'build-docker-uberjar') || github.event.label.name == 'build-docker-uberjar' }}
uses: ./.github/workflows/containerize-uberjar.yml
secrets: inherit

View File

@@ -1,108 +1,89 @@
name: Build Uberjar
# This workflow builds an uberjar and pushes it to dockerhub for any branch, either on-demand,
# or automatically for the listed branches
# This workflow builds and containerizes an uberjar and pushes it to dockerhub.
concurrency:
group: uberjar-${{ inputs.commit || github.event.pull_request.head.sha || github.sha }}
cancel-in-progress: false
on:
push:
branches:
- master
- internal-tools
- ai-service-port
- metabot-mbql-improvements
paths-ignore:
# config files
- ".**"
# documentation
- "docs/**"
- "**.md"
# this covers both BE and FE unit tests, as well as E2E tests
- "**test/**"
- "**_test.clj"
- "**/frontend/**.unit.*"
workflow_dispatch:
inputs:
commit:
description: "Optional full-length commit SHA-1 hash"
type: string
default: ''
required: false
containerize:
description: "Set if the uberjar should be containerized and pushed to Dockerhub."
type: boolean
default: false
required: false
workflow_call:
inputs:
commit:
description: "Optional full-length commit SHA-1 hash"
type: string
default: ''
required: false
containerize:
description: "Set if the uberjar should be containerized and pushed to Dockerhub."
type: boolean
default: false
required: false
jobs:
check-existing-artifacts:
setup:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
outputs:
ee_exists: ${{ steps.check-ee.outcome == 'success' }}
oss_exists: ${{ steps.check-oss.outcome == 'success' }}
should_build: ${{ steps.decide.outputs.should_build }}
build_editions: ${{ steps.matrix.outputs.build_editions }}
java_version: ${{ steps.dependencies.outputs.java_version }}
node_version: ${{ steps.dependencies.outputs.node_version }}
steps:
- name: Check out the code
uses: actions/checkout@v6
- name: Try to fetch existing EE artifact
- uses: actions/checkout@v6
- name: Check for existing EE uberjar
id: check-ee
continue-on-error: true
uses: ./.github/actions/fetch-artifact
continue-on-error: true
with:
commit: ${{ inputs.commit || github.event.pull_request.head.sha || github.sha }}
edition: ee
output-name: metabase-ee.jar
download: false
- name: Try to fetch existing OSS artifact
- name: Check for existing OSS uberjar
id: check-oss
continue-on-error: true
uses: ./.github/actions/fetch-artifact
continue-on-error: true
with:
commit: ${{ inputs.commit || github.event.pull_request.head.sha || github.sha }}
edition: oss
output-name: metabase-oss.jar
download: false
- name: Decide if build is needed
id: decide
run: |
EE_EXISTS="${{ steps.check-ee.outcome == 'success' }}"
OSS_EXISTS="${{ steps.check-oss.outcome == 'success' }}"
echo "EE exists: $EE_EXISTS"
echo "OSS exists: $OSS_EXISTS"
# Build only if artifacts don't exist for this commit hash
# Since we build by hash, if artifacts exist for this hash, we don't need to rebuild
if [[ "$EE_EXISTS" == "false" ]] || [[ "$OSS_EXISTS" == "false" ]]; then
SHOULD_BUILD="true"
echo "Will build: ee_exists=$EE_EXISTS, oss_exists=$OSS_EXISTS"
else
SHOULD_BUILD="false"
echo "Skipping build: artifacts exist for this commit hash"
fi
echo "should_build=$SHOULD_BUILD" >> "$GITHUB_OUTPUT"
# if this is on a release branch, we need to check the build requirements
get-build-requirements:
if: |
!cancelled() &&
contains(github.ref, 'release-x')
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
outputs:
java_version: ${{ fromJson(steps.dependencies.outputs.result).java_version }}
node_version: ${{ fromJson(steps.dependencies.outputs.result).node_version }}
steps:
- uses: actions/checkout@v6
- name: Create build matrix
id: matrix
uses: actions/github-script@v9
with:
sparse-checkout: |
release
.github
script: | # js
const hit = {
ee: "${{ steps.check-ee.outputs.fetch-hit }}" === "true",
oss: "${{ steps.check-oss.outputs.fetch-hit }}" === "true",
};
// Don't rebuild an edition whose uberjar already exists for this commit.
const editions = ['ee', 'oss'].filter((edition) => !hit[edition]);
core.info(`build: ${editions.join(', ') || '(nothing, both artifacts already exist)'}`);
core.setOutput('build_editions', JSON.stringify(editions));
- name: Prepare release scripts
if: ${{ contains(github.ref, 'release-x') }}
uses: ./.github/actions/prepare-release-scripts
- name: Get build dependencies
if: ${{ contains(github.ref, 'release-x') }}
uses: actions/github-script@v9
id: dependencies
with:
@@ -112,26 +93,22 @@ jobs:
const version = getVersionFromReleaseBranch('${{ github.ref }}');
const requirements = getBuildRequirements(version);
return {
java_version: requirements.java,
node_version: requirements.node,
};
core.setOutput('java_version', requirements.java);
core.setOutput('node_version', requirements.node);
build:
needs:
[check-existing-artifacts, get-build-requirements]
if: always() && !cancelled() && needs.check-existing-artifacts.outputs.should_build == 'true' && (needs.get-build-requirements.result == 'success' || needs.get-build-requirements.result == 'skipped')
name: Build MB ${{ matrix.edition }}
needs: [setup]
if: ${{ needs.setup.outputs.build_editions != '[]' }}
name: build (${{ matrix.edition }})
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
strategy:
matrix:
edition: ["ee", "oss"]
edition: ${{ fromJson(needs.setup.outputs.build_editions) }}
env:
MB_EDITION: ${{ matrix.edition }}
INTERACTIVE: false
SKIP_LICENSES: ${{ github.event_name == 'pull_request' }} # faster builds for dev
SKIP_LICENSES: ${{ github.event_name == 'pull_request' && !inputs.containerize }} # faster builds for dev
# Emit bundle stats on trunk/release builds (tracked over time) and on PRs
# (the bundle-size check reads them for both the PR head and its base ref).
EMIT_BUNDLE_STATS: ${{ (github.ref_name == 'master' || startsWith(github.ref_name, 'release-') || github.event_name == 'pull_request') && 'true' || 'false' }}
@@ -143,11 +120,11 @@ jobs:
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
with:
node-version: "${{ needs.get-build-requirements.outputs.node_version || '22' }}"
node-version: "${{ needs.setup.outputs.node_version || '22' }}"
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
with:
java-version: "${{ needs.get-build-requirements.outputs.java_version || 25 }}"
java-version: "${{ needs.setup.outputs.java_version || 25 }}"
- name: Build
run: ./bin/build.sh
- name: Upload bundle stats
@@ -168,29 +145,23 @@ jobs:
uses: actions/upload-artifact@v7
with:
# Same key the artifact lookups use, so a build for an explicitly dispatched commit
# uploads where `check-existing-artifacts` and `check-jar-health` go looking for it.
# uploads where `setup` and `jar-healthcheck` go looking for it.
name: metabase-${{ matrix.edition }}-${{ inputs.commit || github.event.pull_request.head.sha || github.sha }}-uberjar
path: |
./target/uberjar/metabase.jar
./COMMIT-ID
./SHA256.sum
check-jar-health:
jar-healthcheck:
needs: [setup, build]
# Health-check whatever we are about to containerize, plus every build on master and release.
if: ${{ !failure() && !cancelled() && (inputs.containerize || github.ref_name == 'master' || startsWith(github.ref_name, 'release-')) }}
name: jar-healthcheck (${{ matrix.edition }})
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: Is ${{ matrix.edition }} (java ${{ matrix.java-version }}) healthy?
needs: [build, check-existing-artifacts]
# We only care about the explicit JAR health check on push to `master` and the `release-` branches.
# JARs created in random branches on PRs are 99% of the time treated as ephemeral, and used only in e2e tests.
# E2E tests already have a step where they wait for the instance health check.
if: |
always() && !cancelled() &&
(github.ref_name == 'master' || startsWith(github.ref_name, 'release-')) &&
(needs.build.result == 'success' || (needs.check-existing-artifacts.outputs.should_build == 'false' && needs.check-existing-artifacts.outputs.ee_exists == 'true' && needs.check-existing-artifacts.outputs.oss_exists == 'true'))
timeout-minutes: 10
strategy:
matrix:
edition: ["ee", "oss"]
java-version: [25]
edition: [ee, oss]
steps:
- name: Check out the code
uses: actions/checkout@v6
@@ -198,7 +169,7 @@ jobs:
uses: actions/setup-java@v5.2.0
with:
java-package: jre
java-version: ${{ matrix.java-version }}
java-version: ${{ needs.setup.outputs.java_version || 25 }}
distribution: "temurin"
- run: java -version
- name: Retrieve uberjar artifact
@@ -217,3 +188,19 @@ jobs:
java --add-opens java.base/java.nio=ALL-UNNAMED -jar ./metabase.jar &
- name: Wait for Metabase to start
run: while ! curl 'http://localhost:3000/api/health' | grep '{"status":"ok"}'; do sleep 1; done
containerize:
needs: [build, jar-healthcheck]
if: ${{ inputs.containerize && !failure() && !cancelled() }}
name: containerize (${{ matrix.edition }})
strategy:
matrix:
edition: [ee, oss]
uses: ./.github/workflows/containerize-jar.yml
secrets: inherit
with:
edition: ${{ matrix.edition }}
commit: ${{ inputs.commit || github.event.pull_request.head.sha || github.sha }}
release: false
build-args: |
GIT_COMMIT_SHA=${{ inputs.commit || github.event.pull_request.head.sha || github.sha }}

View File

@@ -1,103 +0,0 @@
name: Update E2E Timings
permissions:
contents: write
pull-requests: write
on:
workflow_dispatch:
inputs:
days_back:
description: "Number of days to look back for timing artifacts"
type: number
default: 7
required: false
schedule:
# Run weekly on Sundays at 6 AM UTC
- cron: "0 6 * * 0"
jobs:
collect-and-average-timings:
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
env:
DAYS_BACK: ${{ inputs.days_back || 7 }}
steps:
- name: Generate GitHub App Token
uses: actions/create-github-app-token@v1
id: app-token
with:
app-id: ${{ secrets.METABASE_BOT_APP_ID }}
private-key: ${{ secrets.METABASE_BOT_APP_PRIVATE_KEY }}
- uses: actions/checkout@v6
with:
token: ${{ steps.app-token.outputs.token }}
- name: Setup Node.js
uses: actions/setup-node@v6.4.0
with:
node-version: 22
- name: Collect and average timing data
id: collect-timings
uses: actions/github-script@v9
with:
script: |
const { collectAndAverageTimings } = require('${{ github.workspace }}/.github/scripts/average-e2e-timings.js');
const result = await collectAndAverageTimings({
github,
context,
token: '${{ steps.app-token.outputs.token }}',
daysBack: ${{ env.DAYS_BACK }},
existingTimingsPath: 'e2e/support/timings.json'
});
core.setOutput('artifact-count', result.artifactCount);
- name: Set up git configuration
run: |
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
BRANCH_NAME="update-e2e-timings-$(date +%Y%m%d-%H%M%S)"
echo "BRANCH_NAME=$BRANCH_NAME" >> "$GITHUB_ENV"
echo "Branch name will be: $BRANCH_NAME"
- name: Create Pull Request
uses: peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1 # v8.1.1
with:
token: ${{ steps.app-token.outputs.token }}
branch: ${{ env.BRANCH_NAME }}
base: master
commit-message: |
Update E2E test timings with averaged data
Collected timing data from ${{ env.DAYS_BACK }} days of test runs.
All specs with timing data were included (simple averages).
🤖 Generated automatically by update-e2e-timings workflow
Co-Authored-By: GitHub Actions <actions@github.com>
committer: "github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>"
author: "github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>"
title: "[chore] Update E2E test timings with recent data"
body: |
## Summary
This PR updates the E2E test timing data with averaged values from recent test runs.
## Details
- Collected data from the last **${{ env.DAYS_BACK }} days** of test runs
- Averaged timing data from **${{ steps.collect-timings.outputs.artifact-count }}** test runs
## Generated automatically
🤖 This PR was created automatically by the `update-e2e-timings` workflow.
The timing data helps cypress-split optimize test distribution across parallel jobs.
Co-Authored-By: GitHub Actions <actions@github.com>
labels: |
.CI & Tests
no-backport
add-paths: e2e/support/timings.json
team-reviewers: |
devexp

Binary file not shown.

After

Width:  |  Height:  |  Size: 26 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 40 KiB

After

Width:  |  Height:  |  Size: 40 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 40 KiB

After

Width:  |  Height:  |  Size: 40 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 7.2 KiB

After

Width:  |  Height:  |  Size: 7.2 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 67 KiB

After

Width:  |  Height:  |  Size: 68 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 67 KiB

After

Width:  |  Height:  |  Size: 68 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 60 KiB

After

Width:  |  Height:  |  Size: 61 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 60 KiB

After

Width:  |  Height:  |  Size: 61 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 66 KiB

After

Width:  |  Height:  |  Size: 66 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 66 KiB

After

Width:  |  Height:  |  Size: 67 KiB

Some files were not shown because too many files have changed in this diff Show More