chore: add single dev command to run before push

* Prevent flickered no question "new" found error

* Refix the bug

.claude/commands/fix-flakey-test.md

@@ -0,0 +1 @@
+Fix flakey test $ARGUMENTS

.claude/commands/fix-issue.md

@@ -0,0 +1 @@
+Fix issue $ARGUMENTS

.claude/commands/fix-pr.md

@@ -0,0 +1 @@
+Fetch unresolved comments for this branch's PR, then fix them

.claude/commands/repro-issue.md

@@ -0,0 +1 @@
+Repro issue $ARGUMENTS in a failing test

.clj-kondo/config/test-helpers/config.edn

@@ -0,0 +1,144 @@
+{:linters
+ {:metabase/test-helpers-use-non-thread-safe-functions
+  ;; TODO -- seems silly to maintain different blacklists and whitelists here than we use for the deftest `^:parallel`
+  ;; checker...
+  {:explicitly-safe
+   #{ ;; these toucan methods might actually set global values if it's used outside of a transaction,
+     ;; but since mt/with-temp runs in a transaction, so we'll ignore them in this case.
+     toucan2.core/delete!
+     toucan2.core/update!
+     toucan2.core/insert!
+     toucan2.core/insert-returning-instance!
+     toucan2.core/insert-returning-instances!
+     toucan2.core/insert-returning-pk!
+     toucan2.core/insert-returning-pks!
+     clojure.core.async/<!!
+     clojure.core.async/>!!
+     clojure.core.async/alts!!
+     clojure.core.async/close!
+     clojure.core.async/poll!
+     clojure.core.memoize/memo-clear!
+     clojure.core/conj!
+     clojure.core/persistent!
+     clojure.core/reset!
+     clojure.core/swap!
+     clojure.core/volatile!
+     clojure.core/vreset!
+     clojure.core/vswap!
+     clojure.java.jdbc/execute!
+     methodical.core/add-aux-method-with-unique-key!
+     methodical.core/remove-aux-method-with-unique-key!
+     next.jdbc/execute!
+
+     ;; Definitely thread safe
+     metabase.test.util.dynamic-redefs/patch-vars!
+
+     ;; TODO: most of these symbols shouldn't be here, we should go through them and
+     ;; find the functions/macros that use them and make sure their names end with !
+     ;; best way to do this is try remove each of these and rely on kondo output to find places where it's used
+     clojure.test/grant-collection-perms!
+     clojure.test/grant-collection-perms-fn!
+     clojure.test/grant-perms-fn!
+     clojure.test/purge-old-entries!
+     clojure.test/revoke-collection-perms!
+     clojure.test/save-results!
+     metabase-enterprise.advanced-permissions.models.permissions/update-db-download-permissions!
+     metabase-enterprise.internal-user/install-internal-user!
+     metabase-enterprise.sso.integrations.saml-test/call-with-login-attributes-cleared!
+     metabase.actions.actions/perform-action!
+     metabase.actions.models/insert!
+     metabase.analytics.snowplow-test/fake-track-event-impl!
+     metabase.analytics.snowplow/track-event-impl!
+     metabase.app-db.core/finish-db-setup!
+     metabase.app-db.core/migrate!
+     metabase.app-db.core/setup-db!
+     metabase.app-db.schema-migrations-test.impl/run-migrations-in-range!
+     metabase.app-db.setup/migrate!
+     metabase.app-db.setup/setup-db!
+     metabase.channel.email-test/reset-inbox!
+     metabase.channel.email/send-email!
+     metabase.cmd.dump-to-h2/dump-to-h2!
+     metabase.cmd.load-from-h2/load-from-h2!
+     metabase.content-verification.models.moderation-review/create-review!
+     metabase.core.core/ensure-audit-db-installed!
+     metabase.driver.mongo-test/create-database-from-row-maps!
+     metabase.driver.postgres-test/create-enums-db!
+     metabase.driver.postgres-test/drop-if-exists-and-create-db!
+     metabase.driver.sql-jdbc.execute/execute-statement!
+     metabase.indexed-entities.models.model-index/add-values!
+     metabase.driver.sql-jdbc.connection.ssh-tunnel-test/start-mock-servers!
+     metabase.driver.sql-jdbc.connection.ssh-tunnel-test/stop-mock-servers!
+     metabase.indexed-entities.task.index-values/job-init!
+     metabase.model-persistence.models.persisted-info/ready-database!
+     metabase.model-persistence.task.persist-refresh/job-init!
+     metabase.model-persistence.task.persist-refresh/refresh-tables!
+     metabase.model-persistence.task.persist-refresh/schedule-persistence-for-database!
+     metabase.models.on-demand-test/add-dashcard-with-parameter-mapping!
+     metabase.permissions.core/grant-application-permissions!
+     metabase.permissions.core/grant-collection-read-permissions!
+     metabase.permissions.core/grant-collection-readwrite-permissions!
+     metabase.permissions.core/grant-full-data-permissions!
+     metabase.permissions.core/grant-native-readwrite-permissions!
+     metabase.permissions.core/grant-permissions!
+     metabase.permissions.core/revoke-application-permissions!
+     metabase.permissions.core/revoke-data-perms!
+     metabase.permissions.core/update-data-perms-graph!
+     metabase.permissions.core/update-group-permissions!
+     metabase.permissions.models.collection.graph-test/clear-graph-revisions!
+     metabase.permissions.models.collection.graph-test/do-with-n-temp-users-with-personal-collections!
+     metabase.permissions.models.permissions/grant-application-permissions!
+     metabase.permissions.models.permissions/grant-collection-read-permissions!
+     metabase.permissions.models.permissions/grant-collection-readwrite-permissions!
+     metabase.permissions.models.permissions/grant-full-data-permissions!
+     metabase.permissions.models.permissions/grant-native-readwrite-permissions!
+     metabase.permissions.models.permissions/grant-permissions!
+     metabase.permissions.models.permissions/revoke-application-permissions!
+     metabase.permissions.models.permissions/revoke-data-perms!
+     metabase.permissions.models.permissions/update-data-perms-graph!
+     metabase.permissions.models.permissions/update-group-permissions!
+     metabase.permissions.test-util/with-restored-perms!
+     metabase.public-sharing.api-test/add-card-to-dashboard!
+     metabase.pulse.send/send-notifications!
+     metabase.pulse.send/send-pulse!
+     metabase.query-processor.streaming.interface/begin!
+     metabase.query-processor.streaming.interface/finish!
+     metabase.query-processor.streaming.interface/write-row!
+     metabase.sample-data.impl/try-to-extract-sample-database!
+     metabase.settings.models.setting-test/test-user-local-allowed-setting!
+     metabase.settings.models.setting-test/test-user-local-only-setting!
+     metabase.settings.models.setting.cache/restore-cache!
+     metabase.settings.models.setting/set!
+     metabase.settings.models.setting/validate-settings-formatting!
+     metabase.setup.core/create-token!
+     metabase.sso.ldap-test-util/start-ldap-server!
+     metabase.sync.core/sync-database!
+     metabase.sync.sync-metadata.fields.sync-metadata/update-field-metadata-if-needed!
+     metabase.sync.sync-metadata/sync-db-metadata!
+     metabase.sync.util-test/sync-database!
+     metabase.sync.util/store-sync-summary!
+     metabase.task.core/delete-task!
+     metabase.task.impl/delete-task!
+     metabase.test.data.bigquery-cloud-sdk/execute!
+     metabase.test.data.impl.get-or-create/set-test-db-permissions!
+     metabase.test.data.impl/copy-db-tables-and-fields!
+     metabase.test.data.impl/get-or-create-database!
+     metabase.test.data.impl/get-or-create-default-dataset!
+     metabase.test.data.interface/create-db!
+     metabase.test.data.interface/destroy-db!
+     metabase.test.data.oracle/create-user!
+     metabase.test.data.oracle/drop-user!
+     metabase.test.data.sql-jdbc.load-data/make-insert!
+     metabase.test.data.users/clear-cached-session-tokens!
+     metabase.test.initialize/do-initialization!
+     metabase.test.initialize/initialize-if-needed!
+     metabase.test.util.log/ensure-unique-logger!
+     metabase.test.util.log/set-ns-log-level!
+     metabase.test.util/do-with-temp-env-var-value!
+     metabase.test.util/restore-raw-setting!
+     metabase.test.util/upsert-raw-setting!
+     metabase.test/initialize-if-needed!
+     metabase.test/test-helpers-set-global-values!
+     metabase.test/with-temp-env-var-value!
+     metabase.upload.impl-test/set-local-infile!
+     metabase.util.files/create-dir-if-not-exists!
+     metabase.warehouse-schema.models.field-values/create-or-update-full-field-values!}}}}

.clj-kondo/macros/common.clj

@@ -1,5 +0,0 @@
-(ns macros.common
-  "Helpers for common Metabase macro shapes so we don't have to define the same macroexpansions over and over.")
-
-(defn ignore-unused [symb]
-  (vary-meta symb assoc :clj-kondo/ignore [:unused-binding]))

.clj-kondo/macros/metabase/api/card_test.clj

@@ -1,12 +0,0 @@
-(ns macros.metabase.api.card-test
-  (:require [macros.common]))
-
-(defmacro with-ordered-items
-  [collection model-and-name-syms & body]
-  `(let ~(into []
-               (comp (partition-all 2)
-                     (mapcat (fn [[model binding]]
-                               [(macros.common/ignore-unused binding) model])))
-               model-and-name-syms)
-     ~collection
-     ~@body))

.clj-kondo/macros/metabase/api/collection_test.clj

@@ -1,17 +0,0 @@
-(ns macros.metabase.api.collection-test
-  (:require [macros.common]))
-
-(defmacro with-collection-hierarchy! [bindings & body]
-  `(let [~(macros.common/ignore-unused 'a) nil
-         ~(macros.common/ignore-unused 'b) nil
-         ~(macros.common/ignore-unused 'c) nil
-         ~(macros.common/ignore-unused 'd) nil
-         ~(macros.common/ignore-unused 'e) nil
-         ~(macros.common/ignore-unused 'f) nil
-         ~(macros.common/ignore-unused 'g) nil]
-     ~bindings
-     ~@body))
-
-(defmacro with-some-children-of-collection! [collection-or-id-or-nil & body]
-  `(let [~(macros.common/ignore-unused '&ids) ~collection-or-id-or-nil]
-     ~@body))

.clj-kondo/macros/metabase/api/common.clj

@@ -1,7 +0,0 @@
-(ns macros.metabase.api.common)
-
-(defmacro define-routes
-  "Macro for api.common/define-routes"
-  [& args]
-  `(do (def ~'routes "docstring" nil)
-       ~@args))

.clj-kondo/macros/metabase/api/embed_test.clj

@@ -1,13 +0,0 @@
-(ns macros.metabase.api.embed-test)
-
-(defmacro with-embedding-enabled-and-temp-card-referencing!
-  [table-kw field-kw [card-binding] & body]
-  `(let [~card-binding [~table-kw ~field-kw]]
-     ~@body))
-
-(defmacro with-embedding-enabled-and-temp-dashcard-referencing!
-  [table-kw field-kw [dash-binding card-binding dashcard-binding] & body]
-  `(let [~dash-binding             [~table-kw ~field-kw]
-         ~(or card-binding '_)     nil
-         ~(or dashcard-binding '_) nil]
-     ~@body))

.clj-kondo/macros/metabase/api/public_test.clj

@@ -1,13 +0,0 @@
-(ns macros.metabase.api.public-test)
-
-(defmacro with-sharing-enabled-and-temp-card-referencing!
-  [table-kw field-kw [card-binding] & body]
-  `(let [~card-binding [~table-kw ~field-kw]]
-     ~@body))
-
-(defmacro with-sharing-enabled-and-temp-dashcard-referencing!
-  [table-kw field-kw [dash-binding card-binding dashcard-binding] & body]
-  `(let [~dash-binding             [~table-kw ~field-kw]
-         ~(or card-binding '_)     nil
-         ~(or dashcard-binding '_) nil]
-     ~@body))

.clj-kondo/macros/metabase/collections/api_test.clj

@@ -0,0 +1,24 @@
+(ns macros.metabase.collections.api-test)
+
+(defmacro with-collection-hierarchy! [bindings & body]
+  `(let [~'a nil
+         ~'b nil
+         ~'c nil
+         ~'d nil
+         ~'e nil
+         ~'f nil
+         ~'g nil]
+     ~'a
+     ~'b
+     ~'c
+     ~'d
+     ~'e
+     ~'f
+     ~'g
+     ~bindings
+     ~@body))
+
+(defmacro with-some-children-of-collection! [collection-or-id-or-nil & body]
+  `(let [~'&ids ~collection-or-id-or-nil]
+     ~'&ids
+     ~@body))

.clj-kondo/macros/metabase/embedding/api/embed_test.clj

@@ -0,0 +1,13 @@
+(ns macros.metabase.embedding.api.embed-test)
+
+(defmacro with-embedding-enabled-and-temp-card-referencing!
+  [table-kw field-kw [card-binding] & body]
+  `(let [~card-binding [~table-kw ~field-kw]]
+     ~@body))
+
+(defmacro with-embedding-enabled-and-temp-dashcard-referencing!
+  [table-kw field-kw [dash-binding card-binding dashcard-binding] & body]
+  `(let [~dash-binding             [~table-kw ~field-kw]
+         ~(or card-binding '_)     nil
+         ~(or dashcard-binding '_) nil]
+     ~@body))

.clj-kondo/macros/metabase/models/params/chain_filter_test.clj

@@ -1,4 +0,0 @@
-(ns macros.metabase.models.params.chain-filter-test)
-
-(defmacro chain-filter [& _]
-  `(metabase.models.params.chain-filter/chain-filter nil nil))

.clj-kondo/macros/metabase/models/query_analysis_test.clj

@@ -1,9 +0,0 @@
-(ns macros.metabase.models.query-analysis-test
-  (:require [macros.common]))
-
-(defmacro with-test-setup [& body]
-  `(let [~(macros.common/ignore-unused 'card-id)  1
-         ~(macros.common/ignore-unused 'table-id) 2
-         ~(macros.common/ignore-unused 'tax-id)   3
-         ~(macros.common/ignore-unused 'total-id) 4]
-     ~@body))

.clj-kondo/macros/metabase/models/user_test.clj

@@ -1,9 +0,0 @@
-(ns macros.metabase.models.user-test)
-
-(defmacro with-groups [bindings & body]
-  `(let ~(into []
-              (comp (partition-all 3)
-                    (mapcat (fn [[group-binding properties members]]
-                              [group-binding [properties members]])))
-              bindings)
-     ~@body))

.clj-kondo/macros/metabase/parameters/chain_filter_test.clj

@@ -0,0 +1,4 @@
+(ns macros.metabase.parameters.chain-filter-test)
+
+(defmacro chain-filter [& _]
+  `(metabase.parameters.chain-filter/chain-filter nil nil))

.clj-kondo/macros/metabase/public_sharing/api_test.clj

@@ -0,0 +1,13 @@
+(ns macros.metabase.public-sharing.api-test)
+
+(defmacro with-sharing-enabled-and-temp-card-referencing!
+  [table-kw field-kw [card-binding] & body]
+  `(let [~card-binding [~table-kw ~field-kw]]
+     ~@body))
+
+(defmacro with-sharing-enabled-and-temp-dashcard-referencing!
+  [table-kw field-kw [dash-binding card-binding dashcard-binding] & body]
+  `(let [~dash-binding             [~table-kw ~field-kw]
+         ~(or card-binding '_)     nil
+         ~(or dashcard-binding '_) nil]
+     ~@body))

.clj-kondo/macros/metabase/queries/api/card_test.clj

@@ -0,0 +1,13 @@
+(ns macros.metabase.queries.api.card-test)
+
+(defmacro with-ordered-items
+  [collection model-and-name-syms & body]
+  `(let ~(into []
+               (comp (partition-all 2)
+                     (mapcat (fn [[model binding]]
+                               [binding model])))
+               model-and-name-syms)
+     ~collection
+     ~@(->> (partition-all 2 model-and-name-syms)
+            (map second))
+     ~@body))

.clj-kondo/macros/metabase/query_analysis/models/query_analysis_test.clj

@@ -0,0 +1,12 @@
+(ns macros.metabase.query-analysis.models.query-analysis-test)
+
+(defmacro with-test-setup [& body]
+  `(let [~'card-id  1
+         ~'table-id 2
+         ~'tax-id   3
+         ~'total-id 4]
+     ~'card-id
+     ~'table-id
+     ~'tax-id
+     ~'total-id
+     ~@body))

.clj-kondo/macros/metabase/query_analysis/task/test_setup.clj

@@ -1,13 +1,18 @@
-(ns macros.metabase.query-analysis.task.test-setup
-  (:require [macros.common]))
+(ns macros.metabase.query-analysis.task.test-setup)
 
 (defmacro with-test-setup!
   "Set up the data required to test the Query Analysis related tasks"
   [& body]
-  `(let [~(macros.common/ignore-unused 'c1) 1
-         ~(macros.common/ignore-unused 'c2) 2
-         ~(macros.common/ignore-unused 'c3) 3
-         ~(macros.common/ignore-unused 'c4) 4
-         ~(macros.common/ignore-unused 'archived) 5
-         ~(macros.common/ignore-unused 'invalid) 6]
+  `(let [~'c1 1
+         ~'c2 2
+         ~'c3 3
+         ~'c4 4
+         ~'archived 5
+         ~'invalid 6]
+     ~'c1
+     ~'c2
+     ~'c3
+     ~'c4
+     ~'archived
+     ~'invalid
      ~@body))

.clj-kondo/macros/metabase/server/statistics_handler_test.clj

@@ -0,0 +1,9 @@
+(ns macros.metabase.server.statistics-handler-test)
+
+(defmacro with-server
+  [_ _ [connector chan-start-handle chan-finish-handle chan-done-request] & body]
+  `(let [~connector          nil
+         ~chan-start-handle  nil
+         ~chan-finish-handle nil
+         ~chan-done-request  nil]
+     ~@body))

.clj-kondo/macros/metabase/test/persistence.clj

@@ -1,5 +0,0 @@
-(ns macros.metabase.test.persistence)
-
-(defmacro with-persistence-enabled! [[persist-fn-sym] & body]
-  `(clojure.core/let [~persist-fn-sym (fn [])]
-     ~@body))

.clj-kondo/macros/metabase/users/models/user_test.clj

@@ -0,0 +1,9 @@
+(ns macros.metabase.users.models.user-test)
+
+(defmacro with-groups! [bindings & body]
+  `(let ~(into []
+               (comp (partition-all 3)
+                     (mapcat (fn [[group-binding properties members]]
+                               [group-binding [properties members]])))
+               bindings)
+     ~@body))

.clj-kondo/macros/metabase/xrays/related_test.clj

@@ -1,13 +1,20 @@
-(ns macros.metabase.xrays.related-test
-  (:require [macros.common]))
+(ns macros.metabase.xrays.related-test)
 
 (defmacro with-world [& body]
-  `(let [~(macros.common/ignore-unused 'collection-id) nil
-         ~(macros.common/ignore-unused 'metric-id-a) nil
-         ~(macros.common/ignore-unused 'metric-id-b) nil
-         ~(macros.common/ignore-unused 'segment-id-a) nil
-         ~(macros.common/ignore-unused 'segment-id-b) nil
-         ~(macros.common/ignore-unused 'card-id-a) nil
-         ~(macros.common/ignore-unused 'card-id-b) nil
-         ~(macros.common/ignore-unused 'card-id-c) nil]
+  `(let [~'collection-id nil
+         ~'metric-id-a nil
+         ~'metric-id-b nil
+         ~'segment-id-a nil
+         ~'segment-id-b nil
+         ~'card-id-a nil
+         ~'card-id-b nil
+         ~'card-id-c nil]
+     ~'collection-id
+     ~'metric-id-a
+     ~'metric-id-b
+     ~'segment-id-a
+     ~'segment-id-b
+     ~'card-id-a
+     ~'card-id-b
+     ~'card-id-c
      ~@body))

.clj-kondo/macros/metabase_enterprise/advanced_permissions/api/util_test.clj

@@ -1,6 +0,0 @@
-(ns macros.metabase-enterprise.advanced-permissions.api.util-test
-  (:require [macros.common]))
-
-(defmacro with-impersonations! [impersonations-and-attributes-map & body]
-  `(let [~(macros.common/ignore-unused '&group) ~impersonations-and-attributes-map]
-     ~@body))

.clj-kondo/macros/metabase_enterprise/database_routing/e2e_test.clj

@@ -0,0 +1,5 @@
+(ns macros.metabase-enterprise.database-routing.e2e-test)
+
+(defmacro with-temp-dbs! [bindings & body]
+  `(let [~@(interleave bindings (repeat nil))]
+     ~@body))

.clj-kondo/macros/metabase_enterprise/impersonation/util_test.clj

@@ -0,0 +1,6 @@
+(ns macros.metabase-enterprise.impersonation.util-test)
+
+(defmacro with-impersonations! [impersonations-and-attributes-map & body]
+  `(let [~'&group ~impersonations-and-attributes-map]
+     ~'&group
+     ~@body))

.clj-kondo/macros/metabase_enterprise/query_reference_validation/api_test.clj

@@ -1,12 +1,18 @@
-(ns macros.metabase-enterprise.query-reference-validation.api-test
-  (:require [macros.common]))
+(ns macros.metabase-enterprise.query-reference-validation.api-test)
 
 (defmacro with-test-setup! [& body]
-  `(let [~(macros.common/ignore-unused 'card-1) 1
-         ~(macros.common/ignore-unused 'card-2) 2
-         ~(macros.common/ignore-unused 'card-3) 3
-         ~(macros.common/ignore-unused 'card-4) 4
-         ~(macros.common/ignore-unused 'card-5) 5
-         ~(macros.common/ignore-unused 'coll-2) 100
-         ~(macros.common/ignore-unused 'coll-3) 200]
+  `(let [~'card-1 1
+         ~'card-2 2
+         ~'card-3 3
+         ~'card-4 4
+         ~'card-5 5
+         ~'coll-2 100
+         ~'coll-3 200]
+     ~'card-1
+     ~'card-2
+     ~'card-3
+     ~'card-4
+     ~'card-5
+     ~'coll-2
+     ~'coll-3
      ~@body))

.clj-kondo/macros/metabase_enterprise/sandbox/test_util.clj

@@ -1,6 +1,6 @@
-(ns macros.metabase-enterprise.sandbox.test-util
-  (:require [macros.common]))
+(ns macros.metabase-enterprise.sandbox.test-util)
 
 (defmacro with-gtaps! [gtaps-definition & body]
-  `(let [~(macros.common/ignore-unused '&group) ~gtaps-definition]
+  `(let [~'&group ~gtaps-definition]
+     ~'&group
      ~@body))

.clj-kondo/macros/metabase_enterprise/serialization/test_util.clj

@@ -1,59 +1,112 @@
-(ns macros.metabase-enterprise.serialization.test-util
-  (:require [macros.common]))
+(ns macros.metabase-enterprise.serialization.test-util)
 
 (defmacro with-world [& body]
-  `(let [~(macros.common/ignore-unused 'db-id)                        nil
-         ~(macros.common/ignore-unused 'table-id)                     nil
-         ~(macros.common/ignore-unused 'table)                        nil
-         ~(macros.common/ignore-unused 'table-id-categories)          nil
-         ~(macros.common/ignore-unused 'table-id-users)               nil
-         ~(macros.common/ignore-unused 'table-id-checkins)            nil
-         ~(macros.common/ignore-unused 'venues-pk-field-id)           nil
-         ~(macros.common/ignore-unused 'numeric-field-id)             nil
-         ~(macros.common/ignore-unused 'name-field-id)                nil
-         ~(macros.common/ignore-unused 'latitude-field-id)            nil
-         ~(macros.common/ignore-unused 'longitude-field-id)           nil
-         ~(macros.common/ignore-unused 'category-field-id)            nil
-         ~(macros.common/ignore-unused 'category-pk-field-id)         nil
-         ~(macros.common/ignore-unused 'date-field-id)                nil
-         ~(macros.common/ignore-unused 'users-pk-field-id)            nil
-         ~(macros.common/ignore-unused 'user-id-field-id)             nil
-         ~(macros.common/ignore-unused 'checkins->venues-field-id)    nil
-         ~(macros.common/ignore-unused 'last-login-field-id)          nil
-         ~(macros.common/ignore-unused 'collection-id)                nil
-         ~(macros.common/ignore-unused 'collection-id-nested)         nil
-         ~(macros.common/ignore-unused 'user-id-temp)                 nil
-         ~(macros.common/ignore-unused 'personal-collection-id)       nil
-         ~(macros.common/ignore-unused 'pc-felicia-nested-id)         nil
-         ~(macros.common/ignore-unused 'pc-nested-id)                 nil
-         ~(macros.common/ignore-unused 'pc-deeply-nested-id)          nil
-         ~(macros.common/ignore-unused 'metric-id)                    nil
-         ~(macros.common/ignore-unused 'segment-id)                   nil
-         ~(macros.common/ignore-unused 'dashboard-id)                 nil
-         ~(macros.common/ignore-unused 'root-dashboard-id)            nil
-         ~(macros.common/ignore-unused 'card-id)                      nil
-         ~(macros.common/ignore-unused 'card-arch-id)                 nil
-         ~(macros.common/ignore-unused 'card-id-root)                 nil
-         ~(macros.common/ignore-unused 'card-id-nested)               nil
-         ~(macros.common/ignore-unused 'card-id-nested-query)         nil
-         ~(macros.common/ignore-unused 'card-id-native-query)         nil
-         ~(macros.common/ignore-unused 'card-id-pivot-table)          nil
-         ~(macros.common/ignore-unused 'dashcard-id)                  nil
-         ~(macros.common/ignore-unused 'dashcard-top-level-click-id)  nil
-         ~(macros.common/ignore-unused 'dashcard-with-click-actions)  nil
-         ~(macros.common/ignore-unused 'dashcard-with-textbox-id)     nil
-         ~(macros.common/ignore-unused 'card-id-root-to-collection)   nil
-         ~(macros.common/ignore-unused 'card-id-collection-to-root)   nil
-         ~(macros.common/ignore-unused 'pulse-id)                     nil
-         ~(macros.common/ignore-unused 'pulsecard-root-id)            nil
-         ~(macros.common/ignore-unused 'pulsecard-collection-id)      nil
-         ~(macros.common/ignore-unused 'card-id-template-tags)        nil
-         ~(macros.common/ignore-unused 'card-id-filter-agg)           nil
-         ~(macros.common/ignore-unused 'card-id-temporal-unit)        nil
-         ~(macros.common/ignore-unused 'snippet-id)                   nil
-         ~(macros.common/ignore-unused 'snippet-collection-id)        nil
-         ~(macros.common/ignore-unused 'snippet-nested-collection-id) nil
-         ~(macros.common/ignore-unused 'nested-snippet-id)            nil
-         ~(macros.common/ignore-unused 'card-id-with-native-snippet)  nil
-         ~(macros.common/ignore-unused 'card-join-card-id)            nil]
+  `(let [~'db-id                        nil
+         ~'table-id                     nil
+         ~'table                        nil
+         ~'table-id-categories          nil
+         ~'table-id-users               nil
+         ~'table-id-checkins            nil
+         ~'venues-pk-field-id           nil
+         ~'numeric-field-id             nil
+         ~'name-field-id                nil
+         ~'latitude-field-id            nil
+         ~'longitude-field-id           nil
+         ~'category-field-id            nil
+         ~'category-pk-field-id         nil
+         ~'date-field-id                nil
+         ~'users-pk-field-id            nil
+         ~'user-id-field-id             nil
+         ~'checkins->venues-field-id    nil
+         ~'last-login-field-id          nil
+         ~'collection-id                nil
+         ~'collection-id-nested         nil
+         ~'user-id-temp                 nil
+         ~'personal-collection-id       nil
+         ~'pc-felicia-nested-id         nil
+         ~'pc-nested-id                 nil
+         ~'pc-deeply-nested-id          nil
+         ~'metric-id                    nil
+         ~'segment-id                   nil
+         ~'dashboard-id                 nil
+         ~'root-dashboard-id            nil
+         ~'card-id                      nil
+         ~'card-arch-id                 nil
+         ~'card-id-root                 nil
+         ~'card-id-nested               nil
+         ~'card-id-nested-query         nil
+         ~'card-id-native-query         nil
+         ~'card-id-pivot-table          nil
+         ~'dashcard-id                  nil
+         ~'dashcard-top-level-click-id  nil
+         ~'dashcard-with-click-actions  nil
+         ~'dashcard-with-textbox-id     nil
+         ~'card-id-root-to-collection   nil
+         ~'card-id-collection-to-root   nil
+         ~'pulse-id                     nil
+         ~'pulsecard-root-id            nil
+         ~'pulsecard-collection-id      nil
+         ~'card-id-template-tags        nil
+         ~'card-id-filter-agg           nil
+         ~'card-id-temporal-unit        nil
+         ~'snippet-id                   nil
+         ~'snippet-collection-id        nil
+         ~'snippet-nested-collection-id nil
+         ~'nested-snippet-id            nil
+         ~'card-id-with-native-snippet  nil
+         ~'card-join-card-id            nil]
+     ~'db-id
+     ~'table-id
+     ~'table
+     ~'table-id-categories
+     ~'table-id-users
+     ~'table-id-checkins
+     ~'venues-pk-field-id
+     ~'numeric-field-id
+     ~'name-field-id
+     ~'latitude-field-id
+     ~'longitude-field-id
+     ~'category-field-id
+     ~'category-pk-field-id
+     ~'date-field-id
+     ~'users-pk-field-id
+     ~'user-id-field-id
+     ~'checkins->venues-field-id
+     ~'last-login-field-id
+     ~'collection-id
+     ~'collection-id-nested
+     ~'user-id-temp
+     ~'personal-collection-id
+     ~'pc-felicia-nested-id
+     ~'pc-nested-id
+     ~'pc-deeply-nested-id
+     ~'metric-id
+     ~'segment-id
+     ~'dashboard-id
+     ~'root-dashboard-id
+     ~'card-id
+     ~'card-arch-id
+     ~'card-id-root
+     ~'card-id-nested
+     ~'card-id-nested-query
+     ~'card-id-native-query
+     ~'card-id-pivot-table
+     ~'dashcard-id
+     ~'dashcard-top-level-click-id
+     ~'dashcard-with-click-actions
+     ~'dashcard-with-textbox-id
+     ~'card-id-root-to-collection
+     ~'card-id-collection-to-root
+     ~'pulse-id
+     ~'pulsecard-root-id
+     ~'pulsecard-collection-id
+     ~'card-id-template-tags
+     ~'card-id-filter-agg
+     ~'card-id-temporal-unit
+     ~'snippet-id
+     ~'snippet-collection-id
+     ~'snippet-nested-collection-id
+     ~'nested-snippet-id
+     ~'card-id-with-native-snippet
+     ~'card-join-card-id
      ~@body))

.clj-kondo/src/hooks/clojure/core.clj

@@ -1,328 +0,0 @@
-(ns hooks.clojure.core
-  (:require
-   [clj-kondo.hooks-api :as hooks]
-   [clojure.string :as str]
-   [hooks.common]))
-
-;;; TODO -- seems silly to maintain different blacklists and whitelists here than we use for the deftest `^:parallel`
-;;; checker... those lists live in the Clj Kondo config file
-(def ^:private symbols-allowed-in-fns-not-ending-in-an-exclamation-point
-  '#{;; these toucan methods might actually set global values if it's used outside of a transaction,
-     ;; but since mt/with-temp runs in a transaction, so we'll ignore them in this case.
-     toucan2.core/delete!
-     toucan2.core/update!
-     toucan2.core/insert!
-     toucan2.core/insert-returning-instance!
-     toucan2.core/insert-returning-instances!
-     toucan2.core/insert-returning-pk!
-     toucan2.core/insert-returning-pks!
-     clojure.core.async/<!!
-     clojure.core.async/>!!
-     clojure.core.async/alts!!
-     clojure.core.async/close!
-     clojure.core.async/poll!
-     clojure.core.memoize/memo-clear!
-     clojure.core/conj!
-     clojure.core/persistent!
-     clojure.core/reset!
-     clojure.core/swap!
-     clojure.core/volatile!
-     clojure.core/vreset!
-     clojure.core/vswap!
-     clojure.java.jdbc/execute!
-     methodical.core/add-aux-method-with-unique-key!
-     methodical.core/remove-aux-method-with-unique-key!
-     next.jdbc/execute!
-
-     ;; Definitely thread safe
-     metabase.test.util.dynamic-redefs/patch-vars!
-
-     ;; TODO: most of these symbols shouldn't be here, we should go through them and
-     ;; find the functions/macros that use them and make sure their names end with !
-     ;; best way to do this is try remove each of these and rely on kondo output to find places where it's used
-     clojure.test/grant-collection-perms!
-     clojure.test/grant-collection-perms-fn!
-     clojure.test/grant-perms-fn!
-     clojure.test/purge-old-entries!
-     clojure.test/revoke-collection-perms!
-     clojure.test/save-results!
-     metabase-enterprise.advanced-permissions.models.permissions/update-db-download-permissions!
-     metabase-enterprise.internal-user/install-internal-user!
-     metabase-enterprise.sso.integrations.saml-test/call-with-login-attributes-cleared!
-     metabase.actions.actions/perform-action!
-     metabase.analytics.snowplow-test/fake-track-event-impl!
-     metabase.analytics.snowplow/track-event-impl!
-     metabase.api.public-test/add-card-to-dashboard!
-     metabase.channel.email-test/reset-inbox!
-     metabase.channel.email/send-email!
-     metabase.cmd.dump-to-h2/dump-to-h2!
-     metabase.cmd.load-from-h2/load-from-h2!
-     metabase.core.core/ensure-audit-db-installed!
-     metabase.db.schema-migrations-test.impl/run-migrations-in-range!
-     metabase.db.setup/migrate!
-     metabase.db.setup/setup-db!
-     metabase.db/migrate!
-     metabase.db/setup-db!
-     metabase.driver.mongo-test/create-database-from-row-maps!
-     metabase.driver.postgres-test/create-enums-db!
-     metabase.driver.postgres-test/drop-if-exists-and-create-db!
-     metabase.driver.sql-jdbc.execute/execute-statement!
-     metabase.models.action/insert!
-     metabase.models.collection.graph-test/clear-graph-revisions!
-     metabase.models.collection.graph-test/do-with-n-temp-users-with-personal-collections!
-     metabase.models.field-values/create-or-update-full-field-values!
-     metabase.models.model-index/add-values!
-     metabase.models.moderation-review/create-review!
-     metabase.models.on-demand-test/add-dashcard-with-parameter-mapping!
-     metabase.models.permissions/grant-application-permissions!
-     metabase.models.permissions/grant-collection-read-permissions!
-     metabase.models.permissions/grant-collection-readwrite-permissions!
-     metabase.models.permissions/grant-full-data-permissions!
-     metabase.models.permissions/grant-native-readwrite-permissions!
-     metabase.models.permissions/grant-permissions!
-     metabase.models.permissions/revoke-application-permissions!
-     metabase.models.permissions/revoke-data-perms!
-     metabase.models.permissions/update-data-perms-graph!
-     metabase.models.permissions/update-group-permissions!
-     metabase.models.persisted-info/ready-database!
-     metabase.models.setting-test/test-user-local-allowed-setting!
-     metabase.models.setting-test/test-user-local-only-setting!
-     metabase.models.setting.cache/restore-cache!
-     metabase.models.setting/set!
-     metabase.models.setting/validate-settings-formatting!
-     metabase.permissions.test-util/with-restored-perms!
-     metabase.pulse.send/send-notifications!
-     metabase.pulse.send/send-pulse!
-     metabase.query-processor.streaming.interface/begin!
-     metabase.query-processor.streaming.interface/finish!
-     metabase.query-processor.streaming.interface/write-row!
-     metabase.sample-data/try-to-extract-sample-database!
-     metabase.setup.core/create-token!
-     metabase.sync.core/sync-database!
-     metabase.sync.sync-metadata.fields.sync-metadata/update-field-metadata-if-needed!
-     metabase.sync.sync-metadata/sync-db-metadata!
-     metabase.sync.util-test/sync-database!
-     metabase.sync.util/store-sync-summary!
-     metabase.task.index-values/job-init!
-     metabase.task.persist-refresh/job-init!
-     metabase.task.persist-refresh/refresh-tables!
-     metabase.task.persist-refresh/schedule-persistence-for-database!
-     metabase.task/delete-task!
-     metabase.test.data.bigquery-cloud-sdk/execute!
-     metabase.test.data.impl/copy-db-tables-and-fields!
-     metabase.test.data.impl/get-or-create-database!
-     metabase.test.data.impl/get-or-create-default-dataset!
-     metabase.test.data.impl.get-or-create/set-test-db-permissions!
-     metabase.test.data.interface/create-db!
-     metabase.test.data.interface/destroy-db!
-     metabase.test.data.oracle/create-user!
-     metabase.test.data.oracle/drop-user!
-     metabase.test.data.sql-jdbc.load-data/make-insert!
-     metabase.test.data.users/clear-cached-session-tokens!
-     metabase.test.initialize/do-initialization!
-     metabase.test.initialize/initialize-if-needed!
-     metabase.test.integrations.ldap/start-ldap-server!
-     metabase.test.util.log/ensure-unique-logger!
-     metabase.test.util.log/set-ns-log-level!
-     metabase.test.util/do-with-temp-env-var-value!
-     metabase.test.util/restore-raw-setting!
-     metabase.test.util/upsert-raw-setting!
-     metabase.test/initialize-if-needed!
-     metabase.test/test-helpers-set-global-values!
-     metabase.test/with-temp-env-var-value!
-     metabase.upload-test/set-local-infile!
-     metabase.util.files/create-dir-if-not-exists!
-     metabase.util.ssh-test/start-mock-servers!
-     metabase.util.ssh-test/stop-mock-servers!})
-
-(defn- end-with-exclamation?
-  [s]
-  (str/ends-with? s "!"))
-
-(defn- explicitly-safe? [qualified-symbol]
-  (contains? symbols-allowed-in-fns-not-ending-in-an-exclamation-point qualified-symbol))
-
-(defn- explicitly-unsafe? [config qualified-symbol]
-  (contains? (get-in config [:linters :metabase/validate-deftest :parallel/unsafe]) qualified-symbol))
-
-(defn- unsafe? [config qualified-symbol]
-  (and (or (end-with-exclamation? qualified-symbol)
-           (explicitly-unsafe? config qualified-symbol))
-       (not (explicitly-safe? qualified-symbol))))
-
-(defn- non-thread-safe-form-should-end-with-exclamation*
-  [{[defn-or-defmacro form-name] :children, :as node} config]
-  (when-not (and (:string-value form-name)
-                 (end-with-exclamation? (:string-value form-name)))
-    (letfn [(walk [f form]
-              (f form)
-              (doseq [child (:children form)]
-                (walk f child)))
-            (check-node [form]
-              (when-let [qualified-symbol (hooks.common/node->qualified-symbol form)]
-                (when (unsafe? config qualified-symbol)
-                  (hooks/reg-finding!
-                   (assoc (meta form-name)
-                          :message (format "The name of this %s should end with `!` because it contains calls to non thread safe form `%s`. [:metabase/test-helpers-use-non-thread-safe-functions]"
-                                           (:string-value defn-or-defmacro) qualified-symbol)
-                          :type :metabase/test-helpers-use-non-thread-safe-functions)))))]
-      (walk check-node node))
-    node))
-
-(defn non-thread-safe-form-should-end-with-exclamation
-  "Used to ensure defn and defmacro in test namespace to have name ending with `!` if it's non-thread-safe.
-  A function or a macro can be defined as 'not thread safe' when their funciton name ends with a `!`.
-
-  Only used in tests to identify thread-safe/non-thread-safe test helpers. See #37126"
-  [{:keys [node cljc lang config]}]
-  (when (or (not cljc)
-            (= lang :clj))
-    (non-thread-safe-form-should-end-with-exclamation* node config))
-  {:node node})
-
-(comment
-  (require '[clj-kondo.core :as clj-kondo])
-  (def form (str '(defmacro a
-                    [x]
-                    `(fun-call x))))
-
-  (def form "(defmacro a
-           [x]
-           `(some! ~x))")
-
-  (def form "(defun f
-           [x]
-           (let [g! (fn [] 1)]
-           (g!)))")
-
-  (str (hooks/parse-string form))
-  (hooks/sexpr (hooks/parse-string form))
-
-  (binding [hooks/*reload* true]
-    (-> form
-        (with-in-str (clj-kondo/run! {:lint ["-"]}))
-        :findings))
-
-  (do (non-thread-safe-form-should-end-with-exclamation* (hooks/parse-string form)) nil))
-
-(defn- ns-form-node->require-node [ns-form-node]
-  (some (fn [node]
-          (when (and (hooks/list-node? node)
-                     (let [first-child (first (:children node))]
-                       (and (hooks/keyword-node? first-child)
-                            (= (hooks/sexpr first-child) :require))))
-            node))
-        (:children ns-form-node)))
-
-(defn- lint-require-shapes [ns-form-node]
-  (doseq [node (-> ns-form-node
-                   ns-form-node->require-node
-                   :children
-                   rest)]
-    (cond
-      (not (hooks/vector-node? node))
-      (hooks/reg-finding! (assoc (meta node)
-                                 :message "All :required namespaces should be wrapped in vectors [:metabase/require-shape-checker]"
-                                 :type    :metabase/require-shape-checker))
-
-      (hooks/vector-node? (second (:children node)))
-      (hooks/reg-finding! (assoc (meta node)
-                                 :message "Don't use prefix forms inside :require [:metabase/require-shape-checker]"
-                                 :type    :metabase/require-shape-checker)))))
-
-(defn- require-node->namespace-symb-nodes [require-node]
-  (let [[_ns & args] (:children require-node)]
-    (into []
-          ;; prefixed namespace forms are NOT SUPPORTED!!!!!!!!1
-          (keep (fn [node]
-                  (cond
-                    (hooks/vector-node? node)
-                    ;; propagate the metadata attached to this vector in case there's a `:clj-kondo/ignore` form.
-                    (let [symbol-node (first (:children node))]
-                      (hooks.common/merge-ignored-linters symbol-node require-node node))
-
-                    ;; this should also be dead code since we require requires to be vectors
-                    (hooks/token-node? node)
-                    (hooks.common/merge-ignored-linters node require-node)
-
-                    :else
-                    (printf "Don't know how to figure out what namespace is being required in %s\n" (pr-str node)))))
-          args)))
-
-(defn- ns-form-node->ns-symb [ns-form-node]
-  (some-> (some (fn [node]
-                  (when (and (hooks/token-node? node)
-                             (not= (hooks/sexpr node) 'ns))
-                    node))
-                (:children ns-form-node))
-          hooks/sexpr))
-
-(defn- module
-  "E.g.
-
-    (module 'metabase.qp.middleware.wow) => 'metabase.qp"
-  [ns-symb]
-  (some-> (re-find #"^metabase\.[^.]+" (str ns-symb)) symbol))
-
-(defn- ignored-namespace? [ns-symb config]
-  (some
-   (fn [pattern-str]
-     (re-find (re-pattern pattern-str) (str ns-symb)))
-   (:ignored-namespace-patterns config)))
-
-(defn- module-api-namespaces
-  "Set API namespaces for a given module. `:any` means you can use anything, there are no API namespaces for this
-  module (yet). If unspecified, the default is just the `<module>.core` namespace."
-  [module config]
-  (let [module-config (get-in config [:api-namespaces module])]
-    (cond
-      (= module-config :any)
-      nil
-
-      (set? module-config)
-      module-config
-
-      :else
-      #{(symbol (str module ".core"))})))
-
-(defn- lint-modules [ns-form-node config]
-  (let [ns-symb (ns-form-node->ns-symb ns-form-node)]
-    (when-not (ignored-namespace? ns-symb config)
-      (when-let [current-module (module ns-symb)]
-        (let [allowed-modules               (get-in config [:allowed-modules current-module])
-              required-namespace-symb-nodes (-> ns-form-node
-                                                ns-form-node->require-node
-                                                require-node->namespace-symb-nodes)]
-          (doseq [node  required-namespace-symb-nodes
-                  :when (not (contains? (hooks.common/ignored-linters node) :metabase/ns-module-checker))
-                  :let  [required-namespace (hooks/sexpr node)
-                         required-module    (module required-namespace)]
-                  ;; ignore stuff not in a module i.e. non-Metabase stuff.
-                  :when required-module
-                  :let  [in-current-module? (= required-module current-module)]
-                  :when (not in-current-module?)
-                  :let  [allowed-module?           (or (= allowed-modules :any)
-                                                       (contains? (set allowed-modules) required-module))
-                         module-api-namespaces     (module-api-namespaces required-module config)
-                         allowed-module-namespace? (or (empty? module-api-namespaces)
-                                                       (contains? module-api-namespaces required-namespace))]]
-            (when-let [error (cond
-                               (not allowed-module?)
-                               (format "Module %s should not be used in the %s module. [:metabase/ns-module-checker :allowed-modules %s]"
-                                       required-module
-                                       current-module
-                                       current-module)
-
-                               (not allowed-module-namespace?)
-                               (format "Namespace %s is not an allowed external API namespace for the %s module. [:metabase/ns-module-checker :api-namespaces %s]"
-                                       required-namespace
-                                       required-module
-                                       required-module))]
-              (hooks/reg-finding! (assoc (meta node)
-                                         :message error
-                                         :type    :metabase/ns-module-checker)))))))))
-
-(defn lint-ns [x]
-  (lint-require-shapes (:node x))
-  (lint-modules (:node x) (get-in x [:config :linters :metabase/ns-module-checker]))
-  x)

.clj-kondo/src/hooks/clojure/core/defmulti.clj

@@ -0,0 +1,52 @@
+(ns hooks.clojure.core.defmulti
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clojure.string :as str]
+   [hooks.common]))
+
+(defn- check-arglists [report-node arglists]
+  (letfn [(reg-bad-arglists! []
+            (hooks/reg-finding!
+             (assoc (meta report-node)
+                    :message ":arglists should be a quoted list of vectors [:metabase/check-defmulti-arglists]"
+                    :type :metabase/check-defmulti-arglists)))
+          (reg-bad-arg! []
+            (hooks/reg-finding!
+             (assoc (meta report-node)
+                    :message ":arglists should contain actual arg names, not underscore (unused) symbols [:metabase/check-defmulti-arglists]"
+                    :type    :metabase/check-defmulti-arglists)))
+          (underscore-arg? [arg]
+            (and (symbol? arg)
+                 (str/starts-with? arg "_")))
+          (check-arglist [arglist]
+            (cond
+              (not (vector? arglist))        (reg-bad-arglists!)
+              (some underscore-arg? arglist) (reg-bad-arg!)))]
+    (if-not (and (seq? arglists)
+                 (= (first arglists) 'quote)
+                 (seq (second arglists)))
+      (reg-bad-arglists!)
+      (let [[_quote arglists] arglists]
+        (doseq [arglist arglists]
+          (check-arglist arglist))))))
+
+(defn- defmulti-check-for-arglists-metadata
+  "Make sure a [[defmulti]] has an attribute map with `:arglists` metadata."
+  [node]
+  (let [[_defmulti _symb & args] (:children node)
+        [_docstring & args]      (if (hooks/string-node? (first args))
+                                   args
+                                   (cons nil args))
+        attr-map                 (when (hooks/map-node? (first args))
+                                   (first args))
+        arglists                 (some-> attr-map hooks/sexpr :arglists seq)]
+    (if-not (seq? arglists) ; should be a list or at least list-like
+      (hooks/reg-finding!
+       (assoc (meta node)
+              :message "All defmultis should have an attribute map with :arglists metadata. [:metabase/check-defmulti-arglists]"
+              :type    :metabase/check-defmulti-arglists))
+      (check-arglists attr-map arglists))))
+
+(defn lint-defmulti [x]
+  (defmulti-check-for-arglists-metadata (:node x))
+  x)

.clj-kondo/src/hooks/clojure/core/defn.clj

@@ -0,0 +1,76 @@
+(ns hooks.clojure.core.defn
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clojure.string :as str]
+   [hooks.common]))
+
+(defn- end-with-exclamation?
+  [s]
+  (str/ends-with? s "!"))
+
+(defn- explicitly-safe? [config qualified-symbol]
+  (contains? (get-in config [:linters :metabase/test-helpers-use-non-thread-safe-functions :explicitly-safe])
+             qualified-symbol))
+
+(defn- explicitly-unsafe? [config qualified-symbol]
+  (contains? (get-in config [:linters :metabase/validate-deftest :parallel/unsafe]) qualified-symbol))
+
+(defn- unsafe? [config qualified-symbol]
+  (and (or (end-with-exclamation? qualified-symbol)
+           (explicitly-unsafe? config qualified-symbol))
+       (not (explicitly-safe? config qualified-symbol))))
+
+(defn- non-thread-safe-form-should-end-with-exclamation*
+  [{[defn-or-defmacro form-name] :children, :as node} config]
+  (when-not (and (:string-value form-name)
+                 (end-with-exclamation? (:string-value form-name)))
+    (letfn [(walk [f form]
+              (f form)
+              (doseq [child (:children form)]
+                (walk f child)))
+            (check-node [form]
+              (when-let [qualified-symbol (hooks.common/node->qualified-symbol form)]
+                (when (unsafe? config qualified-symbol)
+                  (hooks/reg-finding!
+                   (assoc (meta form-name)
+                          :message (format "The name of this %s should end with `!` because it contains calls to non thread safe form `%s`. [:metabase/test-helpers-use-non-thread-safe-functions]"
+                                           (:string-value defn-or-defmacro) qualified-symbol)
+                          :type :metabase/test-helpers-use-non-thread-safe-functions)))))]
+      (walk check-node node))
+    node))
+
+(defn non-thread-safe-form-should-end-with-exclamation
+  "Used to ensure defn and defmacro in test namespace to have name ending with `!` if it's non-thread-safe.
+  A function or a macro can be defined as 'not thread safe' when their funciton name ends with a `!`.
+
+  Only used in tests to identify thread-safe/non-thread-safe test helpers. See #37126"
+  [{:keys [node cljc lang config]}]
+  (when (or (not cljc)
+            (= lang :clj))
+    (non-thread-safe-form-should-end-with-exclamation* node config))
+  {:node node})
+
+(comment
+  (require '[clj-kondo.core :as clj-kondo])
+  (def form (str '(defmacro a
+                    [x]
+                    `(fun-call x))))
+
+  (def form "(defmacro a
+           [x]
+           `(some! ~x))")
+
+  (def form "(defun f
+           [x]
+           (let [g! (fn [] 1)]
+           (g!)))")
+
+  (str (hooks/parse-string form))
+  (hooks/sexpr (hooks/parse-string form))
+
+  (binding [hooks/*reload* true]
+    (-> form
+        (with-in-str (clj-kondo/run! {:lint ["-"]}))
+        :findings))
+
+  (do (non-thread-safe-form-should-end-with-exclamation* (hooks/parse-string form)) nil))

.clj-kondo/src/hooks/clojure/core/ns.clj

@@ -0,0 +1,119 @@
+(ns hooks.clojure.core.ns
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clojure.string :as str]
+   [hooks.common]
+   [hooks.common.modules :as modules]))
+
+(defn- ns-form-node->require-node [ns-form-node]
+  (some (fn [node]
+          (when (and (hooks/list-node? node)
+                     (let [first-child (first (:children node))]
+                       (and (hooks/keyword-node? first-child)
+                            (= (hooks/sexpr first-child) :require))))
+            node))
+        (:children ns-form-node)))
+
+(defn- lint-require-shapes [ns-form-node]
+  (doseq [node (-> ns-form-node
+                   ns-form-node->require-node
+                   :children
+                   rest)]
+    (cond
+      (not (hooks/vector-node? node))
+      (hooks/reg-finding! (assoc (meta node)
+                                 :message "All :required namespaces should be wrapped in vectors [:metabase/require-shape-checker]"
+                                 :type    :metabase/require-shape-checker))
+
+      (hooks/vector-node? (second (:children node)))
+      (hooks/reg-finding! (assoc (meta node)
+                                 :message "Don't use prefix forms inside :require [:metabase/require-shape-checker]"
+                                 :type    :metabase/require-shape-checker)))))
+
+(defn- lint-requires-on-new-lines [ns-form-node]
+  (let [[require-keyword first-require] (-> ns-form-node
+                                            ns-form-node->require-node
+                                            :children)]
+    (when-let [require-keyword-line (:row (meta require-keyword))]
+      (when-let [first-require-line (:row (meta first-require))]
+        (when (= require-keyword-line first-require-line)
+          (hooks/reg-finding! (assoc (meta first-require)
+                                     :message "Put your requires on a newline from the :require keyword [:metabase/require-shape-checker]"
+                                     :type    :metabase/require-shape-checker)))))))
+
+(defn- require-node->namespace-symb-nodes [require-node]
+  (let [[_ns & args] (:children require-node)]
+    (into []
+          ;; prefixed namespace forms are NOT SUPPORTED!!!!!!!!1
+          (keep (fn [node]
+                  (cond
+                    (hooks/vector-node? node)
+                    ;; propagate the metadata attached to this vector in case there's a `:clj-kondo/ignore` form.
+                    (let [symbol-node (first (:children node))]
+                      (hooks.common/merge-ignored-linters symbol-node require-node node))
+
+                    ;; this should also be dead code since we require requires to be vectors
+                    (hooks/token-node? node)
+                    (hooks.common/merge-ignored-linters node require-node)
+
+                    :else
+                    (printf "Don't know how to figure out what namespace is being required in %s\n" (pr-str node)))))
+          args)))
+
+(defn- ns-form-node->ns-symb-node [ns-form-node]
+  (some (fn [node]
+          (when (and (hooks/token-node? node)
+                     (not= (hooks/sexpr node) 'ns))
+            node))
+        (:children ns-form-node)))
+
+(defn- ns-form-node->ns-symb [ns-form-node]
+  (some-> (ns-form-node->ns-symb-node ns-form-node)
+          hooks/sexpr))
+
+(defn- lint-modules [ns-form-node config]
+  (let [ns-symb (ns-form-node->ns-symb ns-form-node)]
+    (when-not (modules/ignored-namespace? config ns-symb)
+      (when-let [current-module (modules/module ns-symb)]
+        (let [required-namespace-symb-nodes (-> ns-form-node
+                                                ns-form-node->require-node
+                                                require-node->namespace-symb-nodes)]
+          (doseq [node  required-namespace-symb-nodes
+                  :when (not (contains? (hooks.common/ignored-linters node) :metabase/modules))
+                  :let  [required-namespace (hooks/sexpr node)
+                         error              (modules/usage-error config current-module required-namespace)]
+                  :when error]
+            (hooks/reg-finding! (assoc (meta node)
+                                       :message error
+                                       :type    :metabase/modules))))))))
+
+(defn- lint-namespace-name [ns-form-node]
+  (when-let [ns-symb-node (ns-form-node->ns-symb-node ns-form-node)]
+    (when-not (contains? (hooks.common/ignored-linters ns-symb-node) :metabase/namespace-name)
+      (let [parts (str/split (str (hooks/sexpr ns-symb-node)) #"\.")]
+        (when (and (<= (count parts) 2)
+                   (#{"metabase" "metabase-enterprise"} (first parts))
+                   ;; exclude test namespaces for now
+                   (not (str/ends-with? (last parts) "test")))
+          (hooks/reg-finding! (assoc (meta ns-symb-node)
+                                     :message "Metabase namespaces should have the form metabase[-enterprise].<module>.* [:metabase/namespace-name]"
+                                     :type    :metabase/namespace-name)))))))
+
+(defn lint-ns [x]
+  (doto (:node x)
+    lint-require-shapes
+    lint-requires-on-new-lines
+    (lint-modules (modules/config x))
+    lint-namespace-name)
+  x)
+
+(comment
+  (lint-ns
+   {:node (hooks/parse-string
+           (pr-str
+            '(ns hooks.clojure.core.ns
+               (:require
+                [clj-kondo.hooks-api :as hooks]
+                [clojure.string :as str]
+                [hooks.common]
+                [hooks.common.modules :as modules]))))}))

.clj-kondo/src/hooks/clojure/core/require.clj

@@ -0,0 +1,69 @@
+(ns hooks.clojure.core.require
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common.modules :as modules]))
+
+(defn- lint* [node current-ns config required-namespaces]
+  {:pre [(map? node)
+         (simple-symbol? current-ns)
+         (map? config)
+         (sequential? required-namespaces)
+         (every? simple-symbol? required-namespaces)]}
+  (when-not (modules/ignored-namespace? config current-ns)
+    ;; ignore namespaces outside of the module system
+    (when-let [current-module (modules/module current-ns)]
+      (doseq [required-namespace required-namespaces]
+        ;; ignore namespaces outside of the module system.
+        (when (modules/module required-namespace)
+          (when-let [error (modules/usage-error config current-module required-namespace)]
+            (hooks/reg-finding! (assoc (meta node)
+                                       :message error
+                                       :type    :metabase/modules))))))))
+
+(defn- unwrap-require [node]
+  (case (hooks/tag node)
+    ;; some.namespace of some.namespace/some-var
+    :token
+    (let [sexpr (hooks/sexpr node)]
+      (if (qualified-symbol? sexpr)
+        (symbol (namespace sexpr))
+        sexpr))
+
+    ;; (quote some.namespace)
+    :list
+    (let [[x y] (:children node)]
+      (when (and (hooks/token-node? x)
+                 (= (hooks/sexpr x) 'quote))
+        (recur y)))
+
+    ;; 'some.namespace
+    :quote
+    (recur (first (:children node)))
+
+    ;; something like [some.namespace :as whatever]
+    :vector
+    (recur (first (:children node)))))
+
+(comment
+  (unwrap-require (-> "(requiring-resolve 'metabase.notification.payload.execute/execute-dashboard)"
+                      hooks/parse-string
+                      :children
+                      second)))
+
+(defn- lint-require* [node current-ns config]
+  (let [[_require & args]   (:children node)
+        required-namespaces (keep unwrap-require args)]
+    (lint* node current-ns config required-namespaces)))
+
+(defn- lint-requiring-resolve* [node current-ns config]
+  (let [[_requiring-resolve symb-node] (:children node)
+        required-namespace             (unwrap-require symb-node)]
+    (lint* node current-ns config [required-namespace])))
+
+(defn lint-require [x]
+  (lint-require* (:node x) (:ns x) (modules/config x))
+  x)
+
+(defn lint-requiring-resolve [x]
+  (lint-requiring-resolve* (:node x) (:ns x) (modules/config x))
+  x)

.clj-kondo/src/hooks/common/modules.clj

@@ -0,0 +1,81 @@
+(ns hooks.common.modules)
+
+(defn ignored-namespace? [config ns-symb]
+  (some
+   (fn [pattern-str]
+     (re-find (re-pattern pattern-str) (str ns-symb)))
+   (:ignored-namespace-patterns config)))
+
+(defn config [{:keys [config], :as _hook-input}]
+  (merge (get-in config [:linters :metabase/modules])
+         (select-keys config [:metabase/modules])))
+
+(defn module
+  "E.g.
+
+    (module 'metabase.qp.middleware.wow) => 'qp
+    (module 'metabase-enterprise.whatever.core) => enterprise/whatever"
+  [ns-symb]
+  {:pre [(simple-symbol? ns-symb)]}
+  (or (some->> (re-find #"^metabase-enterprise\.([^.]+)" (str ns-symb))
+               second
+               (symbol "enterprise"))
+      (some-> (re-find #"^metabase\.([^.]+)" (str ns-symb))
+              second
+              symbol)))
+
+(defn module-api-namespaces
+  "Set of API namespace symbols for a given module. `:any` means you can use anything, there are no API namespaces for
+  this module (yet). If unspecified, the default is just the `<module>.core` namespace."
+  [config module]
+  (let [module-config (get-in config [:metabase/modules module :api])]
+    (cond
+      (= module-config :any)
+      nil
+
+      (set? module-config)
+      module-config
+
+      :else
+      (let [ns-prefix (if (= (namespace module) "enterprise")
+                        (str "metabase-enterprise." (name module))
+                        (name module))]
+        #{(symbol (str ns-prefix ".api"))
+          (symbol (str ns-prefix ".core"))
+          (symbol (str ns-prefix ".init"))}))))
+
+(defn allowed-modules
+  "Set of namespace symbols that `module` is allowed to use. `:any` means it's allowed to use anything."
+  [config module]
+  (get-in config [:metabase/modules module :uses]))
+
+(defn allowed-module? [config module required-module]
+  (let [allowed-modules (allowed-modules config module)]
+    (or (= allowed-modules :any)
+        (contains? (set allowed-modules) required-module))))
+
+(defn allowed-module-namespace? [config ns-symb]
+  (let [module                (module ns-symb)
+        module-api-namespaces (module-api-namespaces config module)]
+    (or (empty? module-api-namespaces)
+        (contains? module-api-namespaces ns-symb))))
+
+(defn usage-error
+  "Find usage errors when a `required-namespace` is required in the `current-module`. Returns a string describing the
+  error type if there is one, otherwise `nil` if there are no errors."
+  [config current-module required-namespace]
+  ;; ignore stuff not in a module i.e. non-Metabase stuff.
+  (when-let [required-module (module required-namespace)]
+    (when-not (= current-module required-module)
+      (cond
+        (not (allowed-module? config current-module required-module))
+        (format "Module %s should not be used in the %s module. [:metabase/modules %s :uses]"
+                required-module
+                current-module
+                current-module)
+
+        (not (allowed-module-namespace? config required-namespace))
+        (format "Namespace %s is not an allowed external API namespace for the %s module. [:metabase/modules %s :api]"
+                required-namespace
+                required-module
+                required-module)))))

.clj-kondo/src/hooks/metabase/api/automagic_dashboards_test.clj

@@ -1,28 +0,0 @@
-(ns hooks.metabase.api.automagic-dashboards-test
-  (:require [clj-kondo.hooks-api :as hooks]))
-
-(comment
-
-  (def input (hooks/parse-string
-              "(with-indexed-model! [{:keys [model model-index model-index-value]}
-                                     {:query :some-query}]
-                  :foo :bar :body)"))
-
-  (println (hooks/sexpr input))
-
-  (let [f (load-file ".clj-kondo/hooks/metabase/api/automagic_dashboards_test.clj")]
-    (f {:node input})))
-
-(defn with-indexed-model!
-  [{node :node}]
-  (let [[_macro-call binding-and-query-info & body] (:children node)
-        [binding query-info] (:children binding-and-query-info)
-        node* (hooks/list-node
-               [(hooks/token-node 'do-with-indexed-model!)
-                query-info
-                (hooks/list-node
-                 (list* (hooks/token-node 'fn)
-                        (hooks/vector-node [binding])
-                        body))])]
-    #_(println (hooks/sexpr node*))
-    {:node node*}))

.clj-kondo/src/hooks/metabase/api/common.clj

@@ -1,32 +0,0 @@
-(ns hooks.metabase.api.common
-  (:require
-   [clj-kondo.hooks-api :as api]
-   [clojure.string :as str]
-   [hooks.common]))
-
-(defn route-fn-name
-  "route fn hook"
-  [method route]
-  (let [route (if (vector? route) (first route) route)]
-    (-> (str (name method) route)
-        (str/replace #"/" "_")
-        symbol)))
-
-(defn defendpoint
-  [arg]
-  (letfn [(update-defendpoint [node]
-            (let [[_defendpoint method route & body] (:children node)]
-              (-> (api/list-node
-                   (list
-                    (api/token-node 'do)
-                    (-> (api/token-node (symbol "compojure.core" (str (api/sexpr method))))
-                        (with-meta (meta method)))
-                    (api/list-node
-                     (list*
-                      (api/token-node 'clojure.core/defn)
-                      (-> (api/token-node (route-fn-name (api/sexpr method) (api/sexpr route)))
-                          (with-meta (meta route)))
-                      body))))
-                  (with-meta (meta node))
-                  hooks.common/add-lsp-ignore-unused-public-var-metadata)))]
-    (update arg :node update-defendpoint)))

.clj-kondo/src/hooks/metabase/api/macros.clj

@@ -1,6 +1,7 @@
 (ns hooks.metabase.api.macros
   (:require
-   [clj-kondo.hooks-api :as api]))
+   [clj-kondo.hooks-api :as api]
+   [hooks.common]))
 
 (defn defendpoint
   [arg]
@@ -41,9 +42,15 @@
                      (list*
                       (api/token-node `let)
                       (api/vector-node (into []
-                                             (mapcat (fn [a-binding]
-                                                       [a-binding (api/token-node nil)]))
-                                             bindings))
+                                             cat
+                                             [(mapcat (fn [a-binding]
+                                                        [a-binding (api/map-node {})])
+                                                      (take 4 bindings))
+                                              (mapcat (fn [a-binding]
+                                                        [a-binding (api/list-node (list
+                                                                                   (api/token-node 'clojure.core/constantly)
+                                                                                   (api/token-node 'nil)))])
+                                                      (drop 4 bindings))]))
                       body))))
                   (with-meta (meta node)))))]
     (update arg :node update-defendpoint)))

.clj-kondo/src/hooks/metabase/api/search_test.clj

@@ -1,17 +0,0 @@
-(ns hooks.metabase.api.search-test
-  (:require [clj-kondo.hooks-api :as hooks]))
-
-(defn with-search-items-in-collection [{{[_ & args] :children, :as node} :node}]
-  ;; (println \newline)
-  ;; (clojure.pprint/pprint (hooks/sexpr node))
-  (let [[created-items-sym search-string & body] args
-        node*                                    (hooks/list-node
-                                                  (list*
-                                                   (hooks/token-node 'let)
-                                                   (hooks/vector-node
-                                                    [created-items-sym (hooks/token-node 'nil)])
-                                                   search-string
-                                                   body))]
-    ;; (println '=>)
-    ;; (clojure.pprint/pprint (hooks/sexpr node*))
-    {:node node*}))

.clj-kondo/src/hooks/metabase/app_db/schema_migrations_test/impl.clj

@@ -0,0 +1,14 @@
+(ns hooks.metabase.app-db.schema-migrations-test.impl
+  (:require [clj-kondo.hooks-api :as hooks]))
+
+(defn test-migrations
+  [{{[_ migration-range {[binding] :children} & body] :children} :node}]
+  (let [node* (hooks/list-node
+               (list*
+                (hooks/token-node `let)
+                (hooks/vector-node
+                 [binding (hooks/list-node (list (hooks/token-node `fn)
+                                                 (hooks/vector-node [(hooks/token-node '&) (hooks/token-node '_args)])))])
+                migration-range
+                body))]
+    {:node node*}))

.clj-kondo/src/hooks/metabase/db/schema_migrations_test/impl.clj

@@ -1,14 +0,0 @@
-(ns hooks.metabase.db.schema-migrations-test.impl
-  (:require [clj-kondo.hooks-api :as hooks]))
-
-(defn test-migrations
-  [{{[_ migration-range {[binding] :children} & body] :children} :node}]
-  (let [node* (hooks/list-node
-               (list*
-                (hooks/token-node `let)
-                (hooks/vector-node
-                 [binding (hooks/list-node (list (hooks/token-node `fn)
-                                                 (hooks/vector-node [(hooks/token-node '&) (hooks/token-node '_args)])))])
-                migration-range
-                body))]
-    {:node node*}))

.clj-kondo/src/hooks/metabase/model_persistence/test_util.clj

@@ -0,0 +1,19 @@
+(ns hooks.metabase.model-persistence.test-util
+  (:require
+   [clj-kondo.hooks-api :as hooks]))
+
+(defn with-persistence-enabled! [x]
+  (letfn [(update-node [node]
+            (let [[_symb bindings & body] (:children node)
+                  [fn-binding]            (:children bindings)]
+              (-> (hooks/list-node
+                   (list*
+                    (hooks/token-node `let)
+                    (hooks/vector-node
+                     [fn-binding (hooks/list-node
+                                  (list
+                                   (hooks/token-node `fn)
+                                   (hooks/vector-node [])))])
+                    body))
+                  (with-meta (meta node)))))]
+    (update x :node update-node)))

.clj-kondo/src/hooks/metabase/models/setting.clj

@@ -1,267 +0,0 @@
-(ns hooks.metabase.models.setting
-  (:require
-   [clj-kondo.hooks-api :as hooks]
-   [hooks.common :as common]))
-
-(def ^:private ignored-implicit-export?
-  '#{active-users-count
-     admin-email
-     analytics-uuid
-     anon-tracking-enabled
-     api-key
-     attachment-table-row-limit
-     audit-max-retention-days
-     bcc-enabled?
-     breakout-bin-width
-     check-for-updates
-     cloud-gateway-ips
-     config-from-file-sync-databases
-     custom-homepage
-     custom-homepage-dashboard
-     database-enable-actions
-     deprecation-notice-version
-     dismissed-custom-dashboard-toast
-     dismissed-onboarding-sidebar-link
-     email-configured?
-     email-from-address
-     email-from-name
-     email-reply-to
-     email-smtp-host
-     email-smtp-password
-     email-smtp-port
-     email-smtp-security
-     email-smtp-username
-     embedding-app-origin
-     embedding-secret-key
-     enable-password-login
-     enable-public-sharing
-     enable-query-caching
-     engines
-     enum-cardinality-threshold
-     follow-up-email-sent
-     google-auth-auto-create-accounts-domain
-     google-auth-client-id
-     google-auth-configured
-     google-auth-enabled
-     has-sample-database?
-     has-user-setup
-     help-link
-     help-link-custom-destination
-     instance-creation
-     is-hosted?
-     is-metabot-enabled
-     jdbc-data-warehouse-max-connection-pool-size
-     jdbc-data-warehouse-unreturned-connection-timeout-seconds
-     jwt-attribute-email
-     jwt-attribute-firstname
-     jwt-attribute-groups
-     jwt-attribute-lastname
-     jwt-configured
-     jwt-enabled
-     jwt-group-mappings
-     jwt-group-sync
-     jwt-identity-provider-uri
-     jwt-user-provisioning-enabled?
-     jwt-shared-secret
-     last-acknowledged-version
-     last-used-native-database-id
-     ldap-attribute-email
-     ldap-attribute-firstname
-     ldap-attribute-lastname
-     ldap-bind-dn
-     ldap-configured?
-     ldap-enabled
-     ldap-group-base
-     ldap-group-mappings
-     ldap-group-membership-filter
-     ldap-group-sync
-     ldap-host
-     ldap-password
-     ldap-port
-     ldap-user-provisioning-enabled?
-     ldap-security
-     ldap-sync-user-attributes
-     ldap-sync-user-attributes-blacklist
-     ldap-user-base
-     ldap-user-filter
-     load-analytics-content
-     map-tile-server-url
-     metabot-default-embedding-model
-     metabot-feedback-url
-     metabot-get-prompt-templates-url
-     metabot-prompt-generator-token-limit
-     multi-setting-read-only
-     notebook-native-preview-shown
-     notebook-native-preview-sidebar-width
-     notification-link-base-url
-     num-metabot-choices
-     openai-api-key
-     openai-available-models
-     openai-model
-     openai-organization
-     other-sso-enabled?
-     password-complexity
-     persist-models-enabled
-     persisted-model-refresh-cron-schedule
-     premium-embedding-token
-     prometheus-server-port
-     query-caching-max-kb
-     query-caching-max-ttl
-     query-caching-min-ttl
-     query-caching-ttl-ratio
-     redirect-all-requests-to-https
-     reset-token-ttl-hours
-     retired-setting
-     retry-initial-interval
-     retry-max-attempts
-     retry-max-interval-millis
-     retry-multiplier
-     retry-randomization-factor
-     saml-application-name
-     saml-attribute-email
-     saml-attribute-firstname
-     saml-attribute-group
-     saml-attribute-lastname
-     saml-configured
-     saml-enabled
-     saml-group-mappings
-     saml-group-sync
-     saml-identity-provider-certificate
-     saml-identity-provider-issuer
-     saml-identity-provider-uri
-     saml-keystore-alias
-     saml-keystore-password
-     saml-keystore-path
-     saml-user-provisioning-enabled?
-     send-email-on-first-login-from-new-device
-     send-new-sso-user-admin-email?
-     session-cookie-samesite
-     session-cookies
-     session-timeout
-     setup-token
-     show-database-syncing-modal
-     show-metabase-links
-     site-url
-     site-uuid
-     site-uuid-for-premium-features-token-checks
-     site-uuid-for-unsubscribing-url
-     site-uuid-for-version-info-fetching
-     slack-app-token
-     slack-cached-channels-and-usernames
-     slack-channels-and-usernames-last-updated
-     slack-files-channel
-     slack-token
-     slack-token-valid?
-     snowplow-available
-     snowplow-enabled
-     snowplow-url
-     sql-jdbc-fetch-size
-     ssh-heartbeat-interval-sec
-     ssl-certificate-public-key
-     startup-time-millis
-     token-features
-     token-status
-     toucan-name
-     trial-banner-dismissal-timestamp
-     uncached-setting
-     user-visibility
-     version
-     version-info
-     version-info-last-checked})
-
-(defn- defsetting-lint [node setting-name docstring options-list]
-  (let [anon-binding (common/with-macro-meta (hooks/token-node '_) node)
-        ;; (defn my-setting [] ...)
-        getter-node (-> (list
-                         (hooks/token-node 'defn)
-                         setting-name
-                         (hooks/string-node "Docstring.")
-                         (hooks/vector-node []))
-                        hooks/list-node
-                        (with-meta (meta node)))
-        ;; (defn my-setting! [_x] ...)
-        setter-node (-> (list
-                         (hooks/token-node 'defn)
-                         (with-meta
-                          (hooks/token-node (symbol (str (hooks/sexpr setting-name) \!)))
-                          (meta setting-name))
-                         (hooks/string-node "Docstring.")
-                         (hooks/vector-node [(hooks/token-node '_value-or-nil)]))
-                        hooks/list-node
-                        (with-meta (meta node))
-                        common/add-lsp-ignore-unused-public-var-metadata)]
-
-    (when (nil? (second (drop-while (comp not #{[:k :export?]} first) options-list)))
-      (when-not (contains? ignored-implicit-export? (:value setting-name))
-        (hooks/reg-finding! (assoc (meta node)
-                                   :message "Setting definition must provide an explicit value for :export? indicating whether the setting should be exported or not with serialization."
-                                   :type :metabase/defsetting-must-specify-export))))
-
-    {:node (-> (list
-                (hooks/token-node 'let)
-                 ;; include description and the options map so they can get validated as well.
-                (hooks/vector-node
-                 [anon-binding docstring
-                  anon-binding (hooks/map-node options-list)])
-                getter-node
-                setter-node)
-               hooks/list-node
-               (with-meta (meta node)))}))
-
-(defn defsetting
-  "Rewrite a [[metabase.models.defsetting]] form like
-
-    (defsetting my-setting \"Description\" :type :boolean)
-
-  as
-
-    (let [_ \"Description\"
-          _ {:type :boolean}]
-      (defn my-setting \"Docstring.\" [])
-      (defn my-setting! \"Docstring.\" [_value-or-nil]))
-
-  for linting purposes."
-  [{:keys [node]}]
-  (let [[setting-name docstring & options] (rest (:children node))]
-    (defsetting-lint node setting-name docstring options)))
-
-(defn define-multi-setting
-  "Rewrite a [[metabase.models.define-multi-setting]] form like
-
-    (defsetting my-setting \"Description\" :key :type :boolean)
-
-  as
-
-    (let [_ \"Description\"
-          _ {:type :boolean, :multi-thunk :key}]
-      (defn my-setting \"Docstring.\" [])
-      (defn my-setting! \"Docstring.\" [_value-or-nil]))
-
-  for linting purposes."
-  [{:keys [node]}]
-  (let [[setting-name docstring thunk & options] (rest (:children node))]
-    (defsetting-lint node setting-name docstring (concat options [(hooks/token-node :multi-thunk) thunk]))))
-
-(comment
-  (defn- defsetting* [form]
-    (hooks/sexpr
-     (:node
-      (defsetting
-        {:node
-         (hooks/parse-string
-          (with-out-str
-            #_{:clj-kondo/ignore [:unresolved-namespace]}
-            (clojure.pprint/pprint
-             form)))}))))
-
-  (defn x []
-    (defsetting*
-      '(defsetting active-users-count
-         (deferred-tru "Cached number of active users. Refresh every 5 minutes.")
-         :visibility :admin
-         :type       :integer
-         :default    0
-         :getter     (fn []
-                       (if-not ((requiring-resolve 'metabase.db/db-is-set-up?))
-                         0
-                         (cached-active-users-count)))))))

.clj-kondo/src/hooks/metabase/search/api_test.clj

@@ -0,0 +1,17 @@
+(ns hooks.metabase.search.api-test
+  (:require [clj-kondo.hooks-api :as hooks]))
+
+(defn with-search-items-in-collection [{{[_ & args] :children, :as node} :node}]
+  ;; (println \newline)
+  ;; (clojure.pprint/pprint (hooks/sexpr node))
+  (let [[created-items-sym search-string & body] args
+        node*                                    (hooks/list-node
+                                                  (list*
+                                                   (hooks/token-node 'let)
+                                                   (hooks/vector-node
+                                                    [created-items-sym (hooks/token-node 'nil)])
+                                                   search-string
+                                                   body))]
+    ;; (println '=>)
+    ;; (clojure.pprint/pprint (hooks/sexpr node*))
+    {:node node*}))

.clj-kondo/src/hooks/metabase/settings/models/setting.clj

@@ -0,0 +1,309 @@
+(ns hooks.metabase.settings.models.setting
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common :as common]))
+
+(defn lint-defsetting-namespace [node context]
+  (when-not (re-matches #"^metabase(?:-enterprise)?\.[^\.]+\.settings$" (name (:ns context)))
+    (hooks/reg-finding! (assoc (meta node)
+                               :message "All defsettings should live in metabase[-enterprise].<module>.settings namespaces"
+                               :type :metabase/defsetting-namespace))))
+
+;;; TODO -- move this into a Kondo config file in `.clj-kondo/config/`
+(def ^:private ignored-implicit-export?
+  '#{active-users-count
+     admin-email
+     analytics-uuid
+     anon-tracking-enabled
+     api-key
+     attachment-table-row-limit
+     audit-max-retention-days
+     bcc-enabled?
+     breakout-bin-width
+     check-for-updates
+     cloud-gateway-ips
+     config-from-file-sync-databases
+     custom-homepage
+     custom-homepage-dashboard
+     database-enable-actions
+     deprecation-notice-version
+     dismissed-custom-dashboard-toast
+     email-configured?
+     email-from-address
+     email-from-name
+     email-reply-to
+     email-smtp-host
+     email-smtp-password
+     email-smtp-port
+     email-smtp-security
+     email-smtp-username
+     embedding-app-origin
+     embedding-secret-key
+     enable-password-login
+     enable-public-sharing
+     enable-query-caching
+     engines
+     enum-cardinality-threshold
+     follow-up-email-sent
+     google-auth-auto-create-accounts-domain
+     google-auth-client-id
+     google-auth-configured
+     google-auth-enabled
+     has-sample-database?
+     has-user-setup
+     help-link
+     help-link-custom-destination
+     instance-creation
+     is-hosted?
+     is-metabot-enabled
+     jdbc-data-warehouse-max-connection-pool-size
+     jdbc-data-warehouse-unreturned-connection-timeout-seconds
+     jwt-attribute-email
+     jwt-attribute-firstname
+     jwt-attribute-groups
+     jwt-attribute-lastname
+     jwt-configured
+     jwt-enabled
+     jwt-group-mappings
+     jwt-group-sync
+     jwt-identity-provider-uri
+     jwt-user-provisioning-enabled?
+     jwt-shared-secret
+     last-acknowledged-version
+     last-used-native-database-id
+     ldap-attribute-email
+     ldap-attribute-firstname
+     ldap-attribute-lastname
+     ldap-bind-dn
+     ldap-configured?
+     ldap-enabled
+     ldap-group-base
+     ldap-group-mappings
+     ldap-group-membership-filter
+     ldap-group-sync
+     ldap-host
+     ldap-password
+     ldap-port
+     ldap-user-provisioning-enabled?
+     ldap-security
+     ldap-sync-user-attributes
+     ldap-sync-user-attributes-blacklist
+     ldap-user-base
+     ldap-user-filter
+     load-analytics-content
+     map-tile-server-url
+     metabot-default-embedding-model
+     metabot-feedback-url
+     metabot-get-prompt-templates-url
+     metabot-prompt-generator-token-limit
+     multi-setting-read-only
+     notebook-native-preview-shown
+     notebook-native-preview-sidebar-width
+     notification-link-base-url
+     num-metabot-choices
+     openai-api-key
+     openai-available-models
+     openai-model
+     openai-organization
+     other-sso-enabled?
+     password-complexity
+     persist-models-enabled
+     persisted-model-refresh-cron-schedule
+     premium-embedding-token
+     prometheus-server-port
+     query-caching-max-kb
+     query-caching-max-ttl
+     query-caching-min-ttl
+     query-caching-ttl-ratio
+     redirect-all-requests-to-https
+     reset-token-ttl-hours
+     retired-setting
+     retry-initial-interval
+     retry-max-attempts
+     retry-max-interval-millis
+     retry-multiplier
+     retry-randomization-factor
+     saml-application-name
+     saml-attribute-email
+     saml-attribute-firstname
+     saml-attribute-group
+     saml-attribute-lastname
+     saml-configured
+     saml-enabled
+     saml-group-mappings
+     saml-group-sync
+     saml-identity-provider-certificate
+     saml-identity-provider-issuer
+     saml-identity-provider-uri
+     saml-keystore-alias
+     saml-keystore-password
+     saml-keystore-path
+     saml-user-provisioning-enabled?
+     send-email-on-first-login-from-new-device
+     send-new-sso-user-admin-email?
+     session-cookie-samesite
+     session-cookies
+     session-timeout
+     setup-token
+     show-database-syncing-modal
+     show-metabase-links
+     site-url
+     site-uuid
+     site-uuid-for-premium-features-token-checks
+     site-uuid-for-unsubscribing-url
+     site-uuid-for-version-info-fetching
+     slack-app-token
+     slack-cached-channels-and-usernames
+     slack-channels-and-usernames-last-updated
+     slack-files-channel
+     slack-token
+     slack-token-valid?
+     snowplow-available
+     snowplow-enabled
+     snowplow-url
+     sql-jdbc-fetch-size
+     ssh-heartbeat-interval-sec
+     ssl-certificate-public-key
+     startup-time-millis
+     token-features
+     token-status
+     toucan-name
+     trial-banner-dismissal-timestamp
+     uncached-setting
+     user-visibility
+     version
+     version-info
+     version-info-last-checked})
+
+(defn- lint-defsetting-export [node]
+  (let [[_defsetting setting-name _docstring & options] (:children node)]
+    (when (nil? (second (drop-while (comp not #{[:k :export?]} first) options)))
+      (when-not (contains? ignored-implicit-export? (:value setting-name))
+        (hooks/reg-finding! (assoc (meta node)
+                                   :message "Setting definition must provide an explicit value for :export? indicating whether the setting should be exported or not with serialization."
+                                   :type :metabase/defsetting-must-specify-export))))))
+
+(defn- defsetting-replacement-node [node]
+  (let [[_defsetting setting-name docstring & options-list] (:children node)
+        anon-binding (common/with-macro-meta (hooks/token-node '_) node)
+        ;; (defn my-setting [] ...)
+        getter-node (-> (list
+                         (hooks/token-node 'defn)
+                         setting-name
+                         (hooks/string-node "Docstring.")
+                         (hooks/vector-node []))
+                        hooks/list-node
+                        (with-meta (meta node)))
+        ;; (defn my-setting! [_x] ...)
+        setter-node (-> (list
+                         (hooks/token-node 'defn)
+                         (with-meta
+                          (hooks/token-node (symbol (str (hooks/sexpr setting-name) \!)))
+                          (meta setting-name))
+                         (hooks/string-node "Docstring.")
+                         (hooks/vector-node [(hooks/token-node '_value-or-nil)]))
+                        hooks/list-node
+                        (with-meta (meta node))
+                        common/add-lsp-ignore-unused-public-var-metadata)]
+    (-> (hooks/list-node
+         (list
+          (hooks/token-node 'let)
+          ;; include description and the options map so they can get validated as well.
+          (hooks/vector-node
+           [anon-binding docstring
+            anon-binding (hooks/map-node options-list)])
+          (hooks/reg-keyword! (-> (hooks/keyword-node (keyword (hooks/sexpr setting-name)))
+                                  (with-meta (meta setting-name)))
+                              'metabase.settings.models.setting/defsetting)
+          getter-node
+          setter-node))
+        (with-meta (meta node)))))
+
+(defn defsetting
+  "Rewrite a [[metabase.models.defsetting]] form like
+
+    (defsetting my-setting \"Description\" :type :boolean)
+
+  as
+
+    (let [_ \"Description\"
+          _ {:type :boolean}]
+      (defn my-setting \"Docstring.\" [])
+      (defn my-setting! \"Docstring.\" [_value-or-nil]))
+
+  for linting purposes."
+  [{:keys [node], :as context}]
+  (lint-defsetting-namespace node context)
+  (lint-defsetting-export node)
+  (update context :node defsetting-replacement-node))
+
+(defn define-multi-setting-replacement-node [node]
+  (let [[defsetting setting-name docstring thunk & options] (:children node)]
+    (-> (hooks/list-node
+         (list*
+          defsetting
+          setting-name
+          docstring
+          (hooks/token-node :multi-thunk) thunk
+          options))
+        (with-meta (meta node))
+        defsetting-replacement-node)))
+
+(defn define-multi-setting
+  "Rewrite a [[metabase.models.define-multi-setting]] form like
+
+    (defsetting my-setting \"Description\" :key :type :boolean)
+
+  as
+
+    (let [_ \"Description\"
+          _ {:type :boolean, :multi-thunk :key}]
+      (defn my-setting \"Docstring.\" [])
+      (defn my-setting! \"Docstring.\" [_value-or-nil]))
+
+  for linting purposes."
+  [{:keys [node], :as context}]
+  (update context :node define-multi-setting-replacement-node))
+
+(defn define-multi-setting-impl
+  [context]
+  (letfn [(update-node [node]
+            (let [[_define-multi-setting-impl setting-name & more] (:children node)]
+              (-> (hooks/list-node
+                   (list*
+                    (hooks/token-node 'do)
+                    ;; For a qualified setting name like `oss-namespace/setting`, then leave the symbol as is, so the
+                    ;; usage of that namespace/var gets recorded. Otherwise for an unqualified name convert it to a
+                    ;; keyword so we don't get unresolved var errors.
+                    (if (and (hooks/token-node? setting-name)
+                             (qualified-symbol? (hooks/sexpr setting-name)))
+                      setting-name
+                      (-> (hooks/keyword-node (keyword (hooks/sexpr setting-name)))
+                          (with-meta (meta setting-name))))
+                    more))
+                  (with-meta (meta node)))))]
+    (update context :node update-node)))
+
+(comment
+  (defn- defsetting* [form]
+    (hooks/sexpr
+     (:node
+      (defsetting
+        {:node
+         (hooks/parse-string
+          (with-out-str
+            #_{:clj-kondo/ignore [:unresolved-namespace]}
+            (clojure.pprint/pprint
+             form)))}))))
+
+  (defn x []
+    (defsetting*
+      '(defsetting active-users-count
+         (deferred-tru "Cached number of active users. Refresh every 5 minutes.")
+         :visibility :admin
+         :type       :integer
+         :default    0
+         :getter     (fn []
+                       (if-not ((requiring-resolve 'metabase.app-db.core/db-is-set-up?))
+                         0
+                         (cached-active-users-count)))))))

.clj-kondo/src/hooks/metabase/test/data.clj

@@ -45,37 +45,35 @@
       :unqualified/unknown)))
 
 (defn dataset
-  [{{[_ dataset & body] :children} :node this-ns :ns}]
-  (let [noop (constantly nil)
-        body (case (dataset-type this-ns dataset)
-               ;; non-symbol, qualified symbols, and unqualified symbols from the current namespace/let-bound can all
-               ;; get converted from something like
-               ;;
-               ;;    (dataset whatever
-               ;;      ...)
-               ;;
-               ;; to
-               ;;
-               ;;    (let [_ whatever]
-               ;;      ...)
-               (:non-symbol :qualified :unqualified/local-def)
-               (list* (hooks/token-node 'let)
-                      (hooks/vector-node [(hooks/token-node '_) dataset])
-                      body)
+  [{{[_ dataset & body] :children, :as node} :node this-ns :ns}]
+  (let [node' (case (dataset-type this-ns dataset)
+                ;; non-symbol, qualified symbols, and unqualified symbols from the current namespace/let-bound can all
+                ;; get converted from something like
+                ;;
+                ;;    (dataset whatever
+                ;;      ...)
+                ;;
+                ;; to
+                ;;
+                ;;    (let [_ whatever]
+                ;;      ...)
+                (:non-symbol :qualified :unqualified/local-def)
+                (hooks/list-node
+                 (list*
+                  (hooks/token-node 'let)
+                  (hooks/vector-node [(hooks/token-node '_) dataset])
+                  body))
 
-               ;; for ones that came from the dataset defs namespace or ones whose origin is unknown, just ignore them
-               ;; and generate a `print` form:
-               ;;
-               ;;    (print ...)
-               ;;
-               ;; (this used to be a `do` form (which makes a lot more semantic sense), but that resulted in warnings
-               ;; about unused values
-               (:unqualified/from-dataset-defs-namespace :unqualified/unknown)
-               (list* (hooks/token-node noop)
-                      body))]
-    {:node (with-meta (hooks/list-node (with-meta body
-                                                  (meta dataset)))
-                      (meta dataset))}))
+                ;; for ones that came from the dataset defs namespace or ones whose origin is unknown, just ignore them
+                ;; and generate a form like
+                ;;
+                ;;    (do ...)
+                (:unqualified/from-dataset-defs-namespace :unqualified/unknown)
+                (hooks/list-node
+                 (list*
+                  (hooks/token-node `do)
+                  body)))]
+    {:node (with-meta node' (meta node))}))
 
 (defn- special-token-node?
   "Whether this node is one of the special symbols like `$field`."

.clj-kondo/src/hooks/metabase/test/gentest.clj

@@ -0,0 +1,14 @@
+(ns hooks.metabase.test.gentest
+  (:require
+   [clj-kondo.hooks-api :as hooks]))
+
+(defn iterate*
+  "(iterate {:as limit-spec} [s1 val1 & more] body-form body-form...)"
+  [{{:keys [children] :as node} :node :as orig}]
+  (let [[token limit-spec bindings & body-nodes] children
+        node* (-> (hooks/list-node
+                   (list token limit-spec
+                         (hooks/list-node (list* (hooks/token-node 'let) bindings
+                                                 body-nodes))))
+                  (with-meta (meta node)))]
+    (assoc orig :node node*)))

.clj-kondo/src/hooks/metabase/test/util/generators/jvm.clj

@@ -0,0 +1,15 @@
+(ns hooks.metabase.test.util.generators.jvm
+  (:require
+   [clj-kondo.hooks-api :as hooks]))
+
+(defn with-random-cards
+  "(with-random-cards <metadata-provider> <integer-count-value> & body-forms)"
+  [{{:keys [children] :as node} :node :as orig}]
+  (let [[token num-cards & body-nodes] children
+        node* (-> (hooks/list-node
+                   (list token num-cards
+                         (hooks/list-node (list* (hooks/token-node 'let)
+                                                 (hooks/vector-node [(hooks/token-node '&cards) (hooks/list-node ())])
+                                                 body-nodes))))
+                  (with-meta (meta node)))]
+    (assoc orig :node node*)))

.clj-kondo/src/hooks/metabase/util/i18n.clj

@@ -0,0 +1,74 @@
+(ns hooks.metabase.util.i18n
+  (:require
+   [clj-kondo.hooks-api :as api]
+   [clojure.string :as str]
+   [hooks.common]))
+
+(defn- valid-apostrophes?
+  "Returns true if `s` contains only doubled quotes (''') or complete placeholder-escaping quotes ('{...}'), false otherwise."
+  [s]
+  (loop [chars (seq s)]
+    (if (empty? chars)
+      true
+      (let [c (first chars)]
+        (if (= c \')
+          (cond
+              ;; Doubled quotes: skip both
+            (and (next chars) (= (second chars) \'))
+            (recur (nthrest chars 2))
+
+              ;; Placeholder escape. We allow for intentional escaping, like either '{0}` or '{{`, but not 'arbitrary
+              ;; strings' So basically, just require the *next* character to be a `{`, find the next single-quote, and
+              ;; continue on from there.
+              ;;
+              ;; Technically a string like "foo bar's happy but i'm not" is totally fine, but we'll say it's invalid
+              ;; because... that inner string literal is probably not what we actually want. So since we've never done
+              ;; this intentionally as far as I can tell, let's just remove the possibility to avoid ambiguity.
+            (= (second chars) \{)
+            (let [at-closing (drop-while #(not= \' %) (next chars))]
+              (if (seq at-closing)
+                (recur (next at-closing))
+                false))
+              ;; Unpaired single quote: invalid
+            :else
+            false)
+          (recur (rest chars)))))))
+
+(defn format-str-arg-node->str
+  [node]
+  (cond
+    ;; it's just a string literal
+    (api/string-node? node) (api/sexpr node)
+    ;; it's `(str "some" "strings")`
+    (and (api/list-node? node)
+         (= 'str (api/sexpr (first (:children node))))
+         (every? api/string-node? (rest (:children node))))
+    (apply str (map api/sexpr (rest (:children node))))
+
+    ;; it's something else, no good
+    :else
+    (do
+      (api/reg-finding!
+       (assoc (meta node)
+              :message "Must be a string literal or a call to `str` with string literal arguments."
+              :type :metabase/validate-string-or-str-args-to-i18n))
+      nil)))
+
+(defn strict-apostrophes
+  "Checks the node to make sure it's not a i18n call that will result in dropped apostrophes."
+  [{:keys [node]}]
+  (let [format-str-arg (second (:children node))
+        ;; `format-str-arg` must be either a `"string"` or `(str "a call " "to" "str")` (to allow for splitting long
+        ;; strings into shorter lines)
+        format-str (format-str-arg-node->str format-str-arg)]
+    (when-not (valid-apostrophes? format-str)
+      (api/reg-finding!
+       (assoc (meta node)
+              :message "Format string contains invalid single quote usage. Use '' for literals or '{...}' for escaping."
+              :type :metabase/validate-escaped-single-quotes-in-i18n))))
+  {:node node})
+
+(def tru strict-apostrophes)
+(def trs strict-apostrophes)
+(def deferred-tru strict-apostrophes)
+(def deferred-trs strict-apostrophes)

.clj-kondo/src/hooks/metabase/xrays/api/automagic_dashboards_test.clj

@@ -0,0 +1,29 @@
+(ns hooks.metabase.xrays.api.automagic-dashboards-test
+  (:require
+   [clj-kondo.hooks-api :as hooks]))
+
+(comment
+
+  (def input (hooks/parse-string
+              "(with-indexed-model! [{:keys [model model-index model-index-value]}
+                                     {:query :some-query}]
+                  :foo :bar :body)"))
+
+  (println (hooks/sexpr input))
+
+  (let [f (load-file ".clj-kondo/hooks/metabase/xrays/api/automagic_dashboards_test.clj")]
+    (f {:node input})))
+
+(defn with-indexed-model!
+  [{node :node}]
+  (let [[_macro-call binding-and-query-info & body] (:children node)
+        [binding query-info] (:children binding-and-query-info)
+        node* (hooks/list-node
+               [(hooks/token-node 'do-with-indexed-model!)
+                query-info
+                (hooks/list-node
+                 (list* (hooks/token-node 'fn)
+                        (hooks/vector-node [binding])
+                        body))])]
+    #_(println (hooks/sexpr node*))
+    {:node node*}))

.clj-kondo/test/hooks/clojure/core/defmulti_test.clj

@@ -0,0 +1,63 @@
+(ns hooks.clojure.core.defmulti-test
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clj-kondo.impl.utils]
+   [clojure.test :refer :all]
+   [hooks.clojure.core.defmulti]))
+
+(defn- lint-defmulti [form]
+  (binding [clj-kondo.impl.utils/*ctx* {:config     {:linters {:metabase/check-defmulti-arglists {:level :warning}}}
+                                        :ignores    (atom nil)
+                                        :findings   (atom [])
+                                        :namespaces (atom {})}]
+    (hooks.clojure.core.defmulti/lint-defmulti {:node (hooks/parse-string (pr-str form))})
+    @(:findings clj-kondo.impl.utils/*ctx*)))
+
+(deftest ^:parallel defmulti-missing-arglists-test
+  (testing "missing arglists"
+    (is (=? [{:message "All defmultis should have an attribute map with :arglists metadata. [:metabase/check-defmulti-arglists]"}]
+            (lint-defmulti '(defmulti expand-visualization
+                              (fn [card _ _]
+                                (-> card :visualization first))))))))
+
+(deftest ^:parallel defmulti-invalid-arglists-test
+  (testing "invalid arglists"
+    (are [form] (=? [{:message ":arglists should be a quoted list of vectors [:metabase/check-defmulti-arglists]"}]
+                    (lint-defmulti form))
+      '(defmulti expand-visualization
+         {:arglists '()}
+         (fn [card _ _]
+           (-> card :visualization first)))
+      '(defmulti expand-visualization
+         {:arglists ([a])}              ; unquoted
+         (fn [card _ _]
+           (-> card :visualization first)))
+      '(defmulti expand-visualization
+         {:arglists '[(a)]}
+         (fn [card _ _]
+           (-> card :visualization first)))
+      '(defmulti expand-visualization
+         {:arglists '((a))}
+         (fn [card _ _]
+           (-> card :visualization first))))))
+
+(deftest ^:parallel defmulti-arglists-with-underscore-args-test
+  (testing "arglists, but some symbols are _"
+    (are [form] (=? [{:message ":arglists should contain actual arg names, not underscore (unused) symbols [:metabase/check-defmulti-arglists]"}]
+                    (lint-defmulti form))
+      '(defmulti expand-visualization
+         {:arglists '([card _ _])}
+         (fn [card _ _]
+           (-> card :visualization first)))
+      '(defmulti expand-visualization
+         {:arglists '([card _bad _arg])}
+         (fn [card _ _]
+           (-> card :visualization first))))))
+
+(deftest ^:parallel defmulti-arglists-ok-test
+  (testing "good"
+    (is (= []
+           (lint-defmulti '(defmulti expand-visualization
+                             {:arglists '([card x y])}
+                             (fn [card _ _]
+                               (-> card :visualization first))))))))

.clj-kondo/test/hooks/clojure/core/ns_test.clj

@@ -0,0 +1,76 @@
+(ns hooks.clojure.core.ns-test
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clj-kondo.impl.utils]
+   [clojure.test :refer :all]
+   [hooks.clojure.core.ns]))
+
+(defn- lint-ns [form config]
+  (binding [clj-kondo.impl.utils/*ctx* {:config     config
+                                        :ignores    (atom nil)
+                                        :findings   (atom [])
+                                        :namespaces (atom {})}]
+    (hooks.clojure.core.ns/lint-ns {:node   (hooks/parse-string
+                                             (binding [*print-meta* true]
+                                               (pr-str form)))
+                                    :config config})
+    @(:findings clj-kondo.impl.utils/*ctx*)))
+
+(defn- lint-modules [form config]
+  (lint-ns form (assoc-in config [:linters :metabase/modules :level] :warning)))
+
+(deftest ^:parallel module-checker-allowed-modules-test
+  (are [task-namespace] (=? [{:message "Module task should not be used in the api module. [:metabase/modules api :uses]"
+                              :type :metabase/modules}]
+                            (lint-modules
+                             '(ns metabase.api.search
+                                (:require
+                                 [metabase.request.core :as request]
+                                 [task-namespace :as task]))
+                             '{:metabase/modules {api     {:uses #{request}}
+                                                  request {:api #{metabase.request.core}}}}))
+    metabase.task
+    metabase.task.core))
+
+(deftest ^:parallel module-checker-api-namespaces-test
+  (is (=? [{:message "Namespace metabase.search.config is not an allowed external API namespace for the search module. [:metabase/modules search :api]"
+            :type :metabase/modules}]
+          (lint-modules
+           '(ns metabase.api.search
+              (:require
+               [metabase.search.config :as search.config]
+               [metabase.search.core :as search]))
+           '{:metabase/modules {api    {:uses #{search}}
+                                search {:api  #{metabase.search.core}}}}))))
+
+(deftest ^:parallel module-checker-api-namespaces-ignore-test
+  (is (empty? (lint-modules
+               '(ns metabase.api.search
+                  (:require
+                   ^{:clj-kondo/ignore [:metabase/modules]}
+                   [metabase.search.config :as search.config]
+                   [metabase.search.core :as search]))
+               '{:metabase/modules {api    {:uses #{search}}
+                                    search {:api #{metabase.search.core}}}}))))
+
+(deftest ^:parallel module-checker-enterprise-test
+  (is (=? [{:message "Module search should not be used in the enterprise/search module. [:metabase/modules enterprise/search :uses]"
+            :type :metabase/modules}]
+          (lint-modules
+           '(ns metabase-enterprise.search.core
+              (:require
+               [metabase.search.core :as search]))
+           '{:metabase/modules {search {:api #{metabase.search.core}}}}))))
+
+(deftest ^:parallel require-newlines-test
+  (binding [clj-kondo.impl.utils/*ctx* {:config     {:linters {:metabase/require-shape-checker {:level :warnings}}}
+                                        :ignores    (atom nil)
+                                        :findings   (atom [])
+                                        :namespaces (atom {})}]
+    (hooks.clojure.core.ns/lint-ns {:node (hooks/parse-string "
+(ns metabase.task.cache
+  (:require [metabase.task.bunny]
+            [metabase.task.rabbit]))")})
+    (is (=? [{:message "Put your requires on a newline from the :require keyword [:metabase/require-shape-checker]",
+              :type    :metabase/require-shape-checker}]
+            @(:findings clj-kondo.impl.utils/*ctx*)))))

.clj-kondo/test/hooks/clojure/core_test.clj

@@ -1,54 +0,0 @@
-(ns hooks.clojure.core-test
-  (:require
-   [clj-kondo.hooks-api :as hooks]
-   [clojure.test :refer :all]
-   [hooks.clojure.core]))
-
-(deftest module-checker-allowed-modules-test
-  (let [findings (atom [])]
-    (with-redefs [hooks/reg-finding! (fn [node]
-                                       (swap! findings conj node))]
-      (hooks.clojure.core/lint-ns
-       {:node     (hooks/parse-string "
-(ns metabase.api.search
-  (:require
-   [metabase.request.core :as request]
-   [metabase.task :as task]))")
-        :config '{:linters {:metabase/ns-module-checker {:allowed-modules {metabase.api #{metabase.request}}
-                                                         :api-namespaces  {metabase.request #{metabase.request.core}}}}}})
-      (is (=? [{:message (str "Module metabase.task should not be used in the metabase.api module."
-                              " [:metabase/ns-module-checker :allowed-modules metabase.api]")
-                :type :metabase/ns-module-checker}]
-              @findings)))))
-
-(deftest module-checker-api-namespaces-test
-  (let [findings (atom [])]
-    (with-redefs [hooks/reg-finding! (fn [node]
-                                       (swap! findings conj node))]
-      (hooks.clojure.core/lint-ns
-       {:node     (hooks/parse-string "
-(ns metabase.api.search
-  (:require
-   [metabase.search.config :as search.config]
-   [metabase.search.core :as search]))")
-        :config '{:linters {:metabase/ns-module-checker {:allowed-modules {metabase.api #{metabase.search}}
-                                                         :api-namespaces  {metabase.search #{metabase.search.core}}}}}})
-      (is (=? [{:message (str "Namespace metabase.search.config is not an allowed external API namespace for the"
-                              " metabase.search module. [:metabase/ns-module-checker :api-namespaces metabase.search]")
-                :type :metabase/ns-module-checker}]
-              @findings)))))
-
-(deftest module-checker-api-namespaces-ignore-test
-  (let [findings (atom [])]
-    (with-redefs [hooks/reg-finding! (fn [node]
-                                       (swap! findings conj node))]
-      (hooks.clojure.core/lint-ns
-       {:node     (hooks/parse-string "
-(ns metabase.api.search
-  (:require
-   ^{:clj-kondo/ignore [:metabase/ns-module-checker]}
-   [metabase.search.config :as search.config]
-   [metabase.search.core :as search]))")
-        :config '{:linters {:metabase/ns-module-checker {:allowed-modules {metabase.api #{metabase.search}}
-                                                         :api-namespaces  {metabase.search #{metabase.search.core}}}}}})
-      (is (empty? @findings)))))

.clj-kondo/test/hooks/common/modules_test.clj

@@ -0,0 +1,10 @@
+(ns hooks.common.modules-test
+  (:require
+   [clojure.test :refer :all]
+   [hooks.common.modules]))
+
+(deftest ^:parallel module-test
+  (are [symb expected] (= expected
+                          (hooks.common.modules/module symb))
+    'metabase.qp.middleware.wow        'qp
+    'metabase-enterprise.whatever.core 'enterprise/whatever))

.clj-kondo/test/hooks/common_test.clj

@@ -6,16 +6,16 @@
    [hooks.common]))
 
 (deftest ^:parallel ignored-linters-test
-  (doseq [ignored [":metabase/ns-module-checker"
-                   "[:metabase/ns-module-checker]"
-                   "(:metabase/ns-module-checker)"]
+  (doseq [ignored [":metabase/modules"
+                   "[:metabase/modules]"
+                   "(:metabase/modules)"]
           prefix ["#_"
                   "^"]
           :let [s (format "%s{:clj-kondo/ignore %s} [metabase.search.config :as search.config]"
                           prefix
                           ignored)]]
     (testing (pr-str s)
-      (is (= #{:metabase/ns-module-checker}
+      (is (= #{:metabase/modules}
              (hooks.common/ignored-linters (api/parse-string s)))))))
 
 (deftest ^:parallel merge-ignored-linters-test

.clj-kondo/test/hooks/metabase/api/common_test.clj

@@ -1,35 +0,0 @@
-(ns hooks.metabase.api.common-test
-  (:require
-   [clj-kondo.hooks-api :as api]
-   [clojure.test :refer :all]
-   [hooks.metabase.api.common]))
-
-(deftest ^:parallel defendpoint-test
-  (is (= '(do
-            compojure.core/POST
-            (clojure.core/defn
-              POST_:id_copy
-              "Copy a `Card`, with the new name 'Copy of _name_'"
-              [id]
-              {id [:maybe ms/PositiveInt]}
-              (let [orig-card (api/read-check Card id)
-                    new-name (str (trs "Copy of ") (:name orig-card))
-                    new-card (assoc orig-card :name new-name)]
-                (-> (card/create-card! new-card @api/*current-user*)
-                    hydrate-card-details
-                    (assoc :last-edit-info (last-edit/edit-information-for-user @api/*current-user*))))))
-         (-> {:node (-> '(api/defendpoint POST "/:id/copy"
-                           "Copy a `Card`, with the new name 'Copy of _name_'"
-                           [id]
-                           {id [:maybe ms/PositiveInt]}
-                           (let [orig-card (api/read-check Card id)
-                                 new-name  (str (trs "Copy of ") (:name orig-card))
-                                 new-card  (assoc orig-card :name new-name)]
-                             (-> (card/create-card! new-card @api/*current-user*)
-                                 hydrate-card-details
-                                 (assoc :last-edit-info (last-edit/edit-information-for-user @api/*current-user*)))))
-                        pr-str
-                        api/parse-string)}
-             hooks.metabase.api.common/defendpoint
-             :node
-             api/sexpr))))

.clj-kondo/test/hooks/metabase/api/macros_test.clj

@@ -4,32 +4,68 @@
    [clojure.test :refer :all]
    [hooks.metabase.api.macros]))
 
+(defn- is-valid-node [x]
+  (is (api/node? x))
+  (doseq [child (:children x)]
+    (is-valid-node child)))
+
 (deftest ^:parallel defendpoint-test
-  (let [form '(api.macros/defendpoint :post "/" :- [:map [:collection_id :int]]
-                "Create a new [[Timeline]]."
-                [_route-params
-                 _query-params
-                 {:keys [icon], collection-id :collection_id, :as body} :- [:map
-                                                                            [:name    ms/NonBlankString]
-                                                                            [:default {:optional true} [:maybe :boolean]]]]
-                (body icon)
-                (body collection-id))
-        node (-> form pr-str api/parse-string)]
-    (is (= '(do
-              api.macros/defendpoint
-              :post
-              "/"
-              (do
-                [:map [:collection_id :int]]
-                [:map
-                 [:name    ms/NonBlankString]
-                 [:default {:optional true} [:maybe :boolean]]])
-              (clojure.core/let [_route-params nil
-                                 _query-params nil
-                                 {:keys [icon], collection-id :collection_id, :as body} nil]
-                (body icon)
-                (body collection-id)))
-           (-> {:node node}
-               hooks.metabase.api.macros/defendpoint
-               :node
-               api/sexpr)))))
+  (letfn [(defendpoint [form]
+            (let [node (-> form pr-str api/parse-string)]
+              (is-valid-node node)
+              (-> {:node node}
+                  hooks.metabase.api.macros/defendpoint
+                  :node
+                  api/sexpr)))]
+    (are [form expected] (= expected
+                            (defendpoint form))
+      '(api.macros/defendpoint :post "/" :- [:map [:collection_id :int]]
+         "Create a new [[Timeline]]."
+         [_route-params
+          _query-params
+          {:keys [icon], collection-id :collection_id, :as body} :- [:map
+                                                                     [:name    ms/NonBlankString]
+                                                                     [:default {:optional true} [:maybe :boolean]]]]
+         (body icon)
+         (body collection-id))
+      '(do
+         api.macros/defendpoint
+         :post
+         "/"
+         (do
+           [:map [:collection_id :int]]
+           [:map
+            [:name    ms/NonBlankString]
+            [:default {:optional true} [:maybe :boolean]]])
+         (clojure.core/let [_route-params {}
+                            _query-params {}
+                            {:keys [icon], collection-id :collection_id, :as body} {}]
+           (body icon)
+           (body collection-id)))
+
+      '(api.macros/defendpoint :post "/"
+         [_route-params
+          _query-params
+          body
+          request
+          respond
+          raise]
+         (try
+           (respond :x)
+           (catch Throwable e
+             (raise e))))
+      '(do
+         api.macros/defendpoint
+         :post
+         "/"
+         (do)
+         (clojure.core/let [_route-params {}
+                            _query-params {}
+                            body          {}
+                            request       {}
+                            respond       (clojure.core/constantly nil)
+                            raise         (clojure.core/constantly nil)]
+           (try
+             (respond :x)
+             (catch Throwable e
+               (raise e))))))))

.clj-kondo/test/hooks/metabase/model_persistence/test_util_test.clj

@@ -0,0 +1,19 @@
+(ns hooks.metabase.model-persistence.test-util-test
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clojure.test :refer :all]
+   [hooks.metabase.model-persistence.test-util]))
+
+(deftest ^:parallel with-persistence-enabled-test
+  (is (= '(clojure.core/let [persist-models! (clojure.core/fn [])]
+            (persist-models!)
+            :wow)
+         (as-> '(mt/with-persistence-enabled! [persist-models!]
+                  (persist-models!)
+                  :wow) <>
+           (pr-str <>)
+           (hooks/parse-string <>)
+           {:node <>}
+           (hooks.metabase.model-persistence.test-util/with-persistence-enabled! <>)
+           (:node <>)
+           (hooks/sexpr <>)))))

.clj-kondo/test/hooks/metabase/settings/models/setting_test.clj

@@ -0,0 +1,34 @@
+(ns hooks.metabase.settings.models.setting-test
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clojure.test :refer :all]
+   [hooks.metabase.settings.models.setting]))
+
+#_{:clj-kondo/ignore [:metabase/validate-deftest]}
+(deftest ^:parallel defsetting-test
+  (let [node (-> '(defsetting active-users-count
+                    (deferred-tru "Cached number of active users. Refreshed every 5 minutes.")
+                    :visibility :admin
+                    :type       :integer
+                    :default    0
+                    :getter     (fn []
+                                  (if-not ((requiring-resolve 'metabase.app-db.core/db-is-set-up?))
+                                    0
+                                    (cached-active-users-count))))
+                 pr-str
+                 hooks/parse-string)]
+    (is (= '(let [_ (deferred-tru "Cached number of active users. Refreshed every 5 minutes.")
+                  _ {:default 0
+                     :type :integer
+                     :getter (fn []
+                               (if-not ((requiring-resolve 'metabase.app-db.core/db-is-set-up?))
+                                 0
+                                 (cached-active-users-count)))
+                     :visibility :admin}]
+              :active-users-count
+              (defn active-users-count "Docstring." [])
+              (defn active-users-count! "Docstring." [_value-or-nil]))
+           (-> {:node node, :ns 'hooks.metabase.settings.models.setting-test}
+               hooks.metabase.settings.models.setting/defsetting
+               :node
+               hooks/sexpr)))))

.clj-kondo/test/hooks/metabase/util/i18n_test.clj

@@ -0,0 +1,33 @@
+(ns hooks.metabase.util.i18n-test
+  (:require [clj-kondo.hooks-api :as api]
+            [clj-kondo.impl.utils]
+            [clojure.string :as str]
+            [clojure.test :refer [deftest testing is are]]
+            [hooks.metabase.util.i18n]))
+
+(defn- warnings
+  [form]
+  (binding [clj-kondo.impl.utils/*ctx* {:config     {:linters {:metabase/validate-string-or-str-args-to-i18n {:level :warning}
+                                                               :metabase/validate-escaped-single-quotes-in-i18n {:level :warning}}}
+                                        :ignores    (atom nil)
+                                        :findings   (atom [])
+                                        :namespaces (atom {})}]
+    (hooks.metabase.util.i18n/strict-apostrophes {:node (api/parse-string (pr-str form))})
+    (mapv :message @(:findings clj-kondo.impl.utils/*ctx*))))
+
+(deftest ^:parallel strict-apostrophes-warns
+  (are [form] (= ["Format string contains invalid single quote usage. Use '' for literals or '{...}' for escaping."]
+                 (warnings (quote form)))
+    (metabase.util.i18n/tru "this isn't good bob")
+    (metabase.util.i18n/tru "'this is not good either'")
+    (metabase.util.i18n/tru "''this isn't''")
+    (metabase.util.i18n/tru "nope you can not escape 'like {{0}} so {{1}}'")
+    (metabase.util.i18n/tru (str "it works" "when strings" "are concatenated'"))))
+
+(deftest ^:parallel strict-apostrophes-doesnt-warn-on-good-ones
+  (are [form] (= []
+                 (warnings (quote form)))
+    (metabase.util.i18n/tru "this isn''t bad")
+    (metabase.util.i18n/tru (str "not sure why you'" "'d do this" "... but ok"))
+    (metabase.util.i18n/tru "you can '{{0}}' do things like that")
+    (metabase.util.i18n/tru "or '{{ this or }}}}}}}}}}' that")))

.cljfmt.edn

@@ -81,268 +81,272 @@
   throttle.core/with-throttling                                                        [[:block 1]]
   ;; the rest of the stuff in this list is generated automatically based on `:style/indent` specs
   ;; by running [[dev.generate-cljfmt-config/specs]]... use that code to update this list
-  metabase-enterprise.advanced-permissions.api.util-test/with-impersonations!          [[:inner 0]]
-  metabase-enterprise.cache.config-test/with-temp-persist-models                       [[:block 1]]
-  metabase-enterprise.sandbox.test-util/with-gtaps!                                    [[:inner 0]]
-  metabase-enterprise.sandbox.test-util/with-gtaps-for-user!                           [[:inner 0]]
-  metabase-enterprise.sandbox.test-util/with-user-attributes                           [[:block 2]]
-  metabase-enterprise.serialization.test-util/with-dbs                                 [[:inner 0]]
-  metabase-enterprise.serialization.test-util/with-random-dump-dir                     [[:block 1]]
-  metabase-enterprise.serialization.test-util/with-world                               [[:block 0]]
-  metabase-enterprise.sso.integrations.jwt-test/with-users-with-email-deleted          [[:block 1]]
-  metabase-enterprise.test/with-gtaps!                                                 [[:inner 0]]
-  metabase-enterprise.test/with-gtaps-for-user!                                        [[:inner 0]]
-  metabase-enterprise.test/with-user-attributes                                        [[:block 2]]
-  metabase.actions.actions-test/with-actions-test-data-and-actions-permissively-enabled [[:block 0]]
-  metabase.actions.test-util/with-actions                                              [[:block 1]]
-  metabase.actions.test-util/with-actions-disabled                                     [[:block 0]]
-  metabase.actions.test-util/with-actions-enabled                                      [[:block 0]]
-  metabase.actions.test-util/with-actions-test-data                                    [[:inner 0]]
-  metabase.actions.test-util/with-actions-test-data-and-actions-enabled                [[:block 0]]
-  metabase.actions.test-util/with-actions-test-data-tables                             [[:block 1]]
-  metabase.actions.test-util/with-empty-db                                             [[:inner 0]]
-  metabase.actions.test-util/with-temp-test-data                                       [[:inner 0]]
-  metabase.api.alert-test/with-alert-in-collection                                     [[:block 1]]
-  metabase.api.card-test/with-cards-in-readable-collection                             [[:block 1]]
-  metabase.api.card-test/with-cards-in-writeable-collection                            [[:block 1]]
-  metabase.api.card-test/with-ordered-items                                            [[:inner 0]]
-  metabase.api.card-test/with-temp-native-card!                                        [[:block 1]]
-  metabase.api.card-test/with-temp-native-card-with-params!                            [[:block 1]]
-  metabase.api.collection-test/with-collection-hierarchy                               [[:block 1]]
-  metabase.api.collection-test/with-french-user-and-personal-collection                [[:block 2]]
-  metabase.api.collection-test/with-some-children-of-collection                        [[:block 1]]
-  metabase.api.common/check                                                            [[:default]]
-  metabase.api.common/define-routes                                                    [[:block 0]]
-  metabase.api.common/let-404                                                          [[:block 1]]
-  metabase.api.common.internal/auto-coerce                                             [[:block 1]]
-  metabase.api.common.internal/auto-parse                                              [[:block 1]]
-  metabase.api.common.internal-test/no-route-regexes                                   [[:block 0]]
-  metabase.api.embed-test/do-response-formats                                          [[:block 1]]
-  metabase.api.embed-test/with-embedding-enabled-and-new-secret-key                    [[:block 0]]
-  metabase.api.embed-test/with-embedding-enabled-and-temp-card-referencing             [[:block 3]]
-  metabase.api.embed-test/with-embedding-enabled-and-temp-dashcard-referencing         [[:block 3]]
-  metabase.api.embed-test/with-new-secret-key                                          [[:block 0]]
-  metabase.api.embed-test/with-temp-card                                               [[:block 1]]
-  metabase.api.embed-test/with-temp-dashcard                                           [[:block 1]]
-  metabase.api.preview-embed-test/with-embedding-enabled-and-new-secret-key            [[:block 0]]
-  metabase.api.preview-embed-test/with-new-secret-key                                  [[:block 0]]
-  metabase.api.public-test/with-sharing-enabled-and-temp-card-referencing              [[:block 3]]
-  metabase.api.public-test/with-sharing-enabled-and-temp-dashcard-referencing          [[:block 3]]
-  metabase.api.public-test/with-temp-public-card                                       [[:block 1]]
-  metabase.api.public-test/with-temp-public-dashboard                                  [[:block 1]]
-  metabase.api.public-test/with-temp-public-dashboard-and-card                         [[:block 1]]
-  metabase.api.search-test/do-test-users                                               [[:block 1]]
-  metabase.api.session/http-401-on-error                                               [[:block 0]]
-  metabase.cmd.copy/step                                                               [[:block 1]]
-  metabase.cmd.copy/with-connection-rollback-only                                      [[:block 1]]
-  metabase.cmd.copy/with-disabled-db-constraints                                       [[:block 2]]
-  metabase.config/build-type-case                                                      [[:block 0]]
-  metabase.dashboard-subscription-test/with-link-card-fixture-for-dashboard            [[:block 2]]
-  metabase.db.liquibase/with-liquibase                                                 [[:block 1]]
-  metabase.db.liquibase/with-scope-locked                                              [[:block 1]]
-  metabase.db.schema-migrations-test.impl/test-migrations                              [[:block 2]]
-  metabase.db/with-application-db                                                      [[:inner 0]]
-  metabase.driver.bigquery-cloud-sdk.query-processor/with-temporal-type                [[:default]]
-  metabase.driver.druid.client/DELETE                                                  [[:default]]
-  metabase.driver.druid.client/GET                                                     [[:default]]
-  metabase.driver.druid.client/POST                                                    [[:default]]
-  metabase.driver.druid.query-processor-test/druid-query                               [[:block 0]]
-  metabase.driver.druid.query-processor-test/druid-query-returning-rows                [[:block 0]]
-  metabase.driver.mongo.query-processor/mongo-let                                      [[:block 1]]
-  metabase.driver.sql-jdbc.actions/with-jdbc-transaction                               [[:block 1]]
-  metabase.driver.sql-jdbc.connection/with-connection-spec-for-testing-connection      [[:block 1]]
-  metabase.driver.sql-jdbc.execute.diagnostic/capturing-diagnostic-info                [[:block 1]]
-  metabase.driver.sql.query-processor/apply-top-level-clause                           [[:default]]
-  metabase.driver/with-driver                                                          [[:block 1]]
-  metabase.lib.binning/with-binning                                                    [[:default]]
-  metabase.lib.core/with-binning                                                       [[:default]]
-  metabase.lib.core/with-join-alias                                                    [[:default]]
-  metabase.lib.core/with-join-conditions                                               [[:default]]
-  metabase.lib.join/with-join-alias                                                    [[:default]]
-  metabase.lib.join/with-join-conditions                                               [[:default]]
-  metabase.lib.test-util.macros/$ids                                                   [[:inner 0]]
-  metabase.lib.test-util.macros/mbql-query                                             [[:inner 0]]
-  metabase.lib.util.match/match                                                        [[:inner 0]]
-  metabase.lib.util.match/match-one                                                    [[:inner 0]]
-  metabase.lib.util.match/replace                                                      [[:inner 0]]
-  metabase.lib.util.match/replace-in                                                   [[:inner 0]]
-  metabase.models.collection-test/with-collection-hierarchy                            [[:block 1]]
-  metabase.models.collection-test/with-current-user-perms-for-collections              [[:block 1]]
-  metabase.models.collection-test/with-personal-and-impersonal-collections             [[:block 1]]
-  metabase.models.dashboard-test/with-dash-in-collection                               [[:inner 0]]
-  metabase.models.interface/define-batched-hydration-method                            [[:inner 0]]
-  metabase.models.interface/define-simple-hydration-method                             [[:inner 0]]
-  metabase.models.params.chain-filter-test/with-clean-field-values-for-field           [[:block 1]]
-  metabase.models.params.chain-filter-test/with-fk-field-to-field-remapping            [[:block 0]]
-  metabase.models.params.chain-filter-test/with-human-readable-values-remapping        [[:block 0]]
-  metabase.models.pulse-test/with-dashboard-subscription-in-collection                 [[:block 1]]
-  metabase.models.pulse-test/with-pulse-in-collection                                  [[:inner 0]]
-  metabase.models.setting/defsetting                                                   [[:block 1]]
-  metabase.models.setting.multi-setting/define-multi-setting                           [[:inner 0]]
-  metabase.models.task-history/with-task-history                                       [[:block 1]]
-  metabase.query-processor-test.pipeline-queries-test/pmbql-query                      [[:block 1]]
-  metabase.query-processor-test.pipeline-queries-test/run-pmbql-query                  [[:block 1]]
-  metabase.query-processor.debug/debug>                                                [[:block 0]]
-  metabase.query-processor.error-type/deferror                                         [[:block 1]]
-  metabase.query-processor.middleware.cache-backend.interface/with-cached-results      [[:block 4]]
-  metabase.query-processor.middleware.process-userland-query-test/with-query-execution [[:block 1]]
-  metabase.query-processor.store/cached                                                [[:block 1]]
-  metabase.query-processor.store/with-metadata-provider                                [[:inner 0]]
-  metabase.query-processor.streaming/streaming-response                                [[:block 1]]
-  metabase.query-processor.test-util/format-rows-by                                    [[:default]]
-  metabase.request.core/as-admin                                                       [[:block 0]]
-  metabase.request.core/with-current-request                                           [[:inner 0]]
-  metabase.request.core/with-current-user                                              [[:inner 0]]
-  metabase.request.core/with-limit-and-offset                                          [[:inner 0]]
-  metabase.request.session/as-admin                                                    [[:block 0]]
-  metabase.request.session/with-current-user                                           [[:inner 0]]
-  metabase.sample-data-test/with-temp-sample-database-db                               [[:block 1]]
-  metabase.server.middleware.session/as-admin                                          [[:block 0]]
-  metabase.server.middleware.session/with-current-user                                 [[:inner 0]]
-  metabase.server.streaming-response/streaming-response                                [[:block 2]]
-  metabase.server.streaming-response-test/with-streaming-response-thread-pool          [[:block 0]]
-  metabase.server.streaming-response-test/with-test-driver-db!                         [[:block 0]]
-  metabase.sync.fetch-metadata/log-if-error                                            [[:block 1]]
-  metabase.sync.sync-metadata.fields-test/with-test-db                                 [[:block 0]]
-  metabase.sync.util/do-with-start-and-finish-debug-logging                            [[:default]]
-  metabase.sync.util/sum-for                                                           [[:block 1]]
-  metabase.sync.util/sync-operation                                                    [[:block 3]]
-  metabase.sync.util/with-db-logging-disabled                                          [[:default]]
-  metabase.sync.util/with-duplicate-ops-prevented                                      [[:default]]
-  metabase.sync.util/with-emoji-progress-bar                                           [[:block 1]]
-  metabase.sync.util/with-error-handling                                               [[:block 1]]
-  metabase.sync.util/with-start-and-finish-logging                                     [[:default]]
-  metabase.sync.util/with-start-and-finish-logging*                                    [[:default]]
-  metabase.sync.util/with-sync-events                                                  [[:default]]
-  metabase.test/$ids                                                                   [[:inner 0]]
-  metabase.test/as-admin                                                               [[:inner 0]]
-  metabase.test/dataset                                                                [[:inner 0]]
-  metabase.test/discard-setting-changes                                                [[:block 1]]
-  metabase.test/format-rows-by                                                         [[:default]]
-  metabase.test/let-url                                                                [[:block 1]]
-  metabase.test/mbql-query                                                             [[:inner 0]]
-  metabase.test/native-query                                                           [[:block 0]]
-  metabase.test/query                                                                  [[:block 1]]
-  metabase.test/run-mbql-query                                                         [[:inner 0]]
-  metabase.test/test-driver                                                            [[:inner 0]]
-  metabase.test/test-drivers                                                           [[:inner 0]]
-  metabase.test/test-helpers-set-global-values!                                        [[:block 0]]
-  metabase.test/throw-if-called!                                                       [[:block 1]]
-  metabase.test/with-actions                                                           [[:block 1]]
-  metabase.test/with-actions-disabled                                                  [[:block 0]]
-  metabase.test/with-actions-enabled                                                   [[:block 0]]
-  metabase.test/with-actions-test-data                                                 [[:inner 0]]
-  metabase.test/with-actions-test-data-and-actions-enabled                             [[:block 0]]
-  metabase.test/with-actions-test-data-tables                                          [[:block 1]]
-  metabase.test/with-additional-premium-features                                       [[:block 1]]
-  metabase.test/with-current-user                                                      [[:inner 0]]
-  metabase.test/with-driver                                                            [[:block 1]]
-  metabase.test/with-empty-db                                                          [[:inner 0]]
-  metabase.test/with-empty-h2-app-db                                                   [[:block 0]]
-  metabase.test/with-metadata-provider                                                 [[:inner 0]]
-  metabase.test/with-premium-features                                                  [[:block 1]]
-  metabase.test/with-temp                                                              [[:inner 0]]
-  metabase.test/with-temp-copy-of-db                                                   [[:block 0]]
-  metabase.test/with-temp-scheduler                                                    [[:block 0]]
-  metabase.test/with-temp-test-data                                                    [[:inner 0]]
-  metabase.test/with-temp-vals-in-db                                                   [[:block 3]]
-  metabase.test/with-test-user                                                         [[:inner 0]]
-  metabase.test/with-user-in-groups                                                    [[:inner 0]]
-  metabase.test.data/$ids                                                              [[:inner 0]]
-  metabase.test.data/dataset                                                           [[:inner 0]]
-  metabase.test.data/mbql-query                                                        [[:inner 0]]
-  metabase.test.data/native-query                                                      [[:block 0]]
-  metabase.test.data/query                                                             [[:block 1]]
-  metabase.test.data/run-mbql-query                                                    [[:inner 0]]
-  metabase.test.data/with-empty-h2-app-db                                              [[:block 0]]
-  metabase.test.data/with-temp-copy-of-db                                              [[:block 0]]
-  metabase.test.data.datasets/test-driver                                              [[:inner 0]]
-  metabase.test.data.datasets/test-drivers                                             [[:inner 0]]
-  metabase.test.data.one-off-dbs/with-blank-db                                         [[:block 0]]
-  metabase.test.data.one-off-dbs/with-blueberries-db                                   [[:block 0]]
-  metabase.test.data.users/with-test-user                                              [[:inner 0]]
-  metabase.test.util/discard-setting-changes                                           [[:block 1]]
-  metabase.test.util/let-url                                                           [[:block 1]]
-  metabase.test.util/throw-if-called!                                                  [[:block 1]]
-  metabase.test.util/with-temp-scheduler                                               [[:block 0]]
-  metabase.test.util/with-temp-vals-in-db                                              [[:block 3]]
-  metabase.test.util/with-user-in-groups                                               [[:inner 0]]
-  metabase.test.util.public-settings/with-additional-premium-features                  [[:block 1]]
-  metabase.test.util.public-settings/with-premium-features                             [[:block 1]]
-  metabase.test.util.thread-local/test-helpers-set-global-values!                      [[:block 0]]
-  metabase.timeseries-query-processor-test.util/test-timeseries-drivers                [[:block 0]]
-  metabase.timeseries-query-processor-test/run-mbql-query                              [[:inner 0]]
-  metabase.upload-test/with-upload-table!                                              [[:inner 0]]
-  metabase.upload.types/with-currency                                                  [[:default]]
-  metabase.upload.types/with-parens                                                    [[:default]]
-  metabase.util/auto-retry                                                             [[:block 1]]
-  metabase.util/case-enum                                                              [[:block 1]]
-  metabase.util/ignore-exceptions                                                      [[:block 0]]
-  metabase.util/or-with                                                                [[:block 1]]
-  metabase.util/profile                                                                [[:block 1]]
-  metabase.util/prog1                                                                  [[:inner 0]]
-  metabase.util/varargs                                                                [[:inner 0]]
-  metabase.util/with-us-locale                                                         [[:block 0]]
-  metabase.util.async/cancelable-thread                                                [[:block 0]]
-  metabase.util.date-2/with-time-zone-same-instant                                     [[:default]]
-  metabase.util.encryption-test/with-secret-key                                        [[:block 1]]
-  metabase.util.honey-sql-2/with-database-type-info                                    [[:default]]
-  metabase.util.i18n/deferred-trs                                                      [[:default]]
-  metabase.util.i18n/deferred-tru                                                      [[:default]]
-  metabase.util.i18n/trs                                                               [[:default]]
-  metabase.util.i18n/trsn                                                              [[:default]]
-  metabase.util.i18n/tru                                                               [[:default]]
-  metabase.util.i18n/trun                                                              [[:default]]
-  metabase.util.jvm/auto-retry                                                         [[:block 1]]
-  metabase.util.jvm/varargs                                                            [[:block 1]]
-  metabase.util.jvm/with-us-locale                                                     [[:block 0]]
-  metabase.util.malli/disable-enforcement                                              [[:block 0]]
-  metabase.util.malli/with                                                             [[:default]]
-  metabase.util.malli/with-api-error-message                                           [[:default]]
-  metabase.util.namespaces/import-fns                                                  [[:default]]
-  metabuild-common.core/exit-when-finished-nonzero-on-exception                        [[:block 0]]
-  metabuild-common.core/step                                                           [[:block 1]]
-  metabuild-common.entrypoint/exit-when-finished-nonzero-on-exception                  [[:block 0]]
-  metabuild-common.steps/step                                                          [[:block 1]]
-  methodical.core/defmethod                                                            [[:inner 0]]
-  methodical.core/defmulti                                                             [[:inner 0]]
-  methodical.core/with-dispatcher                                                      [[:default]]
-  methodical.core/with-method-table                                                    [[:default]]
-  methodical.core/with-prefers                                                         [[:default]]
-  methodical.interface/with-dispatcher                                                 [[:default]]
-  methodical.interface/with-method-table                                               [[:default]]
-  methodical.interface/with-prefers                                                    [[:default]]
-  methodical.macros/defmethod                                                          [[:inner 0]]
-  methodical.macros/defmulti                                                           [[:inner 0]]
-  saml20-clj.sp.response/validate-confirmation-datas                                   [[:block 1]]
-  toucan2.connection/with-transaction                                                  [[:block 1]]
-  toucan2.core/build                                                                   [[:block 0]]
-  toucan2.core/compile                                                                 [[:block 0]]
-  toucan2.core/debug                                                                   [[:block 0]]
-  toucan2.core/define-after-insert                                                     [[:inner 0]]
-  toucan2.core/define-after-select                                                     [[:inner 0]]
-  toucan2.core/define-after-update                                                     [[:inner 0]]
-  toucan2.core/define-before-delete                                                    [[:inner 0]]
-  toucan2.core/define-before-insert                                                    [[:inner 0]]
-  toucan2.core/define-before-select                                                    [[:inner 0]]
-  toucan2.core/define-default-fields                                                   [[:inner 0]]
-  toucan2.core/define-named-query                                                      [[:block 1]]
-  toucan2.core/deftransforms                                                           [[:block 1]]
-  toucan2.core/with-transaction                                                        [[:block 1]]
-  toucan2.tools.after/define-after-impl                                                [[:default]]
-  toucan2.tools.after-insert/define-after-insert                                       [[:inner 0]]
-  toucan2.tools.after-select/define-after-select                                       [[:inner 0]]
-  toucan2.tools.after-update/define-after-update                                       [[:inner 0]]
-  toucan2.tools.before-delete/define-before-delete                                     [[:inner 0]]
-  toucan2.tools.before-insert/define-before-insert                                     [[:inner 0]]
-  toucan2.tools.before-select/define-before-select                                     [[:inner 0]]
-  toucan2.tools.compile/build                                                          [[:block 0]]
-  toucan2.tools.compile/compile                                                        [[:block 0]]
-  toucan2.tools.compile/resolved                                                       [[:block 0]]
-  toucan2.tools.debug/debug                                                            [[:block 0]]
-  toucan2.tools.default-fields/define-default-fields                                   [[:inner 0]]
-  toucan2.tools.named-query/define-named-query                                         [[:block 1]]
-  toucan2.tools.simple-out-transform/define-out-transform                              [[:inner 0]]
-  toucan2.tools.transformed/deftransforms                                              [[:block 1]]
-  toucan2.tools.with-temp/with-temp                                                    [[:inner 0]]
-  toucan2.util/try-with-error-context                                                  [[:inner 0]]}}
+  metabase-enterprise.cache.config-test/with-temp-persist-models                         [[:block 1]]
+  metabase-enterprise.impersonation.util-test/with-impersonations!                       [[:inner 0]]
+  metabase-enterprise.sandbox.test-util/with-gtaps!                                      [[:inner 0]]
+  metabase-enterprise.sandbox.test-util/with-gtaps-for-user!                             [[:inner 0]]
+  metabase-enterprise.sandbox.test-util/with-user-attributes                             [[:block 2]]
+  metabase-enterprise.serialization.test-util/with-dbs                                   [[:inner 0]]
+  metabase-enterprise.serialization.test-util/with-random-dump-dir                       [[:block 1]]
+  metabase-enterprise.serialization.test-util/with-world                                 [[:block 0]]
+  metabase-enterprise.sso.integrations.jwt-test/with-users-with-email-deleted            [[:block 1]]
+  metabase-enterprise.test/with-gtaps!                                                   [[:inner 0]]
+  metabase-enterprise.test/with-gtaps-for-user!                                          [[:inner 0]]
+  metabase-enterprise.test/with-user-attributes                                          [[:block 2]]
+  metabase.actions.actions-test/with-actions-test-data-and-actions-permissively-enabled  [[:block 0]]
+  metabase.actions.test-util/with-actions                                                [[:block 1]]
+  metabase.actions.test-util/with-actions-disabled                                       [[:block 0]]
+  metabase.actions.test-util/with-actions-enabled                                        [[:block 0]]
+  metabase.actions.test-util/with-actions-test-data                                      [[:inner 0]]
+  metabase.actions.test-util/with-actions-test-data-and-actions-enabled                  [[:block 0]]
+  metabase.actions.test-util/with-actions-test-data-tables                               [[:block 1]]
+  metabase.actions.test-util/with-empty-db                                               [[:inner 0]]
+  metabase.actions.test-util/with-temp-test-data                                         [[:inner 0]]
+  metabase.api.common/check                                                              [[:default]]
+  metabase.api.common/define-routes                                                      [[:block 0]]
+  metabase.api.common/let-404                                                            [[:block 1]]
+  metabase.app-db.core/with-application-db                                               [[:inner 0]]
+  metabase.app-db.liquibase/with-liquibase                                               [[:block 1]]
+  metabase.app-db.liquibase/with-scope-locked                                            [[:block 1]]
+  metabase.app-db.schema-migrations-test.impl/test-migrations                            [[:block 2]]
+  metabase.cmd.copy/step                                                                 [[:block 1]]
+  metabase.cmd.copy/with-connection-rollback-only                                        [[:block 1]]
+  metabase.cmd.copy/with-disabled-db-constraints                                         [[:block 2]]
+  metabase.collections.api-test/with-collection-hierarchy                                [[:block 1]]
+  metabase.collections.api-test/with-french-user-and-personal-collection                 [[:block 2]]
+  metabase.collections.api-test/with-some-children-of-collection                         [[:block 1]]
+  metabase.collections.models.collection-test/with-collection-hierarchy                  [[:block 1]]
+  metabase.collections.models.collection-test/with-current-user-perms-for-collections    [[:block 1]]
+  metabase.collections.models.collection-test/with-personal-and-impersonal-collections   [[:block 1]]
+  metabase.config/build-type-case                                                        [[:block 0]]
+  metabase.dashboards.models.dashboard-test/with-dash-in-collection                      [[:inner 0]]
+  metabase.driver.bigquery-cloud-sdk.query-processor/with-temporal-type                  [[:default]]
+  metabase.driver.druid.client/DELETE                                                    [[:default]]
+  metabase.driver.druid.client/GET                                                       [[:default]]
+  metabase.driver.druid.client/POST                                                      [[:default]]
+  metabase.driver.druid.query-processor-test/druid-query                                 [[:block 0]]
+  metabase.driver.druid.query-processor-test/druid-query-returning-rows                  [[:block 0]]
+  metabase.driver.mongo.query-processor/mongo-let                                        [[:block 1]]
+  metabase.driver.sql-jdbc.actions/with-jdbc-transaction                                 [[:block 1]]
+  metabase.driver.sql-jdbc.connection/with-connection-spec-for-testing-connection        [[:block 1]]
+  metabase.driver.sql-jdbc.execute.diagnostic/capturing-diagnostic-info                  [[:block 1]]
+  metabase.driver.sql.query-processor/apply-top-level-clause                             [[:default]]
+  metabase.driver/with-driver                                                            [[:block 1]]
+  metabase.embedding.api.embed-test/do-response-formats                                  [[:block 1]]
+  metabase.embedding.api.embed-test/with-embedding-enabled-and-new-secret-key            [[:block 0]]
+  metabase.embedding.api.embed-test/with-embedding-enabled-and-temp-card-referencing     [[:block 3]]
+  metabase.embedding.api.embed-test/with-embedding-enabled-and-temp-dashcard-referencing [[:block 3]]
+  metabase.embedding.api.embed-test/with-new-secret-key                                  [[:block 0]]
+  metabase.embedding.api.embed-test/with-temp-card                                       [[:block 1]]
+  metabase.embedding.api.embed-test/with-temp-dashcard                                   [[:block 1]]
+  metabase.embedding.api.preview-embed-test/with-embedding-enabled-and-new-secret-key    [[:block 0]]
+  metabase.embedding.api.preview-embed-test/with-new-secret-key                          [[:block 0]]
+  metabase.lib.binning/with-binning                                                      [[:default]]
+  metabase.lib.core/with-binning                                                         [[:default]]
+  metabase.lib.core/with-join-alias                                                      [[:default]]
+  metabase.lib.core/with-join-conditions                                                 [[:default]]
+  metabase.lib.join/with-join-alias                                                      [[:default]]
+  metabase.lib.join/with-join-conditions                                                 [[:default]]
+  metabase.lib.test-util.macros/$ids                                                     [[:inner 0]]
+  metabase.lib.test-util.macros/mbql-query                                               [[:inner 0]]
+  metabase.lib.util.match/match                                                          [[:inner 0]]
+  metabase.lib.util.match/match-one                                                      [[:inner 0]]
+  metabase.lib.util.match/replace                                                        [[:inner 0]]
+  metabase.lib.util.match/replace-in                                                     [[:inner 0]]
+  metabase.models.interface/define-batched-hydration-method                              [[:inner 0]]
+  metabase.models.interface/define-simple-hydration-method                               [[:inner 0]]
+  metabase.parameters.chain-filter-test/with-clean-field-values-for-field                [[:block 1]]
+  metabase.parameters.chain-filter-test/with-fk-field-to-field-remapping                 [[:block 0]]
+  metabase.parameters.chain-filter-test/with-human-readable-values-remapping             [[:block 0]]
+  metabase.permissions.core/allow-changing-all-users-group-members                       [[:block 0]]
+  metabase.permissions.core/disable-perms-cache                                          [[:block 0]]
+  metabase.public-sharing.api-test/with-sharing-enabled-and-temp-card-referencing        [[:block 3]]
+  metabase.public-sharing.api-test/with-sharing-enabled-and-temp-dashcard-referencing    [[:block 3]]
+  metabase.public-sharing.api-test/with-temp-public-card                                 [[:block 1]]
+  metabase.public-sharing.api-test/with-temp-public-dashboard                            [[:block 1]]
+  metabase.public-sharing.api-test/with-temp-public-dashboard-and-card                   [[:block 1]]
+  metabase.pulse.api.alert-test/with-alert-in-collection                                 [[:block 1]]
+  metabase.pulse.dashboard-subscription-test/with-link-card-fixture-for-dashboard        [[:block 2]]
+  metabase.pulse.models.pulse-test/with-dashboard-subscription-in-collection             [[:block 1]]
+  metabase.pulse.models.pulse-test/with-pulse-in-collection                              [[:inner 0]]
+  metabase.queries.api.card-test/with-cards-in-readable-collection                       [[:block 1]]
+  metabase.queries.api.card-test/with-cards-in-writeable-collection                      [[:block 1]]
+  metabase.queries.api.card-test/with-ordered-items                                      [[:inner 0]]
+  metabase.queries.api.card-test/with-temp-native-card!                                  [[:block 1]]
+  metabase.queries.api.card-test/with-temp-native-card-with-params!                      [[:block 1]]
+  metabase.query-processor-test.pipeline-queries-test/pmbql-query                        [[:block 1]]
+  metabase.query-processor-test.pipeline-queries-test/run-pmbql-query                    [[:block 1]]
+  metabase.query-processor.debug/debug>                                                  [[:block 0]]
+  metabase.query-processor.error-type/deferror                                           [[:block 1]]
+  metabase.query-processor.middleware.cache-backend.interface/with-cached-results        [[:block 4]]
+  metabase.query-processor.middleware.process-userland-query-test/with-query-execution   [[:block 1]]
+  metabase.query-processor.store/cached                                                  [[:block 1]]
+  metabase.query-processor.store/with-metadata-provider                                  [[:inner 0]]
+  metabase.query-processor.streaming/streaming-response                                  [[:block 1]]
+  metabase.query-processor.test-util/format-rows-by                                      [[:default]]
+  metabase.request.core/as-admin                                                         [[:block 0]]
+  metabase.request.core/with-current-request                                             [[:inner 0]]
+  metabase.request.core/with-current-user                                                [[:inner 0]]
+  metabase.request.core/with-limit-and-offset                                            [[:inner 0]]
+  metabase.request.session/as-admin                                                      [[:block 0]]
+  metabase.request.session/with-current-user                                             [[:inner 0]]
+  metabase.sample-data.impl-test/with-temp-sample-database-db                            [[:block 1]]
+  metabase.search.api-test/do-test-users                                                 [[:block 1]]
+  metabase.server.middleware.session/as-admin                                            [[:block 0]]
+  metabase.server.middleware.session/with-current-user                                   [[:inner 0]]
+  metabase.server.streaming-response-test/with-streaming-response-thread-pool            [[:block 0]]
+  metabase.server.streaming-response-test/with-test-driver-db!                           [[:block 0]]
+  metabase.server.streaming-response/streaming-response                                  [[:block 2]]
+  metabase.session.api/http-401-on-error                                                 [[:block 0]]
+  metabase.settings.core/define-multi-setting                                            [[:inner 0]]
+  metabase.settings.core/defsetting                                                      [[:block 1]]
+  metabase.settings.models.setting.multi-setting/define-multi-setting                    [[:inner 0]]
+  metabase.settings.models.setting/defsetting                                            [[:block 1]]
+  metabase.sync.fetch-metadata/log-if-error                                              [[:block 1]]
+  metabase.sync.sync-metadata.fields-test/with-test-db                                   [[:block 0]]
+  metabase.sync.util/do-with-start-and-finish-debug-logging                              [[:default]]
+  metabase.sync.util/sum-for                                                             [[:block 1]]
+  metabase.sync.util/sync-operation                                                      [[:block 3]]
+  metabase.sync.util/with-db-logging-disabled                                            [[:default]]
+  metabase.sync.util/with-duplicate-ops-prevented                                        [[:default]]
+  metabase.sync.util/with-emoji-progress-bar                                             [[:block 1]]
+  metabase.sync.util/with-error-handling                                                 [[:block 1]]
+  metabase.sync.util/with-start-and-finish-logging                                       [[:default]]
+  metabase.sync.util/with-start-and-finish-logging*                                      [[:default]]
+  metabase.sync.util/with-sync-events                                                    [[:default]]
+  metabase.task-history.models.task-history/with-task-history                            [[:block 1]]
+  metabase.task.core/rerun-on-error                                                      [[:block 1]]
+  metabase.task.impl/rerun-on-error                                                      [[:block 1]]
+  metabase.test.data.datasets/test-driver                                                [[:inner 0]]
+  metabase.test.data.datasets/test-drivers                                               [[:inner 0]]
+  metabase.test.data.one-off-dbs/with-blank-db                                           [[:block 0]]
+  metabase.test.data.one-off-dbs/with-blueberries-db                                     [[:block 0]]
+  metabase.test.data.users/with-test-user                                                [[:inner 0]]
+  metabase.test.data/$ids                                                                [[:inner 0]]
+  metabase.test.data/dataset                                                             [[:inner 0]]
+  metabase.test.data/mbql-query                                                          [[:inner 0]]
+  metabase.test.data/native-query                                                        [[:block 0]]
+  metabase.test.data/query                                                               [[:block 1]]
+  metabase.test.data/run-mbql-query                                                      [[:inner 0]]
+  metabase.test.data/with-empty-h2-app-db!                                               [[:block 0]]
+  metabase.test.data/with-temp-copy-of-db                                                [[:block 0]]
+  metabase.test.util.public-settings/with-additional-premium-features                    [[:block 1]]
+  metabase.test.util.public-settings/with-premium-features                               [[:block 1]]
+  metabase.test.util.thread-local/test-helpers-set-global-values!                        [[:block 0]]
+  metabase.test.util/discard-setting-changes                                             [[:block 1]]
+  metabase.test.util/let-url                                                             [[:block 1]]
+  metabase.test.util/throw-if-called!                                                    [[:block 1]]
+  metabase.test.util/with-temp-scheduler                                                 [[:block 0]]
+  metabase.test.util/with-temp-vals-in-db                                                [[:block 3]]
+  metabase.test.util/with-user-in-groups                                                 [[:inner 0]]
+  metabase.test/$ids                                                                     [[:inner 0]]
+  metabase.test/as-admin                                                                 [[:inner 0]]
+  metabase.test/dataset                                                                  [[:inner 0]]
+  metabase.test/discard-setting-changes                                                  [[:block 1]]
+  metabase.test/format-rows-by                                                           [[:default]]
+  metabase.test/let-url                                                                  [[:block 1]]
+  metabase.test/mbql-query                                                               [[:inner 0]]
+  metabase.test/native-query                                                             [[:block 0]]
+  metabase.test/query                                                                    [[:block 1]]
+  metabase.test/run-mbql-query                                                           [[:inner 0]]
+  metabase.test/test-driver                                                              [[:inner 0]]
+  metabase.test/test-drivers                                                             [[:inner 0]]
+  metabase.test/test-helpers-set-global-values!                                          [[:block 0]]
+  metabase.test/throw-if-called!                                                         [[:block 1]]
+  metabase.test/with-actions                                                             [[:block 1]]
+  metabase.test/with-actions-disabled                                                    [[:block 0]]
+  metabase.test/with-actions-enabled                                                     [[:block 0]]
+  metabase.test/with-actions-test-data                                                   [[:inner 0]]
+  metabase.test/with-actions-test-data-and-actions-enabled                               [[:block 0]]
+  metabase.test/with-actions-test-data-tables                                            [[:block 1]]
+  metabase.test/with-additional-premium-features                                         [[:block 1]]
+  metabase.test/with-current-user                                                        [[:inner 0]]
+  metabase.test/with-driver                                                              [[:block 1]]
+  metabase.test/with-empty-db                                                            [[:inner 0]]
+  metabase.test/with-empty-h2-app-db!                                                    [[:block 0]]
+  metabase.test/with-metadata-provider                                                   [[:inner 0]]
+  metabase.test/with-premium-features                                                    [[:block 1]]
+  metabase.test/with-temp                                                                [[:inner 0]]
+  metabase.test/with-temp-copy-of-db                                                     [[:block 0]]
+  metabase.test/with-temp-scheduler                                                      [[:block 0]]
+  metabase.test/with-temp-test-data                                                      [[:inner 0]]
+  metabase.test/with-temp-vals-in-db                                                     [[:block 3]]
+  metabase.test/with-test-user                                                           [[:inner 0]]
+  metabase.test/with-user-in-groups                                                      [[:inner 0]]
+  metabase.timeseries-query-processor-test.util/test-timeseries-drivers                  [[:block 0]]
+  metabase.timeseries-query-processor-test/run-mbql-query                                [[:inner 0]]
+  metabase.upload.impl-test/with-upload-table!                                           [[:inner 0]]
+  metabase.upload.types/with-currency                                                    [[:default]]
+  metabase.upload.types/with-parens                                                      [[:default]]
+  metabase.util.async/cancelable-thread                                                  [[:block 0]]
+  metabase.util.date-2/with-time-zone-same-instant                                       [[:default]]
+  metabase.util.encryption-test/with-secret-key                                          [[:block 1]]
+  metabase.util.honey-sql-2/with-database-type-info                                      [[:default]]
+  metabase.util.i18n/deferred-trs                                                        [[:default]]
+  metabase.util.i18n/deferred-tru                                                        [[:default]]
+  metabase.util.i18n/trs                                                                 [[:default]]
+  metabase.util.i18n/trsn                                                                [[:default]]
+  metabase.util.i18n/tru                                                                 [[:default]]
+  metabase.util.i18n/trun                                                                [[:default]]
+  metabase.util.jvm/auto-retry                                                           [[:block 1]]
+  metabase.util.jvm/varargs                                                              [[:block 1]]
+  metabase.util.jvm/with-us-locale                                                       [[:block 0]]
+  metabase.util.malli/disable-enforcement                                                [[:block 0]]
+  metabase.util.malli/with                                                               [[:default]]
+  metabase.util.malli/with-api-error-message                                             [[:default]]
+  metabase.util.namespaces/import-fns                                                    [[:default]]
+  metabase.util.queue-test/await-test-while                                              [[:block 1]]
+  metabase.util/auto-retry                                                               [[:block 1]]
+  metabase.util/case-enum                                                                [[:block 1]]
+  metabase.util/ignore-exceptions                                                        [[:block 0]]
+  metabase.util/or-with                                                                  [[:block 1]]
+  metabase.util/profile                                                                  [[:block 1]]
+  metabase.util/prog1                                                                    [[:inner 0]]
+  metabase.util/varargs                                                                  [[:inner 0]]
+  metabase.util/with-us-locale                                                           [[:block 0]]
+  metabuild-common.core/exit-when-finished-nonzero-on-exception                          [[:block 0]]
+  metabuild-common.core/step                                                             [[:block 1]]
+  metabuild-common.entrypoint/exit-when-finished-nonzero-on-exception                    [[:block 0]]
+  metabuild-common.steps/step                                                            [[:block 1]]
+  methodical.core/defmethod                                                              [[:inner 0]]
+  methodical.core/defmulti                                                               [[:inner 0]]
+  methodical.core/with-dispatcher                                                        [[:default]]
+  methodical.core/with-method-table                                                      [[:default]]
+  methodical.core/with-prefers                                                           [[:default]]
+  methodical.interface/with-dispatcher                                                   [[:default]]
+  methodical.interface/with-method-table                                                 [[:default]]
+  methodical.interface/with-prefers                                                      [[:default]]
+  methodical.macros/defmethod                                                            [[:inner 0]]
+  methodical.macros/defmulti                                                             [[:inner 0]]
+  saml20-clj.sp.response/validate-confirmation-datas                                     [[:block 1]]
+  toucan2.connection/with-transaction                                                    [[:block 1]]
+  toucan2.core/build                                                                     [[:block 0]]
+  toucan2.core/compile                                                                   [[:block 0]]
+  toucan2.core/debug                                                                     [[:block 0]]
+  toucan2.core/define-after-insert                                                       [[:inner 0]]
+  toucan2.core/define-after-select                                                       [[:inner 0]]
+  toucan2.core/define-after-update                                                       [[:inner 0]]
+  toucan2.core/define-before-delete                                                      [[:inner 0]]
+  toucan2.core/define-before-insert                                                      [[:inner 0]]
+  toucan2.core/define-before-select                                                      [[:inner 0]]
+  toucan2.core/define-default-fields                                                     [[:inner 0]]
+  toucan2.core/define-named-query                                                        [[:block 1]]
+  toucan2.core/deftransforms                                                             [[:block 1]]
+  toucan2.core/with-transaction                                                          [[:block 1]]
+  toucan2.tools.after-insert/define-after-insert                                         [[:inner 0]]
+  toucan2.tools.after-select/define-after-select                                         [[:inner 0]]
+  toucan2.tools.after-update/define-after-update                                         [[:inner 0]]
+  toucan2.tools.after/define-after-impl                                                  [[:default]]
+  toucan2.tools.before-delete/define-before-delete                                       [[:inner 0]]
+  toucan2.tools.before-insert/define-before-insert                                       [[:inner 0]]
+  toucan2.tools.before-select/define-before-select                                       [[:inner 0]]
+  toucan2.tools.compile/build                                                            [[:block 0]]
+  toucan2.tools.compile/compile                                                          [[:block 0]]
+  toucan2.tools.compile/resolved                                                         [[:block 0]]
+  toucan2.tools.debug/debug                                                              [[:block 0]]
+  toucan2.tools.default-fields/define-default-fields                                     [[:inner 0]]
+  toucan2.tools.named-query/define-named-query                                           [[:block 1]]
+  toucan2.tools.simple-out-transform/define-out-transform                                [[:inner 0]]
+  toucan2.tools.transformed/deftransforms                                                [[:block 1]]
+  toucan2.tools.with-temp/with-temp                                                      [[:inner 0]]
+  toucan2.util/try-with-error-context                                                    [[:inner 0]]}}

.devcontainer/Dockerfile

@@ -1,11 +1,11 @@
-FROM mcr.microsoft.com/vscode/devcontainers/java:11
+FROM mcr.microsoft.com/vscode/devcontainers/java:21
 
 # Set up nodesource, install node, yarn, fontconfig for static viz, rlwrap for dev ergonomics
 
-RUN ( curl -fsSL https://deb.nodesource.com/setup_18.x | bash ) \
+RUN ( curl -fsSL https://deb.nodesource.com/setup_22.x | bash ) \
   && export DEBIAN_FRONTEND=noninteractive \
   && apt-key adv --refresh-keys --keyserver keyserver.ubuntu.com \
   && apt-get update && apt-get -y install --no-install-recommends nodejs yarn rlwrap fontconfig
 
 # install Clojure
-RUN curl https://download.clojure.org/install/linux-install-1.11.1.1262.sh | bash
+RUN curl https://download.clojure.org/install/linux-install-1.12.0.1488.sh | bash

.dir-locals.el

@@ -20,13 +20,8 @@
  (clojure-mode
   ;; Specify which arg is the docstring for certain macros
   ;; (Add more as needed)
-  (eval . (put 'defendpoint-schema                 'clojure-doc-string-elt 3))
-  (eval . (put 'defendpoint                        'clojure-doc-string-elt 3))
-  (eval . (put 'defendpoint-async                  'clojure-doc-string-elt 3))
   (eval . (put 'define-premium-feature             'clojure-doc-string-elt 2))
-  (eval . (put 'api/defendpoint-schema             'clojure-doc-string-elt 3))
-  (eval . (put 'api/defendpoint                    'clojure-doc-string-elt 3))
-  (eval . (put 'api/defendpoint-async              'clojure-doc-string-elt 3))
+  (eval . (put 'api.macros/defendpoint             'clojure-doc-string-elt 3))
   (eval . (put 'defsetting                         'clojure-doc-string-elt 2))
   (eval . (put 'setting/defsetting                 'clojure-doc-string-elt 2))
   (eval . (put 's/defn                             'clojure-doc-string-elt 2))

.eslintrc.js

@@ -6,6 +6,10 @@
 // can use this flag to enable it. This is set to true in CI
 const shouldLintCssModules =
   process.env.LINT_CSS_MODULES === "true" || process.env.CI;
+const plugins = ["react", "no-only-tests", "ttag", "i18next"];
+if (shouldLintCssModules) {
+  plugins.push("postcss-modules");
+}
 
 module.exports = {
   rules: {
@@ -17,11 +21,14 @@ module.exports = {
       {
         vars: "all",
         args: "none",
-        varsIgnorePattern: "^_",
+        varsIgnorePattern: "^_.+$",
         ignoreRestSiblings: true,
       },
     ],
     "no-empty": [1, { allowEmptyCatch: true }],
+    // Note: adding this rule to a eslint config file in a subfolder will remove
+    // *not* carry over the restricted imports from parent folders, you will
+    // need to copy them over
     "no-restricted-imports": [
       "error",
       {
@@ -108,11 +115,10 @@ module.exports = {
           "When",
           "Then",
           "describeWithSnowplow",
-          "describeEE",
         ],
       },
     ],
-    complexity: ["error", { max: 54 }],
+    complexity: ["error", { max: 55 }],
     ...(shouldLintCssModules
       ? {
           "postcss-modules/no-undef-class": "error",
@@ -132,7 +138,7 @@ module.exports = {
     "jest/globals": true,
   },
   parser: "babel-eslint",
-  plugins: ["react", "no-only-tests", "postcss-modules"],
+  plugins,
   extends: [
     "eslint:recommended",
     "plugin:react/recommended",
@@ -143,6 +149,7 @@ module.exports = {
     "plugin:import/typescript",
     "plugin:depend/recommended",
     "plugin:storybook/recommended",
+    "plugin:i18next/recommended",
   ],
   settings: {
     "import/internal-regex": "^metabase/|^metabase-lib/",
@@ -169,6 +176,7 @@ module.exports = {
       files: ["*.js", "*.jsx", "*.ts", "*.tsx"],
       rules: {
         "no-unconditional-metabase-links-render": "error",
+        "no-color-literals": "error",
         "no-literal-metabase-strings": "error",
         "depend/ban-dependencies": [
           "error",
@@ -188,17 +196,38 @@ module.exports = {
         "*.unit.spec.*",
         "frontend/src/metabase/admin/**/*",
         "frontend/src/metabase/setup/**/*",
+        "enterprise/frontend/src/metabase-enterprise/whitelabel/**/*",
         "frontend/lint/**/*",
         "*.stories.*",
+        "stories-data.*",
         "e2e/**/*",
         "**/tests/*",
         "release/**/*",
+        "webpack.config.js",
+        "rspack.config.js",
       ],
       rules: {
+        "no-color-literals": "off",
         "no-unconditional-metabase-links-render": "off",
         "no-literal-metabase-strings": "off",
       },
     },
+    {
+      files: [
+        "*.unit.spec.*",
+        "frontend/lint/**/*",
+        "*.stories.*",
+        "stories-data.*",
+        "e2e/**/*",
+        "**/tests/*",
+        "release/**/*",
+        "webpack.config.js",
+        "rspack.config.js",
+      ],
+      rules: {
+        "i18next/no-literal-string": "off",
+      },
+    },
     {
       extends: ["plugin:@typescript-eslint/recommended"],
       files: ["*.ts", "*.tsx"],
@@ -220,10 +249,10 @@ module.exports = {
         "@typescript-eslint/no-unused-vars": [
           "error",
           {
-            argsIgnorePattern: "^_",
-            varsIgnorePattern: "^_",
+            argsIgnorePattern: "^_.+$",
+            varsIgnorePattern: "^_.+$",
             ignoreRestSiblings: true,
-            destructuredArrayIgnorePattern: "^_",
+            destructuredArrayIgnorePattern: "^_.+$",
           },
         ],
         // This was introduced in 6.0.0
@@ -246,6 +275,13 @@ module.exports = {
       ],
       rules: {
         "jest/valid-title": ["error", { ignoreTypeOfDescribeName: true }],
+        "jest/expect-expect": [
+          "error",
+          {
+            assertFunctionNames: ["expect*", "assert*"],
+            additionalTestBlockFunctions: [],
+          },
+        ],
       },
     },
     {
@@ -276,13 +312,20 @@ module.exports = {
             message:
               "You may not use base colors in the application, use semantic colors instead. (see colors.module.css)",
           },
-          {
-            selector:
-              "CallExpression[callee.property.name='legacyQuery'] > ObjectExpression > Property[key.name='useStructuredQuery'][value.value=true]",
-            message: "StructuredQuery usage is forbidden. Use MLv2",
-          },
         ],
       },
     },
+    {
+      files: ["docs/**/snippets/**/*.{ts,tsx,js,jsx}"],
+      rules: {
+        "@typescript-eslint/no-unused-vars": "off",
+        "@typescript-eslint/no-var-requires": "off",
+        "import/no-commonjs": "off",
+        "import/no-default-export": "off",
+        "import/order": "off",
+        "import/no-unresolved": "off",
+        "no-color-literals": "off",
+      },
+    },
   ],
 };

.github/CODEOWNERS

@@ -1,34 +1,264 @@
 # Before changing this file, make sure you have read how we use it:
 # https://www.notion.so/metabase/Pull-Request-Code-Review-Guide-374f05df889748b69d67af753f9bc9b8?pvs=4#36550c04ceab40b5a8b8bee6264b090c
 
-enterprise/backend/src/metabase_enterprise/advanced_permissions @noahmoss
-enterprise/backend/src/metabase_enterprise/audit_app @noahmoss
-enterprise/backend/src/metabase_enterprise/sso @noahmoss
-enterprise/backend/src/metabase_enterprise/task/truncate_audit_table.clj @noahmoss
-enterprise/backend/src/metabase_enterprise/internal_user.clj @noahmoss
 enterprise/frontend/src/embedding-sdk @metabase/embedding
 frontend/src/metabase/embedding-sdk @metabase/embedding
+frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion @metabase/embedding
+frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard @metabase/embedding
 frontend/src/metabase/ui @metabase/core-frontend-admin-webapp
-src/metabase/**/*permissions* @noahmoss
-src/metabase/integrations @noahmoss
-snowplow/* @metabase/data
-e2e/* @filiphric
+# snowplow/* @metabase/data
+src/metabase/analytics/prometheus.clj @metabase/cloud-ops
+.github @metabase/devexp
+.clj-kondo @metabase/devexp
+deps.edn @metabase/backend-developers
+
+docs @metabase/tech-writers
+docs/developers-guide # exclude from tech-writer ownership
 
 #
 # Backend modules <=> teams that own them
 #
 
+# modules/drivers @metabase/drivers
+src/metabase/driver/sql_jdbc/actions.clj       @metabase/core-workflows
+test/metabase/driver/sql_jdbc/actions_test.clj @metabase/core-workflows
+
+# enterprise/backend/src/metabase_enterprise/advanced_config @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/advanced_config @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/advanced_permissions @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/advanced_permissions @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/airgap @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/airgap @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/api @metabase/devexp
+# enterprise/backend/test/metabase_enterprise/api @metabase/devexp
+
+# enterprise/backend/src/metabase_enterprise/audit_app @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/audit_app @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/auth_provider @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/auth_provider @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/billing @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/billing @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/cache @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/cache @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/content_verification @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/content_verification @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/core @metabase/devexp
+# enterprise/backend/test/metabase_enterprise/core @metabase/devexp
+
+# enterprise/backend/src/metabase_enterprise/dashboard_subscription_filters @metabase/core-workflows
+# enterprise/backend/test/metabase_enterprise/dashboard_subscription_filters @metabase/core-workflows
+
+# enterprise/backend/src/metabase_enterprise/enhancements @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/enhancements @metabase/core-backend-admin-webapp
+
+# # enterprise/backend/src/metabase_enterprise/llm
+# # enterprise/backend/test/metabase_enterprise/llm
+
+# enterprise/backend/src/metabase_enterprise/query_reference_validation @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/query_reference_validation @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/sandbox @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/sandbox @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/scim @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/scim @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/search @metabase/core-workflows
+# enterprise/backend/test/metabase_enterprise/search @metabase/core-workflows
+
+# enterprise/backend/src/metabase_enterprise/serialization @metabase/core-workflows
+# enterprise/backend/test/metabase_enterprise/serialization @metabase/core-workflows
+
+# enterprise/backend/src/metabase_enterprise/snippet_collections @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/snippet_collections @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/sso @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/sso @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/stale @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/stale @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/stats @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/stats @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/task @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/task @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/upload_management @metabase/core-backend-admin-webapp
+# enterprise/backend/test/metabase_enterprise/upload_management @metabase/core-backend-admin-webapp
+
 src/metabase/actions @metabase/core-backend-admin-webapp
 test/metabase/actions @metabase/core-backend-admin-webapp
 
-src/metabase/channel @metabase/core-workflows
-test/metabase/channel @metabase/core-workflows
+# src/metabase/activity_feed @metabase/core-backend-admin-webapp
+# test/metabase/activity_feed @metabase/core-backend-admin-webapp
 
-src/metabase/query_analysis @metabase/core-backend-querying
-test/metabase/query_analysis @metabase/core-backend-querying
+# src/metabase/analytics @metabase/core-backend-admin-webapp
+# test/metabase/analytics @metabase/core-backend-admin-webapp
 
-src/metabase/setup @metabase/core-backend-admin-webapp
-test/metabase/setup @metabase/core-backend-admin-webapp
+# src/metabase/analyze @metabase/drivers
+# test/metabase/analyze @metabase/drivers
 
-src/metabase/sync @metabase/drivers
-test/metabase/sync @metabase/drivers
+# src/metabase/api @metabase/devexp
+# test/metabase/api @metabase/devexp
+
+# src/metabase/audit @metabase/core-backend-admin-webapp
+# test/metabase/audit @metabase/core-backend-admin-webapp
+
+# src/metabase/auth_provider @metabase/core-backend-admin-webapp
+# test/metabase/auth_provider @metabase/core-backend-admin-webapp
+
+# src/metabase/bookmarks @metabase/core-backend-admin-webapp
+# test/metabase/bookmarks @metabase/core-backend-admin-webapp
+
+# src/metabase/cmd @metabase/devexp
+# test/metabase/cmd @metabase/devexp
+
+# src/metabase/channel @metabase/core-workflows
+# test/metabase/channel @metabase/core-workflows
+
+# src/metabase/cloud_migration @metabase/core-workflows
+# test/metabase/cloud_migration @metabase/core-workflows
+
+# src/metabase/cmd @metabase/devexp
+# test/metabase/cmd @metabase/devexp
+
+# src/metabase/config @metabase/devexp
+# test/metabase/config @metabase/devexp
+
+# src/metabase/core @metabase/devexp
+# test/metabase/core @metabase/devexp
+
+# src/metabase/db @metabase/core-backend-admin-webapp
+# test/metabase/db @metabase/core-backend-admin-webapp
+
+# src/metabase/driver @metabase/drivers
+# test/metabase/driver @metabase/drivers
+
+# src/metabase/eid_translation @metabase/core-backend-admin-webapp
+# test/metabase/eid_translation @metabase/core-backend-admin-webapp
+
+# src/metabase/embed @metabase/embedding
+# test/metabase/embed @metabase/embedding
+
+# src/metabase/events @metabase/devexp
+# test/metabase/events @metabase/devexp
+
+# src/metabase/formatter @metabase/core-backend-querying
+# test/metabase/formatter @metabase/core-backend-querying
+
+# src/metabase/indexed_entities @metabase/core-backend-querying
+# test/metabase/indexed_entities @metabase/core-backend-querying
+
+# src/metabase/integrations @metabase/core-workflows
+# test/metabase/integrations @metabase/core-workflows
+
+# src/metabase/legacy_mbql @metabase/core-backend-querying
+# test/metabase/legacy_mbql @metabase/core-backend-querying
+
+# src/metabase/lib @metabase/core-backend-querying
+# test/metabase/lib @metabase/core-backend-querying
+
+# src/metabase/logger @metabase/devexp
+# test/metabase/logger @metabase/devexp
+
+# src/metabase/login_history @metabase/core-backend-admin-webapp
+# test/metabase/login_history @metabase/core-backend-admin-webapp
+
+# src/metabase/model_persistence @metabase/core-backend-querying
+# test/metabase/model_persistence @metabase/core-backend-querying
+
+# src/metabase/models @metabase/devexp
+# test/metabase/models @metabase/devexp
+
+# src/metabase/moderation @metabase/core-backend-admin-webapp
+# test/metabase/moderation @metabase/core-backend-admin-webapp
+
+# src/metabase/notification @metabase/core-workflows
+# test/metabase/notification @metabase/core-workflows
+
+# src/metabase/permissions @metabase/core-backend-admin-webapp
+# test/metabase/permissions @metabase/core-backend-admin-webapp
+
+# src/metabase/plugins @metabase/devexp
+# test/metabase/plugins @metabase/devexp
+
+# src/metabase/premium_features @metabase/core-backend-admin-webapp
+# test/metabase/premium_features @metabase/core-backend-admin-webapp
+
+# src/metabase/public_settings @metabase/core-backend-admin-webapp
+# test/metabase/public_settings @metabase/core-backend-admin-webapp
+
+# src/metabase/public_sharing @metabase/core-backend-admin-webapp
+# test/metabase/public_sharing @metabase/core-backend-admin-webapp
+
+# src/metabase/pulse @metabase/core-workflows
+# test/metabase/pulse @metabase/core-workflows
+
+# src/metabase/query_analysis @metabase/core-backend-querying
+# test/metabase/query_analysis @metabase/core-backend-querying
+
+# src/metabase/query_processor @metabase/core-backend-querying
+# test/metabase/query_processor @metabase/core-backend-querying
+
+# src/metabase/request @metabase/devexp
+# test/metabase/request @metabase/devexp
+
+# src/metabase/revisions @metabase/core-backend-admin-webapp
+# test/metabase/revisions @metabase/core-backend-admin-webapp
+
+# src/metabase/sample_data @metabase/core-backend-admin-webapp
+# test/metabase/sample_data @metabase/core-backend-admin-webapp
+
+# src/metabase/search @metabase/core-workflows
+# test/metabase/search @metabase/core-workflows
+
+# src/metabase/segments @metabase/core-backend-querying
+# test/metabase/segments @metabase/core-backend-querying
+
+# src/metabase/server @metabase/devexp
+# test/metabase/server @metabase/devexp
+
+# src/metabase/session @metabase/core-backend-admin-webapp
+# test/metabase/session @metabase/core-backend-admin-webapp
+
+# src/metabase/setup @metabase/core-backend-admin-webapp
+# test/metabase/setup @metabase/core-backend-admin-webapp
+
+# src/metabase/sso @metabase/core-backend-admin-webapp
+# test/metabase/sso @metabase/core-backend-admin-webapp
+
+# src/metabase/sync @metabase/drivers
+# test/metabase/sync @metabase/drivers
+
+# src/metabase/task @metabase/devexp
+# test/metabase/task @metabase/devexp
+
+# src/metabase/tiles @metabase/core-backend-dashviz
+# test/metabase/tiles @metabase/core-backend-dashviz
+
+# src/metabase/timeline @metabase/core-backend-dashviz
+# test/metabase/timeline @metabase/core-backend-dashviz
+
+# src/metabase/types @metabase/core-backend-querying
+# test/metabase/types @metabase/core-backend-querying
+
+# src/metabase/upload @metabase/core-backend-admin-webapp
+# test/metabase/upload @metabase/core-backend-admin-webapp
+
+# src/metabase/user_key_value @metabase/core-backend-admin-webapp
+# test/metabase/user_key_value @metabase/core-backend-admin-webapp
+
+# src/metabase/util @metabase/devexp
+# test/metabase/util @metabase/devexp
+
+# src/metabase/xrays @metabase/core-backend-querying
+# test/metabase/xrays @metabase/core-backend-querying

.github/PULL_REQUEST_TEMPLATE.md

@@ -3,7 +3,7 @@
 
 > **Warning**
 >
-> If that is your first contribution to Metabase, please sign the [Contributor License Agreement](https://docs.google.com/a/metabase.com/forms/d/1oV38o7b9ONFSwuzwmERRMi9SYrhYeOrkbmNaq9pOJ_E/viewform) (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our [POEditor project](https://poeditor.com/join/project/ynjQmwSsGh) instead of opening a PR.
+> If that is your first contribution to Metabase, please sign the [Contributor License Agreement](https://docs.google.com/a/metabase.com/forms/d/1oV38o7b9ONFSwuzwmERRMi9SYrhYeOrkbmNaq9pOJ_E/viewform) (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our [Crowdin project](https://crowdin.com/project/metabase-i18n) instead of opening a PR.
 
 Closes https://github.com/metabase/metabase/issues/[issue_number]
 

.github/PULL_REQUEST_TEMPLATE/cypress_repro.md

@@ -5,7 +5,7 @@ PENDING CI / PENDING REVIEW / READY _(choose one and update accordingly)_
 - Reproduces #XXXXX
 
 ### How to test this manually?
-- `yarn test-cypress-open`
+- `yarn test-cypress`
 - `relative/path/to/the/file`
 > _(For still unfixed bug)_
 - Replace `it.skip()` with `it.only()` to run the test in isolation

.github/actions/build-ee-extra/action.yml

@@ -1,132 +0,0 @@
-name: Build ee-extra
-description: Build Metabase Enterprise Edition with extra features
-
-inputs:
-  java-version:
-    required: true
-    # build with Java 11 since that's still officially what we target as a minimum and we don't want Java >11 bytecode
-    # sneaking in.
-    default: 11
-  iam-role:
-    description: "The IAM role to assume"
-    required: true
-
-runs:
-  using: composite
-  steps:
-    - name: Prepare Java
-      uses: actions/setup-java@v3
-      with:
-        java-version: ${{ inputs.java-version }}
-        distribution: 'temurin'
-    - name: Reveal its original version.properties
-      run: jar xf ./bin/docker/metabase.jar version.properties && cat version.properties
-      shell: bash
-    - name: get major version
-      id: major_version
-      run: echo "major_version=$(cat version.properties | grep 'tag=' | cut -d'.' -f2)" >> $GITHUB_OUTPUT
-      shell: bash
-    - name: get drivers registry
-      run: |
-        curl -OL https://raw.githubusercontent.com/metabase/metabase-registry/main/registry.yaml
-      shell: bash
-    - uses: actions/setup-node@v4
-      with:
-        node-version: lts/Hydrogen # 18.x.x
-    - run: rm package.json && npm install yaml
-      shell: bash
-    - name: parse drivers registry
-      uses: actions/github-script@v7
-      id: drivers_registry
-      with:
-        script: | # js
-          const { parse } = require('yaml');
-          const fs = require('fs');
-          const registry = parse(fs.readFileSync('registry.yaml', 'utf8'));
-
-          const drivers = registry.drivers;
-          const majorVersion = '${{ steps.major_version.outputs.major_version }}';
-
-          const getDriverUrl = (driverName) => {
-            const driver = drivers.find(driver => driver.name === driverName);
-
-            if (!driver) {
-              throw new Error(`Driver ${driverName} not found in the registry`);
-            }
-
-            const driverUrl = driver.versions[majorVersion] ?? driver.versions.default;
-
-            if (!driverUrl) {
-              throw new Error(`Driver ${driverName} version ${majorVersion} not found in the registry`);
-            }
-
-            return driverUrl;
-          };
-
-          const extraDrivers = {
-            firebolt: getDriverUrl('firebolt'),
-            starburst: getDriverUrl('starburst'),
-            exasol: getDriverUrl('exasol'),
-            exasol_jdbc: drivers.find(d => d.name === 'exasol').deps[0],
-            clickhouse: getDriverUrl('clickhouse'),
-            ocient: getDriverUrl('ocient'),
-            materialize: getDriverUrl('materialize'),
-          };
-
-          console.log(extraDrivers);
-
-          return extraDrivers;
-    - name: Download Firebolt driver
-      run: |
-        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).firebolt }}
-      working-directory: modules
-      shell: bash
-    - name: Download Starburst driver
-      run: |
-        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).starburst }}
-      shell: bash
-      working-directory: modules
-    - name: Download Exasol driver
-      run: |
-        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).exasol }}
-        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).exasol_jdbc }}
-      shell: bash
-      working-directory: modules
-    - name: Download Clickhouse driver
-      run: |
-        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).clickhouse }}
-      shell: bash
-      working-directory: modules
-    - name: Download Ocient driver
-      run: |
-        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).ocient }}
-      shell: bash
-      working-directory: modules
-    - name: Download Materialize driver
-      run: |
-        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).materialize }}
-      shell: bash
-      working-directory: modules
-    - name: Bundle additional drivers into the Uberjar
-      run: jar uf bin/docker/metabase.jar modules/*.jar
-      shell: bash
-    - name: Launch uberjar
-      run: >-
-        java --add-opens java.base/java.nio=ALL-UNNAMED -jar ./bin/docker/metabase.jar &
-      shell: bash
-    - name: Wait for Metabase to start
-      run: while ! curl 'http://localhost:3000/api/health' | grep '{"status":"ok"}'; do sleep 1; done
-      shell: bash
-    - name: Kill the java process
-      run: pkill -f metabase.jar
-      shell: bash
-    - name: configure aws credentials
-      if: ${{ github.ref_name == 'master' }}
-      uses: aws-actions/configure-aws-credentials@v4
-      with:
-        role-to-assume: ${{ inputs.iam-role }}
-        role-session-name: GitHub_to_AWS_via_FederatedOIDC
-        aws-region: us-east-1
-    - name: Login to Amazon ECR
-      if: ${{ github.ref_name == 'master' }}
-      uses: aws-actions/amazon-ecr-login@v2

.github/actions/create-backport/action.yml

@@ -0,0 +1,110 @@
+name: Create Backport PR
+
+inputs:
+  target-version: # major version number like 34 or 86
+    required: true
+  backport-commit:
+    required: true
+  github-token:
+    required: true
+  github-token-2: # need a second token to approve the PR
+    required: true
+
+runs:
+  using: "composite"
+  steps:
+    - id: create_backport_pull_request
+      name: Create backport pull request
+      env:
+        TARGET_VERSION: ${{ inputs.target-version }}
+        TARGET_BRANCH: release-x.${{ inputs.target-version }}.x
+        ORIGINAL_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
+        ORIGINAL_TITLE: ${{ github.event.pull_request.title }}
+        GITHUB_TOKEN: ${{ inputs.github-token }}
+        COMMIT: ${{ inputs.backport-commit }}
+      shell: bash
+      run: | # bash
+        git config --global user.email "metabase-bot@metabase.com"
+        git config --global user.name "Metabase bot"
+
+        BACKPORT_BRANCH="backport-$TARGET_VERSION-$COMMIT"
+
+        # Checkout the target branch and create a new backport branch
+        git checkout ${TARGET_BRANCH}
+        git fetch --all
+        git checkout -b ${BACKPORT_BRANCH}
+        git cherry-pick ${COMMIT} || true
+
+        CONFLICT_LIST=$(git ls-files -u)
+
+        CONFLICTS=$(git ls-files -u | wc -l)
+        if [ "$CONFLICTS" -gt 0 ]; then
+          git cherry-pick --abort
+
+          echo "Could not cherry pick because of a conflict"
+          echo "has-conflicts=true" >> $GITHUB_OUTPUT
+
+          # Add a shell script for resolving conflicts
+          echo "git reset HEAD~1" > ./backport.sh
+          echo "rm ./backport.sh" >> ./backport.sh
+          echo "git cherry-pick ${COMMIT}" >> ./backport.sh
+          echo "echo 'Resolve conflicts and force push this branch.\n\nTo backport translations run: bin/i18n/merge-translations <release-branch>'" >> ./backport.sh
+          chmod +x ./backport.sh
+          git add ./backport.sh
+          git commit -m "Add backport resolution script"
+
+          PR_BODY=$(cat <<-END
+          #${ORIGINAL_PULL_REQUEST_NUMBER}
+          > [!IMPORTANT]
+          > Manual conflict resolution is required.
+          > Checkout the branch and run \`./backport.sh\` script. Force push your changes after cherry-picking. Check the box below when done.
+
+          Conflicts:
+          \`\`\`shell
+          ${CONFLICT_LIST}
+          \`\`\`
+
+          - [ ] Conflicts resolved
+        END
+          )
+        else
+          echo "has-conflicts=false" >> $GITHUB_OUTPUT
+          PR_BODY="#${ORIGINAL_PULL_REQUEST_NUMBER}"
+        fi
+
+        git push -u origin ${BACKPORT_BRANCH}
+
+        BACKPORT_PR_URL=$(gh pr create --base "${TARGET_BRANCH}" --head "${BACKPORT_BRANCH}" --label "was-backported" --assignee "${GITHUB_ACTOR}" --title "🤖 backported \"${ORIGINAL_TITLE}\"" --body "${PR_BODY}")
+        BACKPORT_PR_NUMBER=${BACKPORT_PR_URL##*/}
+
+        echo "backport_pr_number=$BACKPORT_PR_NUMBER" >> $GITHUB_OUTPUT
+        echo "New PR has been created: #${BACKPORT_PR_NUMBER}"
+
+        git checkout ${{ github.sha }}
+
+    - name: Auto approve backport PR
+      if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
+      uses: juliangruber/approve-pull-request-action@v1
+      with:
+        github-token: ${{ inputs.github-token-2 }}
+        number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
+
+    - name: Enable Pull Request Automerge
+      if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
+      uses: peter-evans/enable-pull-request-automerge@v2
+      with:
+        token: ${{ inputs.github-token }}
+        pull-request-number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
+        merge-method: squash
+
+    - uses: ./.github/actions/notify-pull-request
+      if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'true' }}
+      with:
+        include-log: false
+        message: Manual conflict resolution is required on \#${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
+
+    - uses: ./.github/actions/notify-pull-request
+      if: ${{ failure() }}
+      with:
+        include-log: true
+        message: Something went wrong while creating backport

.github/actions/fetch-artifact/action.yml

@@ -0,0 +1,63 @@
+name: Fetch artifact
+description: Fetches a specific artifact and downloads it to the current directory
+
+inputs:
+  name:
+    description: The name of the artifact to fetch
+    required: true
+
+runs:
+  using: "composite"
+  steps:
+    - name: find_release_artifact
+      id: find_release_artifact
+      uses: actions/github-script@v7
+      with:
+        result-encoding: string
+        script: | # js
+          const fs = require('fs');
+
+          const artifacts = await github.rest.actions.listArtifactsForRepo({
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            name: "${{ inputs.name }}",
+            per_page: 1,
+          });
+
+          if (!artifacts.data?.artifacts?.[0]?.id) {
+            throw new Error(`No artifacts found for ${{ inputs.commit }}`);
+          }
+
+          const artifact_id = artifacts.data.artifacts[0].id;
+
+          const download = await github.rest.actions.downloadArtifact({
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            artifact_id: artifact_id,
+            archive_format: 'zip',
+          });
+
+          fs.writeFileSync(`${process.env.GITHUB_WORKSPACE}/mb.zip`, Buffer.from(download.data));
+
+    - name: unzip uberjar artifact
+      shell: bash
+      run: unzip mb.zip
+    - name: Move the Uberjar
+      shell: bash
+      run: | # bash
+        if [ -e "metabase.jar" ]; then
+          echo "metabase.jar is already in the right place"
+        elif [ -e "target/uberjar/metabase.jar" ]; then
+            echo "moving metabase.jar to current directory"
+          mv target/uberjar/metabase.jar metabase.jar
+        else
+          echo "Could not find the metabase.jar file"
+          exit 1
+        fi
+
+    - name: Verify that this is a valid JAR file
+      shell: bash
+      run: file --mime-type ./metabase.jar
+    - name: Reveal its version.properties
+      shell: bash
+      run: jar xf metabase.jar version.properties && cat version.properties

.github/actions/find-squashed-commit/action.yml

@@ -28,3 +28,5 @@ runs:
       env:
         PULL_REQUEST_NUMBER: ${{ inputs.pull-request-number }}
         BASE_REF: ${{ inputs.base-ref }}
+    - run: git checkout ${{ github.sha }} # return to original commit
+      shell: bash

.github/actions/get-latest-release-branch/action.yml

@@ -1,41 +0,0 @@
-name: Get latest release branch
-
-outputs:
-  branch-name:
-    value: ${{ steps.get-latest-release-branch.outputs.result }}
-
-runs:
-  using: "composite"
-  steps:
-    - uses: actions/github-script@v7
-      id: get-latest-release-branch
-      with:
-        result-encoding: string
-        script: |
-          const releaseBranches = await github.rest.git.listMatchingRefs({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            ref: "heads/release-x.",
-          });
-
-          const getVersionFromBranch = branch => {
-            const match = branch.match(/release-x\.(.*?)\.x$/);
-            return match && parseInt(match[1]);
-          };
-          const latestReleaseBranch = releaseBranches.data
-            .filter(branch => getVersionFromBranch(branch.ref) !== null)
-            .reduce(
-              (prev, current) =>
-                getVersionFromBranch(prev.ref) > getVersionFromBranch(current.ref)
-                  ? prev
-                  : current,
-              { ref: "" },
-            );
-          const latestReleaseBranchName = latestReleaseBranch.ref.replace(
-            /^refs\/heads\//,
-            "",
-          );
-
-          console.log(`Latest release branch: ${latestReleaseBranchName}`);
-
-          return latestReleaseBranchName;

.github/actions/notify-pull-request/action.yml

@@ -1,5 +1,13 @@
 name: Notify Pull Request
 inputs:
+  remove-previous-comment:
+    required: false
+    type: boolean
+    default: false
+  add-new-comment:
+    required: false
+    type: boolean
+    default: true
   message:
     required: true
   include-log:
@@ -9,12 +17,56 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - uses: actions/github-script@v7
-      id: get-latest-release-branch
+    - name: Remove previous pull-request comment
+      uses: actions/github-script@v7
+      if: ${{ inputs.remove-previous-comment == 'true' && always() && github.event_name == 'pull_request' }}
+      with:
+        script: |
+          const pr = context.payload.pull_request ?? context.payload.issue;
+
+          if (!pr) {
+           console.error("This action can only be run on pull requests");
+           return;
+          }
+
+          const { owner, repo } = context.repo;
+
+          const { data: comments } = await github.rest.issues.listComments({
+            owner,
+            repo,
+            issue_number: pr.number,
+          }).catch(console.error);
+
+          if (!comments) {
+            return;
+          }
+
+          const message = "${{ inputs.message }}";
+          const comment = comments.find((comment) => comment.body.includes(message));
+
+          if (comment) {
+            await github.rest.issues.deleteComment({
+              owner,
+              repo,
+              comment_id: comment.id,
+            });
+          }
+
+    - name: Notify pull-request
+      uses: actions/github-script@v7
+      if: ${{ inputs.add-new-comment == 'true' && always() && github.event_name == 'pull_request' }}
+      id: notify-pull-request
       with:
         result-encoding: string
-        script: |
-          const message = "${{ inputs.message }}"
+        script: | # js
+          const pr = context.payload.pull_request ?? context.payload.issue;
+
+          if (!pr) {
+            console.error("This action can only be run on pull requests");
+            return;
+          }
+
+          const message = "${{ inputs.message }}";
           const shouldIncludeLog = ${{ inputs.include-log }}.toString() === "true";
           const author = context.payload.sender.login;
 
@@ -27,7 +79,7 @@ runs:
           }
 
           github.rest.issues.createComment({
-            issue_number: context.payload.issue.number,
+            issue_number: pr.number,
             owner: context.repo.owner,
             repo: context.repo.repo,
             body,

.github/actions/prepare-cypress/action.yml

@@ -1,6 +1,12 @@
 name: Prepare cypress environment
 description: Cypress preparation steps
 
+inputs:
+  working-directory:
+    description: "Optional working directory for yarn commands"
+    required: false
+    default: "."
+
 outputs:
   chrome-path:
     description: Path to the custom Chrome executable
@@ -33,3 +39,4 @@ runs:
         yarn cypress cache list
         yarn cypress verify
       shell: bash
+      working-directory: ${{ inputs.working-directory }}

.github/actions/prepare-frontend/action.yml

@@ -33,18 +33,5 @@ runs:
         path: node_modules
         key: ${{ runner.os }}-node-modules-${{ hashFiles('**/yarn.lock', '**/patches/*.patch') }}
 
-    - name: Get yarn cache directory path
-      id: yarn-cache-dir-path
-      if: steps.node-modules-cache.outputs.cache-hit != 'true'
-      run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
-      shell: bash
-
-    - uses: actions/cache@v4
-      if: steps.node-modules-cache.outputs.cache-hit != 'true'
-      with:
-        path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-        key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-        restore-keys: ${{ runner.os }}-yarn-
-
     - run: yarn install --frozen-lockfile --prefer-offline
       shell: bash

.github/actions/test-driver/action.yml

@@ -23,6 +23,8 @@ runs:
       run: yarn build-static-viz
       shell: bash
       if: ${{ inputs.build-static-viz == 'true' }}
+      env:
+        MB_EDITION: ee
     - name: Test database driver
       run: clojure -X:dev:ci:ee:ee-dev:drivers:drivers-dev:test ${{ inputs.test-args }}
       shell: bash
@@ -36,3 +38,10 @@ runs:
         list-suites: failed
         list-tests: failed
         fail-on-error: false
+    - name: Upload Logs on Failure
+      if: failure()
+      uses: actions/upload-artifact@v4
+      with:
+        name: test-logs-${{ github.job }}
+        path: logs/test-log.json
+        retention-days: 1

.github/actions/upgrade-backend-deps/action.yml

@@ -0,0 +1,14 @@
+name: Create Backend Dep Bump PRs
+
+inputs:
+  github-token:
+    required: true
+
+runs:
+  using: "composite"
+  steps:
+    - name: Open PRs to Bump Backend Deps
+      env:
+        GITHUB_TOKEN: ${{ inputs.github-token }}
+      shell: bash
+      run: bash ${{ github.action_path }}/upgrade-deps.sh

.github/actions/upgrade-backend-deps/upgrade-deps.sh

@@ -0,0 +1,81 @@
+#! /usr/bin/env bash
+
+# Script is adapted from https://github.com/nnichols/clojure-dependency-update-action/blob/master/dependency-check.sh
+
+# make sure we're in the root dir of the metabase repo
+script_dir=`dirname "${BASH_SOURCE[0]}"`
+cd "$script_dir/../../.."
+
+echo `pwd`
+
+# Configure Git user opening PRs to the GH Actions bot.
+git config --global user.email "metabase-bot@metabase.com"
+git config --global user.name "Metabase bot"
+
+# Run antq to check for outdated dependencies and output to UPGRADE_LIST
+echo "::group::Checking for outdated dependencies"
+UPGRADE_LIST=$(clojure -M:outdated --reporter=format --error-format="{{name}},{{version}},{{latest-version}},{{diff-url}}")
+echo "$UPGRADE_LIST"
+echo "::endgroup::"
+
+# Parse the output of antq into a list of upgrades, and remove any failed fetches
+UPGRADES=$(echo ${UPGRADE_LIST} | sed '/Failed to fetch/d' | sed '/Unable to fetch/d' | sed '/Logging initialized/d' | sort -u)
+
+echo "::group::Upgrades"
+echo ${UPGRADES}
+echo "::endgroup::"
+
+# Make sure we're on master
+git checkout master
+
+# Iterate over all upgrades
+for upgrade in $UPGRADES; do
+
+  echo "::group::Processing upgrade"
+
+  # Parse each upgrade into its constituent parts
+  IFS=',' temp=($upgrade)
+  DEP_NAME=${temp[0]}
+  OLD_VERSION=${temp[1]}
+  NEW_VERSION=${temp[2]}
+  DIFF_URL=${temp[3]}
+  MODIFIED_FILE=${temp[4]}
+  BRANCH_NAME="dependencies/clojure/$DEP_NAME-$NEW_VERSION"
+
+  # Checkout the branch if it exists, otherwise create it
+  echo "Checking out" $BRANCH_NAME
+  git checkout $BRANCH_NAME || git checkout -b $BRANCH_NAME
+
+  # IF we successfully created a new branch, update the dependency
+  if [[ $? == 0 ]]; then
+
+    # Use antq to update the dependency
+    echo "Updating" $DEP_NAME "version" $OLD_VERSION "to" $NEW_VERSION
+    UPDATE_CMD="clojure -M:outdated --upgrade --force --focus=${DEP_NAME}"
+    eval ${UPDATE_CMD} || $(echo "Cannot update ${DEP_NAME}. Continuing" && git checkout master && continue)
+
+    TITLE="Bump $DEP_NAME from $OLD_VERSION to $NEW_VERSION"
+    BODY="Inspect dependency changes here: $DIFF_URL"
+
+    # Commit the dependency update, and link to the diff
+    git add deps.edn modules
+    git commit -m ${TITLE} -m ${BODY} --no-verify
+    git push -u origin $BRANCH_NAME
+
+    # Open the PR
+    echo "Opening pull request for" $DEP_NAME
+    PR_URL=$(gh pr create --base master --head $BRANCH_NAME --label "no-backport" --title ${TITLE} --body ${BODY})
+    PR_NUMBER=${PR_URL##*/}
+    echo "Opened PR #$PR_NUMBER"
+
+    # Make the PR Auto-Merge
+    gh pr merge -R metabase/metabase --squash --auto "$PR_NUMBER"
+
+    # Print a blank line, and reset the branch
+    echo "Checking out master" master
+    git checkout master
+  fi
+
+  echo "::endgroup::"
+
+done

.github/actions/upload-test-results/action.yml

@@ -18,6 +18,9 @@ inputs:
     required: true
   trunk-api-token:
     required: true
+  variant:
+    required: false
+    default: ''
 
 runs:
   using: "composite"
@@ -45,10 +48,11 @@ runs:
         aws s3 cp ${OUTPUT_FILE}.zip s3://$BUCKET/$DATE/$GITHUB_RUN_ID/$GITHUB_RUN_ATTEMPT/
 
     - name: Upload results to Trunk
-      if: ${{ always() }}
+      if: ${{ always() && !(github.event_name == 'pull_request' && github.event.pull_request.draft == true) }}
       uses: trunk-io/analytics-uploader@main
       with:
         junit-paths: ${{ inputs.input-path }}
+        variant: ${{ inputs.variant || inputs.output-name }}
         org-slug: metabase
         token: ${{ inputs.trunk-api-token }}
       continue-on-error: true

.github/auto_request_review.yml

@@ -6,7 +6,7 @@ files:
   # migrations related files
   'resources/migrations/**':
     - team:core-workflows
-  'src/metabase/db/custom_migrations.clj':
+  'src/metabase/app_db/custom_migrations.clj':
     - team:core-workflows
 
 options:

.github/file-paths.yaml

@@ -5,6 +5,7 @@ default: &default
 shared_sources: &shared_sources
   - "src/**/*.cljc"
   - "src/**/*.cljs"
+  - "package.json"
 
 shared_specs: &shared_specs
   - "test/**/*.cljc"
@@ -25,16 +26,22 @@ frontend_sources: &frontend_sources
   - "babel.config.json"
   - ".eslintrc.js"
   - "postcss.config.js"
+  - "rspack.config.js"
   - "webpack.config.js"
   - "webpack.embedding-sdk.config.js"
   - "webpack.static-viz.config.js"
   - ".nvmrc"
 
+frontend_embedding_sdk_sources:
+  - *frontend_sources
+
 frontend_specs: &frontend_specs
   - *shared_specs
   - "frontend/test/**"
   - "frontend/**/tests/**"
   - "frontend/**/*.unit.*"
+  - "enterprise/frontend/**/*.unit.*"
+  - ".github/**/*.unit.spec.*"
   - "jest.config.js"
   - "jest.tz.unit.conf.json"
 
@@ -93,37 +100,44 @@ sources: &sources
   - *backend_sources
 
 e2e_ci: &e2e_ci
-  - ".github/actions/build-e2e-matrix/**"
   - ".github/actions/prepare-frontend/**"
   - ".github/actions/prepare-backend/**"
   - ".github/actions/prepare-uberjar-artifact/**"
   - ".github/actions/e2e-prepare-containers/**"
   - ".github/actions/prepare-cypress/**"
   - ".github/actions/run-snowplow-micro/**"
-  - ".github/workflows/e2e-tests.yml"
+  - ".github/workflows/e2e-*"
 
 e2e_specs: &e2e_specs
   - "**/*.cy.*.js"
   - "**/*.cy.*.ts"
-  - "e2e/runner/**"
-  - "e2e/support/**"
-  - "e2e/snapshot*/**"
 
 e2e_cross_version: &e2e_cross_version
   - ".github/workflows/e2e-cross-version.yml"
   - "e2e/test/scenarios/cross-version/**"
 
+e2e_embedding_sdk_compatibility:
+  - *default
+  - *e2e_ci
+  - *frontend_sources
+  - "e2e/embedding-sdk-host-apps/**"
+  - "e2e/runner/embedding-sdk/**"
+  - "e2e/runner/test-host-app/**/*.cy.*.js"
+  - "e2e/runner/test-host-app/**/*.cy.*.ts"
+
 e2e_all:
   - *default
   - *e2e_ci
   - *sources
   - *e2e_specs
+  - "e2e/**"
 
 snowplow:
   - ".github/workflows/snowplow.yml"
   - "snowplow/**"
 
 documentation:
+  - ".typedoc/**"
   - "docs/**"
   - "**/*.md"
 

.github/scripts/build-e2e-matrix.js

@@ -0,0 +1,84 @@
+// This script is used in .github/workflows/e2e-matrix-builder.yml
+// its aim is to split the e2e test matrix into multiple jobs
+// grouping some specific tests together, other tests are split into chunks
+
+const DEFAULT_SPEC_PATTERN = "./e2e/test/scenarios/**/*.cy.spec.*";
+const EMBEDDING_SDK_SPEC_PATTERN =
+  "./e2e/test/scenarios/embedding-sdk/**.cy.spec.*";
+
+const specialTestConfigs = [
+  {
+    name: "embedding-sdk",
+    specs: EMBEDDING_SDK_SPEC_PATTERN,
+  },
+  {
+    name: "oss-subset",
+    edition: "oss",
+    tags: "@OSS @smoke+-@EE",
+    specs: DEFAULT_SPEC_PATTERN,
+  },
+  { name: "mongo", tags: "@mongo", specs: DEFAULT_SPEC_PATTERN },
+];
+
+/**
+ *
+ * @param {*} inputSpecs - specs, which were changed in the PR, separated by comma
+ * .e.g e2e/test/scenarios/onboarding/command-palette.cy.spec.js,e2e/test/scenarios/question/document-title.cy.spec.js
+ * or a pattern like DEFAULT_SPEC_PATTERN
+ */
+function buildMatrix(options, inputSpecs, inputChunks) {
+  const { java, defaultRunner } = options;
+
+  // number of specs per chunk when running specific specs
+  const SPECS_PER_CHUNK = 5;
+
+  const defaultOptions = {
+    "java-version": java,
+    runner: defaultRunner,
+    edition: "ee",
+  };
+
+  const isDefaultSpecPattern =
+    inputSpecs === "" || inputSpecs === DEFAULT_SPEC_PATTERN;
+
+  console.log("Processed specs value:", inputSpecs);
+  console.log("Is default pattern:", isDefaultSpecPattern);
+
+  let regularChunks;
+  if (isDefaultSpecPattern) {
+    regularChunks = inputChunks - specialTestConfigs.length;
+  } else {
+    // when pattern is not default, it means we passed some custom list of the changed specs
+    // so we need to calculate how many chunks we need to run
+    const matchingSpecsCount = inputSpecs.split(",").length;
+    regularChunks = Math.max(
+      1,
+      Math.ceil(matchingSpecsCount / SPECS_PER_CHUNK),
+    );
+  }
+
+  const regularTests = new Array(regularChunks).fill(1).map((files, index) => ({
+    name: `e2e-group-${index + 1}`,
+    // works when specs less than 5, otherwise seems all chunks will contain
+    // same specs
+    ...(!isDefaultSpecPattern && {
+      specs: inputSpecs
+        .split(",")
+        .slice(SPECS_PER_CHUNK * index, SPECS_PER_CHUNK * (index + 1))
+        .join(","),
+    }),
+  }));
+
+  const testSets = isDefaultSpecPattern
+    ? regularTests.concat(specialTestConfigs)
+    : regularTests;
+
+  const config = testSets.map((options) => ({
+    ...defaultOptions,
+    ...options,
+  }));
+
+  return { config, regularChunks, isDefaultSpecPattern };
+}
+
+module.exports = { buildMatrix };

.github/scripts/build-e2e-matrix.unit.spec.js

@@ -0,0 +1,97 @@
+const { buildMatrix } = require("./build-e2e-matrix");
+
+describe("buildMatrix", () => {
+  const options = {
+    java: "11",
+    defaultRunner: "ubuntu-22.04",
+  };
+  const testBuildMatrix = (entry, chunks) =>
+    buildMatrix(options, entry, chunks);
+
+  it("should calculate correct regular chunks with default parameters", () => {
+    const result = testBuildMatrix("./e2e/test/scenarios/**/*.cy.spec.*", 30);
+
+    expect(result.regularChunks).toBe(27);
+  });
+
+  it("should create correct number of configuration objects", () => {
+    const result = testBuildMatrix("./e2e/test/scenarios/**/*.cy.spec.*", 10);
+
+    expect(result.config.length).toBe(10);
+  });
+
+  it("should apply default specs path when empty entry is provided", () => {
+    const result = testBuildMatrix("", 5);
+
+    expect(result.regularChunks).toBe(2);
+    expect(result.config.length).toBe(5);
+  });
+
+  it("should name regular test groups sequentially", () => {
+    const result = testBuildMatrix("./e2e/test/scenarios/**/*.cy.spec.*", 10);
+    const regularTests = result.config.filter((cfg) =>
+      cfg.name.startsWith("e2e-group-"),
+    );
+
+    regularTests.forEach((test, index) => {
+      expect(test.name).toBe(`e2e-group-${index + 1}`);
+    });
+  });
+
+  it("should handle case when input chunks equals special tests count", () => {
+    const result = testBuildMatrix("./e2e/test/scenarios/**/*.cy.spec.*", 3);
+
+    expect(result.regularChunks).toBe(0);
+    expect(result.config.length).toBe(3);
+    expect(result.config[0].name).toBe("embedding-sdk");
+    expect(result.config[1].name).toBe("oss-subset");
+    expect(result.config[2].name).toBe("mongo");
+  });
+
+  it("should correctly calculate regularChunks for non-default spec pattern", () => {
+    const entry = "file.cy.spec.js,".repeat(12).slice(0, -1);
+    const result = testBuildMatrix(entry, 10);
+
+    // For 12 matching specs with SPECS_PER_CHUNK=5, we expect ceil(12/5) = 3 chunks
+    expect(result.regularChunks).toBe(3);
+
+    const firstGroupSpecs = result.config[0].specs.split(",").length;
+    const secondGroupSpecs = result.config[1].specs.split(",").length;
+    const thirdGroupSpecs = result.config[2].specs.split(",").length;
+
+    expect(firstGroupSpecs).toBe(5);
+    expect(secondGroupSpecs).toBe(5);
+    expect(thirdGroupSpecs).toBe(2);
+  });
+
+  it("should return isDefaultSpecPattern as true when empty or default value is provided", () => {
+    let result = testBuildMatrix("", 5);
+
+    expect(result.isDefaultSpecPattern).toBe(true);
+
+    result = testBuildMatrix("./e2e/test/scenarios/**/*.cy.spec.*", 5);
+
+    expect(result.isDefaultSpecPattern).toBe(true);
+  });
+
+  it("should return isDefaultSpecPattern as false when non-default spec pattern is provided", () => {
+    const result = testBuildMatrix("test1.cy.spec.js,test2.cy.spec.js", 1);
+
+    expect(result.isDefaultSpecPattern).toBe(false);
+  });
+
+  it("should return special test configs when default spec pattern is provided", () => {
+    const result = testBuildMatrix("./e2e/test/scenarios/**/*.cy.spec.*", 50);
+
+    expect(result.config[47].name).toBe("embedding-sdk");
+    expect(result.config[48].name).toBe("oss-subset");
+    expect(result.config[49].name).toBe("mongo");
+  });
+
+  it("should not return special test configs when non-default spec pattern is provided", () => {
+    const result = testBuildMatrix("test1.cy.spec.js,test2.cy.spec.js", 50);
+
+    expect(result.config.length).toBe(1);
+    expect(result.config[0].name).toBe("e2e-group-1");
+  });
+});

.github/scripts/update-pr-with-issues.js

@@ -0,0 +1,241 @@
+const https = require('https');
+
+function getLinkedIssues(body) {
+  const matches = body.match(
+    /(close(s|d)?|fixe?(s|d)?|resolve(s|d)?)(:?) (#|https?:\/\/github\.com\/.+metabase\/issues\/)(\d+)/gi,
+  );
+
+  if (matches) {
+    console.log(`Matches: ${matches}`);
+    return matches.map(m => {
+      const numberMatch = m.match(/\d+/);
+      return numberMatch ? numberMatch[0] : null;
+    });
+  }
+
+  return [];
+}
+
+// Function to make HTTPS requests
+function httpsRequest(options, data = null) {
+  return new Promise((resolve, reject) => {
+    const req = https.request(options, (res) => {
+      let responseData = '';
+      res.on('data', (chunk) => {
+        responseData += chunk;
+      });
+      res.on('end', () => {
+        if (res.statusCode >= 200 && res.statusCode < 300) {
+          try {
+            resolve(JSON.parse(responseData));
+          } catch (e) {
+            resolve(responseData);
+          }
+        } else {
+          reject(new Error(`Request failed with status code ${res.statusCode}: ${responseData}`));
+        }
+      });
+    });
+
+    req.on('error', (error) => {
+      reject(error);
+    });
+
+    if (data) {
+      req.write(data);
+    }
+
+    req.end();
+  });
+}
+
+// Makes an HTTPS request with exponential backoff retry logic
+async function httpsRequestWithBackoff(options, data = null, backoffOptions = {}) {
+  // Set default backoff options:
+  const {
+    maxRetries = 8,
+    totalDurationSeconds = 60
+  } = backoffOptions;
+
+  let retries = 0;
+  let delay = 500; // Start with a .5 second delay
+
+  // Calculate a reasonable initial delay based on total duration and max retries
+  // This helps distribute the retry attempts across the total allowed duration
+  const totalDurationMs = totalDurationSeconds * 1000;
+
+  // Track the start time
+  const startTime = Date.now();
+
+  // Ensure data is stringified if it's an object
+  const requestData = data ? (typeof data === 'string' ? data : JSON.stringify(data)) : null;
+
+  while (true) {
+    try {
+      const response = await httpsRequest(options, requestData);
+      return response; // Success: Return the data
+
+    } catch (error) {
+      retries++;
+
+      const elapsedMs = Date.now() - startTime;
+      const timeRemaining = totalDurationMs - elapsedMs;
+
+      // Stop retrying if we've hit max retries or exceeded the total duration
+      if (retries >= maxRetries || timeRemaining <= 0) {
+        console.error(`Failed after ${retries} retries (${Math.round(elapsedMs/1000)}s elapsed):`);
+        throw error;
+      }
+
+      // Calculate the next delay with exponential backoff and jitter
+      delay = Math.min(delay * 2 * (0.8 + Math.random() * 0.4), timeRemaining);
+
+      console.log(`Request failed (attempt ${retries}/${maxRetries}). Retrying in ${Math.round(delay)}ms... (${Math.round(timeRemaining/1000)}s remaining)`);
+
+      // Wait for the calculated delay before trying again
+      await new Promise(resolve => setTimeout(resolve, delay));
+    }
+  }
+}
+
+async function link_issues(github) {
+
+  try {
+    // Get environment variables
+    const githubToken = process.env.GITHUB_TOKEN;
+    const linearApiKey = process.env.LINEAR_API_KEY;
+    const prNumber = process.env.PR_NUMBER;
+    const repoOwner = process.env.REPO_OWNER;
+    const repoName = process.env.REPO_NAME;
+
+    if (!githubToken || !linearApiKey || !prNumber || !repoOwner || !repoName) {
+      console.error('Missing required environment variables');
+      process.exit(1);
+    }
+
+    // Get PR details from GitHub API
+    const prInfo = await github.rest.issues.get({
+      owner: repoOwner,
+      repo: repoName,
+      issue_number: prNumber
+    }).catch((err) => {
+      console.log("error getting prInfo:\n" + err);
+    });
+
+    console.log('PR Info:\n' + JSON.stringify(prInfo, null, 2) + "\n");
+
+    if (prInfo &&
+        prInfo.data &&
+        prInfo.data.labels &&
+        prInfo.data.labels.some(label => label.name === "no-auto-issue-links")) {
+      console.log('PR has "no-auto-issue-links" label, skipping...');
+      return;
+    }
+
+    const prUrl = prInfo.data.html_url;
+    console.log(`Processing PR: ${prUrl}`);
+
+    // Query Linear API to find tasks linked to this PR
+    const linearQuery = JSON.stringify({
+      query: `
+        query {
+          attachmentsForURL(url: "${prUrl}") {
+            nodes {
+              issue {
+                id
+                identifier
+                attachments {
+                  nodes {url}}}}}}`});
+
+    console.log('--- Linear API query ---');
+    console.log(linearQuery);
+    console.log('----- End of query -----');
+
+    const linearData = await httpsRequestWithBackoff({
+      hostname: 'api.linear.app',
+      path: '/graphql',
+      method: 'POST',
+      headers: {
+        'Content-Type': 'application/json',
+        'Authorization': linearApiKey
+      }
+    },
+    linearQuery,
+    { maxRetries: 8, totalDurationSeconds: 60 });
+
+    console.log('Linear API response:');
+    console.log(JSON.stringify(linearData) + "\n");
+
+    if (!linearData.data || !linearData.data.attachmentsForURL || linearData.data.attachmentsForURL.nodes.length === 0) {
+      console.log('No Linear tasks linked to this PR');
+      return;
+    } else {
+      console.log(`Found ${linearData.data.attachmentsForURL.nodes.length} linked Linear tasks`);
+    }
+
+
+    // Extract GitHub issue numbers from all attachments in the linked Linear task
+    const issueNumbers = [];
+    for (const node of linearData.data.attachmentsForURL.nodes) {
+      console.log(`checking node task: ${JSON.stringify(node)}`)
+      const linearIssue = node.issue;
+
+      for (const attachment of linearIssue.attachments.nodes) {
+        const url = attachment.url;
+        console.log(`-->  checking url: ${url}`)
+        const match = url.match(/github\.com\/metabase\/metabase\/issues\/(\d+)/);
+        if (match) {
+          console.log(`-->  found match: ${match[1]}`)
+          issueNumbers.push(match[1]);
+          console.log("")
+        }
+      }
+    }
+
+    console.log(`Found linked GitHub issues: ${JSON.stringify(issueNumbers)}`);
+
+    if (issueNumbers.length === 0) {
+      console.log(`Found linked GitHub issues: ${JSON.stringify(issueNumbers)}`);
+      console.log('No GitHub issues linked to the Linear task');
+      return;
+    }
+
+    let body = prInfo.data.body || '';
+
+    let linked_issues = getLinkedIssues(body);
+    console.log(`Linked issues: ${linked_issues}`);
+
+    let newBody = body || '';
+
+    let issueNumbersToAdd = issueNumbers.filter(num => !linked_issues.includes(num));
+
+    console.log(`Issue numbers to add: ${issueNumbersToAdd}`);
+
+    if (issueNumbersToAdd.length > 0) {
+
+      // Generate closing references
+      const closingRefs = issueNumbersToAdd.map(num => `closes #${num}`).join(' ');
+
+      const messagePreamble = "<!-- Added by 'Add Issue References to PR' GitHub Action. To disable linking, add 'no-auto-issue-links' label to your PR. -->"
+
+      newBody = `${messagePreamble} ${closingRefs}\n` + newBody;
+
+      // Update PR body with new closing references
+      await github.rest.issues.update({
+        owner: repoOwner,
+        repo: repoName,
+        issue_number: prNumber,
+        body: newBody
+      });
+
+      console.log(`Updated PR #${prNumber} with issue references:\n ${closingRefs}`);
+    } else {
+      console.log('PR already contains all closing references');
+    }
+  } catch (error) {
+    console.error('Error:', error.message);
+    process.exit(1);
+  }
+}
+
+module.exports = {link_issues};

.github/team.json

@@ -3,25 +3,30 @@
     {
       "name": "Querying",
       "label": ".Team/Querying",
-      "projectUrl": "https://github.com/orgs/metabase/projects/97/views/1",
       "members": [
         "ranquild",
-        "kamilmielnik",
         "romeovs",
         "bshepherdson",
         "metamben",
-        "lbrdnk",
         "appleby",
         "uladzimirdev",
         "wzimrin",
         "ericnormand",
-        "lorem--ipsum"
+        "galdre"
+      ]
+    },
+    {
+      "name": "Semantic Layer",
+      "label": ".Team/SemanticLayer",
+      "members": [
+        "kamilmielnik",
+        "lbrdnk",
+        "bronsa"
       ]
     },
     {
       "name": "Drivers",
       "label": ".Team/Drivers",
-      "projectUrl": "https://github.com/orgs/metabase/projects/98/views/1",
       "members": [
         "snoe",
         "rileythomp"
@@ -30,7 +35,6 @@
     {
       "name": "Embedding",
       "label": ".Team/Embedding",
-      "projectUrl": "https://github.com/orgs/metabase/projects/88/views/1",
       "members": [
         "WiNloSt",
         "oisincoveney",
@@ -42,26 +46,27 @@
     {
       "name": "Workflows",
       "label": ".Team/Workflows",
-      "projectUrl": "https://github.com/orgs/metabase/projects/50/views/1",
       "members": [
         "qnkhuat",
         "piranha",
         "crisptrutski",
-        "deniskaber"
+        "deniskaber",
+        "wotbrew",
+        "spalt08",
+        "stasgavrylov"
       ]
     },
     {
       "name": "Admin Webapp",
       "label": ".Team/AdminWebapp",
       "members": [
-        "noahmoss",
-        "escherize",
         "npfitz",
         "johnswanson",
         "rafpaf",
-        "sloansparger",
         "iethree",
-        "nvoxland"
+        "nvoxland",
+        "fraserdrops",
+        "edpaget"
       ]
     },
     {
@@ -70,16 +75,38 @@
       "members": [
         "alxnddr",
         "kulyk",
-        "adam-james-v",
-        "tsplude"
+        "tsplude",
+        "lorem--ipsum",
+        "noahmoss",
+        "bpander"
       ]
     },
     {
       "name": "DevEx",
       "label": ".Team/DevEx",
       "members": [
-        "camsaul"
+        "camsaul",
+        "escherize"
       ]
+    },
+     {
+      "name": "Metabot",
+      "label": ".Team/Metabot",
+      "members": [
+        "retro",
+        "sloansparger",
+        "somtom"
+      ]
+    },
+    {
+      "name": "Product Growth",
+      "label": ".Team/ProductGrowth",
+      "members": ["nemanjaglumac", "chodorowicz"]
+    },
+    {
+      "name": "Cloud",
+      "label": "cloud",
+      "members": []
     }
   ]
 }

.github/workflows/athena.yml

@@ -0,0 +1,38 @@
+name: Publish Athena JDBC Driver
+
+on:
+  workflow_dispatch:
+    inputs:
+      version:
+        description: 'Athena JDBC driver version to publish'
+        required: true
+        type: string
+
+jobs:
+  deploy:
+    name: Publish Athena JDBC Driver
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - name: Check out the code
+        uses: actions/checkout@v4
+
+      - name: Set up Babashka
+        uses: turtlequeue/setup-babashka@v1.7.0
+        with:
+          babashka-version: 1.12.197
+
+      - name: Set up AWS CLI
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          aws-access-key-id: ${{ secrets.AWS_S3_MAVEN_ACCESS_KEY_ID }}
+          aws-secret-access-key: ${{ secrets.AWS_S3_MAVEN_SECRET_ACCESS_KEY }}
+          aws-region: ${{ vars.AWS_REGION }}
+
+      - name: Deploy Athena JDBC driver
+        run: ./bin/athena.bb ${{ github.event.inputs.version }} --deploy
+
+      - name: Verify deployment
+        run: |
+          aws s3 ls s3://metabase-maven-downloads/com/metabase/athena-jdbc/${{ github.event.inputs.version }}/
+          echo "Athena JDBC driver version ${{ github.event.inputs.version }} has been deployed"

.github/workflows/auto-backport.yml

@@ -1,12 +1,18 @@
 name: Auto-backport
+run-name: Auto Backport ${{ github.event.pull_request.title }}
 on:
   pull_request:
     types: [closed, labeled]
 
 jobs:
   create-backport:
-    if: github.event.pull_request.merged == true && (contains(github.event.pull_request.labels.*.name, 'backport') && github.event.action == 'closed' || github.event.label.name == 'backport')
-    runs-on: ubuntu-22.04
+    if: | # the PR must be merged and have a backport label
+      github.event.pull_request.merged == true && (
+        contains(github.event.pull_request.labels.*.name, 'backport') ||
+        contains(github.event.pull_request.labels.*.name, 'double-backport') ||
+        contains(github.event.pull_request.labels.*.name, 'triple-backport')
+      )
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
@@ -19,91 +25,68 @@ jobs:
           pull-request-number: ${{ github.event.pull_request.number }}
           base-ref: ${{ github.event.pull_request.base.ref }}
 
-      - uses: ./.github/actions/get-latest-release-branch
-        name: Get latest release branch
-        id: get_latest_release_branch
-
-      - id: create_backport_pull_request
-        name: Create backport pull request
-        run: |
-          git config --global user.email "metabase-bot@metabase.com"
-          git config --global user.name "Metabase bot"
-
-          BACKPORT_BRANCH="backport-$COMMIT"
-
-          # Checkout the target branch and create a new backport branch
-          git checkout ${TARGET_BRANCH}
-          git fetch --all
-          git checkout -b ${BACKPORT_BRANCH}
-          git cherry-pick ${COMMIT} || true
-
-          CONFLICTS=$(git ls-files -u | wc -l)
-          if [ "$CONFLICTS" -gt 0 ]; then
-            git cherry-pick --abort
-
-            echo "Could not cherry pick because of a conflict"
-            echo "has-conflicts=true" >> $GITHUB_OUTPUT
-
-            # Add a shell script for resolving conflicts
-            echo "git reset HEAD~1" > ./backport.sh
-            echo "rm ./backport.sh" >> ./backport.sh
-            echo "git cherry-pick ${COMMIT}" >> ./backport.sh
-            echo "echo 'Resolve conflicts and force push this branch'" >> ./backport.sh
-            chmod +x ./backport.sh
-            git add ./backport.sh
-            git commit -m "Add backport resolution script"
-
-            PR_BODY=$(cat <<-END
-            #${ORIGINAL_PULL_REQUEST_NUMBER}
-            > [!IMPORTANT]
-            > Manual conflict resolution is required.
-            Checkout the branch and run \`./backport.sh\` script. Force push your changes after cherry-picking.
-          END
-            )
-          else
-            echo "has-conflicts=false" >> $GITHUB_OUTPUT
-            PR_BODY="#${ORIGINAL_PULL_REQUEST_NUMBER}"
-          fi
-
-          git push -u origin ${BACKPORT_BRANCH}
-
-          BACKPORT_PR_URL=$(gh pr create --base "${TARGET_BRANCH}" --head "${BACKPORT_BRANCH}" --label "was-backported" --assignee "${GITHUB_ACTOR}" --title "🤖 backported \"${ORIGINAL_TITLE}\"" --body "${PR_BODY}")
-          BACKPORT_PR_NUMBER=${BACKPORT_PR_URL##*/}
-
-          echo "backport_pr_number=$BACKPORT_PR_NUMBER" >> $GITHUB_OUTPUT
-          echo "New PR has been created"
-
-          git checkout master
-        env:
-          TARGET_BRANCH: ${{ steps.get_latest_release_branch.outputs.branch-name }}
-          ORIGINAL_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
-          ORIGINAL_TITLE: ${{ github.event.pull_request.title }}
-          GITHUB_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
-          COMMIT: ${{ steps.find_commit.outputs.commit }}
-
-      - name: Auto approve backport PR
-        if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
-        uses: juliangruber/approve-pull-request-action@v1
+      - name: how many backports?
+        id: how-many-backports
+        uses: actions/github-script@v7
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
+          script: | # js
+            const labels = [
+              ...${{ toJson(github.event.pull_request.labels) }},
+              { name:"${{ github.event.label.name }}" }
+            ];
 
-      - name: Enable Pull Request Automerge
-        if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
-        uses: peter-evans/enable-pull-request-automerge@v2
-        with:
-          token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
-          pull-request-number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
-          merge-method: squash
+            const backportLabelNames = labels.filter(label => label.name.includes('backport')).map(label => label.name);
 
-      - uses: ./.github/actions/notify-pull-request
-        if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'true' }}
-        with:
-          include-log: false
-          message: Manual conflict resolution is required
+            let result = 1;
 
-      - uses: ./.github/actions/notify-pull-request
-        if: ${{ failure() }}
+            if (backportLabelNames.includes("triple-backport")) {
+              result = 3;
+            } else if (backportLabelNames.includes("double-backport")) {
+              result = 2;
+            }
+
+            console.log("backports", result);
+            return result;
+
+      - name: get release versions
+        id: get-latest-release-version
+        uses: actions/github-script@v7
         with:
-          include-log: true
-          message: Something went wrong while creating a backport
+          script: | # js
+            const currentVersion = Number(${{ vars.CURRENT_VERSION }});
+
+            const result =  {
+              latest: currentVersion,
+              secondLatest: currentVersion - 1,
+              thirdLatest: currentVersion - 2,
+            };
+
+            console.log(result);
+
+            return result;
+
+      - name: Single Backport
+        uses: ./.github/actions/create-backport
+        with:
+          target-version: ${{ fromJson(steps.get-latest-release-version.outputs.result).latest }}
+          backport-commit: ${{ steps.find_commit.outputs.commit }}
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          github-token-2: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Double Backport
+        if: ${{ always() && fromJson(steps.how-many-backports.outputs.result) >= 2 }}
+        uses: ./.github/actions/create-backport
+        with:
+          target-version: ${{ fromJson(steps.get-latest-release-version.outputs.result).secondLatest }}
+          backport-commit: ${{ steps.find_commit.outputs.commit }}
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          github-token-2: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Triple Backport
+        if: ${{ always() && fromJson(steps.how-many-backports.outputs.result) >= 3 }}
+        uses: ./.github/actions/create-backport
+        with:
+          target-version: ${{ fromJson(steps.get-latest-release-version.outputs.result).thirdLatest }}
+          backport-commit: ${{ steps.find_commit.outputs.commit }}
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          github-token-2: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/backend-cloverage.yml

@@ -19,6 +19,8 @@ jobs:
           m2-cache-key: "cloverage"
       - name: Build static viz frontend
         run: yarn build-static-viz
+        env:
+          MB_EDITION: ee
       - name: Collect the test coverage
         run: clojure -X:dev:ci:ee:ee-dev:test:cloverage
       - name: Upload coverage to codecov.io

.github/workflows/backend.yml

@@ -1,70 +1,19 @@
 name: Backend
 
 on:
-  push:
-    branches:
-      - "master"
-      - "release-**"
-  pull_request:
-    types: [opened, synchronize, reopened, ready_for_review, labeled]
+  workflow_call:
+    inputs:
+      skip:
+        type: boolean
+        default: false
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
+  group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}-backend
   cancel-in-progress: true
 
 jobs:
-  files-changed:
-    name: Check which files changed
-    runs-on: ubuntu-22.04
-    timeout-minutes: 5
-    outputs:
-      backend_all: ${{ steps.changes.outputs.backend_all }}
-      frontend_sources: ${{ steps.changes.outputs.frontend_sources }}
-    steps:
-      - uses: actions/checkout@v4
-      - name: Test which files changed
-        uses: dorny/paths-filter@v3.0.0
-        id: changes
-        with:
-          token: ${{ github.token }}
-          filters: .github/file-paths.yaml
-
-  static-viz-files-changed:
-    needs: files-changed
-    if: needs.files-changed.outputs.backend_all != 'true' && needs.files-changed.outputs.frontend_sources == 'true'
-    name: Check whether static-viz files changed
-    runs-on: ubuntu-22.04
-    timeout-minutes: 10
-    outputs:
-      static_viz: ${{ steps.static_viz.outputs.static_viz }}
-    steps:
-      - uses: actions/checkout@v4
-      - name: Prepare front-end environment
-        uses: ./.github/actions/prepare-frontend
-      - name: Prepare back-end environment
-        uses: ./.github/actions/prepare-backend
-        with:
-          m2-cache-key: "files-changed"
-      - name: Build static-viz frontend
-        run: yarn build-static-viz
-      - name: Upload Static Viz Bundle Artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: static-viz-bundle-${{ github.sha }}
-          path: resources/frontend_client/app/dist
-
-      - name: Check for static viz changes
-        uses: dorny/paths-filter@v3.0.0
-        id: static_viz
-        with:
-          token: ${{ github.token }}
-          filters: .github/static-viz-sources.yaml
-
   be-linter-clj-kondo:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
     timeout-minutes: 10
     name: Clj-Kondo
@@ -75,14 +24,10 @@ jobs:
         with:
           m2-cache-key: 'kondo'
       - name: Run clj-kondo
-        run: ./bin/kondo.sh
+        run: ./bin/mage kondo
 
   be-linter-eastwood:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      github.event.pull_request.draft == false &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
     timeout-minutes: 20
     name: Eastwood
@@ -95,60 +40,14 @@ jobs:
       - run: clojure -X:dev:ee:ee-dev:drivers:drivers-dev:test:eastwood
         name: Run Eastwood linter
 
-  # Because it's not possible to conditionally run only `java-11-ee` test in the draft mode,
-  # we have to extract that job manually here. Backend developers have requested that this
-  # test runs at all times to give them an early warning sign is something is broken.
-  be-tests-java-11-ee-pre-check:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      github.event.pull_request.draft == true &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
-    runs-on: ubuntu-22.04
-    name: Java 11 EE Pre-Check
-    timeout-minutes: 60
-    steps:
-      - uses: actions/checkout@v4
-      - name: Prepare front-end environment
-        uses: ./.github/actions/prepare-frontend
-      - name: Prepare back-end environment
-        uses: ./.github/actions/prepare-backend
-        with:
-          m2-cache-key: java-11-ee-pre-check
-
-      - run: yarn install --frozen-lockfile --prefer-offline
-      - name: Build static viz frontend
-        run: yarn build-static-viz
-
-      - name: Run tests
-        run: clojure -X:dev:ci:test:ee:ee-dev
-
-      - name: Publish Test Report (JUnit)
-        uses: dorny/test-reporter@v1
-        if: failure()
-        with:
-          path: "target/junit/**/*_test.xml"
-          name: JUnit Test Report be-tests-java-11-ee-pre-check
-          reporter: java-junit
-          list-suites: failed
-          list-tests: failed
-          fail-on-error: false
-
   be-tests:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      github.event.pull_request.draft == false &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
     timeout-minutes: 60
     strategy:
       fail-fast: false
       matrix:
-        java-version:
-          - 11
-          - 17
-          - 21
+        java-version: [21]
         job:
           - name: Enterprise Tests
             edition: ee
@@ -213,10 +112,12 @@ jobs:
       # Depending on which files changed, we might either have to build static-viz
       # from scratch or download the previously built artifact
       - name: Build static-viz frontend
-        if: ${{ matrix.job.build-static-viz == 'true' && needs.files-changed.outputs.backend_all == 'true' }}
+        if: ${{ matrix.job.build-static-viz == 'true' && !inputs.skip }}
         run: yarn build-static-viz
+        env:
+          MB_EDITION: ${{ matrix.job.edition }}
       - name: Download Static Viz Bundle Artifact
-        if: ${{ matrix.job.build-static-viz == 'true' && needs.static-viz-files-changed.outputs.static_viz == 'true' }}
+        if: ${{ matrix.job.build-static-viz == 'true' && !inputs.skip }}
         uses: actions/download-artifact@v4
         with:
           name: static-viz-bundle-${{ github.sha }}
@@ -252,19 +153,23 @@ jobs:
           list-tests: failed
           fail-on-error: false
 
+      - name: Upload Logs on Failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: test-logs-${{ matrix.java-version }}-${{ matrix.job.edition }}-${{ github.job }}
+          path: logs/test-log.json
+          retention-days: 1
+
   # checks that all the namespaces we actually ship can be compiled, without any dependencies that we don't ship (such
   # as `:dev` dependencies). See #27009 for more context.
   be-check:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      github.event.pull_request.draft == false &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
     timeout-minutes: 10
     strategy:
       matrix:
-        java-version: [11, 17, 21]
+        java-version: [21]
     name: "Check Java ${{ matrix.java-version }}"
     steps:
       - uses: actions/checkout@v4
@@ -272,13 +177,12 @@ jobs:
         uses: ./.github/actions/prepare-backend
         with:
           m2-cache-key: be-check
+      # TODO -- we should probably also check WITHOUT ee -- do a check with only OSS namespaces on the classpath
       - name: Check namespaces
         run: clojure -M:ee:drivers:check
 
   be-cljfmt:
-    needs: [files-changed]
-    if: |
-      !cancelled() && needs.files-changed.outputs.backend_all == 'true'
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
     timeout-minutes: 10
     name: Cljfmt
@@ -289,7 +193,7 @@ jobs:
         with:
           m2-cache-key: 'cljfmt'
       - name: Run cljfmt
-        run: clojure -T:cljfmt check
+        run: ./bin/mage cljfmt-all --force-check
 
   be-tests-result:
     needs:

.github/workflows/backport-reminder.yml

@@ -9,10 +9,11 @@ on:
 jobs:
   backport-reminder:
     name: Decide whether to backport or not
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
     steps:
       - uses: jesusvasquez333/verify-pr-label-action@v1.4.0
         with:
           github-token: '${{ secrets.GITHUB_TOKEN }}'
-          valid-labels: 'backport, no-backport'
+          valid-labels: 'no-backport, backport, double-backport, triple-backport'
           disable-reviews: true

.github/workflows/backport.yml

@@ -1,238 +0,0 @@
-# Cherry-picks commits from current branch to a specified one in a command "@metabase-bot backport release-x.40.x"
-name: Backport
-
-on:
-  issue_comment:
-    types: [created]
-
-jobs:
-  check_pull_request_state:
-    name: Checks whether the PR has been merged
-    if: github.event.issue.pull_request && contains(github.event.comment.body, '@metabase-bot backport')
-    runs-on: ubuntu-22.04
-    outputs:
-      canBackport: ${{ steps.check_pull_request_state.outputs.result }}
-    steps:
-      - uses: actions/github-script@v7
-        id: check_pull_request_state
-        with:
-          script: |
-            const { data: pullRequest } = await github.rest.pulls.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: context.payload.issue.number
-            });
-
-            const canBackport = pullRequest.state === "closed"
-            if (!canBackport) {
-              await github.rest.issues.createComment({
-                issue_number: context.payload.issue.number,
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                body: "The backport command can only be used after the pull request has been merged. Please wait until the PR is merged before attempting to backport."
-              });
-            }
-            return canBackport
-
-  create_pull_request:
-    name: Creates a pull request
-    needs: [check_pull_request_state]
-    if: needs.check_pull_request_state.outputs.canBackport == 'true'
-    runs-on: ubuntu-22.04
-    steps:
-      - uses: actions/checkout@v4
-        name: Cherry-pick commits and create PR
-        with:
-          fetch-depth: 0
-          token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
-      - name: Verify Membership
-        id: verify-membership
-        uses: ./.github/actions/verify-membership
-        with:
-          github_token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
-          organization_name: metabase
-          username: ${{ github.event.comment.user.login }}
-      - run: |
-          result=${{ steps.verify-membership.outputs.is_member }}
-          if [ $result == false ]; then
-              echo User ${{ github.event.comment.user.login }} is not a member of Metabase organization
-              exit 1
-          fi
-      - uses: actions/github-script@v7
-        id: branch_info
-        with:
-          script: |
-            await github.rest.reactions.createForIssueComment({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              comment_id: context.payload.comment.id,
-              content: 'eyes',
-            });
-
-            // Example: @metabase-bot backport release-x.40.x
-            const [_botName, _command, targetBranch] = context.payload.comment.body.split(" ");
-            console.log(`Target branch is ${targetBranch}`);
-
-            const { data: originalPullRequest } = await github.rest.pulls.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: context.payload.issue.number,
-            });
-
-            const { data: commits } = await github.rest.pulls.listCommits({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: context.payload.issue.number,
-            });
-
-            const targetRef = await github.rest.git.getRef({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              ref: `heads/${targetBranch}`,
-            });
-
-            const backportBranch = `backport-${originalPullRequest.head.ref}-${targetBranch}`
-
-            try {
-              await github.rest.git.getRef({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                ref: `heads/${backportBranch}`,
-              });
-            } catch(e) {
-              if (e.status === 404) {
-                await github.rest.git.createRef({
-                  owner: context.repo.owner,
-                  repo: context.repo.repo,
-                  ref: `refs/heads/${backportBranch}`,
-                  sha: targetRef.data.object.sha,
-                });
-              }
-            }
-
-            return {
-              backportBranch,
-              targetBranch,
-              originalPullRequest,
-              startSha: commits[0].sha,
-              endSha: commits[commits.length - 1].sha
-            }
-      - id: create_backport_pull_request
-        name: Create backport pull request
-        run: |
-          git config --global user.email "metabase-bot@metabase.com"
-          git config --global user.name "Metabase bot"
-
-          git fetch --all
-
-          git checkout "${BACKPORT_BRANCH}"
-          git reset --hard origin/${TARGET_BRANCH}
-
-          if [[ -z $(git ls-remote --heads origin ${ORIGINAL_HEAD_REF}) ]]; then
-            echo "PR has been merged, searching for a squashed commit in the base branch"
-            echo "searching for a commit in a ${ORIGINAL_BASE_REF} that contains pull request number ${ORIGINAL_PULL_REQUEST_NUMBER}"
-            SQUASHED_COMMIT=$(env -i git log ${ORIGINAL_BASE_REF} --grep="(#${ORIGINAL_PULL_REQUEST_NUMBER})" --format="%H")
-
-            if [ -n "${SQUASHED_COMMIT}" ]; then
-              echo "found commit ${SQUASHED_COMMIT}"
-            else
-              echo "probably a PR wasn't merged with Squash And Merge button, searching again"
-              SQUASHED_COMMIT=$(env -i git log ${ORIGINAL_BASE_REF} --grep="#${ORIGINAL_PULL_REQUEST_NUMBER}" --format="%H")
-
-              if [ -n "${SQUASHED_COMMIT}" ]; then
-                echo "found commit ${SQUASHED_COMMIT}"
-              else
-                echo "No squashed commit found for PR #${ORIGINAL_PULL_REQUEST_NUMBER}"
-                exit 1
-              fi
-            fi
-          else
-            echo "The PR has not been merged"
-            exit 1
-          fi
-
-          git cherry-pick ${SQUASHED_COMMIT} || true
-
-          CONFLICTS=$(git ls-files -u | wc -l)
-          if [ "$CONFLICTS" -gt 0 ]; then
-            git cherry-pick --abort
-
-            echo "Could not cherry pick because of a conflict"
-            echo "has-conflicts=true" >> $GITHUB_OUTPUT
-
-            # Add a shell script for resolving conflicts
-            echo "git reset HEAD~1" > ./backport.sh
-            echo "rm ./backport.sh" >> ./backport.sh
-            echo "git cherry-pick ${SQUASHED_COMMIT}" >> ./backport.sh
-            echo "echo 'Resolve conflicts and force push this branch'" >> ./backport.sh
-            chmod +x ./backport.sh
-            git add ./backport.sh
-            git commit -m "Add backport resolution script"
-
-            PR_BODY=$(cat <<-END
-            #${ORIGINAL_PULL_REQUEST_NUMBER}
-            > [!IMPORTANT]
-            > Manual conflict resolution is required.
-            Checkout the branch and run \`./backport.sh\` script. Force push your changes after cherry-picking.
-          END
-            )
-          else
-            echo "has-conflicts=false" >> $GITHUB_OUTPUT
-            PR_BODY="#${ORIGINAL_PULL_REQUEST_NUMBER}"
-          fi
-
-          git push origin "${BACKPORT_BRANCH}" --force-with-lease
-
-          if [[ $(gh pr list --base "${TARGET_BRANCH}" --head "${BACKPORT_BRANCH}" -s "open") ]]; then
-              echo "PR already exists"
-          else
-              BACKPORT_PR_URL=$(gh pr create --base "${TARGET_BRANCH}" --head "${BACKPORT_BRANCH}" --label "was-backported" --assignee "${GITHUB_ACTOR}" --title "🤖 backported \"${ORIGINAL_TITLE}\"" --body "${PR_BODY}")
-              BACKPORT_PR_NUMBER=${BACKPORT_PR_URL##*/}
-
-              echo "backport_pr_number=$BACKPORT_PR_NUMBER" >> $GITHUB_OUTPUT
-              echo "New PR has been created"
-          fi
-
-          git checkout master
-        env:
-          ORIGINAL_TITLE: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.title }}
-          ORIGINAL_BASE_REF: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.base.ref }}
-          ORIGINAL_BASE_SHA: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.base.sha }}
-          ORIGINAL_HEAD_REF: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.head.ref }}
-          ORIGINAL_HEAD_SHA: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.head.sha }}
-          ORIGINAL_PULL_REQUEST_NUMBER: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.number }}
-          TARGET_BRANCH: ${{ fromJson(steps.branch_info.outputs.result).targetBranch }}
-          BACKPORT_BRANCH: ${{ fromJson(steps.branch_info.outputs.result).backportBranch }}
-          START_SHA: ${{ fromJson(steps.branch_info.outputs.result).startSha }}
-          END_SHA: ${{ fromJson(steps.branch_info.outputs.result).endSha }}
-          GITHUB_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
-      - name: Auto approve backport PR
-        if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
-        uses: juliangruber/approve-pull-request-action@v1
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
-      - name: Enable Pull Request Automerge
-        if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
-        uses: peter-evans/enable-pull-request-automerge@v2
-        with:
-          token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
-          pull-request-number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
-          merge-method: squash
-      - uses: ./.github/actions/notify-pull-request
-        if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'true' }}
-        with:
-          include-log: false
-          message: Manual conflict resolution is required
-
-  notify_when_failed:
-    runs-on: ubuntu-22.04
-    name: Notify about failure
-    needs: create_pull_request
-    if: ${{ failure() }}
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/notify-pull-request
-        with:
-          include-log: true
-          message: something went wrong while creating a backport

.github/workflows/chromatic.yml

@@ -18,7 +18,6 @@ jobs:
     timeout-minutes: 3
     outputs:
       frontend_all: ${{ steps.changes.outputs.frontend_all }}
-      e2e_specs: ${{ steps.changes.outputs.e2e_specs }}
     steps:
       - uses: actions/checkout@v4
       - name: Test which files changed
@@ -43,6 +42,8 @@ jobs:
         uses: ./.github/actions/prepare-backend
         with:
           m2-cache-key: "cljs"
+      - name: Compile CLJS
+        run: NODE_ENV=development yarn build-pure:cljs
       - name: Publish to Chromatic
         uses: chromaui/action@v10.2.0
         env:

.github/workflows/codenotify.yml

@@ -1,22 +0,0 @@
-name: Codenotify
-
-on:
-  pull_request:
-    types: [opened, synchronize, ready_for_review]
-    # We're currently notifying developers only for frontend source changes.
-    # Update this glob if that ever changes and we start including backend source code changes.
-    paths:
-      - 'frontend/src/metabase/**'
-      - 'enterprise/frontend/src/metabase-enterprise/**'
-
-jobs:
-  codenotify:
-    runs-on: ubuntu-22.04
-    name: Codenotify
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.pull_request.head.sha }}
-      - uses: sourcegraph/codenotify@v0.6.4
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/containerize-jar.yml

@@ -0,0 +1,141 @@
+name: Containerize Uberjar
+run-name: Containerize ${{ inputs.tag }} Uberjar
+
+on:
+  workflow_call:
+    inputs:
+      artifact-name:
+        type: string
+      repo:
+        description: owner and repo like "metabase/metabase"
+        type: string
+      tag:
+        type: string
+      commit:
+        type: string
+      release:
+        type: string
+        default: 'true'
+      build-args:
+        type: string
+  workflow_dispatch:
+    inputs:
+      artifact-name:
+        description: usually something like "metabase-release-{{ edition }}-{{ hash }}-uberjar"
+        type: string
+      repo:
+        description: docker owner and repo like "metabase/metabase"
+        type: string
+      tag:
+        description: usually a version like v1.87.2
+        type: string
+      commit:
+        description: the full commit hash
+        type: string
+
+jobs:
+  containerize:
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+    outputs:
+      platforms: ${{ steps.platforms.outputs.result }}
+    steps:
+    - uses: actions/checkout@v4
+      with:
+        fetch-depth: 0
+      # we want the dockerfile from the commit we're building
+    - run: git checkout ${{ inputs.commit }} -- bin/docker
+    - name: Retrieve test build uberjar artifact
+      uses: ./.github/actions/fetch-artifact
+      with:
+        name: ${{ inputs.artifact-name }}
+    - name: Prepare build scripts
+      run: cd ${{ github.workspace }}/release && yarn && yarn build
+    - name: Get platforms
+      id: platforms
+      uses: actions/github-script@v7
+      with:
+        result-encoding: string
+        script: | # js
+          const { getBuildRequirements, isValidVersionString} = require('${{ github.workspace }}/release/dist/index.cjs');
+          const version = "${{ inputs.tag }}".split('-')[0];
+
+          if (!isValidVersionString(version)) {
+            return "linux/amd64,linux/arm64";
+          }
+          // versions before 53 need to be handled differently
+          const buildInfo = getBuildRequirements(version);
+          return buildInfo.platforms;
+    - name: Move the Uberjar to the context dir
+      run: mv ./metabase.jar bin/docker/.
+    - name: Login to Docker Hub
+      uses: docker/login-action@v3
+      with:
+        username: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_USERNAME || secrets.DOCKERHUB_USERNAME }}
+        password: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_TOKEN || secrets.DOCKERHUB_TOKEN }}
+    - name: Set up QEMU
+      if: contains(steps.platforms.outputs.result, 'arm')
+      uses: docker/setup-qemu-action@v3
+    - name: Set up Docker Buildx
+      if: contains(steps.platforms.outputs.result, 'arm')
+      uses: docker/setup-buildx-action@v3
+    - name: Build multi-arch container
+      if: contains(steps.platforms.outputs.result, 'arm')
+      uses: docker/build-push-action@v6
+      with:
+        context: bin/docker/.
+        platforms: ${{ steps.platforms.outputs.result }}
+        network: host
+        tags: ${{ inputs.repo }}:${{ inputs.tag }}
+        no-cache: true
+        push: true
+        build-args: ${{ inputs.build-args }}
+
+    # we need to do this to get the nice fallback behavior of the legacy manifest file
+    - name: Build container (x86 only)
+      if: contains(steps.platforms.outputs.result, 'arm') == false
+      run: | # bash
+        docker build \
+          -t ${{ inputs.repo }}:${{ inputs.tag }} \
+          --network=host \
+          --push \
+          bin/docker/.
+
+  verify-docker-pull:
+    runs-on: ubuntu-latest
+    needs: containerize
+    timeout-minutes: 15
+    steps:
+    - name: Login to Docker Hub
+      uses: docker/login-action@v3
+      with:
+        username: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_USERNAME || secrets.DOCKERHUB_USERNAME }}
+        password: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_TOKEN || secrets.DOCKERHUB_TOKEN }}
+    - name: Pull the container image
+      run: docker pull ${{ inputs.repo }}:${{ inputs.tag }}
+    - name: Launch container
+      run: docker run --rm -dp 3000:3000 ${{ inputs.repo }}:${{ inputs.tag }}
+      timeout-minutes: 5
+    - name: Wait for Metabase to start
+      run: while ! curl -s 'http://localhost:3000/api/health' | grep '{"status":"ok"}'; do sleep 1; done
+      timeout-minutes: 5
+
+  verify-docker-pull-arm:
+    runs-on: arm-ubuntu-24-2core
+    needs: containerize
+    if: contains(needs.containerize.outputs.platforms, 'linux/arm64')
+    timeout-minutes: 15
+    steps:
+    - name: Login to Docker Hub
+      uses: docker/login-action@v3
+      with:
+        username: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_USERNAME || secrets.DOCKERHUB_USERNAME }}
+        password: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_TOKEN || secrets.DOCKERHUB_TOKEN }}
+    - name: Pull the container image
+      run: docker pull ${{ inputs.repo }}:${{ inputs.tag }}
+    - name: Launch container
+      run: docker run --rm -dp 3000:3000 ${{ inputs.repo }}:${{ inputs.tag }}
+      timeout-minutes: 5
+    - name: Wait for Metabase to start
+      run: while ! curl -s 'http://localhost:3000/api/health' | grep '{"status":"ok"}'; do sleep 1; done
+      timeout-minutes: 5

.github/workflows/docs_bump_detected.yml

@@ -0,0 +1,37 @@
+name: Docs Bump Detected
+
+on:
+  pull_request_target:
+    types:
+      - opened
+      - synchronize
+      - reopened
+    branches:
+      - 'master'
+      - 'release-x.[0-9]+.x'
+    paths:
+      - 'docs/**'
+
+jobs:
+  push_workflow_to_docs_metabase_github_io_job:
+    runs-on: ubuntu-latest
+    env:
+      SOURCE_BRANCH: ${{ github.head_ref || github.ref  }}
+      TARGET_BRANCH: ${{ github.event.pull_request.base.ref }}
+    steps:
+      - name: Report changed docs files exist
+        run: |
+          echo "A change in the docs directory was detected."
+
+      - name: Trigger repo dispatch
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          script: | #js
+              github.rest.repos.createDispatchEvent({
+                owner: "${{ github.repository_owner }}",
+                repo: "docs.metabase.github.io",
+                event_type: "docs_update",
+                client_payload: {
+                  source_branch: process.env.SOURCE_BRANCH,
+                  target_branch: process.env.TARGET_BRANCH}});

.github/workflows/docs_merge_detected.yml

@@ -0,0 +1,36 @@
+name: Docs Merge Detected
+
+on:
+  pull_request:
+    types:
+      - closed
+    branches:
+      - 'master'
+      - 'release-x.[0-9]+.x'
+    paths:
+      - 'docs/**'
+
+jobs:
+  push_and_merge_workflow_to_docs_metabase_github_io_job:
+    if: github.event.pull_request.merged == true
+    runs-on: ubuntu-latest
+    env:
+      SOURCE_BRANCH: ${{ github.head_ref || github.ref  }}
+      TARGET_BRANCH: ${{ github.event.pull_request.base.ref }}
+    steps:
+      - name: Report changed docs files exist
+        run: |
+          echo "A PR with changes to the docs directory was merged."
+
+      - name: Trigger repo dispatch
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          script: | #js
+            github.rest.repos.createDispatchEvent({
+                owner: "${{ github.repository_owner }}",
+                repo: "docs.metabase.github.io",
+                event_type: "docs_merge",
+                client_payload: {
+                  source_branch: process.env.SOURCE_BRANCH,
+                  target_branch: process.env.TARGET_BRANCH}});