Compare commits

...

61 Commits

Author SHA1 Message Date
Phoomparin Mano
e7aa303fc0 Merge branch 'master' into v2-theme-object 2026-01-22 01:35:39 +07:00
Phoomparin Mano
a0fd1c96bf address review: add tests for gray accent color 2026-01-22 00:15:23 +07:00
Phoomparin Mano
53f555de31 remove no-literal-metabase-strings from file name 2026-01-21 23:51:15 +07:00
Phoomparin Mano
638bb14b7b address review: use grey color as 9th chart color 2026-01-21 23:50:34 +07:00
Phoomparin Mano
8c6caa7a84 rename chart-colors constants to accent-colors for consistency 2026-01-21 23:50:33 +07:00
Phoomparin Mano
94b0e1b3eb fix typo in comment on color aliases
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
2026-01-21 23:50:33 +07:00
Phoomparin Mano
6690aa58b3 remove export of PROTECTED_COLORS by flattening ProtectedColorKey type 2026-01-21 23:50:33 +07:00
Phoomparin Mano
1a586180d8 fix: sdk theme v1 pie chart is wrong 2026-01-21 23:50:33 +07:00
Phoomparin Mano
166fa2c27e Revert "update loki"
This reverts commit f956dee0da3dd859eb65089b640322108135d65c.
2026-01-21 23:50:33 +07:00
Phoomparin Mano
bea0bcdec0 update loki 2026-01-21 23:50:33 +07:00
Phoomparin Mano
0a92b15aeb fix: add sdk portal overrides 2026-01-21 23:50:33 +07:00
Phoomparin Mano
db1f9ed74c add unit tests for derived chart colors 2026-01-21 23:50:33 +07:00
Phoomparin Mano
c8a55de5c5 add chart tint and shade to fix broken pie charts 2026-01-21 23:50:33 +07:00
Phoomparin Mano
64562a739e refactor: add applicationColors as a deprecated method 2026-01-21 23:50:33 +07:00
Phoomparin Mano
3bdeb2d6eb fix application-colors query 2026-01-21 23:50:33 +07:00
Phoomparin Mano
5c0f70488d fix some colors not being reflected 2026-01-21 23:50:33 +07:00
Phoomparin Mano
33f47ef7c1 add null type to ChartColorV2 union 2026-01-21 23:50:33 +07:00
Phoomparin Mano
0e8e56d2d7 move AccentColorOptions to a separate folder 2026-01-21 23:50:32 +07:00
Phoomparin Mano
b901b7932b move themes to constants/themes 2026-01-21 23:50:32 +07:00
Phoomparin Mano
38615664fe replace light|dark union with ResolvedColorScheme 2026-01-21 23:50:32 +07:00
Phoomparin Mano
89f3124621 address review by using whitelabelColors field name in mutateColors 2026-01-21 23:50:32 +07:00
Phoomparin Mano
09206d854d remove unnecessary object spread in mutable colors object
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
2026-01-21 23:50:32 +07:00
Phoomparin Mano
ce5326ed89 address review by exporting PROTECTED_COLORS straight from metabase/lib/colors 2026-01-21 23:50:32 +07:00
Phoomparin Mano
58e85a3d9d address review on accent color mapping 2026-01-21 23:50:32 +07:00
Phoomparin Mano
ffeffd7df2 make deriveFullMetabaseTheme more ergonomic to use 2026-01-21 23:50:32 +07:00
Phoomparin Mano
53281af176 only allow light and dark presets in getPresetColors 2026-01-21 23:50:32 +07:00
Phoomparin Mano
ee73257e75 fix(sdk): fix doc generation 2026-01-21 23:50:32 +07:00
Phoomparin Mano
89f9faebb6 remove no-color-literals eslint-disable 2026-01-21 23:50:32 +07:00
Phoomparin Mano
b341e2ca35 fontFamily only exists in V1 theme for now 2026-01-21 23:50:32 +07:00
Phoomparin Mano
e26b9b31e5 storybook: add metabase-dark theme to storybook 2026-01-21 23:50:31 +07:00
Phoomparin Mano
3d0a3ab4e6 note the transformation of chartColors 2026-01-21 23:50:31 +07:00
Phoomparin Mano
29061e89cd update deriveFullMetabaseTheme unit tests 2026-01-21 23:50:31 +07:00
Phoomparin Mano
9981854f98 extract unit tests 2026-01-21 23:50:31 +07:00
Phoomparin Mano
92b100b059 use baseColors.brand[40] for icon-primary 2026-01-21 23:50:31 +07:00
Phoomparin Mano
572cf68ac1 use base colors as references 2026-01-21 23:50:31 +07:00
Phoomparin Mano
b04a1d7433 remove the need for overriding whitelabel globals 2026-01-21 23:50:31 +07:00
Phoomparin Mano
caf195c3a1 add a function to grab whitelabel colors 2026-01-21 23:50:31 +07:00
Phoomparin Mano
9702d26d0b remove whitelabel hack from createColorVars 2026-01-21 23:50:31 +07:00
Phoomparin Mano
0008737fac always use light theme as embedding base 2026-01-21 23:50:30 +07:00
Phoomparin Mano
a06c9361e1 use deriveFullMetabaseTheme for getColors 2026-01-21 23:50:30 +07:00
Phoomparin Mano
c2d975c441 simplify embedding chart colors 2026-01-21 23:50:30 +07:00
Phoomparin Mano
23b77168fd add todo comments for derive-theme.ts 2026-01-21 23:50:30 +07:00
Phoomparin Mano
be25255df7 use a more accurate accent color types 2026-01-21 23:50:30 +07:00
Phoomparin Mano
d3f708715c cleanup extraneous code comments 2026-01-21 23:50:30 +07:00
Phoomparin Mano
4454738e83 cleanup extraneous code comments 2026-01-21 23:50:30 +07:00
Phoomparin Mano
d86f1ffb86 update code comments on protected colors 2026-01-21 23:50:30 +07:00
Phoomparin Mano
7f226eac3a make predicate more obvious that it is an embedding theme 2026-01-21 23:50:30 +07:00
Phoomparin Mano
aaacb78d2a simplify theme version predicate imports 2026-01-21 23:50:30 +07:00
Phoomparin Mano
6b1bef45d4 simplify code comments 2026-01-21 23:50:30 +07:00
Phoomparin Mano
6f108c04c6 fix codespell warnings 2026-01-21 23:50:30 +07:00
Phoomparin Mano
84da317eef fix imports 2026-01-21 23:50:29 +07:00
Phoomparin Mano
243e24c6ed refactor: use derived terminology instead of resolved 2026-01-21 23:50:29 +07:00
Phoomparin Mano
e0e9a16be5 refactor: remove getDarkColors 2026-01-21 23:50:29 +07:00
Phoomparin Mano
96a7333256 cleanup lib/colors 2026-01-21 23:50:29 +07:00
Phoomparin Mano
223f1ea409 protect more colors from being modifiable 2026-01-21 23:50:29 +07:00
Phoomparin Mano
6f6cb2ac95 refactor: cleanup theming constants and types 2026-01-21 23:50:29 +07:00
Phoomparin Mano
219103c7e7 chore: remove unused theme predicates 2026-01-21 23:50:29 +07:00
Phoomparin Mano
4424c4aa1c refactor: cleanup type names 2026-01-21 23:50:29 +07:00
Phoomparin Mano
8653b83931 replace colorConfig with metabase theme objects 2026-01-21 23:50:29 +07:00
Phoomparin Mano
753a42cc99 add separate theme objects 2026-01-21 23:50:29 +07:00
Phoomparin Mano
6aa305859f scaffold sdk theme 2026-01-21 23:50:29 +07:00

Diff Content Not Available