Revert loadCard changes

This reverts commit 016297badd.

enterprise/frontend/src/embedding-sdk-bundle/lib/sdk-question/load-question.ts

@@ -1,12 +1,15 @@
 import _ from "underscore";
 
+import type {
+  SdkDispatch,
+  SdkStoreState,
+} from "embedding-sdk-bundle/store/types";
 import type { LoadSdkQuestionParams } from "embedding-sdk-bundle/types/question";
 import { resolveCards } from "metabase/query_builder/actions";
 import { getParameterValuesForQuestion } from "metabase/query_builder/actions/core/parameterUtils";
 import { loadMetadataForCard } from "metabase/questions/actions";
 import { getMetadata } from "metabase/selectors/metadata";
 import Question from "metabase-lib/v1/Question";
-import type { Dispatch, GetState } from "metabase-types/store";
 
 export const loadQuestionSdk =
   ({
@@ -17,8 +20,8 @@ export const loadQuestionSdk =
     targetDashboardId,
   }: LoadSdkQuestionParams) =>
   async (
-    dispatch: Dispatch,
-    getState: GetState,
+    dispatch: SdkDispatch,
+    getState: () => SdkStoreState,
   ): Promise<{ question: Question; originalQuestion?: Question }> => {
     const questionId = initQuestionId === "new" ? undefined : initQuestionId;
 

enterprise/frontend/src/embedding-sdk-bundle/lib/sdk-question/run-question-query.ts

@@ -37,7 +37,8 @@ export async function runQuestionQuerySdk(
       isDirty: isQueryDirty,
     });
 
-    const [{ data }] = queryResults;
+    // Default values for rows/cols are needed because the `data` is missing in the case of Static Embedding
+    const [{ data = { rows: [], cols: [] } }] = queryResults;
     const sensibleDisplays = getSensibleDisplays(data);
     question = question.maybeResetDisplay(data, sensibleDisplays, undefined);
   }

enterprise/frontend/src/embedding-sdk-bundle/store/index.ts

@@ -15,7 +15,7 @@ import { getStore } from "metabase/store";
 import { reducer as visualizer } from "metabase/visualizer/visualizer.slice";
 
 import { sdk } from "./reducer";
-import type { SdkStore } from "./types";
+import type { SdkDispatch, SdkStore } from "./types";
 
 export const sdkReducers = {
   ...commonReducers,
@@ -42,7 +42,7 @@ export const getSdkStore = () =>
 export const useSdkDispatch = () => {
   useCheckSdkReduxContext();
 
-  return useDispatch();
+  return useDispatch() as SdkDispatch;
 };
 
 export const useSdkStore = () => {

frontend/src/metabase/lib/utils.ts

@@ -32,7 +32,7 @@ export function numberToWord(num: number) {
   }
 }
 
-export function isJWT(string: unknown) {
+export function isJWT(string: unknown): string is string {
   return (
     typeof string === "string" &&
     /^[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+$/.test(string)

frontend/src/metabase/query_builder/components/ResponsiveParametersList.tsx

@@ -17,6 +17,7 @@ interface ResponsiveParametersListProps {
   setParameterValue: (parameterId: string, value: string) => void;
   setParameterIndex: (parameterId: string, parameterIndex: number) => void;
   enableParameterRequiredBehavior: boolean;
+  commitImmediately?: boolean;
 }
 
 export const ResponsiveParametersList = ({
@@ -26,6 +27,7 @@ export const ResponsiveParametersList = ({
   setParameterValue,
   setParameterIndex,
   enableParameterRequiredBehavior,
+  commitImmediately = true,
 }: ResponsiveParametersListProps) => {
   const [mobileShowParameterList, setShowMobileParameterList] = useState(false);
   const isSmallScreen = useIsSmallScreen();
@@ -87,7 +89,7 @@ export const ResponsiveParametersList = ({
           setParameterIndex={setParameterIndex}
           enableParameterRequiredBehavior={enableParameterRequiredBehavior}
           isEditing
-          commitImmediately
+          commitImmediately={commitImmediately}
         />
       </Box>
     </Box>