handle change on python transform context

* index transforms content

* Add support for transforms & query search in metabot search tool API

* fixup whitespace

* update to use new :fields syntax

* Fix up serach-native-query malli types

* Fix the 15-day interval for transforms to be db-agnostic

* move engine loading to metabase.search.init to break circular dep

* fix kondo

* Revert "Fix the 15-day interval for transforms to be db-agnostic"

This reverts commit 11b34e4cd4a8a5a0cf8041a1d82d487ed8c81025.

* add transform to set of appdb scorer models; unrevert db type fix

* fix kondo

* implement requisite multimethods for transforms not to error in in-place search engine

* ensure we enforce metabot/unknown contexts for transforms in in-place search backend as well

* fix filter test

* transform->postprocess to reduce naming ambiguity; add a basic transform ingestion test

* add a metabot result postprocessing test

* add transforms scoring test

* expand ingestion tests

* fix tests + kondo

* address feedback

.clj-kondo/config.edn

@@ -273,7 +273,6 @@
    clojure.java.jdbc/with-db-connection               {:message "Use sql-jdbc.execute/do-with-connection-with-options (for drivers) or t2/with-connection (for the app DB) instead of jdbc/with-db-connection"}
    clojure.java.jdbc/with-db-metadata                 {:message "Use sql-jdbc.execute/do-with-connection-with-options + .getMetaData instead of jdbc/with-db-metadata"}
    clojure.pprint/pprint                              {:message "Use metabase.util.log instead of clojure.pprint/pprint"}
-   clojure.pprint/print-table                         {:message "Use metabase.util.log instead of printing directly to the console"}
    clojure.string/lower-case                          {:message "Use metabase.util/lower-case-en instead of clojure.string/lower-case"}
    clojure.string/upper-case                          {:message "Use metabase.util/upper-case-en instead of clojure.string/upper-case"}
    compojure.core/context                             {:message "Use metabase.api.util.handlers/route-map-handler instead of compojure.core/context, it is much faster and supports OpenAPI spec generation"}
@@ -489,9 +488,8 @@
   metabase.util.malli/defn-                                                             schema.core/defn
   metabase.util.malli/fn                                                                schema.core/fn
   metabase.util.namespaces/import-fns                                                   potemkin/import-vars
-  metabase.util.performance/doseq                                                       clojure.core/doseq
-  metabase.util.performance/for                                                         clojure.core/for
   metabase.util/with-timer-ms                                                           clojure.core/fn
+  metabase.xrays.domain-entities.malli/defn                                             schema.core/defn
   metabuild-common.core/with-open-jar-file-system                                       clojure.core/let
   metabuild-common.files/with-open-jar-file-system                                      clojure.core/let
   monger.operators/defoperator                                                          clojure.core/def
@@ -575,8 +573,8 @@
    metabase.pulse.models.pulse-test/with-pulse-in-collection!                                                                hooks.common/with-four-bindings
    metabase.pulse.test-util/checkins-query-card                                                                              hooks.metabase.test.data/$ids
    metabase.queries.api.card-test/with-card-param-values-fixtures                                                            hooks.common/let-one-with-optional-value
-   metabase.queries.api.card-test/with-temp-native-card                                                                      hooks.common/with-two-bindings
-   metabase.queries.api.card-test/with-temp-native-card-with-params                                                          hooks.common/with-two-bindings
+   metabase.queries.api.card-test/with-temp-native-card!                                                                     hooks.common/with-two-bindings
+   metabase.queries.api.card-test/with-temp-native-card-with-params!                                                         hooks.common/with-two-bindings
    metabase.query-processor-test.expressions-test/calculate-bird-scarcity                                                    hooks.metabase.query-processor-test.expressions-test/calculate-bird-scarcity
    metabase.query-processor-test.filter-test/count-with-filter-clause                                                        hooks.metabase.test.data/$ids
    metabase.query-processor.middleware.cache-test/with-mock-cache!                                                           hooks.common/with-two-bindings
@@ -626,11 +624,10 @@
    metabase.test/with-non-admin-groups-no-root-collection-perms                                                              hooks.common/do*
    metabase.test/with-persistence-enabled!                                                                                   hooks.metabase.model-persistence.test-util/with-persistence-enabled!
    metabase.test/with-prometheus-system!                                                                                     hooks.common/with-two-bindings
-   metabase.test/with-random-premium-token!                                                                                  hooks.common/with-one-binding
    metabase.test/with-temp                                                                                                   hooks.toucan2.tools.with-temp/with-temp
    metabase.test/with-temp-file                                                                                              hooks.metabase.test.util/with-temp-file
    metabase.test/with-temporary-setting-values                                                                               hooks.metabase.test.util/with-temporary-setting-values
-   metabase.users.api-test/with-temp-user-email!                                                                             hooks.common/with-one-binding
+   metabase.users.api-test/with-temp-user-email!                                                                              hooks.common/with-one-binding
    metabase.util.i18n/deferred-trs                                                                                           hooks.metabase.util.i18n/deferred-trs
    metabase.util.i18n/deferred-tru                                                                                           hooks.metabase.util.i18n/deferred-tru
    metabase.util.i18n/trs                                                                                                    hooks.metabase.util.i18n/trs
@@ -690,6 +687,7 @@
    metabase.test/with-temporary-raw-setting-values                                         macros.metabase.test.util/with-temporary-raw-setting-values
    metabase.users.models.user-test/with-groups!                                            macros.metabase.users.models.user-test/with-groups!
    metabase.util.namespaces/import-fn                                                      macros.metabase.util.namespaces/import-fn
+   metabase.xrays.domain-entities.malli/define-getters-and-setters                         macros.metabase.xrays.domain-entities.malli/define-getters-and-setters
    metabase.xrays.related-test/with-world                                                  macros.metabase.xrays.related-test/with-world}}
 
  :config-in-comment

.clj-kondo/config/modules/config.edn

@@ -62,7 +62,6 @@
            lib-be
            model-persistence
            models
-           parameters
            permissions
            public-sharing
            queries
@@ -318,7 +317,7 @@
            app-db
            classloader
            config
-
+           legacy-mbql
            models
            query-processor
            search
@@ -336,8 +335,10 @@
            app-db
            audit-app
            config
+           driver
            eid-translation
            events
+           legacy-mbql
            lib-be
            models
            notification
@@ -365,8 +366,10 @@
 
   content-translation
   {:team "UX West"
-   :api  #{metabase.content-translation.models}
-   :uses #{premium-features
+   :api  #{metabase.content-translation.api
+           metabase.content-translation.models}
+   :uses #{api
+           premium-features
            util}}
 
   content-verification
@@ -390,8 +393,7 @@
            metabase.dashboards.init
            metabase.dashboards.models.dashboard
            metabase.dashboards.models.dashboard-card
-           metabase.dashboards.models.dashboard-tab
-           metabase.dashboards.schema}
+           metabase.dashboards.models.dashboard-tab}
    :uses #{actions
            analytics
            api
@@ -431,7 +433,10 @@
    :api  #{metabase.driver
            metabase.driver.common
            metabase.driver.common.parameters
+           metabase.driver.common.parameters.dates
+           metabase.driver.common.parameters.operators
            metabase.driver.common.parameters.parse
+           metabase.driver.common.parameters.values
            metabase.driver.ddl.interface
            metabase.driver.h2
            metabase.driver.impl
@@ -445,34 +450,22 @@
            metabase.driver.sql-jdbc.execute.diagnostic
            metabase.driver.sql-jdbc.sync
            metabase.driver.sql.query-processor
+           metabase.driver.sql.query-processor.deprecated
            metabase.driver.sql.util
            metabase.driver.sync
            metabase.driver.util}
-   :uses #{app-db
-           appearance
-           auth-provider
-           classloader
-           config
-           driver-api
-           events
-           legacy-mbql
-           lib
-           lib-be
-           premium-features
-           query-processor
-           settings
-           system
-           util
-           warehouse-schema
-           warehouses}}
+   :uses #{driver-api
+           util}}
 
   driver-api
   {:team "Drivers"
-   :api  #{metabase.driver-api.core}
+   :api  #{metabase.driver-api.core
+           metabase.driver-api.init}
    :uses #{actions
            api
            app-db
            appearance
+           auth-provider
            classloader
            config
            connection-pool
@@ -491,7 +484,8 @@
            system
            upload
            util
-           warehouse-schema}}
+           warehouse-schema
+           warehouses}}
 
   eid-translation
   {:team "UX West"
@@ -513,7 +507,7 @@
    :uses #{analytics
            api
            config
-           dashboards
+           driver
            eid-translation
            events
            models
@@ -542,6 +536,7 @@
    :uses #{appearance
            models
            query-processor
+           system
            types
            util}}
 
@@ -561,11 +556,6 @@
            models
            util}}
 
-  graph
-  {:team "Querying"
-   :api  #{metabase.graph.core}
-   :uses #{util}}
-
   indexed-entities
   {:team "UX West"
    :api  #{metabase.indexed-entities.api
@@ -591,6 +581,7 @@
   legacy-mbql
   {:team "Querying"
    :api  #{metabase.legacy-mbql.normalize
+           metabase.legacy-mbql.predicates
            metabase.legacy-mbql.schema
            metabase.legacy-mbql.util}
    :uses #{lib
@@ -618,6 +609,7 @@
            metabase.lib.metadata.result-metadata
            metabase.lib.normalize
            metabase.lib.options
+           metabase.lib.parse
            metabase.lib.query
            metabase.lib.schema
            metabase.lib.schema.actions
@@ -655,7 +647,8 @@
   lib-be
   {:team "Querying"
    :api  #{metabase.lib-be.core
-           metabase.lib-be.init}
+           metabase.lib-be.init
+           metabase.lib-be.metadata.jvm}
    :uses #{lib
            models
            settings
@@ -722,6 +715,7 @@
            classloader
            legacy-mbql
            lib
+           lib-be
            settings
            util}}
 
@@ -731,7 +725,6 @@
            metabase.native-query-snippets.core}
    :uses #{api
            collections
-           events
            lib
            models
            permissions
@@ -772,7 +765,6 @@
   parameters
   {:team "Querying"
    :api  #{metabase.parameters.chain-filter
-           metabase.parameters.core
            metabase.parameters.custom-values
            metabase.parameters.dashboard
            metabase.parameters.field
@@ -783,11 +775,13 @@
    :uses #{api
            app-db
            classloader
+           driver
            legacy-mbql
            lib
            lib-be
            models
            query-processor
+           types
            util
            warehouse-schema
            warehouses}}
@@ -865,6 +859,7 @@
            dashboards
            events
            lib
+           lib-be
            models
            parameters
            queries
@@ -887,7 +882,6 @@
            config
            driver
            events
-           lib
            models
            notification
            permissions
@@ -900,6 +894,19 @@
            enterprise/advanced-permissions
            enterprise/sandbox}}
 
+  python-runner
+  {:team "Workflows"
+   :api  #{metabase.python-runner.api
+           metabase.python-runner.core
+           metabase.python-runner.init}
+   :uses #{api
+           driver
+           models
+           query-processor
+           request
+           util
+           enterprise/transforms}}
+
   queries
   {:team "Querying"
    :api  #{metabase.queries.api
@@ -967,10 +974,10 @@
            metabase.query-processor.middleware.annotate
            metabase.query-processor.middleware.cache-backend.db
            metabase.query-processor.middleware.constraints
+           metabase.query-processor.middleware.fetch-source-query-legacy
            metabase.query-processor.middleware.limit
            metabase.query-processor.middleware.permissions
            metabase.query-processor.middleware.wrap-value-literals
-           metabase.query-processor.parameters.dates
            metabase.query-processor.parameters.operators
            metabase.query-processor.pipeline
            metabase.query-processor.pivot
@@ -999,7 +1006,6 @@
            batch-processing
            cache
            config
-           dashboards
            driver
            events
            formatter
@@ -1014,9 +1020,11 @@
            premium-features
            queries
            query-permissions
+           request
            server
            settings
            system
+           types
            users
            util}}
 
@@ -1076,14 +1084,12 @@
            audit-app
            collections
            config
+           driver
            events
-           lib
-           lib-be
            models
            permissions
            premium-features
            queries
-           query-processor
            request
            settings
            startup
@@ -1126,7 +1132,6 @@
            core
            driver
            embedding
-           lib-be
            premium-features
            query-processor
            request
@@ -1182,8 +1187,10 @@
            api
            app-db
            appearance
+           channel
            config
            events
+           permissions
            request
            session
            settings
@@ -1289,9 +1296,6 @@
            metabase.tiles.init}
    :uses #{api
            legacy-mbql
-           lib
-           lib-be
-           parameters
            query-processor
            settings
            util}}
@@ -1346,11 +1350,9 @@
   users
   {:team "UX West"
    :api  #{metabase.users.api
-           metabase.users.core
            metabase.users.init
            metabase.users.models.user
-           metabase.users.models.user-parameter-value
-           metabase.users.schema}
+           metabase.users.models.user-parameter-value}
    :uses #{analytics
            api
            appearance
@@ -1497,6 +1499,7 @@
   enterprise/action-v2
   {:team "Workflows"
    :api  #{metabase-enterprise.action-v2.api
+           metabase-enterprise.action-v2.core
            metabase-enterprise.action-v2.init}
    :uses #{actions
            api
@@ -1531,6 +1534,7 @@
            metabase-enterprise.advanced-permissions.common
            metabase-enterprise.advanced-permissions.models.permissions.group-manager}
    :uses #{api
+           legacy-mbql
            lib
            permissions
            premium-features
@@ -1561,6 +1565,7 @@
    :api  #{metabase-enterprise.ai-sql-generation.api}
    :uses #{api
            driver
+           models
            util
            enterprise/metabot-v3}}
 
@@ -1615,11 +1620,6 @@
    :uses #{api
            premium-features util}}
 
-  enterprise/bookmarks
-  {:team "UX West"
-   :api  #{}
-   :uses #{}}
-
   enterprise/cache
   {:team "UX West"
    :api  #{metabase-enterprise.cache.init}
@@ -1642,8 +1642,7 @@
   {:team "Workflows"
    :api  #{metabase-enterprise.comments.api
            metabase-enterprise.comments.init}
-   :uses #{analytics
-           api
+   :uses #{api
            channel
            events
            models
@@ -1653,7 +1652,8 @@
 
   enterprise/content-translation
   {:team "UX West"
-   :api  #{metabase-enterprise.content-translation.routes}
+   :api  #{metabase-enterprise.content-translation.dictionary
+           metabase-enterprise.content-translation.routes}
    :uses #{api
            content-translation
            embedding
@@ -1679,11 +1679,20 @@
    :api  #{}
    :uses #{premium-features}}
 
+  enterprise/data-editing
+  {:team "Workflows"
+   :api  #{metabase-enterprise.data-editing.api}
+   :uses #{actions
+           api
+           models
+           util}}
+
   enterprise/database-replication
   {:team "Cloud"
    :api  #{metabase-enterprise.database-replication.api
            metabase-enterprise.database-replication.init}
-   :uses #{api
+   :uses #{analytics
+           api
            driver
            premium-features
            settings
@@ -1707,29 +1716,6 @@
            warehouse-schema
            warehouses}}
 
-  enterprise/dependencies
-  {:team "Querying"
-   :api  #{metabase-enterprise.dependencies.api
-           #_metabase-enterprise.dependencies.core
-           metabase-enterprise.dependencies.init}
-   :uses #{analyze
-           api
-           collections
-           config
-           driver
-           events
-           graph
-           lib
-           lib-be
-           models
-           native-query-snippets
-           premium-features
-           queries
-           query-processor
-           settings
-           task
-           util}}
-
   enterprise/documents
   {:team "UX West"
    :api  #{metabase-enterprise.documents.api
@@ -1742,11 +1728,13 @@
            collections
            events
            models
+           permissions
            premium-features
            queries
            query-permissions
            revisions
            search
+           users
            util
            view-log}}
 
@@ -1768,6 +1756,7 @@
            audit-app
            embedding
            premium-features
+           util
            enterprise/sso}}
 
   enterprise/gsheets
@@ -1830,7 +1819,6 @@
            metabase-enterprise.metabot-v3.tools.api}
    :uses #{api
            app-db
-           audit-app
            collections
            config
            driver
@@ -1838,6 +1826,7 @@
            lib
            lib-be
            models
+           native-query-snippets
            permissions
            premium-features
            pulse
@@ -1846,7 +1835,6 @@
            search
            server
            settings
-           store-api
            sync
            system
            task
@@ -1854,7 +1842,9 @@
            util
            warehouse-schema
            warehouses
-           enterprise/documents}}
+           enterprise/documents
+           enterprise/transforms
+           enterprise/transforms-python}}
 
   enterprise/permission-debug
   {:team "UX West"
@@ -1879,12 +1869,14 @@
    :uses #{api
            app-db
            audit-app
+           classloader
            driver
            legacy-mbql
            lib
            models
            permissions
            premium-features
+           query-permissions
            query-processor
            request
            users
@@ -1947,13 +1939,18 @@
            app-db
            appearance
            collections
+           config
+           legacy-mbql
+           lib
            logger
            models
            plugins
            premium-features
            search
+           settings
            setup
-           util}}
+           util
+           warehouse-schema}}
 
   enterprise/snippet-collections
   {:team "Querying"
@@ -1981,6 +1978,7 @@
            settings
            sso
            system
+           users
            util
            enterprise/scim}}
 
@@ -2008,18 +2006,22 @@
    :uses #{analytics
            api
            app-db
+           config
            driver
            events
            lib
            lib-be
            models
+           permissions
            premium-features
            query-processor
            request
+           search
            settings
            sync
            task
            task-history
+           upload
            util
            enterprise/transforms-python}}
 
@@ -2027,11 +2029,13 @@
   {:team "Querying"
    :api  #{metabase-enterprise.transforms-python.api
            metabase-enterprise.transforms-python.execute
-           metabase-enterprise.transforms-python.init}
+           metabase-enterprise.transforms-python.init
+           metabase-enterprise.transforms-python.settings}
    :uses #{api
            app-db
            config
            driver
+           models
            query-processor
            settings
            util

.clj-kondo/macros/metabase/xrays/domain_entities/malli.clj

@@ -0,0 +1,16 @@
+(ns macros.metabase.xrays.domain-entities.malli)
+
+(defmacro define-getters-and-setters [schema & defs]
+  `(do
+     (comment ~schema) ;; Reference the schema
+     ~@(for [[sym _path] (partition 2 defs)]
+         `(do
+            (defn ~(vary-meta sym
+                              assoc :export true)
+              "docs" [_x#] nil)
+            (defn ~(vary-meta (symbol (str "with-" (name sym)))
+                              assoc :export true)
+              "docs" [x# _new#] x#)
+            (defn ~(vary-meta (symbol (str (name sym) "-js"))
+                              assoc :export true)
+              "docs" [x#] x#)))))

.clj-kondo/src/hooks/metabase/test/util.clj

@@ -1,6 +1,6 @@
 (ns hooks.metabase.test.util
-  (:require
-   [clj-kondo.hooks-api :as hooks]))
+  (:require [clj-kondo.hooks-api :as hooks]
+            [hooks.common :as common]))
 
 (defn- namespaced-symbol-node? [node]
   (when (hooks/token-node? node)

.cljfmt.edn

@@ -163,8 +163,8 @@
   metabase.models.interface/define-batched-hydration-method                              [[:inner 0]]
   metabase.models.interface/define-simple-hydration-method                               [[:inner 0]]
   metabase.parameters.chain-filter-test/with-clean-field-values-for-field                [[:block 1]]
-  metabase.parameters.chain-filter-test/with-fk-field-to-field-remapping!                [[:block 0]]
-  metabase.parameters.chain-filter-test/with-human-readable-values-remapping!            [[:block 0]]
+  metabase.parameters.chain-filter-test/with-fk-field-to-field-remapping                 [[:block 0]]
+  metabase.parameters.chain-filter-test/with-human-readable-values-remapping             [[:block 0]]
   metabase.permissions.core/allow-changing-all-users-group-members                       [[:block 0]]
   metabase.permissions.core/disable-perms-cache                                          [[:block 0]]
   metabase.public-sharing.api-test/with-sharing-enabled-and-temp-card-referencing        [[:block 3]]
@@ -179,8 +179,8 @@
   metabase.queries.api.card-test/with-cards-in-readable-collection                       [[:block 1]]
   metabase.queries.api.card-test/with-cards-in-writeable-collection                      [[:block 1]]
   metabase.queries.api.card-test/with-ordered-items                                      [[:inner 0]]
-  metabase.queries.api.card-test/with-temp-native-card                                   [[:block 1]]
-  metabase.queries.api.card-test/with-temp-native-card-with-params                       [[:block 1]]
+  metabase.queries.api.card-test/with-temp-native-card!                                  [[:block 1]]
+  metabase.queries.api.card-test/with-temp-native-card-with-params!                      [[:block 1]]
   metabase.query-processor-test.pipeline-queries-test/pmbql-query                        [[:block 1]]
   metabase.query-processor-test.pipeline-queries-test/run-pmbql-query                    [[:block 1]]
   metabase.query-processor.debug/debug>                                                  [[:block 0]]
@@ -232,6 +232,7 @@
   metabase.test.data/$ids                                                                [[:inner 0]]
   metabase.test.data/dataset                                                             [[:inner 0]]
   metabase.test.data/mbql-query                                                          [[:inner 0]]
+  metabase.test.data/native-query                                                        [[:block 0]]
   metabase.test.data/query                                                               [[:block 1]]
   metabase.test.data/run-mbql-query                                                      [[:inner 0]]
   metabase.test.data/with-empty-h2-app-db!                                               [[:block 0]]
@@ -252,6 +253,7 @@
   metabase.test/format-rows-by                                                           [[:default]]
   metabase.test/let-url                                                                  [[:block 1]]
   metabase.test/mbql-query                                                               [[:inner 0]]
+  metabase.test/native-query                                                             [[:block 0]]
   metabase.test/query                                                                    [[:block 1]]
   metabase.test/run-mbql-query                                                           [[:inner 0]]
   metabase.test/test-driver                                                              [[:inner 0]]

.github/actions/cleanup-python-runner/action.yml

@@ -1,36 +0,0 @@
-name: Cleanup Python Runner
-description: Cleanup python-runner services and upload logs as artifacts
-
-inputs:
-  upload-logs:
-    description: 'Whether to upload logs (typically on failure)'
-    required: false
-    default: 'false'
-  logs-artifact-suffix:
-    description: 'The unique name of the .zip artifact containing the logs'
-    required: false
-    default: ''
-
-runs:
-  using: composite
-  steps:
-    - name: Cleanup python-runner services
-      if: always()
-      run: |
-        echo "Stopping python-runner services..."
-        if [ -d "python-runner" ]; then
-          cd python-runner
-          make stop || echo "WARNING: Failed to stop python runner"
-        fi
-      shell: bash
-
-    - name: Upload python-runner logs
-      if: ${{inputs.upload-logs == 'true' && inputs.logs-artifact-suffix != ''}}
-      uses: actions/upload-artifact@v4
-      with:
-        name: python-runner-logs-${{inputs.logs-artifact-suffix}}
-        path: |
-          python-runner.out.log
-          python-runner.err.log
-        retention-days: 1
-        if-no-files-found: warn

.github/actions/setup-python-runner/action.yml

@@ -1,14 +0,0 @@
-name: Setup Python Runner
-description: Setup python-runner for tests
-inputs:
-  metabase-automation-token:
-    description: Token for accessing the python-runner repository
-    required: true
-runs:
-  using: composite
-  steps:
-    - name: Setup python-runner
-      run: ./.github/scripts/setup-python-runner.sh
-      shell: bash
-      env:
-        METABASE_AUTOMATION_USER_TOKEN: ${{ inputs.metabase-automation-token }}

.github/scripts/average-e2e-timings.js

@@ -21,6 +21,7 @@ const collectAndAverageTimings = async ({
 
     const timingData = await downloadAndExtractArtifacts(
       artifacts,
+      token,
       github,
       context,
     );

.github/scripts/setup-python-runner.sh

@@ -24,7 +24,6 @@ git clone --depth 1 https://${METABASE_AUTOMATION_USER_TOKEN}@github.com/metabas
 if [ "$SKIP_START" = false ]; then
   echo "Starting python-runner..."
   cd python-runner
-  make run-ci 1> ../python-runner.out.log 2> ../python-runner.err.log
-  make logs 1>> ../python-runner.out.log 2>> ../python-runner.err.log &
+  make run-ci
   cd ..
 fi

.github/team.json

@@ -36,10 +36,14 @@
       "name": "Workflows",
       "label": ".Team/Workflows",
       "members": [
+        "qnkhuat",
         "piranha",
         "crisptrutski",
         "spalt08",
-        "kulyk"
+        "stasgavrylov",
+        "uladzimirdev",
+        "kulyk",
+        "kamilmielnik"
       ]
     },
     {
@@ -66,8 +70,10 @@
         "retro",
         "sloansparger",
         "somtom",
+        "wotbrew",
         "tsplude",
-        "lbrdnk"
+        "lbrdnk",
+        "bronsa"
       ]
     },
     {
@@ -75,6 +81,7 @@
       "label": ".Team/ProductGrowth",
       "members": [
         "nemanjaglumac",
+        "chodorowicz",
         "andsalves"
       ]
     },
@@ -106,20 +113,6 @@
         "alxnddr",
         "bpander"
       ]
-    },
-    {
-      "name": "Gadget",
-      "label": ".Team/Gadget",
-      "members": [
-        "nmezzopera",
-        "bronsa",
-        "wotbrew",
-        "qnkhuat",
-        "chodorowicz",
-        "kamilmielnik",
-        "stasgavrylov",
-        "uladzimirdev"
-      ]
     }
   ]
 }

.github/workflows/app-db.yml

@@ -255,6 +255,12 @@ jobs:
             env:
               enable-ssl-tests: 'true'
         job:
+          - name: Driver Tests
+            build-static-viz: false
+            test-args: >-
+              :only-tags [:mb/driver-tests]
+              :exclude-tags [:mb/transforms-python-test]
+            exclude-tag: ':mb/transforms-python-test'
           - name: Enterprise Tests
             build-static-viz: false
             test-args: >-

.github/workflows/backend.yml

@@ -51,13 +51,11 @@ jobs:
         job:
           - name: Enterprise Tests
             edition: ee
-            test-group-name: ee
             build-static-viz: 'false'
             test-args: >-
               :only '"enterprise/backend/test"'
           - name: EE App DB Tests (Part 1)
             edition: ee
-            test-group-name: ee-app-db-1
             build-static-viz: 'true'
             test-args: >-
               :only '["test" ".clj-kondo/test"]'
@@ -65,7 +63,6 @@ jobs:
               :partition/index 0
           - name: EE App DB Tests (Part 2)
             edition: ee
-            test-group-name: ee-app-db-2
             build-static-viz: 'true'
             test-args: >-
               :only '["test" ".clj-kondo/test"]'
@@ -73,7 +70,6 @@ jobs:
               :partition/index 1
           - name: OSS App DB Tests (Part 1)
             edition: oss
-            test-group-name: oss-app-db-1
             build-static-viz: 'true'
             test-args: >-
               :only '["test" ".clj-kondo/test"]'
@@ -81,7 +77,6 @@ jobs:
               :partition/index 0
           - name: OSS App DB Tests (Part 2)
             edition: oss
-            test-group-name: oss-app-db-2
             build-static-viz: 'true'
             test-args: >-
               :only '["test" ".clj-kondo/test"]'
@@ -162,7 +157,7 @@ jobs:
         if: always() && !success()
         uses: actions/upload-artifact@v4
         with:
-          name: test-logs-${{ matrix.java-version }}-${{ matrix.job.edition }}-${{ github.job }}-${{ matrix.job.test-group-name }}
+          name: test-logs-${{ matrix.java-version }}-${{ matrix.job.edition }}-${{ github.job }}
           path: logs/test-log.json
           retention-days: 1
 

.github/workflows/bugs-triage-slack-notification.yml

@@ -0,0 +1,52 @@
+name: Bugs Slack Notification
+
+on:
+  issues:
+    types:
+      - labeled
+jobs:
+  on-issue-labeled:
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    if: |
+      github.event.label.name == '.Needs Triage' && contains(github.event.issue.labels.*.name, 'Type:Bug')
+    steps:
+      - name: Setting title
+        uses: actions/github-script@v7
+        id: vars
+        with:
+          script: |
+            core.setOutput('issue_title', ${{ toJson(github.event.issue.title) }}.replaceAll(/"/g, '\\"'));
+      - name: Check for labels containing team name
+        id: check_labels
+        run: |
+          labels_json=$(sed 's/&/\$/g' <<< '${{ toJson(github.event.issue.labels) }}')
+          echo "has_team_label=false" >> "$GITHUB_OUTPUT"
+          for label in "$labels_json"
+          do
+            if [[ $label == *".Team"* ]]; then
+              echo "Label contains the team name."
+              echo "has_team_label=true" >> "$GITHUB_OUTPUT"
+              break
+            fi
+          done
+      - name: Send the issue ${{ github.event.issue.number }} to Slack
+        id: slack
+        if: steps.check_labels.outputs.has_team_label == 'false'
+        uses: slackapi/slack-github-action@v1.26.0
+        with:
+          payload: |
+            {
+              "blocks": [
+                {
+                  "type": "section",
+                  "text": {
+                    "type": "mrkdwn",
+                    "text": "${{ steps.vars.outputs.issue_title }}\n${{ github.event.issue.html_url }}"
+                  }
+                }
+              ]
+            }
+        env:
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_BUG_TRIAGE_WEBHOOK_URL }}
+          SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK

.github/workflows/claude-code-review.yaml

@@ -1,96 +0,0 @@
-name: "Claude Code Review"
-
-on:
-  pull_request:
-    types: [opened, synchronize, reopened, labeled, unlabeled]
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}-claude-code-review
-  cancel-in-progress: true
-
-env:
-  EXCLUDED_PR_AUTHORS: '["kamilmielnik", "romeovs"]'
-
-jobs:
-  review:
-    if: github.event.pull_request.draft == false && !contains(fromJSON(env.EXCLUDED_PR_AUTHORS), github.event.pull_request.user.login) }}
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      pull-requests: write
-
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 1
-          # Make sure the value of GITHUB_TOKEN will not be persisted in repo's config
-          persist-credentials: false
-
-      # Apparently comments on specific lines and top-level comments about the PR as a whole are TWO TOTALLY DIFFERENT
-      # TYPES OF THINGS. So we have to fetch and delete separately.
-      - name: Delete old Claude PR review comments
-        env:
-          GH_TOKEN: ${{ github.token }}
-          REPO: ${{ github.repository }}
-          PR_NUMBER: ${{ github.event.pull_request.number }}
-        shell: bash
-        run: |
-          # Get old comment IDs from the bot
-          old_line_comment_ids=$(gh api "/repos/$REPO/pulls/$PR_NUMBER/comments" --jq '.[] | select(.user.login=="metabase-bot[bot]") | .id')
-          echo "Deleting line comments: $old_line_comment_ids"
-          # Delete each comment
-          for id in $old_line_comment_ids; do
-            gh api -X DELETE "/repos/$REPO/pulls/comments/$id"
-            echo "Deleted line comment $id"
-          done
-          # Get old top-level comment IDs (technically "issue" comments on the PR?)
-          old_top_level_comment_ids=$(gh api "/repos/$REPO/issues/$PR_NUMBER/comments" --jq '.[] | select(.user.login=="metabase-bot[bot]") | .id')
-          echo "Deleting top-level comments: $old_top_level_comment_ids"
-          # Delete each comment
-          for id in $old_top_level_comment_ids; do
-            gh api -X DELETE "/repos/$REPO/issues/comments/$id"
-            echo "Deleted top-level comment $id"
-          done
-
-      - name: Generate GitHub App Token for Claude
-        uses: actions/create-github-app-token@v1
-        id: claude-app-token
-        with:
-          app-id: ${{ secrets.METABASE_BOT_APP_ID }}
-          private-key: ${{ secrets.METABASE_BOT_APP_PRIVATE_KEY }}
-          permission-contents: read       # Required for reading repository files and PR diffs
-          permission-pull-requests: write # Required for creating inline comments and PR comments
-
-      - name: Fetch Community Clojure Style Guide
-        run: >-
-          curl https://raw.githubusercontent.com/bbatsov/clojure-style-guide/refs/heads/master/README.adoc -o CLOJURE_STYLE_GUIDE.adoc
-
-      - uses: anthropics/claude-code-action@v1
-        timeout-minutes: 10
-        with:
-          anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
-          github_token: ${{ steps.claude-app-token.outputs.token }}
-          prompt: |
-            REPO: ${{ github.repository }}
-            PR NUMBER: ${{ github.event.pull_request.number }}
-
-            Review this pull request with a focus on:
-
-            - Compliance with project coding standards and conventions
-            - Code quality and best practices
-            - Clear and correct docstrings
-            - Clear and correct comments explaining what the code is doing
-
-            DO NOT post any comments confirming that something is correct or congratulating someone for following our
-            guidelines -- only post comments for style violations or concerns.
-
-            Follow additional guidelines in the "Code Review Guidelines" section of CLAUDE.md .
-
-            Note: The PR branch is already checked out in the current working directory.
-
-            Use `gh pr comment` for top-level feedback.
-            Use `mcp__github_inline_comment__create_inline_comment` to highlight specific code issues.
-            Only post GitHub comments - don't submit review text as messages.
-
-          claude_args: |
-            --allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),ReadFile(CLOJURE_STYLE_GUIDE.adoc)"

.github/workflows/docs_bump_detected.yml

@@ -0,0 +1,44 @@
+name: Docs Bump Detected
+
+on:
+  pull_request_target:
+    types:
+      - opened
+      - synchronize
+      - reopened
+    branches:
+      - 'master'
+      - 'release-x.[0-9]+.x'
+    paths:
+      - 'docs/**'
+
+jobs:
+  push_workflow_to_docs_metabase_github_io_job:
+    runs-on: ubuntu-latest
+    env:
+      SOURCE_BRANCH: ${{ github.head_ref || github.ref  }}
+      TARGET_BRANCH: ${{ github.event.pull_request.base.ref }}
+      PR_NUMBER: ${{ github.event.pull_request.number }}
+    steps:
+      - name: Report changed docs files exist
+        run: |
+          echo "A PR with changes in the docs directory was detected."
+          echo "Sending workflow trigger to create/update the corresponding PR in docs repo."
+          echo "source branch: $SOURCE_BRANCH"
+          echo "target branch: $TARGET_BRANCH"
+          echo "pr number: $PR_NUMBER"
+
+      - name: Trigger repo dispatch
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          script: | #js
+              github.rest.repos.createDispatchEvent({
+                owner: "${{ github.repository_owner }}",
+                repo: "docs.metabase.github.io",
+                event_type: "docs_update",
+                client_payload: {
+                  dispatch_type: "docs_update",
+                  source_branch: process.env.SOURCE_BRANCH,
+                  target_branch: process.env.TARGET_BRANCH,
+                  pr_number: process.env.PR_NUMBER}});

.github/workflows/docs_close_detected.yml

@@ -0,0 +1,43 @@
+name: Docs Close Detected
+
+on:
+  pull_request:
+    types:
+      - closed
+    branches:
+      - 'master'
+      - 'release-x.[0-9]+.x'
+    paths:
+      - 'docs/**'
+
+jobs:
+  push_and_merge_workflow_to_docs_metabase_github_io_job:
+    if: github.event.pull_request.merged == false
+    runs-on: ubuntu-latest
+    env:
+      SOURCE_BRANCH: ${{ github.head_ref || github.ref  }}
+      TARGET_BRANCH: ${{ github.event.pull_request.base.ref }}
+      PR_NUMBER: ${{ github.event.pull_request.number }}
+    steps:
+      - name: Report changed docs files exist
+        run: |
+          echo "A PR with changes to the docs directory was closed."
+          echo "Sending workflow trigger to close corresponding PR in docs repo."
+          echo "source branch: $SOURCE_BRANCH"
+          echo "target branch: $TARGET_BRANCH"
+          echo "pr number: $PR_NUMBER"
+
+      - name: Trigger repo dispatch
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          script: | #js
+            github.rest.repos.createDispatchEvent({
+                owner: "${{ github.repository_owner }}",
+                repo: "docs.metabase.github.io",
+                event_type: "docs_close",
+                client_payload: {
+                  dispatch_type: "docs_close",
+                  source_branch: process.env.SOURCE_BRANCH,
+                  target_branch: process.env.TARGET_BRANCH,
+                  pr_number: process.env.PR_NUMBER}});

.github/workflows/docs_merge_detected.yml

@@ -0,0 +1,43 @@
+name: Docs Merge Detected
+
+on:
+  pull_request:
+    types:
+      - closed
+    branches:
+      - 'master'
+      - 'release-x.[0-9]+.x'
+    paths:
+      - 'docs/**'
+
+jobs:
+  push_and_merge_workflow_to_docs_metabase_github_io_job:
+    if: github.event.pull_request.merged == true
+    runs-on: ubuntu-latest
+    env:
+      SOURCE_BRANCH: ${{ github.head_ref || github.ref  }}
+      TARGET_BRANCH: ${{ github.event.pull_request.base.ref }}
+      PR_NUMBER: ${{ github.event.pull_request.number }}
+    steps:
+      - name: Report changed docs files exist
+        run: |
+          echo "A PR with changes to the docs directory was merged."
+          echo "Sending workflow trigger to merge corresponding PR in docs repo."
+          echo "source branch: $SOURCE_BRANCH"
+          echo "target branch: $TARGET_BRANCH"
+          echo "pr number: $PR_NUMBER"
+
+      - name: Trigger repo dispatch
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          script: | #js
+            github.rest.repos.createDispatchEvent({
+                owner: "${{ github.repository_owner }}",
+                repo: "docs.metabase.github.io",
+                event_type: "docs_merge",
+                client_payload: {
+                  dispatch_type: "docs_merge",
+                  source_branch: process.env.SOURCE_BRANCH,
+                  target_branch: process.env.TARGET_BRANCH,
+                  pr_number: process.env.PR_NUMBER}});

.github/workflows/drivers.yml

@@ -135,11 +135,10 @@ jobs:
     - uses: actions/checkout@v4
     - name: Setup python-runner
       if: ${{ matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/setup-python-runner
-      with:
-        metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      env:
+        METABASE_AUTOMATION_USER_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      run: ./.github/scripts/setup-python-runner.sh
     - name: Test BigQuery Cloud SDK driver
-      id: test-driver
       uses: ./.github/actions/test-driver
       with:
         junit-name: 'be-tests-bigquery-cloud-sdk-ee'
@@ -155,12 +154,6 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
         aws-region: ${{ vars.AWS_REGION }}
         trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
-    - name: Cleanup python-runner
-      if: ${{ always() && matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/cleanup-python-runner
-      with:
-        upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
-        logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}
 
   be-tests-clickhouse-ee:
     if: ${{ !inputs.skip }}
@@ -190,9 +183,9 @@ jobs:
     - uses: actions/checkout@v4
     - name: Setup python-runner
       if: ${{ matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/setup-python-runner
-      with:
-        metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      env:
+        METABASE_AUTOMATION_USER_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      run: ./.github/scripts/setup-python-runner.sh
     - name: Add ClickHouse TLS instance to /etc/hosts
       run: |
         sudo echo "127.0.0.1 server.clickhouseconnect.test" | sudo tee -a /etc/hosts
@@ -209,7 +202,6 @@ jobs:
           clickhouse_cluster_node2
           nginx
     - name: Test Clickhouse driver
-      id: test-driver
       uses: ./.github/actions/test-driver
       with:
         junit-name: 'be-tests-clickhouse-ee'
@@ -225,12 +217,6 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
         aws-region: ${{ vars.AWS_REGION }}
         trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
-    - name: Cleanup python-runner
-      if: ${{ always() && matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/cleanup-python-runner
-      with:
-        upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
-        logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}
 
   be-tests-druid-ee:
     needs: determine-driver-skips
@@ -391,11 +377,10 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Setup python-runner
-      uses: ./.github/actions/setup-python-runner
-      with:
-        metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      env:
+        METABASE_AUTOMATION_USER_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      run: ./.github/scripts/setup-python-runner.sh
     - name: Test H2 driver
-      id: test-driver
       uses: ./.github/actions/test-driver
       with:
         junit-name: 'be-tests-h2'
@@ -413,12 +398,6 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
         aws-region: ${{ vars.AWS_REGION }}
         trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
-    - name: Cleanup python-runner
-      if: always()
-      uses: ./.github/actions/cleanup-python-runner
-      with:
-        upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
-        logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}
 
   be-tests-mysql-mariadb:
     if: ${{ !inputs.skip }}
@@ -452,7 +431,7 @@ jobs:
           - name: Driver Tests
             test-args: >-
               :only-tags [:mb/driver-tests]
-            exclude-tag: ':mb/transforms-python-test'
+              :exclude-tags [:mb/transforms-python-test]
           - name: Transforms Python Tests
             test-args: >-
               :only-tags [:mb/transforms-python-test]
@@ -512,12 +491,11 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Setup python-runner
-        if: ${{ matrix.job.needs-python-runner == true }}
-        uses: ./.github/actions/setup-python-runner
-        with:
-          metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      #if: ${{ matrix.job.needs-python-runner == true }}
+        env:
+          METABASE_AUTOMATION_USER_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+        run: ./.github/scripts/setup-python-runner.sh
       - name: Test ${{ matrix.version.name }}
-        id: test-driver
         uses: ./.github/actions/test-driver
         with:
           junit-name: ${{ matrix.version.junit-name }}
@@ -535,12 +513,6 @@ jobs:
           aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
           aws-region: ${{ vars.AWS_REGION }}
           trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
-      - name: Cleanup python-runner
-        if: always()
-        uses: ./.github/actions/cleanup-python-runner
-        with:
-          upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
-          logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}
 
   be-tests-mongo:
     needs: determine-driver-skips
@@ -584,11 +556,10 @@ jobs:
     - uses: actions/checkout@v4
     - name: Setup python-runner
       if: ${{ matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/setup-python-runner
-      with:
-        metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      env:
+        METABASE_AUTOMATION_USER_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      run: ./.github/scripts/setup-python-runner.sh
     - name: Test ${{ matrix.version.name }}
-      id: test-driver
       uses: ./.github/actions/test-driver
       with:
         junit-name: ${{ matrix.version.junit-name }}
@@ -604,12 +575,6 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
         aws-region: ${{ vars.AWS_REGION }}
         trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
-    - name: Cleanup python-runner
-      if: ${{ always() && matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/cleanup-python-runner
-      with:
-        upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
-        logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}
 
   be-tests-mongo-ssl:
     needs: determine-driver-skips
@@ -805,7 +770,7 @@ jobs:
           - name: Driver Tests
             test-args: >-
               :only-tags [:mb/driver-tests]
-            exclude-tag: ':mb/transforms-python-test'
+              :exclude-tags [:mb/transforms-python-test]
           - name: Transforms Python Tests
             test-args: >-
               :only-tags [:mb/transforms-python-test]
@@ -852,12 +817,11 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Setup python-runner
-        if: ${{ matrix.job.needs-python-runner == true }}
-        uses: ./.github/actions/setup-python-runner
-        with:
-          metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      #if: ${{ matrix.job.needs-python-runner == true }}
+        env:
+          METABASE_AUTOMATION_USER_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+        run: ./.github/scripts/setup-python-runner.sh
       - name: Test ${{ matrix.version.name }} (${{ matrix.job.name }})
-        id: test-driver
         uses: ./.github/actions/test-driver
         with:
           junit-name: 'be-tests-${{ matrix.version.junit-name }}'
@@ -875,12 +839,6 @@ jobs:
           aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
           aws-region: ${{ vars.AWS_REGION }}
           trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
-      - name: Cleanup python-runner
-        if: always()
-        uses: ./.github/actions/cleanup-python-runner
-        with:
-          upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
-          logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}
 
   be-tests-presto-jdbc-ee:
     needs: determine-driver-skips
@@ -991,11 +949,10 @@ jobs:
     - uses: actions/checkout@v4
     - name: Setup python-runner
       if: ${{ matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/setup-python-runner
-      with:
-        metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      env:
+        METABASE_AUTOMATION_USER_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      run: ./.github/scripts/setup-python-runner.sh
     - name: Test ${{ matrix.job.name }}
-      id: test-driver
       if: ${{ !matrix.job.skip }}
       uses: ./.github/actions/test-driver
       with:
@@ -1013,12 +970,6 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
         aws-region: ${{ vars.AWS_REGION }}
         trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
-    - name: Cleanup python-runner
-      if: ${{ always() && matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/cleanup-python-runner
-      with:
-        upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
-        logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}
 
   be-tests-snowflake-ee:
     if: ${{ !inputs.skip }}
@@ -1060,11 +1011,10 @@ jobs:
     - uses: actions/checkout@v4
     - name: Setup python-runner
       if: ${{ matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/setup-python-runner
-      with:
-        metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      env:
+        METABASE_AUTOMATION_USER_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      run: ./.github/scripts/setup-python-runner.sh
     - name: Test Snowflake driver
-      id: test-driver
       uses: ./.github/actions/test-driver
       with:
         junit-name: 'be-tests-snowflake-ee'
@@ -1080,12 +1030,6 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
         aws-region: ${{ vars.AWS_REGION }}
         trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
-    - name: Cleanup python-runner
-      if: ${{ always() && matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/cleanup-python-runner
-      with:
-        upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
-        logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}
 
   be-tests-sparksql-ee:
     needs: determine-driver-skips
@@ -1196,11 +1140,10 @@ jobs:
     - uses: actions/checkout@v4
     - name: Setup python-runner
       if: ${{ matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/setup-python-runner
-      with:
-        metabase-automation-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      env:
+        METABASE_AUTOMATION_USER_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+      run: ./.github/scripts/setup-python-runner.sh
     - name: Test ${{ matrix.version.name }}
-      id: test-driver
       uses: ./.github/actions/test-driver
       with:
         junit-name: ${{ matrix.version.junit-name }}
@@ -1216,12 +1159,6 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
         aws-region: ${{ vars.AWS_REGION }}
         trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
-    - name: Cleanup python-runner
-      if: ${{ always() && matrix.job.needs-python-runner == true }}
-      uses: ./.github/actions/cleanup-python-runner
-      with:
-        upload-logs: ${{ steps.test-driver.outcome == 'failure' }}
-        logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}
 
   # TODO(dpsutton, 2025-08-20): Re-enable starburst when we figure out why it randomly dies in CI
   # be-tests-starburst-ee:

.github/workflows/e2e-embedding-sdk-compatibility-tests.yml

@@ -179,11 +179,7 @@ jobs:
           name: metabase-ee-${{ github.event.pull_request.head.sha || github.sha }}-uberjar
 
       - name: Build Embedding SDK package
-        run: |
-          # Remove the matchers to not report false positives on every PR
-          # unrelated to embedding (EMB-765)
-          echo "::remove-matcher owner=tsc::"
-          yarn build-embedding-sdk-package
+        run: yarn build-embedding-sdk-package
 
       - name: Prepare Embedding SDK artifact
         uses: actions/upload-artifact@v4

.github/workflows/e2e-tests.yml

@@ -118,8 +118,7 @@ jobs:
             const fs = require('fs');
             const path = require('path');
 
-            const globber = await glob.create('timing-files/*/chunkTimings.json');
-            const chunkFiles = await globber.glob();
+            const chunkFiles = glob.sync('timing-files/*/chunkTimings.json');
 
             const specs = new Map();
             chunkFiles.forEach(file => {

.github/workflows/embedding-sdk.yml

@@ -43,11 +43,7 @@ jobs:
         with:
           m2-cache-key: "cljs"
       - name: Build Embedding SDK package
-        run: |
-          # Remove the matchers to not report false positives on every PR
-          # unrelated to embedding (EMB-765)
-          echo "::remove-matcher owner=tsc::"
-          yarn build-embedding-sdk-package
+        run: yarn build-embedding-sdk-package
       - name: Prepare Embedding SDK artifact
         uses: actions/upload-artifact@v4
         with: