API dox include session token

We're now using `VITE_METABASE_INSTANCE_URL` and `VITE_AUTH_PROVIDER_URI`: https://github.com/metabase/metabase-nodejs-react-sdk-embedding-sample/blob/main/.env.example

.clj-kondo/config/modules/config.edn

@@ -0,0 +1,731 @@
+;; A "module" is any `metabase.<module>.core` namespace in `src`.
+;;
+;; ## `api`:
+;;
+;; Map of module name => the "core" external public-facing API namespace(s). You have three options here:
+;;
+;; 1. Special sentinel value `:any` means means this module does not (yet) have external public-facing API
+;;    namespace(s). This is mostly a temporary placeholder until we go in and create module namespaces, which means
+;;    you should go create one.
+;;
+;; 2. A set of namespace symbols. All namespaces in other modules will only be allowed to use namespaces from
+;;    this set. Ideally this set should only have one namespace, but restricting it to a set of several is still
+;;    better than `:any`.
+;;
+;; 3. `nil` or not listed here -- we default to assuming there is (some subset) of the 'standard' API namespaces
+;;    `<module>.api`, `<module>.core`, and `<module>.init`
+;;
+;; ## `uses`:
+;;
+;; Map of module => other modules you're allowed to use there. You have two options here:
+;;
+;; 1. `:any` means namespaces in this module are allowed to use any other module -- allowed modules are not
+;;    enforced for this module. Module API namespaces for modules that have them defined are still enforced. For
+;;    ones that are `nil`, please go in and add a list of allowed modules. `:any` is mostly meant a temporary
+;;    placeholder until we can fill these all out, so feel free to fix these.
+;;
+;; 2. A set of module symbols. This is the list of modules that are allowed to be referenced. An empty set means no
+;;    other modules are allowed to be referenced; this is the default for any modules that aren't listed here.
+;;
+;; ## Tips
+;;
+;; PRO TIP: Check out the [[dev.deps-graph]] namespace for helpful tools to see where a module is used externally, and
+;; for tools for calculating this config.
+{:metabase/modules
+ {actions
+  {:api  #{metabase.actions.api metabase.actions.core}
+   :uses #{analytics api driver legacy-mbql lib model-persistence models query-processor search util}}
+
+  activity-feed
+  {:api  #{metabase.activity-feed.api metabase.activity-feed.init}
+   :uses #{api config db events models util}}
+
+  analytics
+  {:api  #{metabase.analytics.core
+           metabase.analytics.prometheus
+           metabase.analytics.snowplow}
+   :uses #{api
+           config
+           db
+           driver
+           eid-translation
+           integrations
+           models
+           premium-features
+           public-settings
+           server
+           util}}
+  analyze
+  {:api  #{metabase.analyze.core metabase.analyze.query-results}
+   :uses #{config driver legacy-mbql lib models sync util}}
+
+  api
+  {:api #{metabase.api.cache
+          metabase.api.card
+          metabase.api.collection
+          metabase.api.common
+          metabase.api.common.validation
+          metabase.api.dashboard
+          metabase.api.dataset
+          metabase.api.field
+          metabase.api.macros
+          metabase.api.open-api
+          metabase.api.query-metadata
+          metabase.api.routes
+          metabase.api.routes.common
+          metabase.api.table
+          metabase.api.user
+          metabase.api.util.handlers}
+   :uses :any}
+
+  audit {:api  #{metabase.audit}
+         :uses #{db models}}
+
+  auth-provider
+  {:api  #{metabase.auth-provider}
+   :uses #{premium-features}}
+
+  bookmarks
+  {:api  #{metabase.bookmarks.api}
+   :uses #{api db models util}}
+
+  channel
+  {:api  #{metabase.channel.api
+           metabase.channel.core
+           metabase.channel.email
+           metabase.channel.email.messages
+           metabase.channel.init
+           metabase.channel.render.core
+           metabase.channel.template.core}
+   :uses #{analytics
+           api
+           config
+           db
+           driver
+           events
+           formatter
+           integrations
+           lib
+           models
+           notification
+           permissions
+           premium-features
+           public-settings
+           query-processor
+           timeline
+           types
+           util}}
+
+  cloud-migration
+  {:api  #{metabase.cloud-migration.api
+           metabase.cloud-migration.core
+           metabase.cloud-migration.init}
+   :uses #{api cmd config db models premium-features util}}
+
+  cmd
+  {:api  #{metabase.cmd
+           metabase.cmd.copy
+           metabase.cmd.dump-to-h2}
+   :uses #{api config db legacy-mbql models plugins query-processor search util}}
+
+  ;; technically this 'uses' `enterprise/core` and `test` since it tries to load them to see if they exists so we know
+  ;; if EE/test code is available; however we can ignore them since they're not real usages.
+  config
+  {:api  #{metabase.config}
+   :uses #{}}
+
+  ;; this is not actually a real module, but comes from one of our libraries.
+  connection-pool
+  {:api  #{metabase.connection-pool}
+   :uses #{}}
+
+  core
+  {:api  #{metabase.core.initialization-status}
+   :uses :any}
+
+  db
+  {:api  #{metabase.db metabase.db.metadata-queries metabase.db.query metabase.db.setup}
+   :uses #{auth-provider config connection-pool driver legacy-mbql lib plugins query-processor task util}}
+
+  driver
+  {:api #{metabase.driver
+          metabase.driver.common
+          metabase.driver.common.parameters
+          metabase.driver.common.parameters.dates
+          metabase.driver.common.parameters.operators
+          metabase.driver.common.parameters.parse
+          metabase.driver.common.parameters.values
+          metabase.driver.ddl.interface
+          metabase.driver.h2
+          metabase.driver.impl
+          metabase.driver.init
+          metabase.driver.mysql
+          metabase.driver.postgres
+          metabase.driver.sql
+          metabase.driver.sql-jdbc.connection
+          metabase.driver.sql-jdbc.execute
+          metabase.driver.sql-jdbc.execute.diagnostic
+          metabase.driver.sql-jdbc.sync
+          metabase.driver.sql.query-processor
+          metabase.driver.sql.query-processor.deprecated
+          metabase.driver.sql.util
+          metabase.driver.sync
+          metabase.driver.util}
+   :uses #{actions
+           auth-provider
+           config
+           connection-pool
+           db
+           legacy-mbql
+           lib
+           logger
+           models
+           plugins
+           premium-features
+           public-settings
+           pulse
+           query-processor
+           sync
+           upload
+           util}}
+
+  eid-translation
+  {:api  #{metabase.eid-translation}
+   :uses #{}}
+
+  embed
+  {:api  #{metabase.embed.settings}
+   :uses #{analytics models premium-features util}}
+
+  events
+  {:api  #{metabase.events metabase.events.init metabase.events.notification}
+   :uses #{api driver models notification premium-features util}}
+
+  formatter
+  {:api  #{metabase.formatter}
+   :uses #{models public-settings query-processor types util}}
+
+  indexed-entities
+  {:api  #{metabase.indexed-entities.api metabase.indexed-entities.init}
+   :uses #{analytics api driver legacy-mbql lib models query-processor search sync task util}}
+
+  integrations
+  {:api  #{metabase.integrations.slack}
+   :uses #{events models util}}
+
+  legacy-mbql
+  {:api #{metabase.legacy-mbql.normalize
+          metabase.legacy-mbql.predicates
+          metabase.legacy-mbql.schema
+          metabase.legacy-mbql.schema.helpers
+          metabase.legacy-mbql.util}
+   :uses #{lib models types util}}
+
+  lib
+  {:api #{metabase.lib.binning
+          metabase.lib.binning.util
+          metabase.lib.card
+          metabase.lib.convert
+          metabase.lib.core
+          metabase.lib.equality
+          metabase.lib.field
+          metabase.lib.filter
+          metabase.lib.ident
+          metabase.lib.join.util
+          metabase.lib.metadata
+          metabase.lib.metadata.calculation
+          metabase.lib.metadata.jvm
+          metabase.lib.metadata.protocols
+          metabase.lib.normalize
+          metabase.lib.options
+          metabase.lib.query
+          metabase.lib.schema
+          metabase.lib.schema.actions
+          metabase.lib.schema.binning
+          metabase.lib.schema.common
+          metabase.lib.schema.expression
+          metabase.lib.schema.expression.temporal
+          metabase.lib.schema.expression.window
+          metabase.lib.schema.id
+          metabase.lib.schema.info
+          metabase.lib.schema.literal
+          metabase.lib.schema.metadata
+          metabase.lib.schema.parameter
+          metabase.lib.schema.template-tag
+          metabase.lib.schema.temporal-bucketing
+          metabase.lib.schema.util
+          metabase.lib.temporal-bucket
+          metabase.lib.types.isa
+          metabase.lib.util
+          metabase.lib.util.match
+          metabase.lib.walk}
+   :uses #{config driver legacy-mbql models types util}}
+
+  logger
+  {:api  #{metabase.logger metabase.logger.init}
+   :uses #{config plugins}}
+
+  login-history
+  {:api #{metabase.login-history.api
+          metabase.login-history.core
+          metabase.login-history.init}
+   :uses #{analytics api channel models request util}}
+
+  model-persistence
+  {:api #{metabase.model-persistence.api
+          metabase.model-persistence.core
+          metabase.model-persistence.init}
+   :uses #{api db driver events lib models premium-features public-settings query-processor request task util}}
+
+  models
+  {:api #{metabase.models.api-key
+          metabase.models.application-permissions-revision
+          metabase.models.audit-log
+          metabase.models.cache-config
+          metabase.models.card
+          metabase.models.card.metadata
+          metabase.models.collection
+          metabase.models.collection-permission-graph-revision
+          metabase.models.collection.graph
+          metabase.models.collection.root
+          metabase.models.dashboard
+          metabase.models.dashboard-card
+          metabase.models.dashboard-tab
+          metabase.models.dashboard.constants
+          metabase.models.database
+          metabase.models.dispatch
+          metabase.models.field
+          metabase.models.field-usage
+          metabase.models.field-values
+          metabase.models.humanization
+          metabase.models.init
+          metabase.models.interface
+          metabase.models.moderation-review
+          metabase.models.native-query-snippet
+          metabase.models.native-query-snippet.permissions
+          metabase.models.notification
+          metabase.models.params
+          metabase.models.params.chain-filter
+          metabase.models.params.custom-values
+          metabase.models.params.field-values
+          metabase.models.params.shared
+          metabase.models.query
+          metabase.models.query-analysis
+          metabase.models.query.permissions
+          metabase.models.resolution
+          metabase.models.secret
+          metabase.models.serialization
+          metabase.models.setting
+          metabase.models.setting.cache
+          metabase.models.setting.multi-setting
+          metabase.models.table
+          metabase.models.task-history
+          metabase.models.user
+          metabase.models.user-parameter-value
+          metabase.models.view-log-impl
+          metabase.models.visualization-settings}
+   :uses #{analytics
+           analyze
+           api
+           audit
+           channel
+           config
+           db
+           driver
+           events
+           legacy-mbql
+           lib
+           moderation
+           permissions
+           plugins
+           premium-features
+           public-settings
+           public-sharing
+           pulse
+           query-analysis
+           query-processor
+           request
+           search
+           server
+           setup
+           sync
+           task
+           types
+           util
+           enterprise/advanced-permissions}}
+
+  moderation
+  {:api  #{metabase.moderation}
+   :uses #{models util}}
+
+  notification
+  {:api  #{metabase.notification.core
+           metabase.notification.init
+           metabase.notification.payload.core
+           metabase.notification.payload.execute}
+   :uses #{analytics api channel events models permissions premium-features public-settings query-processor request util}}
+
+  permissions
+  {:api  #{metabase.permissions.api
+           metabase.permissions.core
+           metabase.permissions.models.data-permissions
+           metabase.permissions.models.permissions
+           metabase.permissions.models.permissions-group
+           metabase.permissions.util}
+   :uses #{api audit config db models plugins premium-features request server util}}
+
+  plugins
+  {:api  #{metabase.plugins metabase.plugins.classloader}
+   :uses #{config driver util}}
+
+  premium-features
+  {:api  #{metabase.premium-features.core
+           metabase.premium-features.token-check}
+   :uses #{config db models plugins util}}
+
+  public-settings
+  {:api  #{metabase.public-settings}
+   :uses #{api config models premium-features util}}
+
+  public-sharing
+  {:api  #{metabase.public-sharing.api
+           metabase.public-sharing.core
+           metabase.public-sharing.init}
+   :uses #{actions analytics api db events lib models query-processor request util}}
+
+  pulse
+  {:api  #{metabase.pulse.api
+           metabase.pulse.core
+           metabase.pulse.init
+           metabase.pulse.task.send-pulses}
+   :uses #{api channel config db driver events integrations models notification permissions plugins premium-features
+           query-processor request task util
+           enterprise/advanced-config enterprise/advanced-permissions enterprise/sandbox}}
+
+  query-analysis
+  {:api  #{metabase.query-analysis.core metabase.query-analysis.init}
+   :uses #{config driver legacy-mbql lib public-settings query-processor task util}}
+
+  query-processor
+  {:api #{metabase.query-processor
+          metabase.query-processor.card
+          metabase.query-processor.compile
+          metabase.query-processor.dashboard
+          metabase.query-processor.debug
+          metabase.query-processor.error-type
+          metabase.query-processor.interface
+          metabase.query-processor.metadata
+          metabase.query-processor.middleware.annotate
+          metabase.query-processor.middleware.cache-backend.db
+          metabase.query-processor.middleware.constraints
+          metabase.query-processor.middleware.fetch-source-query
+          metabase.query-processor.middleware.fetch-source-query-legacy
+          metabase.query-processor.middleware.limit
+          metabase.query-processor.middleware.permissions
+          metabase.query-processor.middleware.wrap-value-literals
+          metabase.query-processor.pipeline
+          metabase.query-processor.pivot
+          metabase.query-processor.preprocess
+          metabase.query-processor.reducible
+          metabase.query-processor.schema
+          metabase.query-processor.setup
+          metabase.query-processor.store
+          metabase.query-processor.streaming
+          metabase.query-processor.streaming.common
+          metabase.query-processor.streaming.interface
+          metabase.query-processor.timezone
+          metabase.query-processor.util
+          metabase.query-processor.util.add-alias-info
+          metabase.query-processor.util.nest-query
+          metabase.query-processor.util.persisted-cache
+          metabase.query-processor.util.relative-datetime
+          metabase.query-processor.util.transformations.nest-breakouts
+          metabase.query-processor.writeback}
+   :uses #{analytics
+           analyze
+           api
+           audit
+           config
+           db
+           driver
+           events
+           formatter
+           legacy-mbql
+           lib
+           model-persistence
+           models
+           permissions
+           premium-features
+           public-settings
+           request
+           server
+           types
+           util}}
+
+  request
+  {:api  #{metabase.request.core}
+   :uses #{api config models permissions public-settings util}}
+
+  revisions
+  {:api  #{metabase.revisions.api metabase.revisions.core metabase.revisions.init}
+   :uses #{api config events models util}}
+
+  sample-data
+  {:api  #{metabase.sample-data}
+   :uses #{plugins sync util}}
+
+  search
+  {:api #{metabase.search.api
+          metabase.search.appdb.scoring
+          metabase.search.config
+          metabase.search.core
+          metabase.search.in-place.scoring
+          metabase.search.ingestion
+          metabase.search.init
+          metabase.search.spec}
+   :uses #{analytics api audit config db driver models permissions premium-features public-settings request task util}}
+
+  segments
+  {:api  #{metabase.segments.api}
+   :uses #{api events legacy-mbql lib models permissions search util xrays}}
+
+  server
+  {:api #{metabase.server.core
+          metabase.server.middleware.json
+          metabase.server.middleware.session
+          metabase.server.streaming-response}
+   :uses #{analytics api config core db driver models premium-features public-settings request util enterprise/sso}}
+
+  session
+  {:api  #{metabase.session.api metabase.session.init metabase.session.models.session}
+   :uses #{api channel config db driver events login-history models public-settings request sso task util}}
+
+  setup
+  {:api  #{metabase.setup.api metabase.setup.core}
+   :uses #{analytics
+           api
+           channel
+           config
+           db
+           embed
+           events
+           integrations
+           models
+           permissions
+           premium-features
+           public-settings
+           request
+           session
+           util}}
+
+  sso
+  {:api  #{metabase.sso.api
+           metabase.sso.core
+           metabase.sso.init}
+   :uses #{api models permissions premium-features util}}
+
+  sync
+  {:api #{metabase.sync.api
+          metabase.sync.concurrent
+          metabase.sync.core
+          metabase.sync.init
+          metabase.sync.schedules
+          metabase.sync.task.sync-databases
+          metabase.sync.util}
+   :uses #{analyze api audit config db driver events lib models plugins query-processor task util}}
+
+  task
+  {:api #{metabase.task
+          metabase.task.bootstrap
+          metabase.task.init
+          metabase.task.notification}
+   :uses #{analytics
+           channel
+           config
+           db
+           driver
+           integrations
+           models
+           notification
+           plugins
+           premium-features
+           public-settings
+           query-processor
+           util
+           enterprise/task}}
+
+  tiles
+  {:api  #{metabase.tiles.api
+           metabase.tiles.init}
+   :uses #{api legacy-mbql models query-processor util}}
+
+  timeline
+  {:api  #{metabase.timeline.api metabase.timeline.core}
+   :uses #{analytics api models util}}
+
+  types
+  {:api  #{metabase.types}
+   :uses #{util}}
+
+  upload
+  {:api  #{metabase.upload}
+   :uses #{analytics api driver events legacy-mbql lib model-persistence models permissions public-settings sync util}}
+
+  user-key-value
+  {:api  #{metabase.user-key-value.api metabase.user-key-value.init}
+   :uses #{api config lib util}}
+
+  util
+  {:api :any
+   :uses #{config driver legacy-mbql lib models plugins premium-features public-settings}}
+
+  xrays
+  {:api  #{metabase.xrays.api metabase.xrays.core}
+   :uses #{analyze api db driver legacy-mbql lib models public-settings query-processor util}}
+
+  enterprise/advanced-config
+  {:api  #{metabase-enterprise.advanced-config.api.logs
+           metabase-enterprise.advanced-config.models.pulse-channel
+           metabase-enterprise.advanced-config.file}
+   :uses #{api db driver models premium-features setup sync util}}
+
+  enterprise/advanced-permissions
+  {:api  #{metabase-enterprise.advanced-permissions.api.routes
+           metabase-enterprise.advanced-permissions.api.util
+           metabase-enterprise.advanced-permissions.common
+           metabase-enterprise.advanced-permissions.models.permissions.group-manager}
+   :uses #{api audit driver lib models permissions premium-features query-processor util enterprise/sandbox}}
+
+  enterprise/airgap
+  {:api  #{}
+   :uses #{premium-features util}}
+
+  enterprise/api
+  {:api  #{metabase-enterprise.api.routes
+           metabase-enterprise.api.routes.common}
+   :uses :any}
+
+  enterprise/audit-app
+  {:api  #{metabase-enterprise.audit-app.api.routes}
+   :uses #{api
+           audit
+           db
+           driver
+           lib
+           models
+           permissions
+           plugins
+           premium-features
+           query-processor
+           sync
+           util
+           enterprise/serialization}}
+
+  enterprise/auth-provider
+  {:api  #{}
+   :uses #{premium-features util}}
+
+  enterprise/billing
+  {:api  #{metabase-enterprise.billing.api.routes}
+   :uses #{api premium-features util}}
+
+  enterprise/cache
+  {:api  #{metabase-enterprise.cache.strategies}
+   :uses #{api models premium-features query-processor util}}
+
+  enterprise/content-verification
+  {:api  #{metabase-enterprise.content-verification.api.routes}
+   :uses #{api models moderation util enterprise/api}}
+
+  enterprise/core
+  {:api  #{metabase-enterprise.core.init}
+   :uses #{enterprise/enhancements}}
+
+  enterprise/dashboard-subscription-filters
+  {:api  #{}
+   :uses #{premium-features}}
+
+  enterprise/enhancements
+  {:api  #{metabase-enterprise.enhancements.init}
+   :uses #{models premium-features sso util enterprise/sso}}
+
+  enterprise/llm
+  {:api  #{metabase-enterprise.llm.api}
+   :uses #{analytics analyze api models query-processor util}}
+
+  enterprise/query-reference-validation
+  {:api  #{metabase-enterprise.query-reference-validation.api}
+   :uses #{api models public-settings request util}}
+
+  enterprise/sandbox
+  {:api #{metabase-enterprise.sandbox.api.routes
+          metabase-enterprise.sandbox.api.util}
+   :uses #{api
+           audit
+           db
+           legacy-mbql
+           lib
+           models
+           permissions
+           plugins
+           premium-features
+           query-processor
+           request
+           util
+           enterprise/advanced-permissions
+           enterprise/api}}
+
+  enterprise/scim
+  {:api  #{metabase-enterprise.scim.api metabase-enterprise.scim.routes}
+   :uses #{analytics api models permissions public-settings server util enterprise/serialization}}
+
+  enterprise/search
+  {:api  #{}
+   :uses #{premium-features search}}
+
+  enterprise/serialization
+  {:api #{metabase-enterprise.serialization.api
+          metabase-enterprise.serialization.cmd
+          metabase-enterprise.serialization.v2.backfill-ids}
+   :uses #{analytics api config db legacy-mbql lib logger models plugins premium-features public-settings setup util}}
+
+  enterprise/snippet-collections
+  {:api  #{}
+   :uses #{models permissions premium-features util}}
+
+  enterprise/sso
+  {:api #{metabase-enterprise.sso.api.routes
+          metabase-enterprise.sso.integrations.sso-settings
+          metabase-enterprise.sso.integrations.sso-utils}
+   :uses #{api channel embed events models premium-features public-settings request session sso util enterprise/scim}}
+
+  enterprise/stale
+  {:api  #{metabase-enterprise.stale.routes}
+   :uses #{analytics api embed models premium-features public-settings request util}}
+
+  enterprise/stats
+  {:api  #{}
+   :uses #{driver premium-features enterprise/advanced-config enterprise/scim enterprise/sso}}
+
+  enterprise/task
+  {:api  #{metabase-enterprise.task.truncate-audit-tables}
+   :uses #{premium-features query-processor task util enterprise/cache}}
+
+  enterprise/upload-management
+  {:api  #{metabase-enterprise.upload-management.api}
+   :uses #{api models upload util}}}
+
+ ;; namespaces matching these patterns (with `re-find`) are excluded from the module linter. Since regex literals
+ ;; aren't allowed in EDN just used the `(str <regex>)` version i.e. two slashes instead of one.
+ ;;
+ ;; this is mostly intended for excluding test namespaces or those rare 'glue' namespaces that glue multiple modules
+ ;; together, e.g. `metabase.lib.metadata.jvm`.
+ :linters
+ {:metabase/modules
+  {:ignored-namespace-patterns
+   #{"-test$"                           ; anything ending in `-test`
+     "test[-.]util"                     ; anything that contains `test.util` or `test-util`
+     "test\\.impl"                      ; anything that contains `test.impl`
+     "test-setup"                       ; anything that contains `test-setup`
+     "^metabase(?:-enterprise)?\\.test" ; anything starting with `metabase.test` or `metabase-enterprise.test`
+     "^metabase\\.http-client$"}}}}     ; `metabase.http-client` which is a test-only namespace despite its name.

.clj-kondo/config/test-helpers/config.edn

@@ -0,0 +1,132 @@
+{:linters
+ {:metabase/test-helpers-use-non-thread-safe-functions
+  ;; TODO -- seems silly to maintain different blacklists and whitelists here than we use for the deftest `^:parallel`
+  ;; checker...
+  {:explicitly-safe
+   #{ ;; these toucan methods might actually set global values if it's used outside of a transaction,
+     ;; but since mt/with-temp runs in a transaction, so we'll ignore them in this case.
+     toucan2.core/delete!
+     toucan2.core/update!
+     toucan2.core/insert!
+     toucan2.core/insert-returning-instance!
+     toucan2.core/insert-returning-instances!
+     toucan2.core/insert-returning-pk!
+     toucan2.core/insert-returning-pks!
+     clojure.core.async/<!!
+     clojure.core.async/>!!
+     clojure.core.async/alts!!
+     clojure.core.async/close!
+     clojure.core.async/poll!
+     clojure.core.memoize/memo-clear!
+     clojure.core/conj!
+     clojure.core/persistent!
+     clojure.core/reset!
+     clojure.core/swap!
+     clojure.core/volatile!
+     clojure.core/vreset!
+     clojure.core/vswap!
+     clojure.java.jdbc/execute!
+     methodical.core/add-aux-method-with-unique-key!
+     methodical.core/remove-aux-method-with-unique-key!
+     next.jdbc/execute!
+
+     ;; Definitely thread safe
+     metabase.test.util.dynamic-redefs/patch-vars!
+
+     ;; TODO: most of these symbols shouldn't be here, we should go through them and
+     ;; find the functions/macros that use them and make sure their names end with !
+     ;; best way to do this is try remove each of these and rely on kondo output to find places where it's used
+     clojure.test/grant-collection-perms!
+     clojure.test/grant-collection-perms-fn!
+     clojure.test/grant-perms-fn!
+     clojure.test/purge-old-entries!
+     clojure.test/revoke-collection-perms!
+     clojure.test/save-results!
+     metabase-enterprise.advanced-permissions.models.permissions/update-db-download-permissions!
+     metabase-enterprise.internal-user/install-internal-user!
+     metabase-enterprise.sso.integrations.saml-test/call-with-login-attributes-cleared!
+     metabase.actions.actions/perform-action!
+     metabase.actions.models/insert!
+     metabase.analytics.snowplow-test/fake-track-event-impl!
+     metabase.analytics.snowplow/track-event-impl!
+     metabase.channel.email-test/reset-inbox!
+     metabase.channel.email/send-email!
+     metabase.cmd.dump-to-h2/dump-to-h2!
+     metabase.cmd.load-from-h2/load-from-h2!
+     metabase.core.core/ensure-audit-db-installed!
+     metabase.db.schema-migrations-test.impl/run-migrations-in-range!
+     metabase.db.setup/migrate!
+     metabase.db.setup/setup-db!
+     metabase.db/migrate!
+     metabase.db/setup-db!
+     metabase.driver.mongo-test/create-database-from-row-maps!
+     metabase.driver.postgres-test/create-enums-db!
+     metabase.driver.postgres-test/drop-if-exists-and-create-db!
+     metabase.driver.sql-jdbc.execute/execute-statement!
+     metabase.indexed-entities.models.model-index/add-values!
+     metabase.indexed-entities.task.index-values/job-init!
+     metabase.model-persistence.models.persisted-info/ready-database!
+     metabase.model-persistence.task.persist-refresh/job-init!
+     metabase.model-persistence.task.persist-refresh/refresh-tables!
+     metabase.model-persistence.task.persist-refresh/schedule-persistence-for-database!
+     metabase.models.collection.graph-test/clear-graph-revisions!
+     metabase.models.collection.graph-test/do-with-n-temp-users-with-personal-collections!
+     metabase.models.field-values/create-or-update-full-field-values!
+     metabase.models.moderation-review/create-review!
+     metabase.models.on-demand-test/add-dashcard-with-parameter-mapping!
+     metabase.models.setting-test/test-user-local-allowed-setting!
+     metabase.models.setting-test/test-user-local-only-setting!
+     metabase.models.setting.cache/restore-cache!
+     metabase.models.setting/set!
+     metabase.models.setting/validate-settings-formatting!
+     metabase.permissions.models.permissions/grant-application-permissions!
+     metabase.permissions.models.permissions/grant-collection-read-permissions!
+     metabase.permissions.models.permissions/grant-collection-readwrite-permissions!
+     metabase.permissions.models.permissions/grant-full-data-permissions!
+     metabase.permissions.models.permissions/grant-native-readwrite-permissions!
+     metabase.permissions.models.permissions/grant-permissions!
+     metabase.permissions.models.permissions/revoke-application-permissions!
+     metabase.permissions.models.permissions/revoke-data-perms!
+     metabase.permissions.models.permissions/update-data-perms-graph!
+     metabase.permissions.models.permissions/update-group-permissions!
+     metabase.permissions.test-util/with-restored-perms!
+     metabase.public-sharing.api-test/add-card-to-dashboard!
+     metabase.pulse.send/send-notifications!
+     metabase.pulse.send/send-pulse!
+     metabase.query-processor.streaming.interface/begin!
+     metabase.query-processor.streaming.interface/finish!
+     metabase.query-processor.streaming.interface/write-row!
+     metabase.sample-data/try-to-extract-sample-database!
+     metabase.setup.core/create-token!
+     metabase.sso.ldap-test-util/start-ldap-server!
+     metabase.sync.core/sync-database!
+     metabase.sync.sync-metadata.fields.sync-metadata/update-field-metadata-if-needed!
+     metabase.sync.sync-metadata/sync-db-metadata!
+     metabase.sync.util-test/sync-database!
+     metabase.sync.util/store-sync-summary!
+     metabase.task/delete-task!
+     metabase.test.data.bigquery-cloud-sdk/execute!
+     metabase.test.data.impl.get-or-create/set-test-db-permissions!
+     metabase.test.data.impl/copy-db-tables-and-fields!
+     metabase.test.data.impl/get-or-create-database!
+     metabase.test.data.impl/get-or-create-default-dataset!
+     metabase.test.data.interface/create-db!
+     metabase.test.data.interface/destroy-db!
+     metabase.test.data.oracle/create-user!
+     metabase.test.data.oracle/drop-user!
+     metabase.test.data.sql-jdbc.load-data/make-insert!
+     metabase.test.data.users/clear-cached-session-tokens!
+     metabase.test.initialize/do-initialization!
+     metabase.test.initialize/initialize-if-needed!
+     metabase.test.util.log/ensure-unique-logger!
+     metabase.test.util.log/set-ns-log-level!
+     metabase.test.util/do-with-temp-env-var-value!
+     metabase.test.util/restore-raw-setting!
+     metabase.test.util/upsert-raw-setting!
+     metabase.test/initialize-if-needed!
+     metabase.test/test-helpers-set-global-values!
+     metabase.test/with-temp-env-var-value!
+     metabase.upload-test/set-local-infile!
+     metabase.util.files/create-dir-if-not-exists!
+     metabase.util.ssh-test/start-mock-servers!
+     metabase.util.ssh-test/stop-mock-servers!}}}}

.clj-kondo/macros/metabase/api/collection_test.clj

@@ -1,7 +1,7 @@
 (ns macros.metabase.api.collection-test
   (:require [macros.common]))
 
-(defmacro with-collection-hierarchy [bindings & body]
+(defmacro with-collection-hierarchy! [bindings & body]
   `(let [~(macros.common/ignore-unused 'a) nil
          ~(macros.common/ignore-unused 'b) nil
          ~(macros.common/ignore-unused 'c) nil
@@ -12,6 +12,6 @@
      ~bindings
      ~@body))
 
-(defmacro with-some-children-of-collection [collection-or-id-or-nil & body]
+(defmacro with-some-children-of-collection! [collection-or-id-or-nil & body]
   `(let [~(macros.common/ignore-unused '&ids) ~collection-or-id-or-nil]
      ~@body))

.clj-kondo/macros/metabase/api/common.clj

@@ -1,7 +0,0 @@
-(ns macros.metabase.api.common)
-
-(defmacro define-routes
-  "Macro for api.common/define-routes"
-  [& args]
-  `(do (def ~'routes "docstring" nil)
-       ~@args))

.clj-kondo/macros/metabase/api/embed_test.clj

@@ -1,11 +1,11 @@
 (ns macros.metabase.api.embed-test)
 
-(defmacro with-embedding-enabled-and-temp-card-referencing
+(defmacro with-embedding-enabled-and-temp-card-referencing!
   [table-kw field-kw [card-binding] & body]
   `(let [~card-binding [~table-kw ~field-kw]]
      ~@body))
 
-(defmacro with-embedding-enabled-and-temp-dashcard-referencing
+(defmacro with-embedding-enabled-and-temp-dashcard-referencing!
   [table-kw field-kw [dash-binding card-binding dashcard-binding] & body]
   `(let [~dash-binding             [~table-kw ~field-kw]
          ~(or card-binding '_)     nil

.clj-kondo/macros/metabase/api/public_test.clj

@@ -1,13 +0,0 @@
-(ns macros.metabase.api.public-test)
-
-(defmacro with-sharing-enabled-and-temp-card-referencing
-  [table-kw field-kw [card-binding] & body]
-  `(let [~card-binding [~table-kw ~field-kw]]
-     ~@body))
-
-(defmacro with-sharing-enabled-and-temp-dashcard-referencing
-  [table-kw field-kw [dash-binding card-binding dashcard-binding] & body]
-  `(let [~dash-binding             [~table-kw ~field-kw]
-         ~(or card-binding '_)     nil
-         ~(or dashcard-binding '_) nil]
-     ~@body))

.clj-kondo/macros/metabase/models/query_analysis_test.clj

@@ -0,0 +1,9 @@
+(ns macros.metabase.models.query-analysis-test
+  (:require [macros.common]))
+
+(defmacro with-test-setup [& body]
+  `(let [~(macros.common/ignore-unused 'card-id)  1
+         ~(macros.common/ignore-unused 'table-id) 2
+         ~(macros.common/ignore-unused 'tax-id)   3
+         ~(macros.common/ignore-unused 'total-id) 4]
+     ~@body))

.clj-kondo/macros/metabase/models/query_field_test.clj

@@ -1,9 +0,0 @@
-(ns macros.metabase.models.query-field-test
-  (:require [macros.common]))
-
-(defmacro with-test-setup [& body]
-  `(let [~(macros.common/ignore-unused 'card-id)  1
-         ~(macros.common/ignore-unused 'table-id) 2
-         ~(macros.common/ignore-unused 'tax-id)   3
-         ~(macros.common/ignore-unused 'total-id) 4]
-     ~@body))

.clj-kondo/macros/metabase/public_sharing/api_test.clj

@@ -0,0 +1,13 @@
+(ns macros.metabase.public-sharing.api-test)
+
+(defmacro with-sharing-enabled-and-temp-card-referencing!
+  [table-kw field-kw [card-binding] & body]
+  `(let [~card-binding [~table-kw ~field-kw]]
+     ~@body))
+
+(defmacro with-sharing-enabled-and-temp-dashcard-referencing!
+  [table-kw field-kw [dash-binding card-binding dashcard-binding] & body]
+  `(let [~dash-binding             [~table-kw ~field-kw]
+         ~(or card-binding '_)     nil
+         ~(or dashcard-binding '_) nil]
+     ~@body))

.clj-kondo/macros/metabase/query_analysis/task/test_setup.clj

@@ -0,0 +1,13 @@
+(ns macros.metabase.query-analysis.task.test-setup
+  (:require [macros.common]))
+
+(defmacro with-test-setup!
+  "Set up the data required to test the Query Analysis related tasks"
+  [& body]
+  `(let [~(macros.common/ignore-unused 'c1) 1
+         ~(macros.common/ignore-unused 'c2) 2
+         ~(macros.common/ignore-unused 'c3) 3
+         ~(macros.common/ignore-unused 'c4) 4
+         ~(macros.common/ignore-unused 'archived) 5
+         ~(macros.common/ignore-unused 'invalid) 6]
+     ~@body))

.clj-kondo/macros/metabase/related_test.clj

@@ -1,13 +0,0 @@
-(ns macros.metabase.related-test
-  (:require [macros.common]))
-
-(defmacro with-world [& body]
-  `(let [~(macros.common/ignore-unused 'collection-id) nil
-         ~(macros.common/ignore-unused 'metric-id-a) nil
-         ~(macros.common/ignore-unused 'metric-id-b) nil
-         ~(macros.common/ignore-unused 'segment-id-a) nil
-         ~(macros.common/ignore-unused 'segment-id-b) nil
-         ~(macros.common/ignore-unused 'card-id-a) nil
-         ~(macros.common/ignore-unused 'card-id-b) nil
-         ~(macros.common/ignore-unused 'card-id-c) nil]
-     ~@body))

.clj-kondo/macros/metabase/shared/util/namespaces.clj

@@ -1,8 +0,0 @@
-(ns macros.metabase.shared.util.namespaces)
-
-(defmacro import-fn
-  "Kondo macro replacement for [[metabase.shared.util.namespaces/import-fn]]."
-  ([sym]
-   `(def ~(-> sym name symbol) "docstring" ~sym))
-  ([sym name]
-   `(def ~name "docstring" ~sym)))

.clj-kondo/macros/metabase/task/setup/query_analysis_setup.clj

@@ -1,12 +0,0 @@
-(ns macros.metabase.task.setup.query-analysis-setup
-  (:require [macros.common]))
-
-(defmacro with-test-setup!
-  "Set up the data required to test the Query Analysis related tasks"
-  [& body]
-  `(let [~(macros.common/ignore-unused 'c1) 1
-         ~(macros.common/ignore-unused 'c2) 2
-         ~(macros.common/ignore-unused 'c3) 3
-         ~(macros.common/ignore-unused 'c4) 4
-         ~(macros.common/ignore-unused 'arch) 5]
-     ~@body))

.clj-kondo/macros/metabase/test/persistence.clj

@@ -1,5 +0,0 @@
-(ns macros.metabase.test.persistence)
-
-(defmacro with-persistence-enabled [[persist-fn-sym] & body]
-  `(clojure.core/let [~persist-fn-sym (fn [])]
-     ~@body))

.clj-kondo/macros/metabase/util/namespaces.clj

@@ -0,0 +1,8 @@
+(ns macros.metabase.util.namespaces)
+
+(defmacro import-fn
+  "Kondo macro replacement for [[metabase.util.namespaces/import-fn]]."
+  ([sym]
+   `(def ~(-> sym name symbol) "docstring" ~sym))
+  ([sym name]
+   `(def ~name "docstring" ~sym)))

.clj-kondo/macros/metabase/xrays/related_test.clj

@@ -0,0 +1,13 @@
+(ns macros.metabase.xrays.related-test
+  (:require [macros.common]))
+
+(defmacro with-world [& body]
+  `(let [~(macros.common/ignore-unused 'collection-id) nil
+         ~(macros.common/ignore-unused 'metric-id-a) nil
+         ~(macros.common/ignore-unused 'metric-id-b) nil
+         ~(macros.common/ignore-unused 'segment-id-a) nil
+         ~(macros.common/ignore-unused 'segment-id-b) nil
+         ~(macros.common/ignore-unused 'card-id-a) nil
+         ~(macros.common/ignore-unused 'card-id-b) nil
+         ~(macros.common/ignore-unused 'card-id-c) nil]
+     ~@body))

.clj-kondo/macros/metabase_enterprise/query_field_validation/api_test.clj

@@ -1,13 +0,0 @@
-(ns macros.metabase-enterprise.query-field-validation.api-test
-  (:require [macros.common]))
-
-(defmacro with-test-setup [& body]
-  `(let [~(macros.common/ignore-unused 'card-1) 1
-         ~(macros.common/ignore-unused 'card-2) 2
-         ~(macros.common/ignore-unused 'card-3) 3
-         ~(macros.common/ignore-unused 'card-4) 4
-         ~(macros.common/ignore-unused 'qf-1)   10
-         ~(macros.common/ignore-unused 'qf-1b)  15
-         ~(macros.common/ignore-unused 'qf-2)   20
-         ~(macros.common/ignore-unused 'qf-3)   30]
-     ~@body))

.clj-kondo/macros/metabase_enterprise/query_reference_validation/api_test.clj

@@ -0,0 +1,12 @@
+(ns macros.metabase-enterprise.query-reference-validation.api-test
+  (:require [macros.common]))
+
+(defmacro with-test-setup! [& body]
+  `(let [~(macros.common/ignore-unused 'card-1) 1
+         ~(macros.common/ignore-unused 'card-2) 2
+         ~(macros.common/ignore-unused 'card-3) 3
+         ~(macros.common/ignore-unused 'card-4) 4
+         ~(macros.common/ignore-unused 'card-5) 5
+         ~(macros.common/ignore-unused 'coll-2) 100
+         ~(macros.common/ignore-unused 'coll-3) 200]
+     ~@body))

.clj-kondo/src/hooks/clojure/core.clj

@@ -1,329 +0,0 @@
-(ns hooks.clojure.core
-  (:require
-   [clj-kondo.hooks-api :as hooks]
-   [clojure.set :as set]
-   [clojure.string :as str]))
-
-(defn- node->qualified-symbol [node]
-  (try
-   (when (hooks/token-node? node)
-     (let [sexpr (hooks/sexpr node)]
-       (when (symbol? sexpr)
-         (let [resolved (hooks/resolve {:name sexpr})]
-           (when-not (= :clj-kondo/unknown-namespace (:ns resolved))
-             (symbol (name (:ns resolved)) (name (:name resolved))))))))
-   ;; some symbols like `*count/Integer` aren't resolvable.
-   (catch Exception _
-     nil)))
-
-(def ^:private symbols-allowed-in-fns-not-ending-in-an-exclamation-point
-  '#{;; these toucan methods might actually set global values if it's used outside of a transaction,
-     ;; but since mt/with-temp runs in a transaction, so we'll ignore them in this case.
-     toucan2.core/delete!
-     toucan2.core/update!
-     toucan2.core/insert!
-     toucan2.core/insert-returning-instance!
-     toucan2.core/insert-returning-instances!
-     toucan2.core/insert-returning-pk!
-     toucan2.core/insert-returning-pks!
-     clojure.core.async/<!!
-     clojure.core.async/>!!
-     clojure.core.async/alts!!
-     clojure.core.async/close!
-     clojure.core.async/poll!
-     clojure.core.memoize/memo-clear!
-     clojure.core/conj!
-     clojure.core/persistent!
-     clojure.core/reset!
-     clojure.core/swap!
-     clojure.core/volatile!
-     clojure.core/vreset!
-     clojure.core/vswap!
-     clojure.java.jdbc/execute!
-     methodical.core/add-aux-method-with-unique-key!
-     methodical.core/remove-aux-method-with-unique-key!
-     next.jdbc/execute!
-
-     ;; Definitely thread safe
-     metabase.test.util.dynamic-redefs/patch-vars!
-
-     ;; TODO: most of these symbols shouldn't be here, we should go through them and
-     ;; find the functions/macros that use them and make sure their names end with !
-     ;; best way to do this is try remove each of these and rely on kondo output to find places where it's used
-     clojure.test/grant-collection-perms!
-     clojure.test/grant-collection-perms-fn!
-     clojure.test/grant-perms-fn!
-     clojure.test/purge-old-entries!
-     clojure.test/revoke-collection-perms!
-     clojure.test/save-results!
-     metabase-enterprise.advanced-permissions.models.permissions/update-db-download-permissions!
-     metabase-enterprise.internal-user/install-internal-user!
-     metabase-enterprise.sso.integrations.saml-test/call-with-login-attributes-cleared!
-     metabase.actions/perform-action!
-     metabase.analytics.snowplow-test/fake-track-event-impl!
-     metabase.analytics.snowplow/track-event-impl!
-     metabase.api.public-test/add-card-to-dashboard!
-     metabase.cmd.dump-to-h2/dump-to-h2!
-     metabase.cmd.load-from-h2/load-from-h2!
-     metabase.core/ensure-audit-db-installed!
-     metabase.db.schema-migrations-test.impl/run-migrations-in-range!
-     metabase.db.setup/migrate!
-     metabase.db.setup/setup-db!
-     metabase.db/migrate!
-     metabase.db/setup-db!
-     metabase.driver.mongo-test/create-database-from-row-maps!
-     metabase.driver.postgres-test/create-enums-db!
-     metabase.driver.postgres-test/drop-if-exists-and-create-db!
-     metabase.driver.sql-jdbc.execute/execute-statement!
-     metabase.email-test/reset-inbox!
-     metabase.email/send-email!
-     metabase.models.action/insert!
-     metabase.models.collection.graph-test/clear-graph-revisions!
-     metabase.models.collection.graph-test/do-with-n-temp-users-with-personal-collections!
-     metabase.models.field-values/create-or-update-full-field-values!
-     metabase.models.model-index/add-values!
-     metabase.models.moderation-review/create-review!
-     metabase.models.on-demand-test/add-dashcard-with-parameter-mapping!
-     metabase.models.permissions/grant-application-permissions!
-     metabase.models.permissions/grant-collection-read-permissions!
-     metabase.models.permissions/grant-collection-readwrite-permissions!
-     metabase.models.permissions/grant-full-data-permissions!
-     metabase.models.permissions/grant-native-readwrite-permissions!
-     metabase.models.permissions/grant-permissions!
-     metabase.models.permissions/revoke-application-permissions!
-     metabase.models.permissions/revoke-data-perms!
-     metabase.models.permissions/update-data-perms-graph!
-     metabase.models.permissions/update-group-permissions!
-     metabase.models.persisted-info/ready-database!
-     metabase.models.revision/revert!
-     metabase.models.setting-test/test-user-local-allowed-setting!
-     metabase.models.setting-test/test-user-local-only-setting!
-     metabase.models.setting.cache/restore-cache!
-     metabase.models.setting/set!
-     metabase.models.setting/validate-settings-formatting!
-     metabase.permissions.test-util/with-restored-perms!
-     metabase.pulse/send-notifications!
-     metabase.pulse/send-pulse!
-     metabase.query-processor.streaming.interface/begin!
-     metabase.query-processor.streaming.interface/finish!
-     metabase.query-processor.streaming.interface/write-row!
-     metabase.sample-data/try-to-extract-sample-database!
-     metabase.setup/create-token!
-     metabase.sync.sync-metadata.fields.sync-metadata/update-field-metadata-if-needed!
-     metabase.sync.sync-metadata/sync-db-metadata!
-     metabase.sync.util-test/sync-database!
-     metabase.sync.util/store-sync-summary!
-     metabase.sync/sync-database!
-     metabase.task.index-values/job-init!
-     metabase.task.persist-refresh/job-init!
-     metabase.task.persist-refresh/refresh-tables!
-     metabase.task.persist-refresh/schedule-persistence-for-database!
-     metabase.task/delete-task!
-     metabase.test.data.bigquery-cloud-sdk/execute!
-     metabase.test.data.impl/copy-db-tables-and-fields!
-     metabase.test.data.impl/get-or-create-database!
-     metabase.test.data.impl/get-or-create-default-dataset!
-     metabase.test.data.impl.get-or-create/set-test-db-permissions!
-     metabase.test.data.interface/create-db!
-     metabase.test.data.interface/destroy-db!
-     metabase.test.data.oracle/create-user!
-     metabase.test.data.oracle/drop-user!
-     metabase.test.data.sql-jdbc.load-data/make-insert!
-     metabase.test.data.users/clear-cached-session-tokens!
-     metabase.test.initialize/do-initialization!
-     metabase.test.initialize/initialize-if-needed!
-     metabase.test.integrations.ldap/start-ldap-server!
-     metabase.test.util.log/ensure-unique-logger!
-     metabase.test.util.log/set-ns-log-level!
-     metabase.test.util/do-with-temp-env-var-value!
-     metabase.test.util/restore-raw-setting!
-     metabase.test.util/upsert-raw-setting!
-     metabase.test/initialize-if-needed!
-     metabase.test/test-helpers-set-global-values!
-     metabase.test/with-temp-env-var-value!
-     metabase.upload-test/set-local-infile!
-     metabase.util.files/create-dir-if-not-exists!
-     metabase.util.ssh-test/start-mock-servers!
-     metabase.util.ssh-test/stop-mock-servers!})
-
-(defn- end-with-exclamation?
-  [s]
-  (str/ends-with? s "!"))
-
-(defn- non-thread-safe-form-should-end-with-exclamation*
-  [{[defn-or-defmacro form-name] :children, :as node}]
-  (when-not (and (:string-value form-name)
-                 (end-with-exclamation? (:string-value form-name)))
-    (letfn [(walk [f form]
-              (f form)
-              (doseq [child (:children form)]
-                (walk f child)))]
-      (walk (fn [form]
-              (when-let [qualified-symbol (node->qualified-symbol form)]
-                (when (and (not (contains? symbols-allowed-in-fns-not-ending-in-an-exclamation-point qualified-symbol))
-                           (end-with-exclamation? qualified-symbol))
-                  (hooks/reg-finding! (assoc (meta form-name)
-                                             :message (format "The name of this %s should end with `!` because it contains calls to non thread safe form `%s`."
-                                                              (:string-value defn-or-defmacro) qualified-symbol)
-                                             :type :metabase/test-helpers-use-non-thread-safe-functions)))))
-            node))
-    node))
-
-(defn non-thread-safe-form-should-end-with-exclamation
-  "Used to ensure defn and defmacro in test namespace to have name ending with `!` if it's non-thread-safe.
-  A function or a macro can be defined as 'not thread safe' when their funciton name ends with a `!`.
-
-  Only used in tests to identify thread-safe/non-thread-safe test helpers. See #37126"
-  [{:keys [node cljc lang]}]
-  (when (or (not cljc)
-            (= lang :clj))
-    (non-thread-safe-form-should-end-with-exclamation* node))
-  {:node node})
-
-(comment
- (require '[clj-kondo.core :as clj-kondo])
- (def form (str '(defmacro a
-                   [x]
-                   `(fun-call x))))
-
- (def form "(defmacro a
-           [x]
-           `(some! ~x))")
-
- (def form "(defun f
-           [x]
-           (let [g! (fn [] 1)]
-           (g!)))")
-
- (str (hooks/parse-string form))
- (hooks/sexpr (hooks/parse-string form))
-
- (binding [hooks/*reload* true]
-   (-> form
-       (with-in-str (clj-kondo/run! {:lint ["-"]}))
-       :findings))
-
- (do (non-thread-safe-form-should-end-with-exclamation* (hooks/parse-string form)) nil))
-
-(defn- ns-form-node->require-node [ns-form-node]
-  (some (fn [node]
-          (when (and (hooks/list-node? node)
-                     (let [first-child (first (:children node))]
-                       (and (hooks/keyword-node? first-child)
-                            (= (hooks/sexpr first-child) :require))))
-            node))
-        (:children ns-form-node)))
-
-(defn- lint-require-shapes [ns-form-node]
-  (doseq [node (-> ns-form-node
-                   ns-form-node->require-node
-                   :children
-                   rest)]
-    (cond
-      (not (hooks/vector-node? node))
-      (hooks/reg-finding! (assoc (meta node)
-                                 :message "All :required namespaces should be wrapped in vectors [:metabase/require-shape-checker]"
-                                 :type    :metabase/require-shape-checker))
-
-      (hooks/vector-node? (second (:children node)))
-      (hooks/reg-finding! (assoc (meta node)
-                                 :message "Don't use prefix forms inside :require [:metabase/require-shape-checker]"
-                                 :type    :metabase/require-shape-checker)))))
-
-(defn- require-node->namespace-symb-nodes [require-node]
-  (let [[_ns & args] (:children require-node)]
-    (into []
-          ;; prefixed namespace forms are NOT SUPPORTED!!!!!!!!1
-          (keep (fn [node]
-                  (cond
-                    (hooks/vector-node? node)
-                    ;; propagate the metadata attached to this vector in case there's a `:clj-kondo/ignore` form.
-                    (vary-meta (first (:children node)) (partial merge (meta require-node) (meta node)))
-
-                    ;; this should also be dead code since we require requires to be vectors
-                    (hooks/token-node? node)
-                    (vary-meta node (partial merge (meta require-node)))
-
-                    :else
-                    (printf "Don't know how to figure out what namespace is being required in %s\n" (pr-str node)))))
-          args)))
-
-(defn- ns-form-node->ns-symb [ns-form-node]
-  (some-> (some (fn [node]
-                  (when (and (hooks/token-node? node)
-                             (not= (hooks/sexpr node) 'ns))
-                    node))
-                (:children ns-form-node))
-          hooks/sexpr))
-
-(defn- module
-  "E.g.
-
-    (module 'metabase.qp.middleware.wow) => 'metabase.qp"
-  [ns-symb]
-  (some-> (re-find #"^metabase\.[^.]+" (str ns-symb)) symbol))
-
-(defn- ignored-namespace? [ns-symb config]
-  (some
-   (fn [pattern-str]
-     (re-find (re-pattern pattern-str) (str ns-symb)))
-   (:ignored-namespace-patterns config)))
-
-(defn- module-api-namespaces
-  "Set API namespaces for a given module. `:any` means you can use anything, there are no API namespaces for this
-  module (yet). If unspecified, the default is just the namespace with the same name as the module e.g.
-  `metabase.db`."
-  [module config]
-  (let [module-config (get-in config [:api-namespaces module])]
-    (cond
-      (= module-config :any)
-      nil
-
-      (set? module-config)
-      module-config
-
-      :else
-      #{module})))
-
-(defn- lint-modules [ns-form-node config]
-  (let [ns-symb (ns-form-node->ns-symb ns-form-node)]
-    (when-not (ignored-namespace? ns-symb config)
-      (when-let [current-module (module ns-symb)]
-        (let [allowed-modules               (get-in config [:allowed-modules current-module])
-              required-namespace-symb-nodes (-> ns-form-node
-                                                ns-form-node->require-node
-                                                require-node->namespace-symb-nodes)]
-          (doseq [node  required-namespace-symb-nodes
-                  :let  [clj-kondo-ignore (some-> (meta node) :clj-kondo/ignore hooks/sexpr set)]
-                  :when (not (contains? clj-kondo-ignore :metabase/ns-module-checker))
-                  :let  [required-namespace (hooks/sexpr node)
-                         required-module    (module required-namespace)]
-                  ;; ignore stuff not in a module i.e. non-Metabase stuff.
-                  :when required-module
-                  :let  [in-current-module? (= required-module current-module)]
-                  :when (not in-current-module?)
-                  :let  [allowed-module?           (or (= allowed-modules :any)
-                                                       (contains? (set allowed-modules) required-module))
-                         module-api-namespaces     (module-api-namespaces required-module config)
-                         allowed-module-namespace? (or (empty? module-api-namespaces)
-                                                       (contains? module-api-namespaces required-namespace))]]
-            (when-let [error (cond
-                               (not allowed-module?)
-                               (format "Module %s should not be used in the %s module. [:metabase/ns-module-checker :allowed-modules %s]"
-                                       required-module
-                                       current-module
-                                       current-module)
-
-                               (not allowed-module-namespace?)
-                               (format "Namespace %s is not an allowed external API namespace for the %s module. [:metabase/ns-module-checker :api-namespaces %s]"
-                                       required-namespace
-                                       required-module
-                                       required-module))]
-              (hooks/reg-finding! (assoc (meta node)
-                                         :message error
-                                         :type    :metabase/ns-module-checker)))))))))
-
-(defn lint-ns [x]
-  (lint-require-shapes (:node x))
-  (lint-modules (:node x) (get-in x [:config :linters :metabase/ns-module-checker]))
-  x)

.clj-kondo/src/hooks/clojure/core/defmulti.clj

@@ -0,0 +1,52 @@
+(ns hooks.clojure.core.defmulti
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clojure.string :as str]
+   [hooks.common]))
+
+(defn- check-arglists [report-node arglists]
+  (letfn [(reg-bad-arglists! []
+            (hooks/reg-finding!
+             (assoc (meta report-node)
+                    :message ":arglists should be a quoted list of vectors [:metabase/check-defmulti-arglists]"
+                    :type :metabase/check-defmulti-arglists)))
+          (reg-bad-arg! []
+            (hooks/reg-finding!
+             (assoc (meta report-node)
+                    :message ":arglists should contain actual arg names, not underscore (unused) symbols [:metabase/check-defmulti-arglists]"
+                    :type    :metabase/check-defmulti-arglists)))
+          (underscore-arg? [arg]
+            (and (symbol? arg)
+                 (str/starts-with? arg "_")))
+          (check-arglist [arglist]
+            (cond
+              (not (vector? arglist))        (reg-bad-arglists!)
+              (some underscore-arg? arglist) (reg-bad-arg!)))]
+    (if-not (and (seq? arglists)
+                 (= (first arglists) 'quote)
+                 (seq (second arglists)))
+      (reg-bad-arglists!)
+      (let [[_quote arglists] arglists]
+        (doseq [arglist arglists]
+          (check-arglist arglist))))))
+
+(defn- defmulti-check-for-arglists-metadata
+  "Make sure a [[defmulti]] has an attribute map with `:arglists` metadata."
+  [node]
+  (let [[_defmulti _symb & args] (:children node)
+        [_docstring & args]      (if (hooks/string-node? (first args))
+                                   args
+                                   (cons nil args))
+        attr-map                 (when (hooks/map-node? (first args))
+                                   (first args))
+        arglists                 (some-> attr-map hooks/sexpr :arglists seq)]
+    (if-not (seq? arglists) ; should be a list or at least list-like
+      (hooks/reg-finding!
+       (assoc (meta node)
+              :message "All defmultis should have an attribute map with :arglists metadata. [:metabase/check-defmulti-arglists]"
+              :type    :metabase/check-defmulti-arglists))
+      (check-arglists attr-map arglists))))
+
+(defn lint-defmulti [x]
+  (defmulti-check-for-arglists-metadata (:node x))
+  x)

.clj-kondo/src/hooks/clojure/core/defn.clj

@@ -0,0 +1,76 @@
+(ns hooks.clojure.core.defn
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clojure.string :as str]
+   [hooks.common]))
+
+(defn- end-with-exclamation?
+  [s]
+  (str/ends-with? s "!"))
+
+(defn- explicitly-safe? [config qualified-symbol]
+  (contains? (get-in config [:linters :metabase/test-helpers-use-non-thread-safe-functions :explicitly-safe])
+             qualified-symbol))
+
+(defn- explicitly-unsafe? [config qualified-symbol]
+  (contains? (get-in config [:linters :metabase/validate-deftest :parallel/unsafe]) qualified-symbol))
+
+(defn- unsafe? [config qualified-symbol]
+  (and (or (end-with-exclamation? qualified-symbol)
+           (explicitly-unsafe? config qualified-symbol))
+       (not (explicitly-safe? config qualified-symbol))))
+
+(defn- non-thread-safe-form-should-end-with-exclamation*
+  [{[defn-or-defmacro form-name] :children, :as node} config]
+  (when-not (and (:string-value form-name)
+                 (end-with-exclamation? (:string-value form-name)))
+    (letfn [(walk [f form]
+              (f form)
+              (doseq [child (:children form)]
+                (walk f child)))
+            (check-node [form]
+              (when-let [qualified-symbol (hooks.common/node->qualified-symbol form)]
+                (when (unsafe? config qualified-symbol)
+                  (hooks/reg-finding!
+                   (assoc (meta form-name)
+                          :message (format "The name of this %s should end with `!` because it contains calls to non thread safe form `%s`. [:metabase/test-helpers-use-non-thread-safe-functions]"
+                                           (:string-value defn-or-defmacro) qualified-symbol)
+                          :type :metabase/test-helpers-use-non-thread-safe-functions)))))]
+      (walk check-node node))
+    node))
+
+(defn non-thread-safe-form-should-end-with-exclamation
+  "Used to ensure defn and defmacro in test namespace to have name ending with `!` if it's non-thread-safe.
+  A function or a macro can be defined as 'not thread safe' when their funciton name ends with a `!`.
+
+  Only used in tests to identify thread-safe/non-thread-safe test helpers. See #37126"
+  [{:keys [node cljc lang config]}]
+  (when (or (not cljc)
+            (= lang :clj))
+    (non-thread-safe-form-should-end-with-exclamation* node config))
+  {:node node})
+
+(comment
+  (require '[clj-kondo.core :as clj-kondo])
+  (def form (str '(defmacro a
+                    [x]
+                    `(fun-call x))))
+
+  (def form "(defmacro a
+           [x]
+           `(some! ~x))")
+
+  (def form "(defun f
+           [x]
+           (let [g! (fn [] 1)]
+           (g!)))")
+
+  (str (hooks/parse-string form))
+  (hooks/sexpr (hooks/parse-string form))
+
+  (binding [hooks/*reload* true]
+    (-> form
+        (with-in-str (clj-kondo/run! {:lint ["-"]}))
+        :findings))
+
+  (do (non-thread-safe-form-should-end-with-exclamation* (hooks/parse-string form)) nil))

.clj-kondo/src/hooks/clojure/core/ns.clj

@@ -0,0 +1,91 @@
+(ns hooks.clojure.core.ns
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common]
+   [hooks.common.modules :as modules]))
+
+(defn- ns-form-node->require-node [ns-form-node]
+  (some (fn [node]
+          (when (and (hooks/list-node? node)
+                     (let [first-child (first (:children node))]
+                       (and (hooks/keyword-node? first-child)
+                            (= (hooks/sexpr first-child) :require))))
+            node))
+        (:children ns-form-node)))
+
+(defn- lint-require-shapes [ns-form-node]
+  (doseq [node (-> ns-form-node
+                   ns-form-node->require-node
+                   :children
+                   rest)]
+    (cond
+      (not (hooks/vector-node? node))
+      (hooks/reg-finding! (assoc (meta node)
+                                 :message "All :required namespaces should be wrapped in vectors [:metabase/require-shape-checker]"
+                                 :type    :metabase/require-shape-checker))
+
+      (hooks/vector-node? (second (:children node)))
+      (hooks/reg-finding! (assoc (meta node)
+                                 :message "Don't use prefix forms inside :require [:metabase/require-shape-checker]"
+                                 :type    :metabase/require-shape-checker)))))
+
+(defn- lint-requires-on-new-lines [ns-form-node]
+  (let [[require-keyword first-require] (-> ns-form-node
+                                            ns-form-node->require-node
+                                            :children)]
+    (when-let [require-keyword-line (:row (meta require-keyword))]
+      (when-let [first-require-line (:row (meta first-require))]
+        (when (= require-keyword-line first-require-line)
+          (hooks/reg-finding! (assoc (meta first-require)
+                                     :message "Put your requires on a newline from the :require keyword [:metabase/require-shape-checker]"
+                                     :type    :metabase/require-shape-checker)))))))
+
+(defn- require-node->namespace-symb-nodes [require-node]
+  (let [[_ns & args] (:children require-node)]
+    (into []
+          ;; prefixed namespace forms are NOT SUPPORTED!!!!!!!!1
+          (keep (fn [node]
+                  (cond
+                    (hooks/vector-node? node)
+                    ;; propagate the metadata attached to this vector in case there's a `:clj-kondo/ignore` form.
+                    (let [symbol-node (first (:children node))]
+                      (hooks.common/merge-ignored-linters symbol-node require-node node))
+
+                    ;; this should also be dead code since we require requires to be vectors
+                    (hooks/token-node? node)
+                    (hooks.common/merge-ignored-linters node require-node)
+
+                    :else
+                    (printf "Don't know how to figure out what namespace is being required in %s\n" (pr-str node)))))
+          args)))
+
+(defn- ns-form-node->ns-symb [ns-form-node]
+  (some-> (some (fn [node]
+                  (when (and (hooks/token-node? node)
+                             (not= (hooks/sexpr node) 'ns))
+                    node))
+                (:children ns-form-node))
+          hooks/sexpr))
+
+(defn- lint-modules [ns-form-node config]
+  (let [ns-symb (ns-form-node->ns-symb ns-form-node)]
+    (when-not (modules/ignored-namespace? config ns-symb)
+      (when-let [current-module (modules/module ns-symb)]
+        (let [required-namespace-symb-nodes (-> ns-form-node
+                                                ns-form-node->require-node
+                                                require-node->namespace-symb-nodes)]
+          (doseq [node  required-namespace-symb-nodes
+                  :when (not (contains? (hooks.common/ignored-linters node) :metabase/modules))
+                  :let  [required-namespace (hooks/sexpr node)
+                         error              (modules/usage-error config current-module required-namespace)]
+                  :when error]
+            (hooks/reg-finding! (assoc (meta node)
+                                       :message error
+                                       :type    :metabase/modules))))))))
+
+(defn lint-ns [x]
+  (doto (:node x)
+    lint-require-shapes
+    lint-requires-on-new-lines
+    (lint-modules (modules/config x)))
+  x)

.clj-kondo/src/hooks/clojure/core/require.clj

@@ -0,0 +1,69 @@
+(ns hooks.clojure.core.require
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common.modules :as modules]))
+
+(defn- lint* [node current-ns config required-namespaces]
+  {:pre [(map? node)
+         (simple-symbol? current-ns)
+         (map? config)
+         (sequential? required-namespaces)
+         (every? simple-symbol? required-namespaces)]}
+  (when-not (modules/ignored-namespace? config current-ns)
+    ;; ignore namespaces outside of the module system
+    (when-let [current-module (modules/module current-ns)]
+      (doseq [required-namespace required-namespaces]
+        ;; ignore namespaces outside of the module system.
+        (when (modules/module required-namespace)
+          (when-let [error (modules/usage-error config current-module required-namespace)]
+            (hooks/reg-finding! (assoc (meta node)
+                                       :message error
+                                       :type    :metabase/modules))))))))
+
+(defn- unwrap-require [node]
+  (case (hooks/tag node)
+    ;; some.namespace of some.namespace/some-var
+    :token
+    (let [sexpr (hooks/sexpr node)]
+      (if (qualified-symbol? sexpr)
+        (symbol (namespace sexpr))
+        sexpr))
+
+    ;; (quote some.namespace)
+    :list
+    (let [[x y] (:children node)]
+      (when (and (hooks/token-node? x)
+                 (= (hooks/sexpr x) 'quote))
+        (recur y)))
+
+    ;; 'some.namespace
+    :quote
+    (recur (first (:children node)))
+
+    ;; something like [some.namespace :as whatever]
+    :vector
+    (recur (first (:children node)))))
+
+(comment
+  (unwrap-require (-> "(requiring-resolve 'metabase.notification.payload.execute/execute-dashboard)"
+                      hooks/parse-string
+                      :children
+                      second)))
+
+(defn- lint-require* [node current-ns config]
+  (let [[_require & args]   (:children node)
+        required-namespaces (keep unwrap-require args)]
+    (lint* node current-ns config required-namespaces)))
+
+(defn- lint-requiring-resolve* [node current-ns config]
+  (let [[_requiring-resolve symb-node] (:children node)
+        required-namespace             (unwrap-require symb-node)]
+    (lint* node current-ns config [required-namespace])))
+
+(defn lint-require [x]
+  (lint-require* (:node x) (:ns x) (modules/config x))
+  x)
+
+(defn lint-requiring-resolve [x]
+  (lint-requiring-resolve* (:node x) (:ns x) (modules/config x))
+  x)

.clj-kondo/src/hooks/clojure/test.clj

@@ -4,114 +4,7 @@
    [clojure.string :as str]
    [hooks.common]))
 
-(def ^:private disallowed-parallel-forms
-  "Things you should not be allowed to use inside parallel tests. Besides these, anything ending in `!` not whitelisted
-  in [[allowed-parallel-forms]] is not allowed."
-  '#{clojure.core/alter-var-root
-     clojure.core/with-redefs
-     clojure.core/with-redefs-fn
-     metabase-enterprise.sandbox.test-util/with-gtaps!
-     metabase-enterprise.sandbox.test-util/with-gtaps-for-user!
-     metabase-enterprise.sandbox.test-util/with-user-attributes
-     metabase-enterprise.test/with-gtaps!
-     metabase-enterprise.test/with-gtaps-for-user!
-     metabase-enterprise.test/with-user-attributes
-     metabase.actions.test-util/with-actions
-     metabase.actions.test-util/with-actions-disabled
-     metabase.actions.test-util/with-actions-enabled
-     metabase.actions.test-util/with-actions-test-data
-     metabase.actions.test-util/with-actions-test-data-and-actions-enabled
-     metabase.actions.test-util/with-actions-test-data-tables
-     metabase.analytics.snowplow-test/with-fake-snowplow-collector
-     metabase.email-test/with-expected-messages
-     metabase.email-test/with-fake-inbox
-     metabase.test.data.users/with-group
-     metabase.test.data.users/with-group-for-user
-     metabase.test.persistence/with-persistence-enabled
-     metabase.test.util.log/with-log-level
-     metabase.test.util.log/with-log-messages-for-level
-     metabase.test.util.misc/with-single-admin-user
-     metabase.test.util/with-all-users-permission
-     metabase.test.util/with-discarded-collections-perms-changes
-     metabase.test.util/with-env-keys-renamed-by
-     metabase.test.util/with-locale
-     metabase.test.util/with-non-admin-groups-no-root-collection-for-namespace-perms
-     metabase.test.util/with-non-admin-groups-no-root-collection-perms
-     metabase.test.util/with-temp-env-var-value
-     metabase.test.util/with-temp-vals-in-db
-     metabase.test.util/with-temporary-raw-setting-values
-     metabase.test.util/with-temporary-setting-values
-     metabase.test.util/with-user-in-groups
-     metabase.test/with-actions
-     metabase.test/with-actions-disabled
-     metabase.test/with-actions-enabled
-     metabase.test/with-actions-test-data
-     metabase.test/with-actions-test-data-and-actions-enabled
-     metabase.test/with-actions-test-data-tables
-     metabase.test/with-all-users-permission
-     metabase.test/with-discarded-collections-perms-changes
-     metabase.test/with-env-keys-renamed-by
-     metabase.test/with-expected-messages
-     metabase.test/with-fake-inbox
-     metabase.test/with-group
-     metabase.test/with-group-for-user
-     metabase.test/with-locale
-     metabase.test/with-log-level
-     metabase.test/with-log-messages-for-level
-     metabase.test/with-non-admin-groups-no-root-collection-for-namespace-perms
-     metabase.test/with-non-admin-groups-no-root-collection-perms
-     metabase.test/with-persistence-enabled
-     metabase.test/with-single-admin-user
-     metabase.test/with-temp-env-var-value
-     metabase.test/with-temp-vals-in-db
-     metabase.test/with-temporary-raw-setting-values
-     metabase.test/with-temporary-setting-values
-     metabase.test/with-user-in-groups})
-
-;;; TODO -- we should disallow `metabase.test/user-http-request` with any method other than `:get`
-
-(def ^:private allowed-parallel-forms
-  "These fns are destructive, but are probably fine inside ^:parallel tests because it usually means you're doing
-  something to an atom or something like that."
-  '#{clojure.core/assoc!
-     clojure.core/compare-and-set!
-     clojure.core/conj!
-     clojure.core/disj!
-     clojure.core/dissoc!
-     clojure.core/persistent!
-     clojure.core/pop!
-     clojure.core/reset!
-     clojure.core/reset-vals!
-     clojure.core/run!
-     clojure.core/swap!
-     clojure.core/swap-vals!
-     clojure.core/volatile!
-     clojure.core/vreset!
-     clojure.core/vswap!
-     clojure.core.async/<!
-     clojure.core.async/<!!
-     clojure.core.async/>!
-     clojure.core.async/>!!
-     clojure.core.async/alt!
-     clojure.core.async/alt!!
-     clojure.core.async/alts!
-     clojure.core.async/alts!!
-     clojure.core.async/close!
-     clojure.core.async/ioc-alts!
-     clojure.core.async/offer!
-     clojure.core.async/onto-chan!
-     clojure.core.async/onto-chan!!
-     clojure.core.async/poll!
-     clojure.core.async/put!
-     clojure.core.async/take!
-     clojure.core.async/to-chan!
-     clojure.core.async/to-chan!!
-     metabase.driver.sql-jdbc.execute/execute-prepared-statement!
-     metabase.pulse/send-pulse!
-     metabase.query-processor.store/store-database!
-     next.jdbc/execute!})
-
-(defn- warn-about-disallowed-parallel-forms [form]
+(defn- warn-about-disallowed-parallel-forms [form config]
   (letfn [(error! [form message]
             (hooks/reg-finding! (assoc (meta form)
                                        :message message
@@ -119,12 +12,12 @@
           (f [form]
             (when-let [qualified-symbol (hooks.common/node->qualified-symbol form)]
               (cond
-                (disallowed-parallel-forms qualified-symbol)
-                (error! form (format "%s is not allowed inside a ^:parallel test or test fixture" qualified-symbol))
+                (contains? (:parallel/unsafe config) qualified-symbol)
+                (error! form (format "%s is not allowed inside a ^:parallel test or test fixture [:metabase/validate-deftest]" qualified-symbol))
 
-                (and (not (allowed-parallel-forms qualified-symbol))
+                (and (not (contains? (:parallel/safe config) qualified-symbol))
                      (str/ends-with? (name qualified-symbol) "!"))
-                (error! form (format "destructive functions like %s are not allowed inside a ^:parallel test or test fixture. If this should be allowed, add it to the whitelist in .clj-kondo/hooks/clojure/test.clj"
+                (error! form (format "destructive functions like %s are not allowed inside a ^:parallel test or test fixture. If this should be allowed, add it to the whitelist in the Kondo config file [:metabase/validate-deftest]"
                                      qualified-symbol)))))
           (walk [form]
             (f form)
@@ -135,7 +28,7 @@
 (defn- deftest-check-parallel
   "1. Check if test is marked ^:parallel / ^:synchronized correctly
    2. Make sure disallowed forms are not used in ^:parallel tests"
-  [{[_ test-name & body] :children, :as _node}]
+  [{[_ test-name & body] :children, :as _node} config]
   (let [test-metadata     (:meta test-name)
         metadata-sexprs   (map hooks/sexpr test-metadata)
         combined-metadata (transduce
@@ -152,9 +45,9 @@
       (hooks/reg-finding! (assoc (meta test-name)
                                  :message "Test should not be marked both ^:parallel and ^:synchronized"
                                  :type :metabase/validate-deftest)))
-    ;; only when the custom `:metabase/deftest-not-marked-parallel` is enabled: complain if tests are not explicitly
-    ;; marked `^:parallel` or `^:synchronized`. This is mostly to encourage people to mark everything `^:parallel` in
-    ;; places like `metabase.lib` tests unless there is a really good reason not to.
+    ;; only when the custom `:metabase/deftest-not-marked-parallel-or-synchronized` is enabled: complain if tests are
+    ;; not explicitly marked `^:parallel` or `^:synchronized`. This is mostly to encourage people to mark everything
+    ;; `^:parallel` in places like `metabase.lib` tests unless there is a really good reason not to.
     (when-not (or parallel? synchronized?)
       (hooks/reg-finding!
        (assoc (meta test-name)
@@ -162,30 +55,61 @@
               :type :metabase/deftest-not-marked-parallel-or-synchronized)))
     (when parallel?
       (doseq [form body]
-        (warn-about-disallowed-parallel-forms form)))))
-
-(def ^:private number-of-lines-for-a-test-to-be-considered-horrifically-long
-  200)
+        (warn-about-disallowed-parallel-forms form config)))))
 
 (defn- deftest-check-not-horrifically-long
-  [node]
+  [node {:keys [max-length], :as _config}]
   (let [{:keys [row end-row]} (meta node)]
     (when (and row end-row)
       (let [num-lines (- end-row row)]
-        (when (>= num-lines number-of-lines-for-a-test-to-be-considered-horrifically-long)
+        (when (and max-length
+                   (>= num-lines max-length))
           (hooks/reg-finding! (assoc (meta node)
                                      :message (str (format "This test is horrifically long, it's %d lines! 😱 " num-lines)
                                                    "Do you really want to try to debug it if it fails? 💀 "
                                                    "Split it up into smaller tests! 🥰")
                                      :type :metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests)))))))
 
-(defn deftest [{:keys [node cljc lang]}]
+(defn- ignore? [node error-type]
+  (contains? (hooks.common/ignored-linters node) error-type))
+
+(defn deftest-check-no-driver-keywords [node {:keys [drivers], :as _config}]
+  ;; fail fast after we see the first error, where we see one hardcoded driver name there are likely several more and we
+  ;; don't need multiple warnings for a single test.
+  (letfn [(f [node]
+            (when (and (hooks/keyword-node? node)
+                       (set? drivers)
+                       (contains? drivers (hooks/sexpr node)))
+              (hooks/reg-finding! (assoc (meta node)
+                                         :message (format "Do not hardcode driver name %s in driver tests! [:metabase/disallow-hardcoded-driver-names-in-tests]"
+                                                          (hooks/sexpr node))
+                                         :type    :metabase/disallow-hardcoded-driver-names-in-tests))
+              ::error))
+          (walk [node]
+            (cond
+              (ignore? node :metabase/disallow-hardcoded-driver-names-in-tests)
+              nil
+
+              (= (f node) ::error)
+              ::error
+
+              :else
+              (reduce
+               (fn [_acc child]
+                 (when (= (walk child) ::error)
+                   (reduced ::error)))
+               nil
+               (:children node))))]
+    (walk node)))
+
+(defn deftest [{:keys [node cljc lang config]}]
   ;; run [[deftest-check-parallel]] only once... if this is a `.cljc` file only run it for the `:clj` analysis, no point
   ;; in running it twice.
   (when (or (not cljc)
             (= lang :clj))
-    (deftest-check-parallel node))
-  (deftest-check-not-horrifically-long node)
+    (deftest-check-parallel node (get-in config [:linters :metabase/validate-deftest])))
+  (deftest-check-not-horrifically-long node (get-in config [:linters :metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests]))
+  (deftest-check-no-driver-keywords node (get-in config [:linters :metabase/disallow-hardcoded-driver-names-in-tests]))
   {:node node})
 
 ;;; this is a hacky way to determine whether these namespaces are required in the `ns` form or not... basically `:ns`
@@ -222,20 +146,11 @@
 
               nil)))))))
 
-(defn- warn-about-schema= [{[_is assertion-node] :children, :as _is-node}]
-  (let [{[assertion-symb-node] :children} assertion-node]
-    (when (and (hooks/token-node? assertion-symb-node)
-               (= (hooks/sexpr assertion-symb-node) 'schema=))
-      (hooks/reg-finding! (assoc (meta assertion-symb-node)
-                                 :message "Use =? or malli= instead of schema="
-                                 :type :metabase/warn-about-schema=)))))
-
 (defn is [{:keys [node lang]}]
   (when (= lang :cljs)
     (warn-about-missing-test-expr-requires-in-cljs node))
-  (warn-about-schema= node)
   {:node node})
 
-(defn use-fixtures [{:keys [node]}]
-  (warn-about-disallowed-parallel-forms node)
+(defn use-fixtures [{:keys [node config]}]
+  (warn-about-disallowed-parallel-forms node config)
   {:node node})

.clj-kondo/src/hooks/common.clj

@@ -1,7 +1,8 @@
 (ns hooks.common
   (:require
    [clj-kondo.hooks-api :as hooks]
-   [clojure.pprint]))
+   [clojure.pprint]
+   [clojure.set :as set]))
 
 (defn with-macro-meta
   "When introducing internal nodes (let, defn, etc) it is important to provide a meta of an existing token
@@ -9,10 +10,83 @@
   [new-node hook-node]
   (with-meta new-node (meta (first (:children hook-node)))))
 
+;;; Kondo stores information about ignored linters as rewrite-clj forms matching how they are specified in the code, so
+;;; either
+;;;
+;;;    <vector-node [<token-node :discouraged-namespace>]>
+;;;
+;;; or
+;;;
+;;;    <token-node :discouraged-namespace>
+;;;
+;;; these are stored in
+;;;
+;;;     (-> node meta :clj-kondo/ignore :linters).
+;;;
+;;; These are not a convenient shape(s) to work with, so the next few functions abstract that shape out and work with a
+;;; set of keywords like
+;;;
+;;;    #{:discouraged-namespace}
+;;;
+;;; instead.
+
+(defn- unwrap-ignored-linters [linters]
+  (cond
+    (or (hooks/vector-node? linters)
+        (hooks/list-node? linters))
+    (into #{}
+          (map hooks/sexpr)
+          (:children linters))
+
+    (hooks/keyword-node? linters)
+    #{(hooks/sexpr linters)}
+
+    (and (set? linters)
+         (every? keyword? linters))
+    linters
+
+    (and (sequential? linters)
+         (every? keyword? linters))
+    (into #{} linters)
+
+    (keyword? linters)
+    #{linters}))
+
+(defn- wrap-ignored-linters [linters]
+  (hooks/vector-node (mapv hooks/keyword-node linters)))
+
+(defn ignored-linters
+  "Return a set of keywords all ignored linters associated with a node by looking at its metadata."
+  [node]
+  (or (some-> node meta :clj-kondo/ignore :linters unwrap-ignored-linters)
+      ;; deal with the old pre-2024.09 shape mentioned in https://github.com/clj-kondo/clj-kondo/issues/2414
+      (some-> node :meta first hooks/sexpr :clj-kondo/ignore unwrap-ignored-linters)))
+
+(defn update-ignored-linters
+  "Update the `:clj-kondo/ignore` linters in `node`'s metadata. `linters` should be a set of keywords."
+  [node f & args]
+  (letfn [(apply-f [linters]
+            (apply f linters args))
+          (update-linters [linters]
+            (-> (or (unwrap-ignored-linters linters)
+                    #{})
+                apply-f
+                wrap-ignored-linters))]
+    (vary-meta node update-in [:clj-kondo/ignore :linters] update-linters)))
+
+(defn merge-ignored-linters
+  "Merge the ignored linters from `source-nodes` into `node`. You can use this to propagate
+  ignored linters from parent nodes to child nodes."
+  [node & source-nodes]
+  (if-let [linters (not-empty (transduce (map ignored-linters) set/union #{} source-nodes))]
+    (update-ignored-linters node set/union linters)
+    node))
+
 ;;; This stuff is to help debug hooks. Trace a function and it will pretty-print the before & after sexprs.
 ;;;
 ;;;    (hooks.common/trace #'calculate-bird-scarcity)
 
+#_{:clj-kondo/ignore [:discouraged-var]}
 (defn- trace* [f]
   {:pre [(fn? f)]}
   (fn traced-fn [node]
@@ -42,13 +116,14 @@
 ;;;; Common hook definitions
 
 (defn do*
-  "This is the same idea as [[clojure.core/do]] but doesn't cause Kondo to complain about redundant dos or unused values."
+  "This is the same idea as [[clojure.core/do]] but doesn't cause Kondo to complain about redundant dos or unused
+  values."
   [{{[_ & args] :children, :as node} :node}]
   (let [node* (-> (hooks/list-node
                    (list*
-                    (with-meta (hooks/token-node 'do) {:clj-kondo/ignore [:redundant-do]})
+                    (update-ignored-linters (hooks/token-node 'do) conj :redundant-do)
                     (for [arg args]
-                      (vary-meta arg update :clj-kondo/ignore #(conj (vec %) :unused-value)))))
+                      (update-ignored-linters arg conj :unused-value))))
                   (with-meta (meta node)))]
     {:node node*}))
 
@@ -288,8 +363,8 @@
     (-> (hooks/vector-node
          [(hooks/vector-node (map :model binding-infos))
           (-> (hooks/list-node (list* (hooks/token-node `let)
-                                    (hooks/vector-node (mapcat (juxt :binding :value) binding-infos))
-                                    body))
+                                      (hooks/vector-node (mapcat (juxt :binding :value) binding-infos))
+                                      body))
               (with-meta (meta body)))])
         (with-meta (meta body)))))
 
@@ -364,14 +439,58 @@
   where the first arg should be linted and appear to be used."
   [{{[_ arg & body] :children} :node}]
   (let [node* (hooks/list-node
-                (list*
-                  (hooks/token-node 'let)
-                  (hooks/vector-node [(hooks/token-node (gensym "_"))
-                                      arg])
-                  body))]
+               (list*
+                (hooks/token-node 'let)
+                (hooks/vector-node [(hooks/token-node (gensym "_"))
+                                    arg])
+                body))]
     {:node node*}))
 
-(defn node->qualified-symbol [node]
+(defn with-used-first-two-args
+  "For macros like
+
+    (with-limit-and-offset limit offset
+      ...)
+
+    =>
+
+    (let [_123 limit
+         [_456 offset]
+      ...)
+
+  where the first arg should be linted and appear to be used."
+  [{{[_ x y & body] :children} :node}]
+  (let [node* (hooks/list-node
+               (list*
+                (hooks/token-node 'let)
+                (hooks/vector-node [(hooks/token-node (gensym "_")) x
+                                    (hooks/token-node (gensym "_")) y])
+                body))]
+    {:node node*}))
+
+(defn with-vec-first-binding
+  "For macros like
+
+    (with-temp-file [binding \"temp.txt\" \"content\"]
+      (slurp binding))
+
+    =>
+    (let [binding nil]
+      (slurp binding))
+
+    where the first arg is a vector of bindings."
+  [{{[_ {[x & _args] :children} & body] :children} :node}]
+  (let [node* (hooks/list-node
+               (list*
+                (hooks/token-node 'let)
+                (hooks/vector-node
+                 [(or x (hooks/token-node '_)) (hooks/token-node 'nil)])
+                body))]
+    {:node node*}))
+
+(defn node->qualified-symbol
+  "If the node is a symbol, return it as a qualified symbol if it's not already. Otherwise return nil."
+  [node]
   (try
     (when (hooks/token-node? node)
       (let [sexpr (hooks/sexpr node)]
@@ -381,8 +500,8 @@
               (and resolved (:ns resolved))
               (symbol (name (:ns resolved)) (name (:name resolved)))
 
-              ;; if it wasn't resolved but is still qualified it's probably using the full namespace name rather than an
-              ;; alias.
+             ;; if it wasn't resolved but is still qualified it's probably using the full namespace name rather than an
+             ;; alias.
               (qualified-symbol? sexpr)
               sexpr)))))
     ;; some symbols like `*count/Integer` aren't resolvable.
@@ -407,3 +526,12 @@
 
   ;; should be 1
   (format-string-specifier-count "%-02d"))
+
+(defn add-lsp-ignore-unused-public-var-metadata
+  "Add
+
+    ^{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
+
+  metadata to a node to suppress LSP warnings."
+  [node]
+  (update-ignored-linters node conj :clojure-lsp/unused-public-var))

.clj-kondo/src/hooks/common/modules.clj

@@ -0,0 +1,81 @@
+(ns hooks.common.modules)
+
+(defn ignored-namespace? [config ns-symb]
+  (some
+   (fn [pattern-str]
+     (re-find (re-pattern pattern-str) (str ns-symb)))
+   (:ignored-namespace-patterns config)))
+
+(defn config [{:keys [config], :as _hook-input}]
+  (merge (get-in config [:linters :metabase/modules])
+         (select-keys config [:metabase/modules])))
+
+(defn module
+  "E.g.
+
+    (module 'metabase.qp.middleware.wow) => 'qp
+    (module 'metabase-enterprise.whatever.core) => enterprise/whatever"
+  [ns-symb]
+  {:pre [(simple-symbol? ns-symb)]}
+  (or (some->> (re-find #"^metabase-enterprise\.([^.]+)" (str ns-symb))
+               second
+               (symbol "enterprise"))
+      (some-> (re-find #"^metabase\.([^.]+)" (str ns-symb))
+              second
+              symbol)))
+
+(defn module-api-namespaces
+  "Set of API namespace symbols for a given module. `:any` means you can use anything, there are no API namespaces for
+  this module (yet). If unspecified, the default is just the `<module>.core` namespace."
+  [config module]
+  (let [module-config (get-in config [:metabase/modules module :api])]
+    (cond
+      (= module-config :any)
+      nil
+
+      (set? module-config)
+      module-config
+
+      :else
+      (let [ns-prefix (if (= (namespace module) "enterprise")
+                        (str "metabase-enterprise." (name module))
+                        (name module))]
+        #{(symbol (str ns-prefix ".api"))
+          (symbol (str ns-prefix ".core"))
+          (symbol (str ns-prefix ".init"))}))))
+
+(defn allowed-modules
+  "Set of namespace symbols that `module` is allowed to use. `:any` means it's allowed to use anything."
+  [config module]
+  (get-in config [:metabase/modules module :uses]))
+
+(defn allowed-module? [config module required-module]
+  (let [allowed-modules (allowed-modules config module)]
+    (or (= allowed-modules :any)
+        (contains? (set allowed-modules) required-module))))
+
+(defn allowed-module-namespace? [config ns-symb]
+  (let [module                (module ns-symb)
+        module-api-namespaces (module-api-namespaces config module)]
+    (or (empty? module-api-namespaces)
+        (contains? module-api-namespaces ns-symb))))
+
+(defn usage-error
+  "Find usage errors when a `required-namespace` is required in the `current-module`. Returns a string describing the
+  error type if there is one, otherwise `nil` if there are no errors."
+  [config current-module required-namespace]
+  ;; ignore stuff not in a module i.e. non-Metabase stuff.
+  (when-let [required-module (module required-namespace)]
+    (when-not (= current-module required-module)
+      (cond
+        (not (allowed-module? config current-module required-module))
+        (format "Module %s should not be used in the %s module. [:metabase/modules %s :uses]"
+                required-module
+                current-module
+                current-module)
+
+        (not (allowed-module-namespace? config required-namespace))
+        (format "Namespace %s is not an allowed external API namespace for the %s module. [:metabase/modules %s :api]"
+                required-namespace
+                required-module
+                required-module)))))

.clj-kondo/src/hooks/malli/error.clj

@@ -0,0 +1,26 @@
+(ns hooks.malli.error
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common]))
+
+(defn humanize [x]
+  (letfn [(check-node [node]
+            (when (hooks/list-node? node)
+              (let [[_ child] (:children node)]
+                (when (hooks/list-node? child)
+                  (let [[symb] (:children child)]
+                    (when-let [qualified-symb (hooks.common/node->qualified-symbol symb)]
+                      (when ('#{malli.core/validate metabase.util.malli.registry/validate}
+                             qualified-symb)
+                        (hooks/reg-finding! (assoc (meta symb)
+                                                   :message "Use malli.error/humanize with explain, NOT with validate. [:metabase/check-me-humanize]"
+                                                   :type :metabase/check-me-humanize)))))))))]
+    (check-node (:node x))
+    x))
+
+(comment
+  (humanize {:node (hooks/parse-string
+                    (pr-str '(malli.error/humanize
+                              (malli.core/validate
+                               metabase.sync.sync-metadata.dbms-version/DBMSVersion
+                               metabase.driver.druid.sync-test/dbms-version))))}))

.clj-kondo/src/hooks/metabase/api/automagic_dashboards_test.clj

@@ -1,28 +0,0 @@
-(ns hooks.metabase.api.automagic-dashboards-test
-  (:require [clj-kondo.hooks-api :as hooks]))
-
-(comment
-
-  (def input (hooks/parse-string
-              "(with-indexed-model [{:keys [model model-index model-index-value]}
-                                    {:query :some-query}]
-                  :foo :bar :body)"))
-
-  (println (hooks/sexpr input))
-
-  (let [f (load-file ".clj-kondo/hooks/metabase/api/automagic_dashboards_test.clj")]
-    (f {:node input})))
-
-(defn with-indexed-model
-  [{node :node}]
-  (let [[_macro-call binding-and-query-info & body] (:children node)
-        [binding query-info] (:children binding-and-query-info)
-        node* (hooks/list-node
-               [(hooks/token-node 'do-with-testing-model)
-                query-info
-                (hooks/list-node
-                 (list* (hooks/token-node 'fn)
-                        (hooks/vector-node [binding])
-                        body))])]
-    #_(println (hooks/sexpr node*))
-    {:node node*}))

.clj-kondo/src/hooks/metabase/api/common.clj

@@ -1,45 +0,0 @@
-(ns hooks.metabase.api.common
-  (:require
-   [clj-kondo.hooks-api :as api]
-   [clojure.string :as str]))
-
-(defn route-fn-name
-  "route fn hook"
-  [method route]
-  (let [route (if (vector? route) (first route) route)]
-    (-> (str (name method) route)
-        (str/replace #"/" "_")
-        symbol)))
-
-(defn defendpoint
-  [arg]
-  (letfn [(update-defendpoint [node]
-            (let [[_defendpoint method route & body] (:children node)]
-              (api/list-node
-               (list
-                (api/token-node 'do)
-                (api/token-node (symbol "compojure.core" (str (api/sexpr method))))
-                (-> (api/list-node
-                     (list*
-                      (api/token-node 'clojure.core/defn)
-                      (api/token-node (route-fn-name (api/sexpr method) (api/sexpr route)))
-                      body))
-                    (with-meta (meta node)))))))]
-    (update arg :node update-defendpoint)))
-
-(comment
-  (-> {:node (-> '(api/defendpoint POST "/:id/copy"
-                    "Copy a `Card`, with the new name 'Copy of _name_'"
-                    [id]
-                    {id [:maybe ms/PositiveInt]}
-                    (let [orig-card (api/read-check Card id)
-                          new-name  (str (trs "Copy of ") (:name orig-card))
-                          new-card  (assoc orig-card :name new-name)]
-                      (-> (card/create-card! new-card @api/*current-user*)
-                          hydrate-card-details
-                          (assoc :last-edit-info (last-edit/edit-information-for-user @api/*current-user*)))))
-                 pr-str
-                 api/parse-string)}
-      defendpoint
-      :node
-      api/sexpr))

.clj-kondo/src/hooks/metabase/api/macros.clj

@@ -0,0 +1,56 @@
+(ns hooks.metabase.api.macros
+  (:require
+   [clj-kondo.hooks-api :as api]
+   [hooks.common]))
+
+(defn defendpoint
+  [arg]
+  (letfn [(update-defendpoint [node]
+            (let [[defendpoint method route & more] (:children node)
+                  [result-schema & more] (if (= (api/sexpr (first more)) :-)
+                                           (drop 1 more)
+                                           (cons nil more))
+                  [_docstring & more] (if (api/string-node? (first more))
+                                        more
+                                        (cons nil more))
+                  [metadata & more] (if (api/map-node? (first more))
+                                      more
+                                      (cons nil more))
+                  [params & body] more
+                  [bindings schemas] (when (api/vector-node? params)
+                                       (loop [bindings [], schemas [], [x y & more] (:children params)]
+                                         (cond
+                                           (not x)
+                                           [bindings schemas]
+
+                                           (= (api/sexpr x) :-)
+                                           (recur bindings (conj schemas y) more)
+
+                                           :else
+                                           (recur (conj bindings x) schemas (cons y more)))))]
+              (-> (api/list-node
+                   (list
+                    (api/token-node 'do)
+                    defendpoint
+                    method
+                    route
+                    (api/list-node
+                     (list*
+                      (api/token-node 'do)
+                      (filter some? (list* metadata result-schema schemas))))
+                    (api/list-node
+                     (list*
+                      (api/token-node `let)
+                      (api/vector-node (into []
+                                             cat
+                                             [(mapcat (fn [a-binding]
+                                                        [a-binding (api/map-node {})])
+                                                      (take 4 bindings))
+                                              (mapcat (fn [a-binding]
+                                                        [a-binding (api/list-node (list
+                                                                                   (api/token-node 'clojure.core/constantly)
+                                                                                   (api/token-node 'nil)))])
+                                                      (drop 4 bindings))]))
+                      body))))
+                  (with-meta (meta node)))))]
+    (update arg :node update-defendpoint)))

.clj-kondo/src/hooks/metabase/api/search_test.clj

@@ -1,17 +0,0 @@
-(ns hooks.metabase.api.search-test
-  (:require [clj-kondo.hooks-api :as hooks]))
-
-(defn with-search-items-in-collection [{{[_ & args] :children, :as node} :node}]
-  ;; (println \newline)
-  ;; (clojure.pprint/pprint (hooks/sexpr node))
-  (let [[created-items-sym search-string & body] args
-        node*                                    (hooks/list-node
-                                                  (list*
-                                                   (hooks/token-node 'let)
-                                                   (hooks/vector-node
-                                                    [created-items-sym (hooks/token-node 'nil)])
-                                                   search-string
-                                                   body))]
-    ;; (println '=>)
-    ;; (clojure.pprint/pprint (hooks/sexpr node*))
-    {:node node*}))

.clj-kondo/src/hooks/metabase/channel/template/handlebars_helper.clj

@@ -0,0 +1,25 @@
+(ns hooks.metabase.channel.template.handlebars-helper
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common]))
+
+(defn defhelper
+  "defhelper hook"
+  [{:keys [node]}]
+  (let [[_ helper-name description argvec & body] (:children node)
+        helper-fn-name (symbol (str (hooks/sexpr helper-name) "*"))]
+    {:node (-> (hooks/list-node
+                (list (hooks/token-node 'do)
+                      (hooks/list-node
+                       (list (hooks/token-node 'defn)
+                             (hooks/token-node helper-fn-name)
+                             description
+                             argvec
+                             (hooks/list-node body)))
+                      (hooks/list-node
+                       (list (hooks/token-node 'defn)
+                             helper-name
+                             description
+                             argvec
+                             (hooks/list-node body)))))
+               (with-meta (meta node)))}))

.clj-kondo/src/hooks/metabase/lib/test_util/macros.clj

@@ -4,9 +4,9 @@
 (defn with-testing-against-standard-queries [{{[_ & args] :children} :node}]
   (let [[query-sym & body] args
         node* (hooks/list-node
-                (list*
-                  (hooks/token-node 'let)
-                  (hooks/vector-node
-                    [query-sym (hooks/token-node 'nil)])
-                  body))]
+               (list*
+                (hooks/token-node 'let)
+                (hooks/vector-node
+                 [query-sym (hooks/token-node 'nil)])
+                body))]
     {:node node*}))

.clj-kondo/src/hooks/metabase/model_persistence/test_util.clj

@@ -0,0 +1,19 @@
+(ns hooks.metabase.model-persistence.test-util
+  (:require
+   [clj-kondo.hooks-api :as hooks]))
+
+(defn with-persistence-enabled! [x]
+  (letfn [(update-node [node]
+            (let [[_symb bindings & body] (:children node)
+                  [fn-binding]            (:children bindings)]
+              (-> (hooks/list-node
+                   (list*
+                    (hooks/token-node `let)
+                    (hooks/vector-node
+                     [fn-binding (hooks/list-node
+                                  (list
+                                   (hooks/token-node `fn)
+                                   (hooks/vector-node [])))])
+                    body))
+                  (with-meta (meta node)))))]
+    (update x :node update-node)))

.clj-kondo/src/hooks/metabase/models/interface.clj

@@ -1,5 +1,7 @@
 (ns hooks.metabase.models.interface
-  (:require [clj-kondo.hooks-api :as hooks]))
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common]))
 
 (defn define-hydration-method
   "This is used for both [[metabase.models.interface/define-simple-hydration-method]] and
@@ -14,5 +16,6 @@
                      (hooks/token-node 'defn)
                      fn-name
                      fn-tail))))
-                 (with-meta (update (meta node) :clj-kondo/ignore #(hooks/vector-node (cons :clojure-lsp/unused-public-var (:children %))))))]
+                 (with-meta (meta node))
+                 hooks.common/add-lsp-ignore-unused-public-var-metadata)]
     {:node node}))

.clj-kondo/src/hooks/metabase/models/setting.clj

@@ -3,6 +3,7 @@
    [clj-kondo.hooks-api :as hooks]
    [hooks.common :as common]))
 
+;;; TODO -- move this into
 (def ^:private ignored-implicit-export?
   '#{active-users-count
      admin-email
@@ -21,6 +22,7 @@
      database-enable-actions
      deprecation-notice-version
      dismissed-custom-dashboard-toast
+     dismissed-onboarding-sidebar-link
      email-configured?
      email-from-address
      email-from-name
@@ -161,6 +163,7 @@
      token-features
      token-status
      toucan-name
+     trial-banner-dismissal-timestamp
      uncached-setting
      user-visibility
      version
@@ -181,12 +184,13 @@
         setter-node (-> (list
                          (hooks/token-node 'defn)
                          (with-meta
-                           (hooks/token-node (symbol (str (hooks/sexpr setting-name) \!)))
-                           (meta setting-name))
+                          (hooks/token-node (symbol (str (hooks/sexpr setting-name) \!)))
+                          (meta setting-name))
                          (hooks/string-node "Docstring.")
                          (hooks/vector-node [(hooks/token-node '_value-or-nil)]))
                         hooks/list-node
-                        (with-meta (update (meta node) :clj-kondo/ignore #(hooks/vector-node (cons :clojure-lsp/unused-public-var (:children %))))))]
+                        (with-meta (meta node))
+                        common/add-lsp-ignore-unused-public-var-metadata)]
 
     (when (nil? (second (drop-while (comp not #{[:k :export?]} first) options-list)))
       (when-not (contains? ignored-implicit-export? (:value setting-name))
@@ -194,15 +198,18 @@
                                    :message "Setting definition must provide an explicit value for :export? indicating whether the setting should be exported or not with serialization."
                                    :type :metabase/defsetting-must-specify-export))))
 
-    {:node (-> (list
-                (hooks/token-node 'let)
+    {:node (-> (hooks/list-node
+                (list
+                 (hooks/token-node 'let)
                  ;; include description and the options map so they can get validated as well.
-                (hooks/vector-node
-                 [anon-binding docstring
-                  anon-binding (hooks/map-node options-list)])
-                getter-node
-                setter-node)
-               hooks/list-node
+                 (hooks/vector-node
+                  [anon-binding docstring
+                   anon-binding (hooks/map-node options-list)])
+                 (hooks/reg-keyword! (-> (hooks/keyword-node (keyword (hooks/sexpr setting-name)))
+                                         (with-meta (meta setting-name)))
+                                     'metabase.models.setting/defsetting)
+                 getter-node
+                 setter-node))
                (with-meta (meta node)))}))
 
 (defn defsetting
@@ -218,9 +225,11 @@
       (defn my-setting! \"Docstring.\" [_value-or-nil]))
 
   for linting purposes."
-  [{:keys [node]}]
+  [{:keys [node], :as context}]
   (let [[setting-name docstring & options] (rest (:children node))]
-    (defsetting-lint node setting-name docstring options)))
+    (merge
+     context
+     (defsetting-lint node setting-name docstring options))))
 
 (defn define-multi-setting
   "Rewrite a [[metabase.models.define-multi-setting]] form like
@@ -235,21 +244,42 @@
       (defn my-setting! \"Docstring.\" [_value-or-nil]))
 
   for linting purposes."
-  [{:keys [node]}]
+  [{:keys [node], :as context}]
   (let [[setting-name docstring thunk & options] (rest (:children node))]
-    (defsetting-lint node setting-name docstring (concat options [(hooks/token-node :multi-thunk) thunk]))))
+    (merge
+     context
+     (defsetting-lint node setting-name docstring (concat options [(hooks/token-node :multi-thunk) thunk])))))
+
+(defn define-multi-setting-impl
+  [context]
+  (letfn [(update-node [node]
+            (let [[_define-multi-setting-impl setting-name & more] (:children node)]
+              (-> (hooks/list-node
+                   (list*
+                    (hooks/token-node 'do)
+                    ;; For a qualified setting name like `oss-namespace/setting`, then leave the symbol as is, so the
+                    ;; usage of that namespace/var gets recorded. Otherwise for an unqualified name convert it to a
+                    ;; keyword so we don't get unresolved var errors.
+                    (if (and (hooks/token-node? setting-name)
+                             (qualified-symbol? (hooks/sexpr setting-name)))
+                      setting-name
+                      (-> (hooks/keyword-node (keyword (hooks/sexpr setting-name)))
+                          (with-meta (meta setting-name))))
+                    more))
+                  (with-meta (meta node)))))]
+    (update context :node update-node)))
 
 (comment
   (defn- defsetting* [form]
     (hooks/sexpr
-      (:node
-        (defsetting
-          {:node
-           (hooks/parse-string
-             (with-out-str
-               #_{:clj-kondo/ignore [:unresolved-namespace]}
-               (clojure.pprint/pprint
-                form)))}))))
+     (:node
+      (defsetting
+        {:node
+         (hooks/parse-string
+          (with-out-str
+            #_{:clj-kondo/ignore [:unresolved-namespace]}
+            (clojure.pprint/pprint
+             form)))}))))
 
   (defn x []
     (defsetting*

.clj-kondo/src/hooks/metabase/premium_features/defenterprise.clj

@@ -0,0 +1,65 @@
+(ns hooks.metabase.premium-features.defenterprise
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common]))
+
+(defn defenterprise [{node :node}]
+  (let [[_defenterprise fn-name & args] (:children node)
+        [docstring & args]              (if (hooks/string-node? (first args))
+                                          args
+                                          (cons nil args))
+        [_enterprise-namespace & args]   (if (hooks/token-node? (first args))
+                                           args
+                                           (cons nil args))
+        [options fn-tail]               (loop [options (hooks/map-node []), [x y & more :as args] args]
+                                          (if (hooks/keyword-node? x)
+                                            (recur (update options :children concat [x y]) more)
+                                            [options args]))]
+    {:node (hooks/list-node
+            (list
+             (hooks/token-node 'let)
+             (hooks/vector-node
+              [(hooks/token-node '_options) options])
+             (-> (hooks/list-node
+                  (concat
+                   (filter some?
+                           (list (hooks/token-node 'defn)
+                                 fn-name
+                                 docstring))
+                   fn-tail))
+                 (with-meta (meta node))
+                 hooks.common/add-lsp-ignore-unused-public-var-metadata)))}))
+
+(comment
+  (defn- defenterprise* [form]
+    (hooks/sexpr
+     (:node
+      (defenterprise
+        {:node
+         (hooks/parse-string
+          (with-out-str
+            (clojure.pprint/pprint
+             form)))}))))
+
+  (defn- x []
+    (defenterprise*
+      '(defenterprise score-result
+         "Scoring implementation that adds score for items in official collections."
+         :feature :any
+         :fallback score-result-fallback
+         [result]
+         (conj (scoring/weights-and-scores result)
+               {:weight 2
+                :score  (official-collection-score result)
+                :name   "official collection score"}
+               {:weight 2
+                :score  (verified-score result)
+                :name   "verified"}))))
+
+  (defn- y []
+    (defenterprise*
+      '(defenterprise score-result
+         "Score a result, returning a collection of maps with score and weight."
+         metabase-enterprise.search.scoring
+         [result]
+         (weights-and-scores result)))))

.clj-kondo/src/hooks/metabase/public_settings/premium_features.clj

@@ -1,63 +0,0 @@
-(ns hooks.metabase.public-settings.premium-features
-  (:require
-   [clj-kondo.hooks-api :as hooks]))
-
-(defn defenterprise [{node :node}]
-  (let [[_defenterprise fn-name & args] (:children node)
-        [docstring & args]              (if (hooks/string-node? (first args))
-                                          args
-                                          (cons nil args))
-        [_enterprise-namespace & args]   (if (hooks/token-node? (first args))
-                                           args
-                                           (cons nil args))
-        [options fn-tail]               (loop [options (hooks/map-node []), [x y & more :as args] args]
-                                          (if (hooks/keyword-node? x)
-                                            (recur (update options :children concat [x y]) more)
-                                            [options args]))]
-    {:node (hooks/list-node
-            (list
-             (hooks/token-node 'let)
-             (hooks/vector-node
-              [(hooks/token-node '_options) options])
-             (-> (hooks/list-node
-                  (concat
-                   (filter some?
-                           (list (hooks/token-node 'defn)
-                                 fn-name
-                                 docstring))
-                   fn-tail))
-                 (with-meta (update (meta node) :clj-kondo/ignore #(hooks/vector-node (cons :clojure-lsp/unused-public-var (:children %))))))))}))
-
-(comment
-  (defn- defenterprise* [form]
-    (hooks/sexpr
-     (:node
-      (defenterprise
-        {:node
-         (hooks/parse-string
-          (with-out-str
-            (clojure.pprint/pprint
-             form)))}))))
-
-  (defn- x []
-    (defenterprise*
-      '(defenterprise score-result
-         "Scoring implementation that adds score for items in official collections."
-         :feature :any
-         :fallback score-result-fallback
-         [result]
-         (conj (scoring/weights-and-scores result)
-               {:weight 2
-                :score  (official-collection-score result)
-                :name   "official collection score"}
-               {:weight 2
-                :score  (verified-score result)
-                :name   "verified"}))))
-
-  (defn- y []
-    (defenterprise*
-      '(defenterprise score-result
-         "Score a result, returning a collection of maps with score and weight."
-         metabase-enterprise.search.scoring
-         [result]
-         (weights-and-scores result)))))

.clj-kondo/src/hooks/metabase/search/api_test.clj

@@ -0,0 +1,17 @@
+(ns hooks.metabase.search.api-test
+  (:require [clj-kondo.hooks-api :as hooks]))
+
+(defn with-search-items-in-collection [{{[_ & args] :children, :as node} :node}]
+  ;; (println \newline)
+  ;; (clojure.pprint/pprint (hooks/sexpr node))
+  (let [[created-items-sym search-string & body] args
+        node*                                    (hooks/list-node
+                                                  (list*
+                                                   (hooks/token-node 'let)
+                                                   (hooks/vector-node
+                                                    [created-items-sym (hooks/token-node 'nil)])
+                                                   search-string
+                                                   body))]
+    ;; (println '=>)
+    ;; (clojure.pprint/pprint (hooks/sexpr node*))
+    {:node node*}))

.clj-kondo/src/hooks/metabase/test/data.clj

@@ -11,6 +11,10 @@
   []
   (not-empty (set (keys (:clj (hooks/ns-analysis 'metabase.test.data.dataset-definitions))))))
 
+(defn- local-def?
+  [ns* sexpr]
+  (= ns* (:ns (hooks/resolve {:name sexpr}))))
+
 (defn- dataset-type
   "`dataset` can be one of:
 
@@ -21,7 +25,7 @@
 
   We can only determine if an unqualified symbol refers to something in the dataset definitions namespace if there are
   cached results available from [[global-dataset-symbols]]."
-  [dataset]
+  [this-ns dataset]
   (let [sexpr       (hooks/sexpr dataset)
         global-defs (global-dataset-symbols)]
     (cond
@@ -31,20 +35,19 @@
       (namespace sexpr)
       :qualified
 
-      (empty? global-defs)
-      :unqualified/unknown
-
       (contains? global-defs sexpr)
       :unqualified/from-dataset-defs-namespace
 
-      ;; either something defined in the current namespace or let-bound in the current scope.
+      (local-def? this-ns sexpr)
+      :unqualified/local-def
+
       :else
-      :unqualified/local-def)))
+      :unqualified/unknown)))
 
 (defn dataset
-  [{{[_ dataset & body] :children} :node}]
+  [{{[_ dataset & body] :children} :node this-ns :ns}]
   (let [noop (constantly nil)
-        body (case (dataset-type dataset)
+        body (case (dataset-type this-ns dataset)
                ;; non-symbol, qualified symbols, and unqualified symbols from the current namespace/let-bound can all
                ;; get converted from something like
                ;;

.clj-kondo/src/hooks/metabase/test/data/datasets.clj

@@ -0,0 +1,49 @@
+(ns hooks.metabase.test.data.datasets
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clojure.set :as set]
+   [hooks.common]))
+
+(defn- only-core-drivers?
+  "Whether we're for sure only testing against the 'core' drivers that are also app DB types: `:postgres`, `:mysql`, or
+  `:h2`. Tests like these are ok to mark `:mb/driver-tests` since we always run the full test suite against app DB
+  drivers anyway."
+  [node]
+  (let [drivers (hooks/sexpr (second (:children node)))
+        drivers (cond
+                  (keyword? drivers) #{drivers}
+                  (set? drivers)     drivers
+                  :else              nil)]
+    (when drivers
+      (empty? (set/difference drivers #{:h2 :mysql :postgres})))))
+
+(defn- validate-mb-driver-tests [x]
+  (when-not (:mb/driver-tests (meta (:ns x)))
+    (hooks/reg-finding!
+     (assoc (meta (:ns x))
+            :message (str "Namespaces that run driver tests (test-driver or test-drivers) should be marked"
+                          " ^:mb/driver-tests [:metabase/validate-mb-driver-tests]")
+            :type :metabase/validate-mb-driver-tests))))
+
+(defn- validate-ns-tags [x]
+  (when-not (only-core-drivers? (:node x))
+    (validate-mb-driver-tests x)))
+
+(defn test-drivers [x]
+  (validate-ns-tags x)
+  (letfn [(update-node [node]
+            (let [[test-drivers drivers-expr & body] (:children node)]
+              (-> (hooks/list-node
+                   (list*
+                    (hooks/token-node 'do)
+                    test-drivers
+                    (-> drivers-expr
+                        (hooks.common/update-ignored-linters conj :unused-value))
+                    body))
+                  (with-meta (meta node)))))]
+    (update x :node update-node)))
+
+(defn test-driver
+  "We can use the same hook for `test-driver` as we use for `test-drivers`."
+  [x]
+  (test-drivers x))

.clj-kondo/src/hooks/metabase/test/gentest.clj

@@ -0,0 +1,14 @@
+(ns hooks.metabase.test.gentest
+  (:require
+   [clj-kondo.hooks-api :as hooks]))
+
+(defn with-gentest
+  "(with-gentest {:as limit-spec} [s1 val1 & more] body-form body-form...)"
+  [{{:keys [children] :as node} :node :as orig}]
+  (let [[token limit-spec bindings & body-nodes] children
+        node* (-> (hooks/list-node
+                   (list token limit-spec
+                         (hooks/list-node (list* (hooks/token-node 'let) bindings
+                                                 body-nodes))))
+                  (with-meta (meta node)))]
+    (assoc orig :node node*)))

.clj-kondo/src/hooks/metabase/test/util.clj

@@ -27,11 +27,11 @@
                    (hooks/vector-node (into []
                                             (mapcat (fn [[setting-name v]]
                                                       (concat
-                                                        [(with-meta (hooks/token-node '_) (meta setting-name)) v]
+                                                       [(with-meta (hooks/token-node '_) (meta setting-name)) v]
                                                         ;; if the setting name is namespace-qualified add a `_`
                                                         ;; entry for it too.
-                                                        (when (namespaced-symbol-node? setting-name)
-                                                          [(with-meta (hooks/token-node '_) (meta setting-name)) setting-name]))))
+                                                       (when (namespaced-symbol-node? setting-name)
+                                                         [(with-meta (hooks/token-node '_) (meta setting-name)) setting-name]))))
                                             (partition 2 (:children bindings))))
                    bindings)]
     {:node (-> (list*

.clj-kondo/src/hooks/metabase/util.clj

@@ -15,3 +15,17 @@
                                                     actual-arg-count)
                                    :type :format))))))
   x)
+
+(defn case-enum
+  "Lint `(case-enum ...)` like `(condp = ...)`."
+  [x]
+  (letfn [(update-node [node]
+            (let [[_case-enum x & more] (:children node)]
+              (-> (api/list-node
+                   (list*
+                    (api/token-node 'clojure.core/condp)
+                    (api/token-node 'clojure.core/=)
+                    x
+                    more))
+                  (with-meta (meta node)))))]
+    (update x :node update-node)))

.clj-kondo/src/hooks/metabase/util/log.clj

@@ -109,8 +109,6 @@
                                                 actual-arg-count)
                                :type :metabase/validate-logging)))))
 
-
-
 (defn infof
   "Valid logf, debugf, etc."
   [{:keys [node], :as x}]

.clj-kondo/src/hooks/metabase/util/log/capture.clj

@@ -0,0 +1,26 @@
+(ns hooks.metabase.util.log.capture
+  (:require
+   [clj-kondo.hooks-api :as api]))
+
+(defn with-log-messages-for-level [x]
+  (letfn [(update-binding [[lhs-node _rhs-node]]
+            [lhs-node (api/list-node
+                       (list
+                        (api/token-node 'clojure.core/fn)
+                        (api/vector-node [])))])
+          (update-bindings [bindings-node]
+            (-> (api/vector-node
+                 (into []
+                       (comp (partition-all 2)
+                             (mapcat update-binding))
+                       (:children bindings-node)))
+                (with-meta (meta bindings-node))))
+          (update-node [node]
+            (let [[_with-log-messages-for-level bindings & body] (:children node)]
+              (-> (api/list-node
+                   (list*
+                    (api/token-node 'clojure.core/let)
+                    (update-bindings bindings)
+                    body))
+                  (with-meta (meta node)))))]
+    (update x :node update-node)))

.clj-kondo/src/hooks/metabase/xrays/api/automagic_dashboards_test.clj

@@ -0,0 +1,29 @@
+(ns hooks.metabase.xrays.api.automagic-dashboards-test
+  (:require
+   [clj-kondo.hooks-api :as hooks]))
+
+(comment
+
+  (def input (hooks/parse-string
+              "(with-indexed-model! [{:keys [model model-index model-index-value]}
+                                     {:query :some-query}]
+                  :foo :bar :body)"))
+
+  (println (hooks/sexpr input))
+
+  (let [f (load-file ".clj-kondo/hooks/metabase/xrays/api/automagic_dashboards_test.clj")]
+    (f {:node input})))
+
+(defn with-indexed-model!
+  [{node :node}]
+  (let [[_macro-call binding-and-query-info & body] (:children node)
+        [binding query-info] (:children binding-and-query-info)
+        node* (hooks/list-node
+               [(hooks/token-node 'do-with-indexed-model!)
+                query-info
+                (hooks/list-node
+                 (list* (hooks/token-node 'fn)
+                        (hooks/vector-node [binding])
+                        body))])]
+    #_(println (hooks/sexpr node*))
+    {:node node*}))

.clj-kondo/test/hooks/clojure/core/defmulti_test.clj

@@ -0,0 +1,63 @@
+(ns hooks.clojure.core.defmulti-test
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clj-kondo.impl.utils]
+   [clojure.test :refer :all]
+   [hooks.clojure.core.defmulti]))
+
+(defn- lint-defmulti [form]
+  (binding [clj-kondo.impl.utils/*ctx* {:config     {:linters {:metabase/check-defmulti-arglists {:level :warning}}}
+                                        :ignores    (atom nil)
+                                        :findings   (atom [])
+                                        :namespaces (atom {})}]
+    (hooks.clojure.core.defmulti/lint-defmulti {:node (hooks/parse-string (pr-str form))})
+    @(:findings clj-kondo.impl.utils/*ctx*)))
+
+(deftest ^:parallel defmulti-missing-arglists-test
+  (testing "missing arglists"
+    (is (=? [{:message "All defmultis should have an attribute map with :arglists metadata. [:metabase/check-defmulti-arglists]"}]
+            (lint-defmulti '(defmulti expand-visualization
+                              (fn [card _ _]
+                                (-> card :visualization first))))))))
+
+(deftest ^:parallel defmulti-invalid-arglists-test
+  (testing "invalid arglists"
+    (are [form] (=? [{:message ":arglists should be a quoted list of vectors [:metabase/check-defmulti-arglists]"}]
+                    (lint-defmulti form))
+      '(defmulti expand-visualization
+         {:arglists '()}
+         (fn [card _ _]
+           (-> card :visualization first)))
+      '(defmulti expand-visualization
+         {:arglists ([a])}              ; unquoted
+         (fn [card _ _]
+           (-> card :visualization first)))
+      '(defmulti expand-visualization
+         {:arglists '[(a)]}
+         (fn [card _ _]
+           (-> card :visualization first)))
+      '(defmulti expand-visualization
+         {:arglists '((a))}
+         (fn [card _ _]
+           (-> card :visualization first))))))
+
+(deftest ^:parallel defmulti-arglists-with-underscore-args-test
+  (testing "arglists, but some symbols are _"
+    (are [form] (=? [{:message ":arglists should contain actual arg names, not underscore (unused) symbols [:metabase/check-defmulti-arglists]"}]
+                    (lint-defmulti form))
+      '(defmulti expand-visualization
+         {:arglists '([card _ _])}
+         (fn [card _ _]
+           (-> card :visualization first)))
+      '(defmulti expand-visualization
+         {:arglists '([card _bad _arg])}
+         (fn [card _ _]
+           (-> card :visualization first))))))
+
+(deftest ^:parallel defmulti-arglists-ok-test
+  (testing "good"
+    (is (= []
+           (lint-defmulti '(defmulti expand-visualization
+                             {:arglists '([card x y])}
+                             (fn [card _ _]
+                               (-> card :visualization first))))))))

.clj-kondo/test/hooks/clojure/core/ns_test.clj

@@ -0,0 +1,74 @@
+(ns hooks.clojure.core.ns-test
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clj-kondo.impl.utils]
+   [clojure.test :refer :all]
+   [hooks.clojure.core.ns]))
+
+(defn- lint-ns [form config]
+  (binding [clj-kondo.impl.utils/*ctx* {:config     config
+                                        :ignores    (atom nil)
+                                        :findings   (atom [])
+                                        :namespaces (atom {})}]
+    (hooks.clojure.core.ns/lint-ns {:node   (hooks/parse-string
+                                             (binding [*print-meta* true]
+                                               (pr-str form)))
+                                    :config config})
+    @(:findings clj-kondo.impl.utils/*ctx*)))
+
+(defn- lint-modules [form config]
+  (lint-ns form (assoc-in config [:linters :metabase/modules :level] :warning)))
+
+(deftest ^:parallel module-checker-allowed-modules-test
+  (is (=? [{:message "Module task should not be used in the api module. [:metabase/modules api :uses]"
+            :type :metabase/modules}]
+          (lint-modules
+           '(ns metabase.api.search
+              (:require
+               [metabase.request.core :as request]
+               [metabase.task :as task]))
+           '{:metabase/modules {api     {:uses #{request}}
+                                request {:api #{metabase.request.core}}}}))))
+
+(deftest ^:parallel module-checker-api-namespaces-test
+  (is (=? [{:message "Namespace metabase.search.config is not an allowed external API namespace for the search module. [:metabase/modules search :api]"
+            :type :metabase/modules}]
+          (lint-modules
+           '(ns metabase.api.search
+              (:require
+               [metabase.search.config :as search.config]
+               [metabase.search.core :as search]))
+           '{:metabase/modules {api    {:uses #{search}}
+                                search {:api  #{metabase.search.core}}}}))))
+
+(deftest ^:parallel module-checker-api-namespaces-ignore-test
+  (is (empty? (lint-modules
+               '(ns metabase.api.search
+                  (:require
+                   ^{:clj-kondo/ignore [:metabase/modules]}
+                   [metabase.search.config :as search.config]
+                   [metabase.search.core :as search]))
+               '{:metabase/modules {api    {:uses #{search}}
+                                    search {:api #{metabase.search.core}}}}))))
+
+(deftest ^:parallel module-checker-enterprise-test
+  (is (=? [{:message "Module search should not be used in the enterprise/search module. [:metabase/modules enterprise/search :uses]"
+            :type :metabase/modules}]
+          (lint-modules
+           '(ns metabase-enterprise.search.core
+              (:require
+               [metabase.search.core :as search]))
+           '{:metabase/modules {search {:api #{metabase.search.core}}}}))))
+
+(deftest ^:parallel require-newlines-test
+  (binding [clj-kondo.impl.utils/*ctx* {:config     {:linters {:metabase/require-shape-checker {:level :warnings}}}
+                                        :ignores    (atom nil)
+                                        :findings   (atom [])
+                                        :namespaces (atom {})}]
+    (hooks.clojure.core.ns/lint-ns {:node (hooks/parse-string "
+(ns metabase.task.cache
+  (:require [metabase.task.bunny]
+            [metabase.task.rabbit]))")})
+    (is (=? [{:message "Put your requires on a newline from the :require keyword [:metabase/require-shape-checker]",
+              :type    :metabase/require-shape-checker}]
+            @(:findings clj-kondo.impl.utils/*ctx*)))))

.clj-kondo/test/hooks/clojure/test_test.clj

@@ -0,0 +1,55 @@
+(ns hooks.clojure.test-test
+  (:require
+   [clj-kondo.hooks-api :as api]
+   [clj-kondo.impl.utils]
+   [clojure.edn :as edn]
+   [clojure.test :refer :all]
+   [hooks.clojure.test]))
+
+(set! *warn-on-reflection* true)
+
+(defn- deftest-warnings
+  [form]
+  (binding [clj-kondo.impl.utils/*ctx* {:config     {:linters {:metabase/disallow-hardcoded-driver-names-in-tests {:level :warning}}}
+                                        :ignores    (atom nil)
+                                        :findings   (atom [])
+                                        :namespaces (atom {})}]
+    (hooks.clojure.test/deftest {:node   (api/parse-string form)
+                                 :config {:linters
+                                          {:metabase/disallow-hardcoded-driver-names-in-tests
+                                           {:drivers
+                                            #{:athena}}}}})
+    (mapv :message @(:findings clj-kondo.impl.utils/*ctx*))))
+
+(deftest ^:parallel disallow-hardcoded-driver-names-in-tests-test
+  (is (= []
+         (deftest-warnings
+           "(mt/test-drivers (mt/normal-drivers)
+              (do-something))")))
+  (is (= ["Do not hardcode driver name :athena in driver tests! [:metabase/disallow-hardcoded-driver-names-in-tests]"]
+         (deftest-warnings
+           "(mt/test-drivers (mt/normal-drivers)
+              (when-not (= driver/*driver* :athena)
+                (do-something)))")))
+  (testing "make sure :clj-kondo/ignore is propagated correctly"
+    (is (= []
+           (deftest-warnings
+             "(mt/test-drivers (mt/normal-drivers)
+                #_{:clj-kondo/ignore [:metabase/disallow-hardcoded-driver-names-in-tests]}
+                (when-not (= driver/*driver* :athena)
+                  (do-something)))")))))
+
+(deftest ^:parallel check-driver-keywords-test
+  (testing "Make sure we keep hooks.clojure.test/driver-keywords up to date"
+    (let [driver-keywords (-> (slurp ".clj-kondo/config.edn")
+                              edn/read-string
+                              (get-in [:linters :metabase/disallow-hardcoded-driver-names-in-tests :drivers]))
+          driver-modules (->> (slurp "modules/drivers/deps.edn")
+                              edn/read-string
+                              :deps
+                              vals
+                              (keep (comp keyword :local/root))
+                              (into #{}))]
+      (doseq [driver driver-modules]
+        (is (contains? driver-keywords driver)
+            (format "hooks.clojure.test/driver-keywords should contain %s, please add it" driver))))))

.clj-kondo/test/hooks/common/modules_test.clj

@@ -0,0 +1,10 @@
+(ns hooks.common.modules-test
+  (:require
+   [clojure.test :refer :all]
+   [hooks.common.modules]))
+
+(deftest ^:parallel module-test
+  (are [symb expected] (= expected
+                          (hooks.common.modules/module symb))
+    'metabase.qp.middleware.wow        'qp
+    'metabase-enterprise.whatever.core 'enterprise/whatever))

.clj-kondo/test/hooks/common_test.clj

@@ -1,10 +1,39 @@
-(ns ^:mb/once hooks.common-test
+(ns hooks.common-test
   (:require
    [clj-kondo.hooks-api :as api]
    [clj-kondo.impl.utils]
    [clojure.test :refer :all]
    [hooks.common]))
 
+(deftest ^:parallel ignored-linters-test
+  (doseq [ignored [":metabase/modules"
+                   "[:metabase/modules]"
+                   "(:metabase/modules)"]
+          prefix ["#_"
+                  "^"]
+          :let [s (format "%s{:clj-kondo/ignore %s} [metabase.search.config :as search.config]"
+                          prefix
+                          ignored)]]
+    (testing (pr-str s)
+      (is (= #{:metabase/modules}
+             (hooks.common/ignored-linters (api/parse-string s)))))))
+
+(deftest ^:parallel merge-ignored-linters-test
+  (let [node-1  (api/parse-string "#_{:clj-kondo/ignore [:a]} [:a]")
+        node-2  (api/parse-string "#_{:clj-kondo/ignore [:b]} [:b]")
+        node-3  (api/parse-string "#_{:clj-kondo/ignore [:c]} [:c]")
+        node-1' (hooks.common/merge-ignored-linters node-1 node-2 node-3)]
+    (is (= #{:a :b :c}
+           (hooks.common/ignored-linters node-1')))
+    (testing "Updated metadata should match the shape Kondo expects"
+      (is (=? {:clj-kondo/ignore {:linters api/vector-node?}}
+              (meta node-1')))
+      (let [children (-> node-1' meta :clj-kondo/ignore :linters :children)]
+        (is (= (count children) 3))
+        (is (every? api/keyword-node? children))
+        (is (= [:a :b :c]
+               (sort (map api/sexpr children))))))))
+
 (deftest ^:parallel node->qualified-symbol-test
   (binding [clj-kondo.impl.utils/*ctx* {:namespaces (atom nil)}]
     (is (= 'metabase.util.i18n/tru

.clj-kondo/test/hooks/metabase/api/macros_test.clj

@@ -0,0 +1,71 @@
+(ns hooks.metabase.api.macros-test
+  (:require
+   [clj-kondo.hooks-api :as api]
+   [clojure.test :refer :all]
+   [hooks.metabase.api.macros]))
+
+(defn- is-valid-node [x]
+  (is (api/node? x))
+  (doseq [child (:children x)]
+    (is-valid-node child)))
+
+(deftest ^:parallel defendpoint-test
+  (letfn [(defendpoint [form]
+            (let [node (-> form pr-str api/parse-string)]
+              (is-valid-node node)
+              (-> {:node node}
+                  hooks.metabase.api.macros/defendpoint
+                  :node
+                  api/sexpr)))]
+    (are [form expected] (= expected
+                            (defendpoint form))
+      '(api.macros/defendpoint :post "/" :- [:map [:collection_id :int]]
+         "Create a new [[Timeline]]."
+         [_route-params
+          _query-params
+          {:keys [icon], collection-id :collection_id, :as body} :- [:map
+                                                                     [:name    ms/NonBlankString]
+                                                                     [:default {:optional true} [:maybe :boolean]]]]
+         (body icon)
+         (body collection-id))
+      '(do
+         api.macros/defendpoint
+         :post
+         "/"
+         (do
+           [:map [:collection_id :int]]
+           [:map
+            [:name    ms/NonBlankString]
+            [:default {:optional true} [:maybe :boolean]]])
+         (clojure.core/let [_route-params {}
+                            _query-params {}
+                            {:keys [icon], collection-id :collection_id, :as body} {}]
+           (body icon)
+           (body collection-id)))
+
+      '(api.macros/defendpoint :post "/"
+         [_route-params
+          _query-params
+          body
+          request
+          respond
+          raise]
+         (try
+           (respond :x)
+           (catch Throwable e
+             (raise e))))
+      '(do
+         api.macros/defendpoint
+         :post
+         "/"
+         (do)
+         (clojure.core/let [_route-params {}
+                            _query-params {}
+                            body          {}
+                            request       {}
+                            respond       (clojure.core/constantly nil)
+                            raise         (clojure.core/constantly nil)]
+           (try
+             (respond :x)
+             (catch Throwable e
+               (raise e))))))))

.clj-kondo/test/hooks/metabase/model_persistence/test_util_test.clj

@@ -0,0 +1,19 @@
+(ns hooks.metabase.model-persistence.test-util-test
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [clojure.test :refer :all]
+   [hooks.metabase.model-persistence.test-util]))
+
+(deftest ^:parallel with-persistence-enabled-test
+  (is (= '(clojure.core/let [persist-models! (clojure.core/fn [])]
+            (persist-models!)
+            :wow)
+         (as-> '(mt/with-persistence-enabled! [persist-models!]
+                  (persist-models!)
+                  :wow) <>
+           (pr-str <>)
+           (hooks/parse-string <>)
+           {:node <>}
+           (hooks.metabase.model-persistence.test-util/with-persistence-enabled! <>)
+           (:node <>)
+           (hooks/sexpr <>)))))

.clj-kondo/test/hooks/metabase/util/log/capture_test.clj

@@ -0,0 +1,19 @@
+(ns hooks.metabase.util.log.capture-test
+  (:require
+   [clj-kondo.hooks-api :as api]
+   [clojure.test :refer :all]
+   [hooks.metabase.util.log.capture]))
+
+(deftest ^:parallel with-log-messages-for-level-test
+  (is (= '(clojure.core/let [messages-1 (clojure.core/fn [])
+                             messages-2 (clojure.core/fn [])]
+            (concat (messages-1)
+                    (messages-2)))
+         (-> (hooks.metabase.util.log.capture/with-log-messages-for-level
+               {:node (-> '(with-log-messages-for-level [messages-1 [my.namespace :debug]
+                                                         messages-2 :info]
+                             (concat (messages-1) (messages-2)))
+                          pr-str
+                          api/parse-string)})
+             :node
+             api/sexpr))))

.clj-kondo/test/hooks/metabase/util/log_test.clj

@@ -1,4 +1,4 @@
-(ns ^:mb/once hooks.metabase.util.log-test
+(ns hooks.metabase.util.log-test
   (:require
    [clj-kondo.hooks-api :as api]
    [clj-kondo.impl.utils]

.cljfmt.edn

@@ -1,31 +1,347 @@
-;; https://github.com/weavejester/cljfmt/blob/master/cljfmt/resources/cljfmt/indents/clojure.clj
-{:extra-indents
- {auto-parse                                                       [[:inner 0]]
-  cond->                                                           [[:inner 0]]
-  check                                                            [[:inner 0]]
-  deferred-tru                                                     [[:inner 0]]
-  defprotocol+                                                     [[:block 1] [:inner 1]]
-  potemkin/defprotocol+                                            [[:block 1] [:inner 1]]
-  let-404                                                          [[:block 1]]
-  metabase.legacy-mbql.util/match-one                              [[:inner 0]]
-  merge-with                                                       [[:inner 0]]
-  metabase.test/dataset                                            [[:inner 0]]
-  metabase.test/formatted-rows                                     [[:inner 0]]
-  metabase.test/mbql-query                                         [[:inner 0]]
-  metabase.test/test-drivers                                       [[:inner 0]]
-  metabase.test/with-temporary-setting-values                      [[:block 1]]
-  ;; If we just treat these as functions we can ignore this, despite some files not being consistent
-  ;metabase.models.permissions/set-has-full-permissions-for-set?    [[:inner 0]]
-  ;metabase.models.permissions/set-has-full-permissions?            [[:inner 0]]
-  ;metabase.models.permissions/set-has-partial-permissions?         [[:inner 0]]
-  metabase.models.permissions/set-has-partial-permissions-for-set? [[:inner 0]]
-  publish-event!                                                   [[:block 1]]
-  metabase.query-processor.streaming/streaming-response            [[:inner 0]]
-  metabase.util/prog1                                              [[:inner 0]]
-  metabase.util/select-keys-when                                   [[:inner 0]]
-  ;; This supports a lot of existing formatting, but these are functions so the
-  ;; existing formatting is probably wrong.
-  ;toucan2.core/select                                              [[:inner 0]]
-  ;toucan2.core/update!                                             [[:inner 0]]
-  }
- :sort-ns-references? true}
+;; Cljfmt config. See https://github.com/weavejester/cljfmt#formatting-options
+{:sort-ns-references?
+ true
+
+ :function-arguments-indentation
+ :community
+
+ :parallel?
+ true
+
+ :paths
+ ["src"
+  "test"
+  "enterprise/backend"
+  "bin/build"
+  "bin/lint-migrations-file"
+  "bin/release-list"
+  "modules/drivers"
+  ".clj-kondo/src"
+  ".clj-kondo/test"
+  #_"dev"]
+
+ ;; See https://github.com/weavejester/cljfmt/blob/master/cljfmt/resources/cljfmt/indents/clojure.clj for the default
+ ;; definitions
+ ;;
+ ;;    [[:block 0]]
+ ;;             ^ number of special args
+ ;;
+ ;; `:block` indentation means format with all arguments indented 2 spaces except for the 'special' arguments which
+ ;; normally are supposed to go on the first line. e.g. `let` gets [[:block 1]] because it has one 'special' arg.
+ ;;
+ ;;    [[:inner 0]]
+ ;;             ^ depth
+ ;;    [[:inner 2 0]]
+ ;;               ^ argument index to restrict this rule to
+ ;;
+ ;; `:inner` indentation is like `:defn` indentation. `[[:inner 0]]` (default for `defn`) means all arguments at depth
+ ;; zero get indented 2 spaces if not on the first line regardless of number of elements on the first line.
+ :extra-indents
+ {;; clojure.core stuff
+  fn*                                                                                  [[:inner 0]]
+  let*                                                                                 [[:block 1]]
+  with-meta                                                                            [[:default]]
+  ;; library stuff. Libraries that specify their own `:style/indent` specs are included in the section after this
+  ;; since it is generated automatically.
+  clojure.core.logic/fresh                                                             [[:block 1]]
+  clojure.core.logic/matcha                                                            [[:block 1]]
+  clojure.core.logic/run                                                               [[:block 2]]
+  clojure.core.match/match                                                             [[:block 1]]
+  clojure.test.check.properties/for-all                                                [[:block 1]]
+  clojure.test.check.properties/for-all*                                               [[:block 1]]
+  clojure.test.check/quick-check                                                       [[:block 1]]
+  clojure.tools.macro/macrolet                                                         [[:block 1] [:inner 2 0]]
+  clojurewerkz.quartzite.jobs/build                                                    [[:default]]
+  clojurewerkz.quartzite.jobs/with-description                                         [[:default]]
+  clojurewerkz.quartzite.jobs/with-identity                                            [[:default]]
+  clojurewerkz.quartzite.schedule.cron/schedule                                        [[:default]]
+  clojurewerkz.quartzite.schedule.cron/with-misfire-handling-instruction-do-nothing    [[:default]]
+  clojurewerkz.quartzite.triggers/build                                                [[:default]]
+  clojurewerkz.quartzite.triggers/with-description                                     [[:default]]
+  clojurewerkz.quartzite.triggers/with-identity                                        [[:default]]
+  clojurewerkz.quartzite.triggers/with-priority                                        [[:default]]
+  clojurewerkz.quartzite.triggers/with-schedule                                        [[:default]]
+  def-map-type                                                                         [[:block 2] [:inner 1]]
+  defprotocol+                                                                         [[:block 1] [:inner 1]]
+  defrecord+                                                                           [[:block 2] [:inner 1]]
+  deftype+                                                                             [[:block 2] [:inner 1]]
+  net.cgrand.macrovich/case                                                            [[:block 0]]
+  potemkin.namespaces/import-vars                                                      [[:default]]
+  potemkin.types/def-map-type                                                          [[:block 2] [:inner 1]]
+  potemkin.types/defprotocol+                                                          [[:block 1] [:inner 1]]
+  potemkin.types/defrecord+                                                            [[:block 2] [:inner 1]]
+  potemkin.types/deftype+                                                              [[:block 2] [:inner 1]]
+  potemkin/def-map-type                                                                [[:block 2] [:inner 1]]
+  potemkin/defprotocol+                                                                [[:block 1] [:inner 1]]
+  potemkin/defrecord+                                                                  [[:block 2] [:inner 1]]
+  potemkin/deftype+                                                                    [[:block 2] [:inner 1]]
+  potemkin/import-vars                                                                 [[:default]]
+  taoensso.nippy/extend-freeze                                                         [[:inner 0]]
+  taoensso.nippy/extend-thaw                                                           [[:inner 0]]
+  throttle.core/with-throttling                                                        [[:block 1]]
+  ;; the rest of the stuff in this list is generated automatically based on `:style/indent` specs
+  ;; by running [[dev.generate-cljfmt-config/specs]]... use that code to update this list
+  metabase-enterprise.advanced-permissions.api.util-test/with-impersonations!          [[:inner 0]]
+  metabase-enterprise.cache.config-test/with-temp-persist-models                       [[:block 1]]
+  metabase-enterprise.sandbox.test-util/with-gtaps!                                    [[:inner 0]]
+  metabase-enterprise.sandbox.test-util/with-gtaps-for-user!                           [[:inner 0]]
+  metabase-enterprise.sandbox.test-util/with-user-attributes                           [[:block 2]]
+  metabase-enterprise.serialization.test-util/with-dbs                                 [[:inner 0]]
+  metabase-enterprise.serialization.test-util/with-random-dump-dir                     [[:block 1]]
+  metabase-enterprise.serialization.test-util/with-world                               [[:block 0]]
+  metabase-enterprise.sso.integrations.jwt-test/with-users-with-email-deleted          [[:block 1]]
+  metabase-enterprise.test/with-gtaps!                                                 [[:inner 0]]
+  metabase-enterprise.test/with-gtaps-for-user!                                        [[:inner 0]]
+  metabase-enterprise.test/with-user-attributes                                        [[:block 2]]
+  metabase.actions.actions-test/with-actions-test-data-and-actions-permissively-enabled [[:block 0]]
+  metabase.actions.test-util/with-actions                                              [[:block 1]]
+  metabase.actions.test-util/with-actions-disabled                                     [[:block 0]]
+  metabase.actions.test-util/with-actions-enabled                                      [[:block 0]]
+  metabase.actions.test-util/with-actions-test-data                                    [[:inner 0]]
+  metabase.actions.test-util/with-actions-test-data-and-actions-enabled                [[:block 0]]
+  metabase.actions.test-util/with-actions-test-data-tables                             [[:block 1]]
+  metabase.actions.test-util/with-empty-db                                             [[:inner 0]]
+  metabase.actions.test-util/with-temp-test-data                                       [[:inner 0]]
+  metabase.api.card-test/with-cards-in-readable-collection                             [[:block 1]]
+  metabase.api.card-test/with-cards-in-writeable-collection                            [[:block 1]]
+  metabase.api.card-test/with-ordered-items                                            [[:inner 0]]
+  metabase.api.card-test/with-temp-native-card!                                        [[:block 1]]
+  metabase.api.card-test/with-temp-native-card-with-params!                            [[:block 1]]
+  metabase.api.collection-test/with-collection-hierarchy                               [[:block 1]]
+  metabase.api.collection-test/with-french-user-and-personal-collection                [[:block 2]]
+  metabase.api.collection-test/with-some-children-of-collection                        [[:block 1]]
+  metabase.api.common/check                                                            [[:default]]
+  metabase.api.common/define-routes                                                    [[:block 0]]
+  metabase.api.common/let-404                                                          [[:block 1]]
+  metabase.api.embed-test/do-response-formats                                          [[:block 1]]
+  metabase.api.embed-test/with-embedding-enabled-and-new-secret-key                    [[:block 0]]
+  metabase.api.embed-test/with-embedding-enabled-and-temp-card-referencing             [[:block 3]]
+  metabase.api.embed-test/with-embedding-enabled-and-temp-dashcard-referencing         [[:block 3]]
+  metabase.api.embed-test/with-new-secret-key                                          [[:block 0]]
+  metabase.api.embed-test/with-temp-card                                               [[:block 1]]
+  metabase.api.embed-test/with-temp-dashcard                                           [[:block 1]]
+  metabase.api.preview-embed-test/with-embedding-enabled-and-new-secret-key            [[:block 0]]
+  metabase.api.preview-embed-test/with-new-secret-key                                  [[:block 0]]
+  metabase.cmd.copy/step                                                               [[:block 1]]
+  metabase.cmd.copy/with-connection-rollback-only                                      [[:block 1]]
+  metabase.cmd.copy/with-disabled-db-constraints                                       [[:block 2]]
+  metabase.config/build-type-case                                                      [[:block 0]]
+  metabase.dashboard-subscription-test/with-link-card-fixture-for-dashboard            [[:block 2]]
+  metabase.db.liquibase/with-liquibase                                                 [[:block 1]]
+  metabase.db.liquibase/with-scope-locked                                              [[:block 1]]
+  metabase.db.schema-migrations-test.impl/test-migrations                              [[:block 2]]
+  metabase.db/with-application-db                                                      [[:inner 0]]
+  metabase.driver.bigquery-cloud-sdk.query-processor/with-temporal-type                [[:default]]
+  metabase.driver.druid.client/DELETE                                                  [[:default]]
+  metabase.driver.druid.client/GET                                                     [[:default]]
+  metabase.driver.druid.client/POST                                                    [[:default]]
+  metabase.driver.druid.query-processor-test/druid-query                               [[:block 0]]
+  metabase.driver.druid.query-processor-test/druid-query-returning-rows                [[:block 0]]
+  metabase.driver.mongo.query-processor/mongo-let                                      [[:block 1]]
+  metabase.driver.sql-jdbc.actions/with-jdbc-transaction                               [[:block 1]]
+  metabase.driver.sql-jdbc.connection/with-connection-spec-for-testing-connection      [[:block 1]]
+  metabase.driver.sql-jdbc.execute.diagnostic/capturing-diagnostic-info                [[:block 1]]
+  metabase.driver.sql.query-processor/apply-top-level-clause                           [[:default]]
+  metabase.driver/with-driver                                                          [[:block 1]]
+  metabase.lib.binning/with-binning                                                    [[:default]]
+  metabase.lib.core/with-binning                                                       [[:default]]
+  metabase.lib.core/with-join-alias                                                    [[:default]]
+  metabase.lib.core/with-join-conditions                                               [[:default]]
+  metabase.lib.join/with-join-alias                                                    [[:default]]
+  metabase.lib.join/with-join-conditions                                               [[:default]]
+  metabase.lib.test-util.macros/$ids                                                   [[:inner 0]]
+  metabase.lib.test-util.macros/mbql-query                                             [[:inner 0]]
+  metabase.lib.util.match/match                                                        [[:inner 0]]
+  metabase.lib.util.match/match-one                                                    [[:inner 0]]
+  metabase.lib.util.match/replace                                                      [[:inner 0]]
+  metabase.lib.util.match/replace-in                                                   [[:inner 0]]
+  metabase.models.collection-test/with-collection-hierarchy                            [[:block 1]]
+  metabase.models.collection-test/with-current-user-perms-for-collections              [[:block 1]]
+  metabase.models.collection-test/with-personal-and-impersonal-collections             [[:block 1]]
+  metabase.models.dashboard-test/with-dash-in-collection                               [[:inner 0]]
+  metabase.models.interface/define-batched-hydration-method                            [[:inner 0]]
+  metabase.models.interface/define-simple-hydration-method                             [[:inner 0]]
+  metabase.models.params.chain-filter-test/with-clean-field-values-for-field           [[:block 1]]
+  metabase.models.params.chain-filter-test/with-fk-field-to-field-remapping            [[:block 0]]
+  metabase.models.params.chain-filter-test/with-human-readable-values-remapping        [[:block 0]]
+  metabase.models.setting.multi-setting/define-multi-setting                           [[:inner 0]]
+  metabase.models.setting/defsetting                                                   [[:block 1]]
+  metabase.models.task-history/with-task-history                                       [[:block 1]]
+  metabase.permissions.core/allow-changing-all-users-group-members                     [[:block 0]]
+  metabase.permissions.core/disable-perms-cache                                        [[:block 0]]
+  metabase.public-sharing.api-test/with-sharing-enabled-and-temp-card-referencing      [[:block 3]]
+  metabase.public-sharing.api-test/with-sharing-enabled-and-temp-dashcard-referencing  [[:block 3]]
+  metabase.public-sharing.api-test/with-temp-public-card                               [[:block 1]]
+  metabase.public-sharing.api-test/with-temp-public-dashboard                          [[:block 1]]
+  metabase.public-sharing.api-test/with-temp-public-dashboard-and-card                 [[:block 1]]
+  metabase.pulse.api.alert-test/with-alert-in-collection                               [[:block 1]]
+  metabase.pulse.models.pulse-test/with-dashboard-subscription-in-collection           [[:block 1]]
+  metabase.pulse.models.pulse-test/with-pulse-in-collection                            [[:inner 0]]
+  metabase.query-processor-test.pipeline-queries-test/pmbql-query                      [[:block 1]]
+  metabase.query-processor-test.pipeline-queries-test/run-pmbql-query                  [[:block 1]]
+  metabase.query-processor.debug/debug>                                                [[:block 0]]
+  metabase.query-processor.error-type/deferror                                         [[:block 1]]
+  metabase.query-processor.middleware.cache-backend.interface/with-cached-results      [[:block 4]]
+  metabase.query-processor.middleware.process-userland-query-test/with-query-execution [[:block 1]]
+  metabase.query-processor.store/cached                                                [[:block 1]]
+  metabase.query-processor.store/with-metadata-provider                                [[:inner 0]]
+  metabase.query-processor.streaming/streaming-response                                [[:block 1]]
+  metabase.query-processor.test-util/format-rows-by                                    [[:default]]
+  metabase.request.core/as-admin                                                       [[:block 0]]
+  metabase.request.core/with-current-request                                           [[:inner 0]]
+  metabase.request.core/with-current-user                                              [[:inner 0]]
+  metabase.request.core/with-limit-and-offset                                          [[:inner 0]]
+  metabase.request.session/as-admin                                                    [[:block 0]]
+  metabase.request.session/with-current-user                                           [[:inner 0]]
+  metabase.sample-data-test/with-temp-sample-database-db                               [[:block 1]]
+  metabase.search.api-test/do-test-users                                               [[:block 1]]
+  metabase.server.middleware.session/as-admin                                          [[:block 0]]
+  metabase.server.middleware.session/with-current-user                                 [[:inner 0]]
+  metabase.server.streaming-response-test/with-streaming-response-thread-pool          [[:block 0]]
+  metabase.server.streaming-response-test/with-test-driver-db!                         [[:block 0]]
+  metabase.server.streaming-response/streaming-response                                [[:block 2]]
+  metabase.session.api/http-401-on-error                                               [[:block 0]]
+  metabase.sync.fetch-metadata/log-if-error                                            [[:block 1]]
+  metabase.sync.sync-metadata.fields-test/with-test-db                                 [[:block 0]]
+  metabase.sync.util/do-with-start-and-finish-debug-logging                            [[:default]]
+  metabase.sync.util/sum-for                                                           [[:block 1]]
+  metabase.sync.util/sync-operation                                                    [[:block 3]]
+  metabase.sync.util/with-db-logging-disabled                                          [[:default]]
+  metabase.sync.util/with-duplicate-ops-prevented                                      [[:default]]
+  metabase.sync.util/with-emoji-progress-bar                                           [[:block 1]]
+  metabase.sync.util/with-error-handling                                               [[:block 1]]
+  metabase.sync.util/with-start-and-finish-logging                                     [[:default]]
+  metabase.sync.util/with-start-and-finish-logging*                                    [[:default]]
+  metabase.sync.util/with-sync-events                                                  [[:default]]
+  metabase.test/$ids                                                                   [[:inner 0]]
+  metabase.test/as-admin                                                               [[:inner 0]]
+  metabase.test/dataset                                                                [[:inner 0]]
+  metabase.test/discard-setting-changes                                                [[:block 1]]
+  metabase.test/format-rows-by                                                         [[:default]]
+  metabase.test/let-url                                                                [[:block 1]]
+  metabase.test/mbql-query                                                             [[:inner 0]]
+  metabase.test/native-query                                                           [[:block 0]]
+  metabase.test/query                                                                  [[:block 1]]
+  metabase.test/run-mbql-query                                                         [[:inner 0]]
+  metabase.test/test-driver                                                            [[:inner 0]]
+  metabase.test/test-drivers                                                           [[:inner 0]]
+  metabase.test/test-helpers-set-global-values!                                        [[:block 0]]
+  metabase.test/throw-if-called!                                                       [[:block 1]]
+  metabase.test/with-actions                                                           [[:block 1]]
+  metabase.test/with-actions-disabled                                                  [[:block 0]]
+  metabase.test/with-actions-enabled                                                   [[:block 0]]
+  metabase.test/with-actions-test-data                                                 [[:inner 0]]
+  metabase.test/with-actions-test-data-and-actions-enabled                             [[:block 0]]
+  metabase.test/with-actions-test-data-tables                                          [[:block 1]]
+  metabase.test/with-additional-premium-features                                       [[:block 1]]
+  metabase.test/with-current-user                                                      [[:inner 0]]
+  metabase.test/with-driver                                                            [[:block 1]]
+  metabase.test/with-empty-db                                                          [[:inner 0]]
+  metabase.test/with-empty-h2-app-db                                                   [[:block 0]]
+  metabase.test/with-metadata-provider                                                 [[:inner 0]]
+  metabase.test/with-premium-features                                                  [[:block 1]]
+  metabase.test/with-temp                                                              [[:inner 0]]
+  metabase.test/with-temp-copy-of-db                                                   [[:block 0]]
+  metabase.test/with-temp-scheduler                                                    [[:block 0]]
+  metabase.test/with-temp-test-data                                                    [[:inner 0]]
+  metabase.test/with-temp-vals-in-db                                                   [[:block 3]]
+  metabase.test/with-test-user                                                         [[:inner 0]]
+  metabase.test/with-user-in-groups                                                    [[:inner 0]]
+  metabase.test.data/$ids                                                              [[:inner 0]]
+  metabase.test.data/dataset                                                           [[:inner 0]]
+  metabase.test.data/mbql-query                                                        [[:inner 0]]
+  metabase.test.data/native-query                                                      [[:block 0]]
+  metabase.test.data/query                                                             [[:block 1]]
+  metabase.test.data/run-mbql-query                                                    [[:inner 0]]
+  metabase.test.data/with-empty-h2-app-db                                              [[:block 0]]
+  metabase.test.data/with-temp-copy-of-db                                              [[:block 0]]
+  metabase.test.data.datasets/test-driver                                              [[:inner 0]]
+  metabase.test.data.datasets/test-drivers                                             [[:inner 0]]
+  metabase.test.data.one-off-dbs/with-blank-db                                         [[:block 0]]
+  metabase.test.data.one-off-dbs/with-blueberries-db                                   [[:block 0]]
+  metabase.test.data.users/with-test-user                                              [[:inner 0]]
+  metabase.test.util/discard-setting-changes                                           [[:block 1]]
+  metabase.test.util/let-url                                                           [[:block 1]]
+  metabase.test.util/throw-if-called!                                                  [[:block 1]]
+  metabase.test.util/with-temp-scheduler                                               [[:block 0]]
+  metabase.test.util/with-temp-vals-in-db                                              [[:block 3]]
+  metabase.test.util/with-user-in-groups                                               [[:inner 0]]
+  metabase.test.util.public-settings/with-additional-premium-features                  [[:block 1]]
+  metabase.test.util.public-settings/with-premium-features                             [[:block 1]]
+  metabase.test.util.thread-local/test-helpers-set-global-values!                      [[:block 0]]
+  metabase.timeseries-query-processor-test.util/test-timeseries-drivers                [[:block 0]]
+  metabase.timeseries-query-processor-test/run-mbql-query                              [[:inner 0]]
+  metabase.upload-test/with-upload-table!                                              [[:inner 0]]
+  metabase.upload.types/with-currency                                                  [[:default]]
+  metabase.upload.types/with-parens                                                    [[:default]]
+  metabase.util/auto-retry                                                             [[:block 1]]
+  metabase.util/case-enum                                                              [[:block 1]]
+  metabase.util/ignore-exceptions                                                      [[:block 0]]
+  metabase.util/or-with                                                                [[:block 1]]
+  metabase.util/profile                                                                [[:block 1]]
+  metabase.util/prog1                                                                  [[:inner 0]]
+  metabase.util/varargs                                                                [[:inner 0]]
+  metabase.util/with-us-locale                                                         [[:block 0]]
+  metabase.util.async/cancelable-thread                                                [[:block 0]]
+  metabase.util.date-2/with-time-zone-same-instant                                     [[:default]]
+  metabase.util.encryption-test/with-secret-key                                        [[:block 1]]
+  metabase.util.honey-sql-2/with-database-type-info                                    [[:default]]
+  metabase.util.i18n/deferred-trs                                                      [[:default]]
+  metabase.util.i18n/deferred-tru                                                      [[:default]]
+  metabase.util.i18n/trs                                                               [[:default]]
+  metabase.util.i18n/trsn                                                              [[:default]]
+  metabase.util.i18n/tru                                                               [[:default]]
+  metabase.util.i18n/trun                                                              [[:default]]
+  metabase.util.jvm/auto-retry                                                         [[:block 1]]
+  metabase.util.jvm/varargs                                                            [[:block 1]]
+  metabase.util.jvm/with-us-locale                                                     [[:block 0]]
+  metabase.util.malli/disable-enforcement                                              [[:block 0]]
+  metabase.util.malli/with                                                             [[:default]]
+  metabase.util.malli/with-api-error-message                                           [[:default]]
+  metabase.util.namespaces/import-fns                                                  [[:default]]
+  metabuild-common.core/exit-when-finished-nonzero-on-exception                        [[:block 0]]
+  metabuild-common.core/step                                                           [[:block 1]]
+  metabuild-common.entrypoint/exit-when-finished-nonzero-on-exception                  [[:block 0]]
+  metabuild-common.steps/step                                                          [[:block 1]]
+  methodical.core/defmethod                                                            [[:inner 0]]
+  methodical.core/defmulti                                                             [[:inner 0]]
+  methodical.core/with-dispatcher                                                      [[:default]]
+  methodical.core/with-method-table                                                    [[:default]]
+  methodical.core/with-prefers                                                         [[:default]]
+  methodical.interface/with-dispatcher                                                 [[:default]]
+  methodical.interface/with-method-table                                               [[:default]]
+  methodical.interface/with-prefers                                                    [[:default]]
+  methodical.macros/defmethod                                                          [[:inner 0]]
+  methodical.macros/defmulti                                                           [[:inner 0]]
+  saml20-clj.sp.response/validate-confirmation-datas                                   [[:block 1]]
+  toucan2.connection/with-transaction                                                  [[:block 1]]
+  toucan2.core/build                                                                   [[:block 0]]
+  toucan2.core/compile                                                                 [[:block 0]]
+  toucan2.core/debug                                                                   [[:block 0]]
+  toucan2.core/define-after-insert                                                     [[:inner 0]]
+  toucan2.core/define-after-select                                                     [[:inner 0]]
+  toucan2.core/define-after-update                                                     [[:inner 0]]
+  toucan2.core/define-before-delete                                                    [[:inner 0]]
+  toucan2.core/define-before-insert                                                    [[:inner 0]]
+  toucan2.core/define-before-select                                                    [[:inner 0]]
+  toucan2.core/define-default-fields                                                   [[:inner 0]]
+  toucan2.core/define-named-query                                                      [[:block 1]]
+  toucan2.core/deftransforms                                                           [[:block 1]]
+  toucan2.core/with-transaction                                                        [[:block 1]]
+  toucan2.tools.after/define-after-impl                                                [[:default]]
+  toucan2.tools.after-insert/define-after-insert                                       [[:inner 0]]
+  toucan2.tools.after-select/define-after-select                                       [[:inner 0]]
+  toucan2.tools.after-update/define-after-update                                       [[:inner 0]]
+  toucan2.tools.before-delete/define-before-delete                                     [[:inner 0]]
+  toucan2.tools.before-insert/define-before-insert                                     [[:inner 0]]
+  toucan2.tools.before-select/define-before-select                                     [[:inner 0]]
+  toucan2.tools.compile/build                                                          [[:block 0]]
+  toucan2.tools.compile/compile                                                        [[:block 0]]
+  toucan2.tools.compile/resolved                                                       [[:block 0]]
+  toucan2.tools.debug/debug                                                            [[:block 0]]
+  toucan2.tools.default-fields/define-default-fields                                   [[:inner 0]]
+  toucan2.tools.named-query/define-named-query                                         [[:block 1]]
+  toucan2.tools.simple-out-transform/define-out-transform                              [[:inner 0]]
+  toucan2.tools.transformed/deftransforms                                              [[:block 1]]
+  toucan2.tools.with-temp/with-temp                                                    [[:inner 0]]
+  toucan2.util/try-with-error-context                                                  [[:inner 0]]}}

.dir-locals.el

@@ -20,68 +20,62 @@
  (clojure-mode
   ;; Specify which arg is the docstring for certain macros
   ;; (Add more as needed)
-  (eval . (put 'defendpoint-schema 'clojure-doc-string-elt 3))
-  (eval . (put 'defendpoint 'clojure-doc-string-elt 3))
-  (eval . (put 'defendpoint-async 'clojure-doc-string-elt 3))
-  (eval . (put 'define-premium-feature 'clojure-doc-string-elt 2))
-  (eval . (put 'api/defendpoint-schema 'clojure-doc-string-elt 3))
-  (eval . (put 'api/defendpoint 'clojure-doc-string-elt 3))
-  (eval . (put 'api/defendpoint-async 'clojure-doc-string-elt 3))
-  (eval . (put 'defsetting 'clojure-doc-string-elt 2))
-  (eval . (put 'setting/defsetting 'clojure-doc-string-elt 2))
-  (eval . (put 's/defn 'clojure-doc-string-elt 2))
-  (eval . (put 'p.types/defprotocol+ 'clojure-doc-string-elt 2))
-  (eval . (put 'methodical/defmethod 'clojure-doc-string-elt 3))
-  (eval . (put 'methodical/defmulti 'clojure-doc-string-elt 2))
-  (eval . (put 'mi/define-simple-hydration-method 'clojure-doc-string-elt 3))
+  (eval . (put 'define-premium-feature             'clojure-doc-string-elt 2))
+  (eval . (put 'api.macros/defendpoint             'clojure-doc-string-elt 3))
+  (eval . (put 'defsetting                         'clojure-doc-string-elt 2))
+  (eval . (put 'setting/defsetting                 'clojure-doc-string-elt 2))
+  (eval . (put 's/defn                             'clojure-doc-string-elt 2))
+  (eval . (put 'p.types/defprotocol+               'clojure-doc-string-elt 2))
+  (eval . (put 'methodical/defmethod               'clojure-doc-string-elt 3))
+  (eval . (put 'methodical/defmulti                'clojure-doc-string-elt 2))
+  (eval . (put 'mi/define-simple-hydration-method  'clojure-doc-string-elt 3))
   (eval . (put 'mi/define-batched-hydration-method 'clojure-doc-string-elt 3))
-  (eval . (put 'mr/def 'clojure-doc-string-elt 2))
-  (eval . (put 'mu/defn 'clojure-doc-string-elt 2))
+  (eval . (put 'mr/def                             'clojure-doc-string-elt 2))
+  (eval . (put 'mu/defn                            'clojure-doc-string-elt 2))
   ;; Define custom indentation for functions inside metabase.
   ;; This list isn't complete; add more forms as we come across them.
   ;;
   ;; `put-clojure-indent' is a safe-local-eval-function, so use a bunch of calls to that
   ;; instead of one call to `define-clojure-indent'
-  (eval . (put-clojure-indent 'api/let-404 1))
-  (eval . (put-clojure-indent 'c/step 1))
-  (eval . (put-clojure-indent 'impl/test-migrations 2))
-  (eval . (put-clojure-indent 'let-404 0))
-  (eval . (put-clojure-indent 'lib.schema.match/match 1))
-  (eval . (put-clojure-indent 'lib.schema.match/match-one 1))
-  (eval . (put-clojure-indent 'lib.schema.match/replace 1))
-  (eval . (put-clojure-indent 'lib.schema.match/replace-in 2))
-  (eval . (put-clojure-indent 'lib.util.match/replace 1))
-  (eval . (put-clojure-indent 'macros/case 0))
-  (eval . (put-clojure-indent 'match 1))
-  (eval . (put-clojure-indent 'mi/define-methods '(:form)))
-  (eval . (put-clojure-indent 'mt/dataset 1))
-  (eval . (put-clojure-indent 'mt/format-rows-by 1))
-  (eval . (put-clojure-indent 'mt/query 1))
-  (eval . (put-clojure-indent 'mt/test-driver 1))
-  (eval . (put-clojure-indent 'mt/test-drivers 1))
-  (eval . (put-clojure-indent 'mt/with-anaphora 1))
-  (eval . (put-clojure-indent 'prop/for-all 1))
+  (eval . (put-clojure-indent 'api/let-404                     1))
+  (eval . (put-clojure-indent 'c/step                          1))
+  (eval . (put-clojure-indent 'impl/test-migrations            2))
+  (eval . (put-clojure-indent 'let-404                         0))
+  (eval . (put-clojure-indent 'lib.schema.match/match          '(:defn)))
+  (eval . (put-clojure-indent 'lib.schema.match/match-one      '(:defn)))
+  (eval . (put-clojure-indent 'lib.schema.match/replace        '(:defn)))
+  (eval . (put-clojure-indent 'lib.schema.match/replace-in     '(:defn)))
+  (eval . (put-clojure-indent 'lib.util.match/replace          '(:defn)))
+  (eval . (put-clojure-indent 'macros/case                     0))
+  (eval . (put-clojure-indent 'match                           1))
+  (eval . (put-clojure-indent 'mt/dataset                      1))
+  (eval . (put-clojure-indent 'mt/format-rows-by               '(:form)))
+  (eval . (put-clojure-indent 'mt/query                        1))
+  (eval . (put-clojure-indent 'mt/test-driver                  1))
+  (eval . (put-clojure-indent 'mt/test-drivers                 1))
+  (eval . (put-clojure-indent 'mt/with-anaphora                1))
+  (eval . (put-clojure-indent 'prop/for-all                    1))
   (eval . (put-clojure-indent 'qp.streaming/streaming-response 1))
-  (eval . (put-clojure-indent 'tc/quick-check 1))
-  (eval . (put-clojure-indent 'u/profile 1))
-  (eval . (put-clojure-indent 'u/prog1 1))
-  (eval . (put-clojure-indent 'u/select-keys-when 1))
-  (eval . (put-clojure-indent 'with-meta '(:form)))
+  (eval . (put-clojure-indent 'tc/quick-check                  1))
+  (eval . (put-clojure-indent 'u/profile                       1))
+  (eval . (put-clojure-indent 'u/prog1                         1))
+  (eval . (put-clojure-indent 'u/select-keys-when              '(:form)))
+  (eval . (put-clojure-indent 'with-meta                       '(:form)))
   ;; these ones have to be done with `define-clojure-indent' for now because of upstream bug
   ;; https://github.com/clojure-emacs/clojure-mode/issues/600 once that's resolved we should use `put-clojure-indent'
   ;; instead. Please don't add new entries unless they don't work with `put-clojure-indent'
   (eval . (define-clojure-indent
-           (l/matcha '(1 (:defn)))
-           (l/matche '(1 (:defn)))
+           (l/matcha                  '(1 (:defn)))
+           (l/matche                  '(1 (:defn)))
            (p.types/def-abstract-type '(1 (:defn)))
-           (p.types/defprotocol+ '(1 (:defn)))
-           (p.types/defrecord+ '(2 nil nil (:defn)))
-           (p.types/deftype+ '(2 nil nil (:defn)))
-           (p/def-map-type '(2 nil nil (:defn)))
-           (p/defprotocol+ '(1 (:defn)))
-           (p/defrecord+ '(2 nil nil (:defn)))
-           (p/deftype+ '(2 nil nil (:defn)))
-           (tools.macro/macrolet '(1 ((:defn)) :form))))
+           (p.types/defprotocol+      '(1 (:defn)))
+           (p.types/defrecord+        '(2 nil nil (:defn)))
+           (p.types/deftype+          '(2 nil nil (:defn)))
+           (p/def-map-type            '(2 nil nil (:defn)))
+           (p/defprotocol+            '(1 (:defn)))
+           (p/defrecord+              '(2 nil nil (:defn)))
+           (p/deftype+                '(2 nil nil (:defn)))
+           (tools.macro/macrolet      '(1 ((:defn)) :form))))
   (cider-clojure-cli-aliases . "dev:drivers:drivers-dev:ee:ee-dev:user")
   (clojure-indent-style . always-align)
   (cljr-favor-prefix-notation . nil)

.eslintrc.js

@@ -17,7 +17,7 @@ module.exports = {
       {
         vars: "all",
         args: "none",
-        varsIgnorePattern: "^_",
+        varsIgnorePattern: "^_.+$",
         ignoreRestSiblings: true,
       },
     ],
@@ -62,6 +62,13 @@ module.exports = {
         warnOnUnassignedImports: false,
       },
     ],
+    "sort-imports": [
+      "error",
+      {
+        // allows this rule to work with import/order
+        ignoreDeclarationSort: true,
+      },
+    ],
     "no-console": [2, { allow: ["warn", "error", "errorBuffer"] }],
     "react/no-is-mounted": 2,
     "react/prefer-es6-class": 2,
@@ -81,6 +88,7 @@ module.exports = {
       { additionalHooks: "(useSafeAsyncFunction)" },
     ],
     "prefer-const": [1, { destructuring: "all" }],
+    "no-restricted-globals": ["error", "close"],
     "no-useless-escape": 0,
     "no-only-tests/no-only-tests": [
       "error",
@@ -100,7 +108,6 @@ module.exports = {
           "When",
           "Then",
           "describeWithSnowplow",
-          "describeEE",
         ],
       },
     ],
@@ -133,6 +140,8 @@ module.exports = {
     "plugin:import/errors",
     "plugin:import/warnings",
     "plugin:import/typescript",
+    "plugin:depend/recommended",
+    "plugin:storybook/recommended",
   ],
   settings: {
     "import/internal-regex": "^metabase/|^metabase-lib/",
@@ -160,6 +169,17 @@ module.exports = {
       rules: {
         "no-unconditional-metabase-links-render": "error",
         "no-literal-metabase-strings": "error",
+        "depend/ban-dependencies": [
+          "error",
+          {
+            allowed: [
+              "underscore",
+              "moment",
+              "lodash.orderby",
+              "lodash.debounce",
+            ],
+          },
+        ],
       },
     },
     {
@@ -199,10 +219,10 @@ module.exports = {
         "@typescript-eslint/no-unused-vars": [
           "error",
           {
-            argsIgnorePattern: "^_",
-            varsIgnorePattern: "^_",
+            argsIgnorePattern: "^_.+$",
+            varsIgnorePattern: "^_.+$",
             ignoreRestSiblings: true,
-            destructuredArrayIgnorePattern: "^_",
+            destructuredArrayIgnorePattern: "^_.+$",
           },
         ],
         // This was introduced in 6.0.0
@@ -214,8 +234,9 @@ module.exports = {
         "plugin:jest/recommended",
         "plugin:jest-dom/recommended",
         "plugin:testing-library/react",
+        "plugin:jest-formatting/recommended",
       ],
-      plugins: ["jest", "jest-dom", "testing-library"],
+      plugins: ["jest", "jest-dom", "testing-library", "jest-formatting"],
       files: [
         "*.unit.spec.ts",
         "*.unit.spec.tsx",
@@ -226,5 +247,41 @@ module.exports = {
         "jest/valid-title": ["error", { ignoreTypeOfDescribeName: true }],
       },
     },
+    {
+      // Enable jest formatting for cypress tests too, the plugin logic just works
+      extends: ["plugin:jest-formatting/recommended"],
+      files: ["*.cy.spec.ts", "*.cy.spec.js"],
+    },
+    {
+      files: ["frontend/src/**/*"],
+      rules: {
+        "no-restricted-syntax": [
+          "error",
+          {
+            selector: "Literal[value=/mb-base-color-/]",
+            message:
+              "You may not use base colors in the application, use semantic colors instead. (see colors.module.css)",
+          },
+        ],
+      },
+    },
+    {
+      files: ["frontend/src/metabase/**/*"],
+      rules: {
+        "no-restricted-syntax": [
+          "error",
+          {
+            selector: "Literal[value=/mb-base-color-/]",
+            message:
+              "You may not use base colors in the application, use semantic colors instead. (see colors.module.css)",
+          },
+          {
+            selector:
+              "CallExpression[callee.property.name='legacyQuery'] > ObjectExpression > Property[key.name='useStructuredQuery'][value.value=true]",
+            message: "StructuredQuery usage is forbidden. Use MLv2",
+          },
+        ],
+      },
+    },
   ],
 };

.github/CODEOWNERS

@@ -1,14 +1,257 @@
 # Before changing this file, make sure you have read how we use it:
 # https://www.notion.so/metabase/Pull-Request-Code-Review-Guide-374f05df889748b69d67af753f9bc9b8?pvs=4#36550c04ceab40b5a8b8bee6264b090c
-# TL;DR: if @camsaul hasn't been involved you're probably doing it wrong
 
-src/metabase @camsaul
-modules @camsaul
-enterprise/backend @camsaul
-enterprise/backend/src/metabase_enterprise/advanced_permissions @noahmoss
-enterprise/backend/src/metabase_enterprise/audit_app @noahmoss
-enterprise/backend/src/metabase_enterprise/sso @noahmoss
-enterprise/backend/src/metabase_enterprise/task/truncate_audit_table.clj @noahmoss
-enterprise/backend/src/metabase_enterprise/internal_user.clj @noahmoss
-src/metabase/**/*permissions* @noahmoss
-src/metabase/integrations @noahmoss
+enterprise/frontend/src/embedding-sdk @metabase/embedding
+frontend/src/metabase/embedding-sdk @metabase/embedding
+frontend/src/metabase/ui @metabase/core-frontend-admin-webapp
+snowplow/* @metabase/data
+e2e @filiphric
+
+.github @metabase/devexp
+.clj-kondo @metabase/devexp
+
+#
+# Backend modules <=> teams that own them
+#
+
+modules/drivers @metabase/drivers
+
+enterprise/backend/src/metabase_enterprise/advanced_config @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/advanced_config @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/advanced_permissions @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/advanced_permissions @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/airgap @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/airgap @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/api @metabase/devexp
+enterprise/backend/test/metabase_enterprise/api @metabase/devexp
+
+enterprise/backend/src/metabase_enterprise/audit_app @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/audit_app @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/auth_provider @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/auth_provider @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/billing @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/billing @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/cache @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/cache @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/content_verification @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/content_verification @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/core @metabase/devexp
+enterprise/backend/test/metabase_enterprise/core @metabase/devexp
+
+enterprise/backend/src/metabase_enterprise/dashboard_subscription_filters @metabase/core-workflows
+enterprise/backend/test/metabase_enterprise/dashboard_subscription_filters @metabase/core-workflows
+
+enterprise/backend/src/metabase_enterprise/enhancements @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/enhancements @metabase/core-backend-admin-webapp
+
+# enterprise/backend/src/metabase_enterprise/llm
+# enterprise/backend/test/metabase_enterprise/llm
+
+enterprise/backend/src/metabase_enterprise/query_reference_validation @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/query_reference_validation @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/sandbox @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/sandbox @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/scim @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/scim @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/search @metabase/core-workflows
+enterprise/backend/test/metabase_enterprise/search @metabase/core-workflows
+
+enterprise/backend/src/metabase_enterprise/serialization @metabase/core-workflows
+enterprise/backend/test/metabase_enterprise/serialization @metabase/core-workflows
+
+enterprise/backend/src/metabase_enterprise/snippet_collections @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/snippet_collections @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/sso @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/sso @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/stale @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/stale @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/stats @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/stats @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/task @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/task @metabase/core-backend-admin-webapp
+
+enterprise/backend/src/metabase_enterprise/upload_management @metabase/core-backend-admin-webapp
+enterprise/backend/test/metabase_enterprise/upload_management @metabase/core-backend-admin-webapp
+
+src/metabase/actions @metabase/core-backend-admin-webapp
+test/metabase/actions @metabase/core-backend-admin-webapp
+
+src/metabase/activity_feed @metabase/core-backend-admin-webapp
+test/metabase/activity_feed @metabase/core-backend-admin-webapp
+
+src/metabase/analytics @metabase/core-backend-admin-webapp
+test/metabase/analytics @metabase/core-backend-admin-webapp
+
+src/metabase/analyze @metabase/drivers
+test/metabase/analyze @metabase/drivers
+
+src/metabase/api @metabase/devexp
+test/metabase/api @metabase/devexp
+
+src/metabase/audit @metabase/core-backend-admin-webapp
+test/metabase/audit @metabase/core-backend-admin-webapp
+
+src/metabase/auth_provider @metabase/core-backend-admin-webapp
+test/metabase/auth_provider @metabase/core-backend-admin-webapp
+
+src/metabase/bookmarks @metabase/core-backend-admin-webapp
+test/metabase/bookmarks @metabase/core-backend-admin-webapp
+
+src/metabase/cmd @metabase/devexp
+test/metabase/cmd @metabase/devexp
+
+src/metabase/channel @metabase/core-workflows
+test/metabase/channel @metabase/core-workflows
+
+src/metabase/cloud_migration @metabase/core-workflows
+test/metabase/cloud_migration @metabase/core-workflows
+
+src/metabase/cmd @metabase/devexp
+test/metabase/cmd @metabase/devexp
+
+src/metabase/config @metabase/devexp
+test/metabase/config @metabase/devexp
+
+src/metabase/core @metabase/devexp
+test/metabase/core @metabase/devexp
+
+src/metabase/db @metabase/core-backend-admin-webapp
+test/metabase/db @metabase/core-backend-admin-webapp
+
+src/metabase/driver @metabase/drivers
+test/metabase/driver @metabase/drivers
+
+src/metabase/eid_translation @metabase/core-backend-admin-webapp
+test/metabase/eid_translation @metabase/core-backend-admin-webapp
+
+src/metabase/embed @metabase/embedding
+test/metabase/embed @metabase/embedding
+
+src/metabase/events @metabase/devexp
+test/metabase/events @metabase/devexp
+
+src/metabase/formatter @metabase/core-backend-querying
+test/metabase/formatter @metabase/core-backend-querying
+
+src/metabase/indexed_entities @metabase/core-backend-querying
+test/metabase/indexed_entities @metabase/core-backend-querying
+
+src/metabase/integrations @metabase/core-workflows
+test/metabase/integrations @metabase/core-workflows
+
+src/metabase/legacy_mbql @metabase/core-backend-querying
+test/metabase/legacy_mbql @metabase/core-backend-querying
+
+src/metabase/lib @metabase/core-backend-querying
+test/metabase/lib @metabase/core-backend-querying
+
+src/metabase/logger @metabase/devexp
+test/metabase/logger @metabase/devexp
+
+src/metabase/login_history @metabase/core-backend-admin-webapp
+test/metabase/login_history @metabase/core-backend-admin-webapp
+
+src/metabase/model_persistence @metabase/core-backend-querying
+test/metabase/model_persistence @metabase/core-backend-querying
+
+src/metabase/models @metabase/devexp
+test/metabase/models @metabase/devexp
+
+src/metabase/moderation @metabase/core-backend-admin-webapp
+test/metabase/moderation @metabase/core-backend-admin-webapp
+
+src/metabase/notification @metabase/core-workflows
+test/metabase/notification @metabase/core-workflows
+
+src/metabase/permissions @metabase/core-backend-admin-webapp
+test/metabase/permissions @metabase/core-backend-admin-webapp
+
+src/metabase/plugins @metabase/devexp
+test/metabase/plugins @metabase/devexp
+
+src/metabase/premium_features @metabase/core-backend-admin-webapp
+test/metabase/premium_features @metabase/core-backend-admin-webapp
+
+src/metabase/public_settings @metabase/core-backend-admin-webapp
+test/metabase/public_settings @metabase/core-backend-admin-webapp
+
+src/metabase/public_sharing @metabase/core-backend-admin-webapp
+test/metabase/public_sharing @metabase/core-backend-admin-webapp
+
+src/metabase/pulse @metabase/core-workflows
+test/metabase/pulse @metabase/core-workflows
+
+src/metabase/query_analysis @metabase/core-backend-querying
+test/metabase/query_analysis @metabase/core-backend-querying
+
+src/metabase/query_processor @metabase/core-backend-querying
+test/metabase/query_processor @metabase/core-backend-querying
+
+src/metabase/request @metabase/devexp
+test/metabase/request @metabase/devexp
+
+src/metabase/revisions @metabase/core-backend-admin-webapp
+test/metabase/revisions @metabase/core-backend-admin-webapp
+
+src/metabase/sample_data @metabase/core-backend-admin-webapp
+test/metabase/sample_data @metabase/core-backend-admin-webapp
+
+src/metabase/search @metabase/core-workflows
+test/metabase/search @metabase/core-workflows
+
+src/metabase/segments @metabase/core-backend-querying
+test/metabase/segments @metabase/core-backend-querying
+
+src/metabase/server @metabase/devexp
+test/metabase/server @metabase/devexp
+
+src/metabase/session @metabase/core-backend-admin-webapp
+test/metabase/session @metabase/core-backend-admin-webapp
+
+src/metabase/setup @metabase/core-backend-admin-webapp
+test/metabase/setup @metabase/core-backend-admin-webapp
+
+src/metabase/sso @metabase/core-backend-admin-webapp
+test/metabase/sso @metabase/core-backend-admin-webapp
+
+src/metabase/sync @metabase/drivers
+test/metabase/sync @metabase/drivers
+
+src/metabase/task @metabase/devexp
+test/metabase/task @metabase/devexp
+
+src/metabase/tiles @metabase/core-backend-dashviz
+test/metabase/tiles @metabase/core-backend-dashviz
+
+src/metabase/timeline @metabase/core-backend-dashviz
+test/metabase/timeline @metabase/core-backend-dashviz
+
+src/metabase/types @metabase/core-backend-querying
+test/metabase/types @metabase/core-backend-querying
+
+src/metabase/upload @metabase/core-backend-admin-webapp
+test/metabase/upload @metabase/core-backend-admin-webapp
+
+src/metabase/user_key_value @metabase/core-backend-admin-webapp
+test/metabase/user_key_value @metabase/core-backend-admin-webapp
+
+src/metabase/util @metabase/devexp
+test/metabase/util @metabase/devexp
+
+src/metabase/xrays @metabase/core-backend-querying
+test/metabase/xrays @metabase/core-backend-querying

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -66,12 +66,13 @@ body:
         Copy and paste the JSON from `Admin -> Troubleshooting`.
         _This will be automatically formatted into code, so no need for backticks._
       placeholder: |
-        - Your browser and the version: (e.g., Chrome 52.1, Firefox 48.0, Safari 11.1, …)
-        - Your operating system: (e.g., OS X 10.10, Windows 10.1809, Ubuntu 16.04, …)
-        - Your databases: (e.g, MySQL, Postgres, MongoDB, …)
-        - Metabase version: (e.g., 0.19.3)
-        - Metabase hosting environment: (e.g., Elastic Beanstalk, Docker, Heroku, Jar-file on Ubuntu, …)
-        - Metabase internal database: (e.g., H2 (default), Postgres or MySQL)
+        {"browser-info": {
+           "language": "en-US",
+           "platform": "MacIntel",
+           "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36",
+           "vendor": "Google Inc."},
+         "metabase-info": {
+           "databases": [ "postgres",...
       render: JSON
     validations:
       required: true

.github/ISSUE_TEMPLATE/epic.md

@@ -5,20 +5,19 @@ about: This issue is used to track a feature/project that may span several days
   and manage work.
 title: "[Epic] Title"
 labels: ".Epic"
-
 ---
 
-**Links**
-- product doc: _link to product doc_
-- eng doc: _link to technical design doc, if any_
-- feature branch: `branch-name` _this should be the feature branch where this work will be done in. PRs will be delivered against this branch_
-- issue links: _related issues if any_
+### Links
 
-**Implementation Plan**
+- [product doc](LINK_TO_PRODUCT_DOC)
+- [technical design doc](LINK_TO_TECHNICAL_DESIGN_DOC)
+- [testing plan](LINK_TO_TESTING_PLAN)
+- feature branch: `BRANCH_NAME`
+- issue links: _related issues, if any_
 
+### Implementation Plan
 
-***Milestone 1***
-_insert tasklist here_
-
-***Milestone 2***
-
+```[tasklist]
+#### Milestone 1
+- [ ] _Add tasks here_
+```

.github/PULL_REQUEST_TEMPLATE/cypress_repro.md

@@ -5,7 +5,7 @@ PENDING CI / PENDING REVIEW / READY _(choose one and update accordingly)_
 - Reproduces #XXXXX
 
 ### How to test this manually?
-- `yarn test-cypress-open`
+- `yarn test-cypress`
 - `relative/path/to/the/file`
 > _(For still unfixed bug)_
 - Replace `it.skip()` with `it.only()` to run the test in isolation

.github/actions/await-port/action.yml

@@ -0,0 +1,15 @@
+name: Wait for localhost port to be ready
+
+inputs:
+  port:
+    required: true
+
+runs:
+  using: composite
+  steps:
+    - name: Wait for port ${{ inputs.port }} to be ready
+      shell: bash
+      run: |
+        while ! nc -z localhost ${{ inputs.port }}; do
+          sleep 0.1;
+        done

.github/actions/build-e2e-matrix/action.yml

@@ -1,69 +0,0 @@
-name: Build E2E Matrix
-description: Build and output a custom matrix for E2E tests.
-
-outputs:
-  matrix:
-    description: Parameterized matrix in JSON format
-    value: ${{ steps.matrix.outputs.result }}
-
-runs:
-  using: "composite"
-  steps:
-    - uses: actions/github-script@v7
-      id: matrix
-      with:
-        script: | # js
-          const java = 11;
-
-          const defaultRunner = "ubuntu-22.04";
-
-          const defaultOptions = {
-            "java-version": java,
-            runner: defaultRunner,
-            edition: "ee",
-            context: "folder"
-          };
-
-          const testSets = [
-            ["actions", {} ],
-            ["admin", {} ],
-            ["admin-2", {} ],
-            ["binning", {} ],
-            ["collections", {} ],
-            ["custom-column", {} ],
-            ["dashboard", {} ],
-            ["dashboard-cards", {} ],
-            ["dashboard-filters", {} ],
-            ["embedding", {} ],
-            ["filters", {} ],
-            ["filters-reproductions", {}],
-            ["joins", {} ],
-            ["metrics", {} ],
-            ["models", {} ],
-            ["native", {} ],
-            ["native-filters", {} ],
-            ["onboarding", {} ],
-            ["organization", {} ],
-            ["permissions", {} ],
-            ["question", {} ],
-            ["question-reproductions", {} ],
-            ["search", {}],
-            ["sharing", {} ],
-            ["visualizations-charts", {} ],
-            ["visualizations-tabular", {} ],
-            ["oss-subset", { edition: 'oss', context: "special" } ],
-            ["slow", { context: "special" } ],
-            ["flaky", { context: "special" } ],
-            ["mongo", { context: "qa-database" } ],
-          ];
-
-          const config = testSets.map(([name, specialOptions]) => {
-            return {
-              ...defaultOptions,
-              ...specialOptions,
-              name,
-            }
-          });
-
-          const matrix = { include: config };
-          return matrix;

.github/actions/build-ee-extra/action.yml

@@ -0,0 +1,116 @@
+name: Build ee-extra
+description: Build Metabase Enterprise Edition with extra features
+
+inputs:
+  java-version:
+    required: true
+    default: 21
+  iam-role:
+    description: "The IAM role to assume"
+    required: true
+
+runs:
+  using: composite
+  steps:
+    - name: Prepare Java
+      uses: actions/setup-java@v3
+      with:
+        java-version: ${{ inputs.java-version }}
+        distribution: 'temurin'
+    - name: Reveal its original version.properties
+      run: jar xf ./bin/docker/metabase.jar version.properties && cat version.properties
+      shell: bash
+    - name: get major version
+      id: major_version
+      run: echo "major_version=$(cat version.properties | grep 'tag=' | cut -d'.' -f2)" >> $GITHUB_OUTPUT
+      shell: bash
+    - name: get drivers registry
+      run: |
+        curl -OL https://raw.githubusercontent.com/metabase/metabase-registry/main/registry.yaml
+      shell: bash
+    - uses: actions/setup-node@v4
+      with:
+        node-version: lts/Jod # 22.x.x
+    - run: rm package.json && npm install yaml
+      shell: bash
+    - name: parse drivers registry
+      uses: actions/github-script@v7
+      id: drivers_registry
+      with:
+        script: | # js
+          const { parse } = require('yaml');
+          const fs = require('fs');
+          const registry = parse(fs.readFileSync('registry.yaml', 'utf8'));
+
+          const drivers = registry.drivers;
+          const majorVersion = '${{ steps.major_version.outputs.major_version }}';
+
+          const getDriverUrl = (driverName) => {
+            const driver = drivers.find(driver => driver.name === driverName);
+
+            if (!driver) {
+              throw new Error(`Driver ${driverName} not found in the registry`);
+            }
+
+            const driverUrl = driver.versions[majorVersion] ?? driver.versions.default;
+
+            if (!driverUrl) {
+              throw new Error(`Driver ${driverName} version ${majorVersion} not found in the registry`);
+            }
+
+            return driverUrl;
+          };
+
+          const extraDrivers = {
+            firebolt: getDriverUrl('firebolt'),
+            starburst: getDriverUrl('starburst'),
+            clickhouse: getDriverUrl('clickhouse'),
+            materialize: getDriverUrl('materialize'),
+          };
+
+          console.log(extraDrivers);
+
+          return extraDrivers;
+    - name: Download Firebolt driver
+      run: |
+        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).firebolt }}
+      working-directory: modules
+      shell: bash
+    - name: Download Starburst driver
+      run: |
+        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).starburst }}
+      shell: bash
+      working-directory: modules
+    - name: Download Clickhouse driver
+      run: |
+        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).clickhouse }}
+      shell: bash
+      working-directory: modules
+    - name: Download Materialize driver
+      run: |
+        curl -OL ${{ fromJson(steps.drivers_registry.outputs.result).materialize }}
+      shell: bash
+      working-directory: modules
+    - name: Bundle additional drivers into the Uberjar
+      run: jar uf bin/docker/metabase.jar modules/*.jar
+      shell: bash
+    - name: Launch uberjar
+      run: >-
+        java --add-opens java.base/java.nio=ALL-UNNAMED -jar ./bin/docker/metabase.jar &
+      shell: bash
+    - name: Wait for Metabase to start
+      run: while ! curl 'http://localhost:3000/api/health' | grep '{"status":"ok"}'; do sleep 1; done
+      shell: bash
+    - name: Kill the java process
+      run: pkill -f metabase.jar
+      shell: bash
+    - name: configure aws credentials
+      if: ${{ github.ref_name == 'master' }}
+      uses: aws-actions/configure-aws-credentials@v4
+      with:
+        role-to-assume: ${{ inputs.iam-role }}
+        role-session-name: GitHub_to_AWS_via_FederatedOIDC
+        aws-region: us-east-1
+    - name: Login to Amazon ECR
+      if: ${{ github.ref_name == 'master' }}
+      uses: aws-actions/amazon-ecr-login@v2

.github/actions/create-backport/action.yml

@@ -0,0 +1,101 @@
+name: Create Backport PR
+
+inputs:
+  target-version: # major version number like 34 or 86
+    required: true
+  backport-commit:
+    required: true
+  github-token:
+    required: true
+  github-token-2: # need a second token to approve the PR
+    required: true
+
+runs:
+  using: "composite"
+  steps:
+    - id: create_backport_pull_request
+      name: Create backport pull request
+      env:
+        TARGET_VERSION: ${{ inputs.target-version }}
+        TARGET_BRANCH: release-x.${{ inputs.target-version }}.x
+        ORIGINAL_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
+        ORIGINAL_TITLE: ${{ github.event.pull_request.title }}
+        GITHUB_TOKEN: ${{ inputs.github-token }}
+        COMMIT: ${{ inputs.backport-commit }}
+      shell: bash
+      run: |
+        git config --global user.email "metabase-bot@metabase.com"
+        git config --global user.name "Metabase bot"
+
+        BACKPORT_BRANCH="backport-$TARGET_VERSION-$COMMIT"
+
+        # Checkout the target branch and create a new backport branch
+        git checkout ${TARGET_BRANCH}
+        git fetch --all
+        git checkout -b ${BACKPORT_BRANCH}
+        git cherry-pick ${COMMIT} || true
+
+        CONFLICTS=$(git ls-files -u | wc -l)
+        if [ "$CONFLICTS" -gt 0 ]; then
+          git cherry-pick --abort
+
+          echo "Could not cherry pick because of a conflict"
+          echo "has-conflicts=true" >> $GITHUB_OUTPUT
+
+          # Add a shell script for resolving conflicts
+          echo "git reset HEAD~1" > ./backport.sh
+          echo "rm ./backport.sh" >> ./backport.sh
+          echo "git cherry-pick ${COMMIT}" >> ./backport.sh
+          echo "echo 'Resolve conflicts and force push this branch'" >> ./backport.sh
+          chmod +x ./backport.sh
+          git add ./backport.sh
+          git commit -m "Add backport resolution script"
+
+          PR_BODY=$(cat <<-END
+          #${ORIGINAL_PULL_REQUEST_NUMBER}
+          > [!IMPORTANT]
+          > Manual conflict resolution is required.
+          Checkout the branch and run \`./backport.sh\` script. Force push your changes after cherry-picking.
+        END
+          )
+        else
+          echo "has-conflicts=false" >> $GITHUB_OUTPUT
+          PR_BODY="#${ORIGINAL_PULL_REQUEST_NUMBER}"
+        fi
+
+        git push -u origin ${BACKPORT_BRANCH}
+
+        BACKPORT_PR_URL=$(gh pr create --base "${TARGET_BRANCH}" --head "${BACKPORT_BRANCH}" --label "was-backported" --assignee "${GITHUB_ACTOR}" --title "🤖 backported \"${ORIGINAL_TITLE}\"" --body "${PR_BODY}")
+        BACKPORT_PR_NUMBER=${BACKPORT_PR_URL##*/}
+
+        echo "backport_pr_number=$BACKPORT_PR_NUMBER" >> $GITHUB_OUTPUT
+        echo "New PR has been created: #${BACKPORT_PR_NUMBER}"
+
+        git checkout ${{ github.sha }}
+
+    - name: Auto approve backport PR
+      if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
+      uses: juliangruber/approve-pull-request-action@v1
+      with:
+        github-token: ${{ inputs.github-token-2 }}
+        number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
+
+    - name: Enable Pull Request Automerge
+      if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
+      uses: peter-evans/enable-pull-request-automerge@v2
+      with:
+        token: ${{ inputs.github-token }}
+        pull-request-number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
+        merge-method: squash
+
+    - uses: ./.github/actions/notify-pull-request
+      if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'true' }}
+      with:
+        include-log: false
+        message: Manual conflict resolution is required on \#${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
+
+    - uses: ./.github/actions/notify-pull-request
+      if: ${{ failure() }}
+      with:
+        include-log: true
+        message: Something went wrong while creating backport

.github/actions/cross-branch-migration-test/action.yml

@@ -0,0 +1,67 @@
+name: Cross-branch migration test
+
+inputs:
+  base-ref:
+    required: true
+
+runs:
+  using: "composite"
+  steps:
+    - name: Check out base branch
+      uses: actions/checkout@v4
+      with:
+        ref: ${{ inputs.base-ref }}
+
+    - name: Prepare backend environment
+      uses: ./.github/actions/prepare-backend
+      with:
+        m2-cache-key: cross-branch-migrations
+
+    - name: Run backend on base branch
+      run: |
+        clojure -M:run:ee > metabase.log 2>&1 & echo $! > metabase_pid
+        tail -F metabase.log &
+      shell: bash
+
+    - name: Wait for Metabase to start
+      run: |
+        while ! curl -s 'http://localhost:3000/api/health' | grep '{"status":"ok"}' > /dev/null; do
+          if ! kill -0 $(cat metabase_pid) 2>/dev/null; then
+            cat metabase.log
+            echo "Metabase process has exited."
+            exit 1
+          fi
+          sleep 1
+        done
+      shell: bash
+
+    - name: Stop Metabase on base branch
+      run: kill $(cat metabase_pid)
+      shell: bash
+
+    - name: Check out pull request branch
+      uses: actions/checkout@v4
+      with:
+        ref: ${{ github.head_ref }}
+
+    - name: Run backend on pull request branch
+      run: |
+        clojure -M:run:ee > metabase.log 2>&1 & echo $! > metabase_pid
+        tail -F metabase.log &
+      shell: bash
+
+    - name: Wait for Metabase to start
+      run: |
+        while ! curl -s 'http://localhost:3000/api/health' | grep '{"status":"ok"}' > /dev/null; do
+          if ! kill -0 $(cat metabase_pid) 2>/dev/null; then
+            cat metabase.log
+            echo "Metabase process has exited. Check that your migration changes work on an instance that has been previously initialized on your PR's target branch."
+            exit 1
+          fi
+          sleep 1
+        done
+      shell: bash
+
+    - name: Stop Metabase on pull request branch
+      run: kill $(cat metabase_pid)
+      shell: bash

.github/actions/e2e-download-uberjar/action.yml

@@ -68,10 +68,3 @@ runs:
     - name: Unzip Metabase artifact containing an uberjar
       run: unzip mb.zip
       shell: bash
-
-    - name: Get the version info
-      run: |
-        jar xf target/uberjar/metabase.jar version.properties
-        cat version.properties
-        mv version.properties resources/
-      shell: bash

.github/actions/e2e-prepare-containers/action.yml

@@ -10,24 +10,27 @@ inputs:
   maildev:
     description: Maildev container
     required: true
-    default: 'false'
+    default: false
   openldap:
     description: OpenLDAP container
     required: true
-    default: 'false'
+    default: false
   postgres:
     description: Postgres container
     required: true
-    default: 'false'
+    default: false
   mysql:
     description: MySQL container
     required: true
-    default: 'false'
+    default: false
   mongo:
     description: Mongo container
     required: true
-    default: 'false'
-
+    default: false
+  webhook:
+    description: Webhook tester container
+    required: false
+    default: false
 
 runs:
   using: "composite"
@@ -84,4 +87,11 @@ runs:
           while ! nc -z localhost 27004; do sleep 1; done &&
           echo -e "${G}Mongo is up and running!"
         fi
+
+        if ${{ inputs.webhook }}; then
+          echo -e "${Y}Starting webhook test container..." &&
+          docker run -d -p 9080:8080/tcp tarampampam/webhook-tester:1.1.0 serve --create-session 00000000-0000-0000-0000-000000000000 &&
+          while ! nc -z localhost 9080; do sleep 1; done &&
+          echo -e "${G}Webhook tester is up and running!"
+        fi
       shell: bash

.github/actions/find-squashed-commit/action.yml

@@ -28,3 +28,5 @@ runs:
       env:
         PULL_REQUEST_NUMBER: ${{ inputs.pull-request-number }}
         BASE_REF: ${{ inputs.base-ref }}
+    - run: git checkout ${{ github.sha }} # return to original commit
+      shell: bash

.github/actions/get-latest-release-branch/action.yml

@@ -1,41 +0,0 @@
-name: Get latest release branch
-
-outputs:
-  branch-name:
-    value: ${{ steps.get-latest-release-branch.outputs.result }}
-
-runs:
-  using: "composite"
-  steps:
-    - uses: actions/github-script@v7
-      id: get-latest-release-branch
-      with:
-        result-encoding: string
-        script: |
-          const releaseBranches = await github.rest.git.listMatchingRefs({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            ref: "heads/release-x.",
-          });
-
-          const getVersionFromBranch = branch => {
-            const match = branch.match(/release-x\.(.*?)\.x$/);
-            return match && parseInt(match[1]);
-          };
-          const latestReleaseBranch = releaseBranches.data
-            .filter(branch => getVersionFromBranch(branch.ref) !== null)
-            .reduce(
-              (prev, current) =>
-                getVersionFromBranch(prev.ref) > getVersionFromBranch(current.ref)
-                  ? prev
-                  : current,
-              { ref: "" },
-            );
-          const latestReleaseBranchName = latestReleaseBranch.ref.replace(
-            /^refs\/heads\//,
-            "",
-          );
-
-          console.log(`Latest release branch: ${latestReleaseBranchName}`);
-
-          return latestReleaseBranchName;

.github/actions/notify-pull-request/action.yml

@@ -10,10 +10,17 @@ runs:
   using: "composite"
   steps:
     - uses: actions/github-script@v7
-      id: get-latest-release-branch
+      id: notify-pull-request
       with:
         result-encoding: string
-        script: |
+        script: | # js
+          const pr = context.payload.pull_request ?? context.payload.issue;
+
+          if (!pr) {
+            console.error("This action can only be run on pull requests");
+            return;
+          }
+
           const message = "${{ inputs.message }}"
           const shouldIncludeLog = ${{ inputs.include-log }}.toString() === "true";
           const author = context.payload.sender.login;
@@ -27,7 +34,7 @@ runs:
           }
 
           github.rest.issues.createComment({
-            issue_number: context.payload.issue.number,
+            issue_number: pr.number,
             owner: context.repo.owner,
             repo: context.repo.repo,
             body,

.github/actions/prepare-backend/action.yml

@@ -2,10 +2,10 @@ name: Prepare back-end environment
 inputs:
   java-version:
     required: true
-    default: '11'
+    default: '21'
   clojure-version:
     required: true
-    default: '1.11.1.1262'
+    default: '1.12.0.1488'
   m2-cache-key:
     description: 'Key to cache M2 packages from Maven Central'
     required: true

.github/actions/prepare-cypress/action.yml

@@ -1,12 +1,20 @@
 name: Prepare cypress environment
 description: Cypress preparation steps
 
+outputs:
+  chrome-path:
+    description: Path to the custom Chrome executable
+    value: ${{ steps.setup-chrome.outputs.chrome-path }}
+
 runs:
   using: "composite"
   steps:
-    - name: Install Replay.io browser
-      run: npx replayio@1.5.1 install
-      shell: bash
+    - name: Install Chrome v111
+      uses: browser-actions/setup-chrome@v1
+      with:
+        # https://chromium.cypress.io/linux/stable/111.0.5563.146
+        chrome-version: 1097615
+      id: setup-chrome
 
     - name: Check to see if dependencies should be cached
       if: ${{ contains(github.event.head_commit.message, '[ci nocache]') }}

.github/actions/prepare-frontend/action.yml

@@ -11,6 +11,7 @@ runs:
       with:
         node-version: ${{ inputs.node-version }} # this overrides, if present
         node-version-file: ".nvmrc"
+
     - name: Check to see if dependencies should be cached
       if: ${{ contains(github.event.head_commit.message, '[ci nocache]') }}
       run: |
@@ -23,11 +24,14 @@ runs:
       with:
         path: ~/.m2
         key: ${{ runner.os }}-cljs-${{ hashFiles('**/shadow-cljs.edn') }}
+
     - name: Get node_modules cache
       uses: actions/cache@v4
+      id: node-modules-cache
       if: ${{ !contains(github.event.head_commit.message, '[ci nocache]') }}
       with:
         path: node_modules
         key: ${{ runner.os }}-node-modules-${{ hashFiles('**/yarn.lock', '**/patches/*.patch') }}
+
     - run: yarn install --frozen-lockfile --prefer-offline
       shell: bash

.github/actions/run-embedding-sdk-storybook/action.yml

@@ -0,0 +1,33 @@
+name: Run Embedding SDK Storybook
+runs:
+  using: "composite"
+  steps:
+    - name: Prepare frontend environment
+      uses: ./.github/actions/prepare-frontend
+
+    - name: Prepare back-end environment
+      uses: ./.github/actions/prepare-backend
+      with:
+        m2-cache-key: "cljs"
+
+    - name: Compile CLJS
+      run: yarn build-pure:cljs
+      shell: bash
+
+    - name: Build Storybook
+      run: yarn build-storybook-embedding-sdk
+      shell: bash
+
+    - name: Serve Storybook
+      run: yarn http-server storybook-static -p 6006 &
+      shell: bash
+
+    - name: Wait for Storybook to become available
+      run: |
+        echo "Waiting for Storybook to be served..."
+        while ! curl --silent --fail http://localhost:6006; do
+          sleep 5
+          echo "Retrying..."
+        done
+        echo "Storybook is being served!"
+      shell: bash

.github/actions/test-driver/action.yml

@@ -2,22 +2,27 @@ name: Test database driver
 inputs:
   junit-name:
     required: true
-    default: 'driver'
+    default: "driver"
   test-args:
     required: false
+  build-static-viz:
+    required: true
+    default: false
 
 runs:
   using: "composite"
   steps:
-    - name: Prepare front-end environment
-      uses: ./.github/actions/prepare-frontend
     - name: Prepare back-end environment
       uses: ./.github/actions/prepare-backend
       with:
-        m2-cache-key: driver-${{ inputs.junit-name }}
+        m2-cache-key: driver
+    - name: Prepare front-end environment
+      uses: ./.github/actions/prepare-frontend
+      if: ${{ inputs.build-static-viz == 'true' }}
     - name: Build static viz frontend
       run: yarn build-static-viz
       shell: bash
+      if: ${{ inputs.build-static-viz == 'true' }}
     - name: Test database driver
       run: clojure -X:dev:ci:ee:ee-dev:drivers:drivers-dev:test ${{ inputs.test-args }}
       shell: bash
@@ -25,7 +30,7 @@ runs:
       uses: dorny/test-reporter@v1
       if: failure()
       with:
-        path: 'target/junit/**/*_test.xml'
+        path: "target/junit/**/*_test.xml"
         name: JUnit Test Report ${{ inputs.junit-name }}
         reporter: java-junit
         list-suites: failed

.github/auto_request_review.yml

@@ -5,9 +5,9 @@
 files:
   # migrations related files
   'resources/migrations/**':
-    - team:core-backend-components
+    - team:core-workflows
   'src/metabase/db/custom_migrations.clj':
-    - team:core-backend-components
+    - team:core-workflows
 
 options:
   ignore_draft: true

.github/file-paths.yaml

@@ -5,6 +5,7 @@ default: &default
 shared_sources: &shared_sources
   - "src/**/*.cljc"
   - "src/**/*.cljs"
+  - "package.json"
 
 shared_specs: &shared_specs
   - "test/**/*.cljc"
@@ -35,7 +36,7 @@ frontend_specs: &frontend_specs
   - "frontend/test/**"
   - "frontend/**/tests/**"
   - "frontend/**/*.unit.*"
-  - "jest.config.json"
+  - "jest.config.js"
   - "jest.tz.unit.conf.json"
 
 release_source: &release_sources
@@ -61,6 +62,7 @@ backend_ci: &backend_ci
 backend_presto_kerberos:
   - "**/presto_jdbc/**"
   - "**/presto_jdbc.clj"
+  - ".github/workflows/presto-kerberos-integration-test.yml"
 
 backend_sources: &backend_sources
   - *shared_sources
@@ -78,7 +80,7 @@ backend_specs: &backend_specs
   - "test_modules/**"
   - "modules/drivers/*/test/**"
   - "test_config/**"
-  - "dev/**"
+  - "test_resources/**"
 
 backend_all: &backend_all
   - *default
@@ -92,14 +94,13 @@ sources: &sources
   - *backend_sources
 
 e2e_ci: &e2e_ci
-  - ".github/actions/build-e2e-matrix/**"
   - ".github/actions/prepare-frontend/**"
   - ".github/actions/prepare-backend/**"
   - ".github/actions/prepare-uberjar-artifact/**"
   - ".github/actions/e2e-prepare-containers/**"
   - ".github/actions/prepare-cypress/**"
   - ".github/actions/run-snowplow-micro/**"
-  - ".github/workflows/e2e-tests.yml"
+  - ".github/workflows/e2e-*"
 
 e2e_specs: &e2e_specs
   - "**/*.cy.*.js"

.github/scripts/conventional-commit-pr-title-reminder/utils.js

@@ -0,0 +1,68 @@
+exports.updateComment = updateComment;
+
+/** @param {import('@types/github-script').AsyncFunctionArguments} AsyncFunctionArguments */
+async function updateComment({ github, context }) {
+  const githubUsername = context.payload.sender.login;
+  const comment = `${CONVENTIONAL_COMMIT_REMINDER_COMMENT_IDENTIFIER}
+@${githubUsername} You have modified embedding SDK code. Please make sure the PR title follows [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) style.
+Here are all the supported types that will be shown in the changelog:
+- \`feat\`
+- \`fix\`
+- \`perf\`
+
+These types \`docs\`, \`style\`, \`refactor\`, \`test\`, \`build\`, and \`ci\` are also encouraged for non-changelog related tasks.
+
+Please also make sure to include \`sdk\` scope, otherwise, the changelog will not include this task.
+
+For example, these are valid PR titles:
+- \`feat(sdk): Add interactive dashboard component\`
+- \`feat(sdk): Support theming pie chart\`
+- \`fix(sdk): Fix static dashboard crash\``;
+
+  const owner = context.repo.owner;
+  const repo = context.repo.repo;
+  const pullRequestNumber = context.issue.number;
+  const comments = await github.rest.issues.listComments({
+    owner,
+    repo,
+    issue_number: pullRequestNumber,
+  });
+
+  const existingComment = getExistingConventionalCommitReminderComment(
+    comments.data,
+  );
+
+  if (existingComment) {
+    return await github.rest.issues.updateComment({
+      owner,
+      repo,
+      comment_id: existingComment.id,
+      body: comment,
+    });
+  } else {
+    return await github.rest.issues.createComment({
+      owner,
+      repo,
+      issue_number: pullRequestNumber,
+      body: comment,
+    });
+  }
+}
+
+const CONVENTIONAL_COMMIT_REMINDER_COMMENT_IDENTIFIER =
+  "<!---conventional commit reminder comment ID-->";
+/**
+ * @typedef Comment
+ * @property {string} body
+ *
+ * @param {Comment[]} comments
+ */
+function getExistingConventionalCommitReminderComment(comments) {
+  for (const comment of comments) {
+    if (
+      comment.body.startsWith(CONVENTIONAL_COMMIT_REMINDER_COMMENT_IDENTIFIER)
+    ) {
+      return comment;
+    }
+  }
+}

.github/scripts/handle-mochawesome-report.js

@@ -0,0 +1,112 @@
+const fs = require("fs");
+const { merge } = require("mochawesome-merge");
+
+const logger = { debug: console.debug, error: console.error };
+
+const collectTestsByType = ({ type, suite, path, cache = [] }) => {
+  logger.debug(`Collecting tests of type ${type}`);
+  const localCache = cache;
+  const { [type]: typeList, suites, tests } = suite;
+
+  for (const uuid of typeList) {
+    const foundTestByUuid = tests.find(test => test.uuid === uuid);
+    if (!foundTestByUuid) {
+      logger.error(`Test with uuid ${uuid} not found`);
+      throw new Error(`Test with uuid ${uuid} not found`);
+    }
+    logger.debug(`Found test with uuid ${uuid}`);
+    foundTestByUuid.path = path;
+    localCache.push({ path, ...foundTestByUuid });
+  }
+
+  for (const subSuite of suites) {
+    collectTestsByType({
+      type,
+      suite: subSuite,
+      path: subSuite.file || path,
+      cache: localCache,
+    });
+  }
+
+  return localCache;
+};
+
+const extractTestResultsInfo = ({ results, stats }) => {
+  logger.debug("Extracting test results information");
+
+  const testType = "failures";
+
+  const failedTests = results.flatMap(result =>
+    collectTestsByType({
+      type: testType,
+      suite: result,
+      path: result.file,
+    }),
+  );
+
+  logger.debug("Finished extracting test results information");
+
+  return {
+    failedTests,
+  };
+};
+
+async function generateReport() {
+  const files = ["./cypress/reports/mochareports/*.json"];
+
+  return await merge({ files });
+}
+
+exports.generateReport = generateReport;
+
+function parseReport(report) {
+  return extractTestResultsInfo(report).failedTests.map(test => ({
+    title: test.fullTitle,
+    error: test.err?.message,
+    path: test.path,
+  }));
+}
+
+exports.parseReport = parseReport;
+
+const groupTestsByPath = report => {
+  return report.reduce((acc, item) => {
+    if (!acc[item.path]) {
+      acc[item.path] = [];
+    }
+    acc[item.path].push(item);
+
+    return acc;
+  }, {});
+};
+
+function formatSummary(report) {
+  const failedTestsByPath = groupTestsByPath(report);
+
+  let summary = "### Failed Tests Summary\n\n";
+
+  for (const [path, tests] of Object.entries(failedTestsByPath)) {
+    summary += `| ${path} |\n`;
+    summary += "| :--- |\n";
+
+    tests.forEach(test => {
+      summary += `| ${test.title}`;
+      summary += "<p></p>"; // adds extra space after title
+      summary += `<details>`;
+      summary += "<summary>❌ ";
+      summary += `<code>${truncateError(test.error)}</code>`;
+      summary += "</summary>";
+      summary += `<pre>${test.error}</pre>`.replaceAll("\n", "<br>");
+      summary += `</details> |\n`;
+    });
+  }
+
+  return summary;
+}
+
+function truncateError(error, maxLength = 100) {
+  if (error.length <= maxLength) return error;
+  return error.replaceAll("\n", "").substring(0, maxLength) + "...";
+}
+
+exports.formatSummary = formatSummary;

.github/scripts/run-presto-kerberos-integration-test.sh

@@ -10,9 +10,9 @@ export PATH="$PATH:$JAVA_HOME/bin"
 which java
 
 # install clojure version needed for Metabase
-curl -O https://download.clojure.org/install/linux-install-1.11.0.1100.sh
-chmod +x linux-install-1.11.0.1100.sh
-./linux-install-1.11.0.1100.sh
+curl -O https://download.clojure.org/install/linux-install-1.12.0.1488.sh
+chmod +x linux-install-1.12.0.1488.sh
+./linux-install-1.12.0.1488.sh
 
 RESOURCES_DIR=/app/source/resources
 

.github/team.json

@@ -1,50 +1,69 @@
 {
   "teams": [
     {
-      "name": "Querying Components",
-      "label": ".Team/QueryingComponents",
+      "name": "Querying",
+      "label": ".Team/Querying",
+      "projectUrl": "https://github.com/orgs/metabase/projects/97/views/1",
       "members": [
         "ranquild",
         "kamilmielnik",
-        "nemanjaglumac",
-        "romeovs"
+        "romeovs",
+        "bshepherdson",
+        "metamben",
+        "lbrdnk",
+        "appleby",
+        "uladzimirdev",
+        "wzimrin",
+        "ericnormand"
+      ]
+    },
+    {
+      "name": "Drivers",
+      "label": ".Team/Drivers",
+      "projectUrl": "https://github.com/orgs/metabase/projects/98/views/1",
+      "members": [
+        "snoe",
+        "rileythomp"
       ]
     },
     {
       "name": "Embedding",
       "label": ".Team/Embedding",
       "projectUrl": "https://github.com/orgs/metabase/projects/88/views/1",
-      "members": ["WiNloSt", "deniskaber", "oisincoveney", "npretto", "heypoom"]
-    },
-    {
-      "name": "BEC",
-      "label": ".Team/BackendComponents",
-      "projectUrl": "https://github.com/orgs/metabase/projects/50/views/1",
       "members": [
-        "tsmacdonald",
-        "qnkhuat",
-        "calherries",
-        "piranha",
-        "crisptrutski"
+        "WiNloSt",
+        "oisincoveney",
+        "npretto",
+        "heypoom",
+        "sanex3339"
       ]
     },
     {
-      "name": "Query Processor",
-      "label": ".Team/QueryProcessor",
-      "projectUrl": "https://github.com/orgs/metabase/projects/83/views/8",
-      "members": ["camsaul", "snoe", "bshepherdson", "metamben", "lbrdnk"]
+      "name": "Workflows",
+      "label": ".Team/Workflows",
+      "projectUrl": "https://github.com/orgs/metabase/projects/50/views/1",
+      "members": [
+        "qnkhuat",
+        "piranha",
+        "crisptrutski",
+        "deniskaber",
+        "wotbrew",
+        "spalt08",
+        "stasgavrylov"
+      ]
     },
     {
       "name": "Admin Webapp",
       "label": ".Team/AdminWebapp",
       "members": [
-        "noahmoss",
-        "escherize",
         "npfitz",
         "johnswanson",
         "rafpaf",
         "sloansparger",
-        "iethree"
+        "iethree",
+        "nvoxland",
+        "fraserdrops",
+        "edpaget"
       ]
     },
     {
@@ -52,17 +71,18 @@
       "label": ".Team/DashViz",
       "members": [
         "alxnddr",
-        "EmmadUsmani",
-        "JesseSDevaney",
         "kulyk",
-        "adam-james-v"
+        "tsplude",
+        "lorem--ipsum",
+        "noahmoss"
       ]
     },
     {
       "name": "DevEx",
       "label": ".Team/DevEx",
       "members": [
-        "uladzimirdev"
+        "camsaul",
+        "escherize"
       ]
     }
   ]

.github/workflows/auto-backport.yml

@@ -5,8 +5,16 @@ on:
 
 jobs:
   create-backport:
-    if: github.event.pull_request.merged == true && (contains(github.event.pull_request.labels.*.name, 'backport') && github.event.action == 'closed' || github.event.label.name == 'backport')
-    runs-on: ubuntu-22.04
+    if: | # the PR must be closed and have a backport label
+      (github.event.pull_request.merged == true || github.event.action == 'closed') && (
+        contains(github.event.pull_request.labels.*.name, 'backport') ||
+        contains(github.event.pull_request.labels.*.name, 'double-backport') ||
+        contains(github.event.pull_request.labels.*.name, 'triple-backport') ||
+        github.event.label.name == 'backport' ||
+        github.event.label.name == 'double-backport' ||
+        github.event.label.name == 'triple-backport'
+      )
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
@@ -19,91 +27,68 @@ jobs:
           pull-request-number: ${{ github.event.pull_request.number }}
           base-ref: ${{ github.event.pull_request.base.ref }}
 
-      - uses: ./.github/actions/get-latest-release-branch
-        name: Get latest release branch
-        id: get_latest_release_branch
-
-      - id: create_backport_pull_request
-        name: Create backport pull request
-        run: |
-          git config --global user.email "metabase-bot@metabase.com"
-          git config --global user.name "Metabase bot"
-
-          BACKPORT_BRANCH="backport-$COMMIT"
-
-          # Checkout the target branch and create a new backport branch
-          git checkout ${TARGET_BRANCH}
-          git fetch --all
-          git checkout -b ${BACKPORT_BRANCH}
-          git cherry-pick ${COMMIT} || true
-
-          CONFLICTS=$(git ls-files -u | wc -l)
-          if [ "$CONFLICTS" -gt 0 ]; then
-            git cherry-pick --abort
-
-            echo "Could not cherry pick because of a conflict"
-            echo "has-conflicts=true" >> $GITHUB_OUTPUT
-
-            # Add a shell script for resolving conflicts
-            echo "git reset HEAD~1" > ./backport.sh
-            echo "rm ./backport.sh" >> ./backport.sh
-            echo "git cherry-pick ${COMMIT}" >> ./backport.sh
-            echo "echo 'Resolve conflicts and force push this branch'" >> ./backport.sh
-            chmod +x ./backport.sh
-            git add ./backport.sh
-            git commit -m "Add backport resolution script"
-
-            PR_BODY=$(cat <<-END
-            #${ORIGINAL_PULL_REQUEST_NUMBER}
-            > [!IMPORTANT]
-            > Manual conflict resolution is required.
-            Checkout the branch and run \`./backport.sh\` script. Force push your changes after cherry-picking.
-          END
-            )
-          else
-            echo "has-conflicts=false" >> $GITHUB_OUTPUT
-            PR_BODY="#${ORIGINAL_PULL_REQUEST_NUMBER}"
-          fi
-
-          git push -u origin ${BACKPORT_BRANCH}
-
-          BACKPORT_PR_URL=$(gh pr create --base "${TARGET_BRANCH}" --head "${BACKPORT_BRANCH}" --label "was-backported" --assignee "${GITHUB_ACTOR}" --title "🤖 backported \"${ORIGINAL_TITLE}\"" --body "${PR_BODY}")
-          BACKPORT_PR_NUMBER=${BACKPORT_PR_URL##*/}
-
-          echo "backport_pr_number=$BACKPORT_PR_NUMBER" >> $GITHUB_OUTPUT
-          echo "New PR has been created"
-
-          git checkout master
-        env:
-          TARGET_BRANCH: ${{ steps.get_latest_release_branch.outputs.branch-name }}
-          ORIGINAL_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
-          ORIGINAL_TITLE: ${{ github.event.pull_request.title }}
-          GITHUB_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
-          COMMIT: ${{ steps.find_commit.outputs.commit }}
-
-      - name: Auto approve backport PR
-        if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
-        uses: juliangruber/approve-pull-request-action@v1
+      - name: how many backports?
+        id: how-many-backports
+        uses: actions/github-script@v7
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
+          script: | # js
+            const labels = [
+              ...${{ toJson(github.event.pull_request.labels) }},
+              { name:"${{ github.event.label.name }}" }
+            ];
 
-      - name: Enable Pull Request Automerge
-        if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'false' }}
-        uses: peter-evans/enable-pull-request-automerge@v2
-        with:
-          token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
-          pull-request-number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
-          merge-method: squash
+            const backportLabelNames = labels.filter(label => label.name.includes('backport')).map(label => label.name);
 
-      - uses: ./.github/actions/notify-pull-request
-        if: ${{ steps.create_backport_pull_request.outputs.has-conflicts == 'true' }}
-        with:
-          include-log: false
-          message: Manual conflict resolution is required
+            let result = 1;
 
-      - uses: ./.github/actions/notify-pull-request
-        if: ${{ failure() }}
+            if (backportLabelNames.includes("triple-backport")) {
+              result = 3;
+            } else if (backportLabelNames.includes("double-backport")) {
+              result = 2;
+            }
+
+            console.log("backports", result);
+            return result;
+
+      - name: get release versions
+        id: get-latest-release-version
+        uses: actions/github-script@v7
         with:
-          include-log: true
-          message: Something went wrong while creating a backport
+          script: | # js
+            const currentVersion = Number(${{ vars.CURRENT_VERSION }});
+
+            const result =  {
+              latest: currentVersion,
+              secondLatest: currentVersion - 1,
+              thirdLatest: currentVersion - 2,
+            };
+
+            console.log(result);
+
+            return result;
+
+      - name: Single Backport
+        uses: ./.github/actions/create-backport
+        with:
+          target-version: ${{ fromJson(steps.get-latest-release-version.outputs.result).latest }}
+          backport-commit: ${{ steps.find_commit.outputs.commit }}
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          github-token-2: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Double Backport
+        if: ${{ fromJson(steps.how-many-backports.outputs.result) >= 2 }}
+        uses: ./.github/actions/create-backport
+        with:
+          target-version: ${{ fromJson(steps.get-latest-release-version.outputs.result).secondLatest }}
+          backport-commit: ${{ steps.find_commit.outputs.commit }}
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          github-token-2: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Triple Backport
+        if: ${{ fromJson(steps.how-many-backports.outputs.result) >= 3 }}
+        uses: ./.github/actions/create-backport
+        with:
+          target-version: ${{ fromJson(steps.get-latest-release-version.outputs.result).thirdLatest }}
+          backport-commit: ${{ steps.find_commit.outputs.commit }}
+          github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+          github-token-2: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/backend-cloverage.yml

@@ -7,6 +7,8 @@ on:
 
 jobs:
   be-linter-cloverage:
+    # don't run this workflow on a cron for forks
+    if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
     runs-on: ubuntu-22.04
     timeout-minutes: 90
     steps:

.github/workflows/backend.yml

@@ -1,103 +1,36 @@
 name: Backend
 
 on:
-  push:
-    branches:
-      - "master"
-      - "release-**"
-  pull_request:
-    types: [opened, synchronize, reopened, ready_for_review, labeled]
+  workflow_call:
+    inputs:
+      skip:
+        type: boolean
+        default: false
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
+  group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}-backend
   cancel-in-progress: true
 
-env:
-  CLJ_KONDO_VERSION: "2023.09.07"
-
 jobs:
-  files-changed:
-    name: Check which files changed
-    runs-on: ubuntu-22.04
-    timeout-minutes: 5
-    outputs:
-      backend_all: ${{ steps.changes.outputs.backend_all }}
-      frontend_sources: ${{ steps.changes.outputs.frontend_sources }}
-    steps:
-      - uses: actions/checkout@v4
-      - name: Test which files changed
-        uses: dorny/paths-filter@v3.0.0
-        id: changes
-        with:
-          token: ${{ github.token }}
-          filters: .github/file-paths.yaml
-
-  static-viz-files-changed:
-    needs: files-changed
-    if: needs.files-changed.outputs.backend_all != 'true' && needs.files-changed.outputs.frontend_sources == 'true'
-    name: Check whether static-viz files changed
-    runs-on: ubuntu-22.04
-    timeout-minutes: 10
-    outputs:
-      static_viz: ${{ steps.static_viz.outputs.static_viz }}
-    steps:
-      - uses: actions/checkout@v4
-      - name: Prepare front-end environment
-        uses: ./.github/actions/prepare-frontend
-      - name: Prepare back-end environment
-        uses: ./.github/actions/prepare-backend
-        with:
-          m2-cache-key: "files-changed"
-      - name: Build static-viz frontend
-        run: yarn build-static-viz
-      - name: Upload Static Viz Bundle Artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: static-viz-bundle-${{ github.sha }}
-          path: resources/frontend_client/app/dist
-
-      - name: Check for static viz changes
-        uses: dorny/paths-filter@v3.0.0
-        id: static_viz
-        with:
-          token: ${{ github.token }}
-          filters: .github/static-viz-sources.yaml
-
   be-linter-clj-kondo:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
     timeout-minutes: 10
-    env:
-      DOWNLOAD_URL: https://github.com/clj-kondo/clj-kondo/releases/download
+    name: Clj-Kondo
     steps:
       - uses: actions/checkout@v4
       - name: Prepare back-end environment
         uses: ./.github/actions/prepare-backend
         with:
           m2-cache-key: 'kondo'
-      - name: Install clj-kondo
-        run: |
-          curl -OL ${DOWNLOAD_URL}/v${CLJ_KONDO_VERSION}/clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip
-          curl -OL ${DOWNLOAD_URL}/v${CLJ_KONDO_VERSION}/clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip.sha256
-          cat clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip.sha256 >> SHA256sum.txt
-          echo " clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip" >> SHA256sum.txt
-          sha256sum -c SHA256sum.txt
-          unzip -d /usr/local/bin clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip
-      - run: clj-kondo --version
       - name: Run clj-kondo
         run: ./bin/kondo.sh
 
   be-linter-eastwood:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      github.event.pull_request.draft == false &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
     timeout-minutes: 20
+    name: Eastwood
     steps:
       - uses: actions/checkout@v4
       - name: Prepare back-end environment
@@ -107,95 +40,100 @@ jobs:
       - run: clojure -X:dev:ee:ee-dev:drivers:drivers-dev:test:eastwood
         name: Run Eastwood linter
 
-  # Because it's not possible to conditionally run only `java-11-ee` test in the draft mode,
-  # we have to extract that job manually here. Backend developers have requested that this
-  # test runs at all times to give them an early warning sign is something is broken.
-  be-tests-java-11-ee-pre-check:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      github.event.pull_request.draft == true &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
-    runs-on: ubuntu-22.04
-    name: be-tests-java-11-ee-pre-check
-    timeout-minutes: 60
-    steps:
-      - uses: actions/checkout@v4
-      - name: Prepare front-end environment
-        uses: ./.github/actions/prepare-frontend
-      - name: Prepare back-end environment
-        uses: ./.github/actions/prepare-backend
-        with:
-          m2-cache-key: java-11-ee-pre-check
-
-      - run: yarn install --frozen-lockfile --prefer-offline
-      - name: Build static viz frontend
-        run: yarn build-static-viz
-
-      - name: Run tests
-        run: clojure -X:dev:ci:test:ee:ee-dev
-
-      - name: Publish Test Report (JUnit)
-        uses: dorny/test-reporter@v1
-        if: failure()
-        with:
-          path: "target/junit/**/*_test.xml"
-          name: JUnit Test Report be-tests-java-11-ee-pre-check
-          reporter: java-junit
-          list-suites: failed
-          list-tests: failed
-          fail-on-error: false
-
   be-tests:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      github.event.pull_request.draft == false &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
-    name: be-tests-java-${{ matrix.java-version }}-${{ matrix.edition }}
     timeout-minutes: 60
     strategy:
       fail-fast: false
       matrix:
-        edition: [oss, ee]
-        java-version: [11, 17, 21]
+        java-version: [21]
+        job:
+          - name: Enterprise Tests
+            edition: ee
+            build-static-viz: 'false'
+            test-args: >-
+              :only '"enterprise/backend/test"'
+          - name: EE App DB Tests (Part 1)
+            edition: ee
+            build-static-viz: 'true'
+            test-args: >-
+              :only '["test" ".clj-kondo/test"]'
+              :partition/total 2
+              :partition/index 0
+          - name: EE App DB Tests (Part 2)
+            edition: ee
+            build-static-viz: 'true'
+            test-args: >-
+              :only '["test" ".clj-kondo/test"]'
+              :partition/total 2
+              :partition/index 1
+          - name: OSS App DB Tests (Part 1)
+            edition: oss
+            build-static-viz: 'true'
+            test-args: >-
+              :only '["test" ".clj-kondo/test"]'
+              :partition/total 2
+              :partition/index 0
+          - name: OSS App DB Tests (Part 2)
+            edition: oss
+            build-static-viz: 'true'
+            test-args: >-
+              :only '["test" ".clj-kondo/test"]'
+              :partition/total 2
+              :partition/index 1
+    name: "Java ${{ matrix.java-version }} ${{ matrix.job.name }}"
+    env:
+      # Only run old migrations tests on pushes to master or release branches. All other branches should skip tests
+      # with the tag `mb/old-migrations-test`. `__ADDITIONAL_EXCLUDED_TAG__` is not used anywhere outside of splicing
+      # it in to the command below.
+      __ADDITIONAL_EXCLUDED_TAG__: >-
+        ${{
+          (
+            github.event_name == 'push' &&
+            (
+              github.ref == 'master' ||
+              startsWith(github.ref, 'release-')
+            ) &&
+            ''
+          ) ||
+          ':mb/old-migrations-test'
+        }}
     steps:
       - uses: actions/checkout@v4
       - name: Prepare front-end environment
+        if: ${{ matrix.job.build-static-viz == 'true' }}
         uses: ./.github/actions/prepare-frontend
       - name: Prepare back-end environment
         uses: ./.github/actions/prepare-backend
         with:
           m2-cache-key: be-tests
+          java-version: "${{ matrix.java-version }}"
       # Depending on which files changed, we might either have to build static-viz
       # from scratch or download the previously built artifact
       - name: Build static-viz frontend
-        if: needs.files-changed.outputs.backend_all == 'true'
+        if: ${{ matrix.job.build-static-viz == 'true' && !inputs.skip }}
         run: yarn build-static-viz
       - name: Download Static Viz Bundle Artifact
-        if: needs.static-viz-files-changed.outputs.static_viz == 'true'
+        if: ${{ matrix.job.build-static-viz == 'true' && !inputs.skip }}
         uses: actions/download-artifact@v4
         with:
           name: static-viz-bundle-${{ github.sha }}
           path: resources/frontend_client/app/dist
 
-      - name: Run tests
+      - name: "Test Java ${{ matrix.java-version }} ${{ matrix.job.name }}"
         id: run-java-tests
-        if: matrix.java-version != 21
-        run: clojure -X:dev:ci:test:${{ matrix.edition }}:${{ matrix.edition }}-dev
-
-      - name: If using Java 21, only run tests on `master`
-        id: run-java-tests-21
-        if: matrix.java-version == 21 && github.ref_name == 'master'
-        run: clojure -X:dev:ci:test:${{ matrix.edition }}:${{ matrix.edition }}-dev
+        run: >-
+          clojure -X:dev:ci:test:${{ matrix.job.edition }}:${{ matrix.job.edition }}-dev
+          :exclude-tags '[:mb/driver-tests ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
+          ${{ matrix.job.test-args }}
 
       - name: Upload Test Results
         uses: ./.github/actions/upload-test-results
         if: always() && (steps.run-java-tests.conclusion != 'skipped' || steps.run-java-tests-21.conclusion != 'skipped')
         with:
           input-path: ./target/junit/
-          output-name: be-tests-java-${{ matrix.java-version }}-${{ matrix.edition }}
+          output-name: be-tests-java-${{ matrix.java-version }}-${{ matrix.job.edition }}
           bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
           aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
@@ -207,64 +145,83 @@ jobs:
         if: failure()
         with:
           path: "target/junit/**/*_test.xml"
-          name: JUnit Test Report be-tests-java-${{ matrix.java-version }}-${{ matrix.edition }}
+          name: JUnit Test Report be-tests-java-${{ matrix.java-version }}-${{ matrix.job.edition }}
           reporter: java-junit
           list-suites: failed
           list-tests: failed
           fail-on-error: false
 
-  be-tests-stub:
-    needs: [be-tests]
-    if: |
-      !cancelled() &&
-      github.event.pull_request.draft == false && needs.be-tests.result == 'skipped'
-    runs-on: ubuntu-22.04
-    name: be-tests-java-${{ matrix.java-version }}-${{ matrix.edition }}
-    timeout-minutes: 5
-    strategy:
-      fail-fast: false
-      matrix:
-        edition: [oss, ee]
-        java-version: [11, 17, 21]
-    steps:
-      - run: |
-          echo "Didn't run due to conditional filtering"
-
   # checks that all the namespaces we actually ship can be compiled, without any dependencies that we don't ship (such
   # as `:dev` dependencies). See #27009 for more context.
   be-check:
-    needs: [files-changed, static-viz-files-changed]
-    if: |
-      !cancelled() &&
-      github.event.pull_request.draft == false &&
-      (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
-    name: be-check-java-${{ matrix.java-version }}
     timeout-minutes: 10
     strategy:
       matrix:
-        java-version: [11, 17, 21]
+        java-version: [21]
+    name: "Check Java ${{ matrix.java-version }}"
     steps:
       - uses: actions/checkout@v4
       - name: Prepare backend
         uses: ./.github/actions/prepare-backend
         with:
           m2-cache-key: be-check
+      # TODO -- we should probably also check WITHOUT ee -- do a check with only OSS namespaces on the classpath
       - name: Check namespaces
         run: clojure -M:ee:drivers:check
 
-  be-check-stub:
-    needs: [files-changed, static-viz-files-changed, be-check]
-    if: |
-      always() &&
-      github.event.pull_request.draft == false &&
-      needs.be-check.result == 'skipped'
+  be-cljfmt:
+    if: ${{ !inputs.skip }}
     runs-on: ubuntu-22.04
-    name: be-check-java-${{ matrix.java-version }}
     timeout-minutes: 10
-    strategy:
-      matrix:
-        java-version: [11, 17, 21]
+    name: Cljfmt
     steps:
-      - run: |
-          echo "Didn't run due to conditional filtering"
+      - uses: actions/checkout@v4
+      - name: Prepare back-end environment
+        uses: ./.github/actions/prepare-backend
+        with:
+          m2-cache-key: 'cljfmt'
+      - name: Run cljfmt
+        run: clojure -T:cljfmt check
+
+  be-tests-result:
+    needs:
+      - be-linter-eastwood
+      - be-linter-clj-kondo
+      - be-cljfmt
+      - be-check
+      - be-tests
+    if: always() && !cancelled()
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    env:
+      needs: ${{ toJson(needs) }}
+    steps:
+      - name: Check backend job status
+        uses: actions/github-script@v7
+        env:
+          needs: ${{ toJson(needs) }}
+        with:
+          script: | # js
+            const needs = JSON.parse(process.env.needs);
+            const jobs = Object.entries(needs).map(
+              ([jobName, jobValues]) => ({
+                name: jobName,
+                result: jobValues.result
+              }));
+
+            // are all jobs skipped or successful?
+            if (jobs.every(job => (job.result === 'skipped' || job.result === 'success'))) {
+              console.log('All jobs are skipped or successful');
+              process.exit(0);
+            }
+
+            // otherwise, something failed
+            console.log('Some backend jobs failed');
+            jobs.forEach((job) => {
+              if (job.result !== 'success') {
+                console.log(`${job.name} - ${job.result}`);
+              }
+            });
+            process.exit(1);

.github/workflows/backport-reminder.yml

@@ -9,10 +9,11 @@ on:
 jobs:
   backport-reminder:
     name: Decide whether to backport or not
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
     steps:
       - uses: jesusvasquez333/verify-pr-label-action@v1.4.0
         with:
           github-token: '${{ secrets.GITHUB_TOKEN }}'
-          valid-labels: 'backport, no-backport'
+          valid-labels: 'no-backport, backport, double-backport, triple-backport'
           disable-reviews: true

.github/workflows/backport.yml

@@ -1,162 +0,0 @@
-# Cherry-picks commits from current branch to a specified one in a command "@metabase-bot backport release-x.40.x"
-name: Backport
-
-on:
-  issue_comment:
-    types: [created]
-
-jobs:
-  create_pull_request:
-    name: Creates a pull request
-    if: contains(github.event.comment.body, '@metabase-bot backport')
-    runs-on: ubuntu-22.04
-    steps:
-      - uses: tibdex/github-app-token@v2.1.0
-        id: generate-token
-        with:
-          app_id: ${{ secrets.METABASE_BOT_APP_ID }}
-          private_key: ${{ secrets.METABASE_BOT_APP_PRIVATE_KEY }}
-      - uses: actions/checkout@v4
-        name: Cherry-pick commits and create PR
-        with:
-          fetch-depth: 0
-      - name: Verify Membership
-        id: verify-membership
-        uses: ./.github/actions/verify-membership
-        with:
-          github_token: ${{ steps.generate-token.outputs.token }}
-          organization_name: metabase
-          username: ${{ github.event.comment.user.login }}
-      - run: |
-          result=${{ steps.verify-membership.outputs.is_member }}
-          if [ $result == false ]; then
-              echo User ${{ github.event.comment.user.login }} is not a member of Metabase organization
-              exit 1
-          fi
-      - uses: actions/github-script@v7
-        id: branch_info
-        with:
-          script: |
-            await github.rest.reactions.createForIssueComment({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              comment_id: context.payload.comment.id,
-              content: 'eyes',
-            });
-
-            // Example: @metabase-bot backport release-x.40.x
-            const [_botName, _command, targetBranch] = context.payload.comment.body.split(" ");
-            console.log(`Target branch is ${targetBranch}`);
-
-            const { data: originalPullRequest } = await github.rest.pulls.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: context.payload.issue.number,
-            });
-
-            const { data: commits } = await github.rest.pulls.listCommits({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: context.payload.issue.number,
-            });
-
-            const targetRef = await github.rest.git.getRef({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              ref: `heads/${targetBranch}`,
-            });
-
-            const backportBranch = `backport-${originalPullRequest.head.ref}-${targetBranch}`
-
-            try {
-              await github.rest.git.getRef({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                ref: `heads/${backportBranch}`,
-              });
-            } catch(e) {
-              if (e.status === 404) {
-                await github.rest.git.createRef({
-                  owner: context.repo.owner,
-                  repo: context.repo.repo,
-                  ref: `refs/heads/${backportBranch}`,
-                  sha: targetRef.data.object.sha,
-                });
-              }
-            }
-
-            return {
-              backportBranch,
-              targetBranch,
-              originalPullRequest,
-              startSha: commits[0].sha,
-              endSha: commits[commits.length - 1].sha
-            }
-      - id: create_backport_pull_request
-        name: Create backport pull request
-        run: |
-          git config --global user.email "metabase-bot@metabase.com"
-          git config --global user.name "Metabase bot"
-
-          git fetch --all
-
-          git checkout "${BACKPORT_BRANCH}"
-          git reset --hard origin/${TARGET_BRANCH}
-
-          if [[ -z $(git ls-remote --heads origin ${ORIGINAL_HEAD_REF}) ]]; then
-            echo "PR has been merged, searching for a squashed commit in the base branch"
-            echo "searching for a commit in a ${ORIGINAL_BASE_REF} that contains pull request number ${ORIGINAL_PULL_REQUEST_NUMBER}"
-            SQUASHED_COMMIT=$(env -i git log ${ORIGINAL_BASE_REF} --grep="(#${ORIGINAL_PULL_REQUEST_NUMBER})" --format="%H")
-            echo "found commit ${SQUASHED_COMMIT}"
-            git cherry-pick ${SQUASHED_COMMIT}
-          else
-            echo "PR has not been merged, copying all commits"
-            git cherry-pick ${ORIGINAL_BASE_SHA}..${ORIGINAL_HEAD_SHA}
-          fi
-
-          git push origin "${BACKPORT_BRANCH}" --force-with-lease
-
-          if [[ $(gh pr list --base "${TARGET_BRANCH}" --head "${BACKPORT_BRANCH}" -s "open") ]]; then
-              echo "PR already exists"
-          else
-              BACKPORT_PR_URL=$(gh pr create --base "${TARGET_BRANCH}" --head "${BACKPORT_BRANCH}" --label "was-backported" --assignee "${GITHUB_ACTOR}" --title "🤖 backported \"${ORIGINAL_TITLE}\"" --body "#${ORIGINAL_PULL_REQUEST_NUMBER}")
-              BACKPORT_PR_NUMBER=${BACKPORT_PR_URL##*/}
-
-              echo "backport_pr_number=$BACKPORT_PR_NUMBER" >> $GITHUB_OUTPUT
-              echo "New PR has been created"
-          fi
-        env:
-          ORIGINAL_TITLE: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.title }}
-          ORIGINAL_BASE_REF: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.base.ref }}
-          ORIGINAL_BASE_SHA: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.base.sha }}
-          ORIGINAL_HEAD_REF: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.head.ref }}
-          ORIGINAL_HEAD_SHA: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.head.sha }}
-          ORIGINAL_PULL_REQUEST_NUMBER: ${{ fromJson(steps.branch_info.outputs.result).originalPullRequest.number }}
-          TARGET_BRANCH: ${{ fromJson(steps.branch_info.outputs.result).targetBranch }}
-          BACKPORT_BRANCH: ${{ fromJson(steps.branch_info.outputs.result).backportBranch }}
-          START_SHA: ${{ fromJson(steps.branch_info.outputs.result).startSha }}
-          END_SHA: ${{ fromJson(steps.branch_info.outputs.result).endSha }}
-          GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}
-      - name: Auto approve backport PR
-        uses: juliangruber/approve-pull-request-action@v1
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
-      - name: Enable Pull Request Automerge
-        uses: peter-evans/enable-pull-request-automerge@v2
-        with:
-          token: ${{ steps.generate-token.outputs.token }}
-          pull-request-number: ${{ steps.create_backport_pull_request.outputs.backport_pr_number }}
-          merge-method: squash
-
-  notify_when_failed:
-    runs-on: ubuntu-22.04
-    name: Notify about failure
-    needs: create_pull_request
-    if: ${{ failure() }}
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/notify-pull-request
-        with:
-          include-log: true
-          message: something went wrong while creating a backport

.github/workflows/bugs-triage-slack-notification.yml

@@ -3,14 +3,13 @@ name: Bugs Slack Notification
 on:
   issues:
     types:
-      - opened
+      - labeled
 jobs:
-  on-issue-opened:
+  on-issue-labeled:
     runs-on: ubuntu-22.04
     timeout-minutes: 5
     if: |
-        contains(github.event.issue.labels.*.name, '.Needs Triage') &&
-        contains(github.event.issue.labels.*.name, 'Type:Bug')
+      github.event.label.name == '.Needs Triage' && contains(github.event.issue.labels.*.name, 'Type:Bug')
     steps:
       - name: Setting title
         uses: actions/github-script@v7
@@ -34,7 +33,7 @@ jobs:
       - name: Send the issue ${{ github.event.issue.number }} to Slack
         id: slack
         if: steps.check_labels.outputs.has_team_label == 'false'
-        uses: slackapi/slack-github-action@v1.23.0
+        uses: slackapi/slack-github-action@v1.26.0
         with:
           payload: |
             {

.github/workflows/build-for-release.yml

@@ -100,21 +100,14 @@ jobs:
             oss: getCanonicalVersion(version, 'oss'),
           };
 
-          const ossReleased = await hasBeenReleased({
+          const released = await hasBeenReleased({
             github,
             owner: context.repo.owner,
             repo: context.repo.repo,
             version: versions.oss,
           });
 
-          const eeReleased = await hasBeenReleased({
-            github,
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            version: versions.ee,
-          });
-
-          if (ossReleased || eeReleased) {
+          if (released) {
             throw new Error("This version has already been released!", version);
           }
 
@@ -243,24 +236,11 @@ jobs:
           ./COMMIT-ID
           ./SHA256.sum
 
-  trigger-tests:
-    needs: [build-uberjar-for-release]
-    permissions:
-      actions: write
-    runs-on: ubuntu-22.04
-    timeout-minutes: 5
-    steps:
-      - name: trigger pre-release testing
-        uses: actions/github-script@v7
-        with:
-          script: | # js
-            github.rest.actions.createWorkflowDispatch({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              workflow_id: 'pre-release.yml',
-              ref: '${{ github.ref }}',
-              inputs: {
-                commit: '${{ inputs.commit }}',
-                version: '${{ inputs.version }}',
-              }
-            });
+  run-pre-release-tests:
+    name: Run pre-release tests for ${{ inputs.version }}
+    needs: build-uberjar-for-release
+    uses: ./.github/workflows/pre-release.yml
+    secrets: inherit
+    with:
+      commit: ${{ inputs.commit }}
+      version: ${{ inputs.version }}

.github/workflows/check-milestone.yml

@@ -1,16 +1,24 @@
 name: Automatically set milestone
-run-name: Set milestone for ${{ github.event.head_commit.message }}
+run-name: Set milestone for ${{ github.event.head_commit.message || inputs.version }}
 
 on:
   push:
     branches:
       - release-x.**
+  workflow_dispatch:
+    inputs:
+      version:
+        description: 'Major version number  (e.g. 52, 78, 109)'
+        type: number
+        required: true
 
 jobs:
   set-milestone:
     name: Automatically set milestone
     runs-on: ubuntu-22.04
-    timeout-minutes: 5
+    timeout-minutes: 30
+    env:
+      isNewReleaseBranch: ${{ github.event_name == 'workflow_dispatch' }}
     permissions:
       pull-requests: write
       issues: write
@@ -19,10 +27,13 @@ jobs:
       - uses: actions/checkout@v4
         with:
           sparse-checkout: release
+          fetch-depth: ${{ env.isNewReleaseBranch == 'false' && 3 || 0 }} # we need the full history to get all the commit messages
           ref: master # we want the logic from master, even though we're triggering on a release branch
       - name: Prepare build scripts
         run: cd ${{ github.workspace }}/release && yarn && yarn build
       - uses: actions/github-script@v7
+        if: ${{ env.isNewReleaseBranch == 'false' }}
+        name: Set milestone for single commit
         with:
           script: | # js
             const { setMilestoneForCommits } = require('${{ github.workspace }}/release/dist/index.cjs');
@@ -39,3 +50,36 @@ jobs:
               branchName,
               commitMessages: [commitMessage],
             });
+      - name: Get commit messages for release branch
+        if: ${{ env.isNewReleaseBranch == 'true' }}
+        run: |
+          npm i -g tsx
+          tsx release/src/release-branch-commits.ts ${{ inputs.version }} > commit-messages.json
+      - uses: actions/github-script@v7
+        if: ${{ env.isNewReleaseBranch == 'true' }}
+        name: Set milestones for new release branch
+        env:
+          # this token has a higher rate limit than the default token, and
+          # we will need it for this workflow to work
+          GITHUB_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
+        with:
+          script: | # js
+            const { setMilestoneForCommits } = require('${{ github.workspace }}/release/dist/index.cjs');
+            const commitMessages = require('${{ github.workspace }}/commit-messages.json');
+
+            const owner = context.repo.owner;
+            const repo = context.repo.repo;
+
+            const versionNumber = context.payload.inputs.version;
+            const branchName = `release-x.${versionNumber}.x`;
+
+            console.log(`Found ${commitMessages.length} new commits for ${branchName}`);
+
+            await setMilestoneForCommits({
+              github,
+              owner,
+              repo,
+              branchName,
+              commitMessages: commitMessages,
+              ignoreExistingMilestones: true,
+            });

.github/workflows/chromatic.yml

@@ -43,6 +43,8 @@ jobs:
         uses: ./.github/actions/prepare-backend
         with:
           m2-cache-key: "cljs"
+      - name: Compile CLJS
+        run: NODE_ENV=development yarn build-pure:cljs
       - name: Publish to Chromatic
         uses: chromaui/action@v10.2.0
         env:

.github/workflows/codenotify.yml

@@ -1,22 +0,0 @@
-name: Codenotify
-
-on:
-  pull_request:
-    types: [opened, synchronize, ready_for_review]
-    # We're currently notifying developers only for frontend source changes.
-    # Update this glob if that ever changes and we start including backend source code changes.
-    paths:
-      - 'frontend/src/metabase/**'
-      - 'enterprise/frontend/src/metabase-enterprise/**'
-
-jobs:
-  codenotify:
-    runs-on: ubuntu-22.04
-    name: Codenotify
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.pull_request.head.sha }}
-      - uses: sourcegraph/codenotify@v0.6.4
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/conventional-commit-pr-title-reminder.yml

@@ -35,23 +35,8 @@ jobs:
 
       - name: Remind PR authors to use conventional commit in the title
         if: ${{ steps.is-conventional-commit.outputs.result != 'true' }}
-        run: |
-          comment='@${{ github.event.pull_request.user.login }} You have modified embedding SDK code. Please make sure the PR title follows [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) style.
-
-          Here are all the supported types that will be shown in the changelog:
-          - `feat`
-          - `fix`
-          - `perf`
-
-          These types `docs`, `style`, `refactor`, `test`, `build`, and `ci` are also encouraged for non-changelog related tasks.
-
-          Please also make sure to include `sdk` scope, otherwise, the changelog will not include this task.
-
-          For example, these are valid PR titles:
-          - `feat(sdk): Add interactive dashboard component`
-          - `feat(sdk): Support theming pie chart`
-          - `fix(sdk): Fix static dashboard crash`'
-
-          gh pr comment -b "$comment" --edit-last || gh pr comment -b "$comment"
-        env:
-          GH_TOKEN: ${{ github.token }}
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const { updateComment } = require(".github/scripts/conventional-commit-pr-title-reminder/utils.js")
+            await updateComment({github, context})

.github/workflows/cross-branch-migrations.yml

@@ -0,0 +1,162 @@
+name: Cross-branch migration tests
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
+    paths:
+      - "resources/migrations/**"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  migrations-h2-ee:
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    env:
+      CI: 'true'
+      MB_DB_TYPE: h2
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/cross-branch-migration-test
+        with:
+          base-ref: ${{ github.base_ref }}
+
+  migrations-postgres-12-ee:
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    env:
+      CI: 'true'
+      MB_DB_TYPE: postgres
+      MB_DB_PORT: 5432
+      MB_DB_HOST: localhost
+      MB_DB_DBNAME: circle_test
+      MB_DB_USER: circle_test
+    services:
+      postgres:
+        image: postgres:12-alpine
+        ports:
+          - "5432:5432"
+        env:
+          POSTGRES_USER: circle_test
+          POSTGRES_DB: circle_test
+          POSTGRES_HOST_AUTH_METHOD: trust
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/cross-branch-migration-test
+        with:
+          base-ref: ${{ github.base_ref }}
+
+  migrations-postgres-latest-ee:
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    env:
+      CI: 'true'
+      MB_DB_TYPE: postgres
+      MB_DB_PORT: 5432
+      MB_DB_HOST: localhost
+      MB_DB_DBNAME: circle_test
+      MB_DB_USER: circle_test
+    services:
+      postgres:
+        image: circleci/postgres:latest
+        ports:
+          - "5432:5432"
+        env:
+          POSTGRES_USER: circle_test
+          POSTGRES_DB: circle_test
+          POSTGRES_HOST_AUTH_METHOD: trust
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/cross-branch-migration-test
+        with:
+          base-ref: ${{ github.base_ref }}
+
+  migrations-mysql-8-0-ee:
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    env:
+      CI: 'true'
+      MB_DB_TYPE: mysql
+      MB_DB_HOST: localhost
+      MB_DB_PORT: 3306
+      MB_DB_DBNAME: circle_test
+      MB_DB_USER: root
+    services:
+      mysql:
+        image: cimg/mysql:8.0
+        ports:
+          - "3306:3306"
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/cross-branch-migration-test
+        with:
+          base-ref: ${{ github.base_ref }}
+
+  migrations-mysql-latest-ee:
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    env:
+      CI: 'true'
+      MB_DB_TYPE: mysql
+      MB_DB_HOST: localhost
+      MB_DB_PORT: 3306
+      MB_DB_DBNAME: circle_test
+      MB_DB_USER: root
+      MB_MYSQL_TEST_USER: root
+    services:
+      mysql:
+        image: mysql:latest
+        env:
+          MYSQL_ALLOW_EMPTY_PASSWORD: true
+          MYSQL_DATABASE: circle_test
+        ports:
+          - "3306:3306"
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/cross-branch-migration-test
+        with:
+          base-ref: ${{ github.base_ref }}
+
+  migrations-mariadb-10-2-ee:
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    env:
+      CI: 'true'
+      MB_DB_TYPE: mysql
+      MB_DB_HOST: localhost
+      MB_DB_PORT: 3306
+      MB_DB_DBNAME: circle_test
+      MB_DB_USER: root
+    services:
+      mariadb:
+        image: circleci/mariadb:10.2.23
+        ports:
+          - "3306:3306"
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/cross-branch-migration-test
+        with:
+          base-ref: ${{ github.base_ref }}
+
+  migrations-mariadb-latest-ee:
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    env:
+      CI: 'true'
+      MB_DB_TYPE: mysql
+      MB_DB_HOST: localhost
+      MB_DB_PORT: 3306
+      MB_DB_DBNAME: circle_test
+      MB_DB_USER: root
+    services:
+      mariadb:
+        image: circleci/mariadb:latest
+        ports:
+          - "3306:3306"
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/cross-branch-migration-test
+        with:
+          base-ref: ${{ github.base_ref }}

.github/workflows/doc-md-links.yml

@@ -1,18 +0,0 @@
-name: Lint doc Markdown links
-
-on:
-  push:
-    paths:
-      - docs/**
-  pull_request:
-    paths:
-      - docs/**
-jobs:
-  markdown-link-check:
-    runs-on: ubuntu-22.04
-    steps:
-      - uses: actions/checkout@v4
-      - name: Prepare front-end environment
-        uses: ./.github/actions/prepare-frontend
-      - name: Lint doc links
-        run: yarn run docs-lint-links

.github/workflows/e2e-component-tests-embedding-sdk-cross-version.yml

@@ -0,0 +1,254 @@
+name: E2E Cross-version Component Tests for Embedding SDK
+
+on:
+  push:
+    branches:
+      - "release-**"
+  pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
+    branches:
+      - "release-**"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  files-changed:
+    name: Check which files changed
+    runs-on: ubuntu-22.04
+    timeout-minutes: 3
+    outputs:
+      e2e_all: ${{ steps.changes.outputs.e2e_all }}
+    steps:
+      - uses: actions/checkout@v4
+      - name: Test which files changed
+        uses: dorny/paths-filter@v3.0.0
+        id: changes
+        with:
+          token: ${{ github.token }}
+          filters: .github/file-paths.yaml
+
+  # if this is a test on a release branch, we need to check the build requirements
+  get-build-requirements:
+    if: |
+      !cancelled()
+    runs-on: ubuntu-22.04
+    timeout-minutes: 10
+    outputs:
+      java_version: ${{ fromJson(steps.dependencies.outputs.result).java_version }}
+      node_version: ${{ fromJson(steps.dependencies.outputs.result).node_version }}
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          sparse-checkout: release
+      - name: Prepare build scripts
+        run: cd ${{ github.workspace }}/release && yarn && yarn build
+      - name: Get build dependencies
+        uses: actions/github-script@v7
+        id: dependencies
+        with:
+          script: | # js
+            const {
+              getBuildRequirements,
+              getVersionFromReleaseBranch,
+            } = require('${{ github.workspace }}/release/dist/index.cjs');
+            const targetBranchName = '${{ github.base_ref || github.ref }}';
+
+            const version = getVersionFromReleaseBranch(targetBranchName);
+            const requirements = getBuildRequirements(version);
+
+            return {
+              java_version: requirements.java,
+              node_version: requirements.node,
+            };
+
+  build:
+    needs: [files-changed, get-build-requirements]
+    if: |
+      !cancelled() &&
+      github.event.pull_request.draft == false
+    runs-on: ubuntu-22.04
+    timeout-minutes: 25
+    env:
+      MB_EDITION: ee
+      INTERACTIVE: false
+      # make sure that builds on release branches get licenses, because we use them for releases
+      SKIP_LICENSES: ${{ github.event_name == 'pull_request' }}
+    steps:
+      - uses: actions/checkout@v4
+      - name: Prepare front-end environment
+        uses: ./.github/actions/prepare-frontend
+        with:
+          node-version: "${{ needs.get-build-requirements.outputs.node_version }}"
+      - name: Prepare back-end environment
+        uses: ./.github/actions/prepare-backend
+        with:
+          m2-cache-key: uberjar
+          java-version: "${{ needs.get-build-requirements.outputs.java_version || 11 }}"
+
+      - name: Build uberjar with ./bin/build.sh
+        run: ./bin/build.sh
+
+      - name: Prepare uberjar artifact
+        uses: ./.github/actions/prepare-uberjar-artifact
+        with:
+          name: metabase-ee-${{ github.event.pull_request.head.sha || github.sha }}-uberjar
+
+  resolve-sdk-version:
+    if: |
+      !cancelled()
+    runs-on: ubuntu-22.04
+    timeout-minutes: 10
+    outputs:
+      sdk_version: ${{ fromJson(steps.dependencies.outputs.result).sdk_version }}
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          sparse-checkout: release
+      - name: Prepare build scripts
+        run: cd ${{ github.workspace }}/release && yarn && yarn build
+      - name: Get latest SDK release for this branch
+        uses: actions/github-script@v7
+        id: dependencies
+        with:
+          script: | # js
+            const { getSdkVersionFromReleaseBranchName } = require('${{ github.workspace }}/release/dist/index.cjs');
+            const branchName = '${{ github.base_ref || github.ref }}';
+
+            const sdk_version = await getSdkVersionFromReleaseBranchName({
+              github,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              branchName,
+            });
+
+            return {
+              sdk_version,
+            };
+
+  e2e-tests:
+    needs: [get-build-requirements, build, resolve-sdk-version]
+    if: |
+      !cancelled() && needs.build.result == 'success'
+    runs-on: ubuntu-22.04
+    timeout-minutes: 45
+    name: e2e-tests-embedding-sdk
+    env:
+      MB_EDITION: ee
+      DISPLAY: ""
+      # Any env starting with `CYPRESS_` will be available to all Cypress tests via `Cypress.env()`
+      # Example: you can get `CYPRESS_FOO` with `Cypress.env("FOO")`
+      CYPRESS_ALL_FEATURES_TOKEN: ${{ secrets.ENTERPRISE_TOKEN }}
+      CYPRESS_NO_FEATURES_TOKEN: ${{ secrets.E2E_STARTER_TOKEN }}
+      CYPRESS_PULL_REQUEST_ID: ${{ github.event.pull_request.number || '' }}
+      COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title || github.event.head_commit.message || github.event.head.sha }}
+      TZ: US/Pacific # to make node match the instance tz
+      CYPRESS_CI: true
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Prepare Docker containers
+        uses: ./.github/actions/e2e-prepare-containers
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+
+      # Needed to omit newly added tests for functionality that is not yet released
+      - name: Sparse checkout tests from SDK release commit
+        uses: actions/checkout@v4
+        with:
+          ref: embedding-sdk-${{ needs.resolve-sdk-version.outputs.sdk_version }}
+          path: sdk-release-e2e
+          sparse-checkout: e2e
+
+      - name: Move tests from the release commit into the repo
+        run: |
+          rm -rf ./e2e/support/*
+          mv ./sdk-release-e2e/e2e/support/* ./e2e/support
+
+          rm -rf ./e2e/test-component/*
+          mv ./sdk-release-e2e/e2e/test-component/* ./e2e/test-component
+        shell: bash
+
+      - name: Retrieve uberjar artifact for ee
+        uses: actions/download-artifact@v4
+        with:
+          name: metabase-ee-${{ github.event.pull_request.head.sha || github.sha }}-uberjar
+
+      - name: Prepare front-end environment
+        uses: ./.github/actions/prepare-frontend
+
+      - name: Prepare JDK ${{ needs.get-build-requirements.outputs.java_version || 11 }}
+        uses: actions/setup-java@v4
+        with:
+          java-version: ${{ needs.get-build-requirements.outputs.java_version || 11 }}
+          distribution: "temurin"
+
+      - name: Prepare Cypress environment
+        id: cypress-prep
+        uses: ./.github/actions/prepare-cypress
+
+      - name: Install Embedding SDK package v${{ needs.resolve-sdk-version.outputs.sdk_version }}
+        run: yarn add @metabase/embedding-sdk-react@${{ needs.resolve-sdk-version.outputs.sdk_version }}
+
+      - name: Run Metabase
+        run: node e2e/runner/run_cypress_ci.js start
+
+      - name: Make app db snapshot
+        run: node e2e/runner/run_cypress_ci.js snapshot --browser ${{ steps.cypress-prep.outputs.chrome-path }}
+
+      - name: Run component tests for Embedding SDK
+        run: node e2e/runner/run_cypress_ci.js component --browser ${{ steps.cypress-prep.outputs.chrome-path }}
+
+      - name: Upload Test Results
+        uses: ./.github/actions/upload-test-results
+        if: always()
+        with:
+          input-path: ./target/junit
+          output-name: e2e-embedding-sdk
+          bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
+          aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
+          aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
+          aws-region: ${{ vars.AWS_REGION }}
+          trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
+
+      - name: Upload Cypress Artifacts upon failure
+        uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: cypress-recording-embedding-sdk-cross-version
+          path: |
+            ./cypress
+            ./logs/test.log
+          if-no-files-found: ignore
+
+      - name: Publish Summary
+        if: failure()
+        uses: actions/github-script@v7
+        with:
+          script: | #js
+            const {
+               generateReport,
+               parseReport,
+               formatSummary
+             } = require("./.github/scripts/handle-mochawesome-report.js");
+
+             const report = await generateReport();
+             const results = parseReport(report);
+             const summary = formatSummary(results);
+
+             await core.summary.addRaw(summary).write();
+
+  e2e-tests-skipped-stub:
+    needs: [e2e-tests]
+    if: |
+      !cancelled() &&
+      needs.e2e-tests.result == 'skipped'
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    name: e2e-component-tests-embedding-sdk-cross-version
+    steps:
+      - run: |
+          echo "Didn't run due to conditional filtering"