hackin', yah know?

The Portal diff view wants `[before after]` pairs of the original data,
not the three-part output of `clojure.data/diff`. This fixes the
`qp.debug/debug>` output from the preprocessing middleware to emit
correct diffs.

Also, since the diffs are not useful when the query is converted between
legacy and pMBQL, this also attaches the *converted* input query to the
output query's Clojure metadata, and this converted value is used as the
basis for the diff.

.clj-kondo/config.edn

@@ -20,15 +20,144 @@
   :use                          {:level :warning}
   :warn-on-reflection           {:level :warning}
 
-  :metabase/defsetting-must-specify-export                             {:level :warning}
-  :metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests {:level :warning}
-  :metabase/mbql-query-first-arg                                       {:level :warning}
-  :metabase/missing-test-expr-requires-in-cljs                         {:level :warning}
-  :metabase/require-shape-checker                                      {:level :warning}
-  :metabase/test-helpers-use-non-thread-safe-functions                 {:level :warning}
-  :metabase/validate-deftest                                           {:level :warning}
-  :metabase/validate-logging                                           {:level :warning}
-  :metabase/warn-about-schema=                                         {:level :warning}
+  :metabase/defsetting-must-specify-export             {:level :warning}
+  :metabase/mbql-query-first-arg                       {:level :warning}
+  :metabase/missing-test-expr-requires-in-cljs         {:level :warning}
+  :metabase/require-shape-checker                      {:level :warning}
+  :metabase/test-helpers-use-non-thread-safe-functions {:level :warning}
+  :metabase/validate-logging                           {:level :warning}
+
+  :metabase/validate-deftest
+  {:level :warning
+
+   ;; calling these functions will result in an error in tests marked `^:parallel`
+   ;;
+   ;; TODO -- these should all be made thread safe if possible or renamed so they end in `!`. Then we can remove them
+   ;; from this list because by default anything ending in `!` is considered to be thread-unsafe
+   :parallel/unsafe
+   #{clojure.core/alter-var-root
+     clojure.core/with-redefs
+     clojure.core/with-redefs-fn
+     metabase.actions.test-util/with-actions
+     metabase.actions.test-util/with-actions-disabled
+     metabase.actions.test-util/with-actions-enabled
+     metabase.actions.test-util/with-actions-test-data
+     metabase.actions.test-util/with-actions-test-data-and-actions-enabled
+     metabase.actions.test-util/with-actions-test-data-tables
+     metabase.analytics.snowplow-test/with-fake-snowplow-collector
+     metabase.email-test/with-expected-messages
+     metabase.email-test/with-fake-inbox
+     metabase.test.data.users/with-group
+     metabase.test.data.users/with-group-for-user
+     metabase.test.data/with-empty-h2-app-db
+     metabase.test.util.log/with-log-level
+     metabase.test.util.misc/with-single-admin-user
+     metabase.test.util/with-all-users-permission
+     metabase.test.util/with-discarded-collections-perms-changes
+     metabase.test.util/with-env-keys-renamed-by
+     metabase.test.util/with-locale
+     metabase.test.util/with-model-cleanup
+     metabase.test.util/with-non-admin-groups-no-root-collection-for-namespace-perms
+     metabase.test.util/with-non-admin-groups-no-root-collection-perms
+     metabase.test.util/with-temp-env-var-value
+     metabase.test.util/with-temp-vals-in-db
+     metabase.test.util/with-temporary-raw-setting-values
+     metabase.test.util/with-temporary-setting-values
+     metabase.test.util/with-user-in-groups
+     metabase.test/with-actions
+     metabase.test/with-actions-disabled
+     metabase.test/with-actions-enabled
+     metabase.test/with-actions-test-data
+     metabase.test/with-actions-test-data-and-actions-enabled
+     metabase.test/with-actions-test-data-tables
+     metabase.test/with-all-users-permission
+     metabase.test/with-discarded-collections-perms-changes
+     metabase.test/with-empty-h2-app-db
+     metabase.test/with-env-keys-renamed-by
+     metabase.test/with-expected-messages
+     metabase.test/with-fake-inbox
+     metabase.test/with-group
+     metabase.test/with-group-for-user
+     metabase.test/with-locale
+     metabase.test/with-log-level
+     metabase.test/with-model-cleanup
+     metabase.test/with-non-admin-groups-no-root-collection-for-namespace-perms
+     metabase.test/with-non-admin-groups-no-root-collection-perms
+     metabase.test/with-single-admin-user
+     metabase.test/with-temp-env-var-value
+     metabase.test/with-temp-vals-in-db
+     metabase.test/with-temporary-raw-setting-values
+     metabase.test/with-temporary-setting-values
+     metabase.test/with-user-in-groups}
+
+   ;; these functions are allowed in `^:parallel` tests even tho they end in `!`
+   :parallel/safe
+   #{clojure.core/assoc!
+     clojure.core/compare-and-set!
+     clojure.core/conj!
+     clojure.core/disj!
+     clojure.core/dissoc!
+     clojure.core/persistent!
+     clojure.core/pop!
+     clojure.core/reset!
+     clojure.core/reset-vals!
+     clojure.core/run!
+     clojure.core/swap!
+     clojure.core/swap-vals!
+     clojure.core/volatile!
+     clojure.core/vreset!
+     clojure.core/vswap!
+     clojure.core.async/<!
+     clojure.core.async/<!!
+     clojure.core.async/>!
+     clojure.core.async/>!!
+     clojure.core.async/alt!
+     clojure.core.async/alt!!
+     clojure.core.async/alts!
+     clojure.core.async/alts!!
+     clojure.core.async/close!
+     clojure.core.async/ioc-alts!
+     clojure.core.async/offer!
+     clojure.core.async/onto-chan!
+     clojure.core.async/onto-chan!!
+     clojure.core.async/poll!
+     clojure.core.async/put!
+     clojure.core.async/take!
+     clojure.core.async/to-chan!
+     clojure.core.async/to-chan!!
+     metabase.channel.core/send!
+     metabase.driver.sql-jdbc.execute/execute-prepared-statement!
+     metabase.pulse/send-pulse!
+     metabase.query-processor.store/store-database!
+     next.jdbc/execute!}}
+
+  :metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests
+  {:level      :warning
+   :max-length 180}
+
+  ;; this is not enabled here, it is enabled below only for specific namespaces.
+  :metabase/disallow-hardcoded-driver-names-in-tests
+  ;; don't include `:h2` since that will probably lead to a mountain of tests where we are specifically testing
+  ;; middleware or compilation behavior with just H2 since it's the default.
+  {:drivers #{ ;; core drivers
+              #_:h2
+              :postgres
+              :mysql
+              ;; module drivers
+              :athena
+              :bigquery-cloud-sdk
+              :druid
+              :druid-jdbc
+              :googleanalytics
+              :mongo
+              :oracle
+              :presto-jdbc
+              :redshift
+              :snowflake
+              :sparksql
+              :sqlite
+              :sqlserver
+              :vertica}}
 
   ;;
   ;; disabled linters
@@ -152,7 +281,7 @@
     metabase.analytics             #{metabase.analytics.prometheus
                                      metabase.analytics.snowplow
                                      metabase.analytics.stats
-                                     metabase.analytics.sdk}                                      ; TODO -- consolidate these into a real API namespace.
+                                     metabase.analytics.sdk}                                        ; TODO -- consolidate these into a real API namespace.
     metabase.analyze               #{metabase.analyze}
     metabase.api                   #{metabase.api.common
                                      metabase.api.dataset
@@ -320,11 +449,11 @@
    ;; this is mostly intended for excluding test namespaces or those rare 'glue' namespaces that glue multiple modules
    ;; together, e.g. `metabase.lib.metadata.jvm`.
    :ignored-namespace-patterns
-   #{"-test$"                           ; anything ending in `-test`
-     "test[-.]util"                     ; anything that contains `test.util` or `test-util`
-     "test\\.impl"                      ; anything that contains `test.impl`
-     "^metabase\\.test"                 ; anything starting with `metabase.test`
-     "^metabase\\.http-client$"}}       ; `metabase.http-client` which is a test-only namespace despite its name.
+   #{"-test$"                     ; anything ending in `-test`
+     "test[-.]util"               ; anything that contains `test.util` or `test-util`
+     "test\\.impl"                ; anything that contains `test.impl`
+     "^metabase\\.test"           ; anything starting with `metabase.test`
+     "^metabase\\.http-client$"}} ; `metabase.http-client` which is a test-only namespace despite its name.
 
   :consistent-alias
   {:aliases
@@ -354,11 +483,7 @@
     hiccup.util                                                   hiccup.util
     honey.sql                                                     sql
     honey.sql.helpers                                             sql.helpers
-    honeysql.core                                                 hsql
-    honeysql.format                                               hformat
-    honeysql.helpers                                              hh
-    honeysql.types                                                htypes
-    java-time                                                     t
+    java-time.api                                                 t
     macaw.core                                                    macaw
     malli.core                                                    mc
     malli.error                                                   me
@@ -481,6 +606,7 @@
     metabase.models.collection                                    collection
     metabase.models.collection.graph                              graph
     metabase.models.collection-permission-graph-revision          c-perm-revision
+    metabase.models.channel                                       models.channel
     metabase.models.dashboard-card                                dashboard-card
     metabase.models.database                                      database
     metabase.models.dependency                                    dependency
@@ -611,114 +737,114 @@
     toucan.models                                                 models}}}
 
  :lint-as
- {cljs.cache/defcache                                                                  clojure.core/deftype
-  clojure.core.cache/defcache                                                          clojure.core/deftype
-  clojure.core.logic/defne                                                             clj-kondo.lint-as/def-catch-all
-  clojure.test.check.clojure-test/defspec                                              clojure.test/deftest
-  clojurewerkz.quartzite.jobs/defjob                                                   clojure.core/defn
-  honeysql.helpers/defhelper                                                           clj-kondo.lint-as/def-catch-all
-  honeysql.util/defalias                                                               clojure.core/def
-  metabase-enterprise.serialization.test-util/with-random-dump-dir                     clojure.core/let
-  metabase-enterprise.serialization.test-util/with-dbs                                 clojure.core/fn
-  metabase.actions.test-util/with-actions                                              clojure.core/let
-  metabase.api.common/let-404                                                          clojure.core/let
-  metabase.api.common/defroutes                                                        clojure.core/def
-  metabase.api.search-test/do-test-users                                               clojure.core/let
-  metabase.async.api-response-test/with-response                                       clojure.core/let
-  metabase.dashboard-subscription-test/with-dashboard-sub-for-card                     clojure.core/let
-  metabase.db.custom-migrations/define-migration                                       clj-kondo.lint-as/def-catch-all
-  metabase.db.custom-migrations/define-reversible-migration                            clj-kondo.lint-as/def-catch-all
-  metabase.db.data-migrations/defmigration                                             clojure.core/def
-  metabase.db.liquibase/with-liquibase                                                 clojure.core/let
-  metabase.db.schema-migrations-test.impl/with-temp-empty-app-db                       clojure.core/let
-  metabase.driver.mongo.query-processor/mongo-let                                      clojure.core/let
-  metabase.driver.mongo.connection/with-mongo-client                                   clojure.core/let
-  metabase.driver.mongo.connection/with-mongo-database                                 clojure.core/let
-  metabase.driver.sql-jdbc.actions/with-jdbc-transaction                               clojure.core/let
-  metabase.driver.sql-jdbc.connection/with-connection-spec-for-testing-connection      clojure.core/let
-  metabase.driver.sql-jdbc.execute.diagnostic/capturing-diagnostic-info                clojure.core/fn
-  metabase.integrations.ldap/with-ldap-connection                                      clojure.core/fn
-  metabase.models.collection-test/with-collection-in-location                          clojure.core/let
-  metabase.models.json-migration/def-json-migration                                    clj-kondo.lint-as/def-catch-all
-  metabase.models.setting.multi-setting/define-multi-setting                           clojure.core/def
-  metabase.models.setting/defsetting                                                   clj-kondo.lint-as/def-catch-all
-  metabase.public-settings.premium-features/defenterprise-schema                       clj-kondo.lint-as/def-catch-all
-  metabase.public-settings.premium-features/define-premium-feature                     clojure.core/def
-  metabase.pulse-test/with-pulse-for-card                                              clojure.core/let
-  metabase.query-processor.error-type/deferror                                         clojure.core/def
-  metabase.query-processor.setup/with-qp-setup                                         clojure.core/let
-  metabase.query-processor.middleware.cache.impl/with-reducible-deserialized-results   clojure.core/let
-  metabase.query-processor.middleware.process-userland-query-test/with-query-execution clojure.core/let
-  metabase.query-processor-test.pipeline-queries-test/pmbql-query                      clojure.core/->
-  metabase.query-processor-test.pipeline-queries-test/run-pmbql-query                  clojure.core/->
-  metabase.shared.util.namespaces/import-fns                                           potemkin/import-vars
-  metabase.sync.util/sum-for                                                           clojure.core/for
-  metabase.sync.util/with-emoji-progress-bar                                           clojure.core/let
-  metabase.test.data.interface/defdataset                                              clojure.core/def
-  metabase.test.data.interface/defdataset-edn                                          clojure.core/def
-  metabase.test/defdataset                                                             clojure.core/def
-  metabase.test/let-url                                                                clojure.core/let
-  metabase.test/with-actions                                                           clojure.core/let
-  metabase.test/with-open-channels                                                     clojure.core/let
-  metabase.test/with-single-admin-user                                                 clojure.core/fn
-  metabase.test/with-temp-dir                                                          clojure.core/let
-  metabase.test/with-temp-empty-app-db                                                 clojure.core/let
-  metabase.test/with-temp-file                                                         clojure.core/let
-  metabase.test/with-user-in-groups                                                    clojure.core/let
-  metabase.test/with-grouper-batches!                                                  clojure.core/fn
-  metabase.upload-test/with-upload-table!                                              clojure.core/let
-  metabase.util.files/with-open-path-to-resource                                       clojure.core/let
-  metabase.util.malli.defn/defn                                                        schema.core/defn
-  metabase.util.malli.defn/defn-                                                       schema.core/defn
-  metabase.util.malli.fn/fn                                                            schema.core/fn
-  metabase.util.malli/defmethod                                                        schema.core/defmethod
-  metabase.util.malli/defn                                                             schema.core/defn
-  metabase.util.malli/defn-                                                            schema.core/defn
-  metabase.util.malli/fn                                                               schema.core/fn
-  metabase.util.ssh/with-ssh-tunnel                                                    clojure.core/let
-  metabase.xrays.domain-entities.malli/defn                                            schema.core/defn
-  monger.operators/defoperator                                                         clojure.core/def
-  potemkin.types/defprotocol+                                                          clojure.core/defprotocol
-  potemkin.types/defrecord+                                                            clojure.core/defrecord
-  potemkin.types/deftype+                                                              clojure.core/deftype
-  potemkin/defprotocol+                                                                clojure.core/defprotocol
-  potemkin/defrecord+                                                                  clojure.core/defrecord
-  potemkin/deftype+                                                                    clojure.core/deftype
-  toucan.db/with-call-counting                                                         clojure.core/fn
-  toucan2.core/with-call-count                                                         clojure.core/fn}
+ {cljs.cache/defcache                                                                   clojure.core/deftype
+  clojure.core.cache/defcache                                                           clojure.core/deftype
+  clojure.core.logic/defne                                                              clj-kondo.lint-as/def-catch-all
+  clojure.test.check.clojure-test/defspec                                               clojure.test/deftest
+  clojurewerkz.quartzite.jobs/defjob                                                    clojure.core/defn
+  metabase-enterprise.serialization.test-util/with-dbs                                  clojure.core/fn
+  metabase-enterprise.serialization.test-util/with-random-dump-dir                      clojure.core/let
+  metabase.actions.test-util/with-actions                                               clojure.core/let
+  metabase.api.common/defroutes                                                         clojure.core/def
+  metabase.api.common/let-404                                                           clojure.core/let
+  metabase.api.search-test/do-test-users                                                clojure.core/let
+  metabase.async.api-response-test/with-response                                        clojure.core/let
+  metabase.dashboard-subscription-test/with-dashboard-sub-for-card                      clojure.core/let
+  metabase.channel.http-test/with-captured-http-requests                                clojure.core/fn
+  metabase.channel.http-test/with-server                                                clojure.core/let
+  metabase.db.custom-migrations/define-migration                                        clj-kondo.lint-as/def-catch-all
+  metabase.db.custom-migrations/define-reversible-migration                             clj-kondo.lint-as/def-catch-all
+  metabase.db.data-migrations/defmigration                                              clojure.core/def
+  metabase.db.liquibase/with-liquibase                                                  clojure.core/let
+  metabase.db.schema-migrations-test.impl/with-temp-empty-app-db                        clojure.core/let
+  metabase.driver.mongo.connection/with-mongo-client                                    clojure.core/let
+  metabase.driver.mongo.connection/with-mongo-database                                  clojure.core/let
+  metabase.driver.mongo.query-processor/mongo-let                                       clojure.core/let
+  metabase.driver.sql-jdbc.actions/with-jdbc-transaction                                clojure.core/let
+  metabase.driver.sql-jdbc.connection/with-connection-spec-for-testing-connection       clojure.core/let
+  metabase.driver.sql-jdbc.execute.diagnostic/capturing-diagnostic-info                 clojure.core/fn
+  metabase.integrations.ldap/with-ldap-connection                                       clojure.core/fn
+  metabase.models.collection-test/with-collection-in-location                           clojure.core/let
+  metabase.models.json-migration/def-json-migration                                     clj-kondo.lint-as/def-catch-all
+  metabase.models.setting.multi-setting/define-multi-setting                            clojure.core/def
+  metabase.models.setting/defsetting                                                    clj-kondo.lint-as/def-catch-all
+  metabase.public-settings.premium-features/defenterprise-schema                        clj-kondo.lint-as/def-catch-all
+  metabase.public-settings.premium-features/define-premium-feature                      clojure.core/def
+  metabase.pulse-test/with-pulse-for-card                                               clojure.core/let
+  metabase.query-processor-test.pipeline-queries-test/pmbql-query                       clojure.core/->
+  metabase.query-processor-test.pipeline-queries-test/run-pmbql-query                   clojure.core/->
+  metabase.query-processor.error-type/deferror                                          clojure.core/def
+  metabase.query-processor.middleware.cache.impl/with-reducible-deserialized-results    clojure.core/let
+  metabase.query-processor.middleware.process-userland-query-test/with-query-execution! clojure.core/let
+  metabase.query-processor.setup/with-qp-setup                                          clojure.core/let
+  metabase.shared.util.namespaces/import-fns                                            potemkin/import-vars
+  metabase.sync.util/sum-for                                                            clojure.core/for
+  metabase.sync.util/with-emoji-progress-bar                                            clojure.core/let
+  metabase.test.data.interface/defdataset                                               clojure.core/def
+  metabase.test.data.interface/defdataset-edn                                           clojure.core/def
+  metabase.test/defdataset                                                              clojure.core/def
+  metabase.test/let-url                                                                 clojure.core/let
+  metabase.test/with-actions                                                            clojure.core/let
+  metabase.test/with-grouper-batches!                                                   clojure.core/fn
+  metabase.test/with-open-channels                                                      clojure.core/let
+  metabase.test/with-single-admin-user                                                  clojure.core/fn
+  metabase.test/with-temp-dir                                                           clojure.core/let
+  metabase.test/with-temp-empty-app-db                                                  clojure.core/let
+  metabase.test/with-temp-file                                                          clojure.core/let
+  metabase.test/with-user-in-groups                                                     clojure.core/let
+  metabase.upload-test/with-upload-table!                                               clojure.core/let
+  metabase.util.files/with-open-path-to-resource                                        clojure.core/let
+  metabase.util.malli.defn/defn                                                         schema.core/defn
+  metabase.util.malli.defn/defn-                                                        schema.core/defn
+  metabase.util.malli.fn/fn                                                             schema.core/fn
+  metabase.util.malli/defmethod                                                         schema.core/defmethod
+  metabase.util.malli/defn                                                              schema.core/defn
+  metabase.util.malli/defn-                                                             schema.core/defn
+  metabase.util.malli/fn                                                                schema.core/fn
+  metabase.util.ssh/with-ssh-tunnel                                                     clojure.core/let
+  metabase.xrays.domain-entities.malli/defn                                             schema.core/defn
+  monger.operators/defoperator                                                          clojure.core/def
+  potemkin.types/defprotocol+                                                           clojure.core/defprotocol
+  potemkin.types/defrecord+                                                             clojure.core/defrecord
+  potemkin.types/deftype+                                                               clojure.core/deftype
+  potemkin/defprotocol+                                                                 clojure.core/defprotocol
+  potemkin/defrecord+                                                                   clojure.core/defrecord
+  potemkin/deftype+                                                                     clojure.core/deftype
+  toucan.db/with-call-counting                                                          clojure.core/fn
+  toucan2.core/with-call-count                                                          clojure.core/fn}
 
  :hooks
  {:analyze-call
-  {clojure.core/ns                                                                                                           hooks.clojure.core/lint-ns
-   cljs.test/deftest                                                                                                         hooks.clojure.test/deftest
+  {cljs.test/deftest                                                                                                         hooks.clojure.test/deftest
    cljs.test/is                                                                                                              hooks.clojure.test/is
    cljs.test/use-fixtures                                                                                                    hooks.clojure.test/use-fixtures
+   clojure.core/ns                                                                                                           hooks.clojure.core/lint-ns
    clojure.test/deftest                                                                                                      hooks.clojure.test/deftest
    clojure.test/is                                                                                                           hooks.clojure.test/is
    clojure.test/use-fixtures                                                                                                 hooks.clojure.test/use-fixtures
-   metabase-enterprise.cache.config-test/with-temp-persist-models                                                            hooks.common/with-seven-bindings
    metabase-enterprise.advanced-permissions.models.permissions.application-permissions-test/with-new-group-and-current-graph hooks.common/with-two-top-level-bindings
    metabase-enterprise.audit-app.pages-test/with-temp-objects                                                                hooks.common/with-one-binding
+   metabase-enterprise.cache.config-test/with-temp-persist-models                                                            hooks.common/with-seven-bindings
    metabase-enterprise.serialization.test-util/with-temp-dpc                                                                 hooks.toucan2.tools.with-temp/with-temp
-   metabase.analytics.prometheus-test/with-prometheus-system                                                                 hooks.common/with-two-bindings
-   metabase.api.automagic-dashboards-test/with-indexed-model                                                                 hooks.metabase.api.automagic-dashboards-test/with-indexed-model
-   metabase.api.alert-test/with-alert-in-collection                                                                          hooks.common/with-four-bindings
-   metabase.api.card-test/with-persistence-setup                                                                             hooks.common/with-one-top-level-binding
+   metabase.analytics.prometheus-test/with-prometheus-system!                                                                hooks.common/with-two-bindings
+   metabase.api.alert-test/with-alert-in-collection!                                                                         hooks.common/with-four-bindings
+   metabase.api.automagic-dashboards-test/with-indexed-model!                                                                hooks.metabase.api.automagic-dashboards-test/with-indexed-model!
+   metabase.api.card-test/with-card-param-values-fixtures                                                                    hooks.common/let-one-with-optional-value
+   metabase.api.card-test/with-persistence-setup!                                                                            hooks.common/with-one-top-level-binding
    metabase.api.card-test/with-temp-native-card!                                                                             hooks.common/with-two-bindings
    metabase.api.card-test/with-temp-native-card-with-params!                                                                 hooks.common/with-two-bindings
-   metabase.api.collection-test/with-french-user-and-personal-collection                                                     hooks.common/with-two-top-level-bindings
+   metabase.api.collection-test/with-french-user-and-personal-collection!                                                    hooks.common/with-two-top-level-bindings
    metabase.api.common/defendpoint                                                                                           hooks.metabase.api.common/defendpoint
    metabase.api.common/defendpoint-async                                                                                     hooks.metabase.api.common/defendpoint
    metabase.api.common/defendpoint-async-schema                                                                              hooks.metabase.api.common/defendpoint
    metabase.api.dashboard-test/with-chain-filter-fixtures                                                                    hooks.common/let-one-with-optional-value
    metabase.api.dashboard-test/with-simple-dashboard-with-tabs                                                               hooks.common/with-one-binding
-   metabase.api.card-test/with-card-param-values-fixtures                                                                    hooks.common/let-one-with-optional-value
    metabase.api.embed-test/do-response-formats                                                                               hooks.common/with-two-bindings
-   metabase.api.embed-test/with-chain-filter-fixtures                                                                        hooks.common/let-one-with-optional-value
+   metabase.api.embed-test/with-chain-filter-fixtures!                                                                       hooks.common/let-one-with-optional-value
    metabase.api.embed-test/with-temp-card                                                                                    hooks.common/let-one-with-optional-value
    metabase.api.embed-test/with-temp-dashcard                                                                                hooks.common/let-one-with-optional-value
-   metabase.api.persist-test/with-setup                                                                                      hooks.common/with-one-top-level-binding
-   metabase.api.public-test/with-required-param-card                                                                         hooks.common/with-one-binding
+   metabase.api.persist-test/with-setup!                                                                                     hooks.common/with-one-top-level-binding
+   metabase.api.public-test/with-required-param-card!                                                                        hooks.common/with-one-binding
    metabase.api.public-test/with-temp-public-card                                                                            hooks.common/let-one-with-optional-value
    metabase.api.public-test/with-temp-public-dashboard                                                                       hooks.common/let-one-with-optional-value
    metabase.api.public-test/with-temp-public-dashboard-and-card                                                              hooks.common/with-three-bindings
@@ -726,33 +852,34 @@
    metabase.api.search-test/with-search-items-in-root-collection                                                             hooks.common/do*
    metabase.api.user-test/with-temp-user-email                                                                               hooks.common/with-one-binding
    metabase.async.streaming-response-test/with-start-execution-chan                                                          hooks.common/with-one-binding
-   metabase.db.schema-migrations-test.impl/test-migrations                                                                   hooks.metabase.db.schema-migrations-test.impl/test-migrations
    metabase.dashboard-subscription-test/with-link-card-fixture-for-dashboard                                                 hooks.common/let-second
+   metabase.db.schema-migrations-test.impl/test-migrations                                                                   hooks.metabase.db.schema-migrations-test.impl/test-migrations
    metabase.driver.bigquery-cloud-sdk-test/calculate-bird-scarcity                                                           hooks.metabase.query-processor-test.expressions-test/calculate-bird-scarcity
    metabase.driver/register!                                                                                                 hooks.metabase.driver/register!
    metabase.legacy-mbql.schema.macros/defclause                                                                              hooks.metabase.legacy-mbql.schemas.macros/defclause
-   metabase.lib.schema.mbql-clause/define-mbql-clause                                                                        hooks.metabase.lib.schema.mbql-clause/define-mbql-clause
    metabase.lib.schema.mbql-clause/define-catn-mbql-clause                                                                   hooks.metabase.lib.schema.mbql-clause/define-mbql-clause
+   metabase.lib.schema.mbql-clause/define-mbql-clause                                                                        hooks.metabase.lib.schema.mbql-clause/define-mbql-clause
    metabase.lib.schema.mbql-clause/define-tuple-mbql-clause                                                                  hooks.metabase.lib.schema.mbql-clause/define-mbql-clause
    metabase.lib.test-util.macros/$ids                                                                                        hooks.metabase.test.data/$ids
    metabase.lib.test-util.macros/mbql-query                                                                                  hooks.metabase.test.data/mbql-query
    metabase.lib.test-util.macros/with-testing-against-standard-queries                                                       hooks.metabase.lib.test-util.macros/with-testing-against-standard-queries
-   metabase.models.collection-test/with-collection-hierarchy                                                                 hooks.common/let-one-with-optional-value
+   metabase.models.collection-test/with-collection-hierarchy!                                                                hooks.common/let-one-with-optional-value
    metabase.models.collection-test/with-personal-and-impersonal-collections                                                  hooks.common/with-two-bindings
-   metabase.models.dashboard-test/with-dash-in-collection                                                                    hooks.common/with-three-bindings
    metabase.models.dashboard-tab-test/with-dashtab-in-personal-collection                                                    hooks.common/with-one-top-level-binding
-   metabase.models.interface/define-simple-hydration-method                                                                  hooks.metabase.models.interface/define-hydration-method
+   metabase.models.dashboard-test/with-dash-in-collection!                                                                   hooks.common/with-three-bindings
    metabase.models.interface/define-batched-hydration-method                                                                 hooks.metabase.models.interface/define-hydration-method
-   metabase.models.pulse-test/with-dashboard-subscription-in-collection                                                      hooks.common/with-four-bindings
-   metabase.models.pulse-test/with-pulse-in-collection                                                                       hooks.common/with-four-bindings
+   metabase.models.interface/define-simple-hydration-method                                                                  hooks.metabase.models.interface/define-hydration-method
+   metabase.models.pulse-test/with-dashboard-subscription-in-collection!                                                     hooks.common/with-four-bindings
+   metabase.models.pulse-test/with-pulse-in-collection!                                                                      hooks.common/with-four-bindings
    metabase.models.setting.multi-setting/define-multi-setting                                                                hooks.metabase.models.setting/define-multi-setting
    metabase.models.setting/defsetting                                                                                        hooks.metabase.models.setting/defsetting
    metabase.public-settings.premium-features/defenterprise                                                                   hooks.metabase.public-settings.premium-features/defenterprise
    metabase.pulse.test-util/checkins-query-card                                                                              hooks.metabase.test.data/$ids
    metabase.query-processor-test.expressions-test/calculate-bird-scarcity                                                    hooks.metabase.query-processor-test.expressions-test/calculate-bird-scarcity
    metabase.query-processor-test.filter-test/count-with-filter-clause                                                        hooks.metabase.test.data/$ids
-   metabase.query-processor.middleware.cache-test/with-mock-cache                                                            hooks.common/with-two-bindings
+   metabase.query-processor.middleware.cache-test/with-mock-cache!                                                           hooks.common/with-two-bindings
    metabase.sample-data-test/with-temp-sample-database-db                                                                    hooks.common/with-one-binding
+   metabase.stale-test/with-stale-items                                                                                      hooks.toucan2.tools.with-temp/with-temp
    metabase.test.data.users/with-group                                                                                       hooks.common/let-one-with-optional-value
    metabase.test.data/$ids                                                                                                   hooks.metabase.test.data/$ids
    metabase.test.data/dataset                                                                                                hooks.metabase.test.data/dataset
@@ -760,7 +887,6 @@
    metabase.test.data/run-mbql-query                                                                                         hooks.metabase.test.data/mbql-query
    metabase.test.util.async/with-open-channels                                                                               hooks.common/let-with-optional-value-for-last-binding
    metabase.test.util.log/with-log-level                                                                                     hooks.common/with-ignored-first-arg
-   metabase.test.util.log/with-log-messages-for-level                                                                        hooks.common/with-ignored-first-arg
    metabase.test.util/discard-setting-changes                                                                                hooks.common/with-ignored-first-arg
    metabase.test.util/with-column-remappings                                                                                 hooks.common/with-ignored-first-arg
    metabase.test.util/with-non-admin-groups-no-root-collection-perms                                                         hooks.common/do*
@@ -771,70 +897,70 @@
    metabase.test/discard-setting-changes                                                                                     hooks.common/with-ignored-first-arg
    metabase.test/mbql-query                                                                                                  hooks.metabase.test.data/mbql-query
    metabase.test/query                                                                                                       hooks.metabase.test.data/mbql-query
-   metabase.test/test-drivers                                                                                                hooks.common/do*
    metabase.test/run-mbql-query                                                                                              hooks.metabase.test.data/mbql-query
+   metabase.test/test-drivers                                                                                                hooks.common/do*
    metabase.test/with-column-remappings                                                                                      hooks.common/with-ignored-first-arg
    metabase.test/with-group                                                                                                  hooks.common/let-one-with-optional-value
    metabase.test/with-log-level                                                                                              hooks.common/with-ignored-first-arg
-   metabase.test/with-log-messages-for-level                                                                                 hooks.common/with-ignored-first-arg
+   metabase.test/with-log-messages-for-level                                                                                 hooks.metabase.util.log.capture/with-log-messages-for-level
    metabase.test/with-non-admin-groups-no-root-collection-perms                                                              hooks.common/do*
    metabase.test/with-temp                                                                                                   hooks.toucan2.tools.with-temp/with-temp
-   metabase.stale-test/with-stale-items                                                                                      hooks.toucan2.tools.with-temp/with-temp
    metabase.test/with-temp-file                                                                                              hooks.metabase.test.util/with-temp-file
    metabase.test/with-temporary-setting-values                                                                               hooks.metabase.test.util/with-temporary-setting-values
-   metabase.util/format-color                                                                                                hooks.metabase.util/format-color
-   metabase.util.log/trace                                                                                                   hooks.metabase.util.log/info
-   metabase.util.log/tracef                                                                                                  hooks.metabase.util.log/infof
+   metabase.util.log.capture/with-log-messages-for-level                                                                     hooks.metabase.util.log.capture/with-log-messages-for-level
    metabase.util.log/debug                                                                                                   hooks.metabase.util.log/info
    metabase.util.log/debugf                                                                                                  hooks.metabase.util.log/infof
-   metabase.util.log/info                                                                                                    hooks.metabase.util.log/info
-   metabase.util.log/infof                                                                                                   hooks.metabase.util.log/infof
-   metabase.util.log/warn                                                                                                    hooks.metabase.util.log/info
-   metabase.util.log/warnf                                                                                                   hooks.metabase.util.log/infof
    metabase.util.log/error                                                                                                   hooks.metabase.util.log/info
    metabase.util.log/errorf                                                                                                  hooks.metabase.util.log/infof
    metabase.util.log/fatal                                                                                                   hooks.metabase.util.log/info
    metabase.util.log/fatalf                                                                                                  hooks.metabase.util.log/infof
-   metabase.util.malli.registry/def                                                                                          hooks.metabase.util.malli.registry/def}
+   metabase.util.log/info                                                                                                    hooks.metabase.util.log/info
+   metabase.util.log/infof                                                                                                   hooks.metabase.util.log/infof
+   metabase.util.log/trace                                                                                                   hooks.metabase.util.log/info
+   metabase.util.log/tracef                                                                                                  hooks.metabase.util.log/infof
+   metabase.util.log/warn                                                                                                    hooks.metabase.util.log/info
+   metabase.util.log/warnf                                                                                                   hooks.metabase.util.log/infof
+   metabase.util.malli.registry/def                                                                                          hooks.metabase.util.malli.registry/def
+   metabase.util/format-color                                                                                                hooks.metabase.util/format-color}
 
   :macroexpand
-  {clojurewerkz.quartzite.jobs/build                                            macros.quartz/build-job
-   clojurewerkz.quartzite.schedule.cron/schedule                                macros.quartz/schedule
-   clojurewerkz.quartzite.schedule.simple/schedule                              macros.quartz/simple-schedule
-   clojurewerkz.quartzite.triggers/build                                        macros.quartz/build-trigger
-   metabase-enterprise.sandbox.test-util/with-gtaps!                            macros.metabase-enterprise.sandbox.test-util/with-gtaps!
-   metabase-enterprise.sandbox.test-util/with-gtaps-for-user!                   macros.metabase-enterprise.sandbox.test-util/with-gtaps!
-   metabase-enterprise.serialization.test-util/with-world                       macros.metabase-enterprise.serialization.test-util/with-world
-   metabase-enterprise.test/with-gtaps!                                         macros.metabase-enterprise.sandbox.test-util/with-gtaps!
-   metabase-enterprise.test/with-gtaps-for-user!                                macros.metabase-enterprise.sandbox.test-util/with-gtaps!
-   metabase-enterprise.advanced-permissions.api.util-test/with-impersonations!  macros.metabase-enterprise.advanced-permissions.api.util-test/with-impersonations!
-   metabase-enterprise.query-reference-validation.api-test/with-test-setup      macros.metabase-enterprise.query-reference-validation.api-test/with-test-setup
-   metabase.api.card-test/with-ordered-items                                    macros.metabase.api.card-test/with-ordered-items
-   metabase.api.collection-test/with-collection-hierarchy                       macros.metabase.api.collection-test/with-collection-hierarchy
-   metabase.api.collection-test/with-some-children-of-collection                macros.metabase.api.collection-test/with-some-children-of-collection
-   metabase.api.common/define-routes                                            macros.metabase.api.common/define-routes
-   metabase.api.embed-test/with-embedding-enabled-and-temp-card-referencing     macros.metabase.api.embed-test/with-embedding-enabled-and-temp-card-referencing
-   metabase.api.embed-test/with-embedding-enabled-and-temp-dashcard-referencing macros.metabase.api.embed-test/with-embedding-enabled-and-temp-dashcard-referencing
-   metabase.api.public-test/with-sharing-enabled-and-temp-card-referencing      macros.metabase.api.public-test/with-sharing-enabled-and-temp-card-referencing
-   metabase.api.public-test/with-sharing-enabled-and-temp-dashcard-referencing  macros.metabase.api.public-test/with-sharing-enabled-and-temp-dashcard-referencing
-   metabase.lib.filter/deffilter                                                macros.metabase.lib.filter/deffilter
-   metabase.lib.common/defop                                                    macros.metabase.lib.common/defop
-   metabase.models.params.chain-filter-test/chain-filter                        macros.metabase.models.params.chain-filter-test/chain-filter
-   metabase.models.params.chain-filter-test/chain-filter-search                 macros.metabase.models.params.chain-filter-test/chain-filter
-   metabase.models.query-analysis-test/with-test-setup                          macros.metabase.models.query-analysis-test/with-test-setup
-   metabase.models.user-test/with-groups                                        macros.metabase.models.user-test/with-groups
-   metabase.query-processor.streaming/streaming-response                        macros.metabase.query-processor.streaming/streaming-response
-   metabase.related-test/with-world                                             macros.metabase.related-test/with-world
-   metabase.shared.util.namespaces/import-fn                                    macros.metabase.shared.util.namespaces/import-fn
-   metabase.task.setup.query-analysis-setup/with-test-setup!                    macros.metabase.task.setup.query-analysis-setup/with-test-setup!
-   metabase.test.data.users/with-group-for-user                                 macros.metabase.test.data.users/with-group-for-user
-   metabase.test.util/with-temp-env-var-value!                                  macros.metabase.test.util/with-temp-env-var-value!
-   metabase.test.util/with-temporary-raw-setting-values                         macros.metabase.test.util/with-temporary-raw-setting-values
-   metabase.test/with-group-for-user                                            macros.metabase.test.data.users/with-group-for-user
-   metabase.test/with-persistence-enabled                                       macros.metabase.test.persistence/with-persistence-enabled
-   metabase.test/with-temp-env-var-value!                                       macros.metabase.test.util/with-temp-env-var-value!
-   metabase.test/with-temporary-raw-setting-values                              macros.metabase.test.util/with-temporary-raw-setting-values
-   metabase.xrays.domain-entities.malli/define-getters-and-setters              macros.metabase.xrays.domain-entities.malli/define-getters-and-setters}}
+  {clojurewerkz.quartzite.jobs/build                                             macros.quartz/build-job
+   clojurewerkz.quartzite.schedule.cron/schedule                                 macros.quartz/schedule
+   clojurewerkz.quartzite.schedule.simple/schedule                               macros.quartz/simple-schedule
+   clojurewerkz.quartzite.triggers/build                                         macros.quartz/build-trigger
+   metabase-enterprise.sandbox.test-util/with-gtaps!                             macros.metabase-enterprise.sandbox.test-util/with-gtaps!
+   metabase-enterprise.sandbox.test-util/with-gtaps-for-user!                    macros.metabase-enterprise.sandbox.test-util/with-gtaps!
+   metabase-enterprise.serialization.test-util/with-world                        macros.metabase-enterprise.serialization.test-util/with-world
+   metabase-enterprise.test/with-gtaps!                                          macros.metabase-enterprise.sandbox.test-util/with-gtaps!
+   metabase-enterprise.test/with-gtaps-for-user!                                 macros.metabase-enterprise.sandbox.test-util/with-gtaps!
+   metabase-enterprise.advanced-permissions.api.util-test/with-impersonations!   macros.metabase-enterprise.advanced-permissions.api.util-test/with-impersonations!
+   metabase-enterprise.query-reference-validation.api-test/with-test-setup!      macros.metabase-enterprise.query-reference-validation.api-test/with-test-setup!
+   metabase.api.card-test/with-ordered-items                                     macros.metabase.api.card-test/with-ordered-items
+   metabase.api.collection-test/with-collection-hierarchy!                       macros.metabase.api.collection-test/with-collection-hierarchy!
+   metabase.api.collection-test/with-some-children-of-collection!                macros.metabase.api.collection-test/with-some-children-of-collection!
+   metabase.api.common/define-routes                                             macros.metabase.api.common/define-routes
+   metabase.api.embed-test/with-embedding-enabled-and-temp-card-referencing!     macros.metabase.api.embed-test/with-embedding-enabled-and-temp-card-referencing!
+   metabase.api.embed-test/with-embedding-enabled-and-temp-dashcard-referencing! macros.metabase.api.embed-test/with-embedding-enabled-and-temp-dashcard-referencing!
+   metabase.api.public-test/with-sharing-enabled-and-temp-card-referencing!      macros.metabase.api.public-test/with-sharing-enabled-and-temp-card-referencing!
+   metabase.api.public-test/with-sharing-enabled-and-temp-dashcard-referencing!  macros.metabase.api.public-test/with-sharing-enabled-and-temp-dashcard-referencing!
+   metabase.lib.filter/deffilter                                                 macros.metabase.lib.filter/deffilter
+   metabase.lib.common/defop                                                     macros.metabase.lib.common/defop
+   metabase.models.params.chain-filter-test/chain-filter                         macros.metabase.models.params.chain-filter-test/chain-filter
+   metabase.models.params.chain-filter-test/chain-filter-search                  macros.metabase.models.params.chain-filter-test/chain-filter
+   metabase.models.query-analysis-test/with-test-setup                           macros.metabase.models.query-analysis-test/with-test-setup
+   metabase.models.user-test/with-groups                                         macros.metabase.models.user-test/with-groups
+   metabase.query-processor.streaming/streaming-response                         macros.metabase.query-processor.streaming/streaming-response
+   metabase.related-test/with-world                                              macros.metabase.related-test/with-world
+   metabase.shared.util.namespaces/import-fn                                     macros.metabase.shared.util.namespaces/import-fn
+   metabase.task.setup.query-analysis-setup/with-test-setup!                     macros.metabase.task.setup.query-analysis-setup/with-test-setup!
+   metabase.test.data.users/with-group-for-user                                  macros.metabase.test.data.users/with-group-for-user
+   metabase.test.util/with-temp-env-var-value!                                   macros.metabase.test.util/with-temp-env-var-value!
+   metabase.test.util/with-temporary-raw-setting-values                          macros.metabase.test.util/with-temporary-raw-setting-values
+   metabase.test/with-group-for-user                                             macros.metabase.test.data.users/with-group-for-user
+   metabase.test/with-persistence-enabled!                                       macros.metabase.test.persistence/with-persistence-enabled!
+   metabase.test/with-temp-env-var-value!                                        macros.metabase.test.util/with-temp-env-var-value!
+   metabase.test/with-temporary-raw-setting-values                               macros.metabase.test.util/with-temporary-raw-setting-values
+   metabase.xrays.domain-entities.malli/define-getters-and-setters               macros.metabase.xrays.domain-entities.malli/define-getters-and-setters}}
 
  :config-in-comment
  {:linters {:unresolved-symbol {:level :off}}}
@@ -865,10 +991,18 @@
   ;;
   {:pattern "metabase(?:(?:(?:-enterprise\\.sandbox)?\\.query-processor\\.)|(?:\\.driver\\.)).*(?<!-test)$"
    :name    qp-and-driver-source-namespaces}
-
+  ;;
   ;; driver namespaces
+  ;;
   {:pattern "metabase\\.driver.*$"
-   :name    driver-namespaces}]
+   :name    driver-namespaces}
+  ;;
+  ;; general QP tests are ones that run across multiple drivers. Anything `metabase.query-processor*-test`,
+  ;; `metabase.driver.sql*-test` (excluding SQLServer and SQLite), or
+  ;; `metabase-enterprise.sandbox.query-processor*-test`
+  ;;
+  {:pattern "^metabase(?:((?:-enterprise\\.sandbox)?\\.query-processor)|(?:\\.driver\\.sql(?!server)(?!ite))).*-test$"
+   :name    general-qp-and-driver-test-namespaces}]
 
  :config-in-ns
  {test-namespaces
@@ -946,4 +1080,8 @@
     {medley.core/map-keys              {:message "Use clojure.core/update-keys"}
      medley.core/map-vals              {:message "Use clojure.core/update-vals"}
      metabase.db.query/query           {:message "Don't use application database directly in QP code; use QP Store/metadata provider"}
-     metabase.db.query/reducible-query {:message "Don't use application database directly in QP code; use QP Store/metadata provider"}}}}}}
+     metabase.db.query/reducible-query {:message "Don't use application database directly in QP code; use QP Store/metadata provider"}}}}
+
+  general-qp-and-driver-test-namespaces
+  {:linters
+   {:metabase/disallow-hardcoded-driver-names-in-tests {:level :warning}}}}}

.clj-kondo/macros/metabase/api/collection_test.clj

@@ -1,7 +1,7 @@
 (ns macros.metabase.api.collection-test
   (:require [macros.common]))
 
-(defmacro with-collection-hierarchy [bindings & body]
+(defmacro with-collection-hierarchy! [bindings & body]
   `(let [~(macros.common/ignore-unused 'a) nil
          ~(macros.common/ignore-unused 'b) nil
          ~(macros.common/ignore-unused 'c) nil
@@ -12,6 +12,6 @@
      ~bindings
      ~@body))
 
-(defmacro with-some-children-of-collection [collection-or-id-or-nil & body]
+(defmacro with-some-children-of-collection! [collection-or-id-or-nil & body]
   `(let [~(macros.common/ignore-unused '&ids) ~collection-or-id-or-nil]
      ~@body))

.clj-kondo/macros/metabase/api/embed_test.clj

@@ -1,11 +1,11 @@
 (ns macros.metabase.api.embed-test)
 
-(defmacro with-embedding-enabled-and-temp-card-referencing
+(defmacro with-embedding-enabled-and-temp-card-referencing!
   [table-kw field-kw [card-binding] & body]
   `(let [~card-binding [~table-kw ~field-kw]]
      ~@body))
 
-(defmacro with-embedding-enabled-and-temp-dashcard-referencing
+(defmacro with-embedding-enabled-and-temp-dashcard-referencing!
   [table-kw field-kw [dash-binding card-binding dashcard-binding] & body]
   `(let [~dash-binding             [~table-kw ~field-kw]
          ~(or card-binding '_)     nil

.clj-kondo/macros/metabase/api/public_test.clj

@@ -1,11 +1,11 @@
 (ns macros.metabase.api.public-test)
 
-(defmacro with-sharing-enabled-and-temp-card-referencing
+(defmacro with-sharing-enabled-and-temp-card-referencing!
   [table-kw field-kw [card-binding] & body]
   `(let [~card-binding [~table-kw ~field-kw]]
      ~@body))
 
-(defmacro with-sharing-enabled-and-temp-dashcard-referencing
+(defmacro with-sharing-enabled-and-temp-dashcard-referencing!
   [table-kw field-kw [dash-binding card-binding dashcard-binding] & body]
   `(let [~dash-binding             [~table-kw ~field-kw]
          ~(or card-binding '_)     nil

.clj-kondo/macros/metabase/task/setup/query_analysis_setup.clj

@@ -8,5 +8,6 @@
          ~(macros.common/ignore-unused 'c2) 2
          ~(macros.common/ignore-unused 'c3) 3
          ~(macros.common/ignore-unused 'c4) 4
-         ~(macros.common/ignore-unused 'arch) 5]
+         ~(macros.common/ignore-unused 'archived) 5
+         ~(macros.common/ignore-unused 'invalid) 6]
      ~@body))

.clj-kondo/macros/metabase/test/persistence.clj

@@ -1,5 +1,5 @@
 (ns macros.metabase.test.persistence)
 
-(defmacro with-persistence-enabled [[persist-fn-sym] & body]
+(defmacro with-persistence-enabled! [[persist-fn-sym] & body]
   `(clojure.core/let [~persist-fn-sym (fn [])]
      ~@body))

.clj-kondo/macros/metabase_enterprise/query_reference_validation/api_test.clj

@@ -1,7 +1,7 @@
 (ns macros.metabase-enterprise.query-reference-validation.api-test
   (:require [macros.common]))
 
-(defmacro with-test-setup [& body]
+(defmacro with-test-setup! [& body]
   `(let [~(macros.common/ignore-unused 'card-1) 1
          ~(macros.common/ignore-unused 'card-2) 2
          ~(macros.common/ignore-unused 'card-3) 3

.clj-kondo/src/hooks/clojure/core.clj

@@ -1,21 +1,11 @@
 (ns hooks.clojure.core
   (:require
    [clj-kondo.hooks-api :as hooks]
-   [clojure.set :as set]
-   [clojure.string :as str]))
-
-(defn- node->qualified-symbol [node]
-  (try
-   (when (hooks/token-node? node)
-     (let [sexpr (hooks/sexpr node)]
-       (when (symbol? sexpr)
-         (let [resolved (hooks/resolve {:name sexpr})]
-           (when-not (= :clj-kondo/unknown-namespace (:ns resolved))
-             (symbol (name (:ns resolved)) (name (:name resolved))))))))
-   ;; some symbols like `*count/Integer` aren't resolvable.
-   (catch Exception _
-     nil)))
+   [clojure.string :as str]
+   [hooks.common]))
 
+;;; TODO -- seems silly to maintain different blacklists and whitelists here than we use for the deftest `^:parallel`
+;;; checker... those lists live in the Clj Kondo config file
 (def ^:private symbols-allowed-in-fns-not-ending-in-an-exclamation-point
   '#{;; these toucan methods might actually set global values if it's used outside of a transaction,
      ;; but since mt/with-temp runs in a transaction, so we'll ignore them in this case.
@@ -151,7 +141,7 @@
   (str/ends-with? s "!"))
 
 (defn- non-thread-safe-form-should-end-with-exclamation*
-  [{[defn-or-defmacro form-name] :children, :as node}]
+  [{[defn-or-defmacro form-name] :children, :as node} config]
   (when-not (and (:string-value form-name)
                  (end-with-exclamation? (:string-value form-name)))
     (letfn [(walk [f form]
@@ -159,11 +149,12 @@
               (doseq [child (:children form)]
                 (walk f child)))]
       (walk (fn [form]
-              (when-let [qualified-symbol (node->qualified-symbol form)]
+              (when-let [qualified-symbol (hooks.common/node->qualified-symbol form)]
                 (when (and (not (contains? symbols-allowed-in-fns-not-ending-in-an-exclamation-point qualified-symbol))
-                           (end-with-exclamation? qualified-symbol))
+                           (or (end-with-exclamation? qualified-symbol)
+                               (contains? (get-in config [:linters :metabase/validate-deftest :parallel/unsafe]) qualified-symbol)))
                   (hooks/reg-finding! (assoc (meta form-name)
-                                             :message (format "The name of this %s should end with `!` because it contains calls to non thread safe form `%s`."
+                                             :message (format "The name of this %s should end with `!` because it contains calls to non thread safe form `%s`. [:metabase/test-helpers-use-non-thread-safe-functions]"
                                                               (:string-value defn-or-defmacro) qualified-symbol)
                                              :type :metabase/test-helpers-use-non-thread-safe-functions)))))
             node))
@@ -174,10 +165,10 @@
   A function or a macro can be defined as 'not thread safe' when their funciton name ends with a `!`.
 
   Only used in tests to identify thread-safe/non-thread-safe test helpers. See #37126"
-  [{:keys [node cljc lang]}]
+  [{:keys [node cljc lang config]}]
   (when (or (not cljc)
             (= lang :clj))
-    (non-thread-safe-form-should-end-with-exclamation* node))
+    (non-thread-safe-form-should-end-with-exclamation* node config))
   {:node node})
 
 (comment

.clj-kondo/src/hooks/clojure/test.clj

@@ -4,114 +4,7 @@
    [clojure.string :as str]
    [hooks.common]))
 
-(def ^:private disallowed-parallel-forms
-  "Things you should not be allowed to use inside parallel tests. Besides these, anything ending in `!` not whitelisted
-  in [[allowed-parallel-forms]] is not allowed."
-  '#{clojure.core/alter-var-root
-     clojure.core/with-redefs
-     clojure.core/with-redefs-fn
-     metabase-enterprise.sandbox.test-util/with-gtaps!
-     metabase-enterprise.sandbox.test-util/with-gtaps-for-user!
-     metabase-enterprise.sandbox.test-util/with-user-attributes
-     metabase-enterprise.test/with-gtaps!
-     metabase-enterprise.test/with-gtaps-for-user!
-     metabase-enterprise.test/with-user-attributes
-     metabase.actions.test-util/with-actions
-     metabase.actions.test-util/with-actions-disabled
-     metabase.actions.test-util/with-actions-enabled
-     metabase.actions.test-util/with-actions-test-data
-     metabase.actions.test-util/with-actions-test-data-and-actions-enabled
-     metabase.actions.test-util/with-actions-test-data-tables
-     metabase.analytics.snowplow-test/with-fake-snowplow-collector
-     metabase.email-test/with-expected-messages
-     metabase.email-test/with-fake-inbox
-     metabase.test.data.users/with-group
-     metabase.test.data.users/with-group-for-user
-     metabase.test.persistence/with-persistence-enabled
-     metabase.test.util.log/with-log-level
-     metabase.test.util.log/with-log-messages-for-level
-     metabase.test.util.misc/with-single-admin-user
-     metabase.test.util/with-all-users-permission
-     metabase.test.util/with-discarded-collections-perms-changes
-     metabase.test.util/with-env-keys-renamed-by
-     metabase.test.util/with-locale
-     metabase.test.util/with-non-admin-groups-no-root-collection-for-namespace-perms
-     metabase.test.util/with-non-admin-groups-no-root-collection-perms
-     metabase.test.util/with-temp-env-var-value
-     metabase.test.util/with-temp-vals-in-db
-     metabase.test.util/with-temporary-raw-setting-values
-     metabase.test.util/with-temporary-setting-values
-     metabase.test.util/with-user-in-groups
-     metabase.test/with-actions
-     metabase.test/with-actions-disabled
-     metabase.test/with-actions-enabled
-     metabase.test/with-actions-test-data
-     metabase.test/with-actions-test-data-and-actions-enabled
-     metabase.test/with-actions-test-data-tables
-     metabase.test/with-all-users-permission
-     metabase.test/with-discarded-collections-perms-changes
-     metabase.test/with-env-keys-renamed-by
-     metabase.test/with-expected-messages
-     metabase.test/with-fake-inbox
-     metabase.test/with-group
-     metabase.test/with-group-for-user
-     metabase.test/with-locale
-     metabase.test/with-log-level
-     metabase.test/with-log-messages-for-level
-     metabase.test/with-non-admin-groups-no-root-collection-for-namespace-perms
-     metabase.test/with-non-admin-groups-no-root-collection-perms
-     metabase.test/with-persistence-enabled
-     metabase.test/with-single-admin-user
-     metabase.test/with-temp-env-var-value
-     metabase.test/with-temp-vals-in-db
-     metabase.test/with-temporary-raw-setting-values
-     metabase.test/with-temporary-setting-values
-     metabase.test/with-user-in-groups})
-
-;;; TODO -- we should disallow `metabase.test/user-http-request` with any method other than `:get`
-
-(def ^:private allowed-parallel-forms
-  "These fns are destructive, but are probably fine inside ^:parallel tests because it usually means you're doing
-  something to an atom or something like that."
-  '#{clojure.core/assoc!
-     clojure.core/compare-and-set!
-     clojure.core/conj!
-     clojure.core/disj!
-     clojure.core/dissoc!
-     clojure.core/persistent!
-     clojure.core/pop!
-     clojure.core/reset!
-     clojure.core/reset-vals!
-     clojure.core/run!
-     clojure.core/swap!
-     clojure.core/swap-vals!
-     clojure.core/volatile!
-     clojure.core/vreset!
-     clojure.core/vswap!
-     clojure.core.async/<!
-     clojure.core.async/<!!
-     clojure.core.async/>!
-     clojure.core.async/>!!
-     clojure.core.async/alt!
-     clojure.core.async/alt!!
-     clojure.core.async/alts!
-     clojure.core.async/alts!!
-     clojure.core.async/close!
-     clojure.core.async/ioc-alts!
-     clojure.core.async/offer!
-     clojure.core.async/onto-chan!
-     clojure.core.async/onto-chan!!
-     clojure.core.async/poll!
-     clojure.core.async/put!
-     clojure.core.async/take!
-     clojure.core.async/to-chan!
-     clojure.core.async/to-chan!!
-     metabase.driver.sql-jdbc.execute/execute-prepared-statement!
-     metabase.pulse/send-pulse!
-     metabase.query-processor.store/store-database!
-     next.jdbc/execute!})
-
-(defn- warn-about-disallowed-parallel-forms [form]
+(defn- warn-about-disallowed-parallel-forms [form config]
   (letfn [(error! [form message]
             (hooks/reg-finding! (assoc (meta form)
                                        :message message
@@ -119,12 +12,12 @@
           (f [form]
             (when-let [qualified-symbol (hooks.common/node->qualified-symbol form)]
               (cond
-                (disallowed-parallel-forms qualified-symbol)
-                (error! form (format "%s is not allowed inside a ^:parallel test or test fixture" qualified-symbol))
+                (contains? (:parallel/unsafe config) qualified-symbol)
+                (error! form (format "%s is not allowed inside a ^:parallel test or test fixture [:metabase/validate-deftest]" qualified-symbol))
 
-                (and (not (allowed-parallel-forms qualified-symbol))
+                (and (not (contains? (:parallel/safe config) qualified-symbol))
                      (str/ends-with? (name qualified-symbol) "!"))
-                (error! form (format "destructive functions like %s are not allowed inside a ^:parallel test or test fixture. If this should be allowed, add it to the whitelist in .clj-kondo/hooks/clojure/test.clj"
+                (error! form (format "destructive functions like %s are not allowed inside a ^:parallel test or test fixture. If this should be allowed, add it to the whitelist in the Kondo config file [:metabase/validate-deftest]"
                                      qualified-symbol)))))
           (walk [form]
             (f form)
@@ -135,7 +28,7 @@
 (defn- deftest-check-parallel
   "1. Check if test is marked ^:parallel / ^:synchronized correctly
    2. Make sure disallowed forms are not used in ^:parallel tests"
-  [{[_ test-name & body] :children, :as _node}]
+  [{[_ test-name & body] :children, :as _node} config]
   (let [test-metadata     (:meta test-name)
         metadata-sexprs   (map hooks/sexpr test-metadata)
         combined-metadata (transduce
@@ -152,9 +45,9 @@
       (hooks/reg-finding! (assoc (meta test-name)
                                  :message "Test should not be marked both ^:parallel and ^:synchronized"
                                  :type :metabase/validate-deftest)))
-    ;; only when the custom `:metabase/deftest-not-marked-parallel` is enabled: complain if tests are not explicitly
-    ;; marked `^:parallel` or `^:synchronized`. This is mostly to encourage people to mark everything `^:parallel` in
-    ;; places like `metabase.lib` tests unless there is a really good reason not to.
+    ;; only when the custom `:metabase/deftest-not-marked-parallel-or-synchronized` is enabled: complain if tests are
+    ;; not explicitly marked `^:parallel` or `^:synchronized`. This is mostly to encourage people to mark everything
+    ;; `^:parallel` in places like `metabase.lib` tests unless there is a really good reason not to.
     (when-not (or parallel? synchronized?)
       (hooks/reg-finding!
        (assoc (meta test-name)
@@ -162,30 +55,65 @@
               :type :metabase/deftest-not-marked-parallel-or-synchronized)))
     (when parallel?
       (doseq [form body]
-        (warn-about-disallowed-parallel-forms form)))))
-
-(def ^:private number-of-lines-for-a-test-to-be-considered-horrifically-long
-  200)
+        (warn-about-disallowed-parallel-forms form config)))))
 
 (defn- deftest-check-not-horrifically-long
-  [node]
+  [node {:keys [max-length], :as _config}]
   (let [{:keys [row end-row]} (meta node)]
     (when (and row end-row)
       (let [num-lines (- end-row row)]
-        (when (>= num-lines number-of-lines-for-a-test-to-be-considered-horrifically-long)
+        (when (and max-length
+                   (>= num-lines max-length))
           (hooks/reg-finding! (assoc (meta node)
                                      :message (str (format "This test is horrifically long, it's %d lines! 😱 " num-lines)
                                                    "Do you really want to try to debug it if it fails? 💀 "
                                                    "Split it up into smaller tests! 🥰")
                                      :type :metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests)))))))
 
-(defn deftest [{:keys [node cljc lang]}]
+(defn- ignore? [node error-type]
+  (when-let [ignores (some-> node meta :clj-kondo/ignore hooks/sexpr)]
+    (when-let [ignores (cond
+                         (coll? ignores)    (set ignores)
+                         (keyword? ignores) #{ignores})]
+      (contains? ignores error-type))))
+
+(defn deftest-check-no-driver-keywords [node {:keys [drivers], :as _config}]
+  ;; fail fast after we see the first error, where we see one hardcoded driver name there are likely several more and we
+  ;; don't need multiple warnings for a single test.
+  (letfn [(f [node]
+            (when (and (hooks/keyword-node? node)
+                       (set? drivers)
+                       (contains? drivers (hooks/sexpr node)))
+              (hooks/reg-finding! (assoc (meta node)
+                                         :message (format "Do not hardcode driver name %s in driver tests! [:metabase/disallow-hardcoded-driver-names-in-tests]"
+                                                          (hooks/sexpr node))
+                                         :type    :metabase/disallow-hardcoded-driver-names-in-tests))
+              ::error))
+          (walk [node]
+            (cond
+              (ignore? node :metabase/disallow-hardcoded-driver-names-in-tests)
+              nil
+
+              (= (f node) ::error)
+              ::error
+
+              :else
+              (reduce
+               (fn [_acc child]
+                 (when (= (walk child) ::error)
+                   (reduced ::error)))
+               nil
+               (:children node))))]
+    (walk node)))
+
+(defn deftest [{:keys [node cljc lang config]}]
   ;; run [[deftest-check-parallel]] only once... if this is a `.cljc` file only run it for the `:clj` analysis, no point
   ;; in running it twice.
   (when (or (not cljc)
             (= lang :clj))
-    (deftest-check-parallel node))
-  (deftest-check-not-horrifically-long node)
+    (deftest-check-parallel node (get-in config [:linters :metabase/validate-deftest])))
+  (deftest-check-not-horrifically-long node (get-in config [:linters :metabase/i-like-making-cams-eyes-bleed-with-horrifically-long-tests]))
+  (deftest-check-no-driver-keywords node (get-in config [:linters :metabase/disallow-hardcoded-driver-names-in-tests]))
   {:node node})
 
 ;;; this is a hacky way to determine whether these namespaces are required in the `ns` form or not... basically `:ns`
@@ -222,20 +150,11 @@
 
               nil)))))))
 
-(defn- warn-about-schema= [{[_is assertion-node] :children, :as _is-node}]
-  (let [{[assertion-symb-node] :children} assertion-node]
-    (when (and (hooks/token-node? assertion-symb-node)
-               (= (hooks/sexpr assertion-symb-node) 'schema=))
-      (hooks/reg-finding! (assoc (meta assertion-symb-node)
-                                 :message "Use =? or malli= instead of schema="
-                                 :type :metabase/warn-about-schema=)))))
-
 (defn is [{:keys [node lang]}]
   (when (= lang :cljs)
     (warn-about-missing-test-expr-requires-in-cljs node))
-  (warn-about-schema= node)
   {:node node})
 
-(defn use-fixtures [{:keys [node]}]
-  (warn-about-disallowed-parallel-forms node)
+(defn use-fixtures [{:keys [node config]}]
+  (warn-about-disallowed-parallel-forms node config)
   {:node node})

.clj-kondo/src/hooks/common.clj

@@ -288,8 +288,8 @@
     (-> (hooks/vector-node
          [(hooks/vector-node (map :model binding-infos))
           (-> (hooks/list-node (list* (hooks/token-node `let)
-                                    (hooks/vector-node (mapcat (juxt :binding :value) binding-infos))
-                                    body))
+                                      (hooks/vector-node (mapcat (juxt :binding :value) binding-infos))
+                                      body))
               (with-meta (meta body)))])
         (with-meta (meta body)))))
 
@@ -364,11 +364,11 @@
   where the first arg should be linted and appear to be used."
   [{{[_ arg & body] :children} :node}]
   (let [node* (hooks/list-node
-                (list*
-                  (hooks/token-node 'let)
-                  (hooks/vector-node [(hooks/token-node (gensym "_"))
-                                      arg])
-                  body))]
+               (list*
+                (hooks/token-node 'let)
+                (hooks/vector-node [(hooks/token-node (gensym "_"))
+                                    arg])
+                body))]
     {:node node*}))
 
 (defn node->qualified-symbol [node]
@@ -407,3 +407,17 @@
 
   ;; should be 1
   (format-string-specifier-count "%-02d"))
+
+(defn add-lsp-ignore-unused-public-var-metadata
+  "Add
+
+    ^{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
+
+  metadata to a node to suppress LSP warnings."
+  [node]
+  (letfn [(update-ignores [existing-ignores]
+            (hooks/vector-node
+             (cons
+              (hooks/keyword-node :clojure-lsp/unused-public-var)
+              (:children existing-ignores))))]
+    (vary-meta node update :clj-kondo/ignore update-ignores)))

.clj-kondo/src/hooks/metabase/api/automagic_dashboards_test.clj

@@ -4,8 +4,8 @@
 (comment
 
   (def input (hooks/parse-string
-              "(with-indexed-model [{:keys [model model-index model-index-value]}
-                                    {:query :some-query}]
+              "(with-indexed-model! [{:keys [model model-index model-index-value]}
+                                     {:query :some-query}]
                   :foo :bar :body)"))
 
   (println (hooks/sexpr input))
@@ -13,12 +13,12 @@
   (let [f (load-file ".clj-kondo/hooks/metabase/api/automagic_dashboards_test.clj")]
     (f {:node input})))
 
-(defn with-indexed-model
+(defn with-indexed-model!
   [{node :node}]
   (let [[_macro-call binding-and-query-info & body] (:children node)
         [binding query-info] (:children binding-and-query-info)
         node* (hooks/list-node
-               [(hooks/token-node 'do-with-testing-model)
+               [(hooks/token-node 'do-with-indexed-model!)
                 query-info
                 (hooks/list-node
                  (list* (hooks/token-node 'fn)

.clj-kondo/src/hooks/metabase/api/common.clj

@@ -1,7 +1,8 @@
 (ns hooks.metabase.api.common
   (:require
    [clj-kondo.hooks-api :as api]
-   [clojure.string :as str]))
+   [clojure.string :as str]
+   [hooks.common]))
 
 (defn route-fn-name
   "route fn hook"
@@ -15,16 +16,17 @@
   [arg]
   (letfn [(update-defendpoint [node]
             (let [[_defendpoint method route & body] (:children node)]
-              (api/list-node
-               (list
-                (api/token-node 'do)
-                (api/token-node (symbol "compojure.core" (str (api/sexpr method))))
-                (-> (api/list-node
-                     (list*
-                      (api/token-node 'clojure.core/defn)
-                      (api/token-node (route-fn-name (api/sexpr method) (api/sexpr route)))
-                      body))
-                    (with-meta (meta node)))))))]
+              (-> (api/list-node
+                   (list
+                    (api/token-node 'do)
+                    (api/token-node (symbol "compojure.core" (str (api/sexpr method))))
+                    (-> (api/list-node
+                         (list*
+                          (api/token-node 'clojure.core/defn)
+                          (api/token-node (route-fn-name (api/sexpr method) (api/sexpr route)))
+                          body))
+                        (with-meta (meta node)))))
+                  hooks.common/add-lsp-ignore-unused-public-var-metadata)))]
     (update arg :node update-defendpoint)))
 
 (comment

.clj-kondo/src/hooks/metabase/models/interface.clj

@@ -1,5 +1,7 @@
 (ns hooks.metabase.models.interface
-  (:require [clj-kondo.hooks-api :as hooks]))
+  (:require
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common]))
 
 (defn define-hydration-method
   "This is used for both [[metabase.models.interface/define-simple-hydration-method]] and
@@ -14,5 +16,6 @@
                      (hooks/token-node 'defn)
                      fn-name
                      fn-tail))))
-                 (with-meta (update (meta node) :clj-kondo/ignore #(hooks/vector-node (cons :clojure-lsp/unused-public-var (:children %))))))]
+                 (with-meta (meta node))
+                 hooks.common/add-lsp-ignore-unused-public-var-metadata)]
     {:node node}))

.clj-kondo/src/hooks/metabase/models/setting.clj

@@ -181,12 +181,13 @@
         setter-node (-> (list
                          (hooks/token-node 'defn)
                          (with-meta
-                           (hooks/token-node (symbol (str (hooks/sexpr setting-name) \!)))
-                           (meta setting-name))
+                          (hooks/token-node (symbol (str (hooks/sexpr setting-name) \!)))
+                          (meta setting-name))
                          (hooks/string-node "Docstring.")
                          (hooks/vector-node [(hooks/token-node '_value-or-nil)]))
                         hooks/list-node
-                        (with-meta (update (meta node) :clj-kondo/ignore #(hooks/vector-node (cons :clojure-lsp/unused-public-var (:children %))))))]
+                        (with-meta (meta node))
+                        common/add-lsp-ignore-unused-public-var-metadata)]
 
     (when (nil? (second (drop-while (comp not #{[:k :export?]} first) options-list)))
       (when-not (contains? ignored-implicit-export? (:value setting-name))
@@ -242,14 +243,14 @@
 (comment
   (defn- defsetting* [form]
     (hooks/sexpr
-      (:node
-        (defsetting
-          {:node
-           (hooks/parse-string
-             (with-out-str
-               #_{:clj-kondo/ignore [:unresolved-namespace]}
-               (clojure.pprint/pprint
-                form)))}))))
+     (:node
+      (defsetting
+        {:node
+         (hooks/parse-string
+          (with-out-str
+            #_{:clj-kondo/ignore [:unresolved-namespace]}
+            (clojure.pprint/pprint
+             form)))}))))
 
   (defn x []
     (defsetting*

.clj-kondo/src/hooks/metabase/public_settings/premium_features.clj

@@ -1,6 +1,7 @@
 (ns hooks.metabase.public-settings.premium-features
   (:require
-   [clj-kondo.hooks-api :as hooks]))
+   [clj-kondo.hooks-api :as hooks]
+   [hooks.common]))
 
 (defn defenterprise [{node :node}]
   (let [[_defenterprise fn-name & args] (:children node)
@@ -26,7 +27,8 @@
                                  fn-name
                                  docstring))
                    fn-tail))
-                 (with-meta (update (meta node) :clj-kondo/ignore #(hooks/vector-node (cons :clojure-lsp/unused-public-var (:children %))))))))}))
+                 (with-meta (meta node))
+                 hooks.common/add-lsp-ignore-unused-public-var-metadata)))}))
 
 (comment
   (defn- defenterprise* [form]

.clj-kondo/src/hooks/metabase/util/log/capture.clj

@@ -0,0 +1,26 @@
+(ns hooks.metabase.util.log.capture
+  (:require
+   [clj-kondo.hooks-api :as api]))
+
+(defn with-log-messages-for-level [x]
+  (letfn [(update-binding [[lhs-node _rhs-node]]
+            [lhs-node (api/list-node
+                       (list
+                        (api/token-node 'clojure.core/fn)
+                        (api/vector-node [])))])
+          (update-bindings [bindings-node]
+            (-> (api/vector-node
+                 (into []
+                       (comp (partition-all 2)
+                             (mapcat update-binding))
+                       (:children bindings-node)))
+                (with-meta (meta bindings-node))))
+          (update-node [node]
+            (let [[_with-log-messages-for-level bindings & body] (:children node)]
+              (-> (api/list-node
+                   (list*
+                    (api/token-node 'clojure.core/let)
+                    (update-bindings bindings)
+                    body))
+                  (with-meta (meta node)))))]
+    (update x :node update-node)))

.clj-kondo/test/hooks/clojure/test_test.clj

@@ -0,0 +1,52 @@
+(ns hooks.clojure.test-test
+  (:require
+   [clj-kondo.hooks-api :as api]
+   [clj-kondo.impl.utils]
+   [clojure.edn :as edn]
+   [clojure.java.io :as io]
+   [clojure.test :refer :all]
+   [hooks.clojure.test]))
+
+(set! *warn-on-reflection* true)
+
+(defn- deftest-warnings
+  [form]
+  (binding [clj-kondo.impl.utils/*ctx* {:config     {:linters {:metabase/disallow-hardcoded-driver-names-in-tests {:level :warning}}}
+                                        :ignores    (atom nil)
+                                        :findings   (atom [])
+                                        :namespaces (atom {})}]
+    (hooks.clojure.test/deftest {:node   (api/parse-string form)
+                                 :config {:linters
+                                          {:metabase/disallow-hardcoded-driver-names-in-tests
+                                           {:drivers
+                                            #{:athena}}}}})
+    (mapv :message @(:findings clj-kondo.impl.utils/*ctx*))))
+
+(deftest ^:parallel disallow-hardcoded-driver-names-in-tests-test
+  (is (= []
+         (deftest-warnings
+           "(mt/test-drivers (mt/normal-drivers)
+              (do-something))")))
+  (is (= ["Do not hardcode driver name :athena in driver tests! [:metabase/disallow-hardcoded-driver-names-in-tests]"]
+         (deftest-warnings
+           "(mt/test-drivers (mt/normal-drivers)
+              (when-not (= driver/*driver* :athena)
+                (do-something)))")))
+  (testing "make sure :clj-kondo/ignore is propagated correctly"
+    (is (= []
+           (deftest-warnings
+             "(mt/test-drivers (mt/normal-drivers)
+                #_{:clj-kondo/ignore [:metabase/disallow-hardcoded-driver-names-in-tests]}
+                (when-not (= driver/*driver* :athena)
+                  (do-something)))")))))
+
+(deftest ^:parallel check-driver-keywords-test
+  (testing "Make sure we keep hooks.clojure.test/driver-keywords up to date"
+    (let [driver-keywords (-> (slurp ".clj-kondo/config.edn")
+                              edn/read-string
+                              (get-in [:linters :metabase/disallow-hardcoded-driver-names-in-tests :drivers]))]
+      (doseq [^java.io.File file (.listFiles (io/file "modules/drivers"))
+              :when (.isDirectory file)
+              :let [driver (keyword (.getName file))]]
+        (is (contains? driver-keywords driver)
+            (format "hooks.clojure.test/driver-keywords should contain %s, please add it" driver))))))

.clj-kondo/test/hooks/metabase/util/log/capture_test.clj

@@ -0,0 +1,19 @@
+(ns hooks.metabase.util.log.capture-test
+  (:require
+   [clj-kondo.hooks-api :as api]
+   [clojure.test :refer :all]
+   [hooks.metabase.util.log.capture]))
+
+(deftest ^:parallel with-log-messages-for-level-test
+  (is (= '(clojure.core/let [messages-1 (clojure.core/fn [])
+                             messages-2 (clojure.core/fn [])]
+            (concat (messages-1)
+                    (messages-2)))
+         (-> (hooks.metabase.util.log.capture/with-log-messages-for-level
+               {:node (-> '(with-log-messages-for-level [messages-1 [my.namespace :debug]
+                                                         messages-2 :info]
+                             (concat (messages-1) (messages-2)))
+                          pr-str
+                          api/parse-string)})
+             :node
+             api/sexpr))))

.cljfmt.edn

@@ -1,31 +1,339 @@
-;; https://github.com/weavejester/cljfmt/blob/master/cljfmt/resources/cljfmt/indents/clojure.clj
-{:extra-indents
- {auto-parse                                                       [[:inner 0]]
-  cond->                                                           [[:inner 0]]
-  check                                                            [[:inner 0]]
-  deferred-tru                                                     [[:inner 0]]
-  defprotocol+                                                     [[:block 1] [:inner 1]]
-  potemkin/defprotocol+                                            [[:block 1] [:inner 1]]
-  let-404                                                          [[:block 1]]
-  metabase.legacy-mbql.util/match-one                              [[:inner 0]]
-  merge-with                                                       [[:inner 0]]
-  metabase.test/dataset                                            [[:inner 0]]
-  metabase.test/formatted-rows                                     [[:inner 0]]
-  metabase.test/mbql-query                                         [[:inner 0]]
-  metabase.test/test-drivers                                       [[:inner 0]]
-  metabase.test/with-temporary-setting-values                      [[:block 1]]
-  ;; If we just treat these as functions we can ignore this, despite some files not being consistent
-  ;metabase.models.permissions/set-has-full-permissions-for-set?    [[:inner 0]]
-  ;metabase.models.permissions/set-has-full-permissions?            [[:inner 0]]
-  ;metabase.models.permissions/set-has-partial-permissions?         [[:inner 0]]
-  metabase.models.permissions/set-has-partial-permissions-for-set? [[:inner 0]]
-  publish-event!                                                   [[:block 1]]
-  metabase.query-processor.streaming/streaming-response            [[:inner 0]]
-  metabase.util/prog1                                              [[:inner 0]]
-  metabase.util/select-keys-when                                   [[:inner 0]]
-  ;; This supports a lot of existing formatting, but these are functions so the
-  ;; existing formatting is probably wrong.
-  ;toucan2.core/select                                              [[:inner 0]]
-  ;toucan2.core/update!                                             [[:inner 0]]
-  }
- :sort-ns-references? true}
+;; Cljfmt config. See https://github.com/weavejester/cljfmt#formatting-options
+{:sort-ns-references?
+ true
+
+ :function-arguments-indentation
+ :community
+
+ :parallel?
+ true
+
+ :paths
+ ["src"
+  "test"
+  "enterprise/backend"
+  "bin/build"
+  "modules/drivers"
+  #_"dev"]
+
+ ;; See https://github.com/weavejester/cljfmt/blob/master/cljfmt/resources/cljfmt/indents/clojure.clj for the default
+ ;; definitions
+ ;;
+ ;;    [[:block 0]]
+ ;;             ^ number of special args
+ ;;
+ ;; `:block` indentation means format with all arguments indented 2 spaces except for the 'special' arguments which
+ ;; normally are supposed to go on the first line. e.g. `let` gets [[:block 1]] because it has one 'special' arg.
+ ;;
+ ;;    [[:inner 0]]
+ ;;             ^ depth
+ ;;    [[:inner 2 0]]
+ ;;               ^ argument index to restrict this rule to
+ ;;
+ ;; `:inner` indentation is like `:defn` indentation. `[[:inner 0]]` (default for `defn`) means all arguments at depth
+ ;; zero get indented 2 spaces if not on the first line regardless of number of elements on the first line.
+ :extra-indents
+ {;; clojure.core stuff
+  fn*                                                                                  [[:inner 0]]
+  let*                                                                                 [[:block 1]]
+  with-meta                                                                            [[:default]]
+  ;; library stuff. Libraries that specify their own `:style/indent` specs are included in the section after this
+  ;; since it is generated automatically.
+  clojure.core.logic/fresh                                                             [[:block 1]]
+  clojure.core.logic/matcha                                                            [[:block 1]]
+  clojure.core.logic/run                                                               [[:block 2]]
+  clojure.core.match/match                                                             [[:block 1]]
+  clojure.test.check.properties/for-all                                                [[:block 1]]
+  clojure.test.check.properties/for-all*                                               [[:block 1]]
+  clojure.test.check/quick-check                                                       [[:block 1]]
+  clojure.tools.macro/macrolet                                                         [[:block 1] [:inner 2 0]]
+  clojurewerkz.quartzite.jobs/build                                                    [[:default]]
+  clojurewerkz.quartzite.jobs/with-description                                         [[:default]]
+  clojurewerkz.quartzite.jobs/with-identity                                            [[:default]]
+  clojurewerkz.quartzite.schedule.cron/schedule                                        [[:default]]
+  clojurewerkz.quartzite.schedule.cron/with-misfire-handling-instruction-do-nothing    [[:default]]
+  clojurewerkz.quartzite.triggers/build                                                [[:default]]
+  clojurewerkz.quartzite.triggers/with-description                                     [[:default]]
+  clojurewerkz.quartzite.triggers/with-identity                                        [[:default]]
+  clojurewerkz.quartzite.triggers/with-priority                                        [[:default]]
+  clojurewerkz.quartzite.triggers/with-schedule                                        [[:default]]
+  def-map-type                                                                         [[:block 2] [:inner 1]]
+  defprotocol+                                                                         [[:block 1] [:inner 1]]
+  defrecord+                                                                           [[:block 2] [:inner 1]]
+  deftype+                                                                             [[:block 2] [:inner 1]]
+  net.cgrand.macrovich/case                                                            [[:block 0]]
+  potemkin.namespaces/import-vars                                                      [[:default]]
+  potemkin.types/def-map-type                                                          [[:block 2] [:inner 1]]
+  potemkin.types/defprotocol+                                                          [[:block 1] [:inner 1]]
+  potemkin.types/defrecord+                                                            [[:block 2] [:inner 1]]
+  potemkin.types/deftype+                                                              [[:block 2] [:inner 1]]
+  potemkin/def-map-type                                                                [[:block 2] [:inner 1]]
+  potemkin/defprotocol+                                                                [[:block 1] [:inner 1]]
+  potemkin/defrecord+                                                                  [[:block 2] [:inner 1]]
+  potemkin/deftype+                                                                    [[:block 2] [:inner 1]]
+  potemkin/import-vars                                                                 [[:default]]
+  taoensso.nippy/extend-freeze                                                         [[:inner 0]]
+  taoensso.nippy/extend-thaw                                                           [[:inner 0]]
+  throttle.core/with-throttling                                                        [[:block 1]]
+  ;; the rest of the stuff in this list is generated automatically based on `:style/indent` specs
+  ;; by running [[dev.generate-cljfmt-config/specs]]... use that code to update this list
+  metabase-enterprise.advanced-permissions.api.util-test/with-impersonations!          [[:inner 0]]
+  metabase-enterprise.cache.config-test/with-temp-persist-models                       [[:block 1]]
+  metabase-enterprise.sandbox.test-util/with-gtaps!                                    [[:inner 0]]
+  metabase-enterprise.sandbox.test-util/with-gtaps-for-user!                           [[:inner 0]]
+  metabase-enterprise.sandbox.test-util/with-user-attributes                           [[:block 2]]
+  metabase-enterprise.serialization.test-util/with-dbs                                 [[:inner 0]]
+  metabase-enterprise.serialization.test-util/with-random-dump-dir                     [[:block 1]]
+  metabase-enterprise.serialization.test-util/with-world                               [[:block 0]]
+  metabase-enterprise.sso.integrations.jwt-test/with-users-with-email-deleted          [[:block 1]]
+  metabase-enterprise.test/with-gtaps!                                                 [[:inner 0]]
+  metabase-enterprise.test/with-gtaps-for-user!                                        [[:inner 0]]
+  metabase-enterprise.test/with-user-attributes                                        [[:block 2]]
+  metabase.actions-test/with-actions-test-data-and-actions-permissively-enabled        [[:block 0]]
+  metabase.actions.test-util/with-actions                                              [[:block 1]]
+  metabase.actions.test-util/with-actions-disabled                                     [[:block 0]]
+  metabase.actions.test-util/with-actions-enabled                                      [[:block 0]]
+  metabase.actions.test-util/with-actions-test-data                                    [[:inner 0]]
+  metabase.actions.test-util/with-actions-test-data-and-actions-enabled                [[:block 0]]
+  metabase.actions.test-util/with-actions-test-data-tables                             [[:block 1]]
+  metabase.actions.test-util/with-empty-db                                             [[:inner 0]]
+  metabase.actions.test-util/with-temp-test-data                                       [[:inner 0]]
+  metabase.api.alert-test/with-alert-in-collection                                     [[:block 1]]
+  metabase.api.card-test/with-cards-in-readable-collection                             [[:block 1]]
+  metabase.api.card-test/with-cards-in-writeable-collection                            [[:block 1]]
+  metabase.api.card-test/with-ordered-items                                            [[:inner 0]]
+  metabase.api.card-test/with-temp-native-card!                                        [[:block 1]]
+  metabase.api.card-test/with-temp-native-card-with-params!                            [[:block 1]]
+  metabase.api.collection-test/with-collection-hierarchy                               [[:block 1]]
+  metabase.api.collection-test/with-french-user-and-personal-collection                [[:block 2]]
+  metabase.api.collection-test/with-some-children-of-collection                        [[:block 1]]
+  metabase.api.common/check                                                            [[:default]]
+  metabase.api.common/define-routes                                                    [[:block 0]]
+  metabase.api.common/let-404                                                          [[:block 1]]
+  metabase.api.common.internal/auto-coerce                                             [[:block 1]]
+  metabase.api.common.internal/auto-parse                                              [[:block 1]]
+  metabase.api.common.internal-test/no-route-regexes                                   [[:block 0]]
+  metabase.api.embed-test/do-response-formats                                          [[:block 1]]
+  metabase.api.embed-test/with-embedding-enabled-and-new-secret-key                    [[:block 0]]
+  metabase.api.embed-test/with-embedding-enabled-and-temp-card-referencing             [[:block 3]]
+  metabase.api.embed-test/with-embedding-enabled-and-temp-dashcard-referencing         [[:block 3]]
+  metabase.api.embed-test/with-new-secret-key                                          [[:block 0]]
+  metabase.api.embed-test/with-temp-card                                               [[:block 1]]
+  metabase.api.embed-test/with-temp-dashcard                                           [[:block 1]]
+  metabase.api.preview-embed-test/with-embedding-enabled-and-new-secret-key            [[:block 0]]
+  metabase.api.preview-embed-test/with-new-secret-key                                  [[:block 0]]
+  metabase.api.public-test/with-sharing-enabled-and-temp-card-referencing              [[:block 3]]
+  metabase.api.public-test/with-sharing-enabled-and-temp-dashcard-referencing          [[:block 3]]
+  metabase.api.public-test/with-temp-public-card                                       [[:block 1]]
+  metabase.api.public-test/with-temp-public-dashboard                                  [[:block 1]]
+  metabase.api.public-test/with-temp-public-dashboard-and-card                         [[:block 1]]
+  metabase.api.search-test/do-test-users                                               [[:block 1]]
+  metabase.api.session/http-401-on-error                                               [[:block 0]]
+  metabase.async.streaming-response/streaming-response                                 [[:block 2]]
+  metabase.async.streaming-response-test/with-streaming-response-thread-pool           [[:block 0]]
+  metabase.async.streaming-response-test/with-test-driver-db!                          [[:block 0]]
+  metabase.async.util/cancelable-thread                                                [[:block 0]]
+  metabase.cmd.copy/step                                                               [[:block 1]]
+  metabase.cmd.copy/with-connection-rollback-only                                      [[:block 1]]
+  metabase.cmd.copy/with-disabled-db-constraints                                       [[:block 2]]
+  metabase.config/build-type-case                                                      [[:block 0]]
+  metabase.dashboard-subscription-test/with-link-card-fixture-for-dashboard            [[:block 2]]
+  metabase.db.liquibase/with-liquibase                                                 [[:block 1]]
+  metabase.db.liquibase/with-scope-locked                                              [[:block 1]]
+  metabase.db.schema-migrations-test.impl/test-migrations                              [[:block 2]]
+  metabase.db/with-application-db                                                      [[:inner 0]]
+  metabase.driver.bigquery-cloud-sdk.query-processor/with-temporal-type                [[:default]]
+  metabase.driver.druid.client/DELETE                                                  [[:default]]
+  metabase.driver.druid.client/GET                                                     [[:default]]
+  metabase.driver.druid.client/POST                                                    [[:default]]
+  metabase.driver.druid.query-processor-test/druid-query                               [[:block 0]]
+  metabase.driver.druid.query-processor-test/druid-query-returning-rows                [[:block 0]]
+  metabase.driver.mongo.query-processor/mongo-let                                      [[:block 1]]
+  metabase.driver.sql-jdbc.actions/with-jdbc-transaction                               [[:block 1]]
+  metabase.driver.sql-jdbc.connection/with-connection-spec-for-testing-connection      [[:block 1]]
+  metabase.driver.sql-jdbc.execute.diagnostic/capturing-diagnostic-info                [[:block 1]]
+  metabase.driver.sql.query-processor/apply-top-level-clause                           [[:default]]
+  metabase.driver/with-driver                                                          [[:block 1]]
+  metabase.lib.binning/with-binning                                                    [[:default]]
+  metabase.lib.core/with-binning                                                       [[:default]]
+  metabase.lib.core/with-join-alias                                                    [[:default]]
+  metabase.lib.core/with-join-conditions                                               [[:default]]
+  metabase.lib.join/with-join-alias                                                    [[:default]]
+  metabase.lib.join/with-join-conditions                                               [[:default]]
+  metabase.lib.test-util.macros/$ids                                                   [[:inner 0]]
+  metabase.lib.test-util.macros/mbql-query                                             [[:inner 0]]
+  metabase.lib.util.match/match                                                        [[:inner 0]]
+  metabase.lib.util.match/match-one                                                    [[:inner 0]]
+  metabase.lib.util.match/replace                                                      [[:inner 0]]
+  metabase.lib.util.match/replace-in                                                   [[:inner 0]]
+  metabase.models.collection-test/with-collection-hierarchy                            [[:block 1]]
+  metabase.models.collection-test/with-current-user-perms-for-collections              [[:block 1]]
+  metabase.models.collection-test/with-personal-and-impersonal-collections             [[:block 1]]
+  metabase.models.dashboard-test/with-dash-in-collection                               [[:inner 0]]
+  metabase.models.interface/define-batched-hydration-method                            [[:inner 0]]
+  metabase.models.interface/define-simple-hydration-method                             [[:inner 0]]
+  metabase.models.params.chain-filter-test/with-clean-field-values-for-field           [[:block 1]]
+  metabase.models.params.chain-filter-test/with-fk-field-to-field-remapping            [[:block 0]]
+  metabase.models.params.chain-filter-test/with-human-readable-values-remapping        [[:block 0]]
+  metabase.models.pulse-test/with-dashboard-subscription-in-collection                 [[:block 1]]
+  metabase.models.pulse-test/with-pulse-in-collection                                  [[:inner 0]]
+  metabase.models.setting/defsetting                                                   [[:block 1]]
+  metabase.models.setting.multi-setting/define-multi-setting                           [[:inner 0]]
+  metabase.models.task-history/with-task-history                                       [[:block 1]]
+  metabase.query-processor-test.pipeline-queries-test/pmbql-query                      [[:block 1]]
+  metabase.query-processor-test.pipeline-queries-test/run-pmbql-query                  [[:block 1]]
+  metabase.query-processor.debug/debug>                                                [[:block 0]]
+  metabase.query-processor.error-type/deferror                                         [[:block 1]]
+  metabase.query-processor.middleware.cache-backend.interface/with-cached-results      [[:block 4]]
+  metabase.query-processor.middleware.process-userland-query-test/with-query-execution [[:block 1]]
+  metabase.query-processor.store/cached                                                [[:block 1]]
+  metabase.query-processor.store/with-metadata-provider                                [[:inner 0]]
+  metabase.query-processor.streaming/streaming-response                                [[:block 1]]
+  metabase.query-processor.test-util/format-rows-by                                    [[:default]]
+  metabase.sample-data-test/with-temp-sample-database-db                               [[:block 1]]
+  metabase.server.middleware.session/as-admin                                          [[:block 0]]
+  metabase.server.middleware.session/with-current-user                                 [[:inner 0]]
+  metabase.shared.util.i18n/trs                                                        [[:default]]
+  metabase.shared.util.i18n/trsn                                                       [[:default]]
+  metabase.shared.util.i18n/tru                                                        [[:default]]
+  metabase.shared.util.i18n/trun                                                       [[:default]]
+  metabase.shared.util.namespaces/import-fns                                           [[:default]]
+  metabase.sync.fetch-metadata/log-if-error                                            [[:block 1]]
+  metabase.sync.sync-metadata.fields-test/with-test-db                                 [[:block 0]]
+  metabase.sync.util/do-with-start-and-finish-debug-logging                            [[:default]]
+  metabase.sync.util/sum-for                                                           [[:block 1]]
+  metabase.sync.util/sync-operation                                                    [[:block 3]]
+  metabase.sync.util/with-db-logging-disabled                                          [[:default]]
+  metabase.sync.util/with-duplicate-ops-prevented                                      [[:default]]
+  metabase.sync.util/with-emoji-progress-bar                                           [[:block 1]]
+  metabase.sync.util/with-error-handling                                               [[:block 1]]
+  metabase.sync.util/with-start-and-finish-logging                                     [[:default]]
+  metabase.sync.util/with-start-and-finish-logging*                                    [[:default]]
+  metabase.sync.util/with-sync-events                                                  [[:default]]
+  metabase.test/$ids                                                                   [[:inner 0]]
+  metabase.test/as-admin                                                               [[:inner 0]]
+  metabase.test/dataset                                                                [[:inner 0]]
+  metabase.test/discard-setting-changes                                                [[:block 1]]
+  metabase.test/format-rows-by                                                         [[:default]]
+  metabase.test/let-url                                                                [[:block 1]]
+  metabase.test/mbql-query                                                             [[:inner 0]]
+  metabase.test/native-query                                                           [[:block 0]]
+  metabase.test/query                                                                  [[:block 1]]
+  metabase.test/run-mbql-query                                                         [[:inner 0]]
+  metabase.test/test-driver                                                            [[:inner 0]]
+  metabase.test/test-drivers                                                           [[:inner 0]]
+  metabase.test/test-helpers-set-global-values!                                        [[:block 0]]
+  metabase.test/throw-if-called!                                                       [[:block 1]]
+  metabase.test/with-actions                                                           [[:block 1]]
+  metabase.test/with-actions-disabled                                                  [[:block 0]]
+  metabase.test/with-actions-enabled                                                   [[:block 0]]
+  metabase.test/with-actions-test-data                                                 [[:inner 0]]
+  metabase.test/with-actions-test-data-and-actions-enabled                             [[:block 0]]
+  metabase.test/with-actions-test-data-tables                                          [[:block 1]]
+  metabase.test/with-additional-premium-features                                       [[:block 1]]
+  metabase.test/with-current-user                                                      [[:inner 0]]
+  metabase.test/with-driver                                                            [[:block 1]]
+  metabase.test/with-empty-db                                                          [[:inner 0]]
+  metabase.test/with-empty-h2-app-db                                                   [[:block 0]]
+  metabase.test/with-metadata-provider                                                 [[:inner 0]]
+  metabase.test/with-premium-features                                                  [[:block 1]]
+  metabase.test/with-temp                                                              [[:inner 0]]
+  metabase.test/with-temp-copy-of-db                                                   [[:block 0]]
+  metabase.test/with-temp-scheduler                                                    [[:block 0]]
+  metabase.test/with-temp-test-data                                                    [[:inner 0]]
+  metabase.test/with-temp-vals-in-db                                                   [[:block 3]]
+  metabase.test/with-test-user                                                         [[:inner 0]]
+  metabase.test/with-user-in-groups                                                    [[:inner 0]]
+  metabase.test.data/$ids                                                              [[:inner 0]]
+  metabase.test.data/dataset                                                           [[:inner 0]]
+  metabase.test.data/mbql-query                                                        [[:inner 0]]
+  metabase.test.data/native-query                                                      [[:block 0]]
+  metabase.test.data/query                                                             [[:block 1]]
+  metabase.test.data/run-mbql-query                                                    [[:inner 0]]
+  metabase.test.data/with-empty-h2-app-db                                              [[:block 0]]
+  metabase.test.data/with-temp-copy-of-db                                              [[:block 0]]
+  metabase.test.data.datasets/test-driver                                              [[:inner 0]]
+  metabase.test.data.datasets/test-drivers                                             [[:inner 0]]
+  metabase.test.data.one-off-dbs/with-blank-db                                         [[:block 0]]
+  metabase.test.data.one-off-dbs/with-blueberries-db                                   [[:block 0]]
+  metabase.test.data.users/with-test-user                                              [[:inner 0]]
+  metabase.test.util/discard-setting-changes                                           [[:block 1]]
+  metabase.test.util/let-url                                                           [[:block 1]]
+  metabase.test.util/throw-if-called!                                                  [[:block 1]]
+  metabase.test.util/with-temp-scheduler                                               [[:block 0]]
+  metabase.test.util/with-temp-vals-in-db                                              [[:block 3]]
+  metabase.test.util/with-user-in-groups                                               [[:inner 0]]
+  metabase.test.util.public-settings/with-additional-premium-features                  [[:block 1]]
+  metabase.test.util.public-settings/with-premium-features                             [[:block 1]]
+  metabase.test.util.thread-local/test-helpers-set-global-values!                      [[:block 0]]
+  metabase.timeseries-query-processor-test.util/test-timeseries-drivers                [[:block 0]]
+  metabase.timeseries-query-processor-test/run-mbql-query                              [[:inner 0]]
+  metabase.upload-test/with-upload-table!                                              [[:inner 0]]
+  metabase.upload.types/with-currency                                                  [[:default]]
+  metabase.upload.types/with-parens                                                    [[:default]]
+  metabase.util/auto-retry                                                             [[:block 1]]
+  metabase.util/ignore-exceptions                                                      [[:block 0]]
+  metabase.util/or-with                                                                [[:block 1]]
+  metabase.util/profile                                                                [[:block 1]]
+  metabase.util/prog1                                                                  [[:inner 0]]
+  metabase.util/varargs                                                                [[:inner 0]]
+  metabase.util/with-us-locale                                                         [[:block 0]]
+  metabase.util.date-2/with-time-zone-same-instant                                     [[:default]]
+  metabase.util.encryption-test/with-secret-key                                        [[:block 1]]
+  metabase.util.honey-sql-2/with-database-type-info                                    [[:default]]
+  metabase.util.i18n/deferred-trs                                                      [[:default]]
+  metabase.util.i18n/deferred-tru                                                      [[:default]]
+  metabase.util.i18n/trs                                                               [[:default]]
+  metabase.util.i18n/tru                                                               [[:default]]
+  metabase.util.jvm/auto-retry                                                         [[:block 1]]
+  metabase.util.jvm/varargs                                                            [[:block 1]]
+  metabase.util.jvm/with-us-locale                                                     [[:block 0]]
+  metabase.util.malli/disable-enforcement                                              [[:block 0]]
+  metabase.util.malli/with                                                             [[:default]]
+  metabase.util.malli/with-api-error-message                                           [[:default]]
+  metabuild-common.core/exit-when-finished-nonzero-on-exception                        [[:block 0]]
+  metabuild-common.core/step                                                           [[:block 1]]
+  metabuild-common.entrypoint/exit-when-finished-nonzero-on-exception                  [[:block 0]]
+  metabuild-common.steps/step                                                          [[:block 1]]
+  methodical.core/defmethod                                                            [[:inner 0]]
+  methodical.core/defmulti                                                             [[:inner 0]]
+  methodical.core/with-dispatcher                                                      [[:default]]
+  methodical.core/with-method-table                                                    [[:default]]
+  methodical.core/with-prefers                                                         [[:default]]
+  methodical.interface/with-dispatcher                                                 [[:default]]
+  methodical.interface/with-method-table                                               [[:default]]
+  methodical.interface/with-prefers                                                    [[:default]]
+  methodical.macros/defmethod                                                          [[:inner 0]]
+  methodical.macros/defmulti                                                           [[:inner 0]]
+  saml20-clj.sp.response/validate-confirmation-datas                                   [[:block 1]]
+  toucan2.connection/with-transaction                                                  [[:block 1]]
+  toucan2.core/build                                                                   [[:block 0]]
+  toucan2.core/compile                                                                 [[:block 0]]
+  toucan2.core/debug                                                                   [[:block 0]]
+  toucan2.core/define-after-insert                                                     [[:inner 0]]
+  toucan2.core/define-after-select                                                     [[:inner 0]]
+  toucan2.core/define-after-update                                                     [[:inner 0]]
+  toucan2.core/define-before-delete                                                    [[:inner 0]]
+  toucan2.core/define-before-insert                                                    [[:inner 0]]
+  toucan2.core/define-before-select                                                    [[:inner 0]]
+  toucan2.core/define-default-fields                                                   [[:inner 0]]
+  toucan2.core/define-named-query                                                      [[:block 1]]
+  toucan2.core/deftransforms                                                           [[:block 1]]
+  toucan2.core/with-transaction                                                        [[:block 1]]
+  toucan2.tools.after/define-after-impl                                                [[:default]]
+  toucan2.tools.after-insert/define-after-insert                                       [[:inner 0]]
+  toucan2.tools.after-select/define-after-select                                       [[:inner 0]]
+  toucan2.tools.after-update/define-after-update                                       [[:inner 0]]
+  toucan2.tools.before-delete/define-before-delete                                     [[:inner 0]]
+  toucan2.tools.before-insert/define-before-insert                                     [[:inner 0]]
+  toucan2.tools.before-select/define-before-select                                     [[:inner 0]]
+  toucan2.tools.compile/build                                                          [[:block 0]]
+  toucan2.tools.compile/compile                                                        [[:block 0]]
+  toucan2.tools.compile/resolved                                                       [[:block 0]]
+  toucan2.tools.debug/debug                                                            [[:block 0]]
+  toucan2.tools.default-fields/define-default-fields                                   [[:inner 0]]
+  toucan2.tools.named-query/define-named-query                                         [[:block 1]]
+  toucan2.tools.simple-out-transform/define-out-transform                              [[:inner 0]]
+  toucan2.tools.transformed/deftransforms                                              [[:block 1]]
+  toucan2.tools.with-temp/with-temp                                                    [[:inner 0]]
+  toucan2.util/try-with-error-context                                                  [[:inner 0]]}}

.dir-locals.el

@@ -20,68 +20,67 @@
  (clojure-mode
   ;; Specify which arg is the docstring for certain macros
   ;; (Add more as needed)
-  (eval . (put 'defendpoint-schema 'clojure-doc-string-elt 3))
-  (eval . (put 'defendpoint 'clojure-doc-string-elt 3))
-  (eval . (put 'defendpoint-async 'clojure-doc-string-elt 3))
-  (eval . (put 'define-premium-feature 'clojure-doc-string-elt 2))
-  (eval . (put 'api/defendpoint-schema 'clojure-doc-string-elt 3))
-  (eval . (put 'api/defendpoint 'clojure-doc-string-elt 3))
-  (eval . (put 'api/defendpoint-async 'clojure-doc-string-elt 3))
-  (eval . (put 'defsetting 'clojure-doc-string-elt 2))
-  (eval . (put 'setting/defsetting 'clojure-doc-string-elt 2))
-  (eval . (put 's/defn 'clojure-doc-string-elt 2))
-  (eval . (put 'p.types/defprotocol+ 'clojure-doc-string-elt 2))
-  (eval . (put 'methodical/defmethod 'clojure-doc-string-elt 3))
-  (eval . (put 'methodical/defmulti 'clojure-doc-string-elt 2))
-  (eval . (put 'mi/define-simple-hydration-method 'clojure-doc-string-elt 3))
+  (eval . (put 'defendpoint-schema                 'clojure-doc-string-elt 3))
+  (eval . (put 'defendpoint                        'clojure-doc-string-elt 3))
+  (eval . (put 'defendpoint-async                  'clojure-doc-string-elt 3))
+  (eval . (put 'define-premium-feature             'clojure-doc-string-elt 2))
+  (eval . (put 'api/defendpoint-schema             'clojure-doc-string-elt 3))
+  (eval . (put 'api/defendpoint                    'clojure-doc-string-elt 3))
+  (eval . (put 'api/defendpoint-async              'clojure-doc-string-elt 3))
+  (eval . (put 'defsetting                         'clojure-doc-string-elt 2))
+  (eval . (put 'setting/defsetting                 'clojure-doc-string-elt 2))
+  (eval . (put 's/defn                             'clojure-doc-string-elt 2))
+  (eval . (put 'p.types/defprotocol+               'clojure-doc-string-elt 2))
+  (eval . (put 'methodical/defmethod               'clojure-doc-string-elt 3))
+  (eval . (put 'methodical/defmulti                'clojure-doc-string-elt 2))
+  (eval . (put 'mi/define-simple-hydration-method  'clojure-doc-string-elt 3))
   (eval . (put 'mi/define-batched-hydration-method 'clojure-doc-string-elt 3))
-  (eval . (put 'mr/def 'clojure-doc-string-elt 2))
-  (eval . (put 'mu/defn 'clojure-doc-string-elt 2))
+  (eval . (put 'mr/def                             'clojure-doc-string-elt 2))
+  (eval . (put 'mu/defn                            'clojure-doc-string-elt 2))
   ;; Define custom indentation for functions inside metabase.
   ;; This list isn't complete; add more forms as we come across them.
   ;;
   ;; `put-clojure-indent' is a safe-local-eval-function, so use a bunch of calls to that
   ;; instead of one call to `define-clojure-indent'
-  (eval . (put-clojure-indent 'api/let-404 1))
-  (eval . (put-clojure-indent 'c/step 1))
-  (eval . (put-clojure-indent 'impl/test-migrations 2))
-  (eval . (put-clojure-indent 'let-404 0))
-  (eval . (put-clojure-indent 'lib.schema.match/match 1))
-  (eval . (put-clojure-indent 'lib.schema.match/match-one 1))
-  (eval . (put-clojure-indent 'lib.schema.match/replace 1))
-  (eval . (put-clojure-indent 'lib.schema.match/replace-in 2))
-  (eval . (put-clojure-indent 'lib.util.match/replace 1))
-  (eval . (put-clojure-indent 'macros/case 0))
-  (eval . (put-clojure-indent 'match 1))
-  (eval . (put-clojure-indent 'mi/define-methods '(:form)))
-  (eval . (put-clojure-indent 'mt/dataset 1))
-  (eval . (put-clojure-indent 'mt/format-rows-by 1))
-  (eval . (put-clojure-indent 'mt/query 1))
-  (eval . (put-clojure-indent 'mt/test-driver 1))
-  (eval . (put-clojure-indent 'mt/test-drivers 1))
-  (eval . (put-clojure-indent 'mt/with-anaphora 1))
-  (eval . (put-clojure-indent 'prop/for-all 1))
+  (eval . (put-clojure-indent 'api/let-404                     1))
+  (eval . (put-clojure-indent 'c/step                          1))
+  (eval . (put-clojure-indent 'impl/test-migrations            2))
+  (eval . (put-clojure-indent 'let-404                         0))
+  (eval . (put-clojure-indent 'lib.schema.match/match          '(:defn)))
+  (eval . (put-clojure-indent 'lib.schema.match/match-one      '(:defn)))
+  (eval . (put-clojure-indent 'lib.schema.match/replace        '(:defn)))
+  (eval . (put-clojure-indent 'lib.schema.match/replace-in     '(:defn)))
+  (eval . (put-clojure-indent 'lib.util.match/replace          '(:defn)))
+  (eval . (put-clojure-indent 'macros/case                     0))
+  (eval . (put-clojure-indent 'match                           1))
+  (eval . (put-clojure-indent 'mt/dataset                      1))
+  (eval . (put-clojure-indent 'mt/format-rows-by               '(:form)))
+  (eval . (put-clojure-indent 'mt/query                        1))
+  (eval . (put-clojure-indent 'mt/test-driver                  1))
+  (eval . (put-clojure-indent 'mt/test-drivers                 1))
+  (eval . (put-clojure-indent 'mt/with-anaphora                1))
+  (eval . (put-clojure-indent 'prop/for-all                    1))
   (eval . (put-clojure-indent 'qp.streaming/streaming-response 1))
-  (eval . (put-clojure-indent 'tc/quick-check 1))
-  (eval . (put-clojure-indent 'u/profile 1))
-  (eval . (put-clojure-indent 'u/prog1 1))
-  (eval . (put-clojure-indent 'u/select-keys-when 1))
-  (eval . (put-clojure-indent 'with-meta '(:form)))
+  (eval . (put-clojure-indent 'tc/quick-check                  1))
+  (eval . (put-clojure-indent 'u/profile                       1))
+  (eval . (put-clojure-indent 'u/prog1                         1))
+  (eval . (put-clojure-indent 'u/select-keys-when              '(:form)))
+  (eval . (put-clojure-indent 'with-meta                       '(:form)))
   ;; these ones have to be done with `define-clojure-indent' for now because of upstream bug
   ;; https://github.com/clojure-emacs/clojure-mode/issues/600 once that's resolved we should use `put-clojure-indent'
   ;; instead. Please don't add new entries unless they don't work with `put-clojure-indent'
   (eval . (define-clojure-indent
-           (l/matcha '(1 (:defn)))
-           (l/matche '(1 (:defn)))
+           (l/matcha                  '(1 (:defn)))
+           (l/matche                  '(1 (:defn)))
            (p.types/def-abstract-type '(1 (:defn)))
-           (p.types/defprotocol+ '(1 (:defn)))
-           (p.types/defrecord+ '(2 nil nil (:defn)))
-           (p.types/deftype+ '(2 nil nil (:defn)))
-           (p/def-map-type '(2 nil nil (:defn)))
-           (p/defprotocol+ '(1 (:defn)))
-           (p/defrecord+ '(2 nil nil (:defn)))
-           (p/deftype+ '(2 nil nil (:defn)))
-           (tools.macro/macrolet '(1 ((:defn)) :form))))
+           (p.types/defprotocol+      '(1 (:defn)))
+           (p.types/defrecord+        '(2 nil nil (:defn)))
+           (p.types/deftype+          '(2 nil nil (:defn)))
+           (p/def-map-type            '(2 nil nil (:defn)))
+           (p/defprotocol+            '(1 (:defn)))
+           (p/defrecord+              '(2 nil nil (:defn)))
+           (p/deftype+                '(2 nil nil (:defn)))
+           (tools.macro/macrolet      '(1 ((:defn)) :form))))
   (cider-clojure-cli-aliases . "dev:drivers:drivers-dev:ee:ee-dev:user")
   (clojure-indent-style . always-align)
   (cljr-favor-prefix-notation . nil)

.eslintrc.js

@@ -62,6 +62,13 @@ module.exports = {
         warnOnUnassignedImports: false,
       },
     ],
+    "sort-imports": [
+      "error",
+      {
+        // allows this rule to work with import/order
+        ignoreDeclarationSort: true,
+      },
+    ],
     "no-console": [2, { allow: ["warn", "error", "errorBuffer"] }],
     "react/no-is-mounted": 2,
     "react/prefer-es6-class": 2,
@@ -81,6 +88,7 @@ module.exports = {
       { additionalHooks: "(useSafeAsyncFunction)" },
     ],
     "prefer-const": [1, { destructuring: "all" }],
+    "no-restricted-globals": ["error", "close"],
     "no-useless-escape": 0,
     "no-only-tests/no-only-tests": [
       "error",

.github/CODEOWNERS

@@ -12,3 +12,4 @@ enterprise/backend/src/metabase_enterprise/task/truncate_audit_table.clj @noahmo
 enterprise/backend/src/metabase_enterprise/internal_user.clj @noahmoss
 src/metabase/**/*permissions* @noahmoss
 src/metabase/integrations @noahmoss
+snowplow/* @metabase/data

.github/actions/e2e-prepare-containers/action.yml

@@ -10,24 +10,23 @@ inputs:
   maildev:
     description: Maildev container
     required: true
-    default: 'false'
+    default: false
   openldap:
     description: OpenLDAP container
     required: true
-    default: 'false'
+    default: false
   postgres:
     description: Postgres container
     required: true
-    default: 'false'
+    default: false
   mysql:
     description: MySQL container
     required: true
-    default: 'false'
+    default: false
   mongo:
     description: Mongo container
     required: true
-    default: 'false'
-
+    default: false
 
 runs:
   using: "composite"
@@ -84,4 +83,11 @@ runs:
           while ! nc -z localhost 27004; do sleep 1; done &&
           echo -e "${G}Mongo is up and running!"
         fi
+
+        if ${{ inputs.webhook }}; then
+          echo -e "${Y}Starting webhook test container..." &&
+          docker run -d -p 9080:8080/tcp tarampampam/webhook-tester serve --create-session 00000000-0000-0000-0000-000000000000 &&
+          while ! nc -z localhost 9080; do sleep 1; done &&
+          echo -e "${G}Webhook tester is up and running!"
+        fi
       shell: bash

.github/actions/prepare-frontend/action.yml

@@ -43,11 +43,8 @@ runs:
       if: steps.node-modules-cache.outputs.cache-hit != 'true'
       with:
         path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-        # if global cache is used, we don't care if it's the latest or not
-        # current github actions settings will invalidate saved cache after
-        # a week or so, new cache will be fresh we'll not need to spend time
-        # on it's saving for a specific hash of yarn.lock
-        key: ${{ runner.os }}-yarn-
+        key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+        restore-keys: ${{ runner.os }}-yarn-
 
     - run: yarn install --frozen-lockfile --prefer-offline
       shell: bash

.github/file-paths.yaml

@@ -80,6 +80,7 @@ backend_specs: &backend_specs
   - "modules/drivers/*/test/**"
   - "test_config/**"
   - "dev/**"
+  - "test_resources/**"
 
 backend_all: &backend_all
   - *default

.github/team.json

@@ -1,16 +1,26 @@
 {
   "teams": [
     {
-      "name": "Querying Components",
-      "label": ".Team/QueryingComponents",
+      "name": "Querying",
+      "label": ".Team/Querying",
       "projectUrl": "https://github.com/orgs/metabase/projects/97/views/1",
       "members": [
         "ranquild",
         "kamilmielnik",
         "nemanjaglumac",
-        "romeovs"
+        "romeovs",
+        "bshepherdson",
+        "metamben",
+        "lbrdnk",
+        "appleby",
+        "uladzimirdev"
       ]
     },
+    {
+      "name": "Drivers",
+      "label": ".Team/Drivers",
+      "members": ["snoe"]
+    },
     {
       "name": "Embedding",
       "label": ".Team/Embedding",
@@ -24,17 +34,10 @@
       "members": [
         "tsmacdonald",
         "qnkhuat",
-        "calherries",
         "piranha",
         "crisptrutski"
       ]
     },
-    {
-      "name": "Query Processor",
-      "label": ".Team/QueryProcessor",
-      "projectUrl": "https://github.com/orgs/metabase/projects/83/views/8",
-      "members": ["camsaul", "snoe", "bshepherdson", "metamben", "lbrdnk", "appleby"]
-    },
     {
       "name": "Admin Webapp",
       "label": ".Team/AdminWebapp",
@@ -54,7 +57,6 @@
       "members": [
         "alxnddr",
         "EmmadUsmani",
-        "JesseSDevaney",
         "kulyk",
         "adam-james-v"
       ]
@@ -63,7 +65,7 @@
       "name": "DevEx",
       "label": ".Team/DevEx",
       "members": [
-        "uladzimirdev"
+        "camsaul"
       ]
     }
   ]

.github/workflows/backend.yml

@@ -12,9 +12,6 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
   cancel-in-progress: true
 
-env:
-  CLJ_KONDO_VERSION: "2023.09.07"
-
 jobs:
   files-changed:
     name: Check which files changed
@@ -70,23 +67,12 @@ jobs:
       (needs.files-changed.outputs.backend_all == 'true' || needs.static-viz-files-changed.outputs.static_viz == 'true')
     runs-on: ubuntu-22.04
     timeout-minutes: 10
-    env:
-      DOWNLOAD_URL: https://github.com/clj-kondo/clj-kondo/releases/download
     steps:
       - uses: actions/checkout@v4
       - name: Prepare back-end environment
         uses: ./.github/actions/prepare-backend
         with:
           m2-cache-key: 'kondo'
-      - name: Install clj-kondo
-        run: |
-          curl -OL ${DOWNLOAD_URL}/v${CLJ_KONDO_VERSION}/clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip
-          curl -OL ${DOWNLOAD_URL}/v${CLJ_KONDO_VERSION}/clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip.sha256
-          cat clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip.sha256 >> SHA256sum.txt
-          echo " clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip" >> SHA256sum.txt
-          sha256sum -c SHA256sum.txt
-          unzip -d /usr/local/bin clj-kondo-${CLJ_KONDO_VERSION}-linux-static-amd64.zip
-      - run: clj-kondo --version
       - name: Run clj-kondo
         run: ./bin/kondo.sh
 
@@ -268,3 +254,18 @@ jobs:
     steps:
       - run: |
           echo "Didn't run due to conditional filtering"
+
+  be-cljfmt:
+    needs: [files-changed]
+    if: |
+      !cancelled() && needs.files-changed.outputs.backend_all == 'true'
+    runs-on: ubuntu-22.04
+    timeout-minutes: 10
+    steps:
+      - uses: actions/checkout@v4
+      - name: Prepare back-end environment
+        uses: ./.github/actions/prepare-backend
+        with:
+          m2-cache-key: 'cljfmt'
+      - name: Run cljfmt
+        run: clojure -T:cljfmt check

.github/workflows/backport.yml

@@ -107,8 +107,23 @@ jobs:
             echo "PR has been merged, searching for a squashed commit in the base branch"
             echo "searching for a commit in a ${ORIGINAL_BASE_REF} that contains pull request number ${ORIGINAL_PULL_REQUEST_NUMBER}"
             SQUASHED_COMMIT=$(env -i git log ${ORIGINAL_BASE_REF} --grep="(#${ORIGINAL_PULL_REQUEST_NUMBER})" --format="%H")
-            echo "found commit ${SQUASHED_COMMIT}"
-            git cherry-pick ${SQUASHED_COMMIT}
+
+            if [ -n "${SQUASHED_COMMIT}" ]; then
+              echo "found commit ${SQUASHED_COMMIT}"
+              git cherry-pick ${SQUASHED_COMMIT}
+            else
+              echo "probably a PR wasn't merged with Squash And Merge button, searching again"
+              SQUASHED_COMMIT=$(env -i git log ${ORIGINAL_BASE_REF} --grep="#${ORIGINAL_PULL_REQUEST_NUMBER}" --format="%H")
+
+              if [ -n "${SQUASHED_COMMIT}" ]; then
+                echo "found commit ${SQUASHED_COMMIT}"
+                git cherry-pick ${SQUASHED_COMMIT}
+              else
+                echo "No squashed commit found for PR #${ORIGINAL_PULL_REQUEST_NUMBER}"
+                exit 1
+              fi
+            fi
+
           else
             echo "PR has not been merged, copying all commits"
             git cherry-pick ${ORIGINAL_BASE_SHA}..${ORIGINAL_HEAD_SHA}

.github/workflows/e2e-tests.yml

@@ -50,25 +50,25 @@ jobs:
       java_version: ${{ fromJson(steps.dependencies.outputs.result).java_version }}
       node_version: ${{ fromJson(steps.dependencies.outputs.result).node_version }}
     steps:
-    - uses: actions/checkout@v4
-      with:
-        sparse-checkout: release
-    - name: Prepare build scripts
-      run: cd ${{ github.workspace }}/release && yarn && yarn build
-    - name: Get build dependencies
-      uses: actions/github-script@v7
-      id: dependencies
-      with:
-        script: | # js
-          const { getBuildRequirements, getVersionFromReleaseBranch } = require('${{ github.workspace }}/release/dist/index.cjs');
+      - uses: actions/checkout@v4
+        with:
+          sparse-checkout: release
+      - name: Prepare build scripts
+        run: cd ${{ github.workspace }}/release && yarn && yarn build
+      - name: Get build dependencies
+        uses: actions/github-script@v7
+        id: dependencies
+        with:
+          script: | # js
+            const { getBuildRequirements, getVersionFromReleaseBranch } = require('${{ github.workspace }}/release/dist/index.cjs');
 
-          const version = getVersionFromReleaseBranch('${{ github.ref }}');
-          const requirements = getBuildRequirements(version);
+            const version = getVersionFromReleaseBranch('${{ github.ref }}');
+            const requirements = getBuildRequirements(version);
 
-          return {
-            java_version: requirements.java,
-            node_version: requirements.node,
-          };
+            return {
+              java_version: requirements.java,
+              node_version: requirements.node,
+            };
 
   build:
     needs: [files-changed, e2e-matrix-builder, get-build-requirements]
@@ -92,12 +92,12 @@ jobs:
       - name: Prepare front-end environment
         uses: ./.github/actions/prepare-frontend
         with:
-          node-version: '${{ needs.get-build-requirements.outputs.node_version }}'
+          node-version: "${{ needs.get-build-requirements.outputs.node_version }}"
       - name: Prepare back-end environment
         uses: ./.github/actions/prepare-backend
         with:
-          m2-cache-key: e2e-tests
-          java-version: '${{ needs.get-build-requirements.outputs.java_version || 11 }}'
+          m2-cache-key: uberjar
+          java-version: "${{ needs.get-build-requirements.outputs.java_version || 11 }}"
 
       - name: Build uberjar with ./bin/build.sh
         run: ./bin/build.sh
@@ -127,6 +127,7 @@ jobs:
       MB_SNOWPLOW_AVAILABLE: true
       MB_SNOWPLOW_URL: "http://localhost:9090" # Snowplow micro
       TZ: US/Pacific # to make node match the instance tz
+      CYPRESS_CI: true
     strategy:
       fail-fast: false
       matrix: ${{ fromJSON(needs.e2e-matrix-builder.outputs.matrix) }}
@@ -144,6 +145,7 @@ jobs:
           postgres: ${{ matrix.name != 'mongo'}}
           mysql: ${{ matrix.name != 'mongo'}}
           mongo: ${{ matrix.name == 'mongo'}}
+          webhook: true
 
       - name: Retrieve uberjar artifact for ${{ matrix.edition }}
         uses: actions/download-artifact@v4

.github/workflows/on-epic-close.yml

@@ -0,0 +1,48 @@
+name: A New Feature Slack Notification
+
+on:
+  issues:
+    types:
+      - closed
+
+jobs:
+  on-epic-closed:
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    if: ${{ contains(github.event.issue.labels.*.name, '.Epic') || contains(github.event.issue.labels.*.name, 'Type:New Feature') }}
+    steps:
+      - name: Setting title
+        uses: actions/github-script@v6
+        id: vars
+        with:
+          script: |
+            core.setOutput('issue_title', ${{ toJson(github.event.issue.title) }}.replaceAll(/"/g, '\\"'));
+      - name: Extracting team name
+        id: team_name
+        run: |
+          team_label=$(echo "${{ join(github.event.issue.labels.*.name, ',') }}" | grep -o '\.Team/[^,]*' | head -n 1)
+          echo $team_label
+          echo "team_label=${team_label}" >> "$GITHUB_OUTPUT"
+          team_name=${team_label#*.Team/}
+          echo $team_name
+          echo "team_name=${team_name^^}_SLACK_EPIC_WEBHOOK_URL" >> "$GITHUB_OUTPUT"
+      - name: Send the issue ${{ github.event.issue.number }} to Slack
+        id: slack
+        if: ${{ steps.team_name.outputs.team_label }}
+        uses: slackapi/slack-github-action@v1.26.0
+        with:
+          payload: |
+            {
+              "blocks": [
+                {
+                  "type": "section",
+                  "text": {
+                    "type": "mrkdwn",
+                    "text": "${{ steps.vars.outputs.issue_title }}\n${{ github.event.issue.html_url }}"
+                  }
+                }
+              ]
+            }
+        env:
+          SLACK_WEBHOOK_URL: ${{ secrets[steps.team_name.outputs.team_name] }}
+          SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK

.github/workflows/perf-test-labeled.yml

@@ -0,0 +1,17 @@
+name: Perf test command
+
+on:
+  pull_request:
+    types: [ labeled ]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  run-perf-test:
+    if: ${{ github.event.label.name == 'Run-perf' }}
+    uses: ./.github/workflows/perf-test.yml
+    with:
+      wait_for_uberjar: true
+    secrets: inherit

.github/workflows/perf-test.yml

@@ -0,0 +1,150 @@
+name: CI for Perf tests
+run-name: Run perf test for ${{ github.ref_name }} by @${{ github.actor }}
+
+on:
+  workflow_call:
+    inputs:
+      wait_for_uberjar:
+        description: "Wait for uberjar build"
+        required: false
+        type: boolean
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    if: github.event.pull_request.head.repo.full_name == github.repository
+    name: Build Metabase Docker image
+    timeout-minutes: 60
+    permissions:
+      id-token: write
+      contents: read
+      actions: read
+    steps:
+      - name: Checkout source code
+        uses: actions/checkout@v4
+      - name: Configure AWS credentials
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          role-to-assume: ${{ secrets.PR_ENV_IAM_ROLE }}
+          role-session-name: GitHub_to_AWS_via_FederatedOIDC
+          aws-region: us-east-1
+      - name: Login to Amazon ECR
+        uses: aws-actions/amazon-ecr-login@v2
+        with:
+          registries: "${{ secrets.PR_ENV_AWS_ACCOUNT_ID }}"
+      - name: Wait for uberjar
+        id: wait_for_uberjar
+        if: ${{ inputs.wait_for_uberjar == true }}
+        run: |
+          ## Get workflow run id for uberjar build
+          curl -Ls --output e2e-tests.json \
+          -H "Accept: application/vnd.github+json" \
+          -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
+          -H "X-GitHub-Api-Version: 2022-11-28" \
+          https://api.github.com/repos/${{ github.repository }}/actions/workflows/e2e-tests.yml/runs?head_sha=${{ github.event.pull_request.head.sha || github.sha }}
+          ID=$(jq -r '.workflow_runs[0].id' e2e-tests.json)
+          ## Wait for uberjar build to complete
+          while [ true ]; do
+            curl -Ls --output uberjar.json \
+            -H "Accept: application/vnd.github+json" \
+            -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
+            -H "X-GitHub-Api-Version: 2022-11-28" \
+            https://api.github.com/repos/${{ github.repository }}/actions/runs/${ID}/jobs?filter=latest
+            jq -r '.jobs[] | select(.name == "build (ee)") | .steps[] | select(.name == "Prepare uberjar artifact") | .status' uberjar.json | grep -q "completed" && break
+            echo "Waiting for uberjar build..."
+            sleep 10
+          done
+          echo "run_id=$(jq -r '.workflow_runs[0].id' e2e-tests.json)" >> $GITHUB_OUTPUT
+      - name: Retrieve uberjar artifact for ee
+        uses: actions/download-artifact@v4
+        with:
+          name: metabase-ee-${{ github.event.pull_request.head.sha || github.sha }}-uberjar
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          run-id: ${{ inputs.wait_for_uberjar && steps.wait_for_uberjar.outputs.run_id || github.run_id }}
+      - name: Move uberjar to bin/docker
+        run: |
+          jar xf target/uberjar/metabase.jar
+          mv target/uberjar/metabase.jar bin/docker/metabase.jar
+      - name: Build container
+        uses: docker/build-push-action@v6
+        with:
+          context: bin/docker/
+          platforms: linux/amd64
+          network: host
+          tags: ${{ secrets.PR_ENV_AWS_ACCOUNT_ID }}.dkr.ecr.us-east-1.amazonaws.com/metabase-enterprise:pr${{ github.event.number }}
+          push: true
+  launch_perf_test:
+    needs: [ build ]
+    runs-on: ubuntu-latest
+    name: Launch Perf Test
+    permissions:
+      id-token: write
+      contents: read
+    steps:
+      - name: Checkout source code
+        uses: actions/checkout@v4
+      - name: Tailscale
+        uses: tailscale/github-action@v2
+        with:
+          oauth-client-id: ${{ secrets.PR_ENV_TAILSCALE_OAUTH_CLIENT_ID }}
+          oauth-secret: ${{ secrets.PR_ENV_TAILSCALE_OAUTH_SECRET }}
+          tags: tag:ci
+          version: 1.50.1
+          sha256sum: d9fe6b480fb5078f0aa57dace686898dda7e2a768884271159faa74846bfb576
+      - name: Create OIDC Token
+        id: create-oidc-token
+        shell: bash
+        run: |
+          export OIDC_URL_WITH_AUDIENCE="$ACTIONS_ID_TOKEN_REQUEST_URL&audience=${{ secrets.PR_ENV_K8S_AUDIENCE }}"
+          IDTOKEN=$(curl -H "Authorization: Bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" -H "Accept: application/json; api-version=2.0" "$OIDC_URL_WITH_AUDIENCE" | jq -r .value)
+          echo "::add-mask::${IDTOKEN}"
+          echo "idToken=${IDTOKEN}" >>$GITHUB_OUTPUT
+      - name: Setup Kube Context
+        uses: azure/k8s-set-context@v2
+        with:
+          method: kubeconfig
+          kubeconfig: |
+            kind: Config
+            apiVersion: v1
+            current-context: default
+            clusters:
+            - name: default
+              cluster:
+                certificate-authority-data: ${{ secrets.PR_ENV_K8S_CERTIFICATE_AUTHORITY_DATA }}
+                server: ${{ secrets.PR_ENV_K8S_SERVER }}
+            users:
+            - name: oidc-token
+              user:
+                token: ${{ steps.create-oidc-token.outputs.IDTOKEN }}
+            contexts:
+            - name: default
+              context:
+                cluster: default
+                namespace: default
+                user: oidc-token
+      - name: Configure AWS credentials
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          role-to-assume: ${{ secrets.PR_ENV_IAM_ROLE }}
+          role-session-name: GitHub_to_AWS_via_FederatedOIDC
+          aws-region: us-east-1
+      - name: Download Deployment YAML template
+        run: aws s3 cp s3://metabase-pr-env/perf-test-pr.yml.tmpl ./perf-test-pr.yml.tmpl
+      - name: Trim SHA
+        env:
+          SHA: ${{ github.event.pull_request.head.sha || github.sha }}
+        id: split
+        run: echo "::set-output name=fragment::${SHA:5}"
+      - name: Render Deployment YAML
+        uses: nowactions/envsubst@v1
+        with:
+          input: ./perf-test-pr.yml.tmpl
+          output: ./perf-test-pr.yml
+        env:
+          IMAGE_TAG: pr${{ github.event.number }}
+          PR_NUMBER: ${{ github.event.number }}
+          RUN_ID: ${{ steps.split.outputs.fragment }}
+          SHA: ${{ github.event.pull_request.head.sha || github.sha }}
+          TEST_NAME: test
+      - name: Deploy PR Review ENV
+        run: |
+          kubectl apply -f ./perf-test-pr.yml

.github/workflows/release-milestone-check.yml

@@ -14,6 +14,7 @@ on:
 
 jobs:
   check-milestone:
+    permissions: write-all
     runs-on: ubuntu-22.04
     timeout-minutes: 10
     steps:
@@ -24,9 +25,9 @@ jobs:
         run: yarn --cwd release --frozen-lockfile && yarn --cwd release build
       - uses: actions/github-script@v7
         env:
+          GITHUB_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
           SLACK_RELEASE_CHANNEL: ${{ vars.SLACK_RELEASE_CHANNEL }}
           SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
-          GITHUB_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
         with:
           script: | # js
             const {

.github/workflows/release.yml

@@ -586,6 +586,7 @@ jobs:
             --assignee "jeff-bruemmer"
 
   trigger-cloud-issues:
+    if: ${{ !inputs.auto }}
     needs: push-tags
     runs-on: ubuntu-22.04
     timeout-minutes: 10
@@ -624,7 +625,7 @@ jobs:
               event_type: 'update-ee-extra-build',
               client_payload: {
                 version: enterpriseVersion,
-                auto: '${{ inputs.auto }}',
+                auto: true, // always auto-merge
               }
             });
 

.gitignore

@@ -77,6 +77,7 @@ target/checksum.txt
 xcshareddata
 xcuserdata
 dev/src/dev/nocommit/
+dev/serialization_deltas/
 *~
 **/cypress_sample_database.json
 **/cypress_sample_instance_data.json