chore(build): de-vendor helm/chart-testing-action GHA (#44722)

Signed-off-by: hainenber <dotronghai96@gmail.com>

.github/workflows/superset-helm-lint-test.yml

@@ -43,38 +43,29 @@ jobs:
         with:
           install-superset: "false"
 
-      # Still vendored (not de-vendored like chart-releaser-action below): the
-      # allowlisted helm/chart-testing-action@v2.8.0 depends internally on
-      # astral-sh/setup-uv@v7.0.0, which isn't itself on the ASF Actions
-      # allowlist (only v8.1.0+ are, at apache/infrastructure-actions'
-      # actions.yml). Needs an INFRA request before this can de-vendor too.
-      # chart-testing-action is a submodule (not a plain directory), and the
-      # $/ self-repository syntax resolves action files directly from the
-      # repository without performing a real (submodule-aware) checkout, so
-      # it can't see into a submodule's link. Keep this one on the
-      # workspace-relative ./ form, consistent with every other workflow in
-      # the repo that references a submodule action.
       - name: Set up chart-testing
-        uses: ./.github/actions/chart-testing-action # zizmor: ignore[self-repository] - $/ cannot resolve an action that lives in a submodule; ./ is required here
+        uses: helm/chart-testing-action@6ec842c01de15ebb84c8627d2744a0c2f2755c9f # v2.8.0
 
       - name: Run chart-testing (list-changed)
         id: list-changed
         run: |
-          changed=$(ct list-changed  --print-config)
+          changed=$(ct list-changed --target-branch ${GITHUB_EVENT_REPOSITORY_DEFAULT_BRANCH} --print-config)
           if [[ -n "$changed" ]]; then
             echo "changed=true" >> $GITHUB_OUTPUT
           fi
         env:
           CT_CHART_DIRS: helm
           CT_SINCE: HEAD
+          GITHUB_EVENT_REPOSITORY_DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
 
       - name: Run chart-testing (lint)
-        run: ct lint --print-config
+        run: ct lint --target-branch ${GITHUB_EVENT_REPOSITORY_DEFAULT_BRANCH} --print-config
         env:
           CT_CHART_DIRS: helm
           CT_LINT_CONF: lintconf.yaml
           CT_SINCE: HEAD
           CT_CHART_REPOS: bitnami=https://charts.bitnami.com/bitnami
+          GITHUB_EVENT_REPOSITORY_DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
 
       - name: Set up helm-unittest
         run: helm plugin install https://github.com/helm-unittest/helm-unittest --version v1.1.1

.gitmodules

@@ -21,9 +21,6 @@
 [submodule ".github/actions/cached-dependencies"]
 	path = .github/actions/cached-dependencies
 	url = https://github.com/apache-superset/cached-dependencies
-[submodule ".github/actions/chart-testing-action"]
-	path = .github/actions/chart-testing-action
-	url = https://github.com/helm/chart-testing-action
 [submodule ".github/actions/github-action-push-to-another-repository"]
 	path = .github/actions/github-action-push-to-another-repository
 	url = https://github.com/cpina/github-action-push-to-another-repository