chore: remove unused INCLUDE_FIREFOX build arg and dead screenshot config (#44245)

Dockerfile

@@ -195,17 +195,15 @@ RUN mkdir -p \
       requirements \
     && touch superset/static/version_info.json
 
-# Install Playwright and optionally setup headless browsers
+# Optionally install Playwright and the headless Chromium used for screenshots
 ENV PLAYWRIGHT_BROWSERS_PATH=/usr/local/share/playwright-browsers
 
 ARG INCLUDE_CHROMIUM="false"
-ARG INCLUDE_FIREFOX="false"
 RUN --mount=type=cache,target=${SUPERSET_HOME}/.cache/uv \
-    if [ "${INCLUDE_CHROMIUM}" = "true" ] || [ "${INCLUDE_FIREFOX}" = "true" ]; then \
+    if [ "${INCLUDE_CHROMIUM}" = "true" ]; then \
         uv pip install playwright && \
         playwright install-deps && \
-        if [ "${INCLUDE_CHROMIUM}" = "true" ]; then playwright install chromium; fi && \
-        if [ "${INCLUDE_FIREFOX}" = "true" ]; then playwright install firefox; fi; \
+        playwright install chromium; \
     else \
         echo "Skipping browser installation"; \
     fi

UPDATING.md

@@ -456,6 +456,18 @@ change (`ENABLE_FORCE_PASSWORD_CHANGE`) now redirects to that profile page
 instead of the removed form. Deployments that link to either legacy route should
 point at `/user_info/` or the Users list instead.
 
+### Unused `INCLUDE_FIREFOX` build arg and dead config removed
+
+Screenshots use only Playwright with Chromium, so the `INCLUDE_FIREFOX` Docker build
+arg, which installed a Firefox browser that nothing used, has been removed from the
+`Dockerfile` and the `docker-compose` files. Builds that still pass `INCLUDE_FIREFOX`
+keep working, though Docker may warn that the build argument is unused. Use
+`INCLUDE_CHROMIUM=true` to add the browser that screenshots need.
+
+The `EMAIL_PAGE_RENDER_WAIT` config key and the `ENABLE_PLAYWRIGHT` variable in
+`docker/.env` are also removed. Nothing in Superset read either of them, so setting
+them had no effect and they can be deleted from custom configs.
+
 ### Default Docker image is now batteries-included; the minimal image moves to `-lean`
 
 The default `apache/superset` Docker image (the plain tags: `latest`, `master`,

docker-compose-light.yml

@@ -75,7 +75,6 @@ x-common-build: &common-build
   args:
     DEV_MODE: "true"
     INCLUDE_CHROMIUM: ${INCLUDE_CHROMIUM:-false}
-    INCLUDE_FIREFOX: ${INCLUDE_FIREFOX:-false}
     BUILD_TRANSLATIONS: ${BUILD_TRANSLATIONS:-false}
 
 services:

docker-compose.yml

@@ -43,7 +43,6 @@ x-common-build: &common-build
   args:
     DEV_MODE: "true"
     INCLUDE_CHROMIUM: ${INCLUDE_CHROMIUM:-false}
-    INCLUDE_FIREFOX: ${INCLUDE_FIREFOX:-false}
     BUILD_TRANSLATIONS: ${BUILD_TRANSLATIONS:-false}
 
 services:

docker/.env

@@ -83,6 +83,5 @@ MAPBOX_API_KEY=''
 
 # Make sure you set this to a unique secure random value on production
 SUPERSET_SECRET_KEY=TEST_NON_DEV_SECRET
-ENABLE_PLAYWRIGHT=false
 PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
 BUILD_SUPERSET_FRONTEND_IN_DOCKER=true

docs/admin_docs/installation/docker-builds.mdx

@@ -201,7 +201,6 @@ came out of, credit to the community for working it out.
   `docker-compose` build to take much less time and resources
 - `INCLUDE_CHROMIUM`: whether to include chromium in the backend build so that it can be
   used as a headless browser for workloads related to "Alerts & Reports" and thumbnail generation
-- `INCLUDE_FIREFOX`: same as above, but for firefox
 - `PY_VER`: specifying the base image for the python backend, we don't recommend altering
   this setting if you're not working on forwards or backwards compatibility
 

docs/developer_docs/contributing/development-setup.md

@@ -95,7 +95,6 @@ documentation.
 Affecting the Docker build process:
 
 - **SUPERSET_BUILD_TARGET (default=dev):** which --target to build, either `lean` or `dev` are commonly used
-- **INCLUDE_FIREFOX (default=false):** whether to include the Firefox headless browser in the build. Superset's screenshot features use only Chromium, so Alerts & Reports and thumbnails don't use it
 - **INCLUDE_CHROMIUM (default=false):** whether to include Playwright and the Chromium headless browser in the build, which Alerts & Reports and thumbnails need to take screenshots
 - **BUILD_TRANSLATIONS(default=false):** whether to compile the translations from the .po files available
 - **SUPERSET_LOAD_EXAMPLES (default=yes):** whether to load the examples into the database upon startup,

superset/config.py

@@ -2839,8 +2839,6 @@ WEBDRIVER_OPTION_ARGS: list[str] = []
 WEBDRIVER_BASEURL = "http://0.0.0.0:8080/"
 # The base URL for the email report hyperlinks.
 WEBDRIVER_BASEURL_USER_FRIENDLY = WEBDRIVER_BASEURL
-# Time selenium will wait for the page to load and render for the email report.
-EMAIL_PAGE_RENDER_WAIT = int(timedelta(seconds=30).total_seconds())
 
 # Send user to a link where they can report bugs
 BUG_REPORT_URL = None