Merge branch 'master' into master-no-tracking

src/metabase/events/view_log.clj

@@ -86,7 +86,7 @@
      :topic   topic
      :user-id user-id}
     (try
-      (increment-view-counts! :model/Card object-id)
+      #_(increment-view-counts! :model/Card object-id)
       (record-views! (generate-view :model :model/Card event))
       (catch Throwable e
         (log/warnf e "Failed to process view event. %s" topic)))))
@@ -125,7 +125,7 @@
   "Handle processing for a dashboard query being run"
   [topic {:keys [object-id] :as _event}]
   (try
-    (update-dashboard-last-viewed-at! object-id)
+    #_(update-dashboard-last-viewed-at! object-id)
     (catch Throwable e
       (log/warnf e "Failed to process dashboard query event. %s" topic))))
 
@@ -169,7 +169,7 @@
      :topic topic
      :user-id user-id}
     (try
-      (increment-view-counts! :model/Dashboard object-id)
+      #_(increment-view-counts! :model/Dashboard object-id)
       (record-views! (generate-view :model :model/Dashboard event))
       (catch Throwable e
         (log/warnf e "Failed to process view event. %s" topic)))))
@@ -186,7 +186,7 @@
      :topic topic
      :user-id user-id}
     (try
-      (increment-view-counts! :model/Table (:id object))
+      #_(increment-view-counts! :model/Table (:id object))
       (let [table-id    (u/id object)
             database-id (:db_id object)
             has-access? (when (= api/*current-user-id* user-id)

src/metabase/query_processor/middleware/update_used_cards.clj

@@ -51,8 +51,8 @@
           rff   :- ::qp.schema/rff]
     (let [now  (t/offset-date-time)
           rff* (fn [metadata]
-                 (doseq [card-id (distinct (lib.metadata/invoked-ids (qp.store/metadata-provider) :metadata/card))]
-                   (grouper/submit! @update-used-cards-queue {:id        card-id
-                                                              :timestamp now}))
+                 #_(doseq [card-id (distinct (lib.metadata/invoked-ids (qp.store/metadata-provider) :metadata/card))]
+                     (grouper/submit! @update-used-cards-queue {:id        card-id
+                                                                :timestamp now}))
                  (rff metadata))]
       (qp query rff*))))

src/metabase/util/grouper.clj

@@ -43,9 +43,10 @@
   "A wrapper of [[grouper.core/submit!]] that returns nil instead of a promise.
   We use grouper for fire-and-forget scenarios, so we don't care about the result."
   [& args]
-  (let [p (apply grouper/submit! args)]
-    (when (synchronous-batch-updates)
-      ;; wake up the group immediately and wait for it to finish
-      (.wakeUp ^Grouper (first args))
-      (deref p))
-    nil))
+  nil
+  #_(let [p (apply grouper/submit! args)]
+      (when (synchronous-batch-updates)
+        ;; wake up the group immediately and wait for it to finish
+        (.wakeUp ^Grouper (first args))
+        (deref p))
+      nil))