Fix type

enterprise/frontend/src/metabase-enterprise/caching/components/DashboardCacheSection/DashboardCacheSection.tsx

@@ -1,12 +1,7 @@
-import type { Dashboard } from "metabase-types/api";
+import type { DashboardCacheSectionProps } from "metabase/plugins";
 
 import CacheSection from "../CacheSection";
 
-interface DashboardCacheSectionProps {
-  dashboard: Dashboard;
-  onSave: (cache_ttl: number | null) => Promise<Dashboard>;
-}
-
 const DashboardCacheSection = ({
   dashboard,
   onSave,

enterprise/frontend/src/metabase-enterprise/caching/components/QuestionCacheSection/QuestionCacheSection.tsx

@@ -1,16 +1,11 @@
 import { t } from "ttag";
 
 import { getRelativeTime } from "metabase/lib/time";
+import type { QuestionCacheSectionProps } from "metabase/plugins";
 import { Stack, Text } from "metabase/ui";
-import type Question from "metabase-lib/v1/Question";
 
 import CacheSection from "../CacheSection";
 
-export interface QuestionCacheSectionProps {
-  question: Question;
-  onSave: (cache_ttl: number | null) => Promise<Question>;
-}
-
 const QuestionCacheSection = ({
   question,
   onSave,

enterprise/frontend/src/metabase-enterprise/caching/index.tsx

@@ -9,9 +9,9 @@ import QuestionCacheSection from "./components/QuestionCacheSection";
 import QuestionCacheTTLField from "./components/QuestionCacheTTLField";
 import {
   getQuestionsImplicitCacheTTL,
-  validateCacheTTL,
-  normalizeCacheTTL,
   hasQuestionCacheSection,
+  normalizeCacheTTL,
+  validateCacheTTL,
 } from "./utils";
 
 if (hasPremiumFeature("cache_granular_controls")) {
@@ -20,11 +20,9 @@ if (hasPremiumFeature("cache_granular_controls")) {
     validate: validateCacheTTL,
     normalize: normalizeCacheTTL,
   };
-
   PLUGIN_FORM_WIDGETS.dashboardCacheTTL = CacheTTLField;
   PLUGIN_FORM_WIDGETS.databaseCacheTTL = DatabaseCacheTTLField;
   PLUGIN_FORM_WIDGETS.questionCacheTTL = QuestionCacheTTLField;
-
   PLUGIN_CACHING.getQuestionsImplicitCacheTTL = getQuestionsImplicitCacheTTL;
   PLUGIN_CACHING.DatabaseCacheTimeField = DatabaseCacheTimeField;
   PLUGIN_CACHING.DashboardCacheSection = DashboardCacheSection;

frontend/src/metabase/plugins/index.ts

@@ -275,13 +275,28 @@ export const PLUGIN_MODERATION = {
   ) => [],
 };
 
+export interface QuestionCacheSectionProps {
+  question: Question;
+  onSave: (cache_ttl: number | null) => Promise<Question>;
+}
+
+export interface DashboardCacheSectionProps {
+  dashboard: Dashboard;
+  onSave: (cache_ttl: number | null) => Promise<Dashboard>;
+}
+
 export const PLUGIN_CACHING = {
+  cacheTTLFormField: {} as any,
   dashboardCacheTTLFormField: null,
   questionCacheTTLFormField: null,
-  getQuestionsImplicitCacheTTL: (_question?: any) => null,
-  QuestionCacheSection: PluginPlaceholder,
-  DashboardCacheSection: PluginPlaceholder,
-  DatabaseCacheTimeField: PluginPlaceholder,
+  getQuestionsImplicitCacheTTL: (_question?: any) => null as number | null,
+  QuestionCacheSection:
+    PluginPlaceholder as React.ComponentType<QuestionCacheSectionProps>,
+  DashboardCacheSection:
+    PluginPlaceholder as React.ComponentType<DashboardCacheSectionProps>,
+  DatabaseCacheTimeField: PluginPlaceholder as React.ComponentType<
+    Record<string, never>
+  >,
   isEnabled: () => false,
   hasQuestionCacheSection: (_question: Question) => false,
 };