Compare commits

...

335 Commits

Author SHA1 Message Date
Nicola Mometto
3ae1585c7e bump 2026-07-17 09:40:23 +01:00
Nicola Mometto
b0b11dca91 test seccomp 2026-07-17 09:39:53 +01:00
Oleh K
8984233763 Align transform job header to fix tab layout shift (#77803)
* Fix layout shift when switching tabs on the transform job page

The job Overview and Run history pages each rendered their own header:
Overview used an editable name input plus a `...` menu, while Run history
used a static title with no menu. The differing heights shifted the tab
row, so the clicked tab jumped when switching between the two.

Extract a shared JobHeader component (and a useJobHeaderState hook for the
readOnly/name-change logic) rendered identically by both pages, mirroring
the MetricHeader pattern. Run history now also shows the `...` menu and the
editable name, and Metabot is consistent across both tabs.

* Unify JobPage header logic with useJobHeaderState

JobPage duplicated the readOnly computation and name-change handler that
now live in useJobHeaderState. Source them from the hook instead; keep the
local useTransformPermissions call only for the page-level loading gate.

* Use strict undefined comparisons in job header code

Address review: job/jobId are never null, so compare with undefined
strictly and derive jobId from job.id in the JobHeader render.
2026-07-17 08:51:59 +02:00
Egor Grushin
8ab2269f04 GDGT-2767 Replace deprecated MaybeLink (#77908)
* Replace deprecated MaybeLink

* refactor
2026-07-17 03:12:48 +01:00
Kevin Kelleher
4385d33640 Fix failing test introduced by #77981 (#78000)
fix test
2026-07-17 01:03:20 +00:00
bryan
64588d02fb test(mfa): auth-mechanism matrix + lockout-corner coverage (#77624) 2026-07-16 22:11:37 +00:00
github-automation-metabase
20b1d51e6b Auto-update documentation for master (#77997)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-16 17:41:49 -04:00
Michael Eby
838d5a7a50 docs: add data isolation content (#77876)
* docs: add data isolation content

* Optimized 4 images, saved 70.0 KB (15.8% smaller)

* Fix links

* Edits from Alex

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-16 16:47:42 -04:00
dpsutton
5fb83b02e7 Fix MCP OAuth consent flow when Metabase is hosted under a subpath (#77765)
Fixes GIT-10551: connecting an MCP client to a Metabase instance served
under a subpath (site-url like https://example.com/metabase behind a
prefix-stripping reverse proxy) failed at the consent step.

The OAuth flow already derives every advertised URL from site-url —
discovery metadata, authorization/token/registration endpoints, and the
WWW-Authenticate resource_metadata header are all subpath-correct. But
three browser-facing pieces assumed Metabase lives at the domain root:

1. The consent form posted to root-relative /oauth/authorize/decision,
   so the browser sent the POST outside the subpath and the proxy
   returned 404 (the reported bug). The form action is now the absolute
   site-url-based URL, via the same absolute-url helper the page already
   uses for the logo. The bundled @font-face URLs on the page get the
   same treatment.

2. The CSRF cookie was scoped to Path=/oauth/authorize. Under a subpath
   the consent page lives at /metabase/oauth/authorize, so the browser
   would never send the cookie back and the decision POST would fail
   CSRF validation even with the form action fixed. The cookie path now
   carries the path component of site-url.

3. The logged-out flow: the backend bounces to the login page with a
   basename-relative redirect target (the server sits behind the
   prefix-stripping proxy and never sees the subpath). The frontend
   guard resolved that target against the bare origin, losing the
   subpath on the full-page redirect back to /oauth/authorize. The
   guard now normalizes targets through the router basename in both
   directions: paths without an explicit origin get the basename joined
   (browser-real href), and pathnames get it stripped (router path, so
   the backend-only-path prefix check still matches).

Why this is safe:

- Root deployments are bit-for-bit unchanged. site-url has no path
  component there, so the cookie path is still /oauth/authorize, the
  form action still targets /oauth/authorize/decision, and with an
  empty basename the guard resolves every input shape (relative path,
  bare path, absolute URL) to exactly the URLs it produced before.
- Under a subpath, the only outputs that change are ones that were
  previously unroutable (404 through the proxy or a path the SPA
  router would double-prefix).
- The server never sees the subpath, so no routes, parameters, or
  validation logic change; every fix is to a browser-visible artifact
  derived from site-url.

Tests pin both halves: existing root-deployment assertions are
untouched and still pass, and new tests cover the subpath form action,
cookie path, login redirect target, and the full consent -> decision
round-trip with a subpath site-url. Also verified live against a local
prefix-stripping Caddy proxy with a real MCP client flow (DCR, consent,
PKCE token exchange, tool calls).

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-16 15:06:24 -05:00
Rodrigo López Dato
31b35fb452 Automatically focus new Key field when adding user attributes (#77715)
* Automatically focus new Key field when adding user attributes

* Only focus new entry if no error
2026-07-16 16:55:13 -03:00
Anderson
f82bdbdd52 Restore table color range saturation for single conditional formatting rules (#77981)
Restore color range saturation for single rules
2026-07-16 16:41:02 -03:00
Alexander Polyankin
2819934fdc Unify image-buffer pool (#77836)
* Rewrite image-buffer pool on dirigiste (same pool as the GraalVM contexts)

Replace the hand-rolled ConcurrentLinkedDeque pool, stats counters, sweeper
daemon, and logging with the dirigiste Pool already used for static-viz
contexts, with the same semantics: 0-3 pooled int[] arrays of the fixed
oversized size, held exclusively per render, idle arrays dropped after ~10
minutes. acquire blocks until an array is free when the requested size fits;
larger requests get a fresh unpooled BufferedImage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Extract the dirigiste pool factory into metabase.util.pool

create-pool was duplicated verbatim between the static-viz graal renderer
(channel.render.js.common) and the sqlglot graal runner (sql-parsing.common),
and image-buffer had just picked up a third use. Move it to metabase.util.pool
and use it from all three; the pool behavior tests move from
sql-parsing.common-test to util.pool-test with it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Add prometheus counters for image-buffer pool usage

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Rename image-buffer metrics to metabase-notification namespace

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-16 15:40:38 -04:00
Timofey Kachalov
ce264b2c85 Update SDK version to 0.64.0-alpha (#77978) 2026-07-16 18:33:44 +00:00
lbrdnk
07f62f33c3 Log suggested prompts generation exception on debug only (#77962)
Log exception on debug only
2026-07-16 18:15:54 +00:00
Andrei Chernykh
adf574b57b Convert Scalar visualization from a class to a function component (#77774) 2026-07-16 11:00:04 -07:00
da
43d61f4514 Update Jetty dependencies to version 12.1.11 (#77860)
https://github.com/jetty/jetty.project/releases

check 12.1.7...12.1.11
2026-07-16 14:08:59 -03:00
Andrei Chernykh
12ce1e67e7 Migrate nav search and search result components from Emotion to Mantine (#77332)
* Migrate nav search and search result components from Emotion to Mantine

* Address review feedback: close button label, valid footer markup, footer role and hover transition

* Restore search dropdown footer ref by returning a ref callback from useListKeyboardNavigation
2026-07-16 17:03:22 +00:00
Rodrigo López Dato
89abda4d66 Browse directly from RCLS settings to saved questions (#77614)
* Browse directly from settings to RCLS saved questions

* Move styles to separate file
2026-07-16 14:02:39 -03:00
Anderson
911fe173f2 Fix margins when printing documents with charts (#74234)
* Improve page/container margins when printing document

* do not call flushSync while printing

* Revert "do not call flushSync while printing"

This reverts commit 37c6fe2b50.

* Resize ECharts synchronously for print layout changes

* Refactor ECharts print resize tests

* Clean up
2026-07-16 13:18:49 -03:00
Ethan McCue
8705016252 Fix gauge breaking in static-viz (#77724)
Fix gauge color crashing

Co-authored-by: Kevin Kelleher <16599994+kevinkelleher12@users.noreply.github.com>
2026-07-16 13:46:56 +00:00
Chris Truter
fc7d1ec13b Make default-source-table-entry deterministic and field-safe (#77725) 2026-07-16 13:09:07 +00:00
da
6108e0182e Accept JWT in the body or in parameters according to the method (#75656)
* Follow up to https://github.com/metabase/metabase/pull/72798#discussion_r3234347346

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeffbruemmer@gmail.com>

* Update docs/people-and-groups/authenticating-with-jwt.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Jeff Bruemmer <jeffbruemmer@gmail.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-07-16 13:01:48 +00:00
Kamil Mielnik
479d7ff67b GDGT-1570 Transform has changes after bluring source table input and still has changes after cancelling them (#77712) 2026-07-16 18:20:13 +07:00
Nicola Mometto
3e6612f075 fix incremental transforms on clickhouse (#77921)
* remove compile-with-inline for clickhouse, no longer needed since the driver got fixed

* re-enable full tests

* fix: for max behavior on clickhouse

* fix: insert for clickhouse

* add temporal reg test
2026-07-16 12:04:46 +01:00
Kamil Mielnik
ce8a99bf08 GDGT-2648 Action menu is too wide when editing a dashboard (#77795) 2026-07-16 17:43:14 +07:00
Nicola Mometto
ed3aa72e65 humanize the alert management error when recipient input is wrong (#77852)
* fix: better human readable validation

* tests
2026-07-16 10:34:25 +00:00
Romeo Van Snick
4081105624 Migrate expression parser and NotebookStepPreview to TypeScript (#77914)
* Generate expression parser as TypeScript

Add --typeScript to lezer-generator so the parser emits typed output; convert lezer.js to lezer.ts.

* Migrate NotebookStepPreview to TypeScript

* Reuse QuestionResultLoaderChildrenProps for VisualizationPreview props
2026-07-16 19:04:36 +10:00
Nicola Mometto
37d96787a1 Better human validation of notification schemas (#77922)
* fix: tighten schema

* 400 rather than 500
2026-07-16 08:57:22 +00:00
Fraser
e823ccc4d7 Move source-location utils to their sole consumer, metabot (#77676) 2026-07-16 20:33:45 +12:00
Romeo Van Snick
4674a3610f Compose route guards as element wrappers (#77686)
* Add element prop support to facade Route

* Compose route guards as element wrappers

* Memoize the element bridge by component type and render off the injected route

* Clarify that index routes accept component or element

* Test that the element bridge reuses shared components across sibling routes
2026-07-16 17:32:12 +10:00
Tyler Plude
1f0d8d6b34 [BOT-1840] Drop visualizer bespoke search index cols (#77684)
* drop temporal dim related search index cols

* revert manual changes to generated docs

* pr feedback; bump up overfetch in visualizer

* rm stale test
2026-07-15 22:02:32 -07:00
Chris Truter
5616e61f7a Allow obsolete semantic search kill-switch (#77903) 2026-07-15 21:58:06 -07:00
Romeo Van Snick
3aa548b966 Migrate DataSelector to TypeScript (#76861)
* Migrate DataSelector SavedEntityPicker to TypeScript

* Align DataSelector picker prop types with actual usage

* Migrate DataSelector to TypeScript and adapt consumers

* Migrate DataSelector unit tests to TypeScript

* Remove unused DataSelector props

* Add TODO for DataSelector api/metabase-lib structural-type cleanup

* Remove unused hasBackButton/onBack from DataSelectorSchemaPicker

* Use setState updater form in setStateWithComputedState

* Guard currentUser instead of faking a zero user id

* Avoid passing a null database to SchemaAndTableDataSelector

* Convert SavedQuestionHeaderButton unit spec to TypeScript

* Justify or remove DataSelector type casts for no-unjustified-type-casts
2026-07-16 14:03:33 +10:00
Timothy S. Dean
cb49c63e0c Better destination-db errors (#77890)
Different endpoints dealing with destination databases handled checks differently, causing confusing error messages depending on code path. This consolidates and standardizes both the messages and the HTTP code.
2026-07-15 20:27:53 -07:00
Romeo Van Snick
99661b47e3 Bundle-size stats: lower record threshold to 0.5% (#77780) 2026-07-16 09:06:44 +10:00
Fraser
98daa6fbf8 Move OnboardingStepper into embedding-hub 2026-07-16 10:19:05 +12:00
Alexander Polyankin
30e4219082 Remove redundant table id from segment and measure API (#77716)
* Remove table_id from measures and segments

* Clear stale Card table_id when the query loses its source table

populate-query-fields only wrote table_id when the derived value was
truthy, so converting an MBQL question to native SQL (or pointing it at
a native model) left table_id referencing the old table. Make it
unconditional, the same fix #68080 applied to source_card_id.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Address review: validate derived table on segment/measure updates

- PUT /api/segment/:id and PUT /api/measure/:id now derive the table from an
  updated definition: table-less definitions are rejected (consistent with
  POST), and if the definition implicitly moves the entity to another table,
  the user must also pass the create permission check for the new table
  (write-check alone only covered the old table).
- Drop the dead :table_id insert arg in POST /api/measure — before-insert
  already derives it from the definition.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Derive segment/measure perms from the definition, not table_id

Per review: instead of API-handler checks against a separately derived table
id, the mi/can-read?, mi/can-write?, and mi/can-create? implementations for
:model/Segment and :model/Measure now derive the source table from the
definition via lib/primary-source-table-id (same admin-or-analyst check as
before, rejecting definitions with no source table), and the API handlers no
longer deal with table ids at all — table_id only remains in what we return
to the client.

Segment definitions are now normalized to MBQL5 at the API boundary (like
measures already were), so the perms and model hooks always see full queries.
Updating a definition re-runs the create check with the new definition, since
the write-check only covers the existing one.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Fix remote-sync segment permission tests for definition-derived perms

The three remote-sync segment tests used empty {} definitions and relied on
table_id/hydrated :table for the permission checks. Perms now derive the
source table from the definition, so give the segments a real MBQL5
definition on the venues table. Also coerce the can-manage helpers to
booleans so callers asserting false? keep working.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Strip stray :aggregation from MBQL4 segment fragments at the API boundary

The model migration always dropped :aggregation from legacy segment
fragments (segments cannot have one). When definition normalization moved to
the API layer, that behavior was lost, so fragments with a stray aggregation
(which several Cypress specs post) started failing schema validation on
insert.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Reject invalid segment definitions instead of stripping :aggregation

Per review: don't silently fix up segment definitions with a stray
:aggregation — validate the normalized definition against the segment schema
at the API boundary and return a 400. Remove the aggregation key from the
Cypress specs that were posting it (it was always dropped by the old model
migration, so those specs never exercised it anyway).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Simplify: keep table_id derivation at the API, revert the perms refactor

Restore the segment/measure permission methods, search filtering, and the
associated tests to their previous table_id-based behavior. The PR keeps to
its core change: the segment/measure APIs no longer accept table_id — it is
derived from the definition and used for the permission checks (including
re-checking the newly derived table when an update moves the entity).

Also update compare-to-the-rest-15655-test for the card change in this PR:
a wrong table_id can no longer be persisted (it is always derived from the
query), so the comparison dashboard for a nil-table card is built from the
field-distribution path now.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Only clear a stale card table_id when the query itself changes

populate-query-fields' unconditional :table_id meant any card update
(rename, archive, collection move) would wipe table_id whenever the
derivation came back nil — e.g. when the query's source card had been
hard-deleted. Gate the nil-overwrite on :dataset_query actually being in
t2/changes; inserts and query edits still clear stale values.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-15 18:01:40 -04:00
github-automation-metabase
eed6ef7980 Auto-update documentation for master (#77899)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-15 18:01:11 -04:00
Timofey Kachalov
b21e9dcba1 Fix lost plural translations for strings that also have a msgctxt (#77700) 2026-07-15 21:11:18 +00:00
Nathan Voxland
8771f8eb73 Persistent queue improvements (#77779)
* Persistent queue: concurrent batches, per-queue error handler, config

Generic improvements to the mq persistent-queue subsystem, extracted from the
explorations work so they can land independently:

- max-concurrent-batches: a queue can process multiple batches in parallel,
  bounded by a (optionally dynamic) limit (metabase.mq.queue.concurrency).
- on-error: per-queue handler invoked when a message exhausts its retries,
  so callers can record terminal failures instead of silently dropping them.
- Reworked polling, quartz scheduling, and registry for the above.
- Expanded mq/README.md and tests (concurrency, on-error, quartz affinity).

* Fix Eastwood reflection warnings on Scheduler.checkExists in quartz-test

`Scheduler.checkExists` is overloaded (JobKey vs TriggerKey), so the un-hinted
`nudge-key` made the three call sites reflective. Import `JobKey` and hint the
local; CI's Eastwood step fails the build on reflection warnings.

* Code fixes
2026-07-15 15:20:33 -05:00
Jeff Bruemmer
e5a9978cac docs - 63 temp workflow (#77722)
* 63 temp workflow

* format
2026-07-15 16:15:48 -04:00
Ben Grabow
039504f1e9 Add linear issue link (#77853) 2026-07-15 15:12:57 -05:00
Andrei Chernykh
09e0cf1718 Migrate remaining ModalContent Emotion styles to Mantine and fix dead EmbedModal header overrides (#77324)
* Migrate remaining ModalContent Emotion styles to Mantine and fix dead EmbedModal header overrides

* Make the modal header back button keyboard-accessible with a descriptive label
2026-07-15 11:14:15 -07:00
Ben Grabow
ba4c6a87c3 Update table-level permissions targeting sample DB to use the correct schema on upgrade (#77843)
Update table-level permissions targeting sample DB to use the correct schema
2026-07-15 12:54:25 -05:00
Alexander Polyankin
1921483a0d Revert data_permissions migration (#77864)
* data_permissions migration fix

* fix
2026-07-15 13:28:16 -04:00
Tyler Plude
0f97c3e87b [BOT-1833] Fix semantic search orphan table cleanup (#77499)
* fix orphan semantic search index table cleanup

* Harden orphan index cleanup: schema-scope the scan, skip views, isolate drops

The orphan scan now only considers base tables (a view in the DROP TABLE
batch would abort every nightly cleanup) and, in dedicated-pgvector mode,
only current_schema() — where the unqualified DROP actually resolves;
previously it scanned all schemas and logged drops that never happened.
Stale/orphan tables are dropped one statement at a time with per-table
error handling so a single undroppable table (e.g. one with a dependent
view) cannot permanently block stale, tombstone, and repair cleanup.

Also anchors index-table-name-pattern (\A/\z) so it stays substring-proof
independent of re-matches, documents that legacy pre-BOT-337
index_table_* names must keep matching, and derives the force-reset test
case from model-table-name/model-table-suffix instead of a literal.

* Count actual index-table drops and reap legacy index_table_ stragglers

drop-index-table! now reports :dropped/:missing/:failed — dropping without
IF EXISTS so a vacuous drop (metadata row whose table is already gone)
does not count — and cleanup logs dropped-of-found. The name pattern
gains an index_table_<anything> alternative: the prefix belongs
exclusively to the pre-BOT-337 era, whose digit-less stragglers were
otherwise unreachable.

---------

Co-authored-by: Chris Truter <chris@metabase.com>
2026-07-15 09:40:46 -07:00
appleby
62cdfb57c2 Do not duplicate user context between system prompt and last user message (#77496)
* Do not duplicate user context between system prompt and last user message

In #71045 we moved most of the user context out of internal.selmer system prompt and injected it into the last user
message. However, other system prompts still injected user context into the system prompt, so we wound up formatting
and including it twice. If the `:user_is_viewing` context happens to be large (many related tables / fields), then the
memory and token cost can be significant (#76493).

This commit removes everything from system prompts that was already being injected into the last user message, namely:

- `current_time`
- `first_day_of_week`
- `current_user_info`
- `viewing_context`

It also moves `recent_views` into the last user message (not previously included there).

In addition to saving input tokens and memory, this should also help with caching on providers like openai that do
automatic prefix caching, since we now always inject the current date/time near the end of the prompt.

This also means all system prompts can drop the `<<<METABOT_CACHE_BREAKPOINT>>>` since they no longer have any dynamic
content after the breakpoint.

* Add :slackbot and :document-generate-content to profiles-excluding-recent-views

Their system prompt never included recent_views, so preserve the behavior now that we inject recent_views in the last
user message.
2026-07-15 16:27:20 +00:00
Maksym Yakubych
ba9e327dd0 fix: metabot ai settings (#77637) 2026-07-15 11:20:54 -05:00
Eric Normand
8706236c94 Add test that workspace isolation init never leaks generated passwords (#77721)
A failed CREATE USER used to surface the generated workspace password
verbatim in the JDBC exception message, which provisioning then logged
(GHY-3660). Scrubbing landed in #74657; this adds a regression test that
reproduces the failure for real: init-workspace-isolation! runs over a
connection authenticated as a low-privilege workspace user (granted
database-level CREATE on postgres/redshift so execution reaches the
password-bearing CREATE USER), and every piece of text a logger could
print from the thrown exception - stack trace, Throwable->map, causes,
suppressed, ex-data, and SQLException nextException links - must not
contain the password. A postgres-only assertion requires the redaction
marker in the echoed statement so the test cannot pass vacuously.
2026-07-15 10:18:13 -06:00
Ben Grabow
5598559520 Disable unsupported actions on driver change (#77838) 2026-07-15 11:04:16 -05:00
Ben Grabow
8d47578032 Compile transforms with nested union all layer to prevent inheriting IDENTITY property (#77539)
* Compile transforms with nested union all layer to prevent inheriting IDENTITY property
2026-07-15 10:35:01 -05:00
Timofey Kachalov
7cc5a515f1 Update log4j-* versions (#77808) 2026-07-15 19:10:30 +04:00
Alexander Polyankin
bf028c04dd Treat a blank MB_CONFIG_FILE_PATH as unset (#77821)
JDK 25 changed the empty file path to resolve to the current directory
(File("").exists() is now true), so a long-standing MB_CONFIG_FILE_PATH=''
made the config-from-file loader try to parse the current directory as YAML
and fail at boot. Ignore blank values like metabase.config.core/config-str
does everywhere else, and don't count them as config-text-file being enabled
in anonymous stats.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-15 10:19:28 -04:00
Benoit Vinay
b2d652c6ab Search MB documentation link incorrectly has underline on hover (#77701)
Fix for underline
2026-07-15 16:12:23 +02:00
Sébastien
e29d97eb9e Fill available space in the dashboard new-question query builder (#77270) 2026-07-15 15:56:53 +02:00
Kamil Mielnik
83215dcacd GDGT-2400 Custom viz plugin can overflow its own container (#77695) 2026-07-15 13:44:06 +00:00
Kamil Mielnik
f0a65273fb GDGT-2649 New action modal has redundant vertical scrollbar (#77809) 2026-07-15 13:35:42 +00:00
Egor Grushin
0d59548a1e Gdgt 2586 replace deprecated loadingspinner component (#77638)
* initial migration

* initial migration

* remove deadcode loaders

* one more site is migrated. remove dead code

* make data-testid="loading-indicator" to be by default for Loader component

* fix unit test
2026-07-15 14:11:08 +01:00
github-automation-metabase
16a8399a5c Auto-update documentation for master (#77760)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-15 09:10:37 -04:00
Nicola Mometto
45940c8ff1 fix: index manager driver added metabdata (#77807) 2026-07-15 12:35:34 +00:00
Kevin Kelleher
88474b9d2a Fix type error introduced by #77131 (#77817)
fix type error
2026-07-15 12:19:52 +00:00
Oleh K
bb8b550a21 Omit negative values from treemap instead of producing wrong percentages (#77601)
* Omit negative values from treemap instead of producing wrong percentages

Treemaps summed metric values as signed totals and divided by that signed
total, so rows of 30 and -50 rendered a surviving leaf as -150%. Negative
tiles also have no positive area, so ECharts dropped them with no warning.

Mirror the pie chart: omit negative values (with a warning) during
aggregation, or fall back to absolute values when every value is negative.
With all node values non-negative the downstream percentage math is correct.

Fixes GDGT-2760

* Tighten null check and document per-row negative filtering
2026-07-15 13:57:05 +02:00
Alexander Polyankin
373b755b50 Bump mise JDK and docs to temurin 25 to match CI (#77769)
* Bump mise JDK to temurin 25 to match CI

CI defaults to Java 25 (.github/actions/prepare-backend and the backend
workflow matrix), but mise.toml still pinned temurin 21.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Update remaining Java 21 leftovers to 25

The e2e matrix builder and docs still referenced JDK 21, while CI,
Docker images, and release requirements for v60+ are on Java 25.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-15 07:50:30 -04:00
Kevin Kelleher
03a8afdba8 Truncate categorical axis labels rather than not showing them (#77131)
* truncate categorical axis labels

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-15 07:30:44 -04:00
Ngoc Khuat
aaa84da26f Move index manager driver changelog entry to 0.64.0 (#77710)
move index manager driver changelog entry from 0.63.0 to 0.64.0
2026-07-15 09:27:36 +00:00
Arik Aronov
611ef3690b Set enablePutGet as a Snowflake connection property (#77731)
* assoc in connection-details->spec

* Drop unused empty? refer

* fix in check-manager-of-group function name
2026-07-15 12:05:23 +03:00
github-automation-metabase
559301b57b Fix flaky MBQL to SQL transform conversion e2e test (#77699)
* Pin MBQL transform source schema in transforms e2e spec

The many_schemas Postgres fixture creates an "Animals" table in every
schema (Schema A through Schema Z). createMbqlTransform resolved its
source table via getTableId by name only, so Array.find returned an
arbitrary schema's "Animals" depending on /api/table ordering. The
"convert an MBQL transform to a SQL transform" test asserts the compiled
SQL contains "Schema A", so a non-Schema-A match made it flake.

Add an optional sourceSchema to createMbqlTransform and pin the spec's
source to Schema A so the resolved table and its SQL are deterministic.

* Wait for MBQL->SQL transform save to settle before clicking Run tab

The Run tab only exists in read-only view mode; after clicking Save the
test must wait for the update PUT and the navigation off /edit, otherwise
it races the still-in-flight save and times out looking for the Run tab.

* only pin source schema for the default source table

---------

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
2026-07-15 15:21:14 +07:00
Romeo Van Snick
803f470a7c Replace IndexRoute/IndexRedirect/Redirect with index routes and Navigate (#77591)
* Add index-route support and redirect() to the metabase/router facade

* Adapt ModalRoute and DataPermissionsPage to the function-based Route

* Replace IndexRoute/IndexRedirect/Redirect with index routes and redirect()

* Convert createEntityIdRedirect to a facade-hook wrapper component

* Update route test scaffolding for index routes and redirect()

* Build the Route shim via createRoutes instead of augmenting RouteUtils

* Point the guards spec at the relocated Route export

* Stabilize transforms permission navigation in e2e specs

* Freeze redirect() target at mount to fix chained index-redirect race

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
2026-07-15 14:43:41 +10:00
Alexander Polyankin
cb41874c74 Revert "Bound concurrent query-cache writes" (#77781)
Revert "Bound concurrent query-cache writes (#77738)"

This reverts commit a77339d049.
2026-07-14 23:36:46 -04:00
Alexander Polyankin
1a8a17229a Don't GZIP sync-flush per object when serializing QP cache entries (#77786)
* Don't GZIP sync-flush per object when serializing QP cache entries

Sync-flushing after every cached row meant one native Deflater call in a
JNI critical region per row; on JDK <= 21 (no G1 region pinning, JEP 423)
that stalls GC via the GCLocker under concurrent cache writes. Let the
deflater buffer normally instead, and have result-fn finish the stream
(draining the deflater and writing the GZIP trailer) before returning the
bytes. Old cache entries (unterminated gzip) still deserialize since the
reader already treats EOFException as end-of-stream.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Don't flush the JSON download writer per row

Each per-row flush cascaded into a sync-flush of the gzipped HTTP response:
one native Deflater call in a JNI critical region per exported row (GCLocker
stalls on JDK <= 21) plus one TCP packet per row (#34795, fixed for the :api
writer but not :json downloads) and a worse compression ratio. Let the
BufferedWriter push rows through as it fills, like the CSV writer does;
finish! still flushes the tail.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-14 23:32:58 -04:00
Romeo Van Snick
972c96b58d Convert modal routes to a modalRoute factory and delete getParentPath (#77372)
* Resolve relative navigation in the router facade's useNavigate

* Add modalRoute factory for modals declared as child routes

* Convert modal routes to the modalRoute factory and delete getParentPath

* Keep navigate's identity stable when v3 rebuilds the matched routes

* Measure matched route pathnames with v3's matchPattern

* Address review: splat note and test, parsePath docstring grammar
2026-07-15 11:36:35 +10:00
Alexander Polyankin
4c9497c75c Add missing FKs (#77713) 2026-07-14 21:16:40 -04:00
technomancy
4e5bb2daa8 Isolate snowflake DB names in CI aggressively (#77669)
Make Snowflake CI runs use a randomly-generated, isolated DB names.

Something is still randomly calling `destroy-db!` on the test-data
dataset and wrecking things for CI runs:

```
(pprint (jdbc/query (no-db-connection-spec)
                    ["SELECT query_text, end_time
                        FROM SNOWFLAKE.ACCOUNT_USAGE.QUERY_HISTORY
                       WHERE query_text LIKE '%_c1bae%'
                         AND (query_text LIKE '%DROP%' OR query_text LIKE '%drop%')
                       ORDER BY end_time DESC limit 128"]))
[...]
"DROP DATABASE \"sha_rel_c1baee7db240aa419104c2d925a07a4d4faeeb24_test-data\";"
```

This particular query (without `IF EXISTS`) only exists on master in
the `destroy-db!` method. However, this method already has protection
against being run on the `test-data` dataset and will throw an
exception if this is tried! And the main call to `destroy-db!` is
gated behind a feature check for `:test/dynamic-dataset-loading`. So
there's nowhere this could be coming from on master.

Rather than trying to track it down, I think it's better to just treat
all snowflake DBs as isolated and disposable. Update `qualified-db-name`
to just prefix the DB name with a random prefix, and use the
`after-run` hook to drop it when done. This also allows us to get rid
of the janky and weird locking system, because no two jobs should ever
try to hit the same DB.
2026-07-14 21:05:52 -04:00
Alexander Polyankin
9cd10f877b Always include inactive tables in dependencies API responses (#77714) 2026-07-14 20:00:12 -04:00
Egor Grushin
9a5a4e2587 GDGT-2833 Add per-version download link to Security Center advisories (#77677)
* Add per-version download link to Security Center advisories

Thread optional download_jar_url through backend schema/fetch and render
a Download link next to each fixed version in AdvisoryCard.

* fix aligning

* Read instance version via useSetting; simplify affected-version lookup

* rollback a redundant change

* addressing PRs comments

* use sequence to nil-coerce download_jar_urls

* addressing the PR's comments

* add download-click analytics

* fix test: add download_jar_urls to Advisory factory

* add e2e test
2026-07-15 00:13:03 +01:00
Egor Grushin
7b3ed42a61 GDGT-2585 Replace deprecated Input component (#77559)
* initial migration

* fix link input size

* remove dead files

* Use Input.ClearButton for textinput clear icon

Replace hand-rolled Tooltip+ActionIcon+Icon clear pattern w/ Mantine
Input.ClearButton across 5 sites; c=text-secondary + rightSectionPointerEvents=all.
Comment why LinkViz needs pointer-events on both root+input.

* fix unit test

* Update loki refs for parameter search Input->TextInput

* Use Input.ClearButton in PermissionsEditorContent; rm blank line in SearchBar styled

* addressing the PR's comments
2026-07-14 22:49:55 +01:00
Sloan Sparger
bf26412ac5 [Metabot] Backend driven conversation state (#76939)
* validate client sent parent_message_id

* implement more restrictive retry logic

* move history to the backend

* migate state from conversation to message records

* client nows generates message ids to shrink case of client not knowing id of written message record on aborted requests

* pr feedback

* [Metabot] Implement conversation branches in usage analytics (#77542)

* implement branches in usage analtyics

* sol pass at making code terser / cleaner

* handle error messages correctly + allow branching after assistant message

* pr feedback

* fix test failures

* remove migration logicalFilePath
2026-07-14 16:22:06 -05:00
Egor Grushin
12835e1889 GDGT-2580 Replace deprecated FormErrorMessage component (#77497)
* initial migration

* initial migration

* Fix WritebackParameter missing name/slug in scaffold
2026-07-14 22:09:33 +01:00
Chris Truter
d65b0f5661 Remove the semantic search kill switch (#77570) 2026-07-14 20:51:41 +00:00
Alexander Polyankin
a77339d049 Bound concurrent query-cache writes (#77738) 2026-07-14 16:16:11 -04:00
Alexander Polyankin
fcd561b654 Replace timeout-prone permissions-collapse migration with aggregate-first query (#77727) 2026-07-14 15:39:15 -04:00
Alexander Polyankin
d3a8d67430 Skip static-viz bundle size budget in dev builds (#77741)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-14 15:06:17 -04:00
Chris Vandoodewaard
bd6c7a3ef6 Lint Github Actions Workflows with actionlint (#77698)
* add actionlint workflow

* install actionlint with mage

* pass flags to actionlint

* fix options

* don't use mage

* install actionlint locally with mise, update workflow to use install script
2026-07-14 14:43:38 -04:00
Alexander Polyankin
973bddf906 Bump Docker runtime images to Temurin 25 JRE (#77730) 2026-07-14 13:40:54 -04:00
Nick Fitzpatrick
ace59d6c1c Show all connected parameters when setting up a subscription (#77626) 2026-07-14 21:40:27 +05:30
Eric Normand
5246357b5c Gate write share actions (embed publish, public link) on write access (#72752, GHY-3814) (#77528)
* Hide write-only share actions when entity is not writable (#72752)

The Question and Dashboard sharing menus, and the public-link popover,
offered write actions to any admin regardless of write access. On a
read-only remote-synced instance a card/dashboard in a synced collection
is not writable (can_write=false), so these actions 403'd or authored
state that doesn't stick — the "updating embed fails on read-only
instance" symptom in #72752.

Gate the write actions on can_write, matching how the normal edit
affordances already disappear when the entity can't be written:
- Embed (publish): hidden when not writable.
- Create a public link: hidden when not writable; an existing public link
  stays visible so it can still be viewed/copied (those are reads).
- Remove public link: hidden when not writable.

* Disable embed Publish instead of hiding the option on read-only entities (#72752)

Keep the Embed sharing option visible for a read-only remote-synced
card/dashboard, but disable the Publish/Unpublish buttons in the embed
modal with a tooltip explaining the entity is synced and read-only.
This reverts the earlier hiding of the Embed menu item; the public-link
gating (hide create / remove, keep an existing link viewable) is
unchanged.

* Translate the read-only embed tooltip per resource type (#72752)

Interpolating resourceType left the noun untranslated and prevented the
rest of the sentence from agreeing with its gender.
2026-07-14 10:57:58 -05:00
Mihael Konjević
2ca895407f Bot 1729 eval tracing (#77169)
* Add ai-tracing: eval-time trace capture for the Metabot agent

Introduce a new `ai-tracing` module that captures complete, per-run agent
traces during benchmark/eval runs and exports them to an external eval
backend (Confident AI) over OTLP — separate from production observability.

- Capture is gated by a per-run dynamic binding (`*capture*`), orthogonal to
  MB_TRACING_*, so it never fires on organic traffic. Enabled via the
  env-only MB_AI_EVAL_CAPTURE setting; the API path emits the trace as an
  `eval_trace` data part and exports it.
- Captures the full agent.turn -> llm.call -> tool.* tree with prompts,
  completions, tool args/results, durations, and concurrent-tool nesting
  (conveyed across the agent's virtual threads).
- OTLP export uses a dedicated TracerProvider (SimpleSpanProcessor +
  force-flush, never the production one), replaying the in-memory tree
  post-hoc. The domain -> Confident `confident.*` semconv mapping lives in a
  single chokepoint (`node->semconv-attrs`); vendor/schema swaps are one edit.
- Wires capture into run-agent-loop, loop-step, call-llm, and run-tool.
- Trace-level input/output (user question + final answer) set on the root.
- Export failures are logged loudly instead of swallowed.
- Tests cover the gate, nesting, enrichment, timing, concurrency, the
  semconv mapping, and a metadata-size regression guard.

* Make ai-tracing export more idiomatic; refresh stale docs

- export.clj: replace node->semconv-attrs's nested cond-> of repeated
  type checks + json/encode with :ai/keys destructuring and a flat
  medley/assoc-some table; compose final-llm-output as transducers;
  extract event->attributes; tidy parse-headers (for-comprehension),
  build-provider! (doto), and ensure-provider! (fresh? helper).
- core.clj: drop the stale "seam not wired" comment block and the
  outdated ns docstring (it referenced the abandoned gen_ai/OpenInference
  schema and "single namespace" framing); describe the shipped export.

No behavior change; 14 tests / 56 assertions still pass.

* Replace ai-tracing OTLP export with per-session JSONL log files

Switch the eval-trace collection method from OpenTelemetry/OTLP export to a
dedicated file-based logger, and extend instrumentation to the MCP server and
agent-api in addition to the Metabot agent loop.

- Rip out all OTLP/Confident code (export.clj, the OTLP settings, the OTel
  provider/semconv mapping, the eval_trace SSE part).
- New metabase.ai-tracing.log sink: each span streams one JSON line on a
  dedicated logger, routed per session to its own <session-id>.jsonl by a
  Log4j2 RoutingAppender keyed on mb-eval-session-id. Pure JSONL (%m%n), full
  payloads, no size limits.
- Session model = OTel trace-id analog: *session-id* minted at a fresh
  capture's root, or supplied by the caller, conveyed across virtual threads
  by bound-fn*. Nodes carry :id/:parent-id for tree reconstruction.
- Generic with-eval-session entrypoint (gated by MB_AI_EVAL_CAPTURE, inherits
  when nested) reused by run-agent-loop, MCP dispatch-request (keyed on the
  Mcp-Session-Id so a conversation lands in one file), and agent-api routes.
- MB_AI_EVAL_CAPTURE is the single on/off switch; the logger sits at info and
  writes nothing unless a capture is active.
- run-agent-loop emits a tiny eval_session SSE part so the HTTP harness can
  locate the session file.

Verified end-to-end: real agent run writes a per-session JSONL file with the
correct span tree (parent chain, full structured + normal tool output);
sessions route to separate files. 14 tests / 51 assertions pass.

* ai-tracing: capture full request/response context and add trace read API

Enrich eval spans so a captured trace is a self-contained record of a run:

- agent-api: record HTTP request body, user id, and the response status/body
  via a wrapping respond fn that fires inside the span.
- mcp: record JSON-RPC params, user id, scopes, and the materialized result.
- metabot agent: thread an optional eval-session-id through run-agent-loop so
  the harness can name and read back the per-session trace file; record the
  full request (messages/context/state), turn-level token usage, finish reason,
  and final agent state (link registry / generated entities). Surface the loop
  finish-reason out of loop-step instead of only logging it.
- log: guard span serialization so a non-encodable attribute can never break a
  traced run.

Add metabase.ai-tracing.api: a superuser-only GET /api/eval-trace/:session-id
that returns the captured JSONL, mounted only when MB_AI_EVAL_CAPTURE is on.
Filenames are validated against path traversal. Wire the module into routes and
the kondo module config.

* ai-tracing: preserve OpenAPI spec on agent-api routes; harden trace sink

The eval-tracing wrapper turned agent-api `routes` into a plain fn, which no
longer implemented OpenAPISpec — full-API spec generation (openapi.json,
endpoint-dox, the openapi-all-routes test) threw when the walk reached
/api/agent. Wrap it in `handler-with-open-api-spec`, delegating the spec to the
underlying ns-handler.

Also: narrow the trace-sink catch to Exception so Errors/InterruptedException
propagate; stream the trace file instead of slurping it into heap; and correct
the "single nil-check" docstring claim.

* ai-tracing: validate eval-session-id at mint time to prevent path traversal

The trace read endpoint sanitized the session-id before touching disk, but the
write path fed the raw, caller-supplied eval_session_id straight into the
RoutingAppender's `<session-id>.jsonl` file name — a value like `../../foo` on
an eval instance escaped the trace dir (arbitrary .jsonl write).

Hoist the safety regex to a single `safe-session-id-re` in ai-tracing.core and
add `checked-session-id`, which mints a uuid when none is supplied and throws on
an unsafe supplied id. `with-eval-session` now validates every caller-supplied
id before it can reach the log-file path; ai-tracing.api references the shared
regex so read/write validation can't drift.

* ai-tracing: gate span-macro arg construction on capture-active?

The span macros expanded to an eval-span* call, so span-name and attrs
were built on every invocation and discarded on the nil-check when no
capture was live. Hoist the capture-active? guard into a `spanning`
helper macro (and an inlined variant in with-tool-call, whose name
derives from attrs) so organic traffic never builds the span name string
or attrs map — it pays only the *capture* nil-check plus one thunk
closure. with-tool-call now evaluates attrs exactly once, and only when
capturing.

* ai-tracing: test cross-module span nesting; make agent tests capture-agnostic

Add eval-tracing-nesting-test: drives the real run-agent-loop under
capture-reducible with only the LLM + search backend mocked, and asserts
the emitted span tree nests agent.turn -> llm.call -> tool.search. This
covers the wiring the ai-tracing docstrings promise — the turn/llm spans
opened in metabot.agent.core, the tool span in metabot.self.core, and
*parent* conveyed across bound-fn* into the virtual-thread tool executor
— which the ai-tracing unit tests exercised only at the primitive level.

Also pin eval-capture off for the namespace via a fixture. run-agent-loop
appends an eval_session data part to the stream whenever capture is active,
so every exact-match assertion on its output broke under MB_AI_EVAL_CAPTURE
(which dedicated eval instances set). The fixture keeps those assertions on
the production stream shape; the new test forces capture independently.

* ai-tracing: key MCP eval session on UUID correlator; complete finish-reason

Key the MCP eval-trace session on the session id's UUID prefix rather than
the full <uuid>.<base64> id: the prefix is stable across the conversation and
always filesystem/URL-safe, so a base64 payload that require-valid-session
accepts but safe-session-id-re rejects (e.g. `=` padding) can no longer make
checked-session-id throw ahead of the JSON-RPC try/catch and 500 the request.

Record :finish-reason on the empty-response and reduced (early-termination)
loop terminations too, so the turn span's :ai/finish-reason is populated on
every path, not just natural completion.

* ai-tracing: harden trace sink serialization and error capture

- emit!: fall back to a JSON-safe copy when an attribute value isn't
  encodable, so one bad value no longer drops the span (and, for a root
  span, orphans its children).
- span error events now carry the exception class and ex-data, not just
  the message.
- rename JSONL :start-ns/:end-ns to :start-epoch-ns/:end-epoch-ns (they
  hold wall-clock epoch nanos, not System/nanoTime).
- test the api trace-file path-traversal guard directly.

* ai-tracing: bound session ids, gate user-input build, snapshot finish-node

- Cap supplied eval-session-id at 200 chars on the API schemas and in
  checked-session-id, so a supplied id can't produce a filename that fails
  creation and silently drops the trace (charset was already enforced).
- Compute the turn span's :ai/user-input inside the capture-gated attrs map
  instead of unconditionally on every run-agent-loop call.
- finish-node takes a single consistent snapshot of the node atom.

* ai-tracing: enforce session-id cap+charset at API boundaries

Route the 200-char cap through ait/max-session-id-length everywhere (read
endpoint, run-agent-loop opts, POST /api/metabot params) instead of
hardcoding the literal, and bound the previously-unbounded read-endpoint
:session-id path segment.

Validate the charset via safe-session-id-re in the Malli schemas so a bad
eval-session-id 400s at the boundary rather than throwing deep in
checked-session-id and surfacing as a generic agent error. Anchor
safe-session-id-re with \A/\z so it stays exact under both re-matches (mint/
read checks) and re-find (Malli :re) — unanchored, :re accepted any string
containing a safe run (e.g. ../../etc/passwd).

* ai-tracing: key MCP eval trace on a harness-supplied session id

Let an eval harness name and later fetch an MCP conversation's trace. The MCP
endpoint honors an `x-eval-session-id` header — `dispatch-request` keys
`with-eval-session` on it (validated through `checked-session-id`, the single
source of truth for the safe-id contract), falling back to the `Mcp-Session-Id`
correlator when absent. This is the MCP analogue of metabot's `eval_session_id`,
needed because the client owns the `Mcp-Session-Id` and never exposes it.

Also record the resolved query on the construct-query endpoints as `ai/query`
(inert unless capturing): the MCP `construct_query` tool returns only an opaque
handle, so this is the only place a harness can recover the agent's query off
the trace to grade it.

* ai-tracing: address review — guard :reduced append, cover the read API

- run-agent-loop: on a :reduced stop (client disconnect / cancellation) the
  reducing fn has already terminated, so don't step it again to append the
  eval-session pointer or debug part — that violates the transducer contract.
  Fold both trailing appends into one capture-gated cond-> that no-ops on
  :reduced (also fixes the latent debug-branch case). The harness reads the
  JSONL file, not the stream, so a skipped pointer on disconnect costs nothing.
- agent-api: record :http/user-id in the respond closure, where +auth has bound
  *current-user-id* — it is unbound when the span opens, so direct HTTP callers
  previously recorded nil.
- ai-tracing.api: add endpoint integration tests — capture-gated 404,
  superuser-gated 403, missing-trace 404, and existing-trace 200.
- log: mark node->entry ^:private; document that trace-file retention is the
  operator's responsibility (append-only, no rollover, re-runs accumulate).
- mcp: extract the dispatch lambda (line length) and note the fresh-file-per-
  request fallback when neither session id is present. Mark pure tests ^:parallel.

* ai-tracing: drop dead exports, document capture id, harden json-safe

- Remove the `sanitize-sql` re-export and `event!`: neither has a
  non-test caller. Dropping `sanitize-sql` also removes ai-tracing's only
  dependency on the `tracing` module (trimmed from `:uses`). The sites that
  put a query in a span record the raw value on purpose (a scorer wants the
  real SQL/MBQL), so the sanitizer was advertising an inconsistency the
  design doesn't want.
- Document that `capturing`/`capture-reducible` is return-value-based: a
  session id supplied to an inner `with-eval-session` is ignored because
  capture is already active, so no `<id>.jsonl` is written on that path.
- `json-safe` now stringifies non-scalar map keys too, so the fallback can
  never itself throw and orphan the root span it exists to save. Covered by
  a vector-keyed-map regression test.

* ai-tracing: address review — gate pointers, bound json-safe, drop indirection

Correctness:
- capturing/capture-reducible no longer mint a session id, so the in-process
  path is truly file-less (read :trace) instead of writing a stray <uuid>.jsonl
- gate the trailing eval_session pointer on a non-nil *session-id* so the
  file-less path doesn't emit a pointer to a <nil>.jsonl
- add *retain-tree* so the in-memory span tree is only built when a caller
  reads it back (capturing); the file-routed path no longer pins heap for the
  whole run
- depth-bound json-safe so a deep/cyclic attr degrades to a string instead of a
  StackOverflowError escaping emit!'s catch
- agent-api trace wrapper: only record a plain-data :http/response (skip a
  streaming/opaque body rather than stringifying it); fix the stale comment

Cleanup:
- drop the eval-capture-enabled? indirection; entrypoints and tests consult the
  ai-eval-capture setting directly
- with-eval-session: inline supplied-id, ^:once, generic 404 gate message
- extract mcp dispatch-method to de-nest the JSON-RPC case
- remove the dead ai-tracing.core/event! kondo entry
- keep eval JSONL spans out of the shared test log (log4j2-test.xml)

Tests: cover the agent-api trace wrapper, the file-less no-pointer/no-file
behaviour, and drive the log-sink assertions through with-eval-session.

* ai-tracing: fix route sort order and wire settings through init

Two structural test failures on the branch:

- Move the `/eval-trace` route into sorted position in the route-map
  (keep-routes-sorted-test reads the file and asserts the keys are sorted).
- Add `metabase.ai-tracing.init` (requiring the settings ns), require it from
  `metabase.core.init`, and add it to the module's `:api` — so
  settings-namespaces-should-be-required-by-init-namespaces-test passes and the
  `MB_AI_EVAL_CAPTURE` setting is registered deterministically at startup rather
  than only when some instrumented namespace happens to load `ai-tracing.core`.

* ai-tracing: store span wall-clock timestamps as epoch millis, not nanos

Review: the epoch fields were nanos synthesized from currentTimeMillis (ms-
granular anyway), and precise sub-ms duration already lives in :dur-ms — so nanos
bought nothing. Rename :start-epoch-nanos/:end-epoch-nanos → :start-epoch-ms/
:end-epoch-ms (and the JSONL keys :start-epoch-ns/:end-epoch-ns → :start-epoch-ms/
:end-epoch-ms). End is still start + the monotonic duration (rounded to ms), so it
never reads a second, possibly backward-jumping wall clock.
2026-07-14 17:30:50 +02:00
Nick Fitzpatrick
85485ed925 Fix flaky bulk-move dashboard-questions e2e test (#76165)
visitDashboard waits on every dashcard query with cy.wait's default 5s
per-alias window; with 20+ cards the tail queries stagger behind the HTTP/1
concurrency limit and miss it (the dashcardQuery### "no request occurred"
flake). Add a dashcardTimeout option to visitDashboard and use it for the
large-dashboard visits in this test, so the downstream card assertions can
stay at their default timeouts. Also give the 20-request bulk move a longer
window, since its tail lags under CPU constraint.
2026-07-14 20:54:53 +05:30
github-automation-metabase
8d3584593a Auto-update documentation for master (#77657)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-14 10:09:10 -04:00
Kamil Mielnik
6547e398ee GDGT-2748 Broken Security Center layout in error state (#77704) 2026-07-14 20:39:51 +07:00
Chris Vandoodewaard
a6b0d2c7d6 Clean up stale step condition in backend.yml (#77605)
* remove dead condition, update to match other checks

* just use always
2026-07-14 09:08:06 -04:00
Chris Truter
4d04a9743c MCP notes on archiving questions and dashboards (#77569) 2026-07-14 14:34:05 +02:00
Nemanja Glumac
7712c474dd Run master's ci-conductor sources on release branches (#77625)
The ci-conductor scripts are shared CI infrastructure: every supported
release branch runs them, and they keep evolving on master. A copy
committed to a branch goes stale, and syncing six branches by hand on
every change does not scale.

Add a prepare-ci-conductor action that overlays release/ci-conductor and
e2e/support/ci_conductor.ts from master, so a release branch runs the
current scripts while its workflow wiring stays branch-historical.
Anything headed for master uses its own sources, so a PR can still test
its own changes.

quarantine-gate and report-failures-to-ci-conductor delegate their bun
setup to it. prepare-cypress calls it too, because e2e/support/config.js
imports the reporter at Cypress bundle time and it has to be in place
before the run starts.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-14 14:32:43 +02:00
metamben
dbedcbfbd4 Grouping set pivot (#76560)
* Implement schema, lib helpers, viz-settings + query -> query

* Implement grouping-set compilation

* Implement query nesting to support breakouts with parameters

For example, when selecting nested JSON fields in postgres,
the generated SQL query contains prepared query parameter
placeholders and the engine cannot determine that all copies
are the same expression.
2026-07-14 11:05:24 +00:00
Alexander Polyankin
25eebabf11 2FA E2E tests (#77671)
* 2fa e2e

* tests
2026-07-14 06:40:21 -04:00
Timur Mashara
30daa26a7b GRO-554 update storage upsell (#76052)
* GRO-554 update storage upsell

* combine 2 enabling storage modals

* redesign csv tab + storage upsell

* update gdrive panel upsell / small tweaks on supported DBs for upload

* move StoragePurchaseModal + StorageSetupProvider to ee

* revert unnecesary test change

* remove etl-connections alongside dwh-rent on storage delete; add check for collecting analytics in upsell
2026-07-14 10:36:01 +02:00
Oleh K
ebea514c84 Keep dominant treemap share honest instead of rounding to 100% (#77602)
* Keep dominant treemap share honest instead of rounding to 100%

The treemap percent formatter used a fixed 2 decimal places, so a dominant
leaf's share rounded up to a misleading 100.00% (e.g. 100000 vs 1 rendered
as 100.00% instead of 99.999%).

Mirror the pie chart: derive the decimal count from every node share via
computeMaxDecimalsForValues, so a tiny sibling forces enough precision to
keep the dominant share honest. Floored at the existing two decimals so
ordinary treemaps are unchanged, and a genuine whole still shows a clean 100%.

Fixes GDGT-2761

* Pass tree to test setup via SetupOpts object
2026-07-14 10:15:29 +02:00
github-automation-metabase
622629ef6c Update translations 2026-07-14 (#77689)
* Update translation sources 2026-07-14

* Update translations

---------

Co-authored-by: github-actions <github-actions@github.com>
2026-07-14 07:04:45 +00:00
Fraser
d60573c199 Move single-consumer code to its consumer 2026-07-14 16:44:14 +12:00
Romeo Van Snick
71e305b6ab Dynamic/plugin route conformance (#77586)
* Add dynamic/plugin route conformance harness

* Add dynamic/plugin route conformance spec
2026-07-14 13:05:39 +10:00
Alexander Polyankin
e7211002cf Static viz imports optimization (#77658) 2026-07-13 22:40:54 -04:00
Romeo Van Snick
cf56c33cdd Delete react-router-redux and redux-auth-wrapper (#77590)
* Delete react-router-redux and redux-auth-wrapper

* Dedupe redux to a single v5 copy

Removing the @types packages dropped a transitive redux@3 pin that kept a
typeless redux at the top level and masked a redux@4-vs-RTK-v5 type conflict.
Force a single redux@5 so types stay consistent.

* Migrate remaining react-router-redux references

Drop the now-dead eslint import bans for the deleted package, remove the
obsolete redux-action cast in auth logout, and reword stale comments. Keep the
metabase/router provenance docs that name the package as their reference point.
2026-07-14 09:53:16 +10:00
Anderson
8eea1fc50b Convert visualization settings components and specs to TypeScript (#76759)
* Convert visualizations/components/settings/* to TypeScript (GDGT-1799)

* Remove castings

* Preserve null chart field values in field picker

* Address review
2026-07-13 20:23:26 -03:00
dpsutton
a420372ba0 Revert "update workflow triggers" (#77666)
Revert "update workflow triggers (#77662)"

This reverts commit bc0d27253e.
2026-07-13 17:57:21 -05:00
Fraser
0b7aa11b15 Remove querying e2e repros already covered by existing Lib/QP tests 2026-07-14 10:57:06 +12:00
dpsutton
bc0d27253e update workflow triggers (#77662) 2026-07-13 17:21:14 -05:00
Cam Saul
e3791b88e8 Change :template-tags from a map to a list (#77133)
* First pass for updating Lib

* Update metabase.lib.query.test-spec

* All Lib + Lib BE tests are passing

* Fix remaining tests in Lib + QP

* Update Lib JS template tag functions

* cljfmt

* Another round of test fixes 🔧

* Leave NativeQuerySnippet :template-tags alone for now; test fixes 🔧

* cljfmt

* kondo

* Test fixes 🔧

* FE test fix? 🔧

* Another round of test fixes 🔧

* Test fix 🔧

* Test fixes 🔧

* Test fix 🔧

* Test fixes 🔧

* PR feedback

* PR feedback

* 🔧

* Test fix 🔧
2026-07-13 14:14:16 -07:00
Michael Eby
6c25c78740 docs: pdfs in subscriptions (#77610)
* docs: pdfs in subscriptions

* Edit from Jeff
2026-07-13 17:08:04 -04:00
Nathan Voxland
b3cfb8d510 Persistent Queue (#76352) 2026-07-13 16:05:07 -05:00
Tyler Plude
2765c8d027 [GIT-74954] Fix search reindex hang on metric reference cycles (#77556)
Co-authored-by: mbql-backend-expert <agent@metabase.com>
Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
2026-07-13 20:50:43 +00:00
Jeff Bruemmer
dad63b3da3 docs - supported AI providers (#77603)
* supported AI providers

* overview

* models
2026-07-13 16:24:59 -04:00
Chris Truter
8ef62d8612 Support pgvector on the app DB with minimal config (#77371) 2026-07-13 20:20:24 +00:00
github-automation-metabase
e2e10c2867 Auto-update documentation for master (#77545)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-13 16:20:15 -04:00
Nick Fitzpatrick
ee29a82916 remount EditorBubbleMenu on hide (#77575) 2026-07-14 01:30:18 +05:30
Tyler Plude
ffdd62caaa Disable harbormaster metabot feedback & add appdb MCP feedback (#76932)
* disable metabot feedback harbormaster; add appdb persistence for mcp feedback

* fix kondo

* re-add metabot enabled check; fix migration

* update to v64
2026-07-13 12:59:27 -07:00
Nick Fitzpatrick
6e6bca18d0 Make getState generic for createThunkAction (#77615) 2026-07-14 01:26:49 +05:30
technomancy
5a6a2d84e2 Use qualified db names for locks in snowflake. (#77548)
* Use qualified db names for locks in snowflake.

We're seeing some timeouts in Snowflake on CI. There are a few reasons
for this, but part of it is that we are locking a lot waiting for
access to the datasets. These locks are currently based on unqualified
database names, not hashed and branch-qualified, so they lock more
often than they need to. Using the qualified names spreads things out
a bit.

In order to do this, we need to change the `dataset-lock` method to
take the whole dataset (to hash it) not just the dataset's database-name.

* Fix upload test to not assume table set is stable.

The purpose of this test is to ensure that the created table is gone,
but the assertion it makes is far too wide. This breaks in snowflake
where we have other tests randomly creating tables in the shared cloud
DB across jobs.
2026-07-13 11:44:02 -07:00
Alexander Polyankin
669dc959ff Remove unused code (#77613)
* Remove unused code

* Remove unused code
2026-07-13 14:38:16 -04:00
Ethan McCue
3554cc36fb onboarding: add Github username to team, add Github -> Slack ID mapping (#77608)
Update JSON files
2026-07-13 14:31:21 -04:00
Andrei Chernykh
5340d25eea Convert enterprise auth session middleware to TypeScript (#77399)
* Convert enterprise auth session middleware to TypeScript

* Fix sessionMiddlware -> sessionMiddleware typo

* Justify getState type cast in application permissions reducer
2026-07-13 10:42:03 -07:00
Arik Aronov
7a39244afe Show redirect destination on the OAuth consent page (#77578)
redirect dest in concent page + test for 3 cases
2026-07-13 20:02:33 +03:00
Chris Truter
f9dce94f95 Omit empty optional fields when serializing a transform index request (#77594) 2026-07-13 16:26:53 +00:00
Riley Thompson
2d7ed54076 Finish mbql5 compilation for more drivers (#76549)
* mysql mbql5

* clickhouse mbql5

* starburst mbql5

* sqlite mbql5

* presto-jdbc mbql5

* druid-jdbc mbql5

* vertica mbql5

* athena mbql5

* hive-like mbql5

* fix databricks
2026-07-13 12:20:57 -04:00
bryan
f4d3f69010 Native 2FA: EE scaffold, TOTP core, two-step login, recovery codes (#77449) 2026-07-13 16:15:58 +00:00
Andrei Chernykh
88c9058a51 Convert snippets and application_permissions plugin modules to TypeScript (#77398)
* Rename snippets and application_permissions plugin modules to TS extensions

* Convert snippets and application_permissions plugin modules to TypeScript
2026-07-13 08:44:34 -07:00
Kamil Mielnik
bd2df5059b GDGT-2770 RFC 147. Require justification for type casts (#77168) 2026-07-13 22:06:32 +07:00
Ngoc Khuat
4a12356ec8 Add Snowplow tracking for Index Manager (#77600) 2026-07-13 22:03:52 +07:00
Chris Truter
8e13d485ec Allow MCP to create text cards and headings on dashboards (#77362) 2026-07-13 14:55:37 +02:00
Chris Truter
4d849db7f8 Force a full rebuild when a transform index request is :failed (#77593) 2026-07-13 18:29:38 +07:00
Nicolò Pretto
5a024bd2ff chore(modules): fix embedding violations and start enforcing most of the modules (#77517)
* [pr-3] Move SDK error types to embedding-sdk-shared

* [pr-3] Move SDK auth-config types to embedding-sdk-shared

* remove un-useful usage of SdkCollectionId to remove import of sdk code in core app

we don't really need that type and they both end up being `number | string`

* [pr-3] Move PLUGIN_NOTIFICATIONS_SDK to the core app plugins

I don't particularly like this: this is one of those "plugins" used
both to activate enterprise code and to inject behavior from the SDK
into the core app. We don't have an alternative at the moment, so this
is the change with the smallest blast radius. The plugin was already
used in the core app, so this just moves it to the right place.

* [pr-3] Move onEditQuestion from the SDK dashboard context to DashboardContext

DashCardMenuItems (feature/dashboard) reached into the SDK bundle's
SdkDashboardContext just for the onEditQuestion override.
I moved the onEditQuestion to the DashboardContext instead, as
it's used in the core app dashboard.

* [pr-3] Remove CommonSdkStoryWrapper from SimpleDataPicker stories

It was not needed

* [pr-3] Move useLazySelector to the SDK package

The hook exists to read the lazy-loaded bundle's redux store from the
npm package, so the package is its natural home. Its only bundle-side
consumer, useInitDataInternal, already receives the redux store as a
parameter and now subscribes to it directly instead of going through
the window props-store singleton.

* [pr-3] Introduce SdkSharedStoreState

Some core app code currently needs to read _one_ piece of information
from the SDK redux state, I moved that piece of info into a new type
called `SdkSharedState` which I documented as being something we
should avoid adding to in the future.

* [pr-3] Promote embedding-sdk-bundle to the app tier

Promotes the sdk bundle to app tier, it needs a special rule for the
bridge
module that we'll hopefully clean up in the future

* [pr-4] Promote embedding-iframe-sdk to the app tier

EAJS becomes app tier, but we need to whitelist the theme preview from
importing it

* [pr-5] Move DashboardSharingEmbeddingModal to the dashboard module

The modal is dashboard UI living under metabase/embedding, giving the
embedding module an outgoing edge into dashboard (it imports
metabase/dashboard/selectors). Move it next to its domain so the next
commit can enforce the embedding module's outgoing boundaries.

* [pr-5] Move UserForm and group helpers to the common module

UserForm is used by the new "invite people to view" modal
(InviteToViewModal, which lives in metabase/embedding, shared tier),
so it moves out of feature/admin down to metabase/common together with
GroupsMultiSelect and the group utilities it depends on. Import paths
updated, no logic changes.

* [pr-5] Move DashCardMenuItem to the embedding-sdk plugins contract

It's imported by shared/embedding-sdk but it lived in feature/dashboard,
moved it down to remove violation that will be enforced on one of the next
commits.

* [pr-5] Enforce outgoing boundaries for shared/embedding and shared/embedding-sdk
2026-07-13 12:56:31 +02:00
Ngoc Khuat
fe4a72d76f Record model views in the view log (#77091) 2026-07-13 09:11:59 +00:00
Nicolò Pretto
31e79dc02d create new embedding modules - first pr (#77263)
* [pr-1] Define embedding modules

Defines the embedding modules without promoting them yet: modules whose
back-edges still need cleanup stay at their current tier (shared, outgoing
unenforced). Each module is then promoted to app in its own follow-up PR,
together with the fixes its back-edges require.

* [pr-1] Promote embedding-sdk-package to the app tier

The npm package is an entrypoint and should be able to import from
anything, and nothing should import from it.
I raised it up as app tier

* [pr-1] Promote embedding-sdk-ee to the app tier

This should probably be "embedding-features" in the future, but for now
I'm moving it to app to be above enterprise (which it imports from) and
to prohibit other things from importing from it

* [pr-2] Move LegacyStaticEmbeddingModalProps to the plugins contract

Module `embedding-iframe-sdk-setup` will be moved to app tier, so we move
`LegacyStaticEmbeddingModalProps` to the oss plugin file to avoid an import
going up to app

* [pr-2] Promote embedding-iframe-sdk-setup to the app tier

`embedding-iframe-sdk-setup` imports EAJS, which is app tier
so this also needs to be brought up to app tier
TBD how we want to structure this, but it kinda makes sense that some
parts of the core app are above EAJS as they use it (we also use it
to render theme previews in the admin settings for themes)
2026-07-13 09:28:59 +02:00
Chris Truter
64dfbf0bb3 Dedup the modules config.edn writer (#77571) 2026-07-13 08:32:30 +02:00
Romeo Van Snick
9a6f10f9dc Replace redux-auth-wrapper with guard components (#77259)
* Replace redux-auth-wrapper guards with facade guard components

* Convert admin route guards to facade guard components

* Full-page redirect for absolute post-login redirect targets

* Normalize post-login redirect target to an absolute URL

* Convert transforms route guard to facade guard component
2026-07-13 15:44:24 +10:00
Romeo Van Snick
1ad3f2b114 Move onEnter/onChange/onLeave to components and effects (#77264)
* Move root route onEnter/onChange/onLeave into components and effects

* Replace data-studio index onEnter redirect with a component

* Address review: settle LoadCurrentUser on rejection, drop test any-cast

* Point test Route import at the metabase/router facade

* Freeze has-user-setup on entry so the setup wizard is not interrupted

* Colocate route lifecycle components with the modules that own them

* Drop onEnter/onChange/onLeave from the facade's Route props
2026-07-13 14:47:04 +10:00
Tyler Plude
98424e1a61 [BOT-1807] Add metabot treemap chart support (#77568)
* add treemap chart support

* fix fe lint
2026-07-12 21:31:42 -07:00
Romeo Van Snick
4d47327087 Fix forbidden react-router-redux import in transforms route-guards (#77581)
Use metabase/router routerActions in transforms route-guards
2026-07-13 12:33:32 +10:00
Romeo Van Snick
29993aa6db Typescript 7 (#73979)
* Update to typescript 7.0 (beta)

* Switch to tsgo in scripts

* Remove NODE_OPTIONS from typecheck script

* Use typescript 7 instead of native-preview, but keep 6 around for lint

* Use typescipt 7.0.2

* Use real typescript 6.0.3 for eslint, run tsc 7 by explicit path

* Fix type errors surfaced by typescript 7
2026-07-13 08:41:36 +10:00
Alexander Polyankin
733e1c6f3e Change defaults for graalvm (#77573) 2026-07-11 18:22:31 -04:00
Alexander Polyankin
97f82c0792 mb-sql-parsing-mode=python (#77558)
* refactor(sql-parsing): protocol + graal split, render.js-style context pool

Mirror the static-viz renderer structure (channel/render/js) for the sqlglot
parser:

- protocol.clj: strongly-typed SqlParser protocol for the sql_tools operations
- graal.clj (replaces pool.clj): GraalPy implementation on a 0..2 dirigiste
  pool; contexts share one refcounted Engine and one bootstrap Source, created
  with the first context and closed with the last, so an idle pool releases
  all native memory (replacing the old TTL/min-size-1 leak mitigation);
  timed-out contexts are interrupted and disposed instead of released
- common.clj: create-pool copied as-is from render.js.common (replaces the
  PythonEval protocol); the future external-python impl will share it
- core.clj: public API unchanged; keeps JVM-side pre/post-processing
  (VALUES stripping, field/error conversion) and delegates through the
  protocol

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* tune(sql-parsing, static-viz): 0..3 pooled graal contexts, 10-minute idle reap

:idle-minutes is now an explicit create-pool option in both pool factories
(no default): graal pools (sqlglot + static-viz) keep idle workers for up to
10 minutes, the node renderer pool stays at 1.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(sql-parsing): native CPython parser, mirroring the static-viz node renderer

- python.clj: :python SqlParser running sqlglot in a pool of external CPython
  child processes speaking newline-delimited JSON over stdin/stdout
  (sql_tools_cli.py); in dev the child imports straight from
  resources/python-sources, from the jar the sources are written to a fresh
  temp zip per spawn (zipimport) and deleted with the process; single-process
  pool (0..1, 1-minute idle reap), timeout kills a wedged process, one retry
  when an acquired process turns out dead, call-level Python errors release
  the healthy process back
- settings.clj + parser.clj: sql-parsing-mode setting (:graalvm default |
  :python) and the mode-selection namespace, like static-viz-mode/renderer
- common.clj: python-sources locations + dev sqlglot install move here from
  graal.clj (shared by both transports), plus make-parser building the
  protocol reify over a transport call fn (marshalling written once)
- fix latent nil-schema bug in validate-query arg encoding: (json/encode
  (or schema "{}")) double-encoded, making Python treat the string "{}"
  as a strict-mode schema; encode an empty map instead

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(sql-parsing): transport-agnostic parse errors; 10-minute idle for process pools

Both parser transports now throw the same ex-info for Python-side failures
(common/call-failed-ex: :sql-parsing/error + extracted Python error type) —
graal wraps PolyglotException, the CPython transport wraps its ok:false
responses — and core exposes parse-error? so callers stop catching
PolyglotException (sql-tools.sqlglot updated; a python-mode instance
previously bypassed its parse-error fallbacks entirely).

Also raise the external-process pools (sql-parsing python, static-viz node)
to a 10-minute idle reap, matching the graal context pools.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(sql-parsing): un-nest testing blocks

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* build(docker): install python3 for the :python sql-parsing mode

Both images already carry nodejs for the :node static-viz renderer; add
python3 (~45MB on alpine) so MB_SQL_PARSING_MODE=python works out of the box.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* build(docker): default sql-parsing to python and static-viz to node in the entrypoint

The image ships python3 and node, so prefer the external-process backends
(lighter and faster than in-process GraalVM) unless MB_SQL_PARSING_MODE /
MB_STATIC_VIZ_MODE are set explicitly, following the MB_JETTY_HOST pattern.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* tune(static-viz): keep the node process pool at a 1-minute idle reap

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(sql-parsing): wire settings into module init

metabase.core.init-test requires every .settings namespace to be reachable
from an init namespace; add metabase.sql-parsing.init and register it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-11 16:16:44 -04:00
Chris Truter
6188ef843f Resolve the default search engine from capability precedence (#77418)
* Resolve the default search engine from capability precedence

The search-engine setting's :appdb default meant the engine precedence
list never chose semantic, no matter how many of its dependencies were
met. Engine selection now works in three layers:

- supported-engine? is a pure capability check (app-db type, premium
  features, infrastructure) and no longer reads the search-engine
  setting.
- The default engine is the configured override when servable,
  otherwise the first supported engine in the precedence
  (semantic > appdb > in-place). Unknown configured values warn once
  and degrade instead of breaking all of search.
- Indexes are maintained for the default engine, the engines it
  declares as dependencies (semantic mixes in appdb results), and any
  engines opted in via the new additional-search-engines setting.

Reading the search-engine setting now resolves the engine that
actually serves search, so the admin UI needs no changes; the raw
override is available via configured-search-engine.

An explicitly passed per-request search_engine that cannot serve now
returns a 400 naming the cause (unknown / not supported / not enabled)
instead of silently falling back; legacy engine cookies keep the
fallback. The engine-active prometheus metric now reports active-set
membership rather than capability.

MB_SEMANTIC_SEARCH_ENABLED remains a kill switch, folded into the one
canonical semantic availability predicate (so repair/cleanup tasks now
respect it too); it will be removed once Cloud stops setting it.

Part of BOT-1832

* Tighten search engine docstrings and comments

* Validate cookie-carried search engines before use

A stale engine cookie naming an unmaintained index (e.g. appdb on an
in-place-default instance) now degrades to the default engine instead
of querying a missing index. The in-place exemption in engine-active?
uses = rather than isa?, so derived engines don't inherit a free pass.

Updates the prometheus search-engine-metrics-test to the new
engine-active semantics.

Part of BOT-1832

* Serve per-request engines through validated query-params; gate semantic writers on activity

Review follow-ups from roborev job 2600 and the workflow review:

- The engine middleware now reads and writes :query-params - the
  :params injection had been dead since the api.macros migration, so
  engine cookies had no effect on the served engine. Cookie values are
  validated (stale/unknown degrade to the default), and param values
  are normalized: blank means absent, the qualified form the API
  returns in :engine is accepted, and the legacy fulltext name maps to
  appdb at the boundary so activity checks use exact matches.
- engine-status in search.engine is the one classification of whether
  an engine can serve (:ok/:unknown/:unsupported/:inactive); the API
  layer maps it to 400s and no longer re-encodes engine invariants.
- Semantic fallback (EE core and the metabot search tool) prefers
  engines with a maintained index over merely supported ones, so an
  in-place default with additional-search-engines=semantic mixes with
  the warm appdb index instead of in-place.
- The semantic indexer and index-repair tasks gate on the new
  semantic-search-active? instead of availability, so a supported but
  inactive semantic index no longer accrues hourly embedding spend.
- active-engines guards the pre-init nil default and only
  capability-checks dependency entries.

Part of BOT-1832

* Canonicalize legacy engine names at every boundary; tolerate repeated engine params

search.engine/canonical-engine resolves legacy names (fulltext -> appdb)
for configured values, additional-search-engines, and request
params/cookies alike, so active-engine membership compares exactly.

A repeated search_engine query param parses as a vector; the middleware
now passes it through for schema validation to reject with a 400
instead of throwing.

Part of BOT-1832

* Review cleanups: single evaluation of engine resolution values

Bind configured-engine, the parsed param engine, and active-engines
once per expression instead of re-evaluating (Copilot); remove blank
lines inside the check-engine-serves! case form (CodeRabbit).

Part of BOT-1832

* Engine-active metric means can-serve; harden param parsing and dependency filtering

engine-active shares engine-status's definition: in-place is always
active while it exists, indexed engines while their index is
maintained. Fixes the prometheus test assertion that compared a metric
to itself.

param->engine strips the search.engine/ prefix rather than splitting on
slashes, so junk values 400 with the full value named instead of
validating their last segment, and degenerate values like // cannot
produce an empty or nil keyword.

active-engines filters dependency engines through known-engine? before
supported-engine?, matching the startup-ordering guard in
supported-engines.

Part of BOT-1832

* Reject malformed explicit engine values instead of treating them as absent

A non-blank search_engine that strips to a blank suffix (e.g.
search.engine/) parses to an unknown engine and 400s naming the raw
value; only genuinely blank values fall through to the cookie/default.

Part of BOT-1832

* Clarify the unknown-engine filter comment in supported-engines

* Fix review findings: runtime kill switch, csv hygiene, cookie unpinning, shared fallback

- Semantic Quartz jobs are scheduled when the instance is capable
  (pgvector + feature) and check availability/activity per execution,
  so the kill switch works at runtime again instead of gating job
  scheduling at boot.
- semantic-search-active? is plain active-set membership; the HNSW
  build gates on it like every other index writer.
- additional-search-engines values are trimmed, blanks dropped, and
  qualified/legacy names canonicalized (prefix handling now lives in
  canonical-engine, the one boundary fn).
- An explicit blank search_engine clears the engine cookie (the unpin
  mechanism this branch had removed) instead of being ignored.
- fallback-engine lives in search.engine; the EE semantic core and the
  metabot search tool share it.
- The runtime-activation backfill note moved from the
  additional-search-engines description to a comment.

Part of BOT-1832

* Initialize the semantic index from repair when none is active

Semantic can become active at runtime (kill switch re-enabled, or added
to additional-search-engines) without init! ever having run; the hourly
repair task now initializes and backfills in that case instead of
no-oping until a manual /re-init.

Also renames warn-once to warn-once! per the side-effect convention and
adds end-to-end coverage for the pinned-cookie and blank-unpin paths.

Part of BOT-1832

* Cover the repair-initializes path; unpin test asserts the resolved default

The blank-unpin api test compared against a hard-coded appdb default,
which does not hold on MySQL/MariaDB app dbs. New repair test starts
from a blank pgvector db and asserts repair-index! creates an active
index and gates the documents.

Part of BOT-1832

* Trigger search index init when additional engines are set at runtime

Registers the (previously dangling) init-job-key as a durable,
trigger-less quartz job wrapping the search init, and the
additional-search-engines setter fires it when it exists. In tests the
scheduler is not running, so the setter stays side-effect free there;
env-var configuration is covered by the startup init.

Part of BOT-1832

* Rename the engine cookie and cover the pin/unpin round trip

metabase.SEARCH_ENGINE becomes metabase.SEARCH_ENGINE_OVERRIDE, so the
population of long-lived cookies written before engine validation
existed stays inert.

The round-trip test covers pinning via an explicit param, serving from
the cookie, and clearing it with a blank param.

Part of BOT-1832

* Order semantic capability gates cheapest first

The license check short-circuits before the pgvector URL check, whose
slot becomes a DB probe under BOT-1796.

Part of BOT-1832

* Only trigger search init when the setting change activates an engine

Semantic init re-gates every searchable document, so an unconditional
trigger made any write to additional-search-engines cost a full app-db
sweep. The setter now diffs active-engines across the set and triggers
only for newly activated engines.

Part of BOT-1832

* Defer the engine-activation trigger to after commit

The activation diff and quartz trigger run via do-after-commit in a
future (extracted to trigger-init-for-newly-active-engines!), observing
the final committed settings state - a surrounding set-many! may
include the setting that makes the engine supported - without I/O on
the transaction's thread.

The cookie round-trip test uses the in-process client so the handler
runs inside the fixture's engine and index bindings.

Part of BOT-1832

* Review nits: log async trigger failures, quote the cookie regex, fix a docstring

The post-commit init trigger logs exceptions instead of dropping them
in the future; the cookie test quotes the cookie name before building
its regex; build-hnsw-index-async! says active, matching its gate.

Part of BOT-1832

* Schedule semantic jobs on the boot-static gate; indexer initializes missing indexes

Job scheduling happens once at startup, so it now gates on the only
boot-static input: whether a pgvector DB is configured. The runtime
gates (license, kill switch, engine activity) are checked per
execution, so applying a license or re-enabling the kill switch at
runtime no longer strands semantic as an unindexed default until
restart.

The indexer's 20-second tick initializes the index when it is missing,
so every runtime activation path (license, kill switch, setter on a
stale cluster node) converges within seconds instead of waiting for the
hourly repair or a restart.

Also: the blank-param unpin deletes the engine cookie (max-age 0)
instead of writing an empty 20-year one; the activation trigger helper
lives in search.task.search-index with static requires; the setter test
uses poll-until for the async positive case and a direct synchronous
call for the negative.

Part of BOT-1832

* Runtime self-heal initializes all active engines and the HNSW index

The indexer's missing-index branch runs the generic search init, which
covers newly active dependencies, and applies the same HNSW-strategy
safety net as task registration.

Part of BOT-1832

* Ensure the HNSW index on the indexer's active path

An index-backed strategy configured while semantic was inactive misses
the setter's build event; the indexer tick now fires the async build
when the active index lacks its HNSW index. The pg_indexes existence
check is self-limiting: CONCURRENTLY registers the index when the build
starts.

Part of BOT-1832

* Fix engine tests on app dbs without appdb search support

Explicitly requesting an unservable engine now 400s instead of silently
falling back, so tests must not hard-code appdb: the data-studio search
tests iterate only supported engines, the cookie staleness test pins
in-place (servable everywhere), and the not-enabled case runs only
where appdb is supported.

Also realigns warn-once! call args (cljfmt).

Part of BOT-1832

* Keep semantic active under the search test fixtures

active-engines now derives from the default engine, so fixtures that
pin default-engine were silently deactivating semantic: semantic
queries in the metabot search tool fell through to the term engine.
Both fixtures pin active-engines to the set the old derivation gave
them - appdb plus semantic when supported, or semantic alone for
legacy search.

Part of BOT-1832

* Rename with-new-search-* test fixtures to with-appdb-search-*

The appdb engine predates semantic search; new no longer disambiguates.

Part of BOT-1832

* Update the last supported-implies-active consumers

The metabot semantic-search feature predicate gates tool schemas on
engine-status :ok rather than capability, so semantic_queries is only
advertised when a semantic index is actually maintained.

The metric collector runs only when semantic is active, and index
cleanup no-ops until the bookkeeping tables exist: available but never
initialized is now a steady state, and both jobs would otherwise warn
or throw about missing tables on every run. Cleanup still runs while
merely available so an opted-out instance's leftover indexes get
dropped.

Part of BOT-1832

---------

Co-authored-by: Tyler Plude <tsplude@gmail.com>
2026-07-10 20:16:56 -07:00
Romeo Van Snick
544a0c2ba8 Migrate query_builder/analytics to TypeScript (#76934)
* Migrate query_builder/analytics to TypeScript

* Type Card.creationType and drop analytics cast

Address review: type Card.creationType as a union instead of a plain
string, narrow Question.creationType(), and make the new_question_saved
type field optional/nullable to match the Snowplow schema. Removes the
cast in the analytics tracker.

* Drop as const in load-question via Card annotation
2026-07-11 09:33:43 +10:00
Romeo Van Snick
836e12b526 Re-own react-router-redux behind the metabase/router facade (#77142)
* Re-own react-router-redux mechanisms behind the metabase/router facade

* Wire store, app and store types onto the re-owned router facade

* Re-point react-router-redux call sites onto metabase/router

* Update router tests and harness for the re-owned facade

* Ban react-router-redux imports outside metabase/router

* Model routing state's null location contract instead of casting

* Flatten CallHistoryMethodAction into per-method history action types

* Match history actions with ts-pattern in routerMiddleware

* Preserve explicit null location in createMockRoutingState
2026-07-11 09:33:29 +10:00
Ben Grabow
ba83271710 Auto-fix modules config.edn (#77541)
* Auto-fix modules config.edn

* Extract generic nrepl integration wrapper

* Remind claude to use this

* Demo the module config fixer with some tests
2026-07-10 17:20:33 -05:00
dpsutton
6b855cbe81 feat(dev): browser-based email template previewer (#77546)
Adds `bun run email-dev`: a small Bun server + static page that renders
the Handlebars email templates in src/metabase/channel/email/ with
editable sample data, so designers and copywriters can iterate on email
copy and layout without running Metabase or sending real emails.

- live-reloads when a .hbs file changes on disk (1s polling)
- Fields/JSON panels to fill in template values; edits persist in
  localStorage per browser
- Desktop/Narrow/Phone width toggles and Copy HTML
- sample-contexts.js mirrors the real send-time contexts (traced from
  messages.clj and the notification handlers)
- mirrors the jknack custom helpers (equals, format-date, now, initials,
  card-url, dashboard-url, trash-url) in handlebars.js

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-10 17:09:04 -05:00
Andrei Chernykh
b8673198cd Migrate Link, ListItem, and LoadingSpinner from Emotion to Mantine + CSS modules (#77323)
* Migrate Link, ListItem, and LoadingSpinner from Emotion to Mantine + CSS modules

* Fix TableList disabled-state assertions by exposing data-disabled instead of relying on Emotion-injected styles
2026-07-10 13:47:48 -07:00
lbrdnk
87f0514519 Mention archival and soft deletion in MCP metric update API (#77525)
* Mention archival and soft deletion in MCP metric update api

* Update src/metabase/agent_api/api.clj

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

* Update src/metabase/agent_api/api.clj

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

* Extend update-metric-archive-test

---------

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
2026-07-10 22:43:57 +02:00
Nemanja Glumac
dea12ca75c Wire the test-driver action to work with the Quarantine switch (#77476) 2026-07-10 21:12:56 +02:00
Nemanja Glumac
71863190b1 Wire the quarantine switch into the embedding e2e workflows (#77518) 2026-07-10 19:07:34 +02:00
Eric Normand
5a4f82063e Name the referring entity in remote sync not-found errors (#77430)
* Name the referring entity in remote sync not-found errors

When an import references content that doesn't exist on this instance, the
error named only the missing entity's raw serdes id. It now also names the
entity holding the dangling reference, and backtick-quotes names and ids so
leading and trailing whitespace is visible.

`load-one!` takes the referrer as an explicit parameter rather than carrying
it on the load context: `load-deps!` reduces over sibling deps and each
recursive `load-one!` returns its own context, so a context key would leave
later siblings labelled with the deepest child's referrer.

Message construction lives in `missing-reference-message` so the format can
change without touching the throw sites.

* Attach the referrer by catch-and-rethrow instead of threading it

Replaces the extra `load-one!`/`load-deps!` parameter with a try/catch around
the dependency load. The nearest enclosing `load-one!` unwinds first, so it is
the frame that attaches itself as the referrer; outer frames see the key
already present and rethrow unchanged. The original exception is kept as the
cause, preserving the stack trace of the detection site.

Adds an end-to-end assertion in bare-import-test that a real import of a Card
referencing a missing Database carries the Card as `:referrer`, which the
hand-built ex-info unit tests could not cover.

* Key the database-not-found error off ex-data, and name the referring card

`source-error-message` detected this case by matching "database not found"
against the cause's message text, then interpolated that raw internal string
into the user-facing error:

  Import failed: A referenced database does not exist on this instance.
  table id present, but database not found: [clickhouse nil some_table]

`import-table-fk` now tags the throw with `:error ::database-not-found` and
`:db-name`, and the render walks the whole cause chain looking for that key
rather than checking only the immediate cause. `::load-failure` carries the
referring entity, so both missing-content paths now render through
`missing-reference-message`:

  Import failed: Card `Some card` (`abc123`) references Database (`clickhouse`),
  which does not exist on this instance. ...

Also fixes `:database-names` in that ex-data, which selected names from
:model/Table rather than :model/Database. It has no consumers.

The end-to-end test uses a result_metadata `:table_id`, since that is the path
that actually reaches `import-table-fk` with an undeclared database:
`result-metadata-deps` derives deps only from `:field_ref`, and a Card's own
top-level `table_id` is recomputed from `dataset_query` by
`populate-query-fields` on insert.

* Backtick-quote file paths in remote sync ingest-error messages

GHY-3992 asks for content names to be quoted so leading and trailing
whitespace is visible. The ::not-found path already did this; the
ingest-errors branch still joined raw paths, and the message already uses
": " between path and reason and "; " between entries, so a path containing
punctuation or trailing space was ambiguous to read.

No fallback is added for a nil :file. All three ingest-error producers
(ingest.clj file-hierarchy!, ingestable.clj read and parse failures) always
set it, and only YamlIngestion and IngestableSnapshot produce a non-empty
ingest-errors; the other Ingestables delegate.

Splits source-error-message-entity-not-found-test into three deftests, one
per error branch, which kondo requires now that each has grown assertions.

* Render load-failure errors with the entity name, reason, and stripped keys

::load-failure fell through to the generic "Failed to reload from git
repository: <ex-message>" fallback, showing a NanoID and burying the
stripped-keys note. It now reads:

  Import failed: could not save Card `Orders by Month` (`abc123`).
  NOT NULL constraint failed: report_card.display.

and, when the entity was part of a dependency loop, adds "It may have been
saved without: `dashcards`, `parameters`." — a partial row for it survived
the import, which the user previously had no way to learn.

Renames the ::load-failure ex-data key `:referrer` to `:entity`. It names the
entity that failed to load, which is a referrer only relative to the missing
database in the ::database-not-found case; that branch now reads `:entity` and
passes it as the referrer. ::not-found keeps `:referrer`, where it really is
the parent.

The new branch is ordered after the tenant-collection and database-not-found
branches, both of which match on causes that a ::load-failure wraps.

::circular is left on the fallback. Rendering its cycle needs an ordered
expansion chain — `expanding` is a set — and it only fires when the
key-stripping recovery has already failed.

* Address CodeRabbit review

- Remove a duplicated `testing` block in impl_test.clj. It was byte-identical
  to the one above it, introduced when the deftest was split. Replaced with a
  doseq covering trailing, leading, and no surrounding whitespace.
- Mark `missing-reference-message` and `load-failure-message` private; neither
  is used outside impl.clj.
- Capture the exception once in bare-import-test's not-found case instead of
  running the same failing import twice, and flatten the resulting nested let.
2026-07-10 16:24:16 +00:00
Riley Thompson
9197dc9057 Fix path in location-connection-properties (#77322)
fix path
2026-07-10 14:53:47 +00:00
Sébastien
0b9e1c0be4 Show the SQL editor when useMetabot opens a native question (#77370) 2026-07-10 16:18:42 +02:00
github-automation-metabase
46d217cf64 Auto-update documentation for master (#77469) 2026-07-10 09:23:39 -04:00
Chris Truter
f9ecaf7f92 Fix weak assertion in create-table-from-schema!-test (#77520) 2026-07-10 13:13:42 +00:00
Chris Truter
ae56aaf2b2 Fix the shadow-cljs warning from lib.core's macro re-export (#77521) 2026-07-10 13:08:42 +00:00
Egor Grushin
ab9a3e191a GDGT-2766 GDGT-2766 Migrates deprecated FormTextInput and FormInput components (#77161)
* GDGT-2766 GDGT-2766 Migrates deprecated FormTextInput and FormInput components

* GDGT-2780-2766 DRY FormInputWidget

* GDGT-2780-2766 fix lost margin

* replace with new FormField

* fix marging

* rollback be.visible to exist in action e2e specs

* replace HTML_INPUT_TYPES map with inline ts-match

* fix margin
2026-07-10 13:54:37 +01:00
Sébastien
9f42bcf323 Apply global dashboardCardMenu plugin from MetabaseProvider to dashboards (#77500) 2026-07-10 14:28:51 +02:00
Chris Truter
130888462d Fix the metabot semantic-search tests not runing in CI (#77519) 2026-07-10 11:18:03 +00:00
Ngoc Khuat
32a869b1e6 Index manager (#75848) 2026-07-10 11:05:07 +00:00
Alexander Polyankin
f7f8697947 Add tests for the node static-viz renderer (#77508) 2026-07-10 03:41:13 -04:00
Timothy S. Dean
960d036afd Bump js-yaml to 4.3.0 (#77459)
Bump js-yaml to 4.3.0
2026-07-10 00:49:07 -06:00
da
60e1b995d3 Add CSV uploads to Snowflake (#77239)
Co-authored-by: Chris Truter <chris@metabase.com>
2026-07-10 04:18:36 +00:00
Sébastien
15195d006a fix(sdk-bundle): restore back button after "Edit question" in embedded dashboards (#77389) 2026-07-10 06:14:14 +02:00
appleby
5bd7fa6247 Support OpenRouter (#77139)
* Fix metabase.metabot.api/openrouter-model-group

Fallback to parsing the id if the display_name has no ":"-separated prefix.

* Add a default OpenRouter model so connect-without-model works

Without an entry in default-llm-metabot-model-by-provider, a PUT /api/metabot/settings that connects openrouter with
only an API key would save the key but silently fail to switch llm-metabot-provider.

* Use real dotted OpenRouter model IDs in defaults and docs

OpenRouter model IDs use dots in version numbers, e.g. anthropic/claude-haiku-4.5. The hyphenated
anthropic/claude-haiku-4-5 referenced by the default args and docstrings does not exist.

* FE: enable openrouter provider in metabot admin UI config

* Whitelist openrouter models

Filter openrouter list-models down to the same curated Anthropic and OpenAI model set the direct providers support,
instead of returning the full ~340-model catalog.

* Throw an exception if callers pass :ai-proxy true for openrouter

Similar to bedrock and openai, supporting this would require work on the ai-service side, and we already reject
non-anthropic providers in validate-metabase-managed-provider!

* Remove explicit credentials check in list-all-models

We want to allow callers to omit the creds and fallback to the configured api key from settings. core/resolve-auth
still handles the auth check and will throw if no credentials are provided or configured.

* Support prompt caching for openrouter

Report `:cacheCreationTokens` and `:cacheReadTokens` in the `:usage`.

For anthropic models, add the `:cache_control` breakpoint on the system message to enable caching (openai caching is
automatic).

* Apply code review suggestion in AIProviderSettingsSection.unit.spec.tsx

Co-authored-by: Maksym Yakubych <undrfined@gmail.com>

* Add gpt-5.6 and drop gpt-5 from openrouter supported-models

See also #77450

* Apply code review suggestion in fe tests

Co-authored-by: Maksym Yakubych <undrfined@gmail.com>

---------

Co-authored-by: Maksym Yakubych <undrfined@gmail.com>
2026-07-10 00:47:30 +00:00
Alexander Polyankin
6eff4789f0 Static viz node renderer (#77419) 2026-07-09 20:16:11 -04:00
Egor Grushin
fe6bc8a408 Gdgt 2587 2581 replace deprecated numericinput components (#77117)
* GDGT-2587 GDGT-2581 migrate deprecated components

* GDGT-2587 GDGT-2581 get rid of deprecated components

* GDGT-2581 fix tests

* fix tests

* GDGT-2584 DRY FormNumberInputWidget

* GDGT-2587-2581 fix floats + cover the change with a test

* GDGT-2587-2581 fix a test

* GDGT-2587-2581 addressing PR's comments

* GDGT-2587-2581 small UX improvement

* GDGT-2587-2581 stronger assertions in model-actions test

* GDGT-2587-2581 remove spreading

* GDGT-2587-2581 scrollIntoView before visibility asserts

* GDGT-2587-2581 assert exist not visible for constraint errors
2026-07-10 01:00:25 +01:00
Timothy S. Dean
117020fc2e Pin linkify-it to 5.0.2 (#77457)
Pin linkify-it to 5.0.2
2026-07-09 17:06:06 -06:00
Egor Grushin
b9bba24cfd GDGT-2584 migrate FormTextArea (#77089)
* GDGT-2584 migrate FormTextArea

* GDGT-2584 remove unused code

* GDGT-2581 fix error labeling

* GDGT-2584 DRYed FormTextareaWidget

* GDGT-2584 make textarea resizeable for the snippet form

* GDGT-2584 restore actions

* GDGT-2584 fix margin

* GDGT-2584 fix margins
2026-07-09 23:27:35 +01:00
appleby
a817ed88a6 Add gpt-5.6 to openai supported-models (#77450)
* Add gpt-5.6 to openai supported-models

* Drop gpt-5 from openai supported-models
2026-07-09 22:21:36 +00:00
Eric Normand
0a3932e9cf Move remote-sync branch switching into Settings with destructive-action guard rails (GHY-4019) (#77286)
* Move remote-sync branch switching into Settings with guard rails (GHY-4019)

Branch switching ran a full import that hard-deletes any synced-collection
content absent from the target branch, and it lived as a routine app-bar
dropdown item. A forced switch could permanently delete never-pushed content.

Backend:
- spec: detect collection-scoped deletion conflicts (Cards/metrics, Dashboards,
  Documents, Timelines), not just the transform family; wire into get-conflicts
- import: expose force_deletion on POST /import so a forced version/dirty
  override no longer silently forces deletions
- async-import dirty guard now returns the dirty objects (what would be lost)
- PUT /settings rejects a read-write branch switch (must use the guarded import);
  read-only changes and first-time config still allowed

Frontend:
- remove the Switch branch affordance from the app-bar sync controls (branch
  name stays as a read-only label; push/pull intact); drop the switch-branch
  conflict variant
- add a guarded branch switcher to the read-write Settings panel: destructive
  warning copy, hard block when there are unsaved changes (lists them, no force
  path), destructive confirm when clean, stale-tab handling

* Refine Settings branch switcher: choice modal, admin gating, direct clean switch

Follow-up to the branch-switching rework, from review feedback:

- Offer a choice modal (push / new branch / discard) when switching with
  unsaved changes, instead of a hard block — restores the switch-branch
  conflict variant, now driven from the Settings panel BranchSwitcher.
- Drop the destructive confirmation on a clean switch: with everything pushed
  the switch is reversible, so it runs directly.
- Show a red "N unsaved change(s)" label beside the dropdown when dirty.
- Gate the switcher on superuser: non-admins (e.g. settings managers) see the
  section with an "admin required" message instead of a control they can't use;
  the section no longer depends on the admin-only branch setting being readable.
- Match the section subtitle styling to the other settings sections.
- Strengthen the import superuser test to cover a branch switch.

* Update remote-sync E2E for Settings-panel branch switching

Branch switching moved from the app bar to the Settings panel, so the
branching specs and helpers drive it there now:

- Replace the app-bar switch helpers with Settings-panel ones
  (visitRemoteSyncSettings, getSettingsBranchSwitcher,
  createBranchViaSettings, switchBranchViaSettings).
- Rewrite the branching tests to create/switch branches on the Settings
  page, navigating back to the app for content changes.
- Switching with unsaved changes opens the choice modal (wait for the
  unsaved-changes indicator first); a clean switch goes directly.
- Snowplow triggered_from: app-bar -> admin-settings.

* cljfmt

* Address review: guard-bypass fix, anti-join, shared removal predicate

- api: block blanking the branch in read-write mode too, so it can't be used to
  reset the branch-switch guard and then switch freely; regression test added.
- spec: compute collection deletion conflicts with a SQL anti-join + count/limit
  instead of loading every candidate and an exists? per row, so it scales when a
  switch would drop a large synced collection.
- Extract spec/removal-where-clauses as the single definition of what an import
  reconcile removes for a model; remove-unsynced! and the deletion-conflict check
  both build their WHERE from it (removes the duplicate build-entity-id-where-clause).
- Add a parity test asserting the conflict warning is exactly the unsynced subset
  of what remove-unsynced! removes.
- Nits: be.visible for the dirty-warning indicator; wrap a long test string.

* Build the deletion-conflict WHERE with a thread-first instead of nested into/conj

* Give check-deletion-conflicts the same anti-join as the collection check

Was doing a t2/exists? per candidate (and materializing every candidate).
Now counts via one SQL anti-join, sharing removal-where-clauses and the new
model-id-column / unsynced-anti-join helpers with check-collection-deletion-conflicts.
Adds a direct spec-level test for it.

* Build collection deletion conflicts with cond-> instead of if/into

* Cover NativeQuerySnippet in the deletion-conflict warning

Generalize check-collection-deletion-conflicts -> check-content-deletion-conflicts:
warn before an import deletes any unsynced entity-id content, not just collection-
scoped models. This pulls in NativeQuerySnippet (global, no collection scope), which
otherwise fell through both conflict checks and could be silently deleted on a forced
import/branch switch. Collection stays excluded (structural; its contents are covered).
Adds a snippet test case.

* Address branch-switch review: drop force_deletion param, refetch dirty at switch, add tests

- Remove the unused force_deletion param from POST /import (schema, destructure,
  and async-import! call); internal force-deletion? threading is unchanged.
- BranchSwitcher refetches dirty state at switch time so a stale settings-page
  snapshot can't route a switch down the wrong (delete-without-warning) path.
- Add BranchSwitcher unit tests: non-admin message, dirty count label,
  clean direct switch, and the choose-what-to-do modal on the dirty path.

* Left-align the branch value in the settings switcher for consistency with other selects

* Show a 'Using <env var>' note when the sync branch is pinned by an env var

* Fix branch-switcher e2e: scroll the switcher into view, drop spurious branch-switched event

The Sync branch section sits below the fold at the default viewport, and Cypress treats an element
clipped by a scrollable ancestor as hidden, so the switcher assertions failed (surfaced by
testing-library as a misleading "Unable to find an element"). Scroll to it before asserting.

BranchSwitcher also reported a branch switch when creating a branch, emitting a spurious
remote_sync_branch_switched alongside the branch picker's remote_sync_branch_created. Creating a
branch forks the current one without a reconcile, so only the creation is reported now.
2026-07-09 22:15:44 +00:00
Nemanja Glumac
44dc41a7fa Introduce the Quarantine Control Knob (#77417)
Introduces a `QUARANTINE_ENGINE` variable that acts as a control knob. Either Trunk enforces a quarantine or CI conductor does. So far wired only in three places:
1. fe
2. be
3. e2e
2026-07-09 21:34:00 +00:00
Ben Grabow
f0ef171d25 Ghy-4069 minimal migration approach (#77297)
* Upgrade H2 -> SQLite sample DB by mutating database :driver
2026-07-09 16:29:28 -05:00
Chris Vandoodewaard
5373a65352 Revert "Update translations 2026-07-07" (#77456)
Revert "Update translations 2026-07-07 (#77151)"

This reverts commit 5f56057bfe.
2026-07-09 21:27:36 +00:00
Chris Vandoodewaard
a169d4ab75 remove experimental linear-release-sync workflow (#77302)
* remove experimental linear-release-sync workflow

* remove linear-release-lifecycle job from release workflow

* also cleanup helper functions
2026-07-09 16:47:05 -04:00
Timofey Kachalov
31a0379d5d Update jackson.* dependencies to 2.21.5 (#77427) 2026-07-09 23:55:33 +04:00
Eric Normand
950f453535 Preserve native model column types during serialization (GHY-4043) (#77405)
* Preserve native model column types during serialization (GHY-4043)

export-result-metadata checked (model? card) before the native branch, so
native models were routed through lib/model-preserved-keys — a metadata-merge
soft-key set that omits :base_type/:effective_type. On a read-only Remote Sync
target the column types could not be re-derived without executing the SQL, so
computed columns (e.g. STRING_AGG(...) AS names) fell back to type/* and their
filter UI collapsed to Is empty / Not empty.

Reorder the cond so native cards — models included — go through the branch that
preserves structural type info; only MBQL models, whose types are re-derivable
from the query at import, use the soft-key set.

* Update native-model extract test for preserved column types

extract-result-metadata-native-model-test asserted the old behavior — that a
native model dropped :base_type on export. Update it to expect structural type
info to survive, matching the GHY-4043 fix. Drop the now-unused clojure.set
require.
2026-07-09 19:31:44 +00:00
Kevin Kelleher
7a20b77fbd Add enable/disable setting for Transforms in Data Studio (#75710)
* transform enable/disable setting

* fix test, change approach for self hosted

* fix tests

* fix tests, self review

* add tests

* fix ci

* fix lint

* address review comments

* address review comments

* fix ci

* changelog 63 -> 64

* fix lint, test

* another lint
2026-07-09 19:29:55 +00:00
Maksym Yakubych
7d1f271280 fix: move data complexity lower on the stats page (#77003)
Closes [BOT-1797: Move data complexity lower on the stats page](https://linear.app/metabase/issue/BOT-1797/move-data-complexity-lower-on-the-stats-page)

### Description

Move data complexity lower on the stats page, decrease font size and copy length.

### How to verify

1. Go to Admin settings -> AI.
2. Scroll down to the data complexity section.

### Demo

<img width="1840" height="1120" alt="image" src="https://github.com/user-attachments/assets/627935fd-e9d2-40d6-8c1c-7b2a52c35394" />

### Checklist

- [x] Tests have been added/updated to cover changes in this PR
- [x] If adding new Loki tests: they pass [stress testing](https://github.com/metabase/metabase/actions/workflows/loki-stress-test-flake-fix.yml)
2026-07-09 16:14:13 -03:00
appleby
a9b9b7bb59 Ensure openai reports :cacheReadTokens in :usage (#77341)
* Ensure openai reports `:cacheReadTokens` in `:usage`

Add `openai-usage->aisdk-usage` to convert openai usage format to aisdk format and report `:cacheReadTokens`.

* Add undocumented :cache_write_tokens as well
2026-07-09 19:08:11 +00:00
Eric Normand
368ed03818 Preserve MySQL role name case when expanding role grants (#77415)
`parse-grant` lowercased role names parsed out of `SHOW GRANTS FOR <user>`.
Those names are fed back into `SHOW GRANTS FOR <user> USING <roles>`, and
MySQL 8 treats backticked role identifiers as case-sensitive, so any role
with uppercase characters made the follow-up query fail with error 3530 and
took the whole metadata sync step down with it.

Lowercasing is still correct for the privilege types in the sibling
`:privileges` branch; it was never right for role identifiers.

Also add the missing space before `USING` in the follow-up query, which
only parsed because the user identifier ends in a backtick.
2026-07-09 13:42:32 -05:00
Alexander Polyankin
ffbddbbc6f Static-viz: dispose ECharts instances (OOM fix) + faster SVG dominant-baseline patch (#77412)
* Static-viz: dispose ECharts SSR instances + faster SVG dominant-baseline patch

Two isolated, output-preserving fixes to the static-viz render path:

- Dispose the ECharts/zrender SSR instance after renderToSVGString() in every
  chart component. These instances were never released, leaking ~MBs per render
  and OOMing a long-lived renderer process; memory is flat after.

- Replace patchDominantBaseline's full hast parse+serialize round-trip over the
  whole SVG with a targeted string transform (like the sibling
  transformSvgForOutline), cutting a large share of big-chart render time with
  byte-identical output.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Update BoxPlotChart.tsx

* Update ComboChart.tsx

* Update PieChart.tsx

* Update SankeyChart.tsx

* Update ScatterPlot.tsx

* Update TreemapChart.tsx

* Update WaterfallChart.tsx

* Drop hast deps entirely; svg test uses DOMParser

The SVG dominant-baseline patch no longer uses hast, and its test was the last
user of hast-util-from-html. Rewrite the test with the jsdom DOMParser and
remove hast-util-from-html and hast-util-to-html from the deps.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Fix formatting in ComboChart.tsx

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-09 14:27:18 -04:00
Chris Truter
c6a0c72b01 Enforce the 50 MB CSV upload limit on the backend (#77363) 2026-07-09 17:54:36 +00:00
Alexander Polyankin
22725a83b9 Extract a StaticVizRenderer protocol for static-viz rendering (#77315) 2026-07-09 11:26:13 -04:00
Kamil Mielnik
a9e1b0edf7 GDGT-2454 Badge (#74714) 2026-07-09 21:47:43 +07:00
Sloan Sparger
6912a50e85 [Metabot] Chat internal format improvements (#77301)
* [Metabot] Migrate BE to v2 message format (#75672)

* migrate codebase to writing v2 format

* move to camelCase to match upstream schema changes

* improvements

* improvements

* correction

* metadata corrections

* handle string outputs correctly

* put add error code to message metadata in finish message

* self-review pass

* record step start to db

* correct issue in claude provider that sent too long of message ids

* record text state to open up future ability to write in progress work

* increase malli usage

* limit client streamed output for tool calls

* emit cache token usage correctly

* ensure started before error is emited

* update migration version

* [Metabot] FE read new message format (#76429)

* initial impl

* self review

* update e2e tests

* copilot feedback

* pr feedback

* fix lint

* feedback - test helper ergonomics

* misc. fixes to metabot chat improvements integration branch (#77321)

* fixes due to stale branches, correct data- prefix not getting recorded, remove unused code

* clean up debug visuals

* ci fixes

* fix couple more tests

* pr feedback
2026-07-09 09:39:59 -05:00
github-automation-metabase
5f56057bfe Update translations 2026-07-07 (#77151)
* Update translation sources 2026-07-07

* Update translations

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Co-authored-by: Chris Vandoodewaard <chris.vandoodewaard@metabase.com>
2026-07-09 14:35:20 +00:00
Nicola Mometto
e5bd3a34eb fix: enumerate cols to fix sql server (#77373)
* fix: enumerate cols to fix sql server

* fix sqlserver boolean coercion properly
2026-07-09 14:06:15 +00:00
Chris Truter
6097aa447b Publish / unpublish tables trigger hooks properly (#77374) 2026-07-09 12:22:58 +00:00
Mahatthana (Kelvin) Nomsawadi
ff2b145e37 Forward query edits from viz settings in SDK QuestionSettings (#77262)
* test: add repro for SDK viz-settings column edits being dropped

Reproduces EMB-2057 — in modular embedding (embed.js), removing a
column via Visualization settings > Add or remove columns silently
no-ops. Fails against the current QuestionSettings.tsx onChange,
which drops the second question argument carrying the query edit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix: forward query edits from viz settings in SDK QuestionSettings

QuestionSettings.tsx's onChange dropped the second `question`
argument that ChartSettings forwards for query-level edits (e.g.
add/remove columns), applying only the settings to the stale closure
question and never re-running the query. Column-removal edits landed
in the query object but the table kept rendering the old result.

Forward `nextQuestion` when present and re-run only in that case, so
pure viz-settings-only edits (no query change) keep their existing
no-run behavior.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Fix code format

* move test to where it belongs

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-09 08:47:59 +01:00
Alexander Polyankin
21f2c65b15 Collapse uniform blocked view-data table permissions to db-level rows (#77130) 2026-07-08 21:44:07 -04:00
technomancy
1c90ab2c31 Split databricks CI jobs in 2 parts. (#77312)
Currently they are timing out with some regularity in CI. We've done
this same thing to bigquery and redshift already.

Not only will this get us pass/fail results more quickly; it also
reduces the scope of failures so retries don't have to redo as much
wasted work.
2026-07-09 01:32:33 +00:00
Denis Berezin
82b65c8496 UXW-4481 Timeline Events new UI (#76381)
* UXW-4481 Timeline Events new UI

* Add full implementation (without new icons)

* Update icons

* Self review

* Self review

* Review fixes

* Add focused list of events in sidebar

* Clean-up

* Fix hover color

* Fix unit test

* Better sidebar logic

* Fix e2e

* Review fixes

* Review fixes

* Fix e2e

* Fixes

* Review fix

---------

Co-authored-by: Andrei Chernykh <andrei.chernykh@metabase.com>
2026-07-09 03:59:30 +03:00
Egor Grushin
da4e98d389 GDGT-2576 migrate Toggle (#77063)
* GDGT-2576 migrate Toggle

* GDGT-2576 tests fix

* GDGT-2576 remove unused code + fix test

* GDGT-2576 fix failing tests

* GDGT-2576 drop unused onChange from FormToggle
2026-07-09 01:34:59 +01:00
Fraser
4701e5f8dc Remove querying e2e tests made redundant by backend test parity 2026-07-09 12:12:05 +12:00
Andrei Chernykh
18f5a74df7 Reject replacing a dashcard's card with a question internal to another dashboard (#77236) 2026-07-08 15:20:08 -07:00
Michael Eby
339d2c91b9 docs: add page for treemap visualizations (#77185)
* docs: add page for treemap visualizations

* Optimized 1 images, saved 237.8 KB (44.8% smaller)

* fix broken link

* Edits from Jeff

* Edits from Robert

* Edits from Jeff 2

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-08 16:21:36 -04:00
Ben Grabow
51e50d157c Avoid loading any H2 classes until/unless the H2 lib is on the classpath (#76842)
* Avoid loading any H2 classes until/unless the H2 lib is on the classpath
2026-07-08 14:15:03 -05:00
technomancy
c16d08579d Stop running metabase-enterprise.transforms-inspector-test in cloud DBs (#77231)
Stop running metabase-enterprise.transforms-inspector-test in cloud DBs.

These tests create new tables in the default schema, which is fine for
most drivers, but not for cloud DBs like snowflake and bigquery, because
concurrent CI jobs share the same jobs, which means this will cause test
failures in other unrelated tests which list tables, such as
metabase-enterprise.impersonation.driver-test/resilient-connection-options-test

We need to get these tests to stop creating tables in the default schema,
then we can drop the requirement for the :test/dynamic-dataset-loading feature.
2026-07-08 17:47:57 +00:00
Phoomparin Mano
07c824b6fb fix(sdk): derive dark mode color scheme based on sdk theme colors (#77269)
* add css variables for styled components

* commit loki snapshot change

* add resolved theme mocks

* use real theme color values
2026-07-08 16:24:19 +00:00
Nicola Mometto
6aa06eaa23 Fix notification seed legacy template paths (#77268)
* Fix notification seed crashing on pre-existing template rows

* add regression test
2026-07-08 16:58:49 +01:00
Andrei Chernykh
7876a74202 Uxw 4531 replace the group picker dropdown with a multiselect (#76648)
* Replace the group picker in the user form with a multiselect

* Port the tenant group-picker e2e steps to the new multiselect

* Add group-manager controls and a section separator to the multiselect, with chevron and Backspace fixes

* Fix external-default group ordering in the multiselect dropdown, with manager-flag and divider tests

* Update frontend/src/metabase/admin/people/components/GroupsMultiSelect/GroupsMultiSelect.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update remove-button test assertions for the group-specific aria-label

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2026-07-08 08:35:46 -07:00
dpsutton
c09cdbf49c Serialize static-viz GraalJS context creation (GHY-4077) (#77225)
* Serialize static-viz GraalJS context creation (GHY-4077)

Even with the shared-Source code cache (#77180), evaluating the bundle
in a fresh context churns through ~500 MB of allocation. That memory is
transient — allocated and discarded during the eval, with only ~10 MB
retained per extra live context — but it all still has to pass through
the heap. The dirigiste pool grows during render bursts, and nothing
stopped 2-3 context creations from running concurrently: ~1-1.5 GB of
allocation churn stacked on top of in-flight renders, which on a 2 GB
heap outruns the collector and drives GC thrash / OOM.

Serialize creation on a private monitor so at most one generate runs at
a time; waiting acquires just queue on the pool. Also jitter the
10-minute expiry timestamps (+/- 3 min) so pool members created in the
same burst don't all expire and regenerate in the same window.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Document static-viz pool memory model in namespace docstring

Capture what the OOM investigation measured so the pool's design
choices stay legible: engine + parsed sources ~220 MB retained (paid
once); fresh-context eval ~500 MB of collectable churn with only
~16 MB retained per live context (first-in-JVM cold parse ~1.2 GB);
renders ~1 MB/row transient. Also spell out why creation is serialized
on a monitor rather than time-throttled: bursts genuinely need
multiple contexts, so the pool still grows — just one creation at a
time.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 10:12:58 -05:00
Michael Eby
23825aec8e docs: add mcp + cli webinar callouts (#77191)
* docs: add mcp + cli webinar callouts

* Edit from Jeff
2026-07-08 10:29:39 -04:00
Chris Vandoodewaard
eca47dd2dc DEV-2270: add .bun-version file, configure setup-bun to use version file (#77208)
* add .bun-version file, configure setup-bun to use version file

* use package.json as the source of truth for the version of bun installed
2026-07-08 10:23:09 -04:00
Ngoc Khuat
8a7b431057 Fix redshift transform job dependency-detection flake (#77095) 2026-07-08 14:59:08 +01:00
Fraser
384f6fb9b7 Make test stats upload more robust (#77258)
* Make test stats upload more robust

* Fix trailing whitespace

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 13:47:04 +00:00
github-automation-metabase
b7fa7d73d2 Auto-update documentation for master (#77222)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-08 09:28:53 -04:00
github-automation-metabase
9d523b4604 Auto-update documentation for master (#77036)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-08 09:27:54 -04:00
Sébastien
951be524ec Fix embed preview stuck loader when reopening with a saved theme (#77150) 2026-07-08 15:06:28 +02:00
Ngoc Khuat
c518575acc run the incremental transform suite against all drivers (coverage probe) (#76793) 2026-07-08 11:56:27 +00:00
Ngoc Khuat
206ba7ee99 Don't fail dashboard subscriptions when a filter's default is an empty list (#77158) 2026-07-08 11:43:49 +00:00
Sébastien
e78a7c57e6 MCP Usage Analytics: storage, instrumentation, audit view, and admin page (MVP) (#76403) 2026-07-08 12:15:21 +02:00
Sergii Vozniuk
892974e74e Fix rendering of tenant avatars (#77075)
* Fix rendering of tenant avatars
* Remove unused Avatar code, cleanup initials logic, more explicit types
* Fix type used in isUser
* Stricter types to avoid initial bug in the future
2026-07-08 11:58:50 +02:00
Nemanja Glumac
1bec6455d3 Wire embedding tests to ci-conductor (#77184)
* Wire embedding tests to ci-conductor reporting

* Add ci-conductor quarantine gate to embedding Cypress jobs


Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-08 11:19:26 +02:00
Chris Truter
0149067bd7 execute_question: improve error codes (#77156) 2026-07-08 07:46:17 +00:00
Romeo Van Snick
54a2825522 Convert route-prop reference containers onto the metabase/router facade (#77067)
* Add withRouteProps facade shim for the router migration

* Convert DatabaseListContainer to a function component on facade hooks

* Put route-prop reference containers on withRouteProps

* Require route props in withRouteProps generic constraint

* Convert ScrollToTop from withRouter to useLocation hook form

* Fix merge fallout: rename RouteProps shim and repoint react-router imports
2026-07-08 16:23:09 +10:00
Romeo Van Snick
ca6033b698 Convert query_builder test loose ends to TypeScript (#76938)
* Convert query_builder test loose ends to TypeScript

* Rename ChartSettingsSidebar tests to match their assertions
2026-07-08 14:22:49 +10:00
Fraser
f6be96587f Delete dead frontend code (#77253) 2026-07-08 16:02:20 +12:00
Fraser
1bc18a3626 Consolidate reference-only components into reference/ (#77254) 2026-07-08 16:01:57 +12:00
Fraser
837a454620 Consolidate app banners into AppBanner (#77255) 2026-07-08 16:01:43 +12:00
Fraser
3127b4e8c3 Consolidate question-timeline UI into query_builder (#77256) 2026-07-08 16:01:26 +12:00
Romeo Van Snick
56879decb0 Migrate direct react-router usage onto the metabase/router facade + eslint ban (#77068)
* Facade re-exports full react-router surface via a single leaf seam

* Re-point all react-router imports onto the metabase/router facade

* Ban react-router imports outside the metabase/router facade (eslint)

* Migrate InviteToViewModal Link import onto metabase/router facade
2026-07-08 12:53:05 +10:00
Alexander Polyankin
d81c75451c Minify the static-viz bundle (#77234) 2026-07-08 02:18:57 +00:00
Alexander Polyankin
b48d367c21 Log only the error message for failed queries (#77223) 2026-07-07 21:38:18 -04:00
Denis Berezin
5c6e3e71fe UXW-4235 Transforms nav item permissions (#76705) 2026-07-08 01:29:14 +03:00
Alexander Polyankin
5e05b04e53 Pool error fix (#77212) 2026-07-07 17:00:26 -04:00
Timothy S. Dean
5a39e1adf8 Update version-helpers.ts for v63 (#77211)
Update version-helpers.ts for v63
2026-07-07 14:39:58 -06:00
Eric Normand
ff5e3b6973 Validate serialization dependencies before export (GHY-4010) (#76763)
* Add serialization-dependencies multimethod + Card impl (GHY-4010)

Foundation for export-time dependency validation. serialization-dependencies
runs on a raw appdb entity and returns its references tagged :content (must be
in the export) or :data (database/table/field that must exist in the appdb).
Unlike the load-time `dependencies` multimethod, it operates pre-serialization
and includes tables/fields, which import otherwise creates on the fly.

The Card impl derives content deps from `descendants` (so the two can't drift)
and adds data-model deps from the query via the lib walkers. Not yet wired into
the export pipeline.

* Replace escape analysis with general dependency validation (GHY-4010)

extract-subtrees now runs a dry-run pass (collect-dependencies) that shares the
real export's extract queries but neither serializes nor writes. For every entity
that will be extracted it derives serialization-dependencies and checks them:
content references must be in the visited/extracted set (or be analytics cards),
and data-model references (database/table/field) must exist in the appdb. Any
unsatisfied reference aborts the export (unless continue-on-error), before any
archive is produced.

This generalizes part A's Card-only, collection-id escape analysis: it now also
catches non-Card content escapees and dangling data-model references (a deleted
table/field that would otherwise serialize to a malformed [nil nil nil] ref).

Adds a Dashboard serialization-dependencies impl. Tests not yet updated.

* Update serialization tests for dependency validation (GHY-4010)

The dependency-validation warnings replace the old "Failed to export
Dashboard/Cards ... outside requested collections" messages with a uniform
"<entity> references <model> <id> which is not included in the export /
is missing from the source database" form, so the escape tests now assert
on the new wording. Adds dependency-validation-missing-data-ref-test, which
covers the new data-model case: a card referencing a deleted field aborts the
export (and continue-on-error still exports the rest).

* Fold dependency collection over a monoid, with batched queries (GHY-4010)

Replaces the nested reduce in collect-dependencies with a {:visited :deps}
monoid: entity-deps maps one entity to its contribution, merge-deps is the
associative combine (0/1/2-arity, usable directly as a transduce reducing fn),
and collect-dependencies folds every entity into the whole via a single
transduce. content-id-batches yields [model id-batch] pairs so each extract
query's :in :id clause stays bounded (query-batch-size 1000), and the data-dep
existence check is batched the same way. Behavior is unchanged.

* Flatten dependency collection into four transducer stages (GHY-4010)

entity-deps now reads its model off the entity (extract-query returns modeled
rows) instead of taking it as an argument, so collect-dependencies becomes a
flat pipeline: filter content models, resize into id batches, mapcat each batch
through extract-query into an entity stream, then map entity-deps — no eduction
nested inside the mapcat. Behavior unchanged.

* Move dependency validation into its own namespace (GHY-4010)

Extract the export-time dependency-satisfaction check out of
serialization.v2.extract into serialization.v2.dependency-validation. extract
now just calls dependency-validation/validate-dependencies! and keeps ownership
of the analytics-card set, which it passes in. The moved code carries this
session's cleanups (map-kv-vals for the existence lookup, set-based :deps).

Tests move to a matching dependency-validation-test namespace; the escape
assertion embedded in selective-serialization-basic-test stays with extract as
an extraction-level integration check.

* Address review: drop :kind, transients, cover segment/measure (GHY-4010)

Alex's PR comments on the raw dependency validation:

- serialization-dependencies no longer tags deps with :kind; it returns plain
  {:model :id} and the validator classifies each by model (serdes.models
  content vs data-model), since serdes already knows which is which.
- collect-dependencies accumulates into transient sets — an export can walk a
  lot of entities.
- Card serialization-dependencies now covers every reference in the query,
  including :segment and :measure (both data-model, existence-checked), via the
  lib walkers, closing the gap the field/table/card-only version had.

Refs embedded in parameter_mappings / visualization_settings / result_metadata
still aren't covered, and the raw serialization walker still duplicates the
serialized *-deps knowledge; both are tracked for the follow-up unification.

* Cover result_metadata and visualization_settings field refs (GHY-4010)

serialization-dependencies "Card" now gathers Field references from every
routine-backed source, not just the query:

- query: lib walkers (fields, tables, segments, measures, template-tag fields)
- result_metadata: each column's :id
- visualization_settings: the JSON-encoded column-setting keys, parsed with
  mb.viz/db->norm (the same routine the dependency-analysis project uses)

New test covers a field referenced only in visualization_settings. Field refs
buried in parameter_mappings / parameters value-fields are bare [:field ...]
clauses the lib walkers reject; those remain for the dep-walker unification.

* Rename `dependencies` multimethod to `deserialization-dependencies`

Makes the load-time dep multimethod parallel with the export-time
`serialization-dependencies`. `dependencies` runs on the serialized/ingested
form for load ordering and omits tables/fields (import synthesizes them);
`serialization-dependencies` runs on the raw entity and includes them. The
name now says which is which.

Mechanical rename of the defmulti + default + 19 impls across 18 models + 3
callers (load, metabot, remote-sync) + tests + doc-links. No behavior change.

* Address CodeRabbit: batch analytics lookup, fix test targeting (GHY-4010)

- analytics-card-ids batches the card-id :in via a partition-all transducer, so
  a large closure doesn't exceed database parameter limits (matches the batching
  already used in dependency collection).
- escape-report-test's ":parameters" case targeted coll2 (re-testing the
  source-table card); target coll3 so it actually exercises the parameter card.
- Correct the continue-on-error test wording: it suppresses the abort but does
  not skip the affected card at export (the malformed card is skipped on import).

* Unify serialization/deserialization dependency walkers (GHY-4010)

Make the mbql-deps walker family format-aware so a single traversal handles
both raw (numeric ids, export/serialization) and serialized (portable refs,
load/deserialization) forms, gated by *serialization?* / raw-ref-id?. Card and
Dashboard now share one deps helper across both dependency multimethods.

Implement serialization-dependencies for the remaining content models
(Action, Collection, Document, NativeQuerySnippet, Timeline), computing deps
from the raw entity: Action fetches its query_action child row; Collection
derives its parent from the raw :location path.

Refine export-time validation: a content reference to a deleted entity is not a
failure (export can't emit a portable id for a missing row, so fk-elide drops
it), and structural Collection references are ignored (a selective export may
omit the containing collection tree).

Tests: mbql-deps format-parity test, direct per-model serialization-dependencies
coverage, and the full baseline load->extract round-trip over every model.

* Trim duplicated dependency docstrings and consolidate abort tests (GHY-4010)

Dedupe the "content refs must be in export / data-model refs must exist"
explanation that appeared in four docstrings, and collapse the three
near-identical "delete a data-model ref -> export aborts" tests into one
parameterized test over Field/Segment/viz-settings references.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Share query-batch-size constant; use pos-int? for raw ref ids (GHY-4010)

Hoist the `:in`-clause batch size into a single serdes/query-batch-size
constant instead of a private def plus a bare 1000 literal in extract, and
tighten raw-ref-id? to pos-int? (entity ids are always positive).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Replace transient accumulator with a named merge-entity-deps monoid (GHY-4010)

The set-building is not the hot path (batched DB queries and the mbql walk
dominate), so drop the transients for a plain `merge-with into` monoid,
extracted as `merge-entity-deps` — the same idiom as u/traverse and
remote-sync's merge-incremental-export-plans.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fold partition-all into the existing-ids transducer (GHY-4010)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fold distinct into the existing-ids transducer too (GHY-4010)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Use peek and set-as-predicate in dependency validation (GHY-4010)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* SPIKE: thread allow-int-ids? param instead of *serialization?* dyn var (GHY-4010)

Replaces the *serialization?* dynamic var with an explicit allow-int-ids?
parameter threaded through the mbql walkers (mbql-deps/-map/-vector,
parameters-deps, visualization-settings-deps, viz-link-card-deps) and the
shared model helpers (card-deps, dashboard-deps, serdes-deps-dashcard,
result-metadata-deps). The name states the behavior: integer ids count as
references only when set (raw appdb entities), never on the serialized/load
form where a stray numeric must be ignored.

The parameter is mandatory everywhere — no default arities. Load-side callers
(measure/segment/transform/action deserialization impls) pass false; the three
serialization-dependencies impls pass true.

Spike to compare against the dyn-var approach; drop if we prefer that.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fix cljfmt: align card-deps destructuring continuation lines (GHY-4010)

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-07 20:22:39 +00:00
Alexander Polyankin
486296ff36 Graalvm pool with staticly parsed sources (#77180) 2026-07-07 15:27:15 -04:00
Nick Fitzpatrick
7f6472209d Move only show attachments toggle for email subscriptions (#77022)
* Move  only show attachments toggle for email subscriptions

* fix e2e test
2026-07-08 00:52:14 +05:30
Timothy S. Dean
f57fdc8258 Bump postgresql 42.7.11 -> 42.7.12 (#77181) 2026-07-07 12:36:22 -06:00
Chris Truter
705bda8519 feat(search): publish analytics for every search context (#76613) 2026-07-07 20:17:51 +02:00
appleby
a91da664b9 Do not compute related-tables or metrics in get-report-details (#76945)
Don't compute related-tables or metrics in get-report-details

`get-report-details` drops `:related_tables` and `:metrics` via a `select-keys`, so don't ask `card-details` for them.
2026-07-07 17:57:21 +00:00
Nicola Mometto
631e2c157f write-through cache for transform deps in ee only (#77079)
* write-through cache for transform deps in ee only

* kondo
2026-07-07 17:32:25 +01:00
Timofey Kachalov
01fa952fa7 Update httpcore5, httpcore5-h2 and httpclient5 versions (#77109) 2026-07-07 20:00:34 +04:00
Timothy S. Dean
d9ea875545 Bump handlebars 4.3.1 -> 4.5.3 (#77134)
* Bump handlebars 4.3.1 -> 4.5.3
* Add license for jnack/handlebars
2026-07-07 14:27:21 +00:00
Oleh K
3512caf5ee refactor: Migrate feedback, components, misc, upsell, illustration & admin color tokens (#76871)
* Migrate remaining color tokens to new names (GDGT-2535)

Migrate the remaining legacy design-system color tokens to their new
names per the GDGT-2517 migration guide:

- feedback: error/danger -> feedback-negative, success ->
  feedback-positive, warning/gold -> feedback-warning
- misc/core: info -> core-info, white -> core-white, shadow ->
  shadow-default, overlay -> modal-overlay, focus -> input-focus,
  metabase-brand -> core-metabase_brand
- admin: admin-navbar* -> navbar-admin*
- upsell/illustration: per guide
- remove unused bronze/copper/silver

Covers all reference forms: CSS `var(--mb-color-*)`, `color()`/helper
calls, Mantine `c`/`bg`/`color`/`iconColor` props (string and ternary),
object-literal `color:`/`iconColor:` keys, `ColorName` return values,
arrays, and `Record<_, ColorName>` value maps. Tightens `Undo.toastColor`
from `string` to `ColorName` so future token removals fail at compile
time. Maps the `Alert` component's semantic `color` prop to feedback
tokens internally so its call sites stay unchanged.

Also sweeps up brand/filter/summarize consumer stragglers left over from
the earlier (merged) migration. SDK/whitelabel input keys, the
derive-theme alias definitions, and static-viz's local palette are left
on their existing names by design.

* Migrate missed success-secondary props in StepperWithCards

The .module.css was migrated to feedback-positive-selected but the two
inline c="success-secondary" props (Done check icon + label) were missed.

* Update Loki Snapshots

* Fix toastColor type widening in metabot toast-prop helpers

Undo.toastColor tightened to ColorName in this branch; the two get*ToastProps
helpers returned object literals where toastColor widened to string (missing
as const, unlike their iconColor/dismissIconColor siblings).

* Update TransformListPage sync-color spec to migrated feedback token names

utils.ts color map was migrated (success/warning/danger -> feedback-*) but
the spec assertions still expected the old names.

* Update SDK theme + treemap specs for feedback/misc token mirrors

- get-embedding-theme: SDK mapping now fans text-white->core-white and
  focus->input-focus, so the expected override gains those keys.
- treemap option: getColor("white") became getColor("core-white"); add
  core-white to the test's MOCK_COLORS palette.

* Update Loki Snapshots

* Update toast color-attr assertions to migrated feedback token names

* Cleanup

* Migrate remaining color tokens in Button and Table stories

* Add explainer comment for colors naming convention

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-07 15:34:02 +02:00
Kamil Mielnik
63716689ad GDGT-2771 Remove redundant type casts (#77078) 2026-07-07 19:39:25 +07:00
Oleh K
a7e7e5ac5b fix: Toaster crash on long-running questions from color-mix tokens (#77152)
* fix: Toaster crash on long-running questions from color-mix tokens

The Toaster's styled-components computed colors at render time with the
JS `color` library (via the deprecated lighten()/alpha() helpers). One
of the tokens they parsed, `background_page-tertiary-inverse`, is now
defined as a color-mix() value, which the `color` library can't parse —
so it threw "Unable to parse color from string" and crashed.

Replace those runtime helper calls with CSS color-mix on the variables
directly, so the mixing happens in CSS where color-mix()/var() resolve.

* Adjust dismiss color
2026-07-07 11:43:43 +02:00
Nemanja Glumac
6b5c699c22 Make e2e modal selector slightly more accessible (#76975) 2026-07-07 09:39:39 +02:00
Romeo Van Snick
2a8bbb797c Add v7 conformance tests for the metabase/router facade (#77064)
* Add react-router v7 as a test-only aliased devDependency

* Add differential conformance harness for the router facade

* Add v7 conformance test for useLocation

* Add v7 conformance test for useParams

* Add v7 conformance test for useNavigate

* Add v7 conformance test for useSearchParams

* Add v7 conformance test for Navigate

* Add v7 conformance test for useSearchParams defaultInit

* Pin react-router v7 to 7.18.1 for conformance

* Add type-level conformance tests against react-router v7

* Guarantee cleanup between facade and v7 renders in runBoth
2026-07-07 15:28:44 +10:00
Romeo Van Snick
c16bdc6c32 Migrate DatasetEditor DatasetNotebook and DatasetFieldMetadataSidebar to TypeScript (#76971) 2026-07-07 15:28:20 +10:00
Romeo Van Snick
c1e5037657 Migrate query builder View components and tests to TypeScript (#76972)
* Migrate ChartSettingsSidebar unit test to TypeScript

* Migrate DatasetMetadataStrengthIndicator unit test to TypeScript

* Migrate QuestionDataSource unit test to TypeScript

* Migrate ViewTitleHeader unit test to TypeScript

* Correct onSave return type to Promise<void> and relax Toaster className

* Migrate query builder View components to TypeScript

* Preserve collection type on move and tighten timeline callback types

* Remove dead onCloseQuestionInfo prop from structured sidebar
2026-07-07 15:27:41 +10:00
Fraser
aae7c76e84 Integrate e2e coverage into module graph (#74621) 2026-07-07 16:39:30 +12:00
Tyler Plude
c8ede8c5c5 Pin maildev to 2.2.1 (#77143)
pin maildev to 2.2.1
2026-07-06 18:56:25 -07:00
YB
1b244fdd43 pin @babel/core to 7.29.7 (#77044) 2026-07-07 09:36:03 +08:00
Alexander Polyankin
c109d4fbc6 Add backend test parity for MBQL lib / QP behaviors covered only by e2e tests (#77062) 2026-07-06 20:35:33 -04:00
appleby
16eefb159d Remove enhanced-database-tables and provide columnless tables in metabot context :used_tables (#76944)
`enhance-context-with-schema` resolved each `:user_is_viewing` item's used tables and then ran them through
`table-utils/enhanced-database-tables`, which fetched and formatted the full visible-columns set for every used table, including all implicitly-joinable columns from related tables. That work was discarded anyway since columns were recalculated via `entity-details/get-table-details` when rendering the context. On large, highly-connected schemas this could load thousands of columns into the request metadata cache and exhausted the heap (metabase#76493).

`:used_tables` entries now carry only `{:id :type :name :database_schema :description}`. name/schema/description are kept for the `simple-entity` error fallback. `enhanced-database-tables` had no other callers, so it is removed.
2026-07-06 15:58:03 -07:00
Braden Shepherdson
931afd85c5 [PDFs] Support emoji (#77034)
Fixes UXW-4704.

Support emoji in PDF rendering - in card titles, text cards, and the dashboard title.

These are monochrome only, since monochrome emoji are regular font glyphs. Colour emoji requires unusual bitmap-backed font support, and the PDFBox engine doesn't support that. It could be done, but it would require rendering the emoji glyphs to PNGs, then embedding those in the PDF. It's not worth the effort or including a bulky bitmap emoji font for a cosmetic feature.

This includes the Noto Emoji font in the JAR, and adds the Open Font License notice file covering all the PDF fonts.
2026-07-06 20:55:13 +00:00
Tyler Plude
79002d4666 [BOT-1442] Fix metabot silently producing non-runnable MBQL (#76133)
* fix Metabot construct_notebook_query silently producing non-runnable queries

* trim overly verbose docstring

* pr feedback
2026-07-06 20:07:24 +00:00
Romeo Van Snick
a7b48d8ca8 Convert remaining NativeQueryEditor js files to TypeScript (#76948) 2026-07-07 06:07:07 +10:00
Eric Normand
843ddfa348 Fix transforms-root breadcrumb link in remote-sync changes list (GHY-3901) (#77113)
The "Transforms" group header in the push/pull changes list is backed by a
virtual collection with the sentinel id -1 (TRANSFORMS_ROOT_ID). Every -1 case
is special-cased in displayGroups.ts except the header breadcrumb, so the
sentinel flowed into collectionUrl({ id: -1 }) and produced a dead
/collection/-1-transforms link (a hyphen at the start of the last path segment).

Link the transforms-root segment to the transforms list (/data-studio/transforms)
instead. Covers both the virtual-root group and the transforms-namespace prefix
on sub-collections, since the guard sits at the single render site.
2026-07-06 19:39:13 +00:00
appleby
b7262df217 Whitelist anthropic and bedrock models (#76768)
* Whitelist bedrock models

* Whitelist anthropic models

* Add claude-fable-5 to supported-models for bedrock and claude providers

* Include a display_name for all supported-models

* Filter to available-model? in bedrock's list-models
2026-07-06 19:14:32 +00:00
Eric Normand
8bb5162d89 Fix snippet template-tag id churn in serdes round-trip (GHY-4067) (#77112)
Snippet template-tag ids were regenerated on every serdes import: YAML
ingest keywordizes the tag-name keys, so the NativeQuerySnippet load hook
could not match them to preserve the existing :id and minted a fresh UUID
instead. In a remote-sync import/export loop this produced a spurious id
diff for every snippet with variables on every cycle.

Normalize :template_tags on import in make-spec so the tag-name keys are
strings before the model hooks run; export is unchanged. Add a round-trip
regression test asserting template-tag ids survive export/import.
2026-07-06 19:09:51 +00:00
Eric Normand
0605e0352f [GHY-3974] Fix Usage Analytics breaking after upgrade (two failure modes) (#76551)
* [GHY-3974] Add failing tests for Usage Analytics upgrade failure modes

Two invariant tests covering the audit-DB upgrade breakage, asserted
through ensure-audit-db-installed! so they're independent of the fix
mechanism and leave the generic sync path untouched:

- Mode A (audit-db-self-heals-duplicate-rows-from-stale-schema-test):
  an interrupted host-adjust + schema sync duplicates a v_* view row and
  retires the original, breaking customer content. ensure-audit-db-installed!
  must reconcile back to one active row per view and keep dependent content
  on an active table.

- Mode B (checksum-not-advanced-until-host-adjust-completes-test):
  last-analytics-checksum must not advance if adjust-audit-db-to-host! is
  interrupted, so the next boot re-runs the load and the host-adjust.

Both fail on master.

* [GHY-3974] Fix Usage Analytics upgrade failure modes

Mode B (checksum committed before host-adjust): in maybe-load-analytics-content!
advance last-analytics-checksum only after adjust-audit-db-to-host! completes,
so an interrupted host-adjust leaves the checksum behind and the next boot
re-runs the load + adjust. Also force a reload, regardless of the checksum, when
audit tables are stuck at the postgres "source" schema on a non-postgres host
(audit-db-in-source-state?) so already-corrupted instances self-heal.

Mode A (schema-renamed view duplicated + retired by sync): add
reconcile-audit-db-duplicates!, run on every ensure-audit-db-installed! so
already-corrupted instances (whose checksum already matches, skipping the load)
still recover. For each duplicate same-name group in the audit DB it keeps the
row dependent content points at, repoints stray report_card.table_id refs to it,
normalizes it to the host-canonical name/schema, and deletes the orphans. Schema
is derived from the host engine, not the surviving row, so a duplicate left at
the postgres source schema (Mode B masking Mode A) is corrected too. Scoped
entirely to the audit DB; the generic sync path is untouched.

Both audit-test regression tests pass on h2 and postgres.

* [GHY-3974] Serialize audit DB load/adjust/sync across nodes (1b)

with-duplicate-ops-prevented is per-process only, so on a rolling upgrade
two pods could run the audit load/adjust/sync concurrently and produce the
half-applied schema states behind both failure modes. Wrap the
load+adjust+sync+reconcile in an app-DB cluster lock (metabase_cluster_lock)
so only one node runs it at a time. If another node already holds the lock it
is doing the same work, so skip rather than fail the boot.

The sync must run inside the lock to be serialized, so maybe-sync-audit-db!
now runs synchronously instead of in a background future: on a transactional
appdb a sync on another thread would escape the lock's transaction and
deadlock against its uncommitted metabase_table writes.

Full audit-app namespace passes on h2 (in-process RW lock) and postgres
(transaction + SELECT FOR UPDATE), 52 assertions each.

* [GHY-3974] Filter audit view lookups in SQL, not in memory

audit-view-table and the Mode A heal assertion were selecting every active
audit table and filtering by lower(name) in Clojure. Push the predicate into
the query with a lower(name) where clause.

* Better comments

* [GHY-3974] Don't force a reload for an inactive public orphan (MySQL fix)

audit-db-in-source-state? treated any `public`-schema audit table on a
non-postgres host as the interrupted-host-adjust state and forced a reload.
But a Mode A duplicate leaves an *inactive* `public` orphan, and on MySQL
(canonical schema NULL) forcing a reload made adjust-audit-db-to-source!
move the active NULL row to `public`, colliding with the orphan on the
(db_id, schema, name) unique index (Duplicate entry '…-public-v_content').

Only active rows signal the genuine stuck source state; inactive public rows
are retired orphans handled by reconcile-audit-db-duplicates!. Restrict the
check to active rows. Surfaced by the MySQL/MariaDB app-db CI run of
audit-db-self-heals-duplicate-rows-from-stale-schema-test.

* [GHY-3974] Update modules config: audit-app no longer uses config

Removing the metabase.config.core require from the audit-app module (the
unused config dep dropped when the sync future was removed) leaves config
out of enterprise/audit-app :uses. Fixes modules-config-up-to-date-test.

* [GHY-3974] Only swallow lock-contention failures for our own audit lock

A different cluster lock's acquisition failure raised from inside the locked
body (e.g. the permissions lock taken when serdes inserts a Database) also
carries :lock-names; it must propagate rather than be swallowed as audit
contention and silently abandon the load.

* [GHY-3974] Bail faster on audit lock contention

Drop the lock-acquisition timeout to 5s and retries to 2, so a node that loses
the boot-time audit lock skips in ~17s instead of ~150s. The work is idempotent
and the lock holder is doing it, so a losing node need not win; keeping a couple
retries still lets a node pick up the work if the holder crashes mid-load.

* [GHY-3974] Serialize audit DB install/adjust under the cluster lock too

The install-time adjust-audit-db-to-host! + schema sync (the ::installed and
::updated branches of maybe-install-audit-db!) previously ran outside the
cluster lock, so two nodes detecting an engine mismatch could adjust and sync
concurrently against a half-adjusted schema. Move install inside the lock so the
whole install+adjust+load+sync+reconcile is serialized across nodes; a node that
acquires the lock after the installer commits sees the DB already exists and
no-ops instead of colliding on the audit DB primary key.

* [GHY-3974] Harden reconcile-audit-db-duplicates! and Mode B test

- Sort rows by id before grouping so survivor selection (including the
  referenced? tiebreak) is deterministic regardless of appdb row order.
- Clear is_defective_duplicate on the survivor so it re-enters idx_unique_table
  (a flagged row has a NULL unique_table_helper and is excluded from the index).
- Comment why orphans are deleted before the survivor is re-canonicalized.
- Mode B test: move cleanup into a finally and reinstall the audit DB so an
  unexpected throw can't leave sibling tests without an audit DB.

* [GHY-3974] Make reconcile lossless: move content off orphans before deleting

The previous reconcile did (t2/update! :model/Card {:table_id orphan} {:table_id survivor})
then deleted the orphan. That update is a no-op — Card's before-update populate-query-fields
re-derives table_id from the unchanged dataset_query — and report_card.table_id is ON DELETE
CASCADE, so deleting the orphan destroyed any customer card whose query pointed at it. This
happens in real Mode A: bundled audit cards reference the retired row (making it the survivor)
while a customer question built during the corrupted window references the freshly-synced active
row (the deleted orphan).

Now repoint-cards-to-survivor! rewrites each referencing card's dataset_query (source-table)
and result_metadata, remapping field ids onto the survivor's same-named fields, before the
orphan is deleted. Handles both pMBQL and legacy field refs.

Adds audit-db-reconcile-preserves-content-on-the-deleted-duplicate-test, which asserts the card
survives and its field refs resolve to active fields on the survivor (fails on the old code).

* [GHY-3974] Use lib field-ref helpers instead of hand-indexing refs

repoint-refs now reads/writes the field id via lib/field-ref-id and
lib/with-field-ref-id rather than indexing the ref vector by position. Expose
with-field-ref-id from metabase.lib.core (the setter alongside the already-public
field-ref-id getter) so it's reachable through the lib module's public API.

* [GHY-3974] Use lib clause predicate / field-ref-id for remaining MBQL access

Replace the hand-rolled field-ref? predicate with lib/clause-of-type?, and the
positional field-id extraction in the test with lib/field-ref-id.

* better docstring

* [GHY-3974] Order reconcile rows in the query instead of in memory

Address review: let the DB sort (:order-by [[:id :asc]]) rather than sort-by; group-by
preserves the order within each group, keeping the survivor tiebreak deterministic.

* [GHY-3974] Move query id-remap into lib; handle result-metadata thoroughly

Review (@metamben): the ref manipulation should live in lib and be general-purpose,
and queries vs result metadata shouldn't share one generic walker.

- Add metabase.lib.walk.util/replace-field-ids and replace-table-ids (general, built on
  lib.walk): field refs everywhere via walk-clauses (filters/aggregations/breakouts/joins/
  nested stages), :source-field/:fk-field-id opts, native :template-tags :dimension refs, and
  :source-table per stage/join. Exposed via metabase.lib.core.
- audit-app repoint-cards-to-survivor! now rewrites dataset_query via the lib helpers, and
  handles result_metadata separately (non-generic): :id, :fk_target_field_id, and :field_ref
  covering both legacy ([:field id opts]) and pMBQL ([:field opts id]) shapes.
- Test asserts legacy result_metadata :field_ref is remapped onto the survivor.

Covers review threads: field-ref manipulation in lib (#383), FK/source-field refs (#418),
legacy result-metadata refs (#392).

* [GHY-3974] Batch the reconcile referenced? check into one query

Address review: instead of a t2/exists? per row in a duplicate group, fetch the set of
card-referenced table_ids for the whole group in a single query and test membership.

* [GHY-3974] Review cleanups: cond-> in replace-field-ids; update-existing in result-metadata remap

- lib replace-field-ids: use cond-> for the template-tags/:dimension updates instead of if/else.
- audit remap-result-metadata: use m/update-existing with an identity-for-unmapped fn instead of
  a cond-> with duplicate lookups; drop the redundant pos-int? guard in remap-result-metadata-ref
  (field-id-remap is always a map, so it already returns nil for names/nil).
2026-07-06 19:07:41 +00:00
Aleksandr Lesnenko
fc54b654f4 disable coderabbit PR summaries (#77114)
* disable PR summaries

* disable coderabbit yapping when skipped
2026-07-06 19:03:17 +00:00
Braden Shepherdson
2a8b0fdefe [PDFs] If a Visualizer card has a name override, use it (#77033)
Fixes UXW-4705.

Also refactors the duplicated logic from two other places in the
subscriptions rendering into a new `render.util` helper.
2026-07-06 18:39:19 +00:00
Aleksandr Lesnenko
851cb65a11 coderabbit config (#77111) 2026-07-06 18:24:09 +00:00
Chris Vandoodewaard
62e3bb098e onboarding: add Github username to team, add Github -> Slack ID mapping (#77110)
Add Github ID to DevEx team, map Github ID to Slack ID
2026-07-06 18:22:08 +00:00
Nick Fitzpatrick
6bf214f2c2 update Echarts to 6.1.0 (#75139)
* echarts 6.1.0

* adjusting BE test
2026-07-06 23:44:56 +05:30
Nick Fitzpatrick
77eb75ecd0 improving Pivot table and and object detail PDF renders (#76728)
* improving Pivot table and and object detail PDF renders

* pivot table improvements
2026-07-06 23:41:59 +05:30
Nick Fitzpatrick
2080e7c13f Handle PDF uploads to slack user DMs (#76787) 2026-07-06 23:22:46 +05:30
Braden Shepherdson
78e968bd69 Use a much larger maximum nesting limit while parsing YAML (#76528)
Fixes UXW-3770.

The default limit of 50 levels of nesting is too small for deeply nested
MBQL expressions, such as a `replace(replace(replace(...)))` tower.

This PR raises the limit to 10k, and includes a test that 500 levels
parses fine. 10k works at my REPL but I don't want to commit a test like
that in case other JVMs hit a `StackOverflowError`. Rejecting the import
is a better UX than crashing Metabase!
2026-07-06 13:07:47 -04:00
Braden Shepherdson
636276120b Make /api/cache/invalidate endpoint return 400 for missing filters (#76364)
Fixes UXW-4108.

When no `database`, `dashboard` or `question` parameter is supplied, the
endpoint does not invalidate anything. It previously returned a 404 in
that case, indicating that nothing was found to invalidate.

But since no attempt to invalidate anything is made without at least one
of those parameters, the 404 was misleading. Instead, this malformed
request should return a 400, which it now does.

No impact to the Metabase FE, which only ever calls this endpoint with
the parameters supplied.
2026-07-06 13:07:34 -04:00
Tyler Plude
b0682e0144 [BOT-1776] Show cache read tokens in usage analytics (#76847)
show cache read tokens in usage analytics
2026-07-06 09:34:15 -07:00
Braden Shepherdson
4682a713c8 [PDFs] Regression test: hide "no results" cards per the setting (#77032)
Regression test for UXW-4706, which was fixed in #76918.
2026-07-06 12:29:28 -04:00
Andrei Chernykh
eae64a014a Invite someone to view a dashboard or question (#76444)
* Add an Invite someone to view this action to dashboard and question share menus (#76209)

* Add an Invite someone to view this action to dashboard and question Share menus

* Update admin create-user e2e to reveal the temporary password via the new toggle

* Add a shareable item link to the invite modal's no-email states

* Remove the stale password-toggle aria-label and reword the temp-password invite copy

* Land invited users on the shared dashboard or question after signup (#76505)

* Land invited users on the shared dashboard or question after signup

* Scope the invite email to the shared dashboard or question

* Code cleanup

* Polish the invite email's join button spacing, label, and padding

* Remove stale TODO about synchronous invite email

* Add tests for invite someone to view (unit + e2e) (#76589)

* Add unit and e2e tests for the invite-to-view feature

* Fix the invite-to-view e2e signup button and no-access selectors

---------

Co-authored-by: Nathan Voxland <nathan@metabase.com>

* Add user_invited and invite_to_view_opened analytics events (#76646)

* Add user_invited and invite_to_view_opened analytics events

* Reword the external-invite tracking comment in NewUserModal

* Type isEmailAlreadyInUse's error with a guard instead of a cast

* Return an error_code for the duplicate-email 400 and key isEmailAlreadyInUse off it

* Move invite-events analytics into common/analytics and assert events fire once

---------

Co-authored-by: Nathan Voxland <nathan@metabase.com>
2026-07-06 08:39:46 -07:00
Braden Shepherdson
2c6e6b806d [pdf] Remove branding for white-labeling customers (#76426)
Fixes UXW-4575.

The "Made with Metabase" branding is skipped for customers with white-labeling enabled.
2026-07-06 15:07:02 +00:00
Braden Shepherdson
2f98715cbc [PDFs] Respect the explicit text alignment setting for Markdown cards (#77031)
Fixes UXW-4703.
2026-07-06 10:45:54 -04:00
Brad Anderson
69c3756253 GRO-536 replace ad hoc metaplow functions with @metabase/track alpha (#76618) 2026-07-06 10:10:06 -04:00
Sébastien
344861dd67 Link to usage conditions in the theme preview acceptance prompt (#77072) 2026-07-06 15:38:21 +02:00
Jakub Chodorowicz
3487a7801f GDGT-2750: Treemap renders incorrectly in PDF export (#76996)
* fix treemap wrong size in grid driven pdfs

* add missing loki screenshot
2026-07-06 15:19:43 +02:00
Kevin Kelleher
1fbea58471 Fix tooltips showing incorrect date ranges for native queries (#76295)
* don't format native query weekly dates as ranges in tooltips

* delete e2e test for 25007
2026-07-06 07:41:05 -04:00
Oleh K
605c237a1a Allow map tile server host in img-src CSP (#76967)
* fix(custom-viz): allow map tile server host in img-src CSP

When Custom Visualizations are enabled, csp-img-enabled is forced on,
switching img-src from a permissive wildcard to a restricted allowlist.
Map tiles (OpenStreetMap by default, or a custom map-tile-server-url)
were never added to that allowlist, so map visualizations broke.

Automatically add the configured tile server's origin to img-src,
mirroring how custom font files are added to font-src. The {s} subdomain
placeholder becomes a * wildcard and the {z}/{x}/{y} path is dropped.

* docs: note map tile server is always allowed under restricted image domains

* Missing update to setting description

* Update comment

* Fix whitespace
2026-07-06 08:06:46 +02:00
Romeo Van Snick
b2d81611cc Build the metabase/router facade for react-router v7 (#76859)
* Rename router useRouter to kebab-case use-router

* Add router facade shared types and path/search utils

* Add useNavigate facade hook

* Add useLocation facade hook

* Add useParams facade hook

* Add useSearchParams facade hook

* Add Navigate facade component

* Add Outlet facade shim

* Add Link facade re-export

* Reference react-router v7 docs from each facade helper

* Lock facade tests to react-router v7 behaviour

* Import useRouter from the metabase/router barrel

* Sort metabase/router barrel exports

* Test useNavigate splits query from a string destination with state

* Test setSearchParams clears the query when called with no argument

* Use router/<name> pattern for facade test describe blocks

* Link react-router v7 API reference from facade types

* Use react-router's official descriptions for facade type comments

* Use useMount instead of a bare useEffect in Navigate

* Expand inline JSDoc in router utils to multiline

* Implement useNavigate over v3 history instead of redux dispatch

* Navigate via react-router's router API instead of history directly

* Re-navigate on prop change in Navigate to match v7

* Default useLocation state to null and note v3 helper limitations

* Pass Navigate state by reference and clone search-param updater arg

* Expose v3 splat param under v7's * key in useParams

* Drop the existing hash in setSearchParams to match v7

* Churn useNavigate identity per navigation to match v7

* Support defaultInit in useSearchParams to match v7

* Match v7's URLSearchParamsInit pair-tuple type

* Match v7's useParams generic signature
2026-07-06 09:08:31 +10:00
Alexander Polyankin
af81edb346 Revert "Enable streaming results for app db queries with postgres" (#77048)
Revert "Enable streaming results for app db queries with postgres (#76645)"

This reverts commit 49cc599892.
2026-07-05 04:55:18 -04:00
Denis Berezin
dc91702b6b UXW-4658 Fix viz settings dropdown broken styles (#76845) 2026-07-04 01:47:49 +03:00
Braden Shepherdson
b8d634be90 [PDFs] Reuse query results and PNG rendering memory pools for PDFs (#76918)
The work done in #76355 and #76504 to fix some OOMs while generating
subscriptions modified the core rendering pipeline (static viz charts to
PNGs) concurrently with the work happening on PDFs.

This adapts the PDF generation to reuse both in-memory and on-disk query
results, and to use the whole-dashboard budget of results in memory before
spilling to disk. Cleans up all temporary files when finished.
2026-07-03 16:01:30 -04:00
Nathan Voxland
471df8492b Add request info to 'Request canceled before finishing' log line (#77023) 2026-07-03 14:20:45 -05:00
technomancy
e0ad467236 Take existing tables into account when determining already-loaded bigquery (#76936)
Take existing tables into account when determining already-loaded bigquery.

We no longer have bigquery tables that constantly think that they need
to be recreated, but we have fallen a little too far in the other
direction; datasets that get their DB created but fail midway thru
will still be treated as loaded.

In snowflake we have a way of checking this down to the individual row
counts and counting as not-already-loaded if there's a mismatch. I
don't see a way to do this in bigquery, but we can at least check that
all the tables exist. If we get a failed partial load that gets all
the tables created but fails the rows that will still require manual
intervention.

Also stop using (config/current-major-version) when qualifying dataset
names; turns out this is not at all reliable in CI. This unfortunately
means that we don't actually have cross-major-version isolation; the
best we can do is isolate master/release from all other branches,
which is still an improvement over what we have now.
2026-07-03 17:26:34 +00:00
Timofey Kachalov
eac68e3fe9 Update c3p0 version (#77000) 2026-07-03 20:30:28 +04:00
Alexander Polyankin
d141f2f00e jdbc-data-warehouse-connection-pool-max-pending-checkouts (#77004) 2026-07-03 16:19:41 +00:00
metamben
5c0455b3ec Stop pretending the cache is up to date (#76898)
Closes GIT-10454
2026-07-03 18:38:33 +03:00
Mihael Konjević
a9ceb5f20d Drop unsupported get-day-of-week week-modes in repair (#76766)
`get-day-of-week` accepts a positional week-mode, and the ::week-mode
schema admits :iso, :us, and :instance (shared with get-week). But only
the default (no-mode) and :iso forms have a lowering in lib.filter.desugar
— :us and :instance desugar to a nil temporal-extract unit and 500 at SQL
compile time (observed: an LLM emitting "instance" for "day of week on
weekends"). Drop the unsupported mode, leaving the start-of-week-aware
default. :iso and the bare form are untouched.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-03 17:13:57 +02:00
Mihael Konjević
df0986902c Sharpen Metabot data-source discovery and construct guidance (#76767)
Prompt-snippet updates, independent of any code change:
- discovery: search to choose a source, navigate to drill in (don't skip
  the curated layer just because a raw table name is recognizable)
- data-sources: a source the user explicitly names is authoritative
- grounding: when several columns plausibly match, read descriptions and
  sample values rather than picking by name resemblance
- construct_notebook_query: a "translating the request" section (constraint
  vs breakout, apply every constraint, absolute vs relative dates)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-03 17:13:47 +02:00
Timofey Kachalov
9b3fe8e0ea Pin jackson-databind for databrocks/redshift/snowflake drivers (#76980) 2026-07-03 19:06:40 +04:00
Chris Truter
7ed335db9c Decouple library-retrieval and semantic-search features (#76872) 2026-07-03 15:31:06 +02:00
Timofey Kachalov
b83ac24d1e Update esbuild to 0.28.1 (#76908) 2026-07-03 17:16:51 +04:00
Alexander Polyankin
c32c55c589 MB_JDBC_DATA_WAREHOUSE_CONNECTION_POOL_CHECKOUT_TIMEOUT_MS (#76941)
* MAX_JDBC_DATA_WAREHOUSE_CONNECTION_POOL_CHECKOUT_TIMEOUT_MS

* use same dox

* fix

* fix

* fixes
2026-07-03 12:44:44 +00:00
Benoit Vinay
84b27f02a5 utm query params for docs search (#76674)
* utm query params for docs search

* Misc

* Copy updates
2026-07-03 14:39:22 +02:00
Timofey Kachalov
863d48e920 Pin jackson-databind for bigquery-cloud-sdk (#76899) 2026-07-03 09:09:46 -03:00
lbrdnk
06d3dd8cb4 Support creation and and update of a metric through mcp (#76809)
* Support creation and metric update through mcp

* kondo
2026-07-03 12:46:33 +02:00
Oleh K
bfdce241fe Make custom-viz dev-mode hot reload reliable (#76739)
* fix(custom-viz): make dev hot-reload resilient to transient failures

When the dev server is mid-rebuild its bundle endpoint can transiently
fail, and rapid edits / overlapping reloads could leave the viz showing a
stale bundle or a spurious "unavailable" toast.

- Backend: fetch-dev-bundle returns nil on upstream failure (mirroring
  fetch-dev-manifest) so the endpoint serves its existing retryable 503
  instead of a hard 500.
- Frontend: retry the dev bundle fetch on transient 5xx (fail fast on
  4xx), and tag each load with a monotonic sequence so a slower/older
  overlapping load can't overwrite a newer applied bundle or fire a stale
  toast (latest-wins).

* fix(custom-viz): render the freshest bundle after overlapping dev reloads

Overlapping dev reloads (rapid edits) could apply the newest bundle to the
visualizations registry but leave the chart rendering an older one: the
visualization only re-reads the registry when it remounts on the loading
toggle, and a plain boolean cleared after the first load resolved.

- Refcount in-flight loads so `loading` stays true until the last settles,
  so the single remount reads the freshest registered bundle.
- Stop retrying a load once a newer one has started (it would be discarded
  by the latest-wins guard anyway, and would keep `loading` held).

* fix(e2e): restore custom-viz dev plugin source between retries

The development-mode custom-viz test mutates the scaffolded plugin
source in place ("Above threshold" -> "Way above!") to verify hot
reload, but never reverts it. Since `before` does not re-run on a
Cypress retry, a retried attempt started from the mutated file and the
opening "Above threshold" assertion timed out against stale state.

Capture the pristine source in `before` (after the clean re-scaffold)
and rewrite it in `afterEach` so each attempt starts from the default.

* fix(e2e): use frozen lockfile for custom-viz SDK bun install

Skip lockfile resolution during the dev-mode `before` hook so the
install step is deterministic and faster, reducing the chance of the
120s setup timeout.

* fix(e2e): start custom-viz dev server per test, not per suite

The dev-mode test stops the dev server as its final assertion (revert to
default), but the server was started once in `before`. Since `before`
does not re-run on a Cypress retry or during burn-in, every run after the
first hit a dead server and failed at "verify the dev plugin is
registered".

Move the server start to `beforeEach` and the stop to `afterEach` (the
stop task is idempotent), keeping the heavy build/scaffold/install in
`before`.

* chore(custom-viz): trim verbose comments per review

* refactor(custom-viz): reuse retry util for dev bundle fetch

* fix(custom-viz): use > not >= in superseded check

The == case is impossible (loadAppliedSeq is only set to a load's own seq
on success, which returns before the catch; seqs are unique), so >= and >
are equivalent here. > matches the sibling loadStartedSeq check and reads
as "a strictly newer load exists".

* fix(custom-viz): only the latest-started load registers its bundle

The apply-guard bailed only when a newer load had already applied; bail
when a newer load has merely started too (applying implies starting, so
this subsumes the old check). Reuses isLatest(), consistent with the
retry loop and the superseded check.

* refactor(custom-viz): name load-sequence maps by plugin id

* test(custom-viz): scaffold dev plugin per attempt instead of capturing source

Move the plugin scaffold (init + npm i) into beforeEach so each attempt
starts from a pristine source, dropping the pristineSrc capture/restore.
The expensive SDK build stays one-time in before.
2026-07-03 12:37:31 +02:00
Timofey Kachalov
3777617772 Update @hey-api/openapi-ts (#76897) 2026-07-03 14:17:57 +04:00
Sébastien
06ed290471 Fix crash when editing column settings in the embedding SDK (#76795)
* fix crash when editing column settings in embedding SDK

* add e2e test for editing native question column title in embedding SDK
2026-07-03 11:51:23 +02:00
Oleksandr Yakushev
7afc643c0c [lint] Implement Kondo hooks for metabase.util.match macros (#73986) 2026-07-03 12:31:46 +03:00
Mahatthana (Kelvin) Nomsawadi
960b9fa2d1 Gate SDK query builder controls on create-queries permission (#76862)
* fix(embedding-sdk): gate query builder controls on create-queries permission

Filter/Summarize/Breakout dropdowns and the notebook editor toggle rendered
regardless of query permissions, showing non-working controls for users
without create-queries access. Mirrors main app's FilterHeaderButton/
QuestionSummarizeWidget/QuestionNotebookButton gating (isEditable, !isNative,
!isArchived) via a new shouldRenderQueryBuilderEditingControl.

Fixes EMB-1963

* test(embedding-sdk): unit test shouldRenderQueryBuilderEditingControl

Covers editable/native/archived/no-question cases, plus the missing
create-queries case by building a query against metadata with the source
table excluded (mirrors what the backend does when that permission is
missing) rather than mocking metabase-lib.

* fix(embedding-sdk): hide decorative icon from ToolbarButton accessible name

Icon set role="img" aria-label="<name> icon" unconditionally, so a button's
accessible name became "filter icon Filter" instead of just "Filter",
breaking cy.button()/getByRole name lookups.

* test(embedding-sdk): e2e test for query builder permission gating

Confirms Filter/Summarize/notebook editor toggle are hidden for a user
without create-queries permission on the underlying table, and shown for
one with it, using existing readonly/readonlynosql fixture users whose
default group permissions already match each scenario.

Fixes EMB-1963

* docs(embedding-sdk): tighten comments, scope test fixtures per-test

Bullet the three omitted main-app gating conditions instead of run-on
prose, shorten the missing-permission test comment, and move each
question fixture into the test that uses it instead of module-level
constants shared across unrelated tests.

* fix(embedding-sdk): guard BreakoutDropdown on missing question

Matches the !question || !shouldRenderQueryBuilderEditingControl(question)
pattern used by FilterDropdown and EditorButton.
2026-07-03 10:20:30 +01:00
Oleksandr Yakushev
6c81e71958 [schema] Validation performance improvements (#64815) 2026-07-03 12:19:46 +03:00
Chris Truter
caf298bc5a Support OSI ai_context string shorthand (#76865) 2026-07-03 09:43:46 +02:00
Chris Truter
71c929d0d9 Metabot catalog to include all curated entities (#76863) 2026-07-03 09:42:14 +02:00
Romeo Van Snick
34296d1975 Reuse dashboard save response and make dashboard e2e saves deterministic (#76507)
* Let fetchDashboard accept a prefetched dashboard

(cherry picked from commit 63425d8754777a96f023c3be6028c5a45b4607d5)

* Use save response to refresh dashboard instead of refetching

(cherry picked from commit 8f5aff044beb8290f9c63f7ebb041ffbe8c2b392)

* Test save reuses response without refetching the dashboard

(cherry picked from commit a90b2885f7ac19ed472bed1018a88fa29fee60be)

* Update e2e save helper for dropped post-save dashboard refetch

(cherry picked from commit 41bba584ae41640903c06fcd76022a1569d6f087)

* Update e2e dashboard reload expectations for save-response reuse

(cherry picked from commit 97fabf4f8df7d0c1345ea33a6136a1c3ba76933f)

* Wait on dashboard UI instead of phantom reload when returning from drill

(cherry picked from commit 19181e1345af6af1fe46f323c3b0362a5286e1b4)

* Add waitForDashcardsToLoad e2e helper and use it in #32444 test

(cherry picked from commit fa3a0e989f2166f50af10a0294fcda9bfef968d9)

* Settle saveDashboard on dashcards loaded instead of fixed sleep

(cherry picked from commit b7a2e157b6db12a2f4f8ab10b7c19f68437b94ed)

* Drop redundant saveDashboard waitMs args now that it settles deterministically

(cherry picked from commit e8827b06955f581dde739491d3aef2bee5f90be9)

* Drop redundant post-save sleep now covered by saveDashboard settle

(cherry picked from commit c3ae1c65997165fffc0fa1c394d1d2765b4fb2b8)

* Drop tombstone comments per review

* Make waitForDashcardsToLoad tolerant of dashboards without a grid

* Anchor dashcard settle on dashboard body to avoid early return

* Revert broad saveDashboard auto-settle; keep save-reuse and opt-in waitForDashcardsToLoad

* Settle saveDashboard on dashcards loaded + grid layout stable; drop waitMs sleeps

* Wait for filter widgets to settle after save (parameter panel re-render)

* Make editDashboard resilient to a dropped Edit click after save

* Make editDashboard retry work inside cy.within (use cy.document not cy.get body)
2026-07-03 08:37:10 +10:00
Romeo Van Snick
4dcb2a7f86 Add routing behavior lock-down tests (#76322)
* Add routing behavior lock-down tests

* Add updateUrl navigation producer lock-down tests

* Add table-route preservation lock-down tests for updateUrl

* Add locationChanged read-seam lock-down tests

* Add dashboard URL-query sync lock-down tests

* Restore console spies in routing lock-down tests

* Fix import order lint in dashboard url-query test

* Fix parameterValues type in dashboard url-query test
2026-07-03 07:56:20 +10:00
github-automation-metabase
f19e78d9fc Auto-update documentation for master (#76924)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-02 17:37:52 -04:00
metamben
44570e07cd Convert all ASCII chars in var names not allowed by mongo to _ (#76761)
Closes QUE2-704
2026-07-03 00:33:36 +03:00
github-automation-metabase
b4b8e57722 Restore 30s timeout on findByText (#76021)
* auto stress test

* better options

* fix(e2e): restore 30s timeout on findByText for impersonated permission test

The timeout was removed in a8cc638d2f when updating the error message text.
The impersonated write path takes 15-20s, far exceeding the default 4s timeout,
causing consistent test failures (quarantined for 33 days).

---------

Co-authored-by: Ryan Laurie <iethree@gmail.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
2026-07-02 19:18:59 +00:00
Michael Eby
1fe4641c3e docs: new dimension picker in metrics explorer (#76552)
* docs: new dimension picker in metrics explorer

* Optimized 4 images, saved 493.5 KB (52.8% smaller)

* Edits from Alex

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-02 14:48:50 -04:00
github-automation-metabase
bc91754508 Stabilize flaky pivot-table dashboard filter spec (#76747)
* Fix flaky pivot-table dashboard filter spec: wait for dashcard load before opening question

The "does not use extra filtering stage for pivot tables" spec clicked the pivot
dashcard's legend title immediately after exiting edit mode. The title's
navigation handler is only wired once the card series has reloaded, so an early
click was a no-op and the /api/dataset/pivot request never fired, timing out
cy.wait("@datasetPivot"). Wait for the dashcard to finish loading (visible title
+ no loading indicator) before clicking.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Give pivot-table dashboard filter spec a throttle-tolerant pivot wait

Clicking the pivot dashcard title navigates to an ad-hoc QB that must boot
the route, load table metadata, and only then issue /api/dataset/pivot. Under
network throttling that chain can exceed cy.wait's default 5s timeout, so the
wait occasionally fails even though the request does fire moments later. Wait
on the @datasetPivot alias with a throttle-tolerant timeout.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-02 12:41:18 -06:00
Ryan Laurie
2828ecaa8b Fix Linear Release Sync Again (#76909)
* add catch logic

* do it right this time
2026-07-02 12:14:08 -06:00
Ryan Laurie
8c937d249b Don't fail builds on linear release issue tracking (#76889)
don't ever fail a build for this
2026-07-02 18:56:31 +02:00
Riley Thompson
b27f04d153 Use report timezone if breakout field has datetime effective type (#76697)
use report timezone if bucketed field as temporal effective type
2026-07-02 11:10:59 -04:00
Egor Grushin
8d56144be1 GDGT-2589 Make H.popover() to select the Select component from "metabase/ui" (#76737)
* GDGT-2589 Make H.popover() to select the Select component from "metabase/ui"

* GDGT-2589 fix attributes drilling
2026-07-02 15:52:37 +01:00
Ben Grabow
2833fa63b2 Exclude audit db when coalescing default perms (#76608)
* Exclude audit-db when selecting lowest permission level for group
2026-07-02 09:25:20 -05:00
Nemanja Glumac
7098c5576a Add a unified, dry-run ci-conductor quarantine gate (#76752)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-02 15:14:29 +02:00
Nicola Mometto
03b9522551 Incremental transforms merge (#76663)
* WIP: support for merge strategy via delete + insert

* PoC FE

* fix

* overridable method

* support for py

* refactor

* FE

* changelog

* FE fixes

* validate UK

* chore

* update FE

* tests

* remove compile-merge multi

* FE tests

* remove feature

* move component to its own file

* chore: test composite keys

* fix: override for sqlserver
2026-07-02 13:09:19 +00:00
Nick Fitzpatrick
eec1d1b0d5 Add only published filter to data studio table picker (#76521) 2026-07-02 18:28:32 +05:30
Alex Yarosh
a3596d04cf docs - password complexity (#76776)
* Revise password complexity guidelines in documentation

Updated password complexity requirements and options.

* Update docs/people-and-groups/changing-password-complexity.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Apply suggestions from code review

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-07-02 12:35:51 +00:00
github-automation-metabase
68f276b5a1 Auto-update documentation for master (#76849)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-02 08:31:35 -04:00
Jakub Chodorowicz
2e2aae3f62 GDGT-2527: Make new treemaps full width by default (#76804)
change the default size of treemap to full grid with
2026-07-02 14:08:52 +02:00
Mahatthana (Kelvin) Nomsawadi
2e33d53027 fix(sdk): open SQL editor when Metabot navigates to native hash URL (#76738)
* fix(embedding-sdk): open SQL editor when Metabot navigates to native hash URL

When Metabot sends navigate_to with /question#<native_hash>, SdkAdHocQuestion
was returning questionId=null (no numeric slug), so isNewQuestion=false and the
SQL editor never opened. Now detects dataset_query.type==='native' and returns
'new-native', which makes SdkQuestionProvider set isNewQuestion=true and
useNewQuestionEditorSync open the editor.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dwi9BjxKNSJsztkkVrsU8d

* test(sdk): use real embedding Metabot stream for SQL editor test

Replaces hand-rolled mock payload with a navigate_to event captured
verbatim from an actual embedding Metabot response, so the test
fixture matches real wire format (db id adjusted to match env).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012wNQmcGH7PCXMD1PqFLiBS

* refactor(sdk): call resolveQuestionId inline instead of in useMemo

It's a cheap derivation, not worth complicating the memo for.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012wNQmcGH7PCXMD1PqFLiBS

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-07-02 12:01:36 +01:00
Oleh K
132a7e674a refactor: Migrate icon tokens (disabled/secondary swap) (#76792)
* GDGT-2534 Migrate icon tokens (disabled/secondary swap + text aliases)

Per design, the icon tokens are corrected: `icon-disabled` and
`icon-secondary` swap meaning, and all four icon tokens become runtime
aliases of their text counterparts.

- Swap consumers: `icon-disabled` <-> `icon-secondary` call sites.
- Redefine in both themes:
  - icon-primary  -> var(--mb-color-text-primary)   (value unchanged)
  - icon-secondary -> var(--mb-color-text-secondary)
  - icon-disabled  -> var(--mb-color-text-disabled)
  - icon-brand    -> var(--mb-color-text-brand)      (brand[40] -> brand[50])

Token names are unchanged, so there's nothing to remove at cleanup. Icon
tokens aren't SDK public theme keys and aren't used in static-viz, so the
var() aliases are safe everywhere.

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-02 13:00:13 +02:00
Romeo Van Snick
a1a4a037fd Consolidate basename into a dedicated module (#76852)
* refactor: add basename module for app-wide basename state

* refactor: move basename off ApiClient into the basename module

* refactor: make setBasename tolerate nullish input

* refactor: drop redundant basename guard in sdk init

* test: capture original basename per-test in setupBasename

* fix: strip basename only as a prefix in getDatasetDownloadUrl
2026-07-02 19:20:12 +10:00
Romeo Van Snick
914130d706 Bundle-size stats: emit Description column (fixes 422 on upload) (#76860)
Bundle-size stats: emit Description column populated with the commit subject
2026-07-02 06:06:23 +00:00
Romeo Van Snick
2ed2645f5b Fix bundle-size extract: drop non-existent embedding-sdk.js pattern (#76857)
Fix bundle-size extract: drop non-existent embedding-sdk.js pattern (unzip exit 11)
2026-07-02 14:41:56 +10:00
Fraser
e73f7ecf1b Update affected test stats (#76855) 2026-07-02 16:36:02 +12:00
Romeo Van Snick
91bdbd3f21 Bundle-size: apples-for-apples PR check + delta-aware stats logger (#76409)
* Measure SDK/app bundle sizes from both uberjars, apples-to-apples

* Always report brotli bundle size, estimating when no .br is shipped

* Bundle-size stats: upload per-bundle deltas, skip unchanged commits

* Bundle-size stats: always record releases, gate/report on brotli delta

* Scope app to app-main and SDK totals to reachable code via the chunk graph

* Fall back to whole app/dist when stats lack reachableAssets

* Stats logger: record master only, drop release tags from the live series

* Measure SDK async chunks as loadable; split legacy initial/total

* Point bundle-size logger at table 79702

* Skip SDK bundle-size gate when base ref predates reachable-chunk stats

* Split bundle-size scripts into pure cores + I/O wrappers, add unit tests

* Bundle-size: extract legacy embedding-sdk.js fallback; fix stale as-served comments

* Retry stats upload with backoff; keep bundle-size run green if it still fails
2026-07-02 13:27:43 +10:00
appleby
9160419f64 BOT-1723 Support OpenAI models (#76499)
* Add default-openai-llm-metabot-model gpt-4.1-mini

* Filter openai list-models by supported-models

OpenAI's /vi/models endpoint returns ~140 models, many of which are not relevant (text embeddings, audio/video models)
or else deprecated. Filter this down to a whitelisted set of known supported models.

* Add grouping for openai models in provider-models-response

* Throw an exception if callers pass `:ai-proxy true` for openai

Similar to bedrock and azure, supporting this would require some work on the ai-service side, and we already reject
non-anthropic in validate-metabase-managed-provider!

* FE: enable openai provider in metabot admin UI config

* Drop gpt-4.1-mini from supported-models and change default to gpt-5.4

* Replace gpt-4.1 with gpt-5 in supported-models

* Bump metabase.metabot.example-question-generator/max-tokens to 4096 for gpt-5

GPT-5 produces a lot of reasoning tokens and sometimes exceeded the old limit.

* Remove reference to gpt-4.1-mini in docstring example

* Remove references to gpt-4.1 and gpt-4.1-mini in FE unit tests
2026-07-01 20:03:03 -07:00
Ryan Laurie
0cdbb874ac Add Linear Release tracking (#76711)
* Add Linear Release tracking

* use uniform helper

* fix typos 🤦‍♀️

* get linear release version
2026-07-01 18:16:21 +00:00
Eric Normand
6cc57802d4 Skip empty remote-sync commits after a no-op export (GHY-3934) (#76753)
* Skip empty remote-sync commits after a no-op export (GHY-3934)

A dirty RemoteSyncObject row whose serialized content already matches the
repo stages a net-zero tree change, so finishing the commit produced an
empty commit that still got pushed. GHY-3933's content-hash gating catches
the no-op-update-event case, but not the others: a full-export fallback
that re-serializes byte-identical content, a rename/delete whose old path
isn't known yet, a dedup name collision, or path/hybrid models.

Add an `empty-commit?` query to the CommitBuilder protocol (git layer
answers whether the staged tree equals the parent's; it does not decide
policy). full-export!/incremental-export! branch on it: when empty, abort
the commit, leave the version unadvanced, and report push-skipped — while
still reconciling RemoteSyncObject state so the stale dirty flags that
triggered the no-op are cleared.

* Docstring

* Unify remote-sync export commit lifecycle and skip empty merges

Extract commit-staged! — the open/stage/empty-commit?/finish-or-abort
lifecycle — and route full, incremental, and merge exports through it.
merge-and-store! moves from source.clj into impl.clj (next to the other
export paths) so it shares commit-staged! instead of duplicating the
lifecycle via replace-all-files!; source.clj keeps the merge computation
(compute-merge, preview-merge).

commit-staged! returns the :remote-sync/empty-commit sentinel when the
staged tree matches the parent, so the merge path no longer pushes an
empty commit either. An empty merge folds in any remote changes and
advances to the remote tip, reporting "pulled" (or "push-skipped" when
nothing changed on either side) rather than a misleading "merged, pushed 0".

* Inline merge-and-store! into export-merged!

The intermediate {:status ...} map that export-merged! re-dispatched via
case added nothing: inline the merge computation and commit so the merge
path reads like full-export!/incremental-export! — compute, commit-staged!,
reconcile, outcome.

Move the test seam down from merge-and-store! to source/compute-merge: the
export! tests stub the pure merge function and exercise the real commit
staging, and the three dedicated merge-and-store! unit tests are dropped as
redundant with merge-test (algorithm) and the commit-staged!/export coverage.

* Better docstrings

* Test empty-commit? against a real git repo

Exercise empty-commit? through the real JGit commit builder (not a mock):
identical re-stage and delete-of-absent-path read empty, real edits and new
files don't, aborted no-op checks leave the branch untouched, and the
memoized tree still yields a correct commit when finish-commit! follows.
2026-07-01 18:06:55 +00:00
Oleksandr Yakushev
f8cb4ca1bf Bump kixi.stats to 0.5.9 (#76789) 2026-07-01 15:01:44 -03:00
appleby
d3ee87fab5 Claude Sonnet 5 support (#76756) 2026-07-01 10:33:30 -07:00
Eric Normand
2d635fadf9 Drop metabase_version from serialization (GHY-4013) (#76760)
Serdes stamped every non-Setting entity (and the Card column) with the
instance build version on extract. Since the value differs between
instances, it produced spurious uncommitted changes during remote sync.

Compatibility is now governed by the versioned representation spec
(:card_schema + upgrade-card-schema-to), so the per-entity version stamp
no longer carries useful information. Stop serializing it:

- extract: remove the metabase_version stamp
- Card serdes spec: move :metabase_version from :copy to :skip
- load: remove the now-dead version-mismatch warning machinery

Legacy baseline fixtures still carry the field, exercising that older
exports import cleanly now that it's skipped.
2026-07-01 16:10:32 +00:00
lbrdnk
5c475f1d06 Add endpoint for execution of saved questions (#76720)
* Add endpoint for native query construction in expected format

* Add model import

* Add endpoint for execution of saved questions
2026-07-01 16:54:25 +02:00
lbrdnk
fe2715ef6b Add endpoint for native query construction in expected format (#76717)
* Add endpoint for native query construction in expected format

* Add model import

* Review remarks

* Endopint version
2026-07-01 15:20:39 +02:00
Sébastien
3d8b6293b8 Fix date-dependent test in ConversationFilters date dropdown (#76803)
fix date-dependent ConversationFilters date dropdown test
2026-07-01 18:46:40 +05:30
Nemanja Glumac
b4f0b23363 Reuse the ci-conductor contract types and utils in e2e reporting (#76746)
Replace e2e's local ConductorTest with the shared NormalizedTest wire shape
(plus a transient screenshotPath) and import toNumber from the module, so the
report path and the quarantine path can't drift on a test's identity. The
transport stays forked: e2e posts mid-run from Cypress's after:spec hook on
node-fetch, with screenshots and a dry-run mode the module's post-run transport
doesn't cover.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-01 13:13:29 +00:00
4415 changed files with 511657 additions and 383947 deletions

View File

@@ -102,3 +102,7 @@ breakage keeps happening, *that* is the signal a comment was warranted.
- End all files with a newline
- When editing tabular code, where the columns line up, try to keep them aligned
- Spaces on a line with nothing after it is not allowed
- After changing module boundaries (adding/removing/renaming a `src` namespace, a cross-module `require`
or `:model/X` reference, or a new module), run `./bin/mage fix-modules-config` to regenerate
`.clj-kondo/config/modules/config.edn` and keep `metabase.core.modules-test` green. No-op when nothing
drifted; see "Module Boundaries" in the project `CLAUDE.md`.

View File

@@ -257,7 +257,7 @@ Remove the old styled file entirely. Remove all imports of it from other files.
- Text: `"text-primary"`, `"text-secondary"`, `"text-disabled"`
- Background: `"background_page-primary"`, `"background_page-secondary"`, `"background_surface-hover"`
- Brand: `"core-brand"`, `"error"`, `"success"`, `"warning"`
- Brand: `"core-brand"`, `"feedback-negative"`, `"feedback-positive"`, `"feedback-warning"`
**Typography** (`fz`, `fw`, `lh`, `ta`, `ff`):
@@ -283,7 +283,7 @@ Remove the old styled file entirely. Remove all imports of it from other files.
- `--mb-color-background_page-primary`, `--mb-color-background_page-secondary`, `--mb-color-background_surface-hover`
- `--mb-color-border`, `--mb-color-border-strong`, `--mb-color-border-subtle`
- `--mb-color-core-brand`, `--mb-color-core-brand-hover`
- `--mb-color-error`, `--mb-color-success`, `--mb-color-warning`
- `--mb-color-feedback-negative`, `--mb-color-feedback-positive`, `--mb-color-feedback-warning`
- `--mb-color-shadow`, `--mb-color-focus`
- `--mb-color-accent0` through `--mb-color-accent7`

View File

@@ -179,6 +179,7 @@
clojure.core.async/take!
clojure.core.async/to-chan!
clojure.core.async/to-chan!!
metabase.ai-tracing.core/record!
metabase.api.macros.defendpoint.tools-manifest/assert-optional-fields-nullable!
metabase.channel.core/send!
metabase.channel.render.pdf/draw-too-large!
@@ -187,10 +188,17 @@
metabase.channel.render.pdf.font/load-fonts!
metabase.warehouses.models.database/assert-not-h2!
metabase.driver.sql-jdbc.execute/execute-prepared-statement!
metabase.mcp.usage/record-mcp-session!
metabase.mcp.usage/record-mcp-session-end!
metabase.mcp.usage/record-mcp-tool-call!
metabase.notification.models/create-notification!
metabase.oauth-server.core/reset-provider!
metabase.pulse.send/send-pulse!
metabase-enterprise.transforms-python.python-runner-test/execute!
;; MCP usage tests isolate their rows by unique keys (session id / tool name / duration /
;; client version) and clean up only those, so these deletes are safe in parallel.
metabase-enterprise.mcp.usage-test/cleanup!
metabase-enterprise.mcp.usage-test/cleanup-calls!
;; Workspace isolation functions are safe in parallel tests because they operate on
;; isolated, test-specific workspaces and databases that don't affect other tests
metabase-enterprise.workspaces.isolation/destroy-workspace-isolation!
@@ -252,9 +260,6 @@
;; misc config for built-in linters
;;
:invalid-arity {:skip-args [metabase.util.match/match-one
metabase.util.match/match-many
metabase.util.match/replace]} ; TODO (cam): can we fix these?
:refer-all {:level :warning, :exclude [clojure.test]}
:unused-referred-var {:exclude {compojure.core [GET DELETE POST PUT]}}
@@ -449,6 +454,9 @@
metabase-enterprise.action-v2.test-util/with-test-tables! clojure.core/let
metabase-enterprise.content-translation.routes-test/with-new-secret-key! clojure.core/fn
metabase-enterprise.entity-retrieval.reconcile-test/with-isolated-index clojure.core/fn
metabase-enterprise.mfa.enrollment-flow-test/with-fresh-user-session! clojure.core/fn
metabase-enterprise.mfa.login-flow-test/with-enrolled-rasta! clojure.core/fn
metabase-enterprise.mfa.recovery-codes-test/with-confirmed-enrollment! clojure.core/fn
metabase-enterprise.serialization.metadata-file-import.wire-format-test/with-tiny-fixture! clojure.core/fn
metabase-enterprise.serialization.test-util/with-dbs clojure.core/fn
metabase-enterprise.serialization.test-util/with-random-dump-dir clojure.core/let
@@ -581,7 +589,7 @@
metabase.api.common.internal-test/with-jetty-server hooks.common/with-one-binding
metabase.api.macros/defendpoint hooks.metabase.api.macros/defendpoint
metabase.app-db.schema-migrations-test.impl/test-migrations hooks.metabase.app-db.schema-migrations-test.impl/test-migrations
metabase.channel.render.js.svg/with-static-viz-context hooks.common/with-one-top-level-binding
metabase.channel.render.js.pool/with-static-viz-context hooks.common/with-one-top-level-binding
metabase.channel.template.handlebars-helper/defhelper hooks.metabase.channel.template.handlebars-helper/defhelper
metabase.channel.template.handlebars-test/with-temp-template! hooks.common/with-vec-first-binding
metabase.classloader.core/require hooks.clojure.core.require/lint-require
@@ -617,6 +625,9 @@
metabase.model-persistence.api-test/with-persistence-setup! hooks.common/with-one-top-level-binding
metabase.model-persistence.api-test/with-setup! hooks.common/with-one-top-level-binding
metabase.model-persistence.test-util/with-persistence-enabled! hooks.metabase.model-persistence.test-util/with-persistence-enabled!
metabase.mq.core/with-queue hooks.common/let-second
metabase.mq.test-util/with-test-mq hooks.common/with-one-binding
metabase.mq.core/def-listener! hooks.metabase.mq.impl/def-listener
metabase.models.interface/define-batched-hydration-method hooks.metabase.models.interface/define-hydration-method
metabase.models.interface/define-simple-hydration-method hooks.metabase.models.interface/define-hydration-method
metabase.permissions.core/allow-changing-all-users-group-members hooks.common/do*
@@ -708,6 +719,10 @@
metabase.util.log/warn hooks.metabase.util.log/info
metabase.util.log/warnf hooks.metabase.util.log/infof
metabase.util.malli.registry/def hooks.metabase.util.malli.registry/def
metabase.util.match/match-one hooks.metabase.util.match/match-one
metabase.util.match/match-many hooks.metabase.util.match/match-many
metabase.util.match/replace hooks.metabase.util.match/replace
metabase.util.match/replace-in hooks.metabase.util.match/replace-in
metabase.util/case-enum hooks.metabase.util/case-enum
metabase.util/format-color hooks.metabase.util/format-color
metabase.xrays.api.automagic-dashboards-test/with-indexed-model! hooks.metabase.xrays.api.automagic-dashboards-test/with-indexed-model!
@@ -751,6 +766,7 @@
metabase.test/with-temporary-raw-setting-values macros.metabase.test.util/with-temporary-raw-setting-values
metabase.users.models.user-test/with-groups! macros.metabase.users.models.user-test/with-groups!
metabase.util.namespaces/import-fn macros.metabase.util.namespaces/import-fn
metabase.util.namespaces/import-macro macros.metabase.util.namespaces/import-macro
metabase.xrays.related-test/with-world macros.metabase.xrays.related-test/with-world}}
:config-in-comment

View File

@@ -159,7 +159,8 @@
{:team "Metabot"
:api #{metabase.agent-api.api
metabase.agent-api.init}
:uses #{api
:uses #{ai-tracing
api
auth-identity
channel
collections
@@ -180,6 +181,8 @@
:model/Collection
:model/Dashboard
:model/DashboardCard
:model/DashboardTab
:model/Database
:model/Table
:model/User}}
@@ -192,6 +195,15 @@
models
util}}
ai-tracing
{:team "Metabot"
:api #{metabase.ai-tracing.api
metabase.ai-tracing.core
metabase.ai-tracing.init}
:uses #{api
settings
util}}
analytics
{:team "UX West"
:api #{metabase.analytics.api
@@ -828,7 +840,6 @@
metabase.driver.common
metabase.driver.connection
metabase.driver.ddl.interface
metabase.driver.h2
metabase.driver.impl
metabase.driver.init
metabase.driver.mysql
@@ -1064,6 +1075,27 @@
:model-exports #{:model/ModelIndex :model/ModelIndexValue}
:model-imports #{:model/Card :model/Collection}}
indexes
{:team "Gadget"
:api #{metabase.indexes.models.table-index
metabase.indexes.reconcile
metabase.indexes.schema}
:uses #{driver
models
util}
:model-exports #{:model/TableIndex}}
indexes-rest
{:team "Gadget"
:api #{metabase.indexes-rest.api}
:uses #{api
indexes
transforms-base
util}
:model-imports #{:model/Database
:model/TableIndex
:model/Transform}}
initialization-status
{:team "UX West"
:api #{metabase.initialization-status.core}
@@ -1103,6 +1135,7 @@
metabase.lib.metadata
metabase.lib.metadata.protocols
metabase.lib.options
metabase.lib.pivot
metabase.lib.schema
metabase.lib.schema.actions
metabase.lib.schema.aggregation
@@ -1226,13 +1259,19 @@
:api #{metabase.mcp.api
metabase.mcp.callback-api
metabase.mcp.core
metabase.mcp.init}
metabase.mcp.init
metabase.mcp.usage}
:model-exports #{:model/McpSessionLog
:model/McpToolCallLog}
:uses #{agent-api
ai-tracing
api
app-db
config
llm
metabot
oauth-server
premium-features
request
server
session
@@ -1271,6 +1310,7 @@
slackbot}
:uses #{activity-feed
agent-lib
ai-tracing
analytics
analytics-interface
api
@@ -1302,7 +1342,6 @@
settings
slackbot
sql-tools
store-api
sync
system
task
@@ -1318,6 +1357,8 @@
:model-imports #{:model/Card
:model/Collection
:model/Dashboard
:model/DashboardCard
:model/DashboardTab
:model/Database
:model/Field
:model/Glossary
@@ -1407,6 +1448,17 @@
:model/Table
:model/User}}
mq
{:team "UX West"
:api #{metabase.mq.init}
:uses #{analytics-interface
app-db
classloader
settings
startup
task
util}}
native-query-snippets
{:team "Graphy"
:api #{metabase.native-query-snippets.api
@@ -1850,6 +1902,7 @@
cache
config
dashboards
database-routing
driver
events
formatter
@@ -1943,20 +1996,12 @@
{:team "UX West"
:api #{metabase.sample-data.core
metabase.sample-data.init}
:uses #{config
models
permissions
:uses #{driver
plugins
settings
sync
util}
:model-imports #{:model/Card
:model/Dashboard
:model/DashboardCard
:model/DataPermissions
:model/Database
:model/Field
:model/Table}}
:model-imports #{:model/DataPermissions :model/Database :model/Table}}
search
{:team "UX West"
@@ -2070,6 +2115,7 @@
channel
config
events
premium-features
request
settings
sso
@@ -2167,8 +2213,7 @@
sql-parsing
{:team "DevEx"
:api #{metabase.sql-parsing.core}
:uses #{analytics-interface
util}}
:uses #{analytics-interface util}}
sql-tools
{:team "DevEx"
@@ -2307,9 +2352,11 @@
config
lib
lib-be
mcp
permissions
premium-features
search
session
util}
:model-imports #{:model/AiUsageLog
:model/Card
@@ -2374,6 +2421,7 @@
database-routing
driver
events
indexes
lib
lib-be
models
@@ -2403,6 +2451,7 @@
:model/Database
:model/Field
:model/Table
:model/TableIndex
:model/User}}
transforms-base
@@ -2416,11 +2465,13 @@
:model-imports #{:model/Database
:model/Field
:model/Table
:model/TableIndex
:model/Transform
:model/TransformRun}
:uses #{database-routing
driver
events
indexes
lib
lib-be
premium-features
@@ -2496,7 +2547,8 @@
:model/QueryExecution
:model/Segment
:model/Table}
:uses #{lib
:uses #{app-db
lib
lib-be
models
settings
@@ -2846,6 +2898,7 @@
:uses #{driver
premium-features
enterprise/advanced-config
enterprise/mfa
enterprise/scim
enterprise/semantic-search
enterprise/sso}
@@ -2871,7 +2924,6 @@
app-db
audit-app
classloader
config
driver
lib
models
@@ -3080,7 +3132,6 @@
{:team "UX West"
:api #{metabase-enterprise.database-routing.api}
:uses #{api
config
database-routing
driver
events
@@ -3253,6 +3304,18 @@
premium-features}
:model-imports #{:model/Card :model/Collection :model/Table}}
enterprise/mcp
{:team "Metabot"
:api #{metabase-enterprise.mcp.init}
:uses #{analytics
mcp
metabot
premium-features
task
util}
:model-imports #{:model/McpSessionLog
:model/McpToolCallLog}}
enterprise/memoize-monitor
{:team "Graphy"
:api #{metabase-enterprise.memoize-monitor.init}
@@ -3306,6 +3369,22 @@
util}
:model-imports #{:model/MetabotConversation :model/MetabotFeedback :model/MetabotMessage}}
enterprise/mfa
{:team "Graphy"
:api #{metabase-enterprise.mfa.core
metabase-enterprise.mfa.init
metabase-enterprise.mfa.routes}
:uses #{api
appearance
channel
config
events
premium-features
settings
sso
util}
:model-imports #{:model/AuthIdentity :model/User}}
enterprise/permission-debug
{:team "UX West"
:api #{metabase-enterprise.permission-debug.api}
@@ -3485,6 +3564,7 @@
config
connection-pool
events
lib-be
llm
metabot
models
@@ -3513,7 +3593,6 @@
app-db
appearance
collections
config
events
lib
logger
@@ -3609,7 +3688,9 @@
{:team "Graphy"
:api #{metabase-enterprise.transforms.api}
:uses #{premium-features
enterprise/transforms-inspector}}
util
enterprise/transforms-inspector}
:model-imports #{:model/Transform}}
enterprise/transforms-inspector
{:team "Gadget"

View File

@@ -36,6 +36,9 @@
;; Definitely thread safe
metabase.test.util.dynamic-redefs/patch-vars!
;; test-only cleanup of in-memory throttle state (atom resets)
metabase.session.api/reset-throttlers-for-testing!
;; TODO: most of these symbols shouldn't be here, we should go through them and
;; find the functions/macros that use them and make sure their names end with !
;; best way to do this is try remove each of these and rely on kondo output to find places where it's used

View File

@@ -6,3 +6,8 @@
`(def ~(-> sym name symbol) "docstring" ~sym))
([sym name]
`(def ~name "docstring" ~sym)))
(defmacro import-macro
"Kondo macro replacement for [[metabase.util.namespaces/import-macro]]."
[sym]
`(def ~(-> sym name symbol) "docstring" ~sym))

View File

@@ -0,0 +1,18 @@
(ns hooks.metabase.mq.impl
(:require
[clj-kondo.hooks-api :as hooks]))
(defn def-listener
"Kondo hook for `mq/def-listener`. Rewrites to a `fn` form so kondo can analyze bindings.
Form:
(mq/def-listener! :queue/bar [msgs] body...)"
[{:keys [node]}]
(let [[_ _channel-name bindings & body] (:children node)
;; rewrite as: (fn [bindings...] body...)
new-node (hooks/list-node
(list*
(hooks/token-node 'fn)
bindings
body))]
{:node new-node}))

View File

@@ -0,0 +1,132 @@
(ns hooks.metabase.util.match
(:require [clj-kondo.hooks-api :as api]))
(defn- token-node? [node token-name]
(and (api/token-node? node)
(= (str (:value node)) token-name)))
(defn- keyword-node? [node k]
(and (api/keyword-node? node)
(= (:k node) k)))
(defn- binding-symbol?
"True when the token is a plain symbol that should be treated as a binding
(not a keyword, not a boolean literal, not nil, not a number, not `_`)."
[node]
(and (api/token-node? node)
(let [v (:value node)]
(and (symbol? v)
(not (contains? '#{_ nil true false} v))))))
;; To establish fake let bindings, we need to bind them to something. This "something" has to be vague enough to trick
;; kondo into not looking too much into it. E.g., if we bind everything to `nil`, Kondo linters will get fired up.
(def opaque-node (api/list-node (list (api/token-node 'rand-nth) (api/list-node []))))
(defn collect-bindings
"Return a list of token nodes (symbols) introduced as bindings by `pattern`."
[pattern]
(cond
(binding-symbol? pattern)
[[pattern opaque-node]]
;; Lists: (:or ...), (:and ...), (sym :guard pred ...), or a quoted symbol.
(api/list-node? pattern)
(let [[head & rst] (:children pattern)]
(cond (or (keyword-node? head :or)
(keyword-node? head :and))
(mapcat collect-bindings rst)
(api/token-node? head)
(cond-> []
(binding-symbol? head) (conj [head opaque-node])
(keyword-node? (first rst) :guard) (conj [(api/token-node '_) (second rst)]))
;; anything else (e.g. a function call used as predicate) — no bindings
:else []))
(api/vector-node? pattern)
(mapcat (fn [node]
(when-not (token-node? node "&")
(collect-bindings node)))
(:children pattern))
;; Maps: keys are literal selectors, values are sub-patterns.
;; Special value-symbols &truthy and _ are NOT user bindings.
(api/map-node? pattern)
(let [children (:children pattern)
pairs (partition 2 children)]
(mapcat (fn [[_k v]]
(when-not (or (token-node? v "&truthy")
(token-node? v "_"))
(collect-bindings v)))
pairs))
;; For sets, make sure to use them because they may reference some of the outer local bindings, so if we don't
;; include them, Kondo will complain about those bindings being unused.
(api/set-node? pattern)
[[(api/token-node '_) pattern]]
;; Anything else — no bindings.
:else []))
(defn- dedupe-bindings
"Prevent Kondo complaining that we have multiple fake bindings."
[pairs]
(loop [[[sym v] & r] pairs, seen #{}, result []]
(cond (nil? sym) result
(and (seen sym) (not (token-node? sym "_"))) (recur r seen result)
:else (recur r (conj seen sym) (conj result sym v)))))
(defn match-one
"clj-kondo :analyze-call hook for match-one.
Rewrites
(match-one value
pat1 ret1
pat2 ret2
...)
into a `let` form that declares all binding symbols introduced by the patterns, so clj-kondo knows they are
legitimate and won't warn about unresolved/unused symbols:
(let [<all-bindings> (rand-nth []) ...]
(or ret1 ret2 ...))"
[{:keys [node]}]
(let [[_ value & clauses] (:children node)]
(when (odd? (count clauses))
(api/reg-finding!
{:message "match-one/match-many/replace requires an even number of pattern/result pairs"
:type :metabase/match-odd-clauses
:row (:row node)
:col (:col node)
:filename (-> node meta :filename)}))
(let [pairs (partition 2 clauses)
all-bindings (->> pairs
(mapcat (fn [[pat _ret]] (collect-bindings pat)))
dedupe-bindings)
special-bindings [(api/token-node '_) value
(api/token-node '&match) opaque-node
(api/token-node '&parents) opaque-node
(api/token-node '&recur) opaque-node
;; Pretend to use &match, &parents, and &recur so that Kondo doesn't complain about them
;; if they are not used by the user code.
(api/token-node '_) (api/token-node '&match)
(api/token-node '_) (api/token-node '&parents)
(api/token-node '_) (api/token-node '&recur)]
binding-nodes (into special-bindings all-bindings)
result-exprs (map second pairs)
new-node (api/list-node
(list
(api/token-node 'let)
(api/vector-node binding-nodes)
(api/list-node
(concat [(api/token-node 'clojure.core/or)] result-exprs [opaque-node]))))]
{:node new-node})))
(def match-many match-one)
(def replace match-one)
(defn replace-in [context]
;; Everything is the same as in match-one, just drop the middle argument.
(match-one (update-in context [:node :children] (fn [[sym value path & clauses]] (list* sym value clauses)))))

View File

@@ -0,0 +1,59 @@
(ns hooks.metabase.util.match-test
(:require
[clj-kondo.hooks-api :as hooks]
[clj-kondo.impl.utils]
[clojure.test :refer :all]
[hooks.metabase.util.match :as sut]))
(defn- expand [src]
(-> (sut/match-one {:node (hooks/parse-string (pr-str src))})
:node
hooks/sexpr))
(defn- lint [src]
(binding [clj-kondo.impl.utils/*ctx* {:config {:linters {:metabase/match-odd-clauses {:level :warning}}}
:ignores (atom nil)
:findings (atom [])
:namespaces (atom {})}]
(expand src)
@(:findings clj-kondo.impl.utils/*ctx*)))
(deftest odd-clauses-triggers-warning-test
(is (=? [{:type :metabase/match-odd-clauses}]
(lint '(metabase.util.match/match-one [] [a b c])))))
(deftest expansion-test
(testing "simple expansion example"
(is (= '(let [_ []
&match (rand-nth ())
&parents (rand-nth ())
&recur (rand-nth ())
_ &match
_ &parents
_ &recur
a (rand-nth ())
b (rand-nth ())
c (rand-nth ())]
(clojure.core/or (+ a b) (rand-nth ())))
(expand '(match-one [] [a b c] (+ a b))))))
(testing "complicated expansion example that uses most match-one macro features, and also binding deduplication by the rewriter"
(is (= '(let [_ []
&match (rand-nth ())
&parents (rand-nth ())
&recur (rand-nth ())
_ &match
_ &parents
_ &recur
val1 (rand-nth ())
a (rand-nth ())
_ #{maybe important}
rst (rand-nth ())
x (rand-nth ())
_ (= x 3)
b (rand-nth ())]
(clojure.core/or (+ a val1) (rand-nth ())))
(expand '(match-one []
(:or [{:key1 val1, :key2 &truthy, :key3 _} _ a #{maybe important} & rst]
(:and (x :guard (= x 3))
[a b]))
(+ a val1)))))))

28
.coderabbit.yaml Normal file
View File

@@ -0,0 +1,28 @@
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
reviews:
high_level_summary: false
review_status: false
auto_review:
enabled: false
drafts: true
labels:
- "coderabbit"
path_filters:
- "!**/*.snap"
- "!**/*.po"
- "!**/bun.lock"
- "!**/package-lock.json"
tools:
eslint:
enabled: false
knowledge_base:
code_guidelines:
filePatterns:
- ".claude/skills/clojure-review/SKILL.md"
- ".claude/skills/typescript-review/SKILL.md"
- ".claude/skills/e2e-test-review/SKILL.md"
- ".claude/skills/docs-review/SKILL.md"

View File

@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/vscode/devcontainers/java:21
FROM mcr.microsoft.com/vscode/devcontainers/java:25
# Set up nodesource, install node, bun, fontconfig for static viz, rlwrap for dev ergonomics

View File

@@ -1,5 +1,6 @@
.git
.babel_cache
target/*
target
.circleci
.cpcache
.devcontainer
@@ -15,6 +16,7 @@ test_config/*
test_modules/*
test_resources/*
node_modules
**/node_modules
**metabase.jar
*.db

View File

@@ -17,6 +17,9 @@ inputs:
loki-infra-touched:
description: Whether Loki infra changed.
required: true
e2e-infra-touched:
description: Whether e2e harness/support code changed.
required: true
shared-sources-touched:
description: Whether cljc/cljs/package.json changed.
required: true
@@ -40,6 +43,34 @@ runs:
steps:
- name: Prepare Node + Bun
uses: ./.github/actions/prepare-node-bun
- name: Resolve closest-ancestor e2e coverage manifest
id: manifest
uses: actions/github-script@v9
with:
script: | # js
const { pathToFileURL } = require("url");
const { resolveCoverageManifest } = await import(
pathToFileURL(
`${process.env.GITHUB_WORKSPACE}/.github/scripts/resolve-coverage-manifest.mjs`,
).href,
);
const result = await resolveCoverageManifest({
github,
owner: context.repo.owner,
repo: context.repo.repo,
headSha: context.payload.pull_request?.head?.sha ?? context.sha,
});
core.setOutput("path", result?.path ?? "");
- name: Build dependency graph
shell: bash
run: |
# Quiet on success; surface output only if install fails.
bun install --frozen-lockfile > /tmp/bun-install.log 2>&1 \
|| { echo "bun install issues (continuing):"; tail -20 /tmp/bun-install.log; }
bunx depcruise frontend/src enterprise/frontend/src \
--config .dependency-cruiser.cjs \
--output-type json > dependency-graph.json || true
- name: Create test plan
id: compute
shell: bash
@@ -49,18 +80,52 @@ runs:
BE_CHANGED_FILES: ${{ inputs.be-changed-files }}
UNIT_INFRA_TOUCHED: ${{ inputs.unit-infra-touched }}
LOKI_INFRA_TOUCHED: ${{ inputs.loki-infra-touched }}
E2E_INFRA_TOUCHED: ${{ inputs.e2e-infra-touched }}
SHARED_SOURCES_TOUCHED: ${{ inputs.shared-sources-touched }}
DEP_GRAPH_JSON: dependency-graph.json
E2E_SPEC_MANIFEST: ${{ steps.manifest.outputs.path }}
run: |
# on failure create-test-plan falls back to the rules graph.
bun install --frozen-lockfile || true
bunx depcruise frontend/src enterprise/frontend/src \
--config .dependency-cruiser.cjs \
--output-type json > dependency-graph.json || true
# stdout is the plan JSON; the planner's own info logs go to stderr.
bun .github/scripts/create-test-plan.ts > test-plan.json
echo "stats=$(jq -c '.stats' test-plan.json)" >> "$GITHUB_OUTPUT"
echo "fe_unit_specs_to_run=$(jq -c '.fe_unit_specs_to_run' test-plan.json)" >> "$GITHUB_OUTPUT"
echo "loki_stories_to_run=$(jq -c '.loki_stories_to_run' test-plan.json)" >> "$GITHUB_OUTPUT"
echo "e2e_specs_to_run=$(jq -c '.e2e_specs_to_run' test-plan.json)" >> "$GITHUB_OUTPUT"
OUTPUT=$(bun .github/scripts/create-test-plan.ts)
echo "$OUTPUT" | jq '.stats'
echo "stats=$(echo "$OUTPUT" | jq -c '.stats')" >> "$GITHUB_OUTPUT"
echo "fe_unit_specs_to_run=$(echo "$OUTPUT" | jq -c '.fe_unit_specs_to_run')" >> "$GITHUB_OUTPUT"
echo "loki_stories_to_run=$(echo "$OUTPUT" | jq -c '.loki_stories_to_run')" >> "$GITHUB_OUTPUT"
echo "e2e_specs_to_run=$(echo "$OUTPUT" | jq -c '.e2e_specs_to_run')" >> "$GITHUB_OUTPUT"
- name: Report test plan
shell: bash
run: |
plan=test-plan.json
row() { # name, selected, total
if [ "$2" -eq "$3" ]; then echo "| $1 | all ($3) | $3 |"; else echo "| $1 | $2 | $3 |"; fi
}
{
echo "## Affected test plan"
echo
echo "| Suite | Selected | Total |"
echo "|---|---:|---:|"
row "Unit" "$(jq '.stats.unit_specs_to_run_usage' "$plan")" "$(jq '.stats.unit_specs_all' "$plan")"
row "Loki" "$(jq '.stats.loki_stories_to_run_usage' "$plan")" "$(jq '.stats.loki_stories_all' "$plan")"
row "E2E" "$(jq '.stats.e2e_specs_to_run_usage' "$plan")" "$(jq '.stats.e2e_specs_all' "$plan")"
echo
echo "Changed: $(jq '.stats.fe_files_changed' "$plan") FE / $(jq '.stats.be_files_changed' "$plan") BE file(s) · $(jq '.stats.fe_modules_affected_usage' "$plan") FE module(s) affected"
echo
e2e_run=$(jq '.stats.e2e_specs_to_run_usage' "$plan")
e2e_all=$(jq '.stats.e2e_specs_all' "$plan")
if [ "$e2e_run" -eq "$e2e_all" ]; then
echo "**E2E: full run** — no manifest, or a change the coverage manifest can't scope (backend, e2e infra, cljc/cljs)."
else
echo "<details><summary><b>E2E specs to run ($e2e_run)</b></summary>"
echo
jq -r '.e2e_specs_to_run[]' "$plan" | sed 's/^/- /'
echo
echo "</details>"
fi
echo
echo "<details><summary>Full stats (rules vs usage graph)</summary>"
echo
echo '```json'
jq '.stats' "$plan"
echo '```'
echo "</details>"
} | tee -a "${GITHUB_STEP_SUMMARY:-/dev/null}"

View File

@@ -4,7 +4,7 @@ description: |
inputs:
java-version:
required: true
default: "21"
default: "25"
clojure-version:
required: true
default: "1.12.0.1488"

View File

@@ -0,0 +1,52 @@
name: Prepare CI Conductor
description: >-
Make the ci-conductor sources runnable in the workspace.
Unless the checkout is headed for master, they are overlaid from master, so every
branch runs the latest scripts while its workflow wiring stays branch-historical.
runs:
using: composite
steps:
- name: Detect bun
id: bun
shell: bash
run: |
if command -v bun >/dev/null; then
echo "present=true" >> "$GITHUB_OUTPUT"
else
echo "present=false" >> "$GITHUB_OUTPUT"
fi
- name: Install bun
if: steps.bun.outputs.present != 'true'
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version-file: "package.json"
token: ${{ github.token }}
# Anything headed for master runs master's own sources, so a PR can test its own changes.
- name: Fetch ci-conductor sources from master
if: ${{ github.base_ref != 'master' && github.ref_name != 'master' }}
uses: actions/checkout@v6
with:
repository: metabase/metabase
ref: master
path: .ci-conductor-master
persist-credentials: false
sparse-checkout-cone-mode: false
sparse-checkout: |
release/ci-conductor
e2e/support/ci_conductor.ts
# e2e/support/config.js and e2e/support/ci_conductor.ts resolve these by relative
# path at bundle time, so the sources have to land where the branch expects them.
- name: Overlay ci-conductor sources from master
if: ${{ github.base_ref != 'master' && github.ref_name != 'master' }}
shell: bash
run: |
set -euo pipefail
rm -rf release/ci-conductor
mv .ci-conductor-master/release/ci-conductor release/ci-conductor
mv .ci-conductor-master/e2e/support/ci_conductor.ts e2e/support/ci_conductor.ts
rm -rf .ci-conductor-master
echo "Overlaid ci-conductor sources from master."

View File

@@ -15,6 +15,10 @@ outputs:
runs:
using: "composite"
steps:
# e2e/support/config.js imports the reporter, so it has to be in place before Cypress bundles.
- name: Prepare CI Conductor
uses: ./.github/actions/prepare-ci-conductor
- name: Install Chrome v144
uses: browser-actions/setup-chrome@2e1d749697dd1612b833dba4a722266286fbefcd # v2.1.2
with:

View File

@@ -16,5 +16,5 @@ runs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.14"
bun-version-file: 'package.json'
token: ${{ github.token }}

View File

@@ -6,7 +6,7 @@ runs:
steps:
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.14"
bun-version-file: 'package.json'
token: ${{ github.token }}
- name: Build release scripts

View File

@@ -0,0 +1,38 @@
name: CI Conductor quarantine gate
description: >-
Check this job's test failures against ci-conductor's quarantine list.
Either enforces the quarantine or only prints a verdict (dry run).
Fails closed when enforcing but the `CI_CONDUCTOR_BASE_URL` is missing or unreachable.
inputs:
adapter:
description: Which gate to run — one of `backend`, `frontend`, `e2e`.
required: true
test-suite:
description: >-
Suite label to gate (CI_CONDUCTOR_TEST_SUITE). MUST match the label this
job reports under, or the gate checks the wrong quarantine list.
required: true
enforce-quarantine:
description: >-
Whether the gate actually gates the job. When "false", it only prints a verdict.
required: false
default: "false"
runs:
using: composite
steps:
- name: Prepare CI Conductor
uses: ./.github/actions/prepare-ci-conductor
- name: Check failures against the quarantine list
shell: bash
env:
CI_CONDUCTOR_TEST_SUITE: ${{ inputs.test-suite }}
ADAPTER: ${{ inputs.adapter }}
QUARANTINE_DRY_RUN: ${{ inputs.enforce-quarantine != 'true' }}
run: |
case "$ADAPTER" in
backend|frontend|e2e) ;;
*) echo "::error::quarantine-gate: unknown adapter '$ADAPTER' (expected backend|frontend|e2e)"; exit 1 ;;
esac
bun "release/ci-conductor/src/check-${ADAPTER}-quarantine.ts"

View File

@@ -15,21 +15,8 @@ inputs:
runs:
using: composite
steps:
- name: Detect bun
id: bun
shell: bash
run: |
if command -v bun >/dev/null; then
echo "present=true" >> "$GITHUB_OUTPUT"
else
echo "present=false" >> "$GITHUB_OUTPUT"
fi
- name: Install bun
if: steps.bun.outputs.present != 'true'
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.14"
token: ${{ github.token }}
- name: Prepare CI Conductor
uses: ./.github/actions/prepare-ci-conductor
- name: Report failed tests to ci-conductor
shell: bash
env:

View File

@@ -1,15 +1,17 @@
name: Embedding SDK Bundle Size Check
description: |
Downloads the current branch's uberjar and builds the base ref's
embedding-sdk.js from source, compares their sizes,
and sets output if the size change exceeds the threshold.
Measures app + embedding SDK bundle sizes from the current and base-ref
uberjars (reusing the builds that already ran) plus their bundle-stats
artifacts, and flags changes to the chunked SDK's reachable, gzipped size
beyond the threshold. Skips when the base-ref artifacts aren't available
rather than rebuilding from source (which would compare across pipelines).
inputs:
edition:
description: 'Metabase edition (ee or oss)'
required: true
base-ref-commit:
description: 'Commit SHA of the base ref (e.g. merge base).'
description: 'Commit SHA of the base ref.'
required: true
threshold-percent:
description: 'Percent threshold for bundle size change'
@@ -26,51 +28,73 @@ outputs:
runs:
using: "composite"
steps:
- name: Prepare backend
uses: ./.github/actions/prepare-backend
- name: Prepare frontend
uses: ./.github/actions/prepare-frontend
- name: Download current uberjar
uses: ./.github/actions/fetch-artifact
with:
commit: ${{ github.event.pull_request.head.sha || github.sha }}
edition: ${{ inputs.edition }}
extract-path: temp/current-uberjar
- name: Extract embedding-sdk bundles from current uberjar
shell: bash
run: |
# Extract preserving the jar's internal paths under resources/ so the
# shared measure script sees the same layout as a source build. Both the
# new (embedding-sdk/legacy + chunks) and old (embedding-sdk.js) layouts
# are pulled; whichever exists is what gets measured.
mkdir -p temp/current/resources
unzip -o temp/current-uberjar/metabase.jar \
"frontend_client/app/embedding-sdk/*" \
-d temp/current/resources 2>/dev/null || true
unzip -o temp/current-uberjar/metabase.jar \
"frontend_client/app/embedding-sdk.js" \
-d temp/current/resources 2>/dev/null || true
- name: Checkout base ref
uses: actions/checkout@v6
- name: Download base-ref uberjar
id: base-jar
continue-on-error: true
uses: ./.github/actions/fetch-artifact
with:
ref: ${{ inputs.base-ref-commit }}
path: temp/base-ref-src
- name: Build base-ref embedding-sdk.js
shell: bash
run: |
cd temp/base-ref-src
bun install
MB_EDITION=${{ inputs.edition }} bun run build-release
- name: Measure current and base bundle sizes
shell: bash
env:
MEASURE_BUNDLES: embedding-sdk-legacy,embedding-sdk-chunked
run: |
MEASURE_ROOT=temp/current node ./.github/scripts/measure-bundle-sizes.js > temp/current-sizes.json
MEASURE_ROOT=temp/base-ref-src node ./.github/scripts/measure-bundle-sizes.js > temp/base-sizes.json
- name: Compare sizes and set output
commit: ${{ inputs.base-ref-commit }}
edition: ${{ inputs.edition }}
extract-path: temp/base-uberjar
- name: Measure and compare bundle sizes
id: compare
shell: bash
env:
GH_TOKEN: ${{ github.token }}
EDITION: ${{ inputs.edition }}
HEAD_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
BASE_SHA: ${{ inputs.base-ref-commit }}
THRESHOLD: ${{ inputs.threshold-percent }}
run: node ./.github/actions/sdk-bundle-size-check/compare.js temp/current-sizes.json temp/base-sizes.json
MEASURE_BUNDLES: app,embedding-sdk-legacy,embedding-sdk-chunked
run: |
set -uo pipefail
skip() {
echo "::notice::Embedding SDK bundle-size check skipped: $1"
echo "status=stable" >> "$GITHUB_OUTPUT"
echo "size_change_percent=0" >> "$GITHUB_OUTPUT"
exit 0
}
# The base ref needs an already-built uberjar. Rebuilding it from source
# would compare across two build pipelines (the bug this check used to
# have), so skip instead when it — or its stats — isn't available.
[ -f temp/base-uberjar/metabase.jar ] || skip "base-ref uberjar not found for ${BASE_SHA}"
extract_js() { # $1=jar $2=dest-root
mkdir -p "$2/resources"
unzip -o "$1" \
"frontend_client/app/dist/*" \
"frontend_client/app/embed.js" \
"frontend_client/app/embedding-sdk/*" \
-d "$2/resources" >/dev/null || true
}
fetch_stats() { # $1=sha $2=dest-dir
local name="metabase-bundle-stats-${EDITION}-$1"
local id
id=$(gh api "/repos/${GITHUB_REPOSITORY}/actions/artifacts?name=${name}" --jq '.artifacts[0].id // empty' 2>/dev/null)
[ -n "${id}" ] || return 1
mkdir -p "$2"
gh api "/repos/${GITHUB_REPOSITORY}/actions/artifacts/${id}/zip" > "$2.zip" 2>/dev/null || return 1
unzip -o "$2.zip" -d "$2" >/dev/null || return 1
}
extract_js temp/current-uberjar/metabase.jar temp/current
extract_js temp/base-uberjar/metabase.jar temp/base
fetch_stats "${HEAD_SHA}" temp/current/artifacts || skip "bundle stats not found for current ${HEAD_SHA}"
fetch_stats "${BASE_SHA}" temp/base/artifacts || skip "bundle stats not found for base ${BASE_SHA}"
MEASURE_ROOT=temp/current node ./.github/scripts/measure-bundle-sizes.js > temp/current-sizes.json \
|| { echo "::error::Failed to measure current bundle sizes"; exit 1; }
MEASURE_ROOT=temp/base node ./.github/scripts/measure-bundle-sizes.js > temp/base-sizes.json \
|| { echo "::error::Failed to measure base bundle sizes"; exit 1; }
node ./.github/actions/sdk-bundle-size-check/compare.js temp/current-sizes.json temp/base-sizes.json

View File

@@ -1,16 +1,72 @@
/* eslint-disable import/no-commonjs */
// Diffs the embedding SDK bundle sizes produced by measure-bundle-sizes.js for
// the current build and the base ref. The gate is driven by the legacy
// (monolithic) bundle's raw bytes; the chunked delivery is reported for context.
// Diffs the bundle sizes produced by measure-bundle-sizes.js for the current
// build and the base ref. Every (bundle, kind) is compared strictly against the
// same (bundle, kind) — never one bundle type against another — using gzipped
// (served) bytes. The gate is driven by the chunked SDK's reachable total, which
// is what the SDK actually delivers.
//
// compareBundles is pure (data in, data out) so it can be unit-tested; main()
// is the thin I/O wrapper that reads the size files, prints the report and sets
// the step outputs / exit code.
const fs = require("fs");
const [, , currentPath, basePath] = process.argv;
const threshold = Number(process.env.THRESHOLD ?? 2);
const current = JSON.parse(fs.readFileSync(currentPath, "utf8"));
const base = JSON.parse(fs.readFileSync(basePath, "utf8"));
const pick = (rows, bundle, kind) => rows.find(row => row.bundle === bundle && row.kind === kind);
const keyOf = row => `${row.bundle}/${row.kind}`;
const mb = bytes => (bytes / 1024 / 1024).toFixed(2);
const percentOf = (currentBytes, baseBytes) =>
baseBytes ? Math.trunc(((currentBytes - baseBytes) * 100) / baseBytes) : 0;
/**
* Compare two measurement sets and decide the gate. Returns a human-readable
* `report` (always), and exactly one of:
* - `gate` { status, percent }: the chunked SDK total moved by `percent`.
* - `skip` reason: the gate is non-actionable (report stable, no comment).
* - `error` reason: the gate inputs are missing (hard failure).
*/
function compareBundles({ current, base, threshold }) {
const report = ["=== Bundle sizes (gzipped, current vs base) ==="];
const keys = [...new Set([...current, ...base].map(keyOf))].sort();
for (const key of keys) {
const [bundle, kind] = key.split("/");
const currentRow = pick(current, bundle, kind);
const baseRow = pick(base, bundle, kind);
if (!currentRow || !baseRow) {
report.push(`${key}: present only in ${currentRow ? "current" : "base"} build`);
continue;
}
const diff = currentRow.gzipBytes - baseRow.gzipBytes;
const percent = percentOf(currentRow.gzipBytes, baseRow.gzipBytes);
report.push(`${key}: ${mb(currentRow.gzipBytes)}MB vs ${mb(baseRow.gzipBytes)}MB (${percent}%, ${diff} bytes)`);
}
// Gate on the chunked SDK's reachable total (gzipped) — what the SDK ships.
const gateCurrent = pick(current, "embedding-sdk-chunked", "total");
const gateBase = pick(base, "embedding-sdk-chunked", "total");
if (!gateCurrent || !gateBase || !gateBase.gzipBytes) {
return { report, error: "Could not find embedding-sdk-chunked total (gzip) in both builds" };
}
// Both sides must measure "total" the same way. A base ref built before the
// reachableAssets enrichment collapses its total to the initial set, so
// comparing it against the current reachable total reports a phantom jump
// (~30%). Skip until the base ref also carries reachable stats (i.e. once
// this change is on the base).
if (Boolean(gateCurrent.reachable) !== Boolean(gateBase.reachable)) {
return {
report,
skip:
`chunked "total" measured differently on each side ` +
`(current reachable=${Boolean(gateCurrent.reachable)}, base reachable=${Boolean(gateBase.reachable)}); ` +
`the base ref predates the reachable-chunk stats. Resolves once this change is on the base ref.`,
};
}
const percent = percentOf(gateCurrent.gzipBytes, gateBase.gzipBytes);
const status = percent > threshold ? "increased" : percent < -threshold ? "decreased" : "stable";
return { report, gate: { status, percent } };
}
module.exports = { compareBundles };
const setOutput = (name, value) => {
if (process.env.GITHUB_OUTPUT) {
@@ -18,37 +74,37 @@ const setOutput = (name, value) => {
}
};
const mb = bytes => (bytes / 1024 / 1024).toFixed(2);
function main() {
const [, , currentPath, basePath] = process.argv;
const threshold = Number(process.env.THRESHOLD ?? 2);
const legacyCurrent = pick(current, "embedding-sdk-legacy", "total");
const legacyBase = pick(base, "embedding-sdk-legacy", "total");
const current = JSON.parse(fs.readFileSync(currentPath, "utf8"));
const base = JSON.parse(fs.readFileSync(basePath, "utf8"));
if (!legacyCurrent || !legacyBase || !legacyBase.rawBytes) {
console.error("::error::Could not find embedding-sdk-legacy size in both builds");
process.exit(1);
}
const { report, gate, skip, error } = compareBundles({ current, base, threshold });
console.log(report.join("\n"));
const diff = legacyCurrent.rawBytes - legacyBase.rawBytes;
const percent = Math.trunc((diff * 100) / legacyBase.rawBytes);
if (error) {
console.error(`::error::${error}`);
process.exit(1);
}
const status = percent > threshold ? "increased" : percent < -threshold ? "decreased" : "stable";
if (skip) {
// Treat the gate as non-actionable: report stable so no regression comment
// is posted, mirroring the shell skip() for missing artifacts.
console.log(`::notice::Embedding SDK bundle-size gate skipped: ${skip}`);
setOutput("status", "stable");
setOutput("size_change_percent", "0");
process.exit(0);
}
console.log("=== Embedding SDK legacy (monolithic) bundle ===");
console.log(`Current: ${legacyCurrent.rawBytes} bytes raw / ${mb(legacyCurrent.gzipBytes)}MB gzip`);
console.log(`Base ref: ${legacyBase.rawBytes} bytes raw / ${mb(legacyBase.gzipBytes)}MB gzip`);
console.log(`Difference: ${diff} bytes (${percent}%), threshold ${threshold}%`);
console.log(`Status: ${status}`);
const chunkedCurrent = pick(current, "embedding-sdk-chunked", "total");
const chunkedBase = pick(base, "embedding-sdk-chunked", "total");
if (chunkedCurrent && chunkedBase) {
const chunkedDiff = chunkedCurrent.rawBytes - chunkedBase.rawBytes;
console.log("");
console.log("=== Embedding SDK chunked (informational) ===");
console.log(`Current: ${chunkedCurrent.rawBytes} bytes raw / ${mb(chunkedCurrent.gzipBytes)}MB gzip`);
console.log(`Base ref: ${chunkedBase.rawBytes} bytes raw / ${mb(chunkedBase.gzipBytes)}MB gzip`);
console.log(`Difference: ${chunkedDiff} bytes`);
console.log(`Gate: embedding-sdk-chunked total ${gate.percent}% (threshold ${threshold}%) → ${gate.status}`);
setOutput("status", gate.status);
setOutput("size_change_percent", gate.percent);
}
setOutput("status", status);
setOutput("size_change_percent", percent);
if (require.main === module) {
main();
}

View File

@@ -0,0 +1,65 @@
const { compareBundles } = require("./compare");
const total = (gzipBytes, over = {}) => ({
bundle: "embedding-sdk-chunked",
kind: "total",
gzipBytes,
reachable: true,
...over,
});
describe("compareBundles", () => {
it("gates on the chunked SDK total and flags an increase past the threshold", () => {
const { gate, report } = compareBundles({
current: [total(110)],
base: [total(100)],
threshold: 2,
});
expect(gate).toEqual({ status: "increased", percent: 10 });
expect(report[0]).toContain("current vs base");
});
it("flags a decrease and stays stable within the threshold", () => {
expect(compareBundles({ current: [total(90)], base: [total(100)], threshold: 2 }).gate).toEqual({
status: "decreased",
percent: -10,
});
expect(compareBundles({ current: [total(101)], base: [total(100)], threshold: 2 }).gate).toEqual({
status: "stable",
percent: 1,
});
});
it("skips when the two sides measured total differently (reachable mismatch)", () => {
const result = compareBundles({
current: [total(130, { reachable: true })],
base: [total(100, { reachable: false })],
threshold: 2,
});
expect(result.gate).toBeUndefined();
expect(result.skip).toContain("predates the reachable-chunk stats");
});
it("errors when the gate bundle is missing on either side", () => {
const result = compareBundles({
current: [{ bundle: "app", kind: "total", gzipBytes: 1 }],
base: [total(100)],
threshold: 2,
});
expect(result.gate).toBeUndefined();
expect(result.error).toContain("embedding-sdk-chunked total");
});
it("reports a bundle/kind present on only one side without erroring", () => {
const { report } = compareBundles({
current: [total(100), { bundle: "app", kind: "total", gzipBytes: 50 }],
base: [total(100)],
threshold: 2,
});
expect(report.some(line => line.includes("present only in current build"))).toBe(true);
});
});

View File

@@ -14,8 +14,15 @@ inputs:
description: Suffix to append to the test logs artifact name to avoid conflicts in matrix jobs
edition:
required: false
default: 'ee'
default: "ee"
description: Edition to test (oss or ee)
quarantine-engine:
required: false
driver-status:
required: false
default: ""
description: >-
Configured status for this driver ("info", "skip", "required", or empty), as reported by `mage driver-decisions`.
outputs:
test-outcome:
@@ -39,28 +46,25 @@ runs:
run: bun run build-static-viz
shell: bash
env:
MB_EDITION: ee
MB_EDITION: ${{ inputs.edition }}
- name: Test database driver
run: clojure -X:dev:ci:${{ inputs.edition }}:${{ inputs.edition }}-dev:drivers:drivers-dev:test ${{ inputs.test-args }}
shell: bash
id: run-test
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
# Driver "info" status can affect this logic. See below.
continue-on-error: true
- name: Report failed tests to ci-conductor
# Positioned right after the test run (before the report/upload steps) so it
# reads pristine JUnit. Gated to non-clean runs + continue-on-error so it can
# never change the job outcome — Trunk Quarantine remains the sole arbiter.
# junit-name is the per-job identity label (e.g. be-tests-postgres-ee); only
# workflows that also set CI_CONDUCTOR_BASE_URL actually POST. See DEV-2224 /
# DEV-2235.
if: ${{ always() && steps.run-test.outcome != 'success' }}
if: ${{ !cancelled() && steps.run-test.outcome == 'failure' }}
# This step should NEVER fail the job!
continue-on-error: true
uses: ./.github/actions/report-failures-to-ci-conductor
with:
test-suite: ${{ inputs.junit-name }}
adapter: backend
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 # v3.0.0
# As per the documentation: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#steps-context
@@ -74,6 +78,7 @@ runs:
list-suites: failed
list-tests: failed
fail-on-error: false
- name: Upload Logs on Failure
if: always() && steps.run-test.outcome != 'success'
uses: actions/upload-artifact@v7
@@ -83,3 +88,20 @@ runs:
retention-days: 1
# Failing to upload the artifact should never affect the outcome of the whole test run.
continue-on-error: true
# Last, because this is the only step allowed to fail the job: everything above it reports the
# failure (JUnit report, logs, ci-conductor) and must run regardless of the verdict below.
- name: Quarantine gate
# Off master and release branches an "info" driver is data-collection only - the test always passes!
# On master and release branches "info" carries no weight - the quarantine logic applies.
if: |
!cancelled()
&& steps.run-test.outcome == 'failure'
&& !(inputs.driver-status == 'info'
&& !(github.ref_name == 'master' || startsWith(github.ref_name, 'release-x')))
continue-on-error: ${{ inputs.quarantine-engine != 'ci-conductor' }}
uses: ./.github/actions/quarantine-gate
with:
adapter: backend
test-suite: ${{ inputs.junit-name }}
enforce-quarantine: ${{ inputs.quarantine-engine == 'ci-conductor' }}

View File

@@ -34,6 +34,10 @@ inputs:
description: >-
Optional label disambiguating matrix legs of the same job, so the info-driver
job summary and PR comment stay distinct per leg.
run-trunk:
required: false
default: "true"
description: Whether to run the Trunk step at all.
runs:
using: "composite"
@@ -60,13 +64,11 @@ runs:
aws s3 cp ${OUTPUT_FILE}.zip s3://$BUCKET/$DATE/$GITHUB_RUN_ID/$GITHUB_RUN_ATTEMPT/
- name: Upload results to Trunk
if: ${{ always() && github.repository_owner == 'metabase' && inputs.run-trunk == 'true' }}
# Important!
# 1. This step must always run because it controls job's exit code.
# 2. There's no point in running this outside the organization
# 3. For "info" drivers off master/release branches, our own status takes precedence: we let this
# step pass so the job is reported as passing regardless of the real outcome (still uploaded).
# On master and release branches, info status is ignored and the real outcome gates the job.
if: always() && github.repository_owner == 'metabase'
# For "info" drivers off master/release branches, our own status takes precedence: we let this
# step pass so the job is reported as passing regardless of the real outcome (still uploaded).
# On master and release branches, info status is ignored and the real outcome gates the job.
continue-on-error: ${{ inputs.driver-status == 'info' && !(github.ref_name == 'master' || startsWith(github.ref_name, 'release-x')) }}
uses: trunk-io/analytics-uploader@1198efcc0976501147b10a7e343c3fa069527526 # v2.0.9
env:

View File

@@ -7,6 +7,10 @@ default: &default
- "locales/**"
- "bin/**/!(*.md)"
actionlint:
- ".github/workflows/*.yml"
- ".github/workflows/*.yaml"
shared_sources: &shared_sources
- "src/**/*.cljc"
- "src/**/*.cljs"
@@ -95,6 +99,12 @@ frontend_loki_infra: &frontend_loki_infra
- *shared_ci
- *frontend_loki_ci
# e2e harness/support code (commands, support file, runner). Not in the
# instrumented bundle, so it maps to no covered module — a change here forces a
# full e2e run (see create-test-plan / e2eInfraTouched).
e2e_infra: &e2e_infra
- *shared_e2e
backend_ci: &backend_ci
- *shared_ci
- ".github/actions/test-driver/**"

View File

@@ -1,3 +1,5 @@
import micromatch from "micromatch";
export type ModuleDef = { type: string; pattern: string };
export type Rule = { from: string[]; allow: string[] };
@@ -5,21 +7,12 @@ export type ModuleNode = { type: string; regex: RegExp };
export type FileDependency = { source: string; dependencies: string[] };
/**
* Compiles a glob pattern to an anchored RegExp.
*/
function globToRegex(glob: string): RegExp {
const escapeSegment = (seg: string) =>
seg.replace(/[.+?^${}()|[\]\\]/g, "\\$&").replace(/\*/g, "[^/]*");
const body = glob.split("**").map(escapeSegment).join(".*");
return new RegExp(`^${body}$`);
}
/** First match wins, so element order matters for nested patterns. */
export function buildNodes(elements: ModuleDef[]): ModuleNode[] {
return elements.map((el) => ({
type: el.type,
regex: globToRegex(el.pattern),
// dot:true so files in dot-directories (e.g. .storybook) still match.
regex: micromatch.makeRe(el.pattern, { dot: true }),
}));
}

View File

@@ -1,5 +1,7 @@
// Builds the affected-tests plan from raw inputs: computes the rules and usage
// affected-module sets and selects, per suite, which specs to run under each.
import { getFeatureModules } from "../../frontend/lint/module-boundaries.mjs";
import {
type FileDependency,
type ModuleDef,
@@ -14,7 +16,13 @@ import {
export type TestPlanStats = {
fe_files_changed: number;
fe_files_total: number;
be_files_changed: number;
be_files_total: number;
unit_infra_touched: boolean;
loki_infra_touched: boolean;
shared_sources_touched: boolean;
fe_modules_total: number;
fe_modules_changed: number;
fe_modules_affected_rules: number;
fe_modules_affected_usage: number;
@@ -43,11 +51,15 @@ export type CreateTestPlanInput = {
// Parsed dependency-cruiser edges, or null to fall back to the rules graph.
fileDependencies: FileDependency[] | null;
testFilesBySuite: { unit: string[]; loki: string[]; e2e: string[] };
e2eSpecFiles: Record<string, string[]> | null;
unitInfraTouched: boolean;
lokiInfraTouched: boolean;
e2eInfraTouched: boolean;
sharedSourcesTouched: boolean;
feFilesChanged: number;
beFilesChanged: number;
feFilesTotal: number;
beFilesTotal: number;
};
// Tests whose owning module is affected.
@@ -62,17 +74,73 @@ export function filterAffectedTests(
});
}
// Collapse each spec's covered files to the *feature* modules it exercises,
// once, for reuse across the rules/usage selects. Non-feature tiers
// (shared/lib/...) are intentionally dropped: the manifest is a stale nightly
// artifact, so its coupling to the module graph stays minimal ("does this spec
// touch feature X?"). Accuracy comes from the fresh `affected` set, which
// already expands a shared/infra change into the feature modules that depend on
// it.
export function specFeatureModules(
nodes: ModuleNode[],
featureModules: Set<string>,
specFiles: Record<string, string[]>,
): Map<string, Set<string>> {
const moduleCache = new Map<string, string | null>();
const moduleOf = (file: string): string | null => {
let module = moduleCache.get(file);
if (module === undefined) {
module = mapFileToModule(nodes, file);
moduleCache.set(file, module);
}
return module;
};
const result = new Map<string, Set<string>>();
for (const [spec, files] of Object.entries(specFiles)) {
const features = new Set<string>();
for (const file of files) {
const module = moduleOf(file);
if (module !== null && featureModules.has(module)) {
features.add(module);
}
}
result.set(spec, features);
}
return result;
}
// A spec runs if any feature module it covers is affected.
// A spec doesn't map to any feature module always runs because its scope is unknown
export function filterAffectedE2eSpecs(
specFeatures: Map<string, Set<string>>,
affected: Set<string>,
e2eSpecs: string[],
): string[] {
return e2eSpecs.filter((spec) => {
const features = specFeatures.get(spec);
if (!features || features.size === 0) {
return true;
}
return [...features].some((module) => affected.has(module));
});
}
export function createTestPlan({
elements,
rules,
changedFiles,
fileDependencies,
testFilesBySuite,
e2eSpecFiles,
unitInfraTouched,
lokiInfraTouched,
e2eInfraTouched,
sharedSourcesTouched,
feFilesChanged,
beFilesChanged,
feFilesTotal,
beFilesTotal,
}: CreateTestPlanInput): TestPlan {
const rulesGraph = buildModuleGraph(elements, rules);
const usageGraph = fileDependencies
@@ -80,14 +148,29 @@ export function createTestPlan({
: rulesGraph;
const nodes = rulesGraph.nodes;
// Distinct module types (an element type can span several patterns).
const totalModules = new Set(elements.map((el) => el.type)).size;
const changedModules = getChangedModules(nodes, changedFiles);
const rulesAffected = getAffectedModules(rulesGraph, changedFiles);
const usageAffected = getAffectedModules(usageGraph, changedFiles);
// The coarse "feature" tier is the only set the e2e manifest is ever
// collapsed to (see filterAffectedE2eSpecs).
const featureModules = new Set(getFeatureModules(elements));
// cljc/cljs compile into the FE bundle, so they force a full run that module
// selection can't narrow — same effect as a suite's own infra changing.
const unitForceAll = unitInfraTouched || sharedSourcesTouched;
const lokiForceAll = lokiInfraTouched || sharedSourcesTouched;
// e2e is integration-level, so anything the FE-coverage manifest can't see
// forces a full run: cljc/cljs in the bundle (sharedSourcesTouched), a backend
// change that can break the UI (beFilesChanged), an e2e harness/support change
// (e2eInfraTouched), or no manifest at all.
const e2eForceAll =
sharedSourcesTouched ||
e2eInfraTouched ||
beFilesChanged > 0 ||
e2eSpecFiles === null;
const select = (forceAll: boolean, affected: Set<string>, files: string[]) =>
forceAll ? files : filterAffectedTests(nodes, affected, files);
@@ -97,14 +180,36 @@ export function createTestPlan({
const unitUsage = select(unitForceAll, usageAffected, unit);
const lokiRules = select(lokiForceAll, rulesAffected, loki);
const lokiUsage = select(lokiForceAll, usageAffected, loki);
// No e2e-spec -> module mapping exists yet, so e2e always runs in full.
const e2eRules = e2e;
const e2eUsage = e2e;
// Precompute spec -> feature modules once (null when e2e runs in full).
const specFeatures =
e2eForceAll || e2eSpecFiles === null
? null
: specFeatureModules(nodes, featureModules, e2eSpecFiles);
// A spec that was itself edited always runs, even when no app module changed.
const changedSet = new Set(changedFiles);
const selectE2e = (affected: Set<string>): string[] => {
if (specFeatures === null) {
return e2e;
}
const narrowed = new Set(
filterAffectedE2eSpecs(specFeatures, affected, e2e),
);
return e2e.filter((spec) => narrowed.has(spec) || changedSet.has(spec));
};
const e2eRules = selectE2e(rulesAffected);
const e2eUsage = selectE2e(usageAffected);
return {
stats: {
fe_files_changed: feFilesChanged,
fe_files_total: feFilesTotal,
be_files_changed: beFilesChanged,
be_files_total: beFilesTotal,
unit_infra_touched: unitInfraTouched,
loki_infra_touched: lokiInfraTouched,
shared_sources_touched: sharedSourcesTouched,
fe_modules_total: totalModules,
fe_modules_changed: changedModules.size,
fe_modules_affected_rules: rulesAffected.size,
fe_modules_affected_usage: usageAffected.size,

View File

@@ -28,11 +28,15 @@ const baseInput = {
rules: RULES,
fileDependencies: null,
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e: E2E_FILES },
e2eSpecFiles: null,
unitInfraTouched: false,
lokiInfraTouched: false,
e2eInfraTouched: false,
sharedSourcesTouched: false,
feFilesChanged: 0,
beFilesChanged: 0,
feFilesTotal: 0,
beFilesTotal: 0,
};
describe("createTestPlan", () => {
@@ -93,7 +97,7 @@ describe("createTestPlan", () => {
expect(plan.stats.loki_stories_to_run_rules).toBe(0);
});
it("always runs the full e2e suite", () => {
it("runs the full e2e suite when no coverage manifest is available", () => {
const plan = createTestPlan({ ...baseInput, changedFiles: ["src/foo/x.ts"] });
expect(plan.stats.e2e_specs_to_run_rules).toBe(E2E_FILES.length);
@@ -101,6 +105,119 @@ describe("createTestPlan", () => {
expect(plan.e2e_specs_to_run).toEqual(E2E_FILES);
});
it("narrows e2e to specs covering affected feature modules", () => {
const e2e = [
"e2e/test/scenarios/foo.cy.spec.ts",
"e2e/test/scenarios/bar.cy.spec.ts",
"e2e/test/scenarios/new.cy.spec.ts",
];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/foo/x.ts"], // affects feature/foo only
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: {
"e2e/test/scenarios/foo.cy.spec.ts": ["src/foo/a.ts"], // feature/foo
"e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"], // feature/bar
// new.cy.spec.ts intentionally absent from the manifest
},
});
// foo's feature module is affected; bar's is not; the unmapped new spec
// always runs.
expect(plan.e2e_specs_to_run.sort()).toEqual([
"e2e/test/scenarios/foo.cy.spec.ts",
"e2e/test/scenarios/new.cy.spec.ts",
]);
expect(plan.stats.e2e_specs_all).toBe(3);
});
it("runs a spec that maps to no feature module (unknown scope)", () => {
const e2e = ["e2e/test/scenarios/lib-only.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/foo/x.ts"], // affects feature/foo, NOT lib/utils
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: {
// Covers only a non-feature module (e.g. a home/auth spec whose feature
// the baseline subtracted), so its feature scope is unknown.
"e2e/test/scenarios/lib-only.cy.spec.ts": ["src/utils/colors.ts"],
},
});
// No feature module to gate on -> can't bound scope -> always runs.
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("force-runs all e2e on a backend change (invisible to FE coverage)", () => {
const e2e = ["e2e/test/scenarios/foo.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/metabase/api/card.clj"],
beFilesChanged: 1,
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: { "e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"] },
});
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("force-runs all e2e when e2e infra (support/runner) changes", () => {
const e2e = ["e2e/test/scenarios/foo.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["e2e/support/commands/api/createQuestion.js"],
e2eInfraTouched: true,
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: { "e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"] },
});
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("runs an edited spec even when no app module changed", () => {
const spec = "e2e/test/scenarios/foo.cy.spec.ts";
const e2e = [spec, "e2e/test/scenarios/bar.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: [spec], // only the spec itself changed
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: {
[spec]: ["src/bar/b.ts"], // covers feature/bar, which is NOT affected
"e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"],
},
});
// No module is affected, but the edited spec must still run.
expect(plan.e2e_specs_to_run).toEqual([spec]);
});
it("runs a spec whose coverage was fully baseline-subtracted (empty files)", () => {
const e2e = ["e2e/test/scenarios/empty.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/foo/x.ts"], // affects feature/foo
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: { "e2e/test/scenarios/empty.cy.spec.ts": [] },
});
// Empty coverage means unknown scope, so the spec runs.
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("forces a full e2e run when shared (cljc) sources change", () => {
const e2e = ["e2e/test/scenarios/foo.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/foo/x.ts"],
sharedSourcesTouched: true,
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: { "e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"] },
});
// Manifest is present but cljc is invisible to JS coverage, so run all.
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("passes the FE/BE file counts through to stats", () => {
const plan = createTestPlan({
...baseInput,

View File

@@ -0,0 +1,152 @@
/* eslint-disable import/no-commonjs */
// Prepares the rows the bundle-size stats logger uploads to stats.metabase.com.
//
// For each measured (bundle, kind) it computes the delta — raw, gzipped and
// brotli (as-served) bytes plus percent — against the previously *plotted* data
// point (restored from a rolling cache), so the deltas can be charted directly.
// It also decides whether this commit is worth recording at all: a point is kept
// when the as-served size moved by at least MIN_DELTA_PERCENT, or when a new
// bundle/kind appears. Only master builds run through here — releases form
// non-linear lines whose deltas are meaningless, so they're not recorded (their
// historical sizes are backfilled separately).
//
// buildStatsRows is pure (data in, data out) so it can be unit-tested; main()
// is the thin I/O wrapper that reads env/files and writes the rows, cache and
// step outputs.
const fs = require("fs");
const path = require("path");
const deltaPercent = (current, base) =>
base ? Math.round(((current - base) * 10000) / base) / 100 : "";
/**
* Turn the current measurements + the last plotted point into upload rows, the
* slim cache rows for the next diff, and the keep/skip decision.
*
* The significance threshold tracks the as-served size: brotli where the build
* ships a precompressed .br, otherwise gzip. Current measurements always carry
* brotliBytes (estimated when no .br shipped), but a cached base point recorded
* before brotli logging may not, so the delta still falls back to gzip per row.
*/
function buildStatsRows({ measurements, previous, threshold, date, commit, commitMessage, version }) {
const previousOf = (bundle, kind) => previous.find(row => row.bundle === bundle && row.kind === kind);
let maxServedDeltaPercent = 0;
let hasNewSeries = false;
const rows = measurements.map(measurement => {
const base = previousOf(measurement.bundle, measurement.kind);
const hasBrotli = measurement.brotliBytes != null && base?.brotliBytes != null;
const gzipDeltaPercent = deltaPercent(measurement.gzipBytes, base?.gzipBytes);
const brotliDeltaPercent = hasBrotli ? deltaPercent(measurement.brotliBytes, base.brotliBytes) : "";
if (!base) {
hasNewSeries = true;
} else {
const servedDeltaPercent = hasBrotli ? brotliDeltaPercent : gzipDeltaPercent;
maxServedDeltaPercent = Math.max(maxServedDeltaPercent, Math.abs(servedDeltaPercent));
}
return {
"Date": date,
"Version": version,
"Commit": commit,
"Bundle": measurement.bundle,
"Kind": measurement.kind, // "initial" or "total"
// The stats table carries a free-text Description column; append-csv
// requires every table column to be present. Populate it with the commit
// subject so the chart's points are self-describing.
"Description": commitMessage,
"Raw bytes": measurement.rawBytes,
"Gzip bytes": measurement.gzipBytes,
"Brotli bytes": measurement.brotliBytes, // as-served (shipped .br, else estimated)
"File count": measurement.fileCount,
"Raw bytes delta": base ? measurement.rawBytes - base.rawBytes : "",
"Gzip bytes delta": base ? measurement.gzipBytes - base.gzipBytes : "",
"Brotli bytes delta": hasBrotli ? measurement.brotliBytes - base.brotliBytes : "",
"Raw delta %": deltaPercent(measurement.rawBytes, base?.rawBytes),
"Gzip delta %": gzipDeltaPercent,
"Brotli delta %": brotliDeltaPercent,
};
});
const firstPoint = previous.length === 0;
const significant = firstPoint || hasNewSeries || maxServedDeltaPercent >= threshold;
// Slim rows the next run diffs against. The workflow only persists this to the
// cache when we actually push, so the cached reference always stays the last
// *plotted* point (cumulative drift is caught).
const cacheRows = measurements.map(({ bundle, kind, rawBytes, gzipBytes, brotliBytes }) => ({
bundle,
kind,
rawBytes,
gzipBytes,
brotliBytes,
}));
const reason = firstPoint
? "first point"
: hasNewSeries
? "new bundle/kind series"
: `max served Δ ${maxServedDeltaPercent.toFixed(2)}% (threshold ${threshold}%)`;
return { rows, cacheRows, significant, reason, maxServedDeltaPercent, firstPoint, hasNewSeries };
}
module.exports = { buildStatsRows };
const readJson = filePath => (filePath && fs.existsSync(filePath) ? JSON.parse(fs.readFileSync(filePath, "utf8")) : null);
const writeJson = (filePath, value) => {
fs.mkdirSync(path.dirname(filePath), { recursive: true });
fs.writeFileSync(filePath, JSON.stringify(value));
};
const setOutput = (env, name, value) => {
if (env.GITHUB_OUTPUT) {
fs.appendFileSync(env.GITHUB_OUTPUT, `${name}=${value}\n`);
}
};
// version.properties (extracted from the uberjar) carries the build's tag.
// Non-release (master) builds report tag=vUNKNOWN, so leave Version empty there.
function readVersion(versionPropsPath) {
const raw =
versionPropsPath && fs.existsSync(versionPropsPath)
? (fs.readFileSync(versionPropsPath, "utf8").match(/^tag=(.*)$/m)?.[1]?.trim() ?? "")
: "";
return raw === "vUNKNOWN" ? "" : raw;
}
function main() {
const env = process.env;
const measurements = readJson(env.CURRENT);
if (!Array.isArray(measurements) || measurements.length === 0) {
console.error(`::error::No bundle measurements found at ${env.CURRENT}`);
process.exit(1);
}
const result = buildStatsRows({
measurements,
// The last plotted point, as slim rows: [{ bundle, kind, rawBytes, gzipBytes, brotliBytes }].
previous: readJson(env.LAST) || [],
threshold: Number(env.MIN_DELTA_PERCENT ?? 1),
date: new Date().toISOString().slice(0, 10), // YYYY-MM-DD
commit: (env.HEAD_SHA || "").slice(0, 12),
commitMessage: (env.COMMIT_MESSAGE || "").split("\n")[0], // subject line only
version: readVersion(env.VERSION_PROPS),
});
writeJson(env.ROWS_OUT, result.rows);
writeJson(env.CACHE_OUT, result.cacheRows);
console.log(`${result.significant ? "RECORD" : "SKIP"} — ${result.reason}`);
setOutput(env, "significant", result.significant ? "true" : "false");
setOutput(
env,
"max_delta_percent",
result.firstPoint || result.hasNewSeries ? "" : result.maxServedDeltaPercent.toFixed(2),
);
}
if (require.main === module) {
main();
}

View File

@@ -0,0 +1,87 @@
const { buildStatsRows } = require("./bundle-size-stats-prepare");
const meta = { date: "2026-06-30", commit: "abc123", commitMessage: "Fix the thing (#123)", version: "" };
const measurement = (over = {}) => ({
bundle: "embedding-sdk-chunked",
kind: "total",
rawBytes: 1000,
gzipBytes: 400,
brotliBytes: 300,
fileCount: 3,
...over,
});
describe("buildStatsRows", () => {
it("records the first point and leaves every delta empty", () => {
const result = buildStatsRows({
...meta,
measurements: [measurement()],
previous: [],
threshold: 1,
});
expect(result.firstPoint).toBe(true);
expect(result.significant).toBe(true);
expect(result.reason).toBe("first point");
expect(result.rows[0]["Gzip bytes delta"]).toBe("");
expect(result.rows[0]["Brotli delta %"]).toBe("");
expect(result.rows[0]["Description"]).toBe("Fix the thing (#123)");
expect(result.cacheRows[0]).toEqual({
bundle: "embedding-sdk-chunked",
kind: "total",
rawBytes: 1000,
gzipBytes: 400,
brotliBytes: 300,
});
});
it("records a never-seen bundle/kind as a new series", () => {
const result = buildStatsRows({
...meta,
measurements: [measurement({ bundle: "app", kind: "initial" })],
previous: [{ bundle: "app", kind: "total", rawBytes: 1, gzipBytes: 1, brotliBytes: 1 }],
threshold: 99,
});
expect(result.hasNewSeries).toBe(true);
expect(result.significant).toBe(true);
expect(result.reason).toBe("new bundle/kind series");
});
it("gates significance on the brotli (as-served) delta when both sides have it", () => {
const previous = [{ bundle: "embedding-sdk-chunked", kind: "total", rawBytes: 1000, gzipBytes: 400, brotliBytes: 300 }];
const big = buildStatsRows({
...meta,
measurements: [measurement({ brotliBytes: 315, gzipBytes: 400 })], // brotli +5%, gzip 0%
previous,
threshold: 1,
});
expect(big.maxServedDeltaPercent).toBeCloseTo(5);
expect(big.significant).toBe(true);
expect(big.rows[0]["Brotli delta %"]).toBeCloseTo(5);
const small = buildStatsRows({
...meta,
measurements: [measurement({ brotliBytes: 301, gzipBytes: 999 })], // brotli +0.33%, gzip ignored
previous,
threshold: 1,
});
expect(small.significant).toBe(false);
expect(small.reason).toContain("threshold 1%");
});
it("falls back to the gzip delta when the cached base predates brotli logging", () => {
const result = buildStatsRows({
...meta,
measurements: [measurement({ gzipBytes: 440, brotliBytes: 300 })], // gzip +10%
previous: [{ bundle: "embedding-sdk-chunked", kind: "total", rawBytes: 1000, gzipBytes: 400 }],
threshold: 1,
});
expect(result.maxServedDeltaPercent).toBeCloseTo(10);
expect(result.significant).toBe(true);
expect(result.rows[0]["Brotli bytes delta"]).toBe(""); // no base brotli to diff against
expect(result.rows[0]["Gzip delta %"]).toBeCloseTo(10);
});
});

View File

@@ -4,45 +4,36 @@
import { execFileSync } from "node:child_process";
import { existsSync, readFileSync } from "node:fs";
import micromatch from "micromatch";
import { elements, rules } from "../../frontend/lint/module-boundaries.mjs";
import { type FileDependency, parseCruiseModules } from "./affected-modules";
import { createTestPlan } from "./affected-tests";
import { listSpecFiles } from "./e2e-spec-globs.mjs";
const UNIT_ROOTS = ["frontend/src", "enterprise/frontend/src"];
const UNIT_GLOBS = [
"frontend/src/**/*.unit.spec.js",
"frontend/src/**/*.unit.spec.jsx",
"frontend/src/**/*.unit.spec.ts",
"frontend/src/**/*.unit.spec.tsx",
"enterprise/frontend/src/**/*.unit.spec.js",
"enterprise/frontend/src/**/*.unit.spec.jsx",
"enterprise/frontend/src/**/*.unit.spec.ts",
"enterprise/frontend/src/**/*.unit.spec.tsx",
"frontend/src/**/*.unit.spec.{js,jsx,ts,tsx}",
"enterprise/frontend/src/**/*.unit.spec.{js,jsx,ts,tsx}",
];
const STORY_ROOTS = ["frontend", "enterprise/frontend"];
const STORY_GLOBS = [
"frontend/**/*.stories.js",
"frontend/**/*.stories.jsx",
"frontend/**/*.stories.ts",
"frontend/**/*.stories.tsx",
"enterprise/frontend/**/*.stories.js",
"enterprise/frontend/**/*.stories.jsx",
"enterprise/frontend/**/*.stories.ts",
"enterprise/frontend/**/*.stories.tsx",
"frontend/**/*.stories.{js,jsx,ts,tsx}",
"enterprise/frontend/**/*.stories.{js,jsx,ts,tsx}",
];
const E2E_GLOBS = [
"e2e/test/scenarios/**/*.cy.spec.js",
"e2e/test/scenarios/**/*.cy.spec.jsx",
"e2e/test/scenarios/**/*.cy.spec.ts",
"e2e/test/scenarios/**/*.cy.spec.tsx",
];
function listFiles(globs: string[]): string[] {
return execFileSync("git", ["ls-files", "--", ...globs], { encoding: "utf8" })
// Returns the tracked files under `roots` that match `globs`. The `dot: true`
// option means files inside dot-directories such as `.storybook` are included.
function listFiles(roots: string[], globs: string[]): string[] {
const tracked = execFileSync("git", ["ls-files", "--", ...roots], {
encoding: "utf8",
})
.split("\n")
.map((line) => line.trim())
.filter(Boolean);
return micromatch(tracked, globs, { dot: true });
}
// dorny outputs comma-separated lists; CHANGED_FILES is `all_changed_files`.
@@ -74,21 +65,48 @@ function readFileDependencies(): FileDependency[] | null {
return null;
}
// Reads the nightly coverage manifest (E2E_SPEC_MANIFEST): { builtAt, specs:
// { spec -> files } }. Returns the specs map, or null so e2e falls back to a
// full run when the manifest is missing/unparseable.
function readE2eSpecFiles(): Record<string, string[]> | null {
const path = process.env.E2E_SPEC_MANIFEST;
if (path && existsSync(path)) {
try {
const { specs } = JSON.parse(readFileSync(path, "utf8"));
if (specs && typeof specs === "object") {
process.stderr.write(`Using e2e coverage manifest from ${path}.\n`);
return specs;
}
} catch (error) {
process.stderr.write(
`Failed to read ${path}; e2e will run in full: ${error}\n`,
);
}
} else {
process.stderr.write("No E2E_SPEC_MANIFEST found; e2e will run in full.\n");
}
return null;
}
const testPlan = createTestPlan({
elements,
rules,
changedFiles: csvToList(process.env.CHANGED_FILES),
fileDependencies: readFileDependencies(),
testFilesBySuite: {
unit: listFiles(UNIT_GLOBS),
loki: listFiles(STORY_GLOBS),
e2e: listFiles(E2E_GLOBS),
unit: listFiles(UNIT_ROOTS, UNIT_GLOBS),
loki: listFiles(STORY_ROOTS, STORY_GLOBS),
e2e: listSpecFiles(),
},
e2eSpecFiles: readE2eSpecFiles(),
unitInfraTouched: process.env.UNIT_INFRA_TOUCHED === "true",
lokiInfraTouched: process.env.LOKI_INFRA_TOUCHED === "true",
e2eInfraTouched: process.env.E2E_INFRA_TOUCHED === "true",
sharedSourcesTouched: process.env.SHARED_SOURCES_TOUCHED === "true",
feFilesChanged: csvToList(process.env.FE_CHANGED_FILES).length,
beFilesChanged: csvToList(process.env.BE_CHANGED_FILES).length,
feFilesTotal: listFiles(["frontend", "enterprise/frontend"], ["**"]).length,
beFilesTotal: listFiles(["src", "enterprise/backend"], ["**"]).length,
});
process.stdout.write(JSON.stringify(testPlan) + "\n");

View File

@@ -19,23 +19,73 @@ function jsonToCsvFormData(jsonData) {
return formData;
}
async function uploadCsvToMb({ baseUrl, tableId, jsonData, mode = 'append' }) {
const formData = jsonToCsvFormData(jsonData);
const operation = mode === 'replace' ? 'replace-csv' : 'append-csv';
// Transient failures worth retrying: throttling and server-side errors. A 4xx
// (bad request, auth) won't succeed on retry, so those fail fast.
const RETRYABLE_STATUS = new Set([429, 500, 502, 503, 504]);
const response = await fetch(`${baseUrl}/api/table/${tableId}/${operation}`, {
method: 'POST',
headers: {
"x-api-key": process.env.API_KEY
},
body: formData
});
if (!response.ok) {
const body = await response.text().catch(() => '');
throw new Error(`Upload failed: ${response.status} ${response.statusText} ${body}`.trim());
class UploadError extends Error {
constructor(message, { retryable }) {
super(message);
this.retryable = retryable;
}
}
async function attemptUpload(url, jsonData, timeoutMs) {
let response;
try {
response = await fetch(url, {
method: 'POST',
headers: {
"x-api-key": process.env.API_KEY
},
// Rebuilt per attempt: a consumed request body can't be reused.
body: jsonToCsvFormData(jsonData),
// Without this the request can hang indefinitely on a stalled server,
// eating the whole job timeout. An abort surfaces below as a retryable
// network error, so it retries with backoff instead.
signal: AbortSignal.timeout(timeoutMs)
});
} catch (networkError) {
throw new UploadError(networkError.message, { retryable: true });
}
if (response.ok) {
return;
}
const body = await response.text().catch(() => '');
throw new UploadError(
`Upload failed: ${response.status} ${response.statusText} ${body}`.trim(),
{ retryable: RETRYABLE_STATUS.has(response.status) }
);
}
const sleep = ms => new Promise(resolve => setTimeout(resolve, ms));
/**
* Uploads jsonData as CSV, retrying transient API errors with exponential
* backoff. `retries` is the number of extra attempts after the first (so the
* default 2 means up to 3 tries). `timeoutMs` is a per-attempt total deadline
* (default 60s) that aborts a stalled request. Throws the last error once
* attempts are exhausted or the error is non-retryable.
*/
async function uploadCsvToMb({ baseUrl, tableId, jsonData, mode = 'append', retries = 2, retryDelayMs = 1000, timeoutMs = 60_000 }) {
const operation = mode === 'replace' ? 'replace-csv' : 'append-csv';
const url = `${baseUrl}/api/table/${tableId}/${operation}`;
for (let attempt = 0; ; attempt++) {
try {
await attemptUpload(url, jsonData, timeoutMs);
return { success: true };
} catch (error) {
if (!error.retryable || attempt >= retries) {
throw error;
}
const delay = retryDelayMs * 2 ** attempt;
console.warn(`Upload attempt ${attempt + 1} failed (${error.message}); retrying in ${delay}ms`);
await sleep(delay);
}
}
return { success: true };
}
module.exports = { uploadCsvToMb };

50
.github/scripts/csv-to-mb.unit.spec.js vendored Normal file
View File

@@ -0,0 +1,50 @@
const { uploadCsvToMb } = require("./csv-to-mb");
const ok = () => ({ ok: true });
const fail = status => ({ ok: false, status, statusText: "err", text: async () => "" });
const upload = (over = {}) =>
uploadCsvToMb({
baseUrl: "https://stats.example.com",
tableId: 1,
jsonData: [{ a: 1 }],
retryDelayMs: 1,
...over,
});
describe("uploadCsvToMb retries", () => {
afterEach(() => {
delete global.fetch;
});
it("retries transient server errors then succeeds", async () => {
global.fetch = jest.fn().mockResolvedValueOnce(fail(503)).mockResolvedValueOnce(fail(500)).mockResolvedValueOnce(ok());
await expect(upload({ retries: 2 })).resolves.toEqual({ success: true });
expect(global.fetch).toHaveBeenCalledTimes(3);
});
it("retries network errors", async () => {
global.fetch = jest
.fn()
.mockRejectedValueOnce(new Error("ECONNRESET"))
.mockResolvedValueOnce(ok());
await expect(upload({ retries: 2 })).resolves.toEqual({ success: true });
expect(global.fetch).toHaveBeenCalledTimes(2);
});
it("gives up after exhausting retries and throws the last error", async () => {
global.fetch = jest.fn().mockResolvedValue(fail(500));
await expect(upload({ retries: 2 })).rejects.toThrow("Upload failed: 500");
expect(global.fetch).toHaveBeenCalledTimes(3); // 1 initial + 2 retries
});
it("does not retry a non-transient 4xx", async () => {
global.fetch = jest.fn().mockResolvedValue(fail(400));
await expect(upload({ retries: 2 })).rejects.toThrow("Upload failed: 400");
expect(global.fetch).toHaveBeenCalledTimes(1);
});
});

32
.github/scripts/e2e-spec-globs.mjs vendored Normal file
View File

@@ -0,0 +1,32 @@
import { execFileSync } from "node:child_process";
import micromatch from "micromatch";
const SPEC_DIR = "e2e/test/scenarios";
// This is the nightly-only baseline helper that runs in the instrumented pass to
// capture boot-time coverage. It is not a product spec, so it is excluded from
// the test plan universe and from the manifest backfill reconciliation.
export const BASELINE_SPEC = `${SPEC_DIR}/coverage-baseline.cy.spec.js`;
// This glob set defines the spec "universe". The test planner
// (create-test-plan.ts) selects which specs to run from it, and the coverage
// manifest builder (build-coverage-manifest.mjs) reconciles against it when
// backfilling specs that did not run.
export const E2E_SPEC_GLOBS = [`${SPEC_DIR}/**/*.cy.spec.{js,jsx,ts,tsx}`];
// Returns the tracked e2e specs as repo-relative paths, excluding the baseline
// helper.
export function listSpecFiles(cwd = process.cwd()) {
const tracked = execFileSync("git", ["ls-files", "--", SPEC_DIR], {
cwd,
encoding: "utf8",
})
.split("\n")
.map((line) => line.trim())
.filter(Boolean);
return micromatch(tracked, E2E_SPEC_GLOBS, {
ignore: [BASELINE_SPEC],
dot: true,
});
}

View File

@@ -1,68 +1,58 @@
/* eslint-disable import/no-commonjs */
// Measures the front-end bundles emitted into an extracted uberjar tree.
//
// Every bundle reports one or both of:
// - "initial": JS the browser downloads on first paint (the entry chunk plus
// its initial/sync split chunks). Never excludes initial chunks.
// - "total": all *reachable* JS (initial plus async chunks that are actually
// loadable at runtime). Never includes unreachable/never-fetched chunks.
// Reachability needs the per-entry asset list from the rspack stats file, so the
// app and chunked SDK bundles require their stats file to be present.
//
// The pure pieces — the asset-name selection (initial vs reachable, runtime
// filtering, the async-loadable flag) — are split out as select*Assets so they
// can be unit-tested against a stats object. The measure* functions and main()
// keep all the filesystem and env I/O, threading an explicit `config`.
const fs = require("fs");
const path = require("path");
const zlib = require("zlib");
// MEASURE_ROOT lets callers point at an extracted tree (e.g. the PR bundle-size
// check measures a current and a base-ref tree); defaults to cwd for the stats
// workflow. MEASURE_BUNDLES restricts which bundles are measured (comma-separated).
const baseDir = process.env.MEASURE_ROOT ? path.resolve(process.env.MEASURE_ROOT) : process.cwd();
const resolve = (...relativeParts) => path.resolve(baseDir, ...relativeParts);
const bundleFilter = process.env.MEASURE_BUNDLES
? new Set(process.env.MEASURE_BUNDLES.split(",").map(bundle => bundle.trim()))
: null;
const isBundleWanted = bundle => !bundleFilter || bundleFilter.has(bundle);
const APP_DIST = "resources/frontend_client/app/dist";
const SDK_ROOT = "resources/frontend_client/app/embedding-sdk";
/**
* Async SDK chunks are reachable now that the runtime publicPath is set, so the
* bootstrap can fetch import() chunks on demand. "total" therefore includes the
* lazy chunks while "initial" stays the eager first-load set. There's no reliable
* way to detect loadability from the build artifacts, so this stays a manual flag:
* it was flipped to true alongside the publicPath fix.
*/
const SDK_ASYNC_CHUNKS_LOADABLE = true;
// The chunk runtime is inlined into the bootstrap, never sent as a standalone file.
const SDK_RUNTIME_RE = /embedding-sdk-chunk-runtime\./;
const notRuntime = name => !SDK_RUNTIME_RE.test(name);
/**
* Simple targets measured straight from emitted files.
* - `dir`/`file`/`altFile`: what to measure (altFile is a fallback single file).
* - `stats`: entrypoint whose initial assets are the "initial" download.
* - `optional`: skip (don't fail) when the output is absent.
* The hosted SDK is split into embedding-sdk-legacy (the self-contained
* monolith) and embedding-sdk-chunked (handled separately below).
*/
const simpleTargets = [
{
bundle: "app",
dir: "resources/frontend_client/app/dist",
stats: { file: "artifacts/stats-main.json", entrypoint: "app-main" },
},
{
bundle: "embedding-sdk-legacy",
dir: `${SDK_ROOT}/legacy`,
altFile: `${SDK_ROOT}.js`,
optional: true,
},
{
bundle: "embedding-sdk-package",
dir: "resources/embedding-sdk/dist",
optional: true,
},
{
bundle: "embed-js",
file: "resources/frontend_client/app/embed.js",
},
];
const assetFiles = (root, names) => names.map(name => path.join(root, name));
const unique = files => [...new Set(files)];
// MEASURE_ROOT lets callers point at an extracted tree (e.g. the PR bundle-size
// check measures a current and a base-ref tree); defaults to cwd for the stats
// workflow. MEASURE_BUNDLES restricts which bundles are measured (comma-separated).
// SDK_ASYNC_CHUNKS_LOADABLE (see selectChunkedSdkAssets) toggles whether async
// SDK chunks count toward "total".
function buildConfig(env) {
const baseDir = env.MEASURE_ROOT ? path.resolve(env.MEASURE_ROOT) : process.cwd();
const bundleFilter = env.MEASURE_BUNDLES
? new Set(env.MEASURE_BUNDLES.split(",").map(bundle => bundle.trim()))
: null;
return {
resolve: (...relativeParts) => path.resolve(baseDir, ...relativeParts),
isBundleWanted: bundle => !bundleFilter || bundleFilter.has(bundle),
// Async SDK chunks are reachable once output.publicPath is set so import()
// chunks are actually fetched at runtime — which landed in master. Defaults
// to true to match master; set SDK_ASYNC_CHUNKS_LOADABLE=false to measure an
// older commit built before the publicPath fix (async unreachable, so
// "total" collapses to "initial").
sdkAsyncChunksLoadable: env.SDK_ASYNC_CHUNKS_LOADABLE !== "false",
};
}
function sizeOf(files) {
let rawBytes = 0;
let gzipBytes = 0;
let brotliBytes = 0;
let anyBrotli = false;
for (const file of files) {
const contents = fs.readFileSync(file);
rawBytes += contents.length;
@@ -70,20 +60,17 @@ function sizeOf(files) {
gzipBytes += zlib.gzipSync(contents).length;
// brotli: as-served — count the precompressed .br the build ships; files
// without one (static-viz, sub-threshold chunks) are served compressed on
// the fly, so estimate with brotli. Null when no .br shipped at all.
// the fly, so estimate with brotli. Always reported (like gzip).
const brotliPath = `${file}.br`;
if (fs.existsSync(brotliPath)) {
anyBrotli = true;
brotliBytes += fs.statSync(brotliPath).size;
} else {
brotliBytes += zlib.brotliCompressSync(contents).length;
}
brotliBytes += fs.existsSync(brotliPath)
? fs.statSync(brotliPath).size
: zlib.brotliCompressSync(contents).length;
}
return {
fileCount: files.length,
rawBytes,
gzipBytes,
brotliBytes: anyBrotli ? brotliBytes : null,
brotliBytes,
};
}
@@ -102,104 +89,170 @@ function collectJsFiles(absolutePath) {
});
}
function readStats(statsFile) {
const statsPath = resolve(statsFile);
function readStats(config, statsFile) {
const statsPath = config.resolve(statsFile);
return fs.existsSync(statsPath) ? JSON.parse(fs.readFileSync(statsPath, "utf8")) : null;
}
function entrypointJsAssets(stats, name) {
// An entrypoint's .js assets for a given field: "assets" = its initial
// (synchronous) load; "reachableAssets" = initial plus everything it can lazily
// import (the chunk graph walked at build time in bundle-stats.js).
function entrypointJsAssets(stats, name, field = "assets") {
const entry = stats && stats.entrypoints && stats.entrypoints[name];
if (!entry) {
if (!entry || !entry[field]) {
return null;
}
return entry.assets.map(asset => asset.name || asset).filter(name => name.endsWith(".js"));
}
function initialJsFiles({ file: statsFile, entrypoint, root }, joinRoot) {
const stats = readStats(statsFile);
if (!stats) {
console.warn(`Stats file missing (${statsFile}); reporting initial == total.`);
return null;
}
const assets = entrypointJsAssets(stats, entrypoint);
if (!assets) {
console.warn(`Entrypoint "${entrypoint}" missing in ${statsFile}; reporting initial == total.`);
return null;
}
const base = root ? resolve(root) : joinRoot;
return assets.map(name => path.join(base, name));
}
function measureSimpleTarget({ bundle, dir, file, altFile, stats, optional }) {
const candidates = [dir, file, altFile].filter(Boolean);
const chosen = candidates.find(c => fs.existsSync(resolve(c)));
if (!chosen) {
if (optional) {
console.warn(`Skipping "${bundle}": output not found (${candidates.join(", ")})`);
return [];
}
throw new Error(`Bundle output not found for "${bundle}": ${candidates.join(", ")}`);
}
const root = resolve(chosen);
const total = sizeOf(collectJsFiles(root));
const initialFiles = stats ? initialJsFiles(stats, root) : null;
const initial = initialFiles ? sizeOf(initialFiles) : total;
return [
{ bundle, kind: "initial", ...initial },
{ bundle, kind: "total", ...total },
];
return entry[field].map(asset => asset.name || asset).filter(assetName => assetName.endsWith(".js"));
}
/**
* Chunked SDK delivery. "Reachable" = what the bootstrap actually sends: the
* bootstrap (with its inlined runtime) + the chunked entry's initial chunks,
* minus the standalone runtime file. Async chunks are excluded (initial == total)
* unless SDK_ASYNC_CHUNKS_LOADABLE is set, at which point "total" includes them.
* Main app = the app-main entrypoint only (app/dist also holds other pages like
* app-public, app-embed*, which are not the app). `reachableAssets` is null on
* older stats built before the chunk-graph enrichment — the caller then falls
* back to sizing the whole app/dist.
*/
function measureChunkedSdk(statsFile) {
const chunksDir = resolve(SDK_ROOT, "chunks");
function selectAppAssets(stats) {
const initialAssets = entrypointJsAssets(stats, "app-main", "assets");
if (!initialAssets) {
throw new Error('app: stats-main.json / "app-main" entrypoint missing');
}
return { initialAssets, reachableAssets: entrypointJsAssets(stats, "app-main", "reachableAssets") };
}
/**
* Legacy SDK: the "embedding-sdk" entry, a single eager file in legacy/. It still
* emits on-demand chunks (jspdf, echarts, leaflet, ...) into the shared chunks/
* dir via dynamic import(). initial = the eager legacy file; total = initial plus
* its reachable async chunks, but only when those are loadable at runtime
* (sdkAsyncChunksLoadable), otherwise total collapses to initial. Returns null
* when the stats lack the entry (older layout) so the caller can fall back.
*/
function selectLegacySdkAssets(stats, { sdkAsyncChunksLoadable }) {
const initialNames = entrypointJsAssets(stats, "embedding-sdk", "assets");
if (!initialNames) {
return null;
}
const reachableNames = entrypointJsAssets(stats, "embedding-sdk", "reachableAssets") || initialNames;
const initial = unique(initialNames).filter(notRuntime);
return {
initialNames: initial,
reachableNames: sdkAsyncChunksLoadable ? unique(reachableNames).filter(notRuntime) : initial,
};
}
/**
* Chunked SDK delivery. initial = bootstrap (minus its inlined runtime) + the
* chunked entry's initial chunks. total = the chunked entry's reachable set
* (initial + async children, from the chunk graph). includesAsyncChunks is true
* only when the stats carry the reachable chunk graph AND those chunks are
* loadable at runtime (sdkAsyncChunksLoadable). A base ref built before the
* reachableAssets enrichment has no graph, so its "total" must collapse to
* "initial" — the flag lets the comparison avoid measuring a reachable total
* against a collapsed one (an apples-to-oranges ~30% phantom).
*/
function selectChunkedSdkAssets(stats, { sdkAsyncChunksLoadable }) {
const chunkedInitial = entrypointJsAssets(stats, "embedding-sdk-chunked", "assets");
if (!chunkedInitial) {
throw new Error('embedding-sdk-chunked: stats-embedding-sdk.json / "embedding-sdk-chunked" entrypoint missing');
}
const bootstrapInitial = entrypointJsAssets(stats, "embedding-sdk-bootstrap", "assets") || [];
const chunkedReachableAssets = entrypointJsAssets(stats, "embedding-sdk-chunked", "reachableAssets");
const chunkedReachable = chunkedReachableAssets || chunkedInitial;
const bootstrapReachable = entrypointJsAssets(stats, "embedding-sdk-bootstrap", "reachableAssets") || bootstrapInitial;
return {
initialNames: unique([...bootstrapInitial, ...chunkedInitial]).filter(notRuntime),
reachableNames: unique([...bootstrapReachable, ...chunkedReachable]).filter(notRuntime),
includesAsyncChunks: chunkedReachableAssets != null && sdkAsyncChunksLoadable,
};
}
function measureApp(config) {
const dist = config.resolve(APP_DIST);
if (!fs.existsSync(dist)) {
throw new Error(`Bundle output not found for "app": ${dist}`);
}
const { initialAssets, reachableAssets } = selectAppAssets(readStats(config, "artifacts/stats-main.json"));
if (!reachableAssets) {
console.warn("app: stats has no reachableAssets; app total falls back to the whole app/dist");
}
const totalFiles = reachableAssets ? assetFiles(dist, reachableAssets) : collectJsFiles(dist);
return [
{ bundle: "app", kind: "initial", ...sizeOf(assetFiles(dist, initialAssets)) },
{ bundle: "app", kind: "total", ...sizeOf(totalFiles) },
];
}
function measureLegacySdk(config) {
const absRoot = config.resolve(SDK_ROOT);
const selected = selectLegacySdkAssets(readStats(config, "artifacts/stats-embedding-sdk.json"), config);
if (!selected) {
// No stats / older layout: fall back to whatever sits in the legacy dir.
const candidates = [`${SDK_ROOT}/legacy`, `${SDK_ROOT}.js`];
const chosen = candidates.find(candidate => fs.existsSync(config.resolve(candidate)));
if (!chosen) {
console.warn(`Skipping "embedding-sdk-legacy": output not found (${candidates.join(", ")})`);
return [];
}
return [{ bundle: "embedding-sdk-legacy", kind: "total", ...sizeOf(collectJsFiles(config.resolve(chosen))) }];
}
return [
{ bundle: "embedding-sdk-legacy", kind: "initial", ...sizeOf(assetFiles(absRoot, selected.initialNames)) },
{ bundle: "embedding-sdk-legacy", kind: "total", ...sizeOf(assetFiles(absRoot, selected.reachableNames)) },
];
}
function measureChunkedSdk(config) {
const chunksDir = config.resolve(SDK_ROOT, "chunks");
if (!fs.existsSync(chunksDir)) {
// pre-chunked layout (monolith only) — nothing to measure here
return [];
}
const absRoot = resolve(SDK_ROOT);
const everything = collectJsFiles(chunksDir).filter(f => !SDK_RUNTIME_RE.test(f));
const stats = readStats(statsFile);
const chunked = entrypointJsAssets(stats, "embedding-sdk-chunked");
let reachableFiles;
if (chunked) {
const bootstrap = entrypointJsAssets(stats, "embedding-sdk-bootstrap") || [];
const names = [...new Set([...bootstrap, ...chunked])].filter(n => !SDK_RUNTIME_RE.test(n));
reachableFiles = names.map(n => path.join(absRoot, n));
} else {
console.warn(`embedding-sdk-chunked: entrypoint missing in ${statsFile}; counting whole chunks/ dir`);
reachableFiles = everything;
}
const initial = sizeOf(reachableFiles);
const total = SDK_ASYNC_CHUNKS_LOADABLE ? sizeOf(everything) : sizeOf(reachableFiles);
const absRoot = config.resolve(SDK_ROOT);
const { initialNames, reachableNames, includesAsyncChunks } = selectChunkedSdkAssets(
readStats(config, "artifacts/stats-embedding-sdk.json"),
config,
);
const initial = sizeOf(assetFiles(absRoot, initialNames));
const total = includesAsyncChunks ? sizeOf(assetFiles(absRoot, reachableNames)) : initial;
return [
{ bundle: "embedding-sdk-chunked", kind: "initial", ...initial },
{ bundle: "embedding-sdk-chunked", kind: "total", ...total },
{ bundle: "embedding-sdk-chunked", kind: "total", reachable: includesAsyncChunks, ...total },
];
}
function measureBundleSizes() {
return [
...simpleTargets.filter(target => isBundleWanted(target.bundle)).flatMap(measureSimpleTarget),
...(isBundleWanted("embedding-sdk-chunked")
? measureChunkedSdk("artifacts/stats-embedding-sdk.json")
: []),
];
// Single-file/dir bundles loaded in one shot — total only.
function measureWholeDir(config, bundle, candidates) {
const chosen = candidates.find(candidate => fs.existsSync(config.resolve(candidate)));
if (!chosen) {
console.warn(`Skipping "${bundle}": output not found (${candidates.join(", ")})`);
return [];
}
return [{ bundle, kind: "total", ...sizeOf(collectJsFiles(config.resolve(chosen))) }];
}
module.exports = { measureBundleSizes };
const bundles = {
app: measureApp,
"embedding-sdk-legacy": measureLegacySdk,
"embedding-sdk-chunked": measureChunkedSdk,
"embedding-sdk-package": config => measureWholeDir(config, "embedding-sdk-package", ["resources/embedding-sdk/dist"]),
"embed-js": config => measureWholeDir(config, "embed-js", ["resources/frontend_client/app/embed.js"]),
};
function measureBundleSizes(config) {
return Object.entries(bundles)
.filter(([bundle]) => config.isBundleWanted(bundle))
.flatMap(([, measure]) => measure(config));
}
module.exports = {
measureBundleSizes,
buildConfig,
entrypointJsAssets,
selectAppAssets,
selectLegacySdkAssets,
selectChunkedSdkAssets,
};
if (require.main === module) {
console.log(JSON.stringify(measureBundleSizes(), null, 2));
console.log(JSON.stringify(measureBundleSizes(buildConfig(process.env)), null, 2));
}

View File

@@ -0,0 +1,87 @@
const {
entrypointJsAssets,
selectAppAssets,
selectLegacySdkAssets,
selectChunkedSdkAssets,
} = require("./measure-bundle-sizes");
const RUNTIME = "embedding-sdk-chunk-runtime.deadbeef.js";
const stats = entrypoints => ({ entrypoints });
describe("entrypointJsAssets", () => {
it("returns the .js asset names for a field, accepting strings or {name}", () => {
const s = stats({ app: { assets: [{ name: "a.js" }, "b.js", { name: "c.css" }] } });
expect(entrypointJsAssets(s, "app", "assets")).toEqual(["a.js", "b.js"]);
});
it("returns null when the entrypoint or field is absent", () => {
expect(entrypointJsAssets(stats({}), "missing")).toBeNull();
expect(entrypointJsAssets(null, "app")).toBeNull();
});
});
describe("selectAppAssets", () => {
it("returns the initial set and a null reachable set on pre-enrichment stats", () => {
const s = stats({ "app-main": { assets: ["main.js"] } });
expect(selectAppAssets(s)).toEqual({ initialAssets: ["main.js"], reachableAssets: null });
});
it("throws when the app-main entrypoint is missing", () => {
expect(() => selectAppAssets(stats({}))).toThrow("app-main");
});
});
describe("selectChunkedSdkAssets", () => {
const base = {
"embedding-sdk-chunked": { assets: ["a.js", RUNTIME], reachableAssets: ["a.js", "b.js", RUNTIME] },
"embedding-sdk-bootstrap": { assets: ["boot.js"], reachableAssets: ["boot.js"] },
};
it("merges bootstrap + chunked, drops the inlined runtime, and counts async chunks", () => {
const result = selectChunkedSdkAssets(stats(base), { sdkAsyncChunksLoadable: true });
expect(result.initialNames).toEqual(["boot.js", "a.js"]);
expect(result.reachableNames).toEqual(["boot.js", "a.js", "b.js"]);
expect(result.includesAsyncChunks).toBe(true);
});
it("collapses total to initial when async chunks are not loadable", () => {
const result = selectChunkedSdkAssets(stats(base), { sdkAsyncChunksLoadable: false });
expect(result.includesAsyncChunks).toBe(false);
});
it("collapses total to initial when the stats carry no reachable graph", () => {
const noGraph = { "embedding-sdk-chunked": { assets: ["a.js"] } };
const result = selectChunkedSdkAssets(stats(noGraph), { sdkAsyncChunksLoadable: true });
expect(result.reachableNames).toEqual(["a.js"]);
expect(result.includesAsyncChunks).toBe(false);
});
it("throws when the chunked entrypoint is missing", () => {
expect(() => selectChunkedSdkAssets(stats({}), { sdkAsyncChunksLoadable: true })).toThrow(
"embedding-sdk-chunked",
);
});
});
describe("selectLegacySdkAssets", () => {
it("returns null when the legacy entry is absent so the caller can fall back", () => {
expect(selectLegacySdkAssets(stats({}), { sdkAsyncChunksLoadable: true })).toBeNull();
});
it("expands total to the reachable async set when loadable", () => {
const s = stats({ "embedding-sdk": { assets: ["legacy.js"], reachableAssets: ["legacy.js", "chunk.js"] } });
expect(selectLegacySdkAssets(s, { sdkAsyncChunksLoadable: true })).toEqual({
initialNames: ["legacy.js"],
reachableNames: ["legacy.js", "chunk.js"],
});
});
it("collapses total to initial when async chunks are not loadable", () => {
const s = stats({ "embedding-sdk": { assets: ["legacy.js"], reachableAssets: ["legacy.js", "chunk.js"] } });
expect(selectLegacySdkAssets(s, { sdkAsyncChunksLoadable: false })).toEqual({
initialNames: ["legacy.js"],
reachableNames: ["legacy.js"],
});
});
});

View File

@@ -0,0 +1,94 @@
/**
* Resolves the nightly e2e coverage manifest closest to a commit's point in
* history, so the test planner can narrow the e2e run.
*
* The whole flow lives here so callers "just get a manifest": list the retained
* manifest artifacts, find the one whose nightly commit is the nearest ancestor
* of `headSha` (via the GitHub compare API — no deep clone), download and unzip
* just that one, and return its parsed contents.
*
* `github` is an authenticated Octokit, as injected by actions/github-script.
* Returns { builtAt, specs, path, behindBy } or null when nothing is an
* ancestor (caller then runs e2e in full). Never throws: any API/IO failure is
* logged and resolves to null, because coverage resolution must not break the
* test plan.
*/
import { execFileSync } from "node:child_process";
import fs from "node:fs";
const ARTIFACT_NAME = "spec-file-manifest";
const EXTRACT_DIR = "e2e/coverage";
const MANIFEST_PATH = `${EXTRACT_DIR}/${ARTIFACT_NAME}.json`;
export async function resolveCoverageManifest({
github,
owner,
repo,
headSha,
log = console.log,
}) {
try {
// Every retained manifest artifact, newest first. Each carries its
// nightly's head_sha — the commit it was built from (== builtAt).
const artifacts = await github.paginate(
github.rest.actions.listArtifactsForRepo,
{ owner, repo, name: ARTIFACT_NAME, per_page: 100 },
);
const candidates = artifacts
.filter((artifact) => !artifact.expired && artifact.workflow_run?.head_sha)
.sort(
(a, b) =>
new Date(b.created_at).getTime() - new Date(a.created_at).getTime(),
);
// First candidate that is an ancestor of head is the closest in history
// (master is linear, candidates are chronological). compare base...head:
// behind_by === 0 ⇒ base is an ancestor of head; ahead_by is the distance.
let chosen = null;
for (const artifact of candidates) {
const base = artifact.workflow_run.head_sha;
// A stale candidate (force-pushed/GC'd commit) makes compare 404 — skip
// it rather than lose the optimization for everyone.
let comparison;
try {
({ data: comparison } =
await github.rest.repos.compareCommitsWithBasehead({
owner,
repo,
basehead: `${base}...${headSha}`,
}));
} catch {
continue;
}
if (comparison.behind_by === 0) {
chosen = { artifact, base, behindBy: comparison.ahead_by };
break;
}
}
if (!chosen) {
log("No ancestor coverage manifest found; e2e will run in full.");
return null;
}
const download = await github.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: chosen.artifact.id,
archive_format: "zip",
});
fs.writeFileSync(`${ARTIFACT_NAME}.zip`, Buffer.from(download.data));
execFileSync("unzip", ["-o", `${ARTIFACT_NAME}.zip`, "-d", EXTRACT_DIR]);
const manifest = JSON.parse(fs.readFileSync(MANIFEST_PATH, "utf8"));
log(
`Using coverage manifest ${chosen.base.slice(0, 12)} ` +
`(${chosen.behindBy} commits behind HEAD).`,
);
return { ...manifest, path: MANIFEST_PATH, behindBy: chosen.behindBy };
} catch (error) {
log(`Coverage manifest resolution failed; e2e will run in full: ${error}`);
return null;
}
}

View File

@@ -19,7 +19,8 @@ while [[ $# -gt 0 ]]; do
done
echo "Cloning python-runner repository..."
git clone --depth 1 https://${METABASE_AUTOMATION_USER_TOKEN}@github.com/metabase/python-runner-container.git python-runner
git clone --depth 1 https://${METABASE_AUTOMATION_USER_TOKEN}@github.com/metabase/python-runner-container.git --branch seccomp python-runner
if [ "$SKIP_START" = false ]; then
echo "Starting python-runner..."

View File

@@ -5,44 +5,60 @@
const { uploadCsvToMb } = require("./csv-to-mb.js");
// "FE Affected Tests" uploaded table on stats.metabase.com.
const TABLE_ID = 79841;
const TABLE_ID = 81818;
const s = JSON.parse(process.env.STATS_JSON);
console.log("stats", s);
async function main() {
// create-test-plan doesn't always produce stats (e.g. on release branches
// running an older planner), leaving STATS_JSON empty. Nothing to upload.
const raw = (process.env.STATS_JSON || "").trim();
if (!raw || raw === "null") {
console.log("No STATS_JSON to upload; skipping.");
return;
}
const row = {
Date: new Date().toISOString(),
// "pr_update" or "merge_to_master". ("Trigger" is a reserved SQL word.)
"Triggered By": process.env.TRIGGERED_BY,
PR: Number(process.env.PR_NUMBER),
"Head SHA": process.env.HEAD_SHA,
"Base SHA": process.env.BASE_SHA,
"FE Files Changed": s.fe_files_changed,
"BE Files Changed": s.be_files_changed,
"FE Modules Changed": s.fe_modules_changed,
"FE Modules Affected (Rules)": s.fe_modules_affected_rules,
"FE Modules Affected (Usage)": s.fe_modules_affected_usage,
"Unit Specs All": s.unit_specs_all,
"Unit Specs To Run (Rules)": s.unit_specs_to_run_rules,
"Unit Specs To Run (Usage)": s.unit_specs_to_run_usage,
"Loki Stories All": s.loki_stories_all,
"Loki Stories To Run (Rules)": s.loki_stories_to_run_rules,
"Loki Stories To Run (Usage)": s.loki_stories_to_run_usage,
"E2E Specs All": s.e2e_specs_all,
"E2E Specs To Run (Rules)": s.e2e_specs_to_run_rules,
"E2E Specs To Run (Usage)": s.e2e_specs_to_run_usage,
};
const s = JSON.parse(raw);
console.log("stats", s);
uploadCsvToMb({
baseUrl: "https://stats.metabase.com",
tableId: TABLE_ID,
jsonData: [row],
mode: "append",
})
.then(() => {
console.log("Data uploaded successfully");
})
.catch((error) => {
console.error("Error uploading data:", error);
process.exit(1);
const row = {
Date: new Date().toISOString(),
// "pr_update" or "merge_to_master". ("Trigger" is a reserved SQL word.)
"Triggered By": process.env.TRIGGERED_BY,
PR: Number(process.env.PR_NUMBER),
"Head SHA": process.env.HEAD_SHA,
"Base SHA": process.env.BASE_SHA,
"FE Files Changed": s.fe_files_changed,
"FE Files Total": s.fe_files_total,
"BE Files Changed": s.be_files_changed,
"BE Files Total": s.be_files_total,
"Unit Infra Touched": s.unit_infra_touched,
"Loki Infra Touched": s.loki_infra_touched,
"Shared Sources Touched": s.shared_sources_touched,
"FE Modules Total": s.fe_modules_total,
"FE Modules Changed": s.fe_modules_changed,
"FE Modules Affected (Rules)": s.fe_modules_affected_rules,
"FE Modules Affected (Usage)": s.fe_modules_affected_usage,
"Unit Specs All": s.unit_specs_all,
"Unit Specs To Run (Rules)": s.unit_specs_to_run_rules,
"Unit Specs To Run (Usage)": s.unit_specs_to_run_usage,
"Loki Stories All": s.loki_stories_all,
"Loki Stories To Run (Rules)": s.loki_stories_to_run_rules,
"Loki Stories To Run (Usage)": s.loki_stories_to_run_usage,
"E2E Specs All": s.e2e_specs_all,
"E2E Specs To Run (Rules)": s.e2e_specs_to_run_rules,
"E2E Specs To Run (Usage)": s.e2e_specs_to_run_usage,
};
await uploadCsvToMb({
baseUrl: "https://stats.metabase.com",
tableId: TABLE_ID,
jsonData: [row],
mode: "append",
});
console.log("Data uploaded successfully");
}
// Best-effort: never let a telemetry failure turn the job red.
main().catch((error) => {
console.error("Skipping stats upload after error:", error);
process.exit(0);
});

6
.github/team.json vendored
View File

@@ -47,7 +47,8 @@
"members": [
"fraserdrops",
"nemanjaglumac",
"romeovs"
"romeovs",
"ChrisVandoo"
]
},
{
@@ -92,7 +93,8 @@
"deniskaber",
"andsalves",
"kevinkelleher12",
"AndreyChernykh"
"AndreyChernykh",
"bowbahdoe"
]
},
{

42
.github/workflows/actionlint.yml vendored Normal file
View File

@@ -0,0 +1,42 @@
name: Actionlint
on:
push:
branches:
- 'master'
- 'release-**'
paths:
- '.github/workflows/**'
pull_request:
paths:
- '.github/workflows/**'
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
cancel-in-progress: true
jobs:
actionlint:
name: Lint Github Actions Workflows
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- uses: actions/checkout@v6
- name: Get changed Github actions
uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
id: changes
with:
token: ${{ github.token }}
filters: .github/file-paths.yaml
list-files: shell
- name: Setup actionlint
id: download
shell: bash
run: |
if command -v actionlint; then
echo "executable=actionlint" >> "$GITHUB_OUTPUT"
else
# script sets executable output, for details see: https://github.com/rhysd/actionlint/blob/main/docs/usage.md#use-actionlint-on-github-actions
bash <(curl -fsSL https://raw.githubusercontent.com/rhysd/actionlint/v1.7.12/scripts/download-actionlint.bash)
fi
- name: Run actionlint
run: ${{ steps.download.outputs.executable }} --color --verbose ${{ steps.changes.outputs.actionlint_files }}

View File

@@ -76,7 +76,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -120,6 +120,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -131,6 +132,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mysql:
if: ${{ !inputs.skip }}
@@ -191,7 +193,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -243,6 +245,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -254,6 +257,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-postgres:
if: ${{ !inputs.skip }}
@@ -307,7 +311,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -353,6 +357,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -364,6 +369,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
app-db-tests-result:
needs:

View File

@@ -45,7 +45,7 @@ jobs:
be-linter-eastwood-test:
# Master / release safety net: lint every backend test namespace.
if: ${{ !inputs.skip && github.event_name == 'push' && (github.ref_name == 'master' || startsWith(github.ref_name, 'release-')) }}
if: ${{ !inputs.skip && github.event_name == 'push' && (github.ref_name == 'master' || startsWith(github.ref_name, 'release-x')) }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 45
name: Eastwood (tests only)
@@ -121,7 +121,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java-version: [21]
java-version: [25]
job:
- name: Enterprise Tests
edition: ee
@@ -167,7 +167,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -197,26 +197,31 @@ jobs:
clojure -X:dev:ci:test:${{ matrix.job.edition }}:${{ matrix.job.edition }}-dev
:exclude-tags '[:mb/driver-tests ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
${{ matrix.job.test-args }}
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Report failed tests to ci-conductor
# Positioned between the test run and "Upload Test Results" so it reads
# pristine JUnit (before Trunk quarantine processing). Gated to non-clean
# runs + continue-on-error so it can never change the job outcome — Trunk
# Quarantine remains the sole arbiter. See DEV-2224 / DEV-2235.
if: ${{ always() && steps.run-java-tests.outcome != 'success' }}
if: ${{ !cancelled() && steps.run-java-tests.outcome == 'failure' }}
# This step should NEVER fail the job!
continue-on-error: true
uses: ./.github/actions/report-failures-to-ci-conductor
with:
test-suite: be-tests-java-${{ matrix.java-version }}-${{ matrix.job.test-group-name }}
adapter: backend
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-java-tests.outcome == 'failure' }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: backend
test-suite: be-tests-java-${{ matrix.java-version }}-${{ matrix.job.test-group-name }}
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always() && (steps.run-java-tests.conclusion != 'skipped' || steps.run-java-tests-21.conclusion != 'skipped')
if: always()
with:
input-path: ./target/junit/
output-name: be-tests-java-${{ matrix.java-version }}-${{ matrix.job.edition }}
@@ -225,6 +230,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-java-tests.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 # v3.0.0
@@ -253,7 +259,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
java-version: [21]
java-version: [25]
name: "Check Java ${{ matrix.java-version }}"
steps:
- uses: actions/checkout@v6

View File

@@ -8,6 +8,8 @@ on:
workflow_run:
workflows: ["Build Uberjar"]
types: [completed]
# Master only: releases form non-linear lines whose deltas are meaningless,
# so their sizes are backfilled separately rather than logged here.
branches: [master]
concurrency:
@@ -21,6 +23,10 @@ jobs:
timeout-minutes: 15
env:
HEAD_SHA: ${{ github.event.workflow_run.head_sha }}
# Only record a data point when a bundle's as-served size (brotli where the
# build ships .br, else gzip) moved by at least this percent vs the last
# plotted point, keeping the chart to real changes.
MIN_DELTA_PERCENT: "0.5"
steps:
- name: Check out the code
uses: actions/checkout@v6
@@ -78,9 +84,30 @@ jobs:
mkdir -p artifacts resources/embedding-sdk
if [ -n "$STATS_ZIP" ]; then unzip -o "$STATS_ZIP" -d artifacts; fi
if [ -n "$PKG_ZIP" ]; then unzip -o "$PKG_ZIP" -d resources/embedding-sdk; fi
- name: Restore last plotted bundle sizes
uses: actions/cache/restore@v4
with:
path: bundle-size-cache
key: bundle-size-last-${{ github.run_id }}
restore-keys: |
bundle-size-last-
- name: Measure bundle sizes
run: node ./.github/scripts/measure-bundle-sizes.js | tee artifacts/bundle-sizes.json
- name: Upload sizes to Stats
- name: Compute deltas and decide whether to record this point
id: prepare
env:
CURRENT: artifacts/bundle-sizes.json
LAST: bundle-size-cache/last.json
CACHE_OUT: bundle-size-cache/last.json
ROWS_OUT: artifacts/upload-rows.json
VERSION_PROPS: artifacts/version.properties
# Passed via env (not interpolated into the shell) so the commit
# message can't inject commands; the script keeps only the subject.
COMMIT_MESSAGE: ${{ github.event.workflow_run.head_commit.message }}
run: node ./.github/scripts/bundle-size-stats-prepare.js
- name: Upload sizes (with deltas) to Stats
id: upload
if: steps.prepare.outputs.significant == 'true'
uses: actions/github-script@v9
env:
API_KEY: ${{ secrets.STATS_API_KEY }}
@@ -89,43 +116,33 @@ jobs:
const fs = require("fs");
const { uploadCsvToMb } = require("${{ github.workspace }}/.github/scripts/csv-to-mb.js");
const measurements = JSON.parse(
fs.readFileSync("${{ github.workspace }}/artifacts/bundle-sizes.json", "utf8"),
const data = JSON.parse(
fs.readFileSync("${{ github.workspace }}/artifacts/upload-rows.json", "utf8"),
);
const date = new Date().toISOString().slice(0, 10); // YYYY-MM-DD
const commit = process.env.HEAD_SHA.slice(0, 12);
// version.properties (extracted from the uberjar) carries the build's tag.
// Non-release (master) builds report tag=vUNKNOWN, so leave Version empty there.
const versionProps = "${{ github.workspace }}/artifacts/version.properties";
const rawVersion = fs.existsSync(versionProps)
? (fs.readFileSync(versionProps, "utf8").match(/^tag=(.*)$/m)?.[1]?.trim() ?? "")
: "";
const version = rawVersion === "vUNKNOWN" ? "" : rawVersion;
const data = measurements.map(measurement => ({
"Date": date,
"Version": version,
"Commit": commit,
"Bundle": measurement.bundle,
"Kind": measurement.kind, // "initial" or "total"
"Raw bytes": measurement.rawBytes,
"Gzip bytes": measurement.gzipBytes,
"Brotli bytes": measurement.brotliBytes ?? "", // as-served; empty when no .br shipped
"File count": measurement.fileCount,
}));
console.table(data);
uploadCsvToMb({
baseUrl: "https://stats.metabase.com",
tableId: 79417,
jsonData: data,
mode: "append",
}).then(() => {
try {
await uploadCsvToMb({
baseUrl: "https://stats.metabase.com",
tableId: 79702,
jsonData: data,
mode: "append",
});
console.log("Bundle sizes uploaded successfully");
}).catch(error => {
console.error("Error uploading bundle sizes:", error);
process.exit(1);
});
core.setOutput("uploaded", "true");
} catch (error) {
// Stats logging is best-effort: if stats.metabase.com is still
// unreachable after the client's retries, keep the run green. The
// last-plotted cache is only saved on a successful upload (below),
// so this point is re-attempted on the next master build and
// nothing is silently dropped.
core.warning(`Bundle-size upload failed after retries; leaving run green: ${error.message}`);
core.setOutput("uploaded", "false");
}
- name: Remember this as the last plotted point
if: steps.upload.outputs.uploaded == 'true'
uses: actions/cache/save@v4
with:
path: bundle-size-cache
key: bundle-size-last-${{ github.run_id }}

View File

@@ -26,7 +26,7 @@ concurrency:
jobs:
migrations-h2-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: h2
@@ -40,7 +40,7 @@ jobs:
migrations-postgres-14-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: postgres
@@ -66,7 +66,7 @@ jobs:
migrations-postgres-latest-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: postgres
@@ -92,7 +92,7 @@ jobs:
migrations-mysql-8-0-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: mysql
@@ -117,7 +117,7 @@ jobs:
migrations-mysql-latest-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: mysql
@@ -143,7 +143,7 @@ jobs:
migrations-mariadb-10-6-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: mysql
@@ -168,7 +168,7 @@ jobs:
migrations-mariadb-latest-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: mysql

22
.github/workflows/docs-generate-63.yml vendored Normal file
View File

@@ -0,0 +1,22 @@
name: Auto-update documentation (release)
on:
schedule:
- cron: "0 23 * * 1-5" # Every Monday through Friday at 11 PM UTC
workflow_dispatch:
inputs:
target_branch:
description: "Target branch for documentation update"
required: false
default: "release-x.63.x"
type: string
jobs:
update-release-docs:
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
name: Call documentation update for release branch
uses: ./.github/workflows/docs-generate-base.yml
with:
target_branch: ${{ inputs.target_branch || 'release-x.63.x' }}
secrets:
automation_token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}

View File

@@ -46,6 +46,7 @@ jobs:
sqlserver-should-run: ${{ steps.driver-decisions.outputs.sqlserver-should-run }}
vertica-should-run: ${{ steps.driver-decisions.outputs.vertica-should-run }}
# Per-driver configured status from ci-test-config (skip | info | required)
h2-status: ${{ steps.driver-decisions.outputs.h2-status }}
athena-status: ${{ steps.driver-decisions.outputs.athena-status }}
bigquery-status: ${{ steps.driver-decisions.outputs.bigquery-status }}
clickhouse-status: ${{ steps.driver-decisions.outputs.clickhouse-status }}
@@ -56,6 +57,7 @@ jobs:
mongo-sharded-cluster-status: ${{ steps.driver-decisions.outputs.mongo-sharded-cluster-status }}
mysql-mariadb-status: ${{ steps.driver-decisions.outputs.mysql-mariadb-status }}
oracle-status: ${{ steps.driver-decisions.outputs.oracle-status }}
postgres-status: ${{ steps.driver-decisions.outputs.postgres-status }}
presto-jdbc-status: ${{ steps.driver-decisions.outputs.presto-jdbc-status }}
redshift-status: ${{ steps.driver-decisions.outputs.redshift-status }}
snowflake-status: ${{ steps.driver-decisions.outputs.snowflake-status }}
@@ -136,7 +138,7 @@ jobs:
./bin/mage -driver-decisions "${MAGE_ARGS[@]}" --github-output-only >> $GITHUB_OUTPUT
env:
BASE_REF: ${{ github.event.pull_request.base.ref || github.ref_name }}
IS_MASTER_OR_RELEASE: ${{ github.ref_name == 'master' || startsWith(github.ref_name, 'release-') }}
IS_MASTER_OR_RELEASE: ${{ github.ref_name == 'master' || startsWith(github.ref_name, 'release-x') }}
shell: bash
be-tests-athena-ee:
@@ -177,6 +179,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.athena-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -190,6 +194,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.athena-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-bigquery-cloud-sdk-ee:
needs: determine-driver-skips
@@ -253,6 +258,8 @@ jobs:
junit-name: 'be-tests-bigquery-cloud-sdk-ee'
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.bigquery-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -266,6 +273,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.bigquery-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -338,6 +346,8 @@ jobs:
junit-name: 'be-tests-clickhouse-ee'
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.clickhouse-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -349,6 +359,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.clickhouse-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -392,6 +404,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -403,12 +417,39 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-databricks-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.databricks-should-run == 'true' || needs.determine-driver-skips.outputs.databricks-quarantine-conflict == 'true' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
matrix:
job:
- name: Driver Tests Part 1
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 0
- name: Driver Tests Part 2
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 1
- name: Driver Tests Part 3
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 2
env:
CI: 'true'
DRIVERS: databricks
@@ -437,9 +478,9 @@ jobs:
uses: ./.github/actions/test-driver
with:
junit-name: 'be-tests-databricks-ee'
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
test-args: ${{ matrix.job.test-args }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -453,12 +494,38 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-databricks-multi-catalog-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.databricks-should-run == 'true' || needs.determine-driver-skips.outputs.databricks-quarantine-conflict == 'true' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
matrix:
job:
- name: Driver Tests Part 1
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 0
- name: Driver Tests Part 2
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 1
- name: Driver Tests Part 3
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 2
env:
CI: 'true'
DRIVERS: databricks
@@ -488,9 +555,9 @@ jobs:
uses: ./.github/actions/test-driver
with:
junit-name: 'be-tests-databricks-multi-catalog-ee'
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
test-args: ${{ matrix.job.test-args }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -504,6 +571,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-h2:
needs: determine-driver-skips
@@ -523,6 +591,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -534,6 +604,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-h2-oss:
needs: determine-driver-skips
@@ -554,6 +626,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -565,6 +639,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mysql-mariadb:
needs: determine-driver-skips
@@ -627,7 +703,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -684,6 +760,8 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -695,6 +773,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -764,6 +844,8 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -775,6 +857,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -846,6 +930,8 @@ jobs:
test-args: >-
:exclude-tags '[:mongo-sharded-cluster-tests :mb/transforms-python-test]'
:only-tags [:mb/driver-tests]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -857,6 +943,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mongo-sharded-cluster-ee:
needs: determine-driver-skips
@@ -891,6 +979,8 @@ jobs:
junit-name: 'be-tests-mongo-sharded-cluster-ee'
test-args: >-
:only metabase.driver.mongo.sharded-cluster-test
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -902,6 +992,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-oracle:
needs: determine-driver-skips
@@ -976,6 +1068,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.oracle-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -987,6 +1081,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.oracle-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-postgres:
needs: determine-driver-skips
@@ -1029,7 +1125,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -1080,6 +1176,8 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.postgres-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1091,6 +1189,9 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.postgres-status }}
report-variant: ${{ matrix.version.name }}-${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -1167,6 +1268,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1178,6 +1281,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-redshift-ee:
needs: determine-driver-skips
@@ -1251,6 +1356,8 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.redshift-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: ${{ !matrix.job.skip && !cancelled() }}
@@ -1264,6 +1371,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.redshift-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1283,8 +1391,11 @@ jobs:
- name: Driver Tests
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:exclude-tags '[:mb/upload-tests :mb/transforms-python-test]'
:fail-fast? true
- name: Upload Tests
test-args: >-
:only-tags [:mb/upload-tests]
- name: Transforms Python Tests
test-args: >-
:only-tags [:mb/transforms-python-test]
@@ -1333,6 +1444,8 @@ jobs:
junit-name: 'be-tests-snowflake-ee'
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.snowflake-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1346,6 +1459,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.snowflake-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1387,6 +1501,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.sparksql-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1398,6 +1514,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.sparksql-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-sqlite-ee:
needs: determine-driver-skips
@@ -1428,6 +1546,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlite-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1439,6 +1559,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlite-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-sqlserver:
needs: determine-driver-skips
@@ -1504,6 +1626,8 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.version.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlserver-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1515,6 +1639,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlserver-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1629,6 +1755,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.vertica-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1640,6 +1768,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.vertica-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
drivers-tests-result:
needs:
@@ -1693,11 +1823,13 @@ jobs:
"be-tests-clickhouse-ee": "${{ needs.determine-driver-skips.outputs.clickhouse-status }}",
"be-tests-databricks-ee": "${{ needs.determine-driver-skips.outputs.databricks-status }}",
"be-tests-druid-jdbc-ee": "${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}",
"be-tests-h2": "${{ needs.determine-driver-skips.outputs.h2-status }}",
"be-tests-mongo": "${{ needs.determine-driver-skips.outputs.mongo-status }}",
"be-tests-mongo-ssl": "${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}",
"be-tests-mongo-sharded-cluster-ee": "${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}",
"be-tests-mysql-mariadb": "${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}",
"be-tests-oracle": "${{ needs.determine-driver-skips.outputs.oracle-status }}",
"be-tests-postgres": "${{ needs.determine-driver-skips.outputs.postgres-status }}",
"be-tests-presto-jdbc-ee": "${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}",
"be-tests-redshift-ee": "${{ needs.determine-driver-skips.outputs.redshift-status }}",
"be-tests-snowflake-ee": "${{ needs.determine-driver-skips.outputs.snowflake-status }}",

View File

@@ -0,0 +1,145 @@
name: E2E Coverage Manifest
# Nightly: builds an instrumented frontend, runs the e2e suite sharded to
# record which source files each spec exercises, and publishes a spec -> files
# manifest used for selective e2e runs on PRs.
#
# Isolated from the PR e2e path on purpose - the per-shard worker
# (e2e-coverage-shard.yml) is a dedicated, trimmed copy so coverage runs can
# never affect PR test results.
on:
schedule:
# Nightly, after the day's merges have settled (UTC).
- cron: "0 7 * * *"
workflow_dispatch:
inputs:
edition:
description: "Edition to instrument"
type: choice
options: ["ee", "oss"]
default: "ee"
concurrency:
group: e2e-coverage-manifest-${{ github.ref }}
cancel-in-progress: true
jobs:
build-instrumented:
name: Build instrumented uberjar
runs-on: ubuntu-22.04
timeout-minutes: 60
env:
MB_EDITION: ${{ inputs.edition || 'ee' }}
INSTRUMENT_COVERAGE: "true"
steps:
- uses: actions/checkout@v6
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
# build.clj forwards INSTRUMENT_COVERAGE to the rspack build, so only the
# bundled FE is instrumented; everything else builds normally.
- name: Build instrumented uberjar
run: ./bin/build.sh
- name: Upload instrumented uberjar
uses: actions/upload-artifact@v7
with:
name: instrumented-uberjar
path: target/uberjar/metabase.jar
retention-days: 1
# Fixed-N sharding — coverage doesn't need the PR matrix-builder's tag/edition
# groups, just an even split of the regular spec set. The shard count lives in
# one place (SHARDS below); the matrix is generated from it.
setup:
name: Build shard matrix
runs-on: ubuntu-22.04
outputs:
matrix: ${{ steps.gen.outputs.matrix }}
count: ${{ steps.gen.outputs.count }}
steps:
- id: gen
env:
SHARDS: 100
run: |
matrix=$(node -e "console.log(JSON.stringify({split_index:[...Array(Number(process.env.SHARDS)).keys()]}))")
echo "matrix=$matrix" >> "$GITHUB_OUTPUT"
echo "count=$SHARDS" >> "$GITHUB_OUTPUT"
shards:
name: Shard
needs: [build-instrumented, setup]
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
uses: ./.github/workflows/e2e-coverage-shard.yml
secrets: inherit
with:
edition: ${{ inputs.edition || 'ee' }}
total_chunks: ${{ fromJson(needs.setup.outputs.count) }}
split_index: ${{ matrix.split_index }}
merge:
name: Merge and publish manifest
needs: shards
if: always()
runs-on: ubuntu-22.04
timeout-minutes: 15
# github-script lists/downloads the previous manifest artifact.
permissions:
actions: read
contents: read
steps:
- uses: actions/checkout@v6
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
# merge-multiple unions every shard's per-spec dir into one tree; the
# per-spec file design means no conflict resolution is needed.
- name: Download all shard coverage
uses: actions/download-artifact@v8
with:
pattern: coverage-shard-*
path: e2e/coverage-manifest-raw
merge-multiple: true
# Backfill source: the newest existing manifest is the previous nightly
# (this run hasn't uploaded yet). build-coverage-manifest.mjs carries over
# any still-existing spec that didn't run today.
- name: Download previous manifest for backfill
id: prev
uses: actions/github-script@v9
with:
script: | # js
const fs = require("fs");
const { owner, repo } = context.repo;
const { data } = await github.rest.actions.listArtifactsForRepo({
owner, repo, name: "spec-file-manifest", per_page: 20,
});
const art = (data.artifacts ?? [])
.filter((a) => !a.expired)
.sort((a, b) => new Date(b.created_at) - new Date(a.created_at))[0];
if (!art) {
console.log("No previous manifest; nothing to backfill.");
return;
}
const dl = await github.rest.actions.downloadArtifact({
owner, repo, artifact_id: art.id, archive_format: "zip",
});
fs.writeFileSync("prev-manifest.zip", Buffer.from(dl.data));
core.setOutput("found", "true");
- name: Unzip previous manifest
if: steps.prev.outputs.found == 'true'
run: unzip -o prev-manifest.zip -d prev-manifest
# GITHUB_SHA (the master commit this nightly built from) is stamped into
# the manifest as `builtAt`, so a PR can later pick the manifest closest
# to its own point in history. See resolve-coverage-manifest.mjs.
- name: Build coverage manifest
env:
PREV_MANIFEST: ${{ steps.prev.outputs.found == 'true' && 'prev-manifest/spec-file-manifest.json' || '' }}
run: node e2e/coverage/build-coverage-manifest.mjs
- name: Upload manifest
uses: actions/upload-artifact@v7
with:
name: spec-file-manifest
path: e2e/coverage/spec-file-manifest.json
retention-days: 30

112
.github/workflows/e2e-coverage-shard.yml vendored Normal file
View File

@@ -0,0 +1,112 @@
name: E2E Coverage Shard
# Reusable per-shard worker for the coverage manifest run. Trimmed extract of
# e2e-test.yml: runs one cypress-split shard against an instrumented build and
# uploads that shard's per-spec coverage. Intentionally omits the PR-only
# concerns (failed-spec retry, Trunk quarantine, S3 result upload, timing
# output) since this is a nightly, non-blocking job.
on:
workflow_call:
inputs:
edition:
type: string
default: ee
total_chunks:
type: number
required: true
split_index:
type: number
required: true
env:
DISPLAY: ""
TERM: xterm
TZ: US/Pacific
INSTRUMENT_COVERAGE: "true"
jobs:
run:
runs-on: ubuntu-22.04
timeout-minutes: 60
name: coverage-shard-${{ inputs.split_index }}
env:
MB_EDITION: ${{ inputs.edition }}
CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}
CYPRESS_MB_STARTER_CLOUD_TOKEN: ${{ secrets.STAGING_MB_STARTER_CLOUD_TOKEN }}
CYPRESS_MB_PRO_CLOUD_TOKEN: ${{ secrets.STAGING_MB_PRO_CLOUD_TOKEN }}
CYPRESS_MB_PRO_SELF_HOSTED_TOKEN: ${{ secrets.STAGING_MB_PRO_SELF_HOSTED_TOKEN }}
steps:
- uses: actions/checkout@v6
with:
submodules: true
token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
- name: Prepare Docker containers
uses: ./.github/actions/e2e-prepare-containers
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
maildev: true
openldap: true
webhook: true
snowplow: true
postgres: true
mysql: true
mongo: true
# The orchestrator built and uploaded this in an earlier job of the same run.
- name: Download instrumented uberjar
uses: actions/download-artifact@v8
with:
name: instrumented-uberjar
path: target/uberjar
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- name: Prepare Cypress environment
id: cypress-prep
uses: ./.github/actions/prepare-cypress
- name: Compile CLJS
run: bun run build-pure:cljs
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
- name: Generate database snapshots
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: node e2e/runner/run_cypress_ci.js snapshot
# cypress-split divides the spec set by timing data; INSTRUMENT_COVERAGE
# makes the support hook drain __coverage__ into e2e/coverage-manifest-raw/.
- name: Run shard ${{ inputs.split_index }}
# No SPLIT_FILE: cypress-split shards evenly by spec count using
# SPLIT/SPLIT_INDEX alone. Omitting it means no timings are read or
# written, which avoids cypress-split's after:run writeback (it would
# otherwise try to overwrite ./e2e/support/timings.json from a cwd where
# that subpath isn't reachable, crashing the run). Even-by-count is fine
# here — every spec runs exactly once across the shards.
env:
SPLIT: ${{ inputs.total_chunks }}
SPLIT_INDEX: ${{ inputs.split_index }}
SPLIT_SUMMARY: false
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: |
node e2e/runner/run_cypress_ci.js e2e \
--expose grepTags="-@mongo+-@python+-@OSS+-@skip"
# Don't let a single failing/flaky spec abort the shard — we still want
# coverage from the specs that did run.
continue-on-error: true
- name: Upload shard coverage
if: always()
uses: actions/upload-artifact@v7
with:
name: coverage-shard-${{ inputs.split_index }}
path: e2e/coverage-manifest-raw/
retention-days: 7
if-no-files-found: warn

View File

@@ -46,7 +46,7 @@ jobs:
const { buildMatrix } = require('${{ github.workspace }}/.github/scripts/build-e2e-matrix.js');
const inputSpecs = "${{ inputs.specs }}";
const inputChunks = Number(process.env.chunks);
const java = 21;
const java = 25;
const defaultRunner = "${{ vars.DEFAULT_RUNNER_KEY }}";
const options = {
java,

View File

@@ -164,9 +164,7 @@ jobs:
node e2e/runner/run_cypress_ci.js e2e \
--expose grepTags="-@mongo+-@python+-@OSS+-@skip" \
--spec "$SPEC_PATH"
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Run Tagged EE Cypress tests on ${{ inputs.name }}
@@ -181,9 +179,7 @@ jobs:
node e2e/runner/run_cypress_ci.js e2e \
--expose grepTags="${{inputs.tags && format('{0}+-@skip', inputs.tags) || '-@mongo+-@python+-@OSS+-@skip'}}" \
--spec "$SPEC_PATH"
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Rewrite JUnit hook failures
@@ -213,21 +209,18 @@ jobs:
variant: e2e-tests
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ inputs.specs && steps.tagged-e2e.outcome || steps.split-e2e.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# Quarantine gate (DEV-2082). Compare this job's ultimate test failures
# (recorded by after:spec into ./target/quarantine-failures.jsonl) against
# ci-conductor's quarantine list and decide whether the job should pass:
# pass if every failure is quarantined, fail if any isn't. This mirrors
# what Trunk's analytics-uploader does for us today. Runs in dry-run mode
# for now (QUARANTINE_DRY_RUN defaults to true) — it only prints the
# verdict and never fails the job. `continue-on-error` is belt-and-braces
# while it's observational; drop both it and the dry run to enforce.
- name: Quarantine gate (dry run)
if: always()
continue-on-error: true
timeout-minutes: 2
shell: bash
run: bun e2e/support/check-quarantine.ts
- name: Quarantine gate
# Only one of the two run steps executes; the other reports `skipped`. Only gate on actual failure.
if: ${{ !cancelled() && (steps.split-e2e.outcome == 'failure' || steps.tagged-e2e.outcome == 'failure') }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: e2e
test-suite: e2e
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: Upload Cypress Artifacts upon failure
uses: actions/upload-artifact@v7

View File

@@ -8,6 +8,12 @@ env:
TERM: xterm
TZ: US/Pacific # to make Node match the instance tz
MB_EDITION: "ee"
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
REPO_ID: ${{ github.event.repository.id }}
COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
TARGET_BRANCH: ${{ github.event.pull_request.base.ref || github.ref_name }}
QUARANTINE_FAILURES_FILE: ${{ github.workspace }}/target/quarantine-failures.jsonl
jobs:
sdk-component-tests:
@@ -19,6 +25,7 @@ jobs:
react-version: [18, 19]
fail-fast: false
env:
CI_CONDUCTOR_TEST_SUITE: embedding-sdk-component-react-${{ matrix.react-version }}
# Sensitive env vars (tokens, secrets) starting with `CYPRESS_` are accessed via async `cy.env()`
# Example: `cy.env(["FOO"]).then(({ FOO }) => ...)`
# For non-sensitive config, use `Cypress.expose()` in cypress config instead (synchronous)
@@ -69,6 +76,8 @@ jobs:
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
- uses: ./.github/actions/resolve-job-id
- name: Make app db snapshot
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
@@ -86,6 +95,8 @@ jobs:
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: node e2e/runner/run_cypress_ci.js component
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Rewrite JUnit hook failures
if: always()
@@ -111,10 +122,21 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: e2e
test-suite: ${{ env.CI_CONDUCTOR_TEST_SUITE }}
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: "SDK component tests > Upload Cypress Artifacts upon failure"
uses: actions/upload-artifact@v7
if: failure()
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
with:
name: cypress-recording-embedding-sdk-react-${{ matrix.react-version }}
path: |
@@ -123,7 +145,7 @@ jobs:
if-no-files-found: ignore
- name: "SDK component tests > Publish Summary"
if: failure()
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
uses: actions/github-script@v9
with:
script: | #js
@@ -168,6 +190,7 @@ jobs:
env:
MB_RUN_MODE: "e2e"
METASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}
CI_CONDUCTOR_TEST_SUITE: embedding-sdk-component-backward-compatibility
# Sensitive env vars (tokens, secrets) starting with `CYPRESS_` are accessed via async `cy.env()`
# Example: `cy.env(["FOO"]).then(({ FOO }) => ...)`
# For non-sensitive config, use `Cypress.expose()` in cypress config instead (synchronous)
@@ -237,6 +260,8 @@ jobs:
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
- uses: ./.github/actions/resolve-job-id
- name: Make app db snapshot
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
@@ -252,6 +277,8 @@ jobs:
run: |
node e2e/runner/run_cypress_ci.js component \
--expose grepTags="-@skip-backward-compatibility"
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Rewrite JUnit hook failures
if: always()
@@ -277,10 +304,21 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: e2e
test-suite: ${{ env.CI_CONDUCTOR_TEST_SUITE }}
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: Upload Cypress Artifacts upon failure
uses: actions/upload-artifact@v7
if: failure()
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
with:
name: cypress-recording-embedding-sdk-cross-version
path: |
@@ -289,7 +327,7 @@ jobs:
if-no-files-found: ignore
- name: Publish Summary
if: failure()
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
uses: actions/github-script@v9
with:
script: | #js

View File

@@ -171,6 +171,8 @@ jobs:
- name: Log free disk space
run: df -h /
- uses: ./.github/actions/resolve-job-id
- name: Run e2e tests for Sample App
id: run-e2e-tests
if: ${{ steps.check-sample-app-branch.outputs.sample_app_branch_exists == 'true' }}
@@ -238,6 +240,8 @@ jobs:
shoppy-datadog-application-id: ${{ secrets.SHOPPY_METABASE_APP_DATADOG_APPLICATION_ID }}
shoppy-datadog-client-token: ${{ secrets.SHOPPY_METABASE_APP_DATADOG_CLIENT_TOKEN }}
- uses: ./.github/actions/resolve-job-id
- name: Run e2e tests for Shoppy
id: run-e2e-tests
if: ${{ steps.shoppy-prep.outputs.sample_app_branch_exists == 'true' }}
@@ -316,6 +320,8 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: ./.github/actions/resolve-job-id
- name: Run synthetic monitoring tests
id: run-e2e-tests
if: ${{ steps.shoppy-prep.outputs.sample_app_branch_exists == 'true' }}
@@ -363,6 +369,19 @@ jobs:
timeout-minutes: 45
name: e2e-host-app-${{ matrix.test_suite }}-tests-${{ matrix.environment }}-bundle
env:
# Host apps are the only suite here running through Metabase's Cypress config,
# whose `after:spec` hook reports failures and writes QUARANTINE_FAILURES_FILE.
# Sample-app suites load their own config (no-op), so ci-conductor is scoped to this job.
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
CI_CONDUCTOR_TEST_SUITE: embedding-sdk-host-app
REPO_ID: ${{ github.event.repository.id }}
COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
TARGET_BRANCH: ${{ github.event.pull_request.base.ref || github.ref_name }}
QUARANTINE_FAILURES_FILE: ${{ github.workspace }}/target/quarantine-failures.jsonl
# `Fail job if tests failed` is the arbiter until ci-conductor takes over.
# Exactly one of the two gates the job.
CI_CONDUCTOR_QUARANTINE_ACTIVE: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}
HOST_APP_ENVIRONMENT: ${{ matrix.environment }}
permissions:
@@ -399,6 +418,8 @@ jobs:
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
- uses: ./.github/actions/resolve-job-id
- name: Generate database snapshots
run: |
node e2e/runner/run_cypress_ci.js snapshot \
@@ -416,14 +437,24 @@ jobs:
- name: Upload Cypress Artifacts upon failure
uses: actions/upload-artifact@v7
if: ${{ steps.run-e2e-tests.outcome != 'success' }}
if: ${{ !cancelled() && steps.run-e2e-tests.outcome == 'failure' }}
with:
name: cypress-recording-host-app-${{ matrix.test_suite }}-${{ matrix.environment }}-latest
path: |
./cypress
if-no-files-found: ignore
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-e2e-tests.outcome == 'failure' }}
continue-on-error: ${{ env.CI_CONDUCTOR_QUARANTINE_ACTIVE != 'true' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: e2e
test-suite: ${{ env.CI_CONDUCTOR_TEST_SUITE }}
enforce-quarantine: ${{ env.CI_CONDUCTOR_QUARANTINE_ACTIVE }}
- name: Fail job if tests failed
if: ${{ steps.run-e2e-tests.outcome != 'success' }}
if: ${{ !cancelled() && steps.run-e2e-tests.outcome == 'failure' && env.CI_CONDUCTOR_QUARANTINE_ACTIVE != 'true' }}
run: |
exit 1

View File

@@ -150,7 +150,7 @@ jobs:
with:
remove-previous-comment: true
add-new-comment: true
message: "⚠️ Embedding SDK bundle size increased by ${{ steps.compare.outputs.size_change_percent }}% compared to the ${{ github.base_ref }} branch (threshold: ${{ env.BUNDLE_SIZE_THRESHOLD_PERCENT }}%). Please contact Embedding team."
message: "⚠️ Embedding SDK chunked bundle size (gzipped) increased by ${{ steps.compare.outputs.size_change_percent }}% compared to the ${{ github.base_ref }} branch (threshold: ${{ env.BUNDLE_SIZE_THRESHOLD_PERCENT }}%). Please contact Embedding team."
include-log: false
- name: Send notification to Slack via Zapier
@@ -165,7 +165,7 @@ jobs:
PR_URL: ${{ github.event.pull_request.html_url }}
run: |
curl -s -X POST "$ZAPIER_WEBHOOK_URL" \
-d "⚠️ Embedding SDK bundle size increased by ${SIZE_CHANGE_PERCENT}% (threshold: ${BUNDLE_SIZE_THRESHOLD_PERCENT}%)
-d "⚠️ Embedding SDK chunked bundle size (gzipped) increased by ${SIZE_CHANGE_PERCENT}% (threshold: ${BUNDLE_SIZE_THRESHOLD_PERCENT}%)
PR #${PR_NUMBER} ${PR_TITLE} (${PR_URL})"
@@ -175,7 +175,7 @@ jobs:
with:
remove-previous-comment: true
add-new-comment: true
message: "🎉 Embedding SDK bundle size decreased by ${{ steps.compare.outputs.size_change_percent }}% compared to the ${{ github.base_ref }} branch. Nice work!"
message: "🎉 Embedding SDK chunked bundle size (gzipped) decreased by ${{ steps.compare.outputs.size_change_percent }}% compared to the ${{ github.base_ref }} branch. Nice work!"
include-log: false
embedding-sdk-tests-result:

View File

@@ -110,21 +110,25 @@ jobs:
- name: Run frontend unit tests
id: fe-tests
run: bun run test-unit --silent --shard=${{ matrix.shard }}/${{ env.SHARDS }}
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Report failed tests to ci-conductor
# Positioned between the test run and "Upload Test Results" so it reads
# pristine JUnit (before Trunk quarantine processing). Gated to non-clean
# runs + continue-on-error so it can never change the job outcome — Trunk
# Quarantine remains the sole arbiter. See DEV-2224 / DEV-2235.
if: ${{ always() && steps.fe-tests.outcome != 'success' }}
if: ${{ !cancelled() && steps.fe-tests.outcome == 'failure' }}
# This step should NEVER fail the job!
continue-on-error: true
uses: ./.github/actions/report-failures-to-ci-conductor
with:
test-suite: fe-tests-unit
adapter: frontend
- name: Quarantine gate
if: ${{ !cancelled() && steps.fe-tests.outcome == 'failure' }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: frontend
test-suite: fe-tests-unit
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always() && github.event_name != 'workflow_dispatch'
@@ -136,6 +140,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.fe-tests.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
fe-tests-timezones:
if: ${{ !inputs.skip }}

View File

@@ -13,6 +13,8 @@ jobs:
steps:
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version-file: 'package.json'
- name: Install dependencies
run: bun install --frozen-lockfile
- name: get module boundary stats

View File

@@ -122,7 +122,7 @@ jobs:
strategy:
matrix:
edition: [oss, ee]
java-version: [21]
java-version: [25]
steps:
- name: Prepare JRE (Java Run-time Environment)
uses: actions/setup-java@v5.2.0

View File

@@ -33,7 +33,7 @@ jobs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.14"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: Prepare build scripts
run: bun install --cwd release --frozen-lockfile && bun run --cwd release build

View File

@@ -39,7 +39,7 @@ jobs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.14"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: prepare dependencies in release directory
run: bun install --cwd release --frozen-lockfile
@@ -58,7 +58,7 @@ jobs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.14"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: prepare dependencies in release directory
run: bun install --cwd release --frozen-lockfile
@@ -77,7 +77,7 @@ jobs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.14"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: Install ci-conductor dependencies
run: bun install --cwd release/ci-conductor --frozen-lockfile
@@ -98,7 +98,7 @@ jobs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.14"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: prepare dependencies in release directory
run: bun install --cwd release --frozen-lockfile

View File

@@ -62,6 +62,7 @@ jobs:
be-changed-files: ${{ steps.changes.outputs.backend_sources_files }}
unit-infra-touched: ${{ steps.changes.outputs.frontend_unit_infra }}
loki-infra-touched: ${{ steps.changes.outputs.frontend_loki_infra }}
e2e-infra-touched: ${{ steps.changes.outputs.e2e_infra }}
shared-sources-touched: ${{ steps.changes.outputs.shared_sources }}
upload-affected-tests-stats:

View File

@@ -34,7 +34,7 @@ jobs:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot_v3/tools/semantic_search_test.clj"]'
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
@@ -61,6 +61,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -72,6 +73,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-mariadb:
if: ${{ !inputs.skip }}
@@ -93,7 +95,7 @@ jobs:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot_v3/tools/semantic_search_test.clj"]'
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
@@ -134,6 +136,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -145,6 +148,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-mysql:
if: ${{ !inputs.skip }}
@@ -166,7 +170,7 @@ jobs:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot_v3/tools/semantic_search_test.clj"]'
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
@@ -207,6 +211,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -218,6 +223,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-postgres:
if: ${{ !inputs.skip }}
@@ -239,7 +245,7 @@ jobs:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot_v3/tools/semantic_search_test.clj"]'
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
@@ -281,6 +287,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -292,6 +299,73 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# pgvector-on-the-app-db mode: the app db itself is a pgvector-capable Postgres and
# MB_PGVECTOR_DB_URL is deliberately unset. The dedicated-harness tests gate themselves off; the
# appdb-pgvector-mode round trip (and the URL-independent unit tests) run for real.
semantic-search-tests-appdb-mode:
if: ${{ !inputs.skip }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
matrix:
version:
- name: pgvector pg17 as app db, no dedicated pgvector
junit-name: semantic-search-tests-appdb-mode-pg17
appdb-image: pgvector/pgvector:pg17
job:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
postgres:
image: ${{ matrix.version.appdb-image }}
ports:
- "5432:5432"
env:
POSTGRES_USER: mb_test
POSTGRES_DB: mb_test
POSTGRES_HOST_AUTH_METHOD: trust
env:
CI: 'true'
MB_DB_TYPE: postgres
MB_DB_PORT: 5432
MB_DB_HOST: localhost
MB_DB_DBNAME: mb_test
MB_DB_USER: mb_test
# opts this job into the destructive appdb-pgvector-mode round trip, which then FAILS (rather
# than silently skipping) if the app db can't actually host pgvector
MB_APPDB_PGVECTOR_MODE_TEST: 'true'
name: "${{ matrix.version.name }} ${{ matrix.job.name }}"
steps:
- uses: actions/checkout@v6
- name: Test ${{ matrix.version.name }}
id: test-driver
uses: ./.github/actions/test-driver
with:
build-static-viz: ${{ matrix.job.build-static-viz }}
junit-name: ${{ matrix.version.junit-name }}
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
with:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-result:
needs:
@@ -299,6 +373,7 @@ jobs:
- semantic-search-tests-mariadb
- semantic-search-tests-mysql
- semantic-search-tests-postgres
- semantic-search-tests-appdb-mode
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
name: semantic-search-tests-result

View File

@@ -32,7 +32,7 @@ jobs:
uses: actions/setup-java@v5.2.0
with:
distribution: temurin
java-version: 21
java-version: 25
- name: Set up Babashka
uses: turtlequeue/setup-babashka@d78ec6570aea3b614bc695cafcceb82eb45c2af9 # v1.8.0
with:

View File

@@ -53,7 +53,7 @@ jobs:
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.14"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
# Snyk doesn't support bun.lock yet, so we generate yarn.lock and scan that.
# Bun has a bug where it normalizes "< 3.0.0" to "< 3" in alias entries

View File

@@ -201,7 +201,7 @@ jobs:
uses: actions/setup-java@v5.2.0
with:
distribution: 'temurin'
java-version: 21
java-version: 25
- name: Retrieve test build uberjar artifact for ${{ matrix.edition }}
uses: ./.github/actions/fetch-artifact

View File

@@ -1,3 +1,15 @@
# .github/workflows/team-issues-slack-notification.yml
#
# Posts newly team-labeled bugs to the team's Slack channel (e.g.
# #team-graphy-bugs), now including a link to the synced Linear issue.
#
# Changes from the current version:
# - Checks out .github/scripts so we can reuse find-linear-issue.js
# - The message-building step now queries Linear (via attachmentsForURL)
# with a short retry, and appends "Linear: <link|ID>" when found
# - Degrades gracefully: if no Linear issue is attached (or the API is
# down), the message posts without the Linear issue link
name: Team Issues Slack Notification
on:
@@ -14,18 +26,58 @@ jobs:
( contains(github.event.issue.labels.*.name, 'Type:Bug') ||
contains(github.event.issue.labels.*.name, 'flaky-test-fix') )
steps:
- name: Setting title
- uses: actions/checkout@v4
with:
sparse-checkout: .github/scripts
- name: Build Slack message (with Linear link if available)
uses: actions/github-script@v9
id: vars
env:
LINEAR_API_KEY: ${{ secrets.LINEAR_API_KEY }}
with:
script: |
core.setOutput('issue_title', JSON.stringify(${{ toJson(github.event.issue.title) }} + '\n' + ${{ toJson(github.event.issue.html_url) }}));
const { findLinearIssue } = require('./.github/scripts/find-linear-issue.js');
const title = context.payload.issue.title;
const issueUrl = context.payload.issue.html_url;
let text = title + '\n' + issueUrl;
// The Linear issue is usually already synced by the time the
// team label lands at triage, but retry briefly just in case.
try {
const delaysSeconds = [0, 15, 30];
let result = null;
for (const delay of delaysSeconds) {
if (delay) await new Promise((r) => setTimeout(r, delay * 1000));
result = await findLinearIssue({
githubIssueUrl: issueUrl,
linearApiKey: process.env.LINEAR_API_KEY,
});
if (result.success) break;
}
if (result && result.success) {
const id = result.issue; // e.g. "GIT-1234"
text += `\nLinear: <https://linear.app/metabase/issue/${id}|${id}>`;
} else {
core.info(`No Linear issue found for ${issueUrl}; posting without link.`);
}
} catch (e) {
// Never block the notification on a Linear lookup failure
core.warning(`Linear lookup failed: ${e.message}`);
}
core.setOutput('message', JSON.stringify(text));
- name: Extracting team name
id: team_name
env:
LABEL_NAME: ${{ github.event.label.name }}
run: |
team_label=$(sed 's/&/\$/g' <<< "$LABEL_NAME")
team_label="${LABEL_NAME//&/$}"
echo "$team_label"
team_name=${team_label#*.Team/}
echo "$team_name"
@@ -55,7 +107,7 @@ jobs:
"type": "section",
"text": {
"type": "mrkdwn",
"text": ${{ steps.vars.outputs.issue_title }}
"text": ${{ steps.vars.outputs.message }}
}
}
]

View File

@@ -128,8 +128,9 @@ jobs:
MB_EDITION: ${{ matrix.edition }}
INTERACTIVE: false
SKIP_LICENSES: ${{ github.event_name == 'pull_request' }} # faster builds for dev
# Emit bundle stats on trunk/release builds so they can be tracked over time
EMIT_BUNDLE_STATS: ${{ (github.ref_name == 'master' || startsWith(github.ref_name, 'release-')) && 'true' || 'false' }}
# Emit bundle stats on trunk/release builds (tracked over time) and on PRs
# (the bundle-size check reads them for both the PR head and its base ref).
EMIT_BUNDLE_STATS: ${{ (github.ref_name == 'master' || startsWith(github.ref_name, 'release-') || github.event_name == 'pull_request') && 'true' || 'false' }}
steps:
- name: Check out the code
uses: actions/checkout@v6
@@ -142,7 +143,7 @@ jobs:
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
with:
java-version: "${{ needs.get-build-requirements.outputs.java_version || 21 }}"
java-version: "${{ needs.get-build-requirements.outputs.java_version || 25 }}"
- name: Build
run: ./bin/build.sh
- name: Upload bundle stats
@@ -173,7 +174,7 @@ jobs:
strategy:
matrix:
edition: ["ee", "oss"]
java-version: [21]
java-version: [25]
steps:
- name: Check out the code
uses: actions/checkout@v6

11
.gitignore vendored
View File

@@ -57,6 +57,16 @@ cypress.env.json
/e2e/tmp/db_dumps/*
!/e2e/tmp/db_dumps/.gitkeep
/e2e/support/assets/example_custom_viz_plugin*.tgz
# Coverage artifacts
/e2e/coverage-manifest-raw
/e2e/coverage-manifest
/e2e/coverage/analysis
/e2e/coverage/spec-file-manifest.json
/e2e/support/.nyc_output
/e2e/support/coverage
/e2e/support/e2e
/.nyc_output
/lein-plugins/*/target
/local
/locales/metabase-*.pot
@@ -194,3 +204,4 @@ __pycache__/
# dependency-cruiser output
dependency-graph.json
.playwright-cli/

Binary file not shown.

Before

Width:  |  Height:  |  Size: 77 KiB

After

Width:  |  Height:  |  Size: 76 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 75 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 75 KiB

After

Width:  |  Height:  |  Size: 75 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 77 KiB

After

Width:  |  Height:  |  Size: 76 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 75 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 76 KiB

After

Width:  |  Height:  |  Size: 75 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 74 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 74 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 76 KiB

After

Width:  |  Height:  |  Size: 75 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 74 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 117 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 15 KiB

After

Width:  |  Height:  |  Size: 16 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 398 KiB

After

Width:  |  Height:  |  Size: 392 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 6.6 KiB

After

Width:  |  Height:  |  Size: 6.7 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 6.9 KiB

After

Width:  |  Height:  |  Size: 7.0 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 7.1 KiB

After

Width:  |  Height:  |  Size: 7.3 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 7.3 KiB

After

Width:  |  Height:  |  Size: 7.4 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 6.8 KiB

After

Width:  |  Height:  |  Size: 6.9 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 6.6 KiB

After

Width:  |  Height:  |  Size: 6.7 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 33 KiB

After

Width:  |  Height:  |  Size: 33 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 185 KiB

After

Width:  |  Height:  |  Size: 185 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 35 KiB

After

Width:  |  Height:  |  Size: 35 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 74 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 33 KiB

After

Width:  |  Height:  |  Size: 33 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 33 KiB

After

Width:  |  Height:  |  Size: 33 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 7.7 KiB

After

Width:  |  Height:  |  Size: 7.7 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 3.1 KiB

After

Width:  |  Height:  |  Size: 3.1 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 3.2 KiB

After

Width:  |  Height:  |  Size: 3.2 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 3.1 KiB

After

Width:  |  Height:  |  Size: 3.1 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 27 KiB

After

Width:  |  Height:  |  Size: 26 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 18 KiB

After

Width:  |  Height:  |  Size: 18 KiB

Some files were not shown because too many files have changed in this diff Show More