Compare commits

...

621 Commits

Author SHA1 Message Date
Nicola Mometto
3ae1585c7e bump 2026-07-17 09:40:23 +01:00
Nicola Mometto
b0b11dca91 test seccomp 2026-07-17 09:39:53 +01:00
Oleh K
8984233763 Align transform job header to fix tab layout shift (#77803)
* Fix layout shift when switching tabs on the transform job page

The job Overview and Run history pages each rendered their own header:
Overview used an editable name input plus a `...` menu, while Run history
used a static title with no menu. The differing heights shifted the tab
row, so the clicked tab jumped when switching between the two.

Extract a shared JobHeader component (and a useJobHeaderState hook for the
readOnly/name-change logic) rendered identically by both pages, mirroring
the MetricHeader pattern. Run history now also shows the `...` menu and the
editable name, and Metabot is consistent across both tabs.

* Unify JobPage header logic with useJobHeaderState

JobPage duplicated the readOnly computation and name-change handler that
now live in useJobHeaderState. Source them from the hook instead; keep the
local useTransformPermissions call only for the page-level loading gate.

* Use strict undefined comparisons in job header code

Address review: job/jobId are never null, so compare with undefined
strictly and derive jobId from job.id in the JobHeader render.
2026-07-17 08:51:59 +02:00
Egor Grushin
8ab2269f04 GDGT-2767 Replace deprecated MaybeLink (#77908)
* Replace deprecated MaybeLink

* refactor
2026-07-17 03:12:48 +01:00
Kevin Kelleher
4385d33640 Fix failing test introduced by #77981 (#78000)
fix test
2026-07-17 01:03:20 +00:00
bryan
64588d02fb test(mfa): auth-mechanism matrix + lockout-corner coverage (#77624) 2026-07-16 22:11:37 +00:00
github-automation-metabase
20b1d51e6b Auto-update documentation for master (#77997)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-16 17:41:49 -04:00
Michael Eby
838d5a7a50 docs: add data isolation content (#77876)
* docs: add data isolation content

* Optimized 4 images, saved 70.0 KB (15.8% smaller)

* Fix links

* Edits from Alex

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-16 16:47:42 -04:00
dpsutton
5fb83b02e7 Fix MCP OAuth consent flow when Metabase is hosted under a subpath (#77765)
Fixes GIT-10551: connecting an MCP client to a Metabase instance served
under a subpath (site-url like https://example.com/metabase behind a
prefix-stripping reverse proxy) failed at the consent step.

The OAuth flow already derives every advertised URL from site-url —
discovery metadata, authorization/token/registration endpoints, and the
WWW-Authenticate resource_metadata header are all subpath-correct. But
three browser-facing pieces assumed Metabase lives at the domain root:

1. The consent form posted to root-relative /oauth/authorize/decision,
   so the browser sent the POST outside the subpath and the proxy
   returned 404 (the reported bug). The form action is now the absolute
   site-url-based URL, via the same absolute-url helper the page already
   uses for the logo. The bundled @font-face URLs on the page get the
   same treatment.

2. The CSRF cookie was scoped to Path=/oauth/authorize. Under a subpath
   the consent page lives at /metabase/oauth/authorize, so the browser
   would never send the cookie back and the decision POST would fail
   CSRF validation even with the form action fixed. The cookie path now
   carries the path component of site-url.

3. The logged-out flow: the backend bounces to the login page with a
   basename-relative redirect target (the server sits behind the
   prefix-stripping proxy and never sees the subpath). The frontend
   guard resolved that target against the bare origin, losing the
   subpath on the full-page redirect back to /oauth/authorize. The
   guard now normalizes targets through the router basename in both
   directions: paths without an explicit origin get the basename joined
   (browser-real href), and pathnames get it stripped (router path, so
   the backend-only-path prefix check still matches).

Why this is safe:

- Root deployments are bit-for-bit unchanged. site-url has no path
  component there, so the cookie path is still /oauth/authorize, the
  form action still targets /oauth/authorize/decision, and with an
  empty basename the guard resolves every input shape (relative path,
  bare path, absolute URL) to exactly the URLs it produced before.
- Under a subpath, the only outputs that change are ones that were
  previously unroutable (404 through the proxy or a path the SPA
  router would double-prefix).
- The server never sees the subpath, so no routes, parameters, or
  validation logic change; every fix is to a browser-visible artifact
  derived from site-url.

Tests pin both halves: existing root-deployment assertions are
untouched and still pass, and new tests cover the subpath form action,
cookie path, login redirect target, and the full consent -> decision
round-trip with a subpath site-url. Also verified live against a local
prefix-stripping Caddy proxy with a real MCP client flow (DCR, consent,
PKCE token exchange, tool calls).

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-16 15:06:24 -05:00
Rodrigo López Dato
31b35fb452 Automatically focus new Key field when adding user attributes (#77715)
* Automatically focus new Key field when adding user attributes

* Only focus new entry if no error
2026-07-16 16:55:13 -03:00
Anderson
f82bdbdd52 Restore table color range saturation for single conditional formatting rules (#77981)
Restore color range saturation for single rules
2026-07-16 16:41:02 -03:00
Alexander Polyankin
2819934fdc Unify image-buffer pool (#77836)
* Rewrite image-buffer pool on dirigiste (same pool as the GraalVM contexts)

Replace the hand-rolled ConcurrentLinkedDeque pool, stats counters, sweeper
daemon, and logging with the dirigiste Pool already used for static-viz
contexts, with the same semantics: 0-3 pooled int[] arrays of the fixed
oversized size, held exclusively per render, idle arrays dropped after ~10
minutes. acquire blocks until an array is free when the requested size fits;
larger requests get a fresh unpooled BufferedImage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Extract the dirigiste pool factory into metabase.util.pool

create-pool was duplicated verbatim between the static-viz graal renderer
(channel.render.js.common) and the sqlglot graal runner (sql-parsing.common),
and image-buffer had just picked up a third use. Move it to metabase.util.pool
and use it from all three; the pool behavior tests move from
sql-parsing.common-test to util.pool-test with it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Add prometheus counters for image-buffer pool usage

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Rename image-buffer metrics to metabase-notification namespace

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-16 15:40:38 -04:00
Timofey Kachalov
ce264b2c85 Update SDK version to 0.64.0-alpha (#77978) 2026-07-16 18:33:44 +00:00
lbrdnk
07f62f33c3 Log suggested prompts generation exception on debug only (#77962)
Log exception on debug only
2026-07-16 18:15:54 +00:00
Andrei Chernykh
adf574b57b Convert Scalar visualization from a class to a function component (#77774) 2026-07-16 11:00:04 -07:00
da
43d61f4514 Update Jetty dependencies to version 12.1.11 (#77860)
https://github.com/jetty/jetty.project/releases

check 12.1.7...12.1.11
2026-07-16 14:08:59 -03:00
Andrei Chernykh
12ce1e67e7 Migrate nav search and search result components from Emotion to Mantine (#77332)
* Migrate nav search and search result components from Emotion to Mantine

* Address review feedback: close button label, valid footer markup, footer role and hover transition

* Restore search dropdown footer ref by returning a ref callback from useListKeyboardNavigation
2026-07-16 17:03:22 +00:00
Rodrigo López Dato
89abda4d66 Browse directly from RCLS settings to saved questions (#77614)
* Browse directly from settings to RCLS saved questions

* Move styles to separate file
2026-07-16 14:02:39 -03:00
Anderson
911fe173f2 Fix margins when printing documents with charts (#74234)
* Improve page/container margins when printing document

* do not call flushSync while printing

* Revert "do not call flushSync while printing"

This reverts commit 37c6fe2b50.

* Resize ECharts synchronously for print layout changes

* Refactor ECharts print resize tests

* Clean up
2026-07-16 13:18:49 -03:00
Ethan McCue
8705016252 Fix gauge breaking in static-viz (#77724)
Fix gauge color crashing

Co-authored-by: Kevin Kelleher <16599994+kevinkelleher12@users.noreply.github.com>
2026-07-16 13:46:56 +00:00
Chris Truter
fc7d1ec13b Make default-source-table-entry deterministic and field-safe (#77725) 2026-07-16 13:09:07 +00:00
da
6108e0182e Accept JWT in the body or in parameters according to the method (#75656)
* Follow up to https://github.com/metabase/metabase/pull/72798#discussion_r3234347346

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeffbruemmer@gmail.com>

* Update docs/people-and-groups/authenticating-with-jwt.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Jeff Bruemmer <jeffbruemmer@gmail.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-07-16 13:01:48 +00:00
Kamil Mielnik
479d7ff67b GDGT-1570 Transform has changes after bluring source table input and still has changes after cancelling them (#77712) 2026-07-16 18:20:13 +07:00
Nicola Mometto
3e6612f075 fix incremental transforms on clickhouse (#77921)
* remove compile-with-inline for clickhouse, no longer needed since the driver got fixed

* re-enable full tests

* fix: for max behavior on clickhouse

* fix: insert for clickhouse

* add temporal reg test
2026-07-16 12:04:46 +01:00
Kamil Mielnik
ce8a99bf08 GDGT-2648 Action menu is too wide when editing a dashboard (#77795) 2026-07-16 17:43:14 +07:00
Nicola Mometto
ed3aa72e65 humanize the alert management error when recipient input is wrong (#77852)
* fix: better human readable validation

* tests
2026-07-16 10:34:25 +00:00
Romeo Van Snick
4081105624 Migrate expression parser and NotebookStepPreview to TypeScript (#77914)
* Generate expression parser as TypeScript

Add --typeScript to lezer-generator so the parser emits typed output; convert lezer.js to lezer.ts.

* Migrate NotebookStepPreview to TypeScript

* Reuse QuestionResultLoaderChildrenProps for VisualizationPreview props
2026-07-16 19:04:36 +10:00
Nicola Mometto
37d96787a1 Better human validation of notification schemas (#77922)
* fix: tighten schema

* 400 rather than 500
2026-07-16 08:57:22 +00:00
Fraser
e823ccc4d7 Move source-location utils to their sole consumer, metabot (#77676) 2026-07-16 20:33:45 +12:00
Romeo Van Snick
4674a3610f Compose route guards as element wrappers (#77686)
* Add element prop support to facade Route

* Compose route guards as element wrappers

* Memoize the element bridge by component type and render off the injected route

* Clarify that index routes accept component or element

* Test that the element bridge reuses shared components across sibling routes
2026-07-16 17:32:12 +10:00
Tyler Plude
1f0d8d6b34 [BOT-1840] Drop visualizer bespoke search index cols (#77684)
* drop temporal dim related search index cols

* revert manual changes to generated docs

* pr feedback; bump up overfetch in visualizer

* rm stale test
2026-07-15 22:02:32 -07:00
Chris Truter
5616e61f7a Allow obsolete semantic search kill-switch (#77903) 2026-07-15 21:58:06 -07:00
Romeo Van Snick
3aa548b966 Migrate DataSelector to TypeScript (#76861)
* Migrate DataSelector SavedEntityPicker to TypeScript

* Align DataSelector picker prop types with actual usage

* Migrate DataSelector to TypeScript and adapt consumers

* Migrate DataSelector unit tests to TypeScript

* Remove unused DataSelector props

* Add TODO for DataSelector api/metabase-lib structural-type cleanup

* Remove unused hasBackButton/onBack from DataSelectorSchemaPicker

* Use setState updater form in setStateWithComputedState

* Guard currentUser instead of faking a zero user id

* Avoid passing a null database to SchemaAndTableDataSelector

* Convert SavedQuestionHeaderButton unit spec to TypeScript

* Justify or remove DataSelector type casts for no-unjustified-type-casts
2026-07-16 14:03:33 +10:00
Timothy S. Dean
cb49c63e0c Better destination-db errors (#77890)
Different endpoints dealing with destination databases handled checks differently, causing confusing error messages depending on code path. This consolidates and standardizes both the messages and the HTTP code.
2026-07-15 20:27:53 -07:00
Romeo Van Snick
99661b47e3 Bundle-size stats: lower record threshold to 0.5% (#77780) 2026-07-16 09:06:44 +10:00
Fraser
98daa6fbf8 Move OnboardingStepper into embedding-hub 2026-07-16 10:19:05 +12:00
Alexander Polyankin
30e4219082 Remove redundant table id from segment and measure API (#77716)
* Remove table_id from measures and segments

* Clear stale Card table_id when the query loses its source table

populate-query-fields only wrote table_id when the derived value was
truthy, so converting an MBQL question to native SQL (or pointing it at
a native model) left table_id referencing the old table. Make it
unconditional, the same fix #68080 applied to source_card_id.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Address review: validate derived table on segment/measure updates

- PUT /api/segment/:id and PUT /api/measure/:id now derive the table from an
  updated definition: table-less definitions are rejected (consistent with
  POST), and if the definition implicitly moves the entity to another table,
  the user must also pass the create permission check for the new table
  (write-check alone only covered the old table).
- Drop the dead :table_id insert arg in POST /api/measure — before-insert
  already derives it from the definition.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Derive segment/measure perms from the definition, not table_id

Per review: instead of API-handler checks against a separately derived table
id, the mi/can-read?, mi/can-write?, and mi/can-create? implementations for
:model/Segment and :model/Measure now derive the source table from the
definition via lib/primary-source-table-id (same admin-or-analyst check as
before, rejecting definitions with no source table), and the API handlers no
longer deal with table ids at all — table_id only remains in what we return
to the client.

Segment definitions are now normalized to MBQL5 at the API boundary (like
measures already were), so the perms and model hooks always see full queries.
Updating a definition re-runs the create check with the new definition, since
the write-check only covers the existing one.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Fix remote-sync segment permission tests for definition-derived perms

The three remote-sync segment tests used empty {} definitions and relied on
table_id/hydrated :table for the permission checks. Perms now derive the
source table from the definition, so give the segments a real MBQL5
definition on the venues table. Also coerce the can-manage helpers to
booleans so callers asserting false? keep working.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Strip stray :aggregation from MBQL4 segment fragments at the API boundary

The model migration always dropped :aggregation from legacy segment
fragments (segments cannot have one). When definition normalization moved to
the API layer, that behavior was lost, so fragments with a stray aggregation
(which several Cypress specs post) started failing schema validation on
insert.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Reject invalid segment definitions instead of stripping :aggregation

Per review: don't silently fix up segment definitions with a stray
:aggregation — validate the normalized definition against the segment schema
at the API boundary and return a 400. Remove the aggregation key from the
Cypress specs that were posting it (it was always dropped by the old model
migration, so those specs never exercised it anyway).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Simplify: keep table_id derivation at the API, revert the perms refactor

Restore the segment/measure permission methods, search filtering, and the
associated tests to their previous table_id-based behavior. The PR keeps to
its core change: the segment/measure APIs no longer accept table_id — it is
derived from the definition and used for the permission checks (including
re-checking the newly derived table when an update moves the entity).

Also update compare-to-the-rest-15655-test for the card change in this PR:
a wrong table_id can no longer be persisted (it is always derived from the
query), so the comparison dashboard for a nil-table card is built from the
field-distribution path now.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Only clear a stale card table_id when the query itself changes

populate-query-fields' unconditional :table_id meant any card update
(rename, archive, collection move) would wipe table_id whenever the
derivation came back nil — e.g. when the query's source card had been
hard-deleted. Gate the nil-overwrite on :dataset_query actually being in
t2/changes; inserts and query edits still clear stale values.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-15 18:01:40 -04:00
github-automation-metabase
eed6ef7980 Auto-update documentation for master (#77899)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-15 18:01:11 -04:00
Timofey Kachalov
b21e9dcba1 Fix lost plural translations for strings that also have a msgctxt (#77700) 2026-07-15 21:11:18 +00:00
Nathan Voxland
8771f8eb73 Persistent queue improvements (#77779)
* Persistent queue: concurrent batches, per-queue error handler, config

Generic improvements to the mq persistent-queue subsystem, extracted from the
explorations work so they can land independently:

- max-concurrent-batches: a queue can process multiple batches in parallel,
  bounded by a (optionally dynamic) limit (metabase.mq.queue.concurrency).
- on-error: per-queue handler invoked when a message exhausts its retries,
  so callers can record terminal failures instead of silently dropping them.
- Reworked polling, quartz scheduling, and registry for the above.
- Expanded mq/README.md and tests (concurrency, on-error, quartz affinity).

* Fix Eastwood reflection warnings on Scheduler.checkExists in quartz-test

`Scheduler.checkExists` is overloaded (JobKey vs TriggerKey), so the un-hinted
`nudge-key` made the three call sites reflective. Import `JobKey` and hint the
local; CI's Eastwood step fails the build on reflection warnings.

* Code fixes
2026-07-15 15:20:33 -05:00
Jeff Bruemmer
e5a9978cac docs - 63 temp workflow (#77722)
* 63 temp workflow

* format
2026-07-15 16:15:48 -04:00
Ben Grabow
039504f1e9 Add linear issue link (#77853) 2026-07-15 15:12:57 -05:00
Andrei Chernykh
09e0cf1718 Migrate remaining ModalContent Emotion styles to Mantine and fix dead EmbedModal header overrides (#77324)
* Migrate remaining ModalContent Emotion styles to Mantine and fix dead EmbedModal header overrides

* Make the modal header back button keyboard-accessible with a descriptive label
2026-07-15 11:14:15 -07:00
Ben Grabow
ba4c6a87c3 Update table-level permissions targeting sample DB to use the correct schema on upgrade (#77843)
Update table-level permissions targeting sample DB to use the correct schema
2026-07-15 12:54:25 -05:00
Alexander Polyankin
1921483a0d Revert data_permissions migration (#77864)
* data_permissions migration fix

* fix
2026-07-15 13:28:16 -04:00
Tyler Plude
0f97c3e87b [BOT-1833] Fix semantic search orphan table cleanup (#77499)
* fix orphan semantic search index table cleanup

* Harden orphan index cleanup: schema-scope the scan, skip views, isolate drops

The orphan scan now only considers base tables (a view in the DROP TABLE
batch would abort every nightly cleanup) and, in dedicated-pgvector mode,
only current_schema() — where the unqualified DROP actually resolves;
previously it scanned all schemas and logged drops that never happened.
Stale/orphan tables are dropped one statement at a time with per-table
error handling so a single undroppable table (e.g. one with a dependent
view) cannot permanently block stale, tombstone, and repair cleanup.

Also anchors index-table-name-pattern (\A/\z) so it stays substring-proof
independent of re-matches, documents that legacy pre-BOT-337
index_table_* names must keep matching, and derives the force-reset test
case from model-table-name/model-table-suffix instead of a literal.

* Count actual index-table drops and reap legacy index_table_ stragglers

drop-index-table! now reports :dropped/:missing/:failed — dropping without
IF EXISTS so a vacuous drop (metadata row whose table is already gone)
does not count — and cleanup logs dropped-of-found. The name pattern
gains an index_table_<anything> alternative: the prefix belongs
exclusively to the pre-BOT-337 era, whose digit-less stragglers were
otherwise unreachable.

---------

Co-authored-by: Chris Truter <chris@metabase.com>
2026-07-15 09:40:46 -07:00
appleby
62cdfb57c2 Do not duplicate user context between system prompt and last user message (#77496)
* Do not duplicate user context between system prompt and last user message

In #71045 we moved most of the user context out of internal.selmer system prompt and injected it into the last user
message. However, other system prompts still injected user context into the system prompt, so we wound up formatting
and including it twice. If the `:user_is_viewing` context happens to be large (many related tables / fields), then the
memory and token cost can be significant (#76493).

This commit removes everything from system prompts that was already being injected into the last user message, namely:

- `current_time`
- `first_day_of_week`
- `current_user_info`
- `viewing_context`

It also moves `recent_views` into the last user message (not previously included there).

In addition to saving input tokens and memory, this should also help with caching on providers like openai that do
automatic prefix caching, since we now always inject the current date/time near the end of the prompt.

This also means all system prompts can drop the `<<<METABOT_CACHE_BREAKPOINT>>>` since they no longer have any dynamic
content after the breakpoint.

* Add :slackbot and :document-generate-content to profiles-excluding-recent-views

Their system prompt never included recent_views, so preserve the behavior now that we inject recent_views in the last
user message.
2026-07-15 16:27:20 +00:00
Maksym Yakubych
ba9e327dd0 fix: metabot ai settings (#77637) 2026-07-15 11:20:54 -05:00
Eric Normand
8706236c94 Add test that workspace isolation init never leaks generated passwords (#77721)
A failed CREATE USER used to surface the generated workspace password
verbatim in the JDBC exception message, which provisioning then logged
(GHY-3660). Scrubbing landed in #74657; this adds a regression test that
reproduces the failure for real: init-workspace-isolation! runs over a
connection authenticated as a low-privilege workspace user (granted
database-level CREATE on postgres/redshift so execution reaches the
password-bearing CREATE USER), and every piece of text a logger could
print from the thrown exception - stack trace, Throwable->map, causes,
suppressed, ex-data, and SQLException nextException links - must not
contain the password. A postgres-only assertion requires the redaction
marker in the echoed statement so the test cannot pass vacuously.
2026-07-15 10:18:13 -06:00
Ben Grabow
5598559520 Disable unsupported actions on driver change (#77838) 2026-07-15 11:04:16 -05:00
Ben Grabow
8d47578032 Compile transforms with nested union all layer to prevent inheriting IDENTITY property (#77539)
* Compile transforms with nested union all layer to prevent inheriting IDENTITY property
2026-07-15 10:35:01 -05:00
Timofey Kachalov
7cc5a515f1 Update log4j-* versions (#77808) 2026-07-15 19:10:30 +04:00
Alexander Polyankin
bf028c04dd Treat a blank MB_CONFIG_FILE_PATH as unset (#77821)
JDK 25 changed the empty file path to resolve to the current directory
(File("").exists() is now true), so a long-standing MB_CONFIG_FILE_PATH=''
made the config-from-file loader try to parse the current directory as YAML
and fail at boot. Ignore blank values like metabase.config.core/config-str
does everywhere else, and don't count them as config-text-file being enabled
in anonymous stats.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-15 10:19:28 -04:00
Benoit Vinay
b2d652c6ab Search MB documentation link incorrectly has underline on hover (#77701)
Fix for underline
2026-07-15 16:12:23 +02:00
Sébastien
e29d97eb9e Fill available space in the dashboard new-question query builder (#77270) 2026-07-15 15:56:53 +02:00
Kamil Mielnik
83215dcacd GDGT-2400 Custom viz plugin can overflow its own container (#77695) 2026-07-15 13:44:06 +00:00
Kamil Mielnik
f0a65273fb GDGT-2649 New action modal has redundant vertical scrollbar (#77809) 2026-07-15 13:35:42 +00:00
Egor Grushin
0d59548a1e Gdgt 2586 replace deprecated loadingspinner component (#77638)
* initial migration

* initial migration

* remove deadcode loaders

* one more site is migrated. remove dead code

* make data-testid="loading-indicator" to be by default for Loader component

* fix unit test
2026-07-15 14:11:08 +01:00
github-automation-metabase
16a8399a5c Auto-update documentation for master (#77760)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-15 09:10:37 -04:00
Nicola Mometto
45940c8ff1 fix: index manager driver added metabdata (#77807) 2026-07-15 12:35:34 +00:00
Kevin Kelleher
88474b9d2a Fix type error introduced by #77131 (#77817)
fix type error
2026-07-15 12:19:52 +00:00
Oleh K
bb8b550a21 Omit negative values from treemap instead of producing wrong percentages (#77601)
* Omit negative values from treemap instead of producing wrong percentages

Treemaps summed metric values as signed totals and divided by that signed
total, so rows of 30 and -50 rendered a surviving leaf as -150%. Negative
tiles also have no positive area, so ECharts dropped them with no warning.

Mirror the pie chart: omit negative values (with a warning) during
aggregation, or fall back to absolute values when every value is negative.
With all node values non-negative the downstream percentage math is correct.

Fixes GDGT-2760

* Tighten null check and document per-row negative filtering
2026-07-15 13:57:05 +02:00
Alexander Polyankin
373b755b50 Bump mise JDK and docs to temurin 25 to match CI (#77769)
* Bump mise JDK to temurin 25 to match CI

CI defaults to Java 25 (.github/actions/prepare-backend and the backend
workflow matrix), but mise.toml still pinned temurin 21.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Update remaining Java 21 leftovers to 25

The e2e matrix builder and docs still referenced JDK 21, while CI,
Docker images, and release requirements for v60+ are on Java 25.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-15 07:50:30 -04:00
Kevin Kelleher
03a8afdba8 Truncate categorical axis labels rather than not showing them (#77131)
* truncate categorical axis labels

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-15 07:30:44 -04:00
Ngoc Khuat
aaa84da26f Move index manager driver changelog entry to 0.64.0 (#77710)
move index manager driver changelog entry from 0.63.0 to 0.64.0
2026-07-15 09:27:36 +00:00
Arik Aronov
611ef3690b Set enablePutGet as a Snowflake connection property (#77731)
* assoc in connection-details->spec

* Drop unused empty? refer

* fix in check-manager-of-group function name
2026-07-15 12:05:23 +03:00
github-automation-metabase
559301b57b Fix flaky MBQL to SQL transform conversion e2e test (#77699)
* Pin MBQL transform source schema in transforms e2e spec

The many_schemas Postgres fixture creates an "Animals" table in every
schema (Schema A through Schema Z). createMbqlTransform resolved its
source table via getTableId by name only, so Array.find returned an
arbitrary schema's "Animals" depending on /api/table ordering. The
"convert an MBQL transform to a SQL transform" test asserts the compiled
SQL contains "Schema A", so a non-Schema-A match made it flake.

Add an optional sourceSchema to createMbqlTransform and pin the spec's
source to Schema A so the resolved table and its SQL are deterministic.

* Wait for MBQL->SQL transform save to settle before clicking Run tab

The Run tab only exists in read-only view mode; after clicking Save the
test must wait for the update PUT and the navigation off /edit, otherwise
it races the still-in-flight save and times out looking for the Run tab.

* only pin source schema for the default source table

---------

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
2026-07-15 15:21:14 +07:00
Romeo Van Snick
803f470a7c Replace IndexRoute/IndexRedirect/Redirect with index routes and Navigate (#77591)
* Add index-route support and redirect() to the metabase/router facade

* Adapt ModalRoute and DataPermissionsPage to the function-based Route

* Replace IndexRoute/IndexRedirect/Redirect with index routes and redirect()

* Convert createEntityIdRedirect to a facade-hook wrapper component

* Update route test scaffolding for index routes and redirect()

* Build the Route shim via createRoutes instead of augmenting RouteUtils

* Point the guards spec at the relocated Route export

* Stabilize transforms permission navigation in e2e specs

* Freeze redirect() target at mount to fix chained index-redirect race

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
2026-07-15 14:43:41 +10:00
Alexander Polyankin
cb41874c74 Revert "Bound concurrent query-cache writes" (#77781)
Revert "Bound concurrent query-cache writes (#77738)"

This reverts commit a77339d049.
2026-07-14 23:36:46 -04:00
Alexander Polyankin
1a8a17229a Don't GZIP sync-flush per object when serializing QP cache entries (#77786)
* Don't GZIP sync-flush per object when serializing QP cache entries

Sync-flushing after every cached row meant one native Deflater call in a
JNI critical region per row; on JDK <= 21 (no G1 region pinning, JEP 423)
that stalls GC via the GCLocker under concurrent cache writes. Let the
deflater buffer normally instead, and have result-fn finish the stream
(draining the deflater and writing the GZIP trailer) before returning the
bytes. Old cache entries (unterminated gzip) still deserialize since the
reader already treats EOFException as end-of-stream.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Don't flush the JSON download writer per row

Each per-row flush cascaded into a sync-flush of the gzipped HTTP response:
one native Deflater call in a JNI critical region per exported row (GCLocker
stalls on JDK <= 21) plus one TCP packet per row (#34795, fixed for the :api
writer but not :json downloads) and a worse compression ratio. Let the
BufferedWriter push rows through as it fills, like the CSV writer does;
finish! still flushes the tail.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-14 23:32:58 -04:00
Romeo Van Snick
972c96b58d Convert modal routes to a modalRoute factory and delete getParentPath (#77372)
* Resolve relative navigation in the router facade's useNavigate

* Add modalRoute factory for modals declared as child routes

* Convert modal routes to the modalRoute factory and delete getParentPath

* Keep navigate's identity stable when v3 rebuilds the matched routes

* Measure matched route pathnames with v3's matchPattern

* Address review: splat note and test, parsePath docstring grammar
2026-07-15 11:36:35 +10:00
Alexander Polyankin
4c9497c75c Add missing FKs (#77713) 2026-07-14 21:16:40 -04:00
technomancy
4e5bb2daa8 Isolate snowflake DB names in CI aggressively (#77669)
Make Snowflake CI runs use a randomly-generated, isolated DB names.

Something is still randomly calling `destroy-db!` on the test-data
dataset and wrecking things for CI runs:

```
(pprint (jdbc/query (no-db-connection-spec)
                    ["SELECT query_text, end_time
                        FROM SNOWFLAKE.ACCOUNT_USAGE.QUERY_HISTORY
                       WHERE query_text LIKE '%_c1bae%'
                         AND (query_text LIKE '%DROP%' OR query_text LIKE '%drop%')
                       ORDER BY end_time DESC limit 128"]))
[...]
"DROP DATABASE \"sha_rel_c1baee7db240aa419104c2d925a07a4d4faeeb24_test-data\";"
```

This particular query (without `IF EXISTS`) only exists on master in
the `destroy-db!` method. However, this method already has protection
against being run on the `test-data` dataset and will throw an
exception if this is tried! And the main call to `destroy-db!` is
gated behind a feature check for `:test/dynamic-dataset-loading`. So
there's nowhere this could be coming from on master.

Rather than trying to track it down, I think it's better to just treat
all snowflake DBs as isolated and disposable. Update `qualified-db-name`
to just prefix the DB name with a random prefix, and use the
`after-run` hook to drop it when done. This also allows us to get rid
of the janky and weird locking system, because no two jobs should ever
try to hit the same DB.
2026-07-14 21:05:52 -04:00
Alexander Polyankin
9cd10f877b Always include inactive tables in dependencies API responses (#77714) 2026-07-14 20:00:12 -04:00
Egor Grushin
9a5a4e2587 GDGT-2833 Add per-version download link to Security Center advisories (#77677)
* Add per-version download link to Security Center advisories

Thread optional download_jar_url through backend schema/fetch and render
a Download link next to each fixed version in AdvisoryCard.

* fix aligning

* Read instance version via useSetting; simplify affected-version lookup

* rollback a redundant change

* addressing PRs comments

* use sequence to nil-coerce download_jar_urls

* addressing the PR's comments

* add download-click analytics

* fix test: add download_jar_urls to Advisory factory

* add e2e test
2026-07-15 00:13:03 +01:00
Egor Grushin
7b3ed42a61 GDGT-2585 Replace deprecated Input component (#77559)
* initial migration

* fix link input size

* remove dead files

* Use Input.ClearButton for textinput clear icon

Replace hand-rolled Tooltip+ActionIcon+Icon clear pattern w/ Mantine
Input.ClearButton across 5 sites; c=text-secondary + rightSectionPointerEvents=all.
Comment why LinkViz needs pointer-events on both root+input.

* fix unit test

* Update loki refs for parameter search Input->TextInput

* Use Input.ClearButton in PermissionsEditorContent; rm blank line in SearchBar styled

* addressing the PR's comments
2026-07-14 22:49:55 +01:00
Sloan Sparger
bf26412ac5 [Metabot] Backend driven conversation state (#76939)
* validate client sent parent_message_id

* implement more restrictive retry logic

* move history to the backend

* migate state from conversation to message records

* client nows generates message ids to shrink case of client not knowing id of written message record on aborted requests

* pr feedback

* [Metabot] Implement conversation branches in usage analytics (#77542)

* implement branches in usage analtyics

* sol pass at making code terser / cleaner

* handle error messages correctly + allow branching after assistant message

* pr feedback

* fix test failures

* remove migration logicalFilePath
2026-07-14 16:22:06 -05:00
Egor Grushin
12835e1889 GDGT-2580 Replace deprecated FormErrorMessage component (#77497)
* initial migration

* initial migration

* Fix WritebackParameter missing name/slug in scaffold
2026-07-14 22:09:33 +01:00
Chris Truter
d65b0f5661 Remove the semantic search kill switch (#77570) 2026-07-14 20:51:41 +00:00
Alexander Polyankin
a77339d049 Bound concurrent query-cache writes (#77738) 2026-07-14 16:16:11 -04:00
Alexander Polyankin
fcd561b654 Replace timeout-prone permissions-collapse migration with aggregate-first query (#77727) 2026-07-14 15:39:15 -04:00
Alexander Polyankin
d3a8d67430 Skip static-viz bundle size budget in dev builds (#77741)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-14 15:06:17 -04:00
Chris Vandoodewaard
bd6c7a3ef6 Lint Github Actions Workflows with actionlint (#77698)
* add actionlint workflow

* install actionlint with mage

* pass flags to actionlint

* fix options

* don't use mage

* install actionlint locally with mise, update workflow to use install script
2026-07-14 14:43:38 -04:00
Alexander Polyankin
973bddf906 Bump Docker runtime images to Temurin 25 JRE (#77730) 2026-07-14 13:40:54 -04:00
Nick Fitzpatrick
ace59d6c1c Show all connected parameters when setting up a subscription (#77626) 2026-07-14 21:40:27 +05:30
Eric Normand
5246357b5c Gate write share actions (embed publish, public link) on write access (#72752, GHY-3814) (#77528)
* Hide write-only share actions when entity is not writable (#72752)

The Question and Dashboard sharing menus, and the public-link popover,
offered write actions to any admin regardless of write access. On a
read-only remote-synced instance a card/dashboard in a synced collection
is not writable (can_write=false), so these actions 403'd or authored
state that doesn't stick — the "updating embed fails on read-only
instance" symptom in #72752.

Gate the write actions on can_write, matching how the normal edit
affordances already disappear when the entity can't be written:
- Embed (publish): hidden when not writable.
- Create a public link: hidden when not writable; an existing public link
  stays visible so it can still be viewed/copied (those are reads).
- Remove public link: hidden when not writable.

* Disable embed Publish instead of hiding the option on read-only entities (#72752)

Keep the Embed sharing option visible for a read-only remote-synced
card/dashboard, but disable the Publish/Unpublish buttons in the embed
modal with a tooltip explaining the entity is synced and read-only.
This reverts the earlier hiding of the Embed menu item; the public-link
gating (hide create / remove, keep an existing link viewable) is
unchanged.

* Translate the read-only embed tooltip per resource type (#72752)

Interpolating resourceType left the noun untranslated and prevented the
rest of the sentence from agreeing with its gender.
2026-07-14 10:57:58 -05:00
Mihael Konjević
2ca895407f Bot 1729 eval tracing (#77169)
* Add ai-tracing: eval-time trace capture for the Metabot agent

Introduce a new `ai-tracing` module that captures complete, per-run agent
traces during benchmark/eval runs and exports them to an external eval
backend (Confident AI) over OTLP — separate from production observability.

- Capture is gated by a per-run dynamic binding (`*capture*`), orthogonal to
  MB_TRACING_*, so it never fires on organic traffic. Enabled via the
  env-only MB_AI_EVAL_CAPTURE setting; the API path emits the trace as an
  `eval_trace` data part and exports it.
- Captures the full agent.turn -> llm.call -> tool.* tree with prompts,
  completions, tool args/results, durations, and concurrent-tool nesting
  (conveyed across the agent's virtual threads).
- OTLP export uses a dedicated TracerProvider (SimpleSpanProcessor +
  force-flush, never the production one), replaying the in-memory tree
  post-hoc. The domain -> Confident `confident.*` semconv mapping lives in a
  single chokepoint (`node->semconv-attrs`); vendor/schema swaps are one edit.
- Wires capture into run-agent-loop, loop-step, call-llm, and run-tool.
- Trace-level input/output (user question + final answer) set on the root.
- Export failures are logged loudly instead of swallowed.
- Tests cover the gate, nesting, enrichment, timing, concurrency, the
  semconv mapping, and a metadata-size regression guard.

* Make ai-tracing export more idiomatic; refresh stale docs

- export.clj: replace node->semconv-attrs's nested cond-> of repeated
  type checks + json/encode with :ai/keys destructuring and a flat
  medley/assoc-some table; compose final-llm-output as transducers;
  extract event->attributes; tidy parse-headers (for-comprehension),
  build-provider! (doto), and ensure-provider! (fresh? helper).
- core.clj: drop the stale "seam not wired" comment block and the
  outdated ns docstring (it referenced the abandoned gen_ai/OpenInference
  schema and "single namespace" framing); describe the shipped export.

No behavior change; 14 tests / 56 assertions still pass.

* Replace ai-tracing OTLP export with per-session JSONL log files

Switch the eval-trace collection method from OpenTelemetry/OTLP export to a
dedicated file-based logger, and extend instrumentation to the MCP server and
agent-api in addition to the Metabot agent loop.

- Rip out all OTLP/Confident code (export.clj, the OTLP settings, the OTel
  provider/semconv mapping, the eval_trace SSE part).
- New metabase.ai-tracing.log sink: each span streams one JSON line on a
  dedicated logger, routed per session to its own <session-id>.jsonl by a
  Log4j2 RoutingAppender keyed on mb-eval-session-id. Pure JSONL (%m%n), full
  payloads, no size limits.
- Session model = OTel trace-id analog: *session-id* minted at a fresh
  capture's root, or supplied by the caller, conveyed across virtual threads
  by bound-fn*. Nodes carry :id/:parent-id for tree reconstruction.
- Generic with-eval-session entrypoint (gated by MB_AI_EVAL_CAPTURE, inherits
  when nested) reused by run-agent-loop, MCP dispatch-request (keyed on the
  Mcp-Session-Id so a conversation lands in one file), and agent-api routes.
- MB_AI_EVAL_CAPTURE is the single on/off switch; the logger sits at info and
  writes nothing unless a capture is active.
- run-agent-loop emits a tiny eval_session SSE part so the HTTP harness can
  locate the session file.

Verified end-to-end: real agent run writes a per-session JSONL file with the
correct span tree (parent chain, full structured + normal tool output);
sessions route to separate files. 14 tests / 51 assertions pass.

* ai-tracing: capture full request/response context and add trace read API

Enrich eval spans so a captured trace is a self-contained record of a run:

- agent-api: record HTTP request body, user id, and the response status/body
  via a wrapping respond fn that fires inside the span.
- mcp: record JSON-RPC params, user id, scopes, and the materialized result.
- metabot agent: thread an optional eval-session-id through run-agent-loop so
  the harness can name and read back the per-session trace file; record the
  full request (messages/context/state), turn-level token usage, finish reason,
  and final agent state (link registry / generated entities). Surface the loop
  finish-reason out of loop-step instead of only logging it.
- log: guard span serialization so a non-encodable attribute can never break a
  traced run.

Add metabase.ai-tracing.api: a superuser-only GET /api/eval-trace/:session-id
that returns the captured JSONL, mounted only when MB_AI_EVAL_CAPTURE is on.
Filenames are validated against path traversal. Wire the module into routes and
the kondo module config.

* ai-tracing: preserve OpenAPI spec on agent-api routes; harden trace sink

The eval-tracing wrapper turned agent-api `routes` into a plain fn, which no
longer implemented OpenAPISpec — full-API spec generation (openapi.json,
endpoint-dox, the openapi-all-routes test) threw when the walk reached
/api/agent. Wrap it in `handler-with-open-api-spec`, delegating the spec to the
underlying ns-handler.

Also: narrow the trace-sink catch to Exception so Errors/InterruptedException
propagate; stream the trace file instead of slurping it into heap; and correct
the "single nil-check" docstring claim.

* ai-tracing: validate eval-session-id at mint time to prevent path traversal

The trace read endpoint sanitized the session-id before touching disk, but the
write path fed the raw, caller-supplied eval_session_id straight into the
RoutingAppender's `<session-id>.jsonl` file name — a value like `../../foo` on
an eval instance escaped the trace dir (arbitrary .jsonl write).

Hoist the safety regex to a single `safe-session-id-re` in ai-tracing.core and
add `checked-session-id`, which mints a uuid when none is supplied and throws on
an unsafe supplied id. `with-eval-session` now validates every caller-supplied
id before it can reach the log-file path; ai-tracing.api references the shared
regex so read/write validation can't drift.

* ai-tracing: gate span-macro arg construction on capture-active?

The span macros expanded to an eval-span* call, so span-name and attrs
were built on every invocation and discarded on the nil-check when no
capture was live. Hoist the capture-active? guard into a `spanning`
helper macro (and an inlined variant in with-tool-call, whose name
derives from attrs) so organic traffic never builds the span name string
or attrs map — it pays only the *capture* nil-check plus one thunk
closure. with-tool-call now evaluates attrs exactly once, and only when
capturing.

* ai-tracing: test cross-module span nesting; make agent tests capture-agnostic

Add eval-tracing-nesting-test: drives the real run-agent-loop under
capture-reducible with only the LLM + search backend mocked, and asserts
the emitted span tree nests agent.turn -> llm.call -> tool.search. This
covers the wiring the ai-tracing docstrings promise — the turn/llm spans
opened in metabot.agent.core, the tool span in metabot.self.core, and
*parent* conveyed across bound-fn* into the virtual-thread tool executor
— which the ai-tracing unit tests exercised only at the primitive level.

Also pin eval-capture off for the namespace via a fixture. run-agent-loop
appends an eval_session data part to the stream whenever capture is active,
so every exact-match assertion on its output broke under MB_AI_EVAL_CAPTURE
(which dedicated eval instances set). The fixture keeps those assertions on
the production stream shape; the new test forces capture independently.

* ai-tracing: key MCP eval session on UUID correlator; complete finish-reason

Key the MCP eval-trace session on the session id's UUID prefix rather than
the full <uuid>.<base64> id: the prefix is stable across the conversation and
always filesystem/URL-safe, so a base64 payload that require-valid-session
accepts but safe-session-id-re rejects (e.g. `=` padding) can no longer make
checked-session-id throw ahead of the JSON-RPC try/catch and 500 the request.

Record :finish-reason on the empty-response and reduced (early-termination)
loop terminations too, so the turn span's :ai/finish-reason is populated on
every path, not just natural completion.

* ai-tracing: harden trace sink serialization and error capture

- emit!: fall back to a JSON-safe copy when an attribute value isn't
  encodable, so one bad value no longer drops the span (and, for a root
  span, orphans its children).
- span error events now carry the exception class and ex-data, not just
  the message.
- rename JSONL :start-ns/:end-ns to :start-epoch-ns/:end-epoch-ns (they
  hold wall-clock epoch nanos, not System/nanoTime).
- test the api trace-file path-traversal guard directly.

* ai-tracing: bound session ids, gate user-input build, snapshot finish-node

- Cap supplied eval-session-id at 200 chars on the API schemas and in
  checked-session-id, so a supplied id can't produce a filename that fails
  creation and silently drops the trace (charset was already enforced).
- Compute the turn span's :ai/user-input inside the capture-gated attrs map
  instead of unconditionally on every run-agent-loop call.
- finish-node takes a single consistent snapshot of the node atom.

* ai-tracing: enforce session-id cap+charset at API boundaries

Route the 200-char cap through ait/max-session-id-length everywhere (read
endpoint, run-agent-loop opts, POST /api/metabot params) instead of
hardcoding the literal, and bound the previously-unbounded read-endpoint
:session-id path segment.

Validate the charset via safe-session-id-re in the Malli schemas so a bad
eval-session-id 400s at the boundary rather than throwing deep in
checked-session-id and surfacing as a generic agent error. Anchor
safe-session-id-re with \A/\z so it stays exact under both re-matches (mint/
read checks) and re-find (Malli :re) — unanchored, :re accepted any string
containing a safe run (e.g. ../../etc/passwd).

* ai-tracing: key MCP eval trace on a harness-supplied session id

Let an eval harness name and later fetch an MCP conversation's trace. The MCP
endpoint honors an `x-eval-session-id` header — `dispatch-request` keys
`with-eval-session` on it (validated through `checked-session-id`, the single
source of truth for the safe-id contract), falling back to the `Mcp-Session-Id`
correlator when absent. This is the MCP analogue of metabot's `eval_session_id`,
needed because the client owns the `Mcp-Session-Id` and never exposes it.

Also record the resolved query on the construct-query endpoints as `ai/query`
(inert unless capturing): the MCP `construct_query` tool returns only an opaque
handle, so this is the only place a harness can recover the agent's query off
the trace to grade it.

* ai-tracing: address review — guard :reduced append, cover the read API

- run-agent-loop: on a :reduced stop (client disconnect / cancellation) the
  reducing fn has already terminated, so don't step it again to append the
  eval-session pointer or debug part — that violates the transducer contract.
  Fold both trailing appends into one capture-gated cond-> that no-ops on
  :reduced (also fixes the latent debug-branch case). The harness reads the
  JSONL file, not the stream, so a skipped pointer on disconnect costs nothing.
- agent-api: record :http/user-id in the respond closure, where +auth has bound
  *current-user-id* — it is unbound when the span opens, so direct HTTP callers
  previously recorded nil.
- ai-tracing.api: add endpoint integration tests — capture-gated 404,
  superuser-gated 403, missing-trace 404, and existing-trace 200.
- log: mark node->entry ^:private; document that trace-file retention is the
  operator's responsibility (append-only, no rollover, re-runs accumulate).
- mcp: extract the dispatch lambda (line length) and note the fresh-file-per-
  request fallback when neither session id is present. Mark pure tests ^:parallel.

* ai-tracing: drop dead exports, document capture id, harden json-safe

- Remove the `sanitize-sql` re-export and `event!`: neither has a
  non-test caller. Dropping `sanitize-sql` also removes ai-tracing's only
  dependency on the `tracing` module (trimmed from `:uses`). The sites that
  put a query in a span record the raw value on purpose (a scorer wants the
  real SQL/MBQL), so the sanitizer was advertising an inconsistency the
  design doesn't want.
- Document that `capturing`/`capture-reducible` is return-value-based: a
  session id supplied to an inner `with-eval-session` is ignored because
  capture is already active, so no `<id>.jsonl` is written on that path.
- `json-safe` now stringifies non-scalar map keys too, so the fallback can
  never itself throw and orphan the root span it exists to save. Covered by
  a vector-keyed-map regression test.

* ai-tracing: address review — gate pointers, bound json-safe, drop indirection

Correctness:
- capturing/capture-reducible no longer mint a session id, so the in-process
  path is truly file-less (read :trace) instead of writing a stray <uuid>.jsonl
- gate the trailing eval_session pointer on a non-nil *session-id* so the
  file-less path doesn't emit a pointer to a <nil>.jsonl
- add *retain-tree* so the in-memory span tree is only built when a caller
  reads it back (capturing); the file-routed path no longer pins heap for the
  whole run
- depth-bound json-safe so a deep/cyclic attr degrades to a string instead of a
  StackOverflowError escaping emit!'s catch
- agent-api trace wrapper: only record a plain-data :http/response (skip a
  streaming/opaque body rather than stringifying it); fix the stale comment

Cleanup:
- drop the eval-capture-enabled? indirection; entrypoints and tests consult the
  ai-eval-capture setting directly
- with-eval-session: inline supplied-id, ^:once, generic 404 gate message
- extract mcp dispatch-method to de-nest the JSON-RPC case
- remove the dead ai-tracing.core/event! kondo entry
- keep eval JSONL spans out of the shared test log (log4j2-test.xml)

Tests: cover the agent-api trace wrapper, the file-less no-pointer/no-file
behaviour, and drive the log-sink assertions through with-eval-session.

* ai-tracing: fix route sort order and wire settings through init

Two structural test failures on the branch:

- Move the `/eval-trace` route into sorted position in the route-map
  (keep-routes-sorted-test reads the file and asserts the keys are sorted).
- Add `metabase.ai-tracing.init` (requiring the settings ns), require it from
  `metabase.core.init`, and add it to the module's `:api` — so
  settings-namespaces-should-be-required-by-init-namespaces-test passes and the
  `MB_AI_EVAL_CAPTURE` setting is registered deterministically at startup rather
  than only when some instrumented namespace happens to load `ai-tracing.core`.

* ai-tracing: store span wall-clock timestamps as epoch millis, not nanos

Review: the epoch fields were nanos synthesized from currentTimeMillis (ms-
granular anyway), and precise sub-ms duration already lives in :dur-ms — so nanos
bought nothing. Rename :start-epoch-nanos/:end-epoch-nanos → :start-epoch-ms/
:end-epoch-ms (and the JSONL keys :start-epoch-ns/:end-epoch-ns → :start-epoch-ms/
:end-epoch-ms). End is still start + the monotonic duration (rounded to ms), so it
never reads a second, possibly backward-jumping wall clock.
2026-07-14 17:30:50 +02:00
Nick Fitzpatrick
85485ed925 Fix flaky bulk-move dashboard-questions e2e test (#76165)
visitDashboard waits on every dashcard query with cy.wait's default 5s
per-alias window; with 20+ cards the tail queries stagger behind the HTTP/1
concurrency limit and miss it (the dashcardQuery### "no request occurred"
flake). Add a dashcardTimeout option to visitDashboard and use it for the
large-dashboard visits in this test, so the downstream card assertions can
stay at their default timeouts. Also give the 20-request bulk move a longer
window, since its tail lags under CPU constraint.
2026-07-14 20:54:53 +05:30
github-automation-metabase
8d3584593a Auto-update documentation for master (#77657)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-14 10:09:10 -04:00
Kamil Mielnik
6547e398ee GDGT-2748 Broken Security Center layout in error state (#77704) 2026-07-14 20:39:51 +07:00
Chris Vandoodewaard
a6b0d2c7d6 Clean up stale step condition in backend.yml (#77605)
* remove dead condition, update to match other checks

* just use always
2026-07-14 09:08:06 -04:00
Chris Truter
4d04a9743c MCP notes on archiving questions and dashboards (#77569) 2026-07-14 14:34:05 +02:00
Nemanja Glumac
7712c474dd Run master's ci-conductor sources on release branches (#77625)
The ci-conductor scripts are shared CI infrastructure: every supported
release branch runs them, and they keep evolving on master. A copy
committed to a branch goes stale, and syncing six branches by hand on
every change does not scale.

Add a prepare-ci-conductor action that overlays release/ci-conductor and
e2e/support/ci_conductor.ts from master, so a release branch runs the
current scripts while its workflow wiring stays branch-historical.
Anything headed for master uses its own sources, so a PR can still test
its own changes.

quarantine-gate and report-failures-to-ci-conductor delegate their bun
setup to it. prepare-cypress calls it too, because e2e/support/config.js
imports the reporter at Cypress bundle time and it has to be in place
before the run starts.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-14 14:32:43 +02:00
metamben
dbedcbfbd4 Grouping set pivot (#76560)
* Implement schema, lib helpers, viz-settings + query -> query

* Implement grouping-set compilation

* Implement query nesting to support breakouts with parameters

For example, when selecting nested JSON fields in postgres,
the generated SQL query contains prepared query parameter
placeholders and the engine cannot determine that all copies
are the same expression.
2026-07-14 11:05:24 +00:00
Alexander Polyankin
25eebabf11 2FA E2E tests (#77671)
* 2fa e2e

* tests
2026-07-14 06:40:21 -04:00
Timur Mashara
30daa26a7b GRO-554 update storage upsell (#76052)
* GRO-554 update storage upsell

* combine 2 enabling storage modals

* redesign csv tab + storage upsell

* update gdrive panel upsell / small tweaks on supported DBs for upload

* move StoragePurchaseModal + StorageSetupProvider to ee

* revert unnecesary test change

* remove etl-connections alongside dwh-rent on storage delete; add check for collecting analytics in upsell
2026-07-14 10:36:01 +02:00
Oleh K
ebea514c84 Keep dominant treemap share honest instead of rounding to 100% (#77602)
* Keep dominant treemap share honest instead of rounding to 100%

The treemap percent formatter used a fixed 2 decimal places, so a dominant
leaf's share rounded up to a misleading 100.00% (e.g. 100000 vs 1 rendered
as 100.00% instead of 99.999%).

Mirror the pie chart: derive the decimal count from every node share via
computeMaxDecimalsForValues, so a tiny sibling forces enough precision to
keep the dominant share honest. Floored at the existing two decimals so
ordinary treemaps are unchanged, and a genuine whole still shows a clean 100%.

Fixes GDGT-2761

* Pass tree to test setup via SetupOpts object
2026-07-14 10:15:29 +02:00
github-automation-metabase
622629ef6c Update translations 2026-07-14 (#77689)
* Update translation sources 2026-07-14

* Update translations

---------

Co-authored-by: github-actions <github-actions@github.com>
2026-07-14 07:04:45 +00:00
Fraser
d60573c199 Move single-consumer code to its consumer 2026-07-14 16:44:14 +12:00
Romeo Van Snick
71e305b6ab Dynamic/plugin route conformance (#77586)
* Add dynamic/plugin route conformance harness

* Add dynamic/plugin route conformance spec
2026-07-14 13:05:39 +10:00
Alexander Polyankin
e7211002cf Static viz imports optimization (#77658) 2026-07-13 22:40:54 -04:00
Romeo Van Snick
cf56c33cdd Delete react-router-redux and redux-auth-wrapper (#77590)
* Delete react-router-redux and redux-auth-wrapper

* Dedupe redux to a single v5 copy

Removing the @types packages dropped a transitive redux@3 pin that kept a
typeless redux at the top level and masked a redux@4-vs-RTK-v5 type conflict.
Force a single redux@5 so types stay consistent.

* Migrate remaining react-router-redux references

Drop the now-dead eslint import bans for the deleted package, remove the
obsolete redux-action cast in auth logout, and reword stale comments. Keep the
metabase/router provenance docs that name the package as their reference point.
2026-07-14 09:53:16 +10:00
Anderson
8eea1fc50b Convert visualization settings components and specs to TypeScript (#76759)
* Convert visualizations/components/settings/* to TypeScript (GDGT-1799)

* Remove castings

* Preserve null chart field values in field picker

* Address review
2026-07-13 20:23:26 -03:00
dpsutton
a420372ba0 Revert "update workflow triggers" (#77666)
Revert "update workflow triggers (#77662)"

This reverts commit bc0d27253e.
2026-07-13 17:57:21 -05:00
Fraser
0b7aa11b15 Remove querying e2e repros already covered by existing Lib/QP tests 2026-07-14 10:57:06 +12:00
dpsutton
bc0d27253e update workflow triggers (#77662) 2026-07-13 17:21:14 -05:00
Cam Saul
e3791b88e8 Change :template-tags from a map to a list (#77133)
* First pass for updating Lib

* Update metabase.lib.query.test-spec

* All Lib + Lib BE tests are passing

* Fix remaining tests in Lib + QP

* Update Lib JS template tag functions

* cljfmt

* Another round of test fixes 🔧

* Leave NativeQuerySnippet :template-tags alone for now; test fixes 🔧

* cljfmt

* kondo

* Test fixes 🔧

* FE test fix? 🔧

* Another round of test fixes 🔧

* Test fix 🔧

* Test fixes 🔧

* Test fix 🔧

* Test fixes 🔧

* PR feedback

* PR feedback

* 🔧

* Test fix 🔧
2026-07-13 14:14:16 -07:00
Michael Eby
6c25c78740 docs: pdfs in subscriptions (#77610)
* docs: pdfs in subscriptions

* Edit from Jeff
2026-07-13 17:08:04 -04:00
Nathan Voxland
b3cfb8d510 Persistent Queue (#76352) 2026-07-13 16:05:07 -05:00
Tyler Plude
2765c8d027 [GIT-74954] Fix search reindex hang on metric reference cycles (#77556)
Co-authored-by: mbql-backend-expert <agent@metabase.com>
Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
2026-07-13 20:50:43 +00:00
Jeff Bruemmer
dad63b3da3 docs - supported AI providers (#77603)
* supported AI providers

* overview

* models
2026-07-13 16:24:59 -04:00
Chris Truter
8ef62d8612 Support pgvector on the app DB with minimal config (#77371) 2026-07-13 20:20:24 +00:00
github-automation-metabase
e2e10c2867 Auto-update documentation for master (#77545)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-13 16:20:15 -04:00
Nick Fitzpatrick
ee29a82916 remount EditorBubbleMenu on hide (#77575) 2026-07-14 01:30:18 +05:30
Tyler Plude
ffdd62caaa Disable harbormaster metabot feedback & add appdb MCP feedback (#76932)
* disable metabot feedback harbormaster; add appdb persistence for mcp feedback

* fix kondo

* re-add metabot enabled check; fix migration

* update to v64
2026-07-13 12:59:27 -07:00
Nick Fitzpatrick
6e6bca18d0 Make getState generic for createThunkAction (#77615) 2026-07-14 01:26:49 +05:30
technomancy
5a6a2d84e2 Use qualified db names for locks in snowflake. (#77548)
* Use qualified db names for locks in snowflake.

We're seeing some timeouts in Snowflake on CI. There are a few reasons
for this, but part of it is that we are locking a lot waiting for
access to the datasets. These locks are currently based on unqualified
database names, not hashed and branch-qualified, so they lock more
often than they need to. Using the qualified names spreads things out
a bit.

In order to do this, we need to change the `dataset-lock` method to
take the whole dataset (to hash it) not just the dataset's database-name.

* Fix upload test to not assume table set is stable.

The purpose of this test is to ensure that the created table is gone,
but the assertion it makes is far too wide. This breaks in snowflake
where we have other tests randomly creating tables in the shared cloud
DB across jobs.
2026-07-13 11:44:02 -07:00
Alexander Polyankin
669dc959ff Remove unused code (#77613)
* Remove unused code

* Remove unused code
2026-07-13 14:38:16 -04:00
Ethan McCue
3554cc36fb onboarding: add Github username to team, add Github -> Slack ID mapping (#77608)
Update JSON files
2026-07-13 14:31:21 -04:00
Andrei Chernykh
5340d25eea Convert enterprise auth session middleware to TypeScript (#77399)
* Convert enterprise auth session middleware to TypeScript

* Fix sessionMiddlware -> sessionMiddleware typo

* Justify getState type cast in application permissions reducer
2026-07-13 10:42:03 -07:00
Arik Aronov
7a39244afe Show redirect destination on the OAuth consent page (#77578)
redirect dest in concent page + test for 3 cases
2026-07-13 20:02:33 +03:00
Chris Truter
f9dce94f95 Omit empty optional fields when serializing a transform index request (#77594) 2026-07-13 16:26:53 +00:00
Riley Thompson
2d7ed54076 Finish mbql5 compilation for more drivers (#76549)
* mysql mbql5

* clickhouse mbql5

* starburst mbql5

* sqlite mbql5

* presto-jdbc mbql5

* druid-jdbc mbql5

* vertica mbql5

* athena mbql5

* hive-like mbql5

* fix databricks
2026-07-13 12:20:57 -04:00
bryan
f4d3f69010 Native 2FA: EE scaffold, TOTP core, two-step login, recovery codes (#77449) 2026-07-13 16:15:58 +00:00
Andrei Chernykh
88c9058a51 Convert snippets and application_permissions plugin modules to TypeScript (#77398)
* Rename snippets and application_permissions plugin modules to TS extensions

* Convert snippets and application_permissions plugin modules to TypeScript
2026-07-13 08:44:34 -07:00
Kamil Mielnik
bd2df5059b GDGT-2770 RFC 147. Require justification for type casts (#77168) 2026-07-13 22:06:32 +07:00
Ngoc Khuat
4a12356ec8 Add Snowplow tracking for Index Manager (#77600) 2026-07-13 22:03:52 +07:00
Chris Truter
8e13d485ec Allow MCP to create text cards and headings on dashboards (#77362) 2026-07-13 14:55:37 +02:00
Chris Truter
4d849db7f8 Force a full rebuild when a transform index request is :failed (#77593) 2026-07-13 18:29:38 +07:00
Nicolò Pretto
5a024bd2ff chore(modules): fix embedding violations and start enforcing most of the modules (#77517)
* [pr-3] Move SDK error types to embedding-sdk-shared

* [pr-3] Move SDK auth-config types to embedding-sdk-shared

* remove un-useful usage of SdkCollectionId to remove import of sdk code in core app

we don't really need that type and they both end up being `number | string`

* [pr-3] Move PLUGIN_NOTIFICATIONS_SDK to the core app plugins

I don't particularly like this: this is one of those "plugins" used
both to activate enterprise code and to inject behavior from the SDK
into the core app. We don't have an alternative at the moment, so this
is the change with the smallest blast radius. The plugin was already
used in the core app, so this just moves it to the right place.

* [pr-3] Move onEditQuestion from the SDK dashboard context to DashboardContext

DashCardMenuItems (feature/dashboard) reached into the SDK bundle's
SdkDashboardContext just for the onEditQuestion override.
I moved the onEditQuestion to the DashboardContext instead, as
it's used in the core app dashboard.

* [pr-3] Remove CommonSdkStoryWrapper from SimpleDataPicker stories

It was not needed

* [pr-3] Move useLazySelector to the SDK package

The hook exists to read the lazy-loaded bundle's redux store from the
npm package, so the package is its natural home. Its only bundle-side
consumer, useInitDataInternal, already receives the redux store as a
parameter and now subscribes to it directly instead of going through
the window props-store singleton.

* [pr-3] Introduce SdkSharedStoreState

Some core app code currently needs to read _one_ piece of information
from the SDK redux state, I moved that piece of info into a new type
called `SdkSharedState` which I documented as being something we
should avoid adding to in the future.

* [pr-3] Promote embedding-sdk-bundle to the app tier

Promotes the sdk bundle to app tier, it needs a special rule for the
bridge
module that we'll hopefully clean up in the future

* [pr-4] Promote embedding-iframe-sdk to the app tier

EAJS becomes app tier, but we need to whitelist the theme preview from
importing it

* [pr-5] Move DashboardSharingEmbeddingModal to the dashboard module

The modal is dashboard UI living under metabase/embedding, giving the
embedding module an outgoing edge into dashboard (it imports
metabase/dashboard/selectors). Move it next to its domain so the next
commit can enforce the embedding module's outgoing boundaries.

* [pr-5] Move UserForm and group helpers to the common module

UserForm is used by the new "invite people to view" modal
(InviteToViewModal, which lives in metabase/embedding, shared tier),
so it moves out of feature/admin down to metabase/common together with
GroupsMultiSelect and the group utilities it depends on. Import paths
updated, no logic changes.

* [pr-5] Move DashCardMenuItem to the embedding-sdk plugins contract

It's imported by shared/embedding-sdk but it lived in feature/dashboard,
moved it down to remove violation that will be enforced on one of the next
commits.

* [pr-5] Enforce outgoing boundaries for shared/embedding and shared/embedding-sdk
2026-07-13 12:56:31 +02:00
Ngoc Khuat
fe4a72d76f Record model views in the view log (#77091) 2026-07-13 09:11:59 +00:00
Nicolò Pretto
31e79dc02d create new embedding modules - first pr (#77263)
* [pr-1] Define embedding modules

Defines the embedding modules without promoting them yet: modules whose
back-edges still need cleanup stay at their current tier (shared, outgoing
unenforced). Each module is then promoted to app in its own follow-up PR,
together with the fixes its back-edges require.

* [pr-1] Promote embedding-sdk-package to the app tier

The npm package is an entrypoint and should be able to import from
anything, and nothing should import from it.
I raised it up as app tier

* [pr-1] Promote embedding-sdk-ee to the app tier

This should probably be "embedding-features" in the future, but for now
I'm moving it to app to be above enterprise (which it imports from) and
to prohibit other things from importing from it

* [pr-2] Move LegacyStaticEmbeddingModalProps to the plugins contract

Module `embedding-iframe-sdk-setup` will be moved to app tier, so we move
`LegacyStaticEmbeddingModalProps` to the oss plugin file to avoid an import
going up to app

* [pr-2] Promote embedding-iframe-sdk-setup to the app tier

`embedding-iframe-sdk-setup` imports EAJS, which is app tier
so this also needs to be brought up to app tier
TBD how we want to structure this, but it kinda makes sense that some
parts of the core app are above EAJS as they use it (we also use it
to render theme previews in the admin settings for themes)
2026-07-13 09:28:59 +02:00
Chris Truter
64dfbf0bb3 Dedup the modules config.edn writer (#77571) 2026-07-13 08:32:30 +02:00
Romeo Van Snick
9a6f10f9dc Replace redux-auth-wrapper with guard components (#77259)
* Replace redux-auth-wrapper guards with facade guard components

* Convert admin route guards to facade guard components

* Full-page redirect for absolute post-login redirect targets

* Normalize post-login redirect target to an absolute URL

* Convert transforms route guard to facade guard component
2026-07-13 15:44:24 +10:00
Romeo Van Snick
1ad3f2b114 Move onEnter/onChange/onLeave to components and effects (#77264)
* Move root route onEnter/onChange/onLeave into components and effects

* Replace data-studio index onEnter redirect with a component

* Address review: settle LoadCurrentUser on rejection, drop test any-cast

* Point test Route import at the metabase/router facade

* Freeze has-user-setup on entry so the setup wizard is not interrupted

* Colocate route lifecycle components with the modules that own them

* Drop onEnter/onChange/onLeave from the facade's Route props
2026-07-13 14:47:04 +10:00
Tyler Plude
98424e1a61 [BOT-1807] Add metabot treemap chart support (#77568)
* add treemap chart support

* fix fe lint
2026-07-12 21:31:42 -07:00
Romeo Van Snick
4d47327087 Fix forbidden react-router-redux import in transforms route-guards (#77581)
Use metabase/router routerActions in transforms route-guards
2026-07-13 12:33:32 +10:00
Romeo Van Snick
29993aa6db Typescript 7 (#73979)
* Update to typescript 7.0 (beta)

* Switch to tsgo in scripts

* Remove NODE_OPTIONS from typecheck script

* Use typescript 7 instead of native-preview, but keep 6 around for lint

* Use typescipt 7.0.2

* Use real typescript 6.0.3 for eslint, run tsc 7 by explicit path

* Fix type errors surfaced by typescript 7
2026-07-13 08:41:36 +10:00
Alexander Polyankin
733e1c6f3e Change defaults for graalvm (#77573) 2026-07-11 18:22:31 -04:00
Alexander Polyankin
97f82c0792 mb-sql-parsing-mode=python (#77558)
* refactor(sql-parsing): protocol + graal split, render.js-style context pool

Mirror the static-viz renderer structure (channel/render/js) for the sqlglot
parser:

- protocol.clj: strongly-typed SqlParser protocol for the sql_tools operations
- graal.clj (replaces pool.clj): GraalPy implementation on a 0..2 dirigiste
  pool; contexts share one refcounted Engine and one bootstrap Source, created
  with the first context and closed with the last, so an idle pool releases
  all native memory (replacing the old TTL/min-size-1 leak mitigation);
  timed-out contexts are interrupted and disposed instead of released
- common.clj: create-pool copied as-is from render.js.common (replaces the
  PythonEval protocol); the future external-python impl will share it
- core.clj: public API unchanged; keeps JVM-side pre/post-processing
  (VALUES stripping, field/error conversion) and delegates through the
  protocol

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* tune(sql-parsing, static-viz): 0..3 pooled graal contexts, 10-minute idle reap

:idle-minutes is now an explicit create-pool option in both pool factories
(no default): graal pools (sqlglot + static-viz) keep idle workers for up to
10 minutes, the node renderer pool stays at 1.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(sql-parsing): native CPython parser, mirroring the static-viz node renderer

- python.clj: :python SqlParser running sqlglot in a pool of external CPython
  child processes speaking newline-delimited JSON over stdin/stdout
  (sql_tools_cli.py); in dev the child imports straight from
  resources/python-sources, from the jar the sources are written to a fresh
  temp zip per spawn (zipimport) and deleted with the process; single-process
  pool (0..1, 1-minute idle reap), timeout kills a wedged process, one retry
  when an acquired process turns out dead, call-level Python errors release
  the healthy process back
- settings.clj + parser.clj: sql-parsing-mode setting (:graalvm default |
  :python) and the mode-selection namespace, like static-viz-mode/renderer
- common.clj: python-sources locations + dev sqlglot install move here from
  graal.clj (shared by both transports), plus make-parser building the
  protocol reify over a transport call fn (marshalling written once)
- fix latent nil-schema bug in validate-query arg encoding: (json/encode
  (or schema "{}")) double-encoded, making Python treat the string "{}"
  as a strict-mode schema; encode an empty map instead

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(sql-parsing): transport-agnostic parse errors; 10-minute idle for process pools

Both parser transports now throw the same ex-info for Python-side failures
(common/call-failed-ex: :sql-parsing/error + extracted Python error type) —
graal wraps PolyglotException, the CPython transport wraps its ok:false
responses — and core exposes parse-error? so callers stop catching
PolyglotException (sql-tools.sqlglot updated; a python-mode instance
previously bypassed its parse-error fallbacks entirely).

Also raise the external-process pools (sql-parsing python, static-viz node)
to a 10-minute idle reap, matching the graal context pools.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(sql-parsing): un-nest testing blocks

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* build(docker): install python3 for the :python sql-parsing mode

Both images already carry nodejs for the :node static-viz renderer; add
python3 (~45MB on alpine) so MB_SQL_PARSING_MODE=python works out of the box.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* build(docker): default sql-parsing to python and static-viz to node in the entrypoint

The image ships python3 and node, so prefer the external-process backends
(lighter and faster than in-process GraalVM) unless MB_SQL_PARSING_MODE /
MB_STATIC_VIZ_MODE are set explicitly, following the MB_JETTY_HOST pattern.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* tune(static-viz): keep the node process pool at a 1-minute idle reap

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(sql-parsing): wire settings into module init

metabase.core.init-test requires every .settings namespace to be reachable
from an init namespace; add metabase.sql-parsing.init and register it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-11 16:16:44 -04:00
Chris Truter
6188ef843f Resolve the default search engine from capability precedence (#77418)
* Resolve the default search engine from capability precedence

The search-engine setting's :appdb default meant the engine precedence
list never chose semantic, no matter how many of its dependencies were
met. Engine selection now works in three layers:

- supported-engine? is a pure capability check (app-db type, premium
  features, infrastructure) and no longer reads the search-engine
  setting.
- The default engine is the configured override when servable,
  otherwise the first supported engine in the precedence
  (semantic > appdb > in-place). Unknown configured values warn once
  and degrade instead of breaking all of search.
- Indexes are maintained for the default engine, the engines it
  declares as dependencies (semantic mixes in appdb results), and any
  engines opted in via the new additional-search-engines setting.

Reading the search-engine setting now resolves the engine that
actually serves search, so the admin UI needs no changes; the raw
override is available via configured-search-engine.

An explicitly passed per-request search_engine that cannot serve now
returns a 400 naming the cause (unknown / not supported / not enabled)
instead of silently falling back; legacy engine cookies keep the
fallback. The engine-active prometheus metric now reports active-set
membership rather than capability.

MB_SEMANTIC_SEARCH_ENABLED remains a kill switch, folded into the one
canonical semantic availability predicate (so repair/cleanup tasks now
respect it too); it will be removed once Cloud stops setting it.

Part of BOT-1832

* Tighten search engine docstrings and comments

* Validate cookie-carried search engines before use

A stale engine cookie naming an unmaintained index (e.g. appdb on an
in-place-default instance) now degrades to the default engine instead
of querying a missing index. The in-place exemption in engine-active?
uses = rather than isa?, so derived engines don't inherit a free pass.

Updates the prometheus search-engine-metrics-test to the new
engine-active semantics.

Part of BOT-1832

* Serve per-request engines through validated query-params; gate semantic writers on activity

Review follow-ups from roborev job 2600 and the workflow review:

- The engine middleware now reads and writes :query-params - the
  :params injection had been dead since the api.macros migration, so
  engine cookies had no effect on the served engine. Cookie values are
  validated (stale/unknown degrade to the default), and param values
  are normalized: blank means absent, the qualified form the API
  returns in :engine is accepted, and the legacy fulltext name maps to
  appdb at the boundary so activity checks use exact matches.
- engine-status in search.engine is the one classification of whether
  an engine can serve (:ok/:unknown/:unsupported/:inactive); the API
  layer maps it to 400s and no longer re-encodes engine invariants.
- Semantic fallback (EE core and the metabot search tool) prefers
  engines with a maintained index over merely supported ones, so an
  in-place default with additional-search-engines=semantic mixes with
  the warm appdb index instead of in-place.
- The semantic indexer and index-repair tasks gate on the new
  semantic-search-active? instead of availability, so a supported but
  inactive semantic index no longer accrues hourly embedding spend.
- active-engines guards the pre-init nil default and only
  capability-checks dependency entries.

Part of BOT-1832

* Canonicalize legacy engine names at every boundary; tolerate repeated engine params

search.engine/canonical-engine resolves legacy names (fulltext -> appdb)
for configured values, additional-search-engines, and request
params/cookies alike, so active-engine membership compares exactly.

A repeated search_engine query param parses as a vector; the middleware
now passes it through for schema validation to reject with a 400
instead of throwing.

Part of BOT-1832

* Review cleanups: single evaluation of engine resolution values

Bind configured-engine, the parsed param engine, and active-engines
once per expression instead of re-evaluating (Copilot); remove blank
lines inside the check-engine-serves! case form (CodeRabbit).

Part of BOT-1832

* Engine-active metric means can-serve; harden param parsing and dependency filtering

engine-active shares engine-status's definition: in-place is always
active while it exists, indexed engines while their index is
maintained. Fixes the prometheus test assertion that compared a metric
to itself.

param->engine strips the search.engine/ prefix rather than splitting on
slashes, so junk values 400 with the full value named instead of
validating their last segment, and degenerate values like // cannot
produce an empty or nil keyword.

active-engines filters dependency engines through known-engine? before
supported-engine?, matching the startup-ordering guard in
supported-engines.

Part of BOT-1832

* Reject malformed explicit engine values instead of treating them as absent

A non-blank search_engine that strips to a blank suffix (e.g.
search.engine/) parses to an unknown engine and 400s naming the raw
value; only genuinely blank values fall through to the cookie/default.

Part of BOT-1832

* Clarify the unknown-engine filter comment in supported-engines

* Fix review findings: runtime kill switch, csv hygiene, cookie unpinning, shared fallback

- Semantic Quartz jobs are scheduled when the instance is capable
  (pgvector + feature) and check availability/activity per execution,
  so the kill switch works at runtime again instead of gating job
  scheduling at boot.
- semantic-search-active? is plain active-set membership; the HNSW
  build gates on it like every other index writer.
- additional-search-engines values are trimmed, blanks dropped, and
  qualified/legacy names canonicalized (prefix handling now lives in
  canonical-engine, the one boundary fn).
- An explicit blank search_engine clears the engine cookie (the unpin
  mechanism this branch had removed) instead of being ignored.
- fallback-engine lives in search.engine; the EE semantic core and the
  metabot search tool share it.
- The runtime-activation backfill note moved from the
  additional-search-engines description to a comment.

Part of BOT-1832

* Initialize the semantic index from repair when none is active

Semantic can become active at runtime (kill switch re-enabled, or added
to additional-search-engines) without init! ever having run; the hourly
repair task now initializes and backfills in that case instead of
no-oping until a manual /re-init.

Also renames warn-once to warn-once! per the side-effect convention and
adds end-to-end coverage for the pinned-cookie and blank-unpin paths.

Part of BOT-1832

* Cover the repair-initializes path; unpin test asserts the resolved default

The blank-unpin api test compared against a hard-coded appdb default,
which does not hold on MySQL/MariaDB app dbs. New repair test starts
from a blank pgvector db and asserts repair-index! creates an active
index and gates the documents.

Part of BOT-1832

* Trigger search index init when additional engines are set at runtime

Registers the (previously dangling) init-job-key as a durable,
trigger-less quartz job wrapping the search init, and the
additional-search-engines setter fires it when it exists. In tests the
scheduler is not running, so the setter stays side-effect free there;
env-var configuration is covered by the startup init.

Part of BOT-1832

* Rename the engine cookie and cover the pin/unpin round trip

metabase.SEARCH_ENGINE becomes metabase.SEARCH_ENGINE_OVERRIDE, so the
population of long-lived cookies written before engine validation
existed stays inert.

The round-trip test covers pinning via an explicit param, serving from
the cookie, and clearing it with a blank param.

Part of BOT-1832

* Order semantic capability gates cheapest first

The license check short-circuits before the pgvector URL check, whose
slot becomes a DB probe under BOT-1796.

Part of BOT-1832

* Only trigger search init when the setting change activates an engine

Semantic init re-gates every searchable document, so an unconditional
trigger made any write to additional-search-engines cost a full app-db
sweep. The setter now diffs active-engines across the set and triggers
only for newly activated engines.

Part of BOT-1832

* Defer the engine-activation trigger to after commit

The activation diff and quartz trigger run via do-after-commit in a
future (extracted to trigger-init-for-newly-active-engines!), observing
the final committed settings state - a surrounding set-many! may
include the setting that makes the engine supported - without I/O on
the transaction's thread.

The cookie round-trip test uses the in-process client so the handler
runs inside the fixture's engine and index bindings.

Part of BOT-1832

* Review nits: log async trigger failures, quote the cookie regex, fix a docstring

The post-commit init trigger logs exceptions instead of dropping them
in the future; the cookie test quotes the cookie name before building
its regex; build-hnsw-index-async! says active, matching its gate.

Part of BOT-1832

* Schedule semantic jobs on the boot-static gate; indexer initializes missing indexes

Job scheduling happens once at startup, so it now gates on the only
boot-static input: whether a pgvector DB is configured. The runtime
gates (license, kill switch, engine activity) are checked per
execution, so applying a license or re-enabling the kill switch at
runtime no longer strands semantic as an unindexed default until
restart.

The indexer's 20-second tick initializes the index when it is missing,
so every runtime activation path (license, kill switch, setter on a
stale cluster node) converges within seconds instead of waiting for the
hourly repair or a restart.

Also: the blank-param unpin deletes the engine cookie (max-age 0)
instead of writing an empty 20-year one; the activation trigger helper
lives in search.task.search-index with static requires; the setter test
uses poll-until for the async positive case and a direct synchronous
call for the negative.

Part of BOT-1832

* Runtime self-heal initializes all active engines and the HNSW index

The indexer's missing-index branch runs the generic search init, which
covers newly active dependencies, and applies the same HNSW-strategy
safety net as task registration.

Part of BOT-1832

* Ensure the HNSW index on the indexer's active path

An index-backed strategy configured while semantic was inactive misses
the setter's build event; the indexer tick now fires the async build
when the active index lacks its HNSW index. The pg_indexes existence
check is self-limiting: CONCURRENTLY registers the index when the build
starts.

Part of BOT-1832

* Fix engine tests on app dbs without appdb search support

Explicitly requesting an unservable engine now 400s instead of silently
falling back, so tests must not hard-code appdb: the data-studio search
tests iterate only supported engines, the cookie staleness test pins
in-place (servable everywhere), and the not-enabled case runs only
where appdb is supported.

Also realigns warn-once! call args (cljfmt).

Part of BOT-1832

* Keep semantic active under the search test fixtures

active-engines now derives from the default engine, so fixtures that
pin default-engine were silently deactivating semantic: semantic
queries in the metabot search tool fell through to the term engine.
Both fixtures pin active-engines to the set the old derivation gave
them - appdb plus semantic when supported, or semantic alone for
legacy search.

Part of BOT-1832

* Rename with-new-search-* test fixtures to with-appdb-search-*

The appdb engine predates semantic search; new no longer disambiguates.

Part of BOT-1832

* Update the last supported-implies-active consumers

The metabot semantic-search feature predicate gates tool schemas on
engine-status :ok rather than capability, so semantic_queries is only
advertised when a semantic index is actually maintained.

The metric collector runs only when semantic is active, and index
cleanup no-ops until the bookkeeping tables exist: available but never
initialized is now a steady state, and both jobs would otherwise warn
or throw about missing tables on every run. Cleanup still runs while
merely available so an opted-out instance's leftover indexes get
dropped.

Part of BOT-1832

---------

Co-authored-by: Tyler Plude <tsplude@gmail.com>
2026-07-10 20:16:56 -07:00
Romeo Van Snick
544a0c2ba8 Migrate query_builder/analytics to TypeScript (#76934)
* Migrate query_builder/analytics to TypeScript

* Type Card.creationType and drop analytics cast

Address review: type Card.creationType as a union instead of a plain
string, narrow Question.creationType(), and make the new_question_saved
type field optional/nullable to match the Snowplow schema. Removes the
cast in the analytics tracker.

* Drop as const in load-question via Card annotation
2026-07-11 09:33:43 +10:00
Romeo Van Snick
836e12b526 Re-own react-router-redux behind the metabase/router facade (#77142)
* Re-own react-router-redux mechanisms behind the metabase/router facade

* Wire store, app and store types onto the re-owned router facade

* Re-point react-router-redux call sites onto metabase/router

* Update router tests and harness for the re-owned facade

* Ban react-router-redux imports outside metabase/router

* Model routing state's null location contract instead of casting

* Flatten CallHistoryMethodAction into per-method history action types

* Match history actions with ts-pattern in routerMiddleware

* Preserve explicit null location in createMockRoutingState
2026-07-11 09:33:29 +10:00
Ben Grabow
ba83271710 Auto-fix modules config.edn (#77541)
* Auto-fix modules config.edn

* Extract generic nrepl integration wrapper

* Remind claude to use this

* Demo the module config fixer with some tests
2026-07-10 17:20:33 -05:00
dpsutton
6b855cbe81 feat(dev): browser-based email template previewer (#77546)
Adds `bun run email-dev`: a small Bun server + static page that renders
the Handlebars email templates in src/metabase/channel/email/ with
editable sample data, so designers and copywriters can iterate on email
copy and layout without running Metabase or sending real emails.

- live-reloads when a .hbs file changes on disk (1s polling)
- Fields/JSON panels to fill in template values; edits persist in
  localStorage per browser
- Desktop/Narrow/Phone width toggles and Copy HTML
- sample-contexts.js mirrors the real send-time contexts (traced from
  messages.clj and the notification handlers)
- mirrors the jknack custom helpers (equals, format-date, now, initials,
  card-url, dashboard-url, trash-url) in handlebars.js

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-10 17:09:04 -05:00
Andrei Chernykh
b8673198cd Migrate Link, ListItem, and LoadingSpinner from Emotion to Mantine + CSS modules (#77323)
* Migrate Link, ListItem, and LoadingSpinner from Emotion to Mantine + CSS modules

* Fix TableList disabled-state assertions by exposing data-disabled instead of relying on Emotion-injected styles
2026-07-10 13:47:48 -07:00
lbrdnk
87f0514519 Mention archival and soft deletion in MCP metric update API (#77525)
* Mention archival and soft deletion in MCP metric update api

* Update src/metabase/agent_api/api.clj

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

* Update src/metabase/agent_api/api.clj

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

* Extend update-metric-archive-test

---------

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
2026-07-10 22:43:57 +02:00
Nemanja Glumac
dea12ca75c Wire the test-driver action to work with the Quarantine switch (#77476) 2026-07-10 21:12:56 +02:00
Nemanja Glumac
71863190b1 Wire the quarantine switch into the embedding e2e workflows (#77518) 2026-07-10 19:07:34 +02:00
Eric Normand
5a4f82063e Name the referring entity in remote sync not-found errors (#77430)
* Name the referring entity in remote sync not-found errors

When an import references content that doesn't exist on this instance, the
error named only the missing entity's raw serdes id. It now also names the
entity holding the dangling reference, and backtick-quotes names and ids so
leading and trailing whitespace is visible.

`load-one!` takes the referrer as an explicit parameter rather than carrying
it on the load context: `load-deps!` reduces over sibling deps and each
recursive `load-one!` returns its own context, so a context key would leave
later siblings labelled with the deepest child's referrer.

Message construction lives in `missing-reference-message` so the format can
change without touching the throw sites.

* Attach the referrer by catch-and-rethrow instead of threading it

Replaces the extra `load-one!`/`load-deps!` parameter with a try/catch around
the dependency load. The nearest enclosing `load-one!` unwinds first, so it is
the frame that attaches itself as the referrer; outer frames see the key
already present and rethrow unchanged. The original exception is kept as the
cause, preserving the stack trace of the detection site.

Adds an end-to-end assertion in bare-import-test that a real import of a Card
referencing a missing Database carries the Card as `:referrer`, which the
hand-built ex-info unit tests could not cover.

* Key the database-not-found error off ex-data, and name the referring card

`source-error-message` detected this case by matching "database not found"
against the cause's message text, then interpolated that raw internal string
into the user-facing error:

  Import failed: A referenced database does not exist on this instance.
  table id present, but database not found: [clickhouse nil some_table]

`import-table-fk` now tags the throw with `:error ::database-not-found` and
`:db-name`, and the render walks the whole cause chain looking for that key
rather than checking only the immediate cause. `::load-failure` carries the
referring entity, so both missing-content paths now render through
`missing-reference-message`:

  Import failed: Card `Some card` (`abc123`) references Database (`clickhouse`),
  which does not exist on this instance. ...

Also fixes `:database-names` in that ex-data, which selected names from
:model/Table rather than :model/Database. It has no consumers.

The end-to-end test uses a result_metadata `:table_id`, since that is the path
that actually reaches `import-table-fk` with an undeclared database:
`result-metadata-deps` derives deps only from `:field_ref`, and a Card's own
top-level `table_id` is recomputed from `dataset_query` by
`populate-query-fields` on insert.

* Backtick-quote file paths in remote sync ingest-error messages

GHY-3992 asks for content names to be quoted so leading and trailing
whitespace is visible. The ::not-found path already did this; the
ingest-errors branch still joined raw paths, and the message already uses
": " between path and reason and "; " between entries, so a path containing
punctuation or trailing space was ambiguous to read.

No fallback is added for a nil :file. All three ingest-error producers
(ingest.clj file-hierarchy!, ingestable.clj read and parse failures) always
set it, and only YamlIngestion and IngestableSnapshot produce a non-empty
ingest-errors; the other Ingestables delegate.

Splits source-error-message-entity-not-found-test into three deftests, one
per error branch, which kondo requires now that each has grown assertions.

* Render load-failure errors with the entity name, reason, and stripped keys

::load-failure fell through to the generic "Failed to reload from git
repository: <ex-message>" fallback, showing a NanoID and burying the
stripped-keys note. It now reads:

  Import failed: could not save Card `Orders by Month` (`abc123`).
  NOT NULL constraint failed: report_card.display.

and, when the entity was part of a dependency loop, adds "It may have been
saved without: `dashcards`, `parameters`." — a partial row for it survived
the import, which the user previously had no way to learn.

Renames the ::load-failure ex-data key `:referrer` to `:entity`. It names the
entity that failed to load, which is a referrer only relative to the missing
database in the ::database-not-found case; that branch now reads `:entity` and
passes it as the referrer. ::not-found keeps `:referrer`, where it really is
the parent.

The new branch is ordered after the tenant-collection and database-not-found
branches, both of which match on causes that a ::load-failure wraps.

::circular is left on the fallback. Rendering its cycle needs an ordered
expansion chain — `expanding` is a set — and it only fires when the
key-stripping recovery has already failed.

* Address CodeRabbit review

- Remove a duplicated `testing` block in impl_test.clj. It was byte-identical
  to the one above it, introduced when the deftest was split. Replaced with a
  doseq covering trailing, leading, and no surrounding whitespace.
- Mark `missing-reference-message` and `load-failure-message` private; neither
  is used outside impl.clj.
- Capture the exception once in bare-import-test's not-found case instead of
  running the same failing import twice, and flatten the resulting nested let.
2026-07-10 16:24:16 +00:00
Riley Thompson
9197dc9057 Fix path in location-connection-properties (#77322)
fix path
2026-07-10 14:53:47 +00:00
Sébastien
0b9e1c0be4 Show the SQL editor when useMetabot opens a native question (#77370) 2026-07-10 16:18:42 +02:00
github-automation-metabase
46d217cf64 Auto-update documentation for master (#77469) 2026-07-10 09:23:39 -04:00
Chris Truter
f9ecaf7f92 Fix weak assertion in create-table-from-schema!-test (#77520) 2026-07-10 13:13:42 +00:00
Chris Truter
ae56aaf2b2 Fix the shadow-cljs warning from lib.core's macro re-export (#77521) 2026-07-10 13:08:42 +00:00
Egor Grushin
ab9a3e191a GDGT-2766 GDGT-2766 Migrates deprecated FormTextInput and FormInput components (#77161)
* GDGT-2766 GDGT-2766 Migrates deprecated FormTextInput and FormInput components

* GDGT-2780-2766 DRY FormInputWidget

* GDGT-2780-2766 fix lost margin

* replace with new FormField

* fix marging

* rollback be.visible to exist in action e2e specs

* replace HTML_INPUT_TYPES map with inline ts-match

* fix margin
2026-07-10 13:54:37 +01:00
Sébastien
9f42bcf323 Apply global dashboardCardMenu plugin from MetabaseProvider to dashboards (#77500) 2026-07-10 14:28:51 +02:00
Chris Truter
130888462d Fix the metabot semantic-search tests not runing in CI (#77519) 2026-07-10 11:18:03 +00:00
Ngoc Khuat
32a869b1e6 Index manager (#75848) 2026-07-10 11:05:07 +00:00
Alexander Polyankin
f7f8697947 Add tests for the node static-viz renderer (#77508) 2026-07-10 03:41:13 -04:00
Timothy S. Dean
960d036afd Bump js-yaml to 4.3.0 (#77459)
Bump js-yaml to 4.3.0
2026-07-10 00:49:07 -06:00
da
60e1b995d3 Add CSV uploads to Snowflake (#77239)
Co-authored-by: Chris Truter <chris@metabase.com>
2026-07-10 04:18:36 +00:00
Sébastien
15195d006a fix(sdk-bundle): restore back button after "Edit question" in embedded dashboards (#77389) 2026-07-10 06:14:14 +02:00
appleby
5bd7fa6247 Support OpenRouter (#77139)
* Fix metabase.metabot.api/openrouter-model-group

Fallback to parsing the id if the display_name has no ":"-separated prefix.

* Add a default OpenRouter model so connect-without-model works

Without an entry in default-llm-metabot-model-by-provider, a PUT /api/metabot/settings that connects openrouter with
only an API key would save the key but silently fail to switch llm-metabot-provider.

* Use real dotted OpenRouter model IDs in defaults and docs

OpenRouter model IDs use dots in version numbers, e.g. anthropic/claude-haiku-4.5. The hyphenated
anthropic/claude-haiku-4-5 referenced by the default args and docstrings does not exist.

* FE: enable openrouter provider in metabot admin UI config

* Whitelist openrouter models

Filter openrouter list-models down to the same curated Anthropic and OpenAI model set the direct providers support,
instead of returning the full ~340-model catalog.

* Throw an exception if callers pass :ai-proxy true for openrouter

Similar to bedrock and openai, supporting this would require work on the ai-service side, and we already reject
non-anthropic providers in validate-metabase-managed-provider!

* Remove explicit credentials check in list-all-models

We want to allow callers to omit the creds and fallback to the configured api key from settings. core/resolve-auth
still handles the auth check and will throw if no credentials are provided or configured.

* Support prompt caching for openrouter

Report `:cacheCreationTokens` and `:cacheReadTokens` in the `:usage`.

For anthropic models, add the `:cache_control` breakpoint on the system message to enable caching (openai caching is
automatic).

* Apply code review suggestion in AIProviderSettingsSection.unit.spec.tsx

Co-authored-by: Maksym Yakubych <undrfined@gmail.com>

* Add gpt-5.6 and drop gpt-5 from openrouter supported-models

See also #77450

* Apply code review suggestion in fe tests

Co-authored-by: Maksym Yakubych <undrfined@gmail.com>

---------

Co-authored-by: Maksym Yakubych <undrfined@gmail.com>
2026-07-10 00:47:30 +00:00
Alexander Polyankin
6eff4789f0 Static viz node renderer (#77419) 2026-07-09 20:16:11 -04:00
Egor Grushin
fe6bc8a408 Gdgt 2587 2581 replace deprecated numericinput components (#77117)
* GDGT-2587 GDGT-2581 migrate deprecated components

* GDGT-2587 GDGT-2581 get rid of deprecated components

* GDGT-2581 fix tests

* fix tests

* GDGT-2584 DRY FormNumberInputWidget

* GDGT-2587-2581 fix floats + cover the change with a test

* GDGT-2587-2581 fix a test

* GDGT-2587-2581 addressing PR's comments

* GDGT-2587-2581 small UX improvement

* GDGT-2587-2581 stronger assertions in model-actions test

* GDGT-2587-2581 remove spreading

* GDGT-2587-2581 scrollIntoView before visibility asserts

* GDGT-2587-2581 assert exist not visible for constraint errors
2026-07-10 01:00:25 +01:00
Timothy S. Dean
117020fc2e Pin linkify-it to 5.0.2 (#77457)
Pin linkify-it to 5.0.2
2026-07-09 17:06:06 -06:00
Egor Grushin
b9bba24cfd GDGT-2584 migrate FormTextArea (#77089)
* GDGT-2584 migrate FormTextArea

* GDGT-2584 remove unused code

* GDGT-2581 fix error labeling

* GDGT-2584 DRYed FormTextareaWidget

* GDGT-2584 make textarea resizeable for the snippet form

* GDGT-2584 restore actions

* GDGT-2584 fix margin

* GDGT-2584 fix margins
2026-07-09 23:27:35 +01:00
appleby
a817ed88a6 Add gpt-5.6 to openai supported-models (#77450)
* Add gpt-5.6 to openai supported-models

* Drop gpt-5 from openai supported-models
2026-07-09 22:21:36 +00:00
Eric Normand
0a3932e9cf Move remote-sync branch switching into Settings with destructive-action guard rails (GHY-4019) (#77286)
* Move remote-sync branch switching into Settings with guard rails (GHY-4019)

Branch switching ran a full import that hard-deletes any synced-collection
content absent from the target branch, and it lived as a routine app-bar
dropdown item. A forced switch could permanently delete never-pushed content.

Backend:
- spec: detect collection-scoped deletion conflicts (Cards/metrics, Dashboards,
  Documents, Timelines), not just the transform family; wire into get-conflicts
- import: expose force_deletion on POST /import so a forced version/dirty
  override no longer silently forces deletions
- async-import dirty guard now returns the dirty objects (what would be lost)
- PUT /settings rejects a read-write branch switch (must use the guarded import);
  read-only changes and first-time config still allowed

Frontend:
- remove the Switch branch affordance from the app-bar sync controls (branch
  name stays as a read-only label; push/pull intact); drop the switch-branch
  conflict variant
- add a guarded branch switcher to the read-write Settings panel: destructive
  warning copy, hard block when there are unsaved changes (lists them, no force
  path), destructive confirm when clean, stale-tab handling

* Refine Settings branch switcher: choice modal, admin gating, direct clean switch

Follow-up to the branch-switching rework, from review feedback:

- Offer a choice modal (push / new branch / discard) when switching with
  unsaved changes, instead of a hard block — restores the switch-branch
  conflict variant, now driven from the Settings panel BranchSwitcher.
- Drop the destructive confirmation on a clean switch: with everything pushed
  the switch is reversible, so it runs directly.
- Show a red "N unsaved change(s)" label beside the dropdown when dirty.
- Gate the switcher on superuser: non-admins (e.g. settings managers) see the
  section with an "admin required" message instead of a control they can't use;
  the section no longer depends on the admin-only branch setting being readable.
- Match the section subtitle styling to the other settings sections.
- Strengthen the import superuser test to cover a branch switch.

* Update remote-sync E2E for Settings-panel branch switching

Branch switching moved from the app bar to the Settings panel, so the
branching specs and helpers drive it there now:

- Replace the app-bar switch helpers with Settings-panel ones
  (visitRemoteSyncSettings, getSettingsBranchSwitcher,
  createBranchViaSettings, switchBranchViaSettings).
- Rewrite the branching tests to create/switch branches on the Settings
  page, navigating back to the app for content changes.
- Switching with unsaved changes opens the choice modal (wait for the
  unsaved-changes indicator first); a clean switch goes directly.
- Snowplow triggered_from: app-bar -> admin-settings.

* cljfmt

* Address review: guard-bypass fix, anti-join, shared removal predicate

- api: block blanking the branch in read-write mode too, so it can't be used to
  reset the branch-switch guard and then switch freely; regression test added.
- spec: compute collection deletion conflicts with a SQL anti-join + count/limit
  instead of loading every candidate and an exists? per row, so it scales when a
  switch would drop a large synced collection.
- Extract spec/removal-where-clauses as the single definition of what an import
  reconcile removes for a model; remove-unsynced! and the deletion-conflict check
  both build their WHERE from it (removes the duplicate build-entity-id-where-clause).
- Add a parity test asserting the conflict warning is exactly the unsynced subset
  of what remove-unsynced! removes.
- Nits: be.visible for the dirty-warning indicator; wrap a long test string.

* Build the deletion-conflict WHERE with a thread-first instead of nested into/conj

* Give check-deletion-conflicts the same anti-join as the collection check

Was doing a t2/exists? per candidate (and materializing every candidate).
Now counts via one SQL anti-join, sharing removal-where-clauses and the new
model-id-column / unsynced-anti-join helpers with check-collection-deletion-conflicts.
Adds a direct spec-level test for it.

* Build collection deletion conflicts with cond-> instead of if/into

* Cover NativeQuerySnippet in the deletion-conflict warning

Generalize check-collection-deletion-conflicts -> check-content-deletion-conflicts:
warn before an import deletes any unsynced entity-id content, not just collection-
scoped models. This pulls in NativeQuerySnippet (global, no collection scope), which
otherwise fell through both conflict checks and could be silently deleted on a forced
import/branch switch. Collection stays excluded (structural; its contents are covered).
Adds a snippet test case.

* Address branch-switch review: drop force_deletion param, refetch dirty at switch, add tests

- Remove the unused force_deletion param from POST /import (schema, destructure,
  and async-import! call); internal force-deletion? threading is unchanged.
- BranchSwitcher refetches dirty state at switch time so a stale settings-page
  snapshot can't route a switch down the wrong (delete-without-warning) path.
- Add BranchSwitcher unit tests: non-admin message, dirty count label,
  clean direct switch, and the choose-what-to-do modal on the dirty path.

* Left-align the branch value in the settings switcher for consistency with other selects

* Show a 'Using <env var>' note when the sync branch is pinned by an env var

* Fix branch-switcher e2e: scroll the switcher into view, drop spurious branch-switched event

The Sync branch section sits below the fold at the default viewport, and Cypress treats an element
clipped by a scrollable ancestor as hidden, so the switcher assertions failed (surfaced by
testing-library as a misleading "Unable to find an element"). Scroll to it before asserting.

BranchSwitcher also reported a branch switch when creating a branch, emitting a spurious
remote_sync_branch_switched alongside the branch picker's remote_sync_branch_created. Creating a
branch forks the current one without a reconcile, so only the creation is reported now.
2026-07-09 22:15:44 +00:00
Nemanja Glumac
44dc41a7fa Introduce the Quarantine Control Knob (#77417)
Introduces a `QUARANTINE_ENGINE` variable that acts as a control knob. Either Trunk enforces a quarantine or CI conductor does. So far wired only in three places:
1. fe
2. be
3. e2e
2026-07-09 21:34:00 +00:00
Ben Grabow
f0ef171d25 Ghy-4069 minimal migration approach (#77297)
* Upgrade H2 -> SQLite sample DB by mutating database :driver
2026-07-09 16:29:28 -05:00
Chris Vandoodewaard
5373a65352 Revert "Update translations 2026-07-07" (#77456)
Revert "Update translations 2026-07-07 (#77151)"

This reverts commit 5f56057bfe.
2026-07-09 21:27:36 +00:00
Chris Vandoodewaard
a169d4ab75 remove experimental linear-release-sync workflow (#77302)
* remove experimental linear-release-sync workflow

* remove linear-release-lifecycle job from release workflow

* also cleanup helper functions
2026-07-09 16:47:05 -04:00
Timofey Kachalov
31a0379d5d Update jackson.* dependencies to 2.21.5 (#77427) 2026-07-09 23:55:33 +04:00
Eric Normand
950f453535 Preserve native model column types during serialization (GHY-4043) (#77405)
* Preserve native model column types during serialization (GHY-4043)

export-result-metadata checked (model? card) before the native branch, so
native models were routed through lib/model-preserved-keys — a metadata-merge
soft-key set that omits :base_type/:effective_type. On a read-only Remote Sync
target the column types could not be re-derived without executing the SQL, so
computed columns (e.g. STRING_AGG(...) AS names) fell back to type/* and their
filter UI collapsed to Is empty / Not empty.

Reorder the cond so native cards — models included — go through the branch that
preserves structural type info; only MBQL models, whose types are re-derivable
from the query at import, use the soft-key set.

* Update native-model extract test for preserved column types

extract-result-metadata-native-model-test asserted the old behavior — that a
native model dropped :base_type on export. Update it to expect structural type
info to survive, matching the GHY-4043 fix. Drop the now-unused clojure.set
require.
2026-07-09 19:31:44 +00:00
Kevin Kelleher
7a20b77fbd Add enable/disable setting for Transforms in Data Studio (#75710)
* transform enable/disable setting

* fix test, change approach for self hosted

* fix tests

* fix tests, self review

* add tests

* fix ci

* fix lint

* address review comments

* address review comments

* fix ci

* changelog 63 -> 64

* fix lint, test

* another lint
2026-07-09 19:29:55 +00:00
Maksym Yakubych
7d1f271280 fix: move data complexity lower on the stats page (#77003)
Closes [BOT-1797: Move data complexity lower on the stats page](https://linear.app/metabase/issue/BOT-1797/move-data-complexity-lower-on-the-stats-page)

### Description

Move data complexity lower on the stats page, decrease font size and copy length.

### How to verify

1. Go to Admin settings -> AI.
2. Scroll down to the data complexity section.

### Demo

<img width="1840" height="1120" alt="image" src="https://github.com/user-attachments/assets/627935fd-e9d2-40d6-8c1c-7b2a52c35394" />

### Checklist

- [x] Tests have been added/updated to cover changes in this PR
- [x] If adding new Loki tests: they pass [stress testing](https://github.com/metabase/metabase/actions/workflows/loki-stress-test-flake-fix.yml)
2026-07-09 16:14:13 -03:00
appleby
a9b9b7bb59 Ensure openai reports :cacheReadTokens in :usage (#77341)
* Ensure openai reports `:cacheReadTokens` in `:usage`

Add `openai-usage->aisdk-usage` to convert openai usage format to aisdk format and report `:cacheReadTokens`.

* Add undocumented :cache_write_tokens as well
2026-07-09 19:08:11 +00:00
Eric Normand
368ed03818 Preserve MySQL role name case when expanding role grants (#77415)
`parse-grant` lowercased role names parsed out of `SHOW GRANTS FOR <user>`.
Those names are fed back into `SHOW GRANTS FOR <user> USING <roles>`, and
MySQL 8 treats backticked role identifiers as case-sensitive, so any role
with uppercase characters made the follow-up query fail with error 3530 and
took the whole metadata sync step down with it.

Lowercasing is still correct for the privilege types in the sibling
`:privileges` branch; it was never right for role identifiers.

Also add the missing space before `USING` in the follow-up query, which
only parsed because the user identifier ends in a backtick.
2026-07-09 13:42:32 -05:00
Alexander Polyankin
ffbddbbc6f Static-viz: dispose ECharts instances (OOM fix) + faster SVG dominant-baseline patch (#77412)
* Static-viz: dispose ECharts SSR instances + faster SVG dominant-baseline patch

Two isolated, output-preserving fixes to the static-viz render path:

- Dispose the ECharts/zrender SSR instance after renderToSVGString() in every
  chart component. These instances were never released, leaking ~MBs per render
  and OOMing a long-lived renderer process; memory is flat after.

- Replace patchDominantBaseline's full hast parse+serialize round-trip over the
  whole SVG with a targeted string transform (like the sibling
  transformSvgForOutline), cutting a large share of big-chart render time with
  byte-identical output.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Update BoxPlotChart.tsx

* Update ComboChart.tsx

* Update PieChart.tsx

* Update SankeyChart.tsx

* Update ScatterPlot.tsx

* Update TreemapChart.tsx

* Update WaterfallChart.tsx

* Drop hast deps entirely; svg test uses DOMParser

The SVG dominant-baseline patch no longer uses hast, and its test was the last
user of hast-util-from-html. Rewrite the test with the jsdom DOMParser and
remove hast-util-from-html and hast-util-to-html from the deps.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Fix formatting in ComboChart.tsx

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-09 14:27:18 -04:00
Chris Truter
c6a0c72b01 Enforce the 50 MB CSV upload limit on the backend (#77363) 2026-07-09 17:54:36 +00:00
Alexander Polyankin
22725a83b9 Extract a StaticVizRenderer protocol for static-viz rendering (#77315) 2026-07-09 11:26:13 -04:00
Kamil Mielnik
a9e1b0edf7 GDGT-2454 Badge (#74714) 2026-07-09 21:47:43 +07:00
Sloan Sparger
6912a50e85 [Metabot] Chat internal format improvements (#77301)
* [Metabot] Migrate BE to v2 message format (#75672)

* migrate codebase to writing v2 format

* move to camelCase to match upstream schema changes

* improvements

* improvements

* correction

* metadata corrections

* handle string outputs correctly

* put add error code to message metadata in finish message

* self-review pass

* record step start to db

* correct issue in claude provider that sent too long of message ids

* record text state to open up future ability to write in progress work

* increase malli usage

* limit client streamed output for tool calls

* emit cache token usage correctly

* ensure started before error is emited

* update migration version

* [Metabot] FE read new message format (#76429)

* initial impl

* self review

* update e2e tests

* copilot feedback

* pr feedback

* fix lint

* feedback - test helper ergonomics

* misc. fixes to metabot chat improvements integration branch (#77321)

* fixes due to stale branches, correct data- prefix not getting recorded, remove unused code

* clean up debug visuals

* ci fixes

* fix couple more tests

* pr feedback
2026-07-09 09:39:59 -05:00
github-automation-metabase
5f56057bfe Update translations 2026-07-07 (#77151)
* Update translation sources 2026-07-07

* Update translations

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Co-authored-by: Chris Vandoodewaard <chris.vandoodewaard@metabase.com>
2026-07-09 14:35:20 +00:00
Nicola Mometto
e5bd3a34eb fix: enumerate cols to fix sql server (#77373)
* fix: enumerate cols to fix sql server

* fix sqlserver boolean coercion properly
2026-07-09 14:06:15 +00:00
Chris Truter
6097aa447b Publish / unpublish tables trigger hooks properly (#77374) 2026-07-09 12:22:58 +00:00
Mahatthana (Kelvin) Nomsawadi
ff2b145e37 Forward query edits from viz settings in SDK QuestionSettings (#77262)
* test: add repro for SDK viz-settings column edits being dropped

Reproduces EMB-2057 — in modular embedding (embed.js), removing a
column via Visualization settings > Add or remove columns silently
no-ops. Fails against the current QuestionSettings.tsx onChange,
which drops the second question argument carrying the query edit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix: forward query edits from viz settings in SDK QuestionSettings

QuestionSettings.tsx's onChange dropped the second `question`
argument that ChartSettings forwards for query-level edits (e.g.
add/remove columns), applying only the settings to the stale closure
question and never re-running the query. Column-removal edits landed
in the query object but the table kept rendering the old result.

Forward `nextQuestion` when present and re-run only in that case, so
pure viz-settings-only edits (no query change) keep their existing
no-run behavior.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Fix code format

* move test to where it belongs

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-09 08:47:59 +01:00
Alexander Polyankin
21f2c65b15 Collapse uniform blocked view-data table permissions to db-level rows (#77130) 2026-07-08 21:44:07 -04:00
technomancy
1c90ab2c31 Split databricks CI jobs in 2 parts. (#77312)
Currently they are timing out with some regularity in CI. We've done
this same thing to bigquery and redshift already.

Not only will this get us pass/fail results more quickly; it also
reduces the scope of failures so retries don't have to redo as much
wasted work.
2026-07-09 01:32:33 +00:00
Denis Berezin
82b65c8496 UXW-4481 Timeline Events new UI (#76381)
* UXW-4481 Timeline Events new UI

* Add full implementation (without new icons)

* Update icons

* Self review

* Self review

* Review fixes

* Add focused list of events in sidebar

* Clean-up

* Fix hover color

* Fix unit test

* Better sidebar logic

* Fix e2e

* Review fixes

* Review fixes

* Fix e2e

* Fixes

* Review fix

---------

Co-authored-by: Andrei Chernykh <andrei.chernykh@metabase.com>
2026-07-09 03:59:30 +03:00
Egor Grushin
da4e98d389 GDGT-2576 migrate Toggle (#77063)
* GDGT-2576 migrate Toggle

* GDGT-2576 tests fix

* GDGT-2576 remove unused code + fix test

* GDGT-2576 fix failing tests

* GDGT-2576 drop unused onChange from FormToggle
2026-07-09 01:34:59 +01:00
Fraser
4701e5f8dc Remove querying e2e tests made redundant by backend test parity 2026-07-09 12:12:05 +12:00
Andrei Chernykh
18f5a74df7 Reject replacing a dashcard's card with a question internal to another dashboard (#77236) 2026-07-08 15:20:08 -07:00
Michael Eby
339d2c91b9 docs: add page for treemap visualizations (#77185)
* docs: add page for treemap visualizations

* Optimized 1 images, saved 237.8 KB (44.8% smaller)

* fix broken link

* Edits from Jeff

* Edits from Robert

* Edits from Jeff 2

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-08 16:21:36 -04:00
Ben Grabow
51e50d157c Avoid loading any H2 classes until/unless the H2 lib is on the classpath (#76842)
* Avoid loading any H2 classes until/unless the H2 lib is on the classpath
2026-07-08 14:15:03 -05:00
technomancy
c16d08579d Stop running metabase-enterprise.transforms-inspector-test in cloud DBs (#77231)
Stop running metabase-enterprise.transforms-inspector-test in cloud DBs.

These tests create new tables in the default schema, which is fine for
most drivers, but not for cloud DBs like snowflake and bigquery, because
concurrent CI jobs share the same jobs, which means this will cause test
failures in other unrelated tests which list tables, such as
metabase-enterprise.impersonation.driver-test/resilient-connection-options-test

We need to get these tests to stop creating tables in the default schema,
then we can drop the requirement for the :test/dynamic-dataset-loading feature.
2026-07-08 17:47:57 +00:00
Phoomparin Mano
07c824b6fb fix(sdk): derive dark mode color scheme based on sdk theme colors (#77269)
* add css variables for styled components

* commit loki snapshot change

* add resolved theme mocks

* use real theme color values
2026-07-08 16:24:19 +00:00
Nicola Mometto
6aa06eaa23 Fix notification seed legacy template paths (#77268)
* Fix notification seed crashing on pre-existing template rows

* add regression test
2026-07-08 16:58:49 +01:00
Andrei Chernykh
7876a74202 Uxw 4531 replace the group picker dropdown with a multiselect (#76648)
* Replace the group picker in the user form with a multiselect

* Port the tenant group-picker e2e steps to the new multiselect

* Add group-manager controls and a section separator to the multiselect, with chevron and Backspace fixes

* Fix external-default group ordering in the multiselect dropdown, with manager-flag and divider tests

* Update frontend/src/metabase/admin/people/components/GroupsMultiSelect/GroupsMultiSelect.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update remove-button test assertions for the group-specific aria-label

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2026-07-08 08:35:46 -07:00
dpsutton
c09cdbf49c Serialize static-viz GraalJS context creation (GHY-4077) (#77225)
* Serialize static-viz GraalJS context creation (GHY-4077)

Even with the shared-Source code cache (#77180), evaluating the bundle
in a fresh context churns through ~500 MB of allocation. That memory is
transient — allocated and discarded during the eval, with only ~10 MB
retained per extra live context — but it all still has to pass through
the heap. The dirigiste pool grows during render bursts, and nothing
stopped 2-3 context creations from running concurrently: ~1-1.5 GB of
allocation churn stacked on top of in-flight renders, which on a 2 GB
heap outruns the collector and drives GC thrash / OOM.

Serialize creation on a private monitor so at most one generate runs at
a time; waiting acquires just queue on the pool. Also jitter the
10-minute expiry timestamps (+/- 3 min) so pool members created in the
same burst don't all expire and regenerate in the same window.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Document static-viz pool memory model in namespace docstring

Capture what the OOM investigation measured so the pool's design
choices stay legible: engine + parsed sources ~220 MB retained (paid
once); fresh-context eval ~500 MB of collectable churn with only
~16 MB retained per live context (first-in-JVM cold parse ~1.2 GB);
renders ~1 MB/row transient. Also spell out why creation is serialized
on a monitor rather than time-throttled: bursts genuinely need
multiple contexts, so the pool still grows — just one creation at a
time.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 10:12:58 -05:00
Michael Eby
23825aec8e docs: add mcp + cli webinar callouts (#77191)
* docs: add mcp + cli webinar callouts

* Edit from Jeff
2026-07-08 10:29:39 -04:00
Chris Vandoodewaard
eca47dd2dc DEV-2270: add .bun-version file, configure setup-bun to use version file (#77208)
* add .bun-version file, configure setup-bun to use version file

* use package.json as the source of truth for the version of bun installed
2026-07-08 10:23:09 -04:00
Ngoc Khuat
8a7b431057 Fix redshift transform job dependency-detection flake (#77095) 2026-07-08 14:59:08 +01:00
Fraser
384f6fb9b7 Make test stats upload more robust (#77258)
* Make test stats upload more robust

* Fix trailing whitespace

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 13:47:04 +00:00
github-automation-metabase
b7fa7d73d2 Auto-update documentation for master (#77222)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-08 09:28:53 -04:00
github-automation-metabase
9d523b4604 Auto-update documentation for master (#77036)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-08 09:27:54 -04:00
Sébastien
951be524ec Fix embed preview stuck loader when reopening with a saved theme (#77150) 2026-07-08 15:06:28 +02:00
Ngoc Khuat
c518575acc run the incremental transform suite against all drivers (coverage probe) (#76793) 2026-07-08 11:56:27 +00:00
Ngoc Khuat
206ba7ee99 Don't fail dashboard subscriptions when a filter's default is an empty list (#77158) 2026-07-08 11:43:49 +00:00
Sébastien
e78a7c57e6 MCP Usage Analytics: storage, instrumentation, audit view, and admin page (MVP) (#76403) 2026-07-08 12:15:21 +02:00
Sergii Vozniuk
892974e74e Fix rendering of tenant avatars (#77075)
* Fix rendering of tenant avatars
* Remove unused Avatar code, cleanup initials logic, more explicit types
* Fix type used in isUser
* Stricter types to avoid initial bug in the future
2026-07-08 11:58:50 +02:00
Nemanja Glumac
1bec6455d3 Wire embedding tests to ci-conductor (#77184)
* Wire embedding tests to ci-conductor reporting

* Add ci-conductor quarantine gate to embedding Cypress jobs


Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-08 11:19:26 +02:00
Chris Truter
0149067bd7 execute_question: improve error codes (#77156) 2026-07-08 07:46:17 +00:00
Romeo Van Snick
54a2825522 Convert route-prop reference containers onto the metabase/router facade (#77067)
* Add withRouteProps facade shim for the router migration

* Convert DatabaseListContainer to a function component on facade hooks

* Put route-prop reference containers on withRouteProps

* Require route props in withRouteProps generic constraint

* Convert ScrollToTop from withRouter to useLocation hook form

* Fix merge fallout: rename RouteProps shim and repoint react-router imports
2026-07-08 16:23:09 +10:00
Romeo Van Snick
ca6033b698 Convert query_builder test loose ends to TypeScript (#76938)
* Convert query_builder test loose ends to TypeScript

* Rename ChartSettingsSidebar tests to match their assertions
2026-07-08 14:22:49 +10:00
Fraser
f6be96587f Delete dead frontend code (#77253) 2026-07-08 16:02:20 +12:00
Fraser
1bc18a3626 Consolidate reference-only components into reference/ (#77254) 2026-07-08 16:01:57 +12:00
Fraser
837a454620 Consolidate app banners into AppBanner (#77255) 2026-07-08 16:01:43 +12:00
Fraser
3127b4e8c3 Consolidate question-timeline UI into query_builder (#77256) 2026-07-08 16:01:26 +12:00
Romeo Van Snick
56879decb0 Migrate direct react-router usage onto the metabase/router facade + eslint ban (#77068)
* Facade re-exports full react-router surface via a single leaf seam

* Re-point all react-router imports onto the metabase/router facade

* Ban react-router imports outside the metabase/router facade (eslint)

* Migrate InviteToViewModal Link import onto metabase/router facade
2026-07-08 12:53:05 +10:00
Alexander Polyankin
d81c75451c Minify the static-viz bundle (#77234) 2026-07-08 02:18:57 +00:00
Alexander Polyankin
b48d367c21 Log only the error message for failed queries (#77223) 2026-07-07 21:38:18 -04:00
Denis Berezin
5c6e3e71fe UXW-4235 Transforms nav item permissions (#76705) 2026-07-08 01:29:14 +03:00
Alexander Polyankin
5e05b04e53 Pool error fix (#77212) 2026-07-07 17:00:26 -04:00
Timothy S. Dean
5a39e1adf8 Update version-helpers.ts for v63 (#77211)
Update version-helpers.ts for v63
2026-07-07 14:39:58 -06:00
Eric Normand
ff5e3b6973 Validate serialization dependencies before export (GHY-4010) (#76763)
* Add serialization-dependencies multimethod + Card impl (GHY-4010)

Foundation for export-time dependency validation. serialization-dependencies
runs on a raw appdb entity and returns its references tagged :content (must be
in the export) or :data (database/table/field that must exist in the appdb).
Unlike the load-time `dependencies` multimethod, it operates pre-serialization
and includes tables/fields, which import otherwise creates on the fly.

The Card impl derives content deps from `descendants` (so the two can't drift)
and adds data-model deps from the query via the lib walkers. Not yet wired into
the export pipeline.

* Replace escape analysis with general dependency validation (GHY-4010)

extract-subtrees now runs a dry-run pass (collect-dependencies) that shares the
real export's extract queries but neither serializes nor writes. For every entity
that will be extracted it derives serialization-dependencies and checks them:
content references must be in the visited/extracted set (or be analytics cards),
and data-model references (database/table/field) must exist in the appdb. Any
unsatisfied reference aborts the export (unless continue-on-error), before any
archive is produced.

This generalizes part A's Card-only, collection-id escape analysis: it now also
catches non-Card content escapees and dangling data-model references (a deleted
table/field that would otherwise serialize to a malformed [nil nil nil] ref).

Adds a Dashboard serialization-dependencies impl. Tests not yet updated.

* Update serialization tests for dependency validation (GHY-4010)

The dependency-validation warnings replace the old "Failed to export
Dashboard/Cards ... outside requested collections" messages with a uniform
"<entity> references <model> <id> which is not included in the export /
is missing from the source database" form, so the escape tests now assert
on the new wording. Adds dependency-validation-missing-data-ref-test, which
covers the new data-model case: a card referencing a deleted field aborts the
export (and continue-on-error still exports the rest).

* Fold dependency collection over a monoid, with batched queries (GHY-4010)

Replaces the nested reduce in collect-dependencies with a {:visited :deps}
monoid: entity-deps maps one entity to its contribution, merge-deps is the
associative combine (0/1/2-arity, usable directly as a transduce reducing fn),
and collect-dependencies folds every entity into the whole via a single
transduce. content-id-batches yields [model id-batch] pairs so each extract
query's :in :id clause stays bounded (query-batch-size 1000), and the data-dep
existence check is batched the same way. Behavior is unchanged.

* Flatten dependency collection into four transducer stages (GHY-4010)

entity-deps now reads its model off the entity (extract-query returns modeled
rows) instead of taking it as an argument, so collect-dependencies becomes a
flat pipeline: filter content models, resize into id batches, mapcat each batch
through extract-query into an entity stream, then map entity-deps — no eduction
nested inside the mapcat. Behavior unchanged.

* Move dependency validation into its own namespace (GHY-4010)

Extract the export-time dependency-satisfaction check out of
serialization.v2.extract into serialization.v2.dependency-validation. extract
now just calls dependency-validation/validate-dependencies! and keeps ownership
of the analytics-card set, which it passes in. The moved code carries this
session's cleanups (map-kv-vals for the existence lookup, set-based :deps).

Tests move to a matching dependency-validation-test namespace; the escape
assertion embedded in selective-serialization-basic-test stays with extract as
an extraction-level integration check.

* Address review: drop :kind, transients, cover segment/measure (GHY-4010)

Alex's PR comments on the raw dependency validation:

- serialization-dependencies no longer tags deps with :kind; it returns plain
  {:model :id} and the validator classifies each by model (serdes.models
  content vs data-model), since serdes already knows which is which.
- collect-dependencies accumulates into transient sets — an export can walk a
  lot of entities.
- Card serialization-dependencies now covers every reference in the query,
  including :segment and :measure (both data-model, existence-checked), via the
  lib walkers, closing the gap the field/table/card-only version had.

Refs embedded in parameter_mappings / visualization_settings / result_metadata
still aren't covered, and the raw serialization walker still duplicates the
serialized *-deps knowledge; both are tracked for the follow-up unification.

* Cover result_metadata and visualization_settings field refs (GHY-4010)

serialization-dependencies "Card" now gathers Field references from every
routine-backed source, not just the query:

- query: lib walkers (fields, tables, segments, measures, template-tag fields)
- result_metadata: each column's :id
- visualization_settings: the JSON-encoded column-setting keys, parsed with
  mb.viz/db->norm (the same routine the dependency-analysis project uses)

New test covers a field referenced only in visualization_settings. Field refs
buried in parameter_mappings / parameters value-fields are bare [:field ...]
clauses the lib walkers reject; those remain for the dep-walker unification.

* Rename `dependencies` multimethod to `deserialization-dependencies`

Makes the load-time dep multimethod parallel with the export-time
`serialization-dependencies`. `dependencies` runs on the serialized/ingested
form for load ordering and omits tables/fields (import synthesizes them);
`serialization-dependencies` runs on the raw entity and includes them. The
name now says which is which.

Mechanical rename of the defmulti + default + 19 impls across 18 models + 3
callers (load, metabot, remote-sync) + tests + doc-links. No behavior change.

* Address CodeRabbit: batch analytics lookup, fix test targeting (GHY-4010)

- analytics-card-ids batches the card-id :in via a partition-all transducer, so
  a large closure doesn't exceed database parameter limits (matches the batching
  already used in dependency collection).
- escape-report-test's ":parameters" case targeted coll2 (re-testing the
  source-table card); target coll3 so it actually exercises the parameter card.
- Correct the continue-on-error test wording: it suppresses the abort but does
  not skip the affected card at export (the malformed card is skipped on import).

* Unify serialization/deserialization dependency walkers (GHY-4010)

Make the mbql-deps walker family format-aware so a single traversal handles
both raw (numeric ids, export/serialization) and serialized (portable refs,
load/deserialization) forms, gated by *serialization?* / raw-ref-id?. Card and
Dashboard now share one deps helper across both dependency multimethods.

Implement serialization-dependencies for the remaining content models
(Action, Collection, Document, NativeQuerySnippet, Timeline), computing deps
from the raw entity: Action fetches its query_action child row; Collection
derives its parent from the raw :location path.

Refine export-time validation: a content reference to a deleted entity is not a
failure (export can't emit a portable id for a missing row, so fk-elide drops
it), and structural Collection references are ignored (a selective export may
omit the containing collection tree).

Tests: mbql-deps format-parity test, direct per-model serialization-dependencies
coverage, and the full baseline load->extract round-trip over every model.

* Trim duplicated dependency docstrings and consolidate abort tests (GHY-4010)

Dedupe the "content refs must be in export / data-model refs must exist"
explanation that appeared in four docstrings, and collapse the three
near-identical "delete a data-model ref -> export aborts" tests into one
parameterized test over Field/Segment/viz-settings references.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Share query-batch-size constant; use pos-int? for raw ref ids (GHY-4010)

Hoist the `:in`-clause batch size into a single serdes/query-batch-size
constant instead of a private def plus a bare 1000 literal in extract, and
tighten raw-ref-id? to pos-int? (entity ids are always positive).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Replace transient accumulator with a named merge-entity-deps monoid (GHY-4010)

The set-building is not the hot path (batched DB queries and the mbql walk
dominate), so drop the transients for a plain `merge-with into` monoid,
extracted as `merge-entity-deps` — the same idiom as u/traverse and
remote-sync's merge-incremental-export-plans.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fold partition-all into the existing-ids transducer (GHY-4010)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fold distinct into the existing-ids transducer too (GHY-4010)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Use peek and set-as-predicate in dependency validation (GHY-4010)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* SPIKE: thread allow-int-ids? param instead of *serialization?* dyn var (GHY-4010)

Replaces the *serialization?* dynamic var with an explicit allow-int-ids?
parameter threaded through the mbql walkers (mbql-deps/-map/-vector,
parameters-deps, visualization-settings-deps, viz-link-card-deps) and the
shared model helpers (card-deps, dashboard-deps, serdes-deps-dashcard,
result-metadata-deps). The name states the behavior: integer ids count as
references only when set (raw appdb entities), never on the serialized/load
form where a stray numeric must be ignored.

The parameter is mandatory everywhere — no default arities. Load-side callers
(measure/segment/transform/action deserialization impls) pass false; the three
serialization-dependencies impls pass true.

Spike to compare against the dyn-var approach; drop if we prefer that.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fix cljfmt: align card-deps destructuring continuation lines (GHY-4010)

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-07 20:22:39 +00:00
Alexander Polyankin
486296ff36 Graalvm pool with staticly parsed sources (#77180) 2026-07-07 15:27:15 -04:00
Nick Fitzpatrick
7f6472209d Move only show attachments toggle for email subscriptions (#77022)
* Move  only show attachments toggle for email subscriptions

* fix e2e test
2026-07-08 00:52:14 +05:30
Timothy S. Dean
f57fdc8258 Bump postgresql 42.7.11 -> 42.7.12 (#77181) 2026-07-07 12:36:22 -06:00
Chris Truter
705bda8519 feat(search): publish analytics for every search context (#76613) 2026-07-07 20:17:51 +02:00
appleby
a91da664b9 Do not compute related-tables or metrics in get-report-details (#76945)
Don't compute related-tables or metrics in get-report-details

`get-report-details` drops `:related_tables` and `:metrics` via a `select-keys`, so don't ask `card-details` for them.
2026-07-07 17:57:21 +00:00
Nicola Mometto
631e2c157f write-through cache for transform deps in ee only (#77079)
* write-through cache for transform deps in ee only

* kondo
2026-07-07 17:32:25 +01:00
Timofey Kachalov
01fa952fa7 Update httpcore5, httpcore5-h2 and httpclient5 versions (#77109) 2026-07-07 20:00:34 +04:00
Timothy S. Dean
d9ea875545 Bump handlebars 4.3.1 -> 4.5.3 (#77134)
* Bump handlebars 4.3.1 -> 4.5.3
* Add license for jnack/handlebars
2026-07-07 14:27:21 +00:00
Oleh K
3512caf5ee refactor: Migrate feedback, components, misc, upsell, illustration & admin color tokens (#76871)
* Migrate remaining color tokens to new names (GDGT-2535)

Migrate the remaining legacy design-system color tokens to their new
names per the GDGT-2517 migration guide:

- feedback: error/danger -> feedback-negative, success ->
  feedback-positive, warning/gold -> feedback-warning
- misc/core: info -> core-info, white -> core-white, shadow ->
  shadow-default, overlay -> modal-overlay, focus -> input-focus,
  metabase-brand -> core-metabase_brand
- admin: admin-navbar* -> navbar-admin*
- upsell/illustration: per guide
- remove unused bronze/copper/silver

Covers all reference forms: CSS `var(--mb-color-*)`, `color()`/helper
calls, Mantine `c`/`bg`/`color`/`iconColor` props (string and ternary),
object-literal `color:`/`iconColor:` keys, `ColorName` return values,
arrays, and `Record<_, ColorName>` value maps. Tightens `Undo.toastColor`
from `string` to `ColorName` so future token removals fail at compile
time. Maps the `Alert` component's semantic `color` prop to feedback
tokens internally so its call sites stay unchanged.

Also sweeps up brand/filter/summarize consumer stragglers left over from
the earlier (merged) migration. SDK/whitelabel input keys, the
derive-theme alias definitions, and static-viz's local palette are left
on their existing names by design.

* Migrate missed success-secondary props in StepperWithCards

The .module.css was migrated to feedback-positive-selected but the two
inline c="success-secondary" props (Done check icon + label) were missed.

* Update Loki Snapshots

* Fix toastColor type widening in metabot toast-prop helpers

Undo.toastColor tightened to ColorName in this branch; the two get*ToastProps
helpers returned object literals where toastColor widened to string (missing
as const, unlike their iconColor/dismissIconColor siblings).

* Update TransformListPage sync-color spec to migrated feedback token names

utils.ts color map was migrated (success/warning/danger -> feedback-*) but
the spec assertions still expected the old names.

* Update SDK theme + treemap specs for feedback/misc token mirrors

- get-embedding-theme: SDK mapping now fans text-white->core-white and
  focus->input-focus, so the expected override gains those keys.
- treemap option: getColor("white") became getColor("core-white"); add
  core-white to the test's MOCK_COLORS palette.

* Update Loki Snapshots

* Update toast color-attr assertions to migrated feedback token names

* Cleanup

* Migrate remaining color tokens in Button and Table stories

* Add explainer comment for colors naming convention

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-07 15:34:02 +02:00
Kamil Mielnik
63716689ad GDGT-2771 Remove redundant type casts (#77078) 2026-07-07 19:39:25 +07:00
Oleh K
a7e7e5ac5b fix: Toaster crash on long-running questions from color-mix tokens (#77152)
* fix: Toaster crash on long-running questions from color-mix tokens

The Toaster's styled-components computed colors at render time with the
JS `color` library (via the deprecated lighten()/alpha() helpers). One
of the tokens they parsed, `background_page-tertiary-inverse`, is now
defined as a color-mix() value, which the `color` library can't parse —
so it threw "Unable to parse color from string" and crashed.

Replace those runtime helper calls with CSS color-mix on the variables
directly, so the mixing happens in CSS where color-mix()/var() resolve.

* Adjust dismiss color
2026-07-07 11:43:43 +02:00
Nemanja Glumac
6b5c699c22 Make e2e modal selector slightly more accessible (#76975) 2026-07-07 09:39:39 +02:00
Romeo Van Snick
2a8bbb797c Add v7 conformance tests for the metabase/router facade (#77064)
* Add react-router v7 as a test-only aliased devDependency

* Add differential conformance harness for the router facade

* Add v7 conformance test for useLocation

* Add v7 conformance test for useParams

* Add v7 conformance test for useNavigate

* Add v7 conformance test for useSearchParams

* Add v7 conformance test for Navigate

* Add v7 conformance test for useSearchParams defaultInit

* Pin react-router v7 to 7.18.1 for conformance

* Add type-level conformance tests against react-router v7

* Guarantee cleanup between facade and v7 renders in runBoth
2026-07-07 15:28:44 +10:00
Romeo Van Snick
c16bdc6c32 Migrate DatasetEditor DatasetNotebook and DatasetFieldMetadataSidebar to TypeScript (#76971) 2026-07-07 15:28:20 +10:00
Romeo Van Snick
c1e5037657 Migrate query builder View components and tests to TypeScript (#76972)
* Migrate ChartSettingsSidebar unit test to TypeScript

* Migrate DatasetMetadataStrengthIndicator unit test to TypeScript

* Migrate QuestionDataSource unit test to TypeScript

* Migrate ViewTitleHeader unit test to TypeScript

* Correct onSave return type to Promise<void> and relax Toaster className

* Migrate query builder View components to TypeScript

* Preserve collection type on move and tighten timeline callback types

* Remove dead onCloseQuestionInfo prop from structured sidebar
2026-07-07 15:27:41 +10:00
Fraser
aae7c76e84 Integrate e2e coverage into module graph (#74621) 2026-07-07 16:39:30 +12:00
Tyler Plude
c8ede8c5c5 Pin maildev to 2.2.1 (#77143)
pin maildev to 2.2.1
2026-07-06 18:56:25 -07:00
YB
1b244fdd43 pin @babel/core to 7.29.7 (#77044) 2026-07-07 09:36:03 +08:00
Alexander Polyankin
c109d4fbc6 Add backend test parity for MBQL lib / QP behaviors covered only by e2e tests (#77062) 2026-07-06 20:35:33 -04:00
appleby
16eefb159d Remove enhanced-database-tables and provide columnless tables in metabot context :used_tables (#76944)
`enhance-context-with-schema` resolved each `:user_is_viewing` item's used tables and then ran them through
`table-utils/enhanced-database-tables`, which fetched and formatted the full visible-columns set for every used table, including all implicitly-joinable columns from related tables. That work was discarded anyway since columns were recalculated via `entity-details/get-table-details` when rendering the context. On large, highly-connected schemas this could load thousands of columns into the request metadata cache and exhausted the heap (metabase#76493).

`:used_tables` entries now carry only `{:id :type :name :database_schema :description}`. name/schema/description are kept for the `simple-entity` error fallback. `enhanced-database-tables` had no other callers, so it is removed.
2026-07-06 15:58:03 -07:00
Braden Shepherdson
931afd85c5 [PDFs] Support emoji (#77034)
Fixes UXW-4704.

Support emoji in PDF rendering - in card titles, text cards, and the dashboard title.

These are monochrome only, since monochrome emoji are regular font glyphs. Colour emoji requires unusual bitmap-backed font support, and the PDFBox engine doesn't support that. It could be done, but it would require rendering the emoji glyphs to PNGs, then embedding those in the PDF. It's not worth the effort or including a bulky bitmap emoji font for a cosmetic feature.

This includes the Noto Emoji font in the JAR, and adds the Open Font License notice file covering all the PDF fonts.
2026-07-06 20:55:13 +00:00
Tyler Plude
79002d4666 [BOT-1442] Fix metabot silently producing non-runnable MBQL (#76133)
* fix Metabot construct_notebook_query silently producing non-runnable queries

* trim overly verbose docstring

* pr feedback
2026-07-06 20:07:24 +00:00
Romeo Van Snick
a7b48d8ca8 Convert remaining NativeQueryEditor js files to TypeScript (#76948) 2026-07-07 06:07:07 +10:00
Eric Normand
843ddfa348 Fix transforms-root breadcrumb link in remote-sync changes list (GHY-3901) (#77113)
The "Transforms" group header in the push/pull changes list is backed by a
virtual collection with the sentinel id -1 (TRANSFORMS_ROOT_ID). Every -1 case
is special-cased in displayGroups.ts except the header breadcrumb, so the
sentinel flowed into collectionUrl({ id: -1 }) and produced a dead
/collection/-1-transforms link (a hyphen at the start of the last path segment).

Link the transforms-root segment to the transforms list (/data-studio/transforms)
instead. Covers both the virtual-root group and the transforms-namespace prefix
on sub-collections, since the guard sits at the single render site.
2026-07-06 19:39:13 +00:00
appleby
b7262df217 Whitelist anthropic and bedrock models (#76768)
* Whitelist bedrock models

* Whitelist anthropic models

* Add claude-fable-5 to supported-models for bedrock and claude providers

* Include a display_name for all supported-models

* Filter to available-model? in bedrock's list-models
2026-07-06 19:14:32 +00:00
Eric Normand
8bb5162d89 Fix snippet template-tag id churn in serdes round-trip (GHY-4067) (#77112)
Snippet template-tag ids were regenerated on every serdes import: YAML
ingest keywordizes the tag-name keys, so the NativeQuerySnippet load hook
could not match them to preserve the existing :id and minted a fresh UUID
instead. In a remote-sync import/export loop this produced a spurious id
diff for every snippet with variables on every cycle.

Normalize :template_tags on import in make-spec so the tag-name keys are
strings before the model hooks run; export is unchanged. Add a round-trip
regression test asserting template-tag ids survive export/import.
2026-07-06 19:09:51 +00:00
Eric Normand
0605e0352f [GHY-3974] Fix Usage Analytics breaking after upgrade (two failure modes) (#76551)
* [GHY-3974] Add failing tests for Usage Analytics upgrade failure modes

Two invariant tests covering the audit-DB upgrade breakage, asserted
through ensure-audit-db-installed! so they're independent of the fix
mechanism and leave the generic sync path untouched:

- Mode A (audit-db-self-heals-duplicate-rows-from-stale-schema-test):
  an interrupted host-adjust + schema sync duplicates a v_* view row and
  retires the original, breaking customer content. ensure-audit-db-installed!
  must reconcile back to one active row per view and keep dependent content
  on an active table.

- Mode B (checksum-not-advanced-until-host-adjust-completes-test):
  last-analytics-checksum must not advance if adjust-audit-db-to-host! is
  interrupted, so the next boot re-runs the load and the host-adjust.

Both fail on master.

* [GHY-3974] Fix Usage Analytics upgrade failure modes

Mode B (checksum committed before host-adjust): in maybe-load-analytics-content!
advance last-analytics-checksum only after adjust-audit-db-to-host! completes,
so an interrupted host-adjust leaves the checksum behind and the next boot
re-runs the load + adjust. Also force a reload, regardless of the checksum, when
audit tables are stuck at the postgres "source" schema on a non-postgres host
(audit-db-in-source-state?) so already-corrupted instances self-heal.

Mode A (schema-renamed view duplicated + retired by sync): add
reconcile-audit-db-duplicates!, run on every ensure-audit-db-installed! so
already-corrupted instances (whose checksum already matches, skipping the load)
still recover. For each duplicate same-name group in the audit DB it keeps the
row dependent content points at, repoints stray report_card.table_id refs to it,
normalizes it to the host-canonical name/schema, and deletes the orphans. Schema
is derived from the host engine, not the surviving row, so a duplicate left at
the postgres source schema (Mode B masking Mode A) is corrected too. Scoped
entirely to the audit DB; the generic sync path is untouched.

Both audit-test regression tests pass on h2 and postgres.

* [GHY-3974] Serialize audit DB load/adjust/sync across nodes (1b)

with-duplicate-ops-prevented is per-process only, so on a rolling upgrade
two pods could run the audit load/adjust/sync concurrently and produce the
half-applied schema states behind both failure modes. Wrap the
load+adjust+sync+reconcile in an app-DB cluster lock (metabase_cluster_lock)
so only one node runs it at a time. If another node already holds the lock it
is doing the same work, so skip rather than fail the boot.

The sync must run inside the lock to be serialized, so maybe-sync-audit-db!
now runs synchronously instead of in a background future: on a transactional
appdb a sync on another thread would escape the lock's transaction and
deadlock against its uncommitted metabase_table writes.

Full audit-app namespace passes on h2 (in-process RW lock) and postgres
(transaction + SELECT FOR UPDATE), 52 assertions each.

* [GHY-3974] Filter audit view lookups in SQL, not in memory

audit-view-table and the Mode A heal assertion were selecting every active
audit table and filtering by lower(name) in Clojure. Push the predicate into
the query with a lower(name) where clause.

* Better comments

* [GHY-3974] Don't force a reload for an inactive public orphan (MySQL fix)

audit-db-in-source-state? treated any `public`-schema audit table on a
non-postgres host as the interrupted-host-adjust state and forced a reload.
But a Mode A duplicate leaves an *inactive* `public` orphan, and on MySQL
(canonical schema NULL) forcing a reload made adjust-audit-db-to-source!
move the active NULL row to `public`, colliding with the orphan on the
(db_id, schema, name) unique index (Duplicate entry '…-public-v_content').

Only active rows signal the genuine stuck source state; inactive public rows
are retired orphans handled by reconcile-audit-db-duplicates!. Restrict the
check to active rows. Surfaced by the MySQL/MariaDB app-db CI run of
audit-db-self-heals-duplicate-rows-from-stale-schema-test.

* [GHY-3974] Update modules config: audit-app no longer uses config

Removing the metabase.config.core require from the audit-app module (the
unused config dep dropped when the sync future was removed) leaves config
out of enterprise/audit-app :uses. Fixes modules-config-up-to-date-test.

* [GHY-3974] Only swallow lock-contention failures for our own audit lock

A different cluster lock's acquisition failure raised from inside the locked
body (e.g. the permissions lock taken when serdes inserts a Database) also
carries :lock-names; it must propagate rather than be swallowed as audit
contention and silently abandon the load.

* [GHY-3974] Bail faster on audit lock contention

Drop the lock-acquisition timeout to 5s and retries to 2, so a node that loses
the boot-time audit lock skips in ~17s instead of ~150s. The work is idempotent
and the lock holder is doing it, so a losing node need not win; keeping a couple
retries still lets a node pick up the work if the holder crashes mid-load.

* [GHY-3974] Serialize audit DB install/adjust under the cluster lock too

The install-time adjust-audit-db-to-host! + schema sync (the ::installed and
::updated branches of maybe-install-audit-db!) previously ran outside the
cluster lock, so two nodes detecting an engine mismatch could adjust and sync
concurrently against a half-adjusted schema. Move install inside the lock so the
whole install+adjust+load+sync+reconcile is serialized across nodes; a node that
acquires the lock after the installer commits sees the DB already exists and
no-ops instead of colliding on the audit DB primary key.

* [GHY-3974] Harden reconcile-audit-db-duplicates! and Mode B test

- Sort rows by id before grouping so survivor selection (including the
  referenced? tiebreak) is deterministic regardless of appdb row order.
- Clear is_defective_duplicate on the survivor so it re-enters idx_unique_table
  (a flagged row has a NULL unique_table_helper and is excluded from the index).
- Comment why orphans are deleted before the survivor is re-canonicalized.
- Mode B test: move cleanup into a finally and reinstall the audit DB so an
  unexpected throw can't leave sibling tests without an audit DB.

* [GHY-3974] Make reconcile lossless: move content off orphans before deleting

The previous reconcile did (t2/update! :model/Card {:table_id orphan} {:table_id survivor})
then deleted the orphan. That update is a no-op — Card's before-update populate-query-fields
re-derives table_id from the unchanged dataset_query — and report_card.table_id is ON DELETE
CASCADE, so deleting the orphan destroyed any customer card whose query pointed at it. This
happens in real Mode A: bundled audit cards reference the retired row (making it the survivor)
while a customer question built during the corrupted window references the freshly-synced active
row (the deleted orphan).

Now repoint-cards-to-survivor! rewrites each referencing card's dataset_query (source-table)
and result_metadata, remapping field ids onto the survivor's same-named fields, before the
orphan is deleted. Handles both pMBQL and legacy field refs.

Adds audit-db-reconcile-preserves-content-on-the-deleted-duplicate-test, which asserts the card
survives and its field refs resolve to active fields on the survivor (fails on the old code).

* [GHY-3974] Use lib field-ref helpers instead of hand-indexing refs

repoint-refs now reads/writes the field id via lib/field-ref-id and
lib/with-field-ref-id rather than indexing the ref vector by position. Expose
with-field-ref-id from metabase.lib.core (the setter alongside the already-public
field-ref-id getter) so it's reachable through the lib module's public API.

* [GHY-3974] Use lib clause predicate / field-ref-id for remaining MBQL access

Replace the hand-rolled field-ref? predicate with lib/clause-of-type?, and the
positional field-id extraction in the test with lib/field-ref-id.

* better docstring

* [GHY-3974] Order reconcile rows in the query instead of in memory

Address review: let the DB sort (:order-by [[:id :asc]]) rather than sort-by; group-by
preserves the order within each group, keeping the survivor tiebreak deterministic.

* [GHY-3974] Move query id-remap into lib; handle result-metadata thoroughly

Review (@metamben): the ref manipulation should live in lib and be general-purpose,
and queries vs result metadata shouldn't share one generic walker.

- Add metabase.lib.walk.util/replace-field-ids and replace-table-ids (general, built on
  lib.walk): field refs everywhere via walk-clauses (filters/aggregations/breakouts/joins/
  nested stages), :source-field/:fk-field-id opts, native :template-tags :dimension refs, and
  :source-table per stage/join. Exposed via metabase.lib.core.
- audit-app repoint-cards-to-survivor! now rewrites dataset_query via the lib helpers, and
  handles result_metadata separately (non-generic): :id, :fk_target_field_id, and :field_ref
  covering both legacy ([:field id opts]) and pMBQL ([:field opts id]) shapes.
- Test asserts legacy result_metadata :field_ref is remapped onto the survivor.

Covers review threads: field-ref manipulation in lib (#383), FK/source-field refs (#418),
legacy result-metadata refs (#392).

* [GHY-3974] Batch the reconcile referenced? check into one query

Address review: instead of a t2/exists? per row in a duplicate group, fetch the set of
card-referenced table_ids for the whole group in a single query and test membership.

* [GHY-3974] Review cleanups: cond-> in replace-field-ids; update-existing in result-metadata remap

- lib replace-field-ids: use cond-> for the template-tags/:dimension updates instead of if/else.
- audit remap-result-metadata: use m/update-existing with an identity-for-unmapped fn instead of
  a cond-> with duplicate lookups; drop the redundant pos-int? guard in remap-result-metadata-ref
  (field-id-remap is always a map, so it already returns nil for names/nil).
2026-07-06 19:07:41 +00:00
Aleksandr Lesnenko
fc54b654f4 disable coderabbit PR summaries (#77114)
* disable PR summaries

* disable coderabbit yapping when skipped
2026-07-06 19:03:17 +00:00
Braden Shepherdson
2a8b0fdefe [PDFs] If a Visualizer card has a name override, use it (#77033)
Fixes UXW-4705.

Also refactors the duplicated logic from two other places in the
subscriptions rendering into a new `render.util` helper.
2026-07-06 18:39:19 +00:00
Aleksandr Lesnenko
851cb65a11 coderabbit config (#77111) 2026-07-06 18:24:09 +00:00
Chris Vandoodewaard
62e3bb098e onboarding: add Github username to team, add Github -> Slack ID mapping (#77110)
Add Github ID to DevEx team, map Github ID to Slack ID
2026-07-06 18:22:08 +00:00
Nick Fitzpatrick
6bf214f2c2 update Echarts to 6.1.0 (#75139)
* echarts 6.1.0

* adjusting BE test
2026-07-06 23:44:56 +05:30
Nick Fitzpatrick
77eb75ecd0 improving Pivot table and and object detail PDF renders (#76728)
* improving Pivot table and and object detail PDF renders

* pivot table improvements
2026-07-06 23:41:59 +05:30
Nick Fitzpatrick
2080e7c13f Handle PDF uploads to slack user DMs (#76787) 2026-07-06 23:22:46 +05:30
Braden Shepherdson
78e968bd69 Use a much larger maximum nesting limit while parsing YAML (#76528)
Fixes UXW-3770.

The default limit of 50 levels of nesting is too small for deeply nested
MBQL expressions, such as a `replace(replace(replace(...)))` tower.

This PR raises the limit to 10k, and includes a test that 500 levels
parses fine. 10k works at my REPL but I don't want to commit a test like
that in case other JVMs hit a `StackOverflowError`. Rejecting the import
is a better UX than crashing Metabase!
2026-07-06 13:07:47 -04:00
Braden Shepherdson
636276120b Make /api/cache/invalidate endpoint return 400 for missing filters (#76364)
Fixes UXW-4108.

When no `database`, `dashboard` or `question` parameter is supplied, the
endpoint does not invalidate anything. It previously returned a 404 in
that case, indicating that nothing was found to invalidate.

But since no attempt to invalidate anything is made without at least one
of those parameters, the 404 was misleading. Instead, this malformed
request should return a 400, which it now does.

No impact to the Metabase FE, which only ever calls this endpoint with
the parameters supplied.
2026-07-06 13:07:34 -04:00
Tyler Plude
b0682e0144 [BOT-1776] Show cache read tokens in usage analytics (#76847)
show cache read tokens in usage analytics
2026-07-06 09:34:15 -07:00
Braden Shepherdson
4682a713c8 [PDFs] Regression test: hide "no results" cards per the setting (#77032)
Regression test for UXW-4706, which was fixed in #76918.
2026-07-06 12:29:28 -04:00
Andrei Chernykh
eae64a014a Invite someone to view a dashboard or question (#76444)
* Add an Invite someone to view this action to dashboard and question share menus (#76209)

* Add an Invite someone to view this action to dashboard and question Share menus

* Update admin create-user e2e to reveal the temporary password via the new toggle

* Add a shareable item link to the invite modal's no-email states

* Remove the stale password-toggle aria-label and reword the temp-password invite copy

* Land invited users on the shared dashboard or question after signup (#76505)

* Land invited users on the shared dashboard or question after signup

* Scope the invite email to the shared dashboard or question

* Code cleanup

* Polish the invite email's join button spacing, label, and padding

* Remove stale TODO about synchronous invite email

* Add tests for invite someone to view (unit + e2e) (#76589)

* Add unit and e2e tests for the invite-to-view feature

* Fix the invite-to-view e2e signup button and no-access selectors

---------

Co-authored-by: Nathan Voxland <nathan@metabase.com>

* Add user_invited and invite_to_view_opened analytics events (#76646)

* Add user_invited and invite_to_view_opened analytics events

* Reword the external-invite tracking comment in NewUserModal

* Type isEmailAlreadyInUse's error with a guard instead of a cast

* Return an error_code for the duplicate-email 400 and key isEmailAlreadyInUse off it

* Move invite-events analytics into common/analytics and assert events fire once

---------

Co-authored-by: Nathan Voxland <nathan@metabase.com>
2026-07-06 08:39:46 -07:00
Braden Shepherdson
2c6e6b806d [pdf] Remove branding for white-labeling customers (#76426)
Fixes UXW-4575.

The "Made with Metabase" branding is skipped for customers with white-labeling enabled.
2026-07-06 15:07:02 +00:00
Braden Shepherdson
2f98715cbc [PDFs] Respect the explicit text alignment setting for Markdown cards (#77031)
Fixes UXW-4703.
2026-07-06 10:45:54 -04:00
Brad Anderson
69c3756253 GRO-536 replace ad hoc metaplow functions with @metabase/track alpha (#76618) 2026-07-06 10:10:06 -04:00
Sébastien
344861dd67 Link to usage conditions in the theme preview acceptance prompt (#77072) 2026-07-06 15:38:21 +02:00
Jakub Chodorowicz
3487a7801f GDGT-2750: Treemap renders incorrectly in PDF export (#76996)
* fix treemap wrong size in grid driven pdfs

* add missing loki screenshot
2026-07-06 15:19:43 +02:00
Kevin Kelleher
1fbea58471 Fix tooltips showing incorrect date ranges for native queries (#76295)
* don't format native query weekly dates as ranges in tooltips

* delete e2e test for 25007
2026-07-06 07:41:05 -04:00
Oleh K
605c237a1a Allow map tile server host in img-src CSP (#76967)
* fix(custom-viz): allow map tile server host in img-src CSP

When Custom Visualizations are enabled, csp-img-enabled is forced on,
switching img-src from a permissive wildcard to a restricted allowlist.
Map tiles (OpenStreetMap by default, or a custom map-tile-server-url)
were never added to that allowlist, so map visualizations broke.

Automatically add the configured tile server's origin to img-src,
mirroring how custom font files are added to font-src. The {s} subdomain
placeholder becomes a * wildcard and the {z}/{x}/{y} path is dropped.

* docs: note map tile server is always allowed under restricted image domains

* Missing update to setting description

* Update comment

* Fix whitespace
2026-07-06 08:06:46 +02:00
Romeo Van Snick
b2d81611cc Build the metabase/router facade for react-router v7 (#76859)
* Rename router useRouter to kebab-case use-router

* Add router facade shared types and path/search utils

* Add useNavigate facade hook

* Add useLocation facade hook

* Add useParams facade hook

* Add useSearchParams facade hook

* Add Navigate facade component

* Add Outlet facade shim

* Add Link facade re-export

* Reference react-router v7 docs from each facade helper

* Lock facade tests to react-router v7 behaviour

* Import useRouter from the metabase/router barrel

* Sort metabase/router barrel exports

* Test useNavigate splits query from a string destination with state

* Test setSearchParams clears the query when called with no argument

* Use router/<name> pattern for facade test describe blocks

* Link react-router v7 API reference from facade types

* Use react-router's official descriptions for facade type comments

* Use useMount instead of a bare useEffect in Navigate

* Expand inline JSDoc in router utils to multiline

* Implement useNavigate over v3 history instead of redux dispatch

* Navigate via react-router's router API instead of history directly

* Re-navigate on prop change in Navigate to match v7

* Default useLocation state to null and note v3 helper limitations

* Pass Navigate state by reference and clone search-param updater arg

* Expose v3 splat param under v7's * key in useParams

* Drop the existing hash in setSearchParams to match v7

* Churn useNavigate identity per navigation to match v7

* Support defaultInit in useSearchParams to match v7

* Match v7's URLSearchParamsInit pair-tuple type

* Match v7's useParams generic signature
2026-07-06 09:08:31 +10:00
Alexander Polyankin
af81edb346 Revert "Enable streaming results for app db queries with postgres" (#77048)
Revert "Enable streaming results for app db queries with postgres (#76645)"

This reverts commit 49cc599892.
2026-07-05 04:55:18 -04:00
Denis Berezin
dc91702b6b UXW-4658 Fix viz settings dropdown broken styles (#76845) 2026-07-04 01:47:49 +03:00
Braden Shepherdson
b8d634be90 [PDFs] Reuse query results and PNG rendering memory pools for PDFs (#76918)
The work done in #76355 and #76504 to fix some OOMs while generating
subscriptions modified the core rendering pipeline (static viz charts to
PNGs) concurrently with the work happening on PDFs.

This adapts the PDF generation to reuse both in-memory and on-disk query
results, and to use the whole-dashboard budget of results in memory before
spilling to disk. Cleans up all temporary files when finished.
2026-07-03 16:01:30 -04:00
Nathan Voxland
471df8492b Add request info to 'Request canceled before finishing' log line (#77023) 2026-07-03 14:20:45 -05:00
technomancy
e0ad467236 Take existing tables into account when determining already-loaded bigquery (#76936)
Take existing tables into account when determining already-loaded bigquery.

We no longer have bigquery tables that constantly think that they need
to be recreated, but we have fallen a little too far in the other
direction; datasets that get their DB created but fail midway thru
will still be treated as loaded.

In snowflake we have a way of checking this down to the individual row
counts and counting as not-already-loaded if there's a mismatch. I
don't see a way to do this in bigquery, but we can at least check that
all the tables exist. If we get a failed partial load that gets all
the tables created but fails the rows that will still require manual
intervention.

Also stop using (config/current-major-version) when qualifying dataset
names; turns out this is not at all reliable in CI. This unfortunately
means that we don't actually have cross-major-version isolation; the
best we can do is isolate master/release from all other branches,
which is still an improvement over what we have now.
2026-07-03 17:26:34 +00:00
Timofey Kachalov
eac68e3fe9 Update c3p0 version (#77000) 2026-07-03 20:30:28 +04:00
Alexander Polyankin
d141f2f00e jdbc-data-warehouse-connection-pool-max-pending-checkouts (#77004) 2026-07-03 16:19:41 +00:00
metamben
5c0455b3ec Stop pretending the cache is up to date (#76898)
Closes GIT-10454
2026-07-03 18:38:33 +03:00
Mihael Konjević
a9ceb5f20d Drop unsupported get-day-of-week week-modes in repair (#76766)
`get-day-of-week` accepts a positional week-mode, and the ::week-mode
schema admits :iso, :us, and :instance (shared with get-week). But only
the default (no-mode) and :iso forms have a lowering in lib.filter.desugar
— :us and :instance desugar to a nil temporal-extract unit and 500 at SQL
compile time (observed: an LLM emitting "instance" for "day of week on
weekends"). Drop the unsupported mode, leaving the start-of-week-aware
default. :iso and the bare form are untouched.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-03 17:13:57 +02:00
Mihael Konjević
df0986902c Sharpen Metabot data-source discovery and construct guidance (#76767)
Prompt-snippet updates, independent of any code change:
- discovery: search to choose a source, navigate to drill in (don't skip
  the curated layer just because a raw table name is recognizable)
- data-sources: a source the user explicitly names is authoritative
- grounding: when several columns plausibly match, read descriptions and
  sample values rather than picking by name resemblance
- construct_notebook_query: a "translating the request" section (constraint
  vs breakout, apply every constraint, absolute vs relative dates)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-03 17:13:47 +02:00
Timofey Kachalov
9b3fe8e0ea Pin jackson-databind for databrocks/redshift/snowflake drivers (#76980) 2026-07-03 19:06:40 +04:00
Chris Truter
7ed335db9c Decouple library-retrieval and semantic-search features (#76872) 2026-07-03 15:31:06 +02:00
Timofey Kachalov
b83ac24d1e Update esbuild to 0.28.1 (#76908) 2026-07-03 17:16:51 +04:00
Alexander Polyankin
c32c55c589 MB_JDBC_DATA_WAREHOUSE_CONNECTION_POOL_CHECKOUT_TIMEOUT_MS (#76941)
* MAX_JDBC_DATA_WAREHOUSE_CONNECTION_POOL_CHECKOUT_TIMEOUT_MS

* use same dox

* fix

* fix

* fixes
2026-07-03 12:44:44 +00:00
Benoit Vinay
84b27f02a5 utm query params for docs search (#76674)
* utm query params for docs search

* Misc

* Copy updates
2026-07-03 14:39:22 +02:00
Timofey Kachalov
863d48e920 Pin jackson-databind for bigquery-cloud-sdk (#76899) 2026-07-03 09:09:46 -03:00
lbrdnk
06d3dd8cb4 Support creation and and update of a metric through mcp (#76809)
* Support creation and metric update through mcp

* kondo
2026-07-03 12:46:33 +02:00
Oleh K
bfdce241fe Make custom-viz dev-mode hot reload reliable (#76739)
* fix(custom-viz): make dev hot-reload resilient to transient failures

When the dev server is mid-rebuild its bundle endpoint can transiently
fail, and rapid edits / overlapping reloads could leave the viz showing a
stale bundle or a spurious "unavailable" toast.

- Backend: fetch-dev-bundle returns nil on upstream failure (mirroring
  fetch-dev-manifest) so the endpoint serves its existing retryable 503
  instead of a hard 500.
- Frontend: retry the dev bundle fetch on transient 5xx (fail fast on
  4xx), and tag each load with a monotonic sequence so a slower/older
  overlapping load can't overwrite a newer applied bundle or fire a stale
  toast (latest-wins).

* fix(custom-viz): render the freshest bundle after overlapping dev reloads

Overlapping dev reloads (rapid edits) could apply the newest bundle to the
visualizations registry but leave the chart rendering an older one: the
visualization only re-reads the registry when it remounts on the loading
toggle, and a plain boolean cleared after the first load resolved.

- Refcount in-flight loads so `loading` stays true until the last settles,
  so the single remount reads the freshest registered bundle.
- Stop retrying a load once a newer one has started (it would be discarded
  by the latest-wins guard anyway, and would keep `loading` held).

* fix(e2e): restore custom-viz dev plugin source between retries

The development-mode custom-viz test mutates the scaffolded plugin
source in place ("Above threshold" -> "Way above!") to verify hot
reload, but never reverts it. Since `before` does not re-run on a
Cypress retry, a retried attempt started from the mutated file and the
opening "Above threshold" assertion timed out against stale state.

Capture the pristine source in `before` (after the clean re-scaffold)
and rewrite it in `afterEach` so each attempt starts from the default.

* fix(e2e): use frozen lockfile for custom-viz SDK bun install

Skip lockfile resolution during the dev-mode `before` hook so the
install step is deterministic and faster, reducing the chance of the
120s setup timeout.

* fix(e2e): start custom-viz dev server per test, not per suite

The dev-mode test stops the dev server as its final assertion (revert to
default), but the server was started once in `before`. Since `before`
does not re-run on a Cypress retry or during burn-in, every run after the
first hit a dead server and failed at "verify the dev plugin is
registered".

Move the server start to `beforeEach` and the stop to `afterEach` (the
stop task is idempotent), keeping the heavy build/scaffold/install in
`before`.

* chore(custom-viz): trim verbose comments per review

* refactor(custom-viz): reuse retry util for dev bundle fetch

* fix(custom-viz): use > not >= in superseded check

The == case is impossible (loadAppliedSeq is only set to a load's own seq
on success, which returns before the catch; seqs are unique), so >= and >
are equivalent here. > matches the sibling loadStartedSeq check and reads
as "a strictly newer load exists".

* fix(custom-viz): only the latest-started load registers its bundle

The apply-guard bailed only when a newer load had already applied; bail
when a newer load has merely started too (applying implies starting, so
this subsumes the old check). Reuses isLatest(), consistent with the
retry loop and the superseded check.

* refactor(custom-viz): name load-sequence maps by plugin id

* test(custom-viz): scaffold dev plugin per attempt instead of capturing source

Move the plugin scaffold (init + npm i) into beforeEach so each attempt
starts from a pristine source, dropping the pristineSrc capture/restore.
The expensive SDK build stays one-time in before.
2026-07-03 12:37:31 +02:00
Timofey Kachalov
3777617772 Update @hey-api/openapi-ts (#76897) 2026-07-03 14:17:57 +04:00
Sébastien
06ed290471 Fix crash when editing column settings in the embedding SDK (#76795)
* fix crash when editing column settings in embedding SDK

* add e2e test for editing native question column title in embedding SDK
2026-07-03 11:51:23 +02:00
Oleksandr Yakushev
7afc643c0c [lint] Implement Kondo hooks for metabase.util.match macros (#73986) 2026-07-03 12:31:46 +03:00
Mahatthana (Kelvin) Nomsawadi
960b9fa2d1 Gate SDK query builder controls on create-queries permission (#76862)
* fix(embedding-sdk): gate query builder controls on create-queries permission

Filter/Summarize/Breakout dropdowns and the notebook editor toggle rendered
regardless of query permissions, showing non-working controls for users
without create-queries access. Mirrors main app's FilterHeaderButton/
QuestionSummarizeWidget/QuestionNotebookButton gating (isEditable, !isNative,
!isArchived) via a new shouldRenderQueryBuilderEditingControl.

Fixes EMB-1963

* test(embedding-sdk): unit test shouldRenderQueryBuilderEditingControl

Covers editable/native/archived/no-question cases, plus the missing
create-queries case by building a query against metadata with the source
table excluded (mirrors what the backend does when that permission is
missing) rather than mocking metabase-lib.

* fix(embedding-sdk): hide decorative icon from ToolbarButton accessible name

Icon set role="img" aria-label="<name> icon" unconditionally, so a button's
accessible name became "filter icon Filter" instead of just "Filter",
breaking cy.button()/getByRole name lookups.

* test(embedding-sdk): e2e test for query builder permission gating

Confirms Filter/Summarize/notebook editor toggle are hidden for a user
without create-queries permission on the underlying table, and shown for
one with it, using existing readonly/readonlynosql fixture users whose
default group permissions already match each scenario.

Fixes EMB-1963

* docs(embedding-sdk): tighten comments, scope test fixtures per-test

Bullet the three omitted main-app gating conditions instead of run-on
prose, shorten the missing-permission test comment, and move each
question fixture into the test that uses it instead of module-level
constants shared across unrelated tests.

* fix(embedding-sdk): guard BreakoutDropdown on missing question

Matches the !question || !shouldRenderQueryBuilderEditingControl(question)
pattern used by FilterDropdown and EditorButton.
2026-07-03 10:20:30 +01:00
Oleksandr Yakushev
6c81e71958 [schema] Validation performance improvements (#64815) 2026-07-03 12:19:46 +03:00
Chris Truter
caf298bc5a Support OSI ai_context string shorthand (#76865) 2026-07-03 09:43:46 +02:00
Chris Truter
71c929d0d9 Metabot catalog to include all curated entities (#76863) 2026-07-03 09:42:14 +02:00
Romeo Van Snick
34296d1975 Reuse dashboard save response and make dashboard e2e saves deterministic (#76507)
* Let fetchDashboard accept a prefetched dashboard

(cherry picked from commit 63425d8754777a96f023c3be6028c5a45b4607d5)

* Use save response to refresh dashboard instead of refetching

(cherry picked from commit 8f5aff044beb8290f9c63f7ebb041ffbe8c2b392)

* Test save reuses response without refetching the dashboard

(cherry picked from commit a90b2885f7ac19ed472bed1018a88fa29fee60be)

* Update e2e save helper for dropped post-save dashboard refetch

(cherry picked from commit 41bba584ae41640903c06fcd76022a1569d6f087)

* Update e2e dashboard reload expectations for save-response reuse

(cherry picked from commit 97fabf4f8df7d0c1345ea33a6136a1c3ba76933f)

* Wait on dashboard UI instead of phantom reload when returning from drill

(cherry picked from commit 19181e1345af6af1fe46f323c3b0362a5286e1b4)

* Add waitForDashcardsToLoad e2e helper and use it in #32444 test

(cherry picked from commit fa3a0e989f2166f50af10a0294fcda9bfef968d9)

* Settle saveDashboard on dashcards loaded instead of fixed sleep

(cherry picked from commit b7a2e157b6db12a2f4f8ab10b7c19f68437b94ed)

* Drop redundant saveDashboard waitMs args now that it settles deterministically

(cherry picked from commit e8827b06955f581dde739491d3aef2bee5f90be9)

* Drop redundant post-save sleep now covered by saveDashboard settle

(cherry picked from commit c3ae1c65997165fffc0fa1c394d1d2765b4fb2b8)

* Drop tombstone comments per review

* Make waitForDashcardsToLoad tolerant of dashboards without a grid

* Anchor dashcard settle on dashboard body to avoid early return

* Revert broad saveDashboard auto-settle; keep save-reuse and opt-in waitForDashcardsToLoad

* Settle saveDashboard on dashcards loaded + grid layout stable; drop waitMs sleeps

* Wait for filter widgets to settle after save (parameter panel re-render)

* Make editDashboard resilient to a dropped Edit click after save

* Make editDashboard retry work inside cy.within (use cy.document not cy.get body)
2026-07-03 08:37:10 +10:00
Romeo Van Snick
4dcb2a7f86 Add routing behavior lock-down tests (#76322)
* Add routing behavior lock-down tests

* Add updateUrl navigation producer lock-down tests

* Add table-route preservation lock-down tests for updateUrl

* Add locationChanged read-seam lock-down tests

* Add dashboard URL-query sync lock-down tests

* Restore console spies in routing lock-down tests

* Fix import order lint in dashboard url-query test

* Fix parameterValues type in dashboard url-query test
2026-07-03 07:56:20 +10:00
github-automation-metabase
f19e78d9fc Auto-update documentation for master (#76924)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-02 17:37:52 -04:00
metamben
44570e07cd Convert all ASCII chars in var names not allowed by mongo to _ (#76761)
Closes QUE2-704
2026-07-03 00:33:36 +03:00
github-automation-metabase
b4b8e57722 Restore 30s timeout on findByText (#76021)
* auto stress test

* better options

* fix(e2e): restore 30s timeout on findByText for impersonated permission test

The timeout was removed in a8cc638d2f when updating the error message text.
The impersonated write path takes 15-20s, far exceeding the default 4s timeout,
causing consistent test failures (quarantined for 33 days).

---------

Co-authored-by: Ryan Laurie <iethree@gmail.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
2026-07-02 19:18:59 +00:00
Michael Eby
1fe4641c3e docs: new dimension picker in metrics explorer (#76552)
* docs: new dimension picker in metrics explorer

* Optimized 4 images, saved 493.5 KB (52.8% smaller)

* Edits from Alex

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-02 14:48:50 -04:00
github-automation-metabase
bc91754508 Stabilize flaky pivot-table dashboard filter spec (#76747)
* Fix flaky pivot-table dashboard filter spec: wait for dashcard load before opening question

The "does not use extra filtering stage for pivot tables" spec clicked the pivot
dashcard's legend title immediately after exiting edit mode. The title's
navigation handler is only wired once the card series has reloaded, so an early
click was a no-op and the /api/dataset/pivot request never fired, timing out
cy.wait("@datasetPivot"). Wait for the dashcard to finish loading (visible title
+ no loading indicator) before clicking.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Give pivot-table dashboard filter spec a throttle-tolerant pivot wait

Clicking the pivot dashcard title navigates to an ad-hoc QB that must boot
the route, load table metadata, and only then issue /api/dataset/pivot. Under
network throttling that chain can exceed cy.wait's default 5s timeout, so the
wait occasionally fails even though the request does fire moments later. Wait
on the @datasetPivot alias with a throttle-tolerant timeout.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-02 12:41:18 -06:00
Ryan Laurie
2828ecaa8b Fix Linear Release Sync Again (#76909)
* add catch logic

* do it right this time
2026-07-02 12:14:08 -06:00
Ryan Laurie
8c937d249b Don't fail builds on linear release issue tracking (#76889)
don't ever fail a build for this
2026-07-02 18:56:31 +02:00
Riley Thompson
b27f04d153 Use report timezone if breakout field has datetime effective type (#76697)
use report timezone if bucketed field as temporal effective type
2026-07-02 11:10:59 -04:00
Egor Grushin
8d56144be1 GDGT-2589 Make H.popover() to select the Select component from "metabase/ui" (#76737)
* GDGT-2589 Make H.popover() to select the Select component from "metabase/ui"

* GDGT-2589 fix attributes drilling
2026-07-02 15:52:37 +01:00
Ben Grabow
2833fa63b2 Exclude audit db when coalescing default perms (#76608)
* Exclude audit-db when selecting lowest permission level for group
2026-07-02 09:25:20 -05:00
Nemanja Glumac
7098c5576a Add a unified, dry-run ci-conductor quarantine gate (#76752)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-02 15:14:29 +02:00
Nicola Mometto
03b9522551 Incremental transforms merge (#76663)
* WIP: support for merge strategy via delete + insert

* PoC FE

* fix

* overridable method

* support for py

* refactor

* FE

* changelog

* FE fixes

* validate UK

* chore

* update FE

* tests

* remove compile-merge multi

* FE tests

* remove feature

* move component to its own file

* chore: test composite keys

* fix: override for sqlserver
2026-07-02 13:09:19 +00:00
Nick Fitzpatrick
eec1d1b0d5 Add only published filter to data studio table picker (#76521) 2026-07-02 18:28:32 +05:30
Alex Yarosh
a3596d04cf docs - password complexity (#76776)
* Revise password complexity guidelines in documentation

Updated password complexity requirements and options.

* Update docs/people-and-groups/changing-password-complexity.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Apply suggestions from code review

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-07-02 12:35:51 +00:00
github-automation-metabase
68f276b5a1 Auto-update documentation for master (#76849)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-07-02 08:31:35 -04:00
Jakub Chodorowicz
2e2aae3f62 GDGT-2527: Make new treemaps full width by default (#76804)
change the default size of treemap to full grid with
2026-07-02 14:08:52 +02:00
Mahatthana (Kelvin) Nomsawadi
2e33d53027 fix(sdk): open SQL editor when Metabot navigates to native hash URL (#76738)
* fix(embedding-sdk): open SQL editor when Metabot navigates to native hash URL

When Metabot sends navigate_to with /question#<native_hash>, SdkAdHocQuestion
was returning questionId=null (no numeric slug), so isNewQuestion=false and the
SQL editor never opened. Now detects dataset_query.type==='native' and returns
'new-native', which makes SdkQuestionProvider set isNewQuestion=true and
useNewQuestionEditorSync open the editor.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dwi9BjxKNSJsztkkVrsU8d

* test(sdk): use real embedding Metabot stream for SQL editor test

Replaces hand-rolled mock payload with a navigate_to event captured
verbatim from an actual embedding Metabot response, so the test
fixture matches real wire format (db id adjusted to match env).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012wNQmcGH7PCXMD1PqFLiBS

* refactor(sdk): call resolveQuestionId inline instead of in useMemo

It's a cheap derivation, not worth complicating the memo for.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012wNQmcGH7PCXMD1PqFLiBS

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-07-02 12:01:36 +01:00
Oleh K
132a7e674a refactor: Migrate icon tokens (disabled/secondary swap) (#76792)
* GDGT-2534 Migrate icon tokens (disabled/secondary swap + text aliases)

Per design, the icon tokens are corrected: `icon-disabled` and
`icon-secondary` swap meaning, and all four icon tokens become runtime
aliases of their text counterparts.

- Swap consumers: `icon-disabled` <-> `icon-secondary` call sites.
- Redefine in both themes:
  - icon-primary  -> var(--mb-color-text-primary)   (value unchanged)
  - icon-secondary -> var(--mb-color-text-secondary)
  - icon-disabled  -> var(--mb-color-text-disabled)
  - icon-brand    -> var(--mb-color-text-brand)      (brand[40] -> brand[50])

Token names are unchanged, so there's nothing to remove at cleanup. Icon
tokens aren't SDK public theme keys and aren't used in static-viz, so the
var() aliases are safe everywhere.

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-07-02 13:00:13 +02:00
Romeo Van Snick
a1a4a037fd Consolidate basename into a dedicated module (#76852)
* refactor: add basename module for app-wide basename state

* refactor: move basename off ApiClient into the basename module

* refactor: make setBasename tolerate nullish input

* refactor: drop redundant basename guard in sdk init

* test: capture original basename per-test in setupBasename

* fix: strip basename only as a prefix in getDatasetDownloadUrl
2026-07-02 19:20:12 +10:00
Romeo Van Snick
914130d706 Bundle-size stats: emit Description column (fixes 422 on upload) (#76860)
Bundle-size stats: emit Description column populated with the commit subject
2026-07-02 06:06:23 +00:00
Romeo Van Snick
2ed2645f5b Fix bundle-size extract: drop non-existent embedding-sdk.js pattern (#76857)
Fix bundle-size extract: drop non-existent embedding-sdk.js pattern (unzip exit 11)
2026-07-02 14:41:56 +10:00
Fraser
e73f7ecf1b Update affected test stats (#76855) 2026-07-02 16:36:02 +12:00
Romeo Van Snick
91bdbd3f21 Bundle-size: apples-for-apples PR check + delta-aware stats logger (#76409)
* Measure SDK/app bundle sizes from both uberjars, apples-to-apples

* Always report brotli bundle size, estimating when no .br is shipped

* Bundle-size stats: upload per-bundle deltas, skip unchanged commits

* Bundle-size stats: always record releases, gate/report on brotli delta

* Scope app to app-main and SDK totals to reachable code via the chunk graph

* Fall back to whole app/dist when stats lack reachableAssets

* Stats logger: record master only, drop release tags from the live series

* Measure SDK async chunks as loadable; split legacy initial/total

* Point bundle-size logger at table 79702

* Skip SDK bundle-size gate when base ref predates reachable-chunk stats

* Split bundle-size scripts into pure cores + I/O wrappers, add unit tests

* Bundle-size: extract legacy embedding-sdk.js fallback; fix stale as-served comments

* Retry stats upload with backoff; keep bundle-size run green if it still fails
2026-07-02 13:27:43 +10:00
appleby
9160419f64 BOT-1723 Support OpenAI models (#76499)
* Add default-openai-llm-metabot-model gpt-4.1-mini

* Filter openai list-models by supported-models

OpenAI's /vi/models endpoint returns ~140 models, many of which are not relevant (text embeddings, audio/video models)
or else deprecated. Filter this down to a whitelisted set of known supported models.

* Add grouping for openai models in provider-models-response

* Throw an exception if callers pass `:ai-proxy true` for openai

Similar to bedrock and azure, supporting this would require some work on the ai-service side, and we already reject
non-anthropic in validate-metabase-managed-provider!

* FE: enable openai provider in metabot admin UI config

* Drop gpt-4.1-mini from supported-models and change default to gpt-5.4

* Replace gpt-4.1 with gpt-5 in supported-models

* Bump metabase.metabot.example-question-generator/max-tokens to 4096 for gpt-5

GPT-5 produces a lot of reasoning tokens and sometimes exceeded the old limit.

* Remove reference to gpt-4.1-mini in docstring example

* Remove references to gpt-4.1 and gpt-4.1-mini in FE unit tests
2026-07-01 20:03:03 -07:00
Ryan Laurie
0cdbb874ac Add Linear Release tracking (#76711)
* Add Linear Release tracking

* use uniform helper

* fix typos 🤦‍♀️

* get linear release version
2026-07-01 18:16:21 +00:00
Eric Normand
6cc57802d4 Skip empty remote-sync commits after a no-op export (GHY-3934) (#76753)
* Skip empty remote-sync commits after a no-op export (GHY-3934)

A dirty RemoteSyncObject row whose serialized content already matches the
repo stages a net-zero tree change, so finishing the commit produced an
empty commit that still got pushed. GHY-3933's content-hash gating catches
the no-op-update-event case, but not the others: a full-export fallback
that re-serializes byte-identical content, a rename/delete whose old path
isn't known yet, a dedup name collision, or path/hybrid models.

Add an `empty-commit?` query to the CommitBuilder protocol (git layer
answers whether the staged tree equals the parent's; it does not decide
policy). full-export!/incremental-export! branch on it: when empty, abort
the commit, leave the version unadvanced, and report push-skipped — while
still reconciling RemoteSyncObject state so the stale dirty flags that
triggered the no-op are cleared.

* Docstring

* Unify remote-sync export commit lifecycle and skip empty merges

Extract commit-staged! — the open/stage/empty-commit?/finish-or-abort
lifecycle — and route full, incremental, and merge exports through it.
merge-and-store! moves from source.clj into impl.clj (next to the other
export paths) so it shares commit-staged! instead of duplicating the
lifecycle via replace-all-files!; source.clj keeps the merge computation
(compute-merge, preview-merge).

commit-staged! returns the :remote-sync/empty-commit sentinel when the
staged tree matches the parent, so the merge path no longer pushes an
empty commit either. An empty merge folds in any remote changes and
advances to the remote tip, reporting "pulled" (or "push-skipped" when
nothing changed on either side) rather than a misleading "merged, pushed 0".

* Inline merge-and-store! into export-merged!

The intermediate {:status ...} map that export-merged! re-dispatched via
case added nothing: inline the merge computation and commit so the merge
path reads like full-export!/incremental-export! — compute, commit-staged!,
reconcile, outcome.

Move the test seam down from merge-and-store! to source/compute-merge: the
export! tests stub the pure merge function and exercise the real commit
staging, and the three dedicated merge-and-store! unit tests are dropped as
redundant with merge-test (algorithm) and the commit-staged!/export coverage.

* Better docstrings

* Test empty-commit? against a real git repo

Exercise empty-commit? through the real JGit commit builder (not a mock):
identical re-stage and delete-of-absent-path read empty, real edits and new
files don't, aborted no-op checks leave the branch untouched, and the
memoized tree still yields a correct commit when finish-commit! follows.
2026-07-01 18:06:55 +00:00
Oleksandr Yakushev
f8cb4ca1bf Bump kixi.stats to 0.5.9 (#76789) 2026-07-01 15:01:44 -03:00
appleby
d3ee87fab5 Claude Sonnet 5 support (#76756) 2026-07-01 10:33:30 -07:00
Eric Normand
2d635fadf9 Drop metabase_version from serialization (GHY-4013) (#76760)
Serdes stamped every non-Setting entity (and the Card column) with the
instance build version on extract. Since the value differs between
instances, it produced spurious uncommitted changes during remote sync.

Compatibility is now governed by the versioned representation spec
(:card_schema + upgrade-card-schema-to), so the per-entity version stamp
no longer carries useful information. Stop serializing it:

- extract: remove the metabase_version stamp
- Card serdes spec: move :metabase_version from :copy to :skip
- load: remove the now-dead version-mismatch warning machinery

Legacy baseline fixtures still carry the field, exercising that older
exports import cleanly now that it's skipped.
2026-07-01 16:10:32 +00:00
lbrdnk
5c475f1d06 Add endpoint for execution of saved questions (#76720)
* Add endpoint for native query construction in expected format

* Add model import

* Add endpoint for execution of saved questions
2026-07-01 16:54:25 +02:00
lbrdnk
fe2715ef6b Add endpoint for native query construction in expected format (#76717)
* Add endpoint for native query construction in expected format

* Add model import

* Review remarks

* Endopint version
2026-07-01 15:20:39 +02:00
Sébastien
3d8b6293b8 Fix date-dependent test in ConversationFilters date dropdown (#76803)
fix date-dependent ConversationFilters date dropdown test
2026-07-01 18:46:40 +05:30
Nemanja Glumac
b4f0b23363 Reuse the ci-conductor contract types and utils in e2e reporting (#76746)
Replace e2e's local ConductorTest with the shared NormalizedTest wire shape
(plus a transient screenshotPath) and import toNumber from the module, so the
report path and the quarantine path can't drift on a test's identity. The
transport stays forked: e2e posts mid-run from Cypress's after:spec hook on
node-fetch, with screenshots and a dry-run mode the module's post-run transport
doesn't cover.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-01 13:13:29 +00:00
github-automation-metabase
34cc99da9a Auto-update documentation for master (#76764)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-06-30 23:37:34 -04:00
Mahatthana (Kelvin) Nomsawadi
1f99507ef5 fix(sdk): controlled parameters prop leaks into drill-through target dashboard (#76716)
* fix(sdk): strip controlled parameters from drill-through target dashboard

When InteractiveDashboard renders a drill-through target via
SdkInternalNavigationProvider, the full dashboardProps spread included
the host's controlled `parameters` and `onParametersChange` props.
getEffectiveParameterValues makes the controlled prop win over
initialParameters, so click-behavior filter values were silently
discarded and the target dashboard opened with empty filters.

Introduce getDrillThroughDashboardProps to explicitly strip controller
props before forwarding to the drill-through target. Display props
(withDownloads, withTitle, etc.) pass through unchanged. The target
is seeded from click-behavior initialParameters as intended.

Fixes EMB-1946.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fwn7CNjPBZAg4KLVMaV7HW

* fix(sdk): also strip initialParameters from drill-through target props

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fwn7CNjPBZAg4KLVMaV7HW

* test(sdk): clean up EMB-1946 e2e test

Rename Dashboard A/B to Origin/Target for readability, fix parameter id,
remove cy.intercept/cy.wait in favour of visible UI assertions only, and
rename the describe block to cover all three stripped props.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fwn7CNjPBZAg4KLVMaV7HW

* test(sdk): remove describe.only from EMB-1946 test

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fwn7CNjPBZAg4KLVMaV7HW

* fix(sdk): address review feedback on getDrillThroughDashboardProps

- shorten comment to focus on why (root-scoped props override drill-through target)
- tighten return type to Omit<> reflecting the stripped keys

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fwn7CNjPBZAg4KLVMaV7HW

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-07-01 10:22:19 +07:00
appleby
d5fea3a9a0 Limit metabot related-tables to bound context size (#76588)
* Limit metabot FK related-tables to bound context size

When bulding metabot's context we expand one related-table entry per FK column and fetch and format the full column
set for each related table. On a large, highly-connected schema this fetches a large number of columns into the
metadata cache, exhausting the heap (metabase#76493).

We now limit the number of related-tables we attempt to fetch to metabase.metabot.tools.entity-details/max-related-tables

* Report truncated related tables to the LLM

When the related-table list in the metabot context gets truncated due to exceeding the limit, leave a note in the
context that truncation occurred. For tables that were dropped, include them in a lighter weight list with only
id/name/related-by (also capped), so the LLM knows more related tables exist and can look any of them up individually.

`entity-details/related-tables` now returns the detailed list plus a total count and a list of truncated items; the
result surfaces related_tables_truncated / related_tables_total / related_table_refs (+ related_table_refs_truncated),
and llm-shape renders a <related-tables-truncated> note with the truncated items.

* Rename max-related-table-{,truncated-}refs and add table descriptions

* Don't :include-implicitly-joinable? when looking up FKs for metabot related-tables

Otherwise we fetch and cache the full column set for every FK-target table when looking up realted-tables for
metabot's context. Instead, just do a bulk metadata lookup on the FK target columns only so we don't blow up the
metadata cache for tables with a huge number of columns.

* Cleanup docstrings and formatting in related-tables->xml

* Exclude tables in :related_tables from :related_table_refs

The refs list doesn't need to duplicate the tables from :related_tables. This way, the LLM potentially gets more
info about truncated tables, since we also cap the :related_table_refs list.

* Drop :related_tables_truncated and :related_table_refs_truncated

They can be inferred from :related_tables_total and the size of two lists.

* Use render-llm-template for related-tables->xml and related-table-ref->xml

* Fold related-tables-result into related-tables

* Reduce max-related-tables from 20 to 10

* Make metabase.metabot.tools.entity-details/related-tables private

* Fix docstring typo

* Ensure that :related_tables_total = :realted_tables + :related_table_refs

Don't exclude entries from :related_table_refs just because the table id appears in :realted_tables. We specifically
want to allow duplicate table-ids as long as the (table-id, fk) pairs are distinct to preserve the total = related +
refs invariant.

* Cleanup realted-tables

* Return field id from fk-related-table-groups

To avoid having to call lib.metadata/field in the caller for each fk just to extract the :name.

* Include the field id in related-tables :related_by to distinguish fk fields with the same :name

* Simplify handling for related-tables without fields

- rename max-related-tables to max-related-tables-with-fields
- rename max-related-table-truncated-refs to max-related-tables
- rename :related_table_refs to :related_tables_without_fields
- return up to max-related-tables-with-fields (10) in :related_tables
- return up to 40 tables in :related_tables_without_fields
  - 40 = 50 - 10 = max-related-tables - max-related-tables-with-fields
- always use table-details to format related-tables, just pass :with-fields? false once max-related-tables-with-fields
  is exceeded

* Don't say roster

* Only include :related_tables_without_fields if the caller requested fields

If the caller did not pass `with-fields? true`, then there is no distinction between :related_tables and
:related_tables_without_fields, so don't include it.

* Fix docstring
2026-06-30 17:47:51 -07:00
YB
15c5b59fe7 [GDGT-2688] refactor find-stale-query to core multimethod (#76649)
Makes find-stale-query easier to extend in core models.
2026-07-01 08:40:25 +08:00
technomancy
eeaf08ce0a Adjust dataset name qualification for snowflake and bigquery. (#76706)
Adjust dataset hashing for snowflake and bigquery.

We are frequently seeing some rogue process dropping the test-data
database which is shared across all tests, causing a good deal of
instability. We have not been able to track down what code is doing
this. Changing the way we calculate database names based on dataset
will help us find the culprit and also help isolate branches for
stability.

When we are on master or a release branch, splice the current major
version into the qualified database name. When we aren't, use "sha__"
as a prefix instead of "sha_", which will keep backport branches from
affecting dev branches going forward and help us identify whether it's
backports or not that are causing the database drops we're seeing.

Stop checking the tracking table to determine whether the dataset is
loaded. The dataset will be tracked regardless, so this should not
factor into the question of whether it needs to be created.

Unrelated change: update get-or-create/create-database! to print when
it encounters a failure and deletes the database it was trying to
create. This should never happen for snowflake/bigquery because they
are flagged as not supporting dynamic dataset loading, but it's still
better to have this printed visibly instead of the error logs which
are hidden.
2026-06-30 22:45:36 +00:00
Alexander Polyankin
5fb4c98d45 Fix transform table deletion in workspaces (#76754)
* fix table deletion

* FE fix

* FE fixes
2026-06-30 18:24:50 -04:00
Jeff Bruemmer
7a7e1d4ae3 docs - notes on custom viz (#76703) 2026-06-30 17:52:54 -04:00
Nemanja Glumac
f3370e8c87 Report frontend jest test failures to ci conductor (#76666)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 20:48:03 +00:00
Riley Thompson
5d84f2ea39 Upgrade databricks jdbc driver (#75037)
* upgrade snowflake and databricks jdbc drivers

* remove arrow, disable thrift client

* bump snowflake

* skip snowflake upgrade
2026-06-30 20:01:46 +00:00
Chris Truter
78382c9a96 Retrieve Library Entities tool using OSI metadata (#76394) 2026-06-30 15:15:53 -04:00
Anderson
b113cf9527 Fix shift-scroll behavior in the data picker browse all state (#76537)
Fix shift-scroll in data picker
2026-06-30 16:02:32 -03:00
Anderson
15adc01a45 Consolidate duplicated ColumnSettings types into single definition (#76713)
* Consolidate ColumnSettings types into single definition in metabase-types/api

* Collapse OptionsType into ColumnSettings
2026-06-30 16:01:45 -03:00
Eric Normand
008bf29ce0 Fail serialization export when cards escape requested collections (#75176) (#76741)
* Fail serialization export when cards escape requested collections (#75176)

When a dashboard or card in the requested collections referenced a card
saved outside them, escape analysis logged a warning but the extract
stream was silently emptied. The CLI still printed "Export complete!" and
exited 0, and the API returned HTTP 200 with an archive containing only
export.log, so automated pipelines could not detect the empty export.

The default export now aborts loudly: the eager extract phase throws, so
the CLI exits non-zero and the API returns a 4xx before streaming begins
(the status can't change once the tar.gz starts). continue-on-error is
unchanged - it still proceeds, skipping the escaped entities, and the
escape warnings still land in export.log.

* Unify escape reporting and abort into handle-escapees!

The escape warning report and the abort throw were two adjacent branches
over the same data. Fold them into one handle-escapees! function: it logs
the per-entity report and, unless continue-on-error? is set, throws to
abort. Behavior and the thrown message/status are unchanged.

* Better docstrings
2026-06-30 18:44:44 +00:00
Riley Thompson
8e47d62c2c Don't error when table has a foreign key reference to an inaccessible table (#76740)
* use promise allSettled

* Add e2e test
2026-06-30 14:38:17 -04:00
Nick Fitzpatrick
d53658dc3b Allow field identifiers to grow in Data Studio Table page (#76287)
* Allow field identifiers to grow in Data Studio Table page

* Move Data type section below Field name

* Maz and Anderson feedback
2026-06-30 23:37:40 +05:30
Anderson
b52b11e11a Remove wrong disabled styles on chart settings Data fields (#76744) 2026-06-30 14:48:11 -03:00
Eric Normand
585f612d74 Track remote-sync dirty state by serialized content hash (GHY-3933) (#76098)
* Track remote-sync dirty state by serialized content hash (GHY-3933)

The remote-sync "yellow dot" was driven purely by update events: any
:event/<model>-update flipped the RemoteSyncObject row to "update",
regardless of whether the entity's serialized form actually changed. So
editing a non-serialized field (e.g. a transform's schedule) or any no-op
re-save marked the entity dirty, and the subsequent push produced a commit
with no files.

Record a content_hash (SHA-256 of the entity's serialized YAML, taken from
the live DB entity) on each RemoteSyncObject at every sync point — full
export, incremental export, and import. On an update event, the consumer
recomputes the hash and keeps the row "synced" when it matches the recorded
baseline; a null baseline is treated as dirty so new content still exports
once. A reverted edit that returns to the synced content clears the stale
dirty flag.

Works for all tracked model types (entity-id, hybrid, and path identities).

* Add export/import integration tests for content-hash dirty detection

Beyond the consumer-level per-type tests (which seed the baseline hash
directly), add end-to-end tests that exercise the baseline-recording paths:

- export integration: run a real export! to a mock source, then fire a no-op
  update and assert it stays synced — covers the incremental export
  synced-loop hash recording for Card, Dashboard, Document, Timeline,
  Collection, TransformTag, and PythonLibrary.
- import integration: run a real import! from a mock source (the "right after
  a pull" scenario), then fire a no-op update — covers record-content-hashes!
  on the import path for Transform and TransformTag.

* Better comments in migration

* Batch record-content-hashes! to one extraction and update per model

Instead of re-extracting and updating each RemoteSyncObject one entity at a
time, group rows by model type and: run a single extract-query (keeping each
instance's local id so it correlates to its row), serialize each in-process,
and write all hashes with a single CASE update. This works for every identity
flavor — including the extract-query overrides (Collection, NativeQuerySnippet),
hybrids, and path models (Table/Field) that have no entity_id — since
correlation is by the instance's primary key, not entity_id.

Adds a unit test asserting the batched result matches per-row row->content-hash
across entity-id, override, hybrid, and path models.

* Chunk record-content-hashes! into batches of 500

Bound the IN-list and CASE expression sizes: partition each model type's rows
into chunks of content-hash-batch-size (500) and run one extract-query + one
CASE update per chunk, so very large synced sets don't produce a single
oversized statement. Adds a test (with a small batch size) covering rows that
span multiple chunks.

* Use t2/query CASE update for cross-driver portability

Switch the batched content_hash write from t2/update! (with a honeysql value)
to the t2/query {:update :set :where} form used by
queries.models.query/update-rolling-average-execution-times! — the established
cross-driver (H2/Postgres/MySQL) pattern for a single atomic CASE update.

* Use t2/update! for the batched content_hash CASE update

RemoteSyncObject has no transforms or update hooks, so t2/update! passes the
honeysql CASE expression straight through to the same dialect-aware compilation
as t2/query — equally portable across H2/Postgres/MySQL — while reading more
idiomatically with its conditions/changes maps.

* Make record-content-hashes! no-arg, selecting all rows itself

Both callers passed the same select-all of RemoteSyncObject rows, so move that
query into the function. It is always invoked after every row is synced.

* Run record-content-hashes! under serdes/with-cache

Extraction resolves foreign keys (collections, databases, users, …) while
serializing each entity. Wrapping the pass in serdes/with-cache memoizes those
resolvers so shared references are looked up once instead of once per entity.
The full-export caller was already inside a cache; the import caller was not.

* Record export/import metadata in one serialize + one batched write

Collapses the post-export/import RemoteSyncObject bookkeeping. Previously a full
export serialized the whole synced set twice (store! to write files, then
record-content-hashes! to re-serialize for hashes) and wrote each row up to
three times (blanket status, per-row file_path, batched content_hash); import
was similar.

Now:
- source/store-and-record! drives serialization from extract-query so it keeps
  each entity's primary key, writing files and returning {:model_type :model_id
  :path :content_hash} — so file_path and content_hash come from the single
  serialization store! already does, for every model type (including path
  models with no entity_id).
- record-exported-metadata! writes file_path and content_hash for all models in
  one batched CASE update per chunk (not per model, not per row), matched by
  primary key.
- import-content-metadata re-serializes the loaded entities once (import has no
  store!), overriding file_path with the actual repo path for entity-id models;
  used by both full and incremental import.

Extraction (extract-one) runs inside the extract-query reduction so the JDBC
ResultSet stays open. Replaces record-exported-paths! and record-content-hashes!.

* Batch the incremental export RSO updates

The incremental export fast-path wrote each synced row with its own t2/update!.
Replace with one batched CASE update per chunk (status/status_changed_at
constant, file_path/content_hash per-row CASE), keyed by the RSO :id the synced
plan already carries — no extra select. Fewer round-trips on the fast path.

* Fold import metadata into the insert (one batched insert per row)

Import previously wrote each RemoteSyncObject row twice: sync-objects! inserted
status/name, then record-exported-metadata! updated file_path/content_hash.
Compute the metadata before the insert and merge it into the insert maps
(merge-content-metadata), so the whole import reconcile is one delete-all + one
batched insert (full import) / one delete + one insert (incremental). Drops the
follow-up update pass and leaves record-exported-metadata! export-only.

* Make full export one RSO write per row

record-exported-metadata! now reconciles the whole table in one write per row:
one select of all rows, then chunked updates that set status for every row in
the chunk and file_path/content_hash for the exported ones (CASE with ELSE
keep-existing). full-export! drops the separate blanket status update. Each row
is written once; removed/delete rows just get their status reset.

* Chunk the import pipeline and export IN clauses

Bound the work that could exceed DB param limits / memory on large syncs:
- insert-with-metadata! processes the import in chunks of content-hash-batch-size
  (extract + hash + enrich + insert per chunk, under one shared serdes cache),
  so insert/IN params and the maps held at once stay bounded — replaces the
  whole-table merge + unbounded insert. Used by full and incremental import.
- store-and-record! chunks each model's extract-query IN (restores bounding the
  refactor had dropped from record-content-hashes!).
Removes the now-unused sync-objects!.

* Flatten store-and-record! into one transduction pipeline

Replace the nested mapcat>mapcat>map with a single (into [] (comp ...) targets):
expand each model into bounded [model-type id-chunk] work items, then stream
each chunk's extract-query through a serialize helper via an eduction — so
extract-one still runs while the ResultSet is open, with no intermediate
per-chunk sequence realized.

* Flatten import-content-metadata to a single transduction

Mirror store-and-record!: pull the per-instance work into a serialize helper and
stream each model's extract-query through it via an eduction instead of an inner
(into [] (keep ...)), so the whole function is one transduction over the model
groups with no intermediate per-model sequence realized. extract-one still runs
inside the extract-query reduction (ResultSet open).

* Fix events_test references to the removed sync-objects!

The export/import refactor removed sync-objects!, but events_test still called it
(2-arg form) to set up a synced baseline before firing move-out events, failing
clj-kondo (unresolved var) and the enterprise test load. Replace with a local
mark-synced! helper that does the same via spec/sync-all-entities!. Also refresh
two stale comments referencing removed functions.

* Use empty? instead of not

* kick ci

* Remove no-op (filter identity) from export root-targets

query-export-roots is consumed by mapcat (so nil returns contribute nothing) and
the [model-type id] tuples it produces are never nil, so the filter could never
remove anything. (PR review #76098)

* export-targets returns {} instead of nil

Removes a nil-as-empty signal: export-targets always returns a map, so callers
test emptiness (full-export! already uses empty?; extract-entities-for-export
uses not-empty) rather than nil. (PR review #76098)

* refactor

* Refactor!

* commment

* Stream full-export serialization; fix disabled-files deref

- store-and-record! feeds write-files! a lazy tee'd eduction so the full
  serialized content is never held at once; only the lightweight per-entity
  entries accumulate (GHY-3933 / PR review #11).
- Fix export!: pass @disabled-files (was the raw delay) to export-incremental!,
  which reduces it via into.
- Fix resolve-status: return "synced" (was "synched").

* Stream the incremental export in two passes (bound memory)

The incremental plan used to serialize every dirty entity and hold all their YAML
in :upserts. Split it so the dirty set's content is never all in memory:

- Pass 1 (incremental-plan / incremental-updates-for-row / dep-writes): validate
  the batch is syncable and compute each write's target path — using the new
  source/entity->path, which renders no YAML. Produces a content-free plan of
  {:writes [{:id :model_type :model_id :file_path}] :delete-paths :removed-ids}.
- Pass 2 (export-incremental!): stream-re-serialize each write's content (via
  source/entity->content), using the pass-1 path, and feed it lazily to
  apply-changes!; tee the per-row synced metadata. One entity's content is live
  at a time.

stream-extract is a single comp'd eduction over the model groups (not a nested
eduction over the reduce-only extract-query) so it survives reduce- or
seq-consumption. entity->file-spec is now path+content composed.

* Batch the incremental pass-1 extraction (one query per model, not per row)

incremental-updates-for-row used to extract its entity itself, so incremental-plan
did one DB read per dirty row. Move extraction up into incremental-plan: batch-
extract the create/update rows on entity-id models via stream-extract (one query
per model/chunk), computing each row's path + existing-repo-file info once, then
run incremental-updates-for-row as a pure decision over the precomputed info.

removed/delete and non-entity-id rows need no extraction; a create/update row
whose entity is gone gets no info and is unsyncable; an extraction error sends the
whole batch to a full export (which self-heals). Paths are still computed with the
shared storage context (rows before deps) so dedup stays consistent.

* Simplify stream-extract: one key->row lookup, no tuple threading

Compute the [model-type model-id]->row lookup once instead of threading a per-model
id->row through the work-item tuple. Same two-mapcat structure (which keeps the
reduce-only extract-query on the reduce path); just less to read.

* Full export drops tracking rows for entity-id entities that left the set

Reconcile the removed-row handling between the two export paths. The incremental
path deletes the RemoteSyncObject row for a removed/delete entity; full export
left it as a synced row pointing at a file the wholesale re-serialize had already
dropped. Full export now deletes those rows too — but only for entity-id entities
that genuinely left (removed/delete status AND not in this export). Path/hybrid
removed rows (which can't go incremental) and removed rows whose entity is still
exported are still kept and reconciled to synced, as before.

* remove unnecessary function

* Rework export onto a streaming git commit-builder + chunk model

Reshape the export path around two ideas the reviewer asked for: an incremental
git commit API, and a uniform chunk-based extract pipeline shared by full and
incremental export.

Git protocol: add a stateful CommitBuilder (open-commit / stage-upsert! /
stage-delete! / finish-commit! / abort-commit!). The caller stages one file at a
time and the blob is inserted immediately, so the writer never receives or holds a
whole collection — streaming is structural, not a fragile single-pass contract.
write-files!/apply-changes! are kept, re-expressed on top of the builder. All
SourceSnapshot implementers (git, mocks, read-only views) implement it.

Export core: a chunk is [model-name rows<=500]; ->chunks (pure) groups+partitions
and extract-chunk runs one query per chunk. full-export! and incremental-export!
share stage-and-commit!, which doseq-stages each chunk's entities and accumulates
the synced metadata locally. After the push, set-version! + the RSO writes
(mark-synced! / record-exported-metadata! / removed deletes) run in one
transaction so the version can't advance past stale RSO state. Incremental still
validates first (incremental-plan) and aborts to a full export when unsyncable.

Supersedes the store-and-record! helper and the reduce-once write hardening (now
moot — no collection is passed to git).

* Tighten docstrings on the reworked export functions

One-line intent + args/return; move the how (batched CASE, select-all, streaming,
dedup, validation rules) into body comments where it matters. Fix the open-commit
docstring that still referenced the old :replace-dirs option.

* Batch enable-snippet-tracking! into one insert

Was one t2/insert! per snippets-namespace collection and per snippet (N+M
inserts); build the rows and do a single batched insert instead.

* Fix snippets export test for the removed-row reconciliation

A full export now drops the tracking row for an entity-id entity that left the
synced set (archived snippet, 'delete' status, not in export-targets) instead of
marking it synced — matching the incremental path. Update the assertion to expect
the row to be deleted.

* BEtter names

* Consistent capped chunking + shared path-free? predicate

- ->sized-chunks (group by model + cap at content-hash-batch-size) is now used by
  stage-and-commit!, incremental-plan, and dep-writes, so every extract-chunk gets
  a bounded chunk (the ≤500 cap was missing from the first two).
- dep-writes validates one chunk at a time and short-circuits on the first
  colliding chunk, instead of realizing all decisions then scanning.
- path-free? is a pure predicate over the {:eid :file-exists? :file-eid} info,
  shared by dep-chunk-writes (via repo-file-info) and incremental-updates-for-row's
  create/rename branches — one collision check instead of three copies.

* docs and names

* Calculate the incremental plan one chunk at a time

incremental-export-plan now folds the create/update rows over ->sized-chunks
(chunk->updates per chunk), short-circuiting on the first unsyncable chunk like
dep-writes and stage-and-commit! do — instead of building an id->info map for all
rows and then deciding in a separate pass. Rows that need no entity (removed/delete,
non-entity-id, bad status) are decided up front. A gone entity is detected by the
found-vs-requested count; an extraction error falls back to a full export. Reuses
repo-file-info + path-free?.

* lots of doc improvements, some refactoring

* More renames

* Row is now map

* Chunk-as-map, deps return plans, and a pure plan combiner

- A chunk is {:model_type :rows}; export-closure/untracked deps speak
  {:model_type :model_id} maps throughout.
- dep validation returns plan fragments ({:writes [...]}) merged like every other
  fragment; row/chunk/dependency all produce plans combined by one function.
- Split merge-incremental-export-plans into a pure combiner (safe for direct
  calls, e.g. the deps merge) and a -reducer wrapper that adds the reduced
  short-circuit at fold sites — fixing a bug where the direct deps merge returned
  a Reduced and broke the fall-back path.
- Move the chunk-plan try/catch into chunk->plan where the throwing happens.

* REfactor

* Nice!

* Go!

* Guard no-source export at the API call; add exportable-entity-chunks

- async-export! refuses up front (HTTP 400) when remote sync isn't configured,
  instead of a nil-snapshot check inside the async task (which never fired) or a
  cryptic clone error. export! no longer guards its snapshot.
- spec/exportable-entity-chunks: exportable-entities in chunk form.

* Decompose stage-writes into stage-write/chunk-stage-writes

Split per-entity staging (stage-write) and per-chunk staging (chunk-stage-writes)
out of stage-writes; synced metadata flows out as return values.

* Go for it!

* Self-contained exportable-chunks; tighten docstrings

- exportable-chunks reads its own export set and full-export!/delete-departed-entities!
  flow over chunks; delete-departed derives the exported set from the chunk rows.
- Tighten prose-heavy docstrings to intent + Returns shape (content-metadata trio,
  untracked-content-deps, incremental-export-plan, dep plan, row->content-hash).

* Refactor!

* Go for it!

* Retire the legacy write API (write-files!/apply-changes!, store!)

The CommitBuilder (open-commit → replace-all!/stage-upsert!/stage-delete! →
finish-commit!) is now the sole SourceSnapshot write path:

- merge-and-store! (the export-merged! path) writes via the commit builder
  (replace-all-files!) instead of write-files!.
- Removed the dead store! and its tests/mocks.
- Removed write-files! and apply-changes! entirely — protocol methods, git
  impls + helpers (and the now-unused with-staged), and the read-only stubs.
- Test fixtures (git_test, test_helpers_test) seed via local commit-builder
  helpers, so they still exercise the same wholesale/incremental write paths.

* Untrack content_hash_bench.clj (committed by mistake)

* cljfmt: re-align test helper call sites

* Review fixes: drop unused fn, log skipped serialization, document commit lifecycle

- Remove the unused spec/exportable-entity-chunks.
- Log a warning when an entity fails to serialize for its content hash (was a
  silent catch in import-content-metadata).
- Document the CommitBuilder resource/lifecycle contract (caller must finish/abort).

* Align RSO txn ordering (delete then update); use u/index-by in merge-content-metadata

- incremental-export! now deletes departed rows before updating RSO metadata,
  matching full-export!'s order (the ops are disjoint within the txn, so this is
  a consistency change, not a behavior change).
- merge-content-metadata uses u/index-by instead of an into/map/juxt build.

* Inline expand-nested-collections

* Bgrabow/ghy 3933 suggestions (#76640)

PR feedback

---------

Co-authored-by: Ben Grabow <ben.grabow@metabase.com>
2026-06-30 15:15:36 +00:00
Alexander Polyankin
f1375bb764 Make bigquery throw when there is a next page that we cannot fetch (#76709)
bigquery page fix
2026-06-30 08:38:36 -04:00
Romeo Van Snick
6269865946 Make all API client request middleware declared statically (#75779)
* Move OnBeforeRequest* types into the api client middleware module

The `OnBeforeRequestHandler` / `OnBeforeRequestHandlerConfig` types lived in
`metabase/plugins/oss/api` but describe the request-manipulation middleware,
which lives under `metabase/api/client`. Relocate the type definitions to
`metabase/api/client/middleware` and re-export them from the `metabase/api/client`
barrel, so the middleware contract is fully contained in its own module. Pure
move plus import updates; no behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Make the request middleware a single static plugin-slot list

The request-manipulation pipeline was split across two mechanisms: a hardcoded
list of `PLUGIN_*` slots in `middleware.ts`, plus a dynamic
`api.beforeRequestHandlers` array that three features pushed onto at runtime
(the embed-preview rewrite, the React-SDK embed referrer, and the iframe embed
referrer). That made the full set of handlers — and their order — impossible to
see in one place.

Promote the three dynamic handlers to plugin slots and drop the dynamic array,
so `middleware.ts` lists the entire ordered pipeline statically:

- `PLUGIN_API.onBeforeRequestHandlers.rewriteEmbedPreviewUrl`
- `PLUGIN_EMBEDDING_SDK.onBeforeRequestHandlers.reactSdkEmbedReferrer`
- `PLUGIN_EMBEDDING_IFRAME_SDK.onBeforeRequestHandlers.embedReferrer` (new
  `onBeforeRequestHandlers` section on that plugin)

The owning features now install their handler into the slot instead of pushing.
`ApiClient` loses its `beforeRequestHandlers` field; `apiRequestManipulationMiddleware`
reads the static list and delegates to an exported `runBeforeRequestHandlers`
(kept pure so the merge/ordering semantics stay unit-testable). Slot resets on
plugin `reinitialize` now cover these handlers too, and the dead
`overrideRequestsForStaticEmbeds` slot is removed.

Because the slot positions are fixed, the public/static preview-rewrite no
longer depends on render-vs-effect registration timing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move the embedded-app header to a plugin handler

`client.ts` imported `isEmbeddingSdk` from `metabase/embedding-sdk/config` to
decide whether to send the `X-Metabase-Embedded` header — the last SDK import in
the api HTTP client. Move that logic into a `PLUGIN_API.onBeforeRequestHandlers`
slot (`setEmbeddedHeader`) whose default implementation does the
`isWithinIframe() && !isEmbeddingSdk()` check, and add it to the static pipeline
in `middleware.ts`. The plugin layer may import SDK config; `metabase/api/client`
no longer does.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Route param-remapping endpoints through the embed middleware

`api/card.ts` and `api/dashboard.ts` built the parameter-value remapping URL via
`PLUGIN_API.getRemapped*Url` — the last reason these endpoint files imported
`metabase/plugins`. Switch them to the same `:tag` template + params convention
the sibling `values`/`search` endpoints already use, so the existing embed
override middleware (which already has remapping transforms) does the rewrite.

Embed requests pass `entityIdentifier` instead of the real id, mirroring
`parameters/actions` — non-embed fills `:cardId`/`:dashId`, embed swaps to
`:entityIdentifier` and the guest handler injects the token. `substituteUrlTags`
encodes tag values, matching the getter's prior `encodeURIComponent`.

NOTE: verify the embedding e2e suite (guest/public/static parameter remapping)
before merge — this changes outward-facing embed request URLs and is not covered
by unit tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Remove the now-unused remapping-URL plugin getters

With the card/dashboard endpoints routed through the embed override middleware,
nothing reads `PLUGIN_API.getRemappedCardParameterValueUrl` /
`getRemappedDashboardParameterValueUrl` anymore. Drop the getters from the
plugin default and delete `setupRemappingUrls` (and its calls in the guest /
public-static embed setup), which only existed to override them.

`metabase/api/card.ts` and `metabase/api/dashboard.ts` no longer import
`metabase/plugins`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move embedding auth/client request headers off the api client

The api client carried embedding-only request state (apiKey, sessionToken,
requestClient) and emitted the embedding request headers (X-Api-Key /
X-Metabase-Session / X-Metabase-Client / -Version / -Embedded-Preview). Move
these off the generic client into embedding request-header plugin handlers built
as closure factories: setApiKeyHeader / setSessionTokenHeader installed onto the
setEmbeddingRequestAuthHeaders slot as the active auth strategy, and
setRequestClientHeaders installed onto its own slot per embed mode. The embedding
setup sites install the handlers they need, each closing over its value, so no
embedding state or header logic remains in metabase/api and there is no shared
mutable module state.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Send the SSO session token on the initial embed requests

In the SSO/SAML/JWT path the session-token header was only installed by the
request-pipeline refresh handler, which runs after the auth-header step, so the
user/settings requests fired during init went out without X-Metabase-Session
(the bootstrap path already installed it eagerly). Install the strategy eagerly
right after the initial session refresh, sharing one refresh-and-install helper
with the pipeline handler.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Simplify RequestClientInfo type

* Split the embed-preview header off the request-client handler

X-Metabase-Embedded-Preview signals preview mode (IFRAMED_IN_SELF), which is
orthogonal to which client is embedding. It was riding inside
setRequestClientHeaders, where the IFRAMED_IN_SELF branch was unreachable from
the static and full-app install sites (they skip installing the handler in
preview). Move it to its own setEmbedPreviewHeader slot, installed only by the
public and SDK flows so static/full-app previews keep not emitting it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Set the SSO session header from the refresh handler itself

getOrRefreshSessionHandler re-installed setEmbeddingRequestAuthHeaders with the
fresh token, but that was too late for the triggering request: the handler list
is snapshotted per request, and setEmbeddingRequestAuthHeaders runs earlier in
the pipeline, so the request that detected expiry still went out with the stale
token. Have the handler return the session header itself instead — it runs after
the static auth-header slot, so the refreshed token applies to the same request
(mirroring getOrRefreshGuestSessionHandler).

Drop the three dynamic setSessionTokenHeader installs (SSO + bootstrap) in favour
of the returning handler; keep setSessionTokenHeader for MCP's static token via a
shared sessionTokenHeaders helper. Widen the getOrRefreshSessionHandler slot type
to allow returning a header config.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Type request handlers with OnBeforeRequestHandler

Replace the repeated inline `async (): Promise<Partial<OnBeforeRequestHandlerConfig> | void>`
annotations (and the local EmbeddingRequestHandler alias) with the existing
OnBeforeRequestHandler type. The plugin no-op defaults collapse to a shared
`noop` handler, and the embedding-request-auth factories and the two embed-
referrer handlers gain their parameter and return types from the annotation.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Skip null querystring params, not just undefined

appendQueryParameters only skipped undefined, so a param explicitly set to
null was serialized as the literal string "null" (e.g. ?cursor=null). Skip
nullish values so an absent param drops out of the querystring entirely.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Drop the cardId/entityIdentifier switch into the embed override

The param-value/remapping endpoints chose between cardId/dashId and
entityIdentifier at six call sites to keep the unused id out of the request.
Pass both unconditionally instead: the embed override now drops the real
cardId/dashId from the params bag when it rewrites the path to
:entityIdentifier, so the real id never leaks to an embed endpoint, and a null
entityIdentifier falls out of the normal-app querystring via the nullish skip.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Settle the JWT popover test's auth flow to stop a cross-test leak

The 'usage problem popover' test rendered the auth flow but never awaited it,
so its user/current + session/properties requests were still in flight when the
next test (the SSO subpath test) ran, tripping the strict unmocked-routes
afterEach. Await the user request after the synchronous assertion so the flow
settles within the test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Omit null entityIdentifier from parameter-value requests

The parameter-value dropdowns key their cache on stableStringify(request).
Always including entityIdentifier (null when not embedding) changed that key
from {dashId, paramId} to {dashId, entityIdentifier: null, paramId} — stable-
Stringify keeps null — so every cache lookup missed and the dropdown rendered
empty (caught by the PublicOrEmbeddedDashboardView Loki stories). Only include
entityIdentifier when it exists; cardId/dashId stay unconditional (the embed
override still strips them). Add actions tests pinning the cache-key shape.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Use camelCase ids in the remapped-parameter request types

The getRemapped{Card,Dashboard}ParameterValue requests used snake_case
(card_id/dashboard_id/parameter_id) while the url tags and the embed override
use camelCase (:cardId/:dashId/:paramId), so each query function had to remap
the keys. Align the request types (and their callers) to camelCase like the
sibling values/search endpoints, so the query is a plain passthrough. Rewriting
the url template to snake_case instead would have pushed mixed casing into the
shared override (its embed-url outputs and the cardId/dashId strip), so the
request types are the right place to converge.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 19:03:11 +10:00
Oleh K
aa2e7326e0 Migrate bubble Radio usages to pills and remove the deprecated Radio (#76668)
* Migrate bubble Radio usages off the deprecated component

Replace the two `bubble`-variant usages of the deprecated
`metabase/common/components/Radio`:

- EntityViewSwitch (Groups/Databases view switch) -> Mantine `Tabs`
  `variant="pills"`. Drops the accent7 color scheme for the standard brand.
- FormFieldEditor "Field type" -> a horizontal Mantine `Radio.Group`. It's a
  single-select choice, so a radio group fits better than tabs.

Centralize the pills active style in the shared `metabase/ui` Tabs so
`variant="pills"` renders our soft "selected" pill out of the box.

Update the EntityViewSwitch e2e selectors (label/radio -> tab). The Field type
tests are unchanged: Mantine `Radio.Group` keeps the radio/radiogroup roles.

Part of GDGT-2588 (PR 3 of 3).

* Replace data studio hand-rolled tabs with Mantine pill tabs

PaneHeaderTabs (the data-studio entity-header navigation) was a hand-rolled
Group of Button-as-Link pills. Render it with the shared Mantine `Tabs`
`variant="pills"` instead, deriving the active tab from the existing
`isSelected` logic. Tabs keep real `<Link>` anchors (cmd/middle-click, href)
via a small cast, since Mantine's `Tabs.Tab` isn't polymorphic.

Drops the unused `withBackground` prop and refines the shared pills styling.

* Remove the deprecated common/components/Radio component

All usages have been migrated to metabase/ui (Radio, Tabs, SegmentedControl)
across the normal/underlined/bubble variants, so the deprecated component is
now unused. Delete it along with its stories and spec.

* Document pills variant in Tabs stories and docs

Add Pills (and Pills + icons) stories plus a variant control, and document the
pills variant and the listBorder prop in Tabs.mdx.

* Fix tests for the Tabs/Radio migration

- TransformHeader and JobRunListPage specs: PaneHeaderTabs are now role="tab",
  not "link".
- FormFieldEditor: give the "Field type" Radio.Group a real label (via the
  Subtitle) so the radiogroup has an accessible name again — Mantine doesn't
  name it from a sibling label + aria-label. Fixes the actions e2e specs that
  query the radiogroup by name, and add a positive assertion for it.

* Simplify comment
2026-06-30 10:14:41 +02:00
Mahatthana (Kelvin) Nomsawadi
b58a926cea feat(sdk): migrate analytics events to simple_event schema (#76337)
* feat: convert SDK analytics events to use trackSimpleEvent

Replace the custom Snowplow "sdk" tracker approach with trackSimpleEvent
so SDK analytics go through both Snowplow (simple_event schema) and
Metaplow automatically — no custom schema registration or Metaplow
migration needed.

Two events via trackSimpleEvent:
- embedding_sdk_initialized: fires once per JS load from ComponentProvider
- embedding_sdk_component_rendered: fires per component mount via
  triggered_from (component name) and event_detail (JSON with sdk_version,
  auth_method, locale_used, and component-specific properties)

Removes: snowplow.ts (custom tracker), sdkTrackerReady Redux state
(no longer needed — trackSimpleEvent needs no async init). Dedup for
component events switches to instance-based (useRef + nextInstanceId)
from entity-based, matching the reference branch design.

setSdkTrackingContext() is called synchronously during ComponentProvider
render so child component effects can read auth_method on the first commit
without needing a Redux gate.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: pass live store getState to Snowplow instance-context plugin

getSdkStore() calls configureStore() each invocation — no memoization —
so the plugin's lazy getSdkStore().getState() was always reading from a
fresh empty store, leaving analytics-uuid, version, and token_features
undefined on every event. Fix: pass store.getState from useSdkStore()
(the actual ComponentProvider store) to initSdkTracker, which threads it
into the plugin closure so it reads the live state at event-send time.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VagN42CYBMhd1MHSDhbxTJ

* test: guard tracker-before-event ordering with an integration test

Uses real tracker.ts, snowplow.ts, component-events.ts (only
@snowplow/browser-tracker mocked) to assert that newTracker is called
before the first trackSelfDescribingEvent across a parent+child tree.

Falsifiability verified: reverting initSdkTracker to useEffect causes
the assertion to fail (invocationCallOrder 9 > 6), confirming the test
is exercising real render/effect ordering, not just mocked call counts.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VagN42CYBMhd1MHSDhbxTJ

* fix: address review findings for simple_event schema migration

- Cache sdkMetaplowEnabled at init instead of storing the full store ref
- Unexport trackSdkEvent; only trackSdkSimpleEvent is public
- Move SdkComponentName back to component-events.ts (SDK-only type)
- Remove triggered_from from SDK event types; component goes in event_detail
- Nest event_detail as { component, properties, global } envelope
- Restore field order auth_method/sdk_version/locale_used in global block
- Add sdkTrackerReady Redux flag; gates per-mount events until tracker is up
- Initialize SDK Snowplow tracker synchronously to prevent first-event drop
- Read metaplow gate from Redux store, not Settings singleton

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018HWtepijYZu4qkYB3XAgwT

* fix: tighten trackSdkSimpleEvent to EmbeddingSdkEvent union type

Narrows the parameter from the open SimpleEventSchema to the closed
EmbeddingSdkEvent union so only known SDK events are accepted at
call sites. Updates two Metaplow gate tests to supply the now-required
event_detail field and runs Prettier on format-checked files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jux5AAEEsYVNUNSUEK8zBF

* refactor: remove implementation-detail tests and unnecessary diffs

- Delete reducer.unit.spec.ts (Redux plumbing; behavior covered by events
  and tracker specs)
- Delete ComponentProvider test 1 (call arity check); update tests 2 & 3
  to use toHaveBeenCalledWith instead of magic index access
- Extract parseEventDetail/findEventByComponent helpers in e2e spec to
  eliminate repeated try-catch JSON.parse blocks
- Restore setSdkTrackerReady position in reducer.ts to append after
  setInitialDashboardTabId (matches master, removes unnecessary diff)
- Restore JSDoc on sdkTrackerReady in types.ts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jux5AAEEsYVNUNSUEK8zBF

* refactor: simplify event_detail assertions in events spec

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jux5AAEEsYVNUNSUEK8zBF

* refactor: move SDK event types and schema URI out of metabase-types

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jux5AAEEsYVNUNSUEK8zBF

* fix: pass metaplow-url and analytics-uuid explicitly to trackMetaplowEvent

Convert trackMetaplowEvent to object-style signature with metaplowUrl and
analyticsUuid params that default to Settings.get. The SDK caches both
values from the Redux store at initSdkTracker time and passes them
explicitly, bypassing the Settings singleton which is absent in a
customer's page.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jux5AAEEsYVNUNSUEK8zBF

* refactor: convert all metaplow.ts functions to object-style params

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jux5AAEEsYVNUNSUEK8zBF

* refactor: revert core app metaplow to positional params

Settings.setAll already runs in SDK auth flow, so trackMetaplowEvent and
trackMetaplowPageView can read metaplow-url and analytics-uuid via Settings.get
directly. No need to change the core app function signatures for SDK's sake.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NQTnAAmpqsWDQqNymVmnck

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-30 06:43:00 +01:00
Nick Fitzpatrick
c9f621e291 Add tables and snippets to useSetCollection (#76670)
* Add tables and snippets to useSetCollection

* remove table from Movable Models
2026-06-30 11:09:18 +05:30
Romeo Van Snick
fa01d45f28 Move content-translation facade out of metabase/i18n (#76140)
* Move content-translation facade out of metabase/i18n

* Fix missed i18n->content-translation references and import order
2026-06-30 15:38:22 +10:00
Egor Grushin
4193c0298d Gdgt 2589 replace deprecated select component (#76651)
* GDGT-2589 initial migration

* GDGT-2589 fix get json

* GDGT-2589 fix get json

* GDGT-2589 fix logs

* GDGT-2589 get rid of formselect from /common/

* GDGT-2589 fix size of new action form widget select

* GDGT-2589 fix test

* GDGT-2589 fix comboboxWidths

* GDGT-2589 make ClickMappingsTargetWithoutSource to look like master's version

* GDGT-2589 make ClickMappingsTargetWithoutSource to look like master's version

* GDGT-2589 update static embed

* GDGT-2589 update xray schema selector

* GDGT-2589 update xray schema tests

* GDGT-2589 move menu to combobox

* GDGT-2589 fix tests

* GDGT-2589 fix assertions

* GDGT-2589 fix e2e tests

* GDGT-2589 fixed AI slope

* GDGT-2589 fixed leftovers tests
2026-06-30 06:32:52 +01:00
github-automation-metabase
4fd6ffc3a4 Auto-update documentation for master (#76704)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-06-29 23:05:27 -04:00
Nemanja Glumac
fd95704a9c Report backend & driver test failures to ci-conductor (#76439)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 00:25:49 +02:00
lbrdnk
aff92695a5 Make more entities discoverable through mcp search (#76616) 2026-06-29 23:04:56 +02:00
Alexander Polyankin
6aa80c5a79 Granular permissions for workspaces (#76698) 2026-06-29 16:30:12 -04:00
Alexander Polyankin
c446d690c4 Fix setting writable and admin db details (#76696) 2026-06-29 16:01:12 -04:00
Nemanja Glumac
b114036f85 Stop running auto-stress-tests on any label (#76638)
* Gate auto-stress-test to only the flaky-test-fix label event
2026-06-29 20:48:59 +02:00
Braden Shepherdson
0161c22652 [PDFs] Resolve large results in temp files; surface "too large" errors (#76605)
Fixes UXW-4614.

There are effectively three "sizes" of query results for rendering
dashboard subscriptions. The PDF renderer had so far only supported the
smallest of them ("fits in memory").

The QP always *streams* query results, but the subscriptions sink
collects them in memory up to a threshold, then spills them to a temp
file and streams the rest there.

If the temp files get too large, we don't risk an OOM by reading them and
trying to render the dashcard. The files are discarded and the card's
results are marked `:too-large? true`.

This PR makes the PDF renderer correctly read from temp files, and
properly surfaces a "results too large" message just like the FE if the
results are too big to render in one chart.
2026-06-29 14:37:44 -04:00
Alexander Polyankin
fe80ebe382 Perms graph reduce (#76678) 2026-06-29 14:33:39 -04:00
Braden Shepherdson
a926f047be Visualizer: Preserve the results_timezone if the source has one (#76446)
Fixes UXW-4040.

The timezone being dropped caused it to default to UTC, causing the
bug. With the `results_timezone` preserved the correct timezone is used
to render the x-axis and tooltip labels, achieving correct results.
2026-06-29 14:11:19 -04:00
Maz Ameli
b098b29d46 Restyle the user-joined invite email with the modern card template (#75452)
Migrate the "{user} accepted their Metabase invite" admin notification
email from the legacy _header/_footer layout to the newer card-style
template (_dashsub_alert_header) already used by the new-device login
and transform-failure emails. Updates the sender to build the nested
context map the new template expects.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-29 18:02:38 +00:00
technomancy
64a6e18e21 Make Snowflake data loaded checks look at row count. (#76647)
* Make Snowflake data loaded checks look at row count.

We have some unidentified process that destroys the test-data dataset
and causes failures such as this:

https://github.com/metabase/metabase/actions/runs/28206004397/job/83561786972#step:5:381

Sometimes the database exists but the tables have double or triple the
expected number of rows.

First change: refuse to destroy the test-data database. This should
just never happen. If this ends up throwing, it should allow us to
identify where the deletions are coming from. (Unless the culprit is
someone calling DROP DATABASE directly.) Of course, we really should
be blocking *all* deletions of static datasets, but this is by far the
most commonly-used, and we don't have a good predicate for identifying
static datasets anyway.

Second change: don't consider a dataset loaded if it's been
double-loaded or triple-loaded. Previously we would just look at
whether the dataset's database existed and ignore the tables inside
it, but now we'll be able to see when it's been double-loaded and
treat this the same as if it had not been created at all.

Third change: when creating a database, ensure it gets dropped first
before creating. Without this, the previous change would just cause
the datasets to get loaded increasingly many times. This actually
reverts a change made previously in #74464, but we have a lot more
data now about what's happening, and making create-db into a no-op
when it already exists has turned out to be counterproductive because
of the double-loading issue.

* Remove parallel from database-local-settings-test

This fails in CI sometimes with the following error:

    clojure.lang.ExceptionInfo: Error rolling back after previous error: (conn=362) Deadlock found when trying to get lock; try restarting transaction

This indicates it is probably not safe to do in parallel with other tests.
2026-06-29 10:57:38 -07:00
github-automation-metabase
4fe4c864d6 Auto-update documentation for master (#76636)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-06-29 12:23:01 -04:00
Oleh K
8f5eb11fba refactor: Migrate text and syntax tokens (#76508)
* GDGT-2533 Migrate text and syntax tokens

Sweep all consumer references from the legacy text/syntax tokens to their
new names (added in the foundation PR):

- text-tertiary -> text-disabled (and -inverse) — value shifts from solid
  orion to orion-alpha (intended recolor)
- text-hover -> text-brand-hover (value unchanged)
- syntax-parameters(-active) -> text-syntax-parameter(-active)
- saturated-{blue,green,yellow,red,purple} -> core-{blue,green,yellow,red,
  purple}-saturated (value unchanged)

`text-tertiary` and `text-hover` are also SDK public theme keys, so the
SDK_TO_MAIN_APP_COLORS_MAPPING right-hand sides gain the new internal names
as second targets and the public keys are left unchanged.

Per design review, the five saturated colors are renamed to
`core-{color}-saturated` palette primitives rather than `text-syntax-{role}`;
this PR adds those token definitions, removes the superseded text-syntax-*
ones, and keeps the legacy saturated-* definitions emitting until cleanup.
`text-secondary-opaque` is left untouched (open design question).

* Formatting

* Update Loki Snapshots

* Keep public SDK theme key text-tertiary in embedding examples/tests

text-tertiary is an embedder-facing SDK theme key (MetabaseColors), not an
internal token. The blanket sweep wrongly renamed it to the internal
text-disabled in three embedding spots that live outside the type-check
scope (e2e specs + the CLI scaffold snippet). Revert those to the public
text-tertiary; the SDK maps it internally via SDK_TO_MAIN_APP_COLORS_MAPPING.

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-06-29 16:36:18 +02:00
Anderson
14f1989888 Preserve dashboard table column settings for stale SQL question metadata (#76434)
* Fix dashcard table column settings merge

* Preserve dashcard-only table columns
2026-06-29 11:05:36 -03:00
Alexander Polyankin
49cc599892 Enable streaming results for app db queries with postgres (#76645) 2026-06-29 09:41:26 -04:00
Braden Shepherdson
3507005944 Move bshepherdson from QPlat to UX West on Github; remove edpaget (#76532) 2026-06-29 15:26:59 +02:00
Alexander Polyankin
bffea3f481 Simple shared image buffers for rendering (#76504) 2026-06-29 13:24:27 +00:00
Oleh K
f00423cbd5 Migrate underlined Radio usages to Mantine Tabs (#76535)
* Migrate underlined Radio usages to Mantine Tabs

Replace the `underlined`-variant usages of the deprecated
`metabase/common/components/Radio` with Mantine `Tabs` from `metabase/ui`:
AccountHeader, the admin PermissionsTabs, and the BaseChartSettings section
picker. Mantine's default tab styling already matches the old underlined look
(neutral list divider + brand active underline).

Add a thin `metabase/ui` Tabs wrapper (replacing the bare Mantine re-export)
with a typed `listBorder?: boolean` prop. When `false` it suppresses the tab
list's own divider (default variant only), so a full-width divider can instead
be drawn on a parent container — avoiding full-width hacks and absolute
positioning. The active tab's underline is unaffected.

Adopt that pattern everywhere the list divider is customized, and migrate the
tabs that previously hid the divider with one-off CSS to use it, deleting their
CSS modules:
- PeopleListingApp, TenantsListingApp, SourceReplacementModal (were
  `::before { display: none }`)
- AccountHeader and BaseChartSettings now draw the divider on a parent

Also tidy the permissions header layout (parent-drawn divider, toolbar back in
normal flow) and convert a leftover utility-class `div` to a `Box`.

Update BaseChartSettings tests from radio `toBeChecked()` assertions to tab
`aria-selected`.

Part of GDGT-2588 (PR 2 of 3).

* Update tests for radio -> tab structure

Fix tests that queried the migrated tab bars as radios:
- section picker (Scalar, viz-charts e2e): role="radio" -> "tab",
  toBeChecked() -> aria-selected
- permissions tabs (CollectionPermissionsPage, admin-permissions e2e,
  command-palette e2e, transforms e2e): role="radio"/"radiogroup" and
  label-based selectors -> role="tab"

* Fix data-permissions e2e for radio -> tab structure

The "data permissions > warns about leaving with unsaved changes" test
selected the Collections permissions tab via a label selector; the tab is
now a role="tab" button.

* Reflect listBorder in Tabs stories; show focus outline

- Add the `listBorder` prop to the Tabs Storybook stories (boolean control +
  a dedicated "Without list border" story).
- Show a keyboard focus outline on tabs via `:focus-visible` instead of
  suppressing it, for accessibility.
2026-06-29 14:40:53 +02:00
Jeff Bruemmer
cd9114d94b docs - update SQL query example (#76665) 2026-06-29 08:25:40 -04:00
Jakub Chodorowicz
fdb82ddafc GDGT-2665: Wrong colors in dark mode in getTextColorForBackground function (#76592) 2026-06-29 14:24:54 +02:00
Benoit Vinay
67f4a32538 Fix for docs link (#76660)
Docs link fixed
2026-06-29 08:13:48 -04:00
Romeo Van Snick
f7ea88f395 Fix flaky usage-auditing e2e: anchor seed today in instance timezone (#76657)
Anchor usage-auditing seed today in instance timezone, not UTC
2026-06-29 20:26:03 +10:00
Fraser
3ddd960cbc Add dep-cruiser for creating module graph (#76598) 2026-06-29 22:24:46 +12:00
Ryan Laurie
c14043d64e ignore info status on master and release branches (#76641) 2026-06-29 11:30:23 +02:00
Nemanja Glumac
00050453bb Remove duplicated custom viz e2e helper (#76637) 2026-06-29 10:27:36 +02:00
Nicolò Pretto
1fc3f75419 chore: update codeowners file for embedding folders (#76614) 2026-06-29 09:51:36 +02:00
Nicolò Pretto
2d6f530c2b chore(storybook): exclude embedding sdk stories from main app storybook (#76610) 2026-06-29 09:35:31 +02:00
Nemanja Glumac
1290678ca7 Consolidate dashboard sidebar-switch repros (#76639)
Consolidate dashboard sidebar-switch repros, drop flaky 27356 block

Fold the parameterized -> non-parameterized sidebar-switch coverage into
the better-asserted 26230 sticky-positioning test by making its switch
target a param-less bookmarked dashboard, and remove the redundant,
weakly-asserting flaky block.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-29 06:13:15 +02:00
metabase-bot[bot]
2621d3d6b5 [chore] Update E2E test timings with recent data (#76652)
Update E2E test timings with averaged data

Collected timing data from 7 days of test runs.
All specs with timing data were included (simple averages).

🤖 Generated automatically by update-e2e-timings workflow

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <actions@github.com>
2026-06-28 18:32:07 +00:00
Anderson
8a61a434ec Fix weekly line chart zero-fill across DST (#76376)
* Fix DST weekly zero fill in line charts

* Clean up DST zero-fill fix

* Address review comments
2026-06-27 21:01:57 +00:00
Romeo Van Snick
4f088825ca Remove @ts-nocheck from metabase-lib Question (#76506)
* Add transient creationType field to UnsavedCard type

* Type STRUCTURED_QUERY_TEMPLATE and allow null source-table

* Declare dev-only __lib_query/__lib_metadata/Lib window globals

* Accept null/undefined collection in collection type guards

* Remove @ts-nocheck from metabase-lib Question
2026-06-27 10:39:19 +10:00
Ben Grabow
fe593bdcf1 Copy old sample DB permissions to new sample DB on upgrade (#76561)
* Apply outgoing sample DB permissions to new sample DB
2026-06-26 18:17:30 -05:00
Chris Truter
6509e9818c HNSW benchmark utils + additional diagnostics (#75755) 2026-06-26 23:26:45 +02:00
Nemanja Glumac
ccfc78c97a Fix the flaky "trash" e2e test (#76634)
Open the navbar inside assertTrashSelectedInNavigationSidebar

Routes like a dashboard or question collapse the navbar, so the assertion
needs it open first. Two of the four call sites opened it manually while the
other two relied on the route not collapsing it. Fold the open into the
assertion helper so every call site is covered uniformly, and drop the now
redundant standalone calls. openNavigationSidebar is idempotent and self-heals
against a pending collapse, so calling it unconditionally is safe.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 23:25:01 +02:00
github-automation-metabase
362883f829 Auto-update documentation for master (#76566)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-06-26 17:21:02 -04:00
Anderson
7be4c69df7 Fix input styles in chart visualization settings (#76308) 2026-06-26 18:09:44 -03:00
Nemanja Glumac
fca0657ffc Make openNavigationSidebar self-heal against a pending navbar collapse (#76631)
Navigating to a dashboard/question collapses the navbar, and that collapse
can land a beat after the page content renders. The previous helper took a
single non-retrying snapshot of the sidebar's open state, so it could read a
lingering-open navbar, skip the toggle click, then watch it collapse out from
under the be.visible assertion. Re-check after acting and re-open if it
collapsed, bounded to a few attempts.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 22:46:04 +02:00
Michael Eby
b0b035f0d0 docs: replace drill-through links (#76622)
* docs: replace drill-through links

* add relative links
2026-06-26 16:41:15 -04:00
Jeff Bruemmer
f941dc5964 docs - mcp edits (#76627) 2026-06-26 19:37:32 +00:00
Nemanja Glumac
f5015de183 Add ExplicitSize test for measuring a child that renders content after mount (#76559)
* Add ExplicitSize test for measuring a child that renders content after mount

PivotTable returns null on its first render, so ExplicitSize has nothing
to measure at mount. The regression was that once it rendered content,
its size was never recalculated without a resize event, leaving the
child stuck at null dimensions. Cover that contract directly at the unit
layer rather than through a flaky e2e viz-switch repro.

* Delete e2e repro for 51926

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 14:37:19 -03:00
Chris Truter
a6da15a4b1 feat(search): publish analytics for every search context (#75443) 2026-06-26 17:09:41 +00:00
Jeff Bruemmer
342b6fcb79 Update tool description for read_resource (#76609)
Co-authored-by: Chris Truter <chris@metabase.com>
2026-06-26 16:19:09 +00:00
Anderson
0d432c97f1 Fix dashboard question breadcrumb layout (#76345) 2026-06-26 12:01:09 -03:00
Nick Fitzpatrick
e533c75f9a Fix flaky Pro-cloud email settings e2e test (#76168)
The test forced email-configured?=true with a response-modifying intercept
on GET /api/session/properties; a reload aborting an in-flight refetch made
the callback throw "Socket closed before finished writing response". Set
email-smtp-host server-side instead so email-configured? is genuinely true.
2026-06-26 13:55:11 +02:00
Uladzimir Havenchyk
0368561d80 fix: do not fire custom viz track event when no necessary (#76562)
* fix: do not fire custom viz track event when no necessary

* do not put track event on plugin
2026-06-26 11:37:36 +00:00
Chris Truter
4fe7e43256 Metabot should verify it has the right entity using metadata (#76438) 2026-06-26 09:54:00 +00:00
Nicolò Pretto
7ce7ce034f chore(sdk): clean up old sdk files when starting build-hot (#76538)
* chore(sdk): clean the dist folder when starting build-hot

* chore(sdk): skip writing the hot-update files to disk
2026-06-26 11:46:21 +02:00
Stas Gavrylov
aa0fe0bdd6 GDGT-2676/2677: Migrate Dependency Diagnostics & Admin Tools UI source code under Monitor space (#76416)
* Add monitor dir in metabase-enterprise

* GDGT-2676: Migrate Dependency Diagnostics under Monitor space

* GDGT-2677: Migrate Admin -> Tools under Monitor space

* GDGT-2676: Fix paths

* GDGT-2676: Create separate high-level directories for migrated features

---------

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
2026-06-26 12:01:05 +03:00
github-automation-metabase
fb78326577 Fix flaky data-studio bulk "edit attributes for db" e2e test (#76407)
After publishing, the active-path effect in useExpandedState auto-expands
the database. The test then clicked the (already-expanded, active) database
row, which only toggles expansion and collapses it again — so the schema
fetch never re-fired and the table rows disappeared, causing the getSchema
wait timeout and the missing [data-type="table"] failures.

Re-open Data Studio for a clean, collapsed tree before expanding the
database, matching the reliable pattern the sibling tests already use.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-26 15:34:04 +07:00
Mahatthana (Kelvin) Nomsawadi
720bb19d79 fix: bump dompurify, js-yaml, markdown-it; pin form-data (#76533)
* fix: bump dompurify, echarts, js-yaml, markdown-it; pin form-data

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EBYTJTjQQY4qo5EBCt5YwH

* fix: revert echarts bump; keep dompurify, js-yaml, markdown-it, form-data fixes

* fix: restore echarts 6.0.0 patch, remove 6.1.0 patch

* fix: regenerate release/bun.lock

* fix: pin form-data to 4.0.6 in root resolutions

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EBYTJTjQQY4qo5EBCt5YwH

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-26 08:13:06 +01:00
Mahatthana (Kelvin) Nomsawadi
6df842cd19 fix: pin opentelemetry-api to 1.62.0 (#76531)
* fix: pin opentelemetry-api to 1.62.0

* fix: move io.opentelemetry pin to correct alphabetical position in deps.edn

* fix: correct OTel comment attribution, fix stale sdk-testing comment, bump bigquery netty to 4.2.15

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EBYTJTjQQY4qo5EBCt5YwH

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-26 08:12:57 +01:00
Mahatthana (Kelvin) Nomsawadi
63919edccc fix: bump netty to 4.1.135.Final (athena) and 4.2.15.Final (hive-like) (#76530)
* fix: bump netty to 4.1.135.Final (athena) and 4.2.15.Final (hive-like)

* fix: correct stale version in athena netty comment

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EBYTJTjQQY4qo5EBCt5YwH

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-26 08:12:46 +01:00
Mahatthana (Kelvin) Nomsawadi
31034d8487 fix: bump jackson-databind to 2.21.4 (#76529)
* fix: bump jackson-databind to 2.21.4 and handlebars to 4.5.2

* fix: bypass handlebars 4.4+ root-classpath loader check

* fix: revert handlebars bump; keep only jackson-databind 2.21.4

* fix: bump jackson-core to 2.21.4 to match jackson-databind

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EBYTJTjQQY4qo5EBCt5YwH

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-26 08:12:32 +01:00
technomancy
9de4197be8 Update bigquery remark test to put the remark at the end. (#76567)
This behavior was changed in 3617b2c (#76462) but the test was
overlooked because of quarantine.
2026-06-25 23:03:46 +00:00
Sloan Sparger
a7ff8b0c55 [Metabot] Do not render images in markdown (#76280)
* SEC-505 prevent Metabot frontend from loading external images

* lint fix
2026-06-25 17:49:11 -05:00
Eric Normand
a87f3e0def Make workspaces deletable from any database state (GHY-3954) (#76350)
* Make workspaces deletable from any database state (GHY-3954)

delete-workspace! only deprovisioned :provisioned rows, but the model-level
guard rejects any non-:unprovisioned row. A WorkspaceDatabase stuck in
:provisioning or :deprovisioning (crash mid-flight, or a failed warehouse
teardown) made the workspace permanently undeletable with a 409.

delete-workspace! now drives every active row through a best-effort,
delete-only teardown (force-teardown-for-delete!) that works from any state:
it reconstructs the iso schema/user names deterministically from the row id,
drops them idempotently, always clears app-DB TableRemapping rows so query
routing is never left dangling, and forces the row to :unprovisioned. When the
warehouse is unreachable the workspace is still deleted; the 200 response then
carries :orphaned_resources and a :message naming the inert schema/user left
behind and why.

Recovering a stuck row without deleting (startup reconciliation / admin
force-unstick) remains GHY-3550.

* Surface orphaned warehouse resources in logs and the delete UI

Log a per-row warning (with the exception) when warehouse teardown fails
during delete, plus a consolidated warning carrying the full human-readable
orphan summary.

On the frontend, type the delete response (DeleteWorkspaceResponse) and, when
the workspace was deleted but warehouse cleanup partly failed, show a warning
toast naming the leftover schema/user objects and why they couldn't be removed
— the response is otherwise silently discarded since delete returns 200.

* Gate workspace delete on pending databases with an ignore-pending flag

A database still :provisioning/:deprovisioning may have warehouse work in
flight, so delete-workspace! now refuses by default (409, :pending_databases
lists them) rather than tearing such rows down. The new ignore-pending? arg
(ignore-pending query param, default false) leaves those databases' warehouse
resources untouched and removes only their app-DB rows. :provisioned rows are
still torn down, and the orphaned-resources reporting for unreachable warehouses
is unchanged.

On the frontend, the delete modal fetches the workspace's databases, and when
any are pending it swaps in a warning that lists them by name and confirms with
ignore-pending=true.

* Mock get-workspace in WorkspaceItem delete-modal test

The delete modal now fetches the hydrated workspace when opened, so the
'opens the delete modal' test hit an unmocked GET /api/ee/workspace-manager/:id.
2026-06-25 17:05:54 -05:00
Anderson
cfa17c66be Fix MySQL utf8mb3 app DB Library root migration (#76540)
Fix MySQL utf8mb3 library root migration
2026-06-25 18:34:52 -03:00
technomancy
8c9d598724 Check dynamic dataset in do-with-dataset-definition/with-transform-cleanup (#76543)
Check dynamic dataset in do-with-dataset-definition/with-transform-cleanup!

Monitoring failures for bigquery/snowflake on master, we're seeing
these are still trying to do creation/deletion of datasets and
occasionally failing on bigquery and snowflake.

These are specific to the tests for transforms and actions.

Long term we want to make it so this can work reliably. Short term we
just need the tests to fail less when blocking releases and allow us
to unquarantine sooner.
2026-06-25 14:24:46 -07:00
Nemanja Glumac
c0965b27dc Run e2e "smart test selection" on PRs only (#76539) 2026-06-25 23:11:51 +02:00
Nemanja Glumac
a61f013de4 Consolidate metabot usage-auditing e2e flake fixes (#76490)
* Consolidate usage-auditing row-chart drill-through e2e flake fixes

clickRowChartBarForLabel coordinate-clicked the chart container at a blind
labelRect.right + 30 offset, which intermittently landed on empty SVG so the
drill-through never fired (cy.wait("@conversations") timed out) or a near-miss
drilled a neighboring group. Two things conspired: the page only waits for the
audit metadata so the chart's dataset query + render could still be in flight,
and row charts measure their size asynchronously (ExplicitSize, throttled) and
first render with zero-width bars — assertChartRendered passes in both states.

Anchor on assertChartRendered, then click the measured (non-zero-width) bar
whose vertical band contains the label's midpoint, asserting exactly one match.
Cypress re-resolves the element's center at click time and retries for
actionability, so the click can't miss.

selectUserFilter anchored on `url includes "user="`, a no-op after a
drill-through since the URL already carries the drilled user, so it didn't gate
on the filter actually switching. Anchor on the select's value instead,
mirroring selectDateFilter.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Use graphics-symbol role query for row-chart bar drill

Swap the ad-hoc `[aria-roledescription="bar"]` attribute selector in
clickRowChartBarForLabel for the a11y query cy.findAllByRole("graphics-symbol"),
matching the conventions' preference for role queries over CSS attribute
selectors in spec files. Functionally equivalent — both resolve the same ECharts
row-chart bars within the scoped chart card.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Give the chart-render assertion a budget for the ECharts mount

The usage-stats page waits only for the audit metadata before rendering; each of
its six charts then fires its own adhoc /api/dataset query and mounts ECharts
independently. getChartCard resolves as soon as the chart title paints (a
Skeleton placeholder), but the [data-testid="chart-container"] only mounts once
that card's data query returns. With all six mounting at once under CI CPU
contention, the container mount routinely overran Cypress's default 4s budget,
surfacing as "Unable to find an element by [data-testid=chart-container]".

Give the chart-container readiness assertion a 12s budget (CHART_RENDER_TIMEOUT)
so it waits out the ECharts mount instead of racing it. This hardens every chart
assertion in the spec, including the assertChartRendered anchor the drill-through
helpers rely on.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-25 15:22:35 -05:00
Riley Thompson
a8f6bc947f Sync starburst and presto-jdbc column comments (#76440)
* sync trino and presto column comments

* starburst comment tests

* add presto test
2026-06-25 15:54:38 -04:00
Nathan Voxland
3c58b8226f Add UTF-8 BOM to CSV downloads (#76028) 2026-06-25 14:29:05 -05:00
Riley Thompson
37b72f94e4 Upgrade clickhouse jdbc driver to 0.9.8 (#73404)
* upgrade clickhouse to 0.9.8 and add relevant test

* fix test

* add boolean settings test

* format rows in test
2026-06-25 19:24:02 +00:00
Nathan Voxland
bd049b7d08 Throttle heavy log4j calls (#76482) 2026-06-25 13:40:06 -05:00
Riley Thompson
3617b2ce8b Put remarks at end of query instead of start (#76462)
* put remarks at end

* only keep fix for bigquery and starburst
2026-06-25 14:29:50 -04:00
technomancy
af705d639f Broaden the test disabling from #76502 (#76541)
Just missed a couple here.
2026-06-25 18:18:20 +00:00
Chris Truter
746a65d593 Support HNSW iterative-scan + cross-test each strategy (#75722) 2026-06-25 11:23:05 -04:00
Nick Fitzpatrick
0c145ac68b Searchable document content (#75841) 2026-06-25 09:44:23 -05:00
Eric Normand
a242d43788 Fix model filter dropdown lost on serdes sync (GHY-3946) (#76349)
* Fix model filter dropdown lost on serdes sync (GHY-3946)

A dashboard/model filter mapped to an MBQL model column rendered as a
text-search box instead of a value dropdown after the content was synced
via serdes (git sync).

Root cause: a model's result_metadata is serialized with overrides only
(display_name, semantic_type, ...); the structural :id that links each
column to its underlying Field is dropped on export and never restored on
import, because populate-result-metadata stores passed-in metadata
verbatim during deserialization. Without that link the column can't
resolve has_field_values, so the widget falls back to text search.

Fix: add a generic serdes load-finalize! lifecycle hook that runs after
every entity is loaded (when the referenced Tables/Fields are present),
and implement it for Card to re-derive an MBQL model's result_metadata
field links from its query while preserving the serialized overrides.
This keeps the serialized form unchanged (no :id in the YAML) and avoids
the load-ordering fragility of re-inferring at insert time.

* Drive model metadata restore through model-preserved-keys

Rework the Card load-finalize! to mirror the export: recompute the fresh
columns from the query, then overlay the serialized overrides using the
same lib/model-preserved-keys set (with this model's native flag) that the
export uses to decide what to keep. This replaces the opaque
infer-metadata-with-model-overrides call and removes the separate native
guard — native-ness now flows through model-preserved-keys, so native
models (whose infer-metadata yields nil) keep their already-complete
serialized metadata untouched.

* Remove comments on native models in card.clj

Removed comments about native models and infer-metadata.

* Switch to serializing model result_metadata :id as a portable ref

Carry each model column's :id through serdes as a portable field
reference (via *export-field-fk*), instead of recomputing it on load.
serdes already knows how to remap it on import (import-result-metadata),
and its FK resolution handles load ordering. This drops the load-finalize!
hook (and its serialization/load plumbing) in favor of a one-key change to
the model result_metadata keep-set.

* Re-derive model result_metadata :id on deserialization

Instead of serializing the model column :id (reverted), restore it on
import: when deserializing a model, populate-result-metadata re-derives
the result_metadata from the query (recovering each column's :id link to
its underlying Field) and blends the serialized overrides on top. This
assumes the referenced Fields are already present on the destination; if
they aren't resolvable, it falls back to the passed-in metadata.
2026-06-25 14:20:30 +00:00
Nemanja Glumac
eaf53de036 Ignore tagged tests in e2e smart runs (#76513)
Ignore tagged tests in e2e "smart runs"
2026-06-25 07:25:51 -06:00
Aleksandr Lesnenko
e4f821e593 indicate dirty transforms nodes (#76301)
* indicate dirty transforms nodes

* feedback
2026-06-25 08:58:15 -04:00
Ngoc Khuat
7ae5004486 Fix task_run.notification_id backfill migration on MySQL (#76509) 2026-06-25 12:43:48 +00:00
Nemanja Glumac
9a255e1059 Require an honest e2e-vs-unit-test breakdown in e2e-test-review reports (#76514)
Add a mandatory closing section to the e2e-test-review skill that classifies
each it() block as load-bearing e2e, narrowable, or a unit/component-test
candidate, grounded in which layers the test actually exercises. Wire it into
the review process and final-check steps so every report includes it.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-25 13:45:33 +02:00
github-automation-metabase
984b85591c Fix flaky transforms collections expand by clicking the Expand control (#76375)
The 'should create collections and save transforms to them' e2e test
created a nested transform collection and then clicked the parent row's
name to expand it. The row only toggles when row.getCanExpand() is true,
i.e. once the post-create collection-tree refetch has landed and
re-rendered with the new child. Clicking the name before that re-render
was a no-op, leaving 'Q4 Reports' hidden until the 4s findByText timed
out — a race that surfaced on faster (unthrottled) runs.

Waiting on the GET /api/collection/tree refetch wasn't enough: the
re-render can lag the network response. Instead, wait for the row's
Expand control, which the TreeTable only renders once the row is
actually expandable, and click that. Its presence is the deterministic
signal the child has landed, and it only ever expands (never toggles a
collapse), removing both the readiness race and the toggle ambiguity.

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-25 12:56:28 +02:00
Nicola Mometto
1ed83cde4b reduce compute load of transform planning (#76406)
* feat: cache table_dependencies, reduce read surface during get-plan

* feat: migrations

* for get-cycles too

* backfill migration

* tests

* fix

* write through on cache miss

* fix test

* ensure load source

* fix

* fix
2026-06-25 11:17:17 +01:00
Oleh K
30811cfc49 Migrate normal-variant Radio usages to metabase/ui Radio (#76405)
* Replace deprecated Radio with metabase/ui Radio (normal variant)

Migrate the four `normal`-variant usages of the deprecated
`metabase/common/components/Radio` to Mantine's `Radio.Group` + `Radio`
from `metabase/ui`:

- query_builder LimitPopover
- ActionCreator FieldSettingsPopover (input type)
- ValuesSourceTypeModal (parameter value source)
- enterprise EditSandboxingModal

Mantine's `Radio.Group` only handles string values, so the two non-string
cases are adapted at the radio boundary:

- EditSandboxingModal: boolean options -> "column"/"saved-question"
- ValuesSourceTypeModal: the null source type ("From connected fields")
  -> a sentinel string via serialize/deserialize helpers, keeping
  `ValuesSourceType` (incl. null) as the domain type everywhere else

Part of GDGT-2588 (PR 1 of 3).

* Adjust visual alignment
2026-06-25 11:34:13 +02:00
Oleh K
7e10ccb938 Preserve search relevance order for command palette actions (#76146)
* Preserve search relevance order for command palette actions (#76055)

The command palette re-sorted basic action results by a static
BASIC_ACTION_ORDER array, discarding the relevance order kbar's
useMatches already computes via Fuse.js. Since basic actions only
render when there is a search term, this static sort never served as a
useful default ordering and only buried the best match (e.g. typing
"New c" pushed "New collection" below "New question").

Drop the static re-sort so kbar's relevance order is preserved, and
remove the now-unused BASIC_ACTION_ORDER constant and processSection
sortOrder parameter.

* Update e2e test

* Make command palette nav test independent of action relevance order

* Try fixing e2e

* Fix test

* Tie-break command palette actions by default order via kbar priority

Rather than dropping the default action order entirely, encode it as a
small kbar `priority` so it only orders actions whose relevance scores
are equal. Typing "New" still surfaces "New question" first, while a
stronger match like "New c" surfaces "New collection" (metabase#76055).

Adds unit coverage for both cases and restores the concrete navigation
assertions in the palette specs.

* Rank palette actions by relevance with registration-order tie-break

Type a query and the command palette now orders basic actions by kbar's
search relevance, falling back to registration order only to break ties
between equally-relevant matches (via a tiny per-action priority). This
fixes 'New c' burying 'New collection' while keeping 'New question' first
for the bare 'New' query.

Also drop the redundant 'new embed' and 'new SQL' keywords: each merely
duplicated words already in the action's name, but distorted Fuse scoring
for short prefixes (ranking 'New embed'/'New SQL query' above the plain
create actions for 'New'). They remain findable by name.

* Restore PageDown-based palette nav assertions with updated order
2026-06-25 11:33:52 +02:00
Romeo Van Snick
922fcf102e Move data studio to feature tier (#75846)
* Extract data-studio's cross-module surface into common/data-studio

* Move data-studio FE module to the feature tier
2026-06-25 16:08:05 +10:00
Romeo Van Snick
1df9e07651 Remove @ts-nocheck from metabase-lib Field (#76320)
* Widen isDimension/isMetric and formatField parameter types

* Fold Base into Field and remove @ts-nocheck

* Type the Field constructor input and keep runtime-only fields on the class

* Use the API field directly in MappedFieldPicker; document Field hydration

* Move Field instance fields onto the class; drop vestigial JSDoc type comments

* Remove _comesFromEndpoint reference in clojurescript

* Take a NormalizedField in the Field constructor (removes constructor casts and lies)

* Move comment
2026-06-25 11:36:37 +10:00
technomancy
40d2f6caba Disable known-bad bigquery tests. (#76502)
Also: mark an unrelated test as requiring dynamic dataset creation.

Also: fix an unrelated bug in calculating which dataset tables already exist.
2026-06-24 19:41:35 -04:00
Romeo Van Snick
cd59e7adb5 Remove metabase/redux/question-reducer (#76134)
* Drop dead SOFT_RELOAD_CARD branch from questions reducer

* Hydrate questions slice via RTK endpoints, remove INJECT reducer

* Hydrate metadata store from entity mutation endpoints

* Revert "Hydrate metadata store from entity mutation endpoints"

This reverts commit fc20ae580a.
2026-06-25 08:39:34 +10:00
Ryan Laurie
362621fc4b Dont quarantine drivers on master or release branches (#76468)
dont quarantine drivers on master or release branches
2026-06-24 16:07:21 -06:00
github-automation-metabase
a55fd162cf Fix flaky data-studio bulk "syncing multiple tables" e2e test (#76492)
* Fix flaky data-studio bulk "syncing multiple tables" e2e test

The "syncing multiple tables" test restores the postgres-writable snapshot
in its body but, unlike every sibling test in this spec, never re-signs in
afterward. Visiting Data Studio could then land in an unauthenticated state
where the TablePicker never issues the GET .../schema/public request, so
`cy.wait("@getSchema")` timed out after 5s with "No request ever occurred".

Add `cy.signInAsAdmin()` after the restore — the same deterministic
re-authentication the reliable sibling tests already perform — so the
database expands and the schema request fires before the wait.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fix flaky "syncing multiple tables" e2e test: read table IDs deterministically

The test derived the expected table IDs from the intercepted `@getSchema`
UI response. Under stress that response body is occasionally a truthy
non-array (e.g. an error map), so `tables.find` threw
`TypeError: tables.find is not a function`. Read the table list from a
direct `cy.request` instead, which deterministically returns the array,
and keep `cy.wait("@getSchema")` purely as a UI-readiness wait.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 21:45:58 +00:00
github-automation-metabase
38c9fa8e6b Harden flaky read-only column resize e2e with bounded drag retry (#76483)
* Fix flaky resize-column-width e2e test with real-events drag

The read-only column-resize test hand-rolled a synthetic mousedown/
mousemove/mouseup sequence plus a magic cy.wait(10). The TanStack resize
handle re-renders while the table measures itself, so the synthetic
events intermittently landed on a stale node and the drag was lost (or
only partly applied), leaving the column width unchanged.

Drive the drag with cypress-real-events (CDP-level input) and re-query
the resize handle for every event so each one targets the live node,
matching the proven pattern in notebook-native-preview-sidebar. Drop the
numeric wait in favor of the existing retrying assertion.

* Harden flaky read-only column resize e2e with bounded drag retry

The synthetic TanStack column-resize drag in saved.cy.spec.js was
occasionally lost or only partially applied because the resize handle
re-renders while the data grid measures/auto-sizes itself, so the
width assertion would time out (e.g. expected 72 to be at least 82).

A prior cypress-real-events rewrite did not resize the 4px, hover-only
handle at all. Revert to the proven synthetic drag and re-run it until
the column has actually widened (bounded, gte-checked, idempotent), so
a dropped drag becomes a non-event instead of a failure.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 23:44:33 +02:00
github-automation-metabase
18da9c7f40 Stabilize pivot dashcard drill flake in dashboard-filters-misc (#76491)
* Stabilize pivot dashcard drill flake in dashboard-filters-misc

The 'does not use extra filtering stage for pivot tables' test drilled into
the pivot dashcard via its legend caption immediately after a raw
cy.button("Save").click(), without waiting for the dashboard to leave edit
mode. The drill only navigates in view mode, so when the click landed during
the save/edit-to-view transition it did nothing and /api/dataset/pivot never
fired, timing out cy.wait("@datasetPivot").

Use H.saveDashboard(), which waits for the save PUT, dashboard reload, and the
edit bar to disappear (view mode) before proceeding, so the drill reliably
triggers the pivot request.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Exit dashboard edit mode without awaiting a save PUT in pivot filter test

The 'does not use extra filtering stage for pivot tables' test only inspects
parameter mapping options (verifyDashcardMappingOptions opens the picker and
clicks away); it never creates a mapping, so the dashboard stays clean and
clicking Save issues no PUT /api/dashboard/*. The prior H.saveDashboard() call
waited unconditionally on the saveDashboardCards request, which only fired on
the runs where the dashboard happened to be dirty, timing out otherwise.

Pass awaitRequest: false so saveDashboard clicks save and waits for the edit bar
to disappear (view mode) without awaiting a PUT that may never occur. This still
guarantees the following legend-caption drill runs in view mode, where it
reliably triggers the pivot dataset query.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 21:41:25 +00:00
github-automation-metabase
7804a2b24f Fix flaky metabot usage-auditing by-day drill-through e2e (#76425)
The usage-auditing seed timestamps the "today" conversations at
`today - {15min, 30min, 2h}` where `today` is the current instant in
UTC. When the e2e suite runs shortly after UTC midnight, those events
roll into the previous UTC day, while the reported `:date` (the UTC
calendar day) advances to the new day. The "Conversations by day"
chart's last dot is then yesterday, so drilling navigates to
`date=<yesterday>` and the assertion `search` includes `date=<today>`
times out (e.g. `'?date=2026-05-25' to include 'date=2026-05-26'`).

Anchor `today` at noon UTC so every seeded "today" event stays firmly
inside the current UTC day regardless of run time. Relative offsets and
all per-hour relationships between the seeded conversations are
preserved.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 23:32:01 +02:00
github-automation-metabase
c06ca48e21 Fix click-behavior tab-fallback e2e flake: await target dashboard load before save (#76487)
Fix click-behavior tab-fallback flake: await target dashboard load before save

The "fall back to the first tab" test saved the dashboard immediately after
opening the click behavior sidebar, gated only by a negative assertion that
the tab selector is absent. That assertion passes trivially before the target
dashboard's fetch resolves, so the save raced ahead of the `migrateDeletedTab`
effect that falls the invalid tabId back to the first tab — the only thing
that dirties the dashboard. With no change registered, the PUT never fired and
`cy.wait("@saveDashboard-saveDashboardCards")` timed out.

Anchor on a positive signal (the click-mappings heading, rendered once the
target dashboard has loaded) before asserting the tab selector is absent, so
the migration has run and the dashboard is dirty by the time we save.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 23:21:48 +02:00
Uladzimir Havenchyk
41c638c12a fix: make no results text neutral (#76175)
* fix: make no results text neutral

* update screenshots

* update screenshot
2026-06-25 00:11:19 +03:00
github-automation-metabase
f9fbba15e0 Fix flaky bulk publish/unpublish e2e test (#76488)
The "allows publishing and unpublishing multiple tables" test clicked the database row to expand it and then waited on the schema fetch. The picker tree is still mounting when the databases request resolves, so the click on the row landed before its expand handler was wired and was dropped — the GET .../schema/public?include_hidden=true request that populates the tables never fired, timing out cy.wait("@getSchema") with "No request ever occurred" (and downstream, the [data-type=table] rows never rendered).

Click the database's dedicated expand toggle once it has rendered in its collapsed state (aria-expanded=false), then assert it reaches the expanded state. The pre-click assertion anchors on a positive readiness signal so the toggle is fully interactive before we click it, making the schema fetch fire deterministically.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 23:10:12 +02:00
github-automation-metabase
e15ce8caae Fix flaky test: should not reload dashboard cards not connected to a filter (metabase#32444) (#76484)
* Fix flaky dashboard filter card-reload e2e test

The "should not reload dashboard cards not connected to a filter" test
re-aliases the dashcard query intercept after saving the dashboard, then
asserts exactly one filter-triggered card query fires. Saving exits edit
mode and reloads both dashcards, but the test waited for only one of those
two post-save queries. The unwaited second query, slow under network
throttling, arrived after the intercept was re-registered on the same URL
and got counted as a filter-triggered query, so the assertion saw 2 instead
of 1.

Wait for both post-save card queries (total of four) to settle before
re-aliasing, so only the genuine filter-triggered query is counted.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Settle dashboard reload by loading state, not query count

The flaky dashboard filter card-reload test re-aliased the card-query
intercept right after saving, then asserted only one filter-triggered
query fired. A post-save reload query could still be in flight and get
captured by the new intercept, inflating the count.

The previous attempt waited for a fixed number (4) of post-save queries,
but how many fire is not deterministic — cached card results may be
reused, so the total varied (3 vs 4) and the wait failed.

Wait instead for both dashcards' loading indicators to clear before
re-aliasing, which drains the post-save reload regardless of how many
queries it issued.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 20:41:59 +00:00
Nemanja Glumac
8dfc0fc7c5 Consolidate unreferenced-entities e2e flake fixes into one guard (#76466)
The dependency graph is recomputed asynchronously on entity create/update,
so waitForBackfillComplete (global one-time flag) doesn't guarantee freshly
seeded entities have surfaced in the unreferenced list. Visiting too early
renders an incomplete list and findByText times out.

Replace the per-test ad-hoc waits with a single waitForUnreferencedAnalysis
helper that polls the unreferenced endpoint until every seeded entity (table
included, via the slower DB-sync path) is present. Apply it to all ten
presence-asserting tests, including five that shared the same race but were
never individually patched. The lone absence-asserting test keeps the global
backfill wait, since presence can't be polled for entities that should be
absent.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 14:26:25 -06:00
Alexander Polyankin
f573bc8dba Fix BigQuery OOM with information_schema queries (#76459) 2026-06-24 20:03:05 +00:00
Michael Eby
1701a63d4e docs: add page for dashboard heading and text cards (#76353)
* docs: add page for dashboard heading and text cards

* Optimized 6 images, saved 251.7 KB (49.2% smaller)

* Remove broken links

* Edits from Jeff

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-06-24 15:54:55 -04:00
Michael Eby
71895bbeff docs: add markdown page (#76019)
* docs: add markdown page

* Optimized 1 images, saved 4.5 KB (29.3% smaller)

* Edits from Jeff

* Edits from Jeff 2

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-06-24 15:54:44 -04:00
Alexander Polyankin
91db3c07f9 Fix perms OOM (#76463) 2026-06-24 19:53:08 +00:00
Ben Grabow
0c81b6fc95 Ghy 3975 fix dependency analysis on upgrade (#76442)
* Revert to returning unimported fk when importing fk fails

* Only ask for dashboard_id, for perf and to avoid pulling in problematic dangling refs in visualizer settings
2026-06-24 19:42:41 +00:00
github-automation-metabase
b096963652 Fix flaky test: data studio Undos allows to undo every action (#75996) 2026-06-24 21:38:27 +02:00
technomancy
a6c8c638b6 Mark bigquery as not supporting workspaces yet. (#76445)
Mark transform-schema-created-if-needed-test as requiring dynamic
dataset loading feature.
2026-06-24 18:47:58 +00:00
Alexander Polyankin
375861d545 Bigquery sync-fields less memory (#76441) 2026-06-24 17:40:00 +00:00
Nick Fitzpatrick
5c471b3e4d remove color prop from Based On Icons, center with flex (#76253) 2026-06-24 21:39:57 +05:30
Jakub Chodorowicz
65a4459af7 Gdgt 2498 integration treemap (#76346) 2026-06-24 16:54:30 +02:00
lbrdnk
d992491063 Ignore components of cors urls (#76192)
* Ignore components of cors urls

* Review remarks
2026-06-24 16:17:26 +02:00
Chris Truter
6ca4f480ff Create HNSW index only when explicitly using it (#76387)
* Create HNSW semantic-search index just-in-time, only when configured

The semantic-search index table always got an HNSW index on its embedding
column, regardless of whether anything used it. HNSW indexes are expensive
(build time, memory, disk), and a cluster hosting thousands of instances paid
that cost for every one even though ~99% are fast enough with an exact scan.

Flip the default vector-search strategy to :brute-force (exact, no index) and
only build the HNSW index when an instance is actually configured for :hnsw:

- create-index-table-if-not-exists! builds the HNSW index only when the
  configured strategy is :hnsw (covers env-var config and restarts). Extracted
  into idempotent create-hnsw-index-if-not-exists! (supports CONCURRENTLY).
- Setting the strategy to :hnsw at runtime triggers an async background build
  on the active index table (via core/build-hnsw-index-async!), so the settings
  call returns promptly.
- A query that requests :hnsw (e.g. a per-request override) when no HNSW index
  exists now fails fast with a clear error, rather than silently doing a slow
  exact scan.

* Add clj-kondo ignore marker to index-relfilenode test helper

Matches the sibling pgvector test helpers; suppresses
:metabase/test-helpers-use-non-thread-safe-functions.

* Build HNSW index only on the transition into :hnsw; test trigger and build

The setter previously kicked off a background build on every set to :hnsw,
including the restore that with-temporary-setting-values does. Gate it on the
actual transition (old != :hnsw) so redundant sets don't spawn stray builds.

Tests, split so neither relies on a real (flaky) future:
- index-test asserts the setter *triggers* a build only on the transition into
  :hnsw (spying on the async build).
- pgvector-api-test asserts ensure-active-hnsw-index! actually *builds* a missing
  index, and is a genuine noop when the index already exists (stable relfilenode)
  or when there is no active index.

* Build HNSW index via event instead of requiring-resolve; add startup safety net

* Test the indexer task's startup HNSW safety net
2026-06-24 16:00:22 +02:00
Romeo Van Snick
bb27b7a1c5 Fix MCP embed bundle loading async chunks from wrong origin (#76411) 2026-06-24 14:32:13 +02:00
Chris Truter
b934ac131d Add operator knobs for the pgvector connection pool (#75651) 2026-06-24 11:51:52 +00:00
github-automation-metabase
ecfa59f5fb Fix flaky bulk-table attribute-edit e2e test (#76408)
The "allows to edit attributes for tables" test clicked the database to
expand it and then immediately queried for table rows, without waiting
for the schema/tables to load. The tree picker is populated by an async
GET .../schema/public request, so the `[data-type="table"]` rows were
sometimes not yet rendered when the assertion ran, timing out after
4000ms.

Add `cy.wait("@getSchema")` after expanding the database — the same
deterministic wait the sibling tests in this spec already use — so the
tables are guaranteed to be present before selection.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 11:50:35 +00:00
Chris Truter
b57bcab6f0 Address minor tech debt in Search code (#76240) 2026-06-24 13:46:59 +02:00
github-automation-metabase
ff8b438987 Fix flaky auto-wiring foreign-keys e2e test (#76379)
The two auto-wire suggestion toasts (Orders Question + Reviews Question)
stack and briefly overlap while the undo list re-measures heights and
animates them into their final positions. During that window a sibling
toast can cover the precisely-scoped Auto-connect button, so cy.click()
fails its actionability check with "covered by another element".

Force the two Auto-connect clicks past the transient obstruction; the
target buttons are already uniquely scoped via
.contains(...).closest("toast-undo").

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 11:17:45 +02:00
github-automation-metabase
3b340f98e5 Deflake maps zoom/pan settle detection (#76383)
The "preserve zoom and pan after resize" test reads the first leaflet
marker position before and after a 1px viewport resize and asserts the
two are within 5px. The settle helper only required two consecutive
should() retries to land within 0.5px. Cypress retries faster than the
browser repaints, so two reads can fall in the same animation frame and
return an identical getBoundingClientRect() mid-animation, a false settle
that captured the after-zoom baseline before leaflet finished animating,
producing the historical 8-29px gaps.

Anchor the settle on elapsed wall-clock time (performance.now) instead of
read-count: require the marker to hold within 0.5px of an anchor for at
least 200ms before sampling, which a single-frame coincidence cannot
satisfy.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 11:09:54 +02:00
github-automation-metabase
807236db31 Fix flaky embedding data-picker join-step e2e test (#76380)
The picker resolves its initial path asynchronously before auto-navigating
into the data source's collection: a card-metadata fetch plus one
listCollectionItems request per collection level. On a throttled CI runner
that serial chain outlasts Cypress's default 4 s command timeout, so the
clickPickerItem lookup gives up while the picker is still showing the root
collections — the dominant "cannot find menuitem 'QA Postgres12 Orders
Model'" failure.

Give the picker-item lookup a generous timeout so it waits for the path to
finish resolving, and assert visibility before clicking. Also drop the stale
comment referencing a force-click that was already removed.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 16:07:35 +07:00
Oleh K
6dd944131e refactor: Migrate background-* tokens to background_page-* / background_surface-* (#76049)
* GDGT-2532 Migrate background-* tokens to background_page / background_surface

Sweep all consumer references from the legacy `background-*` semantic
tokens to their `background_page-*` / `background_surface-*` counterparts
(added in the foundation PR):

- Page:    background-primary/secondary/tertiary (+ -inverse), -highlight
           (-> -highlighted), -filter  ->  background_page-*
- Surface: background-disabled (+ -inverse), -hover, -selected, -brand
           (-> -brand-subtle), -success, -warning (+ -secondary -> -strong),
           -error (+ -secondary -> -subtle)  ->  background_surface-*
- Replaces: background-info -> background_page-tertiary;
            background-success-secondary -> feedback-positive-selected

SDK public theme keys (background, background-secondary, -hover, -disabled,
-error, -light) are part of the embedder-facing contract and are left
unchanged; the SDK_TO_MAIN_APP_COLORS_MAPPING right-hand sides gain the new
internal names as second targets so SDK/whitelabel overrides reach consumers
that now read the new tokens. Alert.config.tsx's `background-${color}`
synthesis is replaced with an explicit lookup map.

Drive-by fixes (pre-existing, surfaced by the sweep):
- EmbedFrame.module.css: fix `-inverseer` typo (undefined var since #65855).
- Bare `var(--mb-color-background)` was never a real token (rendered
  transparent at 8 sites); point each at the correct token by role and
  remove the dead `--mb-color-background` definition in LogoBadge that was
  silencing find-never-defined-css-variables.

* Use surface background tokens for Switch component

The Switch is a control (a surface on the page), so its track/thumb
backgrounds should use `background_surface-*` rather than `background_page-*`.
Disabled states now use the purpose-built `background_surface-disabled`;
the enabled off-track uses `background_surface-secondary`.

* Remove redundant comment

* Use text-secondary for RowChart axis text

The axis tick + title text was borrowing `background_page-tertiary-inverse`
(a background token) for its color. That token recolors as part of the
background migration, which shifted the axis text. Point it at the proper
`text-secondary` token instead — also consistent with the goal label.

* Update Loki Snapshots

* Formatting

* Update Loki Snapshots

* Update dark-mode body background assertion for recolored page-secondary

The body background uses `background_page-secondary`, which this migration
intentionally recolors in dark mode (color-mix off the page primary). Update
`assertDarkMode` from rgb(5, 14, 21) to rgb(5, 17, 25) (#051119) to match.
Light mode is unchanged.

* Assert dark-mode body background as color(srgb ...) computed value

The body background is a color-mix(in srgb, ...), which browsers serialize
in computed style as color(srgb ...). Assert the exact computed value
instead of an approximated rgb().

* Formatting

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-06-24 10:31:02 +02:00
Romeo Van Snick
dbf7e231fe Fix document boundaries (#75311) 2026-06-24 17:10:59 +12:00
Alexander Polyankin
1062bfb0a4 Fix BigQuery getQueryResults pagination (#76396) 2026-06-23 23:52:01 -04:00
Romeo Van Snick
d2ffdf5e3f Remove legacy API client (#76241)
* Migrate SDK execute-action to api.request

* Use updateSetting RTK hook in test render helper

* Remove legacy API client

* Flatten ApiClient request dispatch into a single _send

* Call updateSetting hook inside the test store provider

* Use RTK query for executeAction in embedding SDK bundle
2026-06-24 12:48:25 +10:00
Anderson
05e9b21565 Fix y-axis currency symbol clipping in compact view (#76138)
* Fix compact currency tick label padding

* Update loki snapshots

* Address review
2026-06-24 02:40:47 +00:00
Alexander Polyankin
b2b2786712 Fix bigquery nested fields sync (#76389) 2026-06-23 21:33:21 -04:00
Romeo Van Snick
f9fe257031 Allow full async lazy-loading Embedding SDK chunks (#75985)
* Fix embedding SDK on-demand chunk loading via runtime publicPath

The backend-hosted embedding SDK bundle shipped with output.publicPath: ""
and never set a runtime publicPath, so any dynamic import()/React.lazy chunk
URL resolved against the host app's origin (where SDK chunks don't exist) and
failed with ChunkLoadError.

Set webpack's runtime publicPath to the Metabase-hosted asset directory
(app/embedding-sdk/) so on-demand chunks load correctly:

- sdk-public-path.ts resolves the asset base and assigns __webpack_public_path__;
  it is the first import in the entry so it runs before any import().
- The chunked bootstrap exposes the base on
  window.METABASE_EMBEDDING_SDK_ASSET_BASE_URL (the entry runs asynchronously,
  so document.currentScript is unreliable there).
- The legacy monolithic bundle has no bootstrap, so the resolver falls back to
  document.currentScript.src, which is valid during its synchronous evaluation.

The backend already serves any app/embedding-sdk/chunks/*.js generically, so no
backend change is needed.

* Load jspdf and html2canvas lazily in the embedding SDK bundle

These export-only dependencies (~180KB brotli) were force-imported eagerly in
sdk-specific-imports.ts to work around the broken on-demand chunk loading. Now
that the runtime publicPath is set, drop the eager imports so they load on
demand (PDF / image export) instead of weighing down the SDK's critical path.

* Load pivot table grid lazily in the embedding SDK bundle

* Load map renderer lazily in the embedding SDK bundle

* Count async SDK chunks toward total bundle size now that they are loadable
2026-06-24 11:09:43 +10:00
Chris Truter
6c69992d5b Surface curation signals to Metabot in search results (#75511) 2026-06-24 00:27:26 +00:00
Chris Truter
edf5b0ae2e Consolidate "curation" filtering for Metabot (#75510) 2026-06-24 01:53:51 +02:00
github-automation-metabase
a05d864d9d Fix flaky dashboard back-navigation e2e test (#76382)
The "back to the dashboard button when navigating to a question" test
clicked "Edit question" from a dashcard and immediately clicked the
"Back to <dashboard>" button without waiting for the notebook editor to
finish loading. Clicking back before the query builder settles produces
a racy back-navigation that can briefly leave the dashboard without a
mounted app bar, so the later `appBar()` lookup ("Navigation bar")
intermittently fails while the dashboard header text is already visible.

Wait for the notebook editor's "Visualize" button to be visible before
clicking back, mirroring the sibling native-editor test and the
dashboard.cy.spec navigate-to-notebook test.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 22:22:41 +00:00
Sloan Sparger
774531880a [Metabot] Add v1 to v2 migration fns (#75662)
* adds migration for v1 message schema to v2

* output adjustment

* flip migration output keys to camelcase

* match on v1 malli schemas, improve tests

* copilot feedback

* pr feedback

* test fixes
2026-06-23 17:12:27 -05:00
Alex Yarosh
875ee94fc9 docs: Add note about public links and database routing (#76152)
Add note about public links and database routing

Clarified that public links do not function with database routing.
2026-06-23 17:56:09 -04:00
github-automation-metabase
e33b302372 Fix flaky usage-auditing chart drill-through e2e (#76377)
The "drills through from the conversations by hour/day chart" tests
interact with the timeseries chart immediately after visiting the usage
stats page, which only waits for the audit metadata request. The chart's
dataset query and ECharts render can still be in flight, so
cartesianChartCircle() races the render and intermittently times out
looking for [data-testid="chart-container"].

Anchor clickLastTimeseriesChartDot on assertChartRendered so the chart is
fully rendered (container visible with an svg child) before drilling.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 21:53:01 +00:00
github-automation-metabase
a0d9a2614e Deflake model entity-qualified-id drill-through e2e test (#76373)
The test clicked a result cell immediately after saving a new model,
racing the table that renders/animates in after the redirect to the
model view (Cypress reported the cell as still animating). Wait for the
model create (POST /api/card) and its query (POST /api/dataset) to
resolve and assert the table is visible before clicking the cell, so the
click no longer depends on animation timing.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 23:46:44 +02:00
github-automation-metabase
0c6374742f Fix flaky dashcard-duplicate parameters e2e test (#76374)
The "should duplicate filters and mappings when duplicating a dashcard"
test began interacting with the dashboard parameters (clicking the
"Count" pill) immediately after entering edit mode. Entering edit mode
re-mounts the dashcards and re-runs the card query, so the parameter
header was still re-rendering asynchronously when the click fired,
detaching the target element mid-click ("cy.click() failed because the
page updated while this command was executing").

Gate the first interaction on the dashcard's chart being visible so the
page has settled before editing parameters.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 21:35:34 +00:00
technomancy
6fe0c5b57e Don't destroy database during creation failure for cloud DBs. (#76363)
Mark bigquery as not supporting dynamic test loading, because it's a
cloud DB.
2026-06-23 20:57:31 +00:00
dpsutton
6701de190d Notification temp storage across dashboard (#76355) 2026-06-23 16:54:59 -04:00
Alexander Polyankin
9315930aa7 Improve memory usage of sync-tables-and-database! (#76330) 2026-06-23 16:54:04 -04:00
github-automation-metabase
9901a4384d Fix flaky notifications unsubscribe e2e test (#76362)
The "unsubscribe from an alert when the user has not created it" test
scoped its post-unsubscribe negative assertion inside the
notifications-list container and never waited for the unsubscribe
request. Since admin was the only recipient and not the creator,
unsubscribing empties the list and the notifications-list container
unmounts into the empty state. When the refetch won the race,
findByTestId("notifications-list") timed out.

Wait deterministically on the unsubscribe POST, anchor on the success
toast, then assert the notifications-list is gone (the real
post-condition) instead of querying inside a container that disappears.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 22:14:48 +02:00
Ben Grabow
1d050aec9c Bgrabow/monitor memoization cache size (#75967)
* Monitor number of cache entries in unbounded memoization caches

* Refresh metrics every 10 minutes instead of 1 minute
2026-06-23 18:32:31 +00:00
Eric Normand
fdd669322d Log the reason for full remote-sync export/import fallback (GHY-3935) (#76348)
When export! or import! falls back from the incremental fast-path to a
full re-serialize/reload, log which guard forced it so operators can see
why a full sync ran:

- export: forced overwrite, or a pending change can't be applied incrementally
- import: forced, local changes pending, first import, or changes not
  incrementally loadable

Bind import dirty? as a delay so the fast-path check and the reason
derivation share one query without forcing it on the no-op/merge paths.
2026-06-23 18:13:31 +00:00
Andrei Chernykh
c96ad1f49a Fix @tenant.slug tooltip to read 'system defined' on the create tenant user from (#76321)
Fix @tenant.slug tooltip to read 'system defined' on the create tenant user form
2026-06-23 11:01:28 -07:00
appleby
00f5a7c258 Add agent-lib repair pass to fixup invalid lib/type for join clauses (#76309)
* Add metabase.agent-lib.representations.repair/rewrite-lib-type-aliases*

Rewrite the hallucinated lib/type mbql.join/join to the corrected mbql/join. The LLM was observed making this error in BOT-1657.

Similar to the existing rewrite passes:

- rewrite-operator-name-aliases*
- rewrite-temporal-bucket-aliases*
- rewrite-direction-aliases*

* Fill in a missing lib/type for join clauses

We already did this for stages and the top-level query.

* Validate lib/type for ::join clause in metabase.agent-lib.representations/validate-query

* Mark all deftests ^:parallel in metabase.agent-lib.representations-test
2026-06-23 16:03:14 +00:00
Denis Berezin
98e9faea89 UXW-3457 Fix select to overflow viz settings popover (#76297)
Co-authored-by: @syedfardeenjeelani
2026-06-23 18:04:11 +03:00
Kevin Kelleher
025cda0388 Fix non-unique key props in SectionLayoutPreview (#76250)
fix non-unique key props
2026-06-23 10:51:30 -04:00
Riley Thompson
74aa95064b Validate sqlserver additional options when connecting (#76293)
validate sqlserver optios when connecting
2026-06-23 13:48:41 +00:00
github-automation-metabase
daa7c3d33c Auto-update documentation for master (#76303)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-06-23 09:01:23 -04:00
Kevin Kelleher
49c604047d Fix bars overlapping in time series with only two bars (#76246)
* account for extra padding in bar width

* add loki test

* Update Loki Snapshots

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-06-23 07:10:03 -04:00
Nicola Mometto
0a0589299c Restrict glossary permissions (#76275)
* restrict permissions for glossary

* disable on UI

* adjust FE code + removed hover effect if the row is readOnly

* rename FieldId to GlossaryField

* address comments

---------

Co-authored-by: Egor Grushin <egor@metabase.com>
2026-06-23 10:05:54 +00:00
YB
403107f13f [GDGT-376] [GDGT-2624] fix serdes import oom (#75786)
Serializing the **import** of a very large data model (~1M+ fields) can OOM. The entire retained-memory cost of an import is the **ingest index**, built up-front before any entity loads (a flat memory plateau through the whole load phase).

Fixes:
1. **Drop the dead structures.** The cache value becomes the `File` directly (`{stripped-path File}`); delete `:from-ids` and its `medley` require, removing the second `ingest-list` pass.

2. **Intern path segments while building the index.** Each `{:model … :id …}` segment and its strings are canonicalized through a shared interner so index keys share their `[db schema table]` prefix structure. Value equality is unchanged, so cache lookups and `:seen`-set comparisons behave identically. Interning goes through a new `metabase.util.memoize/fast-interner` - a thread-safe `ConcurrentHashMap`-backed interner that stores the *canonical* value as the key (so the retained object is the string-pooled copy, not the parsed input).
2026-06-23 16:57:30 +08:00
Nemanja Glumac
dc80345e66 Drop the fix-flaky-test command (#76299) 2026-06-23 09:54:20 +02:00
Uladzimir Havenchyk
6787014a55 chore: drop deprecated Button (#76296) 2026-06-23 07:46:09 +00:00
Romeo Van Snick
3d5661eb54 Lazy load echarts module (#75220)
* Lazy load Echarts renderer

* Load Echarts as the vizualisation loads

* Use correct fallback for echarts renderer

* Fix placeholders for some skeletons

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Eagerly load echarts in sdk bundle

* Reenable brush after chart loads

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-06-23 16:24:56 +10:00
Alexander Polyankin
5ec0d46be4 Push sync limit to drivers (#76307)
* Push sync limit to drivers

* fix

* fix

* fix
2026-06-22 19:49:21 -04:00
Romeo Van Snick
e5b06223a1 Lazy load leaflet (#75222)
* Lazy load Leaflet

* Eagerly import map renderer in SDK bundle to fix lazy-loaded leaflet

The lazy `import()` of MapRenderer never resolves in the embedding SDK
bundle, which can't fetch on-demand chunks at runtime. Pull it into the
preloaded SDK bundle via sdk-specific-imports so the dynamic import
resolves from an already-loaded chunk, while the main app keeps its lazy
leaflet chunk.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-23 09:32:04 +10:00
Eric Normand
a60bd4f293 Surface essential-step sync failures instead of reporting initial sync complete (GHY-3943) (#76286)
* Surface essential-step sync failures instead of reporting initial sync complete (GHY-3943)

When an essential metadata sync step (sync-tables, sync-fields) failed
non-transiently mid-initial-sync, the error was logged and swallowed,
and the database's initial_sync_status was still set to "complete".
This left tables with zero fields while reporting success -- e.g. on
MariaDB <10.2, whose information_schema lacks generation_expression, so
describe-fields throws and no fields are synced, yet the query builder
reports 'Table has no Fields associated with it'.

Mark sync-tables and sync-fields as essential steps. Initial sync is now
reported as aborted (not complete) when an essential step fails for any
reason, in addition to the existing transient-error abort path. Non-
essential step failures (indexes, FKs) and per-table failures still
report complete, preserving graceful degradation. The status setters
no-op once a database is already complete, so re-syncs of healthy
databases are unaffected.

* Better factoring

* Remove unused metabase.util require in sync-metadata

The cond-based sync-db-metadata!* no longer uses u/prog1, so the alias
is unused; drop it to satisfy clj-kondo.
2026-06-22 17:04:54 -05:00
Ben Grabow
ebb8e4838b Replace H2 with SQLite for sample data 2026-06-22 21:50:25 +00:00
Braden Shepherdson
57991c5b67 [subs] Generate PDFs for dashboard subscriptions on the BE (#75205)
The PDFs are laid out on either A4 or US Letter paper, portrait orientation, following the size and positioning of cards on the dashboard itself.

This is a nearly complete rendering of the dashboard, akin to what you see in the brower:
- Directly building a PDF in memory with Apache PDFBox, a low-level Java library.
- All chart types supported by static viz
    - Recently expanded to include maps and pivot tables!
- Markdown rendering, including code blocks, clickable links etc.
- Unicode support (Europe, Cyrillic, Greek, Hebrew, Arabic, Hindi, CJK and others) including RTL
- iframe cards have their target (e.g. a YouTube video) rendered as a link
- Dashboard is run as the requesting user, and can have parameter values supplied
- Parameters on dashboard and individual cards are shown with their values.
- Solid API endpoint that allows for parameter values and directly responds with the PDF.
- Reusing query results when sending charts via email or Slack along with a PDF.

---------

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
2026-06-22 16:40:28 -04:00
Uladzimir Havenchyk
09726c60c7 chore: migrate to FormSubmitButton from metabase/forms (#75709)
* chore: migrate to FormSubmitButton from metabase/forms

* address code review
2026-06-22 23:28:58 +03:00
bryan
fdf5e72f54 dev.module-viz: interactive modules graph visualizer (#75256) 2026-06-22 20:21:49 +00:00
Andrei Chernykh
0c9ca2b55d Fix middle-click on search results (#76123)
* Make the whole search result row a real link so middle/ctrl-click opens a new tab, and migrate its styles to Mantine

* Block navigation on inactive results, fix click-tracking attribution, and harden the title color override
2026-06-22 11:55:42 -07:00
Alexander Polyankin
ea63bc4889 Fix OOM with BigQuery and Redshift sync (#76276) 2026-06-22 14:23:48 -04:00
Egor Grushin
ab33899be5 GIT-5689 get rid of tippy.js (#76247)
* GIT-5689 get rid of tippy.js

* GIT-5689 additional clean ups
2026-06-22 19:19:43 +01:00
Uladzimir Havenchyk
657d0ec515 fix: handle click on cancel button and make title bigger (#76148) 2026-06-22 21:15:17 +03:00
Denis Berezin
1b5aefd862 UXW-4466 fix Y-axis auto position (#76183)
* UXW-4466 fix Y-axis auto position

* Fix failing e2e

* Fix failing e2e
2026-06-22 21:05:34 +03:00
Nick Fitzpatrick
e809dd2715 Fix library tree auto-expand race leaving Data/Metrics collapsed (#76167) 2026-06-22 23:33:07 +05:30
Nick Fitzpatrick
4318830e5e Stabilize flaky datetime cell-edit table-editing e2e test (#76158)
remove randomness from table edit date test
2026-06-22 23:32:19 +05:30
Eric Normand
6bfb3cc0ae Enforce remote-sync dependency guard on card bulk-move (GHY-3791) (#76278)
* Enforce remote-sync dependency guard on card bulk-move (GHY-3791)

The bulk-move endpoint (POST /api/card/collections) was the only mutation
path that hand-rolled the remote-sync dependency guard instead of using
check-for-remote-sync-update. It checked the stale pre-update card objects
(so moving a root-level card into a synced collection slipped through) and
never checked dependents (so bulk-moving a depended-on synced card out of
the sync set was allowed, unlike the single-card PUT path).

Use check-for-remote-sync-update so the post-update state is re-selected
and both directions are checked inside the existing transaction.

Also add an edit-time test for adding a non-synced dashcard via dashboard
PUT, closing a pre-existing coverage gap.

* Unnecessary comment
2026-06-22 17:00:08 +00:00
Ben Grabow
63a2dbfdf4 Empty nodes yields empty traversal instead of error (#76262) 2026-06-22 16:50:11 +00:00
Riley Thompson
52833fb7bb Use table of LHS join column in query builder (#76038)
* use table of the lhs column

* apply suggestion
2026-06-22 16:41:04 +00:00
metamben
630fc8df93 Preserve nulls in day-of-week calculation (#76180)
Closes QUE2-687
2026-06-22 16:21:01 +00:00
Alexander Polyankin
59637becb1 Fix postgres test (#76277) 2026-06-22 11:58:18 -04:00
Riley Thompson
db9803f9b8 Remove mbql5 experiments (#75127)
* remove postgres-mbql5

* remove mbql5 experiment

* fix postgres, add testing code

* fix and clean up

* include h2 test

* ignore native queries

* add function to compare compilation results

* fix tests

* remove old mbql5 references

* move redshift to mbql5

* redshift compilation test

* examples

* save changes

* fix bad merge
2026-06-22 11:21:28 -04:00
Riley Thompson
cea403df68 Dont override lib temporal types if driver type is text (#75663)
* dont override lib temporal types if driver type is text

* make test driver agnostic

* fix tests

* add sqlite test

* rename unreliable-driver-type? to prefer-lib-type?

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-22 11:03:17 -04:00
Nathan Voxland
16080fabce Fix appdb reindex misdirecting writes to the live index (#76199) 2026-06-22 09:56:06 -05:00
Alexander Polyankin
b342ae4aa7 Fix OOM with json/decode (#76221) 2026-06-22 10:41:55 -04:00
Alexander Polyankin
4392d6aff4 Fix OOM with sync metadata for postgres/redshift (#76218) 2026-06-22 10:41:42 -04:00
metamben
67f5557d3b Skip sandboxing during metric expansion (#76125)
Closes QUE2-681
2026-06-22 17:20:41 +03:00
Anderson
e1e1fef04b Fix conditional formatting range matching (#76137) 2026-06-22 10:53:42 -03:00
Anderson
36329b87e1 Fix download permission warning for blocked groups (#76075) 2026-06-22 10:53:31 -03:00
Ngoc Khuat
a65b91edee GDGT-2332: Retry cluster-lock writes on transient deadlocks (#75172) 2026-06-22 13:46:18 +00:00
Egor Grushin
e3ce080ee8 Gdgt 2590 replace deprecated tooltip component (#76117)
* GDGT-2590 remove tippy completely

* GDGT-2590 replace tippy Tooltip with Tooltip from metabase/ui.

* GDGT-2590 fix tests

* GDGT-2590 fix js test

* GDGT-2590 fix fade animation

* GDGT-2590 fix the gap in stacked tooltip

* GDGT-2590 remove the useState+useEffect hack

* GDGT-2590 remove redundant comment
2026-06-22 14:11:55 +01:00
Romeo Van Snick
4b32e29e29 Move collections frontend module to the feature tier (#75986)
* Move shared collection utilities to metabase/common/collections

Relocate the tier-agnostic collection helpers (utils, constants, types,
hooks, schemas, getExpandedCollectionsById, analytics) from
metabase/collections into metabase/common/collections so they remain in
the shared tier once metabase/collections becomes a feature module.
Update all importers to the new path.

* Move shared collection components to metabase/common/collections

Relocate the collection components and containers that are consumed by
other feature and shared modules (FormCollectionPicker,
FormCollectionAndDashboardPicker, CreateCollectionModal,
FormAuthorityLevelFieldContainer, CreateCollectionForm, PinnedItemCard,
ActionMenu, PinDropZone, CollectionRowMenu, QuestionMoveConfirmModal)
into metabase/common/collections. Extract the shared collection-content
column types into metabase/common/collections/columns. Update importers.

* Move metabase/collections to the feature tier

With all cross-module collection utilities and shared components now
living in metabase/common/collections, metabase/collections only holds
the collection browsing/landing experience. Promote it from the shared
tier to the feature tier so it can no longer be imported by shared or
other feature modules.

* Import SortableColumnHeader directly to avoid barrel cycle resolving undefined
2026-06-22 22:48:40 +10:00
Chris Truter
813d41e755 Respect explicit null collection_id in MCP creation (#75727) 2026-06-22 12:02:40 +00:00
Romeo Van Snick
1b0e9e91d4 Fix silent data corruption when a query errors mid-stream (#75586)
* Abort instead of sending json blob to client in streaming responses

* Stop trying to parse 202 as JSON

* Handle error in response.blob

* Stream an error event when metabot fails mid-stream in text/event-stream

* Clean up handleResponse

* Add e2e test for failing download

* Fix typo in handleResponse comment

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Revert completion flag when aborting the connection fails

If the Jetty .abort throws, the optimistically-set *completed?* flag would
otherwise stay true, causing do-f-async's finally to skip .complete and leave
the async request hanging until Jetty's timeout fires.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Add frontend tests for mid-stream download error handling

Covers readDownloadBlob mapping a blob() rejection to the localized
download-interrupted error, and handleResponse rejecting (rather than silently
resolving) when a streamed success body fails to read mid-stream — the behavior
that replaced the old 202 error-blob sniffing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fix flaky metabot disconnect test under forced chunked encoding

closing-connection-native-agent-test closed the response body stream to
simulate a client disconnect. Now that streaming responses force
Transfer-Encoding: chunked (for mid-stream abort detection on downloads),
closing the body makes clj-http drain the chunked response to completion —
which the server sees as a normal finish, not a disconnect, so the turn
finalized as :finished? true.

Close the underlying http-client instead, which aborts the connection and is
detected by the server's cancel loop — matching the existing pattern in
streaming_response_test. Adds user-real-request-full-response to expose the
:http-client from a real streaming request.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Add special error case for interrupted responses

* Render the new stream error differently than just a network error

* Remove stale _status in BE response

* Remove all references to _status

* Be more explicit about HTTP/2 in comment

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

* Disambiguate singular "Year" granularity label to fix i18n template build

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
2026-06-22 20:52:07 +10:00
Romeo Van Snick
26dc779def Disambiguate singular "Year" granularity label to fix i18n template build (#76231) 2026-06-22 10:51:07 +00:00
Chris Truter
632949fe3d Add search debug API to explain why an entity is missing from results (#75132)
## Summary

Adds a superuser-only **`GET /api/search/debug`** that answers "I searched for X but my card/dashboard/table didn't show up — why?". It takes a normal `/api/search` request plus `expected_result_type` and `expected_result_id`, walks the search pipeline against whatever engine the request resolves to, and returns `{type, details}` for the **first** stage that drops the entity.

| `type` | meaning |
|---|---|
| `not-searchable` | the spec says don't index it (no spec, or its `:where` excludes it) |
| `missing-from-index` | the spec would index it, but it's absent from the active index (stale/failed ingestion) |
| `filtered` | in the index but cut by a structural filter or permissions — `details.excluded-by` says which |
| `not-matching` | passes filters but doesn't match the fulltext/semantic query (semantic includes the 0.7 cosine cutoff) |
| `matched` / `ranked-out` | passes every stage; returned, or ranked below the limit |

## How it works

A new `search.engine/diagnose` multimethod, dispatched per engine — appdb impl in OSS, semantic impl in EE. Shared orchestration in `debug.clj` handles the engine-independent stages (`not-searchable`, terminal `matched`/`ranked-out`); each engine impl handles `missing-from-index` / `filtered` / `not-matching`.

The appdb impl reuses the normal `results` filter chain but **drops the fulltext predicate** — the blank-search-term seam — to separate "filtered" from "not-matching", and probes filters cumulatively to attribute which one excluded the row.

## Notes

- `indexed-entity` is rejected (400) — compound id doesn't fit `PositiveInt`.
- `not-searchable` reflects current spec/DB truth, so it wins over a stale lingering index row.

## Testing

`metabase.search.debug-test` (appdb) and `metabase-enterprise.semantic-search.debug-test` (pgvector, auto-skips without `MB_PGVECTOR_DB_URL`) — one case per result type. Green in a clean JVM.
2026-06-22 11:56:27 +02:00
Ngoc Khuat
0869369208 Admin notifications group by notification id not card id (#75928) 2026-06-22 09:23:04 +00:00
Oleh K
18eeb58dc2 refactor: Sweep border-* tokens to border-neutral-* (#75611)
* Sweep `border-*` tokens to `border-neutral-*` (GDGT-2531)

Renames all internal consumers of the legacy border semantic tokens to
their `border-neutral-*` counterparts (added by the foundation PR):

- `--mb-color-border`           → `--mb-color-border-neutral`
- `--mb-color-border-strong`    → `--mb-color-border-neutral-strong`
- `--mb-color-border-stronger`  → `--mb-color-border-neutral-strongest`
- `--mb-color-border-subtle`    → `--mb-color-border-neutral-subtle`

Sweep covers `var(--mb-color-…)` references in CSS modules and
styled-components, `color()`/`alpha()`/`darken()`/`getColor()`/
`renderingContext.getColor()`/`theme.fn.themeColor()` helper calls,
`theme.colors.border`/`theme.colors.border[0]` accesses, Mantine
`c`/`bg`/`color` props, and a couple of single-site palette lookups.
All four are pure renames — `border-neutral*` resolve to the same
primitives as the legacy tokens in both light and dark modes.

`border` is an SDK v1 theme input key (`MetabaseColors.border`), so
`SDK_TO_MAIN_APP_COLORS_MAPPING.border` now maps to both `["border",
"border-neutral"]`. Without it, an SDK consumer setting
`theme.colors.border = "#hex"` would update only the legacy
`--mb-color-border`; the new `--mb-color-border-neutral` that the swept
code reads would stay at its default. The dual-map covers both SDK v1
paths — the global `colors` object via `getEmbeddingColorPalette` and the
Mantine override via `getEmbeddingThemeOverride`. Unlike
`brand`/`filter`/`summarize`, `border` isn't a whitelabel
(`application-colors`) key, so no whitelabel-passthrough mirror is needed.

Also flips the four `border` references in the emotion-migrate skill to
their `border-neutral` equivalents, matching the per-sweep convention.

The SDK contract surfaces (`embedding-color-palette.ts` left-side input
key, `dynamic-css-vars-config.ts`, `dynamic-sdk-color-defaults.ts`,
`MetabaseTheme.ts`, `apply-theme-preset.ts`) stay on the legacy `border`
name.

* Realign table in SKILL.md
2026-06-22 11:14:18 +02:00
Oleh K
e78aaa2c44 Fix run query button icon being too small on large screens (#76223)
Remove the large-breakpoint padding override on the run button so the icon keeps its intended size across viewport widths.
2026-06-22 11:06:00 +02:00
Oleh K
dc878ea1e5 Add transform job run history page (#76017)
* GDGT-2632 Build frontend for job run history page

Add a "Run history" tab to the individual transform job page
(/data-studio/transforms/jobs/:jobId/runs) showing a paginated,
sortable, status-filterable list of past job runs, with a resizable
right sidebar to drill into the transform runs that made up a run.

- Types/API: TransformJobRun + TransformRunForJobRun, listTransformJobRuns
  and listJobRunTransformRuns endpoints, transformJobRuns URL helper
- Page: JobRunListPage (table, status filter, pagination, polling) and
  JobRunSidebar (job-run info + transform-run items with View transform)
- Tabs: JobTabs (Overview / Run history) wired into JobEditor + routes
- Promote shared sidebar pieces to metabase/transforms/components
  (SidebarResizableBox, SidebarInfoRow, ErrorSection, TimezoneIndicator)
  so both the runs page and job-run page use them instead of
  cross-importing between pages
- ErrorSection gains showTitle option; colors use the new token names

* GDGT-2632 Add run-method and start-time filters to job run history

The base endpoint now supports filtering job runs by run-method and
start-time, so wire them through and surface them in the UI.

- RTKQ/URL: add run-method + start-time to ListTransformJobRunsRequest,
  the transformJobRuns URL helper, and the page param parser
- UI: Trigger Select (manual/cron) and Started Select with relative
  presets reusing TaskRunDatePicker's labels/values
- Tests: cover each filter interaction and URL-driven params; fix an
  async sidebar assertion

* GDGT-2632 Extract TransformRunList to avoid nested ternary

Address PR review: replace the loading/empty/list nested ternary in the
job run sidebar with a small TransformRunList component using early
returns.

* GDGT-2632 Poll sidebar transform runs while a run is in progress

Address PR review: the job run list polls and updates a run's status, but
the sidebar's transform runs are a separate cache entry that never
refetched, so they went stale after the run finished. Poll the sidebar's
transform runs while the run or any of its transforms is still in
progress.

Lets the shared setup*Endpoint helpers accept a response getter so the
test can drive a run from in-progress to finished while the sidebar
stays open.
2026-06-22 09:11:34 +02:00
Nick Fitzpatrick
abeb35e2e6 Fix flaky impersonation caching e2e test (#76162)
After switching to the impersonated user and reloading, the test asserted
query-builder-main before the reloaded query returned; under load the page
outlasted the default 4s timeout (seen in CI at impersonated.cy.spec.js:143).
Wait on the @query response before asserting the error UI.
2026-06-22 07:40:12 +05:30
Nick Fitzpatrick
9eb4bd1407 Fix flake in should preserve correct order of columns after column removal via sidebar (metabase#13455) (#76083) 2026-06-22 07:39:51 +05:30
Nick Fitzpatrick
a56c304e9e Fix flaky document revision-history toast assertion (#76164)
The revert-error check used a singular toast-undo lookup, but the two earlier
"Document saved" undo toasts could still be visible, so it matched multiple
elements and timed out with an ambiguity error. Dismiss each save toast right
after asserting it so they don't stack into the later lookup, keeping the
simple singular assertions.
2026-06-22 07:35:59 +05:30
Nick Fitzpatrick
7c823b037d Fix flaky remote-sync read-only tenant collection test (#76161)
The test created a shared tenant collection right after enabling read-only
sync, racing the auto-triggered import. Both creations bump the implicit
collection-permission revision via a non-atomic max(id)+1 insert, so they
collided on the primary key and returned a 500. Now await the import first.
2026-06-22 07:35:45 +05:30
Nick Fitzpatrick
e2ad12e6bd Fix flaky maps zoom/pan-after-resize e2e test (#76159)
The test compared a pin marker's position before and after a 1px viewport
resize, but read both positions on fixed cy.wait() timers that race leaflet's
~250ms zoom/resize animation. On a slow machine the pre-resize read landed
mid-animation, drifting past the 5px tolerance. Read each position only once it
settles (poll until two consecutive reads agree) instead of waiting a fixed
time; the closeTo tolerance assertions are unchanged.
2026-06-22 07:35:25 +05:30
Nick Fitzpatrick
42446b8240 Stabilize data-studio bulk "edit attributes for db" e2e test (#76085)
The test selected the database, published it, then clicked the database
row to expand it. While a node is selected, the row click only toggles
expansion, which races the post-publish re-render and could collapse the
database so its tables never rendered. Deselect before expanding, then
wait on the schema request before asserting on the table rows.
2026-06-22 07:27:54 +05:30
Fraser
fd771cbb26 Move home to feature tier (#75213) 2026-06-22 13:34:45 +12:00
Fraser
0ef9a1f2a3 Move account to feature tier (#75211) 2026-06-22 13:29:21 +12:00
Romeo Van Snick
45d21618a2 Lazy load react-virtualized (#75680)
* Lazy load react-virtualized

* Force pivot table eager in SDK bundle to fix on-demand chunk failure

The SDK bundle can't fetch on-demand webpack chunks at runtime, so the
lazily-imported react-virtualized-backed pivot table never rendered,
failing the SDK component tests. Importing PivotTableInner from
sdk-specific-imports.ts inlines it eagerly only in the SDK bundle while
keeping the main app lazy.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 11:27:18 +10:00
bryan
7766803a0c Bump bun to 1.3.14 (#76037)
* Bump bun to 1.3.14

* Update bun version in actions

---------

Co-authored-by: Fraser <fraser@metabase.com>
2026-06-22 12:01:29 +12:00
Romeo Van Snick
4bb017ab46 Bundle sizes stats fix (#76220)
* Show error when response fails

* Upload bundle sizes to the correct stats table

* Leave Version empty for unknown build tags
2026-06-22 09:38:38 +10:00
Alexander Polyankin
4df92d8239 Do not fingerprint MongoDB binary blobs (#76214) 2026-06-21 11:17:41 -04:00
Romeo Van Snick
dfecbd6799 Convert metabase/redux/metadata.js to TypeScript and remove some deprecated handlers (#76048)
Type redux/metadata, merge metadata-typed, and split out remapping/revision thunks
2026-06-21 15:09:37 +10:00
Romeo Van Snick
9fd9561b4c Bundle size stats (#76043)
* Emit frontend bundle stats from production build

* Track bundle sizes over time in stats.metabase.com

* Fix formatting

* Remove unused lint rule

* Reuse measure-bundle-sizes.js in the SDK bundle size check
2026-06-21 15:08:36 +10:00
Romeo Van Snick
2c8318d72a Remove enterprise legacy services (#76132)
* Convert enterprise services.ts to RTK query hooks

* Convert application permissions API to RTK query hooks
2026-06-21 15:08:07 +10:00
Egor Grushin
3153af0735 Gdgt 2575 replace deprecated modal component (#75563)
* GDGT-2615 fix PopoverWithRef

* GDGT-2615 migration step 2. (checks 1–6 are passed)

* GDGT-2615 migration step 3 put comments

* GDGT-2615 fix comments

* GDGT-2615 fix test

* GDGT-2615 move tippy-leftovers to tooltip folder

* GDGT-2575 hook mantine's modal to RENDERED_POPOVERS and get rid of deprecated Modal

* GDGT-2615 fix import import "metabase/common/components/Tooltip/tippy.module.css";

* GDGT-2575 extra comment

* GDGT-2575 restore pie_chart.cy.spec.js to master

* GDGT-2575 remove RENDERED_POPOVERS stack

* GDGT-2575 fix closing order

* GDGT-2575 simplify a code

* GDGT-2575 restore working state + added comments + keep code simplification

* GDGT-2575 fix animations

* GDGT-2575 change test description

* GDGT-2575 remove legacy modal selector from H.modal()

* GDGT-2575 fix autofocus in CreateActionForm

* GDGT-2575 remove legacy test

* GDGT-2575 fix Cancel button in NewEventModal

* GDGT-2575 fix autofocus

* GDGT-2575 fix cancel buttons

* GDGT-2575 make wide to be 95% instead of 85%

* GDGT-2575 force rerender to be sync

* GDGT-2575 fix SDK test

* GDGT-2575 addressed #75637 PR's comment leftovers

* GDGT-2575 removed missed unused import

* GDGT-2575 rename store to context

* GDGT-2575 move OverlayStackProvider to the app and sdk roots

* GDGT-2575 fix codemirror editor tooltip inside transformed parent

* GDGT-2590 fix unit tests

* GDGT-2590 fix loki tests
2026-06-20 16:15:11 +01:00
Alexander Polyankin
6992729d5e Limit max sync / scan / fingerprint fields (#76189) 2026-06-19 20:05:50 -04:00
Chris Truter
0bc758804b Add search_curated tool for NLQ (#75237)
* Add semantic_layer_index table and the semantic-layer-search OSS module

The semantic layer is a hand-curated library of saved search prompts, each
mapped to the entities that answer it (canonical = one directly-answering
entity, sources = a set to combine), plus agent-facing usage_instructions.

- migration: single createTable for semantic_layer_index (search_prompt,
  usage_instructions, entities JSON, type, verified, entity_id, timestamps)
- :model/SemanticLayerIndex with validation (non-empty entities; canonical =>
  exactly one) and serdes spec (polymorphic entity refs export as portable
  Card entity_ids / Table paths, mirroring export-viz-link-card)
- write hooks only nudge the enterprise background sync (request-sync!
  defenterprise shim, no-op in OSS) - no embedding or pgvector work on the
  write path
- superuser CRUD API at /api/semantic-layer-search
- module config: new semantic-layer-search module entry

* Add the semantic_layer_search Metabot tool and wire it into the nlq profile

The tool matches the user's request by vector similarity against the curated
semantic layer instead of ranking the whole instance:

- over-fetches raw per-prompt hits, dedupes to distinct entity sets (several
  prompts map to one entity), and returns a small best-first list
- hydrates matched entity refs into the enriched search-result shape via a new
  public tools.search/entity-refs->search-results (portable_entity_id,
  database names, fully-qualified names, metric base tables), so the agent can
  build a query without an extra read_resource round-trip
- surfaces raw cosine similarity and flags low-confidence matches (< 0.45)
  with a leading <note> + confidence="weak", so a miss reads as a miss
- the nlq profile uses it in place of nlq-search-tool

* Add the enterprise pgvector mirror with asynchronous reconciliation

Replaces the hackathon design (embedding-service + pgvector writes inside the
appdb write path via Toucan hooks, best-effort and silently drifting) with a
self-healing background sync:

- reconcile! diffs the whole authoritative appdb table against the mirror by
  content hash every run: stale rows are re-embedded (batched), orphans
  deleted, unchanged rows cost nothing. Any missed write - pgvector downtime,
  a crashed node, an import that bypassed the hooks - is repaired on the next
  run with no operator action.
- index-table/ensure-tables! owns the pgvector DDL: vectors table + HNSW
  index + a single-row meta table recording the embedding model identity and
  schema version. A model/dims change (or version bump) drops and recreates
  the vectors table; the next reconcile re-embeds everything. That
  drop-and-rebuild is the whole model-change story - the source table is
  small and always available.
- task.sync runs reconcile! on a 30s Quartz schedule (cluster-singleton,
  DisallowConcurrentExecution); appdb write hooks trigger-now! the job so
  curator edits are searchable within seconds, with trigger coalescing as
  free debounce.
- core/search serves the tool's similarity query (cosine distance + flat
  canonical/verified boosts, regular-search-shaped score breakdown); [] when
  pgvector is unconfigured or the mirror table does not exist yet.

End-to-end test drives CRUD API -> reconcile -> pgvector -> tool against an
isolated mirror with the 4-dim mock embedding model.

* Wire SemanticLayerIndex into serialization export/import

- exported-models + extract/model-set (with a :no-semantic-layer-index
  opt-out, like sibling models) + ingest legal-top-level-paths
  (semantic_layer_index/, matching the model's storage-path label)
- round-trip coverage: in-memory ref transformation and a real on-disk
  export/import (the two layers that have silently dropped models before),
  excused from the shared baseline fixture it covers itself

* Simplify the semantic layer to a single entity per entry

Drop the sources/canonical distinction: every entry now maps one saved prompt
to exactly ONE entity. Simplifications that follow:

- appdb table: `entities` JSON array + `type` column become a single
  `entity` JSON object; the canonical-arity validation hooks disappear
- pgvector mirror: `canonical` column gone; scoring is similarity (1.0) +
  verified boost (0.1) only
- tool: dedupe key is the single entity, matches lose the kind attribute,
  flatten-data loses match_group, and total_count now trivially equals the
  per-entity row count
- API: no type field/filter

Also folds in the roborev branch-review findings (job 1915):

- serdes entity-ref vocabulary now covers ALL the entity models the tool
  hydrates (question was missing -> export threw; card was hydrated nowhere),
  with an export-viz-link-card-style fallback for unmapped model strings
  instead of aborting the export, and round-trip coverage for every card
  flavor (card/model/metric/question) plus table
- the sync job uses task/defjob (log context + tracing span) instead of a
  raw deftype re-implementing half of it

The remaining two findings (PUT canonical revalidation, total_count vs
flattened rows) are moot now that canonical/sources is gone.

* Address Copilot PR feedback: card->question normalization, XML escaping, finite embeddings

- entity refs with :model "card" now hydrate (normalized to the agent-facing
  "question" type via a new public tools.search/ref-model->entity-type, used
  for both hydration grouping and the tool's lookup key)
- curator-entered saved_search_prompt / usage_instructions are XML-escaped in
  the tool output
- format-embedding rejects NaN/Infinity (they satisfy number? but produce SQL
  literals pgvector chokes on)

* Fix nlq-profile tests for the renamed tool + roborev follow-up nits

CI: the pre-existing profile/tool tests asserted the nlq profile exposes a
tool named "search"; it is now "semantic_layer_search". embedding_next
deliberately keeps the general nlq-search tool (switching embedding customers
to a curated-only layer that starts empty was not in scope), so the
matches-nlq invariant test now asserts the tool sets are identical modulo
that one substitution.

roborev (jobs 1916/1917):
- reuse llm-shape/escape-xml (now public) instead of a second, narrower copy
- format-embedding error message covers non-numbers too ("invalid value")
- API EntityRef :model is now an enum of the known entity types, so garbage
  refs are rejected at the boundary; the serdes :else passthrough (for rows
  predating a model string's removal) gets a test
- migration header notes the in-place changeset edit for anyone who ran the
  earlier branch revision

* Relax the entity-ref response schema to tolerate retired model strings

The write-side enum stays (garbage refs still 400 on POST/PUT), but GET
responses accept any :model string: rows can predate a model string's
retirement — serdes already tolerates those — and under dev/test response
validation a single legacy row would otherwise 400 the whole list endpoint.
(roborev job 1918)

* Drop the in-place-edit note from the migration header

The earlier revision never ran anywhere that survives (and the table name is
new on this branch anyway), so there is no checksum-mismatch audience to warn.

* Fix CI: migration 062->063, ASCII minus, mage driver-test override

* Lint with-isolated-mirror as fn, not let (single-symbol binding)

* Address Copilot round 2: rank by blended score in SQL, PUT patch semantics, smaller nits

- search: the SQL LIMIT now orders by distance minus the verified boost
  (equivalent to the blended score), so a verified row whose boost lifts it
  into the top N is no longer cut by the raw-distance limit; covered by a
  ranking test that fails against the old ordering
- PUT: presence of a key (contains?), not nil-ness, decides what changes, so
  an explicit null clears usage_instructions; entity/verified reject null in
  the schema since the columns are non-nullable
- EntityRef write schema: id must be a positive int
- entity-refs->search-results: drop the per-card (set verified) rebuild;
  select-fn-set already returns a set
- tool instructions prose names the match/note elements without literal
  angle-bracket tags, keeping the instructions element well-formed

* Drop the unused HNSW index from the mirror table

The blended ORDER BY (distance minus the verified boost) can't be served by
an HNSW index, so since the ranking fix the index was built and maintained
but never used on the read path. An exact scan is intentional and
microseconds at curated-table scale; documented at the ranking expression
and in the index-table namespace docstring. (roborev job 1923)

* Tighten docstrings: contracts first, one sentence per line

- mirror/search shim now documents its return shape (the caller contract the
  metabot tool builds on)
- upsert-batch! claimed to return the rows; it returns the count
- format-embedding states the contract (throws on non-finite elements); the
  pgvector-chokes rationale moves to an inline comment at the check
- stale plural in the module docstring (entries map to ONE entity now)
- multi-sentence paragraphs reflowed to one sentence per line

* Bump mirror schema-version so existing tables shed the orphaned HNSW index

Dropping the index creation left tables built under version 1 carrying a
maintained-but-unused index until some other rebuild trigger. The version
bump forces the one-time drop-and-rebuild on first sync. (roborev job 1924)

* Test that a schema-version mismatch alone triggers the mirror rebuild

The version bump is the rebuild trigger the previous commit leans on; cover
it directly (stale-write the meta row, assert :rebuilt + emptied vectors
table) so dropping schema_version from the meta comparison can't regress
silently. (roborev job 1926)

* Assert the mirror rebuild self-terminates

After the rebuild cases, a follow-up ensure-tables! must return :ok — i.e.
write-meta! healed the meta row. Without this, breaking schema_version
handling in write-meta! would silently rebuild on every sync and the tests
would still pass. (roborev job 1927)

* Rename semantic-layer-search -> curated-search; tool 'search_curated', augment not replace

Drops the overloaded 'semantic layer' term (it collides with the BI metrics
layer and with 'semantic search' = embedding IR). New vocabulary throughout:

- appdb table semantic_layer_index -> curated_search_entries
  (model :model/CuratedSearchEntry); pgvector mirror -> curated_search_index
  (now the only thing called an 'index')
- modules curated-search / enterprise/curated-search; API /api/curated-search;
  serdes model CuratedSearchEntry, dir curated_search_entries
- tool var curated-search-tool, :tool-name "search_curated" (verb-first like
  the other tools; distinct from the general 'search' so the two can coexist)

Behavior: the nlq profile now offers BOTH the general search and the curated
search tool, rather than replacing one with the other. The curated tool is
gated on the :semantic-search feature (via a :feature-semantic-search
capability derived in profiles/feature-capabilities) and its description tells
the agent to prefer it, using general search as fallback/complement.

Also tightened two over-long inline comment blocks in EE core.

* Fix alphabetical ordering after the curated-search rename

The in-place sed rename left three sorted lists with curated-search/
CuratedSearchEntry in the old 's' slot:
- api_routes route-map (fails keep-routes-sorted-test) + its keep-me
- models/resolution model->namespace map
Move them to their 'c' slots. (roborev job 2041)

* Filter curated-search hydration by current-user read permissions

entity-refs->search-results fetched Tables/Cards via direct t2/select with no
permission check, so an admin-curated entry pointing at a restricted entity
could leak its name/description/db/portable_entity_id to a user who can't
access it. Filter both fetches with mi/can-read? (mirrors the transform
filter already in this pipeline). (Copilot PR review)

* Address claude-code branch review: permission-filter before take-n, locale-safe XML

- build-matches: hydrate (and thus permission-filter) the whole deduped
  candidate set, then take n — taking n first let unreadable top hits shrink
  the result below n while readable matches sat just past the cut. The
  preceding permission fix made this reachable.
- match->xml: use String/format with Locale/ROOT so %.3f always renders a '.'
  decimal separator (clojure.core/format uses the default locale; a
  comma-decimal site locale produced score="0,950").
Both covered by new regression tests. (roborev job 2042)

* Address claude-fable-5 branch review

- core_test e2e: bind a superuser around the tool calls — the permission
  filter (mi/can-read?) needs *current-user-id*, so the test was returning []
  and would fail wherever it actually runs.
- semantic-search.yml: add the curated_search EE test dir to each job's :only,
  so the pgvector-gated tests (reconcile, rebuild, e2e) actually run in CI
  instead of silently no-opping — which is why the broken e2e went unnoticed.
- dedupe-by-entity: normalize the model so a "card" and a "question" entry
  for the same Card collapse to one (both hydrate to one record).
- ordering: move CuratedSearchEntry / curated-search to their alphabetical
  slots in exported-models, mage driver-affecting-overrides, and the kondo
  lint-as map (+ column alignment).
(roborev job 2048)

* Address claude-fable-5 review: schedule sync independent of feature flag, harden hydration + prompt

- sync task: schedule the Quartz job whenever pgvector is configured (boot-fixed),
  not gated on the semantic-search feature. The job body already self-gates, so
  this keeps the periodic safety net + the write-path trigger's target job alive
  when a license is enabled after startup (otherwise the mirror silently never
  syncs while the tool is offered). New pgvector-configured? predicate.
- card-refs->results: emit one record per ref so a card registered under two
  type strings no longer collapses (last-type-wins) and drops a match.
- API: search_prompt is NonBlankString on POST/PUT — reject blank prompts
  (meaningless embedding + degraded serdes slug).
All covered by new tests. (roborev job 2110)
2026-06-20 00:07:54 +02:00
github-automation-metabase
8b90dc2110 Auto-update documentation for master (#76193)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-06-19 17:31:48 -04:00
Mihael Konjević
b907ae761d Make SQL guardrail skills always-on (#76176)
* Make SQL guardrail skills always-on

The on-demand skills system demoted read_resource and the SQL
create/edit/replace guidance from always-present system-prompt content to
catalog-only skills the agent had to load itself. With the guardrails gone
from the prompt, the SQL profile would loop read_resource calls (no
"drill, don't re-search"/"honor truncation" rules) and fire redundant
edit_sql_query calls instead of one replace_sql_query (no edit-vs-replace
guidance).

Mark read-resource, create-sql-query, edit-sql-query, and replace-sql-query
as always-on so their bodies are inlined into the prompt prefix again, while
keeping the bulky rarely-used skills on-demand. Harden load_skill
registration to fire when the manifest has any catalog or always-on skills,
so the dialect-preload invariant no longer depends on read-resource sitting
in the catalog.

* Make ask-for-sql-clarification always-on to restore SQL termination

The :sql profile is :required-tool-call?, which maps to Anthropic
tool_choice {:type "any"} — the model is forced to emit a tool call on
every turn and can never stop on free text. The agent loop only terminates
on max-iterations or a tool result carrying :final-response?. Among the SQL
profile's tools, ask_for_sql_clarification is the only one that sets it, so
it is the model's de facto termination signal.

The skills commit (ec842e1) moved the clarification guidance from the
always-inlined tool instructions to a catalog-only on-demand skill. Its
content was unchanged, but it was no longer present in the prompt, so the
model lost awareness of its terminal/handoff role and instead spun on
read_resource until hitting max-iterations (observed: a single edit_sql_query
followed by 19 redundant read_resource calls).

Mark the skill always-on so its guidance is inlined again, restoring the
pre-commit behavior. Together with the other SQL guardrail skills, the
:sql profile's catalog is now empty (all guidance inline, as before);
load_skill stays registered via the manifest's always-on entries so dialect
preload keeps working.

* Exclude always-on skills from the loadable/advertised skill set

Always-on skill bodies are already inlined in the system prompt, so the
model must neither see them in the catalog nor be able to load_skill them.
The catalog already removed them, but record-loadable-skill-ids! still
recorded every visible skill, leaving always-on ids loadable — so the agent
could burn an iteration re-fetching a skill it already has inline.

Record only the on-demand (non-always-on) skills as loadable, and build the
catalog from that same set.

* Make always-on a per-profile decision instead of a skill-global flag

A skill's always-on/on-demand status was a boolean on the skill itself, so it
applied to every profile exposing the matching tool. That is wrong: the SQL
profile wants its SQL skills inlined on every turn, but the internal profile
(which shares read_resource/create/edit/replace_sql_query) wants them
on-demand to keep its prompt prefix lean.

Move the decision to the profile: a profile lists :always-on-skills (skill
ids) whose bodies are inlined; every other relevant skill stays on-demand in
the catalog. build-skill-manifest now partitions on the profile's set rather
than the skill's flag. The skill-level :always-on frontmatter is removed, and
register-profile! validates that :always-on-skills resolve to real skills.

The :sql profile inlines read-resource + the create/edit/replace/clarification
SQL skills; no other profile opts in, restoring their pre-skills on-demand
behavior. Adds tests for the per-profile split and for always-on bodies
actually appearing in the rendered system prompt.

* Don't render the load_skill catalog header when the catalog is empty

Selmer treats an empty vector as truthy, so a profile whose skills are all
always-on (empty catalog) still rendered the "# Available skills … load the
skill(s) you need with load_skill" header with nothing listed — nudging the
model into pointless load_skill calls. Pass the catalog through not-empty so
an empty catalog is nil (falsy) and the header is omitted.

* Let a profile mark tools terminal; end :sql turn after a successful write

Under :required-tool-call? the model is forced to emit a tool call every
turn and can only stop on max-iterations or a :final-response? result. After
a clean edit_sql_query the SQL profile had no terminal tool to reach for, so
it spun on read_resource to max-iterations (e.g. 1 edit + 19 redundant reads).

Add a per-profile :terminal-tools set: a *successful* call to one of these
tools ends the turn. Success is detected by the presence of :structured-output
(the query/chart tools attach it only on success, returning just an error
:output otherwise), so a failed edit still lets the model self-correct.
Terminality is per-profile — the same write tools stay non-terminal in
profiles like :internal that need multi-step flows.

The :sql profile marks create/edit/replace_sql_query terminal. register-profile!
validates that :terminal-tools refer to tools the profile exposes.

* Replace tool-level :final-response? with per-profile :terminal-tools

Terminality was expressed two ways: the new per-profile :terminal-tools and
the older tool-level :final-response? flag (set by ask_for_sql_clarification
and the document_construct_*_chart tools). Two mechanisms for one concept —
and, like always-on on skills, the tool-level flag couldn't vary by profile.

Consolidate on :terminal-tools. Both tools already pair their terminal result
with :structured-output (failures return only :output), so success-gated
:terminal-tools is behaviour-preserving:
- :sql adds ask_for_sql_clarification to its terminal set.
- :document-generate-content marks document_construct_model_chart and
  document_construct_sql_chart terminal (schema collection stays preparatory).

Remove :final-response? from the tools and drop has-final-response? from the
loop. No frontend/persistence consumer read the flag.
2026-06-19 23:28:14 +02:00
Uladzimir Havenchyk
3f54ca2ce3 chore: replace more deprecated buttons with mantine buttons (#76051)
* chore: replace more deprecated buttons with mantine buttons

* cleanup

* fix button size

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* chore: replace more deprecated buttons with mantine buttons

* fixup

* apply suggestion

* fix test
2026-06-19 21:05:54 +00:00
appleby
951e37d922 Normalize row charts before sending to metabot in chart configs (#76102)
* Normalize row charts before sending to metabot in chart configs

* Validate chart configs in analyze-chart-tool
2026-06-19 13:08:35 -07:00
Riley Thompson
93954e82de Exclude remapped columns from saved question return columns (#75931)
exclude remapped columns from saved quesiton return columns
2026-06-19 15:59:43 -04:00
Riley Thompson
ff472d84da Re-enable test and clean up fixmes (#75963)
* re-enable data-editing-requires-describe-features-test

* remove trivial fixmes

* set nested-field-columns to false for mariadb

* check for not maria db
2026-06-19 15:59:26 -04:00
Eric Normand
f5e0129bf6 Show success confirmation when remote sync import/export completes (GHY-3747) (#76099)
* Show success confirmation when remote sync import/export completes (GHY-3747)

Remote sync import/export can take a while, so the progress modal now stays
open on success showing a confirmation message and a Close button, instead of
silently auto-dismissing.

The task carries a general-purpose `message` column (reusable beyond success)
populated from the sync result on completion and exposed via GET /current-task.
The modal renders the server message, falling back to generic copy when none is
provided.

* Store sync result as structured outcome, render copy on the client (GHY-3747)

Instead of storing customer-facing copy in remote_sync_task, store a structured
outcome map (e.g. {:kind "pulled" :count 12 :branch "main"}) and let the UI map
it to a localized message. This keeps copy out of the database and renders it in
the viewer's locale rather than freezing the worker thread's locale at write time.

- Migration: remote_sync_task.message -> outcome (JSON)
- complete-sync-task! takes an outcome map (multi-arity); :outcome JSON transform
- impl success paths return :outcome data; drop the tru strings
- Frontend: RemoteSyncOutcome union, modal maps kind -> copy, falling back to
  generic per-task-type copy when the shape isn't recognized

* Drop the no-auto-dismiss middleware test (GHY-3747)

It asserted the absence of the removed auto-dismiss behavior and needed a
subscribe:false workaround to avoid an invalidation refetch loop. The success
state (renders with a Close button, no auto-dismiss) is covered by the
SyncProgressModal component tests.

* Refactor.

* get rid of silly comment

* Test per-kind fallbacks for malformed sync outcomes (GHY-3747)

Cover the kind-specific fallback branches in getSuccessMessage when a known
outcome kind is missing its fields, including the combined pull-and-push copy
for a malformed merged outcome.
2026-06-19 19:33:58 +00:00
Riley Thompson
c95bba80cb Use scanner over regex in make-nestable-sql (#75970)
* use scanner over regex in make-nestable-sql

* clean up
2026-06-19 14:38:57 -04:00
lbrdnk
748eeb1ce7 Fix agent api /query pagination (#76013)
* Fix results pagination

* Adjust description
2026-06-19 20:35:59 +02:00
Anderson
22b1e3d54c Fix native time grouping ordinal labels (#76047)
* Fix native time grouping ordinal labels

* Address review
2026-06-19 15:20:12 -03:00
Sloan Sparger
94dc98834e [Metabot] Add metabot message validation schemas (#75546)
* add malli schemas for ai-sdk v4 + v5/v6 message formats

* add disposable v4 validation endpoint

* add fn to handle historically invalid v4 messages, remove endpoint, add comment form for validation

* split spec version up into files

* automated clean up pass

* v4 naming improvements, v5+ snake case conversion, small correctness changes

* remove ai sdk v4 format given our internal implementation was so incorrect, move to v1 + v2 file names

* tighten types a bit

* remove code comments

* flip v2 schema keys to spec-faithful camelcase

* clean up

* add helpers

* copilot feedback

* impl PR feedback

* second round pr feedback
2026-06-19 18:04:45 +00:00
Denis Berezin
da6c396006 UXW-3079 Add date format settings for Trend viz (#76130)
* UXW-3079 Add date format settings for Trend viz

* Fix CI

* Review suggestions
2026-06-19 20:52:31 +03:00
lbrdnk
07853910a8 Enable searching for models through agent api (#76076) 2026-06-19 19:41:36 +02:00
Sloan Sparger
3fc052ed12 [Metabot] Don't send query in user is viewing context for questions without a data source (#75569)
* ensure there is a data source before registering query context

* disambiguate validation error message

* add extra test
2026-06-19 17:35:59 +00:00
Jeff Bruemmer
bc5719510d docs - rephrase SSO note (#76181)
rephrase
2026-06-19 13:16:20 -04:00
Mahatthana (Kelvin) Nomsawadi
3e09ab817b docs: add embedding telemetry transparency section (#76069) 2026-06-19 11:54:13 -04:00
Phoomparin Mano
03ed418f80 Fix sensible visualization options in MCP Apps visualization selector (#75876)
* fix visualization selector showing illegal visualizations

* reset the stored default display when loading a new query

* refactor: cleanup logic to capture default display

* update unit test name to be clearer

* add unit test to captureDefaultDisplay

* update prompt in MCP resource to not mention display types or viz settings

* do not accept stale query results after query changes
2026-06-19 15:53:53 +00:00
Anderson
4cc540400e Fix pie chart Other slice drill-through (#75938)
* Fix pie chart Other slice drill-through

* Limit grouped pie drill-through actions

* Add e2e test to account for the Other slice drill through options

* Address metamben's
2026-06-19 15:29:38 +00:00
Copilot
69a279d4ad docs: add driver removal steps and required driver exception (#75870) 2026-06-19 11:05:05 -04:00
Nicolò Pretto
598fc88b68 feat(sdk): Custom visualizations in the Embedding SDK (#75920)
* Add custom-viz plugin support to the embedding SDK

Wire the SDK to load EE custom-visualization bundles. The core loader gains a
`sandboxMode` so the SDK can run plugins in an `about:blank` sandbox, fetches
bundles through the authenticated `api.fetch` client, and exposes
`unregisterCustomVizDisplay` / a `loadCustomVizPluginForDisplay` slot so a saved
`custom:*` question keeps its display instead of resetting to a built-in viz.

No allowlist yet: any installed custom-viz plugin loads.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Gate SDK custom-viz behind allowedCustomVisualizations

Add the `allowedCustomVisualizations` MetabaseProvider prop and gate every
custom-viz plugin slot (load, auto-load, list, icon) on it: only listed plugin
identifiers load, and a display dropped from the allowlist is unregistered so
the question falls back to a built-in visualization.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Add initialVisualization prop to SDK questions

Let host apps override the saved display when a question loads via an
`initialVisualization` prop on InteractiveQuestion/StaticQuestion. Accepts
built-in chart types and `custom:*` displays; the custom plugin is loaded
concurrently with the query and the prop falls back to the saved display when
the requested one isn't available or allowed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Show custom visualizations in the SDK chart-type picker

Eagerly load the allowed custom-viz plugins so their displays register in the
global visualizations map and appear in the chart-type dropdown, mirroring the
main-app ChartTypeSidebar. Lets users switch a question to a custom viz from
the picker.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Support loading icons via blobs in the sdk

* Update enterprise/frontend/src/embedding-sdk-ee/custom-viz/initialize.ts

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* Update enterprise/frontend/src/embedding-sdk-ee/custom-viz/initialize.ts

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* Update enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-dom-read.ts

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

* fix icon in collection browser

* use more specific types instead of "number"

* drop call site from code comment

* remove describeNode (unused) and unused imports

* change `allowedCustomVisualizations` to require `custom:` prefix

* warn the host app dev when they pass down plugins that we don't find in the instance

* temporarily disable initialVisualization

* update e2e after the removal of console.error

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
2026-06-19 16:49:57 +02:00
Nick Fitzpatrick
9228b95e0b Fix flaky template-tags transform test by waiting on the save request (#76157)
The undo-toast assertions ran immediately after clicking Save, racing the
PUT /api/transform/* round-trip. Wait on the existing @updateTransform intercept after each Save
2026-06-19 19:36:33 +05:30
Copilot
23c363b9af docs: document auth method switching behavior for existing accounts (#75900) 2026-06-19 09:51:40 -04:00
Alexander Polyankin
e615ca6f97 Fix memory leak with notifications and GraalVM (#76145)
* Fix memory leak with table notifications

* fix
2026-06-19 09:32:19 -04:00
Uladzimir Havenchyk
a57898c7c3 chore: replace more deprecated buttons with mantine buttons (#75903)
* chore: replace more deprecated buttons with mantine buttons

* cleanup

* fix button size

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* apply suggestion

* fixup
2026-06-19 12:42:52 +00:00
Sébastien
7dc9d844b3 Fix flaky editable-dashboard create-question e2e test (#76011) 2026-06-19 13:48:22 +02:00
Romeo Van Snick
8948318340 Convert mode.js to TypeScript (#76135) 2026-06-19 20:52:00 +10:00
Oleh K
f399a41952 Fix find-never-defined-css-variables for multi-line and whitespace var() usages (#76054)
* GDGT-2642 Fix find-never-defined-css-variables for multi-line and fallback var()

The CSS-variable lint only matched contiguous `var(--x)`, so any whitespace,
newline, or fallback between `var(`, the name, and `)` silently defeated
detection. Tighten the usage regex to `var(\s*(--name)\s*[,)])` so it catches:

  - multi-line:        var(\n  --foo\n)
  - inner whitespace:  var( --foo )
  - fallback syntax:   var(--foo, red)

Requiring a trailing `)`/`,` also skips dynamic `var(--mb-color-${x})` template
usages we can't statically validate. A `var(--x, fallback)` is treated as safe
unless `--x` is one of our `--mb-*` design-system primitives, which must always
be defined (a fallback would silently mask a typo or a dropped backport).

Add unit tests covering the bare, whitespace, multi-line, fallback, nested,
mb-with-fallback, and dynamic-interpolation cases.

The tightened lint surfaced several latent bugs, now fixed:
  - EmbedFrame: `--mb-color-background-tertiary-inverseer` typo -> `-inverse`
  - ThemeEditor PreviewPanel: nonexistent `--mb-radius-md` -> `--mantine-radius-md`
  - Switch: `--mb-color-accent-3` typo -> `--mb-color-accent3` (invisible error border)
  - Select: removed dead `.Select` rule and `--select-item-*` declarations that
    referenced variables never defined by Mantine or our theme

Also pruned the knownIssues whitelist from 10 entries down to 2 (only the
genuinely Mantine-provided `--button-bg` and runtime-generated
`--mantine-color-accent-gray-light-filled` remain).

* Clarify why --mantine-color-accent-gray-light-filled is allow-listed

getMantineThemeColors registers the color; Mantine derives the -filled variant
var from it at runtime, so it's absent from the static styles.css we scan.

* Add test for mb-* fallback wrapper with nested bare var

Mirror of the non-mb-wrapper case: an mb-* var carrying the fallback is still
validated, and the nested bare var is too, so both are extracted.

* Remove comment
2026-06-19 12:22:58 +02:00
Nick Fitzpatrick
194821f222 Apply column formatting to static viz map legend, add render to side (#76024)
* Apply column formatting to static viz map legend, add render to side

* PR Feedback
2026-06-19 14:27:28 +05:30
Nicola Mometto
fe44abd20a More generic error message on transform timeout (#76071)
chore: don't leak impl detail on error message
2026-06-19 08:49:53 +00:00
Fraser
24ca0fe913 Error for files that aren't in modules and enforce remaining modules (#76126) 2026-06-19 13:59:48 +12:00
Alexander Polyankin
1c12b1931d BigQuery - sample-table with adaptive page size (#76068) 2026-06-18 23:41:36 +00:00
Timothy S. Dean
28d0a1c5a5 Drain stale dependency entities oldest-first to prevent starvation (#76118)
The dependency entity-check job re-analyzes stale entities in batches. Among entities that are equally stale, the order they're selected in is arbitrary. When the stale backlog is larger than one batch, the same subset can keep getting picked while others are repeatedly passed over — so some stale entities can go unprocessed run after run.

### Solution

Select stale entities oldest-analyzed-first. Each entity that's just been analyzed moves to the back of the line, so the job round-robins through the whole backlog and every stale entity is reached.
2026-06-18 17:23:27 -06:00
Timothy S. Dean
c6be4cae58 Clear the stale flag for entities whose database can't be resolved (#76119)
The dependency entity-check job analyzes each stale entity and records a finding, which clears its stale flag.

If an entity's database can't be resolved — and there's no prior error that already explains why — analysis silently does nothing. The stale flag is never cleared, so the entity is re-selected and re-analyzed on every run, forever.

### Solution

Record a terminal error finding for that case, which clears the stale flag and explains why the entity couldn't be analyzed. If its database later becomes resolvable, the entity is analyzed normally again.
2026-06-18 17:23:00 -06:00
Ryan Laurie
0ccaefe55c Auto Stress Test (#76034)
* auto stress test

* better options

* double test

* variable burn

* less ai comment

* less ai comment
2026-06-18 23:18:40 +00:00
Nemanja Glumac
ac0c1c3d3e Add ci-conductor (dry run) quarantine gate for e2e tests (#76014) 2026-06-18 23:56:34 +02:00
github-automation-metabase
366f27d2f0 Auto-update documentation for master (#76120)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-06-18 21:50:47 +00:00
dpsutton
a57027861f Fix OOM in table-sync permission setup by SELECTing DISTINCT (#76077) (#76100)
When the sync-and-analyze job creates new tables, `set-default-table-permissions!`
calls `load-perm-context`, which loaded *every* table-level `data_permissions`
row for the database to figure out, per (group, perm-type, schema), the set of
distinct permission values already in use. The result set grew with the table
count, so on databases with very many tables it materialized millions of rows
(2.5M+ `org.postgresql.core.Tuple` / `toucan2.instance.Instance` in the heap
dump that prompted this) and OOM'd the JVM on a scheduler thread.

`schema-vals-idx` only ever needs the *distinct* (group_id, perm_type,
schema_name, perm_value) tuples — it reduces the rows into a set keyed by
(group, perm-type, schema), so duplicate rows were already being collapsed in
memory. Pushing that DISTINCT into SQL makes the loaded set bounded by
groups × perm-types × schemas × values instead of growing with table count.

Rows loaded by the introspection query (measured; one perm-type, one schema):

    groups  tables   before (groups×tables)   after (DISTINCT)
      5       10              100                    20
      5      100            1,000                    20
      5    1,000           10,000                    20   <- flat across tables
     10      100            2,000                    40
     50      100           10,000                   200   <- linear in groups

Before, the result scaled with the table count (the thing that blew up); after,
it is flat across table count and grows only linearly with the number of groups.
The produced `schema-vals-idx` is byte-identical because it accumulates into a
set — verified in a regression test.

Not scoping the query to the synced tables' schemas (a further reduction):
a `schema_name IN (...)` filter would add NULL/casing correctness risk, and the
DISTINCT collapse alone removes the geometric blowup that caused the OOM.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-18 16:18:41 -05:00
Oreon Lothamer
7d485d539d run PR-Env-Stats-Dump on already labeled PRs (#76095) 2026-06-18 11:13:38 -10:00
dpsutton
718c730aa9 downgrade apache sshd-core (#76104)
Why? Because 3.0.0-M2 leaks connections.

 Revert mina-sshd 3.0.0-M2 → 2.16 to stop SSH channel leak OOMs

  3.0.0-M2 leaks one KexListener per SSH port-forward channel, never
  removed on channel close. Each Metabase DB query over an SSH tunnel
  opens and closes a `direct-tcpip` channel, so the listener list grows
  unbounded for the life of the (long-lived) SSH connection.

  Heap dump from a crashed prod instance (highway):
  - 1 SSH connection, but 67,221 closed TcpipClientChannel /
    Nio2Session / socket-channel objects retained.
  - KexFilter.listeners (a session-scoped CopyOnWriteArrayList) retained
    572 MB ≈ 38% of heap — full of AbstractChannel$$Lambda instances,
    each capturing one closed channel.

  Root cause in mina-sshd 3.x (dev_3.0 branch):
  - AbstractChannel.init() registers an anonymous KexListener on the
    session for every channel and never removes it on close.
  - AbstractSession.removeKexListener() is also broken: it calls
    addKexListener() instead of remove (copy-paste bug), so even a
    correct removal attempt adds a duplicate.

  The 2.x lineage has no KexFilter / addKexListener / per-channel KEX
  listener — the filter-chain mechanism is entirely new in 3.x — so the
  leak cannot occur on 2.16.
2026-06-18 14:01:00 -07:00
Alexander Polyankin
ddbb6d05e5 BigQuery - ignore tables and fields with long names that we cannot insert into the app db (#76074) 2026-06-18 20:41:51 +00:00
Andrei Chernykh
b04009322f Fix user provisioning getting disabled when adding a group mapping (#75829)
* Fix user provisioning getting disabled when adding a group mapping

* Improve group mappings widget layout and add autosave toasts

* Migrate GroupMappingsWidget off Emotion to Mantine and drop deprecated exports

* Migrate GroupSelect off legacy Select to Mantine Combobox and trim widget CSS to style props

* Show Changes saved toast on JWT settings save and add group field placeholders for SAML and LDAP

* Fix group-mappings e2e helper for the Combobox dropdown

* Consolidate redundant OIDC group-sync and tooltip unit tests

* Give group-select options an explicit aria-label for a stable accessible name

* Scope group-mapping consistency e2e assertions to the table to avoid the portaled dropdown

* Use Text instead of Box for the delete-mapping modal heading and subtitle

* Refactor delete-mapping modal to use Mantine Modal from metabase/ui

* Migrate deprecated Button and Radio to metabase/ui in the group mappings widget
2026-06-18 12:14:43 -07:00
Nick Fitzpatrick
6d294e5f4d Further pdf export improvements (#76016)
* use cssText

* include font props on <text>, <tspan>, and <textPath> nodes

* re-apply SVG transform after cssText copy in html2canvas patch

Chrome's getComputedStyle().cssText is empty, so the cssText copy wiped the Leaflet grid SVG's transform and offset its serialized bounds, re-breaking the #68751 PDF-export grid fix. Re-apply transform/transform-origin/transform-box after the cssText copy; Firefox keeps the bulk-copy perf win. Re-enable the GridMapPdfExport loki test with its baseline reference.

* resolve vars in svg props

* fix hidden row chart axis labels

* gauge value positioning

* fix gauge chart labels

* re-skip grid map loki test
2026-06-18 23:54:41 +05:30
Nathan Voxland
4181df4429 Include dashId in downloaded diagnostics (#75803)
* Include dashId in downloaded diagnostics

* e2e test

---------

Co-authored-by: Nick Fitzpatrick <nickfitz.582@gmail.com>
2026-06-18 23:50:40 +05:30
Eric Normand
c70f62de5c Incremental remote-sync import: load only changed entities on pull (GHY-3779) (#75897)
* Add git changed-files primitive for incremental remote-sync import

changed-files diffs two commit trees with jgit's ANY_DIFF filter,
returning {:added :modified :deleted} path sets. jgit prunes unchanged
subtrees during the walk, so cost is proportional to the number of
changed entries rather than the size of the tree. Returns nil when the
base commit is unresolvable or orphaned (force-push/rebase), signalling
callers to fall back to a full import.

This is the change-detection primitive for making import/pull cost
proportional to what changed (GHY-3779).

* Add differential equivalence harness for incremental import

Establishes the full reload (load-snapshot!) as the oracle for incremental
import: a correct incremental import must leave the app DB, RemoteSyncObject
table, transforms setting, and version pointer in exactly the state a full
import would. Rather than assert hand-computed expectations, the harness runs
both paths against the same change and asserts identical resulting state.

import! provides the seam: :force? true always takes the full path (oracle),
:force? false is the path under test (full today, incremental once GHY-3779
lands). The state vector is pk-independent so delete+recreate doesn't produce
false diffs. Covers no-op / edit / add / delete card scenarios; the
rename/move/delete-collection/transform cases come with the incremental path.

GHY-3779.

* Incremental import fast-path: load only changed entities on pull

On a subsequent (non-first, non-forced, non-dirty) import, load only the
entities whose files changed since the last imported version instead of
deserializing and upserting the entire snapshot.

- Diffable protocol + source.p/changed-files wrapper: git diffs two commit
  trees; the in-memory versioned test source diffs its trees; everything else
  returns nil (no diff available) and falls back to full.
- incremental-load-snapshot!: loads only added/modified files (deps resolve
  from the app DB), deletes only genuinely-removed entities, and reconciles
  just the affected RemoteSyncObject rows. Renames are matched by entity_id, so
  a leaf rename updates in place rather than delete+recreate. Skips the full
  backfill and reindex that the whole-snapshot load runs.
- import! tries the fast-path and falls back to the full load-snapshot! for
  anything structural: first import, force/dirty (only full truly discards
  local drift), an unresolvable base (force-push/rebase), a deleted file with
  no recorded path, or a changed Collection/feature model (v1 scope). Also
  hoists the no-op version-skip ahead of conflict detection so an unchanged
  pull reads nothing.

The differential harness now drives the fast-path behind force? false and
proves it equals the full oracle for no-op / edit / add / delete / rename of
leaf content. (The harness caught a real rename bug during development.)

GHY-3779.

* Update search index per-entity on incremental import

The incremental load skips the whole-appdb reindex, so keep the search index
consistent at a cost proportional to the change: after the reconcile commits,
search/delete! the genuinely-removed entities and search/update! the loaded
(added/modified) ones. Adds search to the enterprise/remote-sync module :uses.

Covered by a test asserting only the changed entity is re-indexed, not the
whole synced set.

GHY-3779.

* Extend differential harness with fast-path assertions and fallback scenarios

run-differential! now reports which path the under-test import took, so every
scenario asserts the v1 scope boundary explicitly:
- leaf changes (no-op / edit / multi-edit / add / delete / rename) run
  :incremental and match the full oracle;
- structural changes (collection rename, collection delete with contents) fall
  back to :fallback (the full import) and still match the oracle.

GHY-3779.

* Improvements

* Drop redundant search/update! on incremental import; rely on serdes load hooks

Serdes load already re-indexes added/modified entities: its t2 insert!/update!
fire the :hook/search-index after-insert/after-update hooks, which call
search/update!. So the explicit per-entity search/update! in the incremental
path was redundant double-work — remove it. Deletes have no such hook, so the
explicit search/delete! for removed entities stays.

Tests: replace the live appdb search-index integration test (its index-tracking
state is order-sensitive across tests in a shared JVM, causing flakiness) with a
stable call-level assertion that search/delete! is invoked with the removed
entity's id. The differential harness + update call-spy continue to cover the
rest. Disable index maintenance in the non-search scenarios so their async
ingestion can't interfere.

GHY-3779.

* Flatten import! decision tree and fix incremental/merge fallback bugs

Refactor the remote-sync import path into flat cond-based decision trees
that read top-to-bottom, and fix correctness/perf issues surfaced along
the way:

- import! / incremental-import-plan / import-merged!: replace nested ifs
  with flat conds (one predicate -> one action per clause).
- incremental-import-plan: guard the diff call so a first import (nil
  last-version) returns the fallback sentinel instead of NPEing on a real
  git source (resolve(nil)).
- import! and import-merged!: compute the expensive conflict scan and
  3-way merge lazily (delay), so no-op pulls and the nil-base / force /
  merge paths don't pay for a full-tree read, and the nil-base merge
  returns its :conflict result instead of throwing.
- Consolidate the repeated full-reload success result via a local
  full-import! closure; route finalize! and the result through the bound
  snapshot-version.
- Make incremental-load-snapshot! private; inline handle-import-exception
  into import!'s catch; refactor prog1 calls to do/let.
- Add a first-import-no-force test (incremental fast-path must not run on
  a first import) and fix the path-detection spy to compare against the
  current sentinel var.

Pre-existing conflict-fixture failures in impl_test are unaffected.

* Batch per-entity deletes and search-index removals in incremental import

incremental-load-snapshot! removed entities (and their search-index
entries) one row at a time. Batch both by model type:

- entity deletes: one (t2/delete! model-key :id [:in ids]) per model
  instead of per row. Toucan2 fires before-delete per matched row even
  for an :in delete, and the Card/Dashboard before-delete cascades are
  row-independent, so behavior is preserved. Still inside the existing
  reconcile transaction.
- search-index removal: one search/delete! per model type (it already
  takes a collection of ids).

The remaining per-row lookups (deleted file_path -> RemoteSyncObject,
RemoteSyncObject -> entity_id) are left as-is; they're bounded by the
number of deletions in a single pull.

* Tag remaining incremental-import N+1 queries with comments

Note the two per-row lookups left un-batched in the incremental import
path (deleted file_path -> RemoteSyncObject, and RemoteSyncObject ->
entity_id) and why: both are bounded by the number of deletions in a
single pull, and batching either has real downsides (long file_path IN
clauses; per-model-key IN grouping).

* Reorder import! so the incremental path skips the conflict scan

After merging GHY-3900, blocking-conflicts was computed before the
incremental fast-path, re-introducing a full-tree get-conflicts scan on
every changed pull and undercutting the constant-time incremental win.

Reorder import!'s cond so the incremental clause sits ahead of the
conflict gate: an incremental load touches only changed files and can't
wholesale-delete unsynced transforms, so it needs no conflict scan and
forces only the cheap O(changes) diff. The conflict gate and full reload
fall to the bottom, so every full-reload path (forced, dirty, first
import, structural) is still gated. force? keeps no standalone branch —
it stays off the incremental path and flows through the gate so
force-deletion? semantics hold.

Also defer the get-conflicts scan behind an inner delay so it runs only
when a gate is open (a forced import with force-deletion? true skips it),
and inline the now single-use full-import! body into :else.

* refactor
2026-06-18 17:04:02 +00:00
lbrdnk
928e9098e2 Add pagination to read_resource (#74966)
* Add pagination to read_resource tool

* kondo

* Review remarks
2026-06-18 18:31:43 +02:00
Nathan Voxland
73cd4c7c1e Pass scopes through the oidc check function (#75416) 2026-06-18 11:20:38 -05:00
Sébastien
5ac6536012 test(sdk-bundle): Fix flaky e2e test (data picker) (#76057) 2026-06-18 17:42:28 +02:00
Nemanja Glumac
42e75a07ba (chore): Point ci-conductor reporter at a base-URL secret (#76067)
Replace the CI_CONDUCTOR_WEBHOOK_URL secret (which held the webhooks base)
with CI_CONDUCTOR_BASE_URL holding the bare origin, and have the reporter
build ${base}/webhooks/failed-tests. This lets each consumer append its own
path.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-18 17:39:17 +02:00
Anderson
11de545b4b Fix public pivot table downloads (#76023) 2026-06-18 11:52:24 -03:00
Anderson
8894b2a7eb Fix conditional formatting for mini bar cells (#76025) 2026-06-18 11:51:37 -03:00
Anderson
6ea899e4b0 Fix progress Goal input styles / Convert ChartSettingFieldPicker to typescript (#75916)
* Fix progress goal input chevron alignment

* Convert components to typescript and css modules / Remove ghost dropdown caret

* Convert test file to ts

* Address Nick's comment
2026-06-18 11:49:54 -03:00
Nemanja Glumac
f35c54150c Harden the flaky text fix command (#76005) 2026-06-18 15:53:00 +02:00
github-automation-metabase
8cfe03b28c Auto-update documentation for master (#76036)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-06-18 09:14:18 -04:00
lbrdnk
9331d39f46 Stamp types on integer id field clauses in resolve-query (#75998)
Stamp types on field clauses after resolve

lib.normalize does not inject type info from the metadata provider.
Add annotate-field-types pass in resolve-query to fill this gap for
all [:field opts integer-id] clauses missing :base-type.
2026-06-18 14:35:31 +02:00
Maz Ameli
3f26fa8e53 Fix capitalization of "View schema" table action label (#76035)
Change "View Schema" to "View schema" in the data model table actions
menu and update the affected unit and e2e tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-18 11:44:58 +00:00
Nicola Mometto
f0fc22bb27 Add BE endpoints for job run history (#75926)
* feat: link transform runs with their parent job

* feat: allow storing job-run-id

* add endpoints

* tests

* fix

* missing remark

* fix: add to schema

* fix schema

* fmt

* kondo

* fix test

* allow filtering by start-time and run-method

* tests

* chore: use read-check

* backfill job run ids

* chore: don't alias

* perf of the migration

* realias, add mysql/h2 versions, remove rollback

* chore

* prefilter on run_method
2026-06-18 12:02:25 +01:00
Fraser
8e2c0cc178 Remove legacy SettingsApi service (#76046) 2026-06-18 21:12:32 +12:00
Oleh K
94144e3411 Add KeyboardShortcut component and restyle Kbd (#75895)
* WIP: restyle Kbd from Figma + disabled state and showcase

Restyle the Kbd component to the GDGT-2473 Figma spec: flat surface
fill, no border/shadow, 4px radius, Lato Medium 12px. Add a thin
metabase/ui wrapper exposing a `disabled` boolean prop, a CSS `:hover`
state, and a Storybook showcase matrix.

* Add sequential shortcut examples to Kbd showcase

* Add KeyboardShortcut component, simplify Kbd, migrate palette

Per design discussion: drop Kbd's hover/disabled states (Kbd is now just a
restyled building block), add a KeyboardShortcut component that composes Kbd —
simultaneous keys adjacent (no "+"), sequential steps joined by a localized
"then", with a canonical modifier order and symbol/casing normalization. Migrate
the command-palette shortcuts modal to it (replacing its local renderer) and
list multiple shortcuts comma-separated.

* Add KeyboardShortcut Overview story to Loki visual regression tests

* Render Shift as a word in KeyboardShortcut, not a symbol

Per design: drop the SHIFTKEY (⇧) mapping so Shift always renders as the word.

* Extract KeyboardShortcut key parsing to utils with unit tests

Move formatKey/parseShortcut into a colocated utils.ts and cover them with unit
tests (each formatKey branch + chord/sequence/modifier-ordering for parseShortcut).
2026-06-18 08:59:18 +02:00
Romeo Van Snick
66a53ed09b Move SessionApi to RTK query hooks (#76045)
* Add session RTK Query mutations

* Migrate auth thunks to session RTK mutations and remove SessionApi
2026-06-18 15:40:55 +10:00
Romeo Van Snick
21a319ed95 Remove simple services API's (#75866)
* Move `FrontendErrorsApi` to RTK hooks and update callers

Replace the legacy `FrontendErrorsApi.report` service with a
`reportFrontendError` RTK Query mutation. The two callers are class-based
error boundaries (`componentDidCatch` requires a class), so each gets a thin
functional wrapper that calls `useReportFrontendErrorMutation` and passes a
bound `onReportError` callback down to the inner class component.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `UserApi` to RTK hooks and update callers

Add `getCurrentUser` and `updateUserModalQbnewb` endpoints to the user RTK
API (`UserApi.list` was already covered by `listUserRecipients`) and remove
`UserApi` from services.js.

Component callers use the hooks directly (`UserNameDisplay` via
`useListUserRecipientsQuery`); thunk and imperative callers dispatch through
`runRtkEndpoint`, matching the existing redux/api migration pattern.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `SetupApi` to RTK hooks and update callers

Replace the legacy `SetupApi.create` service with a `createSetup` RTK Query
mutation. The sole caller is the `submitUser` setup thunk, which dispatches it
through `runRtkEndpoint` so its existing try/catch error handling is preserved.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `PersistedModelsApi` to RTK hooks and update callers

The `persistApi` already had matching `enablePersist`/`disablePersist`/
`setRefreshSchedule` mutations, but they were unused and `setRefreshSchedule`
pointed at the wrong URL (`set-refresh/schedule` instead of the backend's
`set-refresh-schedule`). Fix that URL and wire `ModelPersistenceConfiguration`
onto the hooks, using `.unwrap()` so the existing error-toast handling still
fires on failure. Remove `PersistedModelsApi` from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `PermissionsApi` to RTK hooks and update callers

Add the data-permissions graph endpoints (`getPermissionsGraph`,
`getGroupPermissionsGraph`, `getDatabasePermissionsGraph`,
`updatePermissionsGraph`) to `permissionApi`. All callers are thunks or
imperative hook callbacks, so they dispatch through `runRtkEndpoint` (which
preserves the legacy fetch-every-time behavior and cleans up the query
subscription). Remove `PermissionsApi` from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `ParameterApi` to RTK hooks and update callers

The `parametersApi` already had matching `getParameterValues`/
`searchParameterValues` query endpoints. Route the `fetchParameterValues`
thunk's `loadParameterValues` through `runRtkEndpoint` and remove
`ParameterApi` from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `StoreApi` to RTK hooks and update callers

Add a `getTokenStatus` query to `premiumFeaturesApi` (the token-status GET
that lived in `StoreApi`) and route `useLicense`'s status fetch through
`runRtkEndpoint`, preserving its 404-specific error handling. Remove
`StoreApi` from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `RevisionsApi` to RTK hooks and update callers

The legacy `RevisionsApi.get` (`GET /api/revision/:entity/:id`) and the
existing `listRevisions` query (`GET /api/revision?entity=&id=`) both resolve
to the same backend `revisions+details` after a read-check, so route the two
revision-fetching thunks through `runRtkEndpoint` + `listRevisions`. Remove
`RevisionsApi` from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `ModerationReviewApi` to RTK hooks and update callers

Route the moderation `verifyItem`/`removeReview` helpers through
`runRtkEndpoint` + the existing `editItemVerification` mutation (taking a
`dispatch` argument), and rework their unit tests to assert the real request
against a store-backed `fetchMock` instead of a mocked service. Remove
`ModerationReviewApi` from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `CollectionsApi` to RTK hooks and update callers

Add `getCollectionPermissionsGraph`/`updateCollectionPermissionsGraph` to
`collectionApi` (the `graph`/`updateGraph` endpoints; `get` already existed as
`getCollection`). Route the collection-permission load/save thunks and the
error-page collection fetch through `runRtkEndpoint`. Remove `CollectionsApi`
from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `GTAPApi` to RTK hooks and update callers

Add a `validateGroupTableAccessPolicy` mutation to `groupTableAccessPolicyApi`
for the GTAP `validate` endpoint. The `attributes` endpoint already existed as
`userApi.listUserAttributes`, so reuse it: `useUserAttributes` becomes a thin
`useListUserAttributesQuery` wrapper, and the enterprise `fetchUserAttributes`
thunk dispatches it via `runRtkEndpoint`. (`GTAPApi.list` had no callers.)
Remove `GTAPApi` from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `PulseUnsubscribeApi` to RTK hooks and update callers

Add a `pulseApi` with `unsubscribeFromPulse`/`undoUnsubscribeFromPulse`
mutations (the unauthenticated, hash-based email unsubscribe endpoints) plus
shared `UnsubscribeRequest`/`UnsubscribeResponse` types, and route the pulse
branch of the unsubscribe page through them. Remove `PulseUnsubscribeApi` from
services.js. (Notification branch migrated separately.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `NotificationUnsubscribeApi` to RTK hooks and update callers

Add `unsubscribeFromNotificationByEmail`/`undoUnsubscribeFromNotificationByEmail`
mutations to `notificationApi` (distinct from the existing authenticated
by-id `unsubscribeFromNotification`) and migrate the notification branch of the
unsubscribe page onto them. Remove `NotificationUnsubscribeApi` from
services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `EmbedApi` to RTK hooks and update callers

Add `getEmbedCard`/`getEmbedDashboard` query endpoints to `embedApi` (the base
embed card/dashboard fetches) and route the embed dashboard load and the
public/embedded question loader through `runRtkEndpoint`. Remove `EmbedApi`
from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Move `PublicApi` to RTK hooks and update callers

Add the base public endpoints to `publicApi` — `getPublicAction`,
`getPublicCard`, `getPublicDashboard`, `getPublicDocument`,
`executePublicAction`, `executePublicDashcardAction`, and
`prefetchPublicDashcardValues` — and route all callers (public dashboard/card/
document/action loaders, action execution, and dashcard prefetch) through
`runRtkEndpoint`. Remove `PublicApi` from services.js.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Ignore promise return value

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Fix formatting

* Remove unused code

* Remove mention of EmbedApi

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-06-18 14:19:15 +10:00
Fraser
8460bb5470 Fix unit test violations (#75919) 2026-06-18 16:10:47 +12:00
Alexander Polyankin
b0c6b77bfa Avoid duplicate app db requests in public and embedded cards and dashboards (#76026)
* In-memory entity cache for public/embed paths

* now cards

* fix

* fix

* fixes

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* ffix tests

* fix
2026-06-17 16:08:21 -07:00
technomancy
28b1a1507e Improve dataset creation for Bigquery (#76031)
* Stop deleting datasets for now in bigquery.

* Don't assume the database existing means all tables exist.
2026-06-17 22:50:56 +00:00
6261 changed files with 570239 additions and 401441 deletions

View File

@@ -1,264 +0,0 @@
---
description: Diagnose and fix a flaky Cypress e2e test, then verify the fix with CI stress runs in a bounded loop
---
Fix flaky e2e test: $ARGUMENTS
You are orchestrating a **bounded flake-fix loop** with a real CI feedback signal. The
only integration tool for the loop is `gh` (trigger the stress workflow + read results).
The Linear issue is the input. Everything else is reasoning over files.
**Hard rules — do not deviate:**
- **Max 3 attempts.** One attempt = diagnose → fix → push → 2 stress runs → interpret.
After 3 failed attempts, stop and hand back.
- **Branch existence is the go/no-go gate.** Before starting, check whether the remote branch
`automated-e2e-flake-fix-<TEAM_SLUG>-<ISSUE_NUMBER>` already exists (Phase 0). If it does, a run
is already in flight (or already landed a fix) → **stop, do nothing**. If it doesn't,
proceed through the whole loop and push without pausing for confirmation. This runs
identically whether a human or automation triggered the command.
- **Linear access:** prefer the Linear MCP (`mcp__linear__*`); if it's unavailable (e.g.
headless CI), fall back to the Linear REST/GraphQL API with a token — for both reads and
comment writes.
- **Each attempt triggers TWO stress runs in parallel** — `enable_network_throttling=true`
and `=false` — on the same branch/commit. The fix is verified only if **both** pass.
- **CI is the source of truth.** No local Cypress runs, no `bin/` stress scripts.
- **Branch names use `-` only, never `/`.**
- **Persist state** to a scratch file so the loop survives `ScheduleWakeup` and context
summarization.
---
## Phase 0 — Resolve the target
1. Parse `$ARGUMENTS`:
- If it's a Linear ref (`DEV-####` or a Linear URL) → `mcp__linear__get_issue`. Trunk
titles these `Quarantined Test: <suite> > <test name>`. Extract the **exact test
name** (the part after `> ` — this is the grep string) and the **suite**. Read the
body for failure detail / screenshots / stack, and capture the **ranked failure
reasons** (Trunk lists them "most common" first) — #1 is what you fix first (Phase 1).
- Otherwise treat it as a spec path or fuzzy test name (fallback; no Linear context).
2. **Compute the branch name + dedup gate (this is the go decision).** The branch name is
derived **only** from the Linear ref, never the test name:
`automated-e2e-flake-fix-<TEAM_SLUG>-<ISSUE_NUMBER>` (e.g. `DEV-2181` →
`automated-e2e-flake-fix-DEV-2181`). Check whether it already exists on the remote:
```bash
git ls-remote --exit-code --heads origin automated-e2e-flake-fix-<TEAM_SLUG>-<ISSUE_NUMBER>
```
- **Exists (exit 0)** → a run is already in flight or already landed a fix → **stop, do
nothing.** This is the whole dedup mechanism.
- **Doesn't exist (exit 2)** → that's the **go** signal. Proceed without pausing for
confirmation.
(On the no-Linear fallback path there's no ref to build the name from; that path stays
interactive and is for local debugging only.)
3. **Resolve the spec file** from the exact test name:
```bash
grep -rl "<exact test name>" e2e/test/scenarios
```
Require **exactly one** match. If 0 or >1, stop and ask the user to disambiguate. (Try
a shorter unique substring of the test name if the literal has special characters.)
4. **Decide `qa_db`:** scan the spec / its `describe` for external-DB helpers
(postgres/mysql/mongo-writable) or an `@external` tag → `true`, else `false`.
5. **Write the state file** `local/claude/e2e-flake-fix/<TEAM_SLUG>-<ISSUE_NUMBER>.md`:
```markdown
# Flake fix: <test name>
- linear: <DEV-#### or n/a>
- spec: <spec path>
- test_name (grep): <exact test name>
- qa_db: <true|false>
- edition: ee
- branch: automated-e2e-flake-fix-<TEAM_SLUG>-<ISSUE_NUMBER>
- attempt: 0 / 3
## Failure reasons (Trunk, ranked — fix #1 first)
1. <dominant / most common>
2. <rarer>
...
## Attempts
```
This file is the durable record. Re-read it on every `ScheduleWakeup` wake.
## Phase 1 — Diagnose (run at the start of every attempt)
- **Anchor on the #1 / most-common failure reason first.** Trunk lists the issue's failure
reasons ranked by frequency ("The N most common failure reasons…"). Fix the **dominant**
one and ignore the rarer reasons (#2, #3, …) unless the dominant one is fixed and they
still surface in CI. Do **not** rabbit-hole on a lower-frequency reason — that is the most
common way this loop wastes its 3 attempts. (Capture the ranked reasons in the state file
during Phase 0 so each attempt re-grounds on #1.)
- Read the spec, focused on the failing test, its `describe`, and any `before*`/`after*`
hooks. Read shared helpers it calls.
- Apply the flake anti-pattern checklist (from the `e2e-test-review` skill, as a mental
model — don't invoke it):
- numeric `cy.wait(<ms>)` instead of waiting on an alias
- `cy.intercept` registered **after** the action that triggers the request
- `.should("not.exist")` / negative assertions without a positive anchor first
- unscoped text selectors that can match more than one element
- off-by-one `.last()` / `.eq(-1)` without a length assertion
- JS conditionals on `cy` chains (no retry semantics)
- shared state / ordering assumptions between tests
- Fold in any failure detail from the Linear issue (and, on attempts 2–3, the downloaded
CI artifacts from the previous attempt).
- Write a **concrete hypothesis** to the state file's Attempts log before editing code.
## Phase 2 — Fix on a branch
- On **attempt 1 only**, create the branch computed in Phase 0 (dashes only, no `/`):
```bash
git switch -c automated-e2e-flake-fix-<TEAM_SLUG>-<ISSUE_NUMBER>
```
On later attempts, keep committing to the same branch.
- Apply a **minimal** fix:
- **Default:** test-scoped (deterministic waits via `cy.intercept` + `cy.wait("@alias")`
before asserting; positive anchor before a negative assertion; scoped selectors).
- **Source code is allowed** only when you have **high conviction** the root cause is a
real product defect the test merely surfaces (e.g. a genuine race or non-deterministic
ordering). When you do, write the evidence for that conviction in the state file and
keep the **blast radius minimal**.
## Phase 2.5 — Share the diagnosis on Linear (offer before pushing)
- Once you have a confirmed root cause and a fix in hand, **before** the push/CI gate,
offer to post the **debugging story** as a comment on the Linear issue. Draft it and
show it to the user; post via `mcp__linear__save_comment` only if they accept (let them
edit first). Keep it a tight narrative: the observed failure, the root cause (why the
request never fires), and the fix. Skip silently if there's no Linear issue (spec/test
fallback path).
- This is a separate, earlier offer from the Phase 5 PR/closeout comment — the value here
is capturing the *why* while it's fresh, independent of whether CI later confirms.
## Phase 3 — Push + stress (burn_in=50, fail_fast=true)
**One run, `fail_fast=true`, does both jobs.** A bad fix fails on the **first** iteration
and stops immediately (fast red + artifacts) — no need for a separate cheap sanity stage.
A good fix runs all 50 to green (full confirmation). So every attempt is a single pair of
runs at `burn_in=50` with `fail_fast=true` (throttle on + off).
- **Push without pausing for confirmation.** The branch-existence check in Phase 0 was the
go decision; if you reached this phase you're clear to commit, push, and trigger (same for
a human or automated trigger).
- Commit and push (first attempt only creates the branch; later attempts push the revised
fix), then trigger.
- **Decide `build_jar` (cumulative across the branch, not per-attempt).** With
`build_jar=false` the run downloads a prebuilt uberjar by walking the current commit's
ancestors; with `build_jar=true` it builds the uberjar from this branch, so the JAR is
guaranteed to match your source. Rule:
- If **every** commit on the branch (vs. the base) touches **only** test/spec code →
`build_jar=false`. There is no source change for a JAR to miss, so a download is correct
and saves the build time.
- If **any** commit on the branch changed backend or frontend source — whether this attempt
made it or an earlier one did → `build_jar=true`, and keep it `true` on every later run
(including a test-only attempt 2). We build defensively: it may be redundant if a matching
branch JAR already exists, but it removes any doubt that the stress run tested your actual
source. A redundant build is far cheaper than a hard-to-debug false green from a JAR that
silently didn't include the fix.
- Check with `git diff --name-only <base>...HEAD` and treat anything outside test paths
(`e2e/`, `**/*_test.clj`, `**.unit.*`, etc.) as source. Record the chosen value in the
state file.
### Trigger helper
**Always `git push` and confirm the remote branch is at your new commit BEFORE triggering.**
`gh workflow run --ref <branch>` resolves the ref on GitHub's side at dispatch time, so a
trigger that races an in-flight push will run the *previous* commit. After triggering,
verify with `gh run view <id> --json headSha` and re-trigger if it's stale.
```bash
git add -A && git commit -m "Fix flaky test: <test name>"
git push -u origin <branch> # PUSH FIRST — then trigger
TRIGGERED_AT=$(date -u +%Y-%m-%dT%H:%M:%SZ)
for throttle in true false; do
gh workflow run e2e-stress-test-flake-fix.yml --ref <branch> \
-f spec="<spec path>" \
-f grep="<exact test name>" \
-f burn_in="50" \
-f mb_edition="ee" \
-f qa_db="<true|false>" \
-f build_jar="<true|false>" \
-f enable_network_throttling="$throttle" \
-f fail_fast="true"
done
```
- **Capture both run IDs**, then **verify each `headSha` matches your pushed commit**:
```bash
gh run list --workflow=e2e-stress-test-flake-fix.yml --branch <branch> \
--json databaseId,status,createdAt,event,headSha --limit 10
```
Save both run IDs + URLs to the state file, tagged `throttled` / `unthrottled`.
## Phase 4 — Wait + interpret (gh only)
- **Auto-poll** with `ScheduleWakeup` (~900s / 15 min cadence) until **both** runs leave
`queued`/`in_progress`. Pass the same `/fix-flaky-test $ARGUMENTS`
back so the loop resumes; re-read the state file on each wake (a manual wake must also
work). Don't poll faster than ~900s.
- When both finish, read each conclusion:
```bash
gh run view <id> --json status,conclusion
```
- **Either `cancelled`** → assume a **human cancelled** it. Stop the whole task
immediately — do **not** retry, do **not** open a PR. Note it in the state file and
hand back. (A `cancelled` conclusion means manual cancellation; a `timed_out`
conclusion does **not** — treat `timed_out` like a failure below.)
- **Either `failure` / `timed_out`** → fix is not holding (`fail_fast` stopped at the
first bad iteration, so the artifact is fresh and minimal):
```bash
gh run download <failed-id> --dir local/claude/e2e-flake-fix/<failed-id>-artifacts
```
The Cypress error lives in the GitHub step log (`gh run view <id> --log-failed`) and the
screenshots/video — **not** in `logs/test.log` (that's only the backend health log).
Read the failure screenshot(s) (vision) and the step-log error; append findings to the
state file; increment `attempt`. If `attempt < 3` → loop back to **Phase 1** with the
new evidence. If `attempt == 3` → Phase 5 (exhausted).
- **Both `success`** (all 50 iterations passed, both throttle modes) → fixed → Phase 5.
- Don't worry about CI cost.
## Phase 5 — Conclude
- **Fixed** — open a PR (the upfront OK already authorized the push; don't re-gate):
```bash
gh pr create --title "Fix flaky test: <test name>" --body "<body>"
```
**The PR can NEVER auto-merge** — it always requires at least one human approval, no
matter how green the stress runs are, and never enable auto-merge. A passing stress run is
*necessary but not sufficient*: it proves the test is stable, not that the root cause was
fixed rather than masked. The human owns the merge decision.
The PR description **must follow this exact order**: (1) the **first line is ALWAYS
`Resolves <DEV-####>`**, then (2) the root cause / fix / stress-test sections. The PR body
**must always include both stress-test runs** as links with their pass results:
```markdown
Resolves <DEV-####>
## Root cause
<one paragraph>
## Fix
<what changed and why; note if source code was touched and the blast radius>
## Stress test (burn_in=50, single test via grep)
- ✅ network throttling ON: <run URL>
- ✅ network throttling OFF: <run URL>
```
That `Resolves <ID>` reference (in the **PR description only — NEVER in a commit message
or body**, which would reopen the issue) closes the Linear issue **on merge**, via
Linear's GitHub integration. **NEVER close the Linear issue or change its status yourself**
(no status edits via the Linear MCP — only comments). Linear moves it to *In Progress* when
the PR links and to *Done* when the PR merges. Comment the outcome on the issue (link the
PR), and leave a copy-pasteable summary inline AND in `local/claude/`.
- **Exhausted (3 attempts)** — do **not** guess further. Report each hypothesis tried, the
fixes attempted, all 6 stress-run links, and where the artifacts are. Hand back for human
judgment.
- **Always — attach the run log to Linear (regardless of outcome).** As the final step on
both the fixed and exhausted paths, post the full state file
`local/claude/e2e-flake-fix/<TEAM_SLUG>-<ISSUE_NUMBER>.md` to the Linear issue as a comment titled
**"🤖 Flake-fix run log (audit trail)"** (fence it so it renders verbatim). This is the
end-to-end audit trail — every hypothesis, fix, commit, run URL, and verdict — kept for a
human reviewer and as a learning artifact even when the fix didn't land. Skip only on the
no-Linear fallback path.
- **Lead the comment with a run-cost line** (above the fenced log):
**total wall-clock time spent** on the run and **total tokens used** — e.g.
`⏱ 2h 14m · 🪙 1.8M tokens (N attempts)`. Compute time from the first state-file
timestamp to now; report tokens for the whole session (best available figure). This makes
the cost of each automated run visible at a glance on the issue. (Posting the markdown as a comment is sufficient; a file
attachment via `mcp__linear__create_attachment_from_upload` is optional if the user wants
a downloadable file.)

View File

@@ -102,3 +102,7 @@ breakage keeps happening, *that* is the signal a comment was warranted.
- End all files with a newline
- When editing tabular code, where the columns line up, try to keep them aligned
- Spaces on a line with nothing after it is not allowed
- After changing module boundaries (adding/removing/renaming a `src` namespace, a cross-module `require`
or `:model/X` reference, or a new module), run `./bin/mage fix-modules-config` to regenerate
`.clj-kondo/config/modules/config.edn` and keep `metabase.core.modules-test` green. No-op when nothing
drifted; see "Module Boundaries" in the project `CLAUDE.md`.

View File

@@ -22,10 +22,11 @@ Before starting, determine which mode to use:
3. **(Conditional)** If after reading the spec a specific assertion or selector is **ambiguous** — you can't tell if it's the right anchor, or whether the test actually verifies what its title claims — briefly grep the related component for the test ID / role / text. **Don't read components by default.** Only do this when there's a real signal of confusion in the spec.
4. Scan against the checklist + pattern table below.
5. Number all issues sequentially. Skip nits — only flag what's worth fixing.
6. **Always** finish with the honest e2e-vs-unit breakdown (see the section of that name below). It's part of every report, not an optional add-on.
### When to hand off instead of review
If the spec references an issue (`metabase#NNNNN`) and the user wants to **fix** flakiness or assess whether the test still reproduces the original bug, that's outside the review skill's scope. Point them at `/fix-flakey-test` (or the dedicated flake-fixing workflow), which knows to fetch the issue and the resolving PR's diff. The review skill stays focused on "is this test well-written and conformant" — it doesn't fetch external issue context by default.
If the spec references an issue (`metabase#NNNNN`) and the user wants to **fix** flakiness or assess whether the test still reproduces the original bug, that's outside the review skill's scope. Point them at the dedicated flake-fixing workflow, which knows to fetch the issue and the resolving PR's diff. The review skill stays focused on "is this test well-written and conformant" — it doesn't fetch external issue context by default.
## Review checklist
@@ -194,8 +195,41 @@ Use the pending review workflow:
Each comment body starts with `**Issue N: [Brief title]**`.
## Honest e2e-vs-unit breakdown (always include)
Every report ends with this section. The numbered issues above are about whether the test is *well-written*; this section is about whether it should be an **e2e test at all**. They're orthogonal — a flawless spec can still be paying e2e prices for component-test value, and that's worth saying out loud.
The bar is simple: **an `it()` earns its place in e2e only if it exercises a layer you cannot fake without gutting the test's value.** In this codebase that means one or more of:
- a **real backend query against seeded data** (the assertion depends on the server actually filtering/sorting/bucketing rows, not on a mocked response);
- **real rendering you then interact with** — clicking a charted ECharts SVG element at computed coordinates, drag/hit-testing, drill-through;
- **routing across screens** — navigation, URL param round-trips that the backend then honors, browser back/forward;
- **cross-screen traversal** — list → detail → back, where the value is the seam between screens.
Conversely, a test belongs in **Jest + RTL** (the cheaper layer this repo already uses for component/unit coverage) when its real subject is frontend-only:
- **pure frontend logic** — a bucketing/formatting/derivation decision (e.g. "single-day range → bucket by hour") that has one right answer independent of the backend;
- **render assertions** — "the page mounts N titled cards and an SVG exists." A mocked dataset response + RTL verifies the titles; that an ECharts SVG renders is library behavior, not your logic;
- **state/wiring** — tab → `aria-selected` → active-state, or select → querystring mapping. The *URL gets the param* half is component-level; only the *backend honors the param* half needs e2e.
Write the breakdown in three honest buckets. Ground each call in **which layers the test actually touches**, not in how the test is named:
1. **Genuinely must-be-e2e (keep)** — load-bearing. Name the layer(s) only a browser + backend can verify together.
2. **Defensible-but-narrowable e2e** — justified as integration, but over-split or doing more boots than the coverage requires. Say what to merge.
3. **Should be unit / component tests** — where the real savings are. Name the cheaper layer and what it would assert (often *more precisely* than the e2e test does indirectly).
Then a one-paragraph **bottom line**: what to keep as e2e, what to push down, and — if you pulled CI timing from `e2e/support/timings.json` for the Performance check — roughly how much of that wall time is *earned* by the must-be-e2e set versus paid by the rest.
Rules of engagement so this stays honest, not performative:
- **Don't inflate the keep bucket to look balanced.** If most of the spec is component-test value paying e2e prices, say exactly that. If every test is load-bearing, say that too — a spec where all 12 tests must be e2e is a legitimate outcome, not a failure to find candidates.
- **Be specific.** Cite the `it()` titles and line ranges. "Several tests could be unit tests" is useless; "tests 1/17/18 assert only that N titled cards mount — RTL with a mocked dataset" is actionable.
- **This is advice to the author, not a blocking issue.** It's a recommendation, separate from the numbered issues. Don't renumber it into the issue list.
- **Stay rooted in what exists.** The cheaper layer here is Jest + RTL component/unit tests. Don't invent infrastructure the repo doesn't have, and don't recommend deleting backend-dependent coverage just because part of the test is frontend-only — split it, keep the integration half.
## Final check
1. Trim issues that won't materially help the author.
2. Verify sequential numbering with no gaps.
3. In PR mode, verify each issue was posted as a separate review comment.
4. Verify the honest e2e-vs-unit breakdown is present — it's required in every report, even when the answer is "all of these need to be e2e."

View File

@@ -21,7 +21,7 @@ For EACH styled component, go through every CSS property and ask: "Can this be a
- `display` → `display` prop
- `color` → `c` prop (`c="core-brand"`, `c="text-primary"`)
- `background-color` → `bg` prop (`bg="background-primary"`)
- `background-color` → `bg` prop (`bg="background_page-primary"`)
- `font-size` → `fz` prop (`fz="md"`)
- `font-weight` → `fw` prop (`fw="bold"`)
- `line-height` → `lh` prop (`lh="md"`)
@@ -57,7 +57,7 @@ For EACH styled component, go through every CSS property and ask: "Can this be a
align="center" /* style prop */
gap="sm" /* style prop */
p="md" /* style prop */
bg="background-primary" /* style prop */
bg="background_page-primary" /* style prop */
>
```
@@ -170,9 +170,9 @@ Create `ComponentName.module.css` alongside the component file:
```css
/* Use design system tokens — NEVER raw color/spacing values */
.root {
border: 1px solid var(--mb-color-border);
border: 1px solid var(--mb-color-border-neutral);
border-radius: var(--mantine-radius-md);
background-color: var(--mb-color-background-primary);
background-color: var(--mb-color-background_page-primary);
}
/* Conditional states as separate classes, combined with cx() */
@@ -182,7 +182,7 @@ Create `ComponentName.module.css` alongside the component file:
}
.disabled {
color: var(--mb-color-text-tertiary);
color: var(--mb-color-text-disabled);
pointer-events: none;
}
@@ -192,7 +192,7 @@ Create `ComponentName.module.css` alongside the component file:
&:hover {
color: var(--mb-color-core-brand);
background-color: var(--mb-color-background-hover);
background-color: var(--mb-color-background_surface-hover);
}
}
@@ -255,9 +255,9 @@ Remove the old styled file entirely. Remove all imports of it from other files.
**Colors** (`c`, `bg`):
- Text: `"text-primary"`, `"text-secondary"`, `"text-tertiary"`
- Background: `"background-primary"`, `"background-secondary"`, `"background-hover"`
- Brand: `"core-brand"`, `"error"`, `"success"`, `"warning"`
- Text: `"text-primary"`, `"text-secondary"`, `"text-disabled"`
- Background: `"background_page-primary"`, `"background_page-secondary"`, `"background_surface-hover"`
- Brand: `"core-brand"`, `"feedback-negative"`, `"feedback-positive"`, `"feedback-warning"`
**Typography** (`fz`, `fw`, `lh`, `ta`, `ff`):
@@ -279,11 +279,11 @@ Remove the old styled file entirely. Remove all imports of it from other files.
**Colors** — `var(--mb-color-<name>)`:
- `--mb-color-text-primary`, `--mb-color-text-secondary`, `--mb-color-text-tertiary`
- `--mb-color-background-primary`, `--mb-color-background-secondary`, `--mb-color-background-hover`
- `--mb-color-text-primary`, `--mb-color-text-secondary`, `--mb-color-text-disabled`
- `--mb-color-background_page-primary`, `--mb-color-background_page-secondary`, `--mb-color-background_surface-hover`
- `--mb-color-border`, `--mb-color-border-strong`, `--mb-color-border-subtle`
- `--mb-color-core-brand`, `--mb-color-core-brand-hover`
- `--mb-color-error`, `--mb-color-success`, `--mb-color-warning`
- `--mb-color-feedback-negative`, `--mb-color-feedback-positive`, `--mb-color-feedback-warning`
- `--mb-color-shadow`, `--mb-color-focus`
- `--mb-color-accent0` through `--mb-color-accent7`
@@ -398,7 +398,7 @@ export const Wrapper = styled.div`
```tsx
export const Item = styled.div<{ isSelected: boolean; disabled: boolean }>`
color: ${(props) =>
props.disabled ? color("text-tertiary") : color("text-primary")};
props.disabled ? color("text-disabled") : color("text-primary")};
background-color: ${(props) =>
props.isSelected ? color("core-brand") : "transparent"};
cursor: ${(props) => (props.disabled ? "default" : "pointer")};
@@ -427,11 +427,11 @@ export const Item = styled.div<{ isSelected: boolean; disabled: boolean }>`
}
.disabled {
color: var(--mb-color-text-tertiary);
color: var(--mb-color-text-disabled);
cursor: default;
&:hover {
color: var(--mb-color-text-tertiary);
color: var(--mb-color-text-disabled);
}
}
```
@@ -574,7 +574,7 @@ export const Spinner = styled.div`
| -------------------------- | ----------------------------------------------------------------- | ------------------------------------- |
| `color("core-brand")` | `var(--mb-color-core-brand)` | `c="core-brand"` or `bg="core-brand"` |
| `color("text-primary")` | `var(--mb-color-text-primary)` | `c="text-primary"` |
| `color("border")` | `var(--mb-color-border)` | N/A (use CSS module) |
| `color("border-neutral")` | `var(--mb-color-border-neutral)` | N/A (use CSS module) |
| `alpha("core-brand", 0.2)` | `color-mix(in srgb, var(--mb-color-core-brand), transparent 80%)` | N/A (use CSS module) |
### Pattern 7: Responsive Spacing/Sizing → Responsive Style Props (NOT CSS Media Queries)

View File

@@ -179,14 +179,26 @@
clojure.core.async/take!
clojure.core.async/to-chan!
clojure.core.async/to-chan!!
metabase.ai-tracing.core/record!
metabase.api.macros.defendpoint.tools-manifest/assert-optional-fields-nullable!
metabase.channel.core/send!
metabase.channel.render.pdf/draw-too-large!
metabase.channel.render.pdf/draw-no-results!
metabase.channel.render.pdf/render-card-cell!
metabase.channel.render.pdf.font/load-fonts!
metabase.warehouses.models.database/assert-not-h2!
metabase.driver.sql-jdbc.execute/execute-prepared-statement!
metabase.mcp.usage/record-mcp-session!
metabase.mcp.usage/record-mcp-session-end!
metabase.mcp.usage/record-mcp-tool-call!
metabase.notification.models/create-notification!
metabase.oauth-server.core/reset-provider!
metabase.pulse.send/send-pulse!
metabase-enterprise.transforms-python.python-runner-test/execute!
;; MCP usage tests isolate their rows by unique keys (session id / tool name / duration /
;; client version) and clean up only those, so these deletes are safe in parallel.
metabase-enterprise.mcp.usage-test/cleanup!
metabase-enterprise.mcp.usage-test/cleanup-calls!
;; Workspace isolation functions are safe in parallel tests because they operate on
;; isolated, test-specific workspaces and databases that don't affect other tests
metabase-enterprise.workspaces.isolation/destroy-workspace-isolation!
@@ -248,9 +260,6 @@
;; misc config for built-in linters
;;
:invalid-arity {:skip-args [metabase.util.match/match-one
metabase.util.match/match-many
metabase.util.match/replace]} ; TODO (cam): can we fix these?
:refer-all {:level :warning, :exclude [clojure.test]}
:unused-referred-var {:exclude {compojure.core [GET DELETE POST PUT]}}
@@ -444,6 +453,10 @@
instaparse.core/defparser clojure.core/def
metabase-enterprise.action-v2.test-util/with-test-tables! clojure.core/let
metabase-enterprise.content-translation.routes-test/with-new-secret-key! clojure.core/fn
metabase-enterprise.entity-retrieval.reconcile-test/with-isolated-index clojure.core/fn
metabase-enterprise.mfa.enrollment-flow-test/with-fresh-user-session! clojure.core/fn
metabase-enterprise.mfa.login-flow-test/with-enrolled-rasta! clojure.core/fn
metabase-enterprise.mfa.recovery-codes-test/with-confirmed-enrollment! clojure.core/fn
metabase-enterprise.serialization.metadata-file-import.wire-format-test/with-tiny-fixture! clojure.core/fn
metabase-enterprise.serialization.test-util/with-dbs clojure.core/fn
metabase-enterprise.serialization.test-util/with-random-dump-dir clojure.core/let
@@ -460,6 +473,7 @@
metabase.channel.impl.http-test/with-captured-http-requests clojure.core/fn
metabase.channel.impl.http-test/with-server clojure.core/let
metabase.collections.models.collection-test/with-collection-in-location clojure.core/let
metabase.collections.test-utils/with-library clojure.core/fn
metabase.driver.mongo.connection/with-mongo-client clojure.core/let
metabase.driver.mongo.connection/with-mongo-database clojure.core/let
metabase.driver.mongo.query-processor/mongo-let clojure.core/let
@@ -473,6 +487,7 @@
metabase.notification.test-util/with-card-notification clojure.core/let
metabase.notification.test-util/with-system-event-notification! clojure.core/let
metabase.notification.test-util/with-temp-notification clojure.core/let
metabase.osi.ai-context.api-test/with-test-entry clojure.core/let
metabase.premium-features.core/defenterprise-schema clj-kondo.lint-as/def-catch-all
metabase.premium-features.defenterprise/defenterprise-schema clj-kondo.lint-as/def-catch-all
metabase.premium-features.settings/define-premium-feature clojure.core/def
@@ -574,7 +589,7 @@
metabase.api.common.internal-test/with-jetty-server hooks.common/with-one-binding
metabase.api.macros/defendpoint hooks.metabase.api.macros/defendpoint
metabase.app-db.schema-migrations-test.impl/test-migrations hooks.metabase.app-db.schema-migrations-test.impl/test-migrations
metabase.channel.render.js.svg/with-static-viz-context hooks.common/with-one-top-level-binding
metabase.channel.render.js.pool/with-static-viz-context hooks.common/with-one-top-level-binding
metabase.channel.template.handlebars-helper/defhelper hooks.metabase.channel.template.handlebars-helper/defhelper
metabase.channel.template.handlebars-test/with-temp-template! hooks.common/with-vec-first-binding
metabase.classloader.core/require hooks.clojure.core.require/lint-require
@@ -610,6 +625,9 @@
metabase.model-persistence.api-test/with-persistence-setup! hooks.common/with-one-top-level-binding
metabase.model-persistence.api-test/with-setup! hooks.common/with-one-top-level-binding
metabase.model-persistence.test-util/with-persistence-enabled! hooks.metabase.model-persistence.test-util/with-persistence-enabled!
metabase.mq.core/with-queue hooks.common/let-second
metabase.mq.test-util/with-test-mq hooks.common/with-one-binding
metabase.mq.core/def-listener! hooks.metabase.mq.impl/def-listener
metabase.models.interface/define-batched-hydration-method hooks.metabase.models.interface/define-hydration-method
metabase.models.interface/define-simple-hydration-method hooks.metabase.models.interface/define-hydration-method
metabase.permissions.core/allow-changing-all-users-group-members hooks.common/do*
@@ -701,6 +719,10 @@
metabase.util.log/warn hooks.metabase.util.log/info
metabase.util.log/warnf hooks.metabase.util.log/infof
metabase.util.malli.registry/def hooks.metabase.util.malli.registry/def
metabase.util.match/match-one hooks.metabase.util.match/match-one
metabase.util.match/match-many hooks.metabase.util.match/match-many
metabase.util.match/replace hooks.metabase.util.match/replace
metabase.util.match/replace-in hooks.metabase.util.match/replace-in
metabase.util/case-enum hooks.metabase.util/case-enum
metabase.util/format-color hooks.metabase.util/format-color
metabase.xrays.api.automagic-dashboards-test/with-indexed-model! hooks.metabase.xrays.api.automagic-dashboards-test/with-indexed-model!
@@ -744,6 +766,7 @@
metabase.test/with-temporary-raw-setting-values macros.metabase.test.util/with-temporary-raw-setting-values
metabase.users.models.user-test/with-groups! macros.metabase.users.models.user-test/with-groups!
metabase.util.namespaces/import-fn macros.metabase.util.namespaces/import-fn
metabase.util.namespaces/import-macro macros.metabase.util.namespaces/import-macro
metabase.xrays.related-test/with-world macros.metabase.xrays.related-test/with-world}}
:config-in-comment
@@ -801,7 +824,6 @@
;;
{:pattern "^metabase(?:((?:-enterprise\\.sandbox)?\\.query-processor)|(?:\\.driver\\.sql(?!server)(?!ite))).*-test$"
:name general-qp-and-driver-test-namespaces}
{:pattern "(?:^mage.*)"
:name mage-namespaces}]

View File

@@ -159,7 +159,8 @@
{:team "Metabot"
:api #{metabase.agent-api.api
metabase.agent-api.init}
:uses #{api
:uses #{ai-tracing
api
auth-identity
channel
collections
@@ -180,6 +181,8 @@
:model/Collection
:model/Dashboard
:model/DashboardCard
:model/DashboardTab
:model/Database
:model/Table
:model/User}}
@@ -192,6 +195,15 @@
models
util}}
ai-tracing
{:team "Metabot"
:api #{metabase.ai-tracing.api
metabase.ai-tracing.core
metabase.ai-tracing.init}
:uses #{api
settings
util}}
analytics
{:team "UX West"
:api #{metabase.analytics.api
@@ -357,6 +369,7 @@
{:team "UX West"
:api #{metabase.audit-app.core
metabase.audit-app.init}
:friends #{enterprise/memoize-monitor}
:uses #{api
app-db
events
@@ -504,6 +517,7 @@
pivot
premium-features
query-processor
request
settings
slackbot
system
@@ -514,6 +528,8 @@
util}
:model-exports #{:model/Channel :model/ChannelTemplate}
:model-imports #{:model/Dashboard
:model/DashboardCard
:model/DashboardTab
:model/Database
:model/PulseChannel
:model/User}}
@@ -569,6 +585,7 @@
collections
{:team "UX West"
:api #{metabase.collections.core
metabase.collections.curation
metabase.collections.models.collection
metabase.collections.models.collection.root
metabase.collections.schema}
@@ -697,6 +714,7 @@
audit-app
collections
config
embedding
events
lib
models
@@ -707,6 +725,7 @@
query-processor
search
settings
staleness
sync
util}
:model-exports #{:model/Dashboard
@@ -821,7 +840,6 @@
metabase.driver.common
metabase.driver.connection
metabase.driver.ddl.interface
metabase.driver.h2
metabase.driver.impl
metabase.driver.init
metabase.driver.mysql
@@ -956,7 +974,14 @@
request
tiles
util}
:model-imports #{:model/Card :model/Dashboard :model/EmbeddingTheme}}
:model-imports #{:model/Card :model/Dashboard :model/DashboardCard :model/EmbeddingTheme}}
entity-retrieval
{:team "Metabot"
:api #{metabase.entity-retrieval.core
metabase.entity-retrieval.mirror}
:uses #{premium-features}
:model-imports #{:model/OsiAiContext}}
events
{:team "DevEx"
@@ -1050,6 +1075,27 @@
:model-exports #{:model/ModelIndex :model/ModelIndexValue}
:model-imports #{:model/Card :model/Collection}}
indexes
{:team "Gadget"
:api #{metabase.indexes.models.table-index
metabase.indexes.reconcile
metabase.indexes.schema}
:uses #{driver
models
util}
:model-exports #{:model/TableIndex}}
indexes-rest
{:team "Gadget"
:api #{metabase.indexes-rest.api}
:uses #{api
indexes
transforms-base
util}
:model-imports #{:model/Database
:model/TableIndex
:model/Transform}}
initialization-status
{:team "UX West"
:api #{metabase.initialization-status.core}
@@ -1089,6 +1135,7 @@
metabase.lib.metadata
metabase.lib.metadata.protocols
metabase.lib.options
metabase.lib.pivot
metabase.lib.schema
metabase.lib.schema.actions
metabase.lib.schema.aggregation
@@ -1176,7 +1223,10 @@
sync
util
warehouse-schema}
:model-imports #{:model/Card :model/Database :model/Field :model/Table}}
:model-imports #{:model/Card
:model/Database
:model/Field
:model/Table}}
logger
{:team "DevEx"
@@ -1209,13 +1259,19 @@
:api #{metabase.mcp.api
metabase.mcp.callback-api
metabase.mcp.core
metabase.mcp.init}
metabase.mcp.init
metabase.mcp.usage}
:model-exports #{:model/McpSessionLog
:model/McpToolCallLog}
:uses #{agent-api
ai-tracing
api
app-db
config
llm
metabot
oauth-server
premium-features
request
server
session
@@ -1254,6 +1310,7 @@
slackbot}
:uses #{activity-feed
agent-lib
ai-tracing
analytics
analytics-interface
api
@@ -1265,6 +1322,7 @@
config
documents
driver
entity-retrieval
interestingness
legacy-mbql
lib
@@ -1284,7 +1342,6 @@
settings
slackbot
sql-tools
store-api
sync
system
task
@@ -1300,6 +1357,8 @@
:model-imports #{:model/Card
:model/Collection
:model/Dashboard
:model/DashboardCard
:model/DashboardTab
:model/Database
:model/Field
:model/Glossary
@@ -1389,6 +1448,17 @@
:model/Table
:model/User}}
mq
{:team "UX West"
:api #{metabase.mq.init}
:uses #{analytics-interface
app-db
classloader
settings
startup
task
util}}
native-query-snippets
{:team "Graphy"
:api #{metabase.native-query-snippets.api
@@ -1447,6 +1517,7 @@
:model/DashboardCard
:model/DashboardTab
:model/TaskHistory
:model/TaskRun
:model/User}}
oauth-server
@@ -1467,6 +1538,20 @@
tracing
util}}
osi
{:team "Metabot"
:api #{metabase.osi.ai-context.api}
:uses #{api
app-db
entity-retrieval
models
request
util}
:model-exports #{:model/OsiAiContext}
:model-imports #{:model/Card
:model/Measure
:model/Segment}}
;; TODO -- too many API namespaces
parameters
{:team "Graphy"
@@ -1687,6 +1772,7 @@
content-verification
dashboards
documents
embedding
events
graph
lib
@@ -1702,6 +1788,8 @@
query-processor
request
search
settings
staleness
sync
util
view-log
@@ -1814,6 +1902,7 @@
cache
config
dashboards
database-routing
driver
events
formatter
@@ -1828,6 +1917,7 @@
premium-features
queries
query-permissions
request
server
settings
system
@@ -1836,8 +1926,6 @@
util
workspaces}
:model-imports #{:model/Card
:model/Dashboard
:model/DashboardCard
:model/DashboardCardSeries
:model/Database
:model/QueryCache
@@ -1908,11 +1996,12 @@
{:team "UX West"
:api #{metabase.sample-data.core
metabase.sample-data.init}
:uses #{plugins
:uses #{driver
plugins
settings
sync
util}
:model-imports #{:model/Database}}
:model-imports #{:model/DataPermissions :model/Database :model/Table}}
search
{:team "UX West"
@@ -2026,6 +2115,7 @@
channel
config
events
premium-features
request
settings
sso
@@ -2123,8 +2213,7 @@
sql-parsing
{:team "DevEx"
:api #{metabase.sql-parsing.core}
:uses #{analytics-interface
util}}
:uses #{analytics-interface util}}
sql-tools
{:team "DevEx"
@@ -2158,6 +2247,10 @@
util}
:model-imports #{:model/AuthIdentity :model/PermissionsGroupMembership}}
staleness
{:team "UX West"
:api #{metabase.staleness.core}}
startup
{:team "DevEx"
:api #{metabase.startup.core}
@@ -2239,7 +2332,7 @@
task
tracing
util}
:model-exports #{:model/TaskHistory}
:model-exports #{:model/TaskHistory :model/TaskRun}
:model-imports #{:model/Card :model/Dashboard :model/Database}}
tenants
@@ -2259,9 +2352,11 @@
config
lib
lib-be
mcp
permissions
premium-features
search
session
util}
:model-imports #{:model/AiUsageLog
:model/Card
@@ -2285,7 +2380,8 @@
parameters
query-processor
settings
util}}
util}
:model-imports #{:model/Card :model/Dashboard :model/DashboardCard}}
timeline
{:team "UX West"
@@ -2325,6 +2421,7 @@
database-routing
driver
events
indexes
lib
lib-be
models
@@ -2346,6 +2443,7 @@
enterprise/transforms-python}
:model-exports #{:model/Transform
:model/TransformJob
:model/TransformJobRun
:model/TransformJobTransformTag
:model/TransformRun
:model/TransformTag}
@@ -2353,6 +2451,7 @@
:model/Database
:model/Field
:model/Table
:model/TableIndex
:model/User}}
transforms-base
@@ -2366,11 +2465,13 @@
:model-imports #{:model/Database
:model/Field
:model/Table
:model/TableIndex
:model/Transform
:model/TransformRun}
:uses #{database-routing
driver
events
indexes
lib
lib-be
premium-features
@@ -2399,6 +2500,7 @@
util}
:model-imports #{:model/Transform
:model/TransformJob
:model/TransformJobRun
:model/TransformJobTransformTag
:model/TransformRun
:model/TransformTag}}
@@ -2796,6 +2898,7 @@
:uses #{driver
premium-features
enterprise/advanced-config
enterprise/mfa
enterprise/scim
enterprise/semantic-search
enterprise/sso}
@@ -2821,7 +2924,6 @@
app-db
audit-app
classloader
config
driver
lib
models
@@ -3030,7 +3132,6 @@
{:team "UX West"
:api #{metabase-enterprise.database-routing.api}
:uses #{api
config
database-routing
driver
events
@@ -3126,6 +3227,22 @@
;; make token tracking a hook). Drop this dep once the relocation lands.
:uses #{enterprise/semantic-search}}
enterprise/entity-retrieval
{:team "Metabot"
:api #{metabase-enterprise.entity-retrieval.init}
:uses #{analytics-interface
collections
entity-retrieval
premium-features
task
util
enterprise/semantic-search}
:model-imports #{:model/Card
:model/Measure
:model/OsiAiContext
:model/Segment
:model/Table}}
enterprise/erd
{:team "Gadget"
:api #{metabase-enterprise.erd.api}
@@ -3187,6 +3304,32 @@
premium-features}
:model-imports #{:model/Card :model/Collection :model/Table}}
enterprise/mcp
{:team "Metabot"
:api #{metabase-enterprise.mcp.init}
:uses #{analytics
mcp
metabot
premium-features
task
util}
:model-imports #{:model/McpSessionLog
:model/McpToolCallLog}}
enterprise/memoize-monitor
{:team "Graphy"
:api #{metabase-enterprise.memoize-monitor.init}
:uses #{analytics
analytics-interface
audit-app
collections
driver
models
util
warehouse-schema
warehouses
enterprise/serialization}}
enterprise/metabot
{:team "Metabot"
:api #{metabase-enterprise.metabot.api
@@ -3226,6 +3369,22 @@
util}
:model-imports #{:model/MetabotConversation :model/MetabotFeedback :model/MetabotMessage}}
enterprise/mfa
{:team "Graphy"
:api #{metabase-enterprise.mfa.core
metabase-enterprise.mfa.init
metabase-enterprise.mfa.routes}
:uses #{api
appearance
channel
config
events
premium-features
settings
sso
util}
:model-imports #{:model/AuthIdentity :model/User}}
enterprise/permission-debug
{:team "UX West"
:api #{metabase-enterprise.permission-debug.api}
@@ -3255,6 +3414,7 @@
events
models
premium-features
search
settings
startup
task
@@ -3392,14 +3552,19 @@
{:team "Metabot"
:api #{metabase-enterprise.semantic-search.api
metabase-enterprise.semantic-search.core
metabase-enterprise.semantic-search.db.datasource
metabase-enterprise.semantic-search.embedding
metabase-enterprise.semantic-search.init}
:uses #{activity-feed
analytics
analytics-interface
api
app-db
collections
config
connection-pool
events
lib-be
llm
metabot
models
@@ -3410,7 +3575,9 @@
task
tracing
util}
:model-imports #{:model/Collection}}
:model-imports #{:model/Collection
:model/Dashboard
:model/Table}}
enterprise/serialization
{:team "Graphy"
@@ -3420,12 +3587,12 @@
metabase-enterprise.serialization.init
metabase-enterprise.serialization.schema
metabase-enterprise.serialization.v2.backfill-ids}
:friends #{enterprise/memoize-monitor}
:uses #{analytics
api
app-db
appearance
collections
config
events
lib
logger
@@ -3478,11 +3645,11 @@
:uses #{analytics
api
collections
embedding
premium-features
queries
request
settings
staleness
util}
:model-imports #{:model/Card :model/Collection :model/Dashboard}}
@@ -3521,7 +3688,9 @@
{:team "Graphy"
:api #{metabase-enterprise.transforms.api}
:uses #{premium-features
enterprise/transforms-inspector}}
util
enterprise/transforms-inspector}
:model-imports #{:model/Transform}}
enterprise/transforms-inspector
{:team "Gadget"

View File

@@ -36,6 +36,9 @@
;; Definitely thread safe
metabase.test.util.dynamic-redefs/patch-vars!
;; test-only cleanup of in-memory throttle state (atom resets)
metabase.session.api/reset-throttlers-for-testing!
;; TODO: most of these symbols shouldn't be here, we should go through them and
;; find the functions/macros that use them and make sure their names end with !
;; best way to do this is try remove each of these and rely on kondo output to find places where it's used

View File

@@ -6,3 +6,8 @@
`(def ~(-> sym name symbol) "docstring" ~sym))
([sym name]
`(def ~name "docstring" ~sym)))
(defmacro import-macro
"Kondo macro replacement for [[metabase.util.namespaces/import-macro]]."
[sym]
`(def ~(-> sym name symbol) "docstring" ~sym))

View File

@@ -0,0 +1,18 @@
(ns hooks.metabase.mq.impl
(:require
[clj-kondo.hooks-api :as hooks]))
(defn def-listener
"Kondo hook for `mq/def-listener`. Rewrites to a `fn` form so kondo can analyze bindings.
Form:
(mq/def-listener! :queue/bar [msgs] body...)"
[{:keys [node]}]
(let [[_ _channel-name bindings & body] (:children node)
;; rewrite as: (fn [bindings...] body...)
new-node (hooks/list-node
(list*
(hooks/token-node 'fn)
bindings
body))]
{:node new-node}))

View File

@@ -0,0 +1,132 @@
(ns hooks.metabase.util.match
(:require [clj-kondo.hooks-api :as api]))
(defn- token-node? [node token-name]
(and (api/token-node? node)
(= (str (:value node)) token-name)))
(defn- keyword-node? [node k]
(and (api/keyword-node? node)
(= (:k node) k)))
(defn- binding-symbol?
"True when the token is a plain symbol that should be treated as a binding
(not a keyword, not a boolean literal, not nil, not a number, not `_`)."
[node]
(and (api/token-node? node)
(let [v (:value node)]
(and (symbol? v)
(not (contains? '#{_ nil true false} v))))))
;; To establish fake let bindings, we need to bind them to something. This "something" has to be vague enough to trick
;; kondo into not looking too much into it. E.g., if we bind everything to `nil`, Kondo linters will get fired up.
(def opaque-node (api/list-node (list (api/token-node 'rand-nth) (api/list-node []))))
(defn collect-bindings
"Return a list of token nodes (symbols) introduced as bindings by `pattern`."
[pattern]
(cond
(binding-symbol? pattern)
[[pattern opaque-node]]
;; Lists: (:or ...), (:and ...), (sym :guard pred ...), or a quoted symbol.
(api/list-node? pattern)
(let [[head & rst] (:children pattern)]
(cond (or (keyword-node? head :or)
(keyword-node? head :and))
(mapcat collect-bindings rst)
(api/token-node? head)
(cond-> []
(binding-symbol? head) (conj [head opaque-node])
(keyword-node? (first rst) :guard) (conj [(api/token-node '_) (second rst)]))
;; anything else (e.g. a function call used as predicate) — no bindings
:else []))
(api/vector-node? pattern)
(mapcat (fn [node]
(when-not (token-node? node "&")
(collect-bindings node)))
(:children pattern))
;; Maps: keys are literal selectors, values are sub-patterns.
;; Special value-symbols &truthy and _ are NOT user bindings.
(api/map-node? pattern)
(let [children (:children pattern)
pairs (partition 2 children)]
(mapcat (fn [[_k v]]
(when-not (or (token-node? v "&truthy")
(token-node? v "_"))
(collect-bindings v)))
pairs))
;; For sets, make sure to use them because they may reference some of the outer local bindings, so if we don't
;; include them, Kondo will complain about those bindings being unused.
(api/set-node? pattern)
[[(api/token-node '_) pattern]]
;; Anything else — no bindings.
:else []))
(defn- dedupe-bindings
"Prevent Kondo complaining that we have multiple fake bindings."
[pairs]
(loop [[[sym v] & r] pairs, seen #{}, result []]
(cond (nil? sym) result
(and (seen sym) (not (token-node? sym "_"))) (recur r seen result)
:else (recur r (conj seen sym) (conj result sym v)))))
(defn match-one
"clj-kondo :analyze-call hook for match-one.
Rewrites
(match-one value
pat1 ret1
pat2 ret2
...)
into a `let` form that declares all binding symbols introduced by the patterns, so clj-kondo knows they are
legitimate and won't warn about unresolved/unused symbols:
(let [<all-bindings> (rand-nth []) ...]
(or ret1 ret2 ...))"
[{:keys [node]}]
(let [[_ value & clauses] (:children node)]
(when (odd? (count clauses))
(api/reg-finding!
{:message "match-one/match-many/replace requires an even number of pattern/result pairs"
:type :metabase/match-odd-clauses
:row (:row node)
:col (:col node)
:filename (-> node meta :filename)}))
(let [pairs (partition 2 clauses)
all-bindings (->> pairs
(mapcat (fn [[pat _ret]] (collect-bindings pat)))
dedupe-bindings)
special-bindings [(api/token-node '_) value
(api/token-node '&match) opaque-node
(api/token-node '&parents) opaque-node
(api/token-node '&recur) opaque-node
;; Pretend to use &match, &parents, and &recur so that Kondo doesn't complain about them
;; if they are not used by the user code.
(api/token-node '_) (api/token-node '&match)
(api/token-node '_) (api/token-node '&parents)
(api/token-node '_) (api/token-node '&recur)]
binding-nodes (into special-bindings all-bindings)
result-exprs (map second pairs)
new-node (api/list-node
(list
(api/token-node 'let)
(api/vector-node binding-nodes)
(api/list-node
(concat [(api/token-node 'clojure.core/or)] result-exprs [opaque-node]))))]
{:node new-node})))
(def match-many match-one)
(def replace match-one)
(defn replace-in [context]
;; Everything is the same as in match-one, just drop the middle argument.
(match-one (update-in context [:node :children] (fn [[sym value path & clauses]] (list* sym value clauses)))))

View File

@@ -0,0 +1,59 @@
(ns hooks.metabase.util.match-test
(:require
[clj-kondo.hooks-api :as hooks]
[clj-kondo.impl.utils]
[clojure.test :refer :all]
[hooks.metabase.util.match :as sut]))
(defn- expand [src]
(-> (sut/match-one {:node (hooks/parse-string (pr-str src))})
:node
hooks/sexpr))
(defn- lint [src]
(binding [clj-kondo.impl.utils/*ctx* {:config {:linters {:metabase/match-odd-clauses {:level :warning}}}
:ignores (atom nil)
:findings (atom [])
:namespaces (atom {})}]
(expand src)
@(:findings clj-kondo.impl.utils/*ctx*)))
(deftest odd-clauses-triggers-warning-test
(is (=? [{:type :metabase/match-odd-clauses}]
(lint '(metabase.util.match/match-one [] [a b c])))))
(deftest expansion-test
(testing "simple expansion example"
(is (= '(let [_ []
&match (rand-nth ())
&parents (rand-nth ())
&recur (rand-nth ())
_ &match
_ &parents
_ &recur
a (rand-nth ())
b (rand-nth ())
c (rand-nth ())]
(clojure.core/or (+ a b) (rand-nth ())))
(expand '(match-one [] [a b c] (+ a b))))))
(testing "complicated expansion example that uses most match-one macro features, and also binding deduplication by the rewriter"
(is (= '(let [_ []
&match (rand-nth ())
&parents (rand-nth ())
&recur (rand-nth ())
_ &match
_ &parents
_ &recur
val1 (rand-nth ())
a (rand-nth ())
_ #{maybe important}
rst (rand-nth ())
x (rand-nth ())
_ (= x 3)
b (rand-nth ())]
(clojure.core/or (+ a val1) (rand-nth ())))
(expand '(match-one []
(:or [{:key1 val1, :key2 &truthy, :key3 _} _ a #{maybe important} & rst]
(:and (x :guard (= x 3))
[a b]))
(+ a val1)))))))

28
.coderabbit.yaml Normal file
View File

@@ -0,0 +1,28 @@
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
reviews:
high_level_summary: false
review_status: false
auto_review:
enabled: false
drafts: true
labels:
- "coderabbit"
path_filters:
- "!**/*.snap"
- "!**/*.po"
- "!**/bun.lock"
- "!**/package-lock.json"
tools:
eslint:
enabled: false
knowledge_base:
code_guidelines:
filePatterns:
- ".claude/skills/clojure-review/SKILL.md"
- ".claude/skills/typescript-review/SKILL.md"
- ".claude/skills/e2e-test-review/SKILL.md"
- ".claude/skills/docs-review/SKILL.md"

32
.dependency-cruiser.cjs Normal file
View File

@@ -0,0 +1,32 @@
// dependency-cruiser config for the actual frontend import graph (what's
// imported, vs the *allowed* edges in module-boundaries.mjs). Consumed by
// .github/scripts/create-test-plan.ts.
//
// bunx depcruise frontend/src enterprise/frontend/src \
// --config .dependency-cruiser.cjs --output-type json > dependency-graph.json
/** @type {import('dependency-cruiser').IConfiguration} */
module.exports = {
options: {
// Keep only edges between our own source files (drops node_modules etc.),
// which keeps the JSON small.
includeOnly: "^(frontend/src|enterprise/frontend/src)/",
doNotFollow: { path: "node_modules" },
// Resolve the `"*": ["./frontend/src/*", ...]` aliases so bare imports like
// `metabase/lib/foo` map back to a real file.
tsConfig: { fileName: "tsconfig.json" },
// Keep type-only imports: a type-only dependent still breaks on a type change.
tsPreCompilationDeps: true,
moduleSystems: ["es6", "cjs", "tsd"],
enhancedResolveOptions: {
exportsFields: ["exports"],
conditionNames: ["import", "require", "node", "default", "types"],
extensions: [".js", ".jsx", ".ts", ".tsx", ".json"],
},
},
};

View File

@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/vscode/devcontainers/java:21
FROM mcr.microsoft.com/vscode/devcontainers/java:25
# Set up nodesource, install node, bun, fontconfig for static viz, rlwrap for dev ergonomics

View File

@@ -1,5 +1,6 @@
.git
.babel_cache
target/*
target
.circleci
.cpcache
.devcontainer
@@ -15,6 +16,7 @@ test_config/*
test_modules/*
test_resources/*
node_modules
**/node_modules
**metabase.jar
*.db

6
.gitattributes vendored
View File

@@ -7,3 +7,9 @@
#
# TODO (Bryan 12/12/25) -- reenable this when we can completely verify correctness
# resources/migrations/*_update_migrations.yaml merge=yaml-migrations
# Generated API documentation/specs — regenerated by the "Auto-update documentation for master"
# CI automation, not edited by hand. Mark generated so tools/humans don't review or diff them as source.
docs/api.json linguist-generated
docs/api.html linguist-generated
resources/openapi/openapi.json linguist-generated

20
.github/CODEOWNERS vendored
View File

@@ -12,13 +12,27 @@ enterprise/backend/src/metabase_enterprise/dependencies @metabase/graphy
enterprise/frontend/src/metabase-enterprise/dependencies @metabase/graphy
# @metabase/embedding
enterprise/frontend/src/embedding-sdk-package @metabase/embedding
enterprise/frontend/src/embedding-sdk-bundle @metabase/embedding
enterprise/frontend/src/embedding-sdk-shared @metabase/embedding
frontend/src/metabase/embedding @metabase/embedding
frontend/src/metabase/embedding-sdk @metabase/embedding
frontend/src/embedding-sdk-bundle @metabase/embedding
frontend/src/embedding-sdk-shared @metabase/embedding
frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion @metabase/embedding
frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard @metabase/embedding
enterprise/frontend/src/embedding @metabase/embedding
enterprise/frontend/src/embedding-sdk-ee @metabase/embedding
enterprise/frontend/src/embedding-sdk-package @metabase/embedding
enterprise/frontend/src/metabase-enterprise/embedding @metabase/embedding
enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk @metabase/embedding
enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk_setup @metabase/embedding
enterprise/frontend/src/metabase-enterprise/embedding-sdk @metabase/embedding
e2e/test-component @metabase/embedding
e2e/test/scenarios/embedding @metabase/embedding
e2e/embedding-sdk-host-apps @metabase/embedding
# @metabase/tech-writers
docs @metabase/tech-writers
docs/developers-guide # exclude from tech-writer ownership

View File

@@ -0,0 +1,131 @@
name: Create test plan
description: Cruise the frontend import graph and compute the affected-tests plan.
inputs:
changed-files:
description: All changed files (CSV).
required: true
fe-changed-files:
description: Changed frontend_sources files (CSV).
required: true
be-changed-files:
description: Changed backend_sources files (CSV).
required: true
unit-infra-touched:
description: Whether FE unit infra changed.
required: true
loki-infra-touched:
description: Whether Loki infra changed.
required: true
e2e-infra-touched:
description: Whether e2e harness/support code changed.
required: true
shared-sources-touched:
description: Whether cljc/cljs/package.json changed.
required: true
outputs:
stats:
description: FE Affected Tests stats row (JSON).
value: ${{ steps.compute.outputs.stats }}
fe_unit_specs_to_run:
description: Unit specs to run (JSON array).
value: ${{ steps.compute.outputs.fe_unit_specs_to_run }}
loki_stories_to_run:
description: Loki stories to run (JSON array).
value: ${{ steps.compute.outputs.loki_stories_to_run }}
e2e_specs_to_run:
description: E2E specs to run (JSON array).
value: ${{ steps.compute.outputs.e2e_specs_to_run }}
runs:
using: composite
steps:
- name: Prepare Node + Bun
uses: ./.github/actions/prepare-node-bun
- name: Resolve closest-ancestor e2e coverage manifest
id: manifest
uses: actions/github-script@v9
with:
script: | # js
const { pathToFileURL } = require("url");
const { resolveCoverageManifest } = await import(
pathToFileURL(
`${process.env.GITHUB_WORKSPACE}/.github/scripts/resolve-coverage-manifest.mjs`,
).href,
);
const result = await resolveCoverageManifest({
github,
owner: context.repo.owner,
repo: context.repo.repo,
headSha: context.payload.pull_request?.head?.sha ?? context.sha,
});
core.setOutput("path", result?.path ?? "");
- name: Build dependency graph
shell: bash
run: |
# Quiet on success; surface output only if install fails.
bun install --frozen-lockfile > /tmp/bun-install.log 2>&1 \
|| { echo "bun install issues (continuing):"; tail -20 /tmp/bun-install.log; }
bunx depcruise frontend/src enterprise/frontend/src \
--config .dependency-cruiser.cjs \
--output-type json > dependency-graph.json || true
- name: Create test plan
id: compute
shell: bash
env:
CHANGED_FILES: ${{ inputs.changed-files }}
FE_CHANGED_FILES: ${{ inputs.fe-changed-files }}
BE_CHANGED_FILES: ${{ inputs.be-changed-files }}
UNIT_INFRA_TOUCHED: ${{ inputs.unit-infra-touched }}
LOKI_INFRA_TOUCHED: ${{ inputs.loki-infra-touched }}
E2E_INFRA_TOUCHED: ${{ inputs.e2e-infra-touched }}
SHARED_SOURCES_TOUCHED: ${{ inputs.shared-sources-touched }}
DEP_GRAPH_JSON: dependency-graph.json
E2E_SPEC_MANIFEST: ${{ steps.manifest.outputs.path }}
run: |
# stdout is the plan JSON; the planner's own info logs go to stderr.
bun .github/scripts/create-test-plan.ts > test-plan.json
echo "stats=$(jq -c '.stats' test-plan.json)" >> "$GITHUB_OUTPUT"
echo "fe_unit_specs_to_run=$(jq -c '.fe_unit_specs_to_run' test-plan.json)" >> "$GITHUB_OUTPUT"
echo "loki_stories_to_run=$(jq -c '.loki_stories_to_run' test-plan.json)" >> "$GITHUB_OUTPUT"
echo "e2e_specs_to_run=$(jq -c '.e2e_specs_to_run' test-plan.json)" >> "$GITHUB_OUTPUT"
- name: Report test plan
shell: bash
run: |
plan=test-plan.json
row() { # name, selected, total
if [ "$2" -eq "$3" ]; then echo "| $1 | all ($3) | $3 |"; else echo "| $1 | $2 | $3 |"; fi
}
{
echo "## Affected test plan"
echo
echo "| Suite | Selected | Total |"
echo "|---|---:|---:|"
row "Unit" "$(jq '.stats.unit_specs_to_run_usage' "$plan")" "$(jq '.stats.unit_specs_all' "$plan")"
row "Loki" "$(jq '.stats.loki_stories_to_run_usage' "$plan")" "$(jq '.stats.loki_stories_all' "$plan")"
row "E2E" "$(jq '.stats.e2e_specs_to_run_usage' "$plan")" "$(jq '.stats.e2e_specs_all' "$plan")"
echo
echo "Changed: $(jq '.stats.fe_files_changed' "$plan") FE / $(jq '.stats.be_files_changed' "$plan") BE file(s) · $(jq '.stats.fe_modules_affected_usage' "$plan") FE module(s) affected"
echo
e2e_run=$(jq '.stats.e2e_specs_to_run_usage' "$plan")
e2e_all=$(jq '.stats.e2e_specs_all' "$plan")
if [ "$e2e_run" -eq "$e2e_all" ]; then
echo "**E2E: full run** — no manifest, or a change the coverage manifest can't scope (backend, e2e infra, cljc/cljs)."
else
echo "<details><summary><b>E2E specs to run ($e2e_run)</b></summary>"
echo
jq -r '.e2e_specs_to_run[]' "$plan" | sed 's/^/- /'
echo
echo "</details>"
fi
echo
echo "<details><summary>Full stats (rules vs usage graph)</summary>"
echo
echo '```json'
jq '.stats' "$plan"
echo '```'
echo "</details>"
} | tee -a "${GITHUB_STEP_SUMMARY:-/dev/null}"

View File

@@ -4,7 +4,7 @@ description: |
inputs:
java-version:
required: true
default: "21"
default: "25"
clojure-version:
required: true
default: "1.12.0.1488"

View File

@@ -0,0 +1,52 @@
name: Prepare CI Conductor
description: >-
Make the ci-conductor sources runnable in the workspace.
Unless the checkout is headed for master, they are overlaid from master, so every
branch runs the latest scripts while its workflow wiring stays branch-historical.
runs:
using: composite
steps:
- name: Detect bun
id: bun
shell: bash
run: |
if command -v bun >/dev/null; then
echo "present=true" >> "$GITHUB_OUTPUT"
else
echo "present=false" >> "$GITHUB_OUTPUT"
fi
- name: Install bun
if: steps.bun.outputs.present != 'true'
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version-file: "package.json"
token: ${{ github.token }}
# Anything headed for master runs master's own sources, so a PR can test its own changes.
- name: Fetch ci-conductor sources from master
if: ${{ github.base_ref != 'master' && github.ref_name != 'master' }}
uses: actions/checkout@v6
with:
repository: metabase/metabase
ref: master
path: .ci-conductor-master
persist-credentials: false
sparse-checkout-cone-mode: false
sparse-checkout: |
release/ci-conductor
e2e/support/ci_conductor.ts
# e2e/support/config.js and e2e/support/ci_conductor.ts resolve these by relative
# path at bundle time, so the sources have to land where the branch expects them.
- name: Overlay ci-conductor sources from master
if: ${{ github.base_ref != 'master' && github.ref_name != 'master' }}
shell: bash
run: |
set -euo pipefail
rm -rf release/ci-conductor
mv .ci-conductor-master/release/ci-conductor release/ci-conductor
mv .ci-conductor-master/e2e/support/ci_conductor.ts e2e/support/ci_conductor.ts
rm -rf .ci-conductor-master
echo "Overlaid ci-conductor sources from master."

View File

@@ -15,6 +15,10 @@ outputs:
runs:
using: "composite"
steps:
# e2e/support/config.js imports the reporter, so it has to be in place before Cypress bundles.
- name: Prepare CI Conductor
uses: ./.github/actions/prepare-ci-conductor
- name: Install Chrome v144
uses: browser-actions/setup-chrome@2e1d749697dd1612b833dba4a722266286fbefcd # v2.1.2
with:

View File

@@ -16,5 +16,5 @@ runs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.7"
bun-version-file: 'package.json'
token: ${{ github.token }}

View File

@@ -6,7 +6,7 @@ runs:
steps:
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.7"
bun-version-file: 'package.json'
token: ${{ github.token }}
- name: Build release scripts

View File

@@ -0,0 +1,38 @@
name: CI Conductor quarantine gate
description: >-
Check this job's test failures against ci-conductor's quarantine list.
Either enforces the quarantine or only prints a verdict (dry run).
Fails closed when enforcing but the `CI_CONDUCTOR_BASE_URL` is missing or unreachable.
inputs:
adapter:
description: Which gate to run — one of `backend`, `frontend`, `e2e`.
required: true
test-suite:
description: >-
Suite label to gate (CI_CONDUCTOR_TEST_SUITE). MUST match the label this
job reports under, or the gate checks the wrong quarantine list.
required: true
enforce-quarantine:
description: >-
Whether the gate actually gates the job. When "false", it only prints a verdict.
required: false
default: "false"
runs:
using: composite
steps:
- name: Prepare CI Conductor
uses: ./.github/actions/prepare-ci-conductor
- name: Check failures against the quarantine list
shell: bash
env:
CI_CONDUCTOR_TEST_SUITE: ${{ inputs.test-suite }}
ADAPTER: ${{ inputs.adapter }}
QUARANTINE_DRY_RUN: ${{ inputs.enforce-quarantine != 'true' }}
run: |
case "$ADAPTER" in
backend|frontend|e2e) ;;
*) echo "::error::quarantine-gate: unknown adapter '$ADAPTER' (expected backend|frontend|e2e)"; exit 1 ;;
esac
bun "release/ci-conductor/src/check-${ADAPTER}-quarantine.ts"

View File

@@ -0,0 +1,34 @@
name: Report failures to CI Conductor
description: >-
Report this job's test failures to ci-conductor. Best-effort; no-ops unless
CI_CONDUCTOR_BASE_URL is set. Gate it at the call site with continue-on-error
and an `if:` on the test step's outcome.
inputs:
test-suite:
description: Per-job identity label (CI_CONDUCTOR_TEST_SUITE); unique per job/leg.
required: true
adapter:
description: Which reporter to run; resolves to report-<adapter>.ts. backend or frontend.
required: true
runs:
using: composite
steps:
- name: Prepare CI Conductor
uses: ./.github/actions/prepare-ci-conductor
- name: Report failed tests to ci-conductor
shell: bash
env:
REPO_ID: ${{ github.event.repository.id }}
COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
TARGET_BRANCH: ${{ github.event.pull_request.base.ref || github.ref_name }}
CI_CONDUCTOR_TEST_SUITE: ${{ inputs.test-suite }}
ADAPTER: ${{ inputs.adapter }}
# Keep the path constrained to known entrypoints.
run: |
case "$ADAPTER" in
backend|frontend) ;;
*) echo "::error::Unknown ci-conductor adapter '$ADAPTER'"; exit 1 ;;
esac
bun "release/ci-conductor/src/report-${ADAPTER}.ts"

View File

@@ -1,15 +1,17 @@
name: Embedding SDK Bundle Size Check
description: |
Downloads the current branch's uberjar and builds the base ref's
embedding-sdk.js from source, compares their sizes,
and sets output if the size change exceeds the threshold.
Measures app + embedding SDK bundle sizes from the current and base-ref
uberjars (reusing the builds that already ran) plus their bundle-stats
artifacts, and flags changes to the chunked SDK's reachable, gzipped size
beyond the threshold. Skips when the base-ref artifacts aren't available
rather than rebuilding from source (which would compare across pipelines).
inputs:
edition:
description: 'Metabase edition (ee or oss)'
required: true
base-ref-commit:
description: 'Commit SHA of the base ref (e.g. merge base).'
description: 'Commit SHA of the base ref.'
required: true
threshold-percent:
description: 'Percent threshold for bundle size change'
@@ -26,86 +28,73 @@ outputs:
runs:
using: "composite"
steps:
- name: Prepare backend
uses: ./.github/actions/prepare-backend
- name: Prepare frontend
uses: ./.github/actions/prepare-frontend
- name: Download current uberjar
uses: ./.github/actions/fetch-artifact
with:
commit: ${{ github.event.pull_request.head.sha || github.sha }}
edition: ${{ inputs.edition }}
extract-path: temp/current-uberjar
- name: Extract embedding-sdk bundles from current uberjar
shell: bash
run: |
# Try new layout first (app/embedding-sdk/legacy/), fall back to old layout (app/embedding-sdk.js)
unzip -j temp/current-uberjar/metabase.jar \
"frontend_client/app/embedding-sdk/legacy/embedding-sdk.js" \
-d temp/current-bundle 2>/dev/null || \
unzip -j temp/current-uberjar/metabase.jar \
"frontend_client/app/embedding-sdk.js" \
-d temp/current-bundle
# Extract chunks directory if it exists (new layout only)
mkdir -p temp/current-chunks
unzip -j temp/current-uberjar/metabase.jar \
"frontend_client/app/embedding-sdk/chunks/*" \
-d temp/current-chunks 2>/dev/null || true
- name: Checkout base ref
uses: actions/checkout@v6
- name: Download base-ref uberjar
id: base-jar
continue-on-error: true
uses: ./.github/actions/fetch-artifact
with:
ref: ${{ inputs.base-ref-commit }}
path: temp/base-ref-src
- name: Build base-ref embedding-sdk.js
shell: bash
run: |
cd temp/base-ref-src
bun install
MB_EDITION=${{ inputs.edition }} bun run build-release
- name: Compare sizes and set output
commit: ${{ inputs.base-ref-commit }}
edition: ${{ inputs.edition }}
extract-path: temp/base-uberjar
- name: Measure and compare bundle sizes
id: compare
shell: bash
env:
GH_TOKEN: ${{ github.token }}
EDITION: ${{ inputs.edition }}
HEAD_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
BASE_SHA: ${{ inputs.base-ref-commit }}
THRESHOLD: ${{ inputs.threshold-percent }}
MEASURE_BUNDLES: app,embedding-sdk-legacy,embedding-sdk-chunked
run: |
# --- Legacy (monolithic) bundle comparison ---
current_size=$(wc -c < temp/current-bundle/embedding-sdk.js) || { echo "::error::Failed to read current bundle"; exit 1; }
set -uo pipefail
# Base ref: try new layout first, fall back to old
if [ -f "temp/base-ref-src/resources/frontend_client/app/embedding-sdk/legacy/embedding-sdk.js" ]; then
base_ref_size=$(wc -c < "temp/base-ref-src/resources/frontend_client/app/embedding-sdk/legacy/embedding-sdk.js")
else
base_ref_size=$(wc -c < "temp/base-ref-src/resources/frontend_client/app/embedding-sdk.js")
fi
[ "$current_size" -gt 0 ] && [ "$base_ref_size" -gt 0 ] || { echo "::error::Bundle file is empty"; exit 1; }
skip() {
echo "::notice::Embedding SDK bundle-size check skipped: $1"
echo "status=stable" >> "$GITHUB_OUTPUT"
echo "size_change_percent=0" >> "$GITHUB_OUTPUT"
exit 0
}
diff=$((current_size - base_ref_size))
percent=$(( diff * 100 / base_ref_size ))
# The base ref needs an already-built uberjar. Rebuilding it from source
# would compare across two build pipelines (the bug this check used to
# have), so skip instead when it — or its stats — isn't available.
[ -f temp/base-uberjar/metabase.jar ] || skip "base-ref uberjar not found for ${BASE_SHA}"
echo "=== Legacy (monolithic) bundle ==="
echo "Current size: $current_size bytes"
echo "Base ref size: $base_ref_size bytes"
echo "Difference: $diff bytes ($percent%)"
extract_js() { # $1=jar $2=dest-root
mkdir -p "$2/resources"
unzip -o "$1" \
"frontend_client/app/dist/*" \
"frontend_client/app/embed.js" \
"frontend_client/app/embedding-sdk/*" \
-d "$2/resources" >/dev/null || true
}
threshold="${{ inputs.threshold-percent }}"
if [ "$percent" -gt "$threshold" ]; then
status="increased"
elif [ "$percent" -lt "$(( -threshold ))" ]; then
status="decreased"
else
status="stable"
fi
fetch_stats() { # $1=sha $2=dest-dir
local name="metabase-bundle-stats-${EDITION}-$1"
local id
id=$(gh api "/repos/${GITHUB_REPOSITORY}/actions/artifacts?name=${name}" --jq '.artifacts[0].id // empty' 2>/dev/null)
[ -n "${id}" ] || return 1
mkdir -p "$2"
gh api "/repos/${GITHUB_REPOSITORY}/actions/artifacts/${id}/zip" > "$2.zip" 2>/dev/null || return 1
unzip -o "$2.zip" -d "$2" >/dev/null || return 1
}
echo "status=$status" >> $GITHUB_OUTPUT
echo "size_change_percent=$percent" >> $GITHUB_OUTPUT
extract_js temp/current-uberjar/metabase.jar temp/current
extract_js temp/base-uberjar/metabase.jar temp/base
# --- Chunked bundle (informational) ---
if ls temp/current-chunks/*.js 1>/dev/null 2>&1; then
chunks_size=$(cat temp/current-chunks/*.js | wc -c)
echo ""
echo "=== Chunked bundle (bootstrap + chunks) ==="
echo "Total chunked size: $chunks_size bytes"
echo "chunks_size=$chunks_size" >> $GITHUB_OUTPUT
else
echo ""
echo "No chunked bundle found (expected on master)"
fi
fetch_stats "${HEAD_SHA}" temp/current/artifacts || skip "bundle stats not found for current ${HEAD_SHA}"
fetch_stats "${BASE_SHA}" temp/base/artifacts || skip "bundle stats not found for base ${BASE_SHA}"
MEASURE_ROOT=temp/current node ./.github/scripts/measure-bundle-sizes.js > temp/current-sizes.json \
|| { echo "::error::Failed to measure current bundle sizes"; exit 1; }
MEASURE_ROOT=temp/base node ./.github/scripts/measure-bundle-sizes.js > temp/base-sizes.json \
|| { echo "::error::Failed to measure base bundle sizes"; exit 1; }
node ./.github/actions/sdk-bundle-size-check/compare.js temp/current-sizes.json temp/base-sizes.json

View File

@@ -0,0 +1,110 @@
/* eslint-disable import/no-commonjs */
// Diffs the bundle sizes produced by measure-bundle-sizes.js for the current
// build and the base ref. Every (bundle, kind) is compared strictly against the
// same (bundle, kind) — never one bundle type against another — using gzipped
// (served) bytes. The gate is driven by the chunked SDK's reachable total, which
// is what the SDK actually delivers.
//
// compareBundles is pure (data in, data out) so it can be unit-tested; main()
// is the thin I/O wrapper that reads the size files, prints the report and sets
// the step outputs / exit code.
const fs = require("fs");
const pick = (rows, bundle, kind) => rows.find(row => row.bundle === bundle && row.kind === kind);
const keyOf = row => `${row.bundle}/${row.kind}`;
const mb = bytes => (bytes / 1024 / 1024).toFixed(2);
const percentOf = (currentBytes, baseBytes) =>
baseBytes ? Math.trunc(((currentBytes - baseBytes) * 100) / baseBytes) : 0;
/**
* Compare two measurement sets and decide the gate. Returns a human-readable
* `report` (always), and exactly one of:
* - `gate` { status, percent }: the chunked SDK total moved by `percent`.
* - `skip` reason: the gate is non-actionable (report stable, no comment).
* - `error` reason: the gate inputs are missing (hard failure).
*/
function compareBundles({ current, base, threshold }) {
const report = ["=== Bundle sizes (gzipped, current vs base) ==="];
const keys = [...new Set([...current, ...base].map(keyOf))].sort();
for (const key of keys) {
const [bundle, kind] = key.split("/");
const currentRow = pick(current, bundle, kind);
const baseRow = pick(base, bundle, kind);
if (!currentRow || !baseRow) {
report.push(`${key}: present only in ${currentRow ? "current" : "base"} build`);
continue;
}
const diff = currentRow.gzipBytes - baseRow.gzipBytes;
const percent = percentOf(currentRow.gzipBytes, baseRow.gzipBytes);
report.push(`${key}: ${mb(currentRow.gzipBytes)}MB vs ${mb(baseRow.gzipBytes)}MB (${percent}%, ${diff} bytes)`);
}
// Gate on the chunked SDK's reachable total (gzipped) — what the SDK ships.
const gateCurrent = pick(current, "embedding-sdk-chunked", "total");
const gateBase = pick(base, "embedding-sdk-chunked", "total");
if (!gateCurrent || !gateBase || !gateBase.gzipBytes) {
return { report, error: "Could not find embedding-sdk-chunked total (gzip) in both builds" };
}
// Both sides must measure "total" the same way. A base ref built before the
// reachableAssets enrichment collapses its total to the initial set, so
// comparing it against the current reachable total reports a phantom jump
// (~30%). Skip until the base ref also carries reachable stats (i.e. once
// this change is on the base).
if (Boolean(gateCurrent.reachable) !== Boolean(gateBase.reachable)) {
return {
report,
skip:
`chunked "total" measured differently on each side ` +
`(current reachable=${Boolean(gateCurrent.reachable)}, base reachable=${Boolean(gateBase.reachable)}); ` +
`the base ref predates the reachable-chunk stats. Resolves once this change is on the base ref.`,
};
}
const percent = percentOf(gateCurrent.gzipBytes, gateBase.gzipBytes);
const status = percent > threshold ? "increased" : percent < -threshold ? "decreased" : "stable";
return { report, gate: { status, percent } };
}
module.exports = { compareBundles };
const setOutput = (name, value) => {
if (process.env.GITHUB_OUTPUT) {
fs.appendFileSync(process.env.GITHUB_OUTPUT, `${name}=${value}\n`);
}
};
function main() {
const [, , currentPath, basePath] = process.argv;
const threshold = Number(process.env.THRESHOLD ?? 2);
const current = JSON.parse(fs.readFileSync(currentPath, "utf8"));
const base = JSON.parse(fs.readFileSync(basePath, "utf8"));
const { report, gate, skip, error } = compareBundles({ current, base, threshold });
console.log(report.join("\n"));
if (error) {
console.error(`::error::${error}`);
process.exit(1);
}
if (skip) {
// Treat the gate as non-actionable: report stable so no regression comment
// is posted, mirroring the shell skip() for missing artifacts.
console.log(`::notice::Embedding SDK bundle-size gate skipped: ${skip}`);
setOutput("status", "stable");
setOutput("size_change_percent", "0");
process.exit(0);
}
console.log("");
console.log(`Gate: embedding-sdk-chunked total ${gate.percent}% (threshold ${threshold}%) → ${gate.status}`);
setOutput("status", gate.status);
setOutput("size_change_percent", gate.percent);
}
if (require.main === module) {
main();
}

View File

@@ -0,0 +1,65 @@
const { compareBundles } = require("./compare");
const total = (gzipBytes, over = {}) => ({
bundle: "embedding-sdk-chunked",
kind: "total",
gzipBytes,
reachable: true,
...over,
});
describe("compareBundles", () => {
it("gates on the chunked SDK total and flags an increase past the threshold", () => {
const { gate, report } = compareBundles({
current: [total(110)],
base: [total(100)],
threshold: 2,
});
expect(gate).toEqual({ status: "increased", percent: 10 });
expect(report[0]).toContain("current vs base");
});
it("flags a decrease and stays stable within the threshold", () => {
expect(compareBundles({ current: [total(90)], base: [total(100)], threshold: 2 }).gate).toEqual({
status: "decreased",
percent: -10,
});
expect(compareBundles({ current: [total(101)], base: [total(100)], threshold: 2 }).gate).toEqual({
status: "stable",
percent: 1,
});
});
it("skips when the two sides measured total differently (reachable mismatch)", () => {
const result = compareBundles({
current: [total(130, { reachable: true })],
base: [total(100, { reachable: false })],
threshold: 2,
});
expect(result.gate).toBeUndefined();
expect(result.skip).toContain("predates the reachable-chunk stats");
});
it("errors when the gate bundle is missing on either side", () => {
const result = compareBundles({
current: [{ bundle: "app", kind: "total", gzipBytes: 1 }],
base: [total(100)],
threshold: 2,
});
expect(result.gate).toBeUndefined();
expect(result.error).toContain("embedding-sdk-chunked total");
});
it("reports a bundle/kind present on only one side without erroring", () => {
const { report } = compareBundles({
current: [total(100), { bundle: "app", kind: "total", gzipBytes: 50 }],
base: [total(100)],
threshold: 2,
});
expect(report.some(line => line.includes("present only in current build"))).toBe(true);
});
});

View File

@@ -14,8 +14,15 @@ inputs:
description: Suffix to append to the test logs artifact name to avoid conflicts in matrix jobs
edition:
required: false
default: 'ee'
default: "ee"
description: Edition to test (oss or ee)
quarantine-engine:
required: false
driver-status:
required: false
default: ""
description: >-
Configured status for this driver ("info", "skip", "required", or empty), as reported by `mage driver-decisions`.
outputs:
test-outcome:
@@ -27,6 +34,10 @@ runs:
steps:
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- name: Resolve current job id
# Resolve JOB_ID early (before the long test step) so the ci-conductor
# reporter below can link failures to this exact job. Best-effort.
uses: ./.github/actions/resolve-job-id
- name: Prepare front-end environment
if: ${{ inputs.build-static-viz == 'true' }}
uses: ./.github/actions/prepare-frontend
@@ -35,15 +46,25 @@ runs:
run: bun run build-static-viz
shell: bash
env:
MB_EDITION: ee
MB_EDITION: ${{ inputs.edition }}
- name: Test database driver
run: clojure -X:dev:ci:${{ inputs.edition }}:${{ inputs.edition }}-dev:drivers:drivers-dev:test ${{ inputs.test-args }}
shell: bash
id: run-test
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
# Driver "info" status can affect this logic. See below.
continue-on-error: true
- name: Report failed tests to ci-conductor
if: ${{ !cancelled() && steps.run-test.outcome == 'failure' }}
# This step should NEVER fail the job!
continue-on-error: true
uses: ./.github/actions/report-failures-to-ci-conductor
with:
test-suite: ${{ inputs.junit-name }}
adapter: backend
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 # v3.0.0
# As per the documentation: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#steps-context
@@ -57,6 +78,7 @@ runs:
list-suites: failed
list-tests: failed
fail-on-error: false
- name: Upload Logs on Failure
if: always() && steps.run-test.outcome != 'success'
uses: actions/upload-artifact@v7
@@ -66,3 +88,20 @@ runs:
retention-days: 1
# Failing to upload the artifact should never affect the outcome of the whole test run.
continue-on-error: true
# Last, because this is the only step allowed to fail the job: everything above it reports the
# failure (JUnit report, logs, ci-conductor) and must run regardless of the verdict below.
- name: Quarantine gate
# Off master and release branches an "info" driver is data-collection only - the test always passes!
# On master and release branches "info" carries no weight - the quarantine logic applies.
if: |
!cancelled()
&& steps.run-test.outcome == 'failure'
&& !(inputs.driver-status == 'info'
&& !(github.ref_name == 'master' || startsWith(github.ref_name, 'release-x')))
continue-on-error: ${{ inputs.quarantine-engine != 'ci-conductor' }}
uses: ./.github/actions/quarantine-gate
with:
adapter: backend
test-suite: ${{ inputs.junit-name }}
enforce-quarantine: ${{ inputs.quarantine-engine == 'ci-conductor' }}

View File

@@ -34,6 +34,10 @@ inputs:
description: >-
Optional label disambiguating matrix legs of the same job, so the info-driver
job summary and PR comment stay distinct per leg.
run-trunk:
required: false
default: "true"
description: Whether to run the Trunk step at all.
runs:
using: "composite"
@@ -60,13 +64,12 @@ runs:
aws s3 cp ${OUTPUT_FILE}.zip s3://$BUCKET/$DATE/$GITHUB_RUN_ID/$GITHUB_RUN_ATTEMPT/
- name: Upload results to Trunk
if: ${{ always() && github.repository_owner == 'metabase' && inputs.run-trunk == 'true' }}
# Important!
# 1. This step must always run because it controls job's exit code.
# 2. There's no point in running this outside the organization
# 3. For "info" drivers our own status takes precedence: we let this step pass so
# the job is reported as passing regardless of the real outcome (still uploaded).
if: always() && github.repository_owner == 'metabase'
continue-on-error: ${{ inputs.driver-status == 'info' }}
# For "info" drivers off master/release branches, our own status takes precedence: we let this
# step pass so the job is reported as passing regardless of the real outcome (still uploaded).
# On master and release branches, info status is ignored and the real outcome gates the job.
continue-on-error: ${{ inputs.driver-status == 'info' && !(github.ref_name == 'master' || startsWith(github.ref_name, 'release-x')) }}
uses: trunk-io/analytics-uploader@1198efcc0976501147b10a7e343c3fa069527526 # v2.0.9
env:
TRUNK_REPO_URL: git@github.com:metabase/metabase.git

View File

@@ -7,6 +7,10 @@ default: &default
- "locales/**"
- "bin/**/!(*.md)"
actionlint:
- ".github/workflows/*.yml"
- ".github/workflows/*.yaml"
shared_sources: &shared_sources
- "src/**/*.cljc"
- "src/**/*.cljs"
@@ -95,6 +99,12 @@ frontend_loki_infra: &frontend_loki_infra
- *shared_ci
- *frontend_loki_ci
# e2e harness/support code (commands, support file, runner). Not in the
# instrumented bundle, so it maps to no covered module — a change here forces a
# full e2e run (see create-test-plan / e2eInfraTouched).
e2e_infra: &e2e_infra
- *shared_e2e
backend_ci: &backend_ci
- *shared_ci
- ".github/actions/test-driver/**"

View File

@@ -1,32 +1,191 @@
import micromatch from "micromatch";
export type ModuleDef = { type: string; pattern: string };
export type Rule = { from: string[]; allow: string[] };
type ModuleNode = { type: string; regex: RegExp };
export type ModuleNode = { type: string; regex: RegExp };
export type FileDependency = { source: string; dependencies: string[] };
/** First match wins, so element order matters for nested patterns. */
export function buildNodes(elements: ModuleDef[]): ModuleNode[] {
return elements.map((el) => ({
type: el.type,
// dot:true so files in dot-directories (e.g. .storybook) still match.
regex: micromatch.makeRe(el.pattern, { dot: true }),
}));
}
export function mapFileToModule(
nodes: ModuleNode[],
path: string,
): string | null {
for (const node of nodes) {
if (node.regex.test(path)) {
return node.type;
}
}
return null;
}
export function getChangedModules(
nodes: ModuleNode[],
changedFiles: string[],
): Set<string> {
const direct = new Set<string>();
for (const file of changedFiles) {
const module = mapFileToModule(nodes, file);
if (module) {
direct.add(module);
}
}
return direct;
}
export type FileGraph = {
nodes: ModuleNode[];
fileDependents: Map<string, Set<string>>;
};
/** Drops unresolvable imports (e.g. ambient types) that point at no real file. */
export function parseCruiseModules(
modules: Array<{
source: string;
dependencies?: Array<{ resolved: string; couldNotResolve?: boolean }>;
}>,
): FileDependency[] {
return modules.map((module) => ({
source: module.source,
dependencies: (module.dependencies ?? [])
.filter((dep) => !dep.couldNotResolve)
.map((dep) => dep.resolved),
}));
}
/** Inverts the import edges into the `fileDependents` reverse graph. */
export function buildFileGraph(
elements: ModuleDef[],
fileDependencies: FileDependency[],
): FileGraph {
const fileDependents = new Map<string, Set<string>>();
for (const { source, dependencies } of fileDependencies) {
for (const target of dependencies) {
let importers = fileDependents.get(target);
if (!importers) {
importers = new Set();
fileDependents.set(target, importers);
}
importers.add(source);
}
}
return { nodes: buildNodes(elements), fileDependents };
}
/** Changed files plus every file that transitively imports them. */
export function getAffectedFiles(
fileGraph: FileGraph,
changedFiles: string[],
): Set<string> {
const affected = new Set(changedFiles);
const queue = [...changedFiles];
while (queue.length > 0) {
const file = queue.shift()!;
for (const importer of fileGraph.fileDependents.get(file) ?? []) {
if (!affected.has(importer)) {
affected.add(importer);
queue.push(importer);
}
}
}
return affected;
}
export type ModuleGraph = {
nodes: ModuleNode[];
/**
* dependents.get(M) is every module affected when M changes — the full
* transitive closure, so getAffectedModules only needs a single hop.
*/
dependents: Map<string, Set<string>>;
};
/** Expands a direct-dependents map into its transitive closure. */
function transitiveClosure(
direct: Map<string, Set<string>>,
): Map<string, Set<string>> {
const closure = new Map<string, Set<string>>();
for (const start of direct.keys()) {
const reached = new Set<string>();
const queue = [...(direct.get(start) ?? [])];
while (queue.length > 0) {
const node = queue.shift()!;
if (reached.has(node)) {
continue;
}
reached.add(node);
for (const next of direct.get(node) ?? []) {
queue.push(next);
}
}
reached.delete(start);
closure.set(start, reached);
}
return closure;
}
/**
* Compiles a glob pattern to an anchored RegExp.
* Builds a module graph from the actual import graph. Reachability is computed
* per module at the file level and then collapsed to modules.
*/
export function globToRegex(glob: string): RegExp {
const escapeSegment = (seg: string) =>
seg.replace(/[.+?^${}()|[\]\\]/g, "\\$&").replace(/\*/g, "[^/]*");
const body = glob.split("**").map(escapeSegment).join(".*");
return new RegExp(`^${body}$`);
export function buildUsageModuleGraph(
elements: ModuleDef[],
fileDependencies: FileDependency[],
): ModuleGraph {
const nodes = buildNodes(elements);
const fileGraph = buildFileGraph(elements, fileDependencies);
const filesByModule = new Map<string, string[]>();
const allFiles = new Set<string>();
for (const { source, dependencies } of fileDependencies) {
allFiles.add(source);
for (const target of dependencies) {
allFiles.add(target);
}
}
for (const file of allFiles) {
const module = mapFileToModule(nodes, file);
if (module) {
const files = filesByModule.get(module);
if (files) {
files.push(file);
} else {
filesByModule.set(module, [file]);
}
}
}
const dependents = new Map<string, Set<string>>(
elements.map((el) => [el.type, new Set()]),
);
for (const [module, files] of filesByModule) {
const affected = new Set<string>();
for (const file of getAffectedFiles(fileGraph, files)) {
const owner = mapFileToModule(nodes, file);
if (owner && owner !== module) {
affected.add(owner);
}
}
dependents.set(module, affected);
}
return { nodes, dependents };
}
export function buildModuleGraph(
elements: ModuleDef[],
rules: Rule[],
): ModuleGraph {
const nodes = elements.map((el) => ({
type: el.type,
regex: globToRegex(el.pattern),
}));
const nodes = buildNodes(elements);
const allTypes = elements.map((e) => e.type);
function expandPattern(pattern: string): string[] {
@@ -40,9 +199,7 @@ export function buildModuleGraph(
return allTypes.includes(pattern) ? [pattern] : [];
}
// dependents.get(M) is the set of modules that depend on M
// i.e. modules that are affected when M changes
const dependents = new Map<string, Set<string>>(
const directDependents = new Map<string, Set<string>>(
allTypes.map((type) => [type, new Set()]),
);
for (const rule of rules) {
@@ -51,46 +208,13 @@ export function buildModuleGraph(
for (const target of allowTypes) {
for (const importer of fromTypes) {
if (importer !== target) {
dependents.get(target)?.add(importer);
directDependents.get(target)?.add(importer);
}
}
}
}
return { nodes, dependents };
}
/**
* Returns the module type that owns the given file.
* First match wins, so element ordering matters for nested patterns.
*/
export function mapFileToModule(
moduleGraph: ModuleGraph,
path: string,
): string | null {
for (const el of moduleGraph.nodes) {
if (el.regex.test(path)) {
return el.type;
}
}
return null;
}
/**
* Returns the set of module types containing any of the changed files.
*/
export function getChangedModules(
moduleGraph: ModuleGraph,
changedFiles: string[],
): Set<string> {
const direct = new Set<string>();
for (const file of changedFiles) {
const module = mapFileToModule(moduleGraph, file);
if (module) {
direct.add(module);
}
}
return direct;
return { nodes, dependents: transitiveClosure(directDependents) };
}
/**
@@ -100,16 +224,10 @@ export function getAffectedModules(
moduleGraph: ModuleGraph,
changedFiles: string[],
): Set<string> {
const direct = getChangedModules(moduleGraph, changedFiles);
const affected = new Set(direct);
const queue = [...direct];
while (queue.length > 0) {
const module = queue.shift()!;
const affected = getChangedModules(moduleGraph.nodes, changedFiles);
for (const module of [...affected]) {
for (const dep of moduleGraph.dependents.get(module) ?? []) {
if (!affected.has(dep)) {
affected.add(dep);
queue.push(dep);
}
affected.add(dep);
}
}
return affected;

View File

@@ -1,8 +1,13 @@
import {
buildFileGraph,
buildModuleGraph,
buildNodes,
buildUsageModuleGraph,
getAffectedFiles,
getAffectedModules,
getChangedModules,
mapFileToModule,
parseCruiseModules,
} from "./affected-modules";
const ELEMENTS = [
@@ -31,6 +36,7 @@ const RULES = [
{ from: ["app/*"], allow: ["lib/*", "feature/*", "app/*"] },
];
const nodes = buildNodes(ELEMENTS);
const graph = buildModuleGraph(ELEMENTS, RULES);
describe("affected modules", () => {
@@ -49,19 +55,19 @@ describe("affected modules", () => {
["external/lib/foo.ts", "feature/external"],
["src/embed.tsx", "app/main"],
])("should map %s to %s", (path, expected) => {
expect(mapFileToModule(graph, path)).toBe(expected);
expect(mapFileToModule(nodes, path)).toBe(expected);
});
it("should return null for files outside any pattern", () => {
expect(mapFileToModule(graph, "docs/foo.md")).toBe(null);
expect(mapFileToModule(graph, "README.md")).toBe(null);
expect(mapFileToModule(graph, "external/notlib/foo.ts")).toBe(null);
expect(mapFileToModule(nodes, "docs/foo.md")).toBe(null);
expect(mapFileToModule(nodes, "README.md")).toBe(null);
expect(mapFileToModule(nodes, "external/notlib/foo.ts")).toBe(null);
});
});
describe("getChangedModules", () => {
it("should return the unique set of modules whose files changed", () => {
const result = getChangedModules(graph, [
const result = getChangedModules(nodes, [
"src/utils/colors.ts",
"src/foo/x.ts",
"src/foo/y.ts",
@@ -71,11 +77,81 @@ describe("affected modules", () => {
});
it("should return an empty set when no file maps to a module", () => {
expect(getChangedModules(graph, ["docs/foo.md"]).size).toBe(0);
expect(getChangedModules(nodes, ["docs/foo.md"]).size).toBe(0);
});
});
describe("getAffectedModules", () => {
describe("parseCruiseModules", () => {
it("should flatten to source + resolved-paths and drop unresolved deps", () => {
expect(
parseCruiseModules([
{
source: "src/foo/foo.tsx",
dependencies: [
{ resolved: "src/utils/colors.ts" },
{ resolved: "ambient/types", couldNotResolve: true },
],
},
{ source: "src/bar/bar.tsx" }, // no dependencies key
]),
).toEqual([
{ source: "src/foo/foo.tsx", dependencies: ["src/utils/colors.ts"] },
{ source: "src/bar/bar.tsx", dependencies: [] },
]);
});
});
const FILE_DEPS = [
{ source: "src/app.js", dependencies: ["src/foo/foo.tsx"] },
{ source: "src/bar/bar.tsx", dependencies: ["src/embed.tsx"] },
{ source: "src/foo/foo.tsx", dependencies: ["src/utils/colors.ts"] },
];
const fileGraph = buildFileGraph(ELEMENTS, FILE_DEPS);
describe("getAffectedFiles", () => {
it("should return the changed file and everything that imports it", () => {
expect(
[...getAffectedFiles(fileGraph, ["src/utils/colors.ts"])].sort(),
).toEqual(["src/app.js", "src/foo/foo.tsx", "src/utils/colors.ts"]);
});
it("should include a changed file with no importers (itself only)", () => {
// Nothing imports the app.js entry point.
expect([...getAffectedFiles(fileGraph, ["src/app.js"])]).toEqual([
"src/app.js",
]);
});
});
describe("buildUsageModuleGraph + getAffectedModules", () => {
const usageGraph = buildUsageModuleGraph(ELEMENTS, FILE_DEPS);
it("should expand a changed module to its file-level affected modules", () => {
expect(
[...getAffectedModules(usageGraph, ["src/utils/colors.ts"])].sort(),
).toEqual(["app/main", "feature/foo", "lib/utils"]);
});
it("should NOT pull in feature/bar via the app/main hub", () => {
const affected = getAffectedModules(usageGraph, ["src/foo/foo.tsx"]);
expect([...affected].sort()).toEqual(["app/main", "feature/foo"]);
expect(affected.has("feature/bar")).toBe(false);
});
it("should treat the whole changed module as changed", () => {
// app.js itself has no importers, but app/main also owns embed.tsx, which
// feature/bar imports so changing any app/main file flags feature/bar.
expect(
[...getAffectedModules(usageGraph, ["src/app.js"])].sort(),
).toEqual(["app/main", "feature/bar"]);
});
it("should return empty when no file maps to a module", () => {
expect(getAffectedModules(usageGraph, ["docs/foo.md"]).size).toBe(0);
});
});
describe("getAffectedModules (rules graph)", () => {
it("should affect feature/super and app/main but not feature/bar when feature/foo changes", () => {
const result = getAffectedModules(graph, ["src/foo/x.ts"]);
expect([...result].sort()).toEqual([

View File

@@ -1,36 +1,40 @@
// Per-suite affected-tests logic: combines module-affected closure with
// per-suite "infra-touched" booleans (computed by dorny/paths-filter against
// the `frontend_unit_infra` / `frontend_loki_infra` anchors in file-paths.yaml).
// When infra files change, the whole suite runs in full.
// Builds the affected-tests plan from raw inputs: computes the rules and usage
// affected-module sets and selects, per suite, which specs to run under each.
import { getFeatureModules } from "../../frontend/lint/module-boundaries.mjs";
import {
type FileDependency,
type ModuleDef,
type ModuleGraph,
type ModuleNode,
type Rule,
buildModuleGraph,
buildUsageModuleGraph,
getAffectedModules,
getChangedModules,
mapFileToModule,
} from "./affected-modules";
export type TestSuiteDef = {
statsPrefix: string;
runAllTests?: boolean;
};
export type TestPlanStats = {
modules_changed: number;
modules_affected: number;
modules_affected_list: string[];
fe_unit_specs_total: number;
fe_unit_specs_run: number;
fe_unit_specs_skipped: number;
loki_stories_total: number;
loki_stories_run: number;
loki_stories_skipped: number;
e2e_specs_total: number;
e2e_specs_run: number;
e2e_specs_skipped: number;
fe_files_changed: number;
fe_files_total: number;
be_files_changed: number;
be_files_total: number;
unit_infra_touched: boolean;
loki_infra_touched: boolean;
shared_sources_touched: boolean;
fe_modules_total: number;
fe_modules_changed: number;
fe_modules_affected_rules: number;
fe_modules_affected_usage: number;
unit_specs_all: number;
unit_specs_to_run_rules: number;
unit_specs_to_run_usage: number;
loki_stories_all: number;
loki_stories_to_run_rules: number;
loki_stories_to_run_usage: number;
e2e_specs_all: number;
e2e_specs_to_run_rules: number;
e2e_specs_to_run_usage: number;
};
export type TestPlan = {
@@ -40,101 +44,187 @@ export type TestPlan = {
e2e_specs_to_run: string[];
};
export const TEST_SUITES = {
unit: {
statsPrefix: "fe_unit_specs",
},
loki: {
statsPrefix: "loki_stories",
},
e2e: {
statsPrefix: "e2e_specs",
// We don't map changed files to e2e tests yet, so for now just run them all
runAllTests: true,
},
} satisfies Record<string, TestSuiteDef>;
export function createTestPlan({
elements,
rules,
testSuites,
changedFiles,
testFilesBySuite,
infraTouchedBySuite,
}: {
export type CreateTestPlanInput = {
elements: ModuleDef[];
rules: Rule[];
testSuites: Record<string, TestSuiteDef>;
changedFiles: string[];
testFilesBySuite: Record<string, string[]>;
infraTouchedBySuite: Record<string, boolean>;
}): TestPlan {
const moduleGraph = buildModuleGraph(elements, rules);
// Parsed dependency-cruiser edges, or null to fall back to the rules graph.
fileDependencies: FileDependency[] | null;
testFilesBySuite: { unit: string[]; loki: string[]; e2e: string[] };
e2eSpecFiles: Record<string, string[]> | null;
unitInfraTouched: boolean;
lokiInfraTouched: boolean;
e2eInfraTouched: boolean;
sharedSourcesTouched: boolean;
feFilesChanged: number;
beFilesChanged: number;
feFilesTotal: number;
beFilesTotal: number;
};
const changedModules = getChangedModules(moduleGraph, changedFiles);
const modulesAffected = getAffectedModules(moduleGraph, changedFiles);
const modulesAffectedList = [...modulesAffected].sort();
const specsToRun: Record<string, string[]> = {};
const stats: Record<string, number | string[]> = {
modules_changed: changedModules.size,
modules_affected: modulesAffected.size,
modules_affected_list: modulesAffectedList,
};
for (const [name, testSuite] of Object.entries(testSuites)) {
const files = testFilesBySuite[name] ?? [];
const tests = createTestPlanForSuite(
moduleGraph,
testSuite,
infraTouchedBySuite[name] ?? false,
changedFiles,
files,
);
specsToRun[name] = tests;
stats[`${testSuite.statsPrefix}_total`] = files.length;
stats[`${testSuite.statsPrefix}_run`] = tests.length;
stats[`${testSuite.statsPrefix}_skipped`] = files.length - tests.length;
}
return {
stats: stats as TestPlanStats,
fe_unit_specs_to_run: specsToRun.unit ?? [],
loki_stories_to_run: specsToRun.loki ?? [],
e2e_specs_to_run: specsToRun.e2e ?? [],
};
}
/**
* Computes the test plan for one test suite
*
* Runs the full suite when `runAllTests` is set or `infraTouched` is true,
* otherwise runs the tests based on affected-modules.
*/
export function createTestPlanForSuite(
moduleGraph: ModuleGraph,
testSuite: TestSuiteDef,
infraTouched: boolean,
changedFiles: string[],
allTestFiles: string[],
): string[] {
if (testSuite.runAllTests || infraTouched) {
return allTestFiles;
}
const affected = getAffectedModules(moduleGraph, changedFiles);
return filterAffectedTests(moduleGraph, affected, allTestFiles);
}
/**
* Filters the test-file list down to tests whose owning module is affected.
*/
// Tests whose owning module is affected.
export function filterAffectedTests(
moduleGraph: ModuleGraph,
nodes: ModuleNode[],
affected: Set<string>,
testFiles: string[],
): string[] {
return testFiles.filter((file) => {
const module = mapFileToModule(moduleGraph, file);
const module = mapFileToModule(nodes, file);
return module !== null && affected.has(module);
});
}
// Collapse each spec's covered files to the *feature* modules it exercises,
// once, for reuse across the rules/usage selects. Non-feature tiers
// (shared/lib/...) are intentionally dropped: the manifest is a stale nightly
// artifact, so its coupling to the module graph stays minimal ("does this spec
// touch feature X?"). Accuracy comes from the fresh `affected` set, which
// already expands a shared/infra change into the feature modules that depend on
// it.
export function specFeatureModules(
nodes: ModuleNode[],
featureModules: Set<string>,
specFiles: Record<string, string[]>,
): Map<string, Set<string>> {
const moduleCache = new Map<string, string | null>();
const moduleOf = (file: string): string | null => {
let module = moduleCache.get(file);
if (module === undefined) {
module = mapFileToModule(nodes, file);
moduleCache.set(file, module);
}
return module;
};
const result = new Map<string, Set<string>>();
for (const [spec, files] of Object.entries(specFiles)) {
const features = new Set<string>();
for (const file of files) {
const module = moduleOf(file);
if (module !== null && featureModules.has(module)) {
features.add(module);
}
}
result.set(spec, features);
}
return result;
}
// A spec runs if any feature module it covers is affected.
// A spec doesn't map to any feature module always runs because its scope is unknown
export function filterAffectedE2eSpecs(
specFeatures: Map<string, Set<string>>,
affected: Set<string>,
e2eSpecs: string[],
): string[] {
return e2eSpecs.filter((spec) => {
const features = specFeatures.get(spec);
if (!features || features.size === 0) {
return true;
}
return [...features].some((module) => affected.has(module));
});
}
export function createTestPlan({
elements,
rules,
changedFiles,
fileDependencies,
testFilesBySuite,
e2eSpecFiles,
unitInfraTouched,
lokiInfraTouched,
e2eInfraTouched,
sharedSourcesTouched,
feFilesChanged,
beFilesChanged,
feFilesTotal,
beFilesTotal,
}: CreateTestPlanInput): TestPlan {
const rulesGraph = buildModuleGraph(elements, rules);
const usageGraph = fileDependencies
? buildUsageModuleGraph(elements, fileDependencies)
: rulesGraph;
const nodes = rulesGraph.nodes;
// Distinct module types (an element type can span several patterns).
const totalModules = new Set(elements.map((el) => el.type)).size;
const changedModules = getChangedModules(nodes, changedFiles);
const rulesAffected = getAffectedModules(rulesGraph, changedFiles);
const usageAffected = getAffectedModules(usageGraph, changedFiles);
// The coarse "feature" tier is the only set the e2e manifest is ever
// collapsed to (see filterAffectedE2eSpecs).
const featureModules = new Set(getFeatureModules(elements));
// cljc/cljs compile into the FE bundle, so they force a full run that module
// selection can't narrow — same effect as a suite's own infra changing.
const unitForceAll = unitInfraTouched || sharedSourcesTouched;
const lokiForceAll = lokiInfraTouched || sharedSourcesTouched;
// e2e is integration-level, so anything the FE-coverage manifest can't see
// forces a full run: cljc/cljs in the bundle (sharedSourcesTouched), a backend
// change that can break the UI (beFilesChanged), an e2e harness/support change
// (e2eInfraTouched), or no manifest at all.
const e2eForceAll =
sharedSourcesTouched ||
e2eInfraTouched ||
beFilesChanged > 0 ||
e2eSpecFiles === null;
const select = (forceAll: boolean, affected: Set<string>, files: string[]) =>
forceAll ? files : filterAffectedTests(nodes, affected, files);
const { unit, loki, e2e } = testFilesBySuite;
const unitRules = select(unitForceAll, rulesAffected, unit);
const unitUsage = select(unitForceAll, usageAffected, unit);
const lokiRules = select(lokiForceAll, rulesAffected, loki);
const lokiUsage = select(lokiForceAll, usageAffected, loki);
// Precompute spec -> feature modules once (null when e2e runs in full).
const specFeatures =
e2eForceAll || e2eSpecFiles === null
? null
: specFeatureModules(nodes, featureModules, e2eSpecFiles);
// A spec that was itself edited always runs, even when no app module changed.
const changedSet = new Set(changedFiles);
const selectE2e = (affected: Set<string>): string[] => {
if (specFeatures === null) {
return e2e;
}
const narrowed = new Set(
filterAffectedE2eSpecs(specFeatures, affected, e2e),
);
return e2e.filter((spec) => narrowed.has(spec) || changedSet.has(spec));
};
const e2eRules = selectE2e(rulesAffected);
const e2eUsage = selectE2e(usageAffected);
return {
stats: {
fe_files_changed: feFilesChanged,
fe_files_total: feFilesTotal,
be_files_changed: beFilesChanged,
be_files_total: beFilesTotal,
unit_infra_touched: unitInfraTouched,
loki_infra_touched: lokiInfraTouched,
shared_sources_touched: sharedSourcesTouched,
fe_modules_total: totalModules,
fe_modules_changed: changedModules.size,
fe_modules_affected_rules: rulesAffected.size,
fe_modules_affected_usage: usageAffected.size,
unit_specs_all: unit.length,
unit_specs_to_run_rules: unitRules.length,
unit_specs_to_run_usage: unitUsage.length,
loki_stories_all: loki.length,
loki_stories_to_run_rules: lokiRules.length,
loki_stories_to_run_usage: lokiUsage.length,
e2e_specs_all: e2e.length,
e2e_specs_to_run_rules: e2eRules.length,
e2e_specs_to_run_usage: e2eUsage.length,
},
fe_unit_specs_to_run: unitUsage,
loki_stories_to_run: lokiUsage,
e2e_specs_to_run: e2eUsage,
};
}

View File

@@ -1,9 +1,5 @@
import { buildModuleGraph } from "./affected-modules";
import {
createTestPlan,
createTestPlanForSuite,
filterAffectedTests,
} from "./affected-tests";
import { buildNodes } from "./affected-modules";
import { createTestPlan, filterAffectedTests } from "./affected-tests";
const ELEMENTS = [
{ type: "lib/utils", pattern: "src/utils/**" },
@@ -18,12 +14,6 @@ const RULES = [
{ from: ["feature/*"], allow: ["lib/*"] },
];
const TEST_SUITE_DEFS = {
unit: { statsPrefix: "fe_unit_specs" },
loki: { statsPrefix: "loki_stories" },
e2e: { statsPrefix: "e2e_specs", runAllTests: true },
};
const UNIT_FILES = [
"src/foo/foo.unit.spec.ts",
"src/foo/bar.unit.spec.ts",
@@ -33,158 +23,227 @@ const UNIT_FILES = [
const LOKI_FILES = ["src/foo/Foo.stories.tsx", "src/bar/Bar.stories.tsx"];
const E2E_FILES = ["e2e/test/scenarios/a.cy.spec.ts"];
const moduleGraph = buildModuleGraph(ELEMENTS, RULES);
const baseInput = {
elements: ELEMENTS,
rules: RULES,
fileDependencies: null,
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e: E2E_FILES },
e2eSpecFiles: null,
unitInfraTouched: false,
lokiInfraTouched: false,
e2eInfraTouched: false,
sharedSourcesTouched: false,
feFilesChanged: 0,
beFilesChanged: 0,
feFilesTotal: 0,
beFilesTotal: 0,
};
describe("affected tests", () => {
describe("createTestPlanForSuite", () => {
it("should run all tests when infra is touched", () => {
const result = createTestPlanForSuite(
moduleGraph,
TEST_SUITE_DEFS.unit,
true, // infraTouched
["src/foo/x.ts"],
UNIT_FILES,
);
expect(result).toEqual(UNIT_FILES);
});
describe("createTestPlan", () => {
it("runs only specs in affected modules (rules graph)", () => {
const plan = createTestPlan({ ...baseInput, changedFiles: ["src/foo/x.ts"] });
it("should fall back to affected-tests filtering when infra not touched", () => {
const result = createTestPlanForSuite(
moduleGraph,
TEST_SUITE_DEFS.unit,
false, // infraTouched
["src/foo/x.ts"],
UNIT_FILES,
);
expect(result.sort()).toEqual([
"src/foo/bar.unit.spec.ts",
"src/foo/foo.unit.spec.ts",
]);
});
it("should return nothing when infra not touched and no file maps to a module", () => {
const result = createTestPlanForSuite(
moduleGraph,
TEST_SUITE_DEFS.unit,
false,
["docs/foo.md"],
UNIT_FILES,
);
expect(result).toEqual([]);
});
it("should run all tests for runAllTests suites regardless of inputs", () => {
expect(
createTestPlanForSuite(
moduleGraph,
TEST_SUITE_DEFS.e2e,
false,
["docs/foo.md"],
E2E_FILES,
),
).toEqual(E2E_FILES);
expect(
createTestPlanForSuite(
moduleGraph,
TEST_SUITE_DEFS.e2e,
false,
["src/foo/x.ts"],
E2E_FILES,
),
).toEqual(E2E_FILES);
});
expect(plan.stats.fe_modules_changed).toBe(1);
expect(plan.stats.fe_modules_affected_rules).toBe(1);
expect(plan.fe_unit_specs_to_run.sort()).toEqual([
"src/foo/bar.unit.spec.ts",
"src/foo/foo.unit.spec.ts",
]);
expect(plan.stats.unit_specs_to_run_rules).toBe(2);
expect(plan.stats.loki_stories_to_run_rules).toBe(1);
// With no file deps, usage falls back to rules.
expect(plan.stats.unit_specs_to_run_usage).toBe(2);
});
describe("createTestPlan", () => {
it("should return run lists and stats together", () => {
const result = createTestPlan({
elements: ELEMENTS,
rules: RULES,
testSuites: TEST_SUITE_DEFS,
changedFiles: ["src/foo/x.ts"],
testFilesBySuite: {
unit: UNIT_FILES,
loki: LOKI_FILES,
e2e: E2E_FILES,
},
infraTouchedBySuite: { unit: false, loki: false, e2e: false },
});
expect(result.fe_unit_specs_to_run.sort()).toEqual([
"src/foo/bar.unit.spec.ts",
"src/foo/foo.unit.spec.ts",
]);
expect(result.loki_stories_to_run).toEqual(["src/foo/Foo.stories.tsx"]);
expect(result.e2e_specs_to_run).toEqual(E2E_FILES);
expect(result.stats).toEqual({
modules_changed: 1,
modules_affected: 1,
modules_affected_list: ["feature/foo"],
fe_unit_specs_total: 4,
fe_unit_specs_run: 2,
fe_unit_specs_skipped: 2,
loki_stories_total: 2,
loki_stories_run: 1,
loki_stories_skipped: 1,
e2e_specs_total: 1,
e2e_specs_run: 1,
e2e_specs_skipped: 0,
});
it("narrows further with the usage graph than the rules graph", () => {
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/utils/colors.ts"],
// Only feature/foo actually imports lib/utils.
fileDependencies: [
{ source: "src/foo/foo.tsx", dependencies: ["src/utils/colors.ts"] },
],
});
it("should run all unit specs when unit infra is touched", () => {
const result = createTestPlan({
elements: ELEMENTS,
rules: RULES,
testSuites: TEST_SUITE_DEFS,
changedFiles: ["docs/foo.md"],
testFilesBySuite: {
unit: UNIT_FILES,
loki: LOKI_FILES,
e2e: E2E_FILES,
},
infraTouchedBySuite: { unit: true, loki: false, e2e: false },
});
expect(result.stats.fe_unit_specs_run).toBe(UNIT_FILES.length);
expect(result.stats.fe_unit_specs_skipped).toBe(0);
// Only the unit suite was triggered.
expect(result.stats.loki_stories_run).toBe(0);
});
it("should not run anything when no infra is touched and no modules affected", () => {
const result = createTestPlan({
elements: ELEMENTS,
rules: RULES,
testSuites: TEST_SUITE_DEFS,
changedFiles: ["docs/foo.md"],
testFilesBySuite: {
unit: UNIT_FILES,
loki: LOKI_FILES,
e2e: E2E_FILES,
},
infraTouchedBySuite: { unit: false, loki: false, e2e: false },
});
expect(result.stats.fe_unit_specs_run).toBe(0);
expect(result.stats.loki_stories_run).toBe(0);
// e2e is runAllTests, so it still reports run = total.
expect(result.stats.e2e_specs_run).toBe(E2E_FILES.length);
});
// Rules allow both features to import lib/utils, so both are "affected".
expect(plan.stats.fe_modules_affected_rules).toBe(3);
// Usage sees only feature/foo + lib/utils.
expect(plan.stats.fe_modules_affected_usage).toBe(2);
expect(plan.stats.unit_specs_to_run_rules).toBe(4);
expect(plan.stats.unit_specs_to_run_usage).toBe(3);
});
describe("filterAffectedTests", () => {
it("should keep only tests inside affected modules", () => {
const affected = new Set(["feature/foo", "lib/utils"]);
const tests = [
"src/foo/foo.unit.spec.ts",
"src/utils/colors.unit.spec.ts",
"src/bar/bar.unit.spec.ts",
"docs/unrelated.unit.spec.ts",
];
expect(filterAffectedTests(moduleGraph, affected, tests)).toEqual([
"src/foo/foo.unit.spec.ts",
"src/utils/colors.unit.spec.ts",
]);
it("forces a full FE run on a shared-sources (cljc) change with no affected modules", () => {
const plan = createTestPlan({
...baseInput,
changedFiles: ["docs/readme.md"],
sharedSourcesTouched: true,
});
expect(plan.stats.fe_modules_affected_rules).toBe(0);
expect(plan.stats.unit_specs_to_run_rules).toBe(UNIT_FILES.length);
expect(plan.stats.unit_specs_to_run_usage).toBe(UNIT_FILES.length);
expect(plan.stats.loki_stories_to_run_rules).toBe(LOKI_FILES.length);
});
it("forces only the suite whose infra changed", () => {
const plan = createTestPlan({
...baseInput,
changedFiles: ["docs/readme.md"],
unitInfraTouched: true,
});
expect(plan.stats.unit_specs_to_run_rules).toBe(UNIT_FILES.length);
expect(plan.stats.loki_stories_to_run_rules).toBe(0);
});
it("runs the full e2e suite when no coverage manifest is available", () => {
const plan = createTestPlan({ ...baseInput, changedFiles: ["src/foo/x.ts"] });
expect(plan.stats.e2e_specs_to_run_rules).toBe(E2E_FILES.length);
expect(plan.stats.e2e_specs_to_run_usage).toBe(E2E_FILES.length);
expect(plan.e2e_specs_to_run).toEqual(E2E_FILES);
});
it("narrows e2e to specs covering affected feature modules", () => {
const e2e = [
"e2e/test/scenarios/foo.cy.spec.ts",
"e2e/test/scenarios/bar.cy.spec.ts",
"e2e/test/scenarios/new.cy.spec.ts",
];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/foo/x.ts"], // affects feature/foo only
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: {
"e2e/test/scenarios/foo.cy.spec.ts": ["src/foo/a.ts"], // feature/foo
"e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"], // feature/bar
// new.cy.spec.ts intentionally absent from the manifest
},
});
// foo's feature module is affected; bar's is not; the unmapped new spec
// always runs.
expect(plan.e2e_specs_to_run.sort()).toEqual([
"e2e/test/scenarios/foo.cy.spec.ts",
"e2e/test/scenarios/new.cy.spec.ts",
]);
expect(plan.stats.e2e_specs_all).toBe(3);
});
it("runs a spec that maps to no feature module (unknown scope)", () => {
const e2e = ["e2e/test/scenarios/lib-only.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/foo/x.ts"], // affects feature/foo, NOT lib/utils
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: {
// Covers only a non-feature module (e.g. a home/auth spec whose feature
// the baseline subtracted), so its feature scope is unknown.
"e2e/test/scenarios/lib-only.cy.spec.ts": ["src/utils/colors.ts"],
},
});
// No feature module to gate on -> can't bound scope -> always runs.
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("force-runs all e2e on a backend change (invisible to FE coverage)", () => {
const e2e = ["e2e/test/scenarios/foo.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/metabase/api/card.clj"],
beFilesChanged: 1,
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: { "e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"] },
});
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("force-runs all e2e when e2e infra (support/runner) changes", () => {
const e2e = ["e2e/test/scenarios/foo.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["e2e/support/commands/api/createQuestion.js"],
e2eInfraTouched: true,
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: { "e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"] },
});
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("runs an edited spec even when no app module changed", () => {
const spec = "e2e/test/scenarios/foo.cy.spec.ts";
const e2e = [spec, "e2e/test/scenarios/bar.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: [spec], // only the spec itself changed
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: {
[spec]: ["src/bar/b.ts"], // covers feature/bar, which is NOT affected
"e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"],
},
});
// No module is affected, but the edited spec must still run.
expect(plan.e2e_specs_to_run).toEqual([spec]);
});
it("runs a spec whose coverage was fully baseline-subtracted (empty files)", () => {
const e2e = ["e2e/test/scenarios/empty.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/foo/x.ts"], // affects feature/foo
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: { "e2e/test/scenarios/empty.cy.spec.ts": [] },
});
// Empty coverage means unknown scope, so the spec runs.
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("forces a full e2e run when shared (cljc) sources change", () => {
const e2e = ["e2e/test/scenarios/foo.cy.spec.ts"];
const plan = createTestPlan({
...baseInput,
changedFiles: ["src/foo/x.ts"],
sharedSourcesTouched: true,
testFilesBySuite: { unit: UNIT_FILES, loki: LOKI_FILES, e2e },
e2eSpecFiles: { "e2e/test/scenarios/bar.cy.spec.ts": ["src/bar/b.ts"] },
});
// Manifest is present but cljc is invisible to JS coverage, so run all.
expect(plan.e2e_specs_to_run).toEqual(e2e);
});
it("passes the FE/BE file counts through to stats", () => {
const plan = createTestPlan({
...baseInput,
changedFiles: [],
feFilesChanged: 5,
beFilesChanged: 3,
});
expect(plan.stats.fe_files_changed).toBe(5);
expect(plan.stats.be_files_changed).toBe(3);
});
});
describe("filterAffectedTests", () => {
it("keeps only tests inside affected modules", () => {
const nodes = buildNodes(ELEMENTS);
const affected = new Set(["feature/foo", "lib/utils"]);
const tests = [
"src/foo/foo.unit.spec.ts",
"src/utils/colors.unit.spec.ts",
"src/bar/bar.unit.spec.ts",
"docs/unrelated.unit.spec.ts",
];
expect(filterAffectedTests(nodes, affected, tests)).toEqual([
"src/foo/foo.unit.spec.ts",
"src/utils/colors.unit.spec.ts",
]);
});
});

View File

@@ -0,0 +1,152 @@
/* eslint-disable import/no-commonjs */
// Prepares the rows the bundle-size stats logger uploads to stats.metabase.com.
//
// For each measured (bundle, kind) it computes the delta — raw, gzipped and
// brotli (as-served) bytes plus percent — against the previously *plotted* data
// point (restored from a rolling cache), so the deltas can be charted directly.
// It also decides whether this commit is worth recording at all: a point is kept
// when the as-served size moved by at least MIN_DELTA_PERCENT, or when a new
// bundle/kind appears. Only master builds run through here — releases form
// non-linear lines whose deltas are meaningless, so they're not recorded (their
// historical sizes are backfilled separately).
//
// buildStatsRows is pure (data in, data out) so it can be unit-tested; main()
// is the thin I/O wrapper that reads env/files and writes the rows, cache and
// step outputs.
const fs = require("fs");
const path = require("path");
const deltaPercent = (current, base) =>
base ? Math.round(((current - base) * 10000) / base) / 100 : "";
/**
* Turn the current measurements + the last plotted point into upload rows, the
* slim cache rows for the next diff, and the keep/skip decision.
*
* The significance threshold tracks the as-served size: brotli where the build
* ships a precompressed .br, otherwise gzip. Current measurements always carry
* brotliBytes (estimated when no .br shipped), but a cached base point recorded
* before brotli logging may not, so the delta still falls back to gzip per row.
*/
function buildStatsRows({ measurements, previous, threshold, date, commit, commitMessage, version }) {
const previousOf = (bundle, kind) => previous.find(row => row.bundle === bundle && row.kind === kind);
let maxServedDeltaPercent = 0;
let hasNewSeries = false;
const rows = measurements.map(measurement => {
const base = previousOf(measurement.bundle, measurement.kind);
const hasBrotli = measurement.brotliBytes != null && base?.brotliBytes != null;
const gzipDeltaPercent = deltaPercent(measurement.gzipBytes, base?.gzipBytes);
const brotliDeltaPercent = hasBrotli ? deltaPercent(measurement.brotliBytes, base.brotliBytes) : "";
if (!base) {
hasNewSeries = true;
} else {
const servedDeltaPercent = hasBrotli ? brotliDeltaPercent : gzipDeltaPercent;
maxServedDeltaPercent = Math.max(maxServedDeltaPercent, Math.abs(servedDeltaPercent));
}
return {
"Date": date,
"Version": version,
"Commit": commit,
"Bundle": measurement.bundle,
"Kind": measurement.kind, // "initial" or "total"
// The stats table carries a free-text Description column; append-csv
// requires every table column to be present. Populate it with the commit
// subject so the chart's points are self-describing.
"Description": commitMessage,
"Raw bytes": measurement.rawBytes,
"Gzip bytes": measurement.gzipBytes,
"Brotli bytes": measurement.brotliBytes, // as-served (shipped .br, else estimated)
"File count": measurement.fileCount,
"Raw bytes delta": base ? measurement.rawBytes - base.rawBytes : "",
"Gzip bytes delta": base ? measurement.gzipBytes - base.gzipBytes : "",
"Brotli bytes delta": hasBrotli ? measurement.brotliBytes - base.brotliBytes : "",
"Raw delta %": deltaPercent(measurement.rawBytes, base?.rawBytes),
"Gzip delta %": gzipDeltaPercent,
"Brotli delta %": brotliDeltaPercent,
};
});
const firstPoint = previous.length === 0;
const significant = firstPoint || hasNewSeries || maxServedDeltaPercent >= threshold;
// Slim rows the next run diffs against. The workflow only persists this to the
// cache when we actually push, so the cached reference always stays the last
// *plotted* point (cumulative drift is caught).
const cacheRows = measurements.map(({ bundle, kind, rawBytes, gzipBytes, brotliBytes }) => ({
bundle,
kind,
rawBytes,
gzipBytes,
brotliBytes,
}));
const reason = firstPoint
? "first point"
: hasNewSeries
? "new bundle/kind series"
: `max served Δ ${maxServedDeltaPercent.toFixed(2)}% (threshold ${threshold}%)`;
return { rows, cacheRows, significant, reason, maxServedDeltaPercent, firstPoint, hasNewSeries };
}
module.exports = { buildStatsRows };
const readJson = filePath => (filePath && fs.existsSync(filePath) ? JSON.parse(fs.readFileSync(filePath, "utf8")) : null);
const writeJson = (filePath, value) => {
fs.mkdirSync(path.dirname(filePath), { recursive: true });
fs.writeFileSync(filePath, JSON.stringify(value));
};
const setOutput = (env, name, value) => {
if (env.GITHUB_OUTPUT) {
fs.appendFileSync(env.GITHUB_OUTPUT, `${name}=${value}\n`);
}
};
// version.properties (extracted from the uberjar) carries the build's tag.
// Non-release (master) builds report tag=vUNKNOWN, so leave Version empty there.
function readVersion(versionPropsPath) {
const raw =
versionPropsPath && fs.existsSync(versionPropsPath)
? (fs.readFileSync(versionPropsPath, "utf8").match(/^tag=(.*)$/m)?.[1]?.trim() ?? "")
: "";
return raw === "vUNKNOWN" ? "" : raw;
}
function main() {
const env = process.env;
const measurements = readJson(env.CURRENT);
if (!Array.isArray(measurements) || measurements.length === 0) {
console.error(`::error::No bundle measurements found at ${env.CURRENT}`);
process.exit(1);
}
const result = buildStatsRows({
measurements,
// The last plotted point, as slim rows: [{ bundle, kind, rawBytes, gzipBytes, brotliBytes }].
previous: readJson(env.LAST) || [],
threshold: Number(env.MIN_DELTA_PERCENT ?? 1),
date: new Date().toISOString().slice(0, 10), // YYYY-MM-DD
commit: (env.HEAD_SHA || "").slice(0, 12),
commitMessage: (env.COMMIT_MESSAGE || "").split("\n")[0], // subject line only
version: readVersion(env.VERSION_PROPS),
});
writeJson(env.ROWS_OUT, result.rows);
writeJson(env.CACHE_OUT, result.cacheRows);
console.log(`${result.significant ? "RECORD" : "SKIP"} — ${result.reason}`);
setOutput(env, "significant", result.significant ? "true" : "false");
setOutput(
env,
"max_delta_percent",
result.firstPoint || result.hasNewSeries ? "" : result.maxServedDeltaPercent.toFixed(2),
);
}
if (require.main === module) {
main();
}

View File

@@ -0,0 +1,87 @@
const { buildStatsRows } = require("./bundle-size-stats-prepare");
const meta = { date: "2026-06-30", commit: "abc123", commitMessage: "Fix the thing (#123)", version: "" };
const measurement = (over = {}) => ({
bundle: "embedding-sdk-chunked",
kind: "total",
rawBytes: 1000,
gzipBytes: 400,
brotliBytes: 300,
fileCount: 3,
...over,
});
describe("buildStatsRows", () => {
it("records the first point and leaves every delta empty", () => {
const result = buildStatsRows({
...meta,
measurements: [measurement()],
previous: [],
threshold: 1,
});
expect(result.firstPoint).toBe(true);
expect(result.significant).toBe(true);
expect(result.reason).toBe("first point");
expect(result.rows[0]["Gzip bytes delta"]).toBe("");
expect(result.rows[0]["Brotli delta %"]).toBe("");
expect(result.rows[0]["Description"]).toBe("Fix the thing (#123)");
expect(result.cacheRows[0]).toEqual({
bundle: "embedding-sdk-chunked",
kind: "total",
rawBytes: 1000,
gzipBytes: 400,
brotliBytes: 300,
});
});
it("records a never-seen bundle/kind as a new series", () => {
const result = buildStatsRows({
...meta,
measurements: [measurement({ bundle: "app", kind: "initial" })],
previous: [{ bundle: "app", kind: "total", rawBytes: 1, gzipBytes: 1, brotliBytes: 1 }],
threshold: 99,
});
expect(result.hasNewSeries).toBe(true);
expect(result.significant).toBe(true);
expect(result.reason).toBe("new bundle/kind series");
});
it("gates significance on the brotli (as-served) delta when both sides have it", () => {
const previous = [{ bundle: "embedding-sdk-chunked", kind: "total", rawBytes: 1000, gzipBytes: 400, brotliBytes: 300 }];
const big = buildStatsRows({
...meta,
measurements: [measurement({ brotliBytes: 315, gzipBytes: 400 })], // brotli +5%, gzip 0%
previous,
threshold: 1,
});
expect(big.maxServedDeltaPercent).toBeCloseTo(5);
expect(big.significant).toBe(true);
expect(big.rows[0]["Brotli delta %"]).toBeCloseTo(5);
const small = buildStatsRows({
...meta,
measurements: [measurement({ brotliBytes: 301, gzipBytes: 999 })], // brotli +0.33%, gzip ignored
previous,
threshold: 1,
});
expect(small.significant).toBe(false);
expect(small.reason).toContain("threshold 1%");
});
it("falls back to the gzip delta when the cached base predates brotli logging", () => {
const result = buildStatsRows({
...meta,
measurements: [measurement({ gzipBytes: 440, brotliBytes: 300 })], // gzip +10%
previous: [{ bundle: "embedding-sdk-chunked", kind: "total", rawBytes: 1000, gzipBytes: 400 }],
threshold: 1,
});
expect(result.maxServedDeltaPercent).toBeCloseTo(10);
expect(result.significant).toBe(true);
expect(result.rows[0]["Brotli bytes delta"]).toBe(""); // no base brotli to diff against
expect(result.rows[0]["Gzip delta %"]).toBeCloseTo(10);
});
});

View File

@@ -1,67 +1,112 @@
// Changed files come from dorny/paths-filter's `all_changed_files` output
// I/O entrypoint: gather inputs (env vars, the cruise graph, the test-file
// lists) and hand them to createTestPlan, which does the computing.
import { execFileSync } from "node:child_process";
import { existsSync, readFileSync } from "node:fs";
import micromatch from "micromatch";
import { elements, rules } from "../../frontend/lint/module-boundaries.mjs";
import { TEST_SUITES, createTestPlan } from "./affected-tests";
import { type FileDependency, parseCruiseModules } from "./affected-modules";
import { createTestPlan } from "./affected-tests";
import { listSpecFiles } from "./e2e-spec-globs.mjs";
const UNIT_ROOTS = ["frontend/src", "enterprise/frontend/src"];
const UNIT_GLOBS = [
"frontend/src/**/*.unit.spec.js",
"frontend/src/**/*.unit.spec.jsx",
"frontend/src/**/*.unit.spec.ts",
"frontend/src/**/*.unit.spec.tsx",
"enterprise/frontend/src/**/*.unit.spec.js",
"enterprise/frontend/src/**/*.unit.spec.jsx",
"enterprise/frontend/src/**/*.unit.spec.ts",
"enterprise/frontend/src/**/*.unit.spec.tsx",
"frontend/src/**/*.unit.spec.{js,jsx,ts,tsx}",
"enterprise/frontend/src/**/*.unit.spec.{js,jsx,ts,tsx}",
];
const STORY_ROOTS = ["frontend", "enterprise/frontend"];
const STORY_GLOBS = [
"frontend/**/*.stories.js",
"frontend/**/*.stories.jsx",
"frontend/**/*.stories.ts",
"frontend/**/*.stories.tsx",
"enterprise/frontend/**/*.stories.js",
"enterprise/frontend/**/*.stories.jsx",
"enterprise/frontend/**/*.stories.ts",
"enterprise/frontend/**/*.stories.tsx",
"frontend/**/*.stories.{js,jsx,ts,tsx}",
"enterprise/frontend/**/*.stories.{js,jsx,ts,tsx}",
];
const E2E_GLOBS = [
"e2e/test/scenarios/**/*.cy.spec.js",
"e2e/test/scenarios/**/*.cy.spec.jsx",
"e2e/test/scenarios/**/*.cy.spec.ts",
"e2e/test/scenarios/**/*.cy.spec.tsx",
];
function listFiles(globs: string[]): string[] {
return execFileSync("git", ["ls-files", "--", ...globs], { encoding: "utf8" })
// Returns the tracked files under `roots` that match `globs`. The `dot: true`
// option means files inside dot-directories such as `.storybook` are included.
function listFiles(roots: string[], globs: string[]): string[] {
const tracked = execFileSync("git", ["ls-files", "--", ...roots], {
encoding: "utf8",
})
.split("\n")
.map((line) => line.trim())
.filter(Boolean);
return micromatch(tracked, globs, { dot: true });
}
const changedFiles = (process.env.CHANGED_FILES ?? "")
.split(",")
.map((s) => s.trim())
.filter(Boolean);
// dorny outputs comma-separated lists; CHANGED_FILES is `all_changed_files`.
const csvToList = (csv: string | undefined) =>
(csv ?? "")
.split(",")
.map((s) => s.trim())
.filter(Boolean);
// Reads the dependency-cruiser graph (DEP_GRAPH_JSON). Null falls back to the
// rules graph, so a missing or unparseable file never breaks the plan.
function readFileDependencies(): FileDependency[] | null {
const path = process.env.DEP_GRAPH_JSON;
if (path && existsSync(path)) {
try {
const { modules } = JSON.parse(readFileSync(path, "utf8"));
process.stderr.write(`Using usage graph from ${path}.\n`);
return parseCruiseModules(modules);
} catch (error) {
process.stderr.write(
`Failed to read ${path}; falling back to rules graph: ${error}\n`,
);
}
} else {
process.stderr.write(
"No DEP_GRAPH_JSON found; falling back to rules graph.\n",
);
}
return null;
}
// Reads the nightly coverage manifest (E2E_SPEC_MANIFEST): { builtAt, specs:
// { spec -> files } }. Returns the specs map, or null so e2e falls back to a
// full run when the manifest is missing/unparseable.
function readE2eSpecFiles(): Record<string, string[]> | null {
const path = process.env.E2E_SPEC_MANIFEST;
if (path && existsSync(path)) {
try {
const { specs } = JSON.parse(readFileSync(path, "utf8"));
if (specs && typeof specs === "object") {
process.stderr.write(`Using e2e coverage manifest from ${path}.\n`);
return specs;
}
} catch (error) {
process.stderr.write(
`Failed to read ${path}; e2e will run in full: ${error}\n`,
);
}
} else {
process.stderr.write("No E2E_SPEC_MANIFEST found; e2e will run in full.\n");
}
return null;
}
const testPlan = createTestPlan({
elements,
rules,
testSuites: TEST_SUITES,
changedFiles,
changedFiles: csvToList(process.env.CHANGED_FILES),
fileDependencies: readFileDependencies(),
testFilesBySuite: {
unit: listFiles(UNIT_GLOBS),
loki: listFiles(STORY_GLOBS),
e2e: listFiles(E2E_GLOBS),
},
infraTouchedBySuite: {
unit: process.env.UNIT_INFRA_TOUCHED === "true",
loki: process.env.LOKI_INFRA_TOUCHED === "true",
e2e: false,
unit: listFiles(UNIT_ROOTS, UNIT_GLOBS),
loki: listFiles(STORY_ROOTS, STORY_GLOBS),
e2e: listSpecFiles(),
},
e2eSpecFiles: readE2eSpecFiles(),
unitInfraTouched: process.env.UNIT_INFRA_TOUCHED === "true",
lokiInfraTouched: process.env.LOKI_INFRA_TOUCHED === "true",
e2eInfraTouched: process.env.E2E_INFRA_TOUCHED === "true",
sharedSourcesTouched: process.env.SHARED_SOURCES_TOUCHED === "true",
feFilesChanged: csvToList(process.env.FE_CHANGED_FILES).length,
beFilesChanged: csvToList(process.env.BE_CHANGED_FILES).length,
feFilesTotal: listFiles(["frontend", "enterprise/frontend"], ["**"]).length,
beFilesTotal: listFiles(["src", "enterprise/backend"], ["**"]).length,
});
process.stdout.write(JSON.stringify(testPlan) + "\n");

View File

@@ -19,23 +19,73 @@ function jsonToCsvFormData(jsonData) {
return formData;
}
function uploadCsvToMb({ baseUrl, tableId, jsonData, mode = 'append' }) {
const formData = jsonToCsvFormData(jsonData);
const operation = mode === 'replace' ? 'replace-csv' : 'append-csv';
// Transient failures worth retrying: throttling and server-side errors. A 4xx
// (bad request, auth) won't succeed on retry, so those fail fast.
const RETRYABLE_STATUS = new Set([429, 500, 502, 503, 504]);
return fetch(`${baseUrl}/api/table/${tableId}/${operation}`, {
method: 'POST',
headers: {
"x-api-key": process.env.API_KEY
},
body: formData
})
.then(response => {
if (!response.ok) {
throw new Error(`Upload failed`);
class UploadError extends Error {
constructor(message, { retryable }) {
super(message);
this.retryable = retryable;
}
}
async function attemptUpload(url, jsonData, timeoutMs) {
let response;
try {
response = await fetch(url, {
method: 'POST',
headers: {
"x-api-key": process.env.API_KEY
},
// Rebuilt per attempt: a consumed request body can't be reused.
body: jsonToCsvFormData(jsonData),
// Without this the request can hang indefinitely on a stalled server,
// eating the whole job timeout. An abort surfaces below as a retryable
// network error, so it retries with backoff instead.
signal: AbortSignal.timeout(timeoutMs)
});
} catch (networkError) {
throw new UploadError(networkError.message, { retryable: true });
}
if (response.ok) {
return;
}
const body = await response.text().catch(() => '');
throw new UploadError(
`Upload failed: ${response.status} ${response.statusText} ${body}`.trim(),
{ retryable: RETRYABLE_STATUS.has(response.status) }
);
}
const sleep = ms => new Promise(resolve => setTimeout(resolve, ms));
/**
* Uploads jsonData as CSV, retrying transient API errors with exponential
* backoff. `retries` is the number of extra attempts after the first (so the
* default 2 means up to 3 tries). `timeoutMs` is a per-attempt total deadline
* (default 60s) that aborts a stalled request. Throws the last error once
* attempts are exhausted or the error is non-retryable.
*/
async function uploadCsvToMb({ baseUrl, tableId, jsonData, mode = 'append', retries = 2, retryDelayMs = 1000, timeoutMs = 60_000 }) {
const operation = mode === 'replace' ? 'replace-csv' : 'append-csv';
const url = `${baseUrl}/api/table/${tableId}/${operation}`;
for (let attempt = 0; ; attempt++) {
try {
await attemptUpload(url, jsonData, timeoutMs);
return { success: true };
} catch (error) {
if (!error.retryable || attempt >= retries) {
throw error;
}
const delay = retryDelayMs * 2 ** attempt;
console.warn(`Upload attempt ${attempt + 1} failed (${error.message}); retrying in ${delay}ms`);
await sleep(delay);
}
return { success: true };
});
}
}
module.exports = { uploadCsvToMb };

50
.github/scripts/csv-to-mb.unit.spec.js vendored Normal file
View File

@@ -0,0 +1,50 @@
const { uploadCsvToMb } = require("./csv-to-mb");
const ok = () => ({ ok: true });
const fail = status => ({ ok: false, status, statusText: "err", text: async () => "" });
const upload = (over = {}) =>
uploadCsvToMb({
baseUrl: "https://stats.example.com",
tableId: 1,
jsonData: [{ a: 1 }],
retryDelayMs: 1,
...over,
});
describe("uploadCsvToMb retries", () => {
afterEach(() => {
delete global.fetch;
});
it("retries transient server errors then succeeds", async () => {
global.fetch = jest.fn().mockResolvedValueOnce(fail(503)).mockResolvedValueOnce(fail(500)).mockResolvedValueOnce(ok());
await expect(upload({ retries: 2 })).resolves.toEqual({ success: true });
expect(global.fetch).toHaveBeenCalledTimes(3);
});
it("retries network errors", async () => {
global.fetch = jest
.fn()
.mockRejectedValueOnce(new Error("ECONNRESET"))
.mockResolvedValueOnce(ok());
await expect(upload({ retries: 2 })).resolves.toEqual({ success: true });
expect(global.fetch).toHaveBeenCalledTimes(2);
});
it("gives up after exhausting retries and throws the last error", async () => {
global.fetch = jest.fn().mockResolvedValue(fail(500));
await expect(upload({ retries: 2 })).rejects.toThrow("Upload failed: 500");
expect(global.fetch).toHaveBeenCalledTimes(3); // 1 initial + 2 retries
});
it("does not retry a non-transient 4xx", async () => {
global.fetch = jest.fn().mockResolvedValue(fail(400));
await expect(upload({ retries: 2 })).rejects.toThrow("Upload failed: 400");
expect(global.fetch).toHaveBeenCalledTimes(1);
});
});

32
.github/scripts/e2e-spec-globs.mjs vendored Normal file
View File

@@ -0,0 +1,32 @@
import { execFileSync } from "node:child_process";
import micromatch from "micromatch";
const SPEC_DIR = "e2e/test/scenarios";
// This is the nightly-only baseline helper that runs in the instrumented pass to
// capture boot-time coverage. It is not a product spec, so it is excluded from
// the test plan universe and from the manifest backfill reconciliation.
export const BASELINE_SPEC = `${SPEC_DIR}/coverage-baseline.cy.spec.js`;
// This glob set defines the spec "universe". The test planner
// (create-test-plan.ts) selects which specs to run from it, and the coverage
// manifest builder (build-coverage-manifest.mjs) reconciles against it when
// backfilling specs that did not run.
export const E2E_SPEC_GLOBS = [`${SPEC_DIR}/**/*.cy.spec.{js,jsx,ts,tsx}`];
// Returns the tracked e2e specs as repo-relative paths, excluding the baseline
// helper.
export function listSpecFiles(cwd = process.cwd()) {
const tracked = execFileSync("git", ["ls-files", "--", SPEC_DIR], {
cwd,
encoding: "utf8",
})
.split("\n")
.map((line) => line.trim())
.filter(Boolean);
return micromatch(tracked, E2E_SPEC_GLOBS, {
ignore: [BASELINE_SPEC],
dot: true,
});
}

258
.github/scripts/measure-bundle-sizes.js vendored Normal file
View File

@@ -0,0 +1,258 @@
/* eslint-disable import/no-commonjs */
// Measures the front-end bundles emitted into an extracted uberjar tree.
//
// Every bundle reports one or both of:
// - "initial": JS the browser downloads on first paint (the entry chunk plus
// its initial/sync split chunks). Never excludes initial chunks.
// - "total": all *reachable* JS (initial plus async chunks that are actually
// loadable at runtime). Never includes unreachable/never-fetched chunks.
// Reachability needs the per-entry asset list from the rspack stats file, so the
// app and chunked SDK bundles require their stats file to be present.
//
// The pure pieces — the asset-name selection (initial vs reachable, runtime
// filtering, the async-loadable flag) — are split out as select*Assets so they
// can be unit-tested against a stats object. The measure* functions and main()
// keep all the filesystem and env I/O, threading an explicit `config`.
const fs = require("fs");
const path = require("path");
const zlib = require("zlib");
const APP_DIST = "resources/frontend_client/app/dist";
const SDK_ROOT = "resources/frontend_client/app/embedding-sdk";
// The chunk runtime is inlined into the bootstrap, never sent as a standalone file.
const SDK_RUNTIME_RE = /embedding-sdk-chunk-runtime\./;
const notRuntime = name => !SDK_RUNTIME_RE.test(name);
const assetFiles = (root, names) => names.map(name => path.join(root, name));
const unique = files => [...new Set(files)];
// MEASURE_ROOT lets callers point at an extracted tree (e.g. the PR bundle-size
// check measures a current and a base-ref tree); defaults to cwd for the stats
// workflow. MEASURE_BUNDLES restricts which bundles are measured (comma-separated).
// SDK_ASYNC_CHUNKS_LOADABLE (see selectChunkedSdkAssets) toggles whether async
// SDK chunks count toward "total".
function buildConfig(env) {
const baseDir = env.MEASURE_ROOT ? path.resolve(env.MEASURE_ROOT) : process.cwd();
const bundleFilter = env.MEASURE_BUNDLES
? new Set(env.MEASURE_BUNDLES.split(",").map(bundle => bundle.trim()))
: null;
return {
resolve: (...relativeParts) => path.resolve(baseDir, ...relativeParts),
isBundleWanted: bundle => !bundleFilter || bundleFilter.has(bundle),
// Async SDK chunks are reachable once output.publicPath is set so import()
// chunks are actually fetched at runtime — which landed in master. Defaults
// to true to match master; set SDK_ASYNC_CHUNKS_LOADABLE=false to measure an
// older commit built before the publicPath fix (async unreachable, so
// "total" collapses to "initial").
sdkAsyncChunksLoadable: env.SDK_ASYNC_CHUNKS_LOADABLE !== "false",
};
}
function sizeOf(files) {
let rawBytes = 0;
let gzipBytes = 0;
let brotliBytes = 0;
for (const file of files) {
const contents = fs.readFileSync(file);
rawBytes += contents.length;
// gzip: recompressed, a proxy for the on-the-fly gzip served on every version
gzipBytes += zlib.gzipSync(contents).length;
// brotli: as-served — count the precompressed .br the build ships; files
// without one (static-viz, sub-threshold chunks) are served compressed on
// the fly, so estimate with brotli. Always reported (like gzip).
const brotliPath = `${file}.br`;
brotliBytes += fs.existsSync(brotliPath)
? fs.statSync(brotliPath).size
: zlib.brotliCompressSync(contents).length;
}
return {
fileCount: files.length,
rawBytes,
gzipBytes,
brotliBytes,
};
}
function collectJsFiles(absolutePath) {
if (fs.statSync(absolutePath).isFile()) {
return [absolutePath];
}
return fs
.readdirSync(absolutePath, { withFileTypes: true })
.flatMap(entry => {
const childPath = path.join(absolutePath, entry.name);
if (entry.isDirectory()) {
return collectJsFiles(childPath);
}
return entry.name.endsWith(".js") ? [childPath] : [];
});
}
function readStats(config, statsFile) {
const statsPath = config.resolve(statsFile);
return fs.existsSync(statsPath) ? JSON.parse(fs.readFileSync(statsPath, "utf8")) : null;
}
// An entrypoint's .js assets for a given field: "assets" = its initial
// (synchronous) load; "reachableAssets" = initial plus everything it can lazily
// import (the chunk graph walked at build time in bundle-stats.js).
function entrypointJsAssets(stats, name, field = "assets") {
const entry = stats && stats.entrypoints && stats.entrypoints[name];
if (!entry || !entry[field]) {
return null;
}
return entry[field].map(asset => asset.name || asset).filter(assetName => assetName.endsWith(".js"));
}
/**
* Main app = the app-main entrypoint only (app/dist also holds other pages like
* app-public, app-embed*, which are not the app). `reachableAssets` is null on
* older stats built before the chunk-graph enrichment — the caller then falls
* back to sizing the whole app/dist.
*/
function selectAppAssets(stats) {
const initialAssets = entrypointJsAssets(stats, "app-main", "assets");
if (!initialAssets) {
throw new Error('app: stats-main.json / "app-main" entrypoint missing');
}
return { initialAssets, reachableAssets: entrypointJsAssets(stats, "app-main", "reachableAssets") };
}
/**
* Legacy SDK: the "embedding-sdk" entry, a single eager file in legacy/. It still
* emits on-demand chunks (jspdf, echarts, leaflet, ...) into the shared chunks/
* dir via dynamic import(). initial = the eager legacy file; total = initial plus
* its reachable async chunks, but only when those are loadable at runtime
* (sdkAsyncChunksLoadable), otherwise total collapses to initial. Returns null
* when the stats lack the entry (older layout) so the caller can fall back.
*/
function selectLegacySdkAssets(stats, { sdkAsyncChunksLoadable }) {
const initialNames = entrypointJsAssets(stats, "embedding-sdk", "assets");
if (!initialNames) {
return null;
}
const reachableNames = entrypointJsAssets(stats, "embedding-sdk", "reachableAssets") || initialNames;
const initial = unique(initialNames).filter(notRuntime);
return {
initialNames: initial,
reachableNames: sdkAsyncChunksLoadable ? unique(reachableNames).filter(notRuntime) : initial,
};
}
/**
* Chunked SDK delivery. initial = bootstrap (minus its inlined runtime) + the
* chunked entry's initial chunks. total = the chunked entry's reachable set
* (initial + async children, from the chunk graph). includesAsyncChunks is true
* only when the stats carry the reachable chunk graph AND those chunks are
* loadable at runtime (sdkAsyncChunksLoadable). A base ref built before the
* reachableAssets enrichment has no graph, so its "total" must collapse to
* "initial" — the flag lets the comparison avoid measuring a reachable total
* against a collapsed one (an apples-to-oranges ~30% phantom).
*/
function selectChunkedSdkAssets(stats, { sdkAsyncChunksLoadable }) {
const chunkedInitial = entrypointJsAssets(stats, "embedding-sdk-chunked", "assets");
if (!chunkedInitial) {
throw new Error('embedding-sdk-chunked: stats-embedding-sdk.json / "embedding-sdk-chunked" entrypoint missing');
}
const bootstrapInitial = entrypointJsAssets(stats, "embedding-sdk-bootstrap", "assets") || [];
const chunkedReachableAssets = entrypointJsAssets(stats, "embedding-sdk-chunked", "reachableAssets");
const chunkedReachable = chunkedReachableAssets || chunkedInitial;
const bootstrapReachable = entrypointJsAssets(stats, "embedding-sdk-bootstrap", "reachableAssets") || bootstrapInitial;
return {
initialNames: unique([...bootstrapInitial, ...chunkedInitial]).filter(notRuntime),
reachableNames: unique([...bootstrapReachable, ...chunkedReachable]).filter(notRuntime),
includesAsyncChunks: chunkedReachableAssets != null && sdkAsyncChunksLoadable,
};
}
function measureApp(config) {
const dist = config.resolve(APP_DIST);
if (!fs.existsSync(dist)) {
throw new Error(`Bundle output not found for "app": ${dist}`);
}
const { initialAssets, reachableAssets } = selectAppAssets(readStats(config, "artifacts/stats-main.json"));
if (!reachableAssets) {
console.warn("app: stats has no reachableAssets; app total falls back to the whole app/dist");
}
const totalFiles = reachableAssets ? assetFiles(dist, reachableAssets) : collectJsFiles(dist);
return [
{ bundle: "app", kind: "initial", ...sizeOf(assetFiles(dist, initialAssets)) },
{ bundle: "app", kind: "total", ...sizeOf(totalFiles) },
];
}
function measureLegacySdk(config) {
const absRoot = config.resolve(SDK_ROOT);
const selected = selectLegacySdkAssets(readStats(config, "artifacts/stats-embedding-sdk.json"), config);
if (!selected) {
// No stats / older layout: fall back to whatever sits in the legacy dir.
const candidates = [`${SDK_ROOT}/legacy`, `${SDK_ROOT}.js`];
const chosen = candidates.find(candidate => fs.existsSync(config.resolve(candidate)));
if (!chosen) {
console.warn(`Skipping "embedding-sdk-legacy": output not found (${candidates.join(", ")})`);
return [];
}
return [{ bundle: "embedding-sdk-legacy", kind: "total", ...sizeOf(collectJsFiles(config.resolve(chosen))) }];
}
return [
{ bundle: "embedding-sdk-legacy", kind: "initial", ...sizeOf(assetFiles(absRoot, selected.initialNames)) },
{ bundle: "embedding-sdk-legacy", kind: "total", ...sizeOf(assetFiles(absRoot, selected.reachableNames)) },
];
}
function measureChunkedSdk(config) {
const chunksDir = config.resolve(SDK_ROOT, "chunks");
if (!fs.existsSync(chunksDir)) {
// pre-chunked layout (monolith only) — nothing to measure here
return [];
}
const absRoot = config.resolve(SDK_ROOT);
const { initialNames, reachableNames, includesAsyncChunks } = selectChunkedSdkAssets(
readStats(config, "artifacts/stats-embedding-sdk.json"),
config,
);
const initial = sizeOf(assetFiles(absRoot, initialNames));
const total = includesAsyncChunks ? sizeOf(assetFiles(absRoot, reachableNames)) : initial;
return [
{ bundle: "embedding-sdk-chunked", kind: "initial", ...initial },
{ bundle: "embedding-sdk-chunked", kind: "total", reachable: includesAsyncChunks, ...total },
];
}
// Single-file/dir bundles loaded in one shot — total only.
function measureWholeDir(config, bundle, candidates) {
const chosen = candidates.find(candidate => fs.existsSync(config.resolve(candidate)));
if (!chosen) {
console.warn(`Skipping "${bundle}": output not found (${candidates.join(", ")})`);
return [];
}
return [{ bundle, kind: "total", ...sizeOf(collectJsFiles(config.resolve(chosen))) }];
}
const bundles = {
app: measureApp,
"embedding-sdk-legacy": measureLegacySdk,
"embedding-sdk-chunked": measureChunkedSdk,
"embedding-sdk-package": config => measureWholeDir(config, "embedding-sdk-package", ["resources/embedding-sdk/dist"]),
"embed-js": config => measureWholeDir(config, "embed-js", ["resources/frontend_client/app/embed.js"]),
};
function measureBundleSizes(config) {
return Object.entries(bundles)
.filter(([bundle]) => config.isBundleWanted(bundle))
.flatMap(([, measure]) => measure(config));
}
module.exports = {
measureBundleSizes,
buildConfig,
entrypointJsAssets,
selectAppAssets,
selectLegacySdkAssets,
selectChunkedSdkAssets,
};
if (require.main === module) {
console.log(JSON.stringify(measureBundleSizes(buildConfig(process.env)), null, 2));
}

View File

@@ -0,0 +1,87 @@
const {
entrypointJsAssets,
selectAppAssets,
selectLegacySdkAssets,
selectChunkedSdkAssets,
} = require("./measure-bundle-sizes");
const RUNTIME = "embedding-sdk-chunk-runtime.deadbeef.js";
const stats = entrypoints => ({ entrypoints });
describe("entrypointJsAssets", () => {
it("returns the .js asset names for a field, accepting strings or {name}", () => {
const s = stats({ app: { assets: [{ name: "a.js" }, "b.js", { name: "c.css" }] } });
expect(entrypointJsAssets(s, "app", "assets")).toEqual(["a.js", "b.js"]);
});
it("returns null when the entrypoint or field is absent", () => {
expect(entrypointJsAssets(stats({}), "missing")).toBeNull();
expect(entrypointJsAssets(null, "app")).toBeNull();
});
});
describe("selectAppAssets", () => {
it("returns the initial set and a null reachable set on pre-enrichment stats", () => {
const s = stats({ "app-main": { assets: ["main.js"] } });
expect(selectAppAssets(s)).toEqual({ initialAssets: ["main.js"], reachableAssets: null });
});
it("throws when the app-main entrypoint is missing", () => {
expect(() => selectAppAssets(stats({}))).toThrow("app-main");
});
});
describe("selectChunkedSdkAssets", () => {
const base = {
"embedding-sdk-chunked": { assets: ["a.js", RUNTIME], reachableAssets: ["a.js", "b.js", RUNTIME] },
"embedding-sdk-bootstrap": { assets: ["boot.js"], reachableAssets: ["boot.js"] },
};
it("merges bootstrap + chunked, drops the inlined runtime, and counts async chunks", () => {
const result = selectChunkedSdkAssets(stats(base), { sdkAsyncChunksLoadable: true });
expect(result.initialNames).toEqual(["boot.js", "a.js"]);
expect(result.reachableNames).toEqual(["boot.js", "a.js", "b.js"]);
expect(result.includesAsyncChunks).toBe(true);
});
it("collapses total to initial when async chunks are not loadable", () => {
const result = selectChunkedSdkAssets(stats(base), { sdkAsyncChunksLoadable: false });
expect(result.includesAsyncChunks).toBe(false);
});
it("collapses total to initial when the stats carry no reachable graph", () => {
const noGraph = { "embedding-sdk-chunked": { assets: ["a.js"] } };
const result = selectChunkedSdkAssets(stats(noGraph), { sdkAsyncChunksLoadable: true });
expect(result.reachableNames).toEqual(["a.js"]);
expect(result.includesAsyncChunks).toBe(false);
});
it("throws when the chunked entrypoint is missing", () => {
expect(() => selectChunkedSdkAssets(stats({}), { sdkAsyncChunksLoadable: true })).toThrow(
"embedding-sdk-chunked",
);
});
});
describe("selectLegacySdkAssets", () => {
it("returns null when the legacy entry is absent so the caller can fall back", () => {
expect(selectLegacySdkAssets(stats({}), { sdkAsyncChunksLoadable: true })).toBeNull();
});
it("expands total to the reachable async set when loadable", () => {
const s = stats({ "embedding-sdk": { assets: ["legacy.js"], reachableAssets: ["legacy.js", "chunk.js"] } });
expect(selectLegacySdkAssets(s, { sdkAsyncChunksLoadable: true })).toEqual({
initialNames: ["legacy.js"],
reachableNames: ["legacy.js", "chunk.js"],
});
});
it("collapses total to initial when async chunks are not loadable", () => {
const s = stats({ "embedding-sdk": { assets: ["legacy.js"], reachableAssets: ["legacy.js", "chunk.js"] } });
expect(selectLegacySdkAssets(s, { sdkAsyncChunksLoadable: false })).toEqual({
initialNames: ["legacy.js"],
reachableNames: ["legacy.js"],
});
});
});

123
.github/scripts/module-usage.ts vendored Normal file
View File

@@ -0,0 +1,123 @@
// Builds module-level "usage" maps: for each module, the set of modules that
// depend on it, both directly and indirectly
//
// Both are computed at the FILE level off the real dependency-cruiser import
// graph, then collapsed to module granularity at the very end.
//
// bunx depcruise frontend/src enterprise/frontend/src \
// --config .dependency-cruiser.cjs --output-type json > dependency-graph.json
// DEP_GRAPH_JSON=dependency-graph.json \
// OUT_JSON=usage.json OUT_DIRECT_JSON=usage-direct.json \
// bun .github/scripts/module-usage.ts
import { readFileSync, writeFileSync } from "node:fs";
import { elements } from "../../frontend/lint/module-boundaries.mjs";
import {
buildFileGraph,
getAffectedFiles,
mapFileToModule,
parseCruiseModules,
} from "./affected-modules";
const depGraphPath = process.env.DEP_GRAPH_JSON ?? "dependency-graph.json";
const { modules } = JSON.parse(readFileSync(depGraphPath, "utf8"));
const fileDependencies = parseCruiseModules(modules);
const fileGraph = buildFileGraph(elements, fileDependencies);
// Group every known source file by its owning module. We seed from the cruise
// output's `source` files plus everything that appears as a dependency target,
// so files imported but never importing are still covered.
const filesByModule = new Map<string, string[]>();
const allFiles = new Set<string>();
for (const { source, dependencies } of fileDependencies) {
allFiles.add(source);
for (const dep of dependencies) {
allFiles.add(dep);
}
}
for (const file of allFiles) {
const module = mapFileToModule(fileGraph.nodes, file);
if (!module) {
continue;
}
const list = filesByModule.get(module);
if (list) {
list.push(file);
} else {
filesByModule.set(module, [file]);
}
}
// Ensure every module appears as a key, even those nothing depends on.
const emptyDependents = (): Record<string, Set<string>> => {
const map: Record<string, Set<string>> = {};
for (const module of filesByModule.keys()) {
map[module] = new Set();
}
return map;
};
// DIRECT usage: module B directly depends on module A if any file in B imports
// any file in A — a single edge in the import graph, collapsed to modules.
const directDependents = emptyDependents();
for (const { source, dependencies } of fileDependencies) {
const importer = mapFileToModule(fileGraph.nodes, source);
if (!importer) {
continue;
}
for (const target of dependencies) {
const owner = mapFileToModule(fileGraph.nodes, target);
if (owner && owner !== importer) {
directDependents[owner].add(importer);
}
}
}
// TRANSITIVE usage: for each module, take all its files, walk the file-level
// reverse graph to get every file that transitively imports them, collapse to
// modules, and drop the module itself.
const transitiveDependents = emptyDependents();
for (const [module, files] of filesByModule) {
const affectedFiles = getAffectedFiles(fileGraph, files);
for (const file of affectedFiles) {
const owner = mapFileToModule(fileGraph.nodes, file);
if (owner && owner !== module) {
transitiveDependents[module].add(owner);
}
}
}
// Stable, sorted output for clean diffs.
const toSorted = (
map: Record<string, Set<string>>,
): Record<string, string[]> => {
const sorted: Record<string, string[]> = {};
for (const module of Object.keys(map).sort()) {
sorted[module] = [...map[module]].sort();
}
return sorted;
};
const writeOut = (
map: Record<string, Set<string>>,
outVar: string,
label: string,
) => {
const sorted = toSorted(map);
const json = JSON.stringify(sorted, null, 2) + "\n";
const outPath = process.env[outVar];
if (outPath) {
writeFileSync(outPath, json);
process.stderr.write(
`Wrote ${Object.keys(sorted).length} modules (${label}) to ${outPath}.\n`,
);
} else {
process.stdout.write(json);
}
};
writeOut(transitiveDependents, "OUT_JSON", "transitive");
writeOut(directDependents, "OUT_DIRECT_JSON", "direct");

View File

@@ -0,0 +1,94 @@
/**
* Resolves the nightly e2e coverage manifest closest to a commit's point in
* history, so the test planner can narrow the e2e run.
*
* The whole flow lives here so callers "just get a manifest": list the retained
* manifest artifacts, find the one whose nightly commit is the nearest ancestor
* of `headSha` (via the GitHub compare API — no deep clone), download and unzip
* just that one, and return its parsed contents.
*
* `github` is an authenticated Octokit, as injected by actions/github-script.
* Returns { builtAt, specs, path, behindBy } or null when nothing is an
* ancestor (caller then runs e2e in full). Never throws: any API/IO failure is
* logged and resolves to null, because coverage resolution must not break the
* test plan.
*/
import { execFileSync } from "node:child_process";
import fs from "node:fs";
const ARTIFACT_NAME = "spec-file-manifest";
const EXTRACT_DIR = "e2e/coverage";
const MANIFEST_PATH = `${EXTRACT_DIR}/${ARTIFACT_NAME}.json`;
export async function resolveCoverageManifest({
github,
owner,
repo,
headSha,
log = console.log,
}) {
try {
// Every retained manifest artifact, newest first. Each carries its
// nightly's head_sha — the commit it was built from (== builtAt).
const artifacts = await github.paginate(
github.rest.actions.listArtifactsForRepo,
{ owner, repo, name: ARTIFACT_NAME, per_page: 100 },
);
const candidates = artifacts
.filter((artifact) => !artifact.expired && artifact.workflow_run?.head_sha)
.sort(
(a, b) =>
new Date(b.created_at).getTime() - new Date(a.created_at).getTime(),
);
// First candidate that is an ancestor of head is the closest in history
// (master is linear, candidates are chronological). compare base...head:
// behind_by === 0 ⇒ base is an ancestor of head; ahead_by is the distance.
let chosen = null;
for (const artifact of candidates) {
const base = artifact.workflow_run.head_sha;
// A stale candidate (force-pushed/GC'd commit) makes compare 404 — skip
// it rather than lose the optimization for everyone.
let comparison;
try {
({ data: comparison } =
await github.rest.repos.compareCommitsWithBasehead({
owner,
repo,
basehead: `${base}...${headSha}`,
}));
} catch {
continue;
}
if (comparison.behind_by === 0) {
chosen = { artifact, base, behindBy: comparison.ahead_by };
break;
}
}
if (!chosen) {
log("No ancestor coverage manifest found; e2e will run in full.");
return null;
}
const download = await github.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: chosen.artifact.id,
archive_format: "zip",
});
fs.writeFileSync(`${ARTIFACT_NAME}.zip`, Buffer.from(download.data));
execFileSync("unzip", ["-o", `${ARTIFACT_NAME}.zip`, "-d", EXTRACT_DIR]);
const manifest = JSON.parse(fs.readFileSync(MANIFEST_PATH, "utf8"));
log(
`Using coverage manifest ${chosen.base.slice(0, 12)} ` +
`(${chosen.behindBy} commits behind HEAD).`,
);
return { ...manifest, path: MANIFEST_PATH, behindBy: chosen.behindBy };
} catch (error) {
log(`Coverage manifest resolution failed; e2e will run in full: ${error}`);
return null;
}
}

View File

@@ -19,7 +19,8 @@ while [[ $# -gt 0 ]]; do
done
echo "Cloning python-runner repository..."
git clone --depth 1 https://${METABASE_AUTOMATION_USER_TOKEN}@github.com/metabase/python-runner-container.git python-runner
git clone --depth 1 https://${METABASE_AUTOMATION_USER_TOKEN}@github.com/metabase/python-runner-container.git --branch seccomp python-runner
if [ "$SKIP_START" = false ]; then
echo "Starting python-runner..."

View File

@@ -1,41 +1,64 @@
// This script is used in .github/workflows/run-tests.yml.
// It uploads the test-plan stats row produced by create-test-plan.js to
// the stats.metabase.com tracking table.
// Reads STATS_JSON, PR_NUMBER, HEAD_SHA, BASE_SHA, API_KEY from env.
// Appends the test-plan stats row produced by create-test-plan.ts to the
// "FE Affected Tests" table on stats.metabase.com.
// Reads STATS_JSON, TRIGGERED_BY, PR_NUMBER, HEAD_SHA, BASE_SHA, API_KEY from env.
const { uploadCsvToMb } = require("./csv-to-mb.js");
const stats = JSON.parse(process.env.STATS_JSON);
console.log("stats", stats);
// "FE Affected Tests" uploaded table on stats.metabase.com.
const TABLE_ID = 81818;
const row = {
Date: new Date().toISOString(),
PR: Number(process.env.PR_NUMBER),
"Head SHA": process.env.HEAD_SHA,
"Base SHA": process.env.BASE_SHA,
"Modules changed": stats.modules_changed,
"Modules affected": stats.modules_affected,
"FE Unit specs total": stats.fe_unit_specs_total,
"FE Unit specs run": stats.fe_unit_specs_run,
"FE Unit specs skipped": stats.fe_unit_specs_skipped,
"Loki stories total": stats.loki_stories_total,
"Loki stories run": stats.loki_stories_run,
"Loki stories skipped": stats.loki_stories_skipped,
"E2E specs total": stats.e2e_specs_total,
"E2E specs run": stats.e2e_specs_run,
"E2E specs skipped": stats.e2e_specs_skipped,
};
async function main() {
// create-test-plan doesn't always produce stats (e.g. on release branches
// running an older planner), leaving STATS_JSON empty. Nothing to upload.
const raw = (process.env.STATS_JSON || "").trim();
if (!raw || raw === "null") {
console.log("No STATS_JSON to upload; skipping.");
return;
}
uploadCsvToMb({
baseUrl: "https://stats.metabase.com",
tableId: 77008, // "Affected Tests Stats" table on stats.metabase.com
jsonData: [row],
mode: "append",
})
.then(() => {
console.log("Data uploaded successfully");
})
.catch((error) => {
console.error("Error uploading data:", error);
process.exit(1);
const s = JSON.parse(raw);
console.log("stats", s);
const row = {
Date: new Date().toISOString(),
// "pr_update" or "merge_to_master". ("Trigger" is a reserved SQL word.)
"Triggered By": process.env.TRIGGERED_BY,
PR: Number(process.env.PR_NUMBER),
"Head SHA": process.env.HEAD_SHA,
"Base SHA": process.env.BASE_SHA,
"FE Files Changed": s.fe_files_changed,
"FE Files Total": s.fe_files_total,
"BE Files Changed": s.be_files_changed,
"BE Files Total": s.be_files_total,
"Unit Infra Touched": s.unit_infra_touched,
"Loki Infra Touched": s.loki_infra_touched,
"Shared Sources Touched": s.shared_sources_touched,
"FE Modules Total": s.fe_modules_total,
"FE Modules Changed": s.fe_modules_changed,
"FE Modules Affected (Rules)": s.fe_modules_affected_rules,
"FE Modules Affected (Usage)": s.fe_modules_affected_usage,
"Unit Specs All": s.unit_specs_all,
"Unit Specs To Run (Rules)": s.unit_specs_to_run_rules,
"Unit Specs To Run (Usage)": s.unit_specs_to_run_usage,
"Loki Stories All": s.loki_stories_all,
"Loki Stories To Run (Rules)": s.loki_stories_to_run_rules,
"Loki Stories To Run (Usage)": s.loki_stories_to_run_usage,
"E2E Specs All": s.e2e_specs_all,
"E2E Specs To Run (Rules)": s.e2e_specs_to_run_rules,
"E2E Specs To Run (Usage)": s.e2e_specs_to_run_usage,
};
await uploadCsvToMb({
baseUrl: "https://stats.metabase.com",
tableId: TABLE_ID,
jsonData: [row],
mode: "append",
});
console.log("Data uploaded successfully");
}
// Best-effort: never let a telemetry failure turn the job red.
main().catch((error) => {
console.error("Skipping stats upload after error:", error);
process.exit(0);
});

9
.github/team.json vendored
View File

@@ -4,7 +4,6 @@
"name": "Querying Platform",
"label": ".Team/QueryingPlatform",
"members": [
"bshepherdson",
"metamben",
"rileythomp",
"camsaul",
@@ -48,7 +47,8 @@
"members": [
"fraserdrops",
"nemanjaglumac",
"romeovs"
"romeovs",
"ChrisVandoo"
]
},
{
@@ -89,11 +89,12 @@
"npfitz",
"johnswanson",
"nvoxland",
"edpaget",
"bshepherdson",
"deniskaber",
"andsalves",
"kevinkelleher12",
"AndreyChernykh"
"AndreyChernykh",
"bowbahdoe"
]
},
{

42
.github/workflows/actionlint.yml vendored Normal file
View File

@@ -0,0 +1,42 @@
name: Actionlint
on:
push:
branches:
- 'master'
- 'release-**'
paths:
- '.github/workflows/**'
pull_request:
paths:
- '.github/workflows/**'
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
cancel-in-progress: true
jobs:
actionlint:
name: Lint Github Actions Workflows
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- uses: actions/checkout@v6
- name: Get changed Github actions
uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
id: changes
with:
token: ${{ github.token }}
filters: .github/file-paths.yaml
list-files: shell
- name: Setup actionlint
id: download
shell: bash
run: |
if command -v actionlint; then
echo "executable=actionlint" >> "$GITHUB_OUTPUT"
else
# script sets executable output, for details see: https://github.com/rhysd/actionlint/blob/main/docs/usage.md#use-actionlint-on-github-actions
bash <(curl -fsSL https://raw.githubusercontent.com/rhysd/actionlint/v1.7.12/scripts/download-actionlint.bash)
fi
- name: Run actionlint
run: ${{ steps.download.outputs.executable }} --color --verbose ${{ steps.changes.outputs.actionlint_files }}

View File

@@ -11,6 +11,13 @@ concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}-app-db
cancel-in-progress: true
# Exposed to every job so the test-driver action can report failures to
# ci-conductor (secrets: inherit is already set on the app-db call in
# run-tests.yml). See DEV-2224.
env:
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
jobs:
be-tests-mariadb:
if: ${{ !inputs.skip }}
@@ -69,7 +76,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -113,6 +120,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -124,6 +132,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mysql:
if: ${{ !inputs.skip }}
@@ -184,7 +193,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -236,6 +245,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -247,6 +257,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-postgres:
if: ${{ !inputs.skip }}
@@ -300,7 +311,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -346,6 +357,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -357,6 +369,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
app-db-tests-result:
needs:

View File

@@ -11,6 +11,13 @@ concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}-backend
cancel-in-progress: true
# Exposed to the test jobs so they can report failures to ci-conductor
# (secrets: inherit is already set on the backend call in run-tests.yml).
# See DEV-2224.
env:
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
jobs:
be-linter-clj-kondo:
if: ${{ !inputs.skip }}
@@ -38,7 +45,7 @@ jobs:
be-linter-eastwood-test:
# Master / release safety net: lint every backend test namespace.
if: ${{ !inputs.skip && github.event_name == 'push' && (github.ref_name == 'master' || startsWith(github.ref_name, 'release-')) }}
if: ${{ !inputs.skip && github.event_name == 'push' && (github.ref_name == 'master' || startsWith(github.ref_name, 'release-x')) }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 45
name: Eastwood (tests only)
@@ -114,7 +121,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java-version: [21]
java-version: [25]
job:
- name: Enterprise Tests
edition: ee
@@ -160,7 +167,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -179,20 +186,42 @@ jobs:
env:
MB_EDITION: ${{ matrix.job.edition }}
- name: Resolve current job id
# Resolve JOB_ID before the long test step so the ci-conductor reporter
# below can link failures to this exact job. Best-effort.
uses: ./.github/actions/resolve-job-id
- name: "Test Java ${{ matrix.java-version }} ${{ matrix.job.name }}"
id: run-java-tests
run: >-
clojure -X:dev:ci:test:${{ matrix.job.edition }}:${{ matrix.job.edition }}-dev
:exclude-tags '[:mb/driver-tests ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
${{ matrix.job.test-args }}
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Report failed tests to ci-conductor
if: ${{ !cancelled() && steps.run-java-tests.outcome == 'failure' }}
# This step should NEVER fail the job!
continue-on-error: true
uses: ./.github/actions/report-failures-to-ci-conductor
with:
test-suite: be-tests-java-${{ matrix.java-version }}-${{ matrix.job.test-group-name }}
adapter: backend
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-java-tests.outcome == 'failure' }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: backend
test-suite: be-tests-java-${{ matrix.java-version }}-${{ matrix.job.test-group-name }}
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always() && (steps.run-java-tests.conclusion != 'skipped' || steps.run-java-tests-21.conclusion != 'skipped')
if: always()
with:
input-path: ./target/junit/
output-name: be-tests-java-${{ matrix.java-version }}-${{ matrix.job.edition }}
@@ -201,6 +230,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-java-tests.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 # v3.0.0
@@ -229,7 +259,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
java-version: [21]
java-version: [25]
name: "Check Java ${{ matrix.java-version }}"
steps:
- uses: actions/checkout@v6

148
.github/workflows/bundle-size-stats.yml vendored Normal file
View File

@@ -0,0 +1,148 @@
name: Bundle Size Stats
# Reuses the uberjar built on every master merge: downloads the jar (for the
# emitted JS) plus the bundle-stats and embedding-sdk artifacts, measures
# initial/total bundle sizes, and appends them to stats.metabase.com.
on:
workflow_run:
workflows: ["Build Uberjar"]
types: [completed]
# Master only: releases form non-linear lines whose deltas are meaningless,
# so their sizes are backfilled separately rather than logged here.
branches: [master]
concurrency:
group: bundle-size-stats-${{ github.event.workflow_run.head_sha }}
cancel-in-progress: true
jobs:
bundle-size-stats:
if: ${{ github.event.workflow_run.conclusion == 'success' && github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
env:
HEAD_SHA: ${{ github.event.workflow_run.head_sha }}
# Only record a data point when a bundle's as-served size (brotli where the
# build ships .br, else gzip) moved by at least this percent vs the last
# plotted point, keeping the chart to real changes.
MIN_DELTA_PERCENT: "0.5"
steps:
- name: Check out the code
uses: actions/checkout@v6
with:
ref: ${{ github.event.workflow_run.head_sha }}
- name: Download EE uberjar
uses: ./.github/actions/fetch-artifact
with:
commit: ${{ github.event.workflow_run.head_sha }}
edition: ee
extract-path: temp/uberjar
- name: Extract front-end bundles from uberjar
run: |
mkdir -p resources artifacts
unzip -o "temp/uberjar/metabase.jar" \
"frontend_client/app/dist/*" \
"frontend_client/app/embed.js" \
"frontend_client/app/embedding-sdk/*" \
-d resources
unzip -o -j "temp/uberjar/metabase.jar" version.properties -d artifacts
- name: Download bundle stats and SDK package artifacts
uses: actions/github-script@v9
with:
script: | # js
const fs = require("fs");
async function fetchArtifact(name) {
const res = await github.rest.actions.listArtifactsForRepo({
owner: context.repo.owner,
repo: context.repo.repo,
name,
per_page: 1,
});
const artifact = res.data?.artifacts?.[0];
if (!artifact) {
console.log(`Artifact not found: ${name}`);
return "";
}
const download = await github.rest.actions.downloadArtifact({
owner: context.repo.owner,
repo: context.repo.repo,
artifact_id: artifact.id,
archive_format: "zip",
});
fs.writeFileSync(`${name}.zip`, Buffer.from(download.data));
console.log(`Downloaded ${name}`);
return `${name}.zip`;
}
const sha = process.env.HEAD_SHA;
core.exportVariable("STATS_ZIP", await fetchArtifact(`metabase-bundle-stats-ee-${sha}`));
core.exportVariable("PKG_ZIP", await fetchArtifact(`embedding-sdk-${sha}`));
- name: Extract stats and SDK package
run: |
mkdir -p artifacts resources/embedding-sdk
if [ -n "$STATS_ZIP" ]; then unzip -o "$STATS_ZIP" -d artifacts; fi
if [ -n "$PKG_ZIP" ]; then unzip -o "$PKG_ZIP" -d resources/embedding-sdk; fi
- name: Restore last plotted bundle sizes
uses: actions/cache/restore@v4
with:
path: bundle-size-cache
key: bundle-size-last-${{ github.run_id }}
restore-keys: |
bundle-size-last-
- name: Measure bundle sizes
run: node ./.github/scripts/measure-bundle-sizes.js | tee artifacts/bundle-sizes.json
- name: Compute deltas and decide whether to record this point
id: prepare
env:
CURRENT: artifacts/bundle-sizes.json
LAST: bundle-size-cache/last.json
CACHE_OUT: bundle-size-cache/last.json
ROWS_OUT: artifacts/upload-rows.json
VERSION_PROPS: artifacts/version.properties
# Passed via env (not interpolated into the shell) so the commit
# message can't inject commands; the script keeps only the subject.
COMMIT_MESSAGE: ${{ github.event.workflow_run.head_commit.message }}
run: node ./.github/scripts/bundle-size-stats-prepare.js
- name: Upload sizes (with deltas) to Stats
id: upload
if: steps.prepare.outputs.significant == 'true'
uses: actions/github-script@v9
env:
API_KEY: ${{ secrets.STATS_API_KEY }}
with:
script: | # js
const fs = require("fs");
const { uploadCsvToMb } = require("${{ github.workspace }}/.github/scripts/csv-to-mb.js");
const data = JSON.parse(
fs.readFileSync("${{ github.workspace }}/artifacts/upload-rows.json", "utf8"),
);
console.table(data);
try {
await uploadCsvToMb({
baseUrl: "https://stats.metabase.com",
tableId: 79702,
jsonData: data,
mode: "append",
});
console.log("Bundle sizes uploaded successfully");
core.setOutput("uploaded", "true");
} catch (error) {
// Stats logging is best-effort: if stats.metabase.com is still
// unreachable after the client's retries, keep the run green. The
// last-plotted cache is only saved on a successful upload (below),
// so this point is re-attempted on the next master build and
// nothing is silently dropped.
core.warning(`Bundle-size upload failed after retries; leaving run green: ${error.message}`);
core.setOutput("uploaded", "false");
}
- name: Remember this as the last plotted point
if: steps.upload.outputs.uploaded == 'true'
uses: actions/cache/save@v4
with:
path: bundle-size-cache
key: bundle-size-last-${{ github.run_id }}

View File

@@ -1,205 +0,0 @@
name: "Claude E2E Flake Fix"
# Runs the /fix-flaky-test command headlessly to fix a flaky e2e test tracked by a Linear
# issue. Triggered manually or by automation (e.g. ci-conductor) via workflow_dispatch /
# repository_dispatch. ci-conductor only dispatches this workflow — it never runs the agent
# itself. The agent opens a green, review-ready PR; a human always reviews and merges.
on:
workflow_dispatch:
inputs:
issue:
description: "Linear issue ref for the flaky test (e.g. DEV-2181)"
required: true
type: string
repository_dispatch:
types: [e2e-flake-fix]
concurrency:
# One in-flight run per Linear issue. Belt-and-suspenders alongside the branch-existence
# dedup the command itself performs.
group: e2e-flake-fix-${{ github.event.inputs.issue || github.event.client_payload.issue }}
cancel-in-progress: false
jobs:
flake-fix:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
# 3 attempts x 2 stress runs (burn_in=50) can run for hours. If this bumps the runner's
# job ceiling, decompose via workflow_run completion events + --resume (see DEV-2182).
timeout-minutes: 360
permissions:
contents: write
pull-requests: write
id-token: write
steps:
- name: Resolve Linear issue ref
id: ref
env:
DISPATCH_ISSUE: ${{ github.event.inputs.issue }}
PAYLOAD_ISSUE: ${{ github.event.client_payload.issue }}
run: |
if [ "${{ github.event_name }}" = "repository_dispatch" ]; then
REF="$PAYLOAD_ISSUE"
else
REF="$DISPATCH_ISSUE"
fi
if [ -z "$REF" ]; then
echo "::error::No Linear issue ref supplied"
exit 1
fi
echo "ref=$REF" >> "$GITHUB_OUTPUT"
echo "branch=automated-e2e-flake-fix-$REF" >> "$GITHUB_OUTPUT"
echo "Flake fix for Linear issue: $REF"
# Check out metabase itself with the Metabase Automation token so the agent's
# git push / gh dispatch run as that user (a PAT, so it triggers the stress workflow).
- uses: actions/checkout@v6
with:
token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
fetch-depth: 0
- name: Dedup — skip if the fix branch already exists
id: dedup
env:
BRANCH: ${{ steps.ref.outputs.branch }}
run: |
if git ls-remote --exit-code --heads origin "$BRANCH" >/dev/null 2>&1; then
echo "::notice::$BRANCH already exists — a run is in flight or already landed. Skipping."
echo "exists=true" >> "$GITHUB_OUTPUT"
else
echo "exists=false" >> "$GITHUB_OUTPUT"
fi
- name: Configure git identity (Metabase Automation)
if: steps.dedup.outputs.exists == 'false'
run: |
git config --global user.name "Metabase Automation"
git config --global user.email "github-automation@metabase.com"
# Make the Linear MCP available to the agent (it prefers MCP, falls back to the
# REST/GraphQL API with the same key when MCP is absent).
- name: Register Linear MCP server
if: steps.dedup.outputs.exists == 'false'
env:
LINEAR_API_KEY: ${{ secrets.LINEAR_API_KEY }}
run: |
jq -n \
--arg key "$LINEAR_API_KEY" \
'{
mcpServers: {
"linear-server": {
url: "https://mcp.linear.app/mcp",
type: "http",
headers: { Authorization: ("Bearer " + $key) }
}
}
}' > ~/.claude.json
# Fail fast if the model API is unreachable or the key is bad / over quota.
- name: Preflight — model API reachable & authorized
if: steps.dedup.outputs.exists == 'false'
env:
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY_E2E_FLAKE_FIX }}
LINEAR_API_KEY: ${{ secrets.LINEAR_API_KEY }}
run: |
code=$(curl -sS -o /dev/null -w '%{http_code}' --max-time 15 \
https://api.anthropic.com/v1/models \
-H "x-api-key: $ANTHROPIC_API_KEY" \
-H "anthropic-version: 2023-06-01") \
|| { echo "::error::Anthropic API unreachable (connect/timeout) — runner egress likely blocked"; exit 1; }
echo "Anthropic /v1/models -> HTTP $code"
case "$code" in
200) ;;
401|403) echo "::error::Anthropic API auth failed (HTTP $code) — check ANTHROPIC_FLAKE_FIX_API_KEY"; exit 1 ;;
429) echo "::error::Anthropic API rate limited / over quota (HTTP $code)"; exit 1 ;;
*) echo "::error::Anthropic API unexpected status $code"; exit 1 ;;
esac
# Linear is non-fatal: surface egress/auth trouble without blocking an otherwise-fine run
# (the live path uses Bearer auth via MCP; this raw-key GraphQL probe may differ).
lcode=$(curl -sS -o /dev/null -w '%{http_code}' --max-time 15 \
-X POST https://api.linear.app/graphql \
-H "Authorization: $LINEAR_API_KEY" \
-H "Content-Type: application/json" \
--data '{"query":"{ viewer { id } }"}') \
|| { echo "::warning::Linear API unreachable (connect/timeout)"; lcode=000; }
echo "Linear /graphql -> HTTP $lcode"
[ "$lcode" = "200" ] || echo "::warning::Linear API check returned HTTP $lcode — not blocking"
- name: Run /fix-flaky-test with Claude Code
id: claude
if: steps.dedup.outputs.exists == 'false'
continue-on-error: true
uses: anthropics/claude-code-action@787c5a0ce96a9a6cfb050ea0c8f4c05f2447c251 # v1.0.133
env:
GH_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
GITHUB_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
LINEAR_API_KEY: ${{ secrets.LINEAR_API_KEY }}
GITHUB_ACTIONS_RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
timeout-minutes: 350
with:
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY_E2E_FLAKE_FIX }}
github_token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
allowed_bots: linear
prompt: |
Read and follow the instructions in .claude/commands/fix-flaky-test.md to fix the
flaky e2e test tracked by Linear issue ${{ steps.ref.outputs.ref }}. Treat
"${{ steps.ref.outputs.ref }}" as the command's $ARGUMENTS.
## CI Environment Notes
- You are running headlessly in GitHub Actions as the "Metabase Automation" user.
git, gh, and the Linear MCP are pre-configured — no human is watching, so never
ask for approval. The branch-existence dedup gate in Phase 0 is the only go/no-go.
- The fix branch is `${{ steps.ref.outputs.branch }}`.
- Polling: `ScheduleWakeup` is not available here. Instead, block on the stress runs
with `gh run watch <run-id> --exit-status` (the job is long-lived by design).
- NEVER merge: do not run `gh pr merge` or enable auto-merge. Stop at a green,
review-ready PR. A human owns the merge.
- If a phase fails catastrophically, post the failure (with GITHUB_ACTIONS_RUN_URL)
to the Linear issue before exiting, per the command's audit-trail step.
claude_args: >-
--allowedTools
"Glob,
Grep,
Read,
ToolSearch,
Skill(*),
WebFetch(domain:github.com),
Edit(//./**),
Edit(/tmp/**),
Write(//./**),
Write(/tmp/**),
Bash(cat *),
Bash(cd *),
Bash(diff *),
Bash(echo *),
Bash(find *),
Bash(gh *),
Bash(git *),
Bash(grep *),
Bash(head *),
Bash(jq *),
Bash(ls *),
Bash(mkdir *),
Bash(printf *),
Bash(sed *),
Bash(sort *),
Bash(tail *),
Bash(tee *),
Bash(wc *),
Bash(which *),
mcp__linear-server__get_issue,
mcp__linear-server__list_comments,
mcp__linear-server__list_issues,
mcp__linear-server__save_comment,
mcp__linear-server__create_attachment_from_upload"
--disallowedTools "Bash(gh pr merge*),Bash(git push origin master*),Bash(rm -rf /*)"
- name: Verify the run did not crash
if: steps.dedup.outputs.exists == 'false'
run: |
if [ "${{ steps.claude.outcome }}" = "failure" ]; then
echo "::error::Claude Code crashed or exited with an error"
exit 1
fi
echo "Flake-fix run completed (see the Linear issue for the audit trail and PR)."

View File

@@ -26,7 +26,7 @@ concurrency:
jobs:
migrations-h2-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: h2
@@ -40,7 +40,7 @@ jobs:
migrations-postgres-14-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: postgres
@@ -66,7 +66,7 @@ jobs:
migrations-postgres-latest-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: postgres
@@ -92,7 +92,7 @@ jobs:
migrations-mysql-8-0-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: mysql
@@ -117,7 +117,7 @@ jobs:
migrations-mysql-latest-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: mysql
@@ -143,7 +143,7 @@ jobs:
migrations-mariadb-10-6-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: mysql
@@ -168,7 +168,7 @@ jobs:
migrations-mariadb-latest-ee:
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
timeout-minutes: 15
env:
CI: 'true'
MB_DB_TYPE: mysql

22
.github/workflows/docs-generate-63.yml vendored Normal file
View File

@@ -0,0 +1,22 @@
name: Auto-update documentation (release)
on:
schedule:
- cron: "0 23 * * 1-5" # Every Monday through Friday at 11 PM UTC
workflow_dispatch:
inputs:
target_branch:
description: "Target branch for documentation update"
required: false
default: "release-x.63.x"
type: string
jobs:
update-release-docs:
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
name: Call documentation update for release branch
uses: ./.github/workflows/docs-generate-base.yml
with:
target_branch: ${{ inputs.target_branch || 'release-x.63.x' }}
secrets:
automation_token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}

View File

@@ -11,6 +11,13 @@ concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}-drivers
cancel-in-progress: true
# Exposed to every driver job so the test-driver action can report failures to
# ci-conductor (secrets: inherit is already set on the drivers call in
# run-tests.yml). See DEV-2224.
env:
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
jobs:
# This job determines which driver tests should run based on PR context.
# All decision logic is consolidated in mage driver-decisions.
@@ -39,6 +46,7 @@ jobs:
sqlserver-should-run: ${{ steps.driver-decisions.outputs.sqlserver-should-run }}
vertica-should-run: ${{ steps.driver-decisions.outputs.vertica-should-run }}
# Per-driver configured status from ci-test-config (skip | info | required)
h2-status: ${{ steps.driver-decisions.outputs.h2-status }}
athena-status: ${{ steps.driver-decisions.outputs.athena-status }}
bigquery-status: ${{ steps.driver-decisions.outputs.bigquery-status }}
clickhouse-status: ${{ steps.driver-decisions.outputs.clickhouse-status }}
@@ -49,6 +57,7 @@ jobs:
mongo-sharded-cluster-status: ${{ steps.driver-decisions.outputs.mongo-sharded-cluster-status }}
mysql-mariadb-status: ${{ steps.driver-decisions.outputs.mysql-mariadb-status }}
oracle-status: ${{ steps.driver-decisions.outputs.oracle-status }}
postgres-status: ${{ steps.driver-decisions.outputs.postgres-status }}
presto-jdbc-status: ${{ steps.driver-decisions.outputs.presto-jdbc-status }}
redshift-status: ${{ steps.driver-decisions.outputs.redshift-status }}
snowflake-status: ${{ steps.driver-decisions.outputs.snowflake-status }}
@@ -129,7 +138,7 @@ jobs:
./bin/mage -driver-decisions "${MAGE_ARGS[@]}" --github-output-only >> $GITHUB_OUTPUT
env:
BASE_REF: ${{ github.event.pull_request.base.ref || github.ref_name }}
IS_MASTER_OR_RELEASE: ${{ github.ref_name == 'master' || startsWith(github.ref_name, 'release-') }}
IS_MASTER_OR_RELEASE: ${{ github.ref_name == 'master' || startsWith(github.ref_name, 'release-x') }}
shell: bash
be-tests-athena-ee:
@@ -170,6 +179,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.athena-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -183,6 +194,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.athena-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-bigquery-cloud-sdk-ee:
needs: determine-driver-skips
@@ -246,6 +258,8 @@ jobs:
junit-name: 'be-tests-bigquery-cloud-sdk-ee'
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.bigquery-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -259,6 +273,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.bigquery-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -331,6 +346,8 @@ jobs:
junit-name: 'be-tests-clickhouse-ee'
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.clickhouse-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -342,6 +359,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.clickhouse-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -385,6 +404,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -396,12 +417,39 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-databricks-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.databricks-should-run == 'true' || needs.determine-driver-skips.outputs.databricks-quarantine-conflict == 'true' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
matrix:
job:
- name: Driver Tests Part 1
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 0
- name: Driver Tests Part 2
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 1
- name: Driver Tests Part 3
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 2
env:
CI: 'true'
DRIVERS: databricks
@@ -430,9 +478,9 @@ jobs:
uses: ./.github/actions/test-driver
with:
junit-name: 'be-tests-databricks-ee'
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
test-args: ${{ matrix.job.test-args }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -446,12 +494,38 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-databricks-multi-catalog-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.databricks-should-run == 'true' || needs.determine-driver-skips.outputs.databricks-quarantine-conflict == 'true' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
matrix:
job:
- name: Driver Tests Part 1
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 0
- name: Driver Tests Part 2
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 1
- name: Driver Tests Part 3
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:fail-fast? true
:partition/total 3
:partition/index 2
env:
CI: 'true'
DRIVERS: databricks
@@ -481,9 +555,9 @@ jobs:
uses: ./.github/actions/test-driver
with:
junit-name: 'be-tests-databricks-multi-catalog-ee'
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
test-args: ${{ matrix.job.test-args }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -497,6 +571,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.databricks-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-h2:
needs: determine-driver-skips
@@ -516,6 +591,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -527,6 +604,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-h2-oss:
needs: determine-driver-skips
@@ -547,6 +626,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -558,6 +639,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.h2-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mysql-mariadb:
needs: determine-driver-skips
@@ -620,7 +703,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -677,6 +760,8 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -688,6 +773,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -757,6 +844,8 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -768,6 +857,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -839,6 +930,8 @@ jobs:
test-args: >-
:exclude-tags '[:mongo-sharded-cluster-tests :mb/transforms-python-test]'
:only-tags [:mb/driver-tests]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -850,6 +943,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-mongo-sharded-cluster-ee:
needs: determine-driver-skips
@@ -884,6 +979,8 @@ jobs:
junit-name: 'be-tests-mongo-sharded-cluster-ee'
test-args: >-
:only metabase.driver.mongo.sharded-cluster-test
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -895,6 +992,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-oracle:
needs: determine-driver-skips
@@ -969,6 +1068,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.oracle-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -980,6 +1081,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.oracle-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-postgres:
needs: determine-driver-skips
@@ -1022,7 +1125,7 @@ jobs:
github.event_name == 'push' &&
(
github.ref_name == 'master' ||
startsWith(github.ref_name, 'release-')
startsWith(github.ref_name, 'release-x')
) &&
''
) ||
@@ -1073,6 +1176,8 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.postgres-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1084,6 +1189,9 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.postgres-status }}
report-variant: ${{ matrix.version.name }}-${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: always()
uses: ./.github/actions/cleanup-python-runner
@@ -1160,6 +1268,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1171,6 +1281,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-redshift-ee:
needs: determine-driver-skips
@@ -1244,6 +1356,8 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.redshift-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: ${{ !matrix.job.skip && !cancelled() }}
@@ -1257,6 +1371,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.redshift-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1276,8 +1391,11 @@ jobs:
- name: Driver Tests
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
:exclude-tags '[:mb/upload-tests :mb/transforms-python-test]'
:fail-fast? true
- name: Upload Tests
test-args: >-
:only-tags [:mb/upload-tests]
- name: Transforms Python Tests
test-args: >-
:only-tags [:mb/transforms-python-test]
@@ -1326,6 +1444,8 @@ jobs:
junit-name: 'be-tests-snowflake-ee'
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.job.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.snowflake-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1339,6 +1459,7 @@ jobs:
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.snowflake-status }}
report-variant: ${{ matrix.job.name }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1380,6 +1501,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.sparksql-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1391,6 +1514,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.sparksql-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-sqlite-ee:
needs: determine-driver-skips
@@ -1405,7 +1530,7 @@ jobs:
- name: Fail on quarantine conflict
if: ${{ needs.determine-driver-skips.outputs.sqlite-quarantine-conflict == 'true' }}
run: |
echo "::error::SQLite driver is quarantined but you changed files in modules/drivers/sqlite/"
echo "::error::SQLite driver is quarantined but you changed files that affect it"
echo ""
echo "Your changes will NOT be tested because the driver is currently quarantined."
echo "To run SQLite tests, add the label: break-quarantine-sqlite"
@@ -1421,6 +1546,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlite-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1432,6 +1559,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlite-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
be-tests-sqlserver:
needs: determine-driver-skips
@@ -1497,6 +1626,8 @@ jobs:
junit-name: ${{ matrix.version.junit-name }}
test-args: ${{ matrix.job.test-args }}
logs-artifact-suffix: ${{ matrix.version.name }}
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlserver-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1508,6 +1639,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.sqlserver-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Cleanup python-runner
if: ${{ always() && matrix.job.needs-python-runner == true }}
uses: ./.github/actions/cleanup-python-runner
@@ -1622,6 +1755,8 @@ jobs:
test-args: >-
:only-tags [:mb/driver-tests]
:exclude-tags [:mb/transforms-python-test]
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
driver-status: ${{ needs.determine-driver-skips.outputs.vertica-status }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -1633,6 +1768,8 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
driver-status: ${{ needs.determine-driver-skips.outputs.vertica-status }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
drivers-tests-result:
needs:
@@ -1686,11 +1823,13 @@ jobs:
"be-tests-clickhouse-ee": "${{ needs.determine-driver-skips.outputs.clickhouse-status }}",
"be-tests-databricks-ee": "${{ needs.determine-driver-skips.outputs.databricks-status }}",
"be-tests-druid-jdbc-ee": "${{ needs.determine-driver-skips.outputs.druid-jdbc-status }}",
"be-tests-h2": "${{ needs.determine-driver-skips.outputs.h2-status }}",
"be-tests-mongo": "${{ needs.determine-driver-skips.outputs.mongo-status }}",
"be-tests-mongo-ssl": "${{ needs.determine-driver-skips.outputs.mongo-ssl-status }}",
"be-tests-mongo-sharded-cluster-ee": "${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-status }}",
"be-tests-mysql-mariadb": "${{ needs.determine-driver-skips.outputs.mysql-mariadb-status }}",
"be-tests-oracle": "${{ needs.determine-driver-skips.outputs.oracle-status }}",
"be-tests-postgres": "${{ needs.determine-driver-skips.outputs.postgres-status }}",
"be-tests-presto-jdbc-ee": "${{ needs.determine-driver-skips.outputs.presto-jdbc-status }}",
"be-tests-redshift-ee": "${{ needs.determine-driver-skips.outputs.redshift-status }}",
"be-tests-snowflake-ee": "${{ needs.determine-driver-skips.outputs.snowflake-status }}",

View File

@@ -0,0 +1,145 @@
name: E2E Coverage Manifest
# Nightly: builds an instrumented frontend, runs the e2e suite sharded to
# record which source files each spec exercises, and publishes a spec -> files
# manifest used for selective e2e runs on PRs.
#
# Isolated from the PR e2e path on purpose - the per-shard worker
# (e2e-coverage-shard.yml) is a dedicated, trimmed copy so coverage runs can
# never affect PR test results.
on:
schedule:
# Nightly, after the day's merges have settled (UTC).
- cron: "0 7 * * *"
workflow_dispatch:
inputs:
edition:
description: "Edition to instrument"
type: choice
options: ["ee", "oss"]
default: "ee"
concurrency:
group: e2e-coverage-manifest-${{ github.ref }}
cancel-in-progress: true
jobs:
build-instrumented:
name: Build instrumented uberjar
runs-on: ubuntu-22.04
timeout-minutes: 60
env:
MB_EDITION: ${{ inputs.edition || 'ee' }}
INSTRUMENT_COVERAGE: "true"
steps:
- uses: actions/checkout@v6
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
# build.clj forwards INSTRUMENT_COVERAGE to the rspack build, so only the
# bundled FE is instrumented; everything else builds normally.
- name: Build instrumented uberjar
run: ./bin/build.sh
- name: Upload instrumented uberjar
uses: actions/upload-artifact@v7
with:
name: instrumented-uberjar
path: target/uberjar/metabase.jar
retention-days: 1
# Fixed-N sharding — coverage doesn't need the PR matrix-builder's tag/edition
# groups, just an even split of the regular spec set. The shard count lives in
# one place (SHARDS below); the matrix is generated from it.
setup:
name: Build shard matrix
runs-on: ubuntu-22.04
outputs:
matrix: ${{ steps.gen.outputs.matrix }}
count: ${{ steps.gen.outputs.count }}
steps:
- id: gen
env:
SHARDS: 100
run: |
matrix=$(node -e "console.log(JSON.stringify({split_index:[...Array(Number(process.env.SHARDS)).keys()]}))")
echo "matrix=$matrix" >> "$GITHUB_OUTPUT"
echo "count=$SHARDS" >> "$GITHUB_OUTPUT"
shards:
name: Shard
needs: [build-instrumented, setup]
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
uses: ./.github/workflows/e2e-coverage-shard.yml
secrets: inherit
with:
edition: ${{ inputs.edition || 'ee' }}
total_chunks: ${{ fromJson(needs.setup.outputs.count) }}
split_index: ${{ matrix.split_index }}
merge:
name: Merge and publish manifest
needs: shards
if: always()
runs-on: ubuntu-22.04
timeout-minutes: 15
# github-script lists/downloads the previous manifest artifact.
permissions:
actions: read
contents: read
steps:
- uses: actions/checkout@v6
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
# merge-multiple unions every shard's per-spec dir into one tree; the
# per-spec file design means no conflict resolution is needed.
- name: Download all shard coverage
uses: actions/download-artifact@v8
with:
pattern: coverage-shard-*
path: e2e/coverage-manifest-raw
merge-multiple: true
# Backfill source: the newest existing manifest is the previous nightly
# (this run hasn't uploaded yet). build-coverage-manifest.mjs carries over
# any still-existing spec that didn't run today.
- name: Download previous manifest for backfill
id: prev
uses: actions/github-script@v9
with:
script: | # js
const fs = require("fs");
const { owner, repo } = context.repo;
const { data } = await github.rest.actions.listArtifactsForRepo({
owner, repo, name: "spec-file-manifest", per_page: 20,
});
const art = (data.artifacts ?? [])
.filter((a) => !a.expired)
.sort((a, b) => new Date(b.created_at) - new Date(a.created_at))[0];
if (!art) {
console.log("No previous manifest; nothing to backfill.");
return;
}
const dl = await github.rest.actions.downloadArtifact({
owner, repo, artifact_id: art.id, archive_format: "zip",
});
fs.writeFileSync("prev-manifest.zip", Buffer.from(dl.data));
core.setOutput("found", "true");
- name: Unzip previous manifest
if: steps.prev.outputs.found == 'true'
run: unzip -o prev-manifest.zip -d prev-manifest
# GITHUB_SHA (the master commit this nightly built from) is stamped into
# the manifest as `builtAt`, so a PR can later pick the manifest closest
# to its own point in history. See resolve-coverage-manifest.mjs.
- name: Build coverage manifest
env:
PREV_MANIFEST: ${{ steps.prev.outputs.found == 'true' && 'prev-manifest/spec-file-manifest.json' || '' }}
run: node e2e/coverage/build-coverage-manifest.mjs
- name: Upload manifest
uses: actions/upload-artifact@v7
with:
name: spec-file-manifest
path: e2e/coverage/spec-file-manifest.json
retention-days: 30

112
.github/workflows/e2e-coverage-shard.yml vendored Normal file
View File

@@ -0,0 +1,112 @@
name: E2E Coverage Shard
# Reusable per-shard worker for the coverage manifest run. Trimmed extract of
# e2e-test.yml: runs one cypress-split shard against an instrumented build and
# uploads that shard's per-spec coverage. Intentionally omits the PR-only
# concerns (failed-spec retry, Trunk quarantine, S3 result upload, timing
# output) since this is a nightly, non-blocking job.
on:
workflow_call:
inputs:
edition:
type: string
default: ee
total_chunks:
type: number
required: true
split_index:
type: number
required: true
env:
DISPLAY: ""
TERM: xterm
TZ: US/Pacific
INSTRUMENT_COVERAGE: "true"
jobs:
run:
runs-on: ubuntu-22.04
timeout-minutes: 60
name: coverage-shard-${{ inputs.split_index }}
env:
MB_EDITION: ${{ inputs.edition }}
CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}
CYPRESS_MB_STARTER_CLOUD_TOKEN: ${{ secrets.STAGING_MB_STARTER_CLOUD_TOKEN }}
CYPRESS_MB_PRO_CLOUD_TOKEN: ${{ secrets.STAGING_MB_PRO_CLOUD_TOKEN }}
CYPRESS_MB_PRO_SELF_HOSTED_TOKEN: ${{ secrets.STAGING_MB_PRO_SELF_HOSTED_TOKEN }}
steps:
- uses: actions/checkout@v6
with:
submodules: true
token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
- name: Prepare Docker containers
uses: ./.github/actions/e2e-prepare-containers
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
maildev: true
openldap: true
webhook: true
snowplow: true
postgres: true
mysql: true
mongo: true
# The orchestrator built and uploaded this in an earlier job of the same run.
- name: Download instrumented uberjar
uses: actions/download-artifact@v8
with:
name: instrumented-uberjar
path: target/uberjar
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- name: Prepare Cypress environment
id: cypress-prep
uses: ./.github/actions/prepare-cypress
- name: Compile CLJS
run: bun run build-pure:cljs
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
- name: Generate database snapshots
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: node e2e/runner/run_cypress_ci.js snapshot
# cypress-split divides the spec set by timing data; INSTRUMENT_COVERAGE
# makes the support hook drain __coverage__ into e2e/coverage-manifest-raw/.
- name: Run shard ${{ inputs.split_index }}
# No SPLIT_FILE: cypress-split shards evenly by spec count using
# SPLIT/SPLIT_INDEX alone. Omitting it means no timings are read or
# written, which avoids cypress-split's after:run writeback (it would
# otherwise try to overwrite ./e2e/support/timings.json from a cwd where
# that subpath isn't reachable, crashing the run). Even-by-count is fine
# here — every spec runs exactly once across the shards.
env:
SPLIT: ${{ inputs.total_chunks }}
SPLIT_INDEX: ${{ inputs.split_index }}
SPLIT_SUMMARY: false
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: |
node e2e/runner/run_cypress_ci.js e2e \
--expose grepTags="-@mongo+-@python+-@OSS+-@skip"
# Don't let a single failing/flaky spec abort the shard — we still want
# coverage from the specs that did run.
continue-on-error: true
- name: Upload shard coverage
if: always()
uses: actions/upload-artifact@v7
with:
name: coverage-shard-${{ inputs.split_index }}
path: e2e/coverage-manifest-raw/
retention-days: 7
if-no-files-found: warn

View File

@@ -46,7 +46,7 @@ jobs:
const { buildMatrix } = require('${{ github.workspace }}/.github/scripts/build-e2e-matrix.js');
const inputSpecs = "${{ inputs.specs }}";
const inputChunks = Number(process.env.chunks);
const java = 21;
const java = 25;
const defaultRunner = "${{ vars.DEFAULT_RUNNER_KEY }}";
const options = {
java,

View File

@@ -41,6 +41,49 @@ on:
type: boolean
required: false
default: false
# Reusable form so other workflows (e.g. the flaky-test-fix PR auto-runner) can fan a
# matrix of changed specs into individual stress runs. Inputs mirror workflow_dispatch;
# both triggers read them via the `inputs` context.
workflow_call:
inputs:
spec:
description: "Relative path of the target spec"
type: string
required: true
burn_in:
description: "Number of times to run the test (e.g. 20)"
type: string
required: false
default: "20"
grep:
description: "Grep and filter tests to run in isolation"
type: string
required: false
mb_edition:
description: 'Set MB_EDITION env var to "ee" (enterprise) or "oss" (open-source)'
type: string
required: false
default: "ee"
qa_db:
description: "Whether to set up and include external QA databases"
type: boolean
required: false
default: false
enable_network_throttling:
description: "Enable network throttling simulation (4g slow like in chrome dev tools)"
type: boolean
required: false
default: true
fail_fast:
description: "Stop running remaining tests after the first failure"
type: boolean
required: false
default: false
build_jar:
description: "Build the uberjar from this branch (required to test frontend fixes) instead of downloading a prebuilt one"
type: boolean
required: false
default: false
jobs:
determine-test-type:
@@ -160,13 +203,13 @@ jobs:
# For all options and fine-grained control, take a look at the documentation
# https://github.com/cypress-io/cypress/tree/develop/npm/grep
- name: Stress-test ${{ github.event.inputs.spec }} ${{ github.event.inputs.burn_in }} times
- name: Stress-test ${{ inputs.spec }} ${{ inputs.burn_in }} times
env:
GREP: ${{ github.event.inputs.grep }}
GREP: ${{ inputs.grep }}
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
FAIL_FAST: ${{ inputs.fail_fast }}
SPEC: ${{ github.event.inputs.spec }}
BURN_IN: ${{ github.event.inputs.burn_in }}
SPEC: ${{ inputs.spec }}
BURN_IN: ${{ inputs.burn_in }}
run: |
node e2e/runner/run_cypress_ci.js ${{ needs.determine-test-type.outputs.type }} \
--spec "${SPEC}" \

View File

@@ -0,0 +1,94 @@
name: E2E Stress Test (flaky-test-fix PR)
# Auto-runs the e2e stress test on every changed Cypress spec in a PR
on:
pull_request:
# `opened`/`reopened` catch PRs created already labelled; `labeled` catches the label
# being added later; `synchronize` re-burns after new commits while the label is set.
types: [opened, reopened, synchronize, labeled]
concurrency:
# One in-flight set of stress runs per PR branch — new commits cancel the previous burn.
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
detect-changed-specs:
name: Detect changed e2e specs
# The PR must carry the `flaky-test-fix` label (covers opened/reopened/synchronize), AND
# when this is a `labeled` event we only proceed if the label *just added* is
# `flaky-test-fix` — otherwise adding any unrelated label to an already-labelled
# PR would needlessly re-burn the whole stress matrix.
if: >-
contains(github.event.pull_request.labels.*.name, 'flaky-test-fix') &&
(github.event.action != 'labeled' || github.event.label.name == 'flaky-test-fix')
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
outputs:
# JSON array of spec paths, consumed by the matrix below.
specs: ${{ steps.detect.outputs.specs }}
should_run: ${{ steps.detect.outputs.should_run }}
# burn-50 / burn-100 labels bump the burn-in past 20
burn_in: >-
${{ contains(github.event.pull_request.labels.*.name, 'burn-100') && '100'
|| contains(github.event.pull_request.labels.*.name, 'burn-50') && '50'
|| '20' }}
steps:
- name: Detect changed Cypress spec files
id: detect
env:
GH_TOKEN: ${{ github.token }}
REPO: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: | # sh
# List every file in the PR, drop deletions, then keep only regular e2e Cypress
# specs: paths under e2e/ ending in .cy.spec.{js,ts,tsx}, excluding the
# embedding-SDK component specs under e2e/test-component/ (those use a different
# runner and are out of scope here). The greps are guarded with `|| true` so an
# empty match doesn't trip `pipefail`.
FILES=$(
gh api "repos/${REPO}/pulls/${PR_NUMBER}/files" \
--paginate \
--jq '.[] | select(.status != "removed") | .filename' \
| { grep -E '^e2e/.*\.cy\.spec\.(js|ts|tsx)$' || true; } \
| { grep -v '^e2e/test-component/' || true; } \
| sort -u
)
if [[ -z "$FILES" ]]; then
echo "No changed e2e Cypress spec files found — nothing to stress test."
echo "should_run=false" >> "$GITHUB_OUTPUT"
exit 0
fi
echo "Changed e2e Cypress specs:"
echo "$FILES" | sed 's/^/ - /'
# Compact JSON array for the matrix, e.g. ["e2e/test/scenarios/a.cy.spec.js"].
SPECS_JSON=$(echo "$FILES" | jq -R . | jq -cs .)
echo "specs=${SPECS_JSON}" >> "$GITHUB_OUTPUT"
echo "should_run=true" >> "$GITHUB_OUTPUT"
echo "Note: you can use the burn-50 or burn-100 labels to increase the burn-in count from the default of 20." >> $GITHUB_STEP_SUMMARY
stress-test:
name: Stress test
needs: detect-changed-specs
if: needs.detect-changed-specs.outputs.should_run == 'true'
strategy:
# Don't let one flaky spec (or one throttling regime) cancel the burn-in of the others.
fail-fast: false
matrix:
spec: ${{ fromJson(needs.detect-changed-specs.outputs.specs) }}
# Burn each spec with and without throttle
enable_network_throttling: [true, false]
uses: ./.github/workflows/e2e-stress-test-flake-fix.yml
secrets: inherit
with:
spec: ${{ matrix.spec }}
burn_in: ${{ needs.detect-changed-specs.outputs.burn_in }}
qa_db: true
mb_edition: ee
build_jar: true
enable_network_throttling: ${{ matrix.enable_network_throttling }}

View File

@@ -37,10 +37,11 @@ env:
HASH: ${{ github.event.pull_request.head.sha || github.sha }}-${{ github.run_attempt }}
PR_NUMBER: ${{ github.event.pull_request.number || '' }}
JOB_NAME: ${{ inputs.name }}
# ci-conductor failed-tests reporting (DEV-1999). Secret holds the webhooks
# base URL (".../webhooks"); the reporter appends the endpoint. Callers pass
# ci-conductor reporting (DEV-1999). Secret holds the base origin
# (e.g. "https://conductor.<host>"); each consumer appends the path it needs
# (the reporter POSTs to "/webhooks/failed-tests"). Callers pass
# `secrets: inherit`; reporting no-ops when it's unset.
CI_CONDUCTOR_WEBHOOK_URL: ${{ secrets.CI_CONDUCTOR_WEBHOOK_URL }}
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
# Shared secret sent as the `x-internal-secret` header to authenticate.
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
REPO_ID: ${{ github.event.repository.id }}
@@ -58,6 +59,11 @@ jobs:
name: e2e-tests-${{ inputs.name }}-${{ inputs.edition }}
env:
MB_EDITION: ${{ inputs.edition }}
# Absolute path for the quarantine failures file (DEV-2082). The after:spec
# recorder runs in Cypress' plugins process, whose cwd differs from the
# workspace where the gate step runs; an absolute path anchored to the
# workspace makes both agree regardless of cwd.
QUARANTINE_FAILURES_FILE: ${{ github.workspace }}/target/quarantine-failures.jsonl
# Sensitive env vars (tokens, secrets) starting with `CYPRESS_` are accessed via async `cy.env()`
# Example: `cy.env(["FOO"]).then(({ FOO }) => ...)`
# For non-sensitive config, use `Cypress.expose()` in cypress config instead (synchronous)
@@ -158,9 +164,7 @@ jobs:
node e2e/runner/run_cypress_ci.js e2e \
--expose grepTags="-@mongo+-@python+-@OSS+-@skip" \
--spec "$SPEC_PATH"
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Run Tagged EE Cypress tests on ${{ inputs.name }}
@@ -173,11 +177,9 @@ jobs:
run: |
echo "Running tests with specs: $SPEC_PATH"
node e2e/runner/run_cypress_ci.js e2e \
--expose grepTags="${{inputs.tags && format('{0}+-@skip', inputs.tags) || '-@skip'}}" \
--expose grepTags="${{inputs.tags && format('{0}+-@skip', inputs.tags) || '-@mongo+-@python+-@OSS+-@skip'}}" \
--spec "$SPEC_PATH"
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Rewrite JUnit hook failures
@@ -207,6 +209,18 @@ jobs:
variant: e2e-tests
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ inputs.specs && steps.tagged-e2e.outcome || steps.split-e2e.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Quarantine gate
# Only one of the two run steps executes; the other reports `skipped`. Only gate on actual failure.
if: ${{ !cancelled() && (steps.split-e2e.outcome == 'failure' || steps.tagged-e2e.outcome == 'failure') }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: e2e
test-suite: e2e
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: Upload Cypress Artifacts upon failure
uses: actions/upload-artifact@v7

View File

@@ -8,6 +8,12 @@ env:
TERM: xterm
TZ: US/Pacific # to make Node match the instance tz
MB_EDITION: "ee"
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
REPO_ID: ${{ github.event.repository.id }}
COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
TARGET_BRANCH: ${{ github.event.pull_request.base.ref || github.ref_name }}
QUARANTINE_FAILURES_FILE: ${{ github.workspace }}/target/quarantine-failures.jsonl
jobs:
sdk-component-tests:
@@ -19,6 +25,7 @@ jobs:
react-version: [18, 19]
fail-fast: false
env:
CI_CONDUCTOR_TEST_SUITE: embedding-sdk-component-react-${{ matrix.react-version }}
# Sensitive env vars (tokens, secrets) starting with `CYPRESS_` are accessed via async `cy.env()`
# Example: `cy.env(["FOO"]).then(({ FOO }) => ...)`
# For non-sensitive config, use `Cypress.expose()` in cypress config instead (synchronous)
@@ -69,6 +76,8 @@ jobs:
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
- uses: ./.github/actions/resolve-job-id
- name: Make app db snapshot
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
@@ -86,6 +95,8 @@ jobs:
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: node e2e/runner/run_cypress_ci.js component
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Rewrite JUnit hook failures
if: always()
@@ -111,10 +122,21 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: e2e
test-suite: ${{ env.CI_CONDUCTOR_TEST_SUITE }}
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: "SDK component tests > Upload Cypress Artifacts upon failure"
uses: actions/upload-artifact@v7
if: failure()
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
with:
name: cypress-recording-embedding-sdk-react-${{ matrix.react-version }}
path: |
@@ -123,7 +145,7 @@ jobs:
if-no-files-found: ignore
- name: "SDK component tests > Publish Summary"
if: failure()
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
uses: actions/github-script@v9
with:
script: | #js
@@ -168,6 +190,7 @@ jobs:
env:
MB_RUN_MODE: "e2e"
METASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}
CI_CONDUCTOR_TEST_SUITE: embedding-sdk-component-backward-compatibility
# Sensitive env vars (tokens, secrets) starting with `CYPRESS_` are accessed via async `cy.env()`
# Example: `cy.env(["FOO"]).then(({ FOO }) => ...)`
# For non-sensitive config, use `Cypress.expose()` in cypress config instead (synchronous)
@@ -237,6 +260,8 @@ jobs:
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
- uses: ./.github/actions/resolve-job-id
- name: Make app db snapshot
env:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
@@ -252,6 +277,8 @@ jobs:
run: |
node e2e/runner/run_cypress_ci.js component \
--expose grepTags="-@skip-backward-compatibility"
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Rewrite JUnit hook failures
if: always()
@@ -277,10 +304,21 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: e2e
test-suite: ${{ env.CI_CONDUCTOR_TEST_SUITE }}
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: Upload Cypress Artifacts upon failure
uses: actions/upload-artifact@v7
if: failure()
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
with:
name: cypress-recording-embedding-sdk-cross-version
path: |
@@ -289,7 +327,7 @@ jobs:
if-no-files-found: ignore
- name: Publish Summary
if: failure()
if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
uses: actions/github-script@v9
with:
script: | #js

View File

@@ -171,6 +171,8 @@ jobs:
- name: Log free disk space
run: df -h /
- uses: ./.github/actions/resolve-job-id
- name: Run e2e tests for Sample App
id: run-e2e-tests
if: ${{ steps.check-sample-app-branch.outputs.sample_app_branch_exists == 'true' }}
@@ -238,6 +240,8 @@ jobs:
shoppy-datadog-application-id: ${{ secrets.SHOPPY_METABASE_APP_DATADOG_APPLICATION_ID }}
shoppy-datadog-client-token: ${{ secrets.SHOPPY_METABASE_APP_DATADOG_CLIENT_TOKEN }}
- uses: ./.github/actions/resolve-job-id
- name: Run e2e tests for Shoppy
id: run-e2e-tests
if: ${{ steps.shoppy-prep.outputs.sample_app_branch_exists == 'true' }}
@@ -316,6 +320,8 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: ./.github/actions/resolve-job-id
- name: Run synthetic monitoring tests
id: run-e2e-tests
if: ${{ steps.shoppy-prep.outputs.sample_app_branch_exists == 'true' }}
@@ -363,6 +369,19 @@ jobs:
timeout-minutes: 45
name: e2e-host-app-${{ matrix.test_suite }}-tests-${{ matrix.environment }}-bundle
env:
# Host apps are the only suite here running through Metabase's Cypress config,
# whose `after:spec` hook reports failures and writes QUARANTINE_FAILURES_FILE.
# Sample-app suites load their own config (no-op), so ci-conductor is scoped to this job.
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
CI_CONDUCTOR_TEST_SUITE: embedding-sdk-host-app
REPO_ID: ${{ github.event.repository.id }}
COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
TARGET_BRANCH: ${{ github.event.pull_request.base.ref || github.ref_name }}
QUARANTINE_FAILURES_FILE: ${{ github.workspace }}/target/quarantine-failures.jsonl
# `Fail job if tests failed` is the arbiter until ci-conductor takes over.
# Exactly one of the two gates the job.
CI_CONDUCTOR_QUARANTINE_ACTIVE: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}
HOST_APP_ENVIRONMENT: ${{ matrix.environment }}
permissions:
@@ -399,6 +418,8 @@ jobs:
- name: Run Metabase
run: node e2e/runner/run_cypress_ci.js start
- uses: ./.github/actions/resolve-job-id
- name: Generate database snapshots
run: |
node e2e/runner/run_cypress_ci.js snapshot \
@@ -416,14 +437,24 @@ jobs:
- name: Upload Cypress Artifacts upon failure
uses: actions/upload-artifact@v7
if: ${{ steps.run-e2e-tests.outcome != 'success' }}
if: ${{ !cancelled() && steps.run-e2e-tests.outcome == 'failure' }}
with:
name: cypress-recording-host-app-${{ matrix.test_suite }}-${{ matrix.environment }}-latest
path: |
./cypress
if-no-files-found: ignore
- name: Quarantine gate
if: ${{ !cancelled() && steps.run-e2e-tests.outcome == 'failure' }}
continue-on-error: ${{ env.CI_CONDUCTOR_QUARANTINE_ACTIVE != 'true' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: e2e
test-suite: ${{ env.CI_CONDUCTOR_TEST_SUITE }}
enforce-quarantine: ${{ env.CI_CONDUCTOR_QUARANTINE_ACTIVE }}
- name: Fail job if tests failed
if: ${{ steps.run-e2e-tests.outcome != 'success' }}
if: ${{ !cancelled() && steps.run-e2e-tests.outcome == 'failure' && env.CI_CONDUCTOR_QUARANTINE_ACTIVE != 'true' }}
run: |
exit 1

View File

@@ -150,7 +150,7 @@ jobs:
with:
remove-previous-comment: true
add-new-comment: true
message: "⚠️ Embedding SDK bundle size increased by ${{ steps.compare.outputs.size_change_percent }}% compared to the ${{ github.base_ref }} branch (threshold: ${{ env.BUNDLE_SIZE_THRESHOLD_PERCENT }}%). Please contact Embedding team."
message: "⚠️ Embedding SDK chunked bundle size (gzipped) increased by ${{ steps.compare.outputs.size_change_percent }}% compared to the ${{ github.base_ref }} branch (threshold: ${{ env.BUNDLE_SIZE_THRESHOLD_PERCENT }}%). Please contact Embedding team."
include-log: false
- name: Send notification to Slack via Zapier
@@ -165,7 +165,7 @@ jobs:
PR_URL: ${{ github.event.pull_request.html_url }}
run: |
curl -s -X POST "$ZAPIER_WEBHOOK_URL" \
-d "⚠️ Embedding SDK bundle size increased by ${SIZE_CHANGE_PERCENT}% (threshold: ${BUNDLE_SIZE_THRESHOLD_PERCENT}%)
-d "⚠️ Embedding SDK chunked bundle size (gzipped) increased by ${SIZE_CHANGE_PERCENT}% (threshold: ${BUNDLE_SIZE_THRESHOLD_PERCENT}%)
PR #${PR_NUMBER} ${PR_TITLE} (${PR_URL})"
@@ -175,7 +175,7 @@ jobs:
with:
remove-previous-comment: true
add-new-comment: true
message: "🎉 Embedding SDK bundle size decreased by ${{ steps.compare.outputs.size_change_percent }}% compared to the ${{ github.base_ref }} branch. Nice work!"
message: "🎉 Embedding SDK chunked bundle size (gzipped) decreased by ${{ steps.compare.outputs.size_change_percent }}% compared to the ${{ github.base_ref }} branch. Nice work!"
include-log: false
embedding-sdk-tests-result:

View File

@@ -31,6 +31,13 @@ concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}-frontend
cancel-in-progress: true
env:
# Consumed by the report-failures-to-ci-conductor step in fe-tests-unit. Absent
# (e.g. fork PRs without secret access) the reporter no-ops. Matches the other
# suite workflows (backend, drivers, e2e, app-db, semantic-search).
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
jobs:
fe-lint:
if: ${{ !inputs.skip-lint }}
@@ -96,13 +103,32 @@ jobs:
uses: ./.github/actions/prepare-frontend
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- name: Resolve current job id
# Resolve JOB_ID before the long test step so the ci-conductor reporter
# below can link failures to this exact job. Best-effort.
uses: ./.github/actions/resolve-job-id
- name: Run frontend unit tests
id: fe-tests
run: bun run test-unit --silent --shard=${{ matrix.shard }}/${{ env.SHARDS }}
# Trunk Quarantine controls the final state of the run in the CI!
# Even if this step fails we let it pass, and then `trunk-io/analytics-uploader` determines
# whether to fail or to pass the whole job, based on the quarantine list.
# Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
continue-on-error: true
- name: Report failed tests to ci-conductor
if: ${{ !cancelled() && steps.fe-tests.outcome == 'failure' }}
# This step should NEVER fail the job!
continue-on-error: true
uses: ./.github/actions/report-failures-to-ci-conductor
with:
test-suite: fe-tests-unit
adapter: frontend
- name: Quarantine gate
if: ${{ !cancelled() && steps.fe-tests.outcome == 'failure' }}
continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
timeout-minutes: 3
uses: ./.github/actions/quarantine-gate
with:
adapter: frontend
test-suite: fe-tests-unit
enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always() && github.event_name != 'workflow_dispatch'
@@ -114,6 +140,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.fe-tests.outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
fe-tests-timezones:
if: ${{ !inputs.skip }}

View File

@@ -13,10 +13,10 @@ on:
type: string
required: true
burn_in:
description: "Number of times to run the test (e.g. 50)"
description: "Number of times to run the test (e.g. 10)"
type: string
required: true
default: "50"
default: "10"
jobs:
detect-changed-stories:
@@ -93,7 +93,7 @@ jobs:
env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
STORY_FILES: ${{ needs.detect-changed-stories.outputs.story_files }}
BURN_IN: ${{ inputs.burn_in || 50 }}
BURN_IN: ${{ inputs.burn_in || 10 }}
EVENT_NAME: ${{ github.event_name }}
PR_NUMBER: ${{ github.event.pull_request.number }}
PR_ACTOR: ${{ github.event.pull_request.user.login }}
@@ -154,7 +154,7 @@ jobs:
- name: Stress-test Loki
run: |
BURN_IN=${{ inputs.burn_in || '50' }}
BURN_IN=${{ inputs.burn_in || '10' }}
STORY_FILES='${{ needs.detect-changed-stories.outputs.story_files }}'
echo "Story files: $STORY_FILES"

View File

@@ -13,6 +13,8 @@ jobs:
steps:
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version-file: 'package.json'
- name: Install dependencies
run: bun install --frozen-lockfile
- name: get module boundary stats

View File

@@ -122,7 +122,7 @@ jobs:
strategy:
matrix:
edition: [oss, ee]
java-version: [21]
java-version: [25]
steps:
- name: Prepare JRE (Java Run-time Environment)
uses: actions/setup-java@v5.2.0

View File

@@ -33,7 +33,7 @@ jobs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.7"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: Prepare build scripts
run: bun install --cwd release --frozen-lockfile && bun run --cwd release build

View File

@@ -39,7 +39,7 @@ jobs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.7"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: prepare dependencies in release directory
run: bun install --cwd release --frozen-lockfile
@@ -58,13 +58,34 @@ jobs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.7"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: prepare dependencies in release directory
run: bun install --cwd release --frozen-lockfile
- name: Run release unit tests
run: bun run --cwd release test:unit
ci-conductor-tests:
needs: files-changed
if: needs.files-changed.outputs.release_source == 'true'
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v6
with:
sparse-checkout: "release/ci-conductor"
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: Install ci-conductor dependencies
run: bun install --cwd release/ci-conductor --frozen-lockfile
- name: Type-check ci-conductor
run: bun run --cwd release/ci-conductor type-check
- name: Run ci-conductor unit tests
run: bun run --cwd release/ci-conductor test
release-test-build:
needs: files-changed
if: needs.files-changed.outputs.release_source == 'true'
@@ -77,7 +98,7 @@ jobs:
- name: Install bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.7"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
- name: prepare dependencies in release directory
run: bun install --cwd release --frozen-lockfile

View File

@@ -44,7 +44,6 @@ jobs:
e2e_specs_to_run: ${{ steps.compute.outputs.e2e_specs_to_run }}
steps:
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
- name: Test which files changed
uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
id: changes
@@ -55,23 +54,21 @@ jobs:
filters: .github/file-paths.yaml
- name: Create test plan
id: compute
if: ${{ github.event_name == 'pull_request' }}
env:
CHANGED_FILES: ${{ steps.changes.outputs.all_changed_files }}
UNIT_INFRA_TOUCHED: ${{ steps.changes.outputs.frontend_unit_infra }}
LOKI_INFRA_TOUCHED: ${{ steps.changes.outputs.frontend_loki_infra }}
run: |
OUTPUT=$(bun .github/scripts/create-test-plan.ts)
echo "$OUTPUT" | jq '.stats'
echo "stats=$(echo "$OUTPUT" | jq -c '.stats')" >> $GITHUB_OUTPUT
echo "fe_unit_specs_to_run=$(echo "$OUTPUT" | jq -c '.fe_unit_specs_to_run')" >> $GITHUB_OUTPUT
echo "loki_stories_to_run=$(echo "$OUTPUT" | jq -c '.loki_stories_to_run')" >> $GITHUB_OUTPUT
echo "e2e_specs_to_run=$(echo "$OUTPUT" | jq -c '.e2e_specs_to_run')" >> $GITHUB_OUTPUT
if: ${{ github.event_name == 'pull_request' || (github.event_name == 'push' && github.ref == 'refs/heads/master') }}
uses: ./.github/actions/create-test-plan
with:
changed-files: ${{ steps.changes.outputs.all_changed_files }}
fe-changed-files: ${{ steps.changes.outputs.frontend_sources_files }}
be-changed-files: ${{ steps.changes.outputs.backend_sources_files }}
unit-infra-touched: ${{ steps.changes.outputs.frontend_unit_infra }}
loki-infra-touched: ${{ steps.changes.outputs.frontend_loki_infra }}
e2e-infra-touched: ${{ steps.changes.outputs.e2e_infra }}
shared-sources-touched: ${{ steps.changes.outputs.shared_sources }}
upload-affected-tests-stats:
needs: create-test-plan
# Only land rows for the upstream repo so forks don't pollute the table.
if: ${{ !cancelled() && needs.create-test-plan.result == 'success' && github.event.pull_request.head.repo.full_name == 'metabase/metabase' }}
if: ${{ !cancelled() && needs.create-test-plan.result == 'success' && (github.event.pull_request.head.repo.full_name == 'metabase/metabase' || (github.event_name == 'push' && github.repository == 'metabase/metabase')) }}
# Stats upload is best-effort — a failure here shouldn't fail the PR run.
continue-on-error: true
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
@@ -79,11 +76,14 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Upload affected tests stats
# On push (merge to master) there is no PR context, so fall back to the
# commit SHAs and a 0 PR number.
env:
STATS_JSON: ${{ needs.create-test-plan.outputs.stats }}
PR_NUMBER: ${{ github.event.pull_request.number }}
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
BASE_SHA: ${{ github.event.pull_request.base.sha }}
TRIGGERED_BY: ${{ github.event_name == 'pull_request' && 'pr_update' || 'merge_to_master' }}
PR_NUMBER: ${{ github.event_name == 'pull_request' && github.event.pull_request.number || 0 }}
HEAD_SHA: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
BASE_SHA: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.sha || github.event.before }}
API_KEY: ${{ secrets.STATS_API_KEY }}
run: node .github/scripts/upload-affected-tests-stats.js
@@ -154,8 +154,11 @@ jobs:
# here we pass the list of changed files
# e.g. e2e/test/scenarios/onboarding/command-palette.cy.spec.js,e2e/test/scenarios/question/document-title.cy.spec.js
# e2e_all_files includes all changes which trigger all e2e tests, if the list of changes files is included in the
# list of changed specs files, then only specs are changed and we can run only those specs
specs: ${{ needs.create-test-plan.outputs.e2e_all_files == needs.create-test-plan.outputs.e2e_specs_files && needs.create-test-plan.outputs.e2e_specs_files || '' }}
# list of changed specs files, then only specs are changed and we can run only those specs.
# Only narrow to changed specs on pull requests. On push to master/release branches (and the
# merge queue) the paths-filter still computes these file lists, so without this guard a push
# that touched only specs would silently run a narrowed suite — we always want the full suite there.
specs: ${{ github.event_name == 'pull_request' && needs.create-test-plan.outputs.e2e_all_files == needs.create-test-plan.outputs.e2e_specs_files && needs.create-test-plan.outputs.e2e_specs_files || '' }}
embedding-sdk-package:
needs: [create-test-plan]
@@ -218,6 +221,18 @@ jobs:
self_hosting: false
analytics_dev_mode: true
pr-env-stats-dump:
needs: [uberjar]
if: |
!cancelled() &&
contains(github.event.pull_request.labels.*.name, 'PR-Env-Stats-Dump')
uses: ./.github/workflows/pr-env.yml
secrets: inherit
with:
self_hosting: false
analytics_dev_mode: false
stats_dump: true
containerize:
needs: [uberjar]
if: |

View File

@@ -11,6 +11,13 @@ concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}-semantic-search
cancel-in-progress: true
# Exposed to every job so the test-driver action can report failures to
# ci-conductor (secrets: inherit is already set on the semantic-search call in
# run-tests.yml). See DEV-2224.
env:
CI_CONDUCTOR_BASE_URL: ${{ secrets.CI_CONDUCTOR_BASE_URL }}
CI_CONDUCTOR_WEBHOOK_SECRET: ${{ secrets.CI_CONDUCTOR_WEBHOOK_SECRET }}
jobs:
semantic-search-tests-h2:
if: ${{ !inputs.skip }}
@@ -27,7 +34,7 @@ jobs:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/metabot_v3/tools/semantic_search_test.clj"]'
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
@@ -54,6 +61,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -65,6 +73,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-mariadb:
if: ${{ !inputs.skip }}
@@ -86,7 +95,7 @@ jobs:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/metabot_v3/tools/semantic_search_test.clj"]'
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
@@ -127,6 +136,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -138,6 +148,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-mysql:
if: ${{ !inputs.skip }}
@@ -159,7 +170,7 @@ jobs:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/metabot_v3/tools/semantic_search_test.clj"]'
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
@@ -200,6 +211,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -211,6 +223,7 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-postgres:
if: ${{ !inputs.skip }}
@@ -232,7 +245,7 @@ jobs:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/metabot_v3/tools/semantic_search_test.clj"]'
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
@@ -274,6 +287,7 @@ jobs:
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
@@ -285,6 +299,73 @@ jobs:
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
# pgvector-on-the-app-db mode: the app db itself is a pgvector-capable Postgres and
# MB_PGVECTOR_DB_URL is deliberately unset. The dedicated-harness tests gate themselves off; the
# appdb-pgvector-mode round trip (and the URL-independent unit tests) run for real.
semantic-search-tests-appdb-mode:
if: ${{ !inputs.skip }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
matrix:
version:
- name: pgvector pg17 as app db, no dedicated pgvector
junit-name: semantic-search-tests-appdb-mode-pg17
appdb-image: pgvector/pgvector:pg17
job:
- name: Semantic Search Tests
build-static-viz: false
test-args: >-
:only '["enterprise/backend/test/metabase_enterprise/semantic_search" "enterprise/backend/test/metabase_enterprise/entity_retrieval" "enterprise/backend/test/metabase_enterprise/metabot/tools/semantic_search_test.clj"]'
exclude-tag: ':mb/driver-tests'
services:
postgres:
image: ${{ matrix.version.appdb-image }}
ports:
- "5432:5432"
env:
POSTGRES_USER: mb_test
POSTGRES_DB: mb_test
POSTGRES_HOST_AUTH_METHOD: trust
env:
CI: 'true'
MB_DB_TYPE: postgres
MB_DB_PORT: 5432
MB_DB_HOST: localhost
MB_DB_DBNAME: mb_test
MB_DB_USER: mb_test
# opts this job into the destructive appdb-pgvector-mode round trip, which then FAILS (rather
# than silently skipping) if the app db can't actually host pgvector
MB_APPDB_PGVECTOR_MODE_TEST: 'true'
name: "${{ matrix.version.name }} ${{ matrix.job.name }}"
steps:
- uses: actions/checkout@v6
- name: Test ${{ matrix.version.name }}
id: test-driver
uses: ./.github/actions/test-driver
with:
build-static-viz: ${{ matrix.job.build-static-viz }}
junit-name: ${{ matrix.version.junit-name }}
test-args: >-
${{ matrix.job.test-args }}
:exclude-tags '[${{ matrix.job.exclude-tag }}]'
quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- name: Upload Test Results
uses: ./.github/actions/upload-test-results
if: always()
with:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
run-trunk: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
semantic-search-tests-result:
needs:
@@ -292,6 +373,7 @@ jobs:
- semantic-search-tests-mariadb
- semantic-search-tests-mysql
- semantic-search-tests-postgres
- semantic-search-tests-appdb-mode
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
name: semantic-search-tests-result

View File

@@ -32,7 +32,7 @@ jobs:
uses: actions/setup-java@v5.2.0
with:
distribution: temurin
java-version: 21
java-version: 25
- name: Set up Babashka
uses: turtlequeue/setup-babashka@d78ec6570aea3b614bc695cafcceb82eb45c2af9 # v1.8.0
with:

View File

@@ -53,7 +53,7 @@ jobs:
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version: "1.3.7"
bun-version-file: 'package.json'
token: ${{ secrets.GITHUB_TOKEN }}
# Snyk doesn't support bun.lock yet, so we generate yarn.lock and scan that.
# Bun has a bug where it normalizes "< 3.0.0" to "< 3" in alias entries
@@ -131,9 +131,6 @@ jobs:
- name: Driver - SparkSQL
file: modules/drivers/sparksql/pom.xml
category: driver-sparksql
- name: Driver - SQLite
file: modules/drivers/sqlite/pom.xml
category: driver-sqlite
- name: Driver - SQL Server
file: modules/drivers/sqlserver/pom.xml
category: driver-sqlserver

View File

@@ -201,7 +201,7 @@ jobs:
uses: actions/setup-java@v5.2.0
with:
distribution: 'temurin'
java-version: 21
java-version: 25
- name: Retrieve test build uberjar artifact for ${{ matrix.edition }}
uses: ./.github/actions/fetch-artifact

View File

@@ -1,3 +1,15 @@
# .github/workflows/team-issues-slack-notification.yml
#
# Posts newly team-labeled bugs to the team's Slack channel (e.g.
# #team-graphy-bugs), now including a link to the synced Linear issue.
#
# Changes from the current version:
# - Checks out .github/scripts so we can reuse find-linear-issue.js
# - The message-building step now queries Linear (via attachmentsForURL)
# with a short retry, and appends "Linear: <link|ID>" when found
# - Degrades gracefully: if no Linear issue is attached (or the API is
# down), the message posts without the Linear issue link
name: Team Issues Slack Notification
on:
@@ -14,18 +26,58 @@ jobs:
( contains(github.event.issue.labels.*.name, 'Type:Bug') ||
contains(github.event.issue.labels.*.name, 'flaky-test-fix') )
steps:
- name: Setting title
- uses: actions/checkout@v4
with:
sparse-checkout: .github/scripts
- name: Build Slack message (with Linear link if available)
uses: actions/github-script@v9
id: vars
env:
LINEAR_API_KEY: ${{ secrets.LINEAR_API_KEY }}
with:
script: |
core.setOutput('issue_title', JSON.stringify(${{ toJson(github.event.issue.title) }} + '\n' + ${{ toJson(github.event.issue.html_url) }}));
const { findLinearIssue } = require('./.github/scripts/find-linear-issue.js');
const title = context.payload.issue.title;
const issueUrl = context.payload.issue.html_url;
let text = title + '\n' + issueUrl;
// The Linear issue is usually already synced by the time the
// team label lands at triage, but retry briefly just in case.
try {
const delaysSeconds = [0, 15, 30];
let result = null;
for (const delay of delaysSeconds) {
if (delay) await new Promise((r) => setTimeout(r, delay * 1000));
result = await findLinearIssue({
githubIssueUrl: issueUrl,
linearApiKey: process.env.LINEAR_API_KEY,
});
if (result.success) break;
}
if (result && result.success) {
const id = result.issue; // e.g. "GIT-1234"
text += `\nLinear: <https://linear.app/metabase/issue/${id}|${id}>`;
} else {
core.info(`No Linear issue found for ${issueUrl}; posting without link.`);
}
} catch (e) {
// Never block the notification on a Linear lookup failure
core.warning(`Linear lookup failed: ${e.message}`);
}
core.setOutput('message', JSON.stringify(text));
- name: Extracting team name
id: team_name
env:
LABEL_NAME: ${{ github.event.label.name }}
run: |
team_label=$(sed 's/&/\$/g' <<< "$LABEL_NAME")
team_label="${LABEL_NAME//&/$}"
echo "$team_label"
team_name=${team_label#*.Team/}
echo "$team_name"
@@ -55,7 +107,7 @@ jobs:
"type": "section",
"text": {
"type": "mrkdwn",
"text": ${{ steps.vars.outputs.issue_title }}
"text": ${{ steps.vars.outputs.message }}
}
}
]

View File

@@ -128,6 +128,9 @@ jobs:
MB_EDITION: ${{ matrix.edition }}
INTERACTIVE: false
SKIP_LICENSES: ${{ github.event_name == 'pull_request' }} # faster builds for dev
# Emit bundle stats on trunk/release builds (tracked over time) and on PRs
# (the bundle-size check reads them for both the PR head and its base ref).
EMIT_BUNDLE_STATS: ${{ (github.ref_name == 'master' || startsWith(github.ref_name, 'release-') || github.event_name == 'pull_request') && 'true' || 'false' }}
steps:
- name: Check out the code
uses: actions/checkout@v6
@@ -140,9 +143,17 @@ jobs:
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
with:
java-version: "${{ needs.get-build-requirements.outputs.java_version || 21 }}"
java-version: "${{ needs.get-build-requirements.outputs.java_version || 25 }}"
- name: Build
run: ./bin/build.sh
- name: Upload bundle stats
if: ${{ matrix.edition == 'ee' && env.EMIT_BUNDLE_STATS == 'true' }}
continue-on-error: true
uses: actions/upload-artifact@v7
with:
name: metabase-bundle-stats-${{ matrix.edition }}-${{ github.event.inputs.commit || github.event.pull_request.head.sha || github.sha }}
path: target/bundle-stats
if-no-files-found: warn
- name: Prepare uberjar artifact
uses: ./.github/actions/prepare-uberjar-artifact
with:
@@ -163,7 +174,7 @@ jobs:
strategy:
matrix:
edition: ["ee", "oss"]
java-version: [21]
java-version: [25]
steps:
- name: Check out the code
uses: actions/checkout@v6

15
.gitignore vendored
View File

@@ -57,6 +57,16 @@ cypress.env.json
/e2e/tmp/db_dumps/*
!/e2e/tmp/db_dumps/.gitkeep
/e2e/support/assets/example_custom_viz_plugin*.tgz
# Coverage artifacts
/e2e/coverage-manifest-raw
/e2e/coverage-manifest
/e2e/coverage/analysis
/e2e/coverage/spec-file-manifest.json
/e2e/support/.nyc_output
/e2e/support/coverage
/e2e/support/e2e
/.nyc_output
/lein-plugins/*/target
/local
/locales/metabase-*.pot
@@ -92,6 +102,7 @@ cypress.env.json
/resources/metabase/config/modules.edn
/resources/namespaces.edn
/resources/sample-dataset.db.trace.db
!/resources/sample-database.*
/resources/version.properties
/screenshots
/sqlite.db
@@ -190,3 +201,7 @@ __pycache__/
.claude/scheduled_tasks.lock
.playwright-mcp
.ci_reports/
# dependency-cruiser output
dependency-graph.json
.playwright-cli/

Binary file not shown.

Before

Width:  |  Height:  |  Size: 40 KiB

After

Width:  |  Height:  |  Size: 40 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 67 KiB

After

Width:  |  Height:  |  Size: 67 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 67 KiB

After

Width:  |  Height:  |  Size: 67 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 60 KiB

After

Width:  |  Height:  |  Size: 60 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 60 KiB

After

Width:  |  Height:  |  Size: 60 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 84 KiB

After

Width:  |  Height:  |  Size: 83 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 76 KiB

After

Width:  |  Height:  |  Size: 76 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 73 KiB

After

Width:  |  Height:  |  Size: 72 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 75 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 89 KiB

After

Width:  |  Height:  |  Size: 89 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 79 KiB

After

Width:  |  Height:  |  Size: 78 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 84 KiB

After

Width:  |  Height:  |  Size: 85 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 71 KiB

After

Width:  |  Height:  |  Size: 71 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 77 KiB

After

Width:  |  Height:  |  Size: 76 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 75 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 75 KiB

After

Width:  |  Height:  |  Size: 75 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 77 KiB

After

Width:  |  Height:  |  Size: 76 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 75 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 71 KiB

After

Width:  |  Height:  |  Size: 71 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 71 KiB

After

Width:  |  Height:  |  Size: 71 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 74 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Some files were not shown because too many files have changed in this diff Show More