revert renderSdkHook as we don't need it

frontend/src/metabase/lib/entity-id/hooks/index.ts

@@ -0,0 +1 @@
+export * from "./use-validated-entity-id";

frontend/src/metabase/lib/entity-id/hooks/use-validated-entity-id/index.ts

@@ -0,0 +1 @@
+export * from "./use-validated-entity-id";

frontend/src/metabase/lib/entity-id/hooks/use-validated-entity-id/use-validated-entity-id.ts

@@ -17,6 +17,29 @@ type SUPPORTED_ENTITIES = {
   collection: CollectionId;
 };
 
+export interface UseTranslateEntityIdProps<
+  TEntity extends keyof SUPPORTED_ENTITIES = keyof SUPPORTED_ENTITIES,
+> {
+  type: TEntity;
+  id: BaseEntityId | string | number | null | undefined;
+}
+
+export type UseTranslateEntityIdReturned<
+  TEntity extends keyof SUPPORTED_ENTITIES = keyof SUPPORTED_ENTITIES,
+  TReturnedId = SUPPORTED_ENTITIES[TEntity],
+> =
+  | { id: TReturnedId; isLoading: false; isError: false }
+  | {
+      id: null;
+      isLoading: true;
+      isError: false;
+    }
+  | {
+      id: null;
+      isLoading: false;
+      isError: true;
+    };
+
 /**
  * A hook that validates and potentially translates an entity ID.
  *
@@ -35,21 +58,10 @@ export const useValidatedEntityId = <
 >({
   type,
   id,
-}: {
-  type: TEntity;
-  id: BaseEntityId | string | number | null | undefined;
-}):
-  | { id: TReturnedId; isLoading: false; isError: false }
-  | {
-      id: null;
-      isLoading: true;
-      isError: false;
-    }
-  | {
-      id: null;
-      isLoading: false;
-      isError: true;
-    } => {
+}: UseTranslateEntityIdProps<TEntity>): UseTranslateEntityIdReturned<
+  TEntity,
+  TReturnedId
+> => {
   const isEntityId = isBaseEntityID(id);
   const {
     data: entity_ids,

frontend/src/metabase/lib/entity-id/hooks/use-validated-entity-id/use-validated-entity-id.unit.spec.tsx

@@ -0,0 +1,158 @@
+import { waitFor } from "@testing-library/react";
+
+import {
+  callsToTranslateEntityIdEndpoint,
+  setupTranslateEntityIdEndpoint,
+} from "__support__/server-mocks/entity-ids";
+import { renderHookWithProviders } from "__support__/ui";
+import type { BaseEntityId } from "metabase-types/api";
+
+import { useValidatedEntityId } from "./use-validated-entity-id";
+
+describe("useValidatedEntityId", () => {
+  it("should pass through numeric IDs without calling the translation endpoint", () => {
+    const { result } = renderHookWithProviders(() =>
+      useValidatedEntityId({ type: "card", id: 123 }),
+    );
+
+    expect(result.current).toEqual({
+      id: 123,
+      isLoading: false,
+      isError: false,
+    });
+
+    expect(callsToTranslateEntityIdEndpoint()).toHaveLength(0);
+  });
+
+  it("should handle undefined ID", () => {
+    const { result } = renderHookWithProviders(() =>
+      useValidatedEntityId({ type: "card", id: undefined }),
+    );
+
+    expect(result.current).toEqual({
+      id: null,
+      isLoading: false,
+      isError: true,
+    });
+  });
+
+  it("should handle null ID", () => {
+    const { result } = renderHookWithProviders(() =>
+      useValidatedEntityId({ type: "card", id: null }),
+    );
+
+    expect(result.current).toEqual({
+      id: null,
+      isLoading: false,
+      isError: true,
+    });
+  });
+
+  it("should handle invalid entity ID strings", () => {
+    const { result } = renderHookWithProviders(() =>
+      useValidatedEntityId({ type: "card", id: "not-an-entity-id" }),
+    );
+
+    expect(result.current).toEqual({
+      id: null,
+      isLoading: false,
+      isError: true,
+    });
+  });
+
+  it("should translate card entity IDs correctly", async () => {
+    const validEntityId = "2".repeat(21) as BaseEntityId;
+
+    setupTranslateEntityIdEndpoint({
+      [validEntityId]: {
+        type: "card",
+        status: "ok",
+        id: 123,
+      },
+    });
+
+    const { result } = renderHookWithProviders(() =>
+      useValidatedEntityId({ type: "card", id: validEntityId }),
+    );
+
+    await waitFor(() => expect(result.current.isLoading).toBe(false));
+
+    expect(result.current).toEqual({
+      id: 123,
+      isLoading: false,
+      isError: false,
+    });
+  });
+
+  it("should translate dashboard entity IDs correctly", async () => {
+    const validEntityId = "3".repeat(21) as BaseEntityId;
+
+    setupTranslateEntityIdEndpoint({
+      [validEntityId]: {
+        type: "dashboard",
+        status: "ok",
+        id: 456,
+      },
+    });
+
+    const { result } = renderHookWithProviders(() =>
+      useValidatedEntityId({ type: "dashboard", id: validEntityId }),
+    );
+
+    await waitFor(() => expect(result.current.isLoading).toBe(false));
+
+    expect(result.current).toEqual({
+      id: 456,
+      isLoading: false,
+      isError: false,
+    });
+  });
+
+  it("should translate collection entity IDs correctly", async () => {
+    const validEntityId = "4".repeat(21) as BaseEntityId;
+
+    setupTranslateEntityIdEndpoint({
+      [validEntityId]: {
+        type: "collection",
+        status: "ok",
+        id: 789,
+      },
+    });
+
+    const { result } = renderHookWithProviders(() =>
+      useValidatedEntityId({ type: "collection", id: validEntityId }),
+    );
+
+    await waitFor(() => expect(result.current.isLoading).toBe(false));
+
+    expect(result.current).toEqual({
+      id: 789,
+      isLoading: false,
+      isError: false,
+    });
+  });
+
+  it("should handle failed translations", async () => {
+    const invalidEntityId = "5".repeat(21) as BaseEntityId;
+
+    setupTranslateEntityIdEndpoint({
+      [invalidEntityId]: {
+        type: "card",
+        status: "not-found",
+        id: null,
+      },
+    });
+
+    const { result } = renderHookWithProviders(() =>
+      useValidatedEntityId({ type: "card", id: invalidEntityId }),
+    );
+
+    await waitFor(() => expect(result.current.isLoading).toBe(false));
+
+    expect(result.current).toEqual({
+      id: null,
+      isLoading: false,
+      isError: true,
+    });
+  });
+});

frontend/test/__support__/server-mocks/entity-ids.ts

@@ -0,0 +1,22 @@
+import fetchMock from "fetch-mock";
+
+import type {
+  TranslateEntityIdResponseNotFound,
+  TranslateEntityIdResponseSuccess,
+} from "metabase/api";
+
+export const setupTranslateEntityIdEndpoint = (
+  mockResponse: Record<
+    string, // this should be BaseEntityId, but in tests we probably want to use plain strings
+    TranslateEntityIdResponseSuccess | TranslateEntityIdResponseNotFound
+  >,
+) => {
+  fetchMock.post("path:/api/util/entity_id", {
+    body: { entity_ids: mockResponse },
+    status: 200,
+  });
+};
+
+export const callsToTranslateEntityIdEndpoint = () => {
+  return fetchMock.calls("path:/api/util/entity_id");
+};