Merge branch 'master' into poc-sdk-react-19

docs/embedding/sdk/introduction.md

@@ -18,7 +18,7 @@ Here's the [Shoppy source code](https://github.com/metabase/shoppy).
 
 ## Embedded analytics SDK prerequisites
 
-- React application using React 17 or React 18.
+- React application using React 17, 18 or 19.
 - Nodejs 20.x or higher.
 - Metabase version 1.52 or higher.
 
@@ -72,9 +72,9 @@ You can find the [Embedded analytics SDK source code in the Metabase repo](https
 
 View the SDK's changelog:
 
-* [54-nightly](https://github.com/metabase/metabase/blob/master/enterprise/frontend/src/embedding-sdk/CHANGELOG.md)
-* [53-stable](https://github.com/metabase/metabase/blob/release-x.53.x/enterprise/frontend/src/embedding-sdk/CHANGELOG.md)
-* [52-stable](https://github.com/metabase/metabase/blob/release-x.52.x/enterprise/frontend/src/embedding-sdk/CHANGELOG.md)
+- [54-nightly](https://github.com/metabase/metabase/blob/master/enterprise/frontend/src/embedding-sdk/CHANGELOG.md)
+- [53-stable](https://github.com/metabase/metabase/blob/release-x.53.x/enterprise/frontend/src/embedding-sdk/CHANGELOG.md)
+- [52-stable](https://github.com/metabase/metabase/blob/release-x.52.x/enterprise/frontend/src/embedding-sdk/CHANGELOG.md)
 
 ## Embedded analytics SDK on NPM
 
@@ -94,12 +94,12 @@ The SDK doesn't support:
 
 ## Issues, feature requests and support
 
-[Bugs](https://github.com/metabase/metabase/issues/?q=is%3Aissue%20state%3Aopen%20label%3AType%3ABug%20label%3AEmbedding%2FSDK) and [feature requests](https://github.com/metabase/metabase/issues/?q=is%3Aissue%20state%3Aopen%20label%3AEmbedding%2FSDK%20label%3A%22Type%3ANew%20Feature%22) are tracked on GitHub. 
+[Bugs](https://github.com/metabase/metabase/issues/?q=is%3Aissue%20state%3Aopen%20label%3AType%3ABug%20label%3AEmbedding%2FSDK) and [feature requests](https://github.com/metabase/metabase/issues/?q=is%3Aissue%20state%3Aopen%20label%3AEmbedding%2FSDK%20label%3A%22Type%3ANew%20Feature%22) are tracked on GitHub.
 
 You can upvote an existing feature request by leaving a thumbs up emoji reaction on the issue. Feel free to leave comments with context that could be useful. [Read more](https://www.metabase.com/docs/latest/troubleshooting-guide/requesting-new-features).
 
 Before creating new issues, please make sure an issue for your problem or feature request doesn't already exist.
- 
+
 To seek help:
 
 - Paid customers can contact our success team through the usual channels.

enterprise/frontend/src/embedding-sdk/cli/constants/messages.ts

@@ -23,7 +23,7 @@ export const PACKAGE_JSON_NOT_FOUND_MESSAGE = `
 
 export const MISSING_REACT_DEPENDENCY = `
   Your package.json file does not contain a dependency for React.
-  Please make sure your package.json file contains a dependency for React 18.
+  Please make sure your package.json file contains a dependency for React 17 - 19.
 `;
 
 export const UNSUPPORTED_REACT_VERSION = `

enterprise/frontend/src/embedding-sdk/cli/steps/check-if-react-project.ts

@@ -14,7 +14,7 @@ import {
 } from "../utils/get-package-version";
 
 const isReactVersionSupported = (version: string) =>
-  semver.satisfies(semver.coerce(version)!, "18.x");
+  semver.satisfies(semver.coerce(version)!, "17.x || 18.x || 19.x");
 
 export const checkIfReactProject: CliStepMethod = async state => {
   const spinner = ora("Checking if this is a React project…").start();

enterprise/frontend/src/embedding-sdk/package.template.json

@@ -27,7 +27,7 @@
   },
   "types": "./dist/enterprise/frontend/src/embedding-sdk/index.d.ts",
   "peerDependencies": {
-    "react": ">=17 <=18",
-    "react-dom": ">=17 <=18"
+    "react": ">=17 <=19",
+    "react-dom": ">=17 <=19"
   }
 }

frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormCreator.tsx

@@ -132,7 +132,7 @@ export function FormCreator({
       <SidebarContent>
         <FormContainer>
           {onClose && (
-            /* We want to avoid absolute positioning, so we use margin with z-index since 
+            /* We want to avoid absolute positioning, so we use margin with z-index since
                it's covered by the next element with padding */
             <Flex
               justify="flex-end"

package.json

@@ -95,15 +95,15 @@
     "process": "^0.11.10",
     "prop-types": "^15.5.7",
     "re-reselect": "^4.0.1",
-    "react": "^18.2.0",
+    "react": "^19",
     "react-ansi-style": "^1.0.0",
     "react-beautiful-dnd": "^13.1.1",
     "react-color": "^2.14.1",
     "react-copy-to-clipboard": "^5.0.1",
     "react-dnd": "4",
     "react-dnd-html5-backend": "4",
-    "react-dom": "^18.2.0",
-    "react-draggable": "^4.4.5",
+    "react-dom": "^19",
+    "react-draggable": "^4.4.6",
     "react-dropzone": "^14.2.3",
     "react-grid-layout": "^1.4.4",
     "react-innertext": "^1.1.5",
@@ -217,11 +217,11 @@
     "@types/prettier": "1.19.1",
     "@types/prop-types": "^15.7.4",
     "@types/raf": "^3.4.0",
-    "@types/react": "^18.3.3",
+    "@types/react": "^19",
     "@types/react-beautiful-dnd": "^13.1.3",
     "@types/react-color": "^2.17.6",
     "@types/react-copy-to-clipboard": "^5.0.2",
-    "@types/react-dom": "^18.2.17",
+    "@types/react-dom": "^19",
     "@types/react-grid-layout": "^1.3.5",
     "@types/react-is": "^18.2.4",
     "@types/react-resizable": "^3.0.4",

yarn.lock

@@ -4777,6 +4777,11 @@
   dependencies:
     "@types/react" "*"
 
+"@types/react-dom@^19":
+  version "19.0.4"
+  resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-19.0.4.tgz#bedba97f9346bd4c0fe5d39e689713804ec9ac89"
+  integrity sha512-4fSQ8vWFkg+TGhePfUzVmat3eC14TXYSsiiDSLI0dVLsrm9gZFABjPy/Qu6TKgl1tq1Bu1yDsuQgY3A3DOjCcg==
+
 "@types/react-grid-layout@^1.3.5":
   version "1.3.5"
   resolved "https://registry.yarnpkg.com/@types/react-grid-layout/-/react-grid-layout-1.3.5.tgz#f4b52bf27775290ee0523214be0987be14e66823"
@@ -4854,12 +4859,11 @@
     "@types/prop-types" "*"
     csstype "^3.0.2"
 
-"@types/react@^18.3.3":
-  version "18.3.3"
-  resolved "https://registry.yarnpkg.com/@types/react/-/react-18.3.3.tgz#9679020895318b0915d7a3ab004d92d33375c45f"
-  integrity sha512-hti/R0pS0q1/xx+TsI73XIqk26eBsISZ2R0wUijXIngRK9R/e7Xw/cXVxQK7R5JjW+SV4zGcn5hXjudkN/pLIw==
+"@types/react@^19":
+  version "19.0.10"
+  resolved "https://registry.yarnpkg.com/@types/react/-/react-19.0.10.tgz#d0c66dafd862474190fe95ce11a68de69ed2b0eb"
+  integrity sha512-JuRQ9KXLEjaUNjTWpzuR231Z2WpIwczOkBEIvbHNCzQefFIT0L8IqE6NV6ULLyC1SI/i234JnDoMkfg+RjQj2g==
   dependencies:
-    "@types/prop-types" "*"
     csstype "^3.0.2"
 
 "@types/reactcss@*":
@@ -17166,13 +17170,12 @@ react-docgen@^7.0.0:
     loose-envify "^1.1.0"
     scheduler "^0.23.2"
 
-react-dom@^18.2.0:
-  version "18.2.0"
-  resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-18.2.0.tgz#22aaf38708db2674ed9ada224ca4aa708d821e3d"
-  integrity sha512-6IMTriUmvsjHUjNtEDudZfuDQUoWXVxKHhlEGSk81n4YFS+r/Kl99wXiwlVXtPBtJenozv2P+hxDsw9eA7Xo6g==
+react-dom@^19:
+  version "19.0.0"
+  resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-19.0.0.tgz#43446f1f01c65a4cd7f7588083e686a6726cfb57"
+  integrity sha512-4GV5sHFG0e/0AD4X+ySy6UJd3jVl1iNsNHdpad0qhABJ11twS3TTBnseqsKurKcsNqCEFeGL3uLpVChpIO3QfQ==
   dependencies:
-    loose-envify "^1.1.0"
-    scheduler "^0.23.0"
+    scheduler "^0.25.0"
 
 react-draggable@^4.0.3:
   version "4.4.3"
@@ -17182,7 +17185,7 @@ react-draggable@^4.0.3:
     classnames "^2.2.5"
     prop-types "^15.6.0"
 
-react-draggable@^4.4.5:
+react-draggable@^4.4.5, react-draggable@^4.4.6:
   version "4.4.6"
   resolved "https://registry.yarnpkg.com/react-draggable/-/react-draggable-4.4.6.tgz#63343ee945770881ca1256a5b6fa5c9f5983fe1e"
   integrity sha512-LtY5Xw1zTPqHkVmtM3X8MUOxNDOUhv/khTgBgrUvwaS064bwVvxT+q5El0uUFNx5IEPKXuRejr7UqLwBIg5pdw==
@@ -17445,12 +17448,10 @@ react@^17.0.2:
     loose-envify "^1.1.0"
     object-assign "^4.1.1"
 
-react@^18.2.0:
-  version "18.2.0"
-  resolved "https://registry.yarnpkg.com/react/-/react-18.2.0.tgz#555bd98592883255fa00de14f1151a917b5d77d5"
-  integrity sha512-/3IjMdb2L9QbBdWiW5e3P2/npwMBaU9mHCSCUzNln0ZCYbcfTsGbTJrU/kGemdH2IWmB2ioZ+zkxtmq6g09fGQ==
-  dependencies:
-    loose-envify "^1.1.0"
+react@^19:
+  version "19.0.0"
+  resolved "https://registry.yarnpkg.com/react/-/react-19.0.0.tgz#6e1969251b9f108870aa4bff37a0ce9ddfaaabdd"
+  integrity sha512-V8AVnmPIICiWpGfm6GLzCR/W5FXLchHop40W4nXBmdlEceh16rCN8O8LNWm5bh5XUX91fh7KpA+W0TgMKmgTpQ==
 
 reactcss@^1.2.0:
   version "1.2.3"
@@ -18241,13 +18242,6 @@ scheduler@^0.20.2:
     loose-envify "^1.1.0"
     object-assign "^4.1.1"
 
-scheduler@^0.23.0:
-  version "0.23.0"
-  resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.23.0.tgz#ba8041afc3d30eb206a487b6b384002e4e61fdfe"
-  integrity sha512-CtuThmgHNg7zIZWAXi3AsyIzA3n4xx7aNyjwC2VJldO2LMVDhFK+63xGqq6CsJH4rTAt6/M+N4GhZiDYPx9eUw==
-  dependencies:
-    loose-envify "^1.1.0"
-
 scheduler@^0.23.2:
   version "0.23.2"
   resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.23.2.tgz#414ba64a3b282892e944cf2108ecc078d115cdc3"
@@ -18255,6 +18249,11 @@ scheduler@^0.23.2:
   dependencies:
     loose-envify "^1.1.0"
 
+scheduler@^0.25.0:
+  version "0.25.0"
+  resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.25.0.tgz#336cd9768e8cceebf52d3c80e3dcf5de23e7e015"
+  integrity sha512-xFVuu11jh+xcO7JOAGJNOXld8/TcEHK/4CituBUeUb5hqxJLj9YuemAEuvm9gQ/+pgXYfbQuqAkiYu+u7YEsNA==
+
 schema-utils@^3.0.0:
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/schema-utils/-/schema-utils-3.0.0.tgz#67502f6aa2b66a2d4032b4279a2944978a0913ef"