Compare commits

...

464 Commits

Author SHA1 Message Date
dan sutton
4e70c979ce handle fields from "select * from orders" type queries
```clojure
util=> (sql-parsing/field-references nil "select * from fields")
{:used-fields #{},
 :returned-fields [{:type :all-columns, :table {:table "fields"}}],
 :errors #{}}
```

when this went through our old field prediction work we ended up with

```
 [{:name nil
  :display-name nil
  :base-type :type/*
  :effective-type :type/*
  :semantic-type nil
  :position 0}]
```

Which then failed to insert into the database
2026-04-09 17:07:13 -05:00
dan sutton
09fee616b7 cleanup module config
this causes tests to fail locally:

```clojure
modules-test=> (clojure.test/run-tests 'metabase.core.modules-test)

Testing metabase.core.modules-test
FAIL in (model-boundaries-test) (modules_test.clj:200)
Model boundary enforcement
 No model boundary violations
enterprise/backend/src/metabase_enterprise/replacement/swap/viz.clj (module enterprise/replacement) references :model/DashboardCardSeries (defined in dashboards) — not-imported violation
expected: (nil? violation-type)
  actual: (not (nil? :not-imported))

FAIL in (modules-config-up-to-date-test) (modules_test.clj:169)
Please update .clj-kondo/config/modules/config.edn 🥰
[Pro Tip: use (dev.deps-graph/print-kondo-config-diff) to see the changes you need to make in a nicer format]
 Add #{metabase.lib-be.source-swap} to [lib-be :api]
used by {metabase.lib-be.source-swap #{metabase-enterprise.replacement.swap.viz}}
expected: (empty? missing)
  actual: (not (empty? #{metabase.lib-be.source-swap}))

Ran 10 tests containing 3665 assertions.
2 failures, 0 errors.
{:test 10, :pass 3663, :fail 2, :error 0, :type :summary}
```

but without these changes they fail in CI:

```clojure
FAIL in metabase.core.modules-test/modules-config-up-to-date-test (modules_test.clj:171)
Please update .clj-kondo/config/modules/config.edn 🥰
[Pro Tip: use (dev.deps-graph/print-kondo-config-diff) to see the changes you need to make in a nicer format]
 Remove #{metabase.lib-be.source-swap} from [lib-be :api]
expected: (empty? extraneous)
  actual: (not (empty? #{metabase.lib-be.source-swap}))

FAIL in metabase.core.modules-test/model-config-not-stale-test (modules_test.clj:230)
Model exports and imports should not list models that are unused.

'enterprise/replacement' imports models that aren't used — remove them from :model-imports.
expected: (empty? (sort stale))
  actual: (not (empty? (:model/DashboardCardSeries)))
```

I don't care. i just want them to stop fighting
2026-04-09 16:20:09 -05:00
dpsutton
7f5d65cd08 Merge branch 'master' into transform-importing-creates-fields 2026-04-09 15:48:20 -05:00
Edward Paget
3392486525 Enforce session timeout server-side with last_active_at tracking (#71866)
* Enforce session timeout server-side with last_active_at tracking

Add a last_active_at column to core_session and use it to enforce
session inactivity timeouts on the server side (behind the
session-timeout-config premium feature). Activity updates are throttled
via an atomic compare-and-set cache in session.core to avoid a DB write
on every request. The session cleanup task prunes idle sessions and
expired cache entries.

* Move EE-dependent session timeout tests to enterprise test file

Session timeout tests that require the :session-timeout-config premium
feature fail in OSS mode because enable-session-timeout-config? checks
config/ee-available? which is always false without enterprise code.

* Remove trailing blank lines from test files
2026-04-09 15:48:18 -05:00
Edward Paget
71e5ad58dc Fix nested WHERE clause in remove-unsynced! for TransformTag (#72286)
Fix nested WHERE clause in remove-unsynced! for TransformTag (UXW-3710)

Mixing a {:where ...} HoneySQL map with kv-pair conditions in t2/delete!
caused toucan2 to misinterpret the map as a condition key, producing invalid
SQL with a WHERE inside a WHERE. Convert other-conditions into the {:where}
clause directly and remove unreachable scoped-path code that had the same bug.
2026-04-09 15:47:40 -05:00
Alex Yarosh
a96f3bc9d5 docs: Update links in CONTRIBUTING.md to latest version (#72300)
Update links in CONTRIBUTING.md to latest version
2026-04-09 16:35:49 -04:00
Alexander Polyankin
46e35e97ba Fix serialization export perf with no content models (#72290) 2026-04-09 12:26:36 -07:00
Cam Saul
629c10e733 Replace 'MLv2' with 'Lib' or 'MBQL 5' in docstrings and function names (#72121)
Replace usages of 'MLv2' with 'Lib' or 'MBQL 5'
2026-04-09 12:26:17 -07:00
metamben
5d0d3c47c0 Enable commented out drill-thru tests (#71845)
Closes QUE2-140
2026-04-09 21:54:05 +03:00
metamben
5f5d472fe7 Use locale independent formatting to get the day of the week (#71620)
* Use locale independent formatting to get the day of the week

Closes #57794

* Use MBQL 5 in the test
2026-04-09 21:53:49 +03:00
Aleksandr Lesnenko
afe5a73498 Increase stacked series gap, make it dynamic (#72118)
* increase stacked series gap, make it dynamic

* Update Loki Snapshots

* review

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-04-09 13:59:32 -04:00
github-automation-metabase
b9e2e96185 Update translations 2026-04-07 (#72070)
* Update translation sources 2026-04-07

* Update translations

---------

Co-authored-by: github-actions <github-actions@github.com>
2026-04-09 17:47:56 +00:00
Timothy S. Dean
8d5bd8ebcb Don't trigger result-metadata write based on non-default parameters (#72007)
If you have a parameterized card with computed columns, there is no Field from which to pull fingerprints, and the query-processor runs a fingerprint process based on the results of the query. Because the query is parameterized, the result is specific to whatever random parameter was used. `record-metadata!` saw this difference and updated the result-metadata on the card.

The fix: we will no longer persist `result_metadata` when non-default parameterized values are present.
2026-04-09 11:41:51 -06:00
Kevin Kelleher
2e71a55212 Fix colors in metrics viewer (#71874) 2026-04-09 17:19:16 +00:00
Edward Paget
fccf343325 Fix dashboard PUT response (#72173)
Extract shared `apply-card-permission-filters` helper used by both GET and
PUT paths to ensure consistent card visibility filtering. Also fix
`set-download-perms-on-dashcards` to handle empty dataset_query maps
gracefully.

Fixes: UXW-3571
2026-04-09 11:11:18 -05:00
Nicolò Pretto
2a8821b6a7 Address lack of continuity after admin completes database connection and x-ray dashboard steps (#72072)
* wip modal

* change button text

* polish

* update copy
2026-04-09 18:04:36 +02:00
dan sutton
498c3cb891 Seed metabase_field rows for transform target tables during import
When a transform is imported via serdes, the before-insert hook creates
a provisional metabase_table row but no field rows. Cards referencing
transform output fields fail import because portable references like
`[db schema table field]` can't resolve to integer IDs.

Add field prediction and seeding so that importing a transform also
populates its target table's fields:

- predict-target-fields: pure function that predicts output columns.
  MBQL uses lib/returned-columns; native SQL uses sql-parsing/
  field-references with type resolution via the metadata provider.
  Python transforms return nil (output is runtime-determined).

- sync-target-fields!: reconciles metabase_field rows against predicted
  fields — creates missing, retires stale, leaves matching untouched.

- seed-target-fields!: convenience wrapper chaining predict → sync,
  called from Transform's before-insert hook.

The prediction path is entirely metadata-provider-based with no app-DB
queries, making it reusable for offline validation (checker on a
workspace branch backed by YAML metadata).
2026-04-09 10:38:28 -05:00
John Swanson
6c65769bc5 fix n+1s in db, table, group creation (#72087)
* fix n+1s in db, table, group creation

this batches permissions changes to fix cluster lock timeouts with large numbers of groups, database, and tables.

When we created a new group, table, or database, we obtained O(NxM) fine-grained cluster locks, and did NxM separate inserts into data permissions.

This does batch operations instead. Obtains a single cluster-wide shared lock for batch operations (which actually might not be necessary at all for database and group creation - think it's still needed for creating a table though), then does the insert in batches.

Reduces the total number of queries dramatically:

- group creation: scaling with NxM -> ~10

- db creation: scaling with NxM -> ~10

- table creation: scaling with NxM -> ~8

* Fixup tests, improve perf more

* comment cleanup

* fix test

* remove dead code + unnecessary api epxansion

* Fix cluster lock contention

This is a fairly big change on its own, but it's fairly straightforward
and an additional performance improvement that should help with
concurrent processes trying to modify permissions at the same time.

Essentially, I realized that currently our cluster lock system provides
exactly one type of lock, an exclusive lock. But that's not the only
type of potential lock! Both Postgres and MariaDB/MySQL support locking
a row as *shared*. This conflicts with exclusive locks (`FOR UPDATE`)
but does not conflict with other shared locks.

This way, we can design a two-level lock system in which:

- most operations require:
  - a *shared* lock on `::batch-permissions-update`, and
  - an *exclusive* lock on `::batch-permissions-update-<db>`

- some operations require only an *exclusive* lock on
  `::batch-permissions-update`.

As one example, modifying permissions with the graph API requires an
exclusive lock on `::batch-permissions-update`. We don't want sync
adding a table at the same time that someone is modifying permissions,
e.g. moving from granular -> coalesced or vice versa.

On the other hand, sync itself just requires a *shared* lock on
`::batch-permissions-update`, because it can happily coexist with other
syncs that are for different databases. But they'll all take exclusive
locks on `::batch-permissions-update-<db>`, so any permissions changes
they're making to the database will be serialized.
2026-04-09 08:37:14 -07:00
Kamil Mielnik
42c4a2f3e9 Remove accidental semicolon in JSX (#72242) 2026-04-09 15:18:59 +00:00
Chris Truter
58916bb3ce Fix module update method to insert missing :model-X entries (#72247) 2026-04-09 17:10:20 +02:00
lbrdnk
50e9fe7a7a Adjust format-native-query to accept legacy mbql (#72217)
* Adjust format-native-query to accept legacy mbql

* Add test

* Restore permissive extraction form

* assertion

* Docstring
2026-04-09 16:53:58 +02:00
Ngoc Khuat
d6ccee4d52 GDGT-2143 Use subscription creator's perms for attachment check (#72156) 2026-04-09 14:25:36 +00:00
Aleksandr Lesnenko
d3ba36d66d Change config of js execution context for static viz (#72196)
* static viz bundle should be sandboxed

* update color selector

* split execution contexts
2026-04-09 14:05:01 +00:00
Maksym Yakubych
3b995f986f fix: sql edit tools creating new questions instead of editing (#70255) 2026-04-09 14:03:44 +00:00
Nathan Voxland
6a7e27195f Fix: allow moving dashboard questions to their parent collection (#71550)
Allow moving dashboard questions to their parent dashboard's collection

The MoveModal's isSameDestination() was comparing the question's
collection_id to the target collection, blocking the move. But for
dashboard questions, the real "location" is the dashboard — moving to the
collection is a valid operation that detaches the question from the
dashboard. Added \!movingItem.dashboard_id to the collection check.
2026-04-09 19:26:47 +05:30
Nathan Voxland
dc38720b20 Add keyboard shortcut (g s) to navigate to Data Studio (#71328)
* Add keyboard shortcut (g s) to navigate to Data Studio

Closes UXW-3155

* adding permissions check, e2e test coverage

* e2e adjustment

---------

Co-authored-by: Nick Fitzpatrick <nickfitz.582@gmail.com>
2026-04-09 19:25:03 +05:30
Timofey Kachalov
6078e48144 feat(sdk,embed-js): Improve EntityPicker mobile UX (#71815) 2026-04-09 17:54:23 +04:00
Denis Berezin
605968c6e9 Fix styling for chart png download in Firefox (#72198) 2026-04-09 16:24:59 +03:00
Uladzimir Havenchyk
77fca900be deps: upgrade yaml (#71988)
chore: upgrade yaml
2026-04-09 14:57:30 +03:00
Nick Fitzpatrick
f31336e113 Uxw 3547 add analytics events for metrics viewer and metrics homepage (#72091)
* Adding events

* tests

* remove page view events

* re-adding comment since it's relevant again
2026-04-09 16:40:29 +05:30
Phoomparin Mano
75582f7983 fix(sdk-bundle): only render SDK components when EE plugins are loaded (#70737)
* only render children if plugin is ready

* fix: wait for ee plugins to initialize before rendering children

* add unit tests for race condition

* fix: avoid module cache and always re-dispatch plugin ready

* fix: initialize EE plugins synchronously during render instead of useEffect

Moves plugin initialization out of useEffect into the render body,
eliminating the extra frame delay. Uses reduxStore.dispatch directly
following the same pattern as use-init-data-internal.ts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 17:23:37 +07:00
Chris Truter
e54b1d968c Delete agent APIs for Workspaces (#71827) 2026-04-09 08:02:24 +00:00
Chris Truter
398840c0a1 OAuth token cleanup task (#72081) 2026-04-09 09:33:58 +02:00
Chris Truter
70552d31d8 Add OAuth and MCP throttling (#71884) 2026-04-09 09:33:45 +02:00
Timofey Kachalov
a2d99db064 Mock i18n FE translations to use EN texts (#72044) 2026-04-09 10:58:24 +04:00
da
f09bc46311 Fixes the find and replace menu from dissapearing (#71780)
Fixes the find and remove menu from dissapearing
2026-04-08 21:36:36 -03:00
appleby
80af5a2b55 BOT-1282 Report combined in + out tokens in :metabot-usage metering (#72186)
* BOT-1282 Report combined in + out tokens in :metabot-usage metering

* Add some additional tests for :metabot-usage reporting
2026-04-08 22:21:56 +00:00
github-automation-metabase
7382721f95 Auto-update documentation for master (#72195)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-04-08 17:35:05 -04:00
Maksym Yakubych
ee7663ccd1 feat: metabase as an AI provider (#71655) 2026-04-08 20:39:30 +00:00
Uladzimir Havenchyk
a5cf9c43c5 bundle: exclude lazy loaded libs from vendor bundle again (#72061) 2026-04-08 23:02:42 +03:00
bryan
db672b4043 Copy model metadata overrides to Fields during models-to-transforms (#72129) 2026-04-08 13:51:19 -06:00
Aleksandr Lesnenko
bc41b0d2c3 remove data studio link from the metrics viewer (#72122)
* remove data studio link from the metrics viewer

* update spec
2026-04-08 19:44:31 +00:00
Edward Paget
910a4b3e09 Require authentication for eid-translation API endpoints (#72174)
The /api/eid-translation routes were unauthenticated despite only being
used by frontend routes behind the IsAuthenticated guard. Wrap with +auth
and remove the stale "public facing" comment.
2026-04-08 13:41:01 -05:00
John Swanson
a224d29129 Don't allow pausing JWT if it's on via env var (#69386)
* Don't allow pausing JWT if it's on via env var

This separate the `jwt-enabled` setting into two parts:

- `jwt-enabled`, which is settable via an env var, and means "do I want
JWT to run or not"?

- `jwt-enabled-and-configured`, which is not settable at all, and simply
computes `(and (jwt-enabled) (jwt-configured))`. This one means "JWT is
running".

This way, if you set MB_JWT_ENABLED via the env, we don't give you the
option to pause or disable JWT anymore. If it's configured, it's on.

In some ways `MB_JWT_ENABLED` feels useless here, when set alone - it's
not really doing anything other than blocking the user from pausing JWT.
But I think in context it makes sense: you want to be able to configure
JWT solely via the env, but if you do that partially, it makes sense
that we just don't let you change the env-configured bits.

* kondo

* fix
2026-04-08 11:37:17 -07:00
Jeff Bruemmer
2867945fd4 docs - fix anchor links (#72176)
fix anchor links
2026-04-08 13:23:26 -04:00
technomancy
657669dcc5 Implement table privileges support for SQLite. (#71950)
* Implement table privileges support for SQLite.

This is based on code from https://github.com/metabase/metabase/pull/57000
but breaks it down into more manageable chunks.

* Set SQLite insert/update/delete privileges to true.

Unclear why the original PR hard-coded these to false; SQLite has no
permissions system which could prevent writes.

Getting this wrong doesn't affect anything in the backend; it's not
used anywhere outside the frontend, so I suppose it's somewhat
unrealistic to expect it to cause a test failure.
2026-04-08 10:22:03 -07:00
John Swanson
177a6515b7 Query parameter cleanup (#72048)
* Normalize query parameters in preprocessing

* Filter metadata results by user permissions

* Simplify permission checking logic

* Use server-controlled query context

* Validate query parameters at API boundaries

* Code review improvements

* Fixed failing test

* Fixed failing test

* Revert SQL driver to read persisted-info from query object

Instead of having the SQL driver load persisted-info from the metadata
provider, retain the old behavior where it reads :persisted-info/native
from the query map (set by fetch-source-query middleware).

---------

Co-authored-by: Edward Paget <ed.paget@gmail.com>
Co-authored-by: Nathan Voxland <nathan@metabase.com>
2026-04-08 12:04:28 -05:00
Alexander Polyankin
25969cb31e Fix source replacement with null effective_type (#72124) 2026-04-08 16:29:14 +00:00
Ben Grabow
6d45a39d94 Ghy-3343 Re-export instance analytics content (#72063)
* Re-export instance analytics in new serdes format
2026-04-08 11:00:42 -05:00
Alex Yarosh
97f95e40cd docs: more typos (#72168)
more typos
2026-04-08 11:49:12 -04:00
Nick Fitzpatrick
53a13043ae Hide Regenerate Key button if form field is readonly (#72105)
* Hide Regenerate Key button if form field is readonly

* adjust unit test
2026-04-08 20:59:07 +05:30
Edward Paget
241181c7f8 Add README for built-in MCP server (#71834)
Documents the MCP server capabilities, endpoint, client setup
(Claude Code, Claude Desktop, Cursor), OAuth authentication,
scopes, available tools, JSON-RPC methods, and architecture.
2026-04-08 10:11:22 -05:00
John Swanson
5dde87ebf7 Fix search filters for published tables (#71323)
When:

- a table was published,
- a user had data permissions for that table, and
- the user did NOT have permissions on the collection the table was
  published to

Then the search endpoint would not return that table, even though it's
queryable and viewable via data permissions.

This fixes the filtering, so that the table is discoverable via search.
2026-04-08 08:04:15 -07:00
Anderson
31d3ebe6fb [AI Controls] Add tooltip explaining most-permissive group access (#72132)
Add tooltip explaining most-permissive group access
2026-04-08 11:59:18 -03:00
Ngoc Khuat
9d50b86f16 Fix validation in public dashboard action endpoint (#72088) 2026-04-08 13:21:47 +00:00
YB
fdd2d558ba GDGT-26 Fix discard-setting-changes helper for settings that use init (#72069)
The issue reported that discard-setting-changes is broken for settings that use :init (e.g. query-analysis-native-disabled). The report predicted that calling the setting getter inside the macro would return nil, and that the value would be corrupted afterward.

do-with-discarded-setting-changes! used setting/read-setting to capture the "original" value before the thunk. read-setting binds *disable-init* to true, so for settings whose value comes from an :init function (and which haven't been initialized yet), it returns nil. This nil is then passed as both:

(outer capture) The "temporary" value to set during the thunk (via do-with-temporary-setting-value!)
(inner capture) The value to restore in the finally block (via the :skip-init? flag)
The key fix here is to use setting/get instead of setting/read-setting. We also remove the :skip-init? flag since it was there to match the semantics of read-setting and suppress the init call.
2026-04-08 17:23:40 +08:00
Romeo Van Snick
fc07abb93c Fix race condition in test and reset mocks (#72150) 2026-04-08 11:23:27 +02:00
Chris Truter
8a869177f4 Standardize where models live (#72096) 2026-04-08 08:06:38 +00:00
Romeo Van Snick
ed21122ef5 Content translations for parameters values without custom labels (#72025)
* Translate parameter values too

* Allow translating arrays of values

* Add e2e test for translations without label

* Fix types
2026-04-08 07:36:55 +02:00
Anderson
c989e01952 Metabot AI Usage Limits page (#71699)
* Implement static UI for Usage controls page

* Added initial ai-controls tables

* Set sidenav menu items / Add placeholders for new pages

* Implement Metabot Customization page UI

* - Added metabot/permissions GET and PUT apis
- Added settings for metabot name/tone/icon

* Fixed migration ids

* fixup! bad merge

* Add :scope metadata to all Agent Loop tools and create metabase.metabot.scope namespace

- Create metabase.metabot.scope with *current-user-scope* (defaults to #{}),
  scope-matches? with hierarchical wildcard support, and unrestricted set
- Add :scope to all 38 Agent Loop tool-fns with specific action scopes
  (e.g. "agent:sql:create", "agent:viz:edit") — wildcards are grant-side only
- Propagate :scope through wrap-tools-with-state in tools.clj
- :capabilities remain unchanged (orthogonal data-permission gating)
- Add tests for scope-matches?, default scope, and stub

Done: tool-scope/phase-1-tool-scope-declarations

* Add scope-based authorization middleware for Agent Loop tools

- Filter tools by scope in get-tools-for-profile (profiles.clj)
- Check scope before tool invocation in wrap-tools-with-state (tools.clj),
  returning a generic denial message (scope details logged, not leaked)
- Bind *current-user-scope* to unrestricted in run-agent-loop (temporary
  until phase 4 wires real permission resolution)
- Add scope enforcement tests covering filtering, denial, wildcards,
  no-scope passthrough, and default empty scope behavior

Done: tool-scope/phase-2-authorization-middleware

* Gate profile system prompts by metabot permission types

- Add *current-user-metabot-permissions* dynamic var to scope.clj
- Bind all-yes permissions in run-agent-loop (temporary, phase 4 wires real resolution)
- Derive has_sql_generation, has_nql, has_query_tools, has_other_tools
  boolean flags from permissions and pass to Selmer template context
- Gate internal.selmer sections: critical constraints, verification protocol,
  query building steps, SQL construction, SQL anti-patterns, SQL examples,
  NLQ guidance, dashboard routing, and query-focused common scenarios
- General sections (identity, context grounding, communication style, search
  example, entity linking) remain ungated for all permission levels
- 7 tests, 43 assertions covering all permission combinations

Done: tool-scope/phase-3-profile-prompt-gating

* Wire user-metabot-perms->scopes to metabot_permissions data model

- Implement resolve-user-permissions: looks up user's groups, queries
  MetabotPermissions, resolves most-permissive value across groups
- Implement real user-metabot-perms->scopes: maps :yes permissions to
  wildcard scope sets, always includes always-granted-scopes
- Replace temporary unrestricted/all-yes bindings in run-agent-loop with
  real permission resolution from api/*current-user-id*
- Superusers get scope/unrestricted and all-yes-permissions
- Permission resolution done once at reify construction, not per-reduce
- Agent API scope binding deferred (tracked in rdm task agent-api-scope-binding)
- 38 new test assertions covering permission→scope mapping, single-group,
  multi-group most-permissive-wins, and default scenarios

Done: tool-scope/phase-4-permissions-to-scopes

* Update permissions expected request format

* Include metabot and semantic-search tool options on the backend

* Connect access controls UI to the backend

* Wire up the backend for the Metabot Customize page

* Polish access controls page / Create MetabotSystemPromptsPage

* Added metabot-system-prompt

* Connect System prompt page to the backend

* Remove model selection + clean up

* Use custom metabot name

* Use metabot-icon in the UI + added metabot-show-illustrations toggle

* Removed metabase custom prompt

* Add defscope macro, scope registry, and api-scope module

Introduce a `defscope` macro that registers scopes with translatable
descriptions in a global registry, replacing inline scope strings across
all tool and endpoint metadata with typed var references.

Key changes:
- New `metabase.api-scope.core` module with defscope, scope registry,
  scope-matches?, and public API (all-scopes, scope-description)
- All 25 agent scopes declared via defscope in metabase.metabot.scope
- 3 EE workspace scopes declared in metabase-enterprise.workspaces.scope
- validate-tool-var! rejects tools with unregistered scopes at startup
- defendpoint accepts var references for :scope metadata (not just strings)
- enforce-scope logs dev-time warnings for unregistered endpoint scopes
- MCP scope enforcement now handled by defendpoint middleware (removed
  redundant pre-dispatch check); enforce-authentication preserves existing
  token-scopes on synthetic requests
- Scope enforcement error messages no longer leak required scope names
- Consolidated duplicate scope-matching logic in mcp/tools.clj

Done: tool-scope/phase-5-defscope-registry

* Make semantic_queries optional in search tool schemas

When semantic search is not enabled, the feature gate strips
semantic_queries from the tool definition sent to the LLM, but Malli
validation still required it — causing an "Invalid input" error.

* Add missing agent:query scope declaration

The agent API query endpoint requires "agent:query" but it was never
registered via defscope, only its sub-scopes were.

* Block agent profiles by permission and add prompt gating to slackbot

Add profile-level permission checks in run-agent-loop that throw 403
when users lack required permissions for specialized profiles (:sql,
:nlq, :transforms_codegen, :document-generate-content). Add explicit
denial messages to internal.selmer and slackbot.selmer templates when
features are disabled, directing users toward available capabilities
like search instead.

* Enforce per-group metabot on/off switch and remove semantic-search permission

Add base permission/metabot check in check-metabot-access! that blocks
all agent profiles when the group-level metabot permission is :no.
Remove permission/metabot-semantic-search from the permissions model
and frontend. Fix permissions API test request body format and update
all-perm-types to match current permission set.

Done: task/enforce-metabot-group-onoff

* Integrate custom system prompts into internal, SQL, and NLQ profiles

Read the metabot-system-prompt admin setting in build-system-message-content
and pass it as a custom_instructions Selmer variable. Add {% if %} blocks
at the end of internal, sql-querying-only, and natural-language-querying-only
templates to render custom instructions when set. Use |safe filter to
avoid HTML-escaping admin-provided content.

Done: task/integrate-custom-system-prompts

* Added AI usage backend APIs and tables

* Add new system prompts pages

* Update the ai feature access page

* Update side nav for Usage controls menu item + Clean up

* Make the page headings margin top consistent

* Update Customization page / Remove metabot-tone

* Add default metabot permissions for magic user groups

Insert default metabot permission rows (all yes/medium) for the four
magic groups: Administrators, All Users, Data Analysts, and All Tenant
Users. Also fix missing remarks on group_id column in metabot_group_limit
table to pass migration linter.

* Add GET /api/metabot/permissions/user-permissions endpoint

Return the current user's resolved metabot permissions (most permissive
across all their groups). Superusers get all-yes permissions. Response
uses simplified key names without the permission/ namespace prefix.

Done: frontend-ai-permission-gating/phase-1-backend-user-permissions-endpoint

* Add useUserMetabotPermissions hook for granular AI permission checks

Add RTK Query endpoint for GET /api/metabot/permissions/user-permissions
and a useUserMetabotPermissions() hook that returns granular permission
booleans (canUseMetabot, canUseSqlGeneration, canUseNlq, canUseOtherTools)
combining the global metabot-enabled setting with per-user group permissions.

Done: frontend-ai-permission-gating/phase-2-frontend-permissions-hook

* Gate metabot UI entry points with granular user permissions

Replace useMetabotEnabledEmbeddingAware with useUserMetabotPermissions
in 6 primary metabot UI entry points: sidebar button (canUseMetabot),
AI exploration menu (canUseNlq), Fix SQL button and inline prompt
(canUseSqlGeneration), chart analysis and data studio buttons
(canUseMetabot). Update tests to mock the permissions API endpoint.

Done: frontend-ai-permission-gating/phase-3-gate-ui-entry-points

* Migrate remaining components from useMetabotEnabledEmbeddingAware to useUserMetabotPermissions

Replace useMetabotEnabledEmbeddingAware with useUserMetabotPermissions
in all remaining metabot UI components: Metabot shell, MetabotQueryBuilder
(canUseNlq), MetabotQuickLinks, AppBarLarge, CodeMirrorEditor
(canUseSqlGeneration), query builder context registration, MetabotEmbed,
and CommandSuggestion. Add permissions API mock to shared test utils and
all affected test files. SelectEmbedExperienceStep intentionally kept on
the old hook (uses forceEmbedding for embedding feature config check).

Done: frontend-ai-permission-gating/phase-4-migrate-remaining-embedding-aware-uses

* Remove usage limits menu item

* Fix migration to work with mysql

* Fix clj-kondo warnings on feat/ai-controls branch

- Add api-scope to mcp module and users to metabot module allowed deps
- Add response schema to /user-permissions defendpoint
- Suppress aliased-namespace-symbol warnings on potemkin import-vars
- Remove unused make-tool-var helper and prefix unused bindings with _
- Rename make-tool-var to make-tool-var! (uses alter-meta!)

* Address code review findings from clojure-review

- Add response schemas to GET / and PUT / permissions endpoints
- Add ^:parallel to 22 pure tests across 3 test files
- Move check-metabot-access! guard out of let binding for clarity
- Fix indentation, alignment, :refer :all, and stale kondo ignores

* Route agent API scope references through metabase.metabot.core

Re-export scope vars from metabase.metabot.core so external modules
use the public API namespace instead of metabot.scope directly.

* Address PR review comments

- Fix indent in api-scope module config
- Re-export workspace scopes from workspaces.core instead of using
  workspaces.scope directly in agent_api/workspace.clj
- Extract wrap-with-scope-check into its own function in tools.clj
- Fix comment indentation in core_test.clj

* Add 'Settings and general limits' section on Usage limits page

* Add 'Group and tenant limits' section

* Tighten user-permissions response schema with exact permission fields

Use keyword keys and enum values matching the defined permission types
instead of loose [:map-of :string :string]. Also fix simplify-permissions
to produce keyword keys/values instead of strings.

* Separate foreign keys and indexes into distinct migration steps

Extract inline foreign key constraints from createTable into their own
changesets so FKs can be dropped independently of indexes/unique
constraints. Affects metabot_permissions, metabot_instance_limit, and
metabot_group_limit tables.

* Added api_usage_log tracking table and populate it through usage

* Add api-scope to driver-affecting-overrides

api-scope is a simple scope-registry utility that only depends on util.
It was triggering driver tests via its enterprise/workspaces dependent.

* Connect the backend API / Remove dollar limit type

* Initial llm limit checks

* Fix CI failures from AI controls + master merge

- Add MetabotPermissions/GroupLimit/InstanceLimit to copy entities
- Fix module config: sort api-scope, remove extraneous APIs/uses,
  add PermissionsGroup to metabot model-imports
- Fix MCP scope-matches? returning false instead of nil on non-match
- Remove :capabilities gate from autogen dashboard tool
- Bind scope to unrestricted in profiles capability tests
- Update prompt gating tests to match master's template wording
- Update prompts test to match metabot_name template variable
- Update scope resolution tests for migration defaults (yes/medium)

* Remove usage limit code from AI controls branch

Usage limits (instance, tenant, and group) are being developed on a
separate branch. Remove all related backend code: models, API endpoints,
settings, migrations, and tests.

Done: ai-controls-to-enterprise/phase-1-remove-usage-limits

* Fix copy entities: deduplicate MetabotPrompt, move AI models to core section

* Move permission resolution and MetabotPermissions model to enterprise

Introduce the :ai-controls premium feature flag and restructure metabot
permission resolution for the OSS/EE split:

- Register enable-ai-controls? in premium_features/settings.clj
- Convert resolve-user-permissions to defenterprise (OSS returns defaults)
- Create EE implementation with full DB-backed group resolution
- Move MetabotPermissions Toucan2 model registration to EE namespace
- Keep pure permission type definitions and defaults in OSS
- Split tests: OSS verifies defaults, EE verifies group-based resolution

Done: ai-controls-to-enterprise/phase-2-defenterprise-permission-resolution

* Move permission admin APIs to enterprise with input validation

Move GET/PUT /api/metabot/permissions admin endpoints to
/api/ee/ai-controls/permissions, gated by :ai-controls feature.
Keep user-permissions endpoint in OSS. Add schema validation on
PUT perm_type/perm_value fields, fix 402 feature-gate test to use
correct assertion pattern, and add ^:parallel to all test defs.

* Move AI controls pages into new plugin

* Add error toast for instance limit update

* Remove unused permission/metabot-model (model size) feature

The metabot-model permission (large/medium/small) was defined
speculatively but never wired into model selection and had no UI.
Remove it from permission definitions, defaults, API schemas,
migration seed data, frontend types, and all tests.

Done: ai-controls-to-enterprise/phase-4-move-model-loading

* Gate metabot customization settings behind :ai-controls feature

Add :feature :ai-controls to branding settings (metabot-name,
metabot-icon, metabot-show-illustrations) and system prompt settings
(metabot-chat-system-prompt, metabot-nlq-system-prompt,
metabot-sql-system-prompt). Without the feature, reads return defaults
and writes are rejected.

Done: ai-controls-to-enterprise/phase-5-move-customization-settings

* Refactor MetabotPermissions: move model to OSS, replace deprecated APIs

- Move Toucan2 model registration from enterprise to
  metabase.metabot.models.metabot-permissions (OSS)
- Replace mdb/update-or-insert! with t2/exists?+update!/insert!
- Replace user/group-ids with a subquery join through
  PermissionsGroupMembership
- Update model resolution to point to OSS namespace

* Move MetabotPermissions model to EE, fix test failures for ai-controls feature

- Move MetabotPermissions Toucan2 model registration from OSS to
  enterprise (metabase-enterprise.metabot.models.metabot-permissions)
- Move permission defs (metabot-permissions, perm-types, perm-type-defaults)
  into metabase.metabot.scope alongside related permission/scope code
- Add :ai-controls to snowplow stats ping and session token features test
- Add MetabotPermissions to serialization excluded-models and entity-id
  not-exported lists
- Update serialization baseline with new metabot settings
- Fix modules config: add api routes, model imports/exports for
  enterprise/metabot; remove stale users dep from metabot module

* Fix kondo warnings in settings_test: use true?, remove ^:parallel

* Add usage limit models and API as enterprise-only endpoints

Restore the usage limit code (instance, tenant, and group limits) that
was removed in 2db9f363, now scoped under enterprise modules and the
/api/ee/ai-controls/usage/ route prefix with :ai-controls feature gate.

* Address clojure-review findings: per-type perm validation, privacy, metadata

- Validate perm_value per perm_type in PUT endpoint (not just flat enum)
- Make format-native-query private
- Add ^{:added "0.61.0"} to enable-ai-controls?
- Add clarifying comment on enforce-scope dev-time warning

* - Add AI usage limits enforcement, logging, and cleanup
- Rename metabot-limit-type to metabot-limit-unit
- Add scheduled task to trim ai_usage_log rows older than 3 months

* Move ai controls RTK endpoints to enterprise folder

* Fix input debounced state issue

* Clean up on Group and tenant limits tabs

* - Add AI usage limits enforcement, logging, and cleanup
- Rename metabot-limit-type to metabot-limit-unit
- Add scheduled task to trim ai_usage_log rows older than 3 months

* Cleaned up ai_controls migrations

* Merged from ai-controls

* Fix CI test failures caused by ai-controls permission system

The new check-metabot-access! gate in run-agent-loop rejects
non-superusers whose permissions default to :no. Honor pre-bound
*current-user-metabot-permissions* so tests can bind permissions
directly. Also fix scope error message expectation, gate custom
prompt settings behind :ai-controls feature, increase poll timeout
for closing-connection test, and split large deftests into smaller
parallel tests.

* Move EE-dependent permissions test to enterprise, ignore metabot_permissions in H2 dump comparison

The user-permissions test that creates :model/MetabotPermissions belongs
in EE tests since the model is EE-only. The metabot_permissions table is
created by migration in all editions but only included in H2 dumps when
EE is available, so add it to the ignored tables in the dump comparison
utility.

* Fixed namespace reference

* Make cache ttl be 10 seconds

* Fix FE test failures by mocking metabot user-permissions endpoint

The new useUserMetabotPermissions hook calls /api/metabot/permissions/user-permissions
in many component trees. Tests that render these components were failing due to
unmocked API calls. Added setupUserMetabotPermissionsEndpoint helper and called it
in each affected test's setup.

* Mark update-permissions-test as non-parallel to fix MariaDB CI failures

* Fix prettier formatting in use-user-metabot-permissions test

* Fix TypeScript errors: missing settings defaults, stale token feature refs, type mismatches

* Fix eslint: remove unused createMockTokenFeatures imports, fix import ordering

* Compute token max in millions of tokens

* If any groups have a null limit, return null as the limit

* Improve state handling on group and limits components

* Add unit tests

* Fix metabot/new quicklink / don't call user-permissions if metabot is globally disabled

* Remove test flakiness

* Address PR review comments: remove scope re-exports, use enums, split tests

- Remove potemkin re-exports from metabot.scope; consumers now use
  api-scope directly for scope-matches?, unrestricted, registered-scope?,
  all-scopes, and scope-description
- Use proper malli enums for perm_type/perm_value in EE permissions
  response schema instead of bare :keyword
- Sort required-feature->message alphabetically in EE routes
- Fix api-scope indent in kondo config
- Delete unused keep-me comment in EE metabot routes
- Split large deftests into focused tests in permissions_test,
  scope_resolution_test, and profiles_test
- Remove unnecessary blank lines between testing blocks in api_test

* Exclude new AI usage limit models from serialization and update module config

Add AiUsageLog, MetabotGroupLimit, MetabotInstanceLimit, and
MetabotPermissions to serialization excluded-models, entity-id
not-exported, and copy-test exclusion lists. Update enterprise/metabot
module config with routes API, app-db/users dependencies, and
PermissionsGroup model import. Add new metabot settings to
serialization baseline.

* Fix kondo warnings: sort namespace requires alphabetically

* Fix namespace require ordering in agent core

* Fix add missing init module

* Fix module config for AI usage limit models

Update enterprise/metabot module: remove stale app-db and users deps,
add AiUsageLog model import. Export AiUsageLog from metabot module.
Remove stale internal-stats.metabot from internal-stats API.

* Add e2e tests for basic ai controls

* Fix serialization baseline: rename metabot-limit-type to metabot-limit-unit

* Fix e2e tests

* Add e2e tests for ai usage limits

* Polish tests

* Fix e2e tests

* Fix bug on custom quota-reached message input

* Fix issues with auto-saving and debounced requests

* Address further review comments

* Set max limit number on inputs

* Fix some tests

* Fix flaky MetabotFeatureAccessPage test by awaiting permission state

* Fix unit test

* Add anthropic api mock to test group quota limit more properly

* Remove stale metabot dependency from testing-api module config

* Fix nql→nlq typo in permission type and OSS default permissions

The permission type `permission/metabot-nql` was misspelled throughout
the codebase (should be `nlq` for Natural Language Query). Also fixed
the prompt file reference `nql_search.md` → `nlq_search.md` which was
a runtime bug, and updated the OSS fallback for resolve-user-permissions
to return all-yes (permissive) instead of all-no defaults.

* Move DB query helpers from permissions API into MetabotPermissions model

Move permissions-for-group and all-permissions from the API namespace
into the model namespace where they belong as data-access functions.

* Fix flaky resolve-user-permissions-nil-test

Return all-yes-permissions for nil user-id in both OSS and EE paths
(no user means no restrictions). Wrap test with with-premium-features
to make it deterministic regardless of token presence.

* Fix defenterprise-schema nil return schema causing OSS test failures

defenterprise-schema for log-ai-usage! had no return schema, which
produced nil and crashed malli validation in OSS mode. This broke the
report-token-usage-xf transducer pipeline, preventing snowplow events
from firing in downstream transducers.

* Renamed "conversations" to "messages"

* Add tenant limits e2e test / Address a few other review comments

* Fix more review comments

* Clean up on other pages to reuse new hook

* Move translation maps outside their functions / Fix config.edn issue

* Do not reset limits when switching limit types

* Fix e2e test

---------

Co-authored-by: Nathan Voxland <nathan@metabase.com>
Co-authored-by: Edward Paget <edpaget@users.noreply.github.com>
Co-authored-by: Edward Paget <ed.paget@gmail.com>
2026-04-07 22:13:53 -03:00
Ryan Laurie
0b237d0918 Fix release permissions (#72140)
* more permission constriction

* more permission constriction
2026-04-07 17:07:57 -06:00
Ryan Laurie
b1819f54f4 update release workflow permissions (#72138) 2026-04-07 16:59:49 -06:00
Timothy S. Dean
69a5020367 Adjust CLAUDE.md backend test instructions (#72136) 2026-04-07 16:58:48 -06:00
Ryan Laurie
e01f66612a update release workflow permissions (#72137) 2026-04-07 16:33:15 -06:00
github-automation-metabase
69a776ea2d Auto-update documentation for master (#72131)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-04-07 17:23:02 -04:00
Oleksandr Solovyov
3671d3bd80 metabot: ability to make requests via ai proxy w/o having api key configured (#71714)
* metabot: ability to make requests via ai proxy w/o having api key configured

* modernize logic: BYOK is more important than ai proxy

* dry error messages and tests

* metabot token reporting

* byok setting

* track that ai-proxied messages are marked in the db

* only count ai_proxied in tokens reported

* fix ci concerns

* metabase/ as indicator of requests going through ai-proxy

* Port resolve-auth and test fixes from #71655

* Add claude-list-models-auth-preferences-test similar to claude-auth-preferences

* Add conventional -test suffix to auth-preferences tests

* BOT-1262 Add :feature :metabase-ai-provider guard to llm-proxy-base-url defsetting

Rather than moving the defsetting into ee add a :feature :metabase-ai-provider guard and leave it in oss.

* Fix trailing whitespace

* Fix logic in llm-provider-configured?

Logic now matches metabase.metabot.self.core/resolve-auth, i.e. no proxy fallback if llm-metabot-provider is unconfigured.

* Remove unused func

* Add more tests for metabase proxied models

Add tests for:
- validate-metabot-provider!
- /list-models endpoint provider resolution for both direct and metabase/ prefix
- slackbot streaming ai-proxy? propagation to store-message!

* Add metabot.provider-util namespace for parsing model-and-provider strings

And use it instead of ad-hoc parsing with str/split in various places.

* Remove unused metabot.core/routes

Re-exported from metabot.api/routes but nothing references it.

* Prefer with-redefs over mt/with-temporary-setting-values in tests to override env vars too

Specifically for tests that set llm-anthropic-api-key to ignore any value set in the env.

* Fix token usage reporting for openai

OpenAI returns token usage in :input_tokens and :output_tokens, map those back to out internal :promptTokens and
:completionTokens, respectively and also drop any nested token usage *_details that get returned to prevent an
exception in accumulate-usage-xf when attempting to (merge-with +).

    java.lang.ClassCastException: class clojure.lang.PersistentArrayMap cannot be cast to class java.lang.Number (clojure.lang.PersistentArrayMap is in unnamed module of loader 'app'; java.lang.Number is in module java.base of loader 'bootstrap')
	at clojure.lang.Numbers.add(Numbers.java:155)
	at clojure.core$_PLUS_.invokeStatic(core.clj:994)
	at clojure.core$_PLUS_.invoke(core.clj:986)
	at clojure.core$merge_with$merge_entry__6053.invoke(core.clj:3087)
	at clojure.core$reduce1.invokeStatic(core.clj:946)

* Review feedback: use str/replace-first

* Review feedback: ensure metabot-provider-schema matches supported-metabot-providers

---------

Co-authored-by: Mike Appleby <86076+appleby@users.noreply.github.com>
2026-04-07 13:25:37 -07:00
Tyler Plude
742b2190cd [BOT-1272] Fix missing metabot-id in streaming request (#72114)
pass metabot id to native streaming; unit test
2026-04-07 13:22:05 -07:00
Alex Yarosh
9b76829304 docs: the great detypoing (#72100)
* typos

* embedding
2026-04-07 13:15:59 -04:00
Jeff Bruemmer
0ffb9c891b docs - clarify one dashboard per page (#72098)
* clarify one dashboard per page

* questions
2026-04-07 13:14:34 -04:00
lbrdnk
a0a787ea54 Convert legacy into mbql5 on API level (#71944)
* Convert legacy into mbql5 on API level

* tests

* idempotence

* whitespace

* Review comments
2026-04-07 19:08:10 +02:00
Nathan Voxland
9f7c0c3a27 Search indexing memory and CPU improvements (#71999) 2026-04-07 11:30:01 -05:00
Cam Saul
4ae75fc5e6 Replace leftover usages of 'pMBQL' with 'MBQL 5' (#72066)
* Replace the term 'pMBQL' with 'MBQL 5'

* Restore deleted file
2026-04-07 09:29:27 -07:00
John Swanson
b1734f09ae No "login from new device" emails for to_session (#69854)
* No "login from new device" emails for `to_session`

Prevent the /api/sso/to_session endpoint from sending "login from new
device" emails. This endpoint is used for programmatic JWT-to-session
token exchange, so new device notifications are noise. Login history is
still recorded for audit purposes.

* kondo fix

* fix tests
2026-04-07 09:10:17 -07:00
Jeff Bruemmer
84329d9f08 Fix typo in settings documentation (#72074) 2026-04-07 11:30:04 -04:00
Timofey Kachalov
acfdee530b fix(sdk,embed-js): Fix wrong join on dropdown items styles (#71993) 2026-04-07 19:20:18 +04:00
Nick Fitzpatrick
d029b634ae Metric Viewer Menu Dividers (#71906) 2026-04-07 17:34:38 +05:30
Nick Fitzpatrick
122500f230 Update strings in metric view (#71912) 2026-04-07 17:34:27 +05:30
Nick Fitzpatrick
277d629317 Update Measure Icon in Data Studio and Metric Explorer (#71924) 2026-04-07 17:34:17 +05:30
Nick Fitzpatrick
05a0cd9db2 Hide the separator in breakout menu if not needed (#71937) 2026-04-07 17:34:05 +05:30
YB
12e3515671 GDGT-1431 Delete notifications orphaned from deleted cards (#71897)
When a card with an alert is permanently deleted, the Notification record and its Quartz cron trigger survive.
The trigger keeps firing and crashing every time, clogging logs and task history indefinitely.

The root cause is that Card's before-delete hook cleans up ParameterCards, ModerationReviews, and Revisions — but not Notifications. The notification_card table has a deleteCascade FK to report_card, so the NotificationCard payload row gets cascade-deleted, but the Notification row itself survives with a dangling payload_id.

There's 2 fixes in this PR:

Add notification cleanup to Card's before-delete hook. Materializes notification IDs first because Notification's own before-delete deletes the NotificationCard, which would invalidate a delete that depends on a subquery by the time the actual DELETE executes.

For notifications orphaned before this fix is deployed, guard in send-notification-sync! checks if the NotificationCard payload still exists before hydration. If not, it deletes the notification and throws a clean error.
We fully delete rather than deactivate (setting :active false) because an orphaned notification with a deleted card has no value — its handlers, subscriptions, and recipients would just be dead rows. This matches what happens when users manually delete an alert via delete-alert-and-notify!.
2026-04-07 10:02:06 +08:00
technomancy
69c17552f7 Add technomancy (me) to slack and GH team map json. (#71698)
Add technomancy (me) to slack map json file and github team map.

This is one of the steps of the onboarding guide for day 1.

[ci skip]
2026-04-06 16:36:27 -07:00
github-automation-metabase
3dc0f3eb08 Auto-update documentation for master (#72064)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-04-06 17:19:12 -04:00
Uladzimir Havenchyk
fcde592db4 deps: upgrade markdown-it (#71984) 2026-04-06 23:59:54 +03:00
Uladzimir Havenchyk
05fd40e2fb deps: upgrade dompurify (#71986) 2026-04-06 23:35:06 +03:00
bryan
351e4be6c8 Bundle airgap public key in standard Metabase JAR (#72046) 2026-04-06 19:39:54 +00:00
bryan
3cba66ca73 Guard export-viz-click-behavior-link against nil link models (#72003) 2026-04-06 15:54:46 +00:00
John Swanson
85de150a57 Increase debounce delay to 500ms (#70083)
[UXW-3154: Increase debounce delay for search API calls](https://linear.app/metabase/issue/UXW-3154/increase-debounce-delay-for-search-api-calls)

The current delay (300ms) is a bit too short. Increasing it to 500ms
should still be a snappy UX but send fewer requests while the user is
typing.
2026-04-06 15:16:11 +00:00
Braden Shepherdson
d4821e78e3 [MBQL lib] Add user docs for :fields lists (#71444) 2026-04-06 14:02:19 +00:00
Uladzimir Havenchyk
b34aa1c692 chore: upgrade qs (#70785)
deps: upgrade qs
2026-04-06 14:49:53 +03:00
Uladzimir Havenchyk
27e2412d69 deps: upgrade jspdf (#71987) 2026-04-06 13:04:36 +03:00
Uladzimir Havenchyk
f414178f3f deps: upgrade diff (#71981) 2026-04-06 13:03:19 +03:00
Uladzimir Havenchyk
492c1f3ae6 deps: upgrade lodash and lodash-es (#71982) 2026-04-06 13:02:57 +03:00
Uladzimir Havenchyk
5489604670 chore: replace vulnerable underscore with a util (#70784)
* chore: replace vulnerable underscore with a util

* missed another function

* remove underscore
2026-04-06 12:56:55 +03:00
metamben
cdcf995f5f Use effective/base type info for casts if database-type is missing (#71771)
* Use effective/base type info for casts if database-type is missing

Closes #68065
Closes #71551
2026-04-06 09:52:19 +03:00
Romeo Van Snick
9db030e42c Fix flaky test in unreferenced entries (#71134)
* Fix flaky test

* Fix flaky test

* Fix flaky test

* Add reference for table too
2026-04-05 09:20:57 +02:00
Anderson
672bd07e35 Metabot AI Controls (#71387)
* Implement static UI for Usage controls page

* Added initial ai-controls tables

* Set sidenav menu items / Add placeholders for new pages

* Implement Metabot Customization page UI

* - Added metabot/permissions GET and PUT apis
- Added settings for metabot name/tone/icon

* Fixed migration ids

* fixup! bad merge

* Add :scope metadata to all Agent Loop tools and create metabase.metabot.scope namespace

- Create metabase.metabot.scope with *current-user-scope* (defaults to #{}),
  scope-matches? with hierarchical wildcard support, and unrestricted set
- Add :scope to all 38 Agent Loop tool-fns with specific action scopes
  (e.g. "agent:sql:create", "agent:viz:edit") — wildcards are grant-side only
- Propagate :scope through wrap-tools-with-state in tools.clj
- :capabilities remain unchanged (orthogonal data-permission gating)
- Add tests for scope-matches?, default scope, and stub

Done: tool-scope/phase-1-tool-scope-declarations

* Add scope-based authorization middleware for Agent Loop tools

- Filter tools by scope in get-tools-for-profile (profiles.clj)
- Check scope before tool invocation in wrap-tools-with-state (tools.clj),
  returning a generic denial message (scope details logged, not leaked)
- Bind *current-user-scope* to unrestricted in run-agent-loop (temporary
  until phase 4 wires real permission resolution)
- Add scope enforcement tests covering filtering, denial, wildcards,
  no-scope passthrough, and default empty scope behavior

Done: tool-scope/phase-2-authorization-middleware

* Gate profile system prompts by metabot permission types

- Add *current-user-metabot-permissions* dynamic var to scope.clj
- Bind all-yes permissions in run-agent-loop (temporary, phase 4 wires real resolution)
- Derive has_sql_generation, has_nql, has_query_tools, has_other_tools
  boolean flags from permissions and pass to Selmer template context
- Gate internal.selmer sections: critical constraints, verification protocol,
  query building steps, SQL construction, SQL anti-patterns, SQL examples,
  NLQ guidance, dashboard routing, and query-focused common scenarios
- General sections (identity, context grounding, communication style, search
  example, entity linking) remain ungated for all permission levels
- 7 tests, 43 assertions covering all permission combinations

Done: tool-scope/phase-3-profile-prompt-gating

* Wire user-metabot-perms->scopes to metabot_permissions data model

- Implement resolve-user-permissions: looks up user's groups, queries
  MetabotPermissions, resolves most-permissive value across groups
- Implement real user-metabot-perms->scopes: maps :yes permissions to
  wildcard scope sets, always includes always-granted-scopes
- Replace temporary unrestricted/all-yes bindings in run-agent-loop with
  real permission resolution from api/*current-user-id*
- Superusers get scope/unrestricted and all-yes-permissions
- Permission resolution done once at reify construction, not per-reduce
- Agent API scope binding deferred (tracked in rdm task agent-api-scope-binding)
- 38 new test assertions covering permission→scope mapping, single-group,
  multi-group most-permissive-wins, and default scenarios

Done: tool-scope/phase-4-permissions-to-scopes

* Update permissions expected request format

* Include metabot and semantic-search tool options on the backend

* Connect access controls UI to the backend

* Wire up the backend for the Metabot Customize page

* Polish access controls page / Create MetabotSystemPromptsPage

* Added metabot-system-prompt

* Connect System prompt page to the backend

* Remove model selection + clean up

* Use custom metabot name

* Use metabot-icon in the UI + added metabot-show-illustrations toggle

* Removed metabase custom prompt

* Add defscope macro, scope registry, and api-scope module

Introduce a `defscope` macro that registers scopes with translatable
descriptions in a global registry, replacing inline scope strings across
all tool and endpoint metadata with typed var references.

Key changes:
- New `metabase.api-scope.core` module with defscope, scope registry,
  scope-matches?, and public API (all-scopes, scope-description)
- All 25 agent scopes declared via defscope in metabase.metabot.scope
- 3 EE workspace scopes declared in metabase-enterprise.workspaces.scope
- validate-tool-var! rejects tools with unregistered scopes at startup
- defendpoint accepts var references for :scope metadata (not just strings)
- enforce-scope logs dev-time warnings for unregistered endpoint scopes
- MCP scope enforcement now handled by defendpoint middleware (removed
  redundant pre-dispatch check); enforce-authentication preserves existing
  token-scopes on synthetic requests
- Scope enforcement error messages no longer leak required scope names
- Consolidated duplicate scope-matching logic in mcp/tools.clj

Done: tool-scope/phase-5-defscope-registry

* Make semantic_queries optional in search tool schemas

When semantic search is not enabled, the feature gate strips
semantic_queries from the tool definition sent to the LLM, but Malli
validation still required it — causing an "Invalid input" error.

* Add missing agent:query scope declaration

The agent API query endpoint requires "agent:query" but it was never
registered via defscope, only its sub-scopes were.

* Block agent profiles by permission and add prompt gating to slackbot

Add profile-level permission checks in run-agent-loop that throw 403
when users lack required permissions for specialized profiles (:sql,
:nlq, :transforms_codegen, :document-generate-content). Add explicit
denial messages to internal.selmer and slackbot.selmer templates when
features are disabled, directing users toward available capabilities
like search instead.

* Enforce per-group metabot on/off switch and remove semantic-search permission

Add base permission/metabot check in check-metabot-access! that blocks
all agent profiles when the group-level metabot permission is :no.
Remove permission/metabot-semantic-search from the permissions model
and frontend. Fix permissions API test request body format and update
all-perm-types to match current permission set.

Done: task/enforce-metabot-group-onoff

* Integrate custom system prompts into internal, SQL, and NLQ profiles

Read the metabot-system-prompt admin setting in build-system-message-content
and pass it as a custom_instructions Selmer variable. Add {% if %} blocks
at the end of internal, sql-querying-only, and natural-language-querying-only
templates to render custom instructions when set. Use |safe filter to
avoid HTML-escaping admin-provided content.

Done: task/integrate-custom-system-prompts

* Added AI usage backend APIs and tables

* Add new system prompts pages

* Update the ai feature access page

* Update side nav for Usage controls menu item + Clean up

* Make the page headings margin top consistent

* Update Customization page / Remove metabot-tone

* Add default metabot permissions for magic user groups

Insert default metabot permission rows (all yes/medium) for the four
magic groups: Administrators, All Users, Data Analysts, and All Tenant
Users. Also fix missing remarks on group_id column in metabot_group_limit
table to pass migration linter.

* Add GET /api/metabot/permissions/user-permissions endpoint

Return the current user's resolved metabot permissions (most permissive
across all their groups). Superusers get all-yes permissions. Response
uses simplified key names without the permission/ namespace prefix.

Done: frontend-ai-permission-gating/phase-1-backend-user-permissions-endpoint

* Add useUserMetabotPermissions hook for granular AI permission checks

Add RTK Query endpoint for GET /api/metabot/permissions/user-permissions
and a useUserMetabotPermissions() hook that returns granular permission
booleans (canUseMetabot, canUseSqlGeneration, canUseNlq, canUseOtherTools)
combining the global metabot-enabled setting with per-user group permissions.

Done: frontend-ai-permission-gating/phase-2-frontend-permissions-hook

* Gate metabot UI entry points with granular user permissions

Replace useMetabotEnabledEmbeddingAware with useUserMetabotPermissions
in 6 primary metabot UI entry points: sidebar button (canUseMetabot),
AI exploration menu (canUseNlq), Fix SQL button and inline prompt
(canUseSqlGeneration), chart analysis and data studio buttons
(canUseMetabot). Update tests to mock the permissions API endpoint.

Done: frontend-ai-permission-gating/phase-3-gate-ui-entry-points

* Migrate remaining components from useMetabotEnabledEmbeddingAware to useUserMetabotPermissions

Replace useMetabotEnabledEmbeddingAware with useUserMetabotPermissions
in all remaining metabot UI components: Metabot shell, MetabotQueryBuilder
(canUseNlq), MetabotQuickLinks, AppBarLarge, CodeMirrorEditor
(canUseSqlGeneration), query builder context registration, MetabotEmbed,
and CommandSuggestion. Add permissions API mock to shared test utils and
all affected test files. SelectEmbedExperienceStep intentionally kept on
the old hook (uses forceEmbedding for embedding feature config check).

Done: frontend-ai-permission-gating/phase-4-migrate-remaining-embedding-aware-uses

* Remove usage limits menu item

* Fix migration to work with mysql

* Fix clj-kondo warnings on feat/ai-controls branch

- Add api-scope to mcp module and users to metabot module allowed deps
- Add response schema to /user-permissions defendpoint
- Suppress aliased-namespace-symbol warnings on potemkin import-vars
- Remove unused make-tool-var helper and prefix unused bindings with _
- Rename make-tool-var to make-tool-var! (uses alter-meta!)

* Address code review findings from clojure-review

- Add response schemas to GET / and PUT / permissions endpoints
- Add ^:parallel to 22 pure tests across 3 test files
- Move check-metabot-access! guard out of let binding for clarity
- Fix indentation, alignment, :refer :all, and stale kondo ignores

* Route agent API scope references through metabase.metabot.core

Re-export scope vars from metabase.metabot.core so external modules
use the public API namespace instead of metabot.scope directly.

* Address PR review comments

- Fix indent in api-scope module config
- Re-export workspace scopes from workspaces.core instead of using
  workspaces.scope directly in agent_api/workspace.clj
- Extract wrap-with-scope-check into its own function in tools.clj
- Fix comment indentation in core_test.clj

* Tighten user-permissions response schema with exact permission fields

Use keyword keys and enum values matching the defined permission types
instead of loose [:map-of :string :string]. Also fix simplify-permissions
to produce keyword keys/values instead of strings.

* Separate foreign keys and indexes into distinct migration steps

Extract inline foreign key constraints from createTable into their own
changesets so FKs can be dropped independently of indexes/unique
constraints. Affects metabot_permissions, metabot_instance_limit, and
metabot_group_limit tables.

* Add api-scope to driver-affecting-overrides

api-scope is a simple scope-registry utility that only depends on util.
It was triggering driver tests via its enterprise/workspaces dependent.

* Fix CI failures from AI controls + master merge

- Add MetabotPermissions/GroupLimit/InstanceLimit to copy entities
- Fix module config: sort api-scope, remove extraneous APIs/uses,
  add PermissionsGroup to metabot model-imports
- Fix MCP scope-matches? returning false instead of nil on non-match
- Remove :capabilities gate from autogen dashboard tool
- Bind scope to unrestricted in profiles capability tests
- Update prompt gating tests to match master's template wording
- Update prompts test to match metabot_name template variable
- Update scope resolution tests for migration defaults (yes/medium)

* Remove usage limit code from AI controls branch

Usage limits (instance, tenant, and group) are being developed on a
separate branch. Remove all related backend code: models, API endpoints,
settings, migrations, and tests.

Done: ai-controls-to-enterprise/phase-1-remove-usage-limits

* Fix copy entities: deduplicate MetabotPrompt, move AI models to core section

* Move permission resolution and MetabotPermissions model to enterprise

Introduce the :ai-controls premium feature flag and restructure metabot
permission resolution for the OSS/EE split:

- Register enable-ai-controls? in premium_features/settings.clj
- Convert resolve-user-permissions to defenterprise (OSS returns defaults)
- Create EE implementation with full DB-backed group resolution
- Move MetabotPermissions Toucan2 model registration to EE namespace
- Keep pure permission type definitions and defaults in OSS
- Split tests: OSS verifies defaults, EE verifies group-based resolution

Done: ai-controls-to-enterprise/phase-2-defenterprise-permission-resolution

* Move permission admin APIs to enterprise with input validation

Move GET/PUT /api/metabot/permissions admin endpoints to
/api/ee/ai-controls/permissions, gated by :ai-controls feature.
Keep user-permissions endpoint in OSS. Add schema validation on
PUT perm_type/perm_value fields, fix 402 feature-gate test to use
correct assertion pattern, and add ^:parallel to all test defs.

* Move AI controls pages into new plugin

* Remove unused permission/metabot-model (model size) feature

The metabot-model permission (large/medium/small) was defined
speculatively but never wired into model selection and had no UI.
Remove it from permission definitions, defaults, API schemas,
migration seed data, frontend types, and all tests.

Done: ai-controls-to-enterprise/phase-4-move-model-loading

* Gate metabot customization settings behind :ai-controls feature

Add :feature :ai-controls to branding settings (metabot-name,
metabot-icon, metabot-show-illustrations) and system prompt settings
(metabot-chat-system-prompt, metabot-nlq-system-prompt,
metabot-sql-system-prompt). Without the feature, reads return defaults
and writes are rejected.

Done: ai-controls-to-enterprise/phase-5-move-customization-settings

* Refactor MetabotPermissions: move model to OSS, replace deprecated APIs

- Move Toucan2 model registration from enterprise to
  metabase.metabot.models.metabot-permissions (OSS)
- Replace mdb/update-or-insert! with t2/exists?+update!/insert!
- Replace user/group-ids with a subquery join through
  PermissionsGroupMembership
- Update model resolution to point to OSS namespace

* Move MetabotPermissions model to EE, fix test failures for ai-controls feature

- Move MetabotPermissions Toucan2 model registration from OSS to
  enterprise (metabase-enterprise.metabot.models.metabot-permissions)
- Move permission defs (metabot-permissions, perm-types, perm-type-defaults)
  into metabase.metabot.scope alongside related permission/scope code
- Add :ai-controls to snowplow stats ping and session token features test
- Add MetabotPermissions to serialization excluded-models and entity-id
  not-exported lists
- Update serialization baseline with new metabot settings
- Fix modules config: add api routes, model imports/exports for
  enterprise/metabot; remove stale users dep from metabot module

* Fix kondo warnings in settings_test: use true?, remove ^:parallel

* Address clojure-review findings: per-type perm validation, privacy, metadata

- Validate perm_value per perm_type in PUT endpoint (not just flat enum)
- Make format-native-query private
- Add ^{:added "0.61.0"} to enable-ai-controls?
- Add clarifying comment on enforce-scope dev-time warning

* Cleaned up ai_controls migrations

* Fix CI test failures caused by ai-controls permission system

The new check-metabot-access! gate in run-agent-loop rejects
non-superusers whose permissions default to :no. Honor pre-bound
*current-user-metabot-permissions* so tests can bind permissions
directly. Also fix scope error message expectation, gate custom
prompt settings behind :ai-controls feature, increase poll timeout
for closing-connection test, and split large deftests into smaller
parallel tests.

* Move EE-dependent permissions test to enterprise, ignore metabot_permissions in H2 dump comparison

The user-permissions test that creates :model/MetabotPermissions belongs
in EE tests since the model is EE-only. The metabot_permissions table is
created by migration in all editions but only included in H2 dumps when
EE is available, so add it to the ignored tables in the dump comparison
utility.

* Fix FE test failures by mocking metabot user-permissions endpoint

The new useUserMetabotPermissions hook calls /api/metabot/permissions/user-permissions
in many component trees. Tests that render these components were failing due to
unmocked API calls. Added setupUserMetabotPermissionsEndpoint helper and called it
in each affected test's setup.

* Mark update-permissions-test as non-parallel to fix MariaDB CI failures

* Fix prettier formatting in use-user-metabot-permissions test

* Fix TypeScript errors: missing settings defaults, stale token feature refs, type mismatches

* Fix eslint: remove unused createMockTokenFeatures imports, fix import ordering

* Add unit tests

* Fix metabot/new quicklink / don't call user-permissions if metabot is globally disabled

* Remove test flakiness

* Address PR review comments: remove scope re-exports, use enums, split tests

- Remove potemkin re-exports from metabot.scope; consumers now use
  api-scope directly for scope-matches?, unrestricted, registered-scope?,
  all-scopes, and scope-description
- Use proper malli enums for perm_type/perm_value in EE permissions
  response schema instead of bare :keyword
- Sort required-feature->message alphabetically in EE routes
- Fix api-scope indent in kondo config
- Delete unused keep-me comment in EE metabot routes
- Split large deftests into focused tests in permissions_test,
  scope_resolution_test, and profiles_test
- Remove unnecessary blank lines between testing blocks in api_test

* Fix kondo warnings: sort namespace requires alphabetically

* Fix namespace require ordering in agent core

* Add e2e tests for basic ai controls

* Fix e2e tests

* Fix issues with auto-saving and debounced requests

* Address further review comments

* Fix some tests

* Fix flaky MetabotFeatureAccessPage test by awaiting permission state

* Fix nql→nlq typo in permission type and OSS default permissions

The permission type `permission/metabot-nql` was misspelled throughout
the codebase (should be `nlq` for Natural Language Query). Also fixed
the prompt file reference `nql_search.md` → `nlq_search.md` which was
a runtime bug, and updated the OSS fallback for resolve-user-permissions
to return all-yes (permissive) instead of all-no defaults.

* Move DB query helpers from permissions API into MetabotPermissions model

Move permissions-for-group and all-permissions from the API namespace
into the model namespace where they belong as data-access functions.

* Fix flaky resolve-user-permissions-nil-test

Return all-yes-permissions for nil user-id in both OSS and EE paths
(no user means no restrictions). Wrap test with with-premium-features
to make it deterministic regardless of token presence.

---------

Co-authored-by: Nathan Voxland <nathan@metabase.com>
Co-authored-by: Edward Paget <edpaget@users.noreply.github.com>
Co-authored-by: Edward Paget <ed.paget@gmail.com>
2026-04-03 16:42:29 -07:00
Alex Yarosh
c05bc7d17b docs: stacked series and sticky columns (#71952)
* v60 viz improvements

* Optimized 4 images, saved 715.3 KB (43.9% smaller)

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Update docs/questions/visualizations/line-bar-and-area-charts.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-04-03 22:19:50 +00:00
github-automation-metabase
eb3ef366ad Auto-update documentation for master (#72004)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-04-03 21:16:12 +00:00
Edward Paget
d1d42b9a22 Fix missing :lib/uuid in join metric projection tests (#72000)
The two tests added in #71741 were missing required :lib/uuid keys
in their projection maps, causing API schema validation failures.
2026-04-03 20:03:00 +00:00
John Swanson
c49a43c8fe support expr with multiple instances of same metric (#71930)
support expr with multiple instances of same metric
2026-04-03 09:57:23 -08:00
John Swanson
1f90a2172f Fix metric explorer for metrics with joins (#71741) 2026-04-03 09:56:45 -08:00
Nemanja Glumac
cad0841958 Fix Trivy sarif failing to upload (#71994) 2026-04-03 17:02:22 +00:00
Nemanja Glumac
69fad10cda Fix unsafe inline expression interpolation in CI workflows (#71991)
* fix: extract 20 unsafe expressions from run blocks to env vars

Move ${{ }} expressions used in shell `run:` blocks into step-level
`env:` mappings to prevent script injection. Affected workflows:
athena, drivers, e2e-stress-test, frontend-unit-test-stress-test,
perf-test, pr-env, pr-env-destroy, release-embedding-sdk, repro-bot,
tag-for-release.

This is part 2 of a split from #71610 as requested.

* fix: use C-style for loop for burn_in variable expansion

Bash brace expansion ({1..N}) happens before variable expansion, so
{1..$VAR} doesn't expand as a range. Use a C-style for loop instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: extract inline PGPASSWORD secret to env var

The PR_ENV_DB_PASSWORD was left inline in run blocks while other
secrets in the same steps were already extracted to env mappings.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: rename REF_NAME env var to IS_MASTER_OR_RELEASE in drivers.yml

The variable holds a boolean expression result, not a ref name. The
new name matches the CLI flag it's passed to (--is-master-or-release).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: extract remaining inline workflow_dispatch inputs to env vars

Extracts spec, grep, burn_in, version, and issue_number inputs that
were still interpolated directly in run blocks. Also simplifies env
var names by dropping the redundant INPUT_ prefix.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* style: place env block before run block in athena.yml

Consistent with the convention used in all other steps.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Chris Nyhuis <cnyhuis@vigilantnow.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-03 18:35:30 +02:00
Mahatthana (Kelvin) Nomsawadi
e82a4d027c Add token renewal mechanism for guest embeds (#71075)
* An empty commit for the integration branch

* Extract JWT utilities into dedicated lib/jwt.ts module (#71515)

* Extract JWT utilities into dedicated lib/jwt.ts module

Moves `isJWT`, `decodeJwt`, `extractResourceIdFromJwtToken`, and `redactJwt`
from `lib/utils.ts` into a new `lib/jwt.ts`. Improves JWT decoding with safer
UTF-8 handling via `TextDecoder`. Updates all import sites.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Rename utils.unit.spec.ts to jwt.unit.spec.ts after moving extractResourceIdFromJwtToken

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Remove redactJwt and show full error strings in JWT error messages

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix AI slop

* Fix unit test

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix SdkError too wide (#71569)

* Extract JWT utilities into dedicated lib/jwt.ts module

Moves `isJWT`, `decodeJwt`, `extractResourceIdFromJwtToken`, and `redactJwt`
from `lib/utils.ts` into a new `lib/jwt.ts`. Improves JWT decoding with safer
UTF-8 handling via `TextDecoder`. Updates all import sites.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Rename utils.unit.spec.ts to jwt.unit.spec.ts after moving extractResourceIdFromJwtToken

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Remove redactJwt and show full error strings in JWT error messages

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix AI slop

* Fix unit test

* Add Storybook stories for SdkError component

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix mage error

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

* Add token renewal infrastructure for guest embeds (#71516)

* Add token renewal infrastructure for guest embeds

Implements the full token renewal mechanism across three layers:

- embed.ts: adds _callGuestTokenProvider(), _fetchInitialGuestToken(), and
  _refreshGuestToken() to MetabaseEmbedElement; fetches tokens from
  guestEmbedProviderUri and serves refresh requests via postMessage

- request-session-token.ts + Redux store (auth.ts, guest-embed.ts): SDK-side
  postMessage protocol for requestGuestTokenRefresh / submitRefreshedGuestToken;
  getOrRefreshGuestSession thunk checks JWT expiry and refreshes transparently

- Plugin hooks (api.ts, embedding-sdk.ts, api.js, override-requests-for-embeds):
  wires refresh handler into the API request pipeline; adds x-metabase-guest-embed
  header and :entityIdentifier URL substitution

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* clean up AI slop

* Fix another AI slop

* Fix more slop

* fix embed wizard parameter not affecting the preview for 1 render

* Fix string custom-context not working

* Address review feedback

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

* Wire token renewal into dashboard/question components and add E2E tests (#71517)

* Wire token renewal into dashboard/question components and add E2E tests

- SdkDashboard and SdkQuestionProvider now dispatch setInitialGuestToken on
  mount, storing the raw JWT in Redux so the request interceptor can refresh it
  transparently when it expires
- use-load-question and use-common-dashboard-params updated for guest embed mode
- SdkIframeEmbedRoute: new route component for the iframe embed SDK
- guest-token-refresh.cy.spec.ts: comprehensive E2E Cypress suite covering
  token expiry, automatic refresh, error paths for both iframe and SDK modes

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix _fetchInitialGuestToken to omit dashboardId/questionId from settings

In the guest embed token flow the JWT already encodes the resource, so
dashboardId and questionId should not be forwarded to the iframe via
setSettings. Pass them as undefined to override the values that
_updateSettings merges in from this.properties.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix Kelvin slop

* Make E2E tests consistent

* Make test more complete

* add custom context assertions

* address review feedback

* Address review

* Fix failed E2E tests

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix that one test that's always failing

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-03 16:00:46 +01:00
Mahatthana (Kelvin) Nomsawadi
7f785d6c98 Fix flaky metrics-editing.cy.spec.js test (#71983)
Fix that one test that's always failing
2026-04-03 15:08:36 +01:00
Timofey Kachalov
207548a864 Handle multi-touch events to improve pinch-to-zoom functionality on mobile devices for visualizations (#71932) 2026-04-03 15:52:44 +04:00
Sébastien
2a7c8331be fix(sdk-bundle): <metabase-question/> in guest embed no longer calls pulseform input (#71885) 2026-04-03 11:17:04 +02:00
dagecko
c27db353ba fix: pin 87 unpinned actions to full commit SHAs (#71913)
Pin all third-party GitHub Actions to immutable 40-character commit
SHAs to prevent supply chain attacks via tag rewriting. Version
comments added for readability.
2026-04-03 10:47:55 +02:00
Timofey Kachalov
63d5eb845a fix(sdk,embed-js): Adjust disabled state opacity for EditableText component (#71836) 2026-04-03 12:44:34 +04:00
Eric Normand
cbc40606ef Block database routing when transforms already exist (#71931)
Prevent enabling database routing on a database that already has transforms, since running transforms on databases with DB routing is not supported
Backend: added validation check in PUT /api/ee/database-routing/router-database/:id that returns 400 if transforms exist for the database
Frontend: disables the routing toggle in the UI when transforms exist, with a descriptive message
Also wired through the existing but unused database-id filter param in the transforms list API
2026-04-03 00:07:14 +00:00
github-automation-metabase
a7ca6bbca8 Auto-update documentation for master (#71949)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-04-02 18:06:12 -04:00
Alex Yarosh
a63333ac04 docs: metrics (#71778)
* first draft

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* viewer

* metrics edits

* metrics explorer

* data studio

* Update docs/data-modeling/metrics.md

* typo

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* edits

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-04-02 22:04:37 +00:00
John Swanson
93db322a84 Hide dimensions and filters without access in the metric explorer (#71692) 2026-04-02 13:50:36 -08:00
Alexander Polyankin
940c3e343f fix escape logic in serdes (#71940)
* fix escape logic in serdes

* fix

* fixes
2026-04-02 21:11:30 +00:00
Edward Paget
9f5aaf4a81 Add GitHub Action to auto-resolve backport conflicts with Claude (#71158)
* Add GitHub Action to auto-resolve backport conflicts with Claude

Adds a new workflow triggered by the `auto-resolve-conflicts` label (or
manual dispatch) that uses Claude Code to automatically resolve cherry-pick
conflicts on backport PRs. This eliminates the manual step of checking out
the branch, running backport.sh, and hand-resolving conflicts.

* Add kondo and typescript checks

* Add syntax validation and formatting to backport conflict resolver

- Prepare backend (JDK/Clojure) and frontend (Node/Bun) environments
- Run cljfmt and eslint --fix to auto-format resolved files
- Run clj-kondo and tsc to validate syntax before completing cherry-pick
- Claude loops on errors until files are clean before committing

* Make Claude max turns configurable in backport conflict resolver, default to 50

* Fix Bash permission pattern for cljfmt in backport conflict resolver

Use colon-star syntax (cljfmt:*) to match other Bash tool permission
patterns, fixing permission denial for ./bin/mage cljfmt-files.

* Detect yarn vs bun for older release branches in backport resolver

Release branches ≤58 use yarn, ≥59 use bun. Detect the package manager
by checking for bun.lock after checkout, then use it for the CLJS build
step, allowed_tools permissions, and Claude prompt instructions.

* Set NODE_VERSION=22 for claude-code-base-action step

The action internally runs setup-node with 18.x by default, overriding
the Node 22 installed by prepare-frontend. This caused yarn engine
check failures on older release branches. The action respects a
NODE_VERSION env var, so set it to 22.

* Improve backport resolver: detect max turns, add commit details to success message

- Bump default max turns from 50 to 75
- Detect when Claude exits due to max_turns exceeded and post a specific
  comment explaining the issue with a link to re-run the workflow
- Include a commit link and collapsible changed files list in the success comment
2026-04-02 13:45:21 -07:00
Oreon Lothamer
0eef3193ce Use assume role for AWS credentials in workflows (#71608) 2026-04-02 22:15:16 +02:00
Jeff Bruemmer
6dbb28bb3e docs - Fix formatting of Agent API link in documentation (#71941)
Fix formatting of Agent API link in documentation
2026-04-02 19:23:35 +00:00
Jeff Bruemmer
7034d54542 docs - upload edits (#71684) 2026-04-02 14:49:10 -04:00
Riley Thompson
bdda38ff17 Reject multi statement queries (#71573)
* reject multi statement queries

* add dialect

* update pr

* use multimethod

* mark driver tests

* remove join for clickhouse

* kebab case

* fix e2e test
2026-04-02 18:24:02 +00:00
Aleksandr Lesnenko
293b99e321 fix unnecessary data grid row remounting (#71877)
* fix unnecessary data grid row remounting

* spec
2026-04-02 18:21:26 +00:00
John Swanson
1c26f9d31c Fix document visibility in trash (#71903) 2026-04-02 09:17:25 -08:00
Phoomparin Mano
71b8317b65 Add MCP apps CORS settings page and settings (#71763)
* feat: add MCP apps CORS settings page at /admin/metabot/mcp

Add a new settings page where admins can enable CORS for popular MCP
app clients (Claude, ChatGPT, Cursor/VS Code) via checkboxes, and
add custom domains for self-hosted clients like LibreChat.

Backend: new `common-mcp-apps-cors-origins` (CSV) and
`custom-mcp-apps-cors-origins` (string) settings in mcp/settings.clj.
Security middleware merges these with embedding SDK origins in
`access-control-headers`. Special handling for vscode-webview:// prefix.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address design review — use toggles, fix casing, remove sublines

- Switch from Checkbox to Switch toggles for MCP client selection
- "MCP Apps" → "MCP apps" in sidebar and page title
- Remove redundant description sublines from client options

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor: extract MCP CORS tests to separate security_mcp_test file

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* add unit tests for mcp apps

* rename: common-mcp-apps-cors-origins → mcp-apps-cors-enabled-clients

The setting stores client keys (claude, vscode, chatgpt), not origins.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* rename: custom-mcp-apps-cors-origins → mcp-apps-cors-custom-origins

Consistent mcp-apps-cors- prefix for both settings.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: add mcp to driver-affecting-overrides

MCP settings are infrastructure, not driver logic.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* add cors origins parsing improvements from @crisptrutski

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

* move mcp-apps-sandbox-origin? from security middleware to mcp.settings

Encapsulates MCP sandbox origin logic in the mcp module, uses condp
for extensibility when more non-standard schemes are added.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* add oauth-server to mage modules list

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* add mcp.core as public API, keep mcp.settings internal

External consumers (e.g. security middleware) now go through mcp.core
instead of reaching into mcp.settings directly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* move application logic from mcp.settings to mcp.core

mcp.settings now only contains pure config (defsettings + cors-origins).
vscode-webview-enabled? and sandbox-origin? live in mcp.core.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* remove useEffect state sync from MCP apps settings

Local state is kept for optimistic UI updates, but the useEffect sync
from savedValue is unnecessary since these settings won't change from
an external source concurrently.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* rename "MCP app clients" to "MCP clients" in descriptions

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* rename "vscode" client key to "cursor-vscode"

Aligns the key with the label "Cursor and VS Code" across frontend,
backend domain mapping, and tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* expand test to toggle all MCP clients

Use findByLabelText instead of testIds, and verify each toggle
accumulates the enabled clients list correctly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* add init for mcp

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
2026-04-02 16:29:09 +00:00
Sébastien
f01f753ff2 fixed translation issue with funnels (#71810) 2026-04-02 17:45:16 +02:00
Timofey Kachalov
a6453de48d feat(sdk,embed-js): Add touch device support for collection name description icon (#71762) 2026-04-02 19:42:56 +04:00
Aleksandr Lesnenko
a3ccc35af6 hides overview tab of the metrics pages if no dimensions (#71675)
* hides overview tab of the metrics pages if no dimensions

* hide caching tab if no write access to metric

* update specs based on latest changes from master
2026-04-02 10:28:56 -04:00
Chris Truter
d07b1772b8 Move table_transform_target_fk migrations from v60 to v61 (#71717) 2026-04-02 16:14:49 +02:00
Phoomparin Mano
05ec8451c5 Move CORS settings to OSS and show Security tab in Embedding (#71648)
* move the cors settings to oss

* add quick test for cors on oss

* test: update security middleware tests for OSS CORS behaviour

Add a dedicated test verifying CORS headers are sent when origins are
configured even without embedding features enabled (OSS path).

Update existing cases to reflect that removing the :embedding-sdk
feature flag from embedding-app-origins-sdk means the getter now
returns the actual stored value in all contexts (previously returned ""
without the premium feature active in tests).

Remove 16 redundant test cases where sdk=true with non-empty origins
produced identical results to sdk=false with non-empty origins — now
that CORS is enabled whenever origins are configured, the sdk flag is
only meaningful when origins are empty.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* restore tests

* fix: remove redundant enable flags from CORS check and add OSS CORS test

The enable-embedding-sdk and enable-embedding-simple flags are no longer
needed to gate CORS headers — having configured origins is sufficient,
and localhost is always allowed via the existing passthrough. This
addresses PR review feedback to simplify the logic and add missing
frontend test coverage for CORS settings in OSS.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* test: update e2e tests for OSS/Starter CORS settings visibility

Security tab and CORS settings are now available on all plans,
not just EE. Update assertions to expect them to exist.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-02 14:05:52 +00:00
Chris Truter
6f850e24db Clean up workspace schema and user-name code (#71808)
* Clean up workspace schema and user-name code

1. Single source of truth for the prefix — "mb__isolation" is defined once in metabase.driver.util (private), not three places
2. Matching methods live next to the constant — workspace-isolated-schema? (in-memory) and workspace-isolated-schema-clause (HoneySQL) so callers don't need to know the prefix or construct patterns themselves
3. Removed the requiring-resolve hack in the redshift test
4. Removed duplicated name generation — enterprise workspaces/util had identical copies of isolation-namespace-name, isolation-user-name, and instance-uuid-slug; callers now use driver.u directly

Closes [GDGT-2157: redshift tests require enterprise alias](https://linear.app/metabase/issue/GDGT-2157/redshift-tests-require-enterprise-alias)

* Avoid dynamic string building

* Use escape characters since _ is a wildcard

* Tighten up a bit more

* Remove stale include
2026-04-02 08:17:52 -04:00
github-automation-metabase
c08d322874 Update translations 2026-04-01 (#71841)
* Update translation sources 2026-04-01

* Update translations

* skipping offending test

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Katya Voropaieva <110612633+KorowkaMu@users.noreply.github.com>
Co-authored-by: Sébastien <sebastien@metabase.com>
2026-04-02 11:48:13 +00:00
Chris Truter
33a9177696 Test to catch incorrect migration versions (#71743) 2026-04-02 11:12:44 +00:00
Stas Gavrylov
beed12ea36 GDGT-2089: Adjust viz settings sidebar styling (#71472)
* GDGT-2089: Adjust settings sidebar styling

* GDGT-2089: Fix PR comments. Adjust styling
2026-04-02 13:51:56 +03:00
Sébastien
23eaffd14a add new-native to mb-question doc (#71890) 2026-04-02 09:33:04 +00:00
Stas Gavrylov
96f8785d12 GDGT-2047: Add ability to proxy /api requests to remote server (#71090)
* Add ability to proxy /api requests to remote server

* Tighten security. Add tests

* Move proxy code to dev/. Add mention in docs
2026-04-02 11:48:20 +03:00
Nick Fitzpatrick
0642892b42 Adding Details tab to table section (#71722)
* Adding Details tab to table section

* e2e adjustments

* remove grow on tab list

* fix e2e tests
2026-04-02 12:42:57 +05:30
Timofey Kachalov
0336557161 feat(sdk,embed-js): Improve touch device support in dropdown components in Notebook Editor (#71562) 2026-04-02 11:12:47 +04:00
Timofey Kachalov
8c2ca60ccb Fix duplicated identifiers error (#71883)
Fix duplicated identifiers
2026-04-02 01:38:10 -04:00
Timofey Kachalov
a3340c17a6 feat(sdk,embed-js): Improve mobile range selection experience for visualizations (#71374) 2026-04-02 08:45:00 +04:00
Alexander Polyankin
bd82202177 Representations baseline (#71879)
* Omit UUIDs in SerDes MBQL 5 export unless required

* Test fixes 🔧

* Final test fixes 🔧

* cljfmt

* fixes

* fixes

* fx

* fixes

* es

* fix

---------

Co-authored-by: Cam Saul <github@camsaul.com>
2026-04-02 00:22:41 -04:00
Cam Saul
22a21845f1 Omit UUIDs in SerDes MBQL 5 export unless required (#71862)
* Omit UUIDs in SerDes MBQL 5 export unless required

* Test fixes 🔧

* Final test fixes 🔧

* cljfmt
2026-04-01 21:43:06 -04:00
metatyb
e75d0484e8 chore: add metatyb to team and github-slack-map (#71803) 2026-04-02 09:30:45 +08:00
Nemanja Glumac
43db728f71 Clean up two module violations in metabase api (#71786)
* Move DataSegregationStrategy type to metabase-types/api/permissions

This is a permissions concept, not an embedding one. Moving it to
metabase-types resolves a module boundary violation (basic/api importing
from shared/other) and breaks a circular dependency between metabase/api
and metabase/embedding/embedding-hub.


Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-02 00:39:48 +02:00
Nemanja Glumac
9537481bb2 Improve sync-fork workflow ergonomics (#71875) 2026-04-02 00:38:49 +02:00
Eric Normand
74a08a7a2d Fix usage_info IN clause exceeding 65K parameter limit (GHY-2413) (#71856)
- Fixes `GET /api/database/:id/usage_info` failing when a database has more than 65K tables
- The segment count query was passing all table IDs as parameters to an `IN` clause, which exceeds PostgreSQL's 65,535 parameter limit
- Replaced the `IN` clause with a subselect (`SELECT id FROM metabase_table WHERE db_id = ?`), eliminating the parameter explosion
- Removed the now-unnecessary `select-pks-set` call and `table-ids` argument from `database-usage-query`
2026-04-01 20:42:52 +00:00
Alex Yarosh
db1f2bbe75 Update description for logarithm value parameter (#71851) 2026-04-01 19:37:57 +00:00
Aleksandr Lesnenko
6d190f1f62 do not suggest city as a geo dimension for tabs with map viz (#71768)
* do not suggest city as a geo dimension for tabs with map viz

* update e2e spec
2026-04-01 19:32:56 +00:00
appleby
4ff8b2722e BOT-1223 Fix zero-arity tool call schemas for anthropic provider (#71618)
* BOT-1223 Fix zero-arity tool call schemas for anthropic provider

Anthropic is stricter than openrouter about schemas for tool calls with no arguments. A schema like `[:maybe :map]`
produces a JSON schema like `{"oneOf": [{"type": "object", ...}, {"type": "null"}]}` but Anthropic's API requires
input_schema to be `{"type": "object", ...}` at the top level. A oneOf with a null variant is invalid.

* Handle nil arguments in metabase.metabot.self.core/run-tool
2026-04-01 12:05:14 -07:00
Jeff Bruemmer
75befd8877 docs - links (#71853)
links

Frontload links to ref docs.
2026-04-01 14:04:00 -04:00
Filipe Silva
34a7791680 fix: accept metered transforms product types in cloud-add-ons endpoint (#71664) 2026-04-01 18:56:42 +01:00
Nemanja Glumac
6a72335427 Allow test quarantine in Metabase internal forks (#71837) 2026-04-01 19:15:37 +02:00
Nick Fitzpatrick
a86098bc57 Rename Data Structure to Tables (#71744) 2026-04-01 22:12:00 +05:30
Eric Normand
23410f5c24 Fix sync_schema silently dropping when executor is busy (GHY-3254) (#71756)
* Add failing test reproducing GHY-3254: sync_schema silently drops when executor is busy

The quick-task executor uses a single thread. If any task gets stuck
(e.g., a hanging JDBC connection), all subsequent manual sync requests
queue forever while the endpoint returns 200.

* Add per-task timeout to quick-task executor

Each task submitted to the quick-task executor now runs on a child
thread with a configurable timeout (*task-timeout-ms*, default 2h).
If a task exceeds the timeout, it is cancelled and the executor moves
on to the next queued task. This prevents a single stuck task from
blocking all subsequent manual sync requests.

The stuck thread's stack trace is logged for diagnostics.

* Use MB_QUICK_TASK_TIMEOUT_MINUTES env var for task timeout

Replace the dynamic var with a real env var (default 120 minutes).

* Use config/config-int for MB_QUICK_TASK_TIMEOUT_MINUTES

Read the env var via metabase.config.core instead of System/getenv,
consistent with how other config values are read in the codebase.
2026-04-01 11:39:44 -05:00
Timofey Kachalov
2aae5c688b feat(sdk,embed-js): Enhance getEventTarget to support TouchEvent for improved mobile compatibility when showing a drill popup (#71636) 2026-04-01 20:36:55 +04:00
Nick Fitzpatrick
6af2a17af7 Subtract scrollbar with from pivot table header when apropriate (#71654) 2026-04-01 21:39:41 +05:30
Nick Fitzpatrick
6c297776ee Skipping GridMapPdfExport loki test (#71833) 2026-04-01 21:38:01 +05:30
dpsutton
ee5d80d008 middleware to prevent middleware that hits app-db (#71775)
currently it is just two middleware: impersonation and db routing

this is necessary as we want to move into a world where we can compile a
query from yaml files without an app db file. These middleware are not
impportant for our purposes here.

This is also temporary work. This is slated to be fixed up in

[QUE2-488: Introduce an app-db protocol for QP
middleware](https://linear.app/metabase/issue/QUE2-488/introduce-an-app-db-protocol-for-qp-middleware)
2026-04-01 09:29:07 -05:00
Edward Paget
1038b9d7bd Remove metabot describe API, openai client, and unused deps (#71774)
The metabot describe endpoints (card and dashboard autodescription) are
no longer needed. This removes the API routes, task implementations,
OpenAI client wrapper, tests, and the now-unused openai-clojure and
lambdaisland/uri dependencies.
2026-04-01 08:46:13 -05:00
Nick Fitzpatrick
a4d498d247 add data image check to urlTransform (#71588)
* add data image check to urlTransform

* de-duplicate regex
2026-04-01 19:03:47 +05:30
Nick Fitzpatrick
3b4897a341 show error message on remote sync pull changes or branches error (#71668)
* show error message on remote sync pull changes or branches error

* test adjustments
2026-04-01 19:03:31 +05:30
Jeff Bruemmer
134065e95e docs - images and notes (#71773)
* images and notes

* Optimized 2 images, saved 118.8 KB (41.4% smaller)

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-04-01 13:01:48 +00:00
Nick Fitzpatrick
fdb8d17d50 Revert April Fools Joke (#71801)
* Add CI check

* Revert "Fix metabot padding (#71680)"

This reverts commit 5886b7b7c6.
2026-04-01 05:38:24 -06:00
Timofey Kachalov
efc354420f feat(SDK, EmbedJS): Add touch support for Popover targets to improve mobile usability (#71484) 2026-04-01 12:59:39 +04:00
Tyler Plude
878fc365a3 [BOT-1233] Fix get-table-details arg flag typos (#71679)
* fix get-table-details arg flags

* new unit test
2026-03-31 22:59:18 -07:00
Alexander Polyankin
9ada59a804 Serdes fixes for python transforms (#71735)
* fixes

* fixes
2026-03-31 21:43:55 -04:00
appleby
4544ff5e6b BOT-1221 Resolve metabase://transform links to new data-studio path (#71613) 2026-04-01 00:30:55 +00:00
appleby
734dba5964 BOT-1226 Only run metabot internal tasks when the llm-metabot-provider-lite is configured (#71667)
* BOT-1226 Only run metabot internal tasks when the llm-metabot-provider-lite is configured

The agent loop was already checking llm-metabot-internal-tasks-enabled? before running internal background tasks like
user intent classification. Switch the default value for llm-metabot-internal-tasks-enabled? from true to false and
update the :getter to check that the corresponding llm-metabot-provider-lite is configured.

* Review feedback: ensure llm-provider-configured? returns boolean
2026-03-31 23:10:11 +00:00
Cam Saul
b6a9236b1d Remove legacy MBQL conversion steps from SerDes (#71614)
* SerDes use MBQL 5 [WIP]

* Update serialization baselines

* Test fixes 🔧

* More test fixes 🔧

* Test fixes 🔧
2026-03-31 19:03:43 -04:00
github-automation-metabase
ef14caecf1 Auto-update documentation for master (#71781)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-03-31 18:27:33 -04:00
appleby
9080614933 BOT-1199 ORDERS table link points to an invalid path (#71543)
* BOT-1199 Add table-specific link examples to the internal metabot prompt

* Fix resolve-table-link to resolve to valid ad-hoc question link

The docstring mentioned avoiding a db lookup for the database id, but a link like `/table/<id>` is not a valid
metabase link.

* Cache metabase.metabot.agent.links/resolve-table-link result for 10 minutes

* Remove regex guard around parse-long in resolve-table-link

parse-long already returns nil if the parse fails.

* Fix require for application-database-metadata-provider

* Fix resolve-entity-link-test for tables and split it out into a new test
2026-03-31 15:17:02 -07:00
Cam Saul
da8bc93939 Fix driver-related code scanning alerts (#71666) 2026-03-31 18:00:30 -04:00
Oleksandr Solovyov
9c23e9d35a [metabot] add repr for measures and segments (#71656)
* [metabot] add repr for measures and segments

* Wire up measures and segments correctly

* Improve measures and segments representation

---------

Co-authored-by: Mihael Konjevic <konjevic@gmail.com>
2026-03-31 21:20:17 +00:00
Sloan Sparger
686087f2ec [Metabot] Fix Admin AI sidebar disappearing (#71597)
reorganize page components so sidebar does disappear while loading metabot settings pages
2026-03-31 20:36:42 +00:00
Tyler Plude
e0ba625be4 [BOT-1247] Fix empty string content blocks in anthropic API (#71765)
init
2026-03-31 12:57:49 -07:00
Nemanja Glumac
9038c23075 Run cross-version script only on the main repo (#71754) 2026-03-31 21:55:10 +02:00
Nemanja Glumac
2e28c3f930 Ask for explicit input to override fork changes (#71753) 2026-03-31 21:52:30 +02:00
Fraser
0f42846b53 Clean UI utils and component violations (#71465) 2026-04-01 08:47:17 +13:00
Fraser
afc7fdbeb6 Add subset of files to app-misc module and make schema a lib module (#71700) 2026-04-01 08:46:56 +13:00
Noah Moss
adc3c025c5 Let Metabot write a brief response after using autogen_dashboard (#71758)
remove final-response? from autogen dashboard tool to allow for a brief description
2026-03-31 15:33:51 -04:00
Ryan Laurie
5886b7b7c6 Fix metabot padding (#71680)
* avante garde monetization

* fetch market prices

* limited fun

* obey the linter
2026-03-31 12:50:00 -06:00
Sloan Sparger
aa84a83fba [Metabot] Remove metabot v3 token feature (#71600)
remove metabot v3 token feature
2026-03-31 18:21:13 +00:00
Sloan Sparger
6c14871bae [Slackbot] Make slackbot auth req messages in channel an ephemeral message (#71603)
make slackbot auth req messages in channel an ephemeral message
2026-03-31 12:55:08 -05:00
Edward Paget
9e576f007b Fix git sync to remove stale YAML files from managed export directories (#71739)
Exports are always full, so any .yaml file in a managed directory that isn't
in the current write set should be removed. This fixes stale files persisting
after entity renames, moves between collections, or deletions.

The git source now accepts a set of managed top-level directories. During
write-files!, existing files in managed dirs not in the write set are cleaned
up automatically. This replaces the previous path-prefix-based collection
scoping and the explicit build-all-removal-paths machinery, which couldn't
handle renames or cross-collection moves.
2026-03-31 12:48:56 -05:00
Sloan Sparger
400a33e4ef [Metabot] Hide embedded settings if embedding is not available (#71594)
hide embedded metabot settings if embedding is not available
2026-03-31 12:17:12 -05:00
Noah Moss
201824c6b2 Remove capability check for create-autogenerated-dashboard-tool; clarify system prompt (#71589)
* fix autogen_dashboard tool by removing capability checck, clarify system prompt around dashboards

* fix tests

* fix test
2026-03-31 13:13:30 -04:00
Edward Paget
fa31def1bc Fix support access grant password reset failing for deactivated users (#71598)
* Fix support access grant password reset failing for deactivated users

When a support user was deactivated (e.g. after a previous grant expired),
creating a new grant would leave the user inactive. The password reset
token authentication would succeed, the :after method would consume the
token and change the password, but create-session! would then reject the
login because is_active was false. with-fallback would swallow this and
fall back to emailed-secret-password-reset which also failed, resulting
in an opaque "Invalid reset token" error with the token irreversibly
consumed.

Fix: fetch-or-create-support-user! now reactivates deactivated users.

Also adds tests for the deactivated user flow, pre-existing auth identity
cascade, with-fallback error swallowing behavior, and direct login! calls
for easier debugging.

* fixup! cljfmt
2026-03-31 11:00:45 -05:00
Nicola Mometto
c134074716 Dedupe slack channels (#71653)
dedupe slack channels
2026-03-31 16:39:30 +01:00
lbrdnk
237c3fe056 Remove stale archived_message instructions (#71715) 2026-03-31 16:17:00 +02:00
Nick Fitzpatrick
01af8eb57f updating styling for Database Destination Connection Modal (#71586) 2026-03-31 19:38:54 +05:30
Edward Paget
e60356ffd7 Fix notification send test retry config key (:max-attempts → :max-retries) (#71689)
The test overrode :max-attempts but diehard uses :max-retries, so the
override was silently ignored and all 6 retries ran with exponential
backoff (~31s). With the correct key the test finishes in ~1s.

Done: task/fix-notification-retry-key
2026-03-31 14:08:49 +00:00
Kevin Kelleher
d825c4dab3 Metrics home page and viewer cleanup (#71514) 2026-03-31 13:41:56 +00:00
lbrdnk
bee5aa840a Native query context formatting (#71566)
* Extend the schema for context received in requests

* Fix native question context formatting

* Adjust context schema

* Tests

* test

* Tests

* extract dialect

* remarks
2026-03-31 15:12:05 +02:00
Kevin Kelleher
214f776ad4 Metrics explorer dimension picker and tab creation fixes (#71536) 2026-03-31 07:13:57 -04:00
Timofey Kachalov
a4c66d0626 Update permissions in embedding SDK tests to avoid permission errors in some cases (#71705) 2026-03-31 13:56:11 +04:00
Nemanja Glumac
cc7506cc6f Allow Metabase forks (including private ones) to sync automatically (#71663)
Add a new sync-fork workflow that automatically syncs metabase internal forks
with upstream metabase/metabase (master + 5 most recent release branches).
Force-syncs from upstream as source of truth, skips push when no diff to
avoid unnecessary CI runs. Only runs on forks, never on the public repo.

Guard all scheduled workflows with repository check so they only run on
schedule for metabase/metabase, not on forks (manual dispatch
still works on both).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-31 06:05:11 +00:00
Alexander Polyankin
8f62ee5f3a Serdes skip default values (#71544) 2026-03-31 03:42:08 +00:00
Fraser
f922a58520 Clean dead code (#71463) 2026-03-31 16:02:41 +13:00
metabase-bot[bot]
1179147e3d [chore] Update E2E test timings with recent data (#71621) 2026-03-31 14:03:04 +13:00
Fraser
b2a016926e Push shared redux actions down (#71130) 2026-03-31 13:53:24 +13:00
Maz Ameli
a9f7e0504a Change label for stacked series setting (#71541)
change label for stacked series setting
2026-03-30 23:01:28 +00:00
Edward Paget
4b032951ad Include lock name in cluster lock log and error messages (#71677) 2026-03-30 21:09:03 +00:00
Braden Shepherdson
43ab4ba9d3 [MBQL lib] Add API docs for returned-columns and other metadata (#71443)
Part of QUE2-366.
2026-03-30 21:03:49 +00:00
Nemanja Glumac
610ff28b80 Fix a collection picker flake in cross-version tests (#71599) 2026-03-30 21:26:39 +02:00
Alexander Polyankin
4bbdb37c66 Serdes file and folder human readable names (#71583) 2026-03-30 18:52:39 +00:00
Nick Fitzpatrick
b56c33b6be adjust styling on parameter placeholders (#71577) 2026-03-30 23:40:08 +05:30
Nick Fitzpatrick
a14c0b00b9 don't recompute sensible chart groupings while sidebar is mounted (#71563) 2026-03-30 23:39:46 +05:30
Eric Normand
94cdeffdab Fix field filter dropdowns for users without create-queries permission GHY-1605 (#71046)
## Summary

Field filter dropdowns on native query cards show as text inputs ("Enter some text") for users who have view-data permission but lack create-queries permission on the underlying table.

**Root cause:** Two issues combined to break this:

1. **Frontend couldn't determine dropdown type** — The frontend needs `has_field_values` from field metadata to decide whether to show a dropdown vs text input. This metadata came from `GET /api/database/:id`, which returns 403 for users without `create-queries` permission. Without it, the widget falls back to a text input.

2. **Backend param values endpoint was too restrictive** — Even if the frontend showed a dropdown, the card param values endpoint (`GET /api/card/:id/params/:key/values`) would fail because `search-values-from-field-id` does `api/read-check` on the Field (which requires `create-queries`), and the QP permission check also required `create-queries`.

**Fix:**

- **Hydrate `param_fields` on Card API response** (matching existing Dashboard pattern) — includes `has_field_values` so the frontend can show the correct widget type without needing `GET /api/database/:id`
- **Populate metadata store with `param_fields`** on card load in the query builder
- **Bind `*param-values-query*`** in card param values endpoints (like dashboards already do) so the QP only checks `view-data` permission
- **Skip `api/read-check` on Field** in `search-values-from-field-id` when `*param-values-query*` is true
2026-03-30 12:55:14 -05:00
da
480ef19d1f Document reverse tunneling for SSH connections (#71628)
Added section on reverse tunneling for SSH connections.
2026-03-30 15:54:09 +00:00
Sébastien
65d66d2887 No request to pulse if user canot manage subscriptions (#71575) 2026-03-30 15:36:05 +02:00
Mahatthana (Kelvin) Nomsawadi
a1c3983037 Fix flaky test (#71623)
Attempt to fix flake
2026-03-30 14:26:33 +01:00
Jeff Bruemmer
424541b425 docs - mcp and AI updates (#71601) 2026-03-30 09:04:43 -04:00
Fraser
cc486a476e Lift dashboard only visualizations (#71271)
* Extract Dashboard-only visualizations

  Moved 4 dashboard-only visualization types from visualizations/visualizations/ to dashboard/visualizations/:
  - Heading/ — imports dashboard context, selectors, parameter components
  - IFrameViz/ — imports dashboard selectors
  - LinkViz/ — imports dashboard selectors
  - DashCardPlaceholder.tsx — imports dashboard actions

  Created dashboard/visualizations/register.js — registers these 4 viz types separately from the main visualizations/register.js

  Updated app.js — calls both registerVisualizations() and registerDashboardVisualizations()

  Updated 3 external imports to use the new paths:
  - dashboard/actions/utils.ts — IFrameViz utils
  - parameters/utils/mapping-options.ts — IFrameViz utils
  - PublicOrEmbeddedDashboardView-card-filters.stories.tsx — Heading

  Fixed 1 relative import in DashCardPlaceholder.tsx to use absolute path for VisualizationProps type.

  Violation progression: 157 → 111 → 86 → 78

* List DashboardChartSettings up

* Fix test setup

* Register dashboared viz in embedding
2026-03-30 22:01:47 +13:00
Fraser
e9b56f49b5 Allow Enterprise module to import from feature modules (#71468) 2026-03-29 16:26:56 +13:00
Fraser
307b2906b7 Fix module stats upload script (#71385) 2026-03-29 16:26:43 +13:00
lbrdnk
b8d3ac0869 Adjust search schemas (#71572) 2026-03-27 16:13:42 -07:00
Alexander Polyankin
ad4dfb41b1 Fix typo in transform database validation messages (#71596) 2026-03-27 22:34:25 +00:00
github-automation-metabase
38e28e0ec3 Fix pagerDurty workflow edge case (#71574)
Fix PagerDuty alert broken by single quote in issue title

Use jq --arg to safely construct the JSON payload instead of
interpolating user-controlled data directly into a shell string.
This prevents shell syntax errors when issue titles contain single
quotes or other special characters.

Removes the now-unnecessary 'Setting title' step that only escaped
double-quotes but left single quotes unhandled.
2026-03-27 20:52:32 +01:00
Edward Paget
655a3f6ac7 Move agent API tests from enterprise to OSS (#71456) 2026-03-27 18:30:00 +00:00
Chris Truter
3c968befff Improve model encapsulation with serialization bypass (#71553) 2026-03-27 20:11:07 +02:00
Sloan Sparger
334ed1fe42 [Metabot] Hide metabot feedback buttons on non-hosted instances (#71539)
hide metabot feedback buttons on non-hosted instances
2026-03-27 12:53:02 -05:00
Sloan Sparger
8e79105b9b [Metabot] Temporary removal of analyze chart button on dashboard page (#71540)
temp removal of analyze chart button on dashboard page
2026-03-27 12:52:53 -05:00
Ryan Laurie
92cd3f6cbf Converts some tests to ts (#71520)
converts tests to ts
2026-03-27 11:23:51 -06:00
Noah Moss
7089932b89 Move slack connect tests over to oss + fix API routes (#71525)
* move slack connect tests over to oss and remove some references to the token

* remove EE routes, always use OSS

* simplify

* undo some of that simplification

* fix tests / lint

* Move one test back to EE since it tests slack-connect's interaction with SAML
2026-03-27 10:50:48 -04:00
Nicolò Pretto
c4a27f18d3 embedding-hub: preserve "Select data" state + reset next steps after changing data segregation strategy (#71368)
* move up the state to persist it across steps

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: reopen create tenants step when changing segregation strategy

When the user changes the data segregation strategy after already
creating tenants, the create tenants step now correctly reopens
instead of skipping to summary.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* address feedback

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-27 15:24:32 +01:00
Phoomparin Mano
811e4466b2 Update in-app JWT onboarding to use snippets instead of iframes (#70475)
* share the same snippets for onboarding flow

* use sdk-docs-snippets namespace

* sync snippets

* fix rspack config

* rspack config: use path

* rspack: simplify resolve aliases

* remove node_modules from react refresh

* add copy button

* cleanup codemirror styling

* future proof: allow importing tsx files as well

* fix eslint pattern

* chore: move eslint ignore

* test to simplify aliases

* add context to ttag strings

---------

Co-authored-by: Nicolò Pretto <info@npretto.com>
2026-03-27 15:24:18 +01:00
Jeff Bruemmer
48c41ec6c8 Docs metabot slack (#71526) 2026-03-27 10:02:47 -04:00
Oleksandr Solovyov
b93319ab57 metabot llm calls: tools are optional/maybe (#71555) 2026-03-27 13:25:04 +00:00
lbrdnk
31905eaba4 Add 60 to version-helpers.ts (#71480)
Update versionRequirements
2026-03-27 11:02:22 +01:00
Nicolò Pretto
a0a14a42d3 scroll to top on page change in admin settings (#71369)
* scroll to top on page change in admin settings

* make tests green

* switch to useRouter instead of hoc
2026-03-27 09:55:04 +01:00
lbrdnk
839784b50c Fix transform writing tools (#71100)
* Add needed capabilities

* Partly fix transforms-write ns

* Partial fix to python transforms

* Add tool prompts

* Cleanup native transforms

* Add parameter schema descriptions

* Python schemas adjustments

* Adjust tool prompts

* Cleanup

* Tests

* Add capabilities test

* tests

* cleanup

* cleanup

* mbql5 and tests

* tests

* tests

* tests

* feature sentinel

---------

Co-authored-by: Tyler Plude <tsplude@gmail.com>
2026-03-27 08:44:57 +01:00
Nemanja Glumac
e9bc4ac447 Notify Slack on cross-version test failures (#71491) 2026-03-27 08:16:10 +01:00
Chris Truter
7180c6ae4b Optimize transform target table backfill migrations (#71487)
Better safe than sorry, given recent problems with expensive migrations.
2026-03-27 06:49:07 +02:00
Nick Fitzpatrick
a57a1c0ab8 preserve navbar status in the url update at the end of handleQBInit (#71505) 2026-03-27 09:59:12 +05:30
Nick Fitzpatrick
bee30e6423 Uxw 3355 page titles not in sync with data studio tabs (#71401)
* Fixing page titles in Data Studio

* shuffling Library files around. Adding library page title to all library subpages
2026-03-27 09:50:52 +05:30
Nick Fitzpatrick
281aa0dc12 decrease font size in click behavior sidebar (#71519) 2026-03-27 09:48:40 +05:30
Nick Fitzpatrick
14bd0853f6 set line height to 'normal' for textareas (#71498) 2026-03-27 09:48:20 +05:30
Romeo Van Snick
8be374db14 Convert query builder redux store to ts (#71063)
* Convert query_builder reducers to js

* Convert query_builder selectors to ts

* Fix types

* Fix types

* Fix types

* Fix isResultDirty selector

* Fix selector

* Move selector tests to TS

* Move reducers-typed into reducers

* Fix types

* Fix types

* Fix object id parsing

* Fix more types

* Fix PKRowIndexmap types

* Make name for EDIT_SUMMARY consistent

* Fix hanging test
2026-03-27 13:59:05 +11:00
Alexander Polyankin
b7e1d1eff8 Serdes for cards, segments, measures, transforms - allow deserializing only with minimal required properties without computed ones (#71464) 2026-03-26 18:51:58 -04:00
github-automation-metabase
3dd4c46871 Auto-update documentation for master (#71533)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-03-26 18:49:20 -04:00
Noah Moss
e7ae8072ca Reorganization + consolidation of metabot system prompts (#71506)
* Reorganization + consolidation of metabot system prompts

* More reorganization

* More shared prompt files

* revert search changes included accidentally

* more organization

* Fix dialect resource paths in module drivers

Update llm-sql-dialect-resource defmethods to use correct metabot/prompts/dialects/ path.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* share personality prompt for nlq profile

* bump ci

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-03-26 17:27:26 -04:00
Riley Thompson
483f2086dd Bump databricks jdbc driver to 3.3.1 (#71513)
* bump databricks jdbc

* trigger ci
2026-03-26 21:17:38 +00:00
Edward Paget
cb9c042404 Fix MCP tool dispatch to pass query params correctly per Ring spec (#71502)
invoke-agent-api-with-params was encoding GET/DELETE query params into
the URI string, but defendpoint reads from :query-params (a parsed
map) on the Ring request. The synthetic request never passes through
wrap-params middleware, so query params in the URI were silently
ignored.

Fix by moving the method-based dispatch into deliver-agent-api-response:
POST params go to :body, GET/DELETE params go to :query-params.
Remove invoke-agent-api-with-params which is no longer needed.
2026-03-26 15:49:09 -05:00
Anderson
1b26236cf1 Do not show JWT shared secret as plaintext after it is saved (#71165)
* Handle JWT shared secret as write-only after initial generation (#UXW-3300)

- Thread generated token through wizard state so AddEndpointStep displays
  the plaintext key without re-reading it from session properties
- FormSecretKey now recognises the backend obfuscated format (**********XX)
  and renders an empty input with 'Already set' placeholder and a
  'Regenerate key' button, rather than showing the masked value

* Add unit tests for FormSecretKey obfuscated value handling (#UXW-3300)

- Tests covering no-value, plaintext, and obfuscated backend secret states
- Verifies 'Already set' placeholder and button labels are correct per state
- Verifies confirmation modal uses caller-supplied title/body
- Verifies token regeneration clears obfuscated value

* Fix prettier formatting in FormSecretKey.tsx

* Update the way we obfuscate the key and handle it on the frontend

* Add be test, improve alert

* Fix ts

* discard unnecessary changes

* Remove section that displayed the JWT secret in embedding set up

* Fix e2e test

* Show dedicated modal when generating new JWT shared key

* Fix unit test

* Fix e2e tests

* Fix latest UI changes

* Address review comments

* Add loading state to secret key modal and assert obfuscated key in E2E test

* Read jwt-shared-secret from /api/setting instead of session-properties / Revert unneeded obfuscated? implementation

* Fix tests

* Replace reads of session properties with api settings to simplify component logic
2026-03-26 16:34:54 -03:00
Chris Truter
14ff22021e Support non-datetime migration ids in tests (#71471)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-26 21:03:02 +02:00
Nick Fitzpatrick
55df67b632 Update Value normalization / collapsing in ChartSettingInputNumeric.tsx (#71440) 2026-03-27 00:14:41 +05:30
Edward Paget
53b678bcd6 Flatten root-level :or/:and/:multi into flat object schemas for MCP clients (#71494)
* Flatten root-level :or/:and/:multi into flat object schemas for MCP clients

Only the outermost composite schemas are flattened — nested anyOf/allOf
within properties are preserved since LLM clients handle them fine.

- :and → :merge then deref (flattens the [:map {:encode/...}] pattern)
- :or → :union with optional-keys, then deref (merges branches)
- :multi → same as :or, extracts schemas from dispatch triples

Also updates construct_query and query tool descriptions to explain
which fields are mutually exclusive (table_id vs metric_id vs
continuation_token).

* Refactor flatten-root-schema to worklist with cycle detection

Replace the recursive flatten-root-schema with a two-phase approach:
collect-root-maps walks the root composite tree using an iterative
worklist, then flatten-root-schema merges the collected leaves.

This eliminates stack recursion (:or/:multi no longer call
flatten-root-schema on children) and replaces the fuel counter with
a seen set that precisely detects deref cycles. On cycle detection,
emit an empty :map (-> {"type":"object"}) as a safe fallback.

The worklist also fixes :and wrapping :or — both layers now flatten
correctly since all composite nodes are expanded uniformly.

Adds tests for deeply nested composites, nested composites within
properties (preserved as anyOf/allOf), and :multi root flattening.
2026-03-26 17:48:52 +00:00
Cam Saul
6a15fee1c5 Test to prove #32068 is fixed 🔧 (#71382)
* Test to prove #32068 is fixed 🔧

* Whoops revert deliberate test breakage

* Simplify test
2026-03-26 16:43:44 +00:00
Nicolò Pretto
92c07ddea1 hide sample db from embedding onboarding picker (#71304)
* hide sample db from embedding onboarding picker

* simplify e2e

* let's see if ci is green

* remove useless line, this is always pg
2026-03-26 17:23:19 +01:00
Sébastien
3dd99b6494 Fixed flaky custom elements api <metabase-question> test (#71500) 2026-03-26 17:20:53 +01:00
Riley Thompson
edb5eaad63 Handle non-dates in sqlite date columns (#71492)
* fix sqlite non date handling

* kondo
2026-03-26 12:14:00 -04:00
Chris Truter
77afdaafc0 MCP further nits (#71478) 2026-03-26 16:08:18 +00:00
metamben
56f04b92ca Render |> as a single operator when formatting SQL (#71435)
Closes #70447
2026-03-26 16:06:37 +00:00
Braden Shepherdson
8020b65546 [MBQL lib] Add user docs for joins to lib.core (#71442)
Part of QUE2-366.
2026-03-26 16:06:19 +00:00
Sébastien
0cc35ac876 Sprinkled upsell gems in embed wizard (#71076) 2026-03-26 16:59:33 +01:00
Kevin Kelleher
617ca0f5f0 Fix boolean cartesian charts defaulting to timeseries axis (#71486) 2026-03-26 11:13:37 -04:00
John Swanson
607fb9ba58 Hide destination DBs from permissions (#71395)
* FE: do not show destination DBs in permissions editor

If you add a destination database, don't show it in the perms editor.

This was a temporary bug (disappears on refresh) BUT if you edit permissions
for the destination database then that is persisted, which is not great. I
will fix that in a separate PR.

* Don't add data permissions rows for destination DBs

- Exclude destination databases from the permissions graph

- Don't add permissions for destination DBs when creating a new group
2026-03-26 06:46:59 -08:00
Ngoc Khuat
74c8811981 Fix silent data loss when importing unparseable YAML files (#71421)
* Surface ingestion errors instead of silently skipping unparseable YAML files

The serdes ingestion layer was silently dropping YAML files that failed
to parse (introduced in #41887 as defensive coding for editor temp
files). This caused remote sync imports to silently lose entities when
YAML files were malformed or exceeded SnakeYAML's nesting depth limit,
with no error reported to the user.

Add `ingestion-errors` to the Ingestable protocol so the ingestion
layer collects parse failures and surfaces them through `load-metabase\!`.
When `continue-on-error` is false (default, used by remote sync), the
import fails immediately on ingestion errors. When true, errors are
collected and reported alongside load-phase errors.

The dotfile filter from #41567 is preserved — editor temp files are
still silently skipped before parsing is attempted.

Fixes #71257

* Rename ingestion-errors to ingest-errors, extract populate-cache\! helper, add e2e tests

- Rename protocol method to ingest-errors for consistency with ingest-list/ingest-one
- Extract populate-cache\! helper to DRY up duplicated cache-population logic
- Add e2e test for continue-on-error true/false with ingestion errors

* Add tests for ingest-errors on IngestableSnapshot and wrapper delegation

* Fix log/warnf misuse, tighten tests, remove stale comment

- log/warnf -> log/warn to prevent MissingFormatArgumentException
  when error messages contain % characters
- Add tests for ingest-errors ordering contract and multi-file corruption
- Tighten continue-on-error assertion to check exact error count
- Remove stale comment describing pre-fix behavior

* Include file names in ingestion error messages

Wrap parse/read exceptions with ex-info containing the file path,
so the error message shows which files failed, e.g.
"Failed to read 1 file(s) during ingestion: bad_card.yaml"
2026-03-26 23:29:58 +09:00
Oleksandr Solovyov
ce15b2d9f0 fix metabot sql tools incorrectly checked query type (#71428) 2026-03-26 14:06:13 +00:00
github-automation-metabase
e5db491df4 Auto-update documentation for master (#71454)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-03-26 09:54:44 -04:00
Chris Truter
fdffe7dc82 Add db fallback for renamed settings (#71470) 2026-03-26 15:42:32 +02:00
lbrdnk
3bd3bf5b6a Edit chart fix (#71424)
* Add edit_chart.md instructions

* Ensure ids of state elements are stringified

* Cleanup

* Test

* add test and do cleanup

* Review comments
2026-03-26 14:00:04 +01:00
Chris Truter
c940bb3935 Add FKs from transforms back to tables (#70617) 2026-03-26 13:40:22 +02:00
Timofey Kachalov
366c74c02e Support entityId for guest embedded questions (#71246) 2026-03-26 14:44:00 +04:00
Chris Truter
0303419907 Increase transform test timeout (#71453) 2026-03-26 12:26:05 +02:00
Sébastien
1511899a7e Implement proper column width measurement for custom font sizes (#71407) 2026-03-26 11:08:04 +01:00
lbrdnk
b1a2673e1a Inject context in user message (#71045)
* Add context injection to user message

* Remove context from internal template

* whitespace

* Adjust tests

* Apply suggestion from @appleby

Co-authored-by: appleby <86076+appleby@users.noreply.github.com>

* use lib

---------

Co-authored-by: appleby <86076+appleby@users.noreply.github.com>
2026-03-26 10:42:20 +01:00
Nicolò Pretto
7074e0236a fix frontmatter in add-tracing skill (#71438) 2026-03-26 09:38:16 +01:00
Nemanja Glumac
ddba65c368 Add E2E (questions) tests on top of the cross-version automation (#70190) 2026-03-26 09:13:57 +01:00
Edward Paget
d8bb291939 Inline malli refs and flatten root anyOf in MCP tool schemas (#71457)
* Inline malli refs and flatten root anyOf in MCP tool schemas

MCP clients (Claude API, OpenAI, Gemini, AWS Bedrock) reject or
mishandle $ref and top-level anyOf in tool input schemas. Fix by:

- Walking malli schemas with ::walk-refs and ::walk-schema-refs to
  replace all registered-schema refs with their dereferenced content
  before JSON Schema generation, so mjs/transform never emits $ref
- Flattening root-level anyOf into a merged object schema for
  construct_query (table vs metric request union)
- Expanding construct_query tool description to explain table vs
  metric query differences since the schema no longer structurally
  separates them

Removes all $ref/$defs sanitization code and the defs accumulator
atom that are no longer needed.

* Replace :or/:and with :merge at malli level to eliminate anyOf/allOf

Instead of post-processing JSON Schema to flatten anyOf/allOf, handle
it at the malli schema level: in inline-malli-refs, replace :and with
:merge (eliminates allOf from the encode-map pattern) and :or with
:merge after making all entries optional via mut/optional-keys
(eliminates anyOf, all properties become optional in the merged
output).

This produces clean flat {type: "object", properties: {...}} schemas
that all MCP clients can handle. The construct_query tool now has all
table and metric properties in a single flat schema with none
required, and the description explains which to use.

Removes flatten-any-of and clojure.set dependency.
2026-03-26 06:21:33 +00:00
Aleksandr Lesnenko
1132bfd402 New Metric Home page (#71055) 2026-03-26 03:05:51 +00:00
Maksym Yakubych
37f3a01838 [Metabot] Bring your own keys (#70714)
* move ee/llm into oss

* lots of file movement

* move slack connect to opensource

* ability to have enterprise-only tools

* move tests

* Fix stale metabot-v3 aliases, dangling module refs, disabled linting, broken test paths, and typo

* start using deprecated-name, more ns path fixes

* move llm transforms code to oss

* fix namespaces

* whitespace fix

* checkpoint: switch tools to use mu/defn or defenterprise directly

* compilation fix

* lint fixes

* move around some code to break drivers dependency

* fix tests

* fix tool calls

* sort routes

* fix openapi

* fix module config

* lint

* fix clj-kondo

* fix test

* fix token check tests

* cljfmt

* fix slack test

* maybe fix dashboard tests?

* cljfmt

* is this a fix for dashboard tests

* move metabot models to oss

* untangle module config after rebase

* fix module order

* cleanup

* add back ai service-related settings that are still used

* move some more code to more appropriate places

* more code movement

* better schema names

* clean up mu/defn function name formatting

* update module config

* remove unneeded ai service-related test

* fix module config again

* fix auth in tests by removing more ai service stuff

* enable native agent by default

* test transforms over normal function calls

* requires

* pass through metabot-id to tool calls instead of hardcoding embedded-metabot-id, to fix answer sources test

* fix wrap-tools-with-state calls

* try to fix failing field/dashboard tests by matching the code on master (might have been from a bad rebase)

* Revert "try to fix failing field/dashboard tests by matching the code on master (might have been from a bad rebase)"

This reverts commit cd5ec8b487.

* hard revert parameters.dashboard-test to the version on master after the latest rebase

* mark snippet tests as sequential to try to fix perms test issues, remove a couple stray metabot feature checks

* move entity analysis + sql fixing code to oss

* wrap dashboard tests with with-full-data-perms-for-all-users to isolate the failure

* move ai-entity-analysis and ai-sql-fixer under the metabot module

* fix module test

* remove now-unneeded ai feature falgs

* disable perms cache for these failing dashboard tests

* feat: self-hosted metabot provider settings

* test: patch is-hosted temporarily

* fix: grouping

* move files to the frontend/ folder

* move MetabotProviderSection into MetabotSetup to accomidate design changes

* make anthropic the only allowed provider, updat sonnet 4.6 as default model, small layout change to api key input

* remove PLUGIN_METABOT usage, remove purchase pages, consolidate new connections settings ui

* remove oss impl of sql gen on the FE

* remove MetabotSettingUpModal, add alert for slackbot requiring metabot be setup, remove PLUGIN_METABOT, PLUGIN_METABOT.isCloudManaged checks now check llm-metabot-configured? which breaks things for enterprise for now

* add mock Metabase provider

* fix build

* impl copy feedback

* type-fix

* clean up

* fix unit tests

* fix metabot e2e tests

* type fix

* more test fixes

* fix semantic search tests

* more test fix

* kondo fix

* more test fixes

* copy change

* more kondo fixes

* app db test failure fixes

* fix failing BE tests

* fix e2e tests

* more e2e failure fixes

* fix typo

* remove mocked out endpoint definition

* fix last failing e2e test

---------

Co-authored-by: Oleksandr Solovyov <o@solovyov.net>
Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Sloan Sparger <sloansparger@gmail.com>
2026-03-25 23:49:07 +00:00
Chris Truter
87dc660191 Minor improvements to MCP server (#71406)
* Fix token scope logic to match middleware

* Add :secure to CSRF and DRY up

* Add comment to magic number for clarity

* Clean up complex threading

* Don't clobber token-scopes

* Optimize and improve no user-id failure mode

* trim comment fluff

* Simplify and avoid double str call

* Use database time for revoke-token for robustness

* Use long for user-id actually

* Enable refresh token rotation

A stolen refresh token was reusable for its entire 30-day TTL with no
way to detect theft. The oidc-provider library supports rotation — on
each refresh grant the old token is revoked and a new one issued.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Sanitize brand-color on consent page to prevent CSS injection

The brand-color setting is interpolated via h/raw into a <style> block on
the consent page. A non-hex value could break out of the CSS rule.
Validate defensively at the rendering site rather than changing the setting
setter, to handle already-persisted invalid values gracefully.

* HMAC-bind consent params to CSRF token and sanitize error messages

Two security improvements to the OAuth server:

1. The authorization decision endpoint re-parsed OAuth parameters from
   the POST body without verifying they matched what the user saw on
   the consent page. A modified form could request broader scopes than
   shown. Now the authorize endpoint HMAC-signs the parsed params using
   the CSRF token as key, and the decision endpoint verifies the
   signature against the re-parsed params before proceeding.

2. Error catch blocks on /authorize, /authorize/decision, and /token
   returned raw exception messages that could leak internal details
   (client IDs, redirect URIs, expected vs actual values). Now returns
   generic RFC-compliant error descriptions and logs details server-side.

* Truncate long client name. Show client id

* Non-functional nits

* Clean up

* Align and extract helper

* DRY OCD

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-25 18:04:40 -04:00
Chris Truter
40691f70d8 Faster search index sync when loading snapshots (#71410) 2026-03-25 21:42:40 +00:00
Noah Moss
f4b0e5946b Consolidate metabot-enabled checks and add them to a number of endpoints (#71366)
* consolidate metabot-enabled checks and add them to a number of endpoints

* switch describe_tests to use mbql-query helper for cards

* Remove metabot.settings namespace import
2026-03-25 21:17:14 +00:00
Noah Moss
f3a2cfab7f Query pagination for MCP (#70971)
* Combined /v1/query endpoint with pagination and continuation tokens

- Add /v1/query that combines query construction and execution in one step
- Implement continuation_token-based pagination for large result sets
- Cap agent query rows at 200 per page; pagination stops at userland limits (2k/10k)
- Refactor construct-query into shared construct-query* helper
- Move agent-api dispatch behind defenterprise seam in EE MCP tools
- Add streaming JSON-RPC support for tool results in MCP layer
- Add json-string-escaping OutputStream for embedding streamed JSON in JSON-RPC
- Move /agent route out of naughty-routes into intentional top-level-routes
- Fix SSO test_setup to handle nil server port in CLI test runner

* Remove streaming JSON-RPC, buffer all tool responses in memory

Strip the streaming code path from the MCP layer so this branch
focuses purely on the query tool and pagination. Buffering ~120KB
for 200 rows is fine for the limits we enforce.

- Remove json-string-escaping OutputStream and streaming-tool-response
- Revert MCP api.clj to synchronous Ring form (no SSE streaming)
- Move StreamingResponse materialization into EE MCP tools layer
- Simplify invoke-agent-api to handle only plain map responses
- Remove streaming-specific tests (escaping, SSE streaming, error)

* a bunch of other changes to try get the rebased build working

* Roll back a bunch of fixes from the oss branch that don't need to be fixed here

* restore code accidentally lost via multiple rebases

* update modules + lint

* strip out dead ee code

* update tool  count test
2026-03-25 16:47:10 -04:00
Nathan Voxland
817eb1d787 Roll back transform perms (#71094) 2026-03-25 15:27:25 -05:00
Egor Grushin
8b5224136b Cypress bail (#71420)
* add bail feature to the e2e stress test flake workflow

* add bail feature to the e2e stress test flake workflow

* add bail feature to the e2e stress test flake workflow

* Update e2e/support/cypress.js

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

* renamed BAIL to FAIL_FAST, replace Cypress.env with Cypress.expose

---------

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
2026-03-25 20:11:22 +00:00
Braden Shepherdson
051c1a6b25 [Params] Always return [] for param /values requests (#71302)
Fixes #71164.

On the BE, always return an empty list rather than nil. Old models with `:id` different from `:field_ref` in their metadata could result in `{:values nil ...}` being returned, which breaks the schema and FE. See #71164 for full details.
2026-03-25 20:11:07 +00:00
Jeff Bruemmer
c3c7feeddf docs - OIDC (#70892) 2026-03-25 13:54:47 -04:00
appleby
274b7de269 Remove dangling reference to use-native-agent setting in e2e tests (#71437)
This defsettings was removed in 311b735ae5
2026-03-25 16:48:29 +00:00
Stas Gavrylov
a0bea40dab GDGT-1755: Migrate common components from deprecated Popover to Mantine Popover (#70503)
* GDGT-1755: Migrate RightClickPopover to use Mantine

* GDGT-1755: Migrate DropdownSidebarFilter to Mantine Popover

* GDGT-1755: Migrate ParameterTargetWidget to Mantine Popover

* GDGT-1755: Make DropdownSidebarFilter close on Esc press

* GDGT-1755: Migrate GroupSelect to Mantine Popover

* GDGT-1755: Migrate deprecated Select to Mantine popover to remove deprecated Popover

* GDGT-1755: Cleanup. Delete unused deprecated components

* Fix prettier

* fix: fix test failures after Popover cleanup

- Remove jest.unmock for deleted Popover module in ChartSkeleton tests
- Add missing data-testid="popover" to DropdownSidebarFilter dropdown

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* GDGT-1755: Cleanup

* GDGT-1755: Address code review comments

* Clean up Popover.module.css: keep only tippy.js global styles

Remove unused module-level classes and obsolete tether-related classes.
Import the remaining global styles in TippyPopover.tsx.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-03-25 18:33:12 +02:00
Nicolò Pretto
2576505465 fix flaky test in embedding hub (#71434) 2026-03-25 17:04:32 +01:00
Nick Fitzpatrick
9f5298fa9a Update TablePicker when users publish/unpublish tables, change name (#70954)
* update TablePicker when users publish/unpublish tables, change name

* refetch tables in useTableLoader

* update table owners
2026-03-25 21:27:23 +05:30
Kevin Kelleher
07f25c0cc7 Allow changing conditional formatting to color range when rule condition is set (#71079) 2026-03-25 10:59:01 -04:00
Nicolò Pretto
cfb3ab406c Implement SSO setup checklist locking for steps 2 and 3 until JWT is configured (#71345)
* Implement SSO setup checklist locking for steps 2 and 3 until JWT is configured

* remove e2e for something already covered by unit

* update checklist default values after merging master
2026-03-25 15:52:01 +01:00
Egor Grushin
a4db64b01b GDGT-2017 write watermark to the DB before setting "succeed" status t… (#71334) 2026-03-25 14:21:55 +00:00
Noah Moss
efcefcad96 Avoid sending only whitespace in a slack API request (#71391)
Don't send only whitespace to the Slack API
2026-03-25 14:09:29 +00:00
Braden Shepherdson
38b071e39d [MBQL lib] Add user docs for filter functions in lib.core (#71035)
Part of QUE2-366.
2026-03-25 14:04:28 +00:00
Braden Shepherdson
46902911c8 [QP] Change the nested query alias from source to __mb_source (#70955)
closes #70224
Fixes QUE2-396.

### Description

This is necessary because `source` is a reasonably common name for a
column, and databases diverge on how they treat a reference like
`"source"."source"`:

- Postgres et al see the relation `source` in scope, and access its
  column called `source`, and all is well.
- Athena et al:
  - See that there is a **column** `source` in scope that doesn't require a prefix.
  - Assume it's a nested column with `ROW` type, and try to access the
    nested `source` field.
  - Type mismatch! It's a string or whatever, not `ROW`.

This PR doesn't *eliminate* the problem, but there's not really anything
we can do to fix Athena's honestly pretty odd choice of how to resolve this
ambiguous parse tree. But by changing our hard-coded alias for all
nested queries from `source` to `__mb_source`, we can make it extremely
unlikely that it will collide with a column that's in scope.
2026-03-25 13:53:00 +00:00
Noah Moss
23f686e698 Include conversation history in slackbot feedback (#71359) 2026-03-25 09:47:42 -04:00
Oleksandr Solovyov
311b735ae5 clean up references to ai-service (#71353) 2026-03-25 15:33:26 +02:00
Ngoc Khuat
e2f1a1a315 Fix flaky schema-change integration test (follow-up to #70863) (#71339) 2026-03-25 21:51:33 +09:00
Alex Yarosh
1f7e4b12f7 docs: update embedding skills (#71415)
Remove development note from SSO for embeds section
2026-03-25 08:30:39 -04:00
Sébastien
178ecbaeef fixed flaky (#71405) 2026-03-25 13:22:25 +01:00
Nick Fitzpatrick
5ac346612f Small positioning adjustments to the data studio nav bar (#71379)
* Small positioning adjustments to the data studio nav bar

* pr feedback
2026-03-25 17:36:41 +05:30
Chris Truter
2ace0b69c1 Built-in MCP server (#70787)
* Add MCP server with agent API integration

Implements an MCP (Model Context Protocol) server for Metabase that exposes
agent API endpoints as MCP tools. Includes an Oauth server, SSE transport, 
session management, scope-based auth, and tool dispatch via defendpoint metadata.

Co-Authored-By: Edward Paget <edpaget@users.noreply.github.com>
Co-Authored-By: Noah Moss <32746338+noahmoss@users.noreply.github.com>
2026-03-25 05:04:46 -04:00
Nick Fitzpatrick
6b8d7846de Update response on set token with network error (#70959)
* Update response on set token with network error

* report error message from checker when setting token

Currently when anything goes wrong during token checking while we're
setting a token, we *always* report that the token is invalid. This is
incorrect.

The token checker already gives us a descriptive `status` for the token,
which can tell the user whether the token is invalid or if we just
weren't able to check it.

One slight change here is to add `:canonical? true` to responses we
receive from MetaStore directly. This allows us to respond with the
correct HTTP status, since if we receive a response from the MetaStore
that tells us the token is invalid, that's a 400 error, where if we
weren't able to get a canonical response at all, that's a 503.

* add unit test

---------

Co-authored-by: John Swanson <john.swanson@metabase.com>
2026-03-25 14:19:32 +05:30
Chris Truter
d34d1dc9ff Fix search related testing race conditions (#71290)
Closes [BOT-1105: Search API tests fail with missing temp table](https://linear.app/metabase/issue/BOT-1105/search-api-tests-fail-with-missing-temp-table)
2026-03-25 09:10:23 +02:00
appleby
95f85256c2 BOT-1172 Fix markdown link buffering for slack links (#71388)
Fix markdown link buffering for slack links

find-potential-slack-link-start was looking for a full `<metabase://` prefix which doesn't work if the link prefix is
split across streamed text chunks. Updated it to deal with this case.
2026-03-25 00:37:50 +00:00
appleby
33661d4b6a BOT-1044 Convert links back to metabase:// format before sending to llm (#71125)
* BOT-1044 Convert links back to metabase:// format before sending to llm

This is a re-implementation of https://github.com/metabase/ai-service/pull/597

resolve-links converts metabase:// links into real URLs before sending them back to the client. When the LLM sees
these resolved URLs in the conversation history, it can get confused and start generating resolved links
itself (e.g. /question#<base64>), rather than following instructions to always use metabase:// links. This sometimes
results in wrong/hallucinated base64 repr, especially in longer conversations where many resolved links accumulate in
the history.

With this commit, we add a link-registry to the agent state to record every link rewritten by resolve-links, and use
invert-links to restore them to metabase:// URIs in the message history before sending it to the LLM for completion.

* Simplify state management for link-registry-atom

We don't need to track it separately in the agent state in init-agent. Just extract it from the agent memory in
the loop-step and sync it back after the llm call.

* Only invert urls in markdown links

* Replace handcrafted legacy MBQL in markdown_link_buffer_test.clj

* Mark deftests ^:parallel in markdown_link_buffer_test.clj

* Mark deftests ^:parallel in links_test.clj and breakup into smaller deftests

* Replace handcrafted legacy MBQL in links_test.clj

* Move resolve-slack-links into metabot.agent.links ns

To match existing resolve-links handling for generic metabase links

* Use with-temporary-setting-values to override site-url in markdown_link_buffer_test.clj

To match existing conventions in the codebase.

* Consolidate with-temporary-setting-values and breakup deftests in markdown_link_buffer_test.clj

* Record slack links into the registry map and invert them before sending history back to the llm

See f90619f5e2

* Fix agent memory initialize-test

* review feedback: extract part->invert-links-key helper
2026-03-24 23:41:03 +00:00
github-automation-metabase
d39d8c5800 Auto-update documentation for master (#71389)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-03-24 18:06:41 -04:00
Ryan Laurie
60da7517d1 Allow toggling auto releases via variable (#71313)
allow toggling auto releases via variable
2026-03-24 15:58:32 -06:00
appleby
ea43a75160 Fix metabot snowplow test flakes (#71337)
Fix snowplow test flakes

In call-llm-snowplow-test and call-llm-structured-snowplow-test filter the snowplow events to remove potential
new_instance_created events.
2026-03-24 17:23:04 -04:00
Noah Moss
77f28324a0 Add saved question display type to metabot context (#71372)
add saved question display type to metabot context
2026-03-24 20:14:19 +00:00
metamben
778dcf54a1 Introduce config option to specify known hosts for SSH tunnels (#71194)
* Introduce config option to specify known hosts for SSH tunnels

Closes QUE2-424
2026-03-24 22:44:56 +03:00
Alex Yarosh
161ebe81d5 docs: tenant example (#71365)
* Refine tenant attributes and permissions documentation

* Update docs/embedding/tenants.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Update docs/embedding/tenants.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-03-24 15:38:54 -04:00
Jeff Bruemmer
1dbfa65885 docs - agent API oss (#71380)
* oss and session

* link

* update
2026-03-24 14:51:59 -04:00
Cam Saul
8cb8e93394 Update GH teams config + modules config for Querying Platform (#71182) 2026-03-24 18:25:45 +00:00
Cam Saul
afc8eb428e Fix Snowflake Netty code scanning alert (#71309)
* Fix Snowflake Netty code scanning alert

* Dummy commit to trigger CI
2026-03-24 18:18:05 +00:00
Anderson
1fbe726c08 Fix ARIA grid role hierarchy in DataGrid for accessibility compliance (#70978)
* Fix aria-expanded on dashboard filter trigger button (#70543)

Closes https://github.com/metabase/metabase/issues/70543

### Description

Move aria-expanded from a wrapper div to the actual trigger button element
for dashboard filter popovers. Mantine's Popover.Target injects
aria-expanded via cloneElement onto its direct child. Previously, a Box
wrapper div was the direct child, so aria-expanded landed on a
non-interactive div instead of the button. This restructures the
component hierarchy so ParameterValueWidgetTrigger (which renders as a
button) is the direct child of Popover.Target, and moves the Sortable
wrapper outside the Popover.

### How to verify

1. Open a dashboard with filter parameters
2. Inspect the filter trigger button element in the DOM
3. Verify aria-expanded is on the button element (not a wrapper div)
4. Click the filter to open the popover and confirm aria-expanded
   toggles to true on the button

### Checklist

- [x] Tests have been added/updated to cover changes in this PR

* Fix ARIA grid role hierarchy in DataGrid for accessibility compliance (#70547)

Closes https://github.com/metabase/metabase/issues/70547

### Description

The DataGrid component had an invalid ARIA role hierarchy: `role="button"`
elements (from dnd-kit's useSortable) were nested directly inside a
`role="grid"` element without proper intermediate roles. Per the WAI-ARIA
grid pattern, the hierarchy must be: grid > rowgroup? > row > gridcell/columnheader.

This commit:
- Adds `role="rowgroup"` to header and body container divs
- Adds `role="row"` to the header row div
- Adds `role="columnheader"` to header cell wrapper divs in DataGrid
- Adds `role="gridcell"` to body cell wrapper divs in DataGrid
- Strips the invalid `role="button"` that dnd-kit injects into SortableHeader
- Removes now-redundant role attributes from HeaderCellWrapper and BodyCell
  (roles are now correctly placed on their parent wrapper elements)

### How to verify

1. Open any dashboard with a table/grid visualization
2. Inspect the DOM of the table-scroll-container element
3. Verify the ARIA role hierarchy follows: grid > rowgroup > row > columnheader/gridcell
4. Run an accessibility audit tool and confirm no `role="button"` violations inside the grid

* Keep button role in sortable header (it's ok since it's not wrapping the columnheader)

* Clean up

* Add unit test

* Fix a few tests

* Fix more e2e tests broken by ARIA role changes

* Fix more e2e tests

* Fix embedding-native.cy

* Another e2e test fix batch

* Fix e2e tests (again)

* fix reproductions-3.cy.spec.js
2026-03-24 15:05:33 -03:00
Jeff Bruemmer
2aec3aa887 Update agent API reference documentation (#71360)
* Update agent API reference documentation

Removed requirement for Metabase Pro/Enterprise from documentation.

* path
2026-03-24 17:36:43 +00:00
Nicolò Pretto
446de63944 feat(embedding-hub): add "copy dashboard to shared tenant collection" step (#70726)
* wip

* wip3

* test ci

* update tests

* remove code from tests

* sort xray dashboards

* cleanup

* clean up tests

* small refactor

* more cleaning up

* keep step disabled if  tenants is not active
2026-03-24 16:18:41 +01:00
Oleksandr Solovyov
08717ff883 closing-connection-native-agent-test: lower amount of chunks we check for (#71354) 2026-03-24 16:38:06 +02:00
Chris Truter
ccef0576f9 Calculate init time reliably (#71356) 2026-03-24 14:16:25 +00:00
github-automation-metabase
1b12502ec3 Revive and merge PR #67694: disable sync_schema side-effect in db-operations-test (#71201)
Fix H2 lock timeout in db-operations-test by mocking sync task

Split the monolithic db-operations-test into three focused tests:
- non-admin-sync-schema-test: mocks quick-task/submit-task! to prevent
  the actual sync job from running, eliminating the race condition with
  DATA_PERMISSIONS cleanup in mt/with-all-users-data-perms-graph!
- non-admin-discard-field-values-test: isolated test for discard_values
- non-admin-rescan-field-values-test: isolated test for rescan_values

Also renames update-database-test, delete-database-test, and fetch-db-test
to non-admin-* for consistency, and adds explicit permission-denial (403)
test cases to each test.

Revives the fix from closed PR #67694.
2026-03-24 14:00:45 +00:00
Braden Shepherdson
b42c2f6605 [QP] Override LIMIT for pivot queries to ensure consistent results (#71033)
Closes #70963
Fixes QUE2-431.

Previously, pivot queries got the same default row limits added as any
aggregated query. But since pivot queries synthesize the results from
several inner queries with different subsets of breakouts, they
have different row counts.

The main ("row details") query the user wrote has all the breakouts,
so it has the most rows. If that query gets truncated, only a subset
of the data is returned, leaving gaps in the pivot table. Worse, the
sub-queries with other subsets of the breakouts, intended to collect
group, column and row subtotals, and the grand total, are inconsistent
with the details in the cells, and with each other, because they can
all end up `SUM`ing (etc.) over different sets of the raw rows.

With this change, a new and much larger row limit is permitted for the
pivot sub-queries. The pivot table viz contains one cell for each
aggregation in the query, multiplied by the rows of the main query.
We budget for **200k cells**, divide by the number of aggregations,
and that becomes the row limit.

If the row details query reaches that limit, the query is rejected:
- Other sub-queries are skipped
- A `pivot-rows-truncated` flag in the results signal the FE
- Which shows an error suggesting the user add a filter or remove
  breakouts to lower the row count.

Some reasonable pivot queries might still be excluded, but now we never
run a pivot query with incorrect data in it. If we execute the query and
render the pivot results, then all the returned data should be correct.
2026-03-24 13:45:34 +00:00
Nick Fitzpatrick
cfa96f3fe0 Catch drag events on Dashcard placeholders (#71274)
* Catch drag events on Dashcard placeholders

* scope drag events, add test
2026-03-24 18:46:31 +05:30
github-automation-metabase
3f55d1b9f4 Use env var indirection in Loki stress-test workflow (#71349)
Fix script injection via env var indirection in loki-stress-test-flake-fix.yml
2026-03-24 13:48:02 +01:00
Nemanja Glumac
acbf9bcc88 Delete Claude bug fix workflow (#70993) 2026-03-24 12:52:30 +01:00
Uladzimir Havenchyk
442cf4abb9 fix: cross branch migration workflow (#71153) 2026-03-24 14:31:51 +03:00
Kamil Mielnik
aee64c6047 GDGT-1869 Remove "as VisualizationSettingsDefinitions" casts (#71217) 2026-03-24 17:30:47 +07:00
Nicolò Pretto
41ca038f67 feat(embedding hub): add ability to hide sidebar for some pages (#71278) 2026-03-24 10:09:27 +01:00
Chris Truter
a0896d1faf Fix clickhouse test flake (#71306) 2026-03-24 10:26:47 +02:00
Romeo Van Snick
c8cb9c2f04 Remove sync buttons for managed cloud databases (#71203)
* Remove sync buttons for managed cloud databases

* Remove sync settings button for table in attached data warehouse in admin > table metadata and data studio
2026-03-24 14:17:29 +11:00
Fraser
b8c90cdfbe Push shared files down from feature modules (#71137) 2026-03-24 15:24:34 +13:00
Romeo Van Snick
0ab5a0f603 Fix parameter tags reordering in the presence of snippet tags (#71209)
* Disregard snippet tags when reordering parameters

* Add repro for metabase#69160

* Wording

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

---------

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
2026-03-24 11:59:52 +11:00
Riley Thompson
8f9282dca1 Don't generate join alias that matches source table name (#70876)
* include source name in taken names

* add test

* Update src/metabase/lib/join.cljc

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* fix tests

* fix test

* Fix test metadata for self-join test

* e2e test fix attempt

* second attempt

---------

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
2026-03-24 00:39:09 +00:00
bryan
c8560d8251 Models to transforms (#70735)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
2026-03-23 23:59:16 +00:00
appleby
74a9d5baeb BOT-1157 Update metabot prometheus and snowplow metrics to include both provider and model (#71259)
We now report the full provider and model rather than just the model, e.g.

    anthropic/claude-haiku-4-5 -> openrouter/anthropic/claude-haiku-4-5
    claude-haiku-4-5           -> anthropic/claude-haiku-4-5

In addition to being useful info to capture, this matches the behavior of the pre-existing ai-service metrics.
2026-03-23 16:42:40 -07:00
bryan
fb428f307e Extend ci-report to accept branch names and commit SHAs (#70742) 2026-03-23 15:50:21 -06:00
Jeff Bruemmer
e50748827a docs - sdk playground (#71314)
* sdk playground link

* edit

* image

* Optimized 1 images, saved 188.7 KB (35.5% smaller)

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-03-23 21:48:31 +00:00
Ben Grabow
9ec99afb69 Ghy-3258/table tag dependencies missing in incremental transforms (#71316)
Include table tags as dependencies of native queries
2026-03-23 16:40:06 -05:00
Oleksandr Solovyov
c2ad36cccb move ee/llm into oss (#71068)
* move ee/llm into oss

* lots of file movement

* move slack connect to opensource

* ability to have enterprise-only tools

* move tests

* Fix stale metabot-v3 aliases, dangling module refs, disabled linting, broken test paths, and typo

* start using deprecated-name, more ns path fixes

* move llm transforms code to oss

* fix namespaces

* whitespace fix

* checkpoint: switch tools to use mu/defn or defenterprise directly

* compilation fix

* lint fixes

* move around some code to break drivers dependency

* fix tests

* fix tool calls

* sort routes

* fix openapi

* fix module config

* lint

* fix clj-kondo

* fix test

* fix token check tests

* cljfmt

* fix slack test

* maybe fix dashboard tests?

* cljfmt

* is this a fix for dashboard tests

* move metabot models to oss

* untangle module config after rebase

* fix module order

* cleanup

* add back ai service-related settings that are still used

* move some more code to more appropriate places

* more code movement

* better schema names

* clean up mu/defn function name formatting

* update module config

* remove unneeded ai service-related test

* fix module config again

* fix auth in tests by removing more ai service stuff

* enable native agent by default

* test transforms over normal function calls

* requires

* pass through metabot-id to tool calls instead of hardcoding embedded-metabot-id, to fix answer sources test

* fix wrap-tools-with-state calls

* try to fix failing field/dashboard tests by matching the code on master (might have been from a bad rebase)

* Revert "try to fix failing field/dashboard tests by matching the code on master (might have been from a bad rebase)"

This reverts commit cd5ec8b487.

* hard revert parameters.dashboard-test to the version on master after the latest rebase

* mark snippet tests as sequential to try to fix perms test issues, remove a couple stray metabot feature checks

* move entity analysis + sql fixing code to oss

* wrap dashboard tests with with-full-data-perms-for-all-users to isolate the failure

* move ai-entity-analysis and ai-sql-fixer under the metabot module

* fix module test

* remove now-unneeded ai feature falgs

* disable perms cache for these failing dashboard tests

* simplify test that was still using agent-api feature flag

* memoize spec-index-query by app db to fix failing search tests caused by new test execution order

* LLM OSS FE (#71197)

* bulk move files

* replace usage of /ee/metabot-v3/ to /metabot

* remove PLUGIN_METABOT

* fix broken metabot routes, removes metabot_v3 token feature usage

* remove PLUGIN_AI_*

* bring back enterprise vs oss behavoir, with the code still being OSS

* fix lint + unit tests

* fix embedding sdk stories

* add back missing FixSqlQueryButton.unit.spec.tsx test

* fix last references of `/ee/ai-*` endpoints

* pr feedback

* test fix

---------

Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>
2026-03-23 17:30:50 -04:00
Chris Truter
76b01b772b Define additional metrics for release monitoring (#71237) 2026-03-23 17:20:34 -04:00
Noah Moss
733176c925 Add cancelled check for sdk-tests (#71307) 2026-03-24 10:03:27 +13:00
Ryan Laurie
88a87db2b8 Sanitize database details during serialization import (#71311)
[59] Sanitize database details during serialization import (#335)

* Sanitize database details during serialization import

Strip low-level JDBC keys (classname, subprotocol, connection-uri, subname,
init) from database details during serialization import and reject h2 engine.

Also add subname and init to the connection-details dispatch blocklist and
sanitize details in h2 connection-details->spec as defense in depth.

* Use custom runners

* fix error printing and test

* rebind assert-not-h2! during tests

* kondo ignore

---------



# Conflicts:
#	.github/workflows/backend.yml
#	.github/workflows/cross-branch-migrations.yml
#	.github/workflows/tusk-sanity-check.yml

Co-authored-by: Nicola Mometto <nicola.mometto@metabase.com>
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
2026-03-23 14:40:06 -06:00
Ryan Laurie
45380db283 Send release jars to cloud bucket (#71093)
* update var

* do it in the tag step
2026-03-23 14:29:58 -06:00
metamben
84b79b9126 Reorganize QP module (#70808)
* Introduce qp.core and qp.test namespaces
2026-03-23 20:14:12 +00:00
Nicola Mometto
d6d3bbb89a Fix bug with temporal values in bigquery incremental transforms (#71291)
* fix: coerce temporal values used in incremental transforms filters

* fallthrough on LocalDateTime

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

---------

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
2026-03-23 18:41:40 +00:00
Alex Yarosh
1bb4b60d60 docs: workflow schedule (#71305)
docs workflow schedule
2026-03-23 14:33:38 -04:00
Sébastien
1827c0c37d Fixed dancing MB (#71211) 2026-03-23 16:48:56 +01:00
github-automation-metabase
5dd6f68c46 Fix title escaping for JSON (#71289) 2026-03-23 16:08:50 +01:00
Nemanja Glumac
c85d47365d Remove hard-coded Trivy version (#71287) 2026-03-23 15:03:46 +01:00
github-automation-metabase
17bca77f06 Auto-update documentation for master (#71268)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-03-23 09:19:13 -04:00
Jakub Chodorowicz
4c4c049ac8 update copy and styling of table variable select (#71101)
* update copy and styling of table variable select

* extract common LabelWithInfo component

standardize styling
2026-03-23 13:13:42 +01:00
Kevin Kelleher
38fa86db3f Fix scatter plot flicker on hover (#71036) 2026-03-23 07:38:27 -04:00
Nemanja Glumac
ac3a38209f Patch vulnerable Trivy action (#71282)
Resolves DEV-1712

Patches Trivy GitHub action to a version that is confirmed not to be affected by the supply chain attack. We're using SHA-1 instead of a tag for an improved security.

See: https://app.mendral.com/insights/01KM6NFNZPV1JS72KAPCA2K9XH
2026-03-23 12:22:55 +01:00
Chris Truter
c568186ebc Only run Eastwood (test) on master (#71232) 2026-03-23 12:30:13 +02:00
Nicolò Pretto
a49e97237f add ability to hide Our analytics in MiniPicker and hide it in the table picker in the embedding setup (#70920)
* add ability to hide Our analytics in MiniPicker

* remove changes not needed

* update getOurAnalytics with the values from EntityPicker
2026-03-23 11:12:55 +01:00
Fraser
f1c36719aa Move shared query_builder logic to querying (#71129) 2026-03-23 09:22:12 +00:00
Sébastien
292a667717 Fixes a loki flaky (#71225)
* loki flaky

* .

* .

* fonts
2026-03-23 10:02:28 +01:00
Kamil Mielnik
361549c5af GDGT-2024 Consolidate ChartSettingsWidget's noPadding, marginBottom, and borderBottom (#71154) 2026-03-23 14:25:07 +07:00
Romeo Van Snick
c009e25907 Fix timeline form icon input (#71199)
* Add icon to timeline icons

* Use Select from mantine/ui for timeline form

* Add test for icon in timeline creation
2026-03-23 16:21:20 +11:00
Romeo Van Snick
e13fd47144 Convert dataref to ts (#71062)
* Convert dataref to ts

* Fix unit test

* Fix actions

* Fix field reference

* Fix native data reference

* Fix field pane
2026-03-23 13:01:43 +11:00
metabase-bot[bot]
2812c4496d [chore] Update E2E test timings with recent data (#71265)
Update E2E test timings with averaged data

Collected timing data from 7 days of test runs.
All specs with timing data were included (simple averages).

🤖 Generated automatically by update-e2e-timings workflow

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <actions@github.com>
2026-03-23 10:11:46 +13:00
Nathan Voxland
28093ce803 Support Group Sync in OIDC (#71176) 2026-03-21 00:24:40 -05:00
Nathan Voxland
a649b08171 Field filter does not show dropdown values (#71114) 2026-03-21 00:23:58 -05:00
Egor Grushin
7a7585be68 Gdgt 1864 Add pinned columns and rows to the DataGrid (#70384) 2026-03-21 02:10:09 +00:00
Anderson
6b241a18fd Fix dashboard tab list items having role="button" instead of role="tab" (#70546) (#70976)
* Fix aria-expanded on dashboard filter trigger button (#70543)

Closes https://github.com/metabase/metabase/issues/70543

### Description

Move aria-expanded from a wrapper div to the actual trigger button element
for dashboard filter popovers. Mantine's Popover.Target injects
aria-expanded via cloneElement onto its direct child. Previously, a Box
wrapper div was the direct child, so aria-expanded landed on a
non-interactive div instead of the button. This restructures the
component hierarchy so ParameterValueWidgetTrigger (which renders as a
button) is the direct child of Popover.Target, and moves the Sortable
wrapper outside the Popover.

### How to verify

1. Open a dashboard with filter parameters
2. Inspect the filter trigger button element in the DOM
3. Verify aria-expanded is on the button element (not a wrapper div)
4. Click the filter to open the popover and confirm aria-expanded
   toggles to true on the button

### Checklist

- [x] Tests have been added/updated to cover changes in this PR

* Fix dashboard tab list items having role="button" instead of role="tab"

Closes https://github.com/metabase/metabase/issues/70546

### Description

The Sortable wrapper around each dashboard tab item was applying a default
`role="button"` to its container div, which overrode the inner TabButton
`role="tab"` from the perspective of screen readers and accessibility tools.
Changed the Sortable wrapper to use `role="presentation"` so it is transparent
to the accessibility tree, allowing the inner TabButton role="tab" to be
properly recognized within the role="tablist" container.

### How to verify

1. Open a dashboard with multiple tabs
2. Inspect the tab items in the browser DevTools
3. Verify that tab items have `role="tab"` (not `role="button"`)
4. Verify the tab list container has `role="tablist"`

### Checklist

- [x] Tests have been added/updated to cover changes in this PR

* Add issue number to test titles (#70546)

* Improve test

* Clean up
2026-03-20 20:19:30 -03:00
Ryan Laurie
b9573fc138 Use Local DigiCert for docker container builds (#71095)
use local cert

# Conflicts:
#	Dockerfile
#	bin/docker/Dockerfile
#	bin/docker/Dockerfile_ubuntu
2026-03-20 21:55:40 +00:00
Ben Grabow
8d41c7d068 Disallow adding new classpath resources as geojson paths (#70745)
* Disallow adding new classpath resources as geojson paths
2026-03-20 21:16:01 +00:00
Ben Grabow
e0365e3297 Revert "Temporarily disable app db version checks" (#71191)
Revert "Temporarily disable app db version checks (#70884)"

This reverts commit c5dcdc3238.
2026-03-20 15:36:19 -05:00
Braden Shepherdson
6b6ea19ab7 [MBQL lib] Add user docs for breakouts functions (#71034)
Part of QUE2-366.
2026-03-20 19:56:00 +00:00
Uladzimir Havenchyk
5a142f6eb1 add a workflow to publish custom viz npm package (#71221)
* add a workflow to publish custom viz npm package

* trigger CI
2026-03-20 12:32:56 -06:00
ignacio
cfacacd556 Update account settings docs (#71240)
This is currently doable in version 59.3.



See this issue: https://github.com/metabase/metabase/issues/63581
2026-03-20 15:22:12 -03:00
Uladzimir Havenchyk
a9b9ad9d85 chore: convert isa.js to typescript (#71014)
* chore: convert isa.js to typescript

* address comments

* address review

* revert back broken checks

* fix review
2026-03-20 20:35:23 +03:00
Chris Truter
68ec84ae4d Make all model imports and exports explicit (#71224) 2026-03-20 09:58:44 -07:00
Jakub Chodorowicz
6724b20a7b enable transform inspector only with advanced (python) transforms (#71067)
hide inspect tab when it's not supported by current features
2026-03-20 17:40:50 +01:00
Edward Paget
dd34d56120 fix: cancel serialization when client disconnects (#69864)
* fix: cancel serialization when client disconnects

Co-Authored-By: John Swanson <john.swanson@metabase.com>

* fix: complete serialization virtual thread streaming response

- Fix channel signal direction: use >!! to write to done-chan instead of <!! (read)
- Fix streaming response: use io/copy instead of .write for File objects
- Set explicit 200 status on success, set-status!/set-content-type! on error path
- Add Content-Disposition header on success for proper download behavior
- Clean up temp files on cancel and use finally for deterministic cleanup
- Remove commented-out old synchronous code
- Use canonical clojure.core.async alias (a instead of async)
- Add server module to enterprise/serialization allowed dependencies
- Relax full_stacktrace test threshold (200 -> 50 lines) to avoid JVM-dependent flakiness

---------

Co-authored-by: John Swanson <john.swanson@metabase.com>
2026-03-20 11:28:41 -05:00
Braden Shepherdson
3559ec98b0 [QP] Do coercions (eg. Unix timestamps) with native sandboxing (RCLS) (#70885)
Fixes QUE2-376.

For MBQL queries, type coercions (like integers to Unix timestamps) only
get applied on the earliest stage where that field is introduced. When
the table the field comes from is sandboxed by a native query, an
extra stage is introduced but it doesn't do the coercion.

Decorates the metadata of any native sandbox column whose table counterpart had coercion defined.

It's unfortunately complicated inside lib since the metadata needs to be propagated through exactly one
stage boundary. If it propagates all the way then we get double-coercion and SQL errors.
2026-03-20 16:24:21 +00:00
Jeff Bruemmer
bc80f935a2 docs - transform inspector (#71188)
* draft

* edits

* edits

* toc

* Optimized 3 images, saved 326.0 KB (47.1% smaller)

* Update docs/data-studio/transforms/transform-inspector.md

Co-authored-by: Alex Yarosh <alexandra@metabase.com>

* edits

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
Co-authored-by: Alex Yarosh <alexandra@metabase.com>
2026-03-20 12:19:19 -04:00
github-automation-metabase
d0ac061fee Fix trivy action tag prefix (#71213)
fix: use v prefix on aquasecurity/trivy-action@v0.29.0 tag reference
2026-03-20 09:17:26 -06:00
Jeff Bruemmer
0cdcd2232c docs - agent resources for embedding (#71108) 2026-03-20 10:40:15 -04:00
Sébastien
8de615a69d Fixed empty csv for adhoc pivot tables in SDK (#71141) 2026-03-20 14:28:59 +01:00
Uladzimir Havenchyk
24968aa972 build: use a proper link for cert download (#71064) 2026-03-20 16:22:23 +03:00
Ngoc Khuat
a3ae3ba1f4 Transform inspector reorganization (#71136) 2026-03-20 10:34:24 +00:00
Nicola Mometto
22b6962656 default transforms impls with informative errors (#71145)
feat: provide default transforms impls with informative errors
2026-03-20 10:14:14 +00:00
Nicolò Pretto
94be4bfae3 Emb 1450 simplify sdk e2e test commands and docs (#71168)
* remove the embedding dev command and update the docs

* fix typo
2026-03-20 09:42:10 +01:00
Ngoc Khuat
39bc014f14 Server-side rendering for comment emails (#70938) 2026-03-20 07:55:16 +00:00
Fraser
4864f0ae24 Revert "Further pdf export improvements" (#71208)
Revert "Further pdf export improvements (#71031)"

This reverts commit 536d6bf22f.
2026-03-20 19:45:09 +13:00
Aleksandr Lesnenko
cd7eb82bdb remove emotion from browse pages (#71184) 2026-03-20 06:43:45 +05:30
Nick Fitzpatrick
536d6bf22f Further pdf export improvements (#71031)
* use cssText

* include font props on <text>, <tspan>, and <textPath> nodes
2026-03-20 05:59:35 +05:30
Anderson
ac092618ac Hide 'New metric' and 'Publish a table' actions on Data Studio Library empty state when in read-only mode (#71112)
* Fix: Hide metric creation and table publishing actions in read-only mode

In read-only instances (remote sync read-only mode), the Library still showed:
- 'New metric' action link in the Metrics empty state
- 'Publish a table' action button in the Data empty state
- 'New snippet' action link in the SQL snippets empty state

While the +New button was already hidden in read-only mode, the empty state
action links were not checking for this permission, allowing users to attempt
actions that should be disabled.

Changes:
- Add read-only mode check to EmptyStateAction component in LibrarySectionLayout
- Empty state actions now return null when in remote sync read-only mode
- Add e2e test to verify actions are hidden in read-only mode

* Refactor: use hideAction param and call-site guard instead of returning null from EmptyStateAction

Leverage the existing third param of createEmptyStateItem to suppress
actionUrl for metrics/snippets in read-only mode (consistent with how
the snippet tree handles it). Guard the 'Publish a table' button at
the EmptyStateAction call site in LibrarySectionContent, outside the
component itself. Reorganise the e2e test into the empty state describe
block.
2026-03-19 20:34:20 -03:00
Tyler Plude
03a09e1832 BOT-1127 Metabot Conditional Tool Schema Params (#71050)
* conditional tool schema input params

* simplify feature-available?

* unit tests

* applying to other search tools
2026-03-19 16:01:59 -07:00
Chris Truter
cc74f66a1b Restrict which models are accessible by each module (#71010) 2026-03-19 21:08:20 +00:00
John Swanson
bfa572ec6b Metric viewer can use metrics based on cards (#71107)
[UXW-3260: Metrics from models/table questions are not viewable in the Metrics viewer](https://linear.app/metabase/issue/UXW-3260/metrics-from-modelstable-questions-are-not-viewable-in-the-metrics)
2026-03-19 12:22:17 -08:00
Romeo Van Snick
fb38572a8c Fix flaky test in sidebar content (#71135)
Fix flaky test
2026-03-20 07:11:37 +11:00
lbrdnk
a02acabac1 Add database_engine to enhanced tables (#70968) 2026-03-19 20:59:15 +01:00
Rodrigo López Dato
198cd9a9a3 Remove X-Metabase-Session from autogenerated API docs in favor of X-API-Key (#71155)
* X-API-Key capitalization in docs

* Use X-API-Key instead of X-Metabase-Session in Scalar API docs
2026-03-19 19:32:45 +00:00
Eric Normand
c9c7f230fb Fix string field IDs leaking into bulk-metadata queries (#71167)
Add pos-int? guard to all-implicitly-joined-field-ids pattern match,
matching the guard already used by all-field-ids. String field names
(e.g. from native/model sources) were being collected and passed to
bulk-metadata, causing Postgres type mismatch errors.
2026-03-19 13:58:07 -05:00
Aleksandr Lesnenko
e1608e708d Add skill to migrate emotion to mantine and css modules (#71173)
add skill to migrate emotion to mantine and css modules
2026-03-19 14:21:59 -04:00
Chris Truter
213b1b5905 Add mechanism for more reliably renaming settings (#71088) 2026-03-19 14:12:31 -04:00
Eric Normand
42fdf326b6 Fix StackOverflowError in deduplicated column name resolution (#71096)
Add a dynamic guard `*in-deduplicated-column-resolution?*` and convert the
mutual recursion between `resolve-nonexistent-deduplicated-column-name` and
`resolve-from-previous-stage-or-source` into a loop. Previously, resolving
a field like `name_5000` would create O(N) deep mutual recursion, overflowing
the JVM stack at ~3000-4000 frames.
2026-03-19 12:24:47 -05:00
Anderson
3969de09bb Enable keyboard navigation in dashcard download data popover (#70541) (#70965)
* Enable keyboard navigation in dashcard download data popover

* Use mantine's Menu.Sub for submenus in DashCardMenu
2026-03-19 13:22:04 -03:00
bryan
99548507aa Add ci:run-<driver> and ci:run-all-drivers labels to mage driver decisions (#70894)
* Add ci:run-<driver> and ci:run-all-drivers labels to mage driver decisions

Allow force-running specific drivers or all drivers via PR labels,
overriding quarantine. Inserted at priority 3 (after H2/Postgres
always-run, before quarantine check). Added Labels of Interest and
All Drivers sections to help output.

* Add hint about ci:run labels in CI driver decisions output

Shows a helpful message in CI logs pointing users to the new labels
and the local help command for more info.

---------

Co-authored-by: Ben Grabow <ben.grabow@gmail.com>
2026-03-19 16:07:07 +00:00
Edward Paget
e0a2e2a80a fix: remove logging from session api (#70444) 2026-03-19 11:03:02 -05:00
Edward Paget
b8805a8d92 feat: admin password reset link for users (#70464)
* feat: admin password reset link for users

* fixup! add missing dep to modules.edn

* fixup! response schema position

* fixup! reset e2e tests

* fix: store temporary password in Redux after no-SMTP password reset

The handleResetConfirm function called updatePassword via RTK Query but
never dispatched storeTemporaryPassword, so the temporary password modal
never appeared.

* fix: replace smart quotes with straight apostrophes in password reset modal

The modal title and body strings used Unicode RIGHT SINGLE QUOTATION MARK
(U+2019) instead of ASCII apostrophe, causing E2E tests to fail on text
matching.

* fix: correct reset URL assertion in e2e test

The test expected "password-reset" but the actual URL path is
"reset_password".
2026-03-19 10:30:32 -05:00
Braden Shepherdson
90042b1f02 [MBQL lib] User docs for aggregation functions (#70515)
Part of QUE2-366.

Adds user-facing documentation for aggregations functions in `lib.core`.
2026-03-19 14:26:22 +00:00
Kamil Mielnik
55144d12be GDGT-2001 Get rid of VisualizationSettingDefinition["default"] (#71015) 2026-03-19 14:08:16 +00:00
Stas Gavrylov
91ca661215 GDGT-2037: Fix CssVarsDeclarationPlugin crashing dev server on missing files (#71139)
* Fix CssVarsDeclarationPlugin to not break on build if file is missing

* Fix path to color-keys file

* Add CssVarsDeclarationPlugin warning comments to referenced source files

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 14:03:29 +00:00
github-automation-metabase
b42f3332c0 Auto-update documentation for master (#71128)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-03-19 09:32:36 -04:00
Nicola Mometto
4937134c3e Batch metabase_table update migration (#70996)
* fix: batched metabase_table update on data_layer

* don't replace inline

* preserve

* no need for rollback in liquidbase

* run outside of a transaction

* runInTransaction:false
2026-03-19 12:05:42 +00:00
Jakub Chodorowicz
ebbc0adc70 display sql transforms errors in editor (#71092)
* update setupCardDataset to use named params

* display sql transform errors in editor

* improve mock data in test

* use isObject helper
2026-03-19 11:10:33 +00:00
Nicolò Pretto
45cd62fe3e remove claude from mise as it's not a required tool (#71138) 2026-03-19 10:22:47 +01:00
Jakub Chodorowicz
2d250a7a71 change incremental transform copy (#71103) 2026-03-19 09:59:14 +01:00
Chris Truter
7ecba8f6d4 Create table entries for transform targets on save (#70552) 2026-03-19 08:09:03 +00:00
Aleksandr Lesnenko
e53b32e245 stacked series (#70682) 2026-03-19 00:49:25 +00:00
Edward Paget
48d1a7c36e fix: handle recycled jetty http response objects (#70674)
* fix: handle recycled jetty http response objects

In the streaming response handler. Make sure that the response object is
both committed and that its AsyncContext has not been timedout.
Attempting the write after the timeout results in an NPE.

* fixup! missing reify method

* make async-context-completed? private
2026-03-18 16:37:35 -05:00
Anderson
d2406bf64b Fix aria-expanded on dashboard filter trigger button (#70543) (#70973)
* Fix aria-expanded on dashboard filter trigger button (#70543)

Closes https://github.com/metabase/metabase/issues/70543

Move aria-expanded from a wrapper div to the actual trigger button element
for dashboard filter popovers. Mantine's Popover.Target injects
aria-expanded via cloneElement onto its direct child. Previously, a Box
wrapper div was the direct child, so aria-expanded landed on a
non-interactive div instead of the button. This restructures the
component hierarchy so ParameterValueWidgetTrigger (which renders as a
button) is the direct child of Popover.Target, and moves the Sortable
wrapper outside the Popover.

1. Open a dashboard with filter parameters
2. Inspect the filter trigger button element in the DOM
3. Verify aria-expanded is on the button element (not a wrapper div)
4. Click the filter to open the popover and confirm aria-expanded
   toggles to true on the button

- [x] Tests have been added/updated to cover changes in this PR

* Wrap dashboard filter items in a list container for a11y
2026-03-18 17:30:40 -03:00
Kevin Kelleher
c62b32e78f Fix pivot text overlapping when next header column is collapsed (#71104) 2026-03-18 15:49:56 -04:00
Noah Moss
241e1fb189 Better error logging for slackbot (#71098) 2026-03-18 14:23:36 -05:00
Rodrigo López Dato
db25f8fa80 Docs: improve embedding appearance theming section (#70967)
* Docs: improve embedding appearance theming section

Rewrite the basic theming section for clarity: rename to "Dark mode and
light mode", simplify the explanation, and preserve the old
#basic-theming anchor for existing links.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Update docs/embedding/appearance.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-03-18 18:35:09 +00:00
Ben Grabow
86d1b95df0 Bgrabow/ci test repl mage task (#71025)
* ci-test-repl mage task

* Use ci port map to set port. Include junit name in job string

* Move to bgrabow

* Add dry-run mode

* task! wrapper to support helptext
2026-03-18 18:18:33 +00:00
Jeff Bruemmer
ee6203aa6e docs - agent demo link (#71074)
* agent demo link

* Optimized 1 images, saved 125.8 KB (45.1% smaller)

---------

Co-authored-by: Metabase Automation <github-automation@metabase.com>
2026-03-18 18:03:17 +00:00
Anderson
4b7056a383 Make it clearer why transforms can't be created in read-only mode (#71051)
test: update tests for read-only mode transform creation UI changes

Update E2E tests to verify:
- Create transform button is disabled with explanatory tooltip in read-only mode
- New transform pages show not found message when accessed directly in read-only mode
2026-03-18 13:58:32 -03:00
Nathan Voxland
25100c1310 Allow linear to trigger repro-bot (#71049) 2026-03-18 09:03:46 -07:00
Alex Yarosh
2f7a83ddc5 docs: new incremental transforms (#71080)
* incremental transforms

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
2026-03-18 11:21:06 -04:00
Ben Grabow
0abb871d3f Fix flaky metabase-enterprise.dependencies.api-test (#71024)
* Drain the single-threaded async executor to ensure all pending dependency work completes before model cleanup deletes cards, avoiding lock timeouts.

* Use fresh-dependency-async-executor-fixture on every test
2026-03-18 10:01:34 -05:00
Eric Normand
693550cf45 Correctly hide/show card filters based on permissions (#70980)
Backend (query_processor/dashboard.clj): Added an explicit view-data permission check using most-permissive-database-permission-for-user. This returns 403 when a user has no view-data access, taking precedence over parameter validation errors (400).

Frontend (DashCardVisualization.tsx): Decoupled the three concerns:

* Inline parameters render when inlineParameters.length > 0 AND the user has view access (no 403 on the card result)
* DashCardMenu (download button) renders when DashCardMenu.shouldRender() is true (requires canEditQuestion or canDownloadResults)
* 403 from backend hides both inline params and menu — no point showing UI for data the user can't access
2026-03-18 09:35:17 -05:00
Ryan Laurie
8255a879de Parameterize runners (#71077)
* Use custom runners

# Conflicts:
#	.github/workflows/cross-branch-migrations.yml
#	.github/workflows/pre-release.yml
#	.github/workflows/tusk-sanity-check.yml

* more updates

---------

Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
2026-03-18 08:24:12 -06:00
Sébastien
ea2e642c82 Fixed flaky e2e test (#71019) 2026-03-18 15:00:06 +01:00
github-automation-metabase
3bfd0aa9bf Auto-update documentation for master (#71058)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-03-18 08:41:53 -04:00
Uladzimir Havenchyk
f45dbe78a1 chore: update formatting (#71072) 2026-03-18 13:04:05 +01:00
Kevin Kelleher
43ab4dbb8d Allow grid columns in Detail visualization to grow and shrink (#70964) 2026-03-18 07:49:40 -04:00
Jakub Chodorowicz
80d08cce82 use array/list for sources table in transforms (#70100) 2026-03-18 11:11:24 +01:00
Fraser
7e5435f6f1 Dev 1662 move libcolors into UI (#70754) 2026-03-18 22:52:16 +13:00
Kamil Mielnik
3c229eb38d GDGT-1998 Get rid of VisualizationSettingDefinition["marginBottom"] (#71004) 2026-03-18 15:59:11 +07:00
Kamil Mielnik
e271bc5e52 GDGT-1995 Get rid of VisualizationSettingDefinition["disabled"] (#71000) 2026-03-18 14:00:46 +07:00
Cam Saul
f5eeabb4be Rework Pivot QP to add pivot-grouping in post-processing (#70986)
* Rework Pivot QP to add `pivot-grouping` in post-processing

* PR feedback

* Fix MongoDB test failures

* Fix test failures

* cljfmt

* Fix calculating pivot group for queries with remaps

* cljfmt

* Test fix 🔧

* Test fix 🔧

* Delete unused code
2026-03-18 01:29:20 +00:00
Anderson
f2164af918 Add snowplow events when creating new job (#70279)
* Add snoplow events when creating new job

* Fix e2e
2026-03-17 21:05:09 -04:00
Anderson
832e71aa46 Add aria-level attribute to dashboard title heading (#70985)
* Add aria-level attribute to dashboard title heading

Closes https://github.com/metabase/metabase/issues/70544

### Description

Dashboard title elements with role="heading" now include the aria-level
attribute set to 1, properly indicating they are primary headings. This
improves accessibility for screen reader users by establishing the correct
heading hierarchy.

The fix adds aria-level={1} to the Box component in DashboardHeaderView
that already has role="heading". This ensures screen readers can properly
navigate the heading structure of the dashboard page.

### How to verify

1. Open any dashboard in Metabase
2. Inspect the dashboard title element in browser DevTools
3. Verify the heading has both role="heading" and aria-level="1"
4. Test with a screen reader (e.g., NVDA, JAWS) to verify it's announced
   as a level 1 heading

Alternatively, run the new unit test:
```bash
bun jest --testPathPatterns="DashboardHeader/tests/common.unit.spec"
```

### Checklist

- [x] Tests have been added/updated to cover changes in this PR

* Clean up
2026-03-17 20:45:09 -03:00
Sloan Sparger
6826140380 [Metabot] Slackbot (#68473)
* wip

* clean up and move secrets to settings

* validate incoming slack requests and better sending of messages / processing responses

* get ai response working, make slack app an agent, fetch threads

* add loading / thinking state

* image uploading and clean up

* add test coverage for validation of slack requests

* add test coverage for endpoints only being available with metabot token feature

* add test coverage for user messages

* fix image uploads not working

* add test coverage for messages with visualizations

* fix convo history

* allow for rendering adhoc questions and surrounding the static viz with padding

* Re-enable +auth middleware for endpoints in metabase-enterprise.metabot-v3.api

* Ensure user has linked slack and metabase accounts before sending messages

And send them an ephemeral message with a (currently invalid) link to authorize

* Add some more repl testing comments

* dev comments: fix assert when updating manifest and encourage env vars for dev secrets

* Use request/with-current-user rather than binding api/*current-user* directly

This is the preferred way to set the user and handles binding things like api/*is-superuser?* and
api/*current-user-permissions-set* as well.

* smol refactor to clean up process-user-message

* Fix kondo lint warning about undeclared channel module dep

* Fix reflection warning for metabase.server.streaming_response/StreamingResponse

* Fix reflection warning in user-message-with-visualizations-test

* Use :on-complete handler to capture lines in make-ai-request

* Make all defs except endpoints and routes private

* Rename client :bot-token to :token

Currently only used for endpoints that expect a bot token, but in principal these could be used for other endpoints
that might expect, e.g. an app config token to update the app manifest.

* fix builds

* throw down a basic settings ui page

* validate slack bot token

* fix failing verification step

* refine sso flow, update temp admin form to collect info we need

* ensure slackbot is only enabled if setup is complete

* add instructions to add bot image

* Re-enable user-not-linked-sends-auth-message-test

This deftest got accidentally slurped into the preceding one in 07eb42c76f4. Extract it back out into the toplevel.

* Fix kondo whitespace lint

* temp staging deploy fix?

* BOT-853 Add malli schemas to slackbot defendpoints

* Ensure site-url is configured and fix failing test

* Add reminder to set MB_SLACK_CONNECT_ENABLED

* make image rendering larger

* Ensure :test-users are initialized in slackbot tests

* Fix busted tests due to missing site-url

Site-url needs to be added to with-slackbot-setup and do-with-setup-override since I added site-url to
metabase-enterprise.metabot-v3.api.slackbot/setup-complete?

These tests passed when run from the REPL because I had site-url configured locally, but failed when run from the cli.

* make setup instructions clearer

* clean up dev comment form

* BOT-852 Add malli schemas for slack event types

* improve auth flow

* oops

* Rename SlackHandledMessageEvent to SlackKnownMessageEvent

And fix the order of types in SlackKnownMessageEvent

* improve settings page

* WIP csv uploads

* tweaks

* tweaks

* fixes & cleanups

* Ad-hoc querying for slackbot (#69315)

* basic ad-hoc query support

* fix capabilities

* cleanup + another test

* more test fixes

* fix some kondo

* move middleware auth tests to a new EE namespace

* minor fixes

* fix tests

* remove unneeded transforms capability

* remove some debug code

* [Metabot] Slackbot channel support (#69391)

* channel support

* ignore edited messages

* add tests

* lint fix

* lint fix

* pr feedback

* test fix

* skip channel messages

* default enable slack sso

* Fix failing metabase.core.modules-test/module-uses-should-be-sorted-test

* Require user to be active in slack-id->user-id

* metabot/slackbot - Adjust CSV upload support (#69832)

* init

* remove debug def

* BOT-984 Add slack channel support to create-dashboard-subscription tool (#69371)

* Add slack channel support to create-dashboard-subscription tool

* Fix render-html-to-png

We recently added a new 3-arg arity, but were only passing along the :content of the ::body/RenderedPartCard rather
than the full map, resulting in a malli schema error due to dropping the required :attachments key for any callers of
the 2-arg arity, e.g. when trying to send a slack notification.

    clojure.lang.ExceptionInfo: Invalid input: {:attachments ["missing required key, got: nil"]}
	at metabase.channel.render.png$fn__107479$fn__107505.invoke(png.clj:124)
	at metabase.channel.render.png$fn__107479$render_html_to_png107478__107482.invoke(png.clj:128)
	at metabase.channel.render.png$fn__107479$fn__107505.invoke(png.clj:124)
	at metabase.channel.render.card$fn__108322$png_from_render_info108321__108323.invoke(card.clj:302)
	at metabase.channel.render.card$fn__108322$fn__108325.invoke(card.clj:298)
	at metabase.channel.impl.slack$part__GT_sections_BANG_.invokeStatic(slack.clj:117)
	at metabase.channel.impl.slack$part__GT_sections_BANG_.invoke(slack.clj:87)

* Add find-cached-slack-channel-or-username

* Validate slack-channel in create-dashboard-subscription

Serves the dual purpose of making sure the channel exists and also normalizing the name to the display-name with
leading # which is how channels selected in the UI are stored.

* Drop support for email subscriptions

Since this is only going to be used from the slackbot profile, we'll only support sending subscriptions to slack
channels for now.

* handle-agent-error in create-dashboard-subscription

* Add create-pulse-with-perm-checks! and call that from create-dashboard-subscription tool

To ensure the same permission checks and other logic is used as when creating a pulse from the UI or API.

* Do no export pulse.models.create-pulse! from pulse.core

The only consumer was metabot's create-dashboard-subscription which now calls create-pulse-with-perm-checks! instead.

* BOT-985 Add create-alert metabot tool for slackbot (#69533)

* Add create-alert metabot tool

To allow the agent to create alerts for a given card on a given schedule, similar to the existing
create-dashboard-subscription tool.

* Add notification.api/create-notification! and call it from metabot_v3.tools/create-alert

This ensures that create-alert does the same perms checks and send the same verification email and notifications as
the main api endpoint.

* Improve ::create-alert-arguments malli schema

Use :multi with :dispatch on :channel_type to make it clear that email is required when :channel_type is "email" and
likewise :slack_channel is required when :channel_type is "slack"

* Destructure email in create-alert args

* handle-agent-error in create-alert

* Drop support for email subscriptions

Since this is only going to be used from the slackbot profile, we'll only support sending subscriptions to slack
channels for now.

* Add api test for create-alert metabot tool endpoint

* Fix bad conflict resolution from rebase

* BOT-1026 Pass slack-channel-id in the ai-service request context (#69828)

* BOT-1026 Pass slack-channel-id in the ai-service request context

For ai-service requests originating from slackbot, send along the slack channel id. The ai-service tools will also be
updated to use this channel id when creating dashboard subscriptions or alerts.

* Add make-ai-request-args-test

* Slackbot table output format (#69511)

* WIP - table ouptut for Slack metabot

* lint

* WIP support for pre-fetched data

* WIP

* lint

* add slack-connect-enabled to do-with-other-sso-types-disabled

* fix another test

* change slack-connect-enabled default to false

* simplify approach

* Misc fixups

* more cleanup

* fix another test

* small readability improvements

* Move some of the table data preparation stuff to a new namespace to share with  existing slack/email rendering code

* fix modules lint

* extract table-block components and include in thread history

* revert query results changes (for now) and just drive slack table formatting via viz type selection

* truncation message

* truncation message test case

* rollback more execute-query stuff

* fix build

* temporarily comment out extract-table-blocks stuff

* fix test

* Merge slackbots and settings pages (#69782)

* wip

* more progress

* conslidate manifest endpoints

* remove slack-token

* handle missing scopes case

* respect slackbot feature toggle in event handler

* other-sso-enabled? now takes into account sso mode

* new slack app-info endpoint for getting helpful metadata for the connected slack app, update links on FE to more direct location in slack

* replaced "metabot-slack-bot-enabled" with "slack-connect-enabled"

* misc. small fixes

* move slack scopes endpoint to app-info endpoint, update copy, misc ui improvements

* fix slack events api endpoint to still ack events if metabot later becomes disabled

* first step now configured to show obscured token, remove old modal component that was unused

* improve app icon section

* small design pass and linkage improvement to step 3

* new settings endpoint for metabot slackbot settings, updated FE component and form validation

* improve slack bug channel input, also update api endpoint so that slack setting values can be set seperately

* obfuscate client secret and signing secret

* improve the webhooks page a bit

* inline save / delete btuton for slack oauth token input

* allow removing metabot related slack settings in the ui

* self-review

* fix kondo

* fix some be tests

* test fixes, link fixes, page reorg

* poll for updates

* fix some e2e tests

* show info button w/ bot token info on hover

* updated profile image for slackbot

* fix be tests

* fix unit tests

* fix be test

* add unit test converage for base setup

* remove SlackSettingsPage which had duplicate tests

* add test coverage for settings endpoint

* new settings ui tests

* remove todo comment

* set default icon / name for slackbot

* make slack-get match slack-post response format

* show api errors better in slack metabot form

* impl set-many feedback

* fix requiring resolve code smell

* log error based on feedback

* handle error for app-info

* Slackbot streaming (#69947)

* [wip] Slackbot streaming

* simplify, lint

* Fix tests

* Use a volatile

* fix tests

* refactors, cleanup

* more cleanup

* fix tool name

* Better stream-related error handling + tests

* add another test

* properly destructure api calls for streaming / auth

* fix streaming not having icon_url set and make sure that channel level @mentions has the bot reply with auth request at channel level too

* embarrassing

* Rework + simplify streaming using an agent to try to reduce burstiness

* prevent tests from clearing out setting values

* Add a thinking... placeholder before stream starts +  do initial Slack requests in futures

* rip out overrides, streaming api reverts the defaults so it flashes images if they differ from the one saved for the slack app

* [Slackbot] Render unsupported static viz as tables (#70077)

render unsupported static viz as tables

* Slackbot test refactor + fix overwriting encrypted settings (#70113)

* Fix encryption overwriting in tests; small cleanup

* more refactor

* [Slackbot] Modularize (#70130)

modularize

* [Slackbot] Adds check to prevent replay attacks (#70081)

* prevent relay attack

* fix syntax issue

* pr feedback

* lint fix

* [Slackbot] Prevent channel response (#70136)

* add more tests, refactor

* bit more clean up

* ignore channel messages without @mention

* simplify, fix tests

* add file mock to tests

* move bot id fetch

* Migrate slack-connect SSO to dedicated /auth/sso/slack-connect URL pattern

Move slack-connect from the old unified /auth/sso multimethod dispatch to
dedicated GET /auth/sso/slack-connect and GET /auth/sso/slack-connect/callback
endpoints, aligning with the pattern used by custom OIDC providers.

* fix oauth flow requiring user page refresh

* kick ci

* fix threading for auth message in dms

* Report QP errors to Slack, and run queries off the main thread (#70124)

* WIP - surface QP errors, don't block queries on text stream

* simplifications

* fix up a couple other tests that were corrupting values

* try to fix test

* cleanup

* more cleanup

* more cleanup

* Fix test

* small simplification

* more fixes

* timeouts

* simplify comment

* call shutdown-agents at the end of the core shutdown routine

* [Slackbot] Stable conversation ids (#70281)

* make convo ids stable for slack conversations

* fix lint

* fix missing paren

* Update enterprise/backend/test/metabase_enterprise/metabot_v3/api/slackbot_test.clj

Co-authored-by: appleby <86076+appleby@users.noreply.github.com>

---------

Co-authored-by: appleby <86076+appleby@users.noreply.github.com>

* fixup! set a proper response code in safari

* Slack SSO info logs in initiate & callback endpoints

* make slack user look up deterministic

* log actual oidc cookie

* [Slackbot] Better static viz sizing (#70288)

* make slack user look up deterministic

* calc size of static viz based on display type

* fix doc string

* fix tests, add sankey support

* fix lint

* make metabot self-aware... of @mentions

* add some truncation logic for slack blocks + long cell values

* Improved titles for slackbot visualizations; misc other fixes (#70396)

* support context text for results

* viz captions with links; hold viz results until stream finishes

* tests; remove separate caption & description fields

* grab bag of fixes

* strip out user mention stuff from this branch

* caption->title

* fix build

* fix test

* polish

* some escaping logic for markdown links

* fix filename

* Slackbot feedback buttons (#70280)

* WIP slack feedback buttons

* wire up feedback buttons

* tests

* feedback modal

* revert back to a single hm call

* fix parens

* revert an unexpected change

* small fixes

* fix tests

* tweaks

* fix rebase

* Update enterprise/backend/src/metabase_enterprise/metabot_v3/api/slackbot/streaming.clj

* fix rebase

* [Slackbot] Enrich chat history (#70408)

* poc

* move code around

* fix tests, clean up logs

* clean up

* fix

* automated review feedback

* do not store messages on error

* test coverage

* lint fix

* Ensure we respect slack api rate limits (#70409)

* try to respect slack streaming rate limits

* tests

* simplify

* lint

* try to fix tests, some tweaks

* bump ci

* [Slackbot] Better auth messages (#70465)

* improve auth message responses

* better auth messages

* pr feedback

* Split slackbot DM and channel response paths, embed viz in message (#70531)

* Viz delivery refactor for slackbot

* simplify

* more refactor

* more test porting

* Update enterprise/backend/src/metabase_enterprise/metabot_v3/api/slackbot/channel.clj

* condense some code

* fix tests

* fix stale session bug

* Slackbot message deletion (#70533)

* Slackbot message deletion

* Tests

* Fix tests

* minor cleanup

* add user_id to metabot_message to drive deletion permissions

* balence parens

* fix parens

* feedback

* fix failing migration tests

---------

Co-authored-by: Sloan Sparger <sloansparger@gmail.com>

* Fix slackbot feedback acknowledgement (#70642)

* fix slackbot feedback acknowledgement

* simplify docstring

* remove feedback acknowledgement entirely

* Add slackbot prometheus metrics (#70654)

* add slackbot prometheus metrics

* simplify

* lint

* remove todo comment

* [Slackbot] Cleanup (#70692)

* move migrations to v60 file

* clean up auth debug logging

* move slackbot into its own module and split up the core test file

* fix whitespace lint

* [Slackbot] Fancy (#70729)

* mostly working w/o proper saving of messages

* backfill slack_msg_id

* Minor tweaks: swap volatiles for atoms, switch away from deprecated StringBufferInputStream

* address libor's comments

* fix tests - wrap async functions with bound-fn*

* oops, fix last test

* fix reflection issue

* whitespace chagne to kick new jar build

* update subscription tool + tests

* fix .clj-kondo/config/modules/config.edn resolution and related failing tests

* [Slackbot] Port ai service (#71026)

* main port

* port https://github.com/metabase/ai-service/pull/626/changes

* clean up

* kondo fix

---------

Co-authored-by: Mike Appleby <86076+appleby@users.noreply.github.com>
Co-authored-by: Tyler Plude <tsplude@gmail.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Edward Paget <edpaget@users.noreply.github.com>
Co-authored-by: Edward Paget <ed.paget@gmail.com>
2026-03-17 23:23:40 +00:00
Riley Thompson
47ff6b70a6 Pin google auth dependency to avoid driver mismatches (#70958)
* pin dep

* trigger ci tests

* update test
2026-03-17 20:59:53 +00:00
Nathan Voxland
7ab0784977 ReproBot Improvements (#70990) 2026-03-17 15:57:47 -05:00
Jeff Bruemmer
e8bc1db487 docs - remote sync providers (#70969) 2026-03-17 16:16:15 -04:00
Uladzimir Havenchyk
527a4d67e9 chore: upgrade underscore (#70778) 2026-03-17 22:58:29 +03:00
Nick Fitzpatrick
b0deebf2b6 Clear ChartSettingSelect display value on remove (#70957) 2026-03-17 15:57:55 -04:00
appleby
09d9a4a446 BOT-1131 Rename :snake_case keys to :kebab-case in metabot stats (#71027) 2026-03-17 19:55:33 +00:00
Fraser
08b84f4b16 Lift data_grid.js up to shared (#70755)
* Lift data_grid.js up to shared

     data_grid.js is in lib/lib but imports makeCellBackgroundGetter from table_format in shared/visualizations, causing a lib/lib → shared/visualizations boundary violation. data_grid.js is not used by
     anything in lib — all consumers are in shared/visualizations, feature/dashboard, and visualizer. table_format already lives in shared/visualizations and only depends on basic/ui colors.
2026-03-18 08:33:39 +13:00
Fraser
829b34e44a Remove metadata re export from reference (#70561) 2026-03-18 08:32:01 +13:00
Nathan Voxland
5d6c208865 Improve search endpoint performance with many disabled tables (#70982) 2026-03-17 13:09:19 -05:00
Jeff Bruemmer
6d37120fb9 docs - Fix typo in JWT group mapping documentation (#71017)
Fix typo in JWT group mapping documentation
2026-03-17 11:52:02 -04:00
Sébastien
2390c28119 Fixed metrics not being translated in guest embeds (#70484) 2026-03-17 16:44:59 +01:00
Cam Saul
5217327fb9 Fix running app DB with MariaDB 10.6 official image in CI (#70824)
* Fix running app DB with MariaDB 10.6 official image

* Update all MariaDB configs

* Use custom Docker image 🔧

* Loosen dependence on quoting format of mysql/mariadb error messages

* Use tz aliases supported in mariadb 12

* Run tests in series. Use fresh H2 DB.

---------

Co-authored-by: Ben Grabow <ben.grabow@metabase.com>
2026-03-17 14:52:37 +00:00
Chris Truter
b215b0ff3d Fix mage mise-diagnosis (#71012) 2026-03-17 14:34:13 +00:00
Mihael Konjević
9796110af3 Ai service port (#68463)
* Experiment with communicating with LLMs in Clojure

* Libor comments

* switch to new openai /v1/responses api, check for structured output support

* support for claude to show how different adapters are

* linter fixes

* Implement native Clojure agent for MetaBot v3

This commit implements a production-ready native Clojure agent loop that
replaces the external Python AI Service with an in-process implementation,
leveraging the existing llm-inside streaming infrastructure.

Key Components:
- agent/core.clj: Main agent loop with iteration control and streaming
- agent/memory.clj: Conversation state and step tracking
- agent/messages.clj: Message formatting and LLM communication
- agent/profiles.clj: Profile configurations (embedding, internal, transforms)
- agent/tools.clj: Tool registry with 13 wrapped tools

Integration:
- api.clj: Feature-flagged routing via use-native-agent setting
- settings.clj: New use-native-agent boolean setting (default: false)

Benefits:
- Direct Toucan2 database access (no HTTP round-trips)
- Single JVM process deployment
- Lower latency for tool execution
- Unified logging and error handling
- Reuses 80%+ of existing streaming infrastructure

Test Coverage:
- 5 test files with comprehensive coverage
- All tests passing (133 total assertions)
- Unit tests for memory, messages, profiles, tools
- Integration tests for agent loop with mocked LLM

The implementation is production-ready and can be enabled via feature flag
for gradual rollout and validation against the Python service.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Integrate Phase 2A: Prompts & Context System into agent loop

This commit completes Phase 2A of the native Clojure agent implementation,
integrating the templated prompt system with context enrichment into the
main agent execution loop.

## New Features

### Prompt System (prompts.clj)
- Selmer template loading with caching
- SQL dialect instruction injection (14 dialects supported)
- Tool instruction extraction from docstrings
- System message template rendering with context variables

### Context Enrichment (user_context.clj)
- Timezone-aware time formatting
- SQL dialect extraction from context
- Viewing context formatting for all types:
  - Adhoc queries (notebook editor)
  - Native SQL queries with error context
  - Transforms with source information
  - Code editor with buffer/cursor/selection details
  - Entity details (tables, models, questions, metrics, dashboards)
- Recent views formatting with relevance hints
- Full context enrichment pipeline for template variable injection

### Resource Files
- 3 system prompt templates (embedding, internal, transform-codegen)
- 14 SQL dialect instruction files
- All templates support dynamic context injection

## Integration Changes

### Agent Core (core.clj)
- Updated build-messages-for-llm to accept context, profile, and tools
- Integrated system message building with enriched context
- Fixed pre-existing async blocking issue in run-llm-with-tools
  (changed from blocking a/<!! to returning channel for non-blocking a/<!)
- Agent now builds fresh system messages with context on each iteration

### Messages (messages.clj)
- Updated build-system-message to use templated prompts
- Accepts context, profile, and tools parameters
- Calls prompts/build-system-message-content for rendering

### Profiles (profiles.clj)
- Added :prompt-template mapping to all three profiles
- Maps profile IDs to template files in resources/metabot/prompts/system/

## Tests

All Phase 2A functionality is comprehensively tested:
- prompts-test: 6 tests, 46 assertions ✅
- user-context-test: 5 tests, 81 assertions ✅
- messages-test: 3 tests, 47 assertions ✅
- profiles-test: 1 test, 36 assertions ✅

Total: 15 tests, 210 assertions passing

Note: core-test integration tests have pre-existing failures due to blocking
calls in self/core.clj tool-executor-rff (line 116), which existed before
this change. The async pipeline architecture issue is tracked separately.

## Architecture

The agent now follows this flow on each iteration:
1. Enrich raw context (user_context/enrich-context-for-template)
2. Load and render system prompt template (prompts/build-system-message-content)
3. Build full message array with system message + history
4. Execute LLM call with enriched context
5. Process tool calls and responses
6. Repeat until completion

This matches the Python implementation's prompt and context system while
leveraging Clojure's functional architecture.

* Add Selmer dependency for template rendering

Selmer v1.12.70 provides Jinja-like templating for Clojure,
used by the Phase 2A prompts system for rendering system messages
with dynamic context variables.

* Fix async blocking issue in agent loop by using pipeline-blocking

The tool-executor-rff reducing function blocks in its completion arity
to wait for tool results. Using a/pipeline causes 'Invalid blocking call
in dispatch thread' errors because the regular pipeline uses a fixed
thread pool that doesn't allow blocking.

Solution: Use a/pipeline-blocking instead, which uses a separate thread
pool designed for blocking operations. This allows the tool executor's
completion arity to safely block while waiting for tool results.

Fixes the core-test integration test failures.

* Implement Phase 2B: SQL Query Tools

Add four SQL query manipulation tools to enable the agent to create, edit,
and search SQL queries:

New Tools:
- create_sql_query: Create new SQL queries with validation
- edit_sql_query: Apply structured edits (replace, append, insert, etc.)
- replace_sql_query: Replace SQL content entirely while preserving metadata
- sql_search: Search for SQL queries by content with relevance ranking

Features:
- Direct Toucan2 Card model access (no HTTP round-trips)
- Database and permissions validation
- Structured edit operations (replace, replace-all, append, prepend, insert-after, insert-before)
- Search with ranking by name match, description match, SQL position, and recency
- Integration with existing agent tool registry
- Added to metabot-internal profile and new metabot-sql-only profile

Testing:
- Comprehensive test coverage for all SQL tools
- Integration tests for full workflow (create → edit → search)
- All tests passing (18 assertions, 0 failures)

Architecture:
- Follows existing tool pattern (mu/defn with Malli schemas)
- Returns structured output for agent state tracking
- Error handling with agent-error? flag for LLM-friendly messages

Phase 2B complete. Ready for Phase 2C: Visualization Tools.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Fix SQL tools to handle lib/query format

Fixed multiple issues with SQL tools not handling the transformed
lib/query format when Card models are read from the database:

## Issues Fixed

1. **extract-sql-content not finding SQL**: Card dataset_query transforms
   from {:native {:query "SQL"}} to {:stages [{:native "SQL"}]} when read.
   Updated extract-sql-content in all SQL tools to handle both formats.

2. **OffsetDateTime vs Date**: The rank-result function in sql_search
   called .getTime on timestamps, but Toucan2 returns OffsetDateTime.
   Added instanceof check to convert appropriately.

3. **Missing visualization_settings**: Test code using t2/insert! needed
   :visualization_settings {} field (database constraint).

4. **Test permissions**: Wrapped all test code with mt/with-current-user
   to provide proper permission context.

5. **Fixed typo in sql_search**: Changed accessible-cards variable reference
   from undefined to all-cards.

## Files Changed

- edit_sql_query.clj: Handle both lib/query and legacy formats
- replace_sql_query.clj: Handle both lib/query and legacy formats
- sql_search.clj: Handle both formats + OffsetDateTime conversion
- sql_tools_test.clj: Add visualization_settings, fix permissions,
  add clojure.string alias, fix indentation

## Test Results

All 19 assertions passing (4 test functions):
- edit-sql-query-test: 4 edit types tested
- replace-sql-query-test: Replace with metadata preservation
- sql-search-test: Search, filter by database, limit parameter
- integration-create-edit-search-test: Full workflow

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Add read_resource tool for fetching Metabase resources via URIs

Implement the foundational read_resource tool that provides unified
interface for fetching detailed information about Metabase resources
using URI patterns. This tool implements the "Context Engineering with
Links" pattern where URIs serve as lightweight, token-efficient
references that can be fetched on-demand at the appropriate detail level.

Supported URI patterns:
- metabase://table/{id} - Basic table info
- metabase://table/{id}/fields - Table structure with fields
- metabase://table/{id}/fields/{field_id} - Specific field details
- metabase://model/{id}/fields - Model structure with fields
- metabase://metric/{id}/dimensions - Metric dimensions
- metabase://transform/{id} - Transform details (not yet implemented)
- metabase://dashboard/{id} - Dashboard details (not yet implemented)

Key features:
- Parses metabase:// URIs and routes to appropriate handlers
- Supports fetching multiple resources in parallel (max 5)
- Handles field IDs with slashes (e.g., c75/17)
- Returns formatted XML-like output for LLM consumption
- Provides detailed error messages for invalid URIs

This tool is critical for:
- Enabling agents to get more context about resources on demand
- Supporting workflows where search returns URIs that agents fetch later
- Reducing token usage by deferring detail fetching until needed

Changes:
- Created read_resource.clj with URI parsing and resource handlers
- Added read-resource-tool wrapper in tools.clj with Malli schema
- Updated all 4 profiles to include read_resource tool
- Added comprehensive tests for URI parsing and resource fetching

Tests: 24 assertions, 0 failures

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Implement Phase 2C chart tools, 2F profiles, and fix async blocking

Phase 2C - Chart Tools:
- Add create_chart tool to create visualizations from queries
- Add edit_chart tool to modify existing chart types
- Register chart tools in agent tools registry

Phase 2F - Profiles & Templates:
- Port sql-querying-only.selmer from Jinja2 (fixes broken :metabot-sql-only)
- Port metabot-next.selmer template
- Port natural-language-querying-only.selmer template
- Add :metabot-next, :metabot-nlq-only, :metabot-beta-customer profiles

Async Blocking Fix:
- Use a/thread instead of a/pipeline-blocking in run-llm-with-tools
- tool-executor-rff uses a/<!! in completion arity which cannot run in go-blocks
- Synchronous transducer application in thread context is now aligned with self code
- Fix stream-parts-to-output! and finalize-stream! to use a/>! in go blocks
- Fix api.clj syntax error with metadata on string literal
- Update tests to generate proper Claude raw SSE format

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add AI SDK v4 line protocol output format for native agent

The Python ai-service outputs a specific line protocol format that the
frontend expects. This adds the conversion layer to output the same format
from the native Clojure agent.

Format examples:
- 0:"text content"  - Text (JSON-encoded string)
- 2:{"type":...}    - Data parts
- 3:"error"         - Errors
- 9:{"toolCallId":..., "toolName":..., "args":...}  - Tool calls
- a:{"toolCallId":..., "result":...}  - Tool results
- d:{"finishReason":"stop", "usage":{...}}  - Finish message
- f:{"messageId":...}  - Start message

Changes:
- Add format-* functions for each part type in self/core.clj
- Add aisdk-line-xf transducer for batch conversion
- Export new functions via self.clj
- Update api.clj to stream parts in line protocol format
- Add comprehensive tests for all format functions

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Fix native agent loop for multi-turn conversations with tools

Key fixes:
- Fix premature loop exit: Continue when tool calls present, regardless of text
- Fix Claude API integration: Extract system message separately, pass via :system param
- Fix tool name mismatch: Pass tools as [name, var] pairs so Claude sees registry keys
- Fix message format for tool_use: Use content array format for assistant messages
- Handle START_STEP/FINISH_STEP types in aisdk->messages
- Rename profiles to simpler keys (:embedding, :internal, etc.)
- Add /native-agent-streaming endpoint for testing (bypasses feature flag)
- Add debug logging for message building

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add state management for query/chart IDs in native agent tools

State-dependent tools (show_results_to_user, create_chart, edit_chart) now
look up queries and charts from agent memory by ID instead of expecting raw
query objects. This mirrors the Python AI service pattern.

Key changes:
- memory.clj: Add query/chart storage functions (remember-query, find-query,
  store-chart, find-chart, load-queries-from-state, load-charts-from-state)
- core.clj: Extract queries/charts from tool outputs and store in memory
- tools.clj: Wrap state-dependent tools with memory atom access
- claude.clj: Update schema to accept wrapped tool maps with :fn/:doc/:schema
- self/core.clj: Handle wrapped tool maps in tool-executor-rff
- show_results_to_user.clj: Accept query-id and look up from queries-state

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add metabase:// link resolution for native agent streaming

The native agent now resolves metabase:// URIs in text parts before
streaming to clients. This mirrors the Python AI service's
MarkdownLinkBuffer behavior.

Link types supported:
- metabase://query/{uuid} - Resolves to /question# using stored query
- metabase://chart/{uuid} - Resolves to /question# via chart's query
- metabase://model/{id} - Resolves to /model/{id}
- metabase://metric/{id} - Resolves to /metric/{id}
- metabase://dashboard/{id} - Resolves to /dashboard/{id}
- metabase://question/{id} - Resolves to /question/{id}
- metabase://transform/{id} - Resolves to /admin/transforms/{id}

Changes:
- links.clj: New module for link resolution with markdown parsing
- core.clj: Integrate link processing in stream-parts-to-output!
- Tests for link resolution and streaming integration

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Fix tool result formatting for LLM and link resolution

Key changes:
- Format tool results as XML for LLM consumption (messages.clj)
  - Query results now show query ID clearly: <query id="..." type="query">
  - Chart results include chart ID and reference link
  - This matches Python ai-service format so LLM can extract IDs properly

- Add fallback for chart link resolution (links.clj)
  - When LLM uses metabase://chart/ with a query ID, fall back to
    treating it as a query link
  - Handles common LLM mistake of using wrong link type

- Fix chart extraction logic (core.clj)
  - Charts identified by :chart-id + :query-id (without :query)
  - Distinguishes charts from query results correctly

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add InstructionResultSchema pattern for native agent tool outputs

Align Clojure native agent tool outputs with Python AI Service patterns
by wrapping results in <result>/<instructions> XML format for consistent
LLM guidance.

- Add llm_representations.clj with entity-to-XML formatting utilities
- Add instructions.clj with LLM guidance constants for each tool type
- Update messages.clj to use format-with-instructions wrapper
- Add type-specific formatters for search, entity, query, chart results
- Include comprehensive tests for LLM representation functions

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Align Clojure LLM representations exactly with Python AI Service

Updates tool output formatting to match Python AI Service patterns exactly:

- field->xml: Add quotes around name, database_type attr, ## Description header
- metric->xml: Add collection, default_time_dimension_field, metabase:// URIs
- table->xml: Add database_engine, fully_qualified_name, related_tables section
- model->xml: Use <metabase-model> tag, slug-based fqn, related_tables
- query->xml: Include database_id, query-content, query_results with rows
- Add question->xml, dashboard->xml, collection->xml, user->xml formats
- Add visualization->xml for full chart representation
- Add field-metadata->xml, get-metadata-result->xml for metadata results
- Update search result tags: model→metabase-model, card→metabase_question
- Update instructions.clj with complete Python-matching guidance text
- Update messages.clj to use <metabase-models> tag
- Expand tests to verify Python format compatibility

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add auto-navigation and fix tool output handling for native agent

- Add redirect reactions to SQL query tools (create, edit, replace) for
  auto-navigation after query operations
- Add streaming module to convert reactions to AI SDK data parts
- Fix structured output extraction to handle both :structured-output and
  :structured_output key formats (Clojure vs JSON style)
- Add role normalization in message formatting to handle both keyword
  and string roles from frontend
- Include :query key in SQL tool returns for memory storage

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Implement AI Service parity for native Clojure agent

This commit adds feature parity between the Clojure native agent and
Python AI service, implementing all phases from the parity plan.

New Tools:
- todo_write / todo_read: Task management with todo_list data parts
- navigate_user: Page and entity navigation with redirect reactions
- ask_for_sql_clarification: SQL clarification with final-response flag
- write_transform_sql / write_transform_python: Transform code editing
- create_autogenerated_dashboard: X-ray dashboard generation
- list_snippets / get_snippet_details: SQL snippet access

Core Changes:
- State data part format: {type: data, data-type: "state", version: 1}
- Finish message format: {type: finish, finish-reason: "stop"|"error"}
- New data part types: todo_list, code_edit, transform_suggestion
- Data part streaming from tool results via :data-parts key
- Final response pattern: tools return :final-response? true to stop loop
- Capability-based tool filtering with tool-capabilities map

Profile Updates:
- internal: Added navigate_user, create_autogenerated_dashboard
- transforms-codegen: Added todo tools, transform write tools, snippets
- sql-only: Added ask_for_sql_clarification, :required-tool-call? flag
- nlq-only: Added navigate_user, create_chart, edit_chart

Tests:
- Comprehensive tests for all new tools (29 new tests, 200+ assertions)
- Updated existing tests for new formats and capabilities

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add streaming link buffer and improve AI service compatibility

Key changes:
- Add markdown_link_buffer.clj for handling links split across streaming
  text chunks (matches Python AI Service MarkdownLinkBuffer behavior)
- Seed agent state with queries from user_is_viewing context
- Support both snake_case and kebab-case keys in context for prompts
- Normalize entity types (keyword/string) in message formatting
- Decode tool arguments from JSON strings when needed
- Add table link resolution (metabase://table/{id})
- Preserve system-instructions when wrapping state-dependent tools
- Fix iteration boundary check (use inc iteration for comparison)
- Gracefully handle unresolvable links by falling back to link text

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Refactor SQL tools to use in-memory state and data parts

Key changes:
- SQL tools (edit_sql_query, replace_sql_query) now operate on in-memory
  query state instead of persisting to database
- Convert tools from reactions to data-parts pattern (navigate_to)
- Add semantic_queries and keyword_queries to search tool schema
- Make edit_sql_query and replace_sql_query state-dependent tools
- Support string query IDs (in addition to int) for memory-based queries
- Extract SQL dialect only from native query context type
- Use streaming.navigate-to-part instead of direct reactions
- Add instructions pattern to SQL tools for better LLM guidance

This aligns the SQL tools with the AI Service's transient query model
where queries exist in conversation state until explicitly saved.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Cleanup

* AI Service cleanup

* Refactor metabot tool registration

* Render LLM representations with Selmer

* Refactor tool result formatting

* define caps by metadata

* Refactor metabot v3 tools namespace

* Route agent tools to core implementations

* Simplify metabot tool wrappers

* factor out core.async as much as possible

* Refactor metabot v3 to use IReduceInit reducibles instead of core.async

- Replace channels with IReduceInit (reducible) pattern throughout
- Standard Clojure transducers work directly: (into [] xf (llm-call {...}))
- Remove core.async dependency from self namespace
- Rename chan? -> reducible?, sse-chan -> sse-reducible
- Rename tool-executor-rff -> tool-executor-xf
- Add malli schemas for agent state, messages, parts
- Simplify agent loop using reducible composition
- Update tests to use reducible patterns

* clarify

* ehhh sideeffect

* fix capabilities/nicer profiles

* tools tests

* api tests

* tools tests

* llm-repr test fixes

* fix profiles.clj

* clj-kondo woes

* is this the last test

* damn

* cljfmt

* fix api test

* update path for e2e tests

* little things

* output text fluidly to a user

* update modules config

* cleaning up links code duplication

* cleanup user context templates

* integration test

* cljfmt

* test

* fix read resource output format

* make clj-kondo happier

* simpler tool executor function

* better error messages from metabot backend

* potentially: ability to reload repl state when js is compiled differently

* metabot error messages and tests

* cleanup agent.messages code/tests a bit

* configurable api urls for llms

* use simple templates more

* format tools to string at their definition

* collecting usage and schema on tool

* system prompts

* datadog observability

* fix modules config

* make clj-kondo happy

* fix read_resource

* fix fe formatting

* more prompt changes

* improve search results tool response

* little cleanups and field-metadata with instructions

* sql dialect

* proper context instructions for sql tools

* report tool args well

* tool result should always have 'result' key

* coerce tool args to json

* good filters validation/errors to llm

* fix construct rendering in system prompt

* fix 'SQL Fixing'

* put queries in the context

* proper rendering for query data

* no :system-instructions

* proper capability check

* handle inline llm errors

* ability to debug llm queries

* fixes to improve llm behavior

* unify query formatting

* accept both variations of db id

* debug for python ai-service

* do not escape instructions

* fix claude usage tracking

* python has no header for tool instructions

* instruct llms to use fq table names

* slight prompt rewording to bring it closer to what benchmarks measure

* fancy field select - reduces amount of tool calls needed

* more clear naming

* simpler date filters handling

* retry logic

* great namespace movement

* no more stacktraces on agent errors

* fix token undercounting

* make sure request cancellation works through with native agent streaming

* Replace raw/endraw tags with safe/endsafe

* Fix issues with the sql profile

* openrouter as main provider

* review comments

* fix test for closing connections

* better schema for incoming messages

* fix agent tests

* cumulative usage from agent loop to reduce need for arithmetics

* clj-kondo/cljfmt

* transforms in read_resource tool

* get-dashboard-details

* test fixes

* fix temporal checks

* fix field_stats test

* fix remove-unreadable-transforms

* oh yeah very important type

* fix usage in native streaming

* fix api test formatting

* Get tools back (#69901)

* drop separate url for native agent, only have single url with a toggle

* fix error message in custom-elements e2e

* prompt generation (#69970)

* feat: documents content generation for clojure metabot (#69807)

* llm model select (#70061)

* BOT-866 Add prometheus metrics to metabot clojure agent part II (#70094)

* BOT-866 Add prometheus metrics to metabot clojure agent

* BOT-866 Also count inline aisdk errors

* BOT-866 push prometheus token counting down into call-llm

This is more in keeping with how current ai-service reports the metric, i.e. per llm call rather than a single batched
token usage per agent request.

This also has the advantage of keeping most prometheus metrics localized to the llm layer.

* Ensure that :metabase-metabot/llm-requests counts retries

This is more consistent with the existing ai-service llm_invocations_total metric

* Make :metabase-metabot/llm-duration-ms per llm invocation rather than cumulative

This more closely matches the existing ai-service llm_duration_ms metric

* Add :metabase-metabot/agent-duration-ms prometheus metric

Records the full duration of the outer agent loop, now that :metabase-metabot/llm-duration-ms records individual llm calls.

* Add comment on :metabase-metabot/llm-duration-ms buckets

And extend the low end of the range down to 100ms

* fixup! Add :metabase-metabot/agent-duration-ms prometheus metric

* Fix whitespace

* Add prometheus metrics tracking to call-llm-structured

* Allow llm callers to specificy the source label for prometheus metrics

And pass "example-question-generation" for question generation.

* Fix call-llm-prometheus-test

After rebasing on #70061 these tests need to include the "openrouter/" provider prefix along with the model.

* BOT-1051 Fix provider in generate-example-questions (#70121)

After #70061 call-llm-structured now expects the model to include a
provider prefix, so "anthropic/claude-haiku-4-5" was getting parsed as
:provider "anthropic" :model "claude-haiku-4-5".

Update metabase-enterprise.metabot-v3.example-question-generator/call-llm to
use the provider + model configured via llm/ee-ai-metabot-provider

* BOT-1039 Add snowplow token_usage event tracking to the clojure agent (#70049)

* BOT-1039 Include the profile :name in the profile map in register-profile!

Sometimes it's useful to be able to exract the profile name when you only
have a reference to the profile.

* Add token_usage snowplow event tracking to the clojure agent

- refactor register-profile! to single-arg form with :name now stored in the profile map and returned by get-profile
- report-token-usage-xf now emits a :snowplow/token_usage event per LLM call alongside existing prometheus metrics
- pass tracking-opts from loop-step through call-llm into the token-usage transducer
- likewise for callers of call-llm-structured
- init-agent generates a per-run request-id UUID
- run-agent-loop accepts an optional conversation-id that turns into the snowplow token_usage session_id

* Add :model to tracking-opts and drop separate source arg

The prometheus source label should always be the same as the snowplow :tag (that's how it works in ai-service), so
drop the separate `source` arg from various functions and just take the source label from the tracking-opts :tag.

* Destructure token-opts in report-token-usage-xf

* Allow passing tracking-opts to run-agent-loop

And use this to override the :source in metabot-v3.api.document/native-generate-content

* Improve docstring for tracking-opts

* Provide model and source defaults in report-aisdk-errors-xf

* Fallback to analytics-uuid if premium-embedding-token is unset

* Fix typo: snowplot -> snowplow

* Compute hashed-token-or-uuid once rather than for each usage part in report-token-usage-xf

* BOT-1039 Move token-usage funcs into analytics module (#70213)

* BOT-1052 Move token-usage funcs into analytics module

So they can be shared between oss sql gen and metabot.

* Add some snowplot tests for self/call-llm and call-llm-structured

* Add prometheus tests for call-llm-structured

* Add basic snowplow and prometheus tests for example question generation

* Modify agent loop snowplot test to use with-fake-snowplow-collector

* Modify native-generate-content-snowplow-test to use with-fake-snowplow-collector

* Fix whitespace

* fix: context not included in sql profile

* drop unused tool find-outliers (#70424)

* fix: add error field to transforms

* fix: common library not used by agent

* BOT-1053 Add snowplow events for agent tool calls (#70338)

* BOT-1039 Create metabase.analytics.util

And move some func there from metabase.analytics.llm-token-usage that will also be needed for agent_used_tool events.

* Add ai_service_event snowplow schema

In preparation for tracking the following events:

- agent_tool_used
- user_intent
- agent_action_summary

* Track snowplow agent_used_tool events in metabase-enterprise.metabot-v3.self/call-llm

- add agent loop :iteration to tracking-opts
- add :duration-ms to :tool-output parts
- add report-tool-usage-xf to transducer chain in metabase-enterprise.metabot-v3.self/call-llm to track
  :snowplow/ai_service_event with :event "agent_used_tool"

* BOT-1054 Add snowplow events for user intent classification (#70351)

* BOT-1054 Add snowplow events for user intent classification

* Move run-agent-loop :conversation-id into :tracking-opts :session-id

It does make some sense as a top-level argument, but it's currently only used for snowplow tracking, so push it down
into the tracking-opts.

* Move run-agent-loop :track-user-intent? into :tracking-opts

* Add ee-ai-metabot-provider-lite defsetting and use it in classify-user-intent!

This allows using a lighter weight model for simple tasks like user intent and/or agent response
classification. Defaults to openrouter/openai/gpt-oss-20b which is the same model used by ai-service for these tasks.

* Add run-agent-loop! test helper to run the agent for side effects

* whitespace: fix alignment

* Extract :tracking-opts schema into an mr/def similar to other agent opts

* Rename :profile-name -> :profile-id in tracking-opts

* use embeddings proxy directly rather than via ai-service (#70419)

* fix modules config

* fix: metabot has no context on the currently open transform (#70506)

* sql profile requires tool call to be forced (#70497)

* fix snowplow test

* revert back renames for ai-service embedding provider to evade migration (#70649)

* Add ai-service-port to branches list in uberjar.yml

* BOT-1085 Allow user-intent classification to be disabled (#70521)

Add a new ee-ai-metabot-internal-tasks-enabled? setting to allow disabling metabot internal "bookkeeping" tasks that might make additional llm calls, like user intent classification.

* Fix incorrect docstrings and copy-paste errors in settings and tools (#70793)

* Ai service port  validate sql (#70259)

* metabot-v3.tools.util/validate-sql stub

* Add query to dialect mapping

* Hook validation into tools code

* Add validation error instruction

* query-by-id helper

* Move sql validation to agent/tools/sql.clj

* WIP convert edit-sql-query-tool

* Revert edit-sql-query tool

* Drop validation code from tools/util.clj

* Add tools/sql_validation.clj

* Use sql-validation in tools/create_sql_query.clj

* Use sql-validation in agent.tools.sql/create-sql-query-tool

* Add transpile_sql to sql_tools.py

* Add transpile-sql to sql-parsing

* Macaw implementation stub

* Add transpile-sql interface multimethod

* Update transpile_sql in sql_tools.py

* sql-tools/transpile-sql stub

* Add template tag sentinel to sql_tools.py

* sql-tools/transpile-sql schema

* Sqlglot transpile-sql wrapper

* sql-parsing/transpile-sql result normalization

* Hook sql-tools/transpile-sql into metabot-v3.tools.sql-validation/validate-sql

* Adjust create-sql-query-tool to validate-sql changes

* Adjust reason in sql_tools.py

* Add create-sql-query-validation-failure-test

* Addjust validate-sql

* Revert edit-sql-query tool

* Add validation to metabot_v3/tools/edit_sql_query.clj

* Add schema and update returns for create-sql-query

* Add metabot-v3.tools.sql.common

* Update edit_sql_query

* Update edit_sql_query tool

* Add validation failure test for edit-sql-query-tool

* Adjust edit-sql-query-code-edit-tool

* Adjust create-sql-query-code-edit-tool

* Update replace-sql-query and related

* Adjust replace-sql-query-tool

* Update replace-sql-query-code-edit-tool

* Adjsutment for test

* metabot-v3.tools.sql.validation ns

* validate-sql sentinels

* Hoist template tags sentinel into tools.sql.validation

* Update schema

* Validation tests

* Add transpilation tests and adjust sql_tools.py

* Add dialect mapping

* Adjust validation and tests

* Adjust test

* linter

* Cleanup

* Add tests

* Tests and validation

* More tests and cleanup

* Drop redundant tests

* Use original dialect

* Adjust tests

* whitespace

* Remove direct query manipulation from tests

* Remove direct mbql manipulation from create-sql-query

* Remove more of direct query manipulation

* More remarks

* surface openrouter error messages

* API keys are sensitive (#70847)

* Generate tool manifest from endpoint metadata (#70780)

* Generate tool manifest from endpoint metadta

* Delete reference file

* tweak-and-tidy

* More testing, more robustness

* Fix kondo and cljfmt

* Scrap name inference

* Clean up tool assertions

* Remove silly separators

* Switch away from tool registry approach

* rename + slightly simplify prefer-tool-descriptions

* Replace definitions binding with an explicitly threaded atom

* Minor cleanups/refactor

* Pull over some annotations from my prior PR; tweak test comments

* address comments

---------

Co-authored-by: Noah Moss <noahbmoss@gmail.com>

* properly fetch data for user-is-viewing context (#70857)

* serialize error to string if it is not - backend expects a string anyways

* chore: trigger CI

* [BOT-1056] Metabot Analyze Chart in CLJ Port (#70177)

* init analyze chart tool

* fix compilation error; add interpretation instructions; reduce memory leak

* Add license overrides for techascent/tech.config and net.openhft/zero-allocation-hashing

* Remove hard-coded :debug true in /agent-streaming endpoint

* Fix conflict resolution due to tools.analytics after rebase

tools.analytics and find-outliers were dropped in 974b595784

* BOT-1058 analyze chart add support for non timeseries charts (#70616)

* Add stats for categorical charts to analyze-chart tool

* Add stats for scatter plots to analyze-chart tool

* Add stats for histograms to analyze-chart tool

* Add time series tests for metabot chart analytics

* Add outliers tests for metabot chart analytics

* Small tweaks to reduce the diff between clojure port an ai-service stats

stats/scatter.clj

- Added sample-points helper (random sample up to 30 pairs)
- compute-series-stats: adds :sampled_points (30 random [x y] pairs),
  :outliers (MAD-based, x-values passed as "dates" so each outlier carries its x-coordinate in :date)
- compute-scatter-stats: extracts :x_name / :y_name from series metadata

stats/categorical.clj

- compute-categorical-stats: extracts :x_name / :y_name from series metadata

stats/histogram.clj

- compute-series-stats: now takes optional x-values (single-arity falls back to sequential indices);
  adds :bin_data (all [x y] pairs)
- compute-histogram-stats: extracts :x_name / :y_name from series metadata

stats/repr.clj

- generate-temporal-context: added "incomplete period" sentence
- New compute-data-characteristics: derives small_counts/high_variance/sparse_data flags from existing stats fields (no raw values needed)
- New render-data-characteristics-note: emits **Note**: ... matching Python's exact warning text
- All generate-*-representation functions: use display-type from context for the **Type**: line (fixes "Scatter" → "bar" for binned bar charts)
- Scatter: added **X-axis**, **Y-axis**, note, **Sample Data**, **Outliers** (x=..., y=...) sections
- Categorical: added **X-axis**, **Y-axis**, note
- Histogram: added **X-axis**, **Y-axis**, note, **Bin Data** section (in addition to existing percentile/shape stats)

* Add Data Points to categorical repr to match python implementation

* Do not mention cross-referencing the chart visual

Unlike the Python implementation, the clojure port does not include the chart image in the context.

* Fix detect-chart-type to correctly detect histograms

histograms have :display_type "bar" not "histogram"

* Add some limits on amount of data to analyze in analyze_charts

Downsample series data to 10k datapoints and cap series at 10 when calculating cross-series correlations.

* Add metabot-v3.stats.util ns and move some shared code there

* Use TMD funcs to compute percentiles, quartiles, skew and kurtosis in histogram.clj

* Cleanup comments and formatting in stats/core.clj

* Cleanup comments and formatting in stats/categorical.clj

* Cleanup comments and formatting in stats/histogram.clj

* Cleanup comments and formatting in stats/repr.clj

* Cleanup comments and formatting in stats/scatter.clj

* Fix make-series and drop compute-summary-median-test in util_test.clj

* Cleanup stats tests

* Use =?/approx in test assertions where appropriate

* Move all repr tests into repr_test.clj

* Add some more repr tests

* Add ^:parallel to metabot stats tests

* Make defs private where possible

* Add malli schemas for public funcs in metabot stats

* Replace some? with more specific test assertions where appropriate

* Remove unused find-outlier-indices

* Remove unused malli schemas ::analyze-chart-input ::analyze-chart-output ::chart-type

* Move nan->nil into stats.util and use it in compute-series-stats

* Rename `dates` arg to `labels` in find-outliers and find-outliers-cumulative

These funcs were originally added for timeseries data where the dependent variable was a date/time value, but are now
used for other chart types were the dimension might be any value.

* Fix trailing whitespace

* Convert series keys to strings in chart configs

* Change ::column-type malli enum from keywords to strings

This matches what we get from the frontend

* Add X-axis range to histogram stats and rename **Bin Data** to **Sample Data**

To match the scatter plot output

* Reduce code dup and extract shared helpers in repr.clj

* Fix kondo warning: reduce -> apply

* Add missing keys to malli schemas

* Ensure top/bottom categories are also deduped and aggregated

* Only calculate categorical :percentage if all values are non-negative

* Handle case where correlation coefficient is exactly zero when setting :direction

* Record :data_points in addtion to :categor_count for categorical stats

* Switch to computing weighted estimates plus structural metrics for binned histogram data

* Fix lint error due to reflection warning

* Fix waterfall chart type detection and improve handling for :unknown charts

Co-authored-by: Oleksandr Solovyov <o@solovyov.net>
Co-authored-by: Maksym Yakubych <undrfined@gmail.com>
Co-authored-by: Mike Appleby <86076+appleby@users.noreply.github.com>
Co-authored-by: Maksym Yakubych <maksym@metabase.com>
Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com>
Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Tyler Plude <tsplude@gmail.com>
2026-03-17 16:22:57 +02:00
Nemanja Glumac
65309ff9cb Revert "Update translations 2026-03-11 (#70712)" (#71003)
This reverts commit a989194135.
2026-03-17 14:26:08 +01:00
Nemanja Glumac
36be55e774 Increase the polling timeout (#70999) 2026-03-17 14:00:30 +01:00
Riley Thompson
0c0f3450dd Show expected type in custom expression error message (#70400)
* initial attempt at better error message

* clean up

* Clean up

* improve doc string

* fix cljc test

* add test

* fix test

* exclude perf functions

* have schema produce user facing expected type

* clean up

* Add test

* fix kondo

* defer i18n

* try test fix

* address comments

* update tests
2026-03-17 08:54:48 -04:00
github-automation-metabase
5ac9afd0f5 Auto-update documentation for master (#70988)
Update generated docs (master)

Co-authored-by: github-actions <github-actions@github.com>
2026-03-17 08:52:37 -04:00
Jakub Chodorowicz
21ebfb0a1b Gdgt 2002 transform inspector shows 12 matched columns but renders 2 (#70951)
* create failing test case for comparison layout and groups

* fix cards not loading when they part of group is visible
2026-03-17 13:48:32 +01:00
Uladzimir Havenchyk
52d5e78767 fix: perf improvements for documents (#70802)
* fix: perf improvements for documents

* fix unit test

* address comments
2026-03-17 13:40:47 +03:00
Kamil Mielnik
492008d7fd GDGT-1939 Get rid of VisualizationSettingDefinition["props"] (#70867) 2026-03-17 14:12:56 +07:00
Rodrigo López Dato
08c8928cf3 Update Athena parameter suggestions to JDBC v3 driver (#62689) 2026-03-16 17:16:14 -06:00
github-automation-metabase
a989194135 Update translations 2026-03-11 (#70712)
* Update translation sources 2026-03-11

* Update translations

* Fix host/sample apps e2e assertions

* Improve assertion

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
2026-03-16 17:15:56 -06:00
Braden Shepherdson
3c152db0a1 [MBQL lib] Start on user docs: top-level and expressions (#70375)
Part of QUE2-366.
2026-03-16 17:15:33 -06:00
Nathan Voxland
19d6d374c8 Correctly detect funnel chart config in static-viz (#68158) 2026-03-16 15:43:29 -05:00
Kevin Kelleher
7e3b3f1818 Fix trend visualizations that rely on aggregated datetimes (#70941) 2026-03-16 14:37:45 -04:00
Kevin Kelleher
4cb40dd358 Fix sunburst chart labels not appearing (#70889) 2026-03-16 14:37:25 -04:00
Nicola Mometto
525b09b87b incremental transforms with source filter (#70573)
* WIP: incremental transforms with source filter

* fix: route through substitution

* chore: remove useless check, we're already in python specific code

* fix: validate before parsing

* style

* fix test

* chore: format

* chore: turn off legacy incremental settings

* chore: remove dead code

* chore: remove dead code

* fix tests

* fix warnings

* fix

* update modules

* feat: store actual type

* feat: derive type, store lo/hi in transform runs

* feat: store checkpoint early so it's available on afailure

* feat: surface checkpoint values in UI

* refetch after run

* surface checkpoint value in UI

* fixes for the linter gods

* chore: format

* remove dead e2e test

* fix rebase

* feat: reset checkpoint if incremental field changes

* chore: do it in before-update instead

* chore: test

* chore: add preconds

* fix: remove rebase field that got in

* feat: thread source-range-params through

* fix test

* remove secondary index

* chore: proper schema

* fix: extract proper source columns from UI components

* fix e2e test

* add option to reset checkpoint

* UI: confirmation on field change

* style

* don't break on old import

* fail when running an incremental transform w/o a field set

* chore: polish UI

* appease linter

* add source-filters to table template tags in the BE

* chore: test

* chore: restrict ops

* extend schema

* chore: extract ->sql util

* chore

* some BE cleanup

* make checkpointFilterFieldId mandatory

* preselect first checkpointFilterFieldId when selecting incremental in standalone variant

* improve forced type assertion

* autoselect first value for checkpoint field also in embedded mode

* extract useAutoSelectFirstOption hook

* refactor nested ternary

* disable incremental toggle when no fields checkpoint available

* add better warning for native query lack of tag

* allow turning off incremental for transforms with issues

* consolidate temporal value to ISO

* Adjust style of reset checkpoint button

* Adjust modal confirmation copy

* convert date to iso also in  save-watermark

* fix date time field type detection

* remove superflous space

* feat: better mbql migration

* fix: whitespaces

* extend FormInlineUpdated to accept break condition onBeforeUpdate

* adjust styling

* extract ResetCheckpointSection

* remove superfluous comment

* rename hooks file

* refactor hasCheckpointOptions

* add comment about stage

* chore: validation

* CTA warning on malformed transforms

fix

* fix: refer to variable instead of template tag

* chore: i18n

* refactor transform warning

* schemas for source-range-params

* deal with review comments

* feat: emit via honeysql instead of string interpolation

* fix: use lib/template-tags

* cleanup

* fix IncrementalTransformSettings tests

* refactor, extract TransformType type

* fix: indent

* fix check

* fix tests

* fix lint

* simplify useHasCheckpointOptions

* cleanup utils unit tests

* chore: also add to lib/schema

* fix missing query metadata in useHasCheckpointOptions

* reset the checkpointFilterFieldId if incremental switch is toggled of

* fix transforms e2e tests

* feat: migration test

* chore: reorder

* adjust transform create tracking

* fix e2e GDGT-1774 reproduction

* fix missing space

* simplify useAutoSelectFirstOption hook

* add incremental sql transform e2e test

* add native sql incremental transform test

* add python incremental transform e2e test

* skip sql test for now

* auto include aliases

* simplify hover info

* fix and unskip incremental schema test

---------

Co-authored-by: Dan Stone <wotbrew@gmail.com>
Co-authored-by: Jakub Chodorowicz <jakub.chodorowicz@metabase.com>
2026-03-16 17:20:46 +00:00
Riley Thompson
0ac98129d9 Inline parameter in clickhouse honeysql method (#70905)
* suggested fix and test

* Clean up test

* clean up test
2026-03-16 15:49:00 +00:00
Nicolò Pretto
64712e1f3f feat(embed-onboarding): Block all schemas that does not contain selected (#70717)
* feat(embed-onboarding): Block all schemas that does not contain selected
tables when setting up RLS

* v2

* fix e2e

* clean up tests
2026-03-16 16:16:45 +01:00
Eric Normand
f3bff3f028 Fix 500 error in check-card endpoint for cards with broken dependents (#70828)
Fix unhandled exception in POST /api/ee/dependencies/check-card that causes a 500 when a transitive dependent card fails to compile

 When check-query-soundness iterates over all dependents, if any card's query throws during compilation (e.g. alias resolution errors), the exception propagated uncaught and crashed the entire endpoint
 
Added try/catch around check-entity calls in check-query-soundness, returning a validation-exception-error instead of crashing — consistent with the pattern already used in `/dependencies/findings.clj`

On the stats instance, card 4523 has 2,557 transitive card dependents. One of those dependents (a native query referencing card 34523 via a template tag) fails during query compilation with `Missing ::desired-alias->escaped for "email_domain"`. This compilation error is unrelated to the proposed edit but was bringing down the whole endpoint.

Test plan

  - Verify POST /api/ee/dependencies/check-card returns 200 with {success: false, bad_cards: [...]} instead of 500 when a dependent card has a query compilation error
  - Verify that cards with compilation errors appear in the response as validation-exception-error findings
  - Existing dependency check tests still pass
2026-03-16 14:59:17 +00:00
Ngoc Khuat
8454245aaa Use safe identifier quoting in workspace grant statements (#70869) 2026-03-16 14:58:24 +00:00
Nicola Mometto
3cc709ee43 Aliases for table template tags (#70893)
* auto include aliases

* simplify hover info

* add unit test for emit tables toggle

---------

Co-authored-by: Jakub Chodorowicz <jakub.chodorowicz@metabase.com>
2026-03-16 14:56:21 +00:00
Nicola Mometto
88729c52f1 Table tags filters (#70699)
* add source-filters to table template tags in the BE

* chore: test

* chore: restrict ops

* extend schema

* chore: extract ->sql util

* deal with review comments

* feat: emit via honeysql instead of string interpolation

* fix check

* chore: also add to lib/schema
2026-03-16 13:56:47 +00:00
4316 changed files with 690981 additions and 533515 deletions

View File

@@ -1,4 +1,4 @@
--b-
---
name: add-tracing
description: Add OpenTelemetry tracing spans to Clojure code following Metabase tracing conventions. Use when instrumenting backend code with trace coverage.
---

View File

@@ -0,0 +1,173 @@
---
name: clojure-eval
description: Evaluate Clojure code via nREPL using clj-nrepl-eval. Use this when you need to test code, check if edited files compile, verify function behavior, or interact with a running REPL session.
---
# Clojure REPL Evaluation
## When to Use This Skill
Use this skill when you need to:
- **Verify that edited Clojure files compile and load correctly**
- Test function behavior interactively
- Check the current state of the REPL
- Debug code by evaluating expressions
- Require or load namespaces for testing
- Validate that code changes work before committing
## How It Works
The `clj-nrepl-eval` command evaluates Clojure code against an nREPL server. **Session state persists between evaluations**, so you can require a namespace in one evaluation and use it in subsequent calls. Each host:port combination maintains its own session file.
## Instructions
### 0. Discover and select nREPL server
First, discover what nREPL servers are running in the current directory:
```bash
clj-nrepl-eval --discover-ports
```
This will show all nREPL servers (Clojure, Babashka, shadow-cljs, etc.) running in the current project directory.
**Then use the AskUserQuestion tool:**
- **If ports are discovered:** Prompt user to select which nREPL port to use:
- **question:** "Which nREPL port would you like to use?"
- **header:** "nREPL Port"
- **options:** Present each discovered port as an option with:
- **label:** The port number
- **description:** The server type and status (e.g., "Clojure nREPL server in current directory")
- Include up to 4 discovered ports as options
- The user can select "Other" to enter a custom port number
- **If no ports are discovered:** Prompt user how to start an nREPL server:
- **question:** "No nREPL servers found. How would you like to start one?"
- **header:** "Start nREPL"
- **options:**
- **label:** "deps.edn alias", **description:** "Find and use an nREPL alias in deps.edn"
- **label:** "Leiningen", **description:** "Start nREPL using 'lein repl'"
- The user can select "Other" for alternative methods or if they already have a server running on a specific port
IMPORTANT: IF you start a REPL do not supply a port let the nREPL start and return the port that it was started on.
### 1. Evaluate Clojure Code
> Evaluation automatically connects to the given port
Use the `-p` flag to specify the port and pass your Clojure code.
**Recommended: Pass code as a command-line argument:**
```bash
clj-nrepl-eval -p <PORT> "(+ 1 2 3)"
```
**For multiple expressions (single line):**
```bash
clj-nrepl-eval -p <PORT> "(def x 10) (+ x 20)"
```
**Alternative: Using heredoc (may require permission approval for multiline commands):**
```bash
clj-nrepl-eval -p <PORT> <<'EOF'
(def x 10)
(+ x 20)
EOF
```
**Alternative: Via stdin pipe:**
```bash
echo "(+ 1 2 3)" | clj-nrepl-eval -p <PORT>
```
### 2. Display nREPL Sessions
**Discover all nREPL servers in current directory:**
```bash
clj-nrepl-eval --discover-ports
```
Shows all running nREPL servers in the current project directory, including their type (clj/bb/basilisp) and whether they match the current working directory.
**Check previously connected sessions:**
```bash
clj-nrepl-eval --connected-ports
```
Shows only connections you have made before (appears after first evaluation on a port).
### 3. Common Patterns
**Require a namespace (always use :reload to pick up changes):**
```bash
clj-nrepl-eval -p <PORT> "(require '[my.namespace :as ns] :reload)"
```
**Test a function after requiring:**
```bash
clj-nrepl-eval -p <PORT> "(ns/my-function arg1 arg2)"
```
**Check if a file compiles:**
```bash
clj-nrepl-eval -p <PORT> "(require 'my.namespace :reload)"
```
**Multiple expressions:**
```bash
clj-nrepl-eval -p <PORT> "(def x 10) (* x 2) (+ x 5)"
```
**Complex multiline code (using heredoc):**
```bash
clj-nrepl-eval -p <PORT> <<'EOF'
(def x 10)
(* x 2)
(+ x 5)
EOF
```
*Note: Heredoc syntax may require permission approval.*
**With custom timeout (in milliseconds):**
```bash
clj-nrepl-eval -p <PORT> --timeout 5000 "(long-running-fn)"
```
**Reset the session (clears all state):**
```bash
clj-nrepl-eval -p <PORT> --reset-session
clj-nrepl-eval -p <PORT> --reset-session "(def x 1)"
```
## Available Options
- `-p, --port PORT` - nREPL port (required)
- `-H, --host HOST` - nREPL host (default: 127.0.0.1)
- `-t, --timeout MILLISECONDS` - Timeout (default: 120000 = 2 minutes)
- `-r, --reset-session` - Reset the persistent nREPL session
- `-c, --connected-ports` - List previously connected nREPL sessions
- `-d, --discover-ports` - Discover nREPL servers in current directory
- `-h, --help` - Show help message
## Important Notes
- **Prefer command-line arguments:** Pass code as quoted strings: `clj-nrepl-eval -p <PORT> "(+ 1 2 3)"` - works with existing permissions
- **Heredoc for complex code:** Use heredoc (`<<'EOF' ... EOF`) for truly multiline code, but note it may require permission approval
- **Sessions persist:** State (vars, namespaces, loaded libraries) persists across invocations until the nREPL server restarts or `--reset-session` is used
- **Automatic delimiter repair:** The tool automatically repairs missing or mismatched parentheses
- **Always use :reload:** When requiring namespaces, use `:reload` to pick up recent changes
- **Default timeout:** 2 minutes (120000ms) - increase for long-running operations
- **Input precedence:** Command-line arguments take precedence over stdin
## Typical Workflow
1. Discover nREPL servers: `clj-nrepl-eval --discover-ports`
2. Use **AskUserQuestion** tool to prompt user to select a port
3. Require namespace:
```bash
clj-nrepl-eval -p <PORT> "(require '[my.ns :as ns] :reload)"
```
4. Test function:
```bash
clj-nrepl-eval -p <PORT> "(ns/my-fn ...)"
```
5. Iterate: Make changes, re-require with `:reload`, test again

View File

@@ -0,0 +1,834 @@
---
name: emotion-migrate
description: Migrate Emotion styled-components to Mantine components with style props and CSS modules. Use when converting .styled.tsx files or removing @emotion imports from components.
---
# Emotion → Mantine + CSS Modules Migration Skill
Migrate Emotion styled-components (`@emotion/styled`, `@emotion/react`) to Mantine layout components with style props and CSS modules. The goal is zero Emotion imports, zero inline styles, and maximum use of design system tokens.
## Priority Order (Strict)
1. **Mantine components + style props** — `Box`, `Flex`, `Stack`, `Group`, `Text`, `Title`, `Card`. This is the DEFAULT. Every CSS property must be checked against style props FIRST.
2. **CSS modules** (`.module.css`) — ONLY for properties that Mantine style props genuinely cannot express: pseudo-selectors (`:hover`, `:focus`, `::before`), `box-shadow`, `border` shorthand, `animation`/`@keyframes`, complex selectors, `cursor`, `pointer-events`, `overflow`, `text-overflow`, `white-space`, `transition`.
3. **Inline styles ONLY for dynamic values** — `style={{ }}` is allowed only for truly dynamic runtime values (e.g., computed widths, positions, data-driven colors). All static styles must use Mantine props or CSS modules.
### Mantine-First Decision Gate (CRITICAL)
For EACH styled component, go through every CSS property and ask: "Can this be a Mantine style prop?" If yes → style prop. If no → CSS module. Do NOT dump an entire component into a CSS module just because one property needs it — split them.
**Properties that ARE style props** (use these, not CSS modules):
- `display` → `display` prop
- `color` → `c` prop (`c="brand"`, `c="text-primary"`)
- `background-color` → `bg` prop (`bg="background-primary"`)
- `font-size` → `fz` prop (`fz="md"`)
- `font-weight` → `fw` prop (`fw="bold"`)
- `line-height` → `lh` prop (`lh="md"`)
- `text-align` → `ta` prop (`ta="center"`)
- `padding` (all variants) → `p`, `px`, `py`, `pt`, `pb`, `pl`, `pr`
- `margin` (all variants) → `m`, `mx`, `my`, `mt`, `mb`, `ml`, `mr`
- `width` → `w`, `min-width` → `miw`, `max-width` → `maw`
- `height` → `h`, `min-height` → `mih`, `max-height` → `mah`
- `flex` → `flex` prop (`flex="0 0 auto"`, `flex={1}`)
- `gap` → `gap` prop (on Flex/Stack/Group)
- `align-items` → `align` prop (on Flex/Stack/Group)
- `justify-content` → `justify` prop (on Flex/Stack/Group)
- `flex-direction` → `direction` prop (on Flex)
- `flex-wrap` → `wrap` prop (on Flex)
- `position` → `pos` prop
- `top/right/bottom/left` → `top`, `right`, `bottom`, `left` props
- `opacity` → `opacity` prop
**Properties that NEED CSS modules** (no style prop equivalent):
- `:hover`, `:focus`, `:active`, `::before`, `::after` (pseudo-selectors)
- `box-shadow`, `border` (shorthand with color), `outline`
- `cursor`, `pointer-events`
- `overflow`, `text-overflow`, `white-space`
- `animation`, `transition`, `transform`
- `@media` queries (UNLESS it's simple responsive spacing/sizing — then use responsive syntax: `p={{ base: "md", lg: "xl" }}`)
**Hybrid approach** — when a component needs BOTH, put style props on the Mantine component AND add a CSS module class for the rest:
```tsx
<Flex
className={S.root} /* for :hover, box-shadow, border */
align="center" /* style prop */
gap="sm" /* style prop */
p="md" /* style prop */
bg="background-primary" /* style prop */
>
```
## CSS Module Conventions (Strict)
### Class Naming: camelCase
All CSS module class names MUST use **camelCase**. This is the dominant convention across the codebase (~830 camelCase vs ~620 PascalCase classes), used consistently in Mantine UI components, and matches standard CSS module conventions.
```css
/* CORRECT */
.root {
}
.settingsSection {
}
.dragHandle {
}
.closeIcon {
}
/* WRONG — do not use PascalCase or kebab-case */
.ItemRoot {
}
.settings-section {
}
```
Modifier/state classes also use camelCase:
```css
.selected {
}
.disabled {
}
.interactive {
}
.draggable {
}
```
### No Cascading — Direct Class Assignment
Cascading selectors are **discouraged**. Instead of styling through parent-child relationships, assign a class directly to the element that needs styling.
```css
/* WRONG — cascading/descendant selectors */
.root > input {
}
.root .label {
}
.container > div > span {
}
/* CORRECT — direct class on the target element */
.input {
}
.label {
}
.title {
}
```
The only acceptable nesting patterns are:
- **Pseudo-selectors on the same element**: `.item { &:hover { } }`
- **Modifier composition**: `.item { &.selected { } }`
- **Hover-reveal patterns** where a parent hover affects a child: `.root:hover .showOnHover { opacity: 1; }` — but only when structurally necessary (the child has no way to know about the parent's hover state)
### Import Alias
Always import the CSS module as `S`:
```tsx
import S from "./ComponentName.module.css";
```
## Step-by-Step Migration Process
### Step 1: Read and Understand
Read the `.styled.tsx` file AND every component that imports from it. Understand:
- Which styled components are used and where
- Which props drive dynamic styles
- Which styles are static vs conditional
- Which styles can map directly to Mantine style props
### Step 2: Classify Each Styled Component
For each styled component, apply the Mantine-First Decision Gate above. Then determine the migration target:
| Emotion Pattern | Migration Target |
| ------------------------------------------------------------ | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `styled.div` with only layout/spacing/color | `Box`, `Flex`, `Stack`, or `Group` with style props. **NO CSS module needed.** |
| `styled.div` with flexbox column | `Stack` component with style props |
| `styled.div` with flexbox row | `Flex` or `Group` component with style props |
| `styled.span` / `styled.p` with color/weight/size | **`Text component="span"` with style props** (`c`, `fw`, `fz`). NO CSS module. |
| `styled.div` with hover/focus/pseudo-selectors | **Hybrid**: Mantine component with style props for expressible properties + CSS module class for pseudo-selectors only |
| `styled.div` with media queries (simple spacing/sizing) | **Responsive style props**: `p={{ base: "md", lg: "xl" }}`. NO CSS module. |
| `styled.div` with media queries (complex/non-spacing) | CSS module for the media query parts, style props for the rest |
| `styled.div` with animations/keyframes | CSS module for animation, style props for layout |
| `styled(SomeComponent)` with only color/spacing/flex | **Wrap in Mantine component** with style props: `<Box c="brand" flex="0 0 auto"><Icon /></Box>`, or pass style props if the component accepts them |
| `styled(SomeComponent)` with pseudo-selectors/complex styles | CSS module `className` on the component |
| Dynamic props `styled.div<{ isActive: boolean }>` | Mantine style props for simple toggles (`c={active ? "brand" : "text-primary"}`), `cx()` with CSS module classes for complex state combinations involving pseudo-selectors |
### Step 3: Create CSS Module (if needed)
Create `ComponentName.module.css` alongside the component file:
```css
/* Use design system tokens — NEVER raw color/spacing values */
.root {
border: 1px solid var(--mb-color-border);
border-radius: var(--mantine-radius-md);
background-color: var(--mb-color-background-primary);
}
/* Conditional states as separate classes, combined with cx() */
.active {
background-color: var(--mb-color-brand);
color: var(--mb-color-text-primary-inverse);
}
.disabled {
color: var(--mb-color-text-tertiary);
pointer-events: none;
}
/* Hover/focus/pseudo-selectors — nest with & */
.interactive {
cursor: pointer;
&:hover {
color: var(--mb-color-brand);
background-color: var(--mb-color-background-hover);
}
}
/* Hover-reveal: acceptable parent→child nesting */
.root:hover .showOnHover {
opacity: 1;
}
/* Responsive styles */
@media (--breakpoint-min-md) {
.root {
padding: var(--mantine-spacing-lg);
}
}
```
### Step 4: Update the Component TSX
```tsx
import cx from "classnames";
import CS from "metabase/css/core/index.css";
import { Box, Flex, Group, Stack, Text } from "metabase/ui";
import S from "./ComponentName.module.css";
// Dynamic props → cx() with conditional classes
<Flex
className={cx(S.root, {
[S.active]: isActive,
[S.disabled]: disabled,
})}
align="center"
gap="sm"
p="md"
w="100%"
>
```
### Step 5: Delete the `.styled.tsx` File
Remove the old styled file entirely. Remove all imports of it from other files.
### Step 6: Verify
- Confirm zero `@emotion/styled` or `@emotion/react` imports remain in the migrated files
- Confirm no static inline styles (dynamic runtime values are fine)
- Confirm all colors use tokens, not raw hex/rgb values
## Design System Token Reference
### Mantine Style Props (use directly on components)
**Spacing** (`p`, `px`, `py`, `pt`, `pb`, `pl`, `pr`, `m`, `mx`, `my`, `mt`, `mb`, `ml`, `mr`):
- `"xs"` = 4px, `"sm"` = 8px, `"md"` = 16px, `"lg"` = 24px, `"xl"` = 32px
- Custom: `rem(48)` for non-standard values (import `rem` from `metabase/ui`)
**Dimensions** (`w`, `h`, `maw`, `mah`, `miw`, `mih`):
- `"100%"`, `"100vh"`, `rem(400)`, etc.
**Colors** (`c`, `bg`):
- Text: `"text-primary"`, `"text-secondary"`, `"text-tertiary"`
- Background: `"background-primary"`, `"background-secondary"`, `"background-hover"`
- Brand: `"brand"`, `"error"`, `"success"`, `"warning"`
**Typography** (`fz`, `fw`, `lh`, `ta`, `ff`):
- Font size: `"xs"` = 11px, `"sm"` = 12px, `"md"` = 14px, `"lg"` = 17px, `"xl"` = 21px
- Font weight: `"bold"`, `"normal"`, or numeric `700`
- Line height: `"xs"` = 100%, `"sm"` = 115%, `"md"` = 122%, `"lg"` = 138%, `"xl"` = 150%
- Text align: `"center"`, `"left"`, `"right"`
**Flexbox** (`align`, `justify`, `gap`, `direction`, `wrap`, `flex`):
- `align="center"`, `justify="space-between"`, `gap="sm"`, `direction="column"`, `wrap="nowrap"`
- `flex={1}`, `flex="0 0 auto"`
**Other**: `pos` (position), `display`
**Responsive syntax**: `px={{ base: "md", md: "lg", lg: rem(48) }}`
### CSS Variable Tokens (use in `.module.css` files)
**Colors** — `var(--mb-color-<name>)`:
- `--mb-color-text-primary`, `--mb-color-text-secondary`, `--mb-color-text-tertiary`
- `--mb-color-background-primary`, `--mb-color-background-secondary`, `--mb-color-background-hover`
- `--mb-color-border`, `--mb-color-border-strong`, `--mb-color-border-subtle`
- `--mb-color-brand`, `--mb-color-brand-hover`
- `--mb-color-error`, `--mb-color-success`, `--mb-color-warning`
- `--mb-color-shadow`, `--mb-color-focus`
- `--mb-color-accent0` through `--mb-color-accent7`
**Mantine spacing** — `var(--mantine-spacing-<size>)`:
- `--mantine-spacing-xs` (4px), `--mantine-spacing-sm` (8px), `--mantine-spacing-md` (16px), `--mantine-spacing-lg` (24px), `--mantine-spacing-xl` (32px)
**Mantine radius** — `var(--mantine-radius-<size>)`:
- `--mantine-radius-xs` (4px), `--mantine-radius-sm` (6px), `--mantine-radius-md` (8px), `--mantine-radius-xl` (40px)
**Mantine font sizes** — `var(--mantine-font-size-<size>)`:
- `--mantine-font-size-xs` (11px), `--mantine-font-size-sm` (12px), `--mantine-font-size-md` (14px), `--mantine-font-size-lg` (17px), `--mantine-font-size-xl` (21px)
**Breakpoints** (in `.module.css` files):
- `@media (--breakpoint-min-sm)` (40em / 640px)
- `@media (--breakpoint-min-md)` (60em / 960px)
- `@media (--breakpoint-min-lg)` (80em / 1280px)
- `@media (--breakpoint-min-xl)` (120em / 1920px)
- Also available: `--breakpoint-max-*` variants
### Snap Hardcoded Literals to Nearest Design Token (CRITICAL)
When migrating, **never carry over hardcoded `rem`/`px` values** from the original Emotion code. Instead, snap them to the nearest design system token. The original values were often arbitrary — the migration is an opportunity to align with the design system.
**Spacing** — snap to the nearest Mantine spacing token:
| Hardcoded value | Nearest token | Style prop | CSS variable |
| --------------------------------- | ------------- | ------------ | ------------------------------ |
| `0.125rem` (2px) | `2px` | `2` (number) | `2px` (keep literal, no token) |
| `0.2rem` (3.2px), `0.25rem` (4px) | **xs** (4px) | `"xs"` | `var(--mantine-spacing-xs)` |
| `0.5rem` (8px) | **sm** (8px) | `"sm"` | `var(--mantine-spacing-sm)` |
| `0.75rem` (12px) | between sm/md | `rem(12)` | `0.75rem` (no exact token) |
| `1rem` (16px) | **md** (16px) | `"md"` | `var(--mantine-spacing-md)` |
| `1.5rem` (24px) | **lg** (24px) | `"lg"` | `var(--mantine-spacing-lg)` |
| `2rem` (32px) | **xl** (32px) | `"xl"` | `var(--mantine-spacing-xl)` |
**Border radius** — snap to the nearest Mantine radius token:
| Hardcoded value | Nearest token | CSS variable |
| ---------------- | ----------------------------- | -------------------------- |
| `0.25rem` (4px) | **xs** (4px) | `var(--mantine-radius-xs)` |
| `0.375rem` (6px) | **sm** (6px) | `var(--mantine-radius-sm)` |
| `0.5rem` (8px) | **md** (8px) | `var(--mantine-radius-md)` |
| `1rem`+ (16px+) | **xl** (40px) or keep literal | `var(--mantine-radius-xl)` |
**Font sizes** — snap to the nearest Mantine font size token:
| Hardcoded value | Nearest token | Style prop | CSS variable |
| -------------------------------- | ------------- | ---------- | ----------------------------- |
| `0.6875rem` (11px) | **xs** (11px) | `fz="xs"` | `var(--mantine-font-size-xs)` |
| `0.75rem` (12px) | **sm** (12px) | `fz="sm"` | `var(--mantine-font-size-sm)` |
| `0.875rem` (14px), `1rem` (16px) | **md** (14px) | `fz="md"` | `var(--mantine-font-size-md)` |
| `1.063rem` (17px) | **lg** (17px) | `fz="lg"` | `var(--mantine-font-size-lg)` |
| `1.3rem` (21px) | **xl** (21px) | `fz="xl"` | `var(--mantine-font-size-xl)` |
**Rules:**
- If the hardcoded value is within ~2px of a token, use the token
- If it falls exactly between two tokens, prefer the smaller one (tighter is safer)
- If no token is close (e.g., `48px` spacing), use `rem(48)` for style props or the literal value in CSS modules
- This applies everywhere: style props, CSS module values, Icon `size` props, etc.
## Common Migration Patterns
### Pattern 1: Static Layout Container → Mantine Component
**Before:**
```tsx
// Component.styled.tsx
export const Container = styled.div`
display: flex;
align-items: center;
gap: 0.5rem;
padding: 1rem;
width: 100%;
`;
```
**After:**
```tsx
<Flex align="center" gap="sm" p="md" w="100%">
```
### Pattern 2: Vertical Stack → Stack Component
**Before:**
```tsx
export const Wrapper = styled.div`
display: flex;
flex-direction: column;
gap: 1.5rem;
padding: 2rem;
`;
```
**After:**
```tsx
<Stack gap="lg" p="xl">
```
### Pattern 3: Dynamic Props → cx() with CSS Module Classes
**Before:**
```tsx
export const Item = styled.div<{ isSelected: boolean; disabled: boolean }>`
color: ${(props) =>
props.disabled ? color("text-tertiary") : color("text-primary")};
background-color: ${(props) =>
props.isSelected ? color("brand") : "transparent"};
cursor: ${(props) => (props.disabled ? "default" : "pointer")};
&:hover {
color: ${(props) => !props.disabled && color("brand")};
}
`;
```
**After (CSS module):**
```css
/* Item.module.css */
.itemRoot {
color: var(--mb-color-text-primary);
cursor: pointer;
&:hover {
color: var(--mb-color-brand);
}
}
.selected {
background-color: var(--mb-color-brand);
}
.disabled {
color: var(--mb-color-text-tertiary);
cursor: default;
&:hover {
color: var(--mb-color-text-tertiary);
}
}
```
**After (TSX):**
```tsx
<Box
className={cx(S.itemRoot, {
[S.selected]: isSelected,
[S.disabled]: disabled,
})}
>
```
### Pattern 4: Extending a Component → Style Props First, CSS Module Only If Needed
When a styled component wraps another component, first check if the styles can be expressed as style props on a Mantine wrapper or on the component itself. Only use a CSS module when properties genuinely need it.
**Before:**
```tsx
export const CardIcon = styled(Icon)`
display: block;
flex: 0 0 auto;
color: var(--mb-color-brand);
`;
export const CardTitle = styled(Ellipsified)`
color: var(--mb-color-text-primary);
font-size: 1rem;
font-weight: bold;
margin-left: 1rem;
`;
```
**After — style props on Mantine wrapper (preferred when ALL properties are expressible):**
```tsx
<Box display="block" flex="0 0 auto" c="brand">
<Icon {...icon} />
</Box>
<Box c="text-primary" fz="md" fw="bold" ml="md">
<Ellipsified>{title}</Ellipsified>
</Box>
```
**After — CSS module (use only when component has pseudo-selectors or non-expressible styles):**
```css
.icon {
color: var(--mb-color-brand);
width: 1.5rem;
height: 1.5rem;
cursor: pointer;
&:hover {
color: var(--mb-color-brand-hover);
}
}
```
```tsx
<Icon className={S.icon} name="warning" />
```
### Pattern 4b: `styled.span` / `styled.p` with Text Styles → `Text` Component
**Before:**
```tsx
export const Label = styled.span`
color: var(--mb-color-text-secondary);
font-weight: bold;
`;
export const Title = styled.span`
color: var(--mb-color-text-primary);
font-size: 1rem;
font-weight: bold;
margin-left: 0.5rem;
`;
```
**After — `Text` component with style props (NO CSS module needed):**
```tsx
<Text component="span" c="text-secondary" fw="bold">
{label}
</Text>
<Text component="span" c="text-primary" fz="md" fw="bold" ml="sm">
{title}
</Text>
```
`Text` renders as `<p>` by default. Use `component="span"` to render inline. All color, typography, and spacing props work directly — no CSS module needed for pure text styling.
### Pattern 5: Keyframes Animation → CSS Module
**Before:**
```tsx
const spin = keyframes`
from { transform: rotate(0deg); }
to { transform: rotate(360deg); }
`;
export const Spinner = styled.div`
animation: ${spin} 1s infinite linear;
`;
```
**After (CSS module):**
```css
@keyframes spin {
from {
transform: rotate(0deg);
}
to {
transform: rotate(360deg);
}
}
.spinner {
animation: spin 1s infinite linear;
}
```
**After (TSX):**
```tsx
<Box className={S.spinner} />
```
### Pattern 6: color() Function → CSS Variables
| Emotion (JS) | CSS Module | Mantine Style Prop |
| ----------------------- | ------------------------------------------------------------ | --------------------------- |
| `color("brand")` | `var(--mb-color-brand)` | `c="brand"` or `bg="brand"` |
| `color("text-primary")` | `var(--mb-color-text-primary)` | `c="text-primary"` |
| `color("border")` | `var(--mb-color-border)` | N/A (use CSS module) |
| `alpha("brand", 0.2)` | `color-mix(in srgb, var(--mb-color-brand), transparent 80%)` | N/A (use CSS module) |
### Pattern 7: Responsive Spacing/Sizing → Responsive Style Props (NOT CSS Media Queries)
When a styled component only changes spacing, sizing, or other style-prop-expressible values at breakpoints, use Mantine's responsive syntax instead of CSS module media queries.
**Before:**
```tsx
export const CaptionRoot = styled.div`
margin-bottom: 1.5rem;
${breakpointMinExtraLarge} {
margin-bottom: 2rem;
}
`;
```
**After — responsive style prop (NO CSS module needed):**
```tsx
<Flex mb={{ base: "lg", xl: "xl" }}>
```
Breakpoint keys: `base` (default), `xs` (40em), `sm` (48em), `md` (60em), `lg` (80em), `xl` (120em).
Only use CSS module `@media` queries when the responsive change involves non-style-prop properties (e.g., `box-shadow`, `border`, `cursor` changes at breakpoints).
### Pattern 8: Dynamic Computed Styles → Inline Styles
Inline styles are allowed **only** for truly dynamic values computed at runtime (e.g., widths, positions, colors from data). Everything else must use Mantine style props or CSS modules.
**Before:**
```tsx
export const Bar = styled.div<{ width: number }>`
width: ${(props) => props.width}%;
`;
```
**After:**
```tsx
<Box style={{ width: `${width}%` }} />
```
### Pattern 9: Core CSS Utility Classes (Discouraged)
**Do NOT introduce new `CS` utility class usage.** Core CSS utilities (`CS` from `metabase/css/core/index.css`) are legacy and discouraged for new code. Prefer Mantine style props or CSS modules instead.
If existing code already uses `CS` classes and you're not migrating that specific code, leave them alone. But when migrating Emotion → Mantine, replace with the proper alternative:
| Instead of `CS.*` | Use |
| ------------------- | ------------------------------------------------------- |
| `CS.overflowHidden` | CSS module: `overflow: hidden` |
| `CS.cursorPointer` | CSS module: `cursor: pointer` |
| `CS.flex1` | Style prop: `flex={1}` |
| `CS.flexNoShrink` | Style prop: `flex="0 0 auto"` |
| `CS.textBrandHover` | CSS module: `&:hover { color: var(--mb-color-brand); }` |
### Pattern 10: Shared Emotion Styles Across Files → Shared CSS Module + cx()
When Emotion exports a shared `css` block (like `animationStyles`) imported by many files, create ONE CSS module with the shared keyframe and a reusable class, then compose via `cx()`.
**Before (Emotion — shared animation used by 13+ skeleton files):**
```tsx
// ChartSkeleton.styled.tsx — defines shared animation
const fadingKeyframes = keyframes`
0% { opacity: 0.0625; }
50% { opacity: 0.125; }
100% { opacity: 0.0625; }
`;
export const animationStyles = css`
opacity: 0.1;
animation: ${fadingKeyframes} 1.5s infinite;
`;
// AreaSkeleton.styled.tsx — consumes it
import { animationStyles } from ".../ChartSkeleton.styled";
export const SkeletonImage = styled.svg`
${animationStyles};
flex: 1 1 0;
margin-top: 1rem;
border-bottom: 1px solid currentColor;
`;
// BarSkeleton.styled.tsx — also consumes it
import { animationStyles } from ".../ChartSkeleton.styled";
export const SkeletonImage = styled.svg`
${animationStyles};
flex: 1 1 0;
margin-top: 1rem;
`;
```
**After — shared CSS module:**
```css
/* ChartSkeleton.module.css */
@keyframes fading {
0% {
opacity: 0.0625;
}
50% {
opacity: 0.125;
}
100% {
opacity: 0.0625;
}
}
.animated {
opacity: 0.1;
animation: fading 1.5s infinite;
}
```
**After — per-component CSS modules with own styles only:**
```css
/* AreaSkeleton.module.css */
.skeletonImage {
flex: 1 1 0;
margin-top: 1rem;
border-bottom: 1px solid currentColor;
}
```
```css
/* BarSkeleton.module.css */
.skeletonImage {
flex: 1 1 0;
margin-top: 1rem;
}
```
**After — component TSX uses cx() to compose:**
```tsx
// AreaSkeleton.tsx
import cx from "classnames";
import ChartSkeletonS from "../ChartSkeleton/ChartSkeleton.module.css";
import S from "./AreaSkeleton.module.css";
const AreaSkeleton = (): JSX.Element => {
return (
<svg
className={cx(ChartSkeletonS.animated, S.skeletonImage)}
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 371 113"
preserveAspectRatio="none"
>
<path d="..." fill="currentColor" />
</svg>
);
};
```
The shared module owns the `@keyframes` and the `.animated` class. Each consumer composes it with its own module class via `cx()`. No duplication of the keyframe definition.
## Import Template
```tsx
import cx from "classnames"; // only if needed for conditional classes
import { Box, Flex, Group, Stack, Text, rem } from "metabase/ui";
import S from "./ComponentName.module.css"; // only if CSS module is needed
```
## Checklist Before Finishing
- [ ] **MANTINE-FIRST CHECK**: Every CSS property that has a style prop equivalent (`c`, `bg`, `p`, `m`, `fw`, `fz`, `flex`, `gap`, `align`, `w`, `h`, etc.) is expressed as a style prop, NOT in a CSS module
- [ ] `styled.span`/`styled.p` with only color/weight/size are replaced with `Text component="span"` + style props, NOT CSS module classes
- [ ] `styled.div` with only layout props are replaced with `Flex`/`Stack`/`Group`/`Box` + style props, NOT CSS module classes
- [ ] Responsive spacing/sizing uses responsive style props (`mb={{ base: "lg", xl: "xl" }}`), NOT CSS module `@media` queries
- [ ] CSS modules are used ONLY for: pseudo-selectors, box-shadow, border, cursor, overflow, animation, transition, transform, or complex selectors
- [ ] All `@emotion/styled` and `@emotion/react` imports removed from migrated files
- [ ] The `.styled.tsx` file is deleted
- [ ] All imports of the deleted styled file are updated
- [ ] No static inline styles — `style={{ }}` used only for truly dynamic runtime values
- [ ] All colors use design tokens (`c="brand"`, `var(--mb-color-brand)`), not raw hex/rgb
- [ ] All spacing uses design tokens (`p="md"`, `var(--mantine-spacing-md)`), not arbitrary px values — hardcoded `rem`/`px` literals snapped to the nearest token (see mapping table above)
- [ ] All border-radius values use radius tokens (`var(--mantine-radius-md)`), not hardcoded `0.5rem`
- [ ] All font sizes use font-size tokens (`fz="md"`, `var(--mantine-font-size-md)`), not hardcoded `1rem`
- [ ] Layout uses Mantine components (`Flex`, `Stack`, `Group`, `Box`, `Text`) not raw divs/spans with CSS
- [ ] All CSS module class names use camelCase
- [ ] No cascading/descendant selectors targeting raw elements — use direct class assignment instead
- [ ] Component renders identically to the original (visually verify if possible)
## Visual Verification with Screenshots (Optional — Only When Explicitly Asked)
When the user explicitly asks to create before/after screenshots, use the Playwright MCP tools to capture them. This is NOT done by default — only when requested.
Screenshots must be taken in **both light and dark mode** to verify token usage is correct in both themes.
### Switching Color Scheme via API
Toggle between light and dark mode using the Metabase settings API. Use Playwright's `browser_evaluate` or `browser_navigate` with fetch:
```js
// Switch to dark mode
await fetch("/api/setting/color-scheme", {
method: "PUT",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ value: "dark" }),
});
// Switch to light mode
await fetch("/api/setting/color-scheme", {
method: "PUT",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ value: "light" }),
});
```
After switching, reload the page for the theme to take effect.
### Process
For each state (**after** = migrated code, **before** = stashed original), capture screenshots in both themes at both viewport widths. This produces **8 screenshots total**.
1. **Take "after" screenshots first** (migrated code is already in place):
- Navigate to the page that renders the migrated components (`browser_navigate`)
- Wait for content to load (`browser_wait_for` with key text, or `textGone: "Loading..."`)
- Close the sidebar if it overlaps content on narrow viewports (`browser_click` the toggle button)
- **Light mode** (set `color-scheme` to `"light"` via API, reload):
- Desktop (1280x900): `after-light-desktop.png`
- Narrow (640x900), close sidebar: `after-light-narrow.png`
- **Dark mode** (set `color-scheme` to `"dark"` via API, reload):
- Desktop (1280x900): `after-dark-desktop.png`
- Narrow (640x900), close sidebar: `after-dark-narrow.png`
2. **Stash changes to capture "before" screenshots**:
- Run `git stash --include-untracked` to temporarily revert to the Emotion version
- Repeat the same 4 screenshots with `before-` prefix:
- `before-light-desktop.png`, `before-light-narrow.png`
- `before-dark-desktop.png`, `before-dark-narrow.png`
- Run `git stash pop` to restore the migrated code
3. **Restore the user's original color scheme** (set back to `"auto"` or whatever it was before).
4. **Display all 8 screenshots** using the `Read` tool so the user can visually compare before/after in both themes at both viewport sizes.
### Key Details
- Save screenshots in the repo root (they will be untracked — user can delete after review)
- The dev server must be running (typically `http://localhost:3000`)
- Use `browser_snapshot` to find element refs when you need to click buttons (e.g., sidebar toggle)
- The greeting text on the home page changes randomly on each load — this is expected, not a regression
- If the page being tested is not the home page, navigate to the correct URL that exercises the migrated components
- Dark mode screenshots are critical for verifying that CSS variable tokens (`var(--mb-color-*)`) are used correctly — hardcoded colors will look wrong in dark mode

View File

@@ -68,6 +68,7 @@
:metabase/modules {:level :warning} ; more config in `.clj-kondo/config/modules/config.edn`
:metabase/namespace-name {:level :warning}
:metabase/no-jsqlparser-imports {:level :warning}
:metabase/toucan-model-ns {:level :warning}
:metabase/require-shape-checker {:level :warning}
:metabase/tests-must-live-in-known-modules {:level :warning}
:metabase/validate-defendpoint-route-uses-kebab-case {:level :warning}
@@ -176,8 +177,10 @@
clojure.core.async/to-chan!
clojure.core.async/to-chan!!
metabase.channel.core/send!
metabase.warehouses.models.database/assert-not-h2!
metabase.driver.sql-jdbc.execute/execute-prepared-statement!
metabase.notification.models/create-notification!
metabase.oauth-server.core/reset-provider!
metabase.pulse.send/send-pulse!
metabase-enterprise.transforms-python.python-runner-test/execute!
;; Workspace isolation functions are safe in parallel tests because they operate on
@@ -469,14 +472,15 @@
metabase.premium-features.settings/define-premium-feature clojure.core/def
metabase.pulse.dashboard-subscription-test/with-dashboard-sub-for-card clojure.core/let
metabase.pulse.send-test/with-pulse-for-card clojure.core/let
metabase.query-processor.pipeline-queries-test/pmbql-query clojure.core/->
metabase.query-processor.pipeline-queries-test/run-pmbql-query clojure.core/->
metabase.query-processor.pipeline-queries-test/mbql5-query clojure.core/->
metabase.query-processor.pipeline-queries-test/run-mbql5-query clojure.core/->
metabase.query-processor.error-type/deferror clojure.core/def
metabase.query-processor.middleware.cache.impl/with-reducible-deserialized-results clojure.core/let
metabase.query-processor.middleware.process-userland-query-test/with-query-execution! clojure.core/let
metabase.query-processor.setup/with-qp-setup clojure.core/let
metabase.search.api-test/do-test-users clojure.core/let
metabase.settings.core/define-multi-setting clojure.core/def
metabase.api-scope.core/defscope clj-kondo.lint-as/def-catch-all
metabase.settings.core/defsetting clj-kondo.lint-as/def-catch-all
metabase.settings.models.setting.multi-setting/define-multi-setting clojure.core/def
metabase.settings.models.setting/defsetting clj-kondo.lint-as/def-catch-all
@@ -552,6 +556,7 @@
metabase-enterprise.cache.config-test/with-temp-persist-models hooks.common/with-seven-bindings
metabase-enterprise.dependencies.api-test/with-dependents-test! hooks.common/with-two-bindings
metabase-enterprise.metabot-v3.tools.dependencies-test/with-dependent-transforms! hooks.common/with-two-bindings
metabase-enterprise.metabot.tools.dependencies-test/with-dependent-transforms! hooks.common/with-two-bindings
metabase-enterprise.semantic-search.db.connection/with-migrate-tx hooks.common/let-one-with-optional-value
metabase-enterprise.serialization.api-test/with-serialization-test-data! hooks.common/with-three-bindings
metabase-enterprise.serialization.test-util/with-temp-dpc hooks.toucan2.tools.with-temp/with-temp
@@ -586,6 +591,8 @@
metabase.lib.schema.mbql-clause/define-catn-mbql-clause hooks.metabase.lib.schema.mbql-clause/define-mbql-clause
metabase.lib.schema.mbql-clause/define-mbql-clause hooks.metabase.lib.schema.mbql-clause/define-mbql-clause
metabase.lib.schema.mbql-clause/define-tuple-mbql-clause hooks.metabase.lib.schema.mbql-clause/define-mbql-clause
methodical.core/defmethod hooks.metabase.toucan.table-name/lint-defmethod
methodical.macros/defmethod hooks.metabase.toucan.table-name/lint-defmethod
metabase.lib.test-util.macros/$ids hooks.metabase.test.data/$ids
metabase.lib.test-util.macros/mbql-query hooks.metabase.test.data/mbql-query
metabase.lib.test-util.macros/mbql-5-query hooks.metabase.test.data/mbql-query
@@ -793,7 +800,7 @@
:private-call {:level :off}
:metabase/defsetting-must-specify-export {:level :off}
:metabase/defsetting-namespace {:level :off}
:metabase/test-helpers-use-non-thread-safe-functions {:level :warning} ; more config in `.clj-kondo/config/test-helpers/config.edn
:metabase/test-helpers-use-non-thread-safe-functions {:level :warning} ; more config in `.clj-kondo/config/test-helpers/config.edn`
:discouraged-var
{metabase.driver/database-supports? {:level :off}

File diff suppressed because it is too large Load Diff

View File

@@ -110,6 +110,7 @@
metabase.settings.models.setting-test/test-user-local-allowed-setting!
metabase.settings.models.setting-test/test-user-local-only-setting!
metabase.settings.models.setting.cache/restore-cache!
metabase.settings.models.setting/log-deprecated-env-var-usage!
metabase.settings.models.setting/set!
metabase.settings.models.setting/validate-settings-formatting!
metabase.setup.core/create-token!

View File

@@ -0,0 +1,43 @@
(ns hooks.metabase.toucan.table-name
"Lint that toucan2 model namespaces (those defining `t2/table-name`) live
under `metabase[-enterprise]/<module>/models[/…]`.
This wraps the methodical `defmethod` hook: we delegate to
`hooks.methodical.macros/defmethod` for the actual analysis (so arg bindings
etc. still work), and additionally check the file location when the
multimethod being defined is `t2/table-name`."
(:require
[clj-kondo.hooks-api :as hooks]))
(defn- models-file? [filename]
(boolean
(and filename
(re-find #"/(?:metabase|metabase_enterprise)/[^/]+/models(?:/|\.clj[cs]?$)"
filename))))
(defn- table-name-dispatch? [sym]
(and (symbol? sym)
(= (name sym) "table-name")
(#{"t2" "toucan2.core"} (namespace sym))))
(defn lint-defmethod
"Hook registered at the project level on `methodical.core/defmethod` (and
`methodical.macros/defmethod`). Performs the table-name check, then
delegates to the vendored methodical hook so kondo's normal analysis of the
defmethod body still runs."
[{:keys [filename node] :as input}]
(let [[_defmethod multimethod & _args] (:children node)
dispatch (when multimethod
(try (hooks/sexpr multimethod) (catch Exception _ nil)))]
(when (and (table-name-dispatch? dispatch)
(not (models-file? filename)))
(hooks/reg-finding!
(assoc (meta multimethod)
:message (format "Toucan2 `table-name` defmethods must live under `<module>/models[/…]` (got %s)"
filename)
:type :metabase/toucan-model-ns))))
;; Delegate to the vendored methodical defmethod hook so kondo's normal
;; analysis of the defmethod body still runs. Resolved lazily because
;; `hooks.methodical.macros` isn't on the classpath during `.clj-kondo/test`
;; unit-test runs.
((requiring-resolve 'hooks.methodical.macros/defmethod) input))

View File

@@ -0,0 +1,46 @@
(ns hooks.metabase.toucan.table-name-test
(:require
[clj-kondo.hooks-api :as hooks]
[clj-kondo.impl.utils]
[clojure.test :refer :all]
[hooks.metabase.toucan.table-name :as toucan.table-name]))
;; `hooks.methodical.macros` isn't on the classpath under `.clj-kondo/test`,
;; so stub it out — `lint-defmethod` delegates to it via `requiring-resolve`.
;; If it ever becomes available, warn so we remember to delete this stub.
(if (find-ns 'hooks.methodical.macros)
(println (str "WARNING: hooks.methodical.macros is now on the test classpath; "
"the stub in " *ns* " is no longer needed and can be removed."))
(do (create-ns 'hooks.methodical.macros)
(intern 'hooks.methodical.macros 'defmethod (fn [input] input))))
(defn- lint-defmethod [form filename]
(binding [clj-kondo.impl.utils/*ctx* {:config {:linters {:metabase/toucan-model-ns {:level :warning}}}
:ignores (atom nil)
:findings (atom [])
:namespaces (atom {})}]
(toucan.table-name/lint-defmethod {:node (hooks/parse-string (pr-str form))
:filename filename})
@(:findings clj-kondo.impl.utils/*ctx*)))
(deftest ^:parallel table-name-must-live-in-models-namespace-test
(testing "defmethod t2/table-name outside a models namespace is flagged"
(is (=? [{:type :metabase/toucan-model-ns}]
(lint-defmethod '(defmethod t2/table-name :model/Foo [_] :foo)
"/repo/src/metabase/foo/core.clj"))))
(testing "defmethod t2/table-name inside <module>/models.clj is allowed"
(is (empty? (lint-defmethod '(defmethod t2/table-name :model/Foo [_] :foo)
"/repo/src/metabase/foo/models.clj"))))
(testing "defmethod t2/table-name inside <module>/models/<model>.clj is allowed"
(is (empty? (lint-defmethod '(defmethod t2/table-name :model/Foo [_] :foo)
"/repo/src/metabase/foo/models/bar.clj"))))
(testing "enterprise modules are also allowed"
(is (empty? (lint-defmethod '(defmethod t2/table-name :model/Foo [_] :foo)
"/repo/enterprise/backend/src/metabase_enterprise/foo/models.clj"))))
(testing "toucan2.core/table-name is also recognized"
(is (=? [{:type :metabase/toucan-model-ns}]
(lint-defmethod '(defmethod toucan2.core/table-name :model/Foo [_] :foo)
"/repo/src/metabase/foo/core.clj"))))
(testing "unrelated defmethods are ignored"
(is (empty? (lint-defmethod '(defmethod t2/primary-keys :model/Foo [_] [:id])
"/repo/src/metabase/foo/core.clj")))))

View File

@@ -188,8 +188,8 @@
metabase.query-processor.error-type/deferror [[:block 1]]
metabase.query-processor.middleware.cache-backend.interface/with-cached-results [[:block 4]]
metabase.query-processor.middleware.process-userland-query-test/with-query-execution [[:block 1]]
metabase.query-processor.pipeline-queries-test/pmbql-query [[:block 1]]
metabase.query-processor.pipeline-queries-test/run-pmbql-query [[:block 1]]
metabase.query-processor.pipeline-queries-test/mbql5-query [[:block 1]]
metabase.query-processor.pipeline-queries-test/run-mbql5-query [[:block 1]]
metabase.query-processor.store/cached [[:block 1]]
metabase.query-processor.store/with-metadata-provider [[:inner 0]]
metabase.query-processor.streaming/streaming-response [[:block 1]]

10
.config/wt.toml Normal file
View File

@@ -0,0 +1,10 @@
# worktrunk project config — https://worktrunk.dev
# Hooks run when switching, creating, merging, or removing worktrees.
# Setup tasks for newly-created worktrees. Run once, blocking, in the
# new worktree's cwd before post-start background tasks kick off.
[pre-start]
# Trust mise config so it loads the project's tool versions without prompting.
trust-mise = "mise trust"
# Install JS deps so husky git hooks get wired up in the new worktree.
bun-install = "bun install"

View File

@@ -7,9 +7,7 @@ inputs:
output-name:
required: true
default: test
aws-access-key-id:
required: true
aws-secret-access-key:
role-to-assume:
required: true
aws-region:
required: true
@@ -30,8 +28,7 @@ runs:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ inputs.aws-access-key-id }}
aws-secret-access-key: ${{ inputs.aws-secret-access-key }}
role-to-assume: ${{ inputs.role-to-assume }}
aws-region: ${{ inputs.aws-region }}
- name: zip test results
env:
@@ -50,13 +47,18 @@ runs:
aws s3 cp ${OUTPUT_FILE}.zip s3://$BUCKET/$DATE/$GITHUB_RUN_ID/$GITHUB_RUN_ATTEMPT/
- name: Upload results to Trunk
if: always() # Important! This step must always run because it controls job's exit code.
# Important!
# 1. This step must always run because it controls job's exit code.
# 2. There's no point in running this outside the organization
if: always() && github.repository_owner == 'metabase'
uses: trunk-io/analytics-uploader@main
env:
TRUNK_REPO_URL: git@github.com:metabase/metabase.git
with:
junit-paths: ${{ inputs.input-path }}
variant: ${{ inputs.variant || inputs.output-name }}
org-slug: metabase
dry-run: ${{ github.event_name == 'pull_request' && github.event.pull_request.draft == true }} # quarantine, but do not upload results
dry-run: ${{ (github.event_name == 'pull_request' && github.event.pull_request.draft == true) || github.repository != 'metabase/metabase' }} # quarantine, but do not upload results
token: ${{ inputs.trunk-api-token }}
use-cache: true
previous-step-outcome: ${{ inputs.previous-step-outcome }}

View File

@@ -200,6 +200,10 @@ cljs:
- ".github/workflows/cljs.yml"
- "shadow-cljs.edn"
serialization_baseline:
- ".github/workflows/serialization.yml"
- "test_resources/serialization_baseline/**"
openapi:
- ".github/workflows/openapi.yml"
- "src/metabase/api/**"

View File

@@ -3,7 +3,7 @@ const { buildMatrix } = require("./build-e2e-matrix");
describe("buildMatrix", () => {
const options = {
java: "11",
defaultRunner: "ubuntu-22.04",
defaultRunner: "${{ vars.DEFAULT_RUNNER_KEY }}",
};
const testBuildMatrix = (entry, chunks) =>
buildMatrix(options, entry, chunks);

10
.github/team.json vendored
View File

@@ -1,13 +1,14 @@
{
"teams": [
{
"name": "Querying",
"label": ".Team/Querying",
"name": "Querying Platform",
"label": ".Team/QueryingPlatform",
"members": [
"bshepherdson",
"metamben",
"rileythomp",
"camsual"
"camsaul",
"technomancy"
]
},
{
@@ -106,7 +107,8 @@
"kamilmielnik",
"stasgavrylov",
"uladzimirdev",
"egorgrushin"
"egorgrushin",
"metatyb"
]
},
{

View File

@@ -14,7 +14,7 @@ concurrency:
jobs:
be-tests-mariadb:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -22,12 +22,12 @@ jobs:
version:
- name: MariaDB 10.6
junit-name: be-tests-mariadb-10-6-ee
image: circleci/mariadb:10.6
image: metabase/mariadb:10.6 # https://github.com/metabase/metabase-mariadb-docker-image
env:
enable-ssl-tests: 'false'
- name: MariaDB Latest
junit-name: be-tests-mariadb-latest-ee
image: circleci/mariadb:latest
image: mariadb:latest
env:
enable-ssl-tests: 'false'
job:
@@ -57,8 +57,8 @@ jobs:
ports:
- "3306:3306"
env:
MYSQL_ALLOW_EMPTY_PASSWORD: true
MYSQL_DATABASE: circle_test
MARIADB_ALLOW_EMPTY_ROOT_PASSWORD: true
MARIADB_DATABASE: mb_test
env:
# Only run old migrations tests on pushes to master or release branches. All other branches should skip tests
# with the tag `mb/old-migrations-test`. `__ADDITIONAL_EXCLUDED_TAG__` is not used anywhere outside of splicing
@@ -81,7 +81,7 @@ jobs:
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
#
@@ -120,15 +120,14 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
be-tests-mysql:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -136,7 +135,7 @@ jobs:
version:
- name: MySQL 8.4
junit-name: be-tests-mysql-8-4-ee
image: cimg/mysql:8.4
image: mysql:8.4
env:
enable-ssl-tests: 'false'
enable-aws-iam-tests: 'false'
@@ -174,7 +173,7 @@ jobs:
- "3306:3306"
env:
MYSQL_ALLOW_EMPTY_PASSWORD: true
MYSQL_DATABASE: circle_test
MYSQL_DATABASE: mb_test
env:
# Only run old migrations tests on pushes to master or release branches. All other branches should skip tests
# with the tag `mb/old-migrations-test`. `__ADDITIONAL_EXCLUDED_TAG__` is not used anywhere outside of splicing
@@ -197,7 +196,7 @@ jobs:
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
#
@@ -244,15 +243,14 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
be-tests-postgres:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -355,8 +353,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -366,7 +363,7 @@ jobs:
- be-tests-mariadb
- be-tests-mysql
- be-tests-postgres
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
name: app-db-tests-result
if: always() && !cancelled()

View File

@@ -8,31 +8,38 @@ on:
required: true
type: string
permissions:
id-token: write
contents: read
jobs:
deploy:
name: Publish Athena JDBC Driver
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- name: Check out the code
uses: actions/checkout@v4
- name: Set up Babashka
uses: turtlequeue/setup-babashka@v1.7.0
uses: turtlequeue/setup-babashka@2d4df498c7a578b4f3e906283f9af913590bdec7 # v1.7.0
with:
babashka-version: 1.12.197
- name: Set up AWS CLI
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
aws-access-key-id: ${{ secrets.AWS_S3_MAVEN_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_S3_MAVEN_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_MAVEN_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- name: Deploy Athena JDBC driver
run: ./bin/athena.bb ${{ github.event.inputs.version }} --deploy
run: ./bin/athena.bb "${VERSION}" --deploy
env:
VERSION: ${{ github.event.inputs.version }}
- name: Verify deployment
env:
VERSION: ${{ github.event.inputs.version }}
run: |
aws s3 ls s3://metabase-maven-downloads/com/metabase/athena-jdbc/${{ github.event.inputs.version }}/
echo "Athena JDBC driver version ${{ github.event.inputs.version }} has been deployed"
aws s3 ls s3://metabase-maven-downloads/com/metabase/athena-jdbc/"${VERSION}"/
echo "Athena JDBC driver version ${VERSION} has been deployed"

View File

@@ -7,10 +7,10 @@ on:
jobs:
update_pr:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- uses: tibdex/github-app-token@v2.1.0
- uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2.1.0
id: generate-token
with:
app_id: ${{ secrets.METABASE_BOT_APP_ID }}

View File

@@ -20,7 +20,7 @@ jobs:
github.event.label.name == 'triple-backport'
)
)
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- uses: actions/checkout@v4
with:

View File

@@ -17,7 +17,7 @@ on:
jobs:
setup-oss:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
outputs:
modules: ${{ steps.get-modules.outputs.modules }}
steps:
@@ -31,7 +31,7 @@ jobs:
needs: setup-oss
# don't run this workflow on a cron for forks
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
strategy:
fail-fast: false
@@ -57,14 +57,14 @@ jobs:
- name: Upload coverage to codecov.io
if: always()
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./target/coverage/codecov.json
flags: back-end
setup-ee:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
outputs:
modules: ${{ steps.get-modules.outputs.modules }}
steps:
@@ -78,7 +78,7 @@ jobs:
needs: setup-ee
# don't run this workflow on a cron for forks
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
strategy:
fail-fast: false
@@ -104,7 +104,7 @@ jobs:
- name: Upload coverage to codecov.io
if: always()
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./target/coverage/codecov.json

View File

@@ -14,7 +14,7 @@ concurrency:
jobs:
be-linter-clj-kondo:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
name: Clj-Kondo
steps:
@@ -26,7 +26,7 @@ jobs:
be-linter-eastwood:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
name: Eastwood
steps:
@@ -37,20 +37,20 @@ jobs:
name: Run Eastwood linter
be-linter-eastwood-test:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
if: ${{ !inputs.skip && github.ref_name == 'master' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
name: Eastwood (test)
name: Eastwood (tests only)
steps:
- uses: actions/checkout@v4
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- run: clojure -X:dev:ee:ee-dev:drivers:drivers-dev:test:eastwood/test
name: Run Eastwood linter on tests
name: Run Eastwood linter on our backend tests
be-tests:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -138,14 +138,13 @@ jobs:
input-path: ./target/junit/
output-name: be-tests-java-${{ matrix.java-version }}-${{ matrix.job.edition }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-java-tests.outcome }}
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@v1
uses: dorny/test-reporter@3eeb9fc888e82e8be2fb356bbeec2750231672bc # v1
if: failure()
with:
path: "target/junit/**/*_test.xml"
@@ -167,7 +166,7 @@ jobs:
# as `:dev` dependencies). See #27009 for more context.
be-check:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
strategy:
matrix:
@@ -183,7 +182,7 @@ jobs:
be-cljfmt:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
name: Cljfmt
steps:
@@ -202,7 +201,7 @@ jobs:
- be-check
- be-tests
if: always() && !cancelled()
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
env:
needs: ${{ toJson(needs) }}

View File

@@ -10,10 +10,10 @@ on:
jobs:
backport-reminder:
name: Decide whether to backport or not
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: jesusvasquez333/verify-pr-label-action@v1.4.0
- uses: jesusvasquez333/verify-pr-label-action@657d111bbbe13e22bbd55870f1813c699bde1401 # v1.4.0
with:
github-token: '${{ secrets.GITHUB_TOKEN }}'
valid-labels: 'no-backport, backport, double-backport, triple-backport'

View File

@@ -5,7 +5,7 @@ on:
jobs:
check-source-branch:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- name: Block master branch PRs
if: github.head_ref == 'master'

View File

@@ -14,7 +14,7 @@ on:
jobs:
start-message:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
@@ -45,7 +45,7 @@ jobs:
}).catch(console.error);
trigger-milestone-check:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
needs: start-message
steps:
@@ -66,7 +66,7 @@ jobs:
check-version:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
outputs:
ee: ${{ fromJson(steps.canonical_version.outputs.result).ee }}
@@ -118,7 +118,7 @@ jobs:
return versions;
check-commit:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- name: Check out the code to verify the release branch
@@ -150,7 +150,7 @@ jobs:
git checkout -
get-build-requirements:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
outputs:
java_version: ${{ fromJson(steps.dependencies.outputs.result).java_version }}
@@ -185,7 +185,7 @@ jobs:
build-uberjar-for-release:
needs: [check-version, check-commit, get-build-requirements]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 50
strategy:
matrix:

View File

@@ -10,7 +10,7 @@ on:
jobs:
test-build-scripts:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- uses: actions/checkout@v4
- name: Prepare back-end environment

View File

@@ -39,7 +39,8 @@ concurrency:
jobs:
get-cache-keys:
runs-on: ubuntu-22.04
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- uses: actions/checkout@v4
- name: Get cache keys
@@ -52,7 +53,7 @@ jobs:
cypress-cache-key: ${{ steps.get-cache-keys.outputs.cypress-cache-key }}
generate-caches:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
needs: get-cache-keys
env:

View File

@@ -7,7 +7,7 @@ on:
jobs:
check-backport-script:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- name: Checkout code
uses: actions/checkout@v4

View File

@@ -15,7 +15,7 @@ on:
jobs:
set-milestone:
name: Automatically set milestone
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
env:
isNewReleaseBranch: ${{ github.event_name == 'workflow_dispatch' }}

View File

@@ -14,14 +14,14 @@ concurrency:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
frontend_all: ${{ steps.changes.outputs.frontend_all }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -30,7 +30,7 @@ jobs:
fe-chromatic:
needs: files-changed
if: contains(github.event.pull_request.labels.*.name, 'chromatic') || (github.ref_name == 'master' && needs.files-changed.outputs.frontend_all == 'true')
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- name: Checkout repository
uses: actions/checkout@v4
@@ -43,7 +43,7 @@ jobs:
- name: Compile CLJS
run: NODE_ENV=development bun run build-pure:cljs
- name: Publish to Chromatic
uses: chromaui/action@v10.2.0
uses: chromaui/action@c03d144dc72e609acbb960489fdd1e1a4a23b34f # v10.2.0
env:
PUBLISH_CHROMATIC: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
STORYBOOK_BUILD_TIMEOUT: 900000

View File

@@ -1,360 +0,0 @@
name: "Claude Code Bug Fix"
on:
issues:
types:
- labeled
pull_request_review:
types:
- submitted
workflow_dispatch:
inputs:
issue_number:
description: "Issue number to fix"
required: true
type: string
override_employee_check:
description: "Override employee check for issue creator"
required: false
default: false
type: boolean
jobs:
auto-fix-bug:
runs-on: ubuntu-latest
timeout-minutes: 30
permissions:
contents: write
issues: write
pull-requests: write
id-token: write
if: |
(github.event_name == 'issues' && github.event.label.name == 'Claude Bug Fix' && github.event.issue.state == 'open') ||
(github.event_name == 'workflow_dispatch') ||
(github.event_name == 'pull_request_review' && github.event.review.state == 'changes_requested' && startsWith(github.event.pull_request.head.ref, 'claude-fix/'))
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.GITHUB_TOKEN }}
- name: Get issue data and check employee status
id: get_issue
uses: actions/github-script@v7
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const { getIssueData } = require('${{ github.workspace }}/.github/scripts/get-issue-data.js');
try {
const result = await getIssueData({
context,
github,
manualIssueNumber: '${{ github.event.inputs.issue_number }}'
});
const { issueNumber, issueData, employeeComments, prReviews, triggerType, isIssueAuthorEmployee } = result;
// Check employee status and fail if not authorized
if (!result.isIssueAuthorEmployee && '${{ github.event.inputs.override_employee_check }}' !== 'true') {
core.setFailed(`User ${result.issueData.user.login} is not a Metabase employee. Skipping bug fix automation.`);
}
core.setOutput('issue_number', issueNumber);
core.setOutput('issue_data', JSON.stringify(issueData));
core.setOutput('issue_comments', JSON.stringify(employeeComments));
core.setOutput('pr_reviews', JSON.stringify(prReviews));
core.setOutput('trigger_type', triggerType);
} catch (error) {
core.setFailed(error.message);
}
- name: Find linked Linear issue
id: find_linear
continue-on-error: true
uses: actions/github-script@v7
env:
LINEAR_API_KEY: ${{ secrets.LINEAR_API_KEY }}
ISSUE_NUMBER: ${{ steps.get_issue.outputs.issue_number }}
with:
script: |
const { findLinearIssue } = require('${{ github.workspace }}/.github/scripts/find-linear-issue.js');
const githubIssueUrl = `https://github.com/${context.repo.owner}/${context.repo.repo}/issues/${process.env.ISSUE_NUMBER}`;
const result = await findLinearIssue({
githubIssueUrl,
linearApiKey: process.env.LINEAR_API_KEY
});
if (result.success) {
console.log(`Found Linear issue: ${result.issue}`);
core.setOutput('linear_issue', result.issue);
} else {
console.log(`Could not find Linear issue: ${result.message}`);
}
- name: Set up git configuration
run: |
git config --global user.name "Claude Code[bot]"
git config --global user.email "noreply@anthropic.com"
- name: Prepare issue context and bug fix prompt
id: prepare_prompt
uses: actions/github-script@v7
env:
ISSUE_DATA: ${{ steps.get_issue.outputs.issue_data }}
ISSUE_COMMENTS: ${{ steps.get_issue.outputs.issue_comments }}
PR_REVIEWS: ${{ steps.get_issue.outputs.pr_reviews }}
TRIGGER_TYPE: ${{ steps.get_issue.outputs.trigger_type }}
with:
script: |
const issueData = JSON.parse(process.env.ISSUE_DATA);
const issueComments = JSON.parse(process.env.ISSUE_COMMENTS);
const prReviews = JSON.parse(process.env.PR_REVIEWS);
const triggerType = process.env.TRIGGER_TYPE;
const issueNumber = '${{ steps.get_issue.outputs.issue_number }}';
// Convert issue title to kebab case and create branch name
const issueTitle = issueData.title || 'untitled';
const kebabTitle = issueTitle
.toLowerCase()
.replace(/[^a-z0-9]+/g, '-')
.replace(/^-+|-+$/g, '')
.replace(/-+/g, '-')
.substring(0, 50);
const branchName = `claude-fix/issue-${issueNumber}-${kebabTitle}`;
// Format data for bash environment
const formattedComments = issueComments.length > 0
? issueComments.map(comment =>
`**Comment by @${comment.user.login} on ${comment.created_at}:**\n${comment.body}`
).join('\n\n---\n\n')
: '';
const formattedReviews = prReviews.length > 0
? prReviews.map(review =>
`**Review by @${review.user.login} on ${review.submitted_at} (Changes Requested):**\n${review.body || 'No review comment provided'}`
).join('\n\n---\n\n')
: '';
core.exportVariable('BRANCH_NAME', branchName);
core.exportVariable('ISSUE_NUMBER', issueNumber);
core.exportVariable('ISSUE_TITLE', issueData.title);
core.exportVariable('ISSUE_AUTHOR', issueData.user.login);
core.exportVariable('ISSUE_CREATED', issueData.created_at);
core.exportVariable('ISSUE_BODY', issueData.body || 'No description provided');
core.exportVariable('ISSUE_COMMENTS_FORMATTED', formattedComments);
core.exportVariable('PR_REVIEWS_FORMATTED', formattedReviews);
core.exportVariable('TRIGGER_TYPE', triggerType);
- name: Generate bug fix prompt
run: |
cat << 'EOF' >> $GITHUB_ENV
BUG_FIX_PROMPT<<PROMPT_END
You are helping to fix a bug reported in GitHub issue #${{ env.ISSUE_NUMBER }}.
## Bug Report Details
**Title:** ${{ env.ISSUE_TITLE }}
**Reporter:** ${{ env.ISSUE_AUTHOR }}
**Created:** ${{ env.ISSUE_CREATED }}
**Description:**
${{ env.ISSUE_BODY }}
**Comments:**
${{ env.ISSUE_COMMENTS_FORMATTED }}
EOF
# Add review feedback section only if this is a review trigger
if [ "${{ env.TRIGGER_TYPE }}" = "pull_request_review" ]; then
cat << 'EOF' >> $GITHUB_ENV
## Previous Fix Attempt - Review Feedback (MUST ADDRESS)
Your previous automated fix attempt received the following feedback that needs to be addressed:
${{ env.PR_REVIEWS_FORMATTED }}
EOF
fi
# Add the rest of the prompt (always the same)
cat << 'EOF' >> $GITHUB_ENV
## Instructions
1. **Analyze the issue description and comments** - Understand what the issue is describing
a. Pay particular attention to reproduction steps and if there's an agreed upon fix.
2. **Search the codebase** - Use Grep and Glob tools to find relevant files
3. **Implement a fix** - Use the appropriate write skill based on the file types:
- Use clojure-write for Clojure/ClojureScript files
- Use typescript-write for TypeScript/JavaScript files
- Follow the coding standards and patterns in each skill
4. **Test the fix** - Run appropriate tests as specified in the skills
5. **Verify the fix** - Ensure tests pass and code follows conventions
## Important Guidelines
- Use the appropriate write skill for the language you're working in
- Write failing tests first, then fix them
- Work in small, testable increments
- Don't commit changes - leave that for the workflow
- IMPORTANT: Focus only on fixing the reported bug, don't make unrelated changes
## Scratchpad Directory
A `.claude-scratchpad/` directory has been created for your temporary files:
- Use this directory for ALL temporary verification files. However, prefer using production test files rather than adhoc ones.
- Only modify actual production code in the main repository directories
- The scratchpad will be cleaned up automatically - nothing from it will be committed
Start by understanding the bug and then systematically work toward a solution.
PROMPT_END
EOF
- name: Determine branch strategy
run: |
BRANCH_NAME="${{ env.BRANCH_NAME }}"
if git branch -r --list "origin/${BRANCH_NAME}" | grep -q .; then
echo "Branch already exists: $BRANCH_NAME"
echo "Will push to existing branch and skip PR creation"
echo "BRANCH_EXISTS=true" >> $GITHUB_ENV
else
echo "Creating new branch: $BRANCH_NAME"
echo "Will create new PR"
echo "BRANCH_EXISTS=false" >> $GITHUB_ENV
fi
# Export the branch name
echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_ENV
- name: Create scratchpad directory for Claude
run: |
# Create a scratchpad directory for Claude to use for temporary files
mkdir -p .claude-scratchpad
echo "Scratchpad directory created for Claude's temporary verification files"
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
- name: Prepare back-end environment
uses: ./.github/actions/prepare-backend
- name: Generate GitHub App Token for Claude
uses: actions/create-github-app-token@v1
id: claude-app-token
with:
app-id: ${{ secrets.METABASE_BOT_APP_ID }}
private-key: ${{ secrets.METABASE_BOT_APP_PRIVATE_KEY }}
- name: Generate Bug Fix with Claude Code
uses: anthropics/claude-code-action@v1
with:
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
github_token: ${{ steps.claude-app-token.outputs.token }}
prompt: ${{ env.BUG_FIX_PROMPT }}
claude_args: |
--allowedTools "Bash(bun run test-unit*),Bash(bun run lint-eslint-pure),Bash(./bin/mage*),Bash(clojure*),Bash(find*),Bash(ls*),Bash(grep*),Write,Read,Glob,Grep,Edit,MultiEdit"
--disallowedTools "Bash(git commit*),Bash(git push*),Bash(gh*)"
- name: Clean up scratchpad directory
run: |
# Remove the scratchpad directory so its contents don't get committed
rm -rf .claude-scratchpad/
# Remove output file generated by Claude Code action
rm -f output.txt
echo "Scratchpad directory and action output files cleaned up"
- name: Check for changes and analysis
id: check_changes
run: |
# Now check for actual code changes (excluding analysis file)
if [ -n "$(git status --porcelain)" ]; then
echo "has_changes=true" >> $GITHUB_OUTPUT
echo "Changes detected:"
git status --short
else
echo "has_changes=false" >> $GITHUB_OUTPUT
echo "No changes made by Claude."
fi
- name: Get issue team labels and prepare reviewers
if: steps.check_changes.outputs.has_changes == 'true'
id: prepare_reviewers
uses: actions/github-script@v7
env:
ISSUE_DATA: ${{ steps.get_issue.outputs.issue_data }}
with:
script: |
const issueData = JSON.parse(process.env.ISSUE_DATA);
const issueLabels = issueData.labels.map(label => label.name);
const teamLabels = issueLabels.filter(label => label.startsWith('.Team/'));
const issueCreator = issueData.user.login;
core.setOutput('team_labels', teamLabels.join(','));
core.setOutput('reviewers', issueCreator);
- name: Create Pull Request
id: create_pr
if: steps.check_changes.outputs.has_changes == 'true'
uses: peter-evans/create-pull-request@v6
with:
token: ${{ secrets.GITHUB_TOKEN }}
branch: ${{ env.BRANCH_NAME }}
base: master
commit-message: |
Fix: ${{ env.ISSUE_TITLE }}
Fixes #${{ env.ISSUE_NUMBER }}
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
committer: "Claude Code[bot] <noreply@anthropic.com>"
author: "Claude Code[bot] <noreply@anthropic.com>"
title: "Fix: ${{ env.ISSUE_TITLE }}"
body: |
This PR automatically fixes the bug reported in #${{ env.ISSUE_NUMBER }}.
${{ steps.find_linear.outputs.linear_issue && format('Closes {0}', steps.find_linear.outputs.linear_issue) || '' }}
## Bug Report
**Original Issue:** #${{ env.ISSUE_NUMBER }}
**Reporter:** @${{ env.ISSUE_AUTHOR }}
**Issue Title:** ${{ env.ISSUE_TITLE }}
## Automated Fix
🤖 This fix was generated automatically by Claude Code based on the issue description.
**Please review carefully:**
- [ ] The fix addresses the reported issue
- [ ] Tests pass and code follows conventions
- [ ] No unrelated changes were introduced
- [ ] The solution is appropriate and maintainable
## Next Steps
- Review the changes and test thoroughly
- If the fix looks good, approve and merge
- If issues are found, either fix them or close this PR
---
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
labels: |
${{ steps.prepare_reviewers.outputs.team_labels }}
automated-fix
ci skip
reviewers: ${{ steps.prepare_reviewers.outputs.reviewers }}
assignees: ${{ github.actor }}
- name: Log existing branch update
if: steps.check_changes.outputs.has_changes == 'true' && env.BRANCH_EXISTS == 'true'
uses: actions/github-script@v7
with:
script: |
console.log('🔄 Updated existing branch: ${{ env.BRANCH_NAME }}');
console.log('The changes have been pushed to the existing PR for this issue.');
- name: Log analysis for no changes
if: steps.check_changes.outputs.has_changes == 'false'
uses: actions/github-script@v7
with:
script: |
console.log('🤖 No code changes were made by Claude.');

View File

@@ -14,14 +14,14 @@ concurrency:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
cljs: ${{ steps.changes.outputs.cljs }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -30,7 +30,7 @@ jobs:
shared-tests-cljs:
needs: files-changed
if: needs.files-changed.outputs.cljs == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
steps:
- uses: actions/checkout@v4

View File

@@ -10,14 +10,14 @@ on:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
codeql: ${{ steps.changes.outputs.codeql }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -25,7 +25,7 @@ jobs:
analyze:
needs: files-changed
if: needs.files-changed.outputs.codeql == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- name: Checkout repository
uses: actions/checkout@v4

View File

@@ -8,7 +8,8 @@ on:
jobs:
codespell:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
permissions:
contents: write
@@ -67,7 +68,7 @@ jobs:
- name: Fix spelling errors with Claude Code
if: steps.codespell_check.outcome == 'failure'
uses: anthropics/claude-code-action@v1
uses: anthropics/claude-code-action@3ac52d0da9f8ec9ca7b4dc23bb477e36ef9c77a9 # v1
with:
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
github_token: ${{ steps.claude-app-token.outputs.token }}
@@ -82,7 +83,7 @@ jobs:
- name: Create Pull Request
if: steps.codespell_check.outcome == 'failure'
uses: peter-evans/create-pull-request@v6
uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c # v6
with:
token: ${{ secrets.GITHUB_TOKEN }}
branch: claude-fix/codespell-${{ steps.date.outputs.date }}

View File

@@ -48,7 +48,7 @@ on:
jobs:
containerize:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
outputs:
platforms: ${{ steps.platforms.outputs.result }}
@@ -84,19 +84,19 @@ jobs:
- name: Move the Uberjar to the context dir
run: mv ./metabase.jar bin/docker/.
- name: Login to Docker Hub
uses: docker/login-action@v3
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3
with:
username: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_USERNAME || secrets.DOCKERHUB_USERNAME }}
password: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_TOKEN || secrets.DOCKERHUB_TOKEN }}
- name: Set up QEMU
if: contains(steps.platforms.outputs.result, 'arm')
uses: docker/setup-qemu-action@v3
uses: docker/setup-qemu-action@c7c53464625b32c7a7e944ae62b3e17d2b600130 # v3
- name: Set up Docker Buildx
if: contains(steps.platforms.outputs.result, 'arm')
uses: docker/setup-buildx-action@v3
uses: docker/setup-buildx-action@8d2750c68a42422c14e847fe6c8ac0403b4cbd6f # v3
- name: Build multi-arch container
if: contains(steps.platforms.outputs.result, 'arm')
uses: docker/build-push-action@v6
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6
with:
context: bin/docker/.
platforms: ${{ steps.platforms.outputs.result }}
@@ -117,12 +117,12 @@ jobs:
bin/docker/.
verify-docker-pull:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: containerize
timeout-minutes: 15
steps:
- name: Login to Docker Hub
uses: docker/login-action@v3
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3
with:
username: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_USERNAME || secrets.DOCKERHUB_USERNAME }}
password: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_TOKEN || secrets.DOCKERHUB_TOKEN }}
@@ -142,7 +142,7 @@ jobs:
timeout-minutes: 15
steps:
- name: Login to Docker Hub
uses: docker/login-action@v3
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3
with:
username: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_USERNAME || secrets.DOCKERHUB_USERNAME }}
password: ${{ inputs.release == 'true' && secrets.DOCKERHUB_RELEASE_TOKEN || secrets.DOCKERHUB_TOKEN }}

View File

@@ -6,7 +6,7 @@ on:
jobs:
get-container-info:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
name: Get container info
outputs:
@@ -68,7 +68,7 @@ jobs:
strategy:
matrix:
edition: ${{ fromJson(needs.get-container-info.outputs.editions) }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: Run Trivy vulnerability scanner
steps:
- name: Check out the code
@@ -76,7 +76,7 @@ jobs:
with:
ref: ${{ github.event.inputs.commit || github.event.pull_request.head.sha || github.sha }}
- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@0.29.0
uses: aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1
env:
TRIVY_OFFLINE_SCAN: true
repo: ${{ fromJson(needs.get-container-info.outputs[matrix.edition]).repo }}
@@ -85,7 +85,6 @@ jobs:
image-ref: docker.io/${{ env.repo }}:${{ env.tag }}
format: sarif
output: trivy-results.sarif
version: "v0.57.1"
- name: Upload Trivy scan results to GitHub Security tab
uses: github/codeql-action/upload-sarif@v3
with:
@@ -94,7 +93,7 @@ jobs:
post-comment:
needs: [get-container-info, containerize]
if: github.event_name == 'pull_request'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: Post PR comment
steps:
- name: Check out the code
@@ -107,7 +106,7 @@ jobs:
edition: ee
- name: Post PR comment
uses: marocchino/sticky-pull-request-comment@v2
uses: marocchino/sticky-pull-request-comment@773744901bac0e8cbb5a0dc842800d45e9b2b405 # v2
with:
header: docker-build-status
message: |

View File

@@ -8,21 +8,21 @@ on:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
frontend_embedding_sources: ${{ steps.changes.outputs.frontend_embedding_sources }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
filters: .github/file-paths.yaml
pr-title-reminder:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
permissions:
pull-requests: write

View File

@@ -7,7 +7,8 @@ on:
jobs:
fe-test-coverage:
runs-on: ubuntu-22.04
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
@@ -22,7 +23,7 @@ jobs:
--coverage \
--testTimeout=60000
- name: Upload coverage to codecov.io
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5
with:
files: ./coverage/lcov.info
flags: front-end

View File

@@ -25,7 +25,7 @@ concurrency:
jobs:
migrations-h2-ee:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
CI: 'true'
@@ -39,23 +39,23 @@ jobs:
head-ref: ${{ env.HEAD_REF }}
migrations-postgres-14-ee:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
CI: 'true'
MB_DB_TYPE: postgres
MB_DB_PORT: 5432
MB_DB_HOST: localhost
MB_DB_DBNAME: circle_test
MB_DB_USER: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: mb_test
services:
postgres:
image: postgres:14-alpine
ports:
- "5432:5432"
env:
POSTGRES_USER: circle_test
POSTGRES_DB: circle_test
POSTGRES_USER: mb_test
POSTGRES_DB: mb_test
POSTGRES_HOST_AUTH_METHOD: trust
steps:
- uses: actions/checkout@v4
@@ -65,23 +65,23 @@ jobs:
head-ref: ${{ env.HEAD_REF }}
migrations-postgres-latest-ee:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
CI: 'true'
MB_DB_TYPE: postgres
MB_DB_PORT: 5432
MB_DB_HOST: localhost
MB_DB_DBNAME: circle_test
MB_DB_USER: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: mb_test
services:
postgres:
image: circleci/postgres:latest
image: postgres:latest
ports:
- "5432:5432"
env:
POSTGRES_USER: circle_test
POSTGRES_DB: circle_test
POSTGRES_USER: mb_test
POSTGRES_DB: mb_test
POSTGRES_HOST_AUTH_METHOD: trust
steps:
- uses: actions/checkout@v4
@@ -91,20 +91,23 @@ jobs:
head-ref: ${{ env.HEAD_REF }}
migrations-mysql-8-4-ee:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
CI: 'true'
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
services:
mysql:
image: cimg/mysql:8.4
image: mysql:8.4
ports:
- "3306:3306"
env:
MYSQL_ALLOW_EMPTY_PASSWORD: true
MYSQL_DATABASE: mb_test
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/cross-branch-migration-test
@@ -113,14 +116,14 @@ jobs:
head-ref: ${{ env.HEAD_REF }}
migrations-mysql-latest-ee:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
CI: 'true'
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
services:
@@ -128,7 +131,7 @@ jobs:
image: mysql:latest
env:
MYSQL_ALLOW_EMPTY_PASSWORD: true
MYSQL_DATABASE: circle_test
MYSQL_DATABASE: mb_test
ports:
- "3306:3306"
steps:
@@ -139,20 +142,23 @@ jobs:
head-ref: ${{ env.HEAD_REF }}
migrations-mariadb-10-6-ee:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
CI: 'true'
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
services:
mariadb:
image: circleci/mariadb:10.6
image: metabase/mariadb:10.6 # https://github.com/metabase/metabase-mariadb-docker-image
ports:
- "3306:3306"
env:
MARIADB_ALLOW_EMPTY_ROOT_PASSWORD: true
MARIADB_DATABASE: mb_test
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/cross-branch-migration-test
@@ -161,20 +167,23 @@ jobs:
head-ref: ${{ env.HEAD_REF }}
migrations-mariadb-latest-ee:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
CI: 'true'
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
services:
mariadb:
image: circleci/mariadb:latest
image: mariadb:latest
ports:
- "3306:3306"
env:
MARIADB_ALLOW_EMPTY_ROOT_PASSWORD: true
MARIADB_DATABASE: mb_test
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/cross-branch-migration-test

View File

@@ -25,8 +25,8 @@ on:
jobs:
# Generate matrix for scheduled/PR runs
generate-matrix:
if: github.event_name != 'workflow_dispatch'
runs-on: ubuntu-latest
if: github.event_name != 'workflow_dispatch' && github.repository == 'metabase/metabase'
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
@@ -47,9 +47,9 @@ jobs:
# Matrix-based tests for scheduled/PR runs
test-matrix:
if: github.event_name != 'workflow_dispatch'
if: github.event_name != 'workflow_dispatch' && github.repository == 'metabase/metabase'
needs: generate-matrix
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
strategy:
matrix: ${{ fromJson(needs.generate-matrix.outputs.matrix) }}
@@ -61,13 +61,38 @@ jobs:
- name: Prepare release scripts
uses: ./.github/actions/prepare-release-scripts
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
- name: Prepare Cypress environment
uses: ./.github/actions/prepare-cypress
- name: Run cross-version test
env:
CURRENT_VERSION: ${{ vars.CURRENT_VERSION }}
RESULT_FILE: ${{ runner.temp }}/cross-version-result-${{ matrix.source }}-${{ matrix.target }}.json
run: |
cd cross-version
./test.sh --source "${{ matrix.source }}" --target "${{ matrix.target }}"
- name: Upload failure result
uses: actions/upload-artifact@v4
if: failure()
with:
name: failure-result-${{ matrix.source }}-${{ matrix.target }}
path: ${{ runner.temp }}/cross-version-result-${{ matrix.source }}-${{ matrix.target }}.json
if-no-files-found: ignore
- name: Upload Cypress Artifacts upon failure
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-recording-${{ matrix.source }}-${{ matrix.target }}
path: |
./cypress
./logs/test.log
if-no-files-found: ignore
- name: Show logs on failure
if: failure()
run: |
@@ -75,10 +100,92 @@ jobs:
docker compose logs metabase || true
docker compose logs postgres || true
# Notify Slack on nightly failures
notify-on-failure:
if: >-
always()
&& github.event_name == 'schedule'
&& github.repository == 'metabase/metabase'
&& needs.test-matrix.result == 'failure'
needs: [test-matrix]
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
with:
sparse-checkout: |
release
.github
- name: Prepare release scripts
uses: ./.github/actions/prepare-release-scripts
- name: Download failure results
uses: actions/download-artifact@v4
continue-on-error: true
with:
pattern: failure-result-*
path: failure-results
merge-multiple: true
- name: Notify Slack
continue-on-error: true
uses: actions/github-script@v7
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
with:
script: |
const fs = require('fs');
const path = require('path');
const { buildFailureResults, sendCrossVersionSlackNotification } = require('${{ github.workspace }}/release/dist/index.cjs');
// Get all failed jobs from the GitHub API
const { owner, repo } = context.repo;
const jobInfo = await github.rest.actions.listJobsForWorkflowRun({
owner,
repo,
run_id: context.runId,
per_page: 100,
});
const failedJobs = jobInfo.data.jobs
.filter(job => job.status === 'completed' && job.conclusion === 'failure' && job.name.startsWith('test-matrix'))
.map(job => ({ name: job.name, url: job.html_url }));
if (failedJobs.length === 0) {
console.log('No failed test-matrix jobs found');
return;
}
// Load artifact data for enrichment (phase)
const resultsDir = 'failure-results';
const artifactData = new Map();
if (fs.existsSync(resultsDir)) {
for (const file of fs.readdirSync(resultsDir)) {
if (!file.endsWith('.json')) continue;
try {
const result = JSON.parse(fs.readFileSync(path.join(resultsDir, file), 'utf8'));
artifactData.set(`${result.source}-${result.target}`, result);
} catch (e) {
console.log(`Skipping malformed result: ${file}`);
}
}
}
const failures = buildFailureResults(failedJobs, artifactData);
const runUrl = `${process.env.GITHUB_SERVER_URL}/${process.env.GITHUB_REPOSITORY}/actions/runs/${context.runId}`;
const slackBotToken = process.env.SLACK_BOT_TOKEN;
if (!slackBotToken) {
console.log('SLACK_BOT_TOKEN is not set; skipping Slack notification.');
return;
}
await sendCrossVersionSlackNotification(failures, runUrl, slackBotToken);
console.log('Slack notification sent');
# Manual test for workflow_dispatch
test-manual:
if: github.event_name == 'workflow_dispatch'
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
steps:
@@ -87,6 +194,12 @@ jobs:
- name: Prepare release scripts
uses: ./.github/actions/prepare-release-scripts
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
- name: Prepare Cypress environment
uses: ./.github/actions/prepare-cypress
- name: Run cross-version test
env:
CURRENT_VERSION: ${{ vars.CURRENT_VERSION }}
@@ -94,6 +207,16 @@ jobs:
cd cross-version
./test.sh --source "${{ inputs.source_version }}" --target "${{ inputs.target_version }}"
- name: Upload Cypress Artifacts upon failure
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-recording-${{ inputs.source_version }}-${{ inputs.target_version }}
path: |
./cypress
./logs/test.log
if-no-files-found: ignore
- name: Show logs on failure
if: failure()
run: |

View File

@@ -7,7 +7,8 @@ on:
jobs:
notify-disabled-drivers:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: actions/setup-node@v4

View File

@@ -21,7 +21,7 @@ permissions:
jobs:
update-docs:
name: Update documentation for ${{ inputs.target_branch }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
steps:
- name: Checkout code

View File

@@ -7,7 +7,7 @@ on:
jobs:
link-checker:
name: Check documentation links
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
permissions:
contents: read
@@ -27,7 +27,7 @@ jobs:
- name: Run link checker
id: link-check
uses: lycheeverse/lychee-action@v2.3.0
uses: lycheeverse/lychee-action@f613c4a64e50d792e0b31ec34bbcbba12263c6a6 # v2.3.0
with:
fail: true
args: docs --config ./.lychee/config.toml --offline

View File

@@ -2,11 +2,12 @@ name: Auto-update documentation (master)
on:
schedule:
- cron: "0 1 * * 1-5" # Every Monday through Friday at 1 AM UTC
- cron: "0 21 * * 1-5" # Every Monday through Friday at 9 PM UTC
workflow_dispatch:
jobs:
update-master-docs:
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
name: Call documentation update for master
uses: ./.github/workflows/docs-generate-base.yml
with:

View File

@@ -2,7 +2,7 @@ name: Auto-update documentation (release)
on:
schedule:
- cron: "0 2 * * 1-5" # Every Monday through Friday at 2 AM UTC
- cron: "0 22 * * 1-5" # Every Monday through Friday at 10 PM UTC
workflow_dispatch:
inputs:
target_branch:
@@ -13,6 +13,7 @@ on:
jobs:
update-release-docs:
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
name: Call documentation update for release branch
uses: ./.github/workflows/docs-generate-base.yml
with:

View File

@@ -49,7 +49,7 @@ jobs:
be-tests-athena-ee:
if: inputs.driver == 'Athena'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -68,7 +68,7 @@ jobs:
be-tests-bigquery-cloud-sdk-ee:
if: inputs.driver == 'BigQuery'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -89,7 +89,7 @@ jobs:
be-tests-druid-ee:
if: inputs.driver == 'Druid'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -111,7 +111,7 @@ jobs:
be-tests-mariadb-10-6-ee:
if: inputs.driver == 'Maria DB'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -119,14 +119,17 @@ jobs:
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
services:
mariadb:
image: circleci/mariadb:10.6
image: metabase/mariadb:10.6 # https://github.com/metabase/metabase-mariadb-docker-image
ports:
- "3306:3306"
env:
MARIADB_ALLOW_EMPTY_ROOT_PASSWORD: true
MARIADB_DATABASE: mb_test
steps:
- uses: actions/checkout@v4
- name: Test MariaDB driver (10.6)
@@ -137,7 +140,7 @@ jobs:
be-tests-mariadb-latest-ee:
if: inputs.driver == 'Maria DB (latest)'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -145,14 +148,17 @@ jobs:
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
services:
mariadb:
image: circleci/mariadb:latest
image: mariadb:latest
ports:
- "3306:3306"
env:
MARIADB_ALLOW_EMPTY_ROOT_PASSWORD: true
MARIADB_DATABASE: mb_test
steps:
- uses: actions/checkout@v4
- name: Test MariaDB driver (latest)
@@ -163,7 +169,7 @@ jobs:
be-tests-mongo-4-4-ee:
if: inputs.driver == 'Mongo 4'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -185,7 +191,7 @@ jobs:
be-tests-mongo-4-4-ssl-ee:
if: inputs.driver == 'Mongo 4 (SSL)'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -219,7 +225,7 @@ jobs:
be-tests-mongo-5-0-ee:
if: inputs.driver == 'Mongo 5'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -241,7 +247,7 @@ jobs:
be-tests-mongo-5-0-ssl-ee:
if: inputs.driver == 'Mongo 5 (SSL)'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -275,7 +281,7 @@ jobs:
be-tests-mongo-latest-ee:
if: inputs.driver == 'Mongo (latest)'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -284,7 +290,7 @@ jobs:
MB_MONGO_TEST_PASSWORD: metasample123
services:
mongodb:
image: circleci/mongo:latest
image: mongo:latest
ports:
- "27017:27017"
env:
@@ -300,7 +306,7 @@ jobs:
be-tests-mysql-8-4-ee:
if: inputs.driver == 'MySQL'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -308,14 +314,17 @@ jobs:
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
services:
mysql:
image: cimg/mysql:8.4
image: mysql:8.4
ports:
- "3306:3306"
env:
MYSQL_ALLOW_EMPTY_PASSWORD: true
MYSQL_DATABASE: mb_test
steps:
- uses: actions/checkout@v4
- name: Test MySQL driver (8.4)
@@ -326,7 +335,7 @@ jobs:
be-tests-mysql-latest-ee:
if: inputs.driver == 'MySQL (latest)'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -334,7 +343,7 @@ jobs:
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
# set up env vars for something named "MYSQL_SSL" to run MySQL SSL tests verifying connectivity with PEM cert
@@ -364,7 +373,7 @@ jobs:
be-tests-oracle-18-4-ee:
if: inputs.driver == 'Oracle 18'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -390,7 +399,7 @@ jobs:
be-tests-oracle-21-3-ee:
if: inputs.driver == 'Oracle 21'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -425,7 +434,7 @@ jobs:
be-tests-postgres-ee:
if: inputs.driver == 'Postgres'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -455,7 +464,7 @@ jobs:
be-tests-postgres-latest-ee:
if: inputs.driver == 'Postgres (latest)'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -463,20 +472,20 @@ jobs:
MB_DB_TYPE: postgres
MB_DB_PORT: 5432
MB_DB_HOST: localhost
MB_DB_DBNAME: circle_test
MB_DB_USER: circle_test
MB_POSTGRESQL_TEST_USER: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: mb_test
MB_POSTGRESQL_TEST_USER: mb_test
MB_POSTGRES_SSL_TEST_SSL: true
MB_POSTGRES_SSL_TEST_SSL_MODE: verify-full
MB_POSTGRES_SSL_TEST_SSL_ROOT_CERT_PATH: 'test-resources/certificates/us-east-2-bundle.pem'
services:
postgres:
image: circleci/postgres:latest
image: postgres:latest
ports:
- "5432:5432"
env:
POSTGRES_USER: circle_test
POSTGRES_DB: circle_test
POSTGRES_USER: mb_test
POSTGRES_DB: mb_test
POSTGRES_HOST_AUTH_METHOD: trust
steps:
- uses: actions/checkout@v4
@@ -488,7 +497,7 @@ jobs:
be-tests-presto-jdbc-ee:
if: inputs.driver == 'Presto JDBC'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -537,7 +546,7 @@ jobs:
be-tests-redshift-ee:
if: inputs.driver == 'Redshift'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -556,7 +565,7 @@ jobs:
be-tests-snowflake-ee:
if: inputs.driver == 'Snowflake'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -577,7 +586,7 @@ jobs:
be-tests-sparksql-ee:
if: inputs.driver == 'SparkSQL'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -597,7 +606,7 @@ jobs:
be-tests-sqlite-ee:
if: inputs.driver == 'SQLite'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -612,7 +621,7 @@ jobs:
be-tests-sqlserver-2017-ee:
if: inputs.driver == 'SQL Server 2017'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -639,7 +648,7 @@ jobs:
be-tests-sqlserver-2022-ee:
if: inputs.driver == 'SQL Server 2022'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -666,7 +675,7 @@ jobs:
be-tests-starburst-ee:
if: inputs.driver == 'Starburst'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
env:
CI: 'true'
@@ -691,14 +700,14 @@ jobs:
login-to-ecr:
if: inputs.driver == 'Vertica'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
permissions:
id-token: write
contents: read
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
role-to-assume: ${{ secrets.CI_IAM_ROLE }}
role-session-name: GitHub_to_AWS_via_FederatedOIDC
@@ -720,7 +729,7 @@ jobs:
be-tests-vertica-ee:
if: inputs.driver == 'Vertica'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: login-to-ecr
timeout-minutes: 90
env:

View File

@@ -15,7 +15,7 @@ jobs:
# This job determines which driver tests should run based on PR context.
# All decision logic is consolidated in mage driver-decisions.
determine-driver-skips:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
outputs:
# All driver run decisions (from mage driver-decisions)
h2-should-run: ${{ steps.driver-decisions.outputs.h2-should-run }}
@@ -72,8 +72,8 @@ jobs:
# All decision logic is in mage - it analyzes module dependencies,
# branch context, labels, and file changes to decide what runs.
MAGE_ARGS=(
--git-ref="${{ github.event.pull_request.base.ref || github.ref_name }}"
--is-master-or-release="${{ github.ref_name == 'master' || startsWith(github.ref_name, 'release-') }}"
--git-ref="${BASE_REF}"
--is-master-or-release="${IS_MASTER_OR_RELEASE}"
--pr-labels="${{ join(github.event.pull_request.labels.*.name, ',') }}"
--skip="${{ inputs.skip }}"
)
@@ -82,14 +82,20 @@ jobs:
echo ""
# First call: show human-readable output for debugging
./bin/mage -driver-decisions "${MAGE_ARGS[@]}"
echo ""
echo "Want to force-run a specific driver? Add a ci:run-<driver> or ci:run-all-drivers label to your PR."
echo "Run './bin/mage -driver-decisions -h' locally for the full list of drivers and labels."
# Second call: output only key=value lines for GITHUB_OUTPUT
./bin/mage -driver-decisions "${MAGE_ARGS[@]}" --github-output-only >> $GITHUB_OUTPUT
env:
BASE_REF: ${{ github.event.pull_request.base.ref || github.ref_name }}
IS_MASTER_OR_RELEASE: ${{ github.ref_name == 'master' || startsWith(github.ref_name, 'release-') }}
shell: bash
be-tests-athena-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.athena-should-run == 'true' || needs.determine-driver-skips.outputs.athena-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -131,8 +137,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -140,7 +145,7 @@ jobs:
be-tests-bigquery-cloud-sdk-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.bigquery-should-run == 'true' || needs.determine-driver-skips.outputs.bigquery-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 60
strategy:
fail-fast: false
@@ -197,8 +202,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -212,7 +216,7 @@ jobs:
be-tests-clickhouse-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.clickhouse-should-run == 'true' || needs.determine-driver-skips.outputs.clickhouse-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -255,7 +259,7 @@ jobs:
run: |
sudo echo "127.0.0.1 server.clickhouseconnect.test" | sudo tee -a /etc/hosts
- name: Start ClickHouse in Docker
uses: hoverkraft-tech/compose-action@v2.0.0
uses: hoverkraft-tech/compose-action@802a148945af6399a338c7906c267331b39a71af # v2.0.0
with:
compose-file: "modules/drivers/clickhouse/docker-compose.yml"
down-flags: "--volumes"
@@ -280,8 +284,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -295,7 +298,7 @@ jobs:
be-tests-druid-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.druid-should-run == 'true' || needs.determine-driver-skips.outputs.druid-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -335,8 +338,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -344,7 +346,7 @@ jobs:
be-tests-druid-jdbc-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.druid-jdbc-should-run == 'true' || needs.determine-driver-skips.outputs.druid-jdbc-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -384,8 +386,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -393,7 +394,7 @@ jobs:
be-tests-databricks-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.databricks-should-run == 'true' || needs.determine-driver-skips.outputs.databricks-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -433,8 +434,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -442,7 +442,7 @@ jobs:
be-tests-databricks-multi-catalog-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.databricks-should-run == 'true' || needs.determine-driver-skips.outputs.databricks-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -483,8 +483,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -492,7 +491,7 @@ jobs:
be-tests-h2:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.h2-should-run == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -514,8 +513,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -523,7 +521,7 @@ jobs:
be-tests-h2-oss:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.h2-should-run == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -546,8 +544,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -555,7 +552,7 @@ jobs:
be-tests-mysql-mariadb:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.mysql-mariadb-should-run == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -563,13 +560,13 @@ jobs:
version:
- name: MariaDB 10.6
junit-name: be-tests-mariadb-10-6-ee
image: circleci/mariadb:10.6
image: metabase/mariadb:10.6 # https://github.com/metabase/metabase-mariadb-docker-image
env:
enable-ssl-tests: 'false'
enable-aws-iam-tests: 'false'
- name: MariaDB Latest
junit-name: be-tests-mariadb-latest-ee
image: circleci/mariadb:latest
image: mariadb:latest
env:
enable-ssl-tests: 'false'
enable-aws-iam-tests: 'false'
@@ -602,7 +599,7 @@ jobs:
- "3306:3306"
env:
MYSQL_ALLOW_EMPTY_PASSWORD: true
MYSQL_DATABASE: circle_test
MYSQL_DATABASE: mb_test
env:
# Only run old migrations tests on pushes to master or release branches. All other branches should skip tests
# with the tag `mb/old-migrations-test`. `__ADDITIONAL_EXCLUDED_TAG__` is not used anywhere outside of splicing
@@ -625,7 +622,7 @@ jobs:
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
#
@@ -677,8 +674,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -692,7 +688,7 @@ jobs:
be-tests-mongo:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.mongo-should-run == 'true' || needs.determine-driver-skips.outputs.mongo-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -758,8 +754,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -773,7 +768,7 @@ jobs:
be-tests-mongo-ssl:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.mongo-ssl-should-run == 'true' || needs.determine-driver-skips.outputs.mongo-ssl-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -841,8 +836,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -850,7 +844,7 @@ jobs:
be-tests-mongo-sharded-cluster-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.mongo-sharded-cluster-should-run == 'true' || needs.determine-driver-skips.outputs.mongo-sharded-cluster-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -887,8 +881,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -896,7 +889,7 @@ jobs:
be-tests-oracle:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.oracle-should-run == 'true' || needs.determine-driver-skips.outputs.oracle-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -973,8 +966,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -982,7 +974,7 @@ jobs:
be-tests-postgres:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.postgres-should-run == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -1078,8 +1070,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -1093,7 +1084,7 @@ jobs:
be-tests-presto-jdbc-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.presto-jdbc-should-run == 'true' || needs.determine-driver-skips.outputs.presto-jdbc-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -1166,8 +1157,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -1175,7 +1165,7 @@ jobs:
be-tests-redshift-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.redshift-should-run == 'true' || needs.determine-driver-skips.outputs.redshift-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -1251,8 +1241,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -1266,7 +1255,7 @@ jobs:
be-tests-snowflake-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.snowflake-should-run == 'true' || needs.determine-driver-skips.outputs.snowflake-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 60
strategy:
fail-fast: false
@@ -1332,8 +1321,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -1347,7 +1335,7 @@ jobs:
be-tests-sparksql-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.sparksql-should-run == 'true' || needs.determine-driver-skips.outputs.sparksql-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -1385,8 +1373,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -1394,7 +1381,7 @@ jobs:
be-tests-sqlite-ee:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.sqlite-should-run == 'true' || needs.determine-driver-skips.outputs.sqlite-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -1427,8 +1414,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -1436,7 +1422,7 @@ jobs:
be-tests-sqlserver:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.sqlserver-should-run == 'true' || needs.determine-driver-skips.outputs.sqlserver-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
strategy:
fail-fast: false
@@ -1504,8 +1490,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -1520,7 +1505,7 @@ jobs:
# be-tests-starburst-ee:
# needs: determine-driver-skips
# if: ${{ !inputs.skip && !(needs.determine-driver-skips.outputs.skip == 'true') }}
# runs-on: ubuntu-latest
# runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
# timeout-minutes: 40
# env:
# CI: 'true'
@@ -1550,22 +1535,21 @@ jobs:
# input-path: ./target/junit/
# output-name: ${{ github.job }}
# bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
# aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
# aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
# role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
# aws-region: ${{ vars.AWS_REGION }}
# trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
login-to-ecr:
needs: determine-driver-skips
if: ${{ needs.determine-driver-skips.outputs.vertica-should-run == 'true' || needs.determine-driver-skips.outputs.vertica-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
permissions:
id-token: write
contents: read
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
role-to-assume: ${{ secrets.CI_IAM_ROLE }}
role-session-name: GitHub_to_AWS_via_FederatedOIDC
@@ -1588,7 +1572,7 @@ jobs:
be-tests-vertica-ee:
needs: [determine-driver-skips, login-to-ecr]
if: ${{ needs.determine-driver-skips.outputs.vertica-should-run == 'true' || needs.determine-driver-skips.outputs.vertica-quarantine-conflict == 'true' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: 'true'
@@ -1631,8 +1615,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -1662,7 +1645,7 @@ jobs:
# TODO(rileythomp, 2025-08-20): Re-enable vertica tests once the docker image is updated
# - be-tests-vertica-ee
- be-tests-clickhouse-ee
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
name: drivers-tests-result
if: always() && !cancelled()

View File

@@ -21,7 +21,7 @@ on:
jobs:
build-matrix:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
outputs:
matrix: ${{ steps.matrix.outputs.config }}
@@ -47,7 +47,7 @@ jobs:
const inputSpecs = "${{ inputs.specs }}";
const inputChunks = Number(process.env.chunks);
const java = 21;
const defaultRunner = "ubuntu-22.04";
const defaultRunner = "${{ vars.DEFAULT_RUNNER_KEY }}";
const options = {
java,
defaultRunner,

View File

@@ -31,11 +31,16 @@ on:
type: boolean
required: false
default: true
fail_fast:
description: "Stop running remaining tests after the first failure"
type: boolean
required: false
default: false
jobs:
determine-test-type:
name: Determine test type
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
outputs:
type: ${{ steps.detect.outputs.type }}
@@ -53,7 +58,7 @@ jobs:
workflow-summary:
name: Stress test inputs
needs: [determine-test-type]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Generate workflow summary
@@ -67,12 +72,13 @@ jobs:
echo '- `grep`: "${{ inputs.grep }}"' >> $GITHUB_STEP_SUMMARY
echo '- `qa_db`: "${{ inputs.qa_db }}"' >> $GITHUB_STEP_SUMMARY
echo '- `enable_network_throttling`: "${{ inputs.enable_network_throttling }}"' >> $GITHUB_STEP_SUMMARY
echo '- `fail_fast`: "${{ inputs.fail_fast }}"' >> $GITHUB_STEP_SUMMARY
echo '' >> $GITHUB_STEP_SUMMARY
echo 'triggered by: @${{ github.event.sender.login }}' >> $GITHUB_STEP_SUMMARY
stress-test-flake-fix:
needs: [determine-test-type]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 60
name: Stress test E2E flake fix
env:
@@ -144,10 +150,13 @@ jobs:
env:
GREP: ${{ github.event.inputs.grep }}
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
FAIL_FAST: ${{ inputs.fail_fast }}
SPEC: ${{ github.event.inputs.spec }}
BURN_IN: ${{ github.event.inputs.burn_in }}
run: |
node e2e/runner/run_cypress_ci.js ${{ needs.determine-test-type.outputs.type }} \
--spec '${{ github.event.inputs.spec }}' \
--env burn=${{ github.event.inputs.burn_in }} \
--spec "${SPEC}" \
--env burn="${BURN_IN}" \
--config-file e2e/support/cypress-stress-test.config.js
- name: Upload Cypress Artifacts upon failure

View File

@@ -21,7 +21,7 @@ on:
runner:
required: false
type: string
default: ubuntu-22.04
default: ${{ vars.DEFAULT_RUNNER_KEY }}
total_chunks: # number of chunks
required: false
type: number
@@ -166,8 +166,7 @@ jobs:
# Related to our custom upload to S3
output-name: e2e-${{ inputs.name }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
# Related to Trunk uploader
variant: e2e-tests

View File

@@ -24,7 +24,7 @@ jobs:
reset-e2e-test-comment:
if: ${{ github.event_name == 'pull_request' }}
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Remove test results comment
@@ -75,7 +75,7 @@ jobs:
collect-timings:
name: Collect E2E Timings
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
needs: e2e-tests
if: always() && !cancelled() && github.ref == 'refs/heads/master'
@@ -138,7 +138,7 @@ jobs:
e2e-tests-result:
needs:
- e2e-tests
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
name: e2e-tests-result
if: always() && !cancelled()

View File

@@ -12,7 +12,7 @@ env:
jobs:
sdk-component-tests:
name: "SDK component tests (React ${{ matrix.react-version }})"
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 45
strategy:
matrix:
@@ -94,8 +94,7 @@ jobs:
input-path: ./target/junit
output-name: e2e-embedding-sdk-react-${{ matrix.react-version }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
@@ -128,7 +127,7 @@ jobs:
await core.summary.addRaw(summary).write();
decide-target-ref:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
outputs:
target-ref: ${{ steps.get-target-ref.outputs.value }}
steps:
@@ -151,7 +150,7 @@ jobs:
sdk-component-tests-backward-compatibility:
name: "SDK component tests (Backward compatibility)"
needs: [decide-target-ref]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 45
env:
MB_RUN_MODE: "e2e"
@@ -248,8 +247,7 @@ jobs:
input-path: ./target/junit
output-name: e2e-embedding-sdk
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}

View File

@@ -12,7 +12,7 @@ env:
MB_EDITION: ee
jobs:
get-sample-apps-data:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
# we must support the last two stable releases
@@ -94,7 +94,7 @@ jobs:
environment: ["production", "development"]
if: |
!cancelled() && needs.get-sample-apps-data.result == 'success'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 45
name: e2e-sample-app-${{ matrix.test_suite }}-tests-${{ matrix.environment }}-bundle
env:
@@ -106,6 +106,8 @@ jobs:
SAMPLE_APP_ENVIRONMENT: ${{ matrix.environment }}
permissions:
id-token: write
contents: read
actions: read
steps:
- uses: actions/checkout@v4
@@ -114,7 +116,7 @@ jobs:
# We have to use the latest version that does not have this issue https://github.com/docker/compose/pull/12752
- name: Set up Docker Compose
uses: docker/setup-compose-action@v1
uses: docker/setup-compose-action@2fe291b7677a45ee1269ec56a42604c143505e7e # v1
with:
version: latest
@@ -201,7 +203,7 @@ jobs:
if: |
!cancelled() && needs.get-sample-apps-data.result == 'success' &&
(github.ref == 'refs/heads/master' || github.base_ref == 'master')
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 45
name: e2e-sample-app-shoppy-e2e-tests-${{ matrix.environment }}-bundle
env:
@@ -213,6 +215,8 @@ jobs:
SAMPLE_APP_ENVIRONMENT: ${{ matrix.environment }}
permissions:
id-token: write
contents: read
actions: read
steps:
- uses: actions/checkout@v4
@@ -264,7 +268,7 @@ jobs:
!cancelled() && needs.get-sample-apps-data.result == 'success' &&
github.event_name == 'push' &&
github.ref == 'refs/heads/master'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 45
name: e2e-shoppy-synthetic-monitoring-tests
env:
@@ -277,6 +281,7 @@ jobs:
permissions:
id-token: write
contents: read
actions: read
steps:
- uses: actions/checkout@v4
@@ -354,7 +359,7 @@ jobs:
"angular-20-host-app-e2e",
]
environment: ["production", "development"]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 45
name: e2e-host-app-${{ matrix.test_suite }}-tests-${{ matrix.environment }}-bundle
env:
@@ -362,6 +367,8 @@ jobs:
HOST_APP_ENVIRONMENT: ${{ matrix.environment }}
permissions:
id-token: write
contents: read
actions: read
steps:
- uses: actions/checkout@v4

View File

@@ -10,14 +10,14 @@ on:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
frontend_embedding_sdk_package_sources: ${{ steps.changes.outputs.frontend_embedding_sdk_package_sources }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -29,11 +29,11 @@ jobs:
!cancelled() &&
(needs.files-changed.outputs.frontend_embedding_sdk_package_sources == 'true')
name: Embedding SDK package release-notes/no-release-notes label reminder
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
- uses: jesusvasquez333/verify-pr-label-action@v1.4.0
- uses: jesusvasquez333/verify-pr-label-action@657d111bbbe13e22bbd55870f1813c699bde1401 # v1.4.0
id: verify-release-notes-labels
with:
github-token: '${{ secrets.GITHUB_TOKEN }}'

View File

@@ -10,7 +10,7 @@ concurrency:
jobs:
build-sdk-package:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 25
steps:
- uses: actions/checkout@v4

View File

@@ -39,7 +39,7 @@ concurrency:
jobs:
embedding-sdk-cli-snippets-type-check:
if: inputs.cli-snippets-type-check && !inputs.skip
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
@@ -55,7 +55,7 @@ jobs:
embedding-sdk-docs-snippets-type-check:
if: inputs.docs-snippets-type-check && !inputs.skip
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
@@ -71,7 +71,7 @@ jobs:
embedding-sdk-api-documentation-generation-validation:
if: inputs.documentation-validation && !inputs.skip
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
@@ -131,7 +131,7 @@ jobs:
embedding-sdk-bundle-size-check:
if: inputs.bundle-size-check
continue-on-error: true
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
env:
BUNDLE_SIZE_THRESHOLD_PERCENT: 2
@@ -186,7 +186,7 @@ jobs:
- embedding-sdk-api-documentation-generation-validation
- embedding-sdk-component-tests
if: always() && !cancelled()
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
env:
needs: ${{ toJson(needs) }}

View File

@@ -7,7 +7,7 @@ on:
jobs:
on-escalation-label:
if: github.event.label.name == '.Escalation'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- name: Format issue title (escape quotes)
@@ -18,7 +18,7 @@ jobs:
core.setOutput('issue_title', ${{ toJson(github.event.issue.title) }}.replaceAll(/"/g, '\\"'));
- name: Send escalated issue ${{ github.event.issue.number }} to Slack
id: slack
uses: slackapi/slack-github-action@v1.23.0
uses: slackapi/slack-github-action@007b2c3c751a190b6f0f040e47ed024deaa72844 # v1.23.0
with:
payload: |
{

View File

@@ -19,7 +19,7 @@ on:
jobs:
workflow-summary:
name: Stress test inputs
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Generate workflow summary
@@ -34,7 +34,7 @@ jobs:
echo 'triggered by: @${{ github.event.sender.login }}' >> $GITHUB_STEP_SUMMARY
frontend-unit-test-stress-test-flake-fix:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 60
name: Stress test frontend unit test flake fix
steps:
@@ -47,11 +47,16 @@ jobs:
run: bun run build:cljs
- name: Stress-test ${{ github.event.inputs.spec }} ${{ github.event.inputs.burn_in }} times
run: |
for i in {1..${{ github.event.inputs.burn_in }}}; do
for ((i=1; i<=BURN_IN; i++)); do
bun run jest --runInBand --ci --silent --no-cache \
--testPathPatterns '${{ github.event.inputs.spec }}' \
--testNamePattern '${{ github.event.inputs.grep }}'
--testPathPatterns "${SPEC}" \
--testNamePattern "${GREP}"
if [[ "$?" != 0 ]]; then
echo "Failed after $i attempts" && break;
fi
done
env:
BURN_IN: ${{ github.event.inputs.burn_in }}
SPEC: ${{ github.event.inputs.spec }}
GREP: ${{ github.event.inputs.grep }}

View File

@@ -27,7 +27,7 @@ concurrency:
jobs:
fe-lint:
if: ${{ !inputs.skip-lint }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
@@ -58,7 +58,7 @@ jobs:
fe-type-check:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
@@ -73,7 +73,7 @@ jobs:
fe-tests-unit:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
strategy:
fail-fast: false
@@ -103,15 +103,14 @@ jobs:
input-path: ./target/junit
output-name: frontend-unit
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.fe-tests.outcome }}
fe-tests-timezones:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
@@ -129,7 +128,7 @@ jobs:
- fe-tests-unit
- fe-tests-timezones
if: always() && !cancelled()
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
env:
needs: ${{ toJson(needs) }}

View File

@@ -24,7 +24,7 @@ on:
# TODO: Consider renaming the job in next milestones
jobs:
generative-query-test:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 90
name: Generative Query Test
env:
@@ -47,7 +47,7 @@ jobs:
run: clojure -X:dev:ci:test:ee:ee-dev :only '${{ inputs.test }}'
- name: Publish Test Report (JUnit)
uses: dorny/test-reporter@v1
uses: dorny/test-reporter@3eeb9fc888e82e8be2fb356bbeec2750231672bc # v1
if: failure()
with:
path: "target/junit/**/*_test.xml"

View File

@@ -14,14 +14,14 @@ concurrency:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
i18n: ${{ steps.changes.outputs.i18n }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -30,7 +30,7 @@ jobs:
verify-i18n-files:
needs: files-changed
if: needs.files-changed.outputs.i18n == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
steps:
- uses: actions/checkout@v4

View File

@@ -7,7 +7,8 @@ on:
jobs:
js-stats:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: actions/checkout@v4

View File

@@ -6,7 +6,7 @@ on:
jobs:
add-issue-references:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- name: Checkout code
uses: actions/checkout@v4

View File

@@ -21,7 +21,7 @@ on:
jobs:
detect-changed-stories:
name: Detect changed stories
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
outputs:
story_files: ${{ steps.detect.outputs.story_files }}
@@ -84,32 +84,40 @@ jobs:
name: Summary
needs: detect-changed-stories
if: needs.detect-changed-stories.outputs.should_run == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Generate workflow summary
env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
STORY_FILES: ${{ needs.detect-changed-stories.outputs.story_files }}
BURN_IN: ${{ inputs.burn_in || 50 }}
EVENT_NAME: ${{ github.event_name }}
PR_NUMBER: ${{ github.event.pull_request.number }}
PR_ACTOR: ${{ github.event.pull_request.user.login }}
ACTOR: ${{ github.actor }}
run: |
echo '## Loki Stress Test' >> $GITHUB_STEP_SUMMARY
echo '' >> $GITHUB_STEP_SUMMARY
echo '**Branch:** `${{ github.head_ref || github.ref_name }}`' >> $GITHUB_STEP_SUMMARY
echo "**Branch:** \`${BRANCH_NAME}\`" >> $GITHUB_STEP_SUMMARY
echo '' >> $GITHUB_STEP_SUMMARY
echo '**Story files:**' >> $GITHUB_STEP_SUMMARY
echo '${{ needs.detect-changed-stories.outputs.story_files }}' | tr ',' '\n' | while read -r file; do
echo "${STORY_FILES}" | tr ',' '\n' | while read -r file; do
echo "- \`$file\`" >> $GITHUB_STEP_SUMMARY
done
echo '' >> $GITHUB_STEP_SUMMARY
echo '**Burn-in:** ${{ inputs.burn_in || 50 }} runs' >> $GITHUB_STEP_SUMMARY
echo "**Burn-in:** ${BURN_IN} runs" >> $GITHUB_STEP_SUMMARY
echo '' >> $GITHUB_STEP_SUMMARY
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
echo 'Triggered by PR #${{ github.event.pull_request.number }} from @${{ github.event.pull_request.user.login }}' >> $GITHUB_STEP_SUMMARY
if [[ "${EVENT_NAME}" == "pull_request" ]]; then
echo "Triggered by PR #${PR_NUMBER} from @${PR_ACTOR}" >> $GITHUB_STEP_SUMMARY
else
echo 'Triggered manually by @${{ github.actor }}' >> $GITHUB_STEP_SUMMARY
echo "Triggered manually by @${ACTOR}" >> $GITHUB_STEP_SUMMARY
fi
stress-test-loki:
needs: detect-changed-stories
if: needs.detect-changed-stories.outputs.should_run == 'true'
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 60
name: Stress test Loki visual tests
services:

View File

@@ -7,7 +7,7 @@ on:
jobs:
check-label-and-update-snapshot:
if: contains(github.event.pull_request.labels.*.name, 'loki-update')
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
steps:
- name: Checkout Repository
uses: actions/checkout@v4

View File

@@ -7,7 +7,7 @@ on:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
frontend_ci: ${{ steps.changes.outputs.frontend_ci }}
@@ -16,7 +16,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -25,7 +25,7 @@ jobs:
visual-test:
needs: files-changed
if: needs.files-changed.outputs.frontend_ci == 'true' || needs.files-changed.outputs.frontend_sources == 'true' || needs.files-changed.outputs.frontend_loki_ci == 'true'
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
services:
docker:
image: docker:19.03.12

View File

@@ -6,7 +6,7 @@ on:
jobs:
# run mage tests even if the rest of be isnt needed
mage-tests:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: Mage
steps:
- uses: actions/checkout@v4

View File

@@ -6,7 +6,7 @@ on:
- labeled
jobs:
on-issue-labeled:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
if: |
contains(github.event.issue.labels.*.name, 'Type:New Feature')
@@ -19,7 +19,7 @@ jobs:
core.setOutput('issue_title', ${{ toJson(github.event.issue.title) }}.replaceAll(/"/g, '\\"'));
- name: Send the issue ${{ github.event.issue.number }} to Slack
id: slack
uses: slackapi/slack-github-action@v1.26.0
uses: slackapi/slack-github-action@70cd7be8e40a46e8b0eced40b0de447bdb42f68e # v1.26.0
with:
payload: |
{

View File

@@ -11,7 +11,7 @@ on:
- src/metabase/lib/js.cljs
jobs:
mbql-library-changelog-check:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
if: ${{ !contains( github.event.pull_request.labels.*.name, '.metabase-lib/no-change' ) }}
steps:
# - uses: jesusvasquez333/verify-pr-label-action@v1.4.0

View File

@@ -6,11 +6,13 @@ on:
- 'master'
- 'release-**'
pull_request:
types: [opened, synchronize, reopened, labeled, unlabeled]
jobs:
lint-migrations:
runs-on: ubuntu-22.04
if: github.event.action != 'labeled' && github.event.action != 'unlabeled'
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
@@ -18,3 +20,19 @@ jobs:
uses: ./.github/actions/prepare-backend
- name: Verify Liquibase Migrations
run: ./bin/mage lint-migrations
check-migration-versions:
if: github.event_name == 'pull_request'
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
with:
filter: blob:none
fetch-depth: 0
- name: Check migration versions
env:
BASE_REF: ${{ github.base_ref }}
CURRENT_VERSION: ${{ vars.CURRENT_VERSION }}
PR_LABELS: ${{ join(github.event.pull_request.labels.*.name, ',') }}
run: bin/check-migration-versions

View File

@@ -8,10 +8,16 @@ concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
cancel-in-progress: true
permissions:
id-token: write
contents: read
checks: write
actions: read
jobs:
# Only run if the PR has the minimal-tests label
check-label:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 1
outputs:
should-run: ${{ steps.check.outputs.result }}
@@ -29,7 +35,7 @@ jobs:
postgres-app-db-test:
needs: check-label
if: needs.check-label.outputs.should-run == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: "true"
@@ -70,8 +76,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -80,7 +85,7 @@ jobs:
postgres-driver-test:
needs: check-label
if: needs.check-label.outputs.should-run == 'true'
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
env:
CI: "true"
@@ -118,8 +123,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -128,7 +132,7 @@ jobs:
frontend-unit-tests:
needs: check-label
if: needs.check-label.outputs.should-run == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
env:
JEST_JUNIT_OUTPUT_DIR: ./target/junit
@@ -151,8 +155,7 @@ jobs:
input-path: ./target/junit
output-name: frontend-unit
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.run-tests.outcome }}
@@ -163,7 +166,7 @@ jobs:
- postgres-app-db-test
- postgres-driver-test
- frontend-unit-tests
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
name: minimal-tests-result
if: always() && !cancelled()

View File

@@ -7,11 +7,12 @@ on:
jobs:
module-boundaries-stats:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
- uses: oven-sh/setup-bun@v2
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2
- name: Install dependencies
run: bun install --frozen-lockfile
- name: get module boundary stats
@@ -20,6 +21,7 @@ jobs:
NAMED_MODULES=$(node --input-type=module -e "
import { elements } from './frontend/lint/module-boundaries.mjs';
const named = elements.filter(e => !['shared/other', 'app/misc', 'other'].includes(e.type));
console.log(named.length);
")
NAMED_DIRS=$(node --input-type=module -e "
@@ -29,6 +31,7 @@ jobs:
const m = el.pattern.match(/^frontend\/src\/metabase\/(\w[\w-]*)\//)
if (m) dirs.add(m[1]);
}
for (const d of dirs) console.log(d);
")
TOTAL_DIRS=$(ls -d frontend/src/metabase/*/ | xargs -I{} basename {} | wc -l | tr -d ' ')
NAMED_COUNT=$(echo "$NAMED_DIRS" | grep -c . || true)

View File

@@ -10,7 +10,7 @@ concurrency:
jobs:
check-openapi-specs:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
if: contains(github.event.pull_request.labels.*.name, 'openapi-self-healing')
steps:

View File

@@ -14,14 +14,14 @@ concurrency:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
openapi: ${{ steps.changes.outputs.openapi }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -30,7 +30,7 @@ jobs:
validate-openapi:
needs: files-changed
if: needs.files-changed.outputs.openapi == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4

View File

@@ -7,7 +7,7 @@ on:
jobs:
optimize-images:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
if: ${{ contains(github.event.pull_request.labels.*.name,'Type:Documentation') }}
steps:
- name: Checkout repository

View File

@@ -5,7 +5,7 @@ on:
workflow_call:
jobs:
build:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
if: github.event.pull_request.head.repo.full_name == github.repository
name: Build Metabase Docker image
timeout-minutes: 60
@@ -17,13 +17,13 @@ jobs:
- name: Checkout source code
uses: actions/checkout@v4
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
role-to-assume: ${{ secrets.PR_ENV_IAM_ROLE }}
role-session-name: GitHub_to_AWS_via_FederatedOIDC
aws-region: us-east-1
- name: Login to Amazon ECR
uses: aws-actions/amazon-ecr-login@v2
uses: aws-actions/amazon-ecr-login@183a1442edf41672e66566b7fc560e297a290896 # v2
with:
registries: "${{ secrets.PR_ENV_AWS_ACCOUNT_ID }}"
- name: Retrieve uberjar artifact for ee
@@ -38,7 +38,7 @@ jobs:
jar xf target/uberjar/metabase.jar
mv target/uberjar/metabase.jar bin/docker/metabase.jar
- name: Build container
uses: docker/build-push-action@v6
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6
with:
context: bin/docker/
platforms: linux/amd64
@@ -47,7 +47,7 @@ jobs:
push: true
launch_perf_test:
needs: [ build ]
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: Launch Perf Test
permissions:
id-token: write
@@ -56,7 +56,7 @@ jobs:
- name: Checkout source code
uses: actions/checkout@v4
- name: Tailscale
uses: tailscale/github-action@v2
uses: tailscale/github-action@4e4c49acaa9818630ce0bd7a564372c17e33fb4d # v2
with:
oauth-client-id: ${{ secrets.PR_ENV_TAILSCALE_OAUTH_CLIENT_ID }}
oauth-secret: ${{ secrets.PR_ENV_TAILSCALE_OAUTH_SECRET }}
@@ -67,12 +67,14 @@ jobs:
id: create-oidc-token
shell: bash
run: |
export OIDC_URL_WITH_AUDIENCE="$ACTIONS_ID_TOKEN_REQUEST_URL&audience=${{ secrets.PR_ENV_K8S_AUDIENCE }}"
export OIDC_URL_WITH_AUDIENCE="$ACTIONS_ID_TOKEN_REQUEST_URL&audience=${PR_ENV_K8S_AUDIENCE}"
IDTOKEN=$(curl -H "Authorization: Bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" -H "Accept: application/json; api-version=2.0" "$OIDC_URL_WITH_AUDIENCE" | jq -r .value)
echo "::add-mask::${IDTOKEN}"
echo "idToken=${IDTOKEN}" >>$GITHUB_OUTPUT
env:
PR_ENV_K8S_AUDIENCE: ${{ secrets.PR_ENV_K8S_AUDIENCE }}
- name: Setup Kube Context
uses: azure/k8s-set-context@v2
uses: azure/k8s-set-context@0b53301dcc7ddd3f6d35f97fb67228ac4e5ab2fd # v2
with:
method: kubeconfig
kubeconfig: |
@@ -95,7 +97,7 @@ jobs:
namespace: default
user: oidc-token
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
role-to-assume: ${{ secrets.PR_ENV_IAM_ROLE }}
role-session-name: GitHub_to_AWS_via_FederatedOIDC
@@ -108,7 +110,7 @@ jobs:
id: split
run: echo "::set-output name=fragment::${SHA:5}"
- name: Render Deployment YAML
uses: nowactions/envsubst@v1
uses: nowactions/envsubst@c4b8e3977354d294659a7ec164279ce8fba5c2e1 # v1
with:
input: ./perf-test-pr.yml.tmpl
output: ./perf-test-pr.yml

View File

@@ -14,7 +14,7 @@ on:
jobs:
approve:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
environment: pr-env-admin
steps:
- name: Approved

View File

@@ -19,7 +19,7 @@ env:
jobs:
destroy_pr:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: PR Review ENV Destroy
permissions:
id-token: write
@@ -28,7 +28,7 @@ jobs:
- name: Checkout source code
uses: actions/checkout@v4
- name: Tailscale
uses: tailscale/github-action@v2
uses: tailscale/github-action@4e4c49acaa9818630ce0bd7a564372c17e33fb4d # v2
with:
oauth-client-id: ${{ secrets.PR_ENV_TAILSCALE_OAUTH_CLIENT_ID }}
oauth-secret: ${{ secrets.PR_ENV_TAILSCALE_OAUTH_SECRET }}
@@ -39,12 +39,14 @@ jobs:
id: create-oidc-token
shell: bash
run: |
export OIDC_URL_WITH_AUDIENCE="$ACTIONS_ID_TOKEN_REQUEST_URL&audience=${{ secrets.PR_ENV_K8S_AUDIENCE }}"
export OIDC_URL_WITH_AUDIENCE="$ACTIONS_ID_TOKEN_REQUEST_URL&audience=${PR_ENV_K8S_AUDIENCE}"
IDTOKEN=$(curl -H "Authorization: Bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" -H "Accept: application/json; api-version=2.0" "$OIDC_URL_WITH_AUDIENCE" | jq -r .value)
echo "::add-mask::${IDTOKEN}"
echo "idToken=${IDTOKEN}" >>$GITHUB_OUTPUT
env:
PR_ENV_K8S_AUDIENCE: ${{ secrets.PR_ENV_K8S_AUDIENCE }}
- name: Setup Kube Context
uses: azure/k8s-set-context@v2
uses: azure/k8s-set-context@0b53301dcc7ddd3f6d35f97fb67228ac4e5ab2fd # v2
with:
method: kubeconfig
kubeconfig: |
@@ -73,7 +75,7 @@ jobs:
kubectl delete ns hosting-pr${{ env.PR_NUMBER }}
- name: Setup Helm
if: ${{ inputs.self_hosting }}
uses: azure/setup-helm@v4
uses: azure/setup-helm@1a275c3b69536ee54be43f2070a358922e12c8d4 # v4
with:
version: 'latest'
- name: Destroy PR Review ENV (self-hosting)
@@ -87,9 +89,15 @@ jobs:
sudo apt-get install -y postgresql-client
- name: Drop app database if exists
run: |
PGPASSWORD='${{ secrets.PR_ENV_DB_PASSWORD }}' \
PGPASSWORD="${PR_ENV_DB_PASSWORD}" \
psql \
-h ${{ secrets.PR_ENV_DB_HOST }} \
-U ${{ secrets.PR_ENV_DB_USER }} \
-d ${{ secrets.PR_ENV_DB_NAME }} \
-h "${PR_ENV_DB_HOST}" \
-U "${PR_ENV_DB_USER}" \
-d "${PR_ENV_DB_NAME}" \
-c "DROP DATABASE IF EXISTS hosting_pr${{ env.PR_NUMBER }};"
env:
PR_ENV_DB_PASSWORD: ${{ secrets.PR_ENV_DB_PASSWORD }}
PR_ENV_DB_HOST: ${{ secrets.PR_ENV_DB_HOST }}
PR_ENV_DB_USER: ${{ secrets.PR_ENV_DB_USER }}
PR_ENV_DB_NAME: ${{ secrets.PR_ENV_DB_NAME }}

View File

@@ -16,7 +16,7 @@ on:
default: false
jobs:
build:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
if: github.event.pull_request.head.repo.full_name == github.repository
name: Build Metabase Docker image
timeout-minutes: 60
@@ -28,13 +28,13 @@ jobs:
- name: Checkout source code
uses: actions/checkout@v4
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
role-to-assume: ${{ secrets.PR_ENV_IAM_ROLE }}
role-session-name: GitHub_to_AWS_via_FederatedOIDC
aws-region: us-east-1
- name: Login to Amazon ECR
uses: aws-actions/amazon-ecr-login@v2
uses: aws-actions/amazon-ecr-login@183a1442edf41672e66566b7fc560e297a290896 # v2
with:
registries: "${{ secrets.PR_ENV_AWS_ACCOUNT_ID }}"
- name: Retrieve uberjar artifact for ee
@@ -49,7 +49,7 @@ jobs:
jar xf target/uberjar/metabase.jar
mv target/uberjar/metabase.jar bin/docker/metabase.jar
- name: Build container
uses: docker/build-push-action@v6
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6
with:
context: bin/docker/
platforms: linux/amd64
@@ -58,7 +58,7 @@ jobs:
push: true
deploy_pr:
needs: [build]
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: PR Review ENV
permissions:
id-token: write
@@ -67,7 +67,7 @@ jobs:
- name: Checkout source code
uses: actions/checkout@v4
- name: Tailscale
uses: tailscale/github-action@v2
uses: tailscale/github-action@4e4c49acaa9818630ce0bd7a564372c17e33fb4d # v2
with:
oauth-client-id: ${{ secrets.PR_ENV_TAILSCALE_OAUTH_CLIENT_ID }}
oauth-secret: ${{ secrets.PR_ENV_TAILSCALE_OAUTH_SECRET }}
@@ -78,12 +78,14 @@ jobs:
id: create-oidc-token
shell: bash
run: |
export OIDC_URL_WITH_AUDIENCE="$ACTIONS_ID_TOKEN_REQUEST_URL&audience=${{ secrets.PR_ENV_K8S_AUDIENCE }}"
export OIDC_URL_WITH_AUDIENCE="$ACTIONS_ID_TOKEN_REQUEST_URL&audience=${PR_ENV_K8S_AUDIENCE}"
IDTOKEN=$(curl -H "Authorization: Bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" -H "Accept: application/json; api-version=2.0" "$OIDC_URL_WITH_AUDIENCE" | jq -r .value)
echo "::add-mask::${IDTOKEN}"
echo "idToken=${IDTOKEN}" >>$GITHUB_OUTPUT
env:
PR_ENV_K8S_AUDIENCE: ${{ secrets.PR_ENV_K8S_AUDIENCE }}
- name: Setup Kube Context
uses: azure/k8s-set-context@v2
uses: azure/k8s-set-context@0b53301dcc7ddd3f6d35f97fb67228ac4e5ab2fd # v2
with:
method: kubeconfig
kubeconfig: |
@@ -106,7 +108,7 @@ jobs:
namespace: default
user: oidc-token
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
role-to-assume: ${{ secrets.PR_ENV_IAM_ROLE }}
role-session-name: GitHub_to_AWS_via_FederatedOIDC
@@ -117,19 +119,24 @@ jobs:
sudo apt-get install -y postgresql-client
- name: Create app database if not exists
run: |
export PGPASSWORD='${{ secrets.PR_ENV_DB_PASSWORD }}'
export PGUSER=${{ secrets.PR_ENV_DB_USER }}
export PGHOST=${{ secrets.PR_ENV_DB_HOST }}
export PGDATABASE=${{ secrets.PR_ENV_DB_NAME }}
export PGPASSWORD="${PR_ENV_DB_PASSWORD}"
export PGUSER="${PR_ENV_DB_USER}"
export PGHOST="${PR_ENV_DB_HOST}"
export PGDATABASE="${PR_ENV_DB_NAME}"
psql -tc "SELECT 1 FROM pg_database WHERE datname = 'hosting_pr${{ github.event.number }}'" \
| grep -q 1 \
|| psql -c "CREATE DATABASE hosting_pr${{ github.event.number }}"
env:
PR_ENV_DB_PASSWORD: ${{ secrets.PR_ENV_DB_PASSWORD }}
PR_ENV_DB_USER: ${{ secrets.PR_ENV_DB_USER }}
PR_ENV_DB_HOST: ${{ secrets.PR_ENV_DB_HOST }}
PR_ENV_DB_NAME: ${{ secrets.PR_ENV_DB_NAME }}
- name: Download Deployment YAML template
if: ${{ !inputs.self_hosting }}
run: aws s3 cp s3://metabase-pr-env/metabase.yml.tmpl ./metabase.yml.tmpl
- name: Render Deployment YAML
if: ${{ !inputs.self_hosting }}
uses: nowactions/envsubst@v1
uses: nowactions/envsubst@c4b8e3977354d294659a7ec164279ce8fba5c2e1 # v1
with:
input: ./metabase.yml.tmpl
output: ./metabase.yml
@@ -148,7 +155,7 @@ jobs:
run: aws s3 cp s3://metabase-pr-env/values.yaml.tmpl ./values.yaml.tmpl
- name: Render Helm values (self-hosting)
if: ${{ inputs.self_hosting }}
uses: nowactions/envsubst@v1
uses: nowactions/envsubst@c4b8e3977354d294659a7ec164279ce8fba5c2e1 # v1
with:
input: ./values.yaml.tmpl
output: ./values.yaml
@@ -168,15 +175,18 @@ jobs:
- name: Setup Helm
if: ${{ inputs.self_hosting }}
uses: azure/setup-helm@v4
uses: azure/setup-helm@1a275c3b69536ee54be43f2070a358922e12c8d4 # v4
with:
version: 'latest'
- name: Login to Quay.io
if: ${{ inputs.self_hosting }}
run: |
helm registry login quay.io \
--username ${{ secrets.QUAY_USERNAME }} \
--password ${{ secrets.QUAY_PASSWORD }}
--username "${QUAY_USERNAME}" \
--password "${QUAY_PASSWORD}"
env:
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }}
- name: Deploy PR Review ENV (self-hosting)
if: ${{ inputs.self_hosting }}
run: |
@@ -188,10 +198,10 @@ jobs:
--atomic \
--timeout 10m
preview_links:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: [deploy_pr]
steps:
- uses: marocchino/sticky-pull-request-comment@v2
- uses: marocchino/sticky-pull-request-comment@773744901bac0e8cbb5a0dc842800d45e9b2b405 # v2
with:
recreate: true
message: |

View File

@@ -25,7 +25,7 @@ on:
jobs:
test-mode-config:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
outputs:
run_mode: ${{ fromJson(steps.config.outputs.result).runMode }}
@@ -65,7 +65,7 @@ jobs:
});
release-artifact:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
strategy:
matrix:
@@ -110,7 +110,7 @@ jobs:
check-uberjar-health:
needs: [release-artifact]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
name: Is ${{ matrix.edition }} (java ${{ matrix.java-version }}) healthy?
timeout-minutes: 10
strategy:
@@ -136,7 +136,7 @@ jobs:
run: while ! curl -s 'http://localhost:3000/api/health' | grep '{"status":"ok"}'; do sleep 1; done
run-sanity-check:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
needs: [test-mode-config, release-artifact]
strategy:
@@ -258,14 +258,8 @@ jobs:
tests-complete-message:
if: always()
runs-on: ubuntu-22.04
needs:
[
run-sanity-check,
check-uberjar-health,
containerize-ee,
containerize-oss,
]
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: [run-sanity-check, check-uberjar-health, containerize-ee, containerize-oss]
timeout-minutes: 5
steps:
- uses: actions/checkout@v4

View File

@@ -18,14 +18,14 @@ on:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
backend_presto_kerberos: ${{ steps.changes.outputs.backend_presto_kerberos }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -34,7 +34,7 @@ jobs:
run-presto-kerberos-test:
needs: files-changed
if: needs.files-changed.outputs.backend_presto_kerberos == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
steps:
- name: Install babashka

View File

@@ -10,7 +10,7 @@ jobs:
external-reminder:
name: External PR Helper
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
permissions:
pull-requests: write

View File

@@ -7,38 +7,41 @@ on:
jobs:
notify-querying-on-call:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
if: |
(github.event.label.name == 'Priority:P0' || github.event.label.name == 'Priority:P1' || github.event.label.name == '.Escalation') &&
contains(github.event.issue.labels.*.name, '.Team/Querying')
steps:
- name: Setting title
uses: actions/github-script@v7
id: vars
with:
script: |
core.setOutput('issue_title', ${{ toJson(github.event.issue.title) }}.replaceAll(/"/g, '\\"'));
- name: Trigger PagerDuty Incident
env:
ROUTING_KEY: ${{ secrets.QUERYING_PAGERDUTY_INTEGRATION_KEY }}
ISSUE_TITLE: ${{ github.event.issue.title }}
LABEL_NAME: ${{ github.event.label.name }}
ISSUE_NUMBER: ${{ github.event.issue.number }}
ISSUE_URL: ${{ github.event.issue.html_url }}
REPO: ${{ github.repository }}
ALL_LABELS: ${{ join(github.event.issue.labels.*.name, ', ') }}
run: |
payload=$(jq -n \
--arg rk "$ROUTING_KEY" \
--arg dk "github-issue-$ISSUE_NUMBER" \
--arg sum "[$LABEL_NAME] $ISSUE_TITLE" \
--arg src "GitHub Issues - $REPO" \
--arg lbl "$ALL_LABELS" \
--arg url "$ISSUE_URL" \
'{
routing_key: $rk,
event_action: "trigger",
dedup_key: $dk,
payload: {
summary: $sum,
source: $src,
severity: "critical",
custom_details: { Labels: $lbl }
},
links: [{ href: $url, text: "View GitHub Issue" }]
}')
curl -X POST https://events.pagerduty.com/v2/enqueue \
-H 'Content-Type: application/json' \
-d '{
"routing_key": "${{ secrets.QUERYING_PAGERDUTY_INTEGRATION_KEY }}",
"event_action": "trigger",
"dedup_key": "github-issue-${{ github.event.issue.number }}",
"payload": {
"summary": "[${{ github.event.label.name }}] ${{ steps.vars.outputs.issue_title }}",
"source": "GitHub Issues - ${{ github.repository }}",
"severity": "critical",
"custom_details": {
"Labels": "${{ join(github.event.issue.labels.*.name, ', ') }}"
}
},
"links": [
{
"href": "${{ github.event.issue.html_url }}",
"text": "View GitHub Issue"
}
]
}'
-d "$payload"

View File

@@ -0,0 +1,68 @@
name: Release Custom Viz Package
run-name: Release @metabase/custom-viz v${{ inputs.version }} from ${{ inputs.branch }}
on:
workflow_dispatch:
inputs:
branch:
description: "Branch to release from"
type: string
required: true
default: "custom-viz"
version:
description: "Version to publish (e.g. 0.1.0)"
type: string
required: true
npm_tag:
description: "NPM dist-tag"
type: choice
required: true
default: "latest"
options:
- latest
- next
- canary
jobs:
build-and-publish:
runs-on: ubuntu-22.04
timeout-minutes: 20
defaults:
run:
working-directory: frontend/src/custom-viz
steps:
- name: Check out the code
uses: actions/checkout@v4
with:
ref: ${{ inputs.branch }}
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
- name: Setup npm registry auth
uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"
registry-url: "https://registry.npmjs.org"
- name: Set package version
run: npm version ${{ inputs.version }} --no-git-tag-version
- name: Build package
run: bun run build
- name: Publish to NPM
run: npm publish --tag ${{ inputs.npm_tag }}
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_RELEASE_TOKEN }}
- name: Generate workflow summary
run: |
tee -a $GITHUB_STEP_SUMMARY << EOF
## Published @metabase/custom-viz
- **Version**: ${{ inputs.version }}
- **Tag**: ${{ inputs.npm_tag }}
- **Branch**: ${{ inputs.branch }}
- **Triggered by**: @${{ github.event.sender.login }}
EOF

View File

@@ -21,7 +21,7 @@ concurrency:
jobs:
workflow-summary:
name: Log inputs
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Generate workflow summary
@@ -37,7 +37,7 @@ jobs:
send-slack-notification-start:
name: "Send Slack notification: SDK release started"
needs: determine-sdk-version
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
outputs:
slackMessageId: ${{ steps.send-slack-message-start.outputs.result }}
@@ -96,7 +96,7 @@ jobs:
"publish-npm",
"git-tag",
]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
env:
slackMessageId: ${{ needs.send-slack-notification-start.outputs.slackMessageId }}
@@ -134,7 +134,7 @@ jobs:
name: "Send Slack notification: SDK release successful"
needs:
["determine-sdk-version", "send-slack-notification-start", "publish-npm"]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
env:
slackMessageId: ${{ needs.send-slack-notification-start.outputs.slackMessageId }}
@@ -168,7 +168,7 @@ jobs:
});
determine-sdk-version:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
outputs:
sdk_version: ${{ fromJson(steps.new-sdk-version.outputs.result).version }}
@@ -219,7 +219,7 @@ jobs:
check-git-tag:
needs: determine-sdk-version
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
env:
tag: embedding-sdk-${{ needs.determine-sdk-version.outputs.sdk_version }}
@@ -243,7 +243,7 @@ jobs:
test:
needs: check-git-tag
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
steps:
- name: Check out the code using the provided branch
@@ -262,7 +262,7 @@ jobs:
build-sdk:
needs: [test, determine-sdk-version]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
steps:
- name: Check out the code using the provided branch
@@ -297,7 +297,7 @@ jobs:
publish-npm:
needs: [build-sdk, determine-sdk-version]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
env:
sdk_version: ${{ needs.determine-sdk-version.outputs.sdk_version }}
@@ -383,12 +383,14 @@ jobs:
- name: Publish to NPM
working-directory: sdk
run: |
echo //registry.npmjs.org/:_authToken=${{ secrets.NPM_RELEASE_TOKEN }} > .npmrc
echo //registry.npmjs.org/:_authToken="${NPM_RELEASE_TOKEN}" > .npmrc
TAG="${{ steps.compute-tag.outputs.masterTag }}"
echo "Resolved npm tag: $TAG"
npm publish --tag "$TAG"
env:
NPM_RELEASE_TOKEN: ${{ secrets.NPM_RELEASE_TOKEN }}
# ⚠️ This step should only be executed on the latest stable (gold) release branch.
# Only uncomment this when the new release branch becomes stable (gold).
# - name: Add `latest` tag to the latest release branch (`release-x.55.x`) deployment
@@ -398,7 +400,7 @@ jobs:
git-tag:
needs: [publish-npm, determine-sdk-version]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 20
env:
tag: embedding-sdk-${{ needs.determine-sdk-version.outputs.sdk_version }}

View File

@@ -21,18 +21,21 @@ on:
type: number # needs to be a number to pass variables
required: true
permissions:
id-token: write
contents: read
jobs:
update-release-log:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
# don't run this workflow for forks
if: ${{ github.event_name != 'push' || github.repository == 'metabase/metabase' }}
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
aws-access-key-id: ${{ secrets.AWS_S3_RELEASE_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_S3_RELEASE_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_RELEASE_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- uses: actions/checkout@v4
with:

View File

@@ -14,15 +14,14 @@ on:
jobs:
check-milestone:
permissions: write-all
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
with:
sparse-checkout: release
- name: Install bun
uses: oven-sh/setup-bun@v2
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2
with:
bun-version: "1.3.7"
token: ${{ secrets.GITHUB_TOKEN }}

View File

@@ -11,7 +11,7 @@ on:
jobs:
preview-release-notes:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- name: Fail early on the incorrect version format

View File

@@ -5,29 +5,29 @@ on:
workflow_dispatch:
inputs:
version:
description: 'Major Metabase version (e.g. 45, 52, 68)'
description: "Major Metabase version (e.g. 45, 52, 68)"
type: number
required: true
override_sha:
description: DANGEROUSLY allow releasing from this commit sha, regardless of the state of CI (can be empty)
type: string
required: false
default: ''
default: ""
schedule:
- cron: '0 21 * * 1-5' # every weekday at 4 pm EST/5 pm EDT
- cron: "0 21 * * 1-5" # every weekday at 4 pm EST/5 pm EDT
jobs:
auto-patch-trigger:
# don't run this workflow on a cron for forks
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ubuntu-22.04
if: ${{ github.event_name != 'schedule' || (github.repository == 'metabase/metabase' && vars.ENABLE_AUTO_PATCH == 'true') }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
with:
sparse-checkout: release
- name: Install bun
uses: oven-sh/setup-bun@v2
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2
with:
bun-version: "1.3.7"
token: ${{ secrets.GITHUB_TOKEN }}

View File

@@ -9,7 +9,7 @@ jobs:
check-release-status:
# don't run this workflow on a cron for forks
if: ${{ github.event_name != 'schedule' || github.repository == 'metabase/metabase' }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
@@ -44,7 +44,7 @@ jobs:
});
open-backport-reminder:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4

View File

@@ -53,9 +53,14 @@ on:
type: boolean
default: false
permissions:
id-token: write
contents: read
actions: read
jobs:
green-check-stub:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 2
steps:
- name: Stub
@@ -63,7 +68,7 @@ jobs:
check-version:
# skips everything if the tag_name is 'none' because all later jobs depend on this job
if: ${{ inputs.tag_name != 'none' }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
outputs:
ee: ${{ fromJson(steps.canonical_version.outputs.result).ee }}
@@ -138,7 +143,7 @@ jobs:
throw new Error("No edition selected to tag");
copy-to-s3:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: check-version
timeout-minutes: 5
strategy:
@@ -146,10 +151,9 @@ jobs:
edition: ${{ fromJson(needs.check-version.outputs.edition_matrix) }}
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
aws-access-key-id: ${{ secrets.AWS_S3_RELEASE_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_S3_RELEASE_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_RELEASE_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- name: Determine the source path
uses: actions/github-script@v7
@@ -221,7 +225,7 @@ jobs:
fi
tag-docker-image:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: check-version
timeout-minutes: 5
strategy:
@@ -243,7 +247,7 @@ jobs:
fi
- name: Login to Docker Hub
uses: docker/login-action@v3
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3
with:
username: ${{ secrets.DOCKERHUB_RELEASE_USERNAME }}
password: ${{ secrets.DOCKERHUB_RELEASE_TOKEN }}
@@ -255,9 +259,10 @@ jobs:
$DOCKERHUB_REPO\:$DOCKERHUB_VERSION
push-git-tags:
permissions: write-all
permissions:
contents: write
needs: check-version
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
env:
GH_TOKEN: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
@@ -288,7 +293,7 @@ jobs:
update-version-info:
if: ${{ !inputs.dot-x-tag }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: check-version
timeout-minutes: 5
strategy:
@@ -299,10 +304,9 @@ jobs:
AWS_REGION: ${{ vars.AWS_REGION }}
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
aws-access-key-id: ${{ secrets.AWS_S3_RELEASE_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_S3_RELEASE_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_RELEASE_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- uses: actions/checkout@v4
with:

View File

@@ -14,14 +14,14 @@ concurrency:
jobs:
files-changed:
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
release_source: ${{ steps.changes.outputs.release_source }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -30,14 +30,14 @@ jobs:
release-type-check:
needs: files-changed
if: needs.files-changed.outputs.release_source == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
with:
sparse-checkout: "release"
- name: Install bun
uses: oven-sh/setup-bun@v2
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2
with:
bun-version: "1.3.7"
token: ${{ secrets.GITHUB_TOKEN }}
@@ -49,14 +49,14 @@ jobs:
release-tests-unit:
needs: files-changed
if: needs.files-changed.outputs.release_source == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
with:
sparse-checkout: "release"
- name: Install bun
uses: oven-sh/setup-bun@v2
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2
with:
bun-version: "1.3.7"
token: ${{ secrets.GITHUB_TOKEN }}
@@ -68,14 +68,14 @@ jobs:
release-test-build:
needs: files-changed
if: needs.files-changed.outputs.release_source == 'true'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
with:
sparse-checkout: "release"
- name: Install bun
uses: oven-sh/setup-bun@v2
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2
with:
bun-version: "1.3.7"
token: ${{ secrets.GITHUB_TOKEN }}

View File

@@ -46,9 +46,16 @@ on:
type: boolean
default: false
permissions:
id-token: write
contents: write
checks: write
issues: write
actions: read
jobs:
check-version:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
outputs:
ee: ${{ fromJson(steps.canonical_version.outputs.result).ee }}
@@ -104,7 +111,7 @@ jobs:
return versions
publish-start-message:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: [check-version]
timeout-minutes: 5
steps:
@@ -135,7 +142,7 @@ jobs:
download-uberjar:
needs: check-version
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
strategy:
matrix:
@@ -178,7 +185,7 @@ jobs:
./version.properties
upload-to-s3:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: download-uberjar
timeout-minutes: 15
strategy:
@@ -186,10 +193,9 @@ jobs:
edition: [oss, ee]
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
aws-access-key-id: ${{ secrets.AWS_S3_RELEASE_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_S3_RELEASE_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_RELEASE_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- uses: actions/checkout@v4
with:
@@ -230,7 +236,7 @@ jobs:
--paths "/${{ steps.version_path.outputs.result }}/*"
verify-s3-download:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: upload-to-s3
timeout-minutes: 15
strategy:
@@ -285,9 +291,8 @@ jobs:
release: "true"
push-tags:
permissions: write-all
needs: [verify-s3-download, containerize-oss, containerize-ee, check-version]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
@@ -320,7 +325,7 @@ jobs:
get-extra-tags:
needs: [ check-version ]
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
outputs:
extra_tags: ${{ steps.taglist.outputs.extra_tags }}
steps:
@@ -371,7 +376,7 @@ jobs:
trigger-cloud-issues:
if: ${{ !inputs.auto }}
needs: push-tags
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
@@ -423,7 +428,7 @@ jobs:
needs:
- containerize-ee
- verify-s3-download
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/github-script@v7
@@ -446,9 +451,8 @@ jobs:
draft-release-notes:
if: ${{ !inputs.auto }}
needs: add-extra-tags
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
permissions: write-all
env:
AWS_S3_DOWNLOADS_BUCKET: ${{ vars.AWS_S3_DOWNLOADS_BUCKET }}
DOCKERHUB_OWNER: ${{ vars.DOCKERHUB_OWNER }}
@@ -514,7 +518,7 @@ jobs:
}).catch(console.warn);
publish-version-info:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: [push-tags, check-version]
timeout-minutes: 15
strategy:
@@ -530,10 +534,9 @@ jobs:
echo "skipping version info update for nightly patch"
exit 0
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
aws-access-key-id: ${{ secrets.AWS_S3_RELEASE_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_S3_RELEASE_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_RELEASE_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- uses: actions/checkout@v4
with:
@@ -590,7 +593,7 @@ jobs:
tag_oss: true
publish-complete-message:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: [set-release-channel, add-extra-tags]
timeout-minutes: 5
steps:
@@ -622,8 +625,7 @@ jobs:
manage-milestones:
if: ${{ !inputs.auto }}
permissions: write-all
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
needs: [draft-release-notes, publish-version-info] # this will ensure that the milestone stays open until the release notes are published
timeout-minutes: 15
steps:

View File

@@ -18,14 +18,13 @@ on:
jobs:
repro-bot:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 60
permissions:
contents: read
issues: read
id-token: write
if: |
(github.event_name == 'push') ||
(github.event_name == 'issues' && github.event.label.name == '.Run Repro Bot' && github.event.issue.state == 'open') ||
(github.event_name == 'workflow_dispatch')
@@ -34,13 +33,15 @@ jobs:
id: issue
run: |
if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
echo "number=${{ github.event.inputs.issue_number }}" >> $GITHUB_OUTPUT
elif [ "${{ github.event_name }}" = "push" ]; then
echo "number=70292" >> $GITHUB_OUTPUT
ISSUE_NUMBER="${DISPATCH_ISSUE_NUMBER}"
else
echo "number=${{ github.event.issue.number }}" >> $GITHUB_OUTPUT
ISSUE_NUMBER="${{ github.event.issue.number }}"
fi
echo "number=$ISSUE_NUMBER" >> $GITHUB_OUTPUT
echo "Issue: https://github.com/${{ github.repository }}/issues/$ISSUE_NUMBER"
env:
DISPATCH_ISSUE_NUMBER: ${{ github.event.inputs.issue_number }}
- uses: actions/checkout@v4
- uses: ./.github/actions/prepare-backend
- uses: ./.github/actions/prepare-frontend
@@ -54,11 +55,14 @@ jobs:
path: repro-bot
- name: Pre-clone metabase bare git repo
run: git clone --bare .git repro-bot/git/metabase
run: git clone --bare "https://github.com/${{ github.repository }}.git" repro-bot/git/metabase
- name: Capture Node.js path for MCP subprocesses
run: echo "NODE_BIN_DIR=$(dirname $(which node))" >> $GITHUB_ENV
- name: Pre-install MCP server dependencies
run: uv sync --directory repro-bot/mcp
- name: Install playwright-cli
run: |
npm install -g @playwright/cli@latest
@@ -99,11 +103,12 @@ jobs:
jq -n \
--arg uv "$UV_PATH" \
--arg key "$LINEAR_API_KEY" \
--arg workspace "${{ github.workspace }}" \
'{
mcpServers: {
"metabase-repro": {
command: $uv,
args: ["run", "--directory", "mcp", "--with", "fastmcp", "python", "-m", "metabase_repro"]
args: ["run", "--directory", ($workspace + "/repro-bot/mcp"), "--with", "fastmcp", "python", "-m", "metabase_repro"]
},
"linear-server": {
url: "https://mcp.linear.app/mcp",
@@ -125,18 +130,23 @@ jobs:
- name: Run repro-bot with Claude Code
id: claude
continue-on-error: true
uses: anthropics/claude-code-action@v1
uses: anthropics/claude-code-action@3ac52d0da9f8ec9ca7b4dc23bb477e36ef9c77a9 # v1
env:
CLAUDE_CODE_DEBUG_LOGS_DIR: /tmp/claude-debug-logs
CLAUDE_WORKING_DIR: ${{ github.workspace }}/repro-bot
MB_PREMIUM_EMBEDDING_TOKEN: ${{ secrets.PR_ENV_MB_PREMIUM_EMBEDDING_TOKEN }}
GITHUB_ACTIONS_RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
REPRO_NODE_MODULES_DIR: ${{ github.workspace }}/node_modules
timeout-minutes: 30
with:
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY_REPRO_BOT }}
github_token: ${{ steps.claude-app-token.outputs.token }}
allowed_bots: linear
prompt: |
Read and follow the instructions in .claude/commands/repro.md to investigate this GitHub issue:
IMPORTANT: Your working directory is the repo root, but repro-bot lives in the `repro-bot/` subdirectory.
First, run `cd ${{ github.workspace }}/repro-bot` to change into the repro-bot directory before doing anything else.
Then read and follow the instructions in .claude/commands/repro.md to investigate this GitHub issue:
https://github.com/${{ github.repository }}/issues/${{ steps.issue.outputs.number }}
## CI Environment Notes
@@ -227,9 +237,7 @@ jobs:
mcp__linear-server__get_issue,
mcp__linear-server__list_comments,
mcp__linear-server__list_issues,
mcp__linear-server__list_issue_labels,
mcp__linear-server__save_comment,
mcp__linear-server__save_issue"
mcp__linear-server__save_comment"
--disallowedTools "Bash(git push*),Bash(rm -rf /*)"
- name: Verify repro-bot completed successfully
@@ -259,8 +267,8 @@ jobs:
name: repro-bot-${{ steps.issue.outputs.number }}
if-no-files-found: ignore
path: |
repro/*/SUGGESTIONS.md
repro/*/*.log
repro/*/*.patch
repro/*/playwright/**
repro-bot/repro/*/SUGGESTIONS.md
repro-bot/repro/*/*.log
repro-bot/repro/*/*.patch
repro-bot/repro/*/playwright/**
${{ steps.claude.outputs.execution_file }}

View File

@@ -9,7 +9,7 @@ on:
jobs:
rerun-on-failure:
name: 'Re-run ''${{ github.event.workflow_run.name }}'' workflow'
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
# Do not re-run scheduled workflow runs
if: github.event.workflow_run.conclusion == 'failure' && github.event.workflow_run.event != 'schedule'
env:

View File

@@ -21,7 +21,7 @@ on:
jobs:
reset-dataset:
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
env:
CI: 'true'

View File

@@ -0,0 +1,321 @@
name: Auto-resolve backport conflicts
run-name: Auto-resolve conflicts on PR #${{ github.event.pull_request.number || github.event.inputs.pr_number }}
on:
pull_request:
types: [labeled]
workflow_dispatch:
inputs:
pr_number:
description: "PR number of the backport PR with conflicts"
required: true
type: string
max_turns:
description: "Maximum number of Claude turns"
required: false
type: number
default: 75
jobs:
resolve-conflicts:
if: |
(github.event_name == 'pull_request' && github.event.label.name == 'auto-resolve-conflicts') ||
(github.event_name == 'workflow_dispatch')
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 30
permissions:
contents: write
pull-requests: write
id-token: write
env:
GIT_EDITOR: "true"
steps:
- name: Get PR data
id: pr
uses: actions/github-script@v7
with:
github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
script: |
let pr;
if (context.eventName === 'workflow_dispatch') {
const { data } = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: Number('${{ github.event.inputs.pr_number }}'),
});
pr = data;
} else {
pr = context.payload.pull_request;
}
core.setOutput('number', pr.number);
core.setOutput('head_ref', pr.head.ref);
core.setOutput('base_ref', pr.base.ref);
- name: Checkout PR branch
uses: actions/checkout@v4
with:
ref: ${{ steps.pr.outputs.head_ref }}
fetch-depth: 0
token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
- name: Detect package manager
id: pkg
run: |
if [ -f "bun.lock" ] || [ -f "bun.lockb" ]; then
echo "mgr=bun" >> $GITHUB_OUTPUT
else
echo "mgr=yarn" >> $GITHUB_OUTPUT
fi
- name: Validate backport PR
id: validate
run: |
if [ ! -f "./backport.sh" ]; then
echo "::error::No backport.sh found on this branch. This workflow only works on backport PRs with conflicts."
exit 1
fi
echo "backport.sh found, proceeding with conflict resolution"
cat ./backport.sh
- name: Set up git configuration
run: |
git config --global user.name "Metabase bot"
git config --global user.email "metabase-bot@metabase.com"
git config --global core.editor "true"
- name: Run backport script to create cherry-pick conflicts
id: backport
run: |
bash ./backport.sh 2>&1 || true
# Check if we're in a cherry-pick state with conflicts
CONFLICTED=$(git diff --name-only --diff-filter=U || true)
if [ -n "$CONFLICTED" ]; then
echo "has_conflicts=true" >> $GITHUB_OUTPUT
echo "conflicted_files<<EOF" >> $GITHUB_OUTPUT
echo "$CONFLICTED" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
echo "::notice::Found conflicts in: $CONFLICTED"
else
echo "has_conflicts=false" >> $GITHUB_OUTPUT
echo "::notice::Cherry-pick applied cleanly, no conflicts to resolve"
fi
- name: Push clean cherry-pick (no conflicts)
if: steps.backport.outputs.has_conflicts == 'false'
run: git push --force
- name: Prepare back-end environment
if: steps.backport.outputs.has_conflicts == 'true'
uses: ./.github/actions/prepare-backend
- name: Prepare front-end environment
if: steps.backport.outputs.has_conflicts == 'true'
uses: ./.github/actions/prepare-frontend
- name: Build CLJS for type checking
if: steps.backport.outputs.has_conflicts == 'true'
run: ${{ steps.pkg.outputs.mgr }} run build-pure:cljs
- name: Generate GitHub App Token for Claude
if: steps.backport.outputs.has_conflicts == 'true'
uses: actions/create-github-app-token@v1
id: claude-app-token
with:
app-id: ${{ secrets.METABASE_BOT_APP_ID }}
private-key: ${{ secrets.METABASE_BOT_APP_PRIVATE_KEY }}
- name: Resolve conflicts with Claude
if: steps.backport.outputs.has_conflicts == 'true'
id: claude
uses: anthropics/claude-code-base-action@beta
env:
NODE_VERSION: "22"
with:
# TODO: get a dedicated API key, sharing repro bot's key for now
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY_BACKPORT_FIX }}
model: "claude-sonnet-4-20250514"
max_turns: "${{ github.event.inputs.max_turns || '75' }}"
allowed_tools: "Read,Edit,Write,Bash(git:*),Bash(grep:*),Bash(find:*),Bash(ls:*),Bash(cat:*),Bash(clojure:*),Bash(${{ steps.pkg.outputs.mgr }} run type-check-pure:*),Bash(${{ steps.pkg.outputs.mgr }} run lint-eslint:*),Bash(./bin/mage cljfmt:*),Glob,Grep"
prompt: |
You are resolving git cherry-pick merge conflicts for a Metabase backport PR.
## Context
A commit from the `master` branch is being cherry-picked onto the `${{ steps.pr.outputs.base_ref }}` release branch.
The cherry-pick has failed with conflicts in these files:
${{ steps.backport.outputs.conflicted_files }}
## How to read conflict markers
```
<<<<<<< HEAD
(code from the release branch - the current state)
=======
(code from master - the change being backported)
>>>>>>> <commit-sha>
```
## Common conflict patterns in Metabase backports
- **Module/namespace renames**: A Clojure namespace was renamed or moved between versions. Check what the correct namespace is on the release branch.
- **Test file divergence**: Tests may have been added or reordered differently. Keep the backported test changes while preserving existing release-branch tests.
- **Import path changes**: Frontend imports may reference different paths. Check actual file locations on this branch.
- **Translation files (.po)**: For translation conflicts, prefer the release branch version of existing translations and add new translations from the backported change.
- **Minor context differences**: Surrounding code changed slightly. Adapt the backported change to fit the release branch context.
## Instructions
1. Read each conflicted file to understand the conflict
2. For context, you may search the codebase to understand the current state of the release branch (e.g., check if a module exists at a certain path)
3. Resolve each conflict by editing the file to remove ALL conflict markers (`<<<<<<<`, `=======`, `>>>>>>>`) and leave only the correct resolved code
4. The goal is to apply the INTENT of the backported change while adapting it to the release branch's code structure
5. Verify no conflict markers remain by searching for them
6. Auto-format resolved files:
- **Clojure/ClojureScript** (.clj, .cljc, .cljs): run cljfmt to fix formatting:
```
./bin/mage cljfmt-files <file1> <file2> ...
```
- **TypeScript/JavaScript** (.ts, .tsx, .js, .jsx): run eslint with auto-fix:
```
${{ steps.pkg.outputs.mgr }} run lint-eslint --fix
```
7. Validate resolved files before committing:
- **Clojure/ClojureScript** (.clj, .cljc, .cljs): run clj-kondo to verify syntax:
```
clojure -M:kondo --lint <file1> <file2> ...
```
- **TypeScript/JavaScript** (.ts, .tsx, .js, .jsx): run the type checker:
```
${{ steps.pkg.outputs.mgr }} run type-check-pure
```
If either tool reports errors or warnings, fix them before proceeding. CI treats kondo warnings as errors.
Repeat steps 6-7 until all errors are resolved.
7. Once all files are clean, stage and complete the cherry-pick:
```
git add -A
git cherry-pick --continue
```
8. Push the result:
```
git push --force
```
IMPORTANT: Do not skip any conflicted files. Every conflict marker must be resolved.
- name: Check for max turns exceeded
if: always() && steps.claude.outcome != 'skipped'
id: check-failure
run: |
if [ -f "${{ steps.claude.outputs.execution_file }}" ]; then
SUBTYPE=$(jq -r '.[] | select(.type == "result") | .subtype' "${{ steps.claude.outputs.execution_file }}" | tail -1)
if [ "$SUBTYPE" = "error_max_turns" ]; then
echo "max_turns_exceeded=true" >> $GITHUB_OUTPUT
else
echo "max_turns_exceeded=false" >> $GITHUB_OUTPUT
fi
else
echo "max_turns_exceeded=false" >> $GITHUB_OUTPUT
fi
- name: Get commit details
if: always() && steps.claude.outcome == 'success' && steps.check-failure.outputs.max_turns_exceeded != 'true'
id: commit-info
run: |
echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
FILES=$(git diff --name-only HEAD~1)
echo "changed_files<<EOF" >> $GITHUB_OUTPUT
echo "$FILES" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
- name: Comment on PR (success)
if: always() && steps.claude.outcome == 'success' && steps.check-failure.outputs.max_turns_exceeded != 'true'
uses: actions/github-script@v7
with:
github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
script: |
const sha = '${{ steps.commit-info.outputs.sha }}';
const changedFiles = `${{ steps.commit-info.outputs.changed_files }}`.trim().split('\n').map(f => `- \`${f}\``).join('\n');
await github.rest.issues.createComment({
issue_number: ${{ steps.pr.outputs.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: [
'🤖 Backport conflicts have been automatically resolved and force-pushed.',
'',
`**Commit:** [\`${sha.substring(0, 10)}\`](https://github.com/${context.repo.owner}/${context.repo.repo}/commit/${sha})`,
'',
'<details>',
'<summary>Changed files</summary>',
'',
changedFiles,
'',
'</details>',
'',
'Please review the changes to make sure the resolution is correct before merging.',
].join('\n')
});
- name: Comment on PR (max turns exceeded)
if: always() && steps.check-failure.outputs.max_turns_exceeded == 'true'
uses: actions/github-script@v7
with:
github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
script: |
await github.rest.issues.createComment({
issue_number: ${{ steps.pr.outputs.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: [
'🤖 Auto-resolution of backport conflicts stopped because Claude reached the maximum number of turns (${{ github.event.inputs.max_turns || '75' }}).',
'',
'The conflicts may be too complex for automatic resolution, or Claude needed more turns to finish.',
'',
'You can try again with more turns by manually running the [resolve-backport-conflicts workflow](https://github.com/' + context.repo.owner + '/' + context.repo.repo + '/actions/workflows/resolve-backport-conflicts.yml) with a higher `max_turns` value, or resolve the conflicts manually by checking out the branch and running `./backport.sh`.',
].join('\n')
});
- name: Comment on PR (failure)
if: always() && steps.claude.outcome == 'failure' && steps.check-failure.outputs.max_turns_exceeded != 'true'
uses: actions/github-script@v7
with:
github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
script: |
await github.rest.issues.createComment({
issue_number: ${{ steps.pr.outputs.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: [
'🤖 Auto-resolution of backport conflicts failed.',
'',
'Manual resolution is still required. Check out the branch and run `./backport.sh` to resolve conflicts manually.',
].join('\n')
});
- name: Comment on PR (clean cherry-pick)
if: always() && steps.backport.outputs.has_conflicts == 'false'
uses: actions/github-script@v7
with:
github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
script: |
await github.rest.issues.createComment({
issue_number: ${{ steps.pr.outputs.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: '🤖 Cherry-pick applied cleanly with no conflicts. Force-pushed the resolved branch.'
});
- name: Remove label
if: always()
uses: actions/github-script@v7
with:
github-token: ${{ secrets.METABASE_AUTOMATION_USER_TOKEN }}
script: |
try {
await github.rest.issues.removeLabel({
issue_number: ${{ steps.pr.outputs.number }},
owner: context.repo.owner,
repo: context.repo.repo,
name: 'auto-resolve-conflicts'
});
} catch (e) {
console.log('Label already removed or not found:', e.message);
}

View File

@@ -10,11 +10,19 @@ on:
merge_group:
workflow_dispatch:
permissions:
id-token: write
contents: read
actions: read
checks: write
pull-requests: write
security-events: write
jobs:
files-changed:
if: ${{ !contains(github.event.pull_request.labels.*.name,'ci skip') && !contains(github.event.pull_request.labels.*.name,'minimal-tests') }}
name: Check which files changed
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
outputs:
e2e_all: ${{ steps.changes.outputs.e2e_all }}
@@ -32,7 +40,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0
id: changes
with:
token: ${{ github.token }}
@@ -110,7 +118,7 @@ jobs:
sdk-tests:
needs: [uberjar, embedding-sdk-package, files-changed]
if: always()
if: always() && !cancelled()
uses: ./.github/workflows/embedding-sdk.yml
secrets: inherit
with:

View File

@@ -7,7 +7,7 @@ on:
jobs:
on-issue-opened:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
if: github.event.label.name == 'SECURITY'
steps:
@@ -19,7 +19,7 @@ jobs:
core.setOutput('issue_title', ${{ toJson(github.event.issue.title) }}.replaceAll(/"/g, '\\"'));
- name: Send the issue ${{ github.event.issue.number }} to Slack
id: slack
uses: slackapi/slack-github-action@v1.26.0
uses: slackapi/slack-github-action@70cd7be8e40a46e8b0eced40b0de447bdb42f68e # v1.26.0
with:
payload: |
{

View File

@@ -14,7 +14,7 @@ concurrency:
jobs:
semantic-search-tests-h2:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -61,15 +61,14 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
semantic-search-tests-mariadb:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -77,11 +76,11 @@ jobs:
version:
- name: MariaDB 10.6 with pgvector pg17
junit-name: semantic-search-tests-mariadb-10-6
mariadb-image: circleci/mariadb:10.6
mariadb-image: metabase/mariadb:10.6 # https://github.com/metabase/metabase-mariadb-docker-image
pgvector-image: pgvector/pgvector:pg17
- name: MariaDB Latest with pgvector pg17
junit-name: semantic-search-tests-mariadb-latest
mariadb-image: circleci/mariadb:latest
mariadb-image: mariadb:latest
pgvector-image: pgvector/pgvector:pg17
job:
- name: Semantic Search Tests
@@ -104,15 +103,15 @@ jobs:
ports:
- "3306:3306"
env:
MYSQL_ALLOW_EMPTY_PASSWORD: true
MYSQL_DATABASE: circle_test
MARIADB_ALLOW_EMPTY_ROOT_PASSWORD: true
MARIADB_DATABASE: mb_test
env:
CI: 'true'
DRIVERS: mysql
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
MB_PGVECTOR_DB_URL: 'jdbc:postgres://localhost:5432/mb_semantic_search?user=postgres&password=postgres'
@@ -135,15 +134,14 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
semantic-search-tests-mysql:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -151,7 +149,7 @@ jobs:
version:
- name: MySQL 8.4 with pgvector pg17
junit-name: semantic-search-tests-mysql-8-4
mysql-image: cimg/mysql:8.4
mysql-image: mysql:8.4
pgvector-image: pgvector/pgvector:pg17
- name: MySQL Latest with pgvector pg17
junit-name: semantic-search-tests-mysql-latest
@@ -179,14 +177,14 @@ jobs:
- "3306:3306"
env:
MYSQL_ALLOW_EMPTY_PASSWORD: true
MYSQL_DATABASE: circle_test
MYSQL_DATABASE: mb_test
env:
CI: 'true'
DRIVERS: mysql
MB_DB_TYPE: mysql
MB_DB_HOST: localhost
MB_DB_PORT: 3306
MB_DB_DBNAME: circle_test
MB_DB_DBNAME: mb_test
MB_DB_USER: root
MB_MYSQL_TEST_USER: root
MB_PGVECTOR_DB_URL: 'jdbc:postgres://localhost:5432/mb_semantic_search?user=postgres&password=postgres'
@@ -209,15 +207,14 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
semantic-search-tests-postgres:
if: ${{ !inputs.skip }}
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 40
strategy:
fail-fast: false
@@ -284,8 +281,7 @@ jobs:
input-path: ./target/junit/
output-name: ${{ github.job }}
bucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}
aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_TEST_RESULTS_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
trunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}
previous-step-outcome: ${{ steps.test-driver.outputs.test-outcome }}
@@ -296,7 +292,7 @@ jobs:
- semantic-search-tests-mariadb
- semantic-search-tests-mysql
- semantic-search-tests-postgres
runs-on: ubuntu-latest
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
name: semantic-search-tests-result
if: always() && !cancelled()

39
.github/workflows/serialization.yml vendored Normal file
View File

@@ -0,0 +1,39 @@
name: Serialization
on:
push:
branches:
- 'master'
pull_request:
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
cancel-in-progress: true
jobs:
files-changed:
name: Check which files changed
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 3
outputs:
serialization_baseline: ${{ steps.changes.outputs.serialization_baseline }}
steps:
- uses: actions/checkout@v4
- name: Test which files changed
uses: dorny/paths-filter@v3.0.0
id: changes
with:
token: ${{ github.token }}
filters: .github/file-paths.yaml
validate-serialization-baseline:
needs: files-changed
if: needs.files-changed.outputs.serialization_baseline == 'true'
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
- name: Prepare front-end environment
uses: ./.github/actions/prepare-frontend
- name: Validate serialization baseline schema
run: bunx @metabase/representations validate-schema --folder test_resources/serialization_baseline

View File

@@ -9,9 +9,13 @@ on:
type: string
required: true
permissions:
id-token: write
contents: read
jobs:
set-announce-url:
runs-on: ubuntu-22.04
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 15
steps:
- name: Validate input
@@ -21,10 +25,9 @@ jobs:
exit 1
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v4
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4
with:
aws-access-key-id: ${{ secrets.AWS_S3_RELEASE_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_S3_RELEASE_SECRET_ACCESS_KEY }}
role-to-assume: ${{ secrets.CI_RELEASE_IAM_ROLE }}
aws-region: ${{ vars.AWS_REGION }}
- name: Update announcement url
uses: actions/github-script@v7

Some files were not shown because too many files have changed in this diff Show More